| 3a8678f545de813af044e87f1b86c25f7bddbc1f |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0 am: 0ef6d9c121 am: 966e572c69 am: 1f7d80772c am: a7e658fcca am: 6d2092f734 am: 6447404db3 am: 8693c57563 am: 25e3a40344 am: 51789f19de am: 7ba7584303 am: 5304cbcee8 am: 798dba38c4 am: fdd5f801f5
am: cdc2e0a0d8
Change-Id: I9bcbd28defbddbc323f86cdb4e3f0d57c6518625
|
| 7ba758430328da0c9f6248d82732f5d42b12c8f4 |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0 am: 0ef6d9c121 am: 966e572c69 am: 1f7d80772c am: a7e658fcca am: 6d2092f734 am: 6447404db3 am: 8693c57563 am: 25e3a40344
am: 51789f19de
Change-Id: Id2b44ecf0ce68d609f2a1270662a910a19f57a66
|
| 6447404db3a7bf78ecc6e86a48c784d09bce090e |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0 am: 0ef6d9c121 am: 966e572c69 am: 1f7d80772c am: a7e658fcca
am: 6d2092f734
Change-Id: Ic8ace5d6ed81df5d8298d9031e635501ecf2b590
|
| a7e658fcca95be46061435722c37ae440858dfb8 |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0 am: 0ef6d9c121 am: 966e572c69
am: 1f7d80772c
Change-Id: I7a978b70b1330b619ac0ed46f3c191912ce0ffd1
|
| 1f7d80772cf76eb6373e91039ceb2800ad7af378 |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0 am: 0ef6d9c121
am: 966e572c69
Change-Id: Ida849f8cad82a997a108ad472b150c7be29baf42
|
| 966e572c69397616d31f378fe10089ca99373824 |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev am: ef3a4aead0
am: 0ef6d9c121
Change-Id: I420ab9888c2b542ca66fbb65fd2bf7ea7ff3bb16
|
| ef3a4aead0eb4d6b0615159489d4a187ce90de2c |
|
07-Jun-2017 |
Ricardo Garcia <rago@google.com> |
Merge "Fix security vulnerability: Equalizer setParameter memory overflow" into klp-dev
|
| 68b9e0f5d69d3b1e7b7628037696ce32f032e819 |
|
05-Jun-2017 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer setParameter memory overflow
Bug: 37563371
Test: use POC on bug or cts security test
Change-Id: I9c9453a222b53fd5ef821330a34cb9e938e4d9c5
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| c86bf87c17750470628c2b1064cbb55dda95f38f |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996 am: b401a3bf44 am: 1f44782e92 am: ea83248dfb am: 716d258db4 am: f043bb5da6 am: 4d76e5bcd6 am: f21d5b4580 am: f0221a7dbe am: b26594e6ae am: 158ec15776 am: 426244d6dc am: c47adacb0d am: 0d340d4990
am: 0d77973e73
Change-Id: Id64c4d474e17a866d1981de43c6d22476f29da29
|
| 158ec15776e037711632ba820b0360040e36f9cd |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996 am: b401a3bf44 am: 1f44782e92 am: ea83248dfb am: 716d258db4 am: f043bb5da6 am: 4d76e5bcd6 am: f21d5b4580 am: f0221a7dbe
am: b26594e6ae
Change-Id: I4e3f2f389f80c4dd3f8775ce265f2059ff637f0d
|
| 4d76e5bcd6de1d15648190ca7508e7fb4d64467e |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996 am: b401a3bf44 am: 1f44782e92 am: ea83248dfb am: 716d258db4
am: f043bb5da6
Change-Id: I2a3a4486ade55675ce06ad9b6e3a4c01d1a4647d
|
| 716d258db4442a5e6859027d274494217d3077a1 |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996 am: b401a3bf44 am: 1f44782e92
am: ea83248dfb
Change-Id: I0ceea1282ab530f228b8e6f54678edf3bb2f9d69
|
| ea83248dfb1822e0c0d507f38b13d90a9641261e |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996 am: b401a3bf44
am: 1f44782e92
Change-Id: Idc429c80c4058fcd2232209afd5da70128cca837
|
| 1f44782e928615cc24f627fdd90ff01c04c093eb |
|
06-Jun-2017 |
Andy Hung <hunga@google.com> |
Merge "EffectBundle: Check value size for get preset name" into klp-dev am: f5d6e98996
am: b401a3bf44
Change-Id: Ie62820116b2250c7533975362e90ae8139933697
|
| fa5c6c97ee86ff038979cedea5c449be4e2b9899 |
|
16-May-2017 |
Andy Hung <hunga@google.com> |
EffectBundle: Check value size for get preset name
Test: CTS testAllEffectsEqualizer_CVE_2017_0401
Bug: 37536407
Change-Id: I347af04677fc49a01efb549f06ff81d1a00dc4d0
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 904d632a24db8f94de83e44f7179d1c0af022b03 |
|
18-Mar-2017 |
Eric Laurent <elaurent@google.com> |
Add support for USB headset device
Add missing rules for USB headset devices in routing, volume and effects
management.
Test: playback and catpure regression tests.
Change-Id: I42cd157f483deba2371a05d332cd11dceb2b2fa3
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 683094933e1d245ddab50ea0724158b75c2f832c |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles am: e5a54485e0 am: b0896dfc81 am: b9e070af6a am: e5c0e7e10b am: 3ffe48ed29 am: 3db88c0f00 am: 9169ca1b88 am: 654e9f9282 am: 8e86da478b am: 7ea7597648 am: 5c9fcda34e am: 8987fbb09b
am: dbedfa05fe
Change-Id: I17f774c35abbae99de2b3cfcae548c8863c036a8
|
| 8987fbb09bcd39b9f93b8efc9eae992e56a8d054 |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles am: e5a54485e0 am: b0896dfc81 am: b9e070af6a am: e5c0e7e10b am: 3ffe48ed29 am: 3db88c0f00 am: 9169ca1b88 am: 654e9f9282 am: 8e86da478b am: 7ea7597648
am: 5c9fcda34e
Change-Id: I17a93c1ff1348f4ad270033c095c5d683eb646c6
|
| 654e9f92821c735f8b681f0d2d34da4c33f7ebc0 |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles am: e5a54485e0 am: b0896dfc81 am: b9e070af6a am: e5c0e7e10b am: 3ffe48ed29 am: 3db88c0f00
am: 9169ca1b88
Change-Id: I444281056ba5770276b76900055c6e27daaeba63
|
| e5c0e7e10b9d6db685daa5123a26bff6ec2d4cd7 |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles am: e5a54485e0 am: b0896dfc81
am: b9e070af6a
Change-Id: I1676f829b5571abad93c9f4ce156811a55787024
|
| b0896dfc81d2bea911edbf19f0d8f47798e229a3 |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles
am: e5a54485e0
Change-Id: I131f8d196034854f562a175874bce19b29904664
|
| e5a54485e08400a976092cd5b1c6d909d0e1a4ab |
|
14-Feb-2017 |
Jean-Michel Trivi <jmtrivi@google.com> |
EffectBundle: check nb channels to write speaker angles
When speaker angles are queried, the size of the array for the
returned data is 3x the number of channels (where really it
should be max(2, nbChannels)). The code assumed it was at
least 3x2 (where 2 is the number of virtual speakers this
effect supports) and would thus crash when called for a mono
channel mask.
Test: see repro steps in bug
Bug: 32591350
Change-Id: I33d4bff6b2e19a9fc4284a85a446804878d3a410
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 32a5f5d53f9fe2ba584d2ecdf3edd487fb4146a7 |
|
22-Dec-2016 |
Mark Salyzyn <salyzyn@google.com> |
resolve merge conflicts of 4532a36 to master
Test: build
Change-Id: I9b93c4a703c0ee16116be2bea0e6df0606d29363
|
| 1121dfb5f30a04393ddce02fe7808589fa9e3e25 |
|
22-Dec-2016 |
Mark Salyzyn <salyzyn@google.com> |
Merge "Replace cutils/log.h with either android/log.h or log/log.h" am: a05da2eea4
am: 9e97dc7832
Change-Id: I414954c96ad8b803a0401d416887c9ce167db210
|
| 60d02077d86d2d1092443519290101f503aa6f7a |
|
29-Sep-2016 |
Mark Salyzyn <salyzyn@google.com> |
Replace cutils/log.h with either android/log.h or log/log.h
Test: compile
Bug: 31289077
Change-Id: I795a76f978d2213737f1fa908da789c543219b75
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| c64e124bca8b7813ecea19d38452dd55fee4082f |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a am: 3e8ab60b7f am: 9161586309 am: ad29b47d91 am: 8b9b199891 am: 72729c449d am: 97bb7fe084 am: 3d6aada999 am: ffe82a3b4a am: ec601622f8 am: f50635bdc4 am: f1e829a54e am: a2e95f5c9b am: c6239b0d4d
am: cbc7183fbb
Change-Id: I7a13718ab24d1c4c9c64d83e148031af046921e1
|
| c6239b0d4dfa730c122f2de214dfd2e62f7f8eea |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a am: 3e8ab60b7f am: 9161586309 am: ad29b47d91 am: 8b9b199891 am: 72729c449d am: 97bb7fe084 am: 3d6aada999 am: ffe82a3b4a am: ec601622f8 am: f50635bdc4 am: f1e829a54e
am: a2e95f5c9b
Change-Id: Ic25053a111913dfd4490633b9f0eff1e7fe1d359
|
| ec601622f852cd1710bb92023d318a28dd03c56d |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a am: 3e8ab60b7f am: 9161586309 am: ad29b47d91 am: 8b9b199891 am: 72729c449d am: 97bb7fe084 am: 3d6aada999
am: ffe82a3b4a
Change-Id: I428d5c72ea37518c30d50d21b1ef47e440933cde
|
| 72729c449d9f7a6f217be629066cb683ad27b37b |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a am: 3e8ab60b7f am: 9161586309 am: ad29b47d91
am: 8b9b199891
Change-Id: Id1d62d9ebabab42f5ca82ff2fbbcf14d130466f4
|
| ad29b47d91c26f65d1d9a58d2dac1970175a885c |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a am: 3e8ab60b7f
am: 9161586309
Change-Id: Ibcceb08d7db77f67f3dfc3cdad1d2bd6994183ae
|
| 9161586309fd018a1503dc5227f2cb329b935213 |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57 am: 01e854056a
am: 3e8ab60b7f
Change-Id: Ib575df34ec5bb7dc2cd83a859e10abe94e894317
|
| 3e8ab60b7f65dd4c5c9efa4a1c388a51fbbb5d11 |
|
30-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver am: e275907e57
am: 01e854056a
Change-Id: I7ea6a871eed4b9e1c56c5350c4e5fb5eb628e816
|
| e275907e576601a3579747c3a842790bacf111e2 |
|
23-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: potential OOB write in audioserver
Bug: 32705438
Bug: 32703959
Test: cts security test
Change-Id: I8900c92fa55b56c4c2c9d721efdbabe6bfc8a4a4
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 221bfde160c9d0f52cab903bfb2e48d04881243e |
|
23-Nov-2016 |
Baligh Uddin <baligh@google.com> |
Merge remote-tracking branch 'goog/cw-f-dev' into fix_merger
Bug: 32849428
* goog/cw-f-dev:
If a device does not have a camera, do not set a camera death notifier
Fix security vulnerability: Effect command might allow negative indexes
Make VBRISeeker more robust
DO NOT MERGE: defensive parsing of mp3 album art information
Effects: Check get parameter command size
IOMX: convert ANWB to Gralloc meta if using useBuffer in the same process
DO NOT MERGE: defensive parsing of mp3 album art information
DO NOT MERGE: defensive parsing of mp3 album art information
DO NOT MERGE: defensive parsing of mp3 album art information
DO NOT MERGE: defensive parsing of mp3 album art information
Camera API1: don't pick wrong preview fps value
Fix security vulnerability: Equalizer command might allow negative indexes
Camera API1: relax the fps check with some margin
stagefright: remove allottedSize equality check in IOMX::useBuffer
Camera API1: filter out the unsupported preview fps range
DO NOT MERGE: Visualizer: Check capture size and latency parameters
Visualizer: Check capture size and latency parameters
|
| 179c103d6c0fcae0c80273b53fad8654ab3cbec5 |
|
16-Nov-2016 |
Caroline Tice <cmtice@google.com> |
Merge "Fix 2 compiler warnings."
|
| 3427ab41b4974c68e8f1aa08e1062f3a53fd965c |
|
16-Nov-2016 |
Caroline Tice <cmtice@google.com> |
Fix 2 compiler warnings.
This CL fixes the following 2 compiler warnings:
EffectBundle.cpp:343:18 warning: Dereference of null pointer
(loaded from variable 'pHandle')
EffectBundle.cpp:2662:13 warning: Value stored to 'status' is never read
BUG: None
Test: None
Change-Id: Ifa68a79c6fe82ffcbd22890e1187c92a72535b7e
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 622da70c3b65b922d05518574a2021105f958839 |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74 am: 9bf3487e7a am: d4881f8406 am: f31abe2c96 am: 0905c40edc am: 7b4d79044d am: a6323b04de am: d8383694f9 am: e92a0c60d8 am: 3712921ae9 am: df9b8955cb am: 3939df6105 am: af55335d2d am: 549f6da1f6
am: 9dc4111c17
Change-Id: I0a10b78775b4ae5ab3c0452b4befa052f26f7631
|
| 9dc4111c17971a0530cc6ab88231993bbf5dc223 |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74 am: 9bf3487e7a am: d4881f8406 am: f31abe2c96 am: 0905c40edc am: 7b4d79044d am: a6323b04de am: d8383694f9 am: e92a0c60d8 am: 3712921ae9 am: df9b8955cb am: 3939df6105 am: af55335d2d
am: 549f6da1f6
Change-Id: I8f8302fc4259dba7f26ad7b6c42198c71d94e7ed
|
| 3712921ae97ac6e90f61f341e0c3515b43f9b83e |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74 am: 9bf3487e7a am: d4881f8406 am: f31abe2c96 am: 0905c40edc am: 7b4d79044d am: a6323b04de am: d8383694f9
am: e92a0c60d8
Change-Id: I0275c7561f4da96d0a17a663d4c2ce8942f33bbb
|
| 7b4d79044dbb69378e0b6e72aca384433c7b95e0 |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74 am: 9bf3487e7a am: d4881f8406 am: f31abe2c96
am: 0905c40edc
Change-Id: I1e1cddf4f5a95b4ac251aae6ff5db31877517936
|
| f31abe2c9691b0e8b584b2f6e10d7b181e7eff0a |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74 am: 9bf3487e7a
am: d4881f8406
Change-Id: I4786037f49f5da37a1a363f7cb01c9c086776624
|
| d4881f84060670553efcb9c445a7c48aeaed0dfa |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7 am: 94e3424b74
am: 9bf3487e7a
Change-Id: Ia36571a591829777096ad41316b7edf169ce9a6c
|
| 9bf3487e7a33a85c4270f65abe4bc3e3c0848bcf |
|
16-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes am: 01183402d7
am: 94e3424b74
Change-Id: Id0353ac5716377b45e3a967110d43d9baf744be8
|
| 01183402d757f0c28bfd5e3b127b3809dfd67459 |
|
14-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Effect command might allow negative indexes
Bug: 32448258
Bug: 32095626
Test: Use POC bug or cts security test
Change-Id: I69f24eac5866f8d9090fc4c0ebe58c2c297b63df
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 6184728e5472c2fd1dc112210a5ed72ab6abc798 |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff am: 8fb8275471 am: 6b4cf2c0d3 am: dd060b3bb4 am: 4bcf2e6fbe am: 81e0914473 am: 3d16a9c4b4 am: cde28c8a31 am: 00d12e3037 am: 67f8e40fcd am: 1b1d8e79a3 am: f386ebab0a am: 427e18298a am: 635d955978
am: fb35b6654b
Change-Id: I595408907d99c3466227637f224991510f0a97db
|
| 1b1d8e79a3d0c7e10cfedf928d292e10ff896cb8 |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff am: 8fb8275471 am: 6b4cf2c0d3 am: dd060b3bb4 am: 4bcf2e6fbe am: 81e0914473 am: 3d16a9c4b4 am: cde28c8a31 am: 00d12e3037
am: 67f8e40fcd
Change-Id: Ic2bd5928180f19aee4d0b0a4e048c79e96eb9480
|
| 3d16a9c4b4415b5009e5b3733c4933f5cd4c8193 |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff am: 8fb8275471 am: 6b4cf2c0d3 am: dd060b3bb4 am: 4bcf2e6fbe
am: 81e0914473
Change-Id: Ia098ff7b7e1761e4af3ee256110f736f31860256
|
| 4bcf2e6fbe340fb7089e0ee4a5ad700035d2d5ea |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff am: 8fb8275471 am: 6b4cf2c0d3
am: dd060b3bb4
Change-Id: If6848a77e1f2a785c017d2e5d77f770c34a97d4c
|
| dd060b3bb45cb50e965de50a3b278c8474eeb4b6 |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff am: 8fb8275471
am: 6b4cf2c0d3
Change-Id: I88ed7d46bb8d54dcb2309b103dd6fcf787ba3269
|
| 6b4cf2c0d3e528874a62c78d74d33c6c99b99f7f |
|
09-Nov-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes am: e981cca9ff
am: 8fb8275471
Change-Id: Iba4ca7302804912646e8c510d2e436ebbf8373aa
|
| e981cca9fff3608af22bdf8fc1acef5470e25663 |
|
31-Oct-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes
Bug: 32247948
Bug: 32438598
Bug: 32436341
Test: use POC on bug or cts security test
Change-Id: I91bd6aadb6c7410163e03101f365db767f4cd2a3
(cherry picked from commit 0872b65cff9129633471945431b9a5a28418049c)
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 0872b65cff9129633471945431b9a5a28418049c |
|
31-Oct-2016 |
rago <rago@google.com> |
Fix security vulnerability: Equalizer command might allow negative indexes
Bug: 32247948
Bug: 32438598
Bug: 32436341
Test: use POC on bug or cts security test
Change-Id: I91bd6aadb6c7410163e03101f365db767f4cd2a3
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| ef225074ea06dc8ac2801b2fb9f4707dcd3f4200 |
|
05-Oct-2016 |
Glenn Kasten <gkasten@google.com> |
Enable strict warnings and fix unused warnings
Test: builds without warnings
Change-Id: I0701a44cbd9a2adc405a1e253b57df7ee03a90b7
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 50bccc66cb570459ae5f93faa986204526b81262 |
|
18-May-2016 |
Chih-hung Hsieh <chh@google.com> |
Merge "Fix misc-macro-parentheses warnings." am: 512c04c5cc
am: 00f6841c91
* commit '00f6841c91c4df0e5d9bf86d2593ae9e0e75bcce':
Fix misc-macro-parentheses warnings.
Change-Id: Ice0b2dc35814165460bce73e9cd2dceab0091624
|
| ee5863a537bc83a0a603de43e068bbaff850ec59 |
|
18-May-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix misc-macro-parentheses warnings.
Bug: 28705665
Change-Id: Iaddda0f87395c44173a312f53e42a47c041d4526
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 440c9e9b72277d6fc6cea630b9ab50f12687a9c0 |
|
12-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers. am: 9e29523b95 am: baebc739b0 am: 3a9d4f4a83 am: 5b7c20dd1e am: df81fc3f3c am: 68e43cf141
am: b1338d3cfc
* commit 'b1338d3cfcb47d0fc5f21e2b939d66316b307fe3':
fix possible overflow in effect wrappers.
|
| df81fc3f3c56048a797232fa49185831f250e57c |
|
12-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers. am: 9e29523b95 am: baebc739b0 am: 3a9d4f4a83
am: 5b7c20dd1e
* commit '5b7c20dd1ee9eff7f96676cec68d4b74e33440e7':
fix possible overflow in effect wrappers.
|
| 3a9d4f4a83341e4c083aa50a651fe5d765ef70ad |
|
12-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers. am: 9e29523b95
am: baebc739b0
* commit 'baebc739b0fe7257b26bfe105b67409559171c82':
fix possible overflow in effect wrappers.
|
| baebc739b0fe7257b26bfe105b67409559171c82 |
|
12-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers.
am: 9e29523b95
* commit '9e29523b9537983b4c4b205ff868d0b3bca0383b':
fix possible overflow in effect wrappers.
|
| 9e29523b9537983b4c4b205ff868d0b3bca0383b |
|
08-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers.
Add checks on parameter size field in effect command handlers
to avoid overflow leading to invalid comparison with min allowed
size for command and reply buffers.
Bug: 26347509.
Change-Id: I20e6a9b6de8e5172b957caa1ac9410b9752efa4d
(cherry picked from commit ad1bd92a49d78df6bc6e75bee68c517c1326f3cf)
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| ad1bd92a49d78df6bc6e75bee68c517c1326f3cf |
|
08-Jan-2016 |
Eric Laurent <elaurent@google.com> |
fix possible overflow in effect wrappers.
Add checks on parameter size field in effect command handlers
to avoid overflow leading to invalid comparison with min allowed
size for command and reply buffers.
Bug: 26347509.
Change-Id: I20e6a9b6de8e5172b957caa1ac9410b9752efa4d
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 2a5afed82fd4edd220551ce5565d89ac976f6720 |
|
21-Aug-2015 |
Eric Laurent <elaurent@google.com> |
LVM Effects: add malloc checks
Bug: 20674084.
Change-Id: I7ea2e3a53d020be11c3a7f15315be038bab4bb4d
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| c655561b3580ae7ba3a721e69ac240606e11fab8 |
|
23-Jun-2015 |
Eric Laurent <elaurent@google.com> |
am 29b83cbb: DO NOT MERGE - audio effects: fix heap overflow
* commit '29b83cbb9018e53a18cf6e0fb34893f9774dcb96':
DO NOT MERGE - audio effects: fix heap overflow
|
| 3f0b4976ec8023c5cad92b21ac3064d63d1aa581 |
|
23-Jun-2015 |
Eric Laurent <elaurent@google.com> |
am 4c855d20: am 6368e6d2: audio effects: fix heap overflow
* commit '4c855d207edaaeb8c61109977a5297418295658c':
audio effects: fix heap overflow
|
| 29b83cbb9018e53a18cf6e0fb34893f9774dcb96 |
|
20-Jun-2015 |
Eric Laurent <elaurent@google.com> |
DO NOT MERGE - audio effects: fix heap overflow
Check consistency of effect command reply sizes before
copying to reply address.
Also add null pointer check on reply size.
Also remove unused parameter warning.
Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 6368e6d23ca27cd59a9a1876d6b5a2301a8657ed |
|
20-Jun-2015 |
Eric Laurent <elaurent@google.com> |
audio effects: fix heap overflow
Check consistency of effect command reply sizes before
copying to reply address.
Also add null pointer check on reply size.
Also remove unused parameter warning.
Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4
(cherry picked from commit 0f714a464d2425afe00d6450535e763131b40844)
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 0f714a464d2425afe00d6450535e763131b40844 |
|
20-Jun-2015 |
Eric Laurent <elaurent@google.com> |
audio effects: fix heap overflow
Check consistency of effect command reply sizes before
copying to reply address.
Also add null pointer check on reply size.
Also remove unused parameter warning.
Bug: 21953516.
Change-Id: I4cf00c12eaed696af28f3b7613f7e36f47a160c4
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 7f0e16e391b0bd243005cc1049d3b6799f0692ec |
|
22-May-2015 |
Ricardo Garcia <rago@google.com> |
Level adjustment for Bundled Effect Fix
Fixed automatic level compensation for bundled effects. Fixed algorithm
now works even in corner cases previously reported.
Cross band coefficients and cross interaction of BassBoost fixed.
bug: 18769691
Change-Id: I51570836bdbff37e7c4b26f2b4282e4ded7fa56d
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 02521e37c0494b83947c35160f3669de8adc9e5b |
|
20-Nov-2014 |
Ricardo Garcia <rago@google.com> |
Fix for Bundled Effects level compensation
From the bundled effects, only the EQ had some sort of level compensation
based on the settings of the effect. This patch takes into account all
the status and levels of EQ, BassBoost and Virtualizer bundled effects
and makes an informed decision on the overall level compensation.
bug: 18213779
Change-Id: I23c7b94fe7da5482f0bbef0cbe715ea464631420
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 47d4c9a4d53ed014b520edbda2edc3e280efb8a5 |
|
05-Dec-2014 |
Ricardo Garcia <rago@google.com> |
Fix for AOSP force virtualization mode
Forcing virtualization mode with AOSP code might erroneously return
a failed code, whilst it was correct. Fixing the condition for
Automatic mode.
bug: 18538537
Change-Id: I5837ff40cfed04c99889813cd56ebe3d90793e74
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 333f66d4642ddd36b42668da2767551ba25f0248 |
|
09-Jul-2014 |
Jean-Michel Trivi <jmtrivi@google.com> |
DO NOT MERGE LVM virtualizer: add support for virtualizer capability query
Change-Id: I88106ba25f9b3f8fd7616307ab6b7fbe7afb6e91
(cherry picked from commit bfd3b9764841971be2d2f04a3fdbd41a2144beea)
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 7618c5cb2fd60e944307e46afa051987d1e016c6 |
|
08-Jul-2014 |
Jean-Michel Trivi <jmtrivi@google.com> |
Cleanup unused parameters or variable in EffectBundle
No unused parameter warning in EffectBundle.
Remove unused variable declaration in Virtualizer_getParameter
Change-Id: Ibe1c051bc21ac53a6c770b4aa28e31ac5d559d9b
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 7b6c7b89241397261d52602cbeaa559962efbfec |
|
20-Jun-2014 |
Mark Salyzyn <salyzyn@google.com> |
libeffects: 64-bit compile warnings
Change-Id: I210129f5742b046f7ceef48194f039352eff596d
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| b302bd5d288be2d3363b80053ca2392560b00b25 |
|
18-Feb-2014 |
Ashok Bhat <ashok.bhat@arm.com> |
LP64 fixes for media/libeffects
Changes include:
[x] In get parameter series of functions, replaced size_t*
formal parameter type with uint32_t* where actual parameter
passed was uint32_t*.
[x] In set parameter series of functions, changed size_t
formal parameter to uint32_t where actual parameter was
uint32_t.
[x] Changed the definition of LVM_UINT32 from unsigned
long to uint32_t as unsigned long is 64-bit in LP64.
[x] Used other stdint.h types for other LVM_types for
consistency.
[x] Use of uintptr_t for the pNextMember of the INST_ALLOC
structure, rather than LVM_UINT32, for portablility.
[x] Use of uintptr_t where pointers are used in arithmetic.
[x] Replaced the use of 0xFFFFFFFC with ~3 in places where
it was used to clear last two bits.
[x] Removed int casts where cmdSize and *replySize, both
uint32_t, were being compared with sizeof().
Change-Id: Ibec0b4d8e9b855f44b1cd853be6df84d13cf4186
Signed-off-by: Marcus Oakland <marcus.oakland@arm.com>
Signed-off-by: Ashok Bhat <ashok.bhat@arm.com>
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 377b2ec9a2885f9b6405b07ba900a9e3f4349c38 |
|
03-Feb-2014 |
Kévin PETIT <kevin.petit@arm.com> |
Make frameworks/av 64-bit compatible
Contains the necessary changes to make frameworks/av build and work
on a 64-bit machine.
Signed-off-by: Craig Barber <craig.barber@arm.com>
Signed-off-by: Kévin PETIT <kevin.petit@arm.com>
Signed-off-by: Ashok Bhat <ashok.bhat@arm.com>
Signed-off-by: Marcus Oakland <marcus.oakland@arm.com>
Change-Id: I725feaae50ed8eee25ca2c947cf15aee1f395c43
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| c9d8ea7f8f9a1ca8ecd266695e3cac423790b2f9 |
|
20-Oct-2013 |
synergydev <synergye@codefi.re> |
libeffects: do not use GNU old-style field designators
Not using a GNU extension improves portability
Change-Id: I4e8a0376c089828ca4fc7f1aaf3914bfd917d4c5
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 209bbbcf4190231f9dede758cbe77d109919f9f1 |
|
21-Jun-2013 |
Jean-Michel Trivi <jmtrivi@google.com> |
Apply EQ and bass boost first in effect chain
EQ and bass boost can improperly interact with other effects
(e.g. virtualizer) outside of the bundle. Apply them first
in an effect chain, which is equivalent to using them to affect
the content of a track, rather than how a track is presented,
when additional effects are cascaded behind EQ and BB.
Bug 8589316
Change-Id: Ifb34e46bc1969f613cdc90ee2a79af677e2fad92
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 6a5c6ed13e3ea1b19835e08624125c9b1505b32c |
|
19-Mar-2013 |
Marco Nelissen <marcone@google.com> |
Fix valgrind error
The volume member of the BundledEffectContext class was not being
initialized, resulting in uninitialized data being used for calculations
and control flow.
Change-Id: I84bf9fd478e5d0479e781323b21c7c03dea958c5
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 7f16b197c76fbae9399242f055a7ee16dcd0fd6d |
|
26-Oct-2012 |
Marco Nelissen <marcone@google.com> |
Only export the symbols that need to be
The effects libraries were exporting many more symbols than needed.
This reduces the exported symbols to just the needed ones (basically
just "AELI"), which happens to also save about 28KB.
Change-Id: I115077e52e8dc845282e6f62a522908d26dd72d6
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 6035cb5a61a7606cc8e4ecddec32b2eb37a9fd56 |
|
25-Oct-2012 |
Marco Nelissen <marcone@google.com> |
Switch to new fx library API
Change-Id: I6603aef5e3821a8f911e3f33ef8565d04bd1e2e5
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 97bb6e89845cb6d85f4d34a4efcc1de2ce585336 |
|
17-Oct-2012 |
Marco Nelissen <marcone@google.com> |
Fix valgrind issues
We were reading some uninitialized memory when creating bass boost and EQ
effects, and using memcpy() with identical source and destination.
Change-Id: I15ea1b2c52ae05cbf54aef04351e89805e0ebf8e
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 0ee916f1f69c2d69e02a8de1e5cd5a2e9d0a0782 |
|
17-Sep-2012 |
Eric Laurent <elaurent@google.com> |
Fix THD with max user EQ preset volume again
There was a problem with previous fix in 1b6c677c where
the THD was good for max volume but bad for intermediate
high volume values.
This fix does not limit the band gains but apply a correction
to the effect bundle volume to take into account not only the
maximum band gain but also the average band gains weighted
by the proximity of each band to the max gain band.
Change-Id: Ibedd8da7fce1e163117f29b3da332da0e4fe8889
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 9b3c701bbdbf3e4655758e995d467b325f8f366d |
|
11-Sep-2012 |
Eric Laurent <elaurent@google.com> |
Limit maximum equalizer gain.
Limit maximum gain in all EQ bands according to current volume so that
total gain (current volume + band gain) does not exceed a certain limit.
The gain difference between bands is preserved.
Change-Id: Ice5a9705a0b3353e8778b4c539a29ca9cdf60390
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 9f6f0a7eb1d7f2c35f3547779364a1a8d6d4a24c |
|
30-Aug-2012 |
Eric Laurent <elaurent@google.com> |
audio effects: fix bug in sample rate control.
Fix a bug in LVM bundle wrapper preventing audio framework sample rate
from being sent to the effect bundle instance.
Change-Id: I912027f866d3beac91b977bba869ff96a92d2a62
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| e44615ff6022239850a3ea459ad6e07b44c37544 |
|
24-Aug-2012 |
Eric Laurent <elaurent@google.com> |
Reduce THD when equalizer is ON.
Increase headroom in LVM bundle to reduce THD when equalizer is ON
with high band gains.
Also add a workaround for a bug in headroom parameter control.
Change-Id: I1d67c9ae475f6cf852c2e0e49bacfc82a5e484fd
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| a189a6883ee55cf62da1d7bf5bf5a8ab501938a4 |
|
20-Feb-2012 |
Glenn Kasten <gkasten@google.com> |
Use struct assignment instead of explicit memcpy
for POD structs effect_descriptor_t and effect_config_t
Change-Id: Ib2fc47f85fb65ed91b0abb1f87217c49b5eb571d
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 17a736c3e1d062d7fc916329eb32aef8935614af |
|
14-Feb-2012 |
Glenn Kasten <gkasten@google.com> |
Update comments
Change-Id: I327663a020670d0a72ff57bd0b682e2ce0528650
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| b4d307481960b6b348fae4b4e8edefd003c3d36c |
|
13-Mar-2012 |
Glenn Kasten <gkasten@google.com> |
Use correct syntax for #include <> ""
Change-Id: I943137108668ae66f8eba18dafe069a7951bcd8f
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 5e92a7861196ddae14638d4b7a63fc4892b7ef59 |
|
30-Jan-2012 |
Glenn Kasten <gkasten@google.com> |
Effect UUID inputs passed by pointer are const
Change-Id: I1f5c338bcb7368e3dd8cd5f804b2e6d9fbe087f8
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 3d5188bd6abe55898f10a0edf3c05aff8aa2ef67 |
|
17-Dec-2011 |
Eric Laurent <elaurent@google.com> |
audio effects: rename configure command
Renamed audio effect library interface command for audio format
configuration from EFFECT_CMD_CONFIGURE to EFFECT_CMD_SET_CONFIG.
This makes the naming more consistent with other exixsting commands
and allow adding a new command to get the configuration (EFFECT_CMD_GET_CONFIG).
Same change for reverse channel configuration renamed from
EFFECT_CMD_CONFIGURE_REVERSE to EFFECT_CMD_SET_CONFIG_REVERSE.
Implemented EFFECT_CMD_GET_CONFIG in exisitng effect libraries.
Change-Id: Ia7b1c620f13797fe5aceb3b0b4acbacce09fb067
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 45b92707d851458c73e320d2450cfc246b1167db |
|
05-Nov-2011 |
Eric Laurent <elaurent@google.com> |
resolved conflicts for merge of 914972be to master
Change-Id: I15adb9040eaa206c31bb5a08ed5ee5b32967ba0a
|
| f5a486a54d85ee59f4e9afa18b05c1946d749050 |
|
05-Nov-2011 |
Eric Laurent <elaurent@google.com> |
resolved conflicts for merge of 79178b8b to master
Change-Id: Ia597549a6d159b86063eb3afec5ce7fe98434a65
|
| 4d954c4ff6ab7110df23f1f3ebfe296beb97f3de |
|
04-Nov-2011 |
Eric Laurent <elaurent@google.com> |
Merge "Fix device management in lvm effect bundle wrapper." into ics-mr1
|
| 5dc65e2ce92c7364da60bdff5f345daf145c2c0f |
|
01-Nov-2011 |
Eric Laurent <elaurent@google.com> |
Fix problem in lvm effect bundle wrapper.
When an effect is disabled, the process function should either
copy or accumulate the content of the input buffer to the output buffer
depending on the behavior requested by the framework.
Current implementation is copying the input buffer unconditionally.
Related to issue 5433942.
Change-Id: Ic488ca97eadcc4c763de570d7e6c6f5b7a979415
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| b6431802fc6cff501a4311de288ba469839fbf86 |
|
01-Nov-2011 |
Eric Laurent <elaurent@google.com> |
Fix device management in lvm effect bundle wrapper.
The virtualizer and bass boost effects should be disabled when
not playing throught headsets or headphones.
There is a bug in current wrapper implementation that makes that those
effects are not disabled if the effect is enabled by the user after
the headset has been removed (current logic only works if the device selection
occurs while the effect is enabled).
Change-Id: I7c66b15a0339d95fb9ed13c8320d66379725d3b6
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 3856b090cd04ba5dd4a59a12430ed724d5995909 |
|
20-Oct-2011 |
Steve Block <steveblock@google.com> |
Rename (IF_)LOGV(_IF) to (IF_)ALOGV(_IF) DO NOT MERGE
See https://android-git.corp.google.com/g/#/c/143865
Bug: 5449033
Change-Id: I0122812ed6ff6f5b59fe4a43ab8bff0577adde0a
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| ba7b8f881a9b6b21803752326d2932a3bd42d7cf |
|
18-Jun-2011 |
Eric Laurent <elaurent@google.com> |
Audio Effect API: process reverse stream function
Added function to audio effect interface for processing of
a reverse stream.
This is necessary for audio pre processes like echo cancellation.
Change-Id: I6e12d79dbbed6376acdfc79304b8c0ab3f705eae
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| e1315cf0b63b4c14a77046519e6b01f6f60d74b0 |
|
18-May-2011 |
Eric Laurent <elaurent@google.com> |
New effect library API
Moved and renamed media/EffectApi.h to hardware/audio_effect.h
Modified the effect library API to expose a library info structure
containing an interface functions table.
Also removed enums for audio channels, audio format and devices
from effect API and use values from system/audio.h instead.
Modified effects factory to support new library interface format and
load libraries and efffects listed in audio_effects.conf file.
The file audio_effects.conf is first loaded from /vendor/etc and
then from /system/etc/audio_effects.conf if not found.
Modified existing effect libraries to implement the new library interface.
Change-Id: Ie52351e071b6d352fa2fbc06c3846686f8c45df9
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| d71a0e1ac517cf312b9a96fe5ba9de04f2b9ffd4 |
|
01-Mar-2011 |
Eric Laurent <elaurent@google.com> |
Fix issue 3499926.
Make sure that NumberEffectsEnabled is decremented at the same time as
SamplesToExitCountBb reaches 0 in Effect_process(). Not doing so
causes NumberEffectsEnabled not being decremented if Effect_setEnabled()
is called after SamplesToExitCountBb reaches 0 and before next Effect_process() is called.
Change-Id: Id827a301f93a5a09ecd9995a0c7d731ef526711a
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| dac69110ed1073bf0a9827a3f78698896dd05d97 |
|
28-Sep-2010 |
Eric Laurent <elaurent@google.com> |
Fix several audio effects problems.
Fixed the following issues in LVM effect bundle wrapper:
- memory leaks in EffectCreate() in case effect creation fails at various stages
- Added saturation when accumulating to output buffer
- Fixed problems with enabled effects count when an effect is released while enabled
- Do not allocate temporary buffer for accumulation each time process() is called
Fixed the following issues in effects framework (AudioFlinger)
- Release effect synchronously in the library when deleted from effect chain
- Do not call the effect process function if no tracks are present in the same
audio session
Change-Id: Ifbd80a163415cfb3c0a337c12082853ea45d9c91
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 29cc743e57f2a1701a0a0d3a0e5406ed0f2e8a89 |
|
16-Sep-2010 |
Eric Laurent <elaurent@google.com> |
Fix problem in lvm effect bundle wrapper
When an effect was deleted while enabled, the count of enabled effects
in the bundle was not decremented. Resulted a state where if another effect
was still enabled, its process function was called only every other time.
Change-Id: I59a0c5b7f50f416a9ecadae297b42912e56ddd51
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| e0aed6ddcb4e3c301b80aa26706b6052dab42c41 |
|
11-Sep-2010 |
Eric Laurent <elaurent@google.com> |
Fix volume problems with insert revert
- Use a constant input level to the reverb engine and implement volume control in the
insert reverb. This avoids the volume spikes when an effect that was inserted after
the reverb is disabled or removed.
- Fix clicks (one silent buffer) at the end of the reverb disable period.
- Modified volume management in audioflinger so that the volume ramp is also done by
the insert effect if present when the track is paused (avoids clicks).
- Increased room level for all presets.
Also fixed problems with output stage session (-1):
- effect bundle wrapper was not designed to support session -1
- the permission check in audioflinger for using session -1 failed due to a wrong usage of
getCallingPid()
Change-Id: Id1ff51327263364bf71d3f2668fa5cde4311d84f
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 2d3bf535004f7310fe04a4b5f46b6747cdb3c93f |
|
03-Sep-2010 |
Eric Laurent <elaurent@google.com> |
LVM release 1.08 delivery.
- Changed bundle SamplesToExit to 0.1 secs
- Added SamplesToExit to Revreb
- Removed mixer from Core reverb
Change-Id: I675ec22889f20ef35a0ac427600c2654111c397e
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 8f45bd725549436eeacd12ee69349e2332ed8da5 |
|
31-Aug-2010 |
Eric Laurent <elaurent@google.com> |
Audio Effects: fix problems in volume control.
- Fixed click when re-enabling effect during the turn off phase:
make sure the effect states where effect is processed are the same
where volume control is delegated to effect.
- Fixed click when effect is deleted while still active: do not apply
volume ramp if an effect having volume control was just removed from the
effect chain.
Also fixed a crash when PCM dump is enabled in effect bundle wrapper.
Change-Id: Ib562f5cf75c69af75df0e862536262e2514493e4
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| d918324d44aa48b3b064ea9b87d0c520c38f15a9 |
|
27-Aug-2010 |
Eric Laurent <elaurent@google.com> |
LVM release 1.07 delivery.
- Virtualizer now uses the correct control parameter, instead of reverberation
- Volume smoothing for first frame has been added
- Equalizer_setParameter now returns correct error code
- Correcting Non-Linear compressor gain step noise during transitions and effect level changes
- Removed SVN header blocks
- Memory and MIPS values have been added to the API
- Reverb uses a more efficient malloc for input PCM
- Reverb DecayHFRatio now ranges up to 2000
- Logging has been removed for most volume functions
Change-Id: Ib59e7e331263c3811559231b4ae90c82e34a8421
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 97344f1d8e8e95fd07d5deee2ae2492a7e4c24b0 |
|
24-Aug-2010 |
Eric Laurent <elaurent@google.com> |
Added preset reverb.
Modified lvm reverb wrapper code to expose a preset reverb interface.
Also removed debug log from bundle and reverb wrapper.
Change-Id: If9b95d91e25a6ff834decdfdda34b17df9b46967
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| c59c6fd7f859b4010d788db89b8d4d76bbb70e57 |
|
04-Aug-2010 |
Eric Laurent <elaurent@google.com> |
LVM release 1.05 delivery
- Click have been removed from the HP filter activation in the BassBosst Effect.
- SessionId is now stored as a SessionNo
- Effects now stop being called after a delay
- Unix EOL fixed for .java and .xml
- Updated lines limited to 100 characters.
- Removed the remaining warnings from the wrapper code
- Added reverb
Change-Id: I03a2b3b5ee2286958f4901acc8d9b0daf9e2d7c6
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 7fa8a0ec14781a50695cf8c9dd2a85a5e8a3c3f0 |
|
18-Aug-2010 |
Eric Laurent <elaurent@google.com> |
Audio Effects: fixed "strength supported" parameter size.
The "strength supported" parameter for bass boost and virtualizer effect was incorrectly using a
short value whereas it should be an int. This is to comply to the definition of boolean type in OpenSL ES
that is uint32.
Change-Id: I74ccb61dcc70fc9d390524a1ca5bbbd8b13ab1af
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 3be9523784cc4038f601e510faee595117cdacb3 |
|
30-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Audio effects: aligned Equalizer API argument types on OpenSL ES SLEqualizerItf.
Modified types of some arguments and returned values of the Equalizer class from int to short
to match those defined by OpenSL ES SLEqualizerItf interface.
Also fixed a problem with set properties in equalizer engine implementation.
Change-Id: I75894bad0cb67b01c18ca5e22f9687e75ee491b8
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 25f4395b932fa9859a6e91ba77c5d20d009da64a |
|
28-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Audio effects: modified command() parameter types.
The type of the cmd, cmdSize and *pReplySize parameters of the effect control interface command()
function have been modified from int to uint32_t. This is more consistent with their role.
Change-Id: I84d289fc262d6753747910f06f485597dfee6591
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 23e1de74359f4bb1763aef0adfebe073122b032c |
|
23-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Audio Effects: added methods to effects java classes to store and load current effect settings in
a single call.
Addional changes:
- Fixed simulator build
- Use effect interface UUIDs from OpenSL ES includes when available
- Added cleanspec rules to remove now obsolete test effect libraries
- Fixed bug in AudioEffect JNI setParameter function.
Change-Id: Ic25ddb135e2cec5a68c181d727321f5ac7a1ab6b
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 010ae0dd9eab40a49a840388230d8bb2f97c530e |
|
26-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Fixed bug in vlm effect bunde wrapper effect init function.
The status in the command reply field was not initialized by Effect_command() for
EFFECT_CMD_INIT causing unpredictable failures when initializing an effect.
Change-Id: I7dccb094c9244fad4ed9aea3062a395db295e082
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 163fbcf84010b98e0374110454d85b804bc8d13b |
|
23-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Audio effects: lvm bundle wrapper update after first integration tests.
Change-Id: I20cb55282833bd6e3a160e0dae1cc1fcb6b1ca30
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| de070137f11d346fba77605bd76a44c040a618fc |
|
13-Jul-2010 |
Eric Laurent <elaurent@google.com> |
Audio policy manager changes for audio effects
Added methods for audio effects management by audio policy manager.
- control of total CPU load and memory used by effect engines
- selection of output stream for global effects
- added audio session id in parameter list for startOutput() and stopOutput().
this is not used in default audio policy manager implementation.
Modifications of audio effect framework in AudioFlinger to allow moving and reconfiguring
effect engines from one output mixer thread to another when audio tracks in the same session
are moved or when requested by audio policy manager.
Also fixed mutex deadlock problem with effect chains locks.
Change-Id: Ida43484b06e9b890d6b9e53c13958d042720ebdb
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|
| 2c8e5cab3faa6d360e222b7a6c40a80083d021ac |
|
09-Jul-2010 |
Eric Laurent <elaurent@google.com> |
First submission of audio effect library from NXP software.
This CL contains the first open sourceable version of the audio effect library from NXP software.
The effects implemented are:
- Bass boost
- Virtualizer (stereo widening)
- Equalizer
- Spectrum analyzer
Source file for the effect engines are located under libeffects/lvm/lib
The wrapper implementing the interface with the audio effect framework in under libeffects/lvm/wrapper
The code of other effect libraries has also been reorganized fo clarity:
- the effect factory is now under libeffects/factory
- the test equalizer and reverb effects are under libeffect/testlibs
- the visualizer is under libeffects/virtualizer
Change-Id: I8d91e2181f81b89f8fc0c1e1e6bf552c5809b2eb
/frameworks/av/media/libeffects/lvm/wrapper/Bundle/EffectBundle.cpp
|