| 40d8899f60c5212af9d727ba0ffaaecf676ebd1d |
|
09-Aug-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix clang-tidy warnings in stagefright.
* Add explicit keyword to conversion constructors.
* Or add NOLINT to implicit conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
* Use const reference type to avoid unnecessary copy.
Bug: 30413862
Test: build with WITH_TIDY=1
Change-Id: I7a15ac1e37973fe2c661f577a6106b913653de40
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 2c9cb62d0160fc4353d89fd9d648725794e7995e |
|
29-Feb-2016 |
George Burgess IV <gbiv@google.com> |
Cleanup uses of sprintf so we can deprecate it.
Also removes a seemingly useless branch.
Change-Id: Icd61d4facd64985f4c73e9876569e1ae1a74ee83
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 938e2b34b16c3c1fd29c753eeb53ee95a2b2e2b3 |
|
14-Jun-2015 |
Nick Kralevich <nnk@google.com> |
don't trigger an integer underflow when decrementing.
When decrementing "i", eventually i will equal zero. When that
happens, i-- underflows. This causes a crash when code which uses
clang's -fsanitize=unsigned-integer-overflow is run.
Avoid trigging an unsigned integer underflow.
Change-Id: I61709cb01f56fdb36d631aa95579e8bd09cafd12
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 3f27436a9346f043f52265da1e6a74cde2bffd4d |
|
05-Mar-2015 |
Lajos Molnar <lajos@google.com> |
stagefright: don't use ALooperRoster mutex for reply handling
Change replyID-s from uint32_t to an object
Move reply handling into the loopers (to reuse a common mutex)
Bug: 19607784
Change-Id: Iaa035b846c424c5687ed17ce1079b325e86c54be
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| fa8b4792228083a4c95e8bd1c28690d44bb48bd6 |
|
05-Mar-2015 |
Lajos Molnar <lajos@google.com> |
stagefright: remove AMessage methods using id()
Bug: 19607784
Change-Id: I4b2ca396fb50cde5e7dc9801add69037febe698d
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 5804a76ac5f9f3c311f1bbbcc5ebdc8f8568ae14 |
|
05-Mar-2015 |
Lajos Molnar <lajos@google.com> |
stagefright: use handler instead of handler-id in AMessage
This avoids locking gLooperRoster mutex on post() and deliver().
Bug: 19607784
Change-Id: If6d9d7884dbb08fc390983bda896d223803476ba
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| f09611f2f33752afc28141e1bbaa897651c05d6f |
|
13-Feb-2015 |
Marco Nelissen <marcone@google.com> |
Add dumpsys info
Print a list of looper-handler pairs and the number of messages
they've processed, and optionally break those stats out by
message type.
Change-Id: I68ce4a7003152d5c9b5cb3f42e6f3949b471aa6e
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 047dd13ca42ff7cea10821ef64eb09229fa3e751 |
|
28-Aug-2014 |
Marco Nelissen <marcone@google.com> |
Fix more potential deadlocks in ALooperRoster
Bug: 17059501
Change-Id: I242f2859527bed2d6e275c27de94fb19f4dcdc28
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 75c672fc376ef9b3ceff61a96513242b0e5ebd60 |
|
28-Aug-2014 |
Marco Nelissen <marcone@google.com> |
Fix potential deadlock in unregisterStaleHandlers()
The scenario is that a call to unregisterStaleHandlers() is in progress,
and is holding a temporary sp<ALooper> reference to an active ALooper inside
of the loop. At this point the only other remaining external reference to
the ALooper goes away, so the temporary sp<ALooper> in the loop is now
the only reference keeping that object alive. When the loop iterates and
the sp<> goes out of scope, the ALooper destructor is called, which in turn
calls unregisterStaleHandlers again, resulting in a recursive lock.
Bug: 17300093
Change-Id: I116f2ffab4ae7c43b6bcf54a367ae6f9d77c9626
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 30873bfd08255e2c4e98ff5732ffff2838772617 |
|
31-Jul-2013 |
Andreas Huber <andih@google.com> |
Unregister any handlers still registered on now "dead" ALoopers
upon the death of an ALooper.
Change-Id: I64c0835b8db04486204f3d0fa7173ee53708a116
related-to-bug: 10106648
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 0df36ec3303c2c6bf9b42c07945ac8bd234153f3 |
|
06-Feb-2013 |
Andreas Huber <andih@google.com> |
HLS now properly publishes its "seekable" flags after connection
has successfully completed and a sufficient amount of data fetched,
and only then signals that preparation is completed.
Change-Id: I7684a14238b826909f518f2af506966e522dfcfc
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 5ff1dd576bb93c45b44088a51544a18fc43ebf58 |
|
06-Jan-2012 |
Steve Block <steveblock@google.com> |
Rename (IF_)LOGW(_IF) to (IF_)ALOGW(_IF) DO NOT MERGE
See https://android-git.corp.google.com/g/157065
Bug: 5449033
Change-Id: I00a4b904f9449e6f93b7fd35eac28640d7929e69
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 5df775d2f509c76e76a46615fca83dba95299f6e |
|
26-Aug-2011 |
Andreas Huber <andih@google.com> |
Support for posting messages and synchronously waiting for a response.
Change-Id: Id6c7a08c34fd5cb6c4632f78ece9e7898b29e52c
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| f200777290d2e3e8b580c512cc0808eae9790705 |
|
19-Oct-2010 |
Andreas Huber <andih@google.com> |
An attempt to unregister a handler that's no longer registered should not cause an assertion.
There are edge cases in which a handler attempts to unregister itself while on another thread a message fails to be delivered to that very handler and causes automatic unregistration. In this case the handler's good cleanup intentions are thwarted by the CHECK.
Change-Id: I4e41b5e7b619159ecce4856c15cccca031a28b5b
related-to-bug: 3101247
QA-impact: no(!!!) risk
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 6e4c5c499999c04c2477b987f9e64f3ff2bf1a06 |
|
21-Sep-2010 |
Andreas Huber <andih@google.com> |
Remove stagefright foundation's incompatible logging interface and update callsites.
Change-Id: I45fba7d60530ea0f233ac3695a97306b6dc1795c
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 11cc270ac5fd522c9e6491a7933516a96da4f62e |
|
07-Jul-2010 |
Andreas Huber <andih@google.com> |
ALooperRoster no longer holds strong references to handlers and loopers.
Change-Id: I038d69b0a34eda1bfc5216d92c837a5ddf4fb802
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| e2b20987c2652a984d10520ef3542d50d91119c5 |
|
03-Jul-2010 |
Andreas Huber <andih@google.com> |
An AHandler can now find its associated ALooper.
Change-Id: Ic7087b8dcbc0d9abda272df0cb01b04b006f82ad
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|
| 72961230a5890071bcca436eb5630172ce84ec41 |
|
07-Jun-2010 |
Andreas Huber <andih@google.com> |
Initial checkin of "foundation" library for future stagefright development.
Change-Id: I11714dcaa647d0437a13e4c5b953b35e712da8f3
/frameworks/av/media/libstagefright/foundation/ALooperRoster.cpp
|