History log of /frameworks/base/libs/hwui/AnimatorManager.cpp
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
a483173c78fb453b73308a9b44ce54fb3878ed0e 11-Jan-2017 George Burgess IV <gbiv@google.com> Fix a use-of-uninitialized-value warning.

This warning was generated by the static analyzer:
warning: The left expression of the compound assignment is an
uninitialized value. The computed value will also be garbage
*mDirtyMask |= animator->dirtyMask();

This can be fixed by initializing dirtyMask before using it in
AnimateFunctor.

Bug: None
Test: Static analyzer no longer complains about this.
Change-Id: I892749079cf93a012f1bed059a3f0c8bbaed9d7e
/frameworks/base/libs/hwui/AnimatorManager.cpp
85e0c89ba55188ecc484538efbfdb570606fc1a2 28-Apr-2016 Chih-Hung Hsieh <chh@google.com> resolve merge conflicts of 1599b981 to nyc-dev-plus-aosp

Change-Id: I90807581e10b6a0024515ff634ac8b29eaa5fc9f
c6baf563ba6aa207a48317c177b29f1d2b70cf3d 27-Apr-2016 Chih-Hung Hsieh <chh@google.com> Fix google-explicit-constructor warnings.

Bug: 28341362
Change-Id: Ibdd6a210bb7ff228e3624cc319169f77aca3b51e
/frameworks/base/libs/hwui/AnimatorManager.cpp
9e066cbf59c3e7724eb6c6610ede5697835f65e6 29-Feb-2016 John Reck <jreck@google.com> Fix dirtyMask in AnimateFunctor

Bug: 27313379
Change-Id: I0c0cffe7e1940914f0143714643ede539b86216f
/frameworks/base/libs/hwui/AnimatorManager.cpp
8b083206aef627b6445a8c6be8bf5bb1d778a7f8 19-Feb-2016 Doris Liu <tianliu@google.com> Revert "Revert "Check RenderNode's owning view before attaching animators""

This reverts commit eb40178af3b7c8d925eaf6c1aa0bef739c8ea47e.

Change-Id: I6838ecb35b50847746ee66ac204f14eb5f579b91
/frameworks/base/libs/hwui/AnimatorManager.cpp
c4bb185d41cfb960ed9a3178a4f8974c351abdb0 19-Feb-2016 Doris Liu <tianliu@google.com> VectorDrawable native rendering - Step 5 of MANY

This is reverting the revert of what reverts the revert of the original
implementation. Fourth revert is a charm!

This reverts commit df7fdb1e0bdb5c289bbc08047e5c710185503309.

Change-Id: I6fc3a5accfd8b79c3da31bbc101ad9e9b4d6e7dd
/frameworks/base/libs/hwui/AnimatorManager.cpp
df7fdb1e0bdb5c289bbc08047e5c710185503309 18-Feb-2016 Doris Liu <tianliu@google.com> Revert "Revert "Revert "VectorDrawable native rendering - Step 5 of MANY"""

This reverts commit 0d20a275a5baf8579c8b9111cf2ce6615874a6b6.

Change-Id: I97c782f1164a5d39ab74dc098cca71d9e1b30cd8
/frameworks/base/libs/hwui/AnimatorManager.cpp
0d20a275a5baf8579c8b9111cf2ce6615874a6b6 11-Feb-2016 Doris Liu <tianliu@google.com> Revert "Revert "VectorDrawable native rendering - Step 5 of MANY""

This reverts commit e03ef25a3e44ef5d495e366c30b9b5b69fc58194.

Change-Id: I9c2e1c891667451a3ee668e414bf337ad67279ab
/frameworks/base/libs/hwui/AnimatorManager.cpp
e03ef25a3e44ef5d495e366c30b9b5b69fc58194 11-Feb-2016 John Reck <jreck@google.com> Revert "VectorDrawable native rendering - Step 5 of MANY"

Bug: 27136799

This reverts commit 18bdf443e371e9f293439b4ff92cc79abaa422e5.

Change-Id: I825b061eec2a591f2d18119ba64494624b9ad4f2
/frameworks/base/libs/hwui/AnimatorManager.cpp
18bdf443e371e9f293439b4ff92cc79abaa422e5 02-Feb-2016 Doris Liu <tianliu@google.com> VectorDrawable native rendering - Step 5 of MANY

Implemented reset() (public API for AVD)
and reverse() (internal API that needs to be supported)

Change-Id: Ife1650049f271cad1347943151a5800c40c20aa2
/frameworks/base/libs/hwui/AnimatorManager.cpp
d56554e82b591357cbb819859ddcc7b87ff7306b 04-Aug-2015 John Reck <jreck@google.com> am 906c8dea: am bc04d3ac: Merge "animateNoDamage failed to remove from current frame list"

* commit '906c8dea2ec6ae404ae6d7870c0a0cb2289f3d04':
animateNoDamage failed to remove from current frame list
68eb3b22b06477e5a229714f802cbc48e8486937 04-Aug-2015 Ye Ouyang <a5111c@motorola.com> animateNoDamage failed to remove from current frame list

runRemainingAnimations is used to animate the available animation handle
which were not yet run, it actually animate those animation handle and
removes from the list by notifyAnimationsRan(). In case if these animation
handles are not removed, it leads to the Fatal Assert of runRemainingAnimations.

Some usecases causes the addition of animation handle when there is
no animators, in these cases this check prevents execution of
notifyAnimationsRan() leads to Fatal Assert crash of runRemainingAnimations.

Allowing the animation to happen irrespective of animators solves the problem.

Change-Id: Ifa72286cdc6ff785fcc999f3b951dd787e7003e9
/frameworks/base/libs/hwui/AnimatorManager.cpp
2ccb5030c691849c1dfadf9c7136b7fc18acab9c 01-Jul-2015 Fred Fettinger <fettinge@motorola.com> animateNoDamage failed to remove from current frame list

runRemainingAnimations is used to animate the available animation handle
which were not yet run, it actually animate those animation handle and
removes from the list by notifyAnimationsRan(). In case if these animation
handles are not removed, it leads to the Fatal Assert of runRemainingAnimations.

Some usecases causes the addition of animation handle when there is
no animators, in these cases this check prevents execution of
notifyAnimationsRan() leads to Fatal Assert crash of runRemainingAnimations.

Allowing the animation to happen irrespective of animators solves the problem

Change-Id: I685dc7ebf736268927a536595910fc63353306eb
Signed-off-by: Parasuraman <parasur@motorola.com>
Signed-off-by: Fred Fettinger <fettinge@motorola.com>
/frameworks/base/libs/hwui/AnimatorManager.cpp
49dec430e8a38943c5e934c1e31b724bf53c47c4 24-Jul-2015 John Reck <jreck@google.com> Move updateMatrix() call to animateCommon

Bug: 22667315

HWUI internally always assumes that RenderNode->properties()
has a fully-baked matrix. However, RenderThread animations violate
this and will perform an update of that matrix after they run. This
was missing in the fallback scenario where an animation was
running on a View that is detached from the tree.

If a RenderThread animation is started on an attached view, it becomes
detached, and is then re-attached it will crash in the staging
properties push. The fix for this is to move the call to updateMatrix
from animate() to animateCommon() so that the animateNoDamage()
path will similarly perform the necessary matrix update.

Change-Id: I4c899a6f68659342a6515f1d7f20d3c4af65caf0
/frameworks/base/libs/hwui/AnimatorManager.cpp
d41c4d8c732095ae99c955b6b82f7306633004b1 06-Jan-2015 Chris Craik <ccraik@google.com> Add overrides and switch to nullptr keyword for all files

Adds remaining missing overrides and nullptr usages, missed due to
an extreme failure in tool usage.

Change-Id: I56abd72975a3999ad13330003c348db40f59aebf
/frameworks/base/libs/hwui/AnimatorManager.cpp
2dc236b2bae13b9a0ed9b3f7320502aecd7983b3 15-Oct-2014 Tom Hudson <tomhudson@google.com> Clean up physical coupling

Narrow the use of #include directives in hwui, replacing with forward
declarations where straightforward. Speeds compiles; doesn't do any
restructuring of code.

Change-Id: Icac2baffb5896f55d8c6718e9bd9d4bfa02d3ca0
/frameworks/base/libs/hwui/AnimatorManager.cpp
f5945a0c8bb868f978d9d0d22043a8b44464a86e 06-Sep-2014 John Reck <jreck@google.com> Disable RT-anim for AnimatorSet

Bug: 17317184

Unfortunately this will disable *all* RT animations in a scene,
but we don't have more selective targetting currently

Change-Id: I57e1c0ae43957f45229473bdcdaf34c05825fab7
/frameworks/base/libs/hwui/AnimatorManager.cpp
e2478d45ccbe5b6abb360ac9d44771b5f4a50bde 04-Sep-2014 John Reck <jreck@google.com> Fix some wrong-thread issues around animator management

Bug: 17372309

Fixes a case where UI thread and RT thread both used the same method
which wasn't safe for either of them.

Adds additional assertions & logging in unusual circumstances to
try and track down where the issue is occuring from.

Change-Id: I93d31a6fd0c5927259b67bdf96a475944226eee6
/frameworks/base/libs/hwui/AnimatorManager.cpp
d0cd9db31639b246587fe494ec15d32d9fdb3dc7 28-Aug-2014 John Reck <jreck@google.com> Actually end animators on tree destruction

Bug: 17313962

Change-Id: I66b86d50b415f9aa33da23297f22e2cf7f96f565
/frameworks/base/libs/hwui/AnimatorManager.cpp
119907cd2575c56b1ebf66348b52e67aaf6a88d8 14-Aug-2014 John Reck <jreck@google.com> Animator stuff

Bug: 17228458

Change-Id: Id884a429a512f9cd2be0ed16dbd0f10e92b4440d
/frameworks/base/libs/hwui/AnimatorManager.cpp
a7c2ea20c43ab797bef5801530687e22e83def8f 08-Aug-2014 John Reck <jreck@google.com> Fix damage for layers for projection receivers

Bug: 16880228

Change-Id: I59ab760a21f49cc2cac0d8936b173cff292e6114
/frameworks/base/libs/hwui/AnimatorManager.cpp
8d8af3c1b768d590754d657a7d1242dcb462454b 02-Jul-2014 John Reck <jreck@google.com> Fixes to startDelay

Bug: 15991758

Don't update the UI thread with final value until after
startDelay

Change-Id: Ie8bffb5a3ace353ec1d82943a4efcbd01c42c28f
/frameworks/base/libs/hwui/AnimatorManager.cpp
68bfe0a37a0dcef52abd81688d8520c5d16e1a85 25-Jun-2014 John Reck <jreck@google.com> Animator refactoring & fixes

Tweaks animators to have less unnecessary refcounting

Pull animator management out into seperate class

More control to tweak animator lifecycle, such as doing
Java-side handling of start delay by attaching but not
starting the animator

Change-Id: I4ff8207580ca11fb38f45ef0007b406e0097281c
/frameworks/base/libs/hwui/AnimatorManager.cpp