| 05ff98bbefda39b9ff26f8bca132cfd0248745c6 |
|
14-Jul-2009 |
Tao Liejun <L.J.Tao@motorola.com> |
Fix minor obex bugs and re-format the comments
re-format comments
move connectible to connectable
remove unnecessary throws
remove not-used function ClientOperation.readResponse()
fix client abort case for PUT
set mOpen for PrivateOutputStream
add to platform.xml
/frameworks/base/obex/javax/obex/PrivateInputStream.java
|
| 3998bf009acaf8cde4d7f837f8b8e41ae0a65141 |
|
02-Jul-2009 |
Tao Liejun <a19884@motorola.com> |
Obex library cleanup, third pass
- Change variable namings
- Remove interface public modifier
- Move 2 duplicate methods to ObexSession
- Removed unused code and variables
- Use static variables for some protocol defines
/frameworks/base/obex/javax/obex/PrivateInputStream.java
|
| 41557e18fa3fc5791a5a1c7f0051ae3385608bc4 |
|
01-Jul-2009 |
Nick Pelly <npelly@google.com> |
Obex library cleanup, second pass.
o Use mMemberField variable naming as per style guide
o ClientSession.trans is only used in the ctor, doesn't need to be a member
o Rename connectionOpen to mOpen and isConnected to mObexConnected to reduce
confusion
o Refactor duplicated code into helper functions (setRequestActive())
o Fix whitespace around comment blocks
o Change unnecessary public scope's to package private (eg setRequestInactive())
o Remove a redundant factory method ClientSession.createHeaderSet()
o Rename OPTIMIZATION to TODO to match Android style
o Rename java.io.IOException to IOException
o Be consistent with variable naming - use header not headers
/frameworks/base/obex/javax/obex/PrivateInputStream.java
|
| 2e0da96e757a977154063f980d3f4e1abd41cf09 |
|
01-Jul-2009 |
Nick Pelly <npelly@google.com> |
Obex library cleanup, first pass.
o Add Android.mk file.
o Add @hide so it is not exposed in the public API. It is not yet in shape.
o Prefer @throws to @exception
o Do not use @version. This is meaningless in Android.
o Prefer classes 'final' unless explicitly allowing inheritance
(See "Effective Java" item 15)
o Prefer CamelCaps java naming even for acronyms (OBEXHelper -> ObexHelper)
o Use the built-in MD5 library.
o Move ObexConstants into ObexHelper.
o Remove unused variables.
o Prefer stricter access priveleges. Most importantly, avoid public fields.
o Don't use 'import java.io.*'. Name each class explicitly.
o Delete commented out code. If its not used then remove it.
/frameworks/base/obex/javax/obex/PrivateInputStream.java
|
| 9439a7fe517b858bc5e5c654b459315e4722feb2 |
|
30-Jun-2009 |
Nick Pelly <npelly@google.com> |
Add javax.obex library, contributed by Motorola.
Based of a JSR-82 reference implementation.
This check-in is 'as-is' from the source provided June 25.
This code does not conform to Android style and quality guidelines. I will be
working with Motorola to improve it. If it does not see substantial improvement
in the Eclair timeframe it will be deleted.
/frameworks/base/obex/javax/obex/PrivateInputStream.java
|