| 2c3ccaedaf54dfde879470753f3db61bc3e7c7d3 |
|
01-Feb-2017 |
George Burgess IV <gbiv@google.com> |
Fix a use-of-uninitialized-value warning
Caught by clang's static analyzer:
frameworks/base/core/jni/com_google_android_gles_jni_GLImpl.cpp:190:30:
warning: The right operand of '+' is a garbage value
buf = (char*)buf + offset;
This is because getPointer doesn't always set `offset` to a value. We
could fix it locally by initializing `offset`, but it seems to be less
error-prone to just fix getPointer instead.
Bug: None
Test: Still builds; warning is now gone.
Change-Id: I90bea0c94cf8d7f92a0d9a4db4e64e7e563bfb09
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| b5da0d78d2fde6abbfd387db4a3b218a5c301c20 |
|
11-Nov-2014 |
Andreas Gampe <agampe@google.com> |
Frameworks/native: Add pragmas to glgen headers
The code currently being generated by glgen is not the cleanest, but
we would like to get core/jni onto -Werror. Thus add pragmas turning
off warnings locally to the C headers.
Also fix signed-comparison in two functions.
Longer term TODO: Emit clean code.
Change-Id: Iee8582f8c0c1de076d64851d3b6ca467afd5bc43
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| d8f096114da14f9793d4cca6022ca41b70ab9daa |
|
15-Feb-2014 |
Ashok Bhat <ashok.bhat@arm.com> |
Use reinterpret_cast when an integer is cast to a pointer
Change-Id: I5adcd59f58c029f7b2b596f4826d8ea69fb9bba6
Signed-off-by: Ashok Bhat <ashok.bhat@arm.com>
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| fb913cdb47d5abfac55d6394084932fff597c8c5 |
|
13-Feb-2014 |
Ashok Bhat <ashok.bhat@arm.com> |
Update GLES codegen to be in sync with frameworks/base
Patch from synergydev with commit-id 01994c79 changed
core/jni/com_google_android_gles_jni_GLImpl.cpp in the
frameworks/base. However the corresponding code snippet
in frameworks/native was not updated. This patch addresses
the issue.
Change-Id: I89c3d88de832efc8cbbe682c8a7ff7dfbef99db3
Signed-off-by: Ashok Bhat <ashok.bhat@arm.com>
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| e58a97b5d77b59fad1572ba3c0572c7434e8e503 |
|
12-Jul-2012 |
Thomas Tafertshofer <tafertth@google.com> |
OpenGL bindings fix for methods with iobuffer args
This changes generation of the OpenGL bindings to prevent
crashes of methods with more then one nio buffer argument.
Bug: 6772416
Change-Id: I4eff25c2f568dea78a6ffd3e95ff4620ab4b3b7d
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| 9875750593aae7c2a62f33c620809d49162393eb |
|
09-Apr-2011 |
Elliott Hughes <enh@google.com> |
Kill the global references in the OpenGL wrappers.
Just use jniThrowException instead. Note that it would be trivial to throw
seemingly more appropriate exceptions (NullPointerException and
OutOfMemoryException in particular), but I'm only attempting to preserve
existing behavior here.
I also found shadowing bugs in some of the special-case functions, which
would previously always have leaked memory.
This also moves an accidental change to a generated file (ActivityThread ->
AppGlobals) into the generator, so it won't be overwritten in future.
Change-Id: Iab570310b568cb406c60dd0e2b8211f8a36ae590
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| e44e45c454a1f6ab89bce338d4ef12471549a7a2 |
|
28-Jan-2010 |
Jack Palevich <jackpal@google.com> |
Implement the GL11ExtensionPack APIs.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| 66089a33ea4efda711a3a5180f0b001bdac48dcf |
|
08-Dec-2009 |
Jack Palevich <jackpal@google.com> |
Implement Matrix Palette extension.
Adds support for formerly-unimplemented methods:
glCurrentPaletteMatrixOES
glLoadPaletteFromModelViewMatrixOES
glMatrixIndexPointerOES
glWeightPointerOES
The bulk of the changes are related to implementing the two PointerOES
methods, which are implemented pretty much the same way as the existing
Pointer methods were implemented.
This change also changes the way glPointSizePointerOES is implemented,
making it act like all the other Pointer methods. (Previously it was
not handling non-direct-buffer arguments correctly.)
Fixes bug 2308625 "Support matrix palette skinning
in JSR239 and related APIs"
Also updated GLLogWraper to fix two bugs in GLLogWrapper that were
discovered while testing matrix palette skinning support:
a) Handle trying to print the contents of null-but-enabled buffers.
(It's not legal to draw with null-but-enabled buffers, and
in fact some OpenGL drivers will crash if you try to render in this
state, but there's no reason the GLLogWrapper should crash while trying
to debug this situation.
b) Don't read off the end of a vertex buffer with non-zero position when
printing the entire contents of the vertex buffer. Now we only print from
the current position to the end of the buffer.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| c96812cb27ca2fbfe4456c8297e2c77d23d790f1 |
|
16-Jun-2009 |
Jack Palevich <jackpal@google.com> |
Allow pre-Donut apps to use indirect Buffers in GL11 Pointer methods.
Apps targeting Donut and newer will throw an exception.
We use a heuristic to determine whether an app is pre-Donut or not:
We take the address space's __progname, and use that as the application's
package name. For simple applications this is correct.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| 6eedc8d3b598163f797a2f75d05fdc20809a4364 |
|
16-May-2009 |
Jack Palevich <jackpal@google.com> |
Fix bug 1856713 gl Pointer functions should use Buffer position
JSR239 and android.opengl gl Pointer functions (glColorPointer, etc.)
now respect the current setting of the Buffer position.
This fixes a regression introduced when we started requiring the
Buffers passed to the Pointer functions to be direct Buffers.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| d373c6348a91595dd4c0b83ad256dbf30870fa5d |
|
09-May-2009 |
Mathias Agopian <mathias@google.com> |
remove the gl{Vertex|Color|TexCoord|Normal}PointerBounds() "extension" fro eglext.h
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| 593f203ba3df251b238409bb3fcc66b0a90b856d |
|
07-May-2009 |
Jack Palevich <jackpal@google.com> |
Fix automatically generated code for glGet
Remove include of an internal agl header file. We should not depend on any implementation details
of our software renderer, since they may not be correct if another renderer is used.
Fix glGet number-of-elements logic for GL_FOG_COLOR GL_LIGHT_MODEL_AMBIENT,
and GL_COMPRESSED_TEXTURE_FORMATS.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|
| 427f585f726af6e3bd1fb835f26b2af9f609c483 |
|
16-Apr-2009 |
Jack Palevich <jackpal@google.com> |
Add an Android-specific static OpenGL ES 1.1 Java API.
This change adds four new public classes that expose a static OpenGL ES 1.1 API:
android.opengl.GLES10
android.opengl.GLES10Ext
android.opengl.GLES11
android.opengl.GLES11Ext
Benefits:
+ The static API is slightly faster (1% to 4%) than the existing Interface based JSR239 API.
+ The static API is similar to the C API, which should make it easier to import C-based
example code.
+ The static API provides a clear path for adding new OpenGL ES 1.1 extensions
and OpenGL ES 2.0 APIs, neither of which currently have a JSR standard.
Example:
import static android.opengl.GLES10.*;
...
glClear(GL_COLOR_BUFFER_BIT | GL_DEPTH_BUFFER_BIT);
Note that it is possible to mix-and-match calls to both the static and JSR239 APIs.
This works because neither API maintains state. They both call through to the same underlying
C OpenGL ES APIs.
Implementation details:
This change enhances the "glgen" "gen" script to generate both the original JSR239 and
new static OpenGL ES APIs. The contents of the generated JSR239 classes remained the same as before,
so there is no need to check in new versions of the generated JSR239 classes.
As part of this work the gen script was updated to be somewhat more robust, and to
work with git instead of perforce. The script prints out commands to git add the generated files,
but leaves it up to the script runner to actually execute those commands.
/frameworks/native/opengl/tools/glgen/stubs/jsr239/GLCHeader.cpp
|