History log of /frameworks/rs/rsCppUtils.h
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
82e135c4bbe18855d8ed02632bb074f8da0b96e0 28-Feb-2017 Miao Wang <miaowang@google.com> Remove libutils.so dependency from libRSDriver, libRSCpuRef, and most
parts of libRS_internal.

NOTE: we're resolving dependencies to provide a model for vendors.
For us, all this code is above the HAL, thus the dependencies
are acceptable; whereas for vendors, their equivalent of this code is
below the HAL, and so the dependencies are not acceptable.

This CL resolves the libutils dependency by:
- Implement the timings functions in android::renderscript namespace
using NDK APIs, instead of using libutils counterparts.
- Replace android::Vector and android::String8 by std::vector and
std::string.
- PROPERTY_VALUE_MAX is replaced as PROP_VALUE_MAX.

This CL didn't resolve the libutils dependency of rsFont.cpp and
rsDebugger.cpp in libRS_internal:
The dependent functionality in rsDebugHelper.h is off by default, and
only intended for use during development; and rsFont.cpp is part of
graphics API which is not implemented below the HAL and is not used as
a model by vendors.

Additionally, this CL fixed the bug that mNodes was sorted in a
decreasing order. Nodes in ScriptGroup should be executed in
ascending order. The bad sort was only for support lib; so there was a
previously-unknown bug in support lib implementation of ScriptGroup.

Background:
libutils contains a collection of things like Vector, String8,
CallStack. It served the purpose similar to a STL library, when there
was no stable STL implementation available in Android. And most
importantly, it is not part of NDK.
Support lib used to use our own implementations of android::Vector and
android::String8, because it can only depend on NDK, similarly for the
timing related functions.
As part of the Treble requirements, native RS, including vendor version
libRS_internal, libRSDriver, libRSCpuRef could only depend on NDK
too. So we need to break the dependency on libutils. And since we now
have reasonable support of STLs, we should use that instead.

Bug: 34396220
Test: mm, and all CTS tests pass on Bullhead;
RsTest and RSTest_CompatLib (both native and compat path) also pass.
Change-Id: Ib9a37d16235c1dcd0f5bae3b95c374e394483c91
/frameworks/rs/rsCppUtils.h
2a61168a777ee434ce2c28945aa74f6a6bcf2820 28-Feb-2017 Miao Wang <miaowang@google.com> Remove libcutils dependency.

- Implement property_get using __system_property_get, remove
dependencies on cutils/properties.h.
- remove rsCompatibilityLib.cpp since it only contains propery_get, and
it is now in rsCppUtils.cpp.
- Disable ATRACE. The systrace is current done in Java level. If we
want to do it in the driver, we need to have our own implementation
similar to native/utils/trace.cc
- Remove CC_LIKELY macro.

Bug: 34396220
Test: build

Change-Id: I6a6cbcfb2ca15b9d1f09b9ce0579d39fdbe98727
/frameworks/rs/rsCppUtils.h
62237219e567b9f972c86e7ca4e96f9b3d5ad4de 28-Feb-2017 Miao Wang <miaowang@google.com> Remove RS_SERVER macros and references to unused headers.

- The RS_SERVER macros were intended to have a version of RenderScript
running on the desktop. It has not fully worked for a very long time.

Bug: 35473587
Test: build and CTS tests pass
Change-Id: I0da3fc9d4601951442384d05f9dbecaeddeff8cc
/frameworks/rs/rsCppUtils.h
7974fc03e11f3a8dd40f794f3b33b4889483090c 09-Feb-2017 Rahul Chaudhry <rahulchaudhry@google.com> frameworks/rs: fix typos and clang-tidy warnings

This change fixes a few typos and clang tidy warnings related to the
"llvm-namespace-comment" checks.

Bug: 26936282
Test: WITH_TIDY=1 WITH_TIDY_CHECKS="llvm-namespace-comment" mm
Change-Id: Ic65182e5b4999fbd48d6a8ad7172e4bfeeb541f4
/frameworks/rs/rsCppUtils.h
6e493616d2db02116cfed134b741fb4d50b80e68 09-Jan-2017 Mark Salyzyn <salyzyn@google.com> log: android/log.h defines main logging macros

Add ifdefs surrounding the compatibility set here.

Test: compile
Bug: 30465923
Change-Id: I7d528aa36300a75127c59c950af8727ea0f99fe1
/frameworks/rs/rsCppUtils.h
10ab8bb0fa510bdb577adce5e67b6bf35882a9dd 01-Jul-2016 Chih-Hung Hsieh <chh@google.com> Fix google-explicit-constructor warnings in frameworks/rs.

* Declare explicit conversion constructors.
* Add NOLINT to implicit conversion constructors.

Bug: 28341362
Test: build with clang-tidy

Change-Id: If5114de668c1c8946b8fca9cee4b2b14f95be5f1
/frameworks/rs/rsCppUtils.h
abb806debab6777934716315b930765c7059b324 20-Feb-2016 Miao Wang <miaowang@google.com> Use c++_static instead of stlport_static for support lib.

Bug: 27230989

- Clean up the makefile
- For NDK libs, use c++_static
- Avoid exposing symbols for C++ lib
- Use nullptr instead of NULL

Change-Id: I60cf11cb6a6044584a3e484979da231f72772f86
(cherry picked from commit 5abfd9b62b3173a371c42fc92ca8cf978420d694)
/frameworks/rs/rsCppUtils.h
d614fe9de2415a94bdfc550ee0c03671e378f115 29-Jul-2015 Elliott Hughes <enh@google.com> Move frameworks/rs off AndroidConfig.h.

Change-Id: I7d4801754bb60209f177f9cf4a3ea7c98a90dee3
/frameworks/rs/rsCppUtils.h
bc10dff26207bb8c02051b28326bb134a8f28eb3 04-Apr-2015 Miao Wang <miaowang@google.com> remove STL from rs C++ public interface. Nuke stlport.

Change-Id: Ida273c1cfa21c4db51ae41a4c42746d9d828f292
/frameworks/rs/rsCppUtils.h
2fa8a238dd69afebdeb757adcb1d674043d78e32 26-Mar-2015 Pirama Arumuga Nainar <pirama@google.com> Wrap TEMP_FAILURE_RETRY around system calls

BUG 19934827

Wrap TEMP_FAILURE_RETRY around system calls that can return EINTR
(waitpid, close).

Refactor fork/exec flows in various places into a utility function
and log errors so we can better understand failures in the test server.

Fix a small use-after-free issue in ScriptGroups.

Change-Id: I60b192f83c395a13c27cd6bd2289c44132b84791
/frameworks/rs/rsCppUtils.h
2abfcc6d129fe3defddef4540aa95cc445c03a7a 18-Feb-2015 Yang Ni <yangni@google.com> Moved class ScriptExecutable to its own module

b/19283946

This move also included the related class SharedObjectUtils.

Change-Id: Iefd587b659c4ad99340c330955b41cd92df45563
/frameworks/rs/rsCppUtils.h
b8353c5943f4038fd7f08db3d958390ce9418798 15-Feb-2015 Yang Ni <yangni@google.com> Revert "Replaced android::Vector with std::vector."

b/19148482

This reverts commit 93d6bc872b7d9fba63abfa7513d56b38d9c3d371.

I also made some changes to Make it work with HEAD.

Change-Id: I5e516976ec1d85ffe1cf388c01795348a9441982
/frameworks/rs/rsCppUtils.h
c04fc654149afa4ec8ba78e23787d3e148adbe2a 10-Jan-2015 Elliott Hughes <enh@google.com> Don't use HAVE_POSIX_CLOCKS.

I'm not sure whether it's a bug that this array doesn't contain all the POSIX
clocks. There's also a (different) copy of this function in system/core. But
today I'm just trying to kill HAVE_POSIX_CLOCKS.

Change-Id: Iff6a10b1e7a9d5e9c76b796c5aa75b7d7b6546b5
/frameworks/rs/rsCppUtils.h
44bef6fba6244292b751387f3d6c31cca96c28ad 12-Aug-2014 Chris Wailes <chriswailes@google.com> Replace NULL macros with nullptr literals.

Change-Id: I918c40879aa547438f77e7d1a95fa2aa33bec398
/frameworks/rs/rsCppUtils.h
6847e73314e13aa02231268cca245a81eb0539ca 12-Aug-2014 Chris Wailes <chriswailes@google.com> Replace android::String8 with std::string

Change-Id: I5b2b6d3e38afd0b040f0a584613745206bf01ba0
/frameworks/rs/rsCppUtils.h
93d6bc872b7d9fba63abfa7513d56b38d9c3d371 29-Jul-2014 Chris Wailes <chriswailes@google.com> Replaced android::Vector with std::vector.

Change-Id: I4c6abd964dc4b1412ec2e592fc8e835fecfe53f6
/frameworks/rs/rsCppUtils.h
5e37175676a1089fc7c40ac8b705799dccabcc30 16-Aug-2013 Stephen Hines <srhines@google.com> am fd47ac29: am 43cfc0cb: Remove barriers to using NDK v8 includes.

* commit 'fd47ac29478ed01a581b3326d898ad848858a314':
Remove barriers to using NDK v8 includes.
43cfc0cbe6e6e8f585a0ae5f1d9cc2859ab1dda7 15-Aug-2013 Stephen Hines <srhines@google.com> Remove barriers to using NDK v8 includes.

Bug: 10315692

Removed CLOCK_BOOTTIME, added some additional guards around cutils includes,
and explicitly included errno.h when we use ETIMEDOUT.

Change-Id: I0a764beea2f8ff7387a9afe985f00b5f03c68725
/frameworks/rs/rsCppUtils.h
140a7acade66ab5d1f3dc55803a3a65a71f3f86c 11-Jul-2013 Stephen Hines <srhines@google.com> resolved conflicts for merge of 5376c9bf to master

Change-Id: I51507da10f8d7116a2aa29446a00a43d397a37c8
b0934b67b95cc27e2358c2aa4db5f7c1067c8f9b 04-Jul-2013 Stephen Hines <srhines@google.com> Remove libutils and fix rsDebug for RS support library.

Bug: 9664050

Our bitcode runtime library translates vector rsDebug() calls into passing
their parameters via pointers. The previous version of libRSSupport.so was
being created with non-pointer versions of these routines accidentally.
This change also fixes a missing permission issue for ImageProcessing2, so
that the compatibility library can be verified.

This change also removes the use of libutils by switching the implementation of
String8/Vector in the compatibility library to internal types backed by
libstlport_static.

Change-Id: I20da75e8c19a82a42dc2bceaba1937d21372db84
/frameworks/rs/rsCppUtils.h
f313dc32d5ea68a7c48fb4ec6e131ec2fb97ce2d 09-Jul-2013 Jason Sams <jsams@google.com> Remove internal element builder and vector code.

Remove additional String8 references from shared includes.

Change-Id: Iede11384b9fc5a303d15d47fd4074c800dc6ad5f
/frameworks/rs/rsCppUtils.h
fa85e9143c6f6a227c67bab5f08ff86194abdf2a 23-May-2013 Tim Murray <timmurray@google.com> Enable very basic tracing support.

Change-Id: I524a857390e0bbc49273989caf56f03b51de65cf
/frameworks/rs/rsCppUtils.h
f9e077a531c6a83e978d55f427b5d8ff6d2c943f 21-Mar-2013 Jason Sams <jsams@google.com> Fix logging defined in external header.

Change-Id: I40cc2696b99350b52ac1904b05485db2f567b4ef
/frameworks/rs/rsCppUtils.h