| 700e68883c4324c15b380ff6724249f39d4f498c |
|
06-Mar-2017 |
I-Jui (Ray) Sung <ijsung@google.com> |
Rename unused fields of RS base object handle in 64-bits
Fields other than the first one (p) in RS_BASE_OBJECT are set in some
part of existing RS runtime, but is not used at all. However, removing
them is not desirable as size of RS_BASE_OBJECT is really part of the
ABI and thus if we change it, we are creating a new ABI variant here,
which is not always desirable.
For example, consider a library that contains compiled scripts and
assuming we pass allocation handles between the library and other
user codes, changes to handle size only in user code would break the
compatibility on things like array of rs_allocations.
Thus, to keep ABI compatibility the unused fields r, v1, v2 are renamed.
Also they are now assigned zero consistently. These field however are
not copied consistently in the current runtime, and are not expected
so anyways.
Bug: 35043722
Test: mm, CTS and RSTest on Angler
Change-Id: I426fad8e07bf445b6d8625bd23c689acaee26322
/frameworks/rs/rsov/driver/rsovRuntimeStubs.cpp
|