| 4d947fe6771c1e15e91b19262948b119322028ba |
14-Sep-2016 |
Treehugger Robot <treehugger-gerrit@google.com> |
Merge "Fix clang-tidy warnings in wilhelm."
|
| 9bf773df2b8a0cf788f394c326960bc3a5af7c60 |
11-Aug-2016 |
Chih-Hung Hsieh <chh@google.com> |
Fix clang-tidy warnings in wilhelm.
* Add explicit keyword to conversion constructors.
Bug: 28341362
* Use const reference type for read-only parameters.
Bug: 30407689
Test: build with WITH_TIDY=1
Change-Id: Ib37e6760ba21f92bd03e0f7400e54e28817a89b5
acAdtsExtractor.h
|
| 2cf0a2ee3672659f922bf0df4368b5a49148c5ff |
23-Sep-2015 |
Marco Nelissen <marcone@google.com> |
Extractors are now binderized
Change-Id: I492439d7ec4b007009ea43e5c52b111cf1346154
acAdtsExtractor.h
|
| 5f12770df2875b280acaf6a0de08ae0b57c930cf |
08-Feb-2012 |
James Dong <jdong@google.com> |
Move away from MediaDebug and use ADebug instead
Change-Id: Ic448bdd6462708779f0e5c78a25e0a359b129654
acAdtsExtractor.h
|
| 70e6a0238597223221a8bf5e506c92acf28aa35f |
29-Sep-2011 |
Glenn Kasten <gkasten@google.com> |
Simplify code for the AAC decode use case
Details:
AacBqToPcmCbRenderer constructor
now takes an additional parameter: the IAndroidBufferQueue * interface.
So now there is no need to register a callback after construction,
and AacBqToPcmCbRenderer::registerSourceQueueCallback
can be deleted.
This allows android_audioPlayer_androidBufferQueue_registerCallback_l
to be deleted.
AacBqToPcmCbRenderer::mBqSource is always non-NULL and const, so this
allows removal of mBqSourceLock and some error-checking code.
BufferQueueSource source constructor now takes the IAndroidBufferQueue *
interface instead of the list [user, context, caller].
This allows mAndroidBufferQueueSource to be const, which then allows
more code to be deleted in IAndroidBufferQueue_RegisterCallback.
new AacAdtsExtractor can't fail.
Change-Id: I1f39ccc1e69833fe6df616feb76edbe4ce82fca7
acBqToPcmCbRenderer.h
|
| 167a2af67dcc0d20e6e3e995a23a0567715e0ee1 |
07-Oct-2011 |
Glenn Kasten <gkasten@google.com> |
AudioPlayback_Parameters cleanup
Use AudioPlayback_Parameters more consistently in parameter list of
constructors. Also, StreamPlayer::StreamPlayer was over-assigning to
mPlaybackParams (already assigned by its superclass's constructor).
Move initialization of AudioPlayback_Parameters from each case
to before the switch, as it is shared by each use case.
Remove old asserts.
Change-Id: I8925d36da031c80308457c7e940418d3a4e47b62
acBqToPcmCbRenderer.h
|
| 677c76347d9aaca4cf3746b3dbfc8a741281066b |
24-Aug-2011 |
Glenn Kasten <gkasten@google.com> |
Bug 5217144 AndroidBufferQueue::Enqueue error chks
Add more error checks to Enqueue:
- check for a NULL data pointer with non-zero data size
- check for a NULL item array with non-zero item array size
For the Enqueue item processing:
- examine all items if there is more than one in the array
- check for invalid combinations of items
- check that total length of item array is large enough for each
item's header and any optional data
- check for an EOS with a non-empty item data
- log if an unknown item key is found
- added the EOS item handling code for AAC ADTS
(the underlying implementation is still not yet done).
Fix copy/paste typo in initializeAndroidBufferQueueMembers.
AacBqToPcmCbRenderer::validateBufferStartEndOnFrameBoundaries:
- now returns a more specific result code rather than bool
- readAt return type ssize_t not size_t
- readAt return 0 (EOS) is a LOGV not LOGE.
Fix race in Android buffer queue callback: replaced logic in
BufferQueueSource.cpp by safer code from android_StreamPlayer.cpp
Change-Id: I423ccbd6d76a736a486b49b5dfdb7898b52cdd02
acBqToPcmCbRenderer.h
|
| bb832e853d4afb11b0a3287b2eb0cad87696d631 |
27-Jul-2011 |
Jean-Michel Trivi <jmtrivi@google.com> |
AAC buffer decode to PCM buffer queue
Implement AAC ADTS decode with buffers of compressed data being
passed to the framework through an AndroidBufferQueue, and
decoded PCM buffers being passed to the application through
a BufferQueue (just like existing decode from URI/FD).
Change-Id: Id992a44a5ca7e404088b929f2b0afe9ca1f85223
acAdtsExtractor.h
acBqToPcmCbRenderer.h
|