GrNonAAFillRectOp.cpp revision 3de0aee181b8fe0013b15100cba7381eb0468db4
19c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt/* 29c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt * Copyright 2015 Google Inc. 39c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt * 49c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt * Use of this source code is governed by a BSD-style license that can be 59c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt * found in the LICENSE file. 69c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt */ 79c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 86a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon#include "GrNonAAFillRectOp.h" 99c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 109c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt#include "GrColor.h" 119c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt#include "GrDefaultGeoProcFactory.h" 12dad2923b8ec9270d810c1e8e76da8e6768d8f9ddBrian Salomon#include "GrMeshDrawOp.h" 13742e31de1599f3902810aecdf2e2e3eed3b40a09Brian Salomon#include "GrOpFlushState.h" 149c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt#include "GrPrimitiveProcessor.h" 15ae5b2c623b22b24ea7c0d6200298e5bc366faa63joshualitt#include "GrQuad.h" 16dad2923b8ec9270d810c1e8e76da8e6768d8f9ddBrian Salomon#include "GrResourceProvider.h" 179c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 18a39667c848146d9070e1a45662fb292d8e6bb8fbreed#include "SkMatrixPriv.h" 19a39667c848146d9070e1a45662fb292d8e6bb8fbreed 2008d141534cb24a491edbf5db31cdc7b966ec8d72bsalomonstatic const int kVertsPerInstance = 4; 2108d141534cb24a491edbf5db31cdc7b966ec8d72bsalomonstatic const int kIndicesPerInstance = 6; 222244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 2353e4c3c0da40b58638d05e0f753ab6d450b961f5Brian Salomon/** We always use per-vertex colors so that rects can be combined across color changes. Sometimes 242244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt we have explicit local coords and sometimes not. We *could* always provide explicit local 252244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt coords and just duplicate the positions when the caller hasn't provided a local coord rect, 262244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt but we haven't seen a use case which frequently switches between local rect and no local 272244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt rect draws. 282244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 292244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt The vertex attrib order is always pos, color, [local coords]. 302244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt */ 318c852be264d003b2e610c5b8634bc0f81c46bbbaBrian Salomonstatic sk_sp<GrGeometryProcessor> make_gp() { 326abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips using namespace GrDefaultGeoProcFactory; 333de0aee181b8fe0013b15100cba7381eb0468db4Brian Salomon return GrDefaultGeoProcFactory::Make(Color::kPremulGrColorAttribute_Type, Coverage::kSolid_Type, 348c852be264d003b2e610c5b8634bc0f81c46bbbaBrian Salomon LocalCoords::kHasExplicit_Type, SkMatrix::I()); 356abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips} 366abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips 372244c27ea4db85df305fa09f664b7d75f637e7a9joshualittstatic void tesselate(intptr_t vertices, 382244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt size_t vertexStride, 392244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt GrColor color, 406abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips const SkMatrix* viewMatrix, 412244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt const SkRect& rect, 428cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt const GrQuad* localQuad) { 432244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt SkPoint* positions = reinterpret_cast<SkPoint*>(vertices); 442244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 456a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon positions->setRectFan(rect.fLeft, rect.fTop, rect.fRight, rect.fBottom, vertexStride); 469c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 476abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips if (viewMatrix) { 48a39667c848146d9070e1a45662fb292d8e6bb8fbreed SkMatrixPriv::MapPointsWithStride(*viewMatrix, positions, vertexStride, kVertsPerInstance); 498cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt } 508cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt 518cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt // Setup local coords 522244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt // TODO we should only do this if local coords are being read 538cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt if (localQuad) { 542244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt static const int kLocalOffset = sizeof(SkPoint) + sizeof(GrColor); 5508d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon for (int i = 0; i < kVertsPerInstance; i++) { 566a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon SkPoint* coords = 576a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon reinterpret_cast<SkPoint*>(vertices + kLocalOffset + i * vertexStride); 588cce8f139e4b91783722f11ccb6ac9bbdf8327e7joshualitt *coords = localQuad->point(i); 592244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt } 602244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt } 612244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 622244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt static const int kColorOffset = sizeof(SkPoint); 632244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt GrColor* vertColor = reinterpret_cast<GrColor*>(vertices + kColorOffset); 642244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt for (int j = 0; j < 4; ++j) { 652244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt *vertColor = color; 666a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon vertColor = (GrColor*)((intptr_t)vertColor + vertexStride); 672244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt } 682244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt} 692244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 706a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomonclass NonAAFillRectOp final : public GrMeshDrawOp { 719c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualittpublic: 7225a880960a9a689a745a01071ecba3fe494b5940Brian Salomon DEFINE_OP_CLASS_ID 7308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 746a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon NonAAFillRectOp(GrColor color, const SkMatrix& viewMatrix, const SkRect& rect, 756a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon const SkRect* localRect, const SkMatrix* localMatrix) 769d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon : INHERITED(ClassID()) { 776a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon SkASSERT(!viewMatrix.hasPerspective() && (!localMatrix || !localMatrix->hasPerspective())); 789d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon RectInfo& info = fRects.push_back(); 799d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fColor = color; 809d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fViewMatrix = viewMatrix; 819d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fRect = rect; 829d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon if (localRect && localMatrix) { 839d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fLocalQuad.setFromMappedRect(*localRect, *localMatrix); 849d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon } else if (localRect) { 859d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fLocalQuad.set(*localRect); 869d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon } else if (localMatrix) { 879d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fLocalQuad.setFromMappedRect(rect, *localMatrix); 889d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon } else { 899d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon info.fLocalQuad.set(rect); 909d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon } 9188cf17d099085b8085ab11571b5094163dbb2c84bsalomon this->setTransformedBounds(fRects[0].fRect, viewMatrix, HasAABloat::kNo, IsZeroArea::kNo); 929d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon } 9308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 946a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon const char* name() const override { return "NonAAFillRectOp"; } 9508d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 9608d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon SkString dumpInfo() const override { 9708d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon SkString str; 9853e4c3c0da40b58638d05e0f753ab6d450b961f5Brian Salomon str.appendf("# combined: %d\n", fRects.count()); 999d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon for (int i = 0; i < fRects.count(); ++i) { 1009d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon const RectInfo& info = fRects[i]; 1016a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon str.appendf("%d: Color: 0x%08x, Rect [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n", i, 1026a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon info.fColor, info.fRect.fLeft, info.fRect.fTop, info.fRect.fRight, 1036a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon info.fRect.fBottom); 10408d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 1057c3e7180948766321c51d165737555e78910de51Brian Salomon str.append(DumpPipelineInfo(*this->pipeline())); 10608d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon str.append(INHERITED::dumpInfo()); 10708d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon return str; 10808d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 10908d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 11092aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomonprivate: 11192aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon NonAAFillRectOp() : INHERITED(ClassID()) {} 11208d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 11392aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon void getPipelineAnalysisInput(GrPipelineAnalysisDrawOpInput* input) const override { 11492aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon input->pipelineColorInput()->setKnownFourComponents(fRects[0].fColor); 11592aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon input->pipelineCoverageInput()->setKnownSingleComponent(0xff); 11608d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 11708d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 11892aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon void applyPipelineOptimizations(const GrPipelineOptimizations& optimizations) override { 11992aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon optimizations.getOverrideColorIfSet(&fRects[0].fColor); 12092aee3d6857386f2b5b8e1148e680a7b58e9b1fcBrian Salomon } 12108d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 12208d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon void onPrepareDraws(Target* target) const override { 1238c852be264d003b2e610c5b8634bc0f81c46bbbaBrian Salomon sk_sp<GrGeometryProcessor> gp = make_gp(); 12408d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon if (!gp) { 12508d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon SkDebugf("Couldn't create GrGeometryProcessor\n"); 12608d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon return; 12708d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 128bc9b6a4239b797fe7fbdb876607053b18eba2380bsalomon SkASSERT(gp->getVertexStride() == 129bc9b6a4239b797fe7fbdb876607053b18eba2380bsalomon sizeof(GrDefaultGeoProcFactory::PositionColorLocalCoordAttr)); 13008d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 13108d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon size_t vertexStride = gp->getVertexStride(); 1329d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon int instanceCount = fRects.count(); 13308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 134144caf55ffc692bcda77703a73bb9a894f7d024fHal Canary sk_sp<const GrBuffer> indexBuffer(target->resourceProvider()->refQuadIndexBuffer()); 13508d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon InstancedHelper helper; 1366a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon void* vertices = 1376a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon helper.init(target, kTriangles_GrPrimitiveType, vertexStride, indexBuffer.get(), 1386a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon kVertsPerInstance, kIndicesPerInstance, instanceCount); 13908d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon if (!vertices || !indexBuffer) { 14008d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon SkDebugf("Could not allocate vertices\n"); 14108d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon return; 14208d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 14308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 14408d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon for (int i = 0; i < instanceCount; i++) { 1456a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon intptr_t verts = 1466a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon reinterpret_cast<intptr_t>(vertices) + i * kVertsPerInstance * vertexStride; 1476abd1d192e0b2698d19e0b03fe4c2a34fb604b8frobertphillips tesselate(verts, vertexStride, fRects[i].fColor, &fRects[i].fViewMatrix, 1489d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon fRects[i].fRect, &fRects[i].fLocalQuad); 14908d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 15008d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon helper.recordDraw(target, gp.get()); 15108d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 15208d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 15325a880960a9a689a745a01071ecba3fe494b5940Brian Salomon bool onCombineIfPossible(GrOp* t, const GrCaps& caps) override { 1546a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon NonAAFillRectOp* that = t->cast<NonAAFillRectOp>(); 15508d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon if (!GrPipeline::CanCombine(*this->pipeline(), this->bounds(), *that->pipeline(), 15608d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon that->bounds(), caps)) { 15708d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon return false; 15808d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 15908d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 1609d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon fRects.push_back_n(that->fRects.count(), that->fRects.begin()); 16188cf17d099085b8085ab11571b5094163dbb2c84bsalomon this->joinBounds(*that); 16208d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon return true; 16308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon } 16408d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 1659d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon struct RectInfo { 1669d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon GrColor fColor; 1679d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon SkMatrix fViewMatrix; 1689d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon SkRect fRect; 1699d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon GrQuad fLocalQuad; 1709d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon }; 1719d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon 1729d7f1849a88f5f2f6c7c00fe826d1d42a2df990fbsalomon SkSTArray<1, RectInfo, true> fRects; 17308d141534cb24a491edbf5db31cdc7b966ec8d72bsalomon 174dad2923b8ec9270d810c1e8e76da8e6768d8f9ddBrian Salomon typedef GrMeshDrawOp INHERITED; 1752244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt}; 1769c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 1776a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomonnamespace GrNonAAFillRectOp { 178b8cbd2098225ee2ec1bd96b3e2b1cf3f5164d2d8bsalomon 179f8334781914363caf537f22f012fcd5c03c60dadBrian Salomonstd::unique_ptr<GrDrawOp> Make(GrColor color, 180f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon const SkMatrix& viewMatrix, 181f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon const SkRect& rect, 182f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon const SkRect* localRect, 183f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon const SkMatrix* localMatrix) { 184f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon return std::unique_ptr<GrDrawOp>( 185f8334781914363caf537f22f012fcd5c03c60dadBrian Salomon new NonAAFillRectOp(color, viewMatrix, rect, localRect, localMatrix)); 1863566d44d852b2fc1773e41e80c0c19610aa6d43bjoshualitt} 1879c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt}; 1889c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 1899c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt/////////////////////////////////////////////////////////////////////////////////////////////////// 1909c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 1919c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt#ifdef GR_TEST_UTILS 1929c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 1935ec9def2dd7bba572398ff2aa9361fbbb3b478edBrian Salomon#include "GrDrawOpTest.h" 1949c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 1955ec9def2dd7bba572398ff2aa9361fbbb3b478edBrian SalomonDRAW_OP_TEST_DEFINE(NonAAFillRectOp) { 1962244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt GrColor color = GrRandomColor(random); 1972244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt SkRect rect = GrTest::TestRect(random); 1982244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt SkRect localRect = GrTest::TestRect(random); 1992244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt SkMatrix viewMatrix = GrTest::TestMatrixInvertible(random); 2002244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt SkMatrix localMatrix = GrTest::TestMatrix(random); 2012244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt 2022244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt bool hasLocalRect = random->nextBool(); 2032244c27ea4db85df305fa09f664b7d75f637e7a9joshualitt bool hasLocalMatrix = random->nextBool(); 2046a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon return GrNonAAFillRectOp::Make(color, 2056a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon viewMatrix, 2066a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon rect, 2076a639040bc3ee5369d86c9cb5b9047208beb5206Brian Salomon hasLocalRect ? &localRect : nullptr, 2085ec9def2dd7bba572398ff2aa9361fbbb3b478edBrian Salomon hasLocalMatrix ? &localMatrix : nullptr); 2099c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt} 2109c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt 2119c80b5ff592caf1c18b43e98c85bc8340b3ac531joshualitt#endif 212