| 920a2d1fb62a56abdfd58f90df1d7d457abbc55c |
20-Mar-2017 |
Michael Tang <ntang@google.com> |
Revert "autotest: throw Auto Refresh checkbox into the abyss".
We will add the auto refresh back to Moblab environtment only.
This reverts commit 04ec30490d877f5eddfd1b747b507f754798c985.
BUG=chromium:700418
TEST=manually.
Change-Id: Ib6069e35da927f1d71cdc08abda183fbefd0c3b0
Reviewed-on: https://chromium-review.googlesource.com/456634
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Keith Haddow <haddowk@chromium.org>
i/CustomTabPanel.java
i/TabView.java
|
| bbffcbef0ef7d62f76b0f43edde91fdc57678ca4 |
05-Apr-2017 |
Prathmesh Prabhu <pprabhu@chromium.org> |
[autotest] Include jobs from today in lists
Both on the host detail view and the job list, we would like to see the
jobs from the current day. So, set the default end date to be tomorrow.
BUG=chromium:708243
TEST=Manually check UI on local AFE.
Change-Id: If9959c12fa01fac15ce026ba9ea0e31c95bad56f
Reviewed-on: https://chromium-review.googlesource.com/468387
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
able/DatetimeSegmentFilter.java
|
| cc430e2b9401f7f72440ce95bbcd1e920cf19982 |
29-Mar-2017 |
Prathmesh Prabhu <pprabhu@chromium.org> |
ui: Notify listeners when DateTimeSegmentFilter value changes
This is a bugfix. Nothing was depending on this notification being sent
yet, but a future CL adds a listener who wasn't getting notifications on
change.
BUG=chromium:685424
TEST=Manual testing on local afe.
Change-Id: I121b35bf742a5003b3105466a97e28e5fa9c5e51
Reviewed-on: https://chromium-review.googlesource.com/462119
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
able/DatetimeSegmentFilter.java
|
| 484217188039b02e25716a88901667b62a53653e |
29-Mar-2017 |
Prathmesh Prabhu <pprabhu@chromium.org> |
ui: Change the default date range to be last week
In a future CL, this will let us use the default range for the initial
query.
BUG=chromium:685424
TEST=Local afe manual testing.
Change-Id: Ic589db689cce7e64240cd3a0612376cb73c50112
Reviewed-on: https://chromium-review.googlesource.com/461356
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Xixuan Wu <xixuan@chromium.org>
able/DatetimeSegmentFilter.java
|
| 5d84dc7f52f71992f4ac2719bc099d55f815c37f |
17-Mar-2017 |
Aviv Keshet <akeshet@chromium.org> |
Revert "Adds the auto refresh checkbox back to the UI for moblab."
This reverts commit ed09d8e93668acfbe638d5a8c07879466ca82de6.
Change-Id: I8b35fa4e4ae31e25c986b5d26929dce3b9efc28a
Reviewed-on: https://chromium-review.googlesource.com/456594
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
taticDataRepository.java
i/CustomTabPanel.java
i/TabView.java
|
| ed09d8e93668acfbe638d5a8c07879466ca82de6 |
11-Mar-2017 |
Michael Tang <ntang@google.com> |
Adds the auto refresh checkbox back to the UI for moblab.
We will allow autofresh for Moblab UI, and all existing autotest UI
except the Job List tab.
This partially reverts commit 04ec30490d877f5eddfd1b747b507f754798c985.
BUG=chromium:700418
TEST=manually.
Change-Id: I0ef9bf65520684ff857c8442081f04ddd1e0c824
Reviewed-on: https://chromium-review.googlesource.com/453276
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
taticDataRepository.java
i/CustomTabPanel.java
i/TabView.java
|
| 04ec30490d877f5eddfd1b747b507f754798c985 |
09-Mar-2017 |
Aviv Keshet <akeshet@chromium.org> |
autotest: throw Auto Refresh checkbox into the abyss
BUG=chromium:700174
TEST=None
Change-Id: I39bd7d48f043f1504a2322ec4ce49c2812b74d2c
Reviewed-on: https://chromium-review.googlesource.com/452742
Commit-Ready: Aviv Keshet <akeshet@chromium.org>
Tested-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
i/CustomTabPanel.java
i/TabView.java
|
| 6a34cafd6e9b9d2609308a80a5292ca60e22611e |
22-Oct-2016 |
Michael Tang <ntang@google.com> |
Adds UI to upload all Moblab credentials files.
BUG=chromium:658462
TEST=manual.
Change-Id: I53fff080f524c8cb793911227d18125e45da00fd
Reviewed-on: https://chromium-review.googlesource.com/401282
Reviewed-by: Keith Haddow <haddowk@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Commit-Queue: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Trybot-Ready: Michael Tang <ntang@chromium.org>
i/ContextMenu.java
|
| d27059144bb2f6339f5d5aa6c762574fd94200ca |
21-Mar-2016 |
Michael Tang <ntang@google.com> |
Integrate the wizard into the Moblab UI.
Also adds updated based on some comments from change 334012.
BUG=chromium:596536
TEST=Manually test.
Change-Id: I70d04718bcec81c326ae9b2aab4550214e795558
Reviewed-on: https://chromium-review.googlesource.com/333993
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Stephen Lin <stephenlin@google.com>
Reviewed-by: Michael Tang <ntang@chromium.org>
tils.java
|
| 159ca506308ec48cf31cfa7dbb908143ed58f071 |
21-Mar-2016 |
Michael Tang <ntang@google.com> |
Moblab configuration wizard UI widget.
BUG=chromium:596536
TEST=Unit Tests.
Change-Id: I5d31fd30876b32d40980bbce462764ef26da5520
Reviewed-on: https://chromium-review.googlesource.com/334012
Commit-Ready: Michael Tang <ntang@chromium.org>
Tested-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Reviewed-by: Michael Tang <ntang@chromium.org>
Reviewed-by: Dan Shi <dshi@google.com>
tils.java
|
| 37df54d11d7598f6b7192b5a397d6e9ca05bf8e3 |
14-Dec-2015 |
Dan Shi <dshi@google.com> |
[autotest] Add a currently running job/task of a host on cautotest AFE
Add a new argument include_current_job in get_hosts RPC. If it's set to True,
include the currently running job/task info in the host details. It's default
to False, since the call is used for other callers, and the extra db query will
add unnecessary load to the caller, e.g., shard heartbeat.
BUG=chromium:549193
TEST=local verify
host with no running job/task: http://dshi.mtv/afe/#tab_id=view_host&object_id=1
host with running job/task: http://dshi.mtv/afe/#tab_id=view_host&object_id=8
DEPLOY=afe, apache
Change-Id: Ifc86db3486efafe9a2f3f17f00ea0640f3f1e0ba
Reviewed-on: https://chromium-review.googlesource.com/318260
Commit-Ready: Dan Shi <dshi@google.com>
Tested-by: Dan Shi <dshi@google.com>
Reviewed-by: Fang Deng <fdeng@chromium.org>
able/RpcDataSource.java
|
| 57bc195c551d71c5268d7630aa6e872aaad242bf |
23-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Add time segmented filter on job table on View Host page.
Modified the frontend to provide a start time and an end time with
datetime pickers. The place holder values are set to midnight "today".
Please note that the place holder values are not default values.
They are equivalent to empty strings, but exist to avoid making users
have to fill in all six segments (year, month, day, hour, minute, am/pm).
On the rpc side, added start_time and end_time parameters to
get_host_queue_entries, get_num_host_queue_entries,
get_host_queue_entries_and_special_tasks,
and get_num_host_queue_entries_and_special_tasks.
A helper function inject_start_end_time_to_dict is used to inject start_time
and end_time to filter_datas.
BUG=chromium:362240
TEST=ran afe, passed rpc_interface_unittest and frontend_unittest
DEPLOY=afe, apache
Change-Id: I44d59124cc104cf55d2ac3838be983286e270195
Reviewed-on: https://chromium-review.googlesource.com/209389
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
able/DatetimeSegmentFilter.java
i/DateTimeBox.java
|
| 9d1b6d100cc3f15094784dd5d015885a33924e6b |
23-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Move RadioChooser from package common.ui to afe.
RadioChooser depends on IRadioChooser, which is in package afe.
This will have compilation error because compiling other gwt frontend
needs to rely on package common, but cannot rely on package afe.
Moving RadioChooser to package afe will solve this problem, since no other
gwt frontend other than afe is using it.
BUG=chromium:396694
TEST=ran afe, tko, moblab_setup
DEPLOY=afe,tko,apache
Change-Id: I61a668988843ae8290cdfa585dfb0b535b551b2c
Reviewed-on: https://chromium-review.googlesource.com/209672
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
i/RadioChooser.java
i/RadioChooserDisplay.java
|
| 7a776a607e84e5101818142f67cae3d81c18dcd0 |
18-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Add ToolTips to AFE Job list, Create Job, and User Preference pages.
As part of the UI redesign, ToolTips are adopted to drop more explanations to
many unclear fields.
BUG=chromium:394145
TEST=ran afe
DEPLOY=afe,apache
Change-Id: Id72d3ba5160948d4e84e804306550d1ae7d92b14
Reviewed-on: https://chromium-review.googlesource.com/208956
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
i/ToolTip.java
|
| 6c40be4575c9101d99027ce9a6ca71b7e4962f85 |
16-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Disable action menu items when no table item is selected.
It's confusing to have action menu items clickable but actually having
no effect.
BUG=chromium:394442
TEST=ran afe
DEPLOY=afe,apache
Change-Id: If8dabf66f8a38e2d6a671123235d22cc7eb306c5
Reviewed-on: https://chromium-review.googlesource.com/208484
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
i/ContextMenu.java
|
| d58f008bca8c2d70c3f36d93a9fc1f76f25b4d3f |
18-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] New AFE UI migration.
Migrate AFE to the new UI design including:
* A sharper and more organized UI,
* Organize info on View Job and View Host pages into tables.
BUG=chromium:394145
TEST=ran afe
DEPLOY=afe,apache
Change-Id: I4deb61893888d06ed720e8eb19cdaa1de0270877
Reviewed-on: https://chromium-review.googlesource.com/208159
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
able/DataTable.java
able/SearchFilter.java
able/TableDecorator.java
i/CustomTabPanel.java
i/TableActionsPanel.java
|
| d94d8dc25b6c3f7af965075474d1583cbd7e471e |
16-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Make AFE remember the Autorefresh state of each tab.
If one checks the Autorefresh on AFE, instead of making the Autorefresh
global to every tab, the AFE will remember the state of each tab.
BUG=chromium:394189
TEST=ran afe
DEPLOY=afe,apache
Change-Id: Ib8f136ff229f92424a1623b2525de579c5662547
Reviewed-on: https://chromium-review.googlesource.com/208208
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
i/CustomTabPanel.java
i/TabView.java
|
| 15cbf37cebd87112bb493d12330e123d1b007c23 |
02-Jul-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] filter suite and individual jobs on AFE.
Modified rpc_interface get_jobs and get_num_jobs to take in three extra
filters, suite, sub, and standalone. Add a rpc_util to add a where clause
to SQL, and add a unittest accordingly.
On GWT, add a group of radiobuttons as filters.
BUG=chromium:390345
TEST=ran afe, ran Job List, use filters
DEPLOY=afe,apache
Change-Id: Ibce875b47bef7e89bcc94972e23261290f0ac0e0
Reviewed-on: https://chromium-review.googlesource.com/206415
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
able/RadioButtonSetFilter.java
|
| aac545784cea51dbe230c6c126b52987b7906fb5 |
04-Jun-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] AFE child jobs table on parent job.
Add a table to list all the child jobs of a parent job on Job View tab.
One can click on and navigate between child and parent.
BUG=chromium:379959
DEPLOY=afe,apache
TEST=ran afe, viewed a job, navigated between parent and child jobs
Change-Id: Id70c41c8f7cee40bd71a206e1f3e08a68efe054f
Reviewed-on: https://chromium-review.googlesource.com/202579
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
tatusSummary.java
|
| 9e049285fcdf1a964708774f46b84aae5c09837a |
05-Jun-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[autotest] Allow autorefresh on AFE.
Add a checkbox (default unchecked) to autorefresh the current tab on AFE.
Particularly useful on View Job tab as users don't need to manully refresh
to see the result.
The autorefresh interval is set to 5 seconds. Refresh won't interfere with
any temporary form data from user.
BUG=chromium:359475
DEPLOY=afe,apache
TEST=ran afe, checked the checkbox and wait for five seconds
Change-Id: Icdd8e1c340ec985d2bae65455e30a46fd49c95de
Reviewed-on: https://chromium-review.googlesource.com/202626
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
i/CustomTabPanel.java
|
| 8b7d7e13b97842c18bbdee696cd257b75c8a27c3 |
29-May-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[AFE] Optimize GWT to load Create Job and Host List tabs much faster.
Originally, the Create Job and Host List tabs take one minute to load.
This is due to sub-optimized GWT instead of any DB query latency.
Specificly, GWT by default is using a javascript method add(option, before)
to add options to `select` DOM element. This method runs in O(n) since
it will perform a linear search on the existing options to find `before`
and add the `option` after `before`.
Instead, I override it to make GWT using appendChild(option), which simply
add option at the end and runs in O(1).
BUG=chromium:378888
DEPLOY=afe
TEST=ran afe, create job on specific hosts
Change-Id: Ia6353074495fe04dd89f4c05bd4d919a322e3025
Reviewed-on: https://chromium-review.googlesource.com/202120
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
able/ListFilter.java
i/ExtendedListBox.java
|
| ad1841b1a07d40e3ca4110f9766b0bedee419c07 |
21-May-2014 |
Jiaxi Luo <jiaxiluo@chromium.org> |
[afe] "Job List" entry number not updated
On the "Job List" tab, when changing owners or changing from "All Jobs"
to "Running Jobs" etc., the number of jobs is not be updated.
TEST=Compile afe, ran frontend
BUG=chromium:375468
DEPOLY=afe
Change-Id: Ib4f8379740ca8df9854a25feb0054b9fef9c99e7
Reviewed-on: https://chromium-review.googlesource.com/200671
Tested-by: Jiaxi Luo <jiaxiluo@chromium.org>
Reviewed-by: Simran Basi <sbasi@chromium.org>
Commit-Queue: Jiaxi Luo <jiaxiluo@chromium.org>
able/DynamicTable.java
|
| 7d658cf6bade565c1098fd7b47075e96e7b542ca |
05-Sep-2013 |
Alex Miller <milleral@chromium.org> |
[autotest] Thread priority from create_suite_job through to create_job.
This schedules a suite job itself at the same priority level of its
tests, and also injects the priority value into the suite control files.
The change to thread priority through from dynamic_suite into create_job
needs to happen concurrently, because the type of `priority` is changing
from a string to an int. This also means everything that passes in a
priority gets fixed up in this CL.
suite_scheduler has also been tweaked to schedule all tests at the
PostBuild priority (for now...).
This also does all of the work to get priority to show up by name
instead of by integral value. In the create_job pane, we disallow
anyone to schedule a job at a priority that would preempt major build
processes (anything coming from a waterfall). However, all old jobs are
shown at the integral value, because showing two seperate priority
scales at the same time would be incredibly confusing. (Especially
since URGENT would be incredibly low priority)
BUG=chromium:250583
DEPLOY=afe, apache, suite_scheduler
TEST=unit, run_suite with a priority level
Change-Id: I9ecf5ceed5c58bd8ee0815c6d15f4aba300082fe
Reviewed-on: https://chromium-review.googlesource.com/168143
Reviewed-by: Alex Miller <milleral@chromium.org>
Tested-by: Alex Miller <milleral@chromium.org>
Commit-Queue: Alex Miller <milleral@chromium.org>
taticDataRepository.java
|
| 74a314b490ff542c4dd2ae4aa0d11c6394d92960 |
23-Jun-2011 |
Dale Curtis <dalecurtis@chromium.org> |
Upstream Autotest merge.
As titled, a merge up to 93fc426ca133e775eb495f34d138fc57d92fb55e.
- Removes a bunch of deprecated code.
- Moves several private utilities into the private repo.
- Couple changes ported upstream and resynced.
BUG=None
TEST=In progress... will spin up new Autotest server and use
run_remote_tests for bvt, regression, smoke.
Change-Id: Id3e2ad529bb7b05f148e5d98aea46bb9ea828200
Reviewed-on: http://gerrit.chromium.org/gerrit/3350
Tested-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
sonRpcProxy.java
|
| 6f27d4f22a1ba5063968b8c322fa0845f3279ade |
29-Sep-2010 |
Eric Li <ericli@chromium.org> |
Merge remote branch 'cros/upstream' into tempbranch3
Merge to trunk@4817
BUG=
TEST=
Review URL: http://codereview.chromium.org/3554003
Change-Id: I83376bc7d28104ec2678e157eadbe7df7c05c0e0
able/DynamicTable.java
i/MultiListSelectPresenter.java
i/RadioChooser.java
i/RadioChooserDisplay.java
i/SimplifiedList.java
|
| 517d95a1ef4edb04da427763f86068a447d45ec7 |
29-Sep-2010 |
Benson Leung <bleung@chromium.org> |
Revert "Merge remote branch 'cros/upstream' into tempbranch2"
This reverts commit 25fc6d1f28e54c46689f12d3b93c2540ef45323a.
TBR=ericli@chromium.org
Review URL: http://codereview.chromium.org/3541002
Change-Id: Ib0165b19bfdf02264f8a6a74ddf3ae74c8c0f7df
able/DynamicTable.java
i/MultiListSelectPresenter.java
i/RadioChooser.java
i/RadioChooserDisplay.java
i/SimplifiedList.java
|
| 25fc6d1f28e54c46689f12d3b93c2540ef45323a |
29-Sep-2010 |
Eric Li <ericli@chromium.org> |
Merge remote branch 'cros/upstream' into tempbranch2
Merged to trunk@4816.
BUG=
TEST=we will build a new autotest server instance, and keep cautotest running and then later do a cname switch.
Review URL: http://codereview.chromium.org/3511003
Change-Id: Iee5f52f45f28f84927d6c6f9a74edc370d40288a
able/DynamicTable.java
i/MultiListSelectPresenter.java
i/RadioChooser.java
i/RadioChooserDisplay.java
i/SimplifiedList.java
|
| 26dd6aa23eb2771acefa611c029c06f6ee6f1b11 |
17-Jul-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Prevent NullPointerException when clicking on a test in Create Job.
No functional effect, just keeps the exception from showing up in DevMode.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4721 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| e84f1fab8c04cdcfc992f1c122e0c08c65843657 |
01-Jun-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Create embeddable spreadsheets, and use that on the AFE Job Detail tab.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4570 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 589cc78019a41fa293d7583a3c1b6dfca42da41b |
28-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Code cleanup
Whitespace fixes, and addition of newlines at end of some files.
Use StringBuilder.append() rather than String += in loops.
Add equals() and hashCode() for class that implements Comparable.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4567 592f7852-d20e-0410-864c-8624ca9c26a4
able/CheckboxFilter.java
able/FieldFilter.java
able/Filter.java
able/JSONObjectComparator.java
able/JSONObjectSet.java
able/ListFilter.java
i/SimpleDialog.java
|
| 06e59f14d08f614c659331bb03a352bf488a7cfc |
24-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Initial implementation of Test Planner Test View.
Trying again because generated patch was malformed.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4556 592f7852-d20e-0410-864c-8624ca9c26a4
sonManipulator.java
tils.java
|
| fefab4aeaf1cc8ae9837a860c8502b001eec0c99 |
18-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add filter on locked_by user on AFE host lists
Trying again, so that there isn't a huge quoted patch in the patch notes.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4504 592f7852-d20e-0410-864c-8624ca9c26a4
able/BooleanFilter.java
able/ListFilter.java
|
| 2e48bcb728e151f5744d73f0eb8a274ee59fc461 |
18-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Initial implementation of Test Planner Overview tab
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4503 592f7852-d20e-0410-864c-8624ca9c26a4
sonManipulator.java
|
| 55fc38afc375e326656f121770305376b6239659 |
07-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add coloring to Test Planner machine view table cells.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4485 592f7852-d20e-0410-864c-8624ca9c26a4
bstractStatusSummary.java
preadsheet/Spreadsheet.java
able/TableRenderer.java
|
| 8a7f36583afe076a7198d1b34fe109aa491dc277 |
06-May-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Remove SimpleHyperlink and replace with Anchor, which is a built-in class that
does the same thing.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4480 592f7852-d20e-0410-864c-8624ca9c26a4
i/Paginator.java
i/SimpleHyperlink.java
i/TableActionsPanel.java
i/TableSelectionPanel.java
i/ToggleLink.java
|
| 012d0325b33deeb81f06fa11f5498d2bc8146f57 |
30-Apr-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Move to GWT 2.0.3. Drop in new gwt-incubator to match.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4452 592f7852-d20e-0410-864c-8624ca9c26a4
addedJsonRpcProxy.java
|
| 6275824bd8458253d3ba30beb0f224bc24529158 |
28-Apr-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Change Triage View's tables to ScrollTable, and implement bulk triage
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4450 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| e5dd765d4900a6a826356075906ed552c59d6427 |
12-Apr-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add listeners to the TestPlanSelector, and have Triage View refresh on
entering a test plan.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4403 592f7852-d20e-0410-864c-8624ca9c26a4
i/HasTabVisible.java
i/TabView.java
|
| b852bce914dc3ae05b26f3655bfb437ffed001be |
07-Apr-2010 |
jamesren <jamesren@592f7852-d20e-0410-864c-8624ca9c26a4> |
Adding the GWT framework for the Test Planner.
This adds a new application to the GWT frontend, but does not link to it
from the other frontends yet. I don't anticipate anyone to be using this
just yet. Once the project reaches the point where I can release a working
prototype, I will create user documentation for it and send an announcement.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4378 592f7852-d20e-0410-864c-8624ca9c26a4
omUtils.java
sonRpcProxy.java
preadsheet/Spreadsheet.java
preadsheet/SpreadsheetSelectionManager.java
able/FragmentedTable.java
able/TableRenderer.java
|
| 3adac3671a998be8421238d3a08a7ffd2c3cbe1c |
13-Jan-2010 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Display the text required for filtering on custom fields in the TKO UI.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4113 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| 669624aad9c77060f706fde7c8e717cb636f9be8 |
12-Jan-2010 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fix rendering of empty cells in Job Details host table
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4097 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| 8b0ea2285c1327a686ff0b6ab245915e7fd20094 |
23-Dec-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Overhaul how we deal with related data in TKO -- test labels, test attributes, machine labels, and iteration results.
This has proven one of the trickiest areas of TKO. The first foray into this area was machine label headers, an early feature request implemented in a pretty ad-hoc manner in spreadsheet view which allowed them to be used as header fields. (Ironically, this was closest to the right approach on the server side, but I didn't appreciate it at the time. The original client-side implementation was a mess.) Next was filtering on test attributes and test labels, implemented with the include_labels, exclude_labels, include_attributes_where, and exclude_attributes_where options. This server-side implementation supported filtering but not viewing, grouping or sorting at all. Furthermore, even the filtering support was weak -- it only supporting ORing of inclusion requests and ANDing of exclusion requests. The client-side implementation was still pretty messy but was moving towards correctness. Finally, support was recently added for viewing iteration results in table view, but
grouping and filtering were excluded since they would've been very difficult to fit into the design. This was again a limited server-side approach, though the client-side implementation continued improving, albeit still using the trouble "generator items" in the mutliple list selector widget.
When I started working on support for test iterations and attributes in TKO table view, I finally hit upon the right server-side approach: specify the attributes that you're interested in, have the server perform a separate JOIN for each one, so that there's now a new column for each one, NULL if the attribute didn't exist and having the attribute's value if it did. Once it's created as a normal column, the user can do selection, grouping, sorting and filtering using the regular mechanisms. Everything just works. (For labels, it's slightly different, since whether or not a label is attached to a test is a boolean value. I opted to have the column's value be either NULL or the name of the label.)
Well, not quite perfectly. MySQL lets us define column aliases in a SELECT which are then usable in GROUP BY and ORDER BY. They aren't however, usable in the WHERE clause, because certain select expressions may not exist at the time the WHERE is applied. (Our expressions happen to be fine, but MySQL will have none of it.) There's absolutely no way I can see to define aliases for use in the WHERE clause. And unfortunately, our current interface allows users to provide a WHERE clause directly, so we can't perform translations or substitutions. As a result, filtering must be performed a little differently for these fields. You can't just say <field_name> = "<value>", like you can for most fields. For test attributes and iteration results, you say <field_name>.value = "<value>". For test labels and machine labels, you say <field_name>.id IS [NOT] NULL.
The first part of this CL is changing the server to use this new approach. get_test_views() now accepts test_label_fields, test_attribute_fields, machine_label_fields, and iteration_result_fields parameters, which allow the user to add extra fields based on these data types.
At the same time, I've changed how the TKO web clients deals with these data types in a way that mirrors the new way of handling these features on the server. There is now a global widget for adding custom fields based on any of the four data types. Once one is created, it can be used just like any other field in spreadsheet view, table view, and the global condition. This vastly simplifies most pieces of the code that previously dealt with these features, and it greatly expands the available space of features. Where we formerly had spreadsheet grouping/filtering on machine labels, table viewing of iteration results, and limited filtering on test labels and attributes, we now have viewing, grouping sorting, and filtering on all four.
High-level changes involved:
Server side
* added code to TestViewManager to handle the new options for creating fields, documented them, and documented that these options are supported and the rest are deprecated (we can probably delete them but we should check, they might be in use)
* added thorough unit tests for all of the above. on a side note, i discovered a neat feature of SQLite where you can add any function you've defined at a callable function from SQL statements. I used this to add some functions emulating MySQL-only functions. This could be used to good effect elsewhere, but this CL is big enough :)
* got rid of now-obsolete code for machine_label_headers option and iteration views
Client side:
* made HeaderFields immutable. Mutable HeaderFields turned out to be way too much of a nightmare. Users can specify values for ParameterizedFields at creation time, and if they want to modify them, they can delete and add.
* made all parts of the application (namely SpreadsheetView (both header selectors), TableView, and CommonPanel) use a single global HeaderFieldCollection
* changed ParameterizedFieldListPresenter to handle the new job of allowing creation and deletion of any kind of ParameterizedField. This new widget replaces the label/attribute filtering widget in the CommonPanel -- I got rid of all the code for that widget.
* removed the now-obsolete code for "generator items" in the MultiListSelectPresenter.
* finally made TableView use HeaderSelect. Since HeaderSelect plays a more significant role and it's role is more unified, it made sense to finally do this (TableView was previously duplicating logic from HeaderSelect, which was only used in SpreadsheetView). Since the HeaderSelect used in TableView is much simpler than the one used in SpreadsheetView, I extracted a new class SpreadsheetHeaderSelect, using composition rather than inheritance (it didn't really follow an is-a relationship).
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@4049 592f7852-d20e-0410-864c-8624ca9c26a4
impleChangeListener.java
impleChangeListenerCollection.java
tils.java
able/DataTable.java
i/MultiListSelectPresenter.java
|
| 4879914c122f4ed97eae3b08c5af1930fd75b39d |
13-Nov-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fix a bug where hosts in a cloned job weren't removed when deselecting the host from the "browse hosts" table. This again turned out to be a relatively large change for the size of the problem, because I chose to make some refactorings to attack some of the design problems the were behind the issue in the first place.
The core issue was that the ArrayDataSource was using a plain SortedSet<JSONObject> to hold the selected hosts. This is good because we want to keep them sorted, but it's bad because it uses the default object equality for JSONObjects, but we want to use a special equality based on ID or hostname. We normally accomplish that with JSONObjectSet, but that doesn't get us the sorting. JSONObjectSet is sort of a hack in the first place; the proper solution is to use custom objects that override equality.
As a first step towards that approach, I created a Host class under the models autotest.afe.models package. In order to minimize the scope of this change, I made it override JSONObject, so that we can move incrementally. I made it override equality and made HostDataSource convert the results to Host objects before returning them.
Unfortunately, I ran into a second problem. DataSource passes back results in a JSONArray. Since JSONArrays use native JS objects for storage, the objects you get out of them are always real JSONObjects, constructed on the fly -- not just declared type, but actual type. Even if you put Hosts in, they'll effectively be converted back to plain JSONObjects when you take them out. This is a reflection of a second design problem -- we shouldn't use JSONArrays to pass data around within the program. So I changed DataSource to convert results to List<JSONObject> and pass the data back that way. This required minor changes across many files, but nothing drastic anywhere.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3943 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
able/ArrayDataSource.java
able/DataSource.java
able/DataTable.java
able/DynamicTable.java
able/DynamicTableSelectionManager.java
able/RpcDataSource.java
|
| b9c6617bdc063b3b4aa760a0a45190ee069139fd |
13-Nov-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Modify DynamicTableSelectionListener so that when select "none" is clicked, only deselect items matching the current filters. This turned out to be considerably trickier than i thought, because in order to do this properly and efficiently, it has to work like this: when "none" is clicked, make an RPC call for all the currently filtered items that fall within the currently selected set. We do this by making a new request to the table's active DataSource with the current filtering params plus a list of selected item IDs. There are two problems here:
1) Not all tables show DB objects -- in particular, the host detail view table when "show verifies/repairs/cleanups" is selected, and the TKO table view when grouping is active. For these tables, there's no way to filter on selected items by ID. Fortunately, these tables also happen to not be prone to the original issue, because they can't be filtered. So I added some code to only apply this new logic to tables that have active user-controlled filters. This is pretty ugly from a design point of view, but I had to take a practical approach -- it works, the code is clean, and I couldn't think of any workable alternatives.
2) The DataSource interface was poorly designed such that an RpcDataSource was stateful (and mutated every time a new request was made), so there was no way to make a new request on a DataSource without messing up its state and therefore potentially messing up the table using it. To get around this, I redesigned the interface to use a separate Query objects. Now, both the DataSource and the Query objects are immutable, and making a separate query for the "select none" operation is easy. (This actually also encouraged a change to DynamicTable to be much more efficient by avoiding many unnecessary get_num_*() calls.)
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3941 592f7852-d20e-0410-864c-8624ca9c26a4
SONArrayList.java
able/ArrayDataSource.java
able/DataSource.java
able/DynamicTable.java
able/DynamicTableSelectionManager.java
able/Filter.java
able/JSONObjectSet.java
able/RpcDataSource.java
able/SelectionManager.java
|
| b584458d8d4c8df052dddb02fae033611a80c03d |
10-Nov-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Removed uses of deprecated method ListBox.setMultipleSelect()
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3924 592f7852-d20e-0410-864c-8624ca9c26a4
able/ListFilter.java
able/MultipleListFilter.java
|
| f541a0ae5e2fdb7e4f32422eb005ac2296bb8323 |
04-Nov-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Remove uses of deprecated class HistoryListener
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3897 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
|
| 4cd4763a855d8eb7d25fd4963babc432eb4d25e6 |
12-Oct-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Remove deprecated uses of TableListener, and implement proper
oncontextmenu handling
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3828 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
able/DynamicTable.java
able/TableDecorator.java
i/RightClickTable.java
|
| 16ab5250da1e2e5fb1549774063a8099ce4fdbb8 |
29-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Bugfix to ensure generated items are added to the MultiListSelectPresenter when necessary. Since there's no nice way in general for the clients to know if they've already added a generated item, made MultiListSelectPresenter allow multiple additions of a generated item. This ugliness should go away with the refactoring to formally separate state from presenter (mentioned in a previous change). Also, this change fixes an immediate bug where "Triage failures" wouldn't work (fixed by the change to TableView), but I made a parallel change to HeaderSelect, bringing similar code bits more in line to eventually (soon?) be consolidated.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3771 592f7852-d20e-0410-864c-8624ca9c26a4
i/MultiListSelectPresenter.java
|
| 227a7a1d0484dcfa4c6d996a1c10e95437d059ef |
18-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
OK, one more refactoring -- this time, make TableView use HeaderFields (something I've wanted to do for a long time, there has been a TODO at the top of TableView for ages) and consolidate a lot more logic. Part of this was in the introduction of a new HeaderFieldCollection class, the rest was simple consolidation due to common use of HeaderField.
TableView and HeaderSelect still duplicate a lot of logic, sadly, although it's not immediately obvious from the code at this point. Eventually I'll fully consolidate those, but at this point I think I'm ready to implement the iteration view feature that I've been working towards the whole time.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3753 592f7852-d20e-0410-864c-8624ca9c26a4
i/MultiListSelectPresenter.java
|
| 7f2b0e15c5928ea2914d078e385ca717d078c6d5 |
17-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Removed deprecated uses of isChecked/setChecked.
(Depends on [PATCH] Removed deprecated ChangeListener uses.)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3738 592f7852-d20e-0410-864c-8624ca9c26a4
able/CheckboxFilter.java
able/SelectionManager.java
i/RadioChooser.java
|
| 0d92da0fe19a095fc5678c4159e6a1756df65e48 |
17-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Removed deprecated ChangeListener uses.
(Depends on [PATCH] Removed the uses of some deprecated classes)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3737 592f7852-d20e-0410-864c-8624ca9c26a4
able/DynamicTable.java
able/Filter.java
able/ListFilter.java
i/Paginator.java
|
| 79a7b0d387aac103fc1d125353eefa361030452a |
17-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Removed the uses of the following deprecated classes:
DisclosureEvent
DisclosureHandler
FocusListener
KeyboardListener
TabListener
PopupListener
SuggestionEvent
SuggestionHandler
ScrollListener
WindowResizeListener
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3735 592f7852-d20e-0410-864c-8624ca9c26a4
able/LinkSetFilter.java
able/SearchFilter.java
i/ContextMenu.java
i/CustomTabPanel.java
i/DetailView.java
i/TableActionsPanel.java
|
| a29e963afc9de0ab086b5b2bea2e43ff68d81038 |
14-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fix a ConcurrentModificationException bug in MultiListSelectPresenter than appears when drilling down after a machine label field was selected, and remove an obsolete comment.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3714 592f7852-d20e-0410-864c-8624ca9c26a4
i/MultiListSelectPresenter.java
|
| a5e4d84c9616b0a987e904d3b1d1d3fd9ca1be86 |
11-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Removed deprecated ClickListener uses.
Mostly trivial changes. The only significant change was in
autotest.common.ui.SimpleHyperlink.
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3709 592f7852-d20e-0410-864c-8624ca9c26a4
able/CheckboxFilter.java
able/SearchFilter.java
able/TableClickWidget.java
i/CustomTabPanel.java
i/DetailView.java
i/Paginator.java
i/SimpleDialog.java
i/SimpleHyperlink.java
i/TableActionsPanel.java
i/TableSelectionPanel.java
i/ToggleLink.java
|
| 02ed4bd47471fe77270e5507a7f9759955b3753c |
09-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Reorganization of the host selection UI in the AFE create job view.
* refactor HostSelector into view/presenter (except for tables, which will need to be separately refactored)
* reorganize view into a tabbed format with a unified hostname input tab, a metahost tab and a browse hosts tab, with the selected hosts table alongside as before
Minor changes:
* extracted SimplifiedList interface from MultiListSelectPresenter to a top-level entity
* made ExtendedListBox implement the SimplifiedList interface and got rid of the SimplifiedListWrapper decorator class
* rewrote ArrayDataSource to use a TreeSet so it's actually efficient. this should speed up working with large host selections.
* edited JSONObjectComparator to be consistent with equals() for safety when using with TreeSet
* small change to how widths get set on TabPanels in AFE. rather than setting 100% width on all tab panels' contents using CSS, set it explicitly in CustomTabPanel. there's a quirk with browser layout where a 100% width div inside a table cell will have it's width set larger than the cell containing it. it happens on IE6, FF3 and Chrome so it's probably not something that's going to change. It does go away with the "border box" model, which can be enabled with nonstandard CSS attributes, but it's easy enough to work around here that that's not worth it.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3673 592f7852-d20e-0410-864c-8624ca9c26a4
able/ArrayDataSource.java
able/JSONObjectComparator.java
i/CustomTabPanel.java
i/DoubleListSelector.java
i/ExtendedListBox.java
i/MultiListSelectPresenter.java
i/SimplifiedList.java
|
| d9e04c1a7950691cc348e70fa2470f8c414ae94f |
08-Sep-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Refactor code related to double list selecting widgets used in both SpreadsheetView and TableView. This will facilitate code reuse and extension for the feature to include test iterations/attributes in table view. It will also make unit testing possible and provides cleaner organization of the code.
The major effort here is to refactor the DoubleListSelector and HeaderSelect classes according to the Passive View pattern. There are passive view classes for the double list itself (DoubleListSelector, which will be renamed in a future CL to DoubleListSelectDisplay) and for the spreadsheet header selection UI (HeaderSelectorView, which I think I'll also rename to HeaderSelectorDisplay). There is a new class, MultiListSelectPresenter, which incorporates the presentation logic from DoubleListSelector as well as some of the logic from HeaderSelect related to switch between a single and double list. The remaining code in HeaderSelect was modified to use a MultiListSelectPresenter as much as possible, retaining only the code specific to the spreadsheet header selection (and the management of machine label headers will likely be extracted and generalized too, since that sort of thing will be necessary for test attributes/iterations). Finally, small modifications to Spreadsheet
View and TableView were required to have them use the new interfaces.
This change also introduces the ToggleLink widget, consolidating logic that had been applied in multiple places previously.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3667 592f7852-d20e-0410-864c-8624ca9c26a4
i/DoubleListSelector.java
i/MultiListSelectPresenter.java
i/ToggleControl.java
i/ToggleLink.java
|
| 9e494cc00c53f9dd0fabec3ef675cb874a9130ad |
31-Aug-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Change how we construct the basic page layout in AFE and TKO. The TabView class was sneaking around with RootPanels and DOM elements, effectively doing what HTMLPanel was intended to do in a naughty way. GWT 1.5 was naive enough to let that go on behind its back (although it wasn't safe), but GWT 1.6 won't have any of it (read: assertion errors). So change TabView to use an HTMLPanel properly, and change all the views to construct their layouts the new, nice way.
More info, in an old email from Joel Webber: http://markmail.org/message/xliklhgn5vvuibm4#query:%22A%20widget%20that%20has%20an%20existing%20parent%20widget%20may%20not%20be%20added%20to%20the%20detach%20list%22+page:1+mid:xliklhgn5vvuibm4+state:results
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3630 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
i/DetailView.java
i/TabView.java
|
| 01d6329ddd2b854a2531d432d6083a59c85f9358 |
25-Aug-2009 |
mbligh <mbligh@592f7852-d20e-0410-864c-8624ca9c26a4> |
Update spinner gif.
Signed-off-by: Martin J. Bligh <mbligh@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3616 592f7852-d20e-0410-864c-8624ca9c26a4
i/NotifyManager.java
|
| eb0fd4c76ee70e68d907e542423ae249489552c2 |
21-Aug-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Clicking any part of the row in the hosts table in AFE View Job tab
should take us to the AFE View Host tab. Previously, the right side of
the row would do nothing upon click if the "Status Log" and "Debug Log"
links were not present.
Risk: low
Visibility: low
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3566 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| 752383196594a228f95384e11b8e5b669ba682ee |
28-Jul-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Make paginators left-aligned instead of center-aligned in AFE and TKO. Center-alignment was annoying sometimes because tables could be really wide or could vary in width with each page.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3456 592f7852-d20e-0410-864c-8624ca9c26a4
able/TableDecorator.java
|
| c0ac3a79cceec87873257a8b6d41d19c9fb02ec6 |
08-Jul-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
add the option to include verify/repair/cleanups in the job table on the host detail page.
* added RPC get_host_queue_entries_and_special_tasks, which returns both HQEs and SpecialTasks for a host in a carefully interleaved manner.
* added appropriate frontend unit tests
* added support to HostDetailView to include these entries, but have them not be selectable. this required changes to SelectionManager. I also added a utility method to Utils for opening a new window, and changed all sites that do that to call the new method.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3385 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
able/DynamicTable.java
able/SelectionManager.java
able/SimpleFilter.java
able/TableDecorator.java
i/TabView.java
|
| 3ed34fd6fa69b0d1faba7b67ab32225b63b64781 |
06-Jul-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Expand the test name column in the AFE Create Job tests list to fit the
table, if the test names are all too short to reach the end of the table
column.
Risk: low
Visibility: medium (UI bug fix)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3371 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| 6cff4ad7aa317bab05ab9dc1249dbea652944750 |
30-Jun-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fix FindBugs flags
Risk: low
Visibility: low
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3327 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
able/JSONObjectComparator.java
|
| f77862cb4c75fb91ec06db14f9fe68aac5368e4b |
15-Jun-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Moved the notification box to the top-center of the browser, and changed
the background color to yellow (a la Gmail). Also removed the DOCTYPE
strings from the HTML files, as they were causing problems with GWT
hosted mode.
Risk: low
Visibility: medium (UI change)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3263 592f7852-d20e-0410-864c-8624ca9c26a4
i/NotifyManager.java
|
| 77401f351bd4ef6b6af99e46a9f905b161062574 |
26-May-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Allow all TestView fields to be displayed in cell contents in
Spreadsheet View.
Risk: low
Visibility: medium (UI change)
Signed-off-by: James Ren <jamesren@google.com>
http://test.kernel.org/cgi-bin/mailman/listinfo/autotest
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3175 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 37059dfb50063124bce014d3217e3610499d917f |
08-May-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
CSV support for TKO table view.
* make RpcDataSource record the last RPC call params, since that's much easier than reconstructing it as I was doing for SpreadsheetVIew
* make TableDecorator support an Export CSV link, and make TableView use it
* add onExportCsv to Table View, plus some minor refactorings there that happened along the way
* generalize CSV code from SpreadsheetView and extract to TkoUtils
* add new CsvEncoder classes for table view
* change logic to decide which CsvEncoder to use -- simply dispatching off of method name isn't good enough, since both spreadsheet and table views use get_status_counts
* add new unit tests for the three kinds of table view
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3096 592f7852-d20e-0410-864c-8624ca9c26a4
able/RpcDataSource.java
able/TableDecorator.java
|
| 8748ed29ef2a3a73c18cb387765d595db452256c |
05-May-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fixed FindBugs warnings: changed some inner classes to static inner classes.
Risk: low
Visibility: low
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3092 592f7852-d20e-0410-864c-8624ca9c26a4
hrJsonRpcProxy.java
|
| 3d6ae118f69717e68bc15b9aed7b6a6c7dd9bab0 |
02-May-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Export CSV support for spreadsheet view.
* new Django view, handle_csv(), with a new URLconf, /new_tko/server/csv/
* new module csv_encoder with logic to encode the results of an RPC call into CSV format
* logic in csv_encoder to convert results of get_status_counts() (or get_latest_tests()) into CSV, when called from spreadsheet view
* added optional "Export to CSV" link to TableActionsPanel, and made SpreadsheetView use it with a handler to call the /csv/ entry point with the current query info
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3086 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
able/RpcDataSource.java
i/TableActionsPanel.java
|
| 6d845a7ecbd6d25dfb456cc38472bc916c2db7b6 |
01-May-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
increase timeout for JSON-P queries to 60s
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3074 592f7852-d20e-0410-864c-8624ca9c26a4
addedJsonRpcProxy.java
|
| b4df82db72b3c2c3737b4f12c485fc3267866dbc |
29-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
add @Override tag to overriding method in CommonClassFactory.java
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3062 592f7852-d20e-0410-864c-8624ca9c26a4
ommonClassFactory.java
|
| b7a52fd2431275381b3ecab7d631a135fb613866 |
27-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
globalInitialize() starts a timer and every 10 minutes requests
the motd again and sets the string in the dom.
Signed-off-by: Travis Miller <raphtee@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3040 592f7852-d20e-0410-864c-8624ca9c26a4
ommonClassFactory.java
|
| 9f4500a294eea35dce003cee41c558fcde3eb09f |
27-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Last few changes necessary to make first embeddable graphs work
* add EmbeddedTkoClient GWT entry point + associated scripts, GWT XML, launch configuration, apache config
* added EmbeddedTkoClientTest.html, a simple demonstration/test of using embedded widgets
* modify TabView to no longer be a Composite, but instead have a getWidget element. this allows us to defer any DOM manipulation to initialize() and therefore avoid executing it at all in the embedded case. the introduction of code to TabView.initialize() (it was previous abstract) required adding a super.initalize() call to *all* subclasses, and there are a lot, hence the large number of files in this change.
* added Plot.getNativeProxy(), generating a native JS object that acts as a proxy to the GWT Plot object
* extend JsonRpcProxy to allow use of PaddedJsonRpcProxys
* remove debug prints from PaddedJsonRpcProxy
* fix a little bug where a return statement was missing from Plot.showDrilldown()
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@3039 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
addedJsonRpcProxy.java
i/CustomTabPanel.java
i/DetailView.java
i/TabView.java
|
| edd589779be93badb9f9dc546bad538db5a0318d |
16-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Allow display of the message of the day in tko as well as afe.
refactored as common code in CommonClassFactory.
Signed-off-by: Travis Miller <raphtee@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2991 592f7852-d20e-0410-864c-8624ca9c26a4
ommonClassFactory.java
|
| 3b2b93007ba7ca0a8ace90f2ac0c2263ccbcbdf8 |
15-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
* extract code for displaying graphs and managing graph drilldowns from *Frontend classes (which also manage the graph setup UI) into separate Plot classes (a Plot class and two subclasses, MetricsPlot and MachineQualHistogram). eventually, these plot classes will be usable as embedded widgets in other pages.
* made some changes to graphing_utils.py to support the new design, including encoding drilldown information with JSONEncoder
* extract GraphingDialog class to a generic, top-level SimpleDialog class, so that it'll be usable from embedded widgets without including all the frontend code
* fix a bug in FilterSelector.isEmpty() (it would always return false previously)
* fix a bug in TableView where no column would be sorted on in some cases
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2990 592f7852-d20e-0410-864c-8624ca9c26a4
i/SimpleDialog.java
|
| a901ba9a627c31238bd1b674a532d2e860a1a348 |
07-Apr-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add more infrastructure for common (between AFE & TKO) site-specific features, and various UI widget enhancements.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2965 592f7852-d20e-0410-864c-8624ca9c26a4
ommonClassFactory.java
iteCommonClassFactory.java
i/ContextMenu.java
i/SimpleHyperlink.java
|
| ef6fe028fcc667366e8ac30fe63ba314a4b1d745 |
27-Mar-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
generic JSON-RPC implementation using JSONP (JSON with Padding). the central part of this change consists of:
* refactored JsonRpcProxy to extract all XmlHttpRequest-specific logic into a new XhrHttpRequest subclass, and made JsonRpcProxy abstract
* introduced new PaddedJsonRpcProxy subclass of XmlHttpRequest that uses JSONP instead of XHR
* added new handle_jsonp_rpc_request() method to rpc_handler.py, to handle JSONP requests on the server side
This enables the entire frontend (either AFE or TKO) to operate via JSONP instead of XHR. I didn't make them do that now, since there's no reason, but it will be critical when we go to make components embeddable in other pages (on other domains). Other changes here include:
* made TestDetailView use PaddedJsonRpcProxy (it previous had its own custom JSONP logic, which was all moved into PaddedJsonRpcProxy).
* made retrieve_logs.cgi and jsonp_fetcher.cgi support JSONP requests, so that log fetching requests could go through the shared JsonRpcProxy codepath. retrieve_logs.cgi still supports the old GET params interface for backwards compatibility (at least old TKO still uses it, and possible other scripts).
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2943 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcCallback.java
sonRpcProxy.java
addedJsonRpcProxy.java
tils.java
hrJsonRpcProxy.java
|
| 3af93f9e93f65dad8d8e5b808d67320c2da958d5 |
21-Mar-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
fix some unused code eclipse warnings that had been disabled but should've been enabled
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2920 592f7852-d20e-0410-864c-8624ca9c26a4
i/TabView.java
|
| 6315df674f86f719e816ea5689768ef0944e9f51 |
21-Mar-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-support command-click for macs, since control-click is overridden on macs to get context menu behavior. i forgot about that.
-fix a style issue i forgot to include in the original patch.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2919 592f7852-d20e-0410-864c-8624ca9c26a4
i/TabView.java
|
| c674d3ea684f75f3e05f5834b598050eb1c8856d |
12-Mar-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Support opening drilldown results in a new tab/window from spreadsheet and table views. When drilling down in spreadsheet and table views, either into a group or into test details for a single test, the user can open the resulting page in a new tab/window by control-clicking. I included what I believe is the proper code to support middle-clicking as well, but I could not see any browser support. I tried the GWT hosted mode browser and FF2 on linux, and FF3 and windows. I changed the cell selection combo to shift-click (I don't think anyone uses that feature anyway :-/).
The main technical challenge here was this: state is spread throughout a number of classes that make up the UI for spreadsheet and table views. Code for generating the history tokens is spread throughout those classes as well, using the state in each class. In order to open results in a new tab, the code needs to generate the history token for the new state while leaving the current UI unmodified. It would do this by calling functions to modify application state appropriately, then generate the new history token, and then revert to the previous application state before opening the new token in a new tab. However, since the UI widgets and state variables were all intertwined and spread throughout the code, this was impossible to do as the code was -- when we made calls to setup the new application state, the displayed UI would be modified.
To solve this, I modified a number of classes to implement updateStateFromView() and updateViewFromState() methods, making the separation between state and view more well-defined and explicitly controlled. I ensured that all state-modifying functions don't modify the view at all, and I made sure the history-generating functions only use state variables. Then I was able to make the code setup a new state, generate the new history token, and restore the old state without any visible changes in the UI.
I also modified CustomHistory and clients so that history tokens passing into and out of CustomHistory are dictionaries instead of strings. I find this a bit cleaner and (more importantly) it allows CustomHistory to safely check for token equality (checking strings is unsafe because ordering could change while content remains the same, thanks to the nondeterminism of iterating over a Map).
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2876 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
tils.java
i/DetailView.java
i/TabView.java
|
| e5ae165c706c465f08a732a361ea0aa5d75075ea |
12-Feb-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Widespread cleanup of graphing code, based on notes I took during the original review of the code that never got implemented.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2781 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 35120fef9a1b56fd419ec9794ebb5985754aee98 |
03-Feb-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-changes to TableView to more transparently treat "special" columns (group count, pass rate) more like normal columns.
-make TableView keep track of currently visible column names, instead of field names. This is better for tracking "special" columns because they don't necessarily have field names (e.g. pass rate uses the special widget column "field name").
-since TRIAGE_GROUP_COLUMNS now includes the count column, put it on the left of reason.
-for part of the change, it ended up being easier to stop using the whole "readonly item" thing in DoubleListSelector, so got rid of that and made TableView handle when "special" columns are removed through the DoubleListSelector.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2736 592f7852-d20e-0410-864c-8624ca9c26a4
i/DoubleListSelector.java
|
| d94f4db2fb1a88cb1de25e9a8a81cd59177ea0c8 |
26-Jan-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add job name search feature to AFE job list tab.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2690 592f7852-d20e-0410-864c-8624ca9c26a4
able/SearchFilter.java
|
| 9484c31ad1021c2e3b0ae796c31b220b5c057436 |
07-Jan-2009 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Change drop-down log viewers in TKO to use JSONP instead of XmlHttpRequests so they can handle direction to other servers. If you're curious what the hell JSONP is, check out http://code.google.com/docreader/#p=google-web-toolkit-doc-1-5&s=google-web-toolkit-doc-1-5&t=Article_UsingGWTForJSONMashups.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2607 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 2e9415ff78190fcc6f1c6c9cb6ca5529316b7248 |
05-Dec-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Preparation for adding a widget to edit job dependencies in the create job view in AFE. I haven't quite finalized how to add the widget so it's not there yet, but this puts the piece in place, and also fixes a bug with job cloning and dependencies.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2547 592f7852-d20e-0410-864c-8624ca9c26a4
i/DoubleListSelector.java
|
| 43a3d26e49662d06e145ed94a0c2dfb2b455126f |
12-Nov-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add a checkbox 'exclude "only if needed" labels' to host lists in AFE, checked by default in the create job view.
-add exclude_only_if_needed_labels argument to get_hosts() and get_num_hosts() RPCs
-move some code from tko.models.TestViewManager up into model_logic, since AFE now needs it to create a custom join for doing many-valued exclusion
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2405 592f7852-d20e-0410-864c-8624ca9c26a4
able/CheckboxFilter.java
|
| 291476fb2561cbd02d465d763e39686cf4c7a611 |
27-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Handle null values properly in updateObject(). When it's called from TestGroupDataSource.updateData(), source may be null.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2339 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| f248952e42ea33c34e41a49817e50f98c65c2716 |
24-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add feature to make spreadsheet header fields from combinations of machine labels. The user can create as many different machine-label-based fields as she wishes. For each field, she can enter a list of labels to be included. The field will then group on each combination of those labels.
-added new HeaderField abstract class with two implementations - SimpleHeaderField for normal fields and MachineLabelField for the new machine label fields
-made HeaderSelect capable of creating MachineLabelFields. In single header mode, selecting "Machine labels..." creates one, and deselecting it destroys it. In multiple header mode, each time "Machine labels..." is selected a new machine labels field is created, and deselecting one destroys it.
-made HeaderSelect display text boxes for each MachineLabelField for the user to input the label list.
-created HeaderSelect.addQueryParameters, moved fixed value logic into it (from SpreadsheetView.java), and put logic for machine label header in it.
-made TestGroupDataSource accept raw query parameters, and updated SpreadsheetDataProcessor to pass it through.
-modified SpreadsheetView to use HeaderFields throughout. Eventually other code (such as TableView) should be made to use them.
-added capability for ConditionTestSet to accept raw condition pieces. Eventually it will only work this way and I'll get rid of the field setting logic, since that's been moved to SimpleHeaderField.
-added ExtendedListBox class containing a bunch of utilities for ListBoxes that I've wanted for a long time. Several other parts of the code (DoubleListSelector, some of the graphing stuff) should be changes to use these utilities eventually.
-added ChangeListener support to DoubleListSelector
-made rpc interface accept a new "machine_label_headers" parameters, and added logic to tko_rpc_utils.py to construct SQL for machine label headers
-modified TestView manager to support a join into host labels
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2331 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
i/DoubleListSelector.java
i/ExtendedListBox.java
|
| 0fc3830f17d644bab74bfe38556299f5e58bc0fa |
23-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add user preferences for reboot options, including simple user preferences tab which could later be expanded to include more options.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2330 592f7852-d20e-0410-864c-8624ca9c26a4
taticDataRepository.java
|
| e78760cb696ef36fd1c58fd21a80282255a8ca95 |
23-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
TableDecorator needs to create a DynamicTableSelectionManager for "select all" to work correctly.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2328 592f7852-d20e-0410-864c-8624ca9c26a4
able/SelectionManager.java
able/TableDecorator.java
|
| 21baa459ea14f96e06212f1f35fcddab9442b3fc |
21-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add options to control reboots before and after a job.
-add reboot_before and reboot_after fields to Job, along with enums for each
-add options to create_job RPC for reboot_before and reboot_after
-add options to job create CLI for these fields, and made job stat -v display them
-add widgets to job create page in AFE for these fields and made job detail view display them
-add dirty field to Hosts, defaulting to True, and set to True when a host is locked
-made scheduler set this field when a job runs and clear it when a host is rebooted
-updated scheduler's PidfileRunMonitor to read a new three-line .autoserv_execute format, where the third line contains the number of tests that failed
-made scheduler Job.run() include a RebootTask before the verify task according to the reboot_before option
-made QueueTask.epilog() launch a RebootTask for each host according to the reboot_after option
-updated autoserv to write out a third line to .autoserv_execute containing the number of failed tests.
Other changes:
-added support for displaying Job.run_verify in the CLI (job stat -v) and job detail page on AFE
-updated ModelExtensions to convert BooleanField values to actual booleans. The MySQL Django backend just leaves them as ints (as they are represented in the DB), and it's stupid and annoying (Yes, bool is a subclass of int, so it's often not a problem. But yes, it can be.).
-get rid of use of Job.synch_count since we don't actually support it. I think this was meant for inclusion in a previous change and got left out.
-made the scheduler use the new setup_django_environment stuff to import and use the django models. It doesn't *really* use the models yet -- it just uses the Job.Reboot{Before,After} enum objects -- but this shows we could easily start using the models, and that's definitely the direction I want to go long term.
-refactored PidfileRunMonitor generally and made it a bit more robust by having it email errors for corrupt pidfiles and continue gracefully, instead of just crashing the scheduler
-changed the way Agent.tick() works. now, it basically runs through as much work as it can in a single call. for example, if there's a RebootTask and a VerifyTask, and the RebootTask has just finished, in a single call it will finish up the RebootTask and start the VerifyTask. this used to take two cycles and that was problematic for cases like this one -- the RebootTask would like to set host.status=Ready, but then the host could get snatched up on the next scheduling round, before the VerifyTask got started. This was sort of solved previously by keeping the HostQueueEntry active, and we could apply that approach here by making a new status for HostQueueEntries like "Rebooting". But I prefer this approach as I think it's more efficient, more powerful and easier to work with.
Risk: extremely high
Visibility: new reboot options for jobs, skip verify now displayed in AFE + CLI
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2308 592f7852-d20e-0410-864c-8624ca9c26a4
i/RadioChooser.java
|
| 9dbdcda5104991cbf344ea5cba1aa58e1af444f3 |
14-Oct-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Add feature to abort individual host queue entries the job detail and host detail pages. Performed a few other cleanups along the way.
-refactor TableActionsPanel, extract separate TableSelectionPanel
-make TableDecorator support a SelectionManager and a TableActionsPanel (or selection panel or other such control) just above the paginator. this makes it really easy to add selection capability, selection checkboxes, and an actions menu to any table.
-refactor TableDecorator in general since it kinda sucked
-change all existing code that does table selection to use the new TableDecorator support. this include job list view, the create job host selector (which now uses the common selection links instead of its old buttons), and tko.TableView.
-add selection support + a bulk abort action to the tables in job detail view and host detail view. this itself was easy given the above refactorings.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2283 592f7852-d20e-0410-864c-8624ca9c26a4
able/JSONObjectSet.java
able/SelectionManager.java
able/TableDecorator.java
i/TableActionsPanel.java
i/TableSelectionPanel.java
|
| 8c9b839c2f5073a755952a8a865a04db3b2d4547 |
30-Sep-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
add primitive support for fixed header values. fixed headers can be given as a comma- or whitespace-separated list of values. they will serve to both limit to results to the given values (something that could just as well be done with the WHERE clause, but I figured people would want this behavior) + force all given values to be included, even if it causes empty rows.
* add support to GroupDataProcessor + relevant RPCs in Django to support fixed header values, but *only* for single headers (i.e. no composite header support)
* add text box to GWT spreadsheet UI, accessible only in single-header mode. box accepts comma- or whitespace-separated list of values.
* add necessary code to process fixed headers + pass them to server, and to store in history URL
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2204 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| e732ee7d450b11261c82df0950fde8e02f839b26 |
23-Sep-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-added capability to have site-specific urlconfs in TKO Django server
-added ClassFactory and SiteClassFactory to autotest.tko package to allow site-specific modifications to TKO. made some changes to the AFE [Site]ClassFactory files (reducing visibility)
-added get_detailed_test_views RPC which includes information about labels and attributes associated with a test
-made changes to model_logic.py to make fewer assumptions about models. these were basically bugs in model_logic.py that weren't exposed until i started doing fancier queries on TKO models.
-made list_objects capable of accepting a field list
-changed JsonRpcProxy to contain base URLs instead of full RPC urls; this way, other components (graphing, jlog) can use them (and i made graphing use this URL, which fixes a bug in the embedded URL generation)
-added RealHyperlink widget to common.ui package, representing a plain old hyperlink to another page (as opposed to Hyperlink and SimpleHyperlink, which are intended to be handling by the GWT code). this eases dynamic updates of the link href and allows setting visibility, styles, and all the other good stuff that comes along with using Widgets.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2191 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
tils.java
i/RealHyperlink.java
|
| 64aeecdec485192241e5377b3fa5ac7cf57a0c12 |
19-Sep-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-add feature to filter on test attributes in TKO
-new server arguments "include_attributes_where" and "exclude_attributes_where" for filtering on test attributes
-refactor joining code in TKO models.py to support test attributes joining
-add new UI to CommonPanel.java to filter on test attributes. some of the UI code was written in a general way so that in the future it could be merged with some of the graphing UI code.
-modified TestSets and code that uses them to fix two bugs - first, TestSets didn't contain all the relevant filtering information (only the SQL clause), and second, the SQL clause would build up incorrectly during drilldown
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2177 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| d50ffb4b0ef514fb969d53b82e23ab41d4d3812e |
04-Sep-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-add easy invalidation functionality
-add "show invalidated tests" option to common panel, disabled by default
-made client submit "exclude_labels" option to exclude invalid tests. this required somewhat widespread changes because it means the global condition is no longer just a SQL string but now a collection of parameters
-add "invalidate tests" option to spreadsheet/table context menu, and button to test detail view. it's really just a shortcut to add the "invalidated" label.
-added logic to the server to handle "exclude_labels" option. it was done in this generic way because in the future i plan to add a UI to exclude any label or labels.
-force test label names to be unique
-fix a bug in logic to determine all labels assigned to a set of tests
-got rid of auto-refresh when changing between spreadsheet and table after the condition had changed
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2099 592f7852-d20e-0410-864c-8624ca9c26a4
able/SimpleFilter.java
|
| 21085f22a3c616ff12bf80b997187a00e44f851b |
19-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-fix bug with drilldown on null headers
-make spreadsheet view ignore TEST_NA entries
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2012 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 3c0f07d0127913043c2c704a6a374e20b62f6b30 |
19-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Several small TKO-related bugfixes/improvements:
-include show_incomplete option in afe "new results interface" link
-escape single quotes in history URLs
-reset table view to default when using "view in table" feature from spreadsheet
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2011 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 8579ea343f8d4c74b44d5b5cb2df3ef7552b2f6e |
18-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Snazzy new interface for select tests in Create Job view. Tests are now presented in a scrollable table, with descriptions displayed in a resizable pane on the right.
-new TestSelector widget displays table + description
-move some basic input handling from DynamicTable into DataTable, so that plain DataTables can handle clicks
-make DataTable capable of refreshing the widgets in a table without refreshing the entire table - this is useful for updating selections
-pull out the one bit of SelectionManager that depends on DynamicTable (as opposed to DataTable). This is now in DynamicTableSelectionManager, and the orignal SelectionManager can work with a plain DataTable.
-make SelectionManager capable of acting as the TableWidgetFactory for producing row selection checkboxes
-fix a couple minor bugs in (Site)CreateJobView, where some controls (skip verify, custom tests) would not be disabled when they should be
-pull out ArrayDataSource.JSONObjectComparator into a top-level class, so it could be used elsewhere to sort JSONObjects
git-svn-id: http://test.kernel.org/svn/autotest/trunk@2004 592f7852-d20e-0410-864c-8624ca9c26a4
able/ArrayDataSource.java
able/DataTable.java
able/DynamicTable.java
able/DynamicTableSelectionManager.java
able/JSONObjectComparator.java
able/SelectionManager.java
|
| cc0def989c9154f3ae0b5cfda16aa18c03490683 |
13-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Make popup stay fixed position, and cleanup related styles
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1980 592f7852-d20e-0410-864c-8624ca9c26a4
i/NotifyManager.java
|
| fb0762ed9e6e20c987d0613ffdf4859d14bd720a |
08-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
add spinner image during AFE/TKO loading
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1967 592f7852-d20e-0410-864c-8624ca9c26a4
i/NotifyManager.java
|
| 0c31bc5ef2ecdf8edf19468e1a373520110f5bc6 |
08-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Make query controls collapsible in spreadsheet and table views. This should help enable better use of screen real estate, especially in spreadsheet view.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1965 592f7852-d20e-0410-864c-8624ca9c26a4
i/CustomTabPanel.java
i/ElementWidget.java
i/SimpleHyperlink.java
i/TabView.java
|
| 76d9739461e614e04120383294974cc300fafa9d |
08-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fixing removing metahosts from the selected hosts in Create Job.
Removing metahosts should now work properly.
Risk: low
Visibility: medium (UI bug fix)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1961 592f7852-d20e-0410-864c-8624ca9c26a4
able/ArrayDataSource.java
|
| f0d4c570c1cf47af108bfc1236112a344ecc9c98 |
01-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Don't call preventDefault() on normal click events. This was breaking links in tables.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1944 592f7852-d20e-0410-864c-8624ca9c26a4
i/RightClickTable.java
|
| 091d19411105375c39acae752b698e9feb658e2d |
01-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
fix minor bug where detail views would refresh twice in a row
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1943 592f7852-d20e-0410-864c-8624ca9c26a4
i/DetailView.java
i/TabView.java
|
| 6a4e444d7b53d4171c0fbf50d442256e56959c55 |
01-Aug-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-add support for "read only" items to DoubleListSelector, to support new TKO features
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1942 592f7852-d20e-0410-864c-8624ca9c26a4
i/DoubleListSelector.java
|
| 76ce410967787f0a834b1cb85fc4aec9261ac8bc |
31-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
refactor RightClickTable to support some work on new TKO
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1940 592f7852-d20e-0410-864c-8624ca9c26a4
i/RightClickTable.java
|
| 5e2c70db8586bcd4c47fe6e5173357539c84cc57 |
31-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
couple of changes needed for new TKO:
-make NotifyManager support direct logging
-make DataSource support an onError method
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1938 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataSource.java
able/DynamicTable.java
able/RpcDataSource.java
able/SelectionManager.java
i/NotifyManager.java
|
| 1d2ff01b31f1918575a8ba3df30f7e79b97036d3 |
31-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Changed Select All on Job List tab to select all jobs across all pages.
Added a Select Visible link on Job List tab to select only visible
jobs.
Risk: low
Visibility: medium (UI change)
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1931 592f7852-d20e-0410-864c-8624ca9c26a4
i/TableActionsPanel.java
|
| c3afc99304e4d6ada6eaaaa0a1513e408ecca6eb |
28-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-move "select visible" logic into SelectionManager from HostSelector
-make JobListView "select all" link only select visible
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1918 592f7852-d20e-0410-864c-8624ca9c26a4
able/SelectionManager.java
|
| a62866be14da66b1d3f061837617eeea8a192aa7 |
28-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-add test_view_2 with more sensible field names, for use by new TKO. this is intended to replace test_view, but I don't want to modify test_view until old TKO is phased out.
-ensure "loading" popup doesn't get closed too early, especially on initial load
-extend logic for RPC serialization for new TKO
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1916 592f7852-d20e-0410-864c-8624ca9c26a4
i/NotifyManager.java
|
| 8f5a6fbeb7b7ec58424f0cf0bdbcca0e084e3e34 |
28-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
use replace instead of replaceAll in common.Utils, since we don't actually need regexps
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1915 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| 103690a0d2ebc312711f44882bfa82cba7d97839 |
25-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
make CustomHistory more robust (and simpler as it turns out)
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1902 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
|
| 237ba463f5d03aa26ae88df2c6c265fb1d8b447a |
24-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
display timeout in the AFE job details tab
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1892 592f7852-d20e-0410-864c-8624ca9c26a4
i/DetailView.java
|
| 353923be210e4c452ecd4e23ccd4e2d1fbebb490 |
24-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
more changes to history handling needed for new TKO. adds a utility for setting default values in maps, and avoids passing history arguments to TabViews if there is no actual information contained.
Signed-off-by: Steve Howard <showard@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1891 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
i/CustomTabPanel.java
|
| 585c2abb80648f80e7cb649b06dc9f6a8690a790 |
23-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-fix query_count to support flexible filtering like everything else
-ensure DataTable always escapes HTML in contents, and use whitespace: pre so that newlines can still be included (i.e. in JobTable)
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1882 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
|
| b2f591d75a6739f5d4efdbba0806e88507864b8e |
21-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
minor improvement to common.Utils needed for new TKO
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1876 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
|
| ef37eccb66c415fdb6a8fe63244fe8545463719f |
21-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
support real right-click events. GWT doesn't support this but will in the next 1.5 RC, but until then, we'll need this hackery to make it work. this is also definitely not cross-browser compatible, but it could be made so if necessary.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1874 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
i/RightClickTable.java
|
| 5524adf7fc9d923ac3b6f7e7fa72158a5625460b |
21-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-unified code for table actions (select all/none and table-wide actions menu) between AFE and new TKO
-extracted non-TKO-specific code for ContextMenu into common.ui.ContextMenu
-moved TableActionsPanel to common.ui
-made JobListView use TableActionsPanel instead of its old private version of it
-made AfeClient module use standard.css stylesheet, since TableActionsPanel depends on it
-added checkbox to host tables to enable/disable filtering on ACL-accessible hosts, and got rid of now-unnecessary RpcHostTable class
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1873 592f7852-d20e-0410-864c-8624ca9c26a4
able/FieldFilter.java
i/ContextMenu.java
i/TableActionsPanel.java
|
| 9865997a354f669584c1cc3ef210efbdefb9a508 |
17-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-fixed url redirection for /tko URLs in debug server, to ease development pain
-changed links in job details table a bit (added status log link and changed text)
-change rpc_utils.py to handle datetime.date objects
-various minor changes needed for new TKO
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1861 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
able/DataSource.java
able/RpcDataSource.java
i/SimpleHyperlink.java
|
| 77f95db6250c71693f4775bb7b6f8876cb536000 |
17-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-move log file URL logic to common.Utils
-make retrieve_logs.cgi use Location header instead of Refresh; this works with XmlHttpRequests
-small fix to JsonRpcProxy to show better error data in some cases
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1860 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
tils.java
|
| 35dbd8414c0e7022a6a4b54f7ef16b5ff51ae53b |
16-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
introduced distinction between clickable and non-clickable widgets in DataTable; this allows read-only widgets that will still generate a row click event when clicked. this was necessary for new TKO development.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1839 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
able/DynamicTable.java
|
| 9f8a27b21824eb4a0f1c977ead46aea269b66e53 |
14-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
change DataSource (and subclasses) and DynamicTable to support multi-level sorting (sorting on multiple fields)
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1830 592f7852-d20e-0410-864c-8624ca9c26a4
able/ArrayDataSource.java
able/DataSource.java
able/DynamicTable.java
able/RpcDataSource.java
able/SelectionManager.java
|
| 3fa9db8b343151474035d7d199c318694d687c4f |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
improved selection support for AFE tables
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1813 592f7852-d20e-0410-864c-8624ca9c26a4
able/SelectionManager.java
|
| 12fbfde376d7748085be73f9f45e46f7d3433590 |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Fix some issues from findbugs.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1812 592f7852-d20e-0410-864c-8624ca9c26a4
i/DoubleListSelector.java
|
| 6f1593c98487664a6c330a638e6645dc39b4aca3 |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
some changes to support saved queries for new TKO
-migration to add saved_queries table. this is different from the existing query_history table. this feature is incompatible with the old one and I didn't want to interfere with the old one.
-various modifications to history handling across the board to allow better support for saved queries (the url will show up as just "saved_query=123", without all the extra crap)
-refactoring of apache_auth.py to allow new TKO to use it without using all the Django auth crap
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1810 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
i/CustomTabPanel.java
|
| 9d821ab7d97c677a63589e6d71ee3c9da46f7077 |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Made use of the new Widget functionality in DataTable and added checkboxes to
JobTable. JobListView now makes use of the SelectionManager and its checkboxes
to allow mulitple persistent selection of entries. This required some small
change to the behvavior of SelectionManager -- namely that it no longer
subscribes to the table itsef. This required some change to HostSelector which
acts on HostTable (it now does the listening to the table and calls the
SelectionManager methods directly). Added hyperlinks for "Select All" "DeSelect
All" and "Abort Selected" to the JobListView. Added a new rpc call "abort_jobs"
which takes a list of ids of jobs to abort.
Signed-off-by: Travis Miller <raphtee@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1809 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
able/SelectionManager.java
able/TableClickWidget.java
|
| ca67229c5d9d3d6d5a94164338cedb1db6fc49ca |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
rewrite history handling code to support generic storage of keyvals in the history token
-added support to Utils for encoding and decoding keyvals as GET args
-modify TabView and CustomTabPanel to use it for history token handling
-modify existing views that use history to use keyvals instead of the old ad-hoc format
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1807 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
i/CustomTabPanel.java
i/DetailView.java
i/TabView.java
|
| 1e935f132c1a1d2aad7bad28bfa9d030f5d9393d |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-modify django-directives to support multiple Django servers
-modify JsonRpcProxy to support multiple proxies to different URLs
-add AFE RPC get_hqe_percentage_complete to get percentage of HQE's matching some filter that are complete
-ensure user-supplied WHERE conditions have %'s escaped
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1806 592f7852-d20e-0410-864c-8624ca9c26a4
sonRpcProxy.java
|
| a334a8b203268d4a53dd39130add56874eabd012 |
11-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
some changes to CustomTabPanel to support a common area between tabs, and a new DoubleListSelector widget. both are used by the new TKO interface.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1805 592f7852-d20e-0410-864c-8624ca9c26a4
i/CustomTabPanel.java
i/DoubleListSelector.java
|
| affe09b5a82a1ec1a6c8f19571e07bb9f901abe0 |
10-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Narrowing the access modifiers on mutable static fields, to protect
against accidental or intentional modification of the fields' contents.
Note: Apply the "Some additions to autotest.common.Utils..." patch before
applying this one.
Risk: low
Visibility: low
Signed-off-by: James Ren <jamesren@google.com>
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1796 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
able/BooleanFilter.java
|
| 94b698cacab819b42104ce0db68aa63b68f4d1d1 |
08-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Added the ability to insert widgets into a column of DataTable.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1778 592f7852-d20e-0410-864c-8624ca9c26a4
able/DataTable.java
able/DynamicTable.java
able/TableClickWidget.java
|
| a7c7a582e9774aa24a9f608fbb1dfcfb9e59bb0d |
08-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Some additions to autotest.common.Utils made during new TKO development
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1777 592f7852-d20e-0410-864c-8624ca9c26a4
tils.java
able/SelectionManager.java
|
| 7f69e4383fa7be06c28fe54d1a0c834fa1de313a |
08-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
small change to StaticDataRepository needed for new TKO development
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1774 592f7852-d20e-0410-864c-8624ca9c26a4
taticDataRepository.java
|
| 6bc47015cce0ebc2fc255d3950bfeaf4851f36fd |
03-Jul-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Refactoring to eliminate warnings and (slightly) improve performance.
Added @Override annotations, and added parameterizations for generic
collections. Made small performance tweaks.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1761 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
SONArrayList.java
sonRpcProxy.java
taticDataRepository.java
nmodifiableSublistView.java
tils.java
able/ArrayDataSource.java
able/BooleanFilter.java
able/DataTable.java
able/DynamicTable.java
able/FieldFilter.java
able/Filter.java
able/LinkSetFilter.java
able/ListFilter.java
able/MultipleListFilter.java
able/RpcDataSource.java
able/SearchFilter.java
able/SelectionManager.java
able/SimpleFilter.java
i/DetailView.java
i/NotifyManager.java
i/Paginator.java
i/SimpleHyperlink.java
i/TabView.java
|
| c9d462b1b48a8cd109308453dd5eb610dd7108cb |
28-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
Separating the Labels input field in the Create Job interface;
platforms and other labels are now separate. User can select zero or
one platform, and an unlimited number of other labels.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1748 592f7852-d20e-0410-864c-8624ca9c26a4
able/TableDecorator.java
|
| 9b53349896f215b44ee0d39e9002da0a4c260554 |
28-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
some slight fixes to page refresh logic to make sure history works correctly (ran into issues during new TKO development)
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1747 592f7852-d20e-0410-864c-8624ca9c26a4
able/LinkSetFilter.java
i/CustomTabPanel.java
i/TabView.java
|
| acdbe3535529a24555d874a8038993c62fd690c2 |
06-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
-moved StaticDataRepository to autotest.common so new TKO can use it
-moved most logic from AfeClient into CustomTabPanel so new TKO can share it
-converted JsonRpcProxy to use new RequestBuilder in place of deprecated HTTPRequest
-converted JSONArrayList to use generics
-few more leftover changes from GWT reorganization
This CL introduces dependency on GWT 1.5 so you'll need to upgrade before using this. It's a painless upgrade.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1623 592f7852-d20e-0410-864c-8624ca9c26a4
SONArrayList.java
sonRpcProxy.java
taticDataRepository.java
i/CustomTabPanel.java
|
| e3f6868dac3b4c4714637d12b93d97823011a35c |
05-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
GWT reorg part 3
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1614 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
SONArrayList.java
sonRpcCallback.java
sonRpcProxy.java
impleCallback.java
nmodifiableSublistView.java
tils.java
able/ArrayDataSource.java
able/BooleanFilter.java
able/DataSource.java
able/DataTable.java
able/DynamicTable.java
able/FieldFilter.java
able/Filter.java
able/LinkSetFilter.java
able/ListFilter.java
able/MultipleListFilter.java
able/RpcDataSource.java
able/SearchFilter.java
able/SelectionManager.java
able/SimpleFilter.java
able/TableDecorator.java
i/CustomTabPanel.java
i/DetailView.java
i/ElementWidget.java
i/NotifyManager.java
i/Paginator.java
i/SimpleHyperlink.java
i/TabView.java
|
| a2216e7e327b464ac03932b4add2983e9052bc79 |
05-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
GWT reorg part 2
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1613 592f7852-d20e-0410-864c-8624ca9c26a4
ustomHistory.java
SONArrayList.java
sonRpcCallback.java
sonRpcProxy.java
impleCallback.java
nmodifiableSublistView.java
tils.java
i/CustomTabPanel.java
i/DetailView.java
i/ElementWidget.java
i/NotifyManager.java
i/Paginator.java
i/SimpleHyperlink.java
i/TabView.java
|
| ee4baa6495590c14c933f1fafa37d1843bbee996 |
05-Jun-2008 |
showard <showard@592f7852-d20e-0410-864c-8624ca9c26a4> |
GWT reorg step 1. This is just too difficult to do in one step. This temporarily breaks GWT but we'll just have to accept that. It'll be fixed soon.
git-svn-id: http://test.kernel.org/svn/autotest/trunk@1612 592f7852-d20e-0410-864c-8624ca9c26a4
able/ArrayDataSource.java
able/BooleanFilter.java
able/DataSource.java
able/DataTable.java
able/DynamicTable.java
able/FieldFilter.java
able/Filter.java
able/LinkSetFilter.java
able/ListFilter.java
able/MultipleListFilter.java
able/RpcDataSource.java
able/SearchFilter.java
able/SelectionManager.java
able/SimpleFilter.java
able/TableDecorator.java
|