| ac8805e7e9bd40c03baf44e37b26f28d9b763ab5 |
16-Mar-2013 |
Gabe Black <gabeblack@chromium.org> |
Get rid of some crufty macros.
These were macros that were never used, or that were only set to one thing and
could be substituted up front.
I left in code guarded by the HAVE_ENDIAN_H and HAVE_LITTLE_ENDIAN macros even
though those are never defined because they guard a reportedly significantly
faster implementation of some functionality, at least according to a comment
in the source. It would be a good idea to enable that code path and see if it
really does make a big difference before removing it entirely.
BUG=None
TEST=Built for Link, Daisy, and the host with FEATURES=test. Built depthcharge
for Link and booted in normal mode.
BRANCH=None
Change-Id: I934a4dd0da169ac018ba07350d56924ab88b1acc
Signed-off-by: Gabe Black <gabeblack@google.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/45687
Reviewed-by: Randall Spangler <rspangler@chromium.org>
Commit-Queue: Gabe Black <gabeblack@chromium.org>
Tested-by: Gabe Black <gabeblack@chromium.org>
lcl_internal.h
|
| 8b6da26a6e5978a43233f7a43c7bab5889d3817a |
07-Jun-2012 |
Kees Cook <keescook@chromium.org> |
tlcl: add GetOwner command
Since the "ownership" permament flag does not indicate if the TPM is
currently owned, the state of TPM Ownership must be read via a Capability
read of TPM_CAP_PROP_OWNER. This adds the "getownership" function.
BUG=chromium-os:22172
TEST=x86-alex build & manual test
Change-Id: I2fc9e933e891ba40190d008436b22496dced1c93
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/24784
Reviewed-by: Will Drewry <wad@chromium.org>
lcl_structures.h
|
| f0605cbdc36f58829a908a3333e438c565c8c7af |
01-Mar-2012 |
Kees Cook <keescook@chromium.org> |
tpm_lite: implement TPM_GetRandom
Provide TPM_GetRandom function to library callers.
BUG=chromium-os:22172
TEST=lumpy build & manual testing
Change-Id: Id604fd92490ba697033158a580b0b4df1d975932
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/17120
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
lcl_structures.h
|
| 946370d012a809bba833ff9d37fe0ce86af09860 |
09-Jan-2012 |
Kees Cook <keescook@chromium.org> |
tpmc: add PCR reading function
Add ability to report a single PCR value via the tpmc utility. Using
/sys/devices/platform/tpm_tis/pcrs is too slow, since it reads all
PCRs before returning. Anything wanting to read PCR0 on a time-critical
path needs maximum speed.
BUG=chromium-os:22172
TEST=install and test x86-alex.
Change-Id: I2d450961d33fa314d54b909135a74aa756279ec6
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/13891
Reviewed-by: Luigi Semenzato <semenzato@chromium.org>
lcl_structures.h
|
| 050785c31210176e0a6202e320a02afc21c2640b |
16-Mar-2011 |
Luigi Semenzato <semenzato@google.com> |
Bump tlcl_structures.h.
Change-Id: I9346c02244246b82cc6fe7c60090173ff650efc1
BUG=chromium-os:433
TEST=none
Review URL: http://codereview.chromium.org/6667050
lcl_structures.h
|
| baa3bbe7a50a4bc7d76ebbc92652a64796c5af5a |
23-Feb-2011 |
Rong Chang <rongchang@chromium.org> |
Move tpm lite API to common include path
In order to run test cases in both Linux user mode and u-boot command
mode. The API header tlcl.h must be accessed by both ebuilds.
Change-Id: Ic027dc118f26666b88bf54c511e2455a55e4eb8f
BUG=chromium-os:10497
TEST=emerge vboot_reference-firmware successfully
Review URL: http://codereview.chromium.org/6469089
lcl.h
|
| 5d9509cbdee7b9c8dd91ed47d967569dbb9af83d |
16-Dec-2010 |
Che-Liang Chiou <clchiou@chromium.org> |
vboot TPM stub functions return error codes
TlclStubInit, TlclCloseDevice, and TlclOpenDevice were void functions but
should return error codes.
BUG=chromium-os:6695
TEST=RUNTESTS=1 make && emerge successfully
Review URL: http://codereview.chromium.org/5796005
Change-Id: I8ddbf8b1f080d98ff6ed42c4a675fbda5b17eef1
lcl.h
|
| 89678602e66df24dea75b384ce079519cb8ec2a4 |
09-Nov-2010 |
Che-Liang Chiou <clchiou@chromium.org> |
Fix integration bugs (vboot side)
BUG=chromium-os:8621
TEST=See below
1. Build and run tests of vboot (including linktest)
$ make && make runtests
2. Check if *_stub.o are not in vboot_fw.a
$ nm /build/<board>/usr/lib/vboot_fw.a | grep _stub.o
3. Build and boot x86-generic image
$ ./build_packages --board=x86-generic && ./build_image --board=x86-generic
(Then successfully boot the image you just built)
See CL=4372001 for u-boot side changes
Review URL: http://codereview.chromium.org/4266002
Change-Id: Icc2bcc551c998f370e4b737fbe442ebf029cd81c
lcl.h
ss_constants.h
|
| a7e19cffbee540a130d16b3b93ebfe250a774358 |
16-Sep-2010 |
Luigi Semenzato <semenzato@google.com> |
Add new files: two tests, one common file, one program to set things up.
Change-Id: I4c9b7a937103f3978cbed6629ee4057018b80eae
More cleanup. Also allow some tests to run even when TPM is already started.
Change-Id: I23558b96a1de55bbeca42dbf2e44f6802a0ec85b
Reorganize and standardize behavior of tests.
Change-Id: Id32fd09211a72deaa66a3dd0f973d35506ff96f2
BUG=433
TEST=ran all the tests I could run without TPM-free BIOS
Review URL: http://codereview.chromium.org/3389004
lcl.h
|
| 528f6a20dbcf6aeca9fd4825984719038040af9c |
09-Sep-2010 |
Randall Spangler <rspangler@chromium.org> |
fix missing constant
Change-Id: I26d7d725cb429394e24be40a2f362b7ff160f4ee
BUG=none
TEST=make && make runtests (and build into test BIOS)
Review URL: http://codereview.chromium.org/3337017
ss_constants.h
|
| 1fe1607679a17a37ab6be390e2f04155e5c37e8e |
02-Sep-2010 |
Randall Spangler <rspangler@chromium.org> |
TBR: reviewed in person with semenzato
ss_constants.h
|
| 89a02c194f1b6da0de7f98784d85e6827c3a1aec |
01-Sep-2010 |
Luigi Semenzato <semenzato@google.com> |
Make TPM datagrams const, since they cannot be modified in the RO firmware.
Change-Id: I7f135584536c7437824ae65f74a8f7ef27c28665
BUG=
TEST=
Review URL: http://codereview.chromium.org/3271006
lcl.h
lcl_structures.h
|
| 3da063e3f7612464a41a4c9b2b31fb7eade57a13 |
31-Aug-2010 |
Luigi Semenzato <semenzato@google.com> |
Add resume command (TPM_Startup(ST_STATE))
Change-Id: Ia85c3cdbcb74c6cd8e7bd53c51eaccc98b13677e
BUG=
TEST=
Review URL: http://codereview.chromium.org/3232006
lcl.h
lcl_structures.h
|
| 377557fcb260c9b41abc36ebba5759336436e59c |
31-Aug-2010 |
Luigi Semenzato <semenzato@google.com> |
Add physical presence initialization and locking to one-time initializations.
Change-Id: If2b6041fe93bc97885e45bbb0cf7e1b81cb06c18
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3229011
lcl.h
lcl_structures.h
|
| 1d83dd1ba5b825407a8e17972c54577d14ba173d |
30-Aug-2010 |
Luigi Semenzato <semenzato@google.com> |
Add a command to enable the physical presence command.
Change-Id: Id8b6ac3c75d1ee34237cde8adde55cea33b25889
Review URL: http://codereview.chromium.org/3163045
lcl.h
lcl_structures.h
|
| 5896b9664d088699e246de964a7c374af663a34e |
25-Aug-2010 |
Luigi Semenzato <semenzato@google.com> |
Added new commands and reactivated full rebuild after fixing for ARM ebuild.
Review URL: http://codereview.chromium.org/3116025
Change-Id: Ideb82562f6b1c3ce5cd9e0b79de250d0a7bd976e
lcl.h
lcl_structures.h
ss_constants.h
|
| 4abede35afc8b5ecc8165d5d79f77c203bce51fc |
13-Aug-2010 |
Randall Spangler <rspangler@chromium.org> |
Add structs for TPM NV simplification. Now uses only 2 NV spaces, one for firmware and one for kernel.
Changed TlclRead / TlclWrite to take void* / const void* to reduce typecasts.
Much restructuring of rollback_index.c.
Fixed a version-packing bug in rollback_index.c (& --> |)
BUG:chrome-os-partner:304
TEST:manual testing of all code flows on CRB
Review URL: http://codereview.chromium.org/3084030
lcl.h
|
| e72291c636ee690dc656f5c274e02ed726929527 |
10-Aug-2010 |
Luigi Semenzato <semenzato@google.com> |
Command-line utility to execute TPM commands bypassing the TSS stack.
Review URL: http://codereview.chromium.org/3149001
pm_error_messages.h
|
| 205190d4ae8080298d9d1b580dd95c885f2af42c |
06-Aug-2010 |
Randall Spangler <rspangler@chromium.org> |
Pay attention to TPM communication errors
BUG=none
TEST=make && make runtests
Review URL: http://codereview.chromium.org/3078028
lcl.h
ss_constants.h
|
| 553d00ec86fed95888dcaff1b911ce8c444d03fd |
20-Jul-2010 |
Gaurav Shah <gauravsh@chromium.org> |
(In the right repository this time.)
Do not directly manipulate global structs. Work on the local copy instead.
In firmware-land, globals are a bad idea.
Review URL: http://codereview.chromium.org/3027011
lcl_structures.h
|
| 3e1081fb71385d72fd3a522599c35b516dda7a37 |
19-Jul-2010 |
Randall Spangler <rspangler@chromium.org> |
Add lots of debugging to TPM library.
Temporarily disable TPM in developer mode.
Review URL: http://codereview.chromium.org/3041005
lcl.h
|
| 39f66114c03639715cb88774255f066a2d942557 |
14-Jul-2010 |
Randall Spangler <rspangler@chromium.org> |
Add tpm lite to vboot reference
Review URL: http://codereview.chromium.org/2919010
lcl.h
lcl_internal.h
lcl_structures.h
ss_constants.h
|