History log of /packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
Revision Date Author Comments (<<< Hide modified files) (Show modified files >>>)
da2acb9ee8cd7cf4082f3b159f7a302d84e953d0 04-Aug-2017 Scott Randolph <randolphs@google.com> Minor cleanup to go along with matching vhal update

Standardize a few constant names, and a few miscellanious clean ups (but
not net functionality change).

Test: runtest -x
packages/services/Car/tests/carservice_test/src/com/android/car/test/CarAudioFocusTest.java
(plus 3 others) on Mojave

Change-Id: I70c73f511a63aa714414acaca5bdc4e929946959
Bug: 65384336
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
9fbc3e79b151cd1e3283eefbe5a345ceedf2b729 17-Aug-2017 Yao Chen <yaochen@google.com> Cherry-pick and manually resolved the conflicts.

Note that this is a cherry-pick of ag/2745105 and there is no intent to
modify the original CL except for conflicts resolving.

Map the VehicleAudioContextFlag.UNKNOWN_FLAG to current context.

+ When vehicle hal is reporting volume change on unknown context, we
will map it to the current context. This makes partner's
implementation easier and our volume handling more robust.

+ Added test.

Bug: 62064580
Test: runtest -x packages/services/Car/tests/carservice_test/src/com/android/car/test/CarVolumeServiceTest.java

Change-Id: I488967e48e96f15f0094337282ef0b6f25465754
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
543ef8915362454aa2ea13b61ebe9f6d21a8070c 28-Mar-2017 Yao Chen <yaochen@google.com> Fix CarVolumeServiceTest failure.

1. VolumeLimit test failure
- The min config value is always 0 in the new vhal. So the test for min
volume is removed.

2. testSuppressVolumeUI failure
- The reason is the car service code runs in the same process with the
test. When the test waits for a callback, it blocked the main thread
on which the Handler is running
- Moved the Handler in the car volume controller to a handler thread.

Test: runtest -x packages/services/Car/tests/carservice_test/ \
-c com.android.car.test.CarVolumeServiceTest

Change-Id: I1a11edfc6c330d7cbda0e6eb5afb94ac1c5eb4c6
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
0d07c76bbc788fba8c77d8e932330ab22ec6ba27 04-Nov-2016 Pavel Maltsev <pavelm@google.com> Migrating Car service to new Vehicle HAL

- make car service work directly with Vehicle HAL
- getting rid of protobufs and dependencies on VNS
- get rid of CarTestManager / CarTestService and refactor
tests accordingly
- reworked ICarImpl to pass dependencies rather than
using singletons for better testing experience

Test: existing test should work, although some of the tests
(esp. audio) are broken and we will fix them in follow up CLs

Bug: b/31971746
Change-Id: I229969af332304ba3b1718f130cdf22038e86fad
Tests: tests adjusted to new data structures
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
f9215209e0f425d2fc570bef37dad959c82d2e9e 10-Oct-2016 Keun-young Park <keunyoung@google.com> update TODOs

- assign bugs for future items
- remove it if not necessary any more
- also remove unused CarServiceApplication

bug: 31970410

Change-Id: I3f5ecb8a80fd450afdb58007e07e88527132edb9
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
1b1247b5648975dd41ee73c25425825abb256234 30-Sep-2016 Vitalii Tomkiv <vitalit@google.com> Change logging for car packages.

Removed PII information.
Disable all debug logging by default.
bug: 31811554
Test: manual build.

Change-Id: If95a27a1bb514f79f2acd65c21f5e7b29345a361
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
4df5a286dff8b597cefaf012bde5be02000c00f3 24-Aug-2016 Yao Chen <yaochen@google.com> Hide volume UI after we set volume due to context change.

Change-Id: I56d66b6cdabe13b5502a382ba38e70cbbca7480e
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
2612bb4b5b4043a3833e4e07e7dc788af84def09 20-Aug-2016 Yao Chen <yaochen@google.com> Save volumes in settings.

If car audio module does not have persistent memory, we will save per
car audio context volume in settings. So that the volumes will be
remembered after reboot.

Change-Id: I5ea485e8aed024b985d8342dbabfd4b8cf556bd5
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
c837829409a384cf4e081987b84d4a2ac9a2808c 09-Jul-2016 Keun-young Park <keunyoung@google.com> add dump to volume service

- helps tracking volume related issues

bug: 30021451
Change-Id: Id7ee5d251af345281e5408f1f5df94f467b97977
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
d36a995ad9a1d864c2b0d1c407220ecc176be925 24-May-2016 Keun-young Park <keunyoung@google.com> more volume support

- add master volume only case:
some H/W can have only single master volume.
In that case, all volume change will be sent to stream 0.
TODO: do better handling of master volule only case

- add no_auto_get in vns_policy.xml so that subscription does not
lead into auto get for some properties

bug: 28175862

Change-Id: I0aa7a8a54385704620c28aaa0f21898bdc1e8164
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
740c2700480438a4216b853dd4fea0a4b51b53f9 12-May-2016 Yao Chen <yaochen@google.com> Handle the audio context 0 in car volume service.

Change-Id: Ia4085942088bdc91c62b42b073de806fdf6a57a0
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
75279c94a7805218e7ced7456a144cc8c548fefb 06-May-2016 Yao Chen <yaochen@google.com> Some updates to CarVolumeService

+ CarVolumeController should keep volume information for each car audio
context, instead of for each android logial stream. As a result, Radio
and music can have different volumes.

+ Added more debug logging.

Bug: 28348447
Change-Id: I15cc66c7ffdfd65c0bb326b288969a01f86f45ea
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
031ec0a528739bb1cc310ac5a6d34fb0a0f3f1b5 29-Apr-2016 TreeHugger Robot <treehugger-gerrit@google.com> Merge "Handle volume during incoming call ringing." into nyc-car-dev
f162811018f2a52e3226ada1b715d188084ec8b6 29-Apr-2016 Yao Chen <yaochen@google.com> Handle volume during incoming call ringing.

+ intercept the volume key when ringer is ringing, we will mute the
ringer immediately. This is consistent with phone's behavior.

Bug: 28447613

Change-Id: I0331fd888bd41341d0082fa6f3e441e9fd9a1ca6
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
7ea2107e6cc92b32628f893978ab3fc444b89bec 28-Apr-2016 Keun-young Park <keunyoung@google.com> follow-up fix failing carservice tests

- last patch missed

bug: 28387670
Change-Id: I6d4c29624308f3b6d4c3bbc43d19437da4cc0fec
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
021310d76665163d6a7907d056b3ef43e6e910e4 26-Apr-2016 Keun-young Park <keunyoung@google.com> fix failing carservice tests

- revamp hal release init order during mocking:
release hal after service release and init hal before service init
- fix wrong order of mocking state setting. This led into
bringing audio muting while in mocking.
- remove some default properties from CarEmulator
as default dummy value does not work.
- add synchronization for mCarVolumeController
- handle ServiceSpecificException for get call
- reduce init time for non-functioning vhal by caching
volule get calls in init
- update CarAudioFocusTest
- remove CarConnectionListenerInMockingTest as connection state
is no longer notified when mocking starts

bug: 28387670

Change-Id: Idf975a3b0ed86b111618487eedbc380c5662a487
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java
c4d442f4a0d3acf90b1c7a1dd7c222a8f32a193f 08-Apr-2016 Yao Chen <yaochen@google.com> Add CarVolumeService

Things added in this cl:
+ Hook up hardware volume keys to CarVolumeService to directly update
volume for current audio context.
+ Added volume control apis in AudioManager, and the real implementation
is done in CarVolumeService
+ The volume updates from car is broadcast to listeners through
IVolumeController api which is already in framework. SystemUI is using
this api to listen to volume changes (through AudioManager).
+ Added new permission for volume controls

Main TODOs left:
+ Multi stream playing at the same time. This can be done through
adjustign software mixer gain on Android side. Utility functions to
compute the gain is added in VolumeUtils, but it's not used yet in
CarVolumeService.

+ Hook up with Settings so per stream volume can be persisted across
multiple boots.

Bug: 27595951

Change-Id: I3a63e423d4e0a347215af65e79926212e4503d1b
/packages/services/Car/service/src/com/android/car/CarVolumeControllerFactory.java