descriptor_sets.h revision e1cc7cf9e8a7808209ecc45df2421f3a494daccc
1fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc.
2fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation
3fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc.
4fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Copyright (C) 2015-2016 Google Inc.
5fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
6fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Licensed under the Apache License, Version 2.0 (the "License");
7fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * you may not use this file except in compliance with the License.
8fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * You may obtain a copy of the License at
9fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
10fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *     http://www.apache.org/licenses/LICENSE-2.0
11fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
12fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Unless required by applicable law or agreed to in writing, software
13fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * distributed under the License is distributed on an "AS IS" BASIS,
14fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * See the License for the specific language governing permissions and
16fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * limitations under the License.
17fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
18fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com>
19fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis */
20fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#ifndef CORE_VALIDATION_DESCRIPTOR_SETS_H_
21fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define CORE_VALIDATION_DESCRIPTOR_SETS_H_
22fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
23fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// Check for noexcept support
24fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#if defined(__clang__)
25fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#if __has_feature(cxx_noexcept)
26fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define HAS_NOEXCEPT
27fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#endif
28fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#else
29fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#if defined(__GXX_EXPERIMENTAL_CXX0X__) && __GNUC__ * 10 + __GNUC_MINOR__ >= 46
30fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define HAS_NOEXCEPT
31fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#else
32fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#if defined(_MSC_FULL_VER) && _MSC_FULL_VER >= 190023026 && defined(_HAS_EXCEPTIONS) && _HAS_EXCEPTIONS
33fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define HAS_NOEXCEPT
34fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#endif
35fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#endif
36fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#endif
37fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
38fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#ifdef HAS_NOEXCEPT
39fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define NOEXCEPT noexcept
40fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#else
41fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#define NOEXCEPT
42fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#endif
43fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
44fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include "core_validation_error_enums.h"
45cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis#include "core_validation_types.h"
46fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include "vk_layer_logging.h"
47cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis#include "vk_layer_utils.h"
48fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include "vk_safe_struct.h"
49fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include "vulkan/vk_layer.h"
50cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis#include <memory>
51fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include <unordered_map>
52cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis#include <unordered_set>
53fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis#include <vector>
54fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
55fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// Descriptor Data structures
56fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
57fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis/*
58fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * DescriptorSetLayout class
59fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
60fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Overview - This class encapsulates the Vulkan VkDescriptorSetLayout data (layout).
61fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *   A layout consists of some number of bindings, each of which has a binding#, a
62fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *   type, descriptor count, stage flags, and pImmutableSamplers.
63fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
64fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Index vs Binding - A layout is created with an array of VkDescriptorSetLayoutBinding
65fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  where each array index will have a corresponding binding# that is defined in that struct.
66fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  This class, therefore, provides utility functions where you can retrieve data for
67fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  layout bindings based on either the original index into the pBindings array, or based
68fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  on the binding#.
69fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  Typically if you want to cover all of the bindings in a layout, you can do that by
70fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *   iterating over GetBindingCount() bindings and using the Get*FromIndex() functions.
71fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  Otherwise, you can use the Get*FromBinding() functions to just grab binding info
72fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *   for a particular binding#.
73fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *
74fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis * Global Index - The "Index" referenced above is the index into the original pBindings
75fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  array. So there are as many indices as there are bindings.
76fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  This class also has the concept of a Global Index. For the global index functions,
77fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  there are as many global indices as there are descriptors in the layout.
78fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  For the global index, consider all of the bindings to be a flat array where
79fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  descriptor 0 of pBinding[0] is index 0 and each descriptor in the layout increments
80fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  from there. So if pBinding[0] in this example had descriptorCount of 10, then
81fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  the GlobalStartIndex of pBinding[1] will be 10 where 0-9 are the global indices
82fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis *  for pBinding[0].
83fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis */
84cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisnamespace cvdescriptorset {
85fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisclass DescriptorSetLayout {
86fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis  public:
87fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // Constructors and destructor
88fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    DescriptorSetLayout(debug_report_data *report_data, const VkDescriptorSetLayoutCreateInfo *p_create_info,
89fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis                        const VkDescriptorSetLayout layout);
90fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // Straightforward Get functions
91cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorSetLayout GetDescriptorSetLayout() const { return layout_; };
92cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetTotalDescriptorCount() const { return descriptor_count_; };
93cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDynamicDescriptorCount() const { return dynamic_descriptor_count_; };
94cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetBindingCount() const { return binding_count_; };
95cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Fill passed-in set with bindings
96cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    void FillBindingSet(std::unordered_set<uint32_t> *) const;
97fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // Return true if given binding is present in this layout
98cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool HasBinding(const uint32_t binding) const { return binding_to_index_map_.count(binding) > 0; };
99fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // Return true if this layout is compatible with passed in layout,
100fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    //   else return false and update error_msg with description of incompatibility
101cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool IsCompatible(const DescriptorSetLayout *, std::string *) const;
102cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Return true if binding 1 beyond given exists and has same type, stageFlags & immutable sampler use
103cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool IsNextBindingConsistent(const uint32_t) const;
104fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // Various Get functions that can either be passed a binding#, which will
105fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    //  be automatically translated into the appropriate index from the original
106fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    //  pBindings array, or the index# can be passed in directly
107cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorSetLayoutBinding const *GetDescriptorSetLayoutBindingPtrFromBinding(const uint32_t) const;
108cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorSetLayoutBinding const *GetDescriptorSetLayoutBindingPtrFromIndex(const uint32_t) const;
109cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDescriptorCountFromBinding(const uint32_t) const;
110cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDescriptorCountFromIndex(const uint32_t) const;
111cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromBinding(const uint32_t) const;
112cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromIndex(const uint32_t) const;
113cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromGlobalIndex(const uint32_t) const;
114cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkShaderStageFlags GetStageFlagsFromBinding(const uint32_t) const;
115cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkSampler const *GetImmutableSamplerPtrFromBinding(const uint32_t) const;
116cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkSampler const *GetImmutableSamplerPtrFromIndex(const uint32_t) const;
117fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    // For a particular binding, get the global index
118d119d1f6896796f6387925babceff3924be76199Tobin Ehlis    //  These calls should be guarded by a call to "HasBinding(binding)" to verify that the given binding exists
119cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetGlobalStartIndexFromBinding(const uint32_t) const;
120cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetGlobalEndIndexFromBinding(const uint32_t) const;
121c20ad7c6c296ae63b46170068cf469edc5bfb995Tobin Ehlis    // For a particular binding starting at offset and having update_count descriptors
122c20ad7c6c296ae63b46170068cf469edc5bfb995Tobin Ehlis    //  updated, verify that for any binding boundaries crossed, the update is consistent
123c20ad7c6c296ae63b46170068cf469edc5bfb995Tobin Ehlis    bool VerifyUpdateConsistency(uint32_t, uint32_t, uint32_t, const char *, const VkDescriptorSet, std::string *) const;
124fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis
125fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis  private:
126fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    VkDescriptorSetLayout layout_;
127cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    std::unordered_map<uint32_t, uint32_t> binding_to_index_map_;
128cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    std::unordered_map<uint32_t, uint32_t> binding_to_global_start_index_map_;
129cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    std::unordered_map<uint32_t, uint32_t> binding_to_global_end_index_map_;
130cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // VkDescriptorSetLayoutCreateFlags flags_;
131fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    uint32_t binding_count_; // # of bindings in this layout
132958678d33c9de693ddbf4c914036d38635edd366Tobin Ehlis    std::vector<safe_VkDescriptorSetLayoutBinding> bindings_;
133fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    uint32_t descriptor_count_; // total # descriptors in this layout
134fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis    uint32_t dynamic_descriptor_count_;
135fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis};
136cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
137cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis/*
138cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis * Descriptor classes
139cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *  Descriptor is an abstract base class from which 5 separate descriptor types are derived.
140cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   This allows the WriteUpdate() and CopyUpdate() operations to be specialized per
141cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   descriptor type, but all descriptors in a set can be accessed via the common Descriptor*.
142cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis */
143cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
144cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis// Slightly broader than type, each c++ "class" will has a corresponding "DescriptorClass"
14537992b31e5e41117ec617517b4f6901733d41008Mark Lobodzinskienum DescriptorClass { PlainSampler, ImageSampler, Image, TexelBuffer, GeneralBuffer };
146cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
147cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass Descriptor {
148cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
149cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual ~Descriptor(){};
1506b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    virtual void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) = 0;
1516b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    virtual void CopyUpdate(const Descriptor *) = 0;
152cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual DescriptorClass GetClass() const { return descriptor_class; };
153cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Special fast-path check for SamplerDescriptors that are immutable
154cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsImmutableSampler() const { return false; };
155cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Check for dynamic descriptor type
156cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsDynamic() const { return false; };
157cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Check for storage descriptor type
158cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsStorage() const { return false; };
159cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool updated; // Has descriptor been updated?
160cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    DescriptorClass descriptor_class;
161a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis};
162cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis// Shared helper functions - These are useful because the shared sampler image descriptor type
163cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis//  performs common functions with both sampler and image descriptors so they can share their common functions
1649a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlisbool ValidateSampler(const VkSampler, const core_validation::layer_data *);
165b110cb87b9478586719d7f7dc769b350857366baTobin Ehlisbool ValidateImageUpdate(VkImageView, VkImageLayout, VkDescriptorType, const core_validation::layer_data *, std::string *);
166a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis
167cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass SamplerDescriptor : public Descriptor {
168cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
1696b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    SamplerDescriptor();
1706b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    SamplerDescriptor(const VkSampler *);
1716b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
1726b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void CopyUpdate(const Descriptor *) override;
173cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsImmutableSampler() const override { return immutable_; };
1746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    VkSampler GetSampler() const { return sampler_; }
175cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
176cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
177cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // bool ValidateSampler(const VkSampler) const;
178cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkSampler sampler_;
179cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool immutable_;
180cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
181cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
182cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass ImageSamplerDescriptor : public Descriptor {
183cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
1846b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    ImageSamplerDescriptor();
1856b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    ImageSamplerDescriptor(const VkSampler *);
1866b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
1876b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void CopyUpdate(const Descriptor *) override;
1887cf7f01f9ed038eff17df11320d0c58f03d81778Tobin Ehlis    virtual bool IsImmutableSampler() const override { return immutable_; };
1896b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    VkSampler GetSampler() const { return sampler_; }
1906b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    VkImageView GetImageView() const { return image_view_; }
1916b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    VkImageLayout GetImageLayout() const { return image_layout_; }
192cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
193cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
194cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkSampler sampler_;
195cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool immutable_;
196cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageView image_view_;
197cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageLayout image_layout_;
198cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
199cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
200cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass ImageDescriptor : public Descriptor {
201cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
2026b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    ImageDescriptor(const VkDescriptorType);
2036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
2046b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void CopyUpdate(const Descriptor *) override;
205b7bdfafcc0304aad5b4483787282953552ea3e64Norbert Nopper    virtual bool IsStorage() const override { return storage_; }
206cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageView GetImageView() const { return image_view_; }
207cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageLayout GetImageLayout() const { return image_layout_; }
208cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
209cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
210cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool storage_;
211cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageView image_view_;
212cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkImageLayout image_layout_;
213cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
214cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
215cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass TexelDescriptor : public Descriptor {
216cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
2176b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    TexelDescriptor(const VkDescriptorType);
2186b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
2196b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void CopyUpdate(const Descriptor *) override;
22013138d0514445fc70b23ecb2ce639326f76c7883Tobin Ehlis    virtual bool IsStorage() const override { return storage_; }
22113138d0514445fc70b23ecb2ce639326f76c7883Tobin Ehlis    VkBufferView GetBufferView() const { return buffer_view_; }
222cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
223cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
224cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkBufferView buffer_view_;
225cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool storage_;
226cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
227cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
228cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlisclass BufferDescriptor : public Descriptor {
229cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
2306b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    BufferDescriptor(const VkDescriptorType);
2316b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void WriteUpdate(const VkWriteDescriptorSet *, const uint32_t) override;
2326b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void CopyUpdate(const Descriptor *) override;
233cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsDynamic() const override { return dynamic_; }
234cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    virtual bool IsStorage() const override { return storage_; }
235cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkBuffer GetBuffer() const { return buffer_; }
236cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDeviceSize GetOffset() const { return offset_; }
237cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDeviceSize GetRange() const { return range_; }
238cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
239cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
240cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool storage_;
241cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool dynamic_;
242cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkBuffer buffer_;
243cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDeviceSize offset_;
244cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDeviceSize range_;
245cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
2467f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis// Structs to contain common elements that need to be shared between Validate* and Perform* calls below
2477f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstruct AllocateDescriptorSetsData {
2487f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis    uint32_t required_descriptors_by_type[VK_DESCRIPTOR_TYPE_RANGE_SIZE];
2497f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis    std::vector<cvdescriptorset::DescriptorSetLayout const *> layout_nodes;
2507f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis    AllocateDescriptorSetsData(uint32_t);
2517f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis};
2527e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Helper functions for descriptor set functions that cross multiple sets
2537e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// "Validate" will make sure an update is ok without actually performing it
254104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlisbool ValidateUpdateDescriptorSets(const debug_report_data *, const core_validation::layer_data *, uint32_t,
2559319aad73ddc9ceea3a19dc1b2a51e707b888f2dTobin Ehlis                                  const VkWriteDescriptorSet *, uint32_t, const VkCopyDescriptorSet *);
2567e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// "Perform" does the update with the assumption that ValidateUpdateDescriptorSets() has passed for the given update
257104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlisvoid PerformUpdateDescriptorSets(const core_validation::layer_data *, uint32_t, const VkWriteDescriptorSet *, uint32_t,
258104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis                                 const VkCopyDescriptorSet *);
2597e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Validate that Allocation state is ok
2607e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisbool ValidateAllocateDescriptorSets(const debug_report_data *, const VkDescriptorSetAllocateInfo *,
261e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis                                    const core_validation::layer_data *, AllocateDescriptorSetsData *);
2627e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Update state based on allocating new descriptorsets
26357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlisvoid PerformAllocateDescriptorSets(const VkDescriptorSetAllocateInfo *, const VkDescriptorSet *, const AllocateDescriptorSetsData *,
26457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis                                   std::unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> *,
26557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis                                   std::unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> *,
266b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis                                   const core_validation::layer_data *);
2677e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis
268cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis/*
269cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis * DescriptorSet class
270cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *
271cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis * Overview - This class encapsulates the Vulkan VkDescriptorSet data (set).
272cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   A set has an underlying layout which defines the bindings in the set and the
273cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   types and numbers of descriptors in each descriptor slot. Most of the layout
274cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   interfaces are exposed through identically-named functions in the set class.
275cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   Please refer to the DescriptorSetLayout comment above for a description of
276cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   index, binding, and global index.
277cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *
278cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis * At construction a vector of Descriptor* is created with types corresponding to the
279cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   layout. The primary operation performed on the descriptors is to update them
280cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   via write or copy updates, and validate that the update contents are correct.
281cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   In order to validate update contents, the DescriptorSet stores a bunch of ptrs
282cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   to data maps where various Vulkan objects can be looked up. The management of
283cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   those maps is performed externally. The set class relies on their contents to
284cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis *   be correct at the time of update.
285cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis */
286397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisclass DescriptorSet : public BASE_NODE {
287cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  public:
2889d17becd811b49e1ecf91a02eee22f9cf7cbc026Tobin Ehlis    using BASE_NODE::in_use;
289e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis    using BASE_NODE::cb_bindings;
290b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis    DescriptorSet(const VkDescriptorSet, const DescriptorSetLayout *, const core_validation::layer_data *);
291fda02154007d70e5c078c29585c5e8fdd90ebc5fTobin Ehlis    ~DescriptorSet();
292cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // A number of common Get* functions that return data based on layout from which this set was created
293cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetTotalDescriptorCount() const { return p_layout_ ? p_layout_->GetTotalDescriptorCount() : 0; };
294cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDynamicDescriptorCount() const { return p_layout_ ? p_layout_->GetDynamicDescriptorCount() : 0; };
295cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetBindingCount() const { return p_layout_ ? p_layout_->GetBindingCount() : 0; };
296cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromIndex(const uint32_t index) const {
297cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_ ? p_layout_->GetTypeFromIndex(index) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
298cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
299cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromGlobalIndex(const uint32_t index) const {
300cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_ ? p_layout_->GetTypeFromGlobalIndex(index) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
301cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
302cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorType GetTypeFromBinding(const uint32_t binding) const {
303cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_ ? p_layout_->GetTypeFromBinding(binding) : VK_DESCRIPTOR_TYPE_MAX_ENUM;
304cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
305cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDescriptorCountFromIndex(const uint32_t index) const {
306cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_ ? p_layout_->GetDescriptorCountFromIndex(index) : 0;
307cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
308cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetDescriptorCountFromBinding(const uint32_t binding) const {
309cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_ ? p_layout_->GetDescriptorCountFromBinding(binding) : 0;
310cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
311cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Return true if given binding is present in this set
312cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool HasBinding(const uint32_t binding) const { return p_layout_->HasBinding(binding); };
313cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Is this set compatible with the given layout?
314cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool IsCompatible(const DescriptorSetLayout *, std::string *) const;
315cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // For given bindings validate state at time of draw is correct, returning false on error and writing error details into string*
316cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool ValidateDrawState(const std::unordered_set<uint32_t> &, const std::vector<uint32_t> &, std::string *) const;
317cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // For given set of bindings, add any buffers and images that will be updated to their respective unordered_sets & return number
318cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // of objects inserted
319cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetStorageUpdates(const std::unordered_set<uint32_t> &, std::unordered_set<VkBuffer> *,
320cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis                               std::unordered_set<VkImageView> *) const;
3216b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis
3226b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    // Descriptor Update functions. These functions validate state and perform update separately
3236b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    // Validate contents of a WriteUpdate
3246b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    bool ValidateWriteUpdate(const debug_report_data *, const VkWriteDescriptorSet *, std::string *);
3256b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    // Perform a WriteUpdate whose contents were just validated using ValidateWriteUpdate
3266b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void PerformWriteUpdate(const VkWriteDescriptorSet *);
3276b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    // Validate contents of a CopyUpdate
3286b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    bool ValidateCopyUpdate(const debug_report_data *, const VkCopyDescriptorSet *, const DescriptorSet *, std::string *);
3296b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    // Perform a CopyUpdate whose contents were just validated using ValidateCopyUpdate
3306b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    void PerformCopyUpdate(const VkCopyDescriptorSet *, const DescriptorSet *);
331cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
332c20ad7c6c296ae63b46170068cf469edc5bfb995Tobin Ehlis    const DescriptorSetLayout *GetLayout() const { return p_layout_; };
333cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorSet GetSet() const { return set_; };
334cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Return unordered_set of all command buffers that this set is bound to
335e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis    std::unordered_set<GLOBAL_CB_NODE *> GetBoundCmdBuffers() const { return cb_bindings; }
336cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Bind given cmd_buffer to this descriptor set
337e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis    void BindCommandBuffer(GLOBAL_CB_NODE *cb_node) { cb_bindings.insert(cb_node); }
338e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis    // If given cmd_buffer is in the cb_bindings set, remove it
339e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis    void RemoveBoundCommandBuffer(GLOBAL_CB_NODE *cb_node) { cb_bindings.erase(cb_node); }
340cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkSampler const *GetImmutableSamplerPtrFromBinding(const uint32_t index) const {
341cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_->GetImmutableSamplerPtrFromBinding(index);
342cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
343cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // For a particular binding, get the global index
344cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetGlobalStartIndexFromBinding(const uint32_t binding) const {
345cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_->GetGlobalStartIndexFromBinding(binding);
346cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
347cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    uint32_t GetGlobalEndIndexFromBinding(const uint32_t binding) const {
348cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis        return p_layout_->GetGlobalEndIndexFromBinding(binding);
349cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    };
350cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    // Return true if any part of set has ever been updated
351cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool IsUpdated() const { return some_update_; };
352cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis
353cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis  private:
3546b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis    bool VerifyWriteUpdateContents(const VkWriteDescriptorSet *, const uint32_t, std::string *) const;
35536c6435049204bbdbd4909005b431a5717b8041eTobin Ehlis    bool VerifyCopyUpdateContents(const VkCopyDescriptorSet *, const DescriptorSet *, VkDescriptorType, uint32_t,
35636c6435049204bbdbd4909005b431a5717b8041eTobin Ehlis                                  std::string *) const;
357e2de40ad4581afb9c4b5f00c74d2a77918e2f4a7Tobin Ehlis    bool ValidateBufferUpdate(VkBuffer, VkDescriptorType, std::string *) const;
358fda02154007d70e5c078c29585c5e8fdd90ebc5fTobin Ehlis    // Private helper to set all bound cmd buffers to INVALID state
359fda02154007d70e5c078c29585c5e8fdd90ebc5fTobin Ehlis    void InvalidateBoundCmdBuffers();
360cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    bool some_update_; // has any part of the set ever been updated?
361cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    VkDescriptorSet set_;
362cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    const DescriptorSetLayout *p_layout_;
363cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis    std::vector<std::unique_ptr<Descriptor>> descriptors_;
364c52a0558d694535303b3dc7d6f0f1aa558febc54Tobin Ehlis    // Ptr to device data used for various data look-ups
3658718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis    const core_validation::layer_data *device_data_;
366cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis};
367fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis}
3686660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes#endif // CORE_VALIDATION_DESCRIPTOR_SETS_H_
369