b826967966bfab552d80d0609f9830eec9905c13 |
|
10-Aug-2016 |
Ben Zhang <benzh@chromium.org> |
scripts: Fix audio-tuning frontend with new WebAudio biquad filter implementation The spec of WebAudio biquad filter "lowpass" and "highpass" has been changed. Chrome's implementation was changed in 53.0.2768.0. The new implementation uses the Audio EQ Cookbook formula, different from the original one, but still expects Q in dB. See https://github.com/WebAudio/web-audio-api/issues/771 This patch adds detection of the filter implementation. If the browser uses the new formula, conversion of Q is made to simulate the original filter frequency response with the new formula. This ensures the audio-tuning playback is always consistent with the current CRAS DSP implementation, on any browser verion. BUG=chrome-os-partner:55365 TEST=DRC/EQ testing on Chrome before/after the filter change Change-Id: I3e67a9b87f94b228d173fa08dcaa0fe4df5ac64e Signed-off-by: Ben Zhang <benzh@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/367551 Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
db8d80e7b2c6dd91df52e3a121fa7f0882810e3d |
|
28-Apr-2015 |
Cheng-Yi Chiang <cychiang@chromium.org> |
audio_tuning: Add cross origin support In Chrome M42 and above, audio tag needs to have crossOrigin attribute set to access audio source served from different origin. Note that the header in the response from server should include Access-Control-Allow-Origin: *. Check crbug.com/477692 and crbug.com/477364 for detail. BUG=chromium:480768 TEST=run audio_tuning webpage and check an url with CORS support can play. Change-Id: I3c1cbf0ab8bb252ed4a848278dd389e6e52c8b2d Reviewed-on: https://chromium-review.googlesource.com/267724 Reviewed-by: Dylan Reid <dgreid@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
80a94bfb0e0f0cfb438b614074af3f43372d6a85 |
|
23-Apr-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
script: Fix audio-tuning frontend for web audio element name webkitAudioContext is renamed to AudioContext. webkitOfflineAudioContext is renamed to OfflineAudioContext. createGainNode in AudioConext is renamed to createGain. This CL fixes those element names so the site can work with both old and new version. Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> BUG=chromium:365989 TEST=run audio-tuning site on ubuntu desktop and chromeos Change-Id: Icd18cac04e7db9549c5d307e21bfde8ab764bcfe Reviewed-on: https://chromium-review.googlesource.com/196469 Reviewed-by: Chih-Chung Chang <chihchung@chromium.org> Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
14a75e49ac4aed5af5e2af61e9007885d2c65039 |
|
11-Mar-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
scripts: Fix audio-tuning frontend createMediaElementSource error When audio file is played in a loop, we don't need to reset source node in every loop. Now we just set the source node when there is a new file url being set. BUG=chrome-os-partner:26686 TEST=run audio-tuning frontend, check there is no error message complaining audioContext.createMediaElementSource gets an invalid argument. Also check that processing effect remains the same when playing a file in a loop. Change-Id: Ia75b732690a0d467be0c5096e78bef327780fd18 Reviewed-on: https://chromium-review.googlesource.com/189567 Reviewed-by: Chih-Chung Chang <chihchung@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
fee0261a882c659aaab25d98bad695755ab66cb2 |
|
11-Mar-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
scripts: Fix audio-tuning frontend emphasis_disabled config setting When setting config from UI or applying config from config file, drc.emphasis_disabled should be skipped since it is a tag and is different from other configs that can actually be set to the audio processing graph. BUG=chrome-os-partner:26686 TEST=run audio-tuning frontend and check console there is no error message complaining 'config' is not defined. Change-Id: Ia7cbfc09fb7a904bb81abd0ae9b44a9f4524e3f0 Reviewed-on: https://chromium-review.googlesource.com/189566 Reviewed-by: Chih-Chung Chang <chihchung@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
91977cf7045d3610c574af49f69c41a856c83c57 |
|
11-Mar-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
scripts: Fix audio-tuning frontend disable_emphasis detection error Currently drc.disable_emphasis is detected when user plays audio file. It should be detected in the webpage load time. Also, before disable_emphasis detection is done, save_config button should be disabled. When saving config, drc.disable_emphasis value should come from the variable which set by get_disable_emphasis function so that value will be not be changed when user loads a config file. BUG=chrome-os-partner:26686 TEST=run audio-tuning ui, save config and check drc.emphasis_disabled is in the config. Load a config with different drc.emphasis_disabled, then save config. Check drc.emphasis_disabled is not affected. Change-Id: I692534260f75df9e1632bb9d5a493ac048ba725a Reviewed-on: https://chromium-review.googlesource.com/189565 Reviewed-by: Chih-Chung Chang <chihchung@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
257eb2abf4e92a0eabc53642da01abeec9527ac4 |
|
18-Feb-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
scripts: Modify audio.js for emphasis_disabled in drc There is a new parameter "emphasis_disabled" in drc. This patch modifies audio.js file in audio_tuning webpage such that it will check if emphasis/disemphasis is disabled in chrome, then determine drc.emphasis_disabled config value. BUG=chrome-os-partner:25940 TEST=run audio_tuning webpage with modified audio.js. Checks that the output config contains "drc.emphasis_disabled": 0 for chrome without https://codereview.chromium.org/152333003/, and contains "drc.emphasis_disabled": 1 for chrome with https://codereview.chromium.org/152333003/. Change-Id: I6ef355a1d7cd6a4ac340f711d4270a6a88d42b27 Reviewed-on: https://chromium-review.googlesource.com/186857 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|
4dcc739672538350f8f5e6555bea1a2c0134c168 |
|
18-Feb-2014 |
Cheng-Yi Chiang <cychiang@chromium.org> |
scripts: Add webpage source code for audio tuning Initial commit for source code at http://audio-tuning.appspot.com/ BUG=chrome-os-partner:25940 TEST=serve audio.html webpage and connect to it to generate a config file. Change-Id: Id05f08c300aec70dc502281a0f26b3135d68f60b Reviewed-on: https://chromium-review.googlesource.com/186865 Reviewed-by: Hsinyu Chao <hychao@chromium.org> Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org>
/external/adhd/scripts/audio_tuning/frontend/audio.js
|