| 2b29e3bb3ee095001d497771e6d058887aaa7e37 |
|
28-Nov-2017 |
Shelley Chen <shchen@chromium.org> |
faft: Catch exceptions in cleanup() so that parent cleanup still executes
With the NVRAM initialization errors (recovery code 0x2b), we get
stuck in recovery and never end up running cleanup to get the DUT in a
good state. Putting all the code before the parent cleanup() call in
a try block fixes this problem.
BUG=b:68012381, b:68250622, b:63888325
BRANCH=None
TEST=Run firmware_CorruptKernelB and artificially shutdown device
during the test run. Make sure that cleanup still happens and
DUT is online after test completes. Also run faft_lv* suites and
make sure that they complete and we get summary results.
Change-Id: Iefe5b2699f617f094b9c533e3b75f25a2e5052bd
Signed-off-by: Shelley Chen <shchen@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/794836
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Wai-Hong Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| eabe8051fc4b0112529d9e93bd35e5d951a452b8 |
|
07-May-2015 |
Tom Wai-Hong Tam <waihong@google.com> |
faft: Simplify test flows by using wait_for_dut_up=True
It modifies test flows to reuse the mode_aware_reboot method to
wait for DUT up, not to do duplicated works.
BUG=chrome-os-partner:16231
TEST=Ran all affected FAFT tests on Jerry.
Change-Id: I55ec5b5b6dd8181a8ba56838ad6cecfe544a111b
Reviewed-on: https://chromium-review.googlesource.com/270014
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Tom Tam <waihong@google.com>
Tested-by: Tom Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 4777624b69b3b223a5d3c3abe86000783f6c0e96 |
|
06-May-2015 |
Tom Wai-Hong Tam <waihong@google.com> |
faft: Use mode_aware_reboot instead of reboot_warm and reboot_cold
This change removes reboot_warm, reboot_cold, reboot_warm_trigger,
and reboot_cold_trigger from FAFT framework and uses the new
mode_award_reboot method which does the same job.
BUG=chrome-os-partner:16231
TEST=Ran some of the affected FAFT tests on Jerry.
Change-Id: I9f0d1fd3416c7e4a624a915507dfa9c97f16d3e0
Reviewed-on: https://chromium-review.googlesource.com/269764
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Tom Tam <waihong@google.com>
Tested-by: Tom Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 0cc9a4fe28f221cfc73bb35c30fa79338c4b43f1 |
|
01-May-2015 |
Tom Wai-Hong Tam <waihong@google.com> |
faft: Refactor setup_mode and restore_mode
The change moves and splits the original logic on setup_dev_mode and
restore_dev_mode to FAFTCheckers and ModeSwitcher. It is also enhanced
to support setting up all firmware modes, including recovery. They are
now methods in ModeSwitcher as they are highly related to mode
switching.
BUG=chrome-os-partner:39744
TEST=Switched DUT to normal mode and ran firmware_DevMode. Then
switched DUT to dev mode and run firmware_DevMode. Checked DUT
restored to the original mode state.
Change-Id: I16314d18b785da59473df3ef5e02f7fe8f2693b0
Reviewed-on: https://chromium-review.googlesource.com/268858
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Tom Tam <waihong@google.com>
Tested-by: Tom Tam <waihong@google.com>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| af0542e925bd59a885238b6b7abe4f0704d006fc |
|
27-Jun-2014 |
Yusuf Mohsinally <mohsinally@google.com> |
Converting firmware_ShellBall to use new FirmwareTest class.
The new FirmwareTest class does not require the traditional dict of objects
that FAFTSequence required.
Note that this test does not currently work, and will not work till some
additional fixes are put into place. Doing this work to unblock removal of the
old faft classes.
1. Converted the test to use the new flat function call style.
2. Fixed doc string in control file.
BUG=chromium:371185
TEST=Manually ran this test at desk against squawks device.
Change-Id: If0a0c317ec46d08202740e98f109cd1c2cf8fccc
Reviewed-on: https://chromium-review.googlesource.com/205957
Reviewed-by: Vic Yang <victoryang@chromium.org>
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 1f115ae9ee3c043e9577e7ce9872dc99323fdcb3 |
|
07-Nov-2013 |
Yusuf Mohsinally <mohsinally@chromium.org> |
Correctly using initialize() rather than setup() for FAFT tests.
FAFT tests have been using setup() (which is run once at autotest init), when
it should have instead used initialize() for running code before each
test case is run.
BUG=chromium:267175
TEST=Ran tests manually against Pit device to ensure that these changes did not
introduce problems.
Change-Id: If0e76e12b9f40249154d7b95a1375b2787a56304
Reviewed-on: https://chromium-review.googlesource.com/176024
Reviewed-by: Wai-Hong Tam <waihong@chromium.org>
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 73c28f3abd6ec8de4dc5a8e6afca1d5e83eb59c7 |
|
03-Aug-2013 |
Yusuf Mohsinally <mohsinally@google.com> |
Reorginazing FAFT (server side) files.
Initial reorganization step while moves FAFT (autotest/server)
files over to packages. Naming and other cleanup will be performed
in additional CLs.
BUG=None
TEST=built and ran faft tests at desk against Link
Change-Id: I83712620c0e6816ec08b9afdf8c227a800734ea6
Reviewed-on: https://gerrit.chromium.org/gerrit/64408
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Tested-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Yusuf Mohsinally <mohsinally@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| d4340315f76fcae9a5e9430d0446705f4f8fa7b7 |
|
17-Jul-2013 |
Tom Wai-Hong Tam <waihong@chromium.org> |
FAFT: Rename the module faftsequence to faft_classes
For preparing the future refactoring that splitting FAFTSequence into
multiple meaningful small classes, changes the original module name
faftsequence to faft_classes.
BUG=chrome-os-partner:21118
TEST=Manual
Ran the affected test cases, firmware_FAFTSetup, on Spring and passed.
Change-Id: I662cfc8d37a54711d7c52ff5322ed28a9a759ffe
Reviewed-on: https://gerrit.chromium.org/gerrit/62642
Reviewed-by: Yusuf Mohsinally <mohsinally@chromium.org>
Commit-Queue: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| d43aa9b4568e0b1283d6ff535b87446b14a6e3b9 |
|
16-Nov-2012 |
Chun-ting Chang <ctchang@chromium.org> |
Classify methods in FAFTClient
There are too many methods in FAFTClient, so this CL is to classify them into
several groups: ec, bios, kernel. Methods which can be put into one of the
target group should be renamed with format _[group name]_[method name].
For example, dump_firmware should be modified to bios_dump. To call methods in
FAFTClient, use [group name].[method name].
BUG=chromium-os:36429
TEST=run firmware update tests
Change-Id: I7ead01246121b454c0a9f29e10bd026a77925e4f
Reviewed-on: https://gerrit.chromium.org/gerrit/38186
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Commit-Ready: Chun-Ting Chang <ctchang@chromium.org>
Tested-by: Chun-Ting Chang <ctchang@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| b09a04183cf7017eb4b30ad28f5f81f1204c36b3 |
|
06-Nov-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Fix lint warning and error
This includes removing unnecessary 'pass' and unused argumenets.
BUG=chrome-os-partner:35902
TEST=Check tests still work.
Change-Id: Ifb9ac8348e7e26e2ea1a10b9c7e509f817e117b9
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/37424
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 47d42ba469b82b51e45f755240eacad404b6122d |
|
31-Oct-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Fix lint warning
This includes:
- String format arguments as logging function paramters
- Unused loop counter
- Long line
- Unused import
- Disable W0702 when we want to catch any exception
BUG=chromium-os:35902
TEST=Run faft suite and passed.
Change-Id: I8442fefc5d0687dfe18c3563b5befbff750ba3a7
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/36998
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| f93f702b4e2b59bab22cde8d4d05b35a31520f6a |
|
31-Oct-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Move FAFT checkers to a separate module
BUG=chrome-os-partner:35902
TEST=Run FAFT suites and check they still work fine.
Change-Id: Idfb60632b67e7bc92b4ae12a60269e00c7b90b77
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/36989
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| 01d5e57a6bbe304c026ce2801e7e744d23694a91 |
|
23-Oct-2012 |
Tom Wai-Hong Tam <waihong@chromium.org> |
faft: Refactor the one time setup methods of FAFT
This CL makes all the one time setup states in a single place. It'd be easy
to add more in the future. And wrap the class level variable in methods to
prevent mis-used.
BUG=chromium-os:34392
TEST=run a test suite to see the GBB flag setup only run once:
run_remote_tests.sh --board daisy --remote dut control.faft_lv1
Change-Id: I113cd04777231bbde8e3f924c0661b0412ac36ec
Reviewed-on: https://gerrit.chromium.org/gerrit/36303
Reviewed-by: Vic Yang <victoryang@chromium.org>
Commit-Ready: Tom Wai-Hong Tam <waihong@chromium.org>
Tested-by: Tom Wai-Hong Tam <waihong@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| dbaba8f38dcdf98595105e36f177153c02b27e0e |
|
17-Oct-2012 |
Vic Yang <victoryang@chromium.org> |
faft: Skip checking GBB flags after the first test finished
There is no need to set GBB flags at the beginning of every test. We
just need to set them when running the first test. This saves us about
8 seconds per test.
BUG=chromium-os:34392
TEST=Run a test suite. Check GBB flags is only set in the first test.
Change-Id: Ib23e1326d208634e7331ff2bb54000529d11afb0
Signed-off-by: Vic Yang <victoryang@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/35811
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| bfe70fc6b0a9a63055f798687087121c8c430c73 |
|
09-Mar-2012 |
Rajesh Chenna <rchenna@chromium.org> |
Added factory_install test.
TEST=FAFT
BUG=None
modified: firmware_ShellBall.py
Change-Id: Ieb30337dec1ca910e68d8c82d6552cf98cb151ff
Reviewed-on: https://gerrit.chromium.org/gerrit/17657
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Commit-Ready: Rajesh Chenna <rchenna@chromium.org>
Tested-by: Rajesh Chenna <rchenna@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|
| fe6d97c5b4ac6fdedf38a3a6ef1bc52784cdadf5 |
|
06-Mar-2012 |
Rajesh Chenna <rchenna@chromium.org> |
Functional tests for shellball using FAFT.
TEST=FAFT
BUG=None
Change-Id: Ic02ad11265c99a9263c9ecaaa6a91712e8363617
Reviewed-on: https://gerrit.chromium.org/gerrit/17424
Reviewed-by: Tom Wai-Hong Tam <waihong@chromium.org>
Commit-Ready: Rajesh Chenna <rchenna@chromium.org>
Tested-by: Rajesh Chenna <rchenna@chromium.org>
/external/autotest/server/site_tests/firmware_ShellBall/firmware_ShellBall.py
|