| 5908c71128aea207e42f86468aedb0a6fce3cccb |
|
21-Dec-2015 |
philipel <philipel@webrtc.org> |
Lint fix for webrtc/modules/video_coding PART 3!
Trying to submit all changes at once proved impossible since there were
too many changes in too many files. The changes to PRESUBMIT.py
will be uploaded in the last CL.
(original CL: https://codereview.webrtc.org/1528503003/)
BUG=webrtc:5309
TBR=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1540243002
Cr-Commit-Position: refs/heads/master@{#11105}
/external/webrtc/PRESUBMIT.py
|
| 377b5e622f3e2f4d3b564c0d64f40ff3b5d5acb5 |
|
15-Dec-2015 |
danilchap <danilchap@webrtc.org> |
enabled cpplint for the webrtc/modules/rtp_rtcp directory
BUG=webrtc:5277
R=kjellander@webrtc.org
NOTRY=True
Review URL: https://codereview.webrtc.org/1528863002
Cr-Commit-Position: refs/heads/master@{#11027}
/external/webrtc/PRESUBMIT.py
|
| 8f09f170e650e14c4cd57c51be32a46e8cd1843b |
|
15-Dec-2015 |
terelius <terelius@webrtc.org> |
Simple CL to fix lint errors in webrtc/modules/remote_bitrate_estimator. Added the lint check for the folder to the presubmit script.
BUG=webrtc:5310
Review URL: https://codereview.webrtc.org/1520513003
Cr-Commit-Position: refs/heads/master@{#11021}
/external/webrtc/PRESUBMIT.py
|
| 0f2e939a92fc1a70a67a9fc141d1f1d006bcded9 |
|
10-Dec-2015 |
jbauch <jbauch@webrtc.org> |
Enable cpplint for more webrtc subfolders and fix all uncovered cpplint errors.
This CL enableds cpplint for webrtc/common_video, webrtc/sound and webrtc/tools.
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/common_video webrtc/sound webrtc/tools -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.
Review URL: https://codereview.webrtc.org/1511603004
Cr-Commit-Position: refs/heads/master@{#10967}
/external/webrtc/PRESUBMIT.py
|
| 70625e5bf3c91c57bf704d380bcc9df86575f08a |
|
09-Dec-2015 |
jbauch <jbauch@webrtc.org> |
Enable cpplint for webrtc/examples and fix all uncovered cpplint errors.
BUG=webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/examples/ -type f -name *.cc -o -name *.h | grep -v objc | xargs cpplint.py
followed by 'git cl presubmit'.
NOTRY=True
Review URL: https://codereview.webrtc.org/1504283004
Cr-Commit-Position: refs/heads/master@{#10960}
/external/webrtc/PRESUBMIT.py
|
| d1590b2571c4cb33416e14c92e4f2dfed42ec3d4 |
|
09-Dec-2015 |
mflodman <mflodman@webrtc.org> |
Lint clean video/ and add lint presubmit check.
BUG=webrtc:5316
Review URL: https://codereview.webrtc.org/1507643004
Cr-Commit-Position: refs/heads/master@{#10953}
/external/webrtc/PRESUBMIT.py
|
| 7623ce4aeb9130c937ba5836490cbb3a35679e79 |
|
09-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Reland of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:300001 of https://codereview.webrtc.org/1507903005/ )
Reason for revert:
Bot breakage caused by TickTime::UseFakeClock has been removed.
Original issue's description:
> Revert of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:20001 of https://codereview.webrtc.org/1506773002/ )
>
> Reason for revert:
> Breaks Dr Memory Light https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/builds/4643 and all the Android Tests bots.
>
> Original issue's description:
> > Merge webrtc/video_engine/ into webrtc/video/
> >
> > BUG=webrtc:1695
> > R=mflodman@webrtc.org
> >
> > Committed: https://crrev.com/03ef053202bc5d5ab43460eebf5403232f157646
> > Cr-Commit-Position: refs/heads/master@{#10926}
>
> TBR=mflodman@webrtc.org,pbos@webrtc.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:1695
>
> Committed: https://crrev.com/8237abf563bf4782ee104408b53cc8e55ce44518
> Cr-Commit-Position: refs/heads/master@{#10937}
BUG=webrtc:1695
TBR=mflodman@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
Review URL: https://codereview.webrtc.org/1510183002 .
Cr-Commit-Position: refs/heads/master@{#10948}
/external/webrtc/PRESUBMIT.py
|
| edd8fefa9b31f903eefe1e9fcabb09a5d6fc1ad1 |
|
08-Dec-2015 |
haysc <haysc@webrtc.org> |
Add new view that renders local video using AVCaptureLayerPreview.
BUG=
Review URL: https://codereview.webrtc.org/1497393002
Cr-Commit-Position: refs/heads/master@{#10940}
/external/webrtc/PRESUBMIT.py
|
| 8237abf563bf4782ee104408b53cc8e55ce44518 |
|
08-Dec-2015 |
kjellander <kjellander@webrtc.org> |
Revert of Merge webrtc/video_engine/ into webrtc/video/ (patchset #2 id:20001 of https://codereview.webrtc.org/1506773002/ )
Reason for revert:
Breaks Dr Memory Light https://build.chromium.org/p/client.webrtc/builders/Win%20DrMemory%20Light/builds/4643 and all the Android Tests bots.
Original issue's description:
> Merge webrtc/video_engine/ into webrtc/video/
>
> BUG=webrtc:1695
> R=mflodman@webrtc.org
>
> Committed: https://crrev.com/03ef053202bc5d5ab43460eebf5403232f157646
> Cr-Commit-Position: refs/heads/master@{#10926}
TBR=mflodman@webrtc.org,pbos@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:1695
Review URL: https://codereview.webrtc.org/1507903005
Cr-Commit-Position: refs/heads/master@{#10937}
/external/webrtc/PRESUBMIT.py
|
| ffea13c42cc3ebc118b6261be688f88974cc7ab5 |
|
08-Dec-2015 |
kjellander <kjellander@webrtc.org> |
PRESUBMIT: change native API check from warning to information.
NOTRY=True
Review URL: https://codereview.webrtc.org/1507723002
Cr-Commit-Position: refs/heads/master@{#10931}
/external/webrtc/PRESUBMIT.py
|
| 88eeac4aa7eaf22afc95bffbc8c2a2652b9222c8 |
|
08-Dec-2015 |
mflodman <mflodman@webrtc.org> |
Adding video_processing to presubmit lint check
BUG=webrtc:5259
R=pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1507213002 .
Cr-Commit-Position: refs/heads/master@{#10928}
/external/webrtc/PRESUBMIT.py
|
| 03ef053202bc5d5ab43460eebf5403232f157646 |
|
08-Dec-2015 |
Peter Boström <pbos@webrtc.org> |
Merge webrtc/video_engine/ into webrtc/video/
BUG=webrtc:1695
R=mflodman@webrtc.org
Review URL: https://codereview.webrtc.org/1506773002 .
Cr-Commit-Position: refs/heads/master@{#10926}
/external/webrtc/PRESUBMIT.py
|
| fd595235878df06e7737ba8b72e8792d31d58d8a |
|
04-Dec-2015 |
kjellander <kjellander@webrtc.org> |
Add webrtc/base to deprecated APIs.
webrtc/base is used in several places downstream so we need
to be careful when updating it as well. Add it as deprecated
to disencourage new projects starting to depend on it.
BUG=webrtc:5095
NOTRY=True
Review URL: https://codereview.webrtc.org/1497733002
Cr-Commit-Position: refs/heads/master@{#10892}
/external/webrtc/PRESUBMIT.py
|
| 53047c9739989251cbe7090865411b1469b47f5d |
|
03-Dec-2015 |
kjellander <kjellander@webrtc.org> |
Add PRESUBMIT check for native API changes.
BUG=webrtc:5095
TESTED=Modified local header file, ensured only one directory matches it's path (since 'webrtc' is in the list).
Also tested that the _VerifyNativeApiHeadersListIsValid works by adding a path that doesn't exist to the list and verified it produces an error.
NOTRY=True
Review URL: https://codereview.webrtc.org/1408783008
Cr-Commit-Position: refs/heads/master@{#10878}
/external/webrtc/PRESUBMIT.py
|
| ea07373a2eb46f2732a8b5acef06a9b5078f37f8 |
|
01-Dec-2015 |
Fredrik Solenberg <solenberg@webrtc.org> |
Enable cpplint for webrtc/audio and webrtc/call, and fix all uncovered cpplint errors.
BUG=webrtc:5268,webrtc:5273
TESTED=Fixed issues reported by:
find webrtc/audio -type f -name *.cc -o -name *.h | xargs cpplint.py
find webrtc/call -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.
R=kjellander@webrtc.org, pbos@webrtc.org
Review URL: https://codereview.webrtc.org/1483323002 .
Cr-Commit-Position: refs/heads/master@{#10853}
/external/webrtc/PRESUBMIT.py
|
| 42f580e490e8343a87362dbb20207380d850372c |
|
27-Nov-2015 |
tkchin <tkchin@webrtc.org> |
Leaving all original files in talk/app/webrtc/objc until we can officially tell clients about the new locations.
Also changes presubmit script to not run cpplint on objc dirs.
BUG=
Review URL: https://codereview.webrtc.org/1467173006
Cr-Commit-Position: refs/heads/master@{#10815}
/external/webrtc/PRESUBMIT.py
|
| 0fcaf99b716c71e721db25f37f62dabf5dcbe69a |
|
26-Nov-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Enable cpplint for webrtc/video_engine
Enable cpplint and have it use a whitelist that also checks
in subdirectories.
Move the cpplint check so it runs before the pylint check
since that one always run and increases the time to errors
for cpplint.
Fix all cpplint errors in webrtc/video_engine.
BUG=webrtc:5149
TESTED=Fixed issues reported by:
find webrtc/video_engine -type f -name *.cc -o -name *.h | xargs cpplint.py
followed by 'git cl presubmit'.
R=pbos@chromium.org, phoglund@chromium.org
TBR=pbos@webrtc.org, phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1481723003 .
Cr-Commit-Position: refs/heads/master@{#10808}
/external/webrtc/PRESUBMIT.py
|
| 8cc126f91bc0dcb3506100d780146850de23b714 |
|
02-Nov-2015 |
kjellander <kjellander@webrtc.org> |
PRESUBMIT: Enable header guard checks for cpplint.
This check has always been disabled since the start in
https://webrtc-codereview.appspot.com/317011 since it didn't support
our style guide back then (wanted our source code to be prefixed
with SRC_ in the header guards). I belive this was later fixed in
https://chromiumcodereview.appspot.com/15864011. At least it can now
be enabled.
BUG=5149
NOTRY=True
Review URL: https://codereview.webrtc.org/1419203005
Cr-Commit-Position: refs/heads/master@{#10482}
/external/webrtc/PRESUBMIT.py
|
| d6d27e7340bca1598973e2197cf08d79ce9aeb04 |
|
25-Sep-2015 |
Henrik Kjellander <kjellander@google.com> |
Update isolate.gypi to support Swarming + move .isolate files
This updates the isolate.gypi copies we have to maintain in our
code repo to Chromium's revision 310ea93.
The changes about generating .isolated.gen.json files are needed
to support running with Swarming (https://www.chromium.org/developers/testing/isolated-testing)
Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that's added to our links
script.
In order to use isolate_driver.py, the .isolate files must be in the
same directory as the test_name_run target is defined, which meant
I had to move around some of the isolate files and targets below
webrtc/modules.
BUG=497757
R=maruel@chromium.org
TBR=henrik.lundin@webrtc.org, mflodman@webrtc.org, niklas.enbom@webrtc.org
TESTED=Clobbered trybots:
git cl try -c --bot=linux_compile_rel --bot=mac_compile_rel --bot=win_compile_rel --bot=android_compile_rel --bot=ios_rel -m tryserver.webrtc
Review URL: https://codereview.webrtc.org/1373513002 .
Cr-Commit-Position: refs/heads/master@{#10081}
/external/webrtc/PRESUBMIT.py
|
| 632246792fb208280a048fb2497a309c5a4d3690 |
|
08-Sep-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
PRESUBMIT: Exclude some files from 80-character limit check.
Exclude the following files from 80-characters line limit check:
* DEPS
* GN files (.gn and .gni)
* GYP files (.gyp and .gypi)
BUG=webrtc:4794
TESTED=Ran the presubmit check with a modified DEPS and GYP file before this change and verified it failed. Re-ran after these changes and verified it passed. I also tested editing a .cc file to be >80 chars and verified the check found it.
R=andrew@webrtc.org, sergiyb@chromium.org
Review URL: https://codereview.webrtc.org/1323943012 .
Cr-Commit-Position: refs/heads/master@{#9877}
/external/webrtc/PRESUBMIT.py
|
| 04465d286e6a1a643c88fabddd44eb870f906c38 |
|
20-Jun-2015 |
tandrii <tandrii@chromium.org> |
Revert of Fix PRESUBMIT.py after disabling CQ. (patchset #1 id:1 of https://codereview.webrtc.org/1192673003/)
Reason for revert:
CQ-Rietveld combination now supports webrtc custom domain.
Original issue's description:
> Fix PRESUBMIT.py after disabling CQ.
>
> The disabling of CQ in https://codereview.webrtc.org/1177243003/
> broke PRESUBMIT.py since it's trying to read cq.cfg.
>
> BUG=501332
> TBR=phoglund@webrtc.org
>
> Committed: https://chromium.googlesource.com/external/webrtc/+/141725f50fa4223ce2f9e84500971a44d7720c03
TBR=phoglund@webrtc.org,kjellander@webrtc.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=501332
Review URL: https://codereview.webrtc.org/1190283003
Cr-Commit-Position: refs/heads/master@{#9476}
/external/webrtc/PRESUBMIT.py
|
| 141725f50fa4223ce2f9e84500971a44d7720c03 |
|
18-Jun-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
Fix PRESUBMIT.py after disabling CQ.
The disabling of CQ in https://codereview.webrtc.org/1177243003/
broke PRESUBMIT.py since it's trying to read cq.cfg.
BUG=501332
TBR=phoglund@webrtc.org
Review URL: https://codereview.webrtc.org/1192673003.
Cr-Commit-Position: refs/heads/master@{#9462}
/external/webrtc/PRESUBMIT.py
|
| 986ee082b628ffd3a90fbbe4b933a312489921e0 |
|
16-Jun-2015 |
kjellander <kjellander@webrtc.org> |
Move default trybots configuration to CQ config.
This is the same set of trybots that used to be configured in PRESUBMIT.py
BUG=470518
TBR=
Review URL: https://codereview.webrtc.org/1189583003
Cr-Commit-Position: refs/heads/master@{#9448}
/external/webrtc/PRESUBMIT.py
|
| 14771ac6bfe0c66134425b99212f443f03231229 |
|
02-Jun-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
Fix Python lint and unit tests
One of the unit tests added in
https://webrtc-codereview.appspot.com/50079004/ is failing
on Windows since os.sep is a backslash on Windows.
The code is based on the contents of the DEPS file rather than
the filesystem, so the right thing is to use '/' instead of os.sep.
The PyLint blacklist also didn't work on Windows, causing it
to process a massive list of files during presubmit.
I also added a bunch of new entries to speed up lint execution on
all platforms.
TESTED=Ran the presubmit with this CL on Windows and Linux.
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/52029004
Cr-Commit-Position: refs/heads/master@{#9353}
/external/webrtc/PRESUBMIT.py
|
| 8d3ad82d30f3634c49af07dad210449721b9d3d1 |
|
26-May-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
Script for auto-rolling chromium_revision in DEPS.
The previous script only looked up the LKGR and generated a
commit message. This CL renames the script and makes it update
the DEPS file, commit locally, upload CL and send tryjobs.
BUG=4688
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50079004
Cr-Commit-Position: refs/heads/master@{#9284}
/external/webrtc/PRESUBMIT.py
|
| e982a70ae3e5d301b009e9c3f9520163bd4d9eb3 |
|
25-May-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
PRESUBMIT: Fix typo.
In https://webrtc-codereview.appspot.com/50069004/
the regex for Mac trybots became invalid. This fixes it.
TBR=phoglund@webrtc.org
TESTED=Ran 'git cl try --bot=mac_x64_gn'
Review URL: https://webrtc-codereview.appspot.com/53529004
Cr-Commit-Position: refs/heads/master@{#9278}
/external/webrtc/PRESUBMIT.py
|
| 57e5fd2e604ff7e60425c3f7654b40da03fc763c |
|
25-May-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
PRESUBMIT: Improve PyLint check and add GN format check.
Add pylintrc file based on
https://code.google.com/p/chromium/codesearch#chromium/src/tools/perf/pylintrc
bit tightened up quite a bit (the one in depot_tools is far
more relaxed).
Remove a few excluded directories from pylint check and fixed/
suppressed all warnings generated.
Add GN format check + formatted all GN files using 'gn format'.
Cleanup redundant rules in tools/PRESUBMIT.py
TESTED=Ran 'git cl presubmit -vv', fixed the PyLint violations.
Ran it again with a modification in webrtc/build/webrtc.gni, formatted
all the GN files and ran it again.
R=henrika@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/50069004
Cr-Commit-Position: refs/heads/master@{#9274}
/external/webrtc/PRESUBMIT.py
|
| d43ba89d0056854e84c6dc7f12698edd14719efb |
|
20-Apr-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
PRESUBMIT: Add new trybots for iOS Simulator
Trybots added in https://codereview.chromium.org/1096683002
BUG=chromium:478057
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/49049004
Cr-Commit-Position: refs/heads/master@{#9031}
/external/webrtc/PRESUBMIT.py
|
| 36fc1bad3851d9e5f57c09034bd22e145f08ca33 |
|
15-Apr-2015 |
Henrik Kjellander <kjellander@webrtc.org> |
Update renamed Android ARM64 trybot in PRESUBMIT.py.
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44209004
Cr-Commit-Position: refs/heads/master@{#9006}
/external/webrtc/PRESUBMIT.py
|
| c98f6f368a789955f4dec5a58e0163571021ac4a |
|
04-Mar-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Exclude overrides paths from source above GYP check.
Since base.gyp contains a couple of those.
BUG=4185
TESTED=Ran git cl presubmit with a modified base.gyp without this patch - got errors about overrides. Ran another time with this patch applied - no errors.
TBR=pthatcher@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/44529004
Cr-Commit-Position: refs/heads/master@{#8586}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8586 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| e723728992de4626445fc7d3ca500cfea7c96890 |
|
26-Feb-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Add p2p.gyp to rtc_base presubmit check exclusion.
It is one of the valid users of rtc_base. This change
should have been a part of https://webrtc-codereview.appspot.com/29319004
TESTED=Modified p2p.gyp locally and ran the presubmit without+with this
patch applied. Only the latter passed.
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/43449004
Cr-Commit-Position: refs/heads/master@{#8511}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8511 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| c0fc4dd87c1d226158cdaf1489c6f69e0fff62ca |
|
17-Feb-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Add 'mac_x64' trybot to default set.
This trybot was recently added since we've run into
some failures only happening for Mac 64 Debug.
TBR=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/41969004
Cr-Commit-Position: refs/heads/master@{#8382}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8382 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| a33f05e8d7f293b5984b3cd7695eadefd16dcaba |
|
29-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Re-land "Remove <(webrtc_root) from source file entries."
Changes differing from https://webrtc-codereview.appspot.com/37859004:
* I put the include_tests==1 stuff of audio_coding.gypi in its
own audio_coding_tests.gypi file, including the Android and isolate
targets which were incorrectly located in the previous CL
* I moved the bwe utilities in remote_bitrate_estimator.gypi
into include_tests==1 since they depend on test.gyp after I
cleaned up the duplicated inclusion of rtp_file_reader.cc
R=stefan@webrtc.org
TBR=tina.legrand@webrtc.org
TESTED=Passing gyp and compile using:
webrtc/build/gyp_webrtc -Dinclude_tests=1
webrtc/build/gyp_webrtc -Dinclude_tests=0
I also setup a Chromium checkout with my checkout mounted in
third_party/webrtc and ran build/gyp_chromium successfully.
BUG=4185
Review URL: https://webrtc-codereview.appspot.com/33159004
Cr-Commit-Position: refs/heads/master@{#8205}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8205 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 1ece0cbbec63d4fc14e3a6121d3d828c250fc20f |
|
29-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Revert "Remove <(webrtc_root) from source file entries."
And the follow-up fix in r8198 that was not sufficient.
Reason: breaks Chromium bots runhooks (GYP).
I will have to try some more to make sure I don't
include test code, since include_tests==0 in Chromium.
TBR=andrew@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37039004
Cr-Commit-Position: refs/heads/master@{#8200}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8200 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 2d2a1f9f056bb552e725b70b863d31cbee5ef7d8 |
|
29-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Remove <(webrtc_root) from source file entries.
This required to move the AGC tools source files
into webrtc/tools and create a new agc_test_utils target.
Since audio_codec_speed_tests.gypi referenced sources above,
the best approach I could come up with was to add an audio_coding.gypi
file at a higher level and move the targets in there (+ the includes from
modules.gyp which is an improvement IMO).
I also added a PRESUBMIT.py check to prevent new source
entries being added with <(webrtc_root) in the path.
BUG=4185
R=andrew@webrtc.org, tina.legrand@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/37859004
Cr-Commit-Position: refs/heads/master@{#8197}
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8197 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| f68ffca050438b8055b108228cca198686abc0c1 |
|
27-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Add PRESUBMIT check for GYP files including source files above itself.
This is needed because some tools does not support files
located above the project generated.
BUG=4185
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34069004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8166 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 995b4c9e8a4f42420919bb057840070615718dc3 |
|
25-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Remove win_asan trybot from PRESUBMIT.py
Removing it since it no longer exists.
See https://codereview.chromium.org/872263002/
TBR=phoglund@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/36979004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8146 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 1592df78ef952a4a44fe4c37291998095ad40ef5 |
|
09-Jan-2015 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Add GN trybots for Windows and Mac.
Add to the default set since they're now green.
BUG=4105
R=pbos@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/34689004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@8029 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| aefe61ae2a392122994739adac54017e33cab9bf |
|
08-Dec-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Add check for checkdeps.
Several times I've run into the problem with
presubmit crashing when uploading a CL from a checkout
where gclient sync hasn't run yet.
This will print a user friendly error message instead.
BUG=
R=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/32699004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7824 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| d91d359feb29a90ebbdcdb359fc0f426cd8b3b8c |
|
08-Dec-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Add iOS ARM64 trybots to default set.
BUG=chromium:436831
TBR=phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/25319004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7822 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 3398a4ac15c9954f7d6355607897060236c3169b |
|
24-Nov-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Only notify GN changes for GYP files in webrtc/*
We don't maintain a BUILD.gn file for talk/ since it's a part
of Chromium:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/BUILD.gn
Because of this, it's confusing to get warnings about updating
a GYP file in talk/ from the PRESUBMIT check.
TESTED=Successsfully ran git cl presubmit with this change
applied on top of a CL containing changes in .gyp files.
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/27189004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7737 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 28af64105b6dbe97e423e2f6cfde8e47a2df625a |
|
04-Nov-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Presubmit was not whitelisting libjingle_tests.gyp or sound.gyp due to a missing comma leading to a concatenation of the two strings in the whitelist.
R=kjellander@webrtc.org
TBR=niklas.enbom@webrtc.org
BUG=N/A
Review URL: https://webrtc-codereview.appspot.com/25999004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7614 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 3b839d008f3d03fdd23fbf25d840c139322b9358 |
|
24-Oct-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
PRESUBMIT: Add linux_msan to default trybots.
Will commit as soon it's online.
BUG=
R=pbos@webrtc.org
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/26939004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7523 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 36b0c1afae15e6cb47971ba81d1a8cf670045cca |
|
01-Oct-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Adds PRESUBMIT.py dispensation for depending on rtc_base.
Dispensation for: a few test suites, desktop capture and libjingle.
BUG=N/A
R=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31549004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7356 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 83fe69da95bde17a8a80c4e9f8aaa1fe1439be85 |
|
30-Sep-2014 |
henrike@webrtc.org <henrike@webrtc.org> |
Added presubmit protecting against inclusion of rtc_base, while allowing rtc_base_approved.
BUG=N/A
R=andrew@webrtc.org, kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/29609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7349 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 8cad9432d554f9117faf147dcbaeabd6f7968e63 |
|
30-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Revert 7327 "Update isolate.gypi files + link to isolate_driver.py"
Breaks debug compilation (didn't run all trybots when testing this).
> Update isolate.gypi files + link to isolate_driver.py
>
> This updates the isolate.gypi copies we're forced to
> maintain in our code repo to Chromium revision c264a05.
>
> Since isolated testing is now using a new launch script
> in tools: isolate_driver.py, that is added to our links
> script.
>
> BUG=395700
> TESTED=Ran one of our tests with:
> ninja -C out/Release tools_unittests_run
> tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate
>
> R=henrika@webrtc.org, jam@chromium.org
>
> Review URL: https://webrtc-codereview.appspot.com/26649004
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/31509004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7328 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 02cd3067d2338239052d98a193b4fe13be5bbdfd |
|
30-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Update isolate.gypi files + link to isolate_driver.py
This updates the isolate.gypi copies we're forced to
maintain in our code repo to Chromium revision c264a05.
Since isolated testing is now using a new launch script
in tools: isolate_driver.py, that is added to our links
script.
BUG=395700
TESTED=Ran one of our tests with:
ninja -C out/Release tools_unittests_run
tools/isolate_driver.py run --isolated out/Release/tools_unittests.isolated --isolate webrtc/tools/tools_unittests.isolate
R=henrika@webrtc.org, jam@chromium.org
Review URL: https://webrtc-codereview.appspot.com/26649004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7327 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| eb43264f267dde21796514f0b3e92fbff00d9b0a |
|
17-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Remove linux_memcheck from default trybots.
Now that we have enabled leak detection (LeakSanitizer) for our
Linux ASan bots, there's no point always running the linux_memcheck trybot
since it's very slow and almost always gets a long queue of builds.
BUG=
R=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/28479004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7203 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 94da2034b054e484001133ad41f8a73a46d546a2 |
|
02-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Remove retired android_apk[_rel] trybots from PRESUBMIT.py
BUG=webrtc:3741
TBR=niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/14289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7024 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 3bd4156d75b12c084026e8e31c12fd4b982374d3 |
|
01-Sep-2014 |
kjellander@webrtc.org <kjellander@webrtc.org> |
Android APK tests built from a normal WebRTC checkout.
Restructure how the Android APK tests are compiled now
that we have a Chromium checkout available (since r6938).
This removes the need of several hacks that were needed when
building these targets from inside a Chromium checkout.
By creating a symlink to Chromium's base we can compile the required
targets. This also removes the need of the previously precompiled
binaries we keep in /deps/tools/android at Google code.
All the user needs to do is to add the target_os = ["android"]
entry to his .gclient as described at
https://code.google.com/p/chromium/wiki/AndroidBuildInstructions
Before committing this CL, the Android APK buildbots will need
to be updated.
This also solves http://crbug.com/402594 since the apply_svn_patch.py
usage will be similar to the other standalone bots.
It also solves http://crbug.com/399297
BUG=chromium:399297, chromium:402594
TESTED=Locally compiled all APK targets by running:
GYP_DEFINES="OS=android include_tests=1 enable_tracing=1" gclient runhooks
ninja -C out/Release
checkdeps
R=henrike@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/22149004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@7014 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 8925662318ca10d841e92f4dc20bbf0c53aea865 |
|
20-Aug-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Make WebRTC work with Chromium Git checkouts
WebRTC standalone shares a lot of dependencies and build
tools with Chromium. To make the build work, many of the
paths of a Chromium checkout is now emulated by creating
symlinks to files and directories.
All DEPS entries that previously used Var("chromium_trunk")
to reference a Chromium checkout or From("chromium_deps"..)
to reference the Chromium DEPS file are now removed and
replaced by symlink entries in setup_links.py.
The script also handles cleanup of the legacy
Subversion-based dependencies that's needed for the
transition.
Windows: One Windows-specific important change is that
gclient sync|runhooks must now be run from a shell
with Administrator privileges in order to be able to create
symlinks. This also means that Windows XP is no longer
supported.
To transition a previously created checkout:
Run "python setup_links.py --force" to cleanup the old
SVN-based dependencies that have been synced by gclient sync.
For Buildbots, the --force flag is automatically enabled for
their syncs.
BUG=2863, chromium:339647
TEST=Manual testing on Linux, Mac and Windows.
R=andrew@webrtc.org, iannucci@chromium.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18379005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6938 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| e415864a326ce48ff2d41d4c9a3faed26c033450 |
|
06-Aug-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
GN: Add PRESUBMIT.py check for GN changes + default bots.
Add the GN trybots to the default set and also set them
to be the only bots to run if a CL contains only BUILD.gn
changes.
Update Python exclusions in general and fix a few of the lint
warnings.
The ones in python_charts needs to be disabled since those variables
are actually used when passed via vars() to the template.
BUG=None
TEST=git cl presubmit with the following cases:
A CL with two .gyp changes.
A CL with no changes in .gyp* files.
R=niklas.enbom@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/18719004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6834 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 9359edaf7808355bf12516df6f919e26bcc3a912 |
|
08-Jun-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
PRESUBMIT: Add Android ARM64 and remove Linux TSan
Update the default trybots due to recent changes in the
trybots available.
TBR=tommi@webrtc.org
BUG=chromium:354539
Review URL: https://webrtc-codereview.appspot.com/21619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6364 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 10f871f29b190996a5a051bb00cd84b12e9b33bc |
|
23-May-2014 |
wu@webrtc.org <wu@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Remove the restriction to allow having both webrtc and talk changes in the same cl.
This restriction is no longer needed as the auto sync script can handle changes to both folder in same commit correctly.
BUG=
R=andrew@webrtc.org, henrike@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/15479006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@6225 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| a956ec2019c28598b0abcc801b17b6589230cca9 |
|
14-Apr-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add win_drmemory_light trybot to default trybot list.
BUG=chromium:360054
TEST=None
R=henrika@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11879004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5894 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| c7b8b2f2a75f0620a978f3e7eff057780d49ed5c |
|
03-Apr-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
PRESUBMIT.py: use new way to specify default try builders
In https://codereview.chromium.org/178223016 and
https://codereview.chromium.org/197963003 the way the
PRESUBMIT.py specifies the default try builders for a
try job have changed.
When submitting a try job now, the test filter argument no
longer works unless --bot is also specified.
This CL attempts to resolve this by moving away from the
deprecated approach onto using the new format instead.
This CL also includes two new trybots: win_asan and linux_tsan2
(added in https://codereview.chromium.org/220453004).
BUG=3148
TEST=Successfully fired off a -t compile job where the
test filter worked.
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/11119004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5839 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 10adbeff781c053cea346272994be0f84597789b |
|
01-Mar-2014 |
fischman@webrtc.org <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Exclude /out* instead of just /out from pylint checks.
This matches .gitignore's pattern, and avoids tons of presubmit errors when
building to multiple out directories (e.g. using
GYP_GENERATOR_FLAGS=output_dir=out_android)
R=andrew@webrtc.org, phoglund@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/9249005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5628 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 056176b96248fa926e0e1d1249c4f31a3246a1b1 |
|
20-Feb-2014 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Presubmit script that prohibits cls to both trunk/webrtc and trunk/talk.
BUG=N/A
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7999006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5582 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 12cb88cab9f3a1b4dbb60bebc4fc4fe6c705306e |
|
13-Feb-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add check to verify tree is open to PRESUBMIT.py.
This will disallow commits when our tree is closed.
BUG=chromium:342743
TEST=ran git cl presubmit with an open tree (no error). Then I closed the tree at http://webrtc-status.appspot.com and ran it again, got this message:
Tree state is: closed
***************
Tree is temporarily closed (testing presubmit hook real quick)
http://webrtc-status.appspot.com/current?format=json
***************
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/8609004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5542 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 2a260d9fabecd8a1a2ea798aea7b452b038240a2 |
|
27-Jan-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Enable Android APK trybots by default.
As the new bots building the WebRTC native tests for Android as APKs
and executing them on a device has now proven to be reasonably stable,
it is time to enable them by default for tryjobs.
TEST=several green builds sent from a WebRTC checkout.
BUG=chromium:312827
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7529004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5440 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 570bc3d792369c357bca4dc3a6c22e0f1fc5337d |
|
22-Jan-2014 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Make new baremetal trybots receive tryjobs by default.
I've done several green builds with these machines, but I suspect
some of the flakiness we still see in the build waterfall may
occur on these ones. Hopefully at least the ones for vie_auto_test
will be ironed out in Q1 as the old Video Engine API becomes deprecated.
TEST=none
BUG=chromium:332726
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/7459004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5414 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| cf2b3acc480b5b316b03ba867d6504618019051f |
|
20-Dec-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Update Android trybots in the default try job list.
This updates the default set of trybots that are used
when no bot names are specified when submitting a try job.
TBR=andrew@webrtc.org
TEST=Ran git try -t compile and verified it was sent to all bots.
BUG=none
Review URL: https://webrtc-codereview.appspot.com/6289004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5329 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| f9bdbe36198341d678ea22f8a47de60ee552e69a |
|
11-Dec-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Roll chromium_revision 232627:238260
This brings us the updated swarming_client
that has moved out from Chromium into a standalone
project.
Because of this, all .isolate files needed to be
updated as well, similar to the changes in
https://codereview.chromium.org/29993003
TEST=trybots passing
BUG=none
R=andrew@webrtc.org, perkj@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/4859004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5260 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 8575980e16b917b5d94e670a9c6da9029615b575 |
|
22-Oct-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add default trybots for WebRTC try server.
Today, our tryjobs default to run on all trybots since
we don't have any default list configured in PRESUBMIT.py.
Because of this, the --testfilter argument doesn't work
unless you also specify --bot when sending the tryjob.
With this CL, it is possible to use --testfilter without
--bot.
It also gets the benefit of excluding unnecessary bots
when doing platform-specific changes.
Most of the code is copied from Chromium's src/PRESUBMIT.py:
https://code.google.com/p/chromium/codesearch#chromium/src/PRESUBMIT.py&l=1030
TEST=tested submitting a tryjob with git try -t compile.
BUG=none
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2619004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@5016 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 3365422c419b535dc436da5990e32860a3d02440 |
|
22-Aug-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Isolate GYP target and .isolate files for tests
This is a re-land attempt of http://review.webrtc.org/1673004/
It now includes a build/isolate.gypi in WebRTC that includes the same
file as the one that would be included when WebRTC is used in a Chromium
checkout. It is needed since it is not possible to use variables in GYP's
includes sections.
Implemented according to the instructions at
http://www.chromium.org/developers/testing/isolated-testing
Workflow has been like this:
1. create _run GYP target
2. create a stripped down .isolate file
3. export GYP_DEFINES="$GYP_DEFINES test_isolation_mode=check"
4. runhooks
5. compile
6. test if the test would run (i.e. find it's dependencies) without
actually executing it:
tools/swarm_client/isolate.py run --isolated out/Release/testname.isolated
7. If failing, run the fix_test_cases.py script like this:
tools/swarm_client/googletest/fix_test_cases.py --isolated out/Release/testname.isolated
All tests that run on the bots for WebRTC has got _run target
and .isolate file created.
"Normal tests" that run fine on any machine:
* audio_decoder_unittests
* common_audio_unittests
* common_video_unittests
* metrics_unittests
* modules_tests
* modules_unittests
* neteq_unittests
* system_wrappers_unittests
* test_support_unittests
* tools_unittests
* video_engine_core_unittests
* voice_engine_unittests
Tests that requires bare-metal and audio/video devices:
* audio_device_tests
* video_capture_tests
I also added the isolate boilerplate code for the following
tests that are not yet pure gtest binaries (which means they
cannot run isolated yet):
* video_render_tests
* vie_auto_test
* voe_auto_test
TEST=running isolate.py as described above. WebRTC trybots passing. Created a Chromium checkout with third_party/webrtc ToT and this patch applied, passing the runhooks step.
BUG=1916
R=henrike@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2056004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4590 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 4298f73031df2c5c442727d06ae8c3303b907412 |
|
15-Aug-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert 4547 "Isolate GYP target and .isolate files for tests"
As this breaks the FYI bots in
http://build.chromium.org/p/chromium.webrtc.fyi/waterfall
due to different path to isolate.gypi (which cannot easily
be resolved due to limitations in GYP)
> Isolate GYP target and .isolate files for tests
>
> Implemented according to the instructions at
> http://www.chromium.org/developers/testing/isolated-testing
>
> Workflow has been like this:
> 1. create _run GYP target
> 2. create a stripped down .isolate file
> 3. export GYP_DEFINES="$GYP_DEFINES test_isolation_mode=check"
> 4. runhooks
> 5. compile
> 6. test if the test would run (i.e. find it's dependencies) without
> actually executing it:
> tools/swarm_client/isolate.py run --isolated out/Release/testname.isolated
> 7. If failing, run the fix_test_cases.py script like this:
> tools/swarm_client/fix_test_cases.py --isolated out/Release/testname.isolated
>
> All tests that run on the bots for WebRTC has got _run target
> and .isolate file created.
>
> "Normal tests" that run fine on any machine:
> * audio_decoder_unittests
> * common_audio_unittests
> * common_video_unittests
> * metrics_unittests
> * modules_integrationtests
> * modules_unittests
> * neteq_unittests
> * system_wrappers_unittests
> * test_support_unittests
> * tools_unittests
> * video_engine_core_unittests
> * voice_engine_unittests
>
> Tests that requires bare-metal and audio/video devices:
> * audio_device_integrationtests
> * video_capture_integrationtests
>
> I also added the isolate boilerplate code for the following
> tests that are not yet pure gtest binaries (which means they
> cannot run isolated yet):
> * video_render_integrationtests
> * vie_auto_test
> * voe_auto_test
>
> TEST=running isolate.py as described above.
> BUG=1916
> R=tommi@webrtc.org
>
> Review URL: https://webrtc-codereview.appspot.com/1673004
TBR=kjellander@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/2040004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4548 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| d7a4d235d2685df6f1c356cecee0322d1251ad69 |
|
15-Aug-2013 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Isolate GYP target and .isolate files for tests
Implemented according to the instructions at
http://www.chromium.org/developers/testing/isolated-testing
Workflow has been like this:
1. create _run GYP target
2. create a stripped down .isolate file
3. export GYP_DEFINES="$GYP_DEFINES test_isolation_mode=check"
4. runhooks
5. compile
6. test if the test would run (i.e. find it's dependencies) without
actually executing it:
tools/swarm_client/isolate.py run --isolated out/Release/testname.isolated
7. If failing, run the fix_test_cases.py script like this:
tools/swarm_client/fix_test_cases.py --isolated out/Release/testname.isolated
All tests that run on the bots for WebRTC has got _run target
and .isolate file created.
"Normal tests" that run fine on any machine:
* audio_decoder_unittests
* common_audio_unittests
* common_video_unittests
* metrics_unittests
* modules_integrationtests
* modules_unittests
* neteq_unittests
* system_wrappers_unittests
* test_support_unittests
* tools_unittests
* video_engine_core_unittests
* voice_engine_unittests
Tests that requires bare-metal and audio/video devices:
* audio_device_integrationtests
* video_capture_integrationtests
I also added the isolate boilerplate code for the following
tests that are not yet pure gtest binaries (which means they
cannot run isolated yet):
* video_render_integrationtests
* vie_auto_test
* voe_auto_test
TEST=running isolate.py as described above.
BUG=1916
R=tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1673004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4547 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 33584f942c6e1723918d9d2b76f429ab8396751e |
|
25-Jul-2013 |
fischman@webrtc.org <fischman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Introduce a bit of sanity to talk/PRESUBMIT.py's license checking.
The comma this allows is a very common variant of the license header (3:1
preferred over the no-comma variant in talk/).
Also pacify pylint a bit, and correct a flagrantly incorrect header I happened
to come across.
BUG=2098,2133
R=henrike@webrtc.org, niklas.enbom@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1866004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4396 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 390fcb7a202163a22ae13979a0246f66180b2011 |
|
23-Jul-2013 |
henrike@webrtc.org <henrike@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Modified the presubmit checks such that difference license templates are checked for in webrtc and talk folder.
BUG=2091
R=andrew@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1833004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4381 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 6d07ad9cccbf172efd84294ee8552da4fa8860fe |
|
14-May-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Added protoc_wrapper to blacklist, fixed tools/PRESUBMIT.py which was passing in the wrong args to CheckLongLines.
BUG=
R=kjellander@webrtc.org, tommi@webrtc.org
Review URL: https://webrtc-codereview.appspot.com/1470005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@4021 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| f2e7bc6b6ac3ec7761a6a164a41c8d708bc1ef33 |
|
08-Apr-2013 |
pbos@webrtc.org <pbos@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Added maxlen=80 to CheckLongLines() call in PRESUBMIT.py
BUG=
Review URL: https://webrtc-codereview.appspot.com/1285006
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3779 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 5d37139374178479c16956a2a4eefd231206c2a1 |
|
07-Mar-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Fixed a ton of Python lint errors, enabled python lint checking.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1166004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3627 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 527fb4d607a19c7f9b2d2bd84d4735bd6a0e0944 |
|
01-Mar-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Revert "Will now run pylint on all python files if there's at least one modified python file in the checkin."
This reverts commit 6bd8730dfad6e7c5a5cf9a089605fcb9f83a13e0.
TBR=ajm@webrtc.org
BUG=
Review URL: https://webrtc-codereview.appspot.com/1150004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3585 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| ba23d11564c23c4c5e1b2252f83396d37600f136 |
|
19-Feb-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Will now run pylint on all python files if there's at least one modified python file in the checkin.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1101011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3531 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 899699e6f3eb4c26c211b864115065d34332d69c |
|
21-Jan-2013 |
phoglund@webrtc.org <phoglund@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Enabled full lint checking for ALL WebRTC changes.
According to decision at the 14/1 -13 test sync meeting.
TESTED=Made local modification; noted the brutal amount of presubmit lint warnings.
BUG=
Review URL: https://webrtc-codereview.appspot.com/1063004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3394 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| f98ffc6db3562eac0ba9e85507242c425b41a6c3 |
|
11-Dec-2012 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Removing default trybot names
This is removing the default try bot names added in r3031. It doesn't seem like we need to avoid sending all jobs to these bots, even if they're much slower.
BUG=none
TEST=none
Review URL: https://webrtc-codereview.appspot.com/978004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3258 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| f3ffcceaf864d32ee95692fdb87f8420f7f7b88a |
|
31-Oct-2012 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adding default trybot names to PRESUBMIT.py.
With this change, only the listed trybots will be the ones that a tryjob
is sent to. This works because there's a check in depot_tools/presubmit_support.py that looks for a function defined with the name 'GetPreferredTrySlaves'.
This makes it possible for us to add new trybots that will not receive jobs by default (only when the --bot flag is specified).
This CL is needed before we add the following try bots:
linux_memcheck
linux_tsan
linux_asan
BUG=none
TEST=submitting jobs to a local try server, with and without the --bot
flag.
Review URL: https://webrtc-codereview.appspot.com/939008
git-svn-id: http://webrtc.googlecode.com/svn/trunk@3031 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 6307dbf4688b72233405ae72530d1182ac0159f4 |
|
31-Aug-2012 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Updates the PRESUBMIT.py to allow years from 2011 to the current year.
Since Chromium has moved to this policy, we should too.
Code is copied from /depot_tools/presubmit_canned_checks.py but modified for our purpose.
BUG=
TEST=Tested git cl presubmit with a modified .cc file with the 2011 header and one with the 2012.
Review URL: https://webrtc-codereview.appspot.com/770005
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2691 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 2a45209a6d17e12419e13592eba786e7ba7b1425 |
|
01-Jul-2012 |
mflodman@webrtc.org <mflodman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adde video_engine to cpplint check.
BUG=627
TEST=Manual test with style violations in src/video_engine and in other folders.
Review URL: https://webrtc-codereview.appspot.com/399014
git-svn-id: http://webrtc.googlecode.com/svn/trunk@2474 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 51198f1c683cff50986fd043dc2185bb336fed99 |
|
21-Feb-2012 |
kjellander@webrtc.org <kjellander@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
More PRESUBMIT checks.
Checks for:
- No iostream includes in headers
- No use of FRIEND_TEST for gtest
- Verifies that all C/C++ code passes cpplint.py check.
- Verifies that BUG= is present in commit message
- Verifies that TEST= is present in commit message
For more details, see Chrome's PRESUBMIT.py at
http://src.chromium.org/viewvc/chrome/trunk/src/PRESUBMIT.py?revision=113979&view=markup
and the canned checks at
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?view=markup
BUG=
TEST=
Review URL: https://webrtc-codereview.appspot.com/317011
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1737 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 53df136240bc78e8054085a2ef25c4240530a745 |
|
26-Jan-2012 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Add upload and commit checks to a common function.
Add HasDescription and HasNoStrayWhitespace checks.
BUG=none
TEST=uploaded a dummy CL with violations.
Review URL: https://webrtc-codereview.appspot.com/372004
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1556 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 2442de1351a8d9bee0912a09317122bb5bdb08bc |
|
23-Jan-2012 |
andrew@webrtc.org <andrew@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Clean up PRESUBMIT.py, and enable license check.
Fix the license header based on the example in:
http://src.chromium.org/viewvc/chrome/trunk/tools/depot_tools/presubmit_canned_checks.py?revision=107590&view=markup
BUG=None
TEST=Run presubmit checks on a dummy CL with Python and C code.
Review URL: https://webrtc-codereview.appspot.com/369002
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1511 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 9dddfaefdca066d7645e47c8f79b1ec3699bfabf |
|
20-Jan-2012 |
mflodman@webrtc.org <mflodman@webrtc.org@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Change copyright year.
Review URL: https://webrtc-codereview.appspot.com/353009
git-svn-id: http://webrtc.googlecode.com/svn/trunk@1492 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| 1198db9dd6017a286590ce3a7095b1deda7b94a9 |
|
09-Jun-2011 |
niklase@google.com <niklase@google.com@4adac7df-926f-26a2-2b94-8c16560cd09d> |
Adding owners check in presubmit script.
git-svn-id: http://webrtc.googlecode.com/svn/trunk@62 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|
| da159d6be61ae8041ab265092c2d6ba0ca7b64f5 |
|
30-May-2011 |
niklase@google.com <niklase@google.com@4adac7df-926f-26a2-2b94-8c16560cd09d> |
git-svn-id: http://webrtc.googlecode.com/svn/trunk@11 4adac7df-926f-26a2-2b94-8c16560cd09d
/external/webrtc/PRESUBMIT.py
|