core_validation.cpp revision 080afef66a53dbdd085698b713697296458edfd9
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 65b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Permission is hereby granted, free of charge, to any person obtaining a copy 75b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * of this software and/or associated documentation files (the "Materials"), to 85b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * deal in the Materials without restriction, including without limitation the 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or 105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sell copies of the Materials, and to permit persons to whom the Materials 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are furnished to do so, subject to the following conditions: 125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * The above copyright notice(s) and this permission notice shall be included 145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * in all copies or substantial portions of the Materials. 155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE MATERIALS OR THE 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * USE OR OTHER DEALINGS IN THE MATERIALS 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <assert.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_map> 455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_set> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <map> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string> 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <iostream> 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <algorithm> 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <list> 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <SPIRV/spirv.hpp> 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <set> 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_config.h" 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_logging.h" 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 wsi_enabled; 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 10903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - stuff pulled directly from MT 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t currentFenceId; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Maps for tracking key structs related to mem_tracker state 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, MT_DESCRIPTOR_SET_INFO> descriptorSetMap; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Images and Buffers are 2 objects that can have memory bound to them so they get special treatment 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<uint64_t, MT_OBJ_BINDING_INFO> imageBindingMap; 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<uint64_t, MT_OBJ_BINDING_INFO> bufferBindingMap; 11603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - End of MT stuff 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 119b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, SET_NODE *> setMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSetLayout, LAYOUT_NODE *> descriptorSetLayoutMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 13458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 14172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 146918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Current render pass 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassBeginInfo renderPassBeginInfo; 1495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t currentSubpass; 1506c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PHYS_DEV_PROPERTIES_NODE physDevProperties; 15403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - added a couple of fields to constructor initializer 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), 15703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 158de040b4d09f3714f94116be2a1841d448869bed2Tobin Ehlis currentFenceId(1), 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis device_extensions(){}; 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_global_layers[] = {{ 164f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(createInfo.ppEnabledLayerNames[i], cv_global_layers[0].layerName)) { 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cv_global_layers[0].layerName); 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t len() { return *it >> 16; } 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t const &word(unsigned n) { return it[n]; } 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int globalLockInitialized = 0; 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic loader_platform_thread_mutex globalLock; 25603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 25703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkPhysicalDeviceMemoryProperties memProps; 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *my_data, const VkCommandBuffer cb); 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define MAX_BINDING 0xFFFFFFFF 2635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic MT_OBJ_BINDING_INFO *get_object_binding_info(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_BINDING_INFO *retValue = NULL; 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 2685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = my_data->imageBindingMap.find(handle); 2695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it != my_data->imageBindingMap.end()) 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*it).second; 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 2745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = my_data->bufferBindingMap.find(handle); 2755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it != my_data->bufferBindingMap.end()) 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*it).second; 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return retValue; 2835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate layer_data *get_my_data_ptr<layer_data>(void *data_key, std::unordered_map<void *, layer_data *> &data_map); 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 28972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *, const VkCommandBuffer); 29072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 29103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void delete_queue_info_list(layer_data *my_data) { 2935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process queue list, cleaning up each entry before deleting 2945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap.clear(); 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Delete CBInfo from container and clear mem references to CB 29872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic void delete_cmd_buf_info(layer_data *my_data, VkCommandPool commandPool, const VkCommandBuffer cb) { 29972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(my_data, cb); 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete the CBInfo info 30172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandPoolMap[commandPool].commandBuffers.remove(cb); 30272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.erase(cb); 3035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_object_binding_info(layer_data *my_data, const uint64_t handle, const VkDebugReportObjectTypeEXT type, 3065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceMemory mem) { 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Buffers and images are unique as their CreateInfo is in container struct 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pCI = &my_data->bufferBindingMap[handle]; 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCI->mem = mem; 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pCI = &my_data->imageBindingMap[handle]; 3165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCI->mem = mem; 3175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_object_create_info(layer_data *my_data, const uint64_t handle, const VkDebugReportObjectTypeEXT type, 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pCreateInfo) { 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : For any CreateInfo struct that has ptrs, need to deep copy them and appropriately clean up on Destroy 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Buffers and images are unique as their CreateInfo is in container struct 3295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pCI = &my_data->bufferBindingMap[handle]; 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCI, 0, sizeof(MT_OBJ_BINDING_INFO)); 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pCI->create_info.buffer, pCreateInfo, sizeof(VkBufferCreateInfo)); 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pCI = &my_data->imageBindingMap[handle]; 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCI, 0, sizeof(MT_OBJ_BINDING_INFO)); 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pCI->create_info.image, pCreateInfo, sizeof(VkImageCreateInfo)); 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Swap Chain is very unique, use my_data->imageBindingMap, but copy in 3425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // SwapChainCreatInfo's usage flags and set the mem value to a unique key. These is used by 3435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkCreateImageView and internal mem_tracker routines to distinguish swap chain images 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: { 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pCI = &my_data->imageBindingMap[handle]; 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCI, 0, sizeof(MT_OBJ_BINDING_INFO)); 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCI->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCI->valid = false; 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCI->create_info.image.usage = 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const_cast<VkSwapchainCreateInfoKHR *>(static_cast<const VkSwapchainCreateInfoKHR *>(pCreateInfo))->imageUsage; 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add a fence, creating one if necessary to our list of fences/fenceIds 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 add_fence_info(layer_data *my_data, VkFence fence, VkQueue queue, uint64_t *fenceId) { 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *fenceId = my_data->currentFenceId++; 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no fence, create an internal fence to track the submissions 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 3655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].fenceId = *fenceId; 3665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].queue = queue; 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that fence is in UNSIGNALED state 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFenceCreateInfo *pFenceCI = &(my_data->fenceMap[fence].createInfo); 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceCI->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence); 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Do we need to create an internal fence here for tracking purposes? 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update most recently submitted fence and fenceId for Queue 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap[queue].lastSubmittedId = *fenceId; 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove a fenceInfo from our list of fences/fenceIds 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void delete_fence_info(layer_data *my_data, VkFence fence) { my_data->fenceMap.erase(fence); } 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Record information when a fence is known to be signalled 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void update_fence_tracking(layer_data *my_data, VkFence fence) { 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = my_data->fenceMap.find(fence); 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != my_data->fenceMap.end()) { 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pCurFenceInfo = &(*fence_item).second; 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue queue = pCurFenceInfo->queue; 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_item = my_data->queueMap.find(queue); 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_item != my_data->queueMap.end()) { 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*queue_item).second; 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pQueueInfo->lastRetiredId < pCurFenceInfo->fenceId) { 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pCurFenceInfo->fenceId; 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update fence state in fenceCreateInfo structure 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFCI = &(my_data->fenceMap[fence].createInfo); 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFCI->flags = static_cast<VkFenceCreateFlags>(pFCI->flags | VK_FENCE_CREATE_SIGNALED_BIT); 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates the fence list for a specific queue to all-retired 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_queue_fences(layer_data *my_data, VkQueue queue) { 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates all queues to all-retired 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_device_fences(layer_data *my_data, VkDevice device) { 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process each queue for device 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add multiple device support 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->queueMap.begin(); ii != my_data->queueMap.end(); ++ii) { 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*ii).second; 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 4255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_usage_flags(layer_data *my_data, void *disp_obj, VkFlags actual, VkFlags desired, VkBool32 strict, 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char const *func_name, char const *usage_str) { 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 correct_usage = VK_FALSE; 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 4365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s %#" PRIxLEAST64 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 4475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_image_usage_flags(layer_data *my_data, void *disp_obj, VkImage image, VkFlags desired, VkBool32 strict, 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char const *func_name, char const *usage_string) { 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_BINDING_INFO *pBindInfo = get_object_binding_info(my_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBindInfo) { 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = validate_usage_flags(my_data, disp_obj, pBindInfo->create_info.image.usage, desired, strict, (uint64_t)image, 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_buffer_usage_flags(layer_data *my_data, void *disp_obj, VkBuffer buffer, VkFlags desired, VkBool32 strict, 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char const *func_name, char const *usage_string) { 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_BINDING_INFO *pBindInfo = get_object_binding_info(my_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBindInfo) { 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = validate_usage_flags(my_data, disp_obj, pBindInfo->create_info.buffer.usage, desired, strict, (uint64_t)buffer, 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 47658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 47758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 47858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].refCount = 0; 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 49558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 4995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 5005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = VK_NULL_HANDLE) { 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 50658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis MT_OBJ_BINDING_INFO *pBindInfo = 50758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis get_object_binding_info(dev_data, reinterpret_cast<const uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBindInfo && !pBindInfo->valid) { 50958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 5115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid swapchain image %" PRIx64 ", please fill the memory before using.", 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 51558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 51758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid memory %" PRIx64 ", please fill the memory before using.", functionName, 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 5215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 52858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis MT_OBJ_BINDING_INFO *pBindInfo = 52958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis get_object_binding_info(dev_data, reinterpret_cast<const uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBindInfo) { 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBindInfo->valid = valid; 5325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 54358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *apiName) { 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 55158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Search for cmd buffer object in memory object's binding list 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 found = VK_FALSE; 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo->pCommandBufferBindings.size() > 0) { 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<VkCommandBuffer>::iterator it = pMemInfo->pCommandBufferBindings.begin(); 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it != pMemInfo->pCommandBufferBindings.end(); ++it) { 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((*it) == cb) { 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found = VK_TRUE; 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If not present, add to list 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (found == VK_FALSE) { 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemInfo->pCommandBufferBindings.push_front(cb); 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemInfo->refCount++; 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 57072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 57272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Search for memory object in cmd buffer's reference list 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 found = VK_FALSE; 57572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->pMemObjList.size() > 0) { 57672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto it = pCBNode->pMemObjList.begin(); it != pCBNode->pMemObjList.end(); ++it) { 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((*it) == mem) { 5785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found = VK_TRUE; 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If not present, add to list 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (found == VK_FALSE) { 58572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->pMemObjList.push_front(mem); 5865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free bindings related to CB 59472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 59572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 59872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->pMemObjList.size() > 0) { 59972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis list<VkDeviceMemory> mem_obj_list = pCBNode->pMemObjList; 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<VkDeviceMemory>::iterator it = mem_obj_list.begin(); it != mem_obj_list.end(); ++it) { 60158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, *it); 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->pCommandBufferBindings.remove(cb); 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->refCount--; 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->pMemObjList.clear(); 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->activeDescriptorSets.clear(); 61072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Delete the entire CB list 61572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic void delete_cmd_buf_info_list(layer_data *my_data) { 61672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 61772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(my_data, cb_node.first); 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.clear(); 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 62358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 6245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t cmdBufRefCount = pMemObjInfo->pCommandBufferBindings.size(); 6265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t objRefCount = pMemObjInfo->pObjBindings.size(); 6275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pMemObjInfo->pCommandBufferBindings.size()) != 0) { 62958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory object %#" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 6325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 6335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 6345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cmdBufRefCount > 0 && pMemObjInfo->pCommandBufferBindings.size() > 0) { 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<VkCommandBuffer>::const_iterator it = pMemObjInfo->pCommandBufferBindings.begin(); 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it != pMemObjInfo->pCommandBufferBindings.end(); ++it) { 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : CommandBuffer should be source Obj here 64058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(*it), __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Command Buffer %p still has a reference to mem obj %#" PRIxLEAST64, (*it), (uint64_t)pMemObjInfo->mem); 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObjInfo->pCommandBufferBindings.clear(); 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (objRefCount > 0 && pMemObjInfo->pObjBindings.size() > 0) { 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto it = pMemObjInfo->pObjBindings.begin(); it != pMemObjInfo->pObjBindings.end(); ++it) { 65058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, it->type, it->handle, __LINE__, 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_FREED_MEM_REF, "MEM", "VK Object %#" PRIxLEAST64 " still has a reference to mem obj %#" PRIxLEAST64, 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it->handle, (uint64_t)pMemObjInfo->mem); 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObjInfo->pObjBindings.clear(); 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 6615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 6625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Request to delete memory object %#" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check if fence for given CB is completed 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkCBCompleted(layer_data *my_data, const VkCommandBuffer cb, bool *complete) { 67572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(my_data, cb); 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = false; 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = true; 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 68072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->lastSubmittedQueue != NULL) { 68172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkQueue queue = pCBNode->lastSubmittedQueue; 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 68372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->fenceId > pQueueInfo->lastRetiredId) { 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)cb, __LINE__, MEMTRACK_NONE, "MEM", 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "fence %#" PRIxLEAST64 " for CB %p has not been checked for completion", 68772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCBNode->lastSubmittedFence, cb); 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = false; 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, VkBool32 internal) { 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 69858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 7015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 70258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 7035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 7045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory associated with a Persistent Image, %#" PRIxLEAST64 ", " 7055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 7135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer>::iterator it = pInfo->pCommandBufferBindings.begin(); 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer>::iterator temp; 7155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pInfo->pCommandBufferBindings.size() > 0 && it != pInfo->pCommandBufferBindings.end()) { 71658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= checkCBCompleted(dev_data, *it, &commandBufferComplete); 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (commandBufferComplete) { 7185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis temp = it; 7195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++temp; 72072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *it); 7215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it = temp; 7225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 7285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->refCount) { 72958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 7305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 73258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 7395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 7465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 2. Decrement refCount for MemObjInfo 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 3. Clear mem binding for image/buffer by setting its handle to 0 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 75658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 clear_object_binding(layer_data *dev_data, void *dispObj, uint64_t handle, VkDebugReportObjectTypeEXT type) { 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 75958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis MT_OBJ_BINDING_INFO *pObjBindInfo = get_object_binding_info(dev_data, handle, type); 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pObjBindInfo) { 76158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, pObjBindInfo->mem); 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pObjBindInfo->mem = VK_NULL_HANDLE; 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, decrement the 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // memObj's refcount 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 clearSucceeded = VK_FALSE; 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto it = pMemObjInfo->pObjBindings.begin(); it != pMemObjInfo->pObjBindings.end(); ++it) { 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((it->handle == handle) && (it->type == type)) { 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObjInfo->refCount--; 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObjInfo->pObjBindings.erase(it); 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearSucceeded = VK_TRUE; 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == clearSucceeded) { 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj %#" PRIxLEAST64 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", unable to find that object referenced by mem obj %#" PRIxLEAST64, 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// device is required for error logging, need a dispatchable 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// object for that. 79658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 set_mem_binding(layer_data *dev_data, void *dispatch_object, VkDeviceMemory mem, uint64_t handle, 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 80258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(%#" PRIxLEAST64 ") to NULL", apiName, handle); 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis MT_OBJ_BINDING_INFO *pObjBindInfo = get_object_binding_info(dev_data, handle, type); 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pObjBindInfo) { 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to update Binding of %s Obj(%#" PRIxLEAST64 ") that's not in global list()", 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 81358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to track mem binding for obj and report conflict here 81658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, pObjBindInfo->mem); 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 81958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to bind memory (%#" PRIxLEAST64 ") to object (%#" PRIxLEAST64 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") which has already been bound to mem object %#" PRIxLEAST64, 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_HANDLE_TYPE oht; 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis oht.handle = handle; 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis oht.type = type; 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemInfo->pObjBindings.push_front(oht); 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemInfo->refCount++; 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageCreateInfo ici = pObjBindInfo->create_info.image; 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO:: More memory state transition stuff. 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pObjBindInfo->mem = mem; 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return VK_TRUE if addition is successful, VK_FALSE otherwise 85258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic VkBool32 set_sparse_mem_binding(layer_data *dev_data, void *dispObject, VkDeviceMemory mem, uint64_t handle, 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 85758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = clear_object_binding(dev_data, dispObject, handle, type); 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis MT_OBJ_BINDING_INFO *pObjBindInfo = get_object_binding_info(dev_data, handle, type); 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pObjBindInfo) { 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 86258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to update Binding of Obj(%#" PRIxLEAST64 ") that's not in global list()", apiName, handle); 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 86658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Search for object in memory object's binding list 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 found = VK_FALSE; 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->pObjBindings.size() > 0) { 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto it = pInfo->pObjBindings.begin(); it != pInfo->pObjBindings.end(); ++it) { 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((*it).handle == handle) && ((*it).type == type)) { 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found = VK_TRUE; 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If not present, add to list 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (found == VK_FALSE) { 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_HANDLE_TYPE oht; 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis oht.handle = handle; 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis oht.type = type; 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->pObjBindings.push_front(oht); 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->refCount++; 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to set mem binding for this object 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pObjBindInfo->mem = mem; 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <typename T> 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid print_object_map_members(layer_data *my_data, void *dispObj, T const &objectName, VkDebugReportObjectTypeEXT objectType, 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *objectStr) { 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &element : objectName) { 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, objectType, 0, __LINE__, MEMTRACK_NONE, "MEM", 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " %s Object list contains %s Object %#" PRIxLEAST64 " ", objectStr, objectStr, element.first); 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 get_mem_binding_from_object(layer_data *my_data, void *dispObj, const uint64_t handle, 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_OBJ_BINDING_INFO *pObjBindInfo = get_object_binding_info(my_data, handle, type); 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pObjBindInfo) { 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pObjBindInfo->mem) { 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = pObjBindInfo->mem; 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but object has no mem binding", handle); 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but no such object in %s list", handle, 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 92558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void print_mem_list(layer_data *dev_data, void *dispObj) { 92658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 92958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 93458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 93658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 93758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at %p===", (void *)pInfo); 94858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: %#" PRIxLEAST64, (uint64_t)(pInfo->mem)); 95058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: %u", pInfo->refCount); 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 95458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->pObjBindings.size()); 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->pObjBindings.size() > 0) { 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<MT_OBJ_HANDLE_TYPE>::iterator it = pInfo->pObjBindings.begin(); it != pInfo->pObjBindings.end(); ++it) { 96658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 96758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT %" PRIu64, it->handle); 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo->pCommandBufferBindings.size()); 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->pCommandBufferBindings.size() > 0) { 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<VkCommandBuffer>::iterator it = pInfo->pCommandBufferBindings.begin(); 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it != pInfo->pCommandBufferBindings.end(); ++it) { 97858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 97958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB %p", (*it)); 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCBList(layer_data *my_data, void *dispObj) { 98672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 99472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 99572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 100372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " CB Info (%p) has CB %p, fenceId %" PRIx64 ", and fence %#" PRIxLEAST64, 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCBInfo, (void *)pCBInfo->commandBuffer, pCBInfo->fenceId, (uint64_t)pCBInfo->lastSubmittedFence); 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCBInfo->pMemObjList.size() <= 0) 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (list<VkDeviceMemory>::iterator it = pCBInfo->pMemObjList.begin(); it != pCBInfo->pMemObjList.end(); ++it) { 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem obj %" PRIu64, (uint64_t)(*it)); 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) { 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t *words = (uint32_t *)pCreateInfo->pCode; 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Just validate that the header makes sense. */ 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12519ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 12599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12619ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 12629ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 12659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 12679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 12689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 12729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 12769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 12809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 12819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 12839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 12859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 12869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 12879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 12889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 12899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 12909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 12959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 12969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 12989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 12999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 13009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 13029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 13039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 13069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 13129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 13139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 13149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 13159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 13169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool b_arrayed) { 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return types_match(a, b, a_type, b_insn.word(2), false); 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* if b_arrayed and we hit a leaf type, then we can't match -- there's nowhere for the extra OpTypeArray to be! */ 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true && !b_arrayed; 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3) && !b_arrayed; 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return a_insn.word(2) == b_insn.word(2) && !b_arrayed; 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed -- that is handled above. */ 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return !b_arrayed && types_match(a, b, a_insn.word(2), b_insn.word(2), b_arrayed) && a_insn.word(3) == b_insn.word(3); 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return !b_arrayed && types_match(a, b, a_insn.word(2), b_insn.word(2), b_arrayed) && 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed) { 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* for the purposes of matching different levels of arrayness, structs are leaves. */ 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!types_match(a, b, a_insn.word(i), b_insn.word(i), b_arrayed)) { 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on pointee type. storage class is expected to differ */ 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return types_match(a, b, a_insn.word(3), b_insn.word(3), b_arrayed); 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14486c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_block_members(layer_data *my_data, shader_module const *src, 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id, uint32_t type_id) { 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts); 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14986c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_location(layer_data *my_data, shader_module const *src, spirv_inst_iter entrypoint, 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * have the same location, and we DONT want to clobber. */ 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto word = 3; 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == sinterface) { 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 15545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts); 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 15776c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_block_members(my_data, src, out, blocks, is_array_of_verts, id, type); 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15836c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_descriptor_slot(layer_data *my_data, shader_module const *src, 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1617080afef66a53dbdd085698b713697296458edfd9Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16326c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_interface_between_stages(layer_data *my_data, shader_module const *producer, 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter producer_entrypoint, char const *producer_name, 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char const *consumer_name, bool consumer_arrayed_input) { 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16416c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, producer, producer_entrypoint, spv::StorageClassOutput, outputs, false); 16426c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, consumer, consumer_entrypoint, spv::StorageClassInput, inputs, 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer_arrayed_input); 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1656080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1657080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s writes to output location %u.%u which is not consumed by %s", producer_name, a_first.first, 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_first.second, consumer_name)) { 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1664080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s consumes input location %u.%u which is not written by %s", consumer_name, b_first.first, b_first.second, 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer_name)) { 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, consumer_arrayed_input)) { 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1675080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 16779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 16789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 16799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17706c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_consistency(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi) { 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1781080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17946c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_against_vs_inputs(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi, 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17996c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, vs, entrypoint, spv::StorageClassInput, inputs, false); 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attribs[vi->pVertexAttributeDescriptions[i].location] = &vi->pVertexAttributeDescriptions[i]; 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1817080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1818080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1836080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 18399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 18409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18546c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_fs_outputs_against_render_pass(layer_data *my_data, shader_module const *fs, 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18626c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, fs, entrypoint, spv::StorageClassOutput, outputs, false); 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = outputs.begin(); 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = 0; 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk attachment list and outputs together -- this is a little overpowered since attachments 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are currently dense, but the parallel with matching between shader stages is nice. 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == color_formats.size() || (it != outputs.end() && it->first.first < attachment)) { 1873080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "FS writes to output location %d with no matching attachment", it->first.first)) { 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (it == outputs.end() || it->first.first > attachment) { 1880080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", attachment)) { 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned output_type = get_fundamental_type(fs, it->second.type_id); 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned att_type = get_format_type(color_formats[attachment]); 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1891080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d of type `%s` does not match FS output type of `%s`", attachment, 18949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(color_formats[attachment]), 18959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(fs, it->second.type_id).c_str())) { 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* id is something we didnt collect in build_def_index. that's OK -- we'll stumble 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 3; i < insn.len(); i++) { 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 5; i < insn.len(); i++) { 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_stage_attributes { 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char const *const name; 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool arrayed_input; 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic shader_stage_attributes shader_stage_attribs[] = { 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis {"vertex shader", false}, 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis {"tessellation control shader", true}, 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis {"tessellation evaluation shader", false}, 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis {"geometry shader", true}, 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis {"fragment shader", false}, 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20396c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_block_against_pipeline(layer_data *my_data, 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2065080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2066080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2079080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2080080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20946c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_usage(layer_data *my_data, 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2102080afef66a53dbdd085698b713697296458edfd9Chris Forbes pass &= validate_push_constant_block_against_pipeline(my_data, pushConstantRanges, src, 2103080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipelineLayout verify that the setLayout at slot.first 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// has the requested binding at slot.second 211278be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(layer_data *my_data, PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 211537083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 211778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 211837083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 212078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto const layout_node = my_data->descriptorSetLayoutMap[pipelineLayout->descriptorSetLayouts[slot.first]]; 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingIt = layout_node->bindingToIndexMap.find(slot.second); 212314fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis if ((bindingIt == layout_node->bindingToIndexMap.end()) || (layout_node->createInfo.pBindings == NULL)) 212437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 212614fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis assert(bindingIt->second < layout_node->createInfo.bindingCount); 212737083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return &layout_node->createInfo.pBindings[bindingIt->second]; 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 hasDrawCmd(GLOBAL_CB_NODE *pCB) { 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 21483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisstatic VkBool32 validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 21493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAW_STATE_ERROR error_code, const char *fail_msg) { 21503d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 21513d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 21523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 21533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *getPipeline(layer_data *my_data, const VkPipeline pipeline) { 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->pipelineMap[pipeline]; 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return VK_TRUE if for a given PSO, the given state enum is dynamic, else return VK_FALSE 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 21783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisstatic VkBool32 validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, 21793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis VkBool32 indexedDraw) { 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 result; 21813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 21823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 21833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 21843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 21853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if ((pPipe->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 21863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP)) { 21873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 21893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->rsStateCI.depthBiasEnable) { 21913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 21933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 21953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 21973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->dsStateCI.depthBoundsTestEnable) { 21993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 22013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->dsStateCI.stencilTestEnable) { 22033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22043d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 22053d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 22073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 22093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 22113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 22143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 222806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 222906e963555b0df747c98c43816c16647349d21001Mark Young return true; 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 223106e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 223206e963555b0df747c98c43816c16647349d21001Mark Young return true; 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 22355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis stringstream errorStr; 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "depth/stencil attachments at index " << cIdx << " of subpass index " << spIndex 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " are not compatible."; 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const SET_NODE *pSet, const VkPipelineLayout layout, 23175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t layoutIndex, string &errorMsg) { 23185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis stringstream errorStr; 2319ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2320ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 23215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 23225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2325ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2326ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2327ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get the specific setLayout from PipelineLayout that overlaps this set 2333ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes LAYOUT_NODE *pLayoutNode = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t descriptorCount = pLayoutNode->descriptorTypes.size(); 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors."; 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; // trivial fail case 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now need to check set against corresponding pipelineLayout to verify compatibility 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (size_t i = 0; i < descriptorCount; ++i) { 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to verify that layouts are identically defined 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // do we also need to check immutable samplers? 23505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "descriptor " << i << " for descriptorSet being bound is type '" 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) 23535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout is type '" 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; 23555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] 23605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_specialization_offsets(layer_data *my_data, VkPipelineShaderStageCreateInfo const *info) { 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 pass = VK_TRUE; 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = VK_FALSE; 23865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 23925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool descriptor_type_match(layer_data *my_data, shader_module const *module, uint32_t type_id, 23951b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 23975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23981b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 23991b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 24007b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 24017b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 24037b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 24047b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 24057b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 24067b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24077b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 24087b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 24097b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 24135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 24145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 24155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 24165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 24175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 24185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 24195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 24205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 24225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 24275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 24315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 24325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 243435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 243535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 243635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 243735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 243835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 243935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 244035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 244135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 244235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 244335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 24475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 24485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 24535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 24545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 24565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 24575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 24585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 24595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 24605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 24625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 24645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 24655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 24675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 24715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 24725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 24745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 24755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbesstatic VkBool32 require_feature(layer_data *my_data, VkBool32 feature, char const *feature_name) { 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 2480080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2481080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 24926c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic VkBool32 validate_shader_capabilities(layer_data *my_data, shader_module const *src) 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes{ 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes VkBool32 pass = VK_TRUE; 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes auto enabledFeatures = &my_data->physDevProperties.features; 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2500a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2505a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2510a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 2514a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->geometryShader, "geometryShader"); 2515a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 2518a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->tessellationShader, "tessellationShader"); 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2523a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2524a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderInt64, "shaderInt64"); 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2528a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2529a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2533a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2537a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2546a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2547a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2548a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2550a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2551a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2552a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2553a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 2554a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2555a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2556a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2557a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2558a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 2559a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2560a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2561a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2562a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2563a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 2564a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2565a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2566a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2567a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 2568a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2569a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2570a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2571a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 2572a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2573a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2574a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2575a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 2576a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2577a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2578a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2579a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 2580a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2581a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2582a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2583a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 2584a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2585a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2586a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2587a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 2588a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2589a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2590a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2591a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 2592a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2593a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2594a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2595a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 2596a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageExtendedFormats, 2597a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2598a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2599a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2600a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 2601a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2602a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2603a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2604a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 2605a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2606a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2607a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2608a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2609a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 2610a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2611a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2612a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2613a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2614a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 2615a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->multiViewport, "multiViewport"); 2616a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2617a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2618a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 2619080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2620a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2621a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2622a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2623a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass = VK_FALSE; 2624a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2625a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2626a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2627a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2628a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2629a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2630a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2631a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2632a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 263378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263478be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkBool32 validate_pipeline_shader_stage(layer_data *dev_data, 263578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 263678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes PIPELINE_NODE *pipeline, 263778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes PIPELINE_LAYOUT_NODE *pipelineLayout, 263878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes shader_module **out_module, 263978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes spirv_inst_iter *out_entrypoint) 264078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes{ 264178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes VkBool32 pass = VK_TRUE; 264278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto module = *out_module = dev_data->shaderModuleMap[pStage->module].get(); 264378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_specialization_offsets(dev_data, pStage); 264478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 264578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 264678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 264778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2648080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2649080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 265078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 265178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 265278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass = VK_FALSE; 265378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 265478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 265578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 265678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 265778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_shader_capabilities(dev_data, module); 265878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 265978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 266078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 266178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 266278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 266378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 266478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 266578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes collect_interface_by_descriptor_slot(dev_data, module, accessible_ids, descriptor_uses); 266678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 266778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 266878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_push_constant_usage(dev_data, &pipelineLayout->pushConstantRanges, 266978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 267078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 267178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 267278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 267378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 267478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 267578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 267678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the matching binding */ 267778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto binding = get_descriptor_binding(dev_data, pipelineLayout, use.first); 267878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 267978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 268078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2681080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2682080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 268378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 268478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 268578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass = VK_FALSE; 268678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 268778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 268878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 268978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 269078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 269178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 269278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 269378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 269478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 269578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 269678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass = VK_FALSE; 269778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 269878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (!descriptor_type_match(dev_data, module, use.second.type_id, binding->descriptorType, /*out*/ required_descriptor_count)) { 2699080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2700080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 270178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Type mismatch on descriptor slot " 270278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "%u.%u (used as type `%s`) but " 270378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "descriptor of type %s", 270478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 270578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 270678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 270778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass = VK_FALSE; 270878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 270978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2710080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2711080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 271278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 271378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 271478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 271578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes binding->descriptorCount)) { 271678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass = VK_FALSE; 271778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 271878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 271978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 272078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 272178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 272278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 272378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 272478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2725a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2726a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 27276c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic VkBool32 validate_and_capture_pipeline_shader_state(layer_data *my_data, PIPELINE_NODE *pPipeline) { 27285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkGraphicsPipelineCreateInfo const *pCreateInfo = &pPipeline->graphicsPipelineCI; 27295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 27305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 27315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 27335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 27345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 27355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 27365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 27375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 pass = VK_TRUE; 27385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 273978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 274078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 27415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 27425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineShaderStageCreateInfo const *pStage = &pCreateInfo->pStages[i]; 274378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 274478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_pipeline_shader_stage(my_data, pStage, pPipeline, pipelineLayout, 274578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes &shaders[stage_id], &entrypoints[stage_id]); 27465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 27495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 27516c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes pass = validate_vi_consistency(my_data, vi) && pass; 27525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 27556c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes pass = validate_vi_against_vs_inputs(my_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]) && pass; 27565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 27595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 27605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 27625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 27635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 27645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 27675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 27685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 27696c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes pass = validate_interface_between_stages(my_data, shaders[producer], entrypoints[producer], 27705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_stage_attribs[producer].name, shaders[consumer], entrypoints[consumer], 27715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_stage_attribs[consumer].name, 27725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_stage_attribs[consumer].arrayed_input) && 27735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass; 27745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 27765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 277978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto rp = pCreateInfo->renderPass != VK_NULL_HANDLE ? my_data->renderPassMap[pCreateInfo->renderPass] : nullptr; 278078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 27815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[fragment_stage] && rp) { 27826c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes pass = validate_fs_outputs_against_render_pass(my_data, shaders[fragment_stage], entrypoints[fragment_stage], rp, 27835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->subpass) && 27845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass; 27855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 27885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 27915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic SET_NODE *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 27925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 27935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 27945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 27965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2797a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2798a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given Layout Node and binding, return index where that binding begins 2799a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingStartIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2800a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2801a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2802a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2803a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2804a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2805a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2806a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex; 2807a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2808a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2809a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given layout node and binding, return last index that is updated 2810a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingEndIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2811a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2812a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2813a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2814a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2815a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2816a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2817a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex - 1; 2818a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2819a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2820a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For the given command buffer, verify that for each set in activeSetBindingsPairs 28215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// that any dynamic descriptor in that set has a valid dynamic offset bound. 2822c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 28235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 2824a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic VkBool32 validate_dynamic_offsets(layer_data *my_data, const GLOBAL_CB_NODE *pCB, 2825a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis const vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 28265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 result = VK_FALSE; 28275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 28295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dynOffsetIndex = 0; 28305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize bufferSize = 0; 2831a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2832a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis SET_NODE *set_node = set_bindings_pair.first; 2833a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis LAYOUT_NODE *layout_node = set_node->pLayout; 2834a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto binding : set_bindings_pair.second) { 2835a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t startIdx = getBindingStartIndex(layout_node, binding); 2836a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t endIdx = getBindingEndIndex(layout_node, binding); 2837a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = startIdx; i <= endIdx; ++i) { 28383a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis // TODO : Flag error here if set_node->pDescriptorUpdates[i] is NULL 28393a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis switch (set_node->pDescriptorUpdates[i]->sType) { 28405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 28413a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pWDS = (VkWriteDescriptorSet *)set_node->pDescriptorUpdates[i]; 28425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 28435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 28445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bufferSize = my_data->bufferMap[pWDS->pBufferInfo[j].buffer].create_info->size; 284672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis uint32_t dynOffset = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets[dynOffsetIndex]; 28475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pWDS->pBufferInfo[j].range == VK_WHOLE_SIZE) { 284872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((dynOffset + pWDS->pBufferInfo[j].offset) > bufferSize) { 2849c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2850c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2851c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2852c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2853c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has range of " 2854c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "VK_WHOLE_SIZE but dynamic offset %#" PRIxLEAST32 ". " 2855c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "combined with offset %#" PRIxLEAST64 " oversteps its buffer (%#" PRIxLEAST64 2856c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis ") which has a size of %#" PRIxLEAST64 ".", 2857c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), i, 2858c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis pCB->dynamicOffsets[dynOffsetIndex], pWDS->pBufferInfo[j].offset, 2859c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 286172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > bufferSize) { 2862c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis result |= log_msg( 2863c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2864c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2865c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, 2866c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "DS", 2867c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2868c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2869c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis " from its update, this oversteps its buffer " 2870c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2871c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), i, pCB->dynamicOffsets[dynOffsetIndex], 2872c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2873c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 287472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > bufferSize) { 2875c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis result |= log_msg( 2876c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2877c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2878c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, 2879c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "DS", 2880c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2881c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2882c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis " from its update, this oversteps its buffer " 2883c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2884c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), i, pCB->dynamicOffsets[dynOffsetIndex], 2885c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2886c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 28875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dynOffsetIndex++; 28895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i += j; // Advance i to end of this set of descriptors (++i at end of for loop will move 1 index past 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // last of these descriptors) 28915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 28945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: // Currently only shadowing Write update nodes so shouldn't get here 28955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 28965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 28975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 29055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, VkBool32 indexedDraw) { 290672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 29073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 29083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis VkBool32 result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 29105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Currently only performing next check if *something* was bound (non-zero last bound) 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There is probably a better way to gate when this check happens, and to know if something *should* have been bound 29125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // We should have that check separately and then gate this check based on that check 29135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipe) { 291472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &state = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS]; 291572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (state.pipelineLayout) { 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString; 29175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2918a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> activeSetBindingsPairs; 2919a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 2920a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t setIndex = setBindingPair.first; 29215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If valid set is not bound throw an error 292272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 29235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 29255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", 29265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPipe->pipeline, setIndex); 292772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 29285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 293072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->set; 29315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg( 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 29335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 29345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 29355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 29375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated and verify any dynamic offsets 29385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull the set node 293972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis SET_NODE *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 29405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2941a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // activeSetNodes.push_back(pSet); 2942a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure set has been updated 29445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet->pUpdateStructs) { 29455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 29465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pSet->set, __LINE__, 29475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 29485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS %#" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 29495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this will result in undefined behavior.", 29505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSet->set); 29515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each dynamic descriptor, make sure dynamic offset doesn't overstep buffer 295572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (!state.dynamicOffsets.empty()) 2956a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis result |= validate_dynamic_offsets(my_data, pCB, activeSetBindingsPairs); 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify Vtx binding 29595188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes if (pPipe->vertexBindingDescriptions.size() > 0) { 29605188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 29615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 296272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 296372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 296472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "The Pipeline State Object (%#" PRIxLEAST64 296572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 296672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " should be set via vkCmdBindVertexBuffers.", 296772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline, i); 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 29735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 29755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", 297672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 29775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable) && 29835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 29865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dynViewport) { 29875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 29885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 29915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 29925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 29935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dynScissor) { 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int pipelineIndex) { 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 30405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 30475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!my_data->physDevProperties.features.independentBlend) { 30483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 304926c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3050c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3051c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3052c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3053c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3054c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3055c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3056c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3057c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3058c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3059c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3060c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3061c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3062c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3063c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!my_data->physDevProperties.features.logicOp && 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3084a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 30905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30966c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data, pPipeline)) { 30975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = VK_TRUE; 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 31245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->iaStateCI.topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 31255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->iaStateCI.topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->tessStateCI.patchControlPoints || (pPipeline->tessStateCI.patchControlPoints > 32)) { 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->tessStateCI.patchControlPoints); 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable) { 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->vpStateCI.viewportCount, pPipeline->vpStateCI.scissorCount); 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Init the pipeline mapping info based on pipeline create info LL tree 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Threading note : Calls to this function should wrapped in mutex 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : this should really just be in the constructor for PIPELINE_NODE 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *initGraphicsPipeline(layer_data *dev_data, const VkGraphicsPipelineCreateInfo *pCreateInfo) { 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = new PIPELINE_NODE; 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First init create info 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->graphicsPipelineCI, pCreateInfo, sizeof(VkGraphicsPipelineCreateInfo)); 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t bufferSize = 0; 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkPipelineVertexInputStateCreateInfo *pVICI = NULL; 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkPipelineColorBlendStateCreateInfo *pCBCI = NULL; 32055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i]; 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pPSSCI->stage) { 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_VERTEX_BIT: 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->vsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_VERTEX_BIT; 32135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT: 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->tcsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT; 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT: 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->tesCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT; 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_GEOMETRY_BIT: 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->gsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_GEOMETRY_BIT; 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_FRAGMENT_BIT: 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeline->fsCI, pPSSCI, sizeof(VkPipelineShaderStageCreateInfo)); 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_FRAGMENT_BIT; 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_SHADER_STAGE_COMPUTE_BIT: 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error, CS is specified through VkComputePipelineCreateInfo 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->active_shaders |= VK_SHADER_STAGE_COMPUTE_BIT; 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Copy over GraphicsPipelineCreateInfo structure embedded pointers 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->stageCount != 0) { 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pStages = new VkPipelineShaderStageCreateInfo[pCreateInfo->stageCount]; 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bufferSize = pCreateInfo->stageCount * sizeof(VkPipelineShaderStageCreateInfo); 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pPipeline->graphicsPipelineCI.pStages, pCreateInfo->pStages, bufferSize); 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pVertexInputState != NULL) { 32465188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->vertexInputCI = *pCreateInfo->pVertexInputState; 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Copy embedded ptrs 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pVICI = pCreateInfo->pVertexInputState; 32495188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes if (pVICI->vertexBindingDescriptionCount) { 32505188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->vertexBindingDescriptions = std::vector<VkVertexInputBindingDescription>( 32515188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pVICI->pVertexBindingDescriptions, pVICI->pVertexBindingDescriptions + pVICI->vertexBindingDescriptionCount); 32525188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes } 32535188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes if (pVICI->vertexAttributeDescriptionCount) { 32545188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->vertexAttributeDescriptions = std::vector<VkVertexInputAttributeDescription>( 32555188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pVICI->pVertexAttributeDescriptions, pVICI->pVertexAttributeDescriptions + pVICI->vertexAttributeDescriptionCount); 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pVertexInputState = &pPipeline->vertexInputCI; 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pInputAssemblyState != NULL) { 32605188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->iaStateCI = *pCreateInfo->pInputAssemblyState; 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState = &pPipeline->iaStateCI; 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pTessellationState != NULL) { 32645188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->tessStateCI = *pCreateInfo->pTessellationState; 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState = &pPipeline->tessStateCI; 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pViewportState != NULL) { 32685188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->vpStateCI = *pCreateInfo->pViewportState; 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState = &pPipeline->vpStateCI; 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pRasterizationState != NULL) { 32725188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->rsStateCI = *pCreateInfo->pRasterizationState; 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState = &pPipeline->rsStateCI; 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pMultisampleState != NULL) { 32765188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->msStateCI = *pCreateInfo->pMultisampleState; 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pMultisampleState = &pPipeline->msStateCI; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDepthStencilState != NULL) { 32805188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->dsStateCI = *pCreateInfo->pDepthStencilState; 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pDepthStencilState = &pPipeline->dsStateCI; 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pColorBlendState != NULL) { 32845188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->cbStateCI = *pCreateInfo->pColorBlendState; 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Copy embedded ptrs 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCBCI = pCreateInfo->pColorBlendState; 32875188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes if (pCBCI->attachmentCount) { 32885188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->attachments = std::vector<VkPipelineColorBlendAttachmentState>( 32895188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pCBCI->pAttachments, pCBCI->pAttachments + pCBCI->attachmentCount); 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pColorBlendState = &pPipeline->cbStateCI; 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDynamicState != NULL) { 32945188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes pPipeline->dynStateCI = *pCreateInfo->pDynamicState; 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->dynStateCI.dynamicStateCount) { 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->dynStateCI.pDynamicStates = new VkDynamicState[pPipeline->dynStateCI.dynamicStateCount]; 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bufferSize = pPipeline->dynStateCI.dynamicStateCount * sizeof(VkDynamicState); 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pPipeline->dynStateCI.pDynamicStates, pCreateInfo->pDynamicState->pDynamicStates, bufferSize); 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pDynamicState = &pPipeline->dynStateCI; 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pPipeline; 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->pipelineMap.begin(); ii != my_data->pipelineMap.end(); ++ii) { 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((*ii).second->graphicsPipelineCI.stageCount != 0) { 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[](*ii).second->graphicsPipelineCI.pStages; 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((*ii).second->dynStateCI.dynamicStateCount != 0) { 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[](*ii).second->dynStateCI.pDynamicStates; 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipeline, return number of MSAA samples, or one if MSAA disabled 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(layer_data *my_data, const VkPipeline pipeline) { 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipe = my_data->pipelineMap[pipeline]; 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->msStateCI.sType) { 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pPipe->msStateCI.rasterizationSamples; 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_SAMPLE_COUNT_1_BIT; 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state related to the PSO 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validatePipelineState(layer_data *my_data, const GLOBAL_CB_NODE *pCB, const VkPipelineBindPoint pipelineBindPoint, 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkPipeline pipeline) { 33335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that any MSAA request in PSO matches sample# in bound FB 33355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip the check if rasterization is disabled. 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = my_data->pipelineMap[pipeline]; 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable) { 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); 33405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits)0; 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pSD->colorAttachmentCount; i++) { 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits samples; 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) { 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (subpassNumSamples != samples) { 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else if (subpassNumSamples != samples) 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (psoNumSamples != subpassNumSamples) { 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, psoNumSamples, (uint64_t)pCB->activeRenderPass, subpassNumSamples); 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify and flag error as appropriate 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add more checks here 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Validate non-gfx pipeline updates 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 33935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic LAYOUT_NODE *getLayoutNode(layer_data *my_data, const VkDescriptorSetLayout layout) { 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorSetLayoutMap[layout]; 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return VK_FALSE if update struct is of valid type, otherwise flag error and return code from callback 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return value of skipCall, which is only VK_TRUE if error occurs and callback signals execution to cease 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex; 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex + count - 1; 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateUpdateConsistency(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType actualType; 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set first stageFlags as reference and verify that all other updates match it 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = startIndex; i <= endIndex; i++) { 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->descriptorTypes[i] != actualType) { 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->stageFlags[i] != refStageFlags) { 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis refStageFlags, pLayout->stageFlags[i]); 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Determine the update type, allocate a new struct of that type, shadow the given pUpdate 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// struct into the pNewNode param. Return VK_TRUE if error condition encountered and callback signals early exit. 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 34935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 shadowUpdateNode(layer_data *my_data, const VkDevice device, GENERIC_HEADER *pUpdate, GENERIC_HEADER **pNewNode) { 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCopyDescriptorSet *pCDS = NULL; 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdate->sType) { 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = new VkWriteDescriptorSet; 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pWDS; 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pImageInfo = info; 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pTexelBufferView = info; 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; 35235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pBufferInfo = info; 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS = new VkCopyDescriptorSet; 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pCDS; 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), pUpdate->sType)) 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that pNext for the end of shadow copy is NULL 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*pNewNode)->pNext = NULL; 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given sampler is valid 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateSampler(const layer_data *my_data, const VkSampler *pSampler, const VkBool32 immutable) { 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->sampleMap.find(*pSampler); 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->sampleMap.end()) { 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!immutable) { 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // immutable 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable " 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "sampler %#" PRIxLEAST64, 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the sampler? 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) { 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgsubIt = pCB->imageLayoutMap.find(imgpair); 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis node = imgsubIt->second; 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) { 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgsubIt = my_data->imageLayoutMap.find(imgpair); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layout = imgsubIt->second.layout; 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 364008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 364308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 364408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 364508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 364608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 365008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 365208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 365308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 36597068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 36607068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 36617068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 366208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 366608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 366708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 366808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 366908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 367008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 367108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 367408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 367508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 367708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 367808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 367908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 368008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 368308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 368508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given imageView is valid 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateImageView(const layer_data *my_data, const VkImageView *pImageView, const VkImageLayout imageLayout) { 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ivIt = my_data->imageViewMap.find(*pImageView); 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ivIt == my_data->imageViewMap.end()) { 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that imageLayout is compatible with aspectMask and image format 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageAspectFlags aspectMask = ivIt->second.subresourceRange.aspectMask; 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = ivIt->second.image; 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Check here in case we have a bad image 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format = VK_FORMAT_MAX_ENUM; 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt != my_data->imageMap.end()) { 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = (*imgIt).second.createInfo.format; 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Also need to check the swapchains. 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchainIt = my_data->device_extensions.imageToSwapchainMap.find(image); 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchainIt != my_data->device_extensions.imageToSwapchainMap.end()) { 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR swapchain = swapchainIt->second; 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_nodeIt = my_data->device_extensions.swapchainMap.find(swapchain); 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_nodeIt != my_data->device_extensions.swapchainMap.end()) { 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SWAPCHAIN_NODE *pswapchain_node = swapchain_nodeIt->second; 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = pswapchain_node->createInfo.imageFormat; 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (format == VK_FORMAT_MAX_ENUM) { 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " in imageView %#" PRIxLEAST64, 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, (uint64_t)*pImageView); 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 ds = vk_format_is_depth_or_stencil(format); 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (imageLayout) { 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Only Color bit must be set 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must NOT be DS 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds) { 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a color format.", 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, string_VkFormat(format)); 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Depth or stencil bit must be set, but both must NOT be set 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // both must NOT be set 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that has both STENCIL and DEPTH aspects set", 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Neither were set 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have STENCIL or DEPTH aspect set.", 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView); 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must be DS 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ds) { 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a depth/stencil format.", 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView, string_VkFormat(format)); 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // anything to check for other layouts? 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferView is valid 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateBufferView(const layer_data *my_data, const VkBufferView *pBufferView) { 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferViewMap.find(*pBufferView); 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferViewMap.end()) { 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView, __LINE__, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferInfo is valid 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateBufferInfo(const layer_data *my_data, const VkDescriptorBufferInfo *pBufferInfo) { 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferMap.end()) { 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer, __LINE__, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer); 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validateUpdateContents(const layer_data *my_data, const VkWriteDescriptorSet *pWDS, 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDescriptorSetLayoutBinding *pLayoutBinding) { 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampler *pSampler = NULL; 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 immutable = VK_FALSE; 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For given update type, verify that update contents are correct 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayoutBinding->pImmutableSamplers) { 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pWDS->pImageInfo[i].sampler); 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (immutable) { 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but previous update(s) from this " 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, (uint64_t)*pSampler); 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i > 0 && !immutable) { 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i); 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis immutable = VK_TRUE; 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pLayoutBinding->pImmutableSamplers[i]); 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, pSampler, immutable); 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Intentionally fall through here to also validate image stuff 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return VK_FALSE if no errors occur 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return VK_TRUE if validation error occurs and callback returns VK_TRUE (to skip upcoming API call down the chain) 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s() on descriptor set %" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Cannot call %s() on descriptor set %" PRIxLEAST64 " that is in use by a command buffer.", 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const SET_NODE *pSet) { 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : pSet->boundCmdBuffers) { 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = NULL; 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSetLayoutCreateInfo *pLayoutCI = NULL; 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = my_data->setMap[ds]; 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == VK_TRUE) 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayout = pSet->pLayout; 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == VK_TRUE) { 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t binding = 0, endIndex = 0; 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = pWDS[i].dstBinding; 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingToIndex = pLayout->bindingToIndexMap.find(binding); 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that layout being updated has the binding being updated 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (bindingToIndex == pLayout->bindingToIndexMap.end()) { 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor Set %" PRIu64 " does not have binding to match " 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "update binding %u for update type " 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s!", 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), binding, string_VkStructureType(pUpdate->sType)); 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Next verify that update falls within size of given binding 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pLayout, binding) < endIndex) { 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pLayout->createInfo; 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // TODO : should we skip update on a type mismatch or force it? 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t startIndex; 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layout bindings match w/ update, now verify that update type 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // & stageFlags are the same for entire update 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == VK_FALSE) { 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The update is within bounds and consistent, but need to 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // make sure contents make sense as well 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateContents(my_data, &pWDS[i], 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &pLayout->createInfo.pBindings[bindingToIndex->second])) == VK_FALSE) { 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update is good. Save the update info 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new update struct for this set's shadow copy 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pNewNode = NULL; 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert shadow node into LL of updates for this set 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pSet->pUpdateStructs; 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = pNewNode; 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update appropriate descriptor(s) to point to new Update node 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = startIndex; j <= endIndex; j++) { 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(j < pSet->descriptorCount); 40093a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates[j] = pNewNode; 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSrcSet = NULL, *pDstSet = NULL; 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->set, "VkUpdateDescriptorSets")) == VK_TRUE) 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcLayout = pSrcSet->pLayout; 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstLayout = pDstSet->pLayout; 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src binding is valid for src set layout 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->bindingToIndexMap.find(pCDS[i].srcBinding) == pSrcLayout->bindingToIndexMap.end()) { 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has srcBinding %u " 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].srcBinding, (uint64_t)pSrcLayout->layout, pSrcLayout->createInfo.bindingCount - 1); 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDstLayout->bindingToIndexMap.find(pCDS[i].dstBinding) == pDstLayout->bindingToIndexMap.end()) { 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has dstBinding %u " 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].dstBinding, (uint64_t)pDstLayout->layout, pDstLayout->createInfo.bindingCount - 1); 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pSrcLayout->createInfo; 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].srcBinding, DSstr.c_str()); 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pDstLayout->createInfo; 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].dstBinding, DSstr.c_str()); 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pCDS[i].descriptorCount; ++j) { 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For copy just make sure that the types match and then perform the update 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->descriptorTypes[srcStartIndex + j] != pDstLayout->descriptorTypes[dstStartIndex + j]) { 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update index %u, update count #%u, has src update descriptor type %s " 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that does not match overlapping dest descriptor type of %s!", 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, j + 1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex + j]), 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex + j])); 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // point dst descriptor at corresponding src descriptor 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This may be a hole. I believe copy should be its own copy, 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // otherwise a subsequent write update to src will incorrectly affect the copy 40863a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pDstSet->pDescriptorUpdates[j + dstStartIndex] = pSrcSet->pDescriptorUpdates[j + srcStartIndex]; 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet->pUpdateStructs = pSrcSet->pUpdateStructs; 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4096a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 4097a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDescriptorSetLayout *pSetLayouts) { 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 4101a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 4102a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 4103a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 4104a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 4105a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 4106a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 4107a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 4108a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski "Unable to allocate %u descriptorSets from pool %#" PRIxLEAST64 4109a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 4110a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 4111a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 4112a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 4113a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 4114a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pSetLayouts[i]); 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 41255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pLayout->createInfo.bindingCount; ++j) { 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pLayout->layout, __LINE__, 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 4133a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptors of this type remaining.", 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBindings[j].descriptorType), 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the shadowed update node for this Set 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void freeShadowUpdateTree(SET_NODE *pSet) { 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pShadowUpdate = pSet->pUpdateStructs; 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = NULL; 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pFreeUpdate = pShadowUpdate; 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the descriptor mappings as they will now be invalid 41523a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates.clear(); 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pShadowUpdate) { 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeUpdate = pShadowUpdate; 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pShadowUpdate = (GENERIC_HEADER *)pShadowUpdate->pNext; 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pFreeUpdate->sType) { 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = (VkWriteDescriptorSet *)pFreeUpdate; 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pImageInfo; 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pTexelBufferView; 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pBufferInfo; 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeUpdate; 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = (*ii).second->pSets; 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pFreeSet = pSet; 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeSet = pSet; 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Freeing layouts handled in deleteLayouts() function 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free Update shadow struct tree 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pFreeSet); 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeSet; 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteLayouts(layer_data *my_data) { 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.size() <= 0) 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorSetLayoutMap.begin(); ii != my_data->descriptorSetLayoutMap.end(); ++ii) { 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = (*ii).second; 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->createInfo.pBindings) { 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings[i].pImmutableSamplers; 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings; 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pLayout; 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorSetLayoutMap.clear(); 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Currently clearing a set is removing all previous updates to that set 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Validate if this is correct clearing behavior 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorSet(layer_data *my_data, VkDescriptorSet set) { 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = getSetNode(my_data, set); 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet) { 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Return error 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pSet); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For every set off of this pool, clear it 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = pPool->pSets; 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorSet(my_data, pSet->set); 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset available count to max count for this pool 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *my_data, const VkCommandBuffer cb) { 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.count(cb) == 0) { 426672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 426772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 426872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->commandBufferMap[cb]; 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.size() <= 0) { 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 42905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueueFlags flags = my_data->physDevProperties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 43775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 43805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void resetCB(layer_data *my_data, const VkCommandBuffer cb) { 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = my_data->commandBufferMap[cb]; 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 442472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 442572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 442672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 442772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto set_node = my_data->setMap.find(set); 442872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (set_node != my_data->setMap.end()) { 442972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis set_node->second->boundCmdBuffers.erase(pCB->commandBuffer); 443072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 443172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 443272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 443372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = 0; 443972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->fenceId = 0; 444072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 444172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 4458b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->activeDescriptorSets.clear(); 4459b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->validate_functions.clear(); 4460b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->pMemObjList.clear(); 4461b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipe->dynStateCI.dynamicStateCount) { // All state is static 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipe->dynStateCI.dynamicStateCount; i++) { 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pPipe->dynStateCI.pDynamicStates[i]) { 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 44903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 451872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo(&pPipeTrav->graphicsPipelineCI, "{DS}").c_str()); 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_NONE, "DS", "Cmds in CB %p", (void *)cb); 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", " CMD#%" PRIu64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 inside = VK_FALSE; 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 45625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", apiName, 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass); 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 45665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 outside = VK_FALSE; 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void init_core_validation(layer_data *my_data, const VkAllocationCallbacks *pAllocator) { 4583d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4584d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski layer_debug_actions(my_data->report_data, my_data->logging_callback, pAllocator, "lunarg_core_validation"); 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!globalLockInitialized) { 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_create_mutex(&globalLock); 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 1; 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 459003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Zero out memory property data 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&memProps, 0, sizeof(VkPhysicalDeviceMemoryProperties)); 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 46105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, my_data->instance_dispatch_table, fpGetInstanceProcAddr); 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data = debug_report_create_instance(my_data->instance_dispatch_table, *pInstance, 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis init_core_validation(my_data, pAllocator); 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layer_data_map.empty()) { 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Release mutex when destroying last instance. 46515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_delete_mutex(&globalLock); 46525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 0; 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 46585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 46595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 46655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(NULL, "vkCreateDevice"); 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 47046c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->physDevProperties.properties)); 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->physDevProperties.queue_family_properties.resize(count); 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis gpu, &count, &my_device_data->physDevProperties.queue_family_properties[0]); 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 47165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->physDevProperties.features = *pCreateInfo->pEnabledFeatures; 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&my_device_data->physDevProperties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteLayouts(dev_data); 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 474803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(dev_data, device); 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCBList(dev_data, device); 475772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis delete_cmd_buf_info_list(dev_data); 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 475958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->memObjMap.size() > 0) { 47615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mem Object %" PRIu64 " has not been freed. You should clean up this memory by calling " 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkFreeMemory(%" PRIu64 ") prior to vkDestroyDevice().", 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Queues persist until device is destroyed 47755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete_queue_info_list(dev_data); 47765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fprintf(stderr, "Device: %p, key: %p\n", device, key); 47815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 479303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 47955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPhysicalDeviceMemoryProperties(VkPhysicalDevice physicalDevice, VkPhysicalDeviceMemoryProperties *pMemoryProperties) { 47965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); 47975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pInstanceTable = my_data->instance_dispatch_table; 47985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInstanceTable->GetPhysicalDeviceMemoryProperties(physicalDevice, pMemoryProperties); 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&memProps, pMemoryProperties, sizeof(VkPhysicalDeviceMemoryProperties)); 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 48075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 48085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 48115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_global_layers), cv_global_layers, pCount, pProperties); 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Why does this exist - can we just use global? 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_device_layers[] = {{ 4817f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *pLayerName, uint32_t *pCount, 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkExtensionProperties *pProperties) { 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayerName == NULL) { 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(physicalDevice); 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(0, NULL, pCount, pProperties); 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* draw_state physical device layers are the same as global */ 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_device_layers), cv_device_layers, pCount, pProperties); 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 48435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 48445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image %" PRIu64 ".", 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 48545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 485639d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski skip_call |= 485739d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 485839d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 485939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski "Cannot submit cmd buffer using image (%" PRIx64 ") with layout %s when " 486039d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski "first use is %s.", 486139d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 486239d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski string_VkImageLayout(cb_image_data.second.initialLayout)); 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 486939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 48735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 48795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted buffer %" PRIu64 ".", (uint64_t)(buffer)); 48805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 488572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 488672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 488772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 488872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 488972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 489072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 489172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 489272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Cannot submit cmd buffer using deleted descriptor set %" PRIu64 ".", (uint64_t)(set)); 489372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 489472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 489572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 48965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted semaphore %" PRIu64 ".", reinterpret_cast<uint64_t &>(semaphore)); 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 49105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 49115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted event %" PRIu64 ".", reinterpret_cast<uint64_t &>(event)); 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 49245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 493372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 493472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 493572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 493672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 493772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 493872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 49675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_sub(1); 4968ede566c411d308e49d03a28448cf8ac89ef647e6Mark Lobodzinski decrementResources(my_data, fence_data->second.priorFences.size(), fence_data->second.priorFences.data()); 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid decrementResources(layer_data *my_data, VkQueue queue) { 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 498262592801ae20ab7e059e43232c639521eb32b759Mark Lobodzinski decrementResources(my_data, queue_data->second.lastFences.size(), queue_data->second.lastFences.data()); 49830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 49850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 49860a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentinevoid updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 49870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 49880a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 49910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 49920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 49930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto fence : other_queue_data->second.lastFences) { 49960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 49970a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49980a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 49990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 50000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 50010a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 50020a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50030a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 50040a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 50050a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 50070a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 50080a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 50090a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 50100a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50110a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5013b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 5014b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 5015b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 50210a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 50245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50270a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 50280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 50290a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 50300a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 50310a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.clear(); 50360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.queue = queue; 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 50565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add cmdBuffers to both the global set and queue set 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(secondaryCmdBuffer); 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Command Buffer %#" PRIx64 " is already in use and is not marked " 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "for simultaneous use.", 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 50875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 50945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 51015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid because it had the following " 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkBool32 validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = validateAndIncrementResources(dev_data, pCB); 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->primaryCommandBuffer != pCB->commandBuffer) { 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was submitted with secondary buffer %#" PRIxLEAST64 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "primary cmd buffer %#" PRIxLEAST64 ".", 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 51755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 51765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify if this also needs to be checked for secondary command 51805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers. If so, this block of code can move to 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // validateCommandBufferState() function. vulkan GL106 filed to clarify 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, but has been submitted %#" PRIxLEAST64 " times.", 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 51975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 519972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 520303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to track fence and clear mem references when fence clears 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this code with code below to avoid duplicating efforts 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t fenceId = 0; 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = add_fence_info(dev_data, fence, queue, &fenceId); 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(dev_data, queue); 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCBList(dev_data, queue); 52115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 52125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 521472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 521572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 521672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->fenceId = fenceId; 521772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->lastSubmittedFence = fence; 521872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->lastSubmittedQueue = queue; 521972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &function : pCBNode->validate_functions) { 52205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= function(); 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5222b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto &function : pCBNode->eventUpdates) { 5223b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skipCall |= static_cast<VkBool32>(function(queue)); 5224b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 52255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; i++) { 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pWaitSemaphores[i]; 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_SIGNALLED) { 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 52345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 52365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueSubmit: Semaphore must be in signaled state before passing to pWaitSemaphores"); 52375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_WAIT; 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; i++) { 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pSignalSemaphores[i]; 52435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, (uint64_t)sem, __LINE__, MEMTRACK_NONE, 52485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "SEMAPHORE", "vkQueueSubmit: Semaphore must not be currently signaled or in a wait state"); 52495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 52565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((fence != VK_NULL_HANDLE) && (submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 52605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 52620a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 52665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 52670a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 52680a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine semaphoreList.push_back(semaphore); 52690a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (dev_data->semaphoreMap[semaphore].signaled) { 52700a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].signaled = 0; 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 52750a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 52760a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 52770a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 52780a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 52790a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 52800a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine processed_other_queues.insert(other_queue); 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 52840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 52850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine semaphoreList.push_back(semaphore); 52860a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (dev_data->semaphoreMap[semaphore].signaled) { 52870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52880a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, 52890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine "DS", "Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 52900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine " that has already been signaled but not waited on by queue %#" PRIx64 ".", 52910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 52920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 52930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 52940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].signaled = 1; 52950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].queue = queue; 52960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 530072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 530172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->semaphores = semaphoreList; 530272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->submitCount++; // increment submit count 530372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 53045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update cmdBuffer-related data structs and mark fence in-use 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 531103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; i++) { 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pWaitSemaphores[i]; 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 53255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 532803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 53305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(my_data, device); 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeMemObjInfo(my_data, device, mem, VK_FALSE); 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(my_data, device); 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCBList(my_data, device); 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object %#" PRIxLEAST64, (uint64_t)mem); 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 54005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj %#" PRIxLEAST64, (uint64_t)mem); 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid initializeAndTrackMemory(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (memProps.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : queryEventsPair.second) { 54575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->eventMap[event].needsSignaled) { 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " with index %d which was guarded by unsignaled event %" PRIu64 ".", 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove given cmd_buffer from the global inFlight set. 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Also, if given queue is valid, then remove the cmd_buffer from that queues 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// inFlightCmdBuffer set. Finally, check all other queues and if given cmd_buffer 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// is still in flight on another queue, add it back into the global set. 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkQueue queue) { 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull it off of global list initially, but if we find it in any other queue list, add it back in 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 54795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.erase(cmd_buffer); 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto q : dev_data->queues) { 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((q != queue) && 54825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dev_data->queueMap[q].inFlightCmdBuffers.find(cmd_buffer) != dev_data->queueMap[q].inFlightCmdBuffers.end())) { 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cmd_buffer); 54845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 548903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline bool verifyFenceStatus(VkDevice device, VkFence fence, const char *apiCall) { 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = false; 54935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo->second.firstTimeFlag != VK_TRUE) { 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pFenceInfo->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT) && 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFenceInfo->second.firstTimeFlag != VK_TRUE) { 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 54995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 55005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s specified fence %#" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pFenceInfo->second.queue && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 55065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s called for fence %#" PRIxLEAST64 " which has not been submitted on a Queue or during " 55075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 55085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 55095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 55115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFenceInfo->second.firstTimeFlag = VK_FALSE; 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 55155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 552103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= verifyFenceStatus(device, pFences[i], "vkWaitForFences"); 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 553803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, pFences[i]); 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue fence_queue = dev_data->fenceMap[pFences[i]].queue; 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[pFences[i]].cmdBuffers) { 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, fenceCount, pFences); 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetFenceStatus(VkDevice device, VkFence fence) { 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 556303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = verifyFenceStatus(device, fence, "vkGetFenceStatus"); 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 557403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, fence); 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_queue = dev_data->fenceMap[fence].queue; 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[fence].cmdBuffers) { 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 55815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, 1, &fence); 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5590b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5591b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5595b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5596b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5597b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5598b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5599b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 5600b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 560103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5602b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastRetiredId = 0; 5603b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastSubmittedId = 0; 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5605b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 5606b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueWaitIdle(VkQueue queue) { 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Iterate over local set since we erase set members as we go in for loop 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto local_cb_set = dev_data->queueMap[queue].inFlightCmdBuffers; 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : local_cb_set) { 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, queue); 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 562603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_queue_fences(dev_data, queue); 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDeviceWaitIdle(VkDevice device) { 56375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 56385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear all of the queue inFlightCmdBuffers (global set cleared below) 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 565503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 56565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_device_fences(dev_data, device); 56595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 56625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 56665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[fence].in_use.load()) { 56705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 567403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete_fence_info(dev_data, fence); 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->fenceMap.find(fence); 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->fenceMap.end()) { 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->fenceMap.erase(item); 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete semaphore %" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 56995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 57115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 57125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete event %" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 57155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 57205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 57215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 57225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 57265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 57275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 57285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 57295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryResultFlags flags) { 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 57475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Available and in flight 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryToStateElement->second) { 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queryElement->second) { 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is in flight.", 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : queryEventElement->second) { 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[event].needsSignaled = true; 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Unavailable and in flight 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !queryToStateElement->second) { 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Can there be the same query in use by multiple command buffers in flight? 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool make_available = false; 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queryElement->second) { 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis make_available |= pCB->queryToStateMap[query]; 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Unavailable 57845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 57865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Unitialized 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5793076b41e60e609f4d1317f0a55c0f22c6e64a3ceeMichael Lentine "Cannot get query results on queryPool %" PRIu64 " with index %d as data has not been collected for this index.", 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 57995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 58025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 58115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 58125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 58145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 58155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 58195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 58255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 582603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 58275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferBindingMap.find((uint64_t)buffer); 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferBindingMap.end()) { 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = clear_object_binding(dev_data, device, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferBindingMap.erase(item); 58315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 58335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!validateIdleBuffer(dev_data, buffer) && (VK_FALSE == skipCall)) { 58345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 58355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 58365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.erase(buffer); 58395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 58405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 58445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 58465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 58495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 58505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 58525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 58555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 585703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 58585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->imageBindingMap.find((uint64_t)image); 58605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->imageBindingMap.end()) { 58615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = clear_object_binding(dev_data, device, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageBindingMap.erase(item); 58635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 58655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 58665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 58675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& entry = dev_data->imageMap.find(image); 58715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (entry != dev_data->imageMap.end()) { 587258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Clear any memory mapping for this image 587358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis const auto &mem_entry = dev_data->memObjMap.find(entry->second.mem); 587458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (mem_entry != dev_data->memObjMap.end()) 587558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis mem_entry->second.image = VK_NULL_HANDLE; 587658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 587758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.erase(entry); 58795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 58815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 58825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 58835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 58845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 58865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 58885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 588903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 589058070a671b39e2058a799c7b9c932f3f03f2e66dTobin EhlisVkBool32 print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 58915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportObjectTypeEXT object_type) { 58925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 589358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Buffer %" PRIx64 " is alised with image %" PRIx64, object_handle, 58955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 589758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 58985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Image %" PRIx64 " is alised with buffer %" PRIx64, object_handle, 58995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 590358070a671b39e2058a799c7b9c932f3f03f2e66dTobin EhlisVkBool32 validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 590458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VkDebugReportObjectTypeEXT object_type) { 59055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = false; 590658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 59075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto range : ranges) { 590858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((range.end & ~(dev_data->physDevProperties.properties.limits.bufferImageGranularity - 1)) < 590958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis (new_range.start & ~(dev_data->physDevProperties.properties.limits.bufferImageGranularity - 1))) 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 591158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((range.start & ~(dev_data->physDevProperties.properties.limits.bufferImageGranularity - 1)) > 591258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis (new_range.end & ~(dev_data->physDevProperties.properties.limits.bufferImageGranularity - 1))) 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 591458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 59155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 591958070a671b39e2058a799c7b9c932f3f03f2e66dTobin EhlisVkBool32 validate_buffer_image_aliasing(layer_data *dev_data, uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 592058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges, 592158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis const vector<MEMORY_RANGE> &other_ranges, VkDebugReportObjectTypeEXT object_type) { 59225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMORY_RANGE range; 59235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.handle = handle; 59245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.memory = mem; 59255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.start = memoryOffset; 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.end = memoryOffset + memRequirements.size - 1; 592758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis ranges.push_back(range); 592858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return validate_memory_range(dev_data, other_ranges, range, object_type); 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 593358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = 593958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis set_mem_binding(dev_data, device, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 594058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis add_object_binding_info(dev_data, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, mem); 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Shouldn't this call down the chain? 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vkGetBufferMemoryRequirements(device, buffer, &memRequirements); 594558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, buffer_handle, mem, memoryOffset, memRequirements, 594658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].bufferRanges, dev_data->memObjMap[mem].imageRanges, 594758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 594958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis print_mem_list(dev_data, device); 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 595258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5982918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5983918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5984918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_lock_mutex(&globalLock); 5985918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5986918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5987918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5988918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_unlock_mutex(&globalLock); 5989918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5990918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 60095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 60105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 60165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 60175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 60235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 60245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 60285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 603303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 603472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCommandBuffers[i]); 603503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCommandBuffers[i])) { 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 60385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to free command buffer (%#" PRIxLEAST64 ") which is in use.", 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]); 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb != dev_data->commandBufferMap.end()) { 60465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 60475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*cb).second->commandBuffer); 60485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*cb).second; 60495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap.erase(cb); 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 605503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCBList(dev_data, device); 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool *pCommandPool) { 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateCommandBuffersNotInUse(const layer_data *dev_data, VkCommandPool commandPool) { 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : pool_data->second.commandBuffers) { 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmdBuffer)) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT, 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandPool), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot reset command pool %" PRIx64 " when allocated command buffer %" PRIx64 " is in use.", 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandPool), (uint64_t)(cmdBuffer)); 61045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 61155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 611703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this with code below (separate *NotInUse() call) 61205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it != dev_data->commandPoolMap[commandPool].commandBuffers.end(); it++) { 61225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBufferComplete = VK_FALSE; 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, *it, &commandBufferComplete); 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == commandBufferComplete) { 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(*it), __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Destroying Command Pool 0x%" PRIxLEAST64 " before " 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "its command buffer (0x%" PRIxLEAST64 ") has completed.", 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandPool), reinterpret_cast<uint64_t>(*it)); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 613972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 61415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_TRUE == validateCommandBuffersNotInUse(dev_data, commandPool)) 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 615303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove command buffers from command buffer map 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (item != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_item = item++; 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete_cmd_buf_info(dev_data, commandPool, *del_item); 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 617203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this with *NotInUse() call below 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that CB's in pool are complete (not in-flight) 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, (*it), &commandBufferComplete); 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(*it), __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Resetting CB %p before it has completed. You must check CB " 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flag before calling vkResetCommandBuffer().", 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*it)); 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear memory references at this point. 618772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, (*it)); 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_TRUE == validateCommandBuffersNotInUse(dev_data, commandPool)) 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 621803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset fence state in fenceCreateInfo structure 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge with code below 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate fences in SIGNALED state 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(fence_item->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT)) { 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: I don't see a Valid Usage section for ResetFences. This behavior should be documented there. 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pFences[i], __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted to VkResetFences in UNSIGNALED STATE", (uint64_t)pFences[i]); 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_item->second.createInfo.flags = 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<VkFenceCreateFlags>(fence_item->second.createInfo.flags & ~VK_FENCE_CREATE_SIGNALED_BIT); 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[pFences[i]].in_use.load()) { 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 62587e6ee472f8858eeca9f38d29b7ed0054ec615537Tony Barbour loader_platform_thread_lock_mutex(&globalLock); 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 62607e6ee472f8858eeca9f38d29b7ed0054ec615537Tony Barbour loader_platform_thread_unlock_mutex(&globalLock); 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6263937bfd4b04c5c92a072f357f9c12d82eaf445d5eTony Barbour loader_platform_thread_lock_mutex(&globalLock); 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->frameBufferMap.erase(framebuffer); 6265937bfd4b04c5c92a072f357f9c12d82eaf445d5eTony Barbour loader_platform_thread_unlock_mutex(&globalLock); 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 627947892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 628047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 628247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 628347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 628703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_object_create_info(dev_data, (uint64_t)*pBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, pCreateInfo); 62895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].create_info = unique_ptr<VkBufferCreateInfo>(new VkBufferCreateInfo(*pCreateInfo)); 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].in_use.store(0); 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 630503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validate_buffer_usage_flags(dev_data, device, pCreateInfo->buffer, 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, VK_FALSE, 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 631747892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 631847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 632047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 632147892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6324e5bc02759d9ab768d67b2f45ec53d29fb59a4705Tony Barbour loader_platform_thread_lock_mutex(&globalLock); 632503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_object_create_info(dev_data, (uint64_t)*pImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, pCreateInfo); 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[*pImage].createInfo = *pCreateInfo; 63325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 63745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 638703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that img has correct usage flags set 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validate_image_usage_flags(dev_data, device, pCreateInfo->image, 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_FALSE, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pFN = &dev_data->fenceMap[*pFence]; 640603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pFN, 0, sizeof(MT_FENCE_INFO)); 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&(pFN->createInfo), pCreateInfo, sizeof(VkFenceCreateInfo)); 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFN->firstTimeFlag = VK_TRUE; 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFN->in_use.store(0); 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 64483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 64493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 64503d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 64513d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 64523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 64533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 64613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 64623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 64673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = initGraphicsPipeline(dev_data, &pCreateInfos[i]); 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65035188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 65335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 65585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 65705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 65755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pNewNode = new LAYOUT_NODE; 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSetLayout, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->createInfo.pBindings = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pNewNode->createInfo.pBindings, pCreateInfo->pBindings, 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sizeof(VkDescriptorSetLayoutBinding) * pCreateInfo->bindingCount); 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // g++ does not like reserve with size 0 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->bindingCount) 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap.reserve(pCreateInfo->bindingCount); 65895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t totalCount = 0; 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pNewNode->bindingToIndexMap.emplace(pCreateInfo->pBindings[i].binding, i).second) { 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)*pSetLayout, __LINE__, 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LAYOUT, "DS", "duplicated binding number in " 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSetLayoutBinding")) 65965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap[pCreateInfo->pBindings[i].binding] = i; 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis totalCount += pCreateInfo->pBindings[i].descriptorCount; 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pBindings[i].pImmutableSamplers) { 66025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampler **ppIS = (VkSampler **)&pNewNode->createInfo.pBindings[i].pImmutableSamplers; 66035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppIS = new VkSampler[pCreateInfo->pBindings[i].descriptorCount]; 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(*ppIS, pCreateInfo->pBindings[i].pImmutableSamplers, 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pBindings[i].descriptorCount * sizeof(VkSampler)); 66065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->layout = *pSetLayout; 66095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->startIndex = 0; 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (totalCount > 0) { 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes.resize(totalCount); 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags.resize(totalCount); 66135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset = 0; 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType dType; 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dType = pCreateInfo->pBindings[i].descriptorType; 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pCreateInfo->pBindings[i].descriptorCount; j++) { 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes[offset + j] = dType; 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags[offset + j] = pCreateInfo->pBindings[i].stageFlags; 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 66225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->dynamicDescriptorCount++; 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset += j; 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // no descriptors 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = 0; 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Put new node at Head of global Layer list 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validatePushConstantSize(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *caller_name) { 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 66435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > dev_data->physDevProperties.properties.limits.maxPushConstantsSize) { 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis caller_name, offset, size, dev_data->physDevProperties.properties.limits.maxPushConstantsSize); 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 66505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 66535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 66545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()"); 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCreateInfo->pPushConstantRanges[i].size == 0) || ((pCreateInfo->pPushConstantRanges[i].size & 0x3) != 0)) { 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constant index %u with " 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "size %u. Size must be greater than zero and a multiple of 4.", 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCreateInfo->pPushConstantRanges[i].size); 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if ranges overlap 66685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge capture of the setLayouts per pipeline 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPool *pDescriptorPool) { 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool %#" PRIxLEAST64, 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 67485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 67535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set %#" PRIxLEAST64, 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new set node and add to head of pool nodes 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pNewNode = new SET_NODE; 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 67655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", 6767ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) { 6768ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6770ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Pool should store a total count of each type of Descriptor available 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When descriptors are allocated, decrement the count and validate here 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that the count doesn't go below 0. One reset/free need to bump count back up. 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert set at head of Set LL for this pool 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pPoolNode->pSets; 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->pSets = pNewNode; 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 67825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " specified in vkAllocateDescriptorSets() call", 6786ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6787ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6789ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pLayout = pLayout; 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pool = pAllocateInfo->descriptorPool; 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->set = pDescriptorSets[i]; 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorCount = (pLayout->createInfo.bindingCount != 0) ? pLayout->endIndex + 1 : 0; 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pNewNode->descriptorCount) { 6796656b1a5d2165c66fd4af21d070243d387cd4ac56Karl Schultz pNewNode->pDescriptorUpdates.resize(pNewNode->descriptorCount); 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDesriptorSets"); 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skipCall) 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 6829a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6830a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6831a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6832a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6833a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // For each freed descriptor add it back into the pool as available 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(dev_data, pSet); 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = pSet->pLayout; 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pLayout->createInfo.bindingCount; ++j) { 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 68415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dsUpdate will return VK_TRUE only if a bailout error occurs, so we want to call down tree when update returns VK_FALSE 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 685703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this in with existing update code below and handle descriptor copies case 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < descriptorWriteCount; ++i) { 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pDescriptorWrites[i].descriptorCount; ++j) { 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetMap[pDescriptorWrites[i].dstSet].images.push_back( 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorWrites[i].pImageInfo[j].imageView); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pDescriptorWrites[i].descriptorCount; ++j) { 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetMap[pDescriptorWrites[i].dstSet].buffers.push_back( 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[pDescriptorWrites[i].pTexelBufferView[j]].buffer); 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorWrites[i].descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pDescriptorWrites[i].descriptorCount; ++j) { 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetMap[pDescriptorWrites[i].dstSet].buffers.push_back( 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorWrites[i].pBufferInfo[j].buffer); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 689472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 689572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 689672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 689872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 690703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCBList(dev_data, device); 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 69175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 692303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this with code below 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, commandBuffer, &commandBufferComplete); 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Calling vkBeginCommandBuffer() on active CB %p before it has completed. " 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must check CB flag before this call.", 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBuffer); 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must have inheritance info.", 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for an Secondary CB 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for an Secondary CB, but this affects perf 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a " 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // renderPass that framebuffer was created with 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // must 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be compatible with local renderPass 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Buffer (%p) renderPass (%#" PRIxLEAST64 ") is incompatible w/ framebuffer " 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") w/ render pass (%#" PRIxLEAST64 ") due to: %s", 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->physDevProperties.features.occlusionQueryPrecise == VK_FALSE) && 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must not have " 69935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must has a subpass index (%d) " 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void *)commandBuffer); 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skipCall) { 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 704903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, commandBuffer); 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) { 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Ending command buffer with in progress query: queryPool %" PRIu64 ", index %d", 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 70835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 70925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 70945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 709603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that CB is complete (not in-flight) 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, commandBuffer, &commandBufferComplete); 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Resetting CB %p before it has completed. You must check CB " 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flag before calling vkResetCommandBuffer().", 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBuffer); 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear memory references as this point. 710872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, commandBuffer); 71095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 71135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 71185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 71225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") which is in use.", 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer)); 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall != VK_FALSE) 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 71285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 71305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 713603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 71385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 71495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 71515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 71525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")", 71535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass); 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 71575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 715872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 71595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 71603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 71615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); 71625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 71635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 71645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 71655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 71695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 71705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 71715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 71815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 71865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 71875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 71925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 71935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 71985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 72015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 72055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 72145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 72155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 72235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 72355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 72385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 72443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 72645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 73135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t *pDynamicOffsets) { 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 731803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this with code below 732072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 732172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 732272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // MTMTODO : activeDescriptorSets should be merged with lastBound.boundDescriptorSets 732372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis std::vector<VkDescriptorSet> &activeDescriptorSets = cb_data->second->activeDescriptorSets; 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (activeDescriptorSets.size() < (setCount + firstSet)) { 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeDescriptorSets.resize(setCount + firstSet); 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < setCount; ++i) { 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeDescriptorSets[i + firstSet] = pDescriptorSets[i]; 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that all textures referenced by shaders in DS are in some type of *SHADER_READ* state 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7336787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7337787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7338787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7339787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 734072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 734172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 734272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7343787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7344787f29d93dee194c015789cf61c079504c980572Tobin Ehlis SET_NODE *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7345787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 734672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 7347787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pSet->boundCmdBuffers.insert(commandBuffer); 734872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 734972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 7350787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 7351787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7352787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_NONE, "DS", "DS %#" PRIxLEAST64 " bound on pipeline %s", 7353787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7354787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!pSet->pUpdateStructs && (pSet->descriptorCount != 0)) { 7355787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 7356787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7357787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7358787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "DS %#" PRIxLEAST64 7359787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 7360787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7361787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7362787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 7363787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 7364787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7365787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7366787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 7367787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping layout in " 7368787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "pipelineLayout due to: %s", 7369787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, errorString.c_str()); 7370787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7371787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->dynamicDescriptorCount) { 7372787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7373787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if ((totalDynamicDescriptors + pSet->pLayout->dynamicDescriptorCount) > dynamicOffsetCount) { 7374787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 7375787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7376787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7377787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7378787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u (%#" PRIxLEAST64 7379787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7380787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7381787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->pLayout->dynamicDescriptorCount, 7382787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7383787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7384787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7385787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7386787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t d = 0; d < pSet->descriptorCount; d++) { 7387787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7388787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7389787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7390787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->physDevProperties.properties.limits.minUniformBufferOffsetAlignment) != 7391787f29d93dee194c015789cf61c079504c980572Tobin Ehlis 0) { 7392787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7393787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7394787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7395787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7396787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7397787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 7398787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7399787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->physDevProperties.properties.limits.minUniformBufferOffsetAlignment); 7400787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7401787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7402787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7403787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7404787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7405787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->physDevProperties.properties.limits.minStorageBufferOffsetAlignment) != 7406787f29d93dee194c015789cf61c079504c980572Tobin Ehlis 0) { 7407787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7408787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7409787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7410787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7411787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7412787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 7413787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7414787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->physDevProperties.properties.limits.minStorageBufferOffsetAlignment); 74155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7416787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7419787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7420787f29d93dee194c015789cf61c079504c980572Tobin Ehlis totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7423787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 7424787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7425787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7426787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", 7427787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 742972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 743072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 743172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 743272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 743372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 743472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 743572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 743672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 743772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 743872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 743972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 744072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 744172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "DescriptorSetDS %#" PRIxLEAST64 744272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 744372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 744472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 744572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 744672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 744772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 744872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 744972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 745072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 745172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 74525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 745372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 745472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 745572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 745672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_NONE, "DS", "DescriptorSetDS %#" PRIxLEAST64 745772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 745872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 745972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 746072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 746172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 746272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 746372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 746672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 746772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 746872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 746972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 747072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 747172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 747272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 747372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 747472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 747572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Save dynamicOffsets bound to this CB 747672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 747772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.push_back(pDynamicOffsets[i]); 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7480787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7481787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 7482787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7483787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 7484787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7485787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 7486787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 7487787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7488787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7489787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 7490787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 7491787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pCB->dynamicOffsets.emplace_back(pDynamicOffsets[i]); 7492787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 74995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 750803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 751272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 751372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 751572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bindingCount, const VkBuffer *pBuffers, 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceSize *pOffsets) { 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 756503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)(pBuffers[i]), 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 757072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 757172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 757472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 759103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* expects globalLock to be held by caller */ 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool markStoreImagesAndBuffersAsWritten(VkCommandBuffer commandBuffer) { 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 759672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = my_data->commandBufferMap.find(commandBuffer); 759772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data == my_data->commandBufferMap.end()) 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 759972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis std::vector<VkDescriptorSet> &activeDescriptorSets = cb_data->second->activeDescriptorSets; 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto descriptorSet : activeDescriptorSets) { 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ds_data = my_data->descriptorSetMap.find(descriptorSet); 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds_data == my_data->descriptorSetMap.end()) 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageView> images = ds_data->second.images; 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkBuffer> buffers = ds_data->second.buffers; 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imageView : images) { 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto iv_data = my_data->imageViewMap.find(imageView); 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (iv_data == my_data->imageViewMap.end()) 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = iv_data->second.image; 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(my_data, commandBuffer, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(my_data, mem, true, image); 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 761872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : buffers) { 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(my_data, commandBuffer, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(my_data, mem, true); 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 762872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstVertex, uint32_t firstInstance) { 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 764003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = markStoreImagesAndBuffersAsWritten(commandBuffer); 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE); 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 767003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = markStoreImagesAndBuffersAsWritten(commandBuffer); 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE); 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 770003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(commandBuffer); 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_draw_state(dev_data, pCB, VK_FALSE); 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 773303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(commandBuffer); 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_draw_state(dev_data, pCB, VK_TRUE); 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 77595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 776603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = markStoreImagesAndBuffersAsWritten(commandBuffer); 77685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 778403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(commandBuffer); 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferCopy *pRegions) { 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 780603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 780872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 781172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 781372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 781872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 782372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout) { 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 78495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 78525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 785308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 78545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 78555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 78635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 78675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 78715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout destImageLayout) { 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 789208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 78965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 78995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 79005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 79055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 79065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 792503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 792772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 793072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 793272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 793772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 79405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 794272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 797103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 797372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 797672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 797872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 798372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 798872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage dstImage, VkImageLayout dstImageLayout, 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 801303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 801572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 801772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 802272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 802772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 802972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout, VkBuffer dstBuffer, 80545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 805803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 806072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 806272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); }; 806572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 807072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 80715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 80725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 80745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 807572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, commandBuffer, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 80835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 80885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 80895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 80965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 81005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 810303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 81045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 810572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 81065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 810872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 811372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 81185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 81195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 81235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 81245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 81285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 81325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 81335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 813503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 81365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 813772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 814072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 81415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 814572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 81495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 81505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 81515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 81565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *pAttachments, uint32_t rectCount, 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearRect *pRects) { 81655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 81715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 81725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 81745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 found = VK_FALSE; 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found = VK_TRUE; 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == found) { 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout, const VkClearColorValue *pColor, 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 823803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 824172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 824372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 824872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 82555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange *pRanges) { 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 826903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 827272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 827472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 827972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 830003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 830172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 830472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 830772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 831272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 831772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8332b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8333b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8334b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8335b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8336b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8337b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8338b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8339b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8340b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8341b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8342b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8343b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8344b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8355b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8356b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8357b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8374b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8375b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8376b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, const VkImageMemoryBarrier *pImgMemBarriers) { 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip = VK_FALSE; 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 840508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 840608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstd::string string_VkAccessFlags(VkAccessFlags accessMask) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, const char *type) { 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & !(required_bit | optional_bits)) { 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageLayout &layout, const char *type) { 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 85105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageMemoryBarrier *pImageMemBarriers) { 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((src_q_f_index >= dev_data->physDevProperties.queue_family_properties.size()) || 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dst_q_f_index >= dev_data->physDevProperties.queue_family_properties.size()))) { 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dst_q_f_index, dev_data->physDevProperties.queue_family_properties.size()); 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format; 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t arrayLayers, mipLevels; 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 86315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8639f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8640f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8641f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8642f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8650f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8651f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8652f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8653f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 86725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->physDevProperties.queue_family_properties.size()) || 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->physDevProperties.queue_family_properties.size())) { 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 86825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->physDevProperties.queue_family_properties.size()); 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_size = 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.create_info ? reinterpret_cast<uint64_t &>(buffer_data->second.create_info->size) : 0; 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " whose sum is not less than total size %" PRIu64 ".", 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), buffer_size); 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " and size %" PRIu64 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " whose sum is greater than total size %" PRIu64 ".", 87035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->size), buffer_size); 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8712b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool validateEventStageMask(VkQueue queue, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask) { 8713b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8714b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8715b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8716b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 8717b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8718b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8719b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8720b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto event_data = queue_data->second.eventToStageMap.find(pEvents[i]); 8721b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8722b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8723b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8724b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto global_event_data = dev_data->eventMap.find(pEvents[i]); 8725b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 8726b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 8727b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine reinterpret_cast<const uint64_t &>(pEvents[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 8728b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Fence 0x%" PRIx64 " cannot be waited on if it has never been set.", 8729b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine reinterpret_cast<const uint64_t &>(pEvents[i])); 8730b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8731b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 8732b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8733b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8734b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8735b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 8736b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 8737b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8738b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine DRAWSTATE_INVALID_FENCE, "DS", 8739b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 8740b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 8741b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 8742b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8743b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8744b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8745b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8760b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8761b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(validateEventStageMask, std::placeholders::_1, eventCount, pEvents, sourceStageMask); 8762b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 88065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool %" PRIu64 ", index %d", 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 888003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 888272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, commandBuffer, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 888572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 88875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 889072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, commandBuffer, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Requesting a copy from query to buffer with invalid query: queryPool %" PRIu64 ", index %d", 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pValues) { 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > dev_data->physDevProperties.properties.limits.maxPushConstantsSize) { 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, offset, size, "vkCmdPushConstants()"); 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if push constant update doesn't align with range 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer *pFramebuffer) { 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebufferCreateInfo *localFBCI = new VkFramebufferCreateInfo(*pCreateInfo); 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localFBCI->pAttachments = new VkImageView[localFBCI->attachmentCount]; 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localFBCI->pAttachments, pCreateInfo->pAttachments, localFBCI->attachmentCount * sizeof(VkImageView)); 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FRAMEBUFFER_NODE fbNode = {}; 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode.createInfo = *localFBCI; 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::pair<VkFramebuffer, FRAMEBUFFER_NODE> fbPair(*pFramebuffer, fbNode); 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 89835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_mem_binding_from_object(dev_data, device, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 89875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 89885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 89895b81366f6b6bf2b76529d233143bcd13bdbb8533Tobin Ehlis fbPair.second.attachments.push_back(fb_info); 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->frameBufferMap.insert(fbPair); 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 89935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> &processed_nodes) { 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<DAGNode> &subpass_to_node, VkBool32 &skip_call) { 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 result = VK_TRUE; 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass == dependent_subpasses[k]) 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_FALSE; 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, VkBool32 &skip_call) { 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_TRUE; 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 result = VK_FALSE; 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 has_preserved = VK_FALSE; 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_preserved = VK_TRUE; 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (has_preserved == VK_FALSE) { 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<DAGNode> &subpass_to_node) { 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 91355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 91845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 91995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 92045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 92055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip = VK_FALSE; 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92284d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92434d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 92545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 92594d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 92685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 92725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 92745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9299918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderModule *pShaderModule) { 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!shader_is_spirv(pCreateInfo)) { 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* dev */ 0, __LINE__, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", "Shader is not SPIR-V"); 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 9318918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass *pRenderPass) { 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE != skip_call) { 9337ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->subpassToNode = subpass_to_node; 939587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 939687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 939787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 939887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 939987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 940087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 940187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 940287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 940387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachments.push_back(pass_info); 940487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 940587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 940687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, bool> &attachment_first_read = dev_data->renderPassMap[*pRenderPass]->attachment_first_read; 940787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 940887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachment_first_layout; 940987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 941087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 941187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 941287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 941387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 941487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 941587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, true)); 941687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 941787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 941887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 941987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 942087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 942187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 942287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 942387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 942487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 942587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 942687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 942787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 942887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 942987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 943087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 943187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 943287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 943387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 94405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 94645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9503d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 95041c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 95051c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, const int subpass_index) { 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 95445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9570885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentinebool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9571885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 9572885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 9573885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9574885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9575885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9576885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9577885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9578885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9579885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9580885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9581885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9582885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9583885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9584885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9585885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9586885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9587885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9588885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 959787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 959887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 959987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 960087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 960187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 960272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 960387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 960487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 960587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 960672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 961172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 961387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkImageLayout &attachment_layout = pRPNode->attachment_first_layout[pRPNode->attachments[i].attachment]; 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL || 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, (uint64_t)(pRenderPassBegin->renderPass), __LINE__, 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_LAYOUT, "MEM", "Cannot clear attachment %d with invalid first layout %d.", 962087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->attachments[i].attachment, attachment_layout); 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 962287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 962372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 962872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 963087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 963172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 96345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 963572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 963887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 963972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 964372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 9649885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skipCall |= static_cast<VkBool32>(VerifyRenderAreaBounds(dev_data, pRenderPassBegin)); 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 96575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = pRenderPassBegin->renderPass; 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = pRenderPassBegin->framebuffer; 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->frameBufferMap[pCB->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassBeginInfo = *pRenderPassBegin; 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->currentSubpass = 0; 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass); 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 969572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline) { 969672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, 969772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) { 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 971003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 971172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 971272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 971387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(cb_data->second->activeRenderPass); 971487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 971587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 971687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 971787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 971887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 971972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 972472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 972687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 972772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::function<VkBool32()> function = [=]() { 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_FALSE; 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 973272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo); 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, const char *msg) { 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %" PRIu32 " is not compatable with %" PRIu32 ". %s", 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass), primaryAttach, secondaryAttach, 97625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryAttach, bool is_multi) { 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->attachmentCount <= primaryAttach) { 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data->second->pCreateInfo->attachmentCount <= secondaryAttach) { 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].format != 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].format) { 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].samples != 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].samples) { 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_data->second->pCreateInfo->pAttachments[primaryAttach].flags != 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].flags) { 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, const int subpass, bool is_multi) { 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &primary_desc = primary_data->second->pCreateInfo->pSubpasses[subpass]; 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &secondary_desc = secondary_data->second->pCreateInfo->pSubpasses[subpass]; 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validateSubpassCompatibility(dev_data, primaryBuffer, primaryPass, secondaryBuffer, secondaryPass, i, is_multi); 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer primary_fb = pCB->framebuffer; 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a framebuffer %" PRIx64 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current framebuffer %" PRIx64 ".", 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid framebuffer %" PRIx64 ".", 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 99255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 99355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 ". Pipeline statistics is being queried so the command " 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 "of type %d but a query of that type has been started on " 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "secondary Cmd Buffer %p.", 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 99785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 99795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers " 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 99935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 99945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 99955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 99985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) executed within render pass (%#" PRIxLEAST64 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass); 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass, pCommandBuffers[i], 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass, 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 100125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) w/ render pass (%#" PRIxLEAST64 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") is incompatible w/ primary command buffer (%p) w/ render pass (%#" PRIxLEAST64 ") due to: %s", 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass, errorString.c_str()); 100175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) references framebuffer (%#" PRIxLEAST64 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does not match framebuffer (%#" PRIxLEAST64 ") in active renderpass (%#" PRIxLEAST64 ").", 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass); 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to simultaneously execute CB %#" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%#" PRIxLEAST64 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 100535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 100565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->physDevProperties.features.inheritedQueries) { 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") cannot be submitted with a query in " 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 100665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 100675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 100705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 100715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 100795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 100825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1008458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 1008558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 1008758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 100995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 101025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 101065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1010803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 1010958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 101125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((memProps.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 101135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 101145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 101155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 101165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj %#" PRIxLEAST64, (uint64_t)mem); 101175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 101205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 101215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 1012258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 101235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 101245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skip_call) { 101265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 1012703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 1012881a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_lock_mutex(&globalLock); 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 1013081a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_unlock_mutex(&globalLock); 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1013603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 101375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUnmapMemory(VkDevice device, VkDeviceMemory mem) { 101385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 101405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 101425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 101435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 101445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 101455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 101465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMappedMemoryRange *pMemRanges) { 101515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 101525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 101535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 101545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 101555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 101565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 101575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 101585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 101595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 101605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 101615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 101625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 101655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 101675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 101735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 101775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVkBool32 validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 101805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMappedMemoryRange *pMemRanges) { 101815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 101825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 101835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 101855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 101865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 101875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 101895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 101905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 101915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 102035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 102065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 102105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 102145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 102155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 102165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 102205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 102215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 102245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 102295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 102305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skipCall = VK_FALSE; 102325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 102395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 102435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 102455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1024703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski VkBool32 skipCall = VK_FALSE; 1024803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 102515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t image_handle = (uint64_t)(image); 1025203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski skipCall = 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_mem_binding(dev_data, device, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_object_binding_info(dev_data, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, mem); 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 102565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 102575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vkGetImageMemoryRequirements(device, image, &memRequirements); 1025858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, image_handle, mem, memoryOffset, memRequirements, 1025958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].imageRanges, dev_data->memObjMap[mem].bufferRanges, 1026058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(dev_data, device); 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skipCall) { 102665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1027058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].image = image; 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[image].mem = mem; 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[image].memOffset = memoryOffset; 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[image].memSize = memRequirements.size; 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkSetEvent(VkDevice device, VkEvent event) { 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[event].needsSignaled = false; 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[event].stageMask = VK_PIPELINE_STAGE_HOST_BIT; 102845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->SetEvent(device, event); 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBool32 skip_call = VK_FALSE; 1029403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis //MTMTODO : Merge this code with the checks below 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfoCount; i++) { 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo *bindInfo = &pBindInfo[i]; 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 103015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->bufferBindCount; j++) { 103025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pBufferBinds[j].bindCount; k++) { 103035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_sparse_mem_binding(dev_data, queue, bindInfo->pBufferBinds[j].pBinds[k].memory, 103045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 103055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 103065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = VK_TRUE; 103075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->imageOpaqueBindCount; j++) { 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pImageOpaqueBinds[j].bindCount; k++) { 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_sparse_mem_binding(dev_data, queue, bindInfo->pImageOpaqueBinds[j].pBinds[k].memory, 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = VK_TRUE; 103155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->imageBindCount; j++) { 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pImageBinds[j].bindCount; k++) { 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_sparse_mem_binding(dev_data, queue, bindInfo->pImageBinds[j].pBinds[k].memory, 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = VK_TRUE; 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate semaphore state 103265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->waitSemaphoreCount; i++) { 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pWaitSemaphores[i]; 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_SIGNALLED) { 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 103325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 103335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 103345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse: Semaphore must be in signaled state before passing to pWaitSemaphores"); 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_WAIT; 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->signalSemaphoreCount; i++) { 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pSignalSemaphores[i]; 103415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 103435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 103455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse: Semaphore must not be currently signaled or in a wait state"); 103485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 103505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis print_mem_list(dev_data, queue); 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[bindInfo.pWaitSemaphores[i]].signaled) { 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[bindInfo.pWaitSemaphores[i]].signaled = 0; 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 103665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 103685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queue), (uint64_t)(bindInfo.pWaitSemaphores[i])); 103695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[bindInfo.pSignalSemaphores[i]].signaled = 1; 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_FALSE == skip_call) 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 1037903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update semaphore state 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t bind_info_idx = 0; bind_info_idx < bindInfoCount; bind_info_idx++) { 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo *bindInfo = &pBindInfo[bind_info_idx]; 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->waitSemaphoreCount; i++) { 103855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pWaitSemaphores[i]; 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->signaled = 0; 104060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->state = MEMTRACK_SEMAPHORE_STATE_UNSET; 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 104215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 104295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 104305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR *pSwapchain) { 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 104350801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104370801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 104525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1046403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 104650801763633180d277d26a90343464bd11646056fTobin Ehlis skipCall = clear_object_binding(dev_data, device, (uint64_t)swapchain_image, 104660801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 104670801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->imageBindingMap.erase((uint64_t)swapchain_image); 1046803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 104900801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 104910801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 104920801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 104930801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 104940801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 104965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 104975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkGetSwapchainInfoKHR(%" PRIu64 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 105025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]].createInfo.mipLevels = 1; 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]].createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105160801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 105170801763633180d277d26a90343464bd11646056fTobin Ehlis for (auto image : swapchain_node->images) { 105180801763633180d277d26a90343464bd11646056fTobin Ehlis // Add image object binding, then insert the new Mem Object and then bind it to created image 1051903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 105200801763633180d277d26a90343464bd11646056fTobin Ehlis add_object_create_info(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 105210801763633180d277d26a90343464bd11646056fTobin Ehlis &swapchain_node->createInfo); 1052203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 105230801763633180d277d26a90343464bd11646056fTobin Ehlis } 105240801763633180d277d26a90343464bd11646056fTobin Ehlis } 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 105265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 105375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 105385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[pPresentInfo->pWaitSemaphores[i]].signaled) { 105395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[pPresentInfo->pWaitSemaphores[i]].signaled = 0; 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queue), (uint64_t)(pPresentInfo->pWaitSemaphores[i])); 105465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105480801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 1055403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 105550801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 105560801763633180d277d26a90343464bd11646056fTobin Ehlis get_mem_binding_from_object(dev_data, queue, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 105570801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1055803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 1057903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; i++) { 105825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = pPresentInfo->pWaitSemaphores[i]; 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 1059703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[semaphore].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)semaphore, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[semaphore].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 106145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // FIXME/TODO: Need to add some thing code the "fence" parameter 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[semaphore].signaled = 1; 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 106215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT msgCallback, 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator) { 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueSubmit")) 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueSubmit; 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkWaitForFences")) 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkWaitForFences; 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetFenceStatus")) 106675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetFenceStatus; 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueWaitIdle")) 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueWaitIdle; 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDeviceWaitIdle")) 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDeviceWaitIdle; 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceQueue")) 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceQueue; 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFence")) 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFence; 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetFences")) 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetFences; 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySemaphore")) 106835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySemaphore; 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyEvent")) 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyEvent; 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyQueryPool")) 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyQueryPool; 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBuffer")) 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBuffer; 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBufferView")) 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBufferView; 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImage")) 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImage; 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImageView")) 106955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImageView; 106965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyShaderModule")) 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyShaderModule; 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipeline")) 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipeline; 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipelineLayout")) 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineLayout; 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySampler")) 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySampler; 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorSetLayout; 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorPool")) 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorPool; 107085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFramebuffer")) 107095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFramebuffer; 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyRenderPass")) 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyRenderPass; 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBuffer")) 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBuffer; 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBufferView")) 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBufferView; 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImage")) 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImage; 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImageView")) 107195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImageView; 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFence")) 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFence; 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "CreatePipelineCache")) 107235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineCache; 107245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "DestroyPipelineCache")) 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineCache; 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "GetPipelineCacheData")) 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPipelineCacheData; 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "MergePipelineCaches")) 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMergePipelineCaches; 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateGraphicsPipelines")) 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateGraphicsPipelines; 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateComputePipelines")) 107335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateComputePipelines; 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSampler")) 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSampler; 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorSetLayout; 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreatePipelineLayout")) 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineLayout; 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorPool")) 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorPool; 107425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetDescriptorPool")) 107435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetDescriptorPool; 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateDescriptorSets")) 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateDescriptorSets; 107465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeDescriptorSets")) 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeDescriptorSets; 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUpdateDescriptorSets")) 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUpdateDescriptorSets; 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateCommandPool")) 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateCommandPool; 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyCommandPool")) 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyCommandPool; 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandPool")) 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandPool; 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateQueryPool")) 107575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateQueryPool; 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateCommandBuffers")) 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateCommandBuffers; 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeCommandBuffers")) 107615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeCommandBuffers; 107625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBeginCommandBuffer")) 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBeginCommandBuffer; 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEndCommandBuffer")) 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEndCommandBuffer; 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandBuffer")) 107675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandBuffer; 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindPipeline")) 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindPipeline; 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetViewport")) 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetViewport; 107725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetScissor")) 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetScissor; 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetLineWidth")) 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetLineWidth; 107765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBias")) 107775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBias; 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetBlendConstants")) 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetBlendConstants; 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBounds")) 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBounds; 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilCompareMask; 107845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilWriteMask; 107865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilReference")) 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilReference; 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindDescriptorSets")) 107895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindDescriptorSets; 107905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindVertexBuffers")) 107915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindVertexBuffers; 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindIndexBuffer")) 107935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindIndexBuffer; 107945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDraw")) 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDraw; 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexed")) 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexed; 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndirect")) 107995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndirect; 108005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexedIndirect; 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatch")) 108035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatch; 108045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatchIndirect")) 108055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatchIndirect; 108065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBuffer")) 108075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBuffer; 108085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImage")) 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImage; 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBlitImage")) 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBlitImage; 108125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBufferToImage")) 108135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBufferToImage; 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) 108155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImageToBuffer; 108165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdUpdateBuffer")) 108175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdUpdateBuffer; 108185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdFillBuffer")) 108195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdFillBuffer; 108205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearColorImage")) 108215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearColorImage; 108225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) 108235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearDepthStencilImage; 108245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearAttachments")) 108255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearAttachments; 108265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResolveImage")) 108275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResolveImage; 108285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetEvent")) 108295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetEvent; 108305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetEvent")) 108315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetEvent; 108325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWaitEvents")) 108335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWaitEvents; 108345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPipelineBarrier")) 108355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPipelineBarrier; 108365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginQuery")) 108375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginQuery; 108385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndQuery")) 108395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndQuery; 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetQueryPool")) 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetQueryPool; 108425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyQueryPoolResults")) 108435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyQueryPoolResults; 108445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPushConstants")) 108455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPushConstants; 108465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWriteTimestamp")) 108475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWriteTimestamp; 108485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFramebuffer")) 108495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFramebuffer; 108505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateShaderModule")) 108515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateShaderModule; 108525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateRenderPass")) 108535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateRenderPass; 108545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginRenderPass")) 108555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginRenderPass; 108565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdNextSubpass")) 108575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdNextSubpass; 108585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndRenderPass")) 108595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndRenderPass; 108605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdExecuteCommands")) 108615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdExecuteCommands; 108625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkSetEvent")) 108635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkSetEvent; 108645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkMapMemory")) 108655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMapMemory; 1086603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 108675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUnmapMemory")) 108685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUnmapMemory; 108695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateMemory")) 108705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateMemory; 108715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeMemory")) 108725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeMemory; 108735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFlushMappedMemoryRanges")) 108745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFlushMappedMemoryRanges; 108755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkInvalidateMappedMemoryRanges")) 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkInvalidateMappedMemoryRanges; 108775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindBufferMemory")) 108785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindBufferMemory; 108795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetBufferMemoryRequirements")) 108805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetBufferMemoryRequirements; 108815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetImageMemoryRequirements")) 108825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetImageMemoryRequirements; 108835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 108845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetQueryPoolResults")) 108855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetQueryPoolResults; 108865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindImageMemory")) 108875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindImageMemory; 108885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueBindSparse")) 108895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueBindSparse; 108905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSemaphore")) 108915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSemaphore; 108925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateEvent")) 108935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateEvent; 108945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev == NULL) 108965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 108975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 108995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 109005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->device_extensions.wsi_enabled) { 109025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSwapchainKHR")) 109035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSwapchainKHR; 109045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySwapchainKHR")) 109055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySwapchainKHR; 109065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) 109075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetSwapchainImagesKHR; 109085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAcquireNextImageKHR")) 109095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAcquireNextImageKHR; 109105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueuePresentKHR")) 109115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueuePresentKHR; 109125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 109155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 109165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 109175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 109185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 109195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 109235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetInstanceProcAddr")) 109245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetInstanceProcAddr; 109255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 109265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 109275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateInstance")) 109285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateInstance; 109295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDevice")) 109305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDevice; 109315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 109325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 1093303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 109345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetPhysicalDeviceMemoryProperties")) 109355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPhysicalDeviceMemoryProperties; 109365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 109375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 109385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceLayerProperties; 109395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 109405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceExtensionProperties; 109415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 109425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceLayerProperties; 109435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) 109445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceExtensionProperties; 109455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (instance == NULL) 109475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 109485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkVoidFunction fptr; 109505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 109525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 109535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 109545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fptr) 109555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return fptr; 109565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 109585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 109595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 109605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 109615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10962