core_validation.cpp revision 0dc3fd4e57b8531638781daa01a2fb5d1048a6fb
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 41825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 46dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 63b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 73c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 7871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis// TODO : CB really needs it's own class and files so this is just temp code until that happens 7971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin EhlisGLOBAL_CB_NODE::~GLOBAL_CB_NODE() { 8071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (uint32_t i=0; i<VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 8171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis // Make sure that no sets hold onto deleted CB binding 8271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (auto set : lastBound[i].uniqueBoundSets) { 8371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(this); 8471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis} 8771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis 88d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 89d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 96b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 98e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 993f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 10856a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 109b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski unique_ptr<INSTANCE_STATE> instance_state; 110b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski 11156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 11694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 118cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 119cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Vector indices correspond to queueFamilyIndex 120cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski vector<unique_ptr<VkQueueFamilyProperties>> queue_family_properties; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 124cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1252c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis unordered_map<VkImageView, unique_ptr<VkImageViewCreateInfo>> imageViewMap; 1266d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 1272f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis unordered_map<VkBufferView, unique_ptr<VkBufferViewCreateInfo>> bufferViewMap; 1288718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1308d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 132397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 133cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 13557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 14272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 14304861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_NODE>> frameBufferMap; 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 147918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1486c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 151b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 152b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 153f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDeviceFeatures physical_device_features; 154cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unique_ptr<PHYSICAL_DEVICE_STATE> physical_device_state; 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 157b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski : instance_state(nullptr), report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), 158825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski device_extensions(), device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{}, physical_device_features{}, 159cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski physical_device_state(nullptr){}; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 162b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 163b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 164b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 165e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 166f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 167e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 172e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 178e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 196b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 197b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 199b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 200b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 201b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 202b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 203b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 204b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 263b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 264593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 2652c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis// Return ImageViewCreateInfo ptr for specified imageView or else NULL 266a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkImageViewCreateInfo *getImageViewData(const layer_data *dev_data, VkImageView image_view) { 2672c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2682c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2692c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2702c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2712c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2722c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2739a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 274a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2752c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2762c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2779a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2789a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2799a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2809a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2816d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 282a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2836d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2846d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2856d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2866d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2876d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2886d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2898718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 290a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2912c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2922c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2938718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2948718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2958718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2968718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 297b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 298a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 299b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 300b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 301b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 302b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 3033f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 304b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 305170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 306a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 307170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 308170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 309170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 310170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 311170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 312170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3132f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 314a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkBufferViewCreateInfo *getBufferViewInfo(const layer_data *my_data, VkBufferView buffer_view) { 3152f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3162f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3172f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3182f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3192f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3202f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 32266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 32366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 32466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 32566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 32666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 32766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 32866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3309556936067fd0c4eb74c4a13631bc163b154faedTobin EhlisEVENT_NODE *getEventNode(layer_data *dev_data, VkEvent event) { 3319556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3329556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3339556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3349556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3359556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3369556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3379556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 338ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 339ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 340ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 341ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 342ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 343ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 344ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 345ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 34666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 34766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 34866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 34966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 35066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 35166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 35266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 35366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3545e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3555e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3565e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3575e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3585e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3595e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3605e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3615e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3628d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3638d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3648d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3658d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3668d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3678d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3688d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3698d6a38de0389036581ada119e548180c614fe0efChris Forbes 37094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 3746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3798718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 3808718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3818718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3915121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 39272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3970a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 400e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 40183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 40783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 40883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 40983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 41083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 416249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 417249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 418249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlisstatic bool validateImageUsageFlags(layer_data *dev_data, IMAGE_NODE const *image_node, VkFlags desired, VkBool32 strict, 419249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 420249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, 421249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 422249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 423249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 424249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 425249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 426ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 427ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 428ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlisstatic bool validateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 429ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 430ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 431ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 432ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 433ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 434ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 43757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 43857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 43957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 452e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 453e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4556d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, image); 4566d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node && !image_node->valid) { 45758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 459414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 4605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 46558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 467414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 4776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 4786d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = valid; 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 49283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 49857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 4995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 500de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 50272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 50472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 505c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 5105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 511ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 512ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given iamge node and command buffer node 513ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlisstatic bool addCommandBufferBindingImage(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_NODE *img_node, const char *apiName) { 514ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis bool skip_call = false; 515ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 516ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (img_node->mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 517ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 518ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, img_node->mem); 519ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 520ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis pMemInfo->commandBufferBindings.insert(cb_node->commandBuffer); 521ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 522ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(img_node->mem); 523ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 524bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 525ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 526ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for image 527ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis img_node->cb_bindings.insert(cb_node); 528ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return skip_call; 529ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 530ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 531ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 532ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlisstatic bool addCommandBufferBindingBuffer(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node, 533ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis const char *apiName) { 534ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis bool skip_call = false; 535ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 536ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 537ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->mem); 538ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 539ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis pMemInfo->commandBufferBindings.insert(cb_node->commandBuffer); 540ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 541ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(buff_node->mem); 542bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 543ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 544ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 545ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 546ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 547ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return skip_call; 548ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 549ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 550400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 551400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 55272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 553c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 554c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 55557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 557400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 560c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 565400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 566400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 567400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 57283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 573de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 574896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 576de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 57783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 57883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 57983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 58083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " references", 58183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 584de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 585de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 58658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 587de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 588414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 591de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 594896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 595896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 596896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 597414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 598896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 601896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 606e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 60783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 60957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 611ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO: Verify against Valid Use section 612ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Clear any CB bindings for completed CBs 613ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO : Is there a better place to do this? 614ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 615ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller assert(pInfo->object != VK_NULL_HANDLE); 616ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // clear_cmd_buf_and_mem_references removes elements from 617ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // pInfo->commandBufferBindings -- this copy not needed in c++14, 618ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // and probably not needed in practice in c++11 619ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller auto bindings = pInfo->commandBufferBindings; 620ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (auto cb : bindings) { 621ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 622ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller clear_cmd_buf_and_mem_references(dev_data, cb); 6235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 624ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 626ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Now verify that no references to this mem obj remain and remove bindings 627ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 628ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= reportMemReferencesAndCleanUp(dev_data, pInfo); 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 630ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Delete mem obj info 631ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->memObjMap.erase(dev_data->memObjMap.find(mem)); 632ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } else if (VK_NULL_HANDLE != mem) { 633ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // The request is to free an invalid, non-zero handle 634ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 635ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 636ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem), __LINE__, 637ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller MEMTRACK_INVALID_MEM_OBJ, 638ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "MEM", "Request to delete memory object 0x%" 639ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller PRIxLEAST64 " not present in memory Object Map", 640ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem)); 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 653e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 654e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis return "descriptor set"; 655e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 656e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis return "buffer"; 6579556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 6589556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return "event"; 659ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 660ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return "query pool"; 661a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 662a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis return "pipeline"; 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 670c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 67483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 67694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 67757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 67994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 681c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 683896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 68483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 68558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 686414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 687414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 695b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 696b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinskistatic bool ValidateMemoryIsBoundToImage(layer_data *dev_data, IMAGE_NODE *image_node, const char *api_name) { 697b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 698b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == (static_cast<uint32_t>(image_node->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 699b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == image_node->mem) { 700b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 701b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 702b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski "%s: VkImage object 0x%" PRIxLEAST64 " used without first calling vkBindImageMemory.", api_name, 703b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image)); 704b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 705b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 706b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 707b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 708b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 709b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 710b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinskistatic bool ValidateMemoryIsBoundToBuffer(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *api_name) { 711b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 712b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 713b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == buffer_node->mem) { 714b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 715b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski reinterpret_cast<uint64_t &>(buffer_node->buffer), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 716b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski "%s: VkBuffer object 0x%" PRIxLEAST64 " used without first calling vkBindBufferMemory.", api_name, 717b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski reinterpret_cast<uint64_t &>(buffer_node->buffer)); 718b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 719b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 720b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 721b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 722b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 72894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 72994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 73083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 73483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 73583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7382e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 73957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 7402e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 74157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = getMemObjInfo(dev_data, *pMemBinding); 7422e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 74383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 74483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 74583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 74683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 74783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 7482e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 7492e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pMemInfo->objBindings.insert({handle, type}); 7502e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 7512e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 7522e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 7536d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 7546d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 7556d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 7562e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 7572e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7612e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 7730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 7740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 7750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 77683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 77983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = clear_object_binding(dev_data, handle, type); 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7822e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 78357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7842e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 7852e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pInfo->objBindings.insert({handle, type}); 7862e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 7872e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 793caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 794caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 795caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 797caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 798caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 799caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getImageNode(dev_data, VkImage(handle))->mem; 800caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 801caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 802caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->mem; 803caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 804caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 805caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 807caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 808caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 809caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 810caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 811caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 812caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 813caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 814caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 815caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 8170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 81958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 82458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 82658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 82758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 83457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 83757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 83858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 83957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 84058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 841c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 84257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size() + mem_info->objBindings.size()); 84357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (0 != mem_info->allocInfo.allocationSize) { 84457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->allocInfo, "MEM(INFO): "); 84558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 85457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->objBindings.size()); 85557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->objBindings.size() > 0) { 85657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto obj : mem_info->objBindings) { 85758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 858414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 86557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->commandBufferBindings.size()); 86657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->commandBufferBindings.size() > 0) { 86757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis for (auto cb : mem_info->commandBufferBindings) { 86858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 869414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 87672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 88472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 88572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 89372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 896414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 898c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 900c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 902414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11319ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 11389ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 11419ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11439ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 11449ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11469ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 11479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11509ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 11519ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11549ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 11559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 11599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 11609ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 11629ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 11649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 11659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 11829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 11859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 119737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 119837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 119937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 120037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 120137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 120237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 120337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 120437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 120537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12127c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 121337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 12147c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12157c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 121837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 121937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 122037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 122137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 122237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12297c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 12307c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 123137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 12327c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12337c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12347c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 12357c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 12367c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 12377c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12387c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12417c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 12447c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 12477c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 124937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 125037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 125137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 125237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 125337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 125437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 125537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 125637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 125737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 125937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 126037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 126537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 127537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1316cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1317cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1318cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1319cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1320cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1321cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1322cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1323cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1324cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1334c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1335c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1336c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1337c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1338c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1339c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1340c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1341c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1342c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1343c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1344c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1345c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1346c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1347c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1355b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1356fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1360031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1361031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1362031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1363031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1364031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1365031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1366031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1367031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1368031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1369031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1370031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1371031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1372031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1373031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1390edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1393b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1395031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1433b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1434fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1442edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_location(shader_module const *src, spirv_inst_iter entrypoint, 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1449b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1472b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1473b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1474b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1475b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 148181264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1486c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14971d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1504b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 15177c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1523b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1524fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1529edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_block_members(src, out, blocks, is_array_of_verts, id, type, is_patch); 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1535edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_descriptor_slot(debug_report_data *report_data, shader_module const *src, 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 1537cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> &out) { 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1569b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1570b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1571fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1572cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1577edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1578031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1580031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1586edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1587edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1600edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1601080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1602031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1603031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1608edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1610031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1611031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1616fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1617fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1618fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1619fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 16200f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1621fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1622fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 162337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1624edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 16269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 16279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 16289ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16320f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1633edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16340f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1635f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 16360f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 16370f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 16380f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 16390f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 16400f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 16410f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 167331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 167431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 167531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 167631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1679f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 169531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 169631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 169731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 169831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1701f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1739edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1750edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1763edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1768edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, inputs, false); 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1773c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1774c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1775c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1776c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1777c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1778c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 17831730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 17911730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1792080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17961730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1799edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1811edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 18149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 18159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 18211730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1829edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 18308da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 18318da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 1833025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 18348da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 18358da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 1836d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 1837d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 1838d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 1839d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 1840d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 1841025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1842025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1843025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1848edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, outputs, false); 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1850025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1851025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1853025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1854025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1855025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1856025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1857025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1859025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1860edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1862025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1865025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1866025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1867edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1868025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1871025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1873025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1874025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1878edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1880025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1881025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1882025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1888025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1889025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 191681264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1996c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2002c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2013edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2014416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2034416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2039edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2040080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2053edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2054080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2068edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2069416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2076416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2077416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2084fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2085fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 20864a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 208937083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2091416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 209237083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2094416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2109e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2111e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2115e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2116e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 21173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 21183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 21193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2122e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 212616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2127ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2128ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2129ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2131ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 213416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 213516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 213616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 213716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 213816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 213916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 214016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 214116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 214204861caca7eb93a5241b164e8480bb93c826902cTobin Ehlisstatic FRAMEBUFFER_NODE *getFramebuffer(const layer_data *my_data, VkFramebuffer framebuffer) { 2143f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2144f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2145f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2146f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 214704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2148f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2149f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2150e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 215111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 215211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 215311f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 215411f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 215511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 215611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 215711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 21584a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 21594a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 21604a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 21614a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 21624a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 21634a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 21644a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 21654a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2171e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2174e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2178e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2179e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 21803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 21813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 21823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 21833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2184ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2185ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2186ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 21873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 21893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 219045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 219145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 21923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 21943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 21953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 21963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 21973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 21983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 219945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 220045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 22013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 22033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 220445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 220545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 22063d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 22083d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22093d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 22103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 22123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22133d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 22143d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22153d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 22173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 22235ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2230e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2231e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2232e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2233e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2234e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2235e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2236e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2237e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2238e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 224006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 224106e963555b0df747c98c43816c16647349d21001Mark Young return true; 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 224306e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 224406e963555b0df747c98c43816c16647349d21001Mark Young return true; 22455ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 22465ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 22475ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 22485ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 22495ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 22505ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2260a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 22618da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2262a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 22638da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2265c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2281c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2289c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2295fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2296fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2297fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2298fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2299fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2300c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2301fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2302fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2303fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2304fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2305fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2313c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2323397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2324397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2325397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 232669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 232769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2328416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 23299b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2330c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 233169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 233269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 233369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2337416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2338397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2342edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2350edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 23535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 23555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 23575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2367edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 23681b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23711b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 23721b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 23737b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 23747b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 23767b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 23777b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 23787b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 23797b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23807b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 23817b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 23827b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 23865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 23875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 23885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 23895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 23915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 24005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 240467d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 240567d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 240835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 240935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 241035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 241135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 241235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 241335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 241435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 241535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 241635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 241735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 24185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 24225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 24235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 24275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 24285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 24315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 24325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 24335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 24345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 24365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 243867d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 243967d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 24425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 24475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24534110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 24554110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2456080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2463a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 246769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 246869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2472a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2473a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2477a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2481a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 24884110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 24924110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 24964110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 25004110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 25054110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 25104110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2513a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 25144110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2515a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2516a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 25184110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 25234110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2524a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2527a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 25284110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2529a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 25334110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2537a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 25384110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 25424110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 25464110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2547a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2548a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 25504110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2551a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2552a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2553a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 25544110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2555a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2556a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2557a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 25584110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2559a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2560a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2561a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 25624110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2563a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2564a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2565a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 25664110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2567a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2568a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2569a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 25704110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2571a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2572a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2573a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2574a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 25754110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2576a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2577a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2578a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 25794110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2580a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2581a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2582a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2583a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 25844110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2585a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2586a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2587a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2588a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 25894110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2590a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2591a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2592a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 25934110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2594a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2595a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2596a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2597e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2598a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2599a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2600a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2601a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2602a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2603a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2604a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2605a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2606ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2607ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2608ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2609ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2610ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 261169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2612ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2613ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 261569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 261669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2617557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 261878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 261978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 262078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 262178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2622557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2623080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 262478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 262578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2626e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 262778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 262878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 262978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2631557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 263278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 263478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 263578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 263678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 263778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 2638cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> descriptor_uses; 2639557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes collect_interface_by_descriptor_slot(report_data, module, accessible_ids, descriptor_uses); 264078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26412e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2642ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 264378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2644416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 264578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 264678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 264778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 264878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 264978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 265078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2651fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2652c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 265378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 265478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 265578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2656557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2657080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 265878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 265978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2660e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 266178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 266278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2663557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 266478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 266578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 266678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 266778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2668fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 266978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2670e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 267178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2672edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2673fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2674557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2675fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2676fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2677fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2678fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 267978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 268178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 268278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2683557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2684fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 268578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 268678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2687fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 268978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 269078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 269178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 269278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 269378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 269478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 269578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 269678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2697a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2698a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2699e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 270069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 270169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 27026660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 27035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 27045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 27055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 27075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 27085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 27095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 27105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 27125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 27146660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 271578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2716e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 271769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 271869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 27195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 27225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2724e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 27255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2728e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 27295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 27325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 27335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 27355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 27365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 27375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 27405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 27415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2742e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2743031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2744031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 27455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 27475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27508da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 2751e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 27528da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 27535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 27565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2758e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 275969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 27606660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 276103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 276203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 276303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 276403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2765e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 276669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 276703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 27685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2769a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2770104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2771104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 27725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 27735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2774104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 27755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 27767a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27777a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27787a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27807a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27817a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 2785dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes const vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, 2786dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t> const *>> &activeSetBindingsPairs) { 2787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2788a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2789dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2790cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2791dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2792397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2793cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2794397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2795cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2796cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2797414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " encountered the following validation error at draw time: %s", 2798cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), err_str.c_str()); 2799cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2800dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 28015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2805eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2806ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2807ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2808ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2809eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2810eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2811eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2812eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2813eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2814eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 281529d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 281629d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 281729d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 281829d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2819eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 282029d196e071b2dc1db47702085469396f2b956820Chris Forbes 282129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 282229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 282329d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 282429d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 282529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 282629d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 282729d196e071b2dc1db47702085469396f2b956820Chris Forbes "The Pipeline State Object (0x%" PRIxLEAST64 282829d196e071b2dc1db47702085469396f2b956820Chris Forbes ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 282929d196e071b2dc1db47702085469396f2b956820Chris Forbes " should be set via vkCmdBindVertexBuffers.", 283029d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)state.pipeline, i); 283129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 283229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 283329d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 283429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 283529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 283629d196e071b2dc1db47702085469396f2b956820Chris Forbes 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 283729d196e071b2dc1db47702085469396f2b956820Chris Forbes "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 283829d196e071b2dc1db47702085469396f2b956820Chris Forbes ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 283929d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 284029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 284129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 284229d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 284329d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 284429d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 284529d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 284629d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 284729d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 284829d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 284929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 285029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->viewports.size() != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 285129d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 285229d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 285329d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 285429d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO viewportCount is %u. These counts must match.", 285529d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->viewports.size(), pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 285629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 285729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 285829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 285929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->scissors.size() != pPipeline->graphicsPipelineCI.pViewportState->scissorCount) { 286029d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 286129d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 286229d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 286329d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO scissorCount is %u. These counts must match.", 286429d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->scissors.size(), pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 286529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 286629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 286729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 286829d196e071b2dc1db47702085469396f2b956820Chris Forbes 286929d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 287029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 287129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 287229d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 287329d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 287429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 287529d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 287629d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 287729d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 287829d196e071b2dc1db47702085469396f2b956820Chris Forbes 287929d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 288029d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 288129d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 288229d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2883eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2884ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 2885eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 2886414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 2887eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 2888eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 2889ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 289029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2891eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 289276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 28930a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 289429d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 289576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 289676957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 289776957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 289829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 28990a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 290076957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 290176957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 290276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 290376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 290429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2905eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 29060dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 290729d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2908eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2909ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2910414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 2911414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 2912ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 2913ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 2914eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 291529d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 291629d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 291729d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 291829d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 291929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2920eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2921eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2922528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 2923528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 2924528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 2925a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 2926a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->pCreateInfo, pPipeline->render_pass_ci.ptr(), 2927528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 2928528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 2929528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 2930528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2931528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 2932528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 2933528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 2934528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 2935528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 2936528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 2937528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 293829d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 293929d196e071b2dc1db47702085469396f2b956820Chris Forbes 2940eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 2941eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2942eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2944e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2945e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2946e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 29477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 29487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 294922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 295022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 295122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 295222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 295322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 295422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 295522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 295622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 295722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 29583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 29597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 29607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 29617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 29625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 296369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 296422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 296569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 2966169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 296722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2968dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, std::vector<uint32_t> const *>> activeSetBindingsPairs; 2969dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 297022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 297122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 297222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 297322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 297422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 2975414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 297622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 297769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 297869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 297969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 298071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 298122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 298222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 298322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 2984414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 2985414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 298669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 298769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 298822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 298922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 299071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 299122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2992dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, 2993dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes &state.dynamicOffsets[setIndex])); 299422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 299522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 2996397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 299722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto binding : setBindingPair.second) { 2998397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 299922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 300022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3001397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3002414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 300322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3004397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3005fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 300922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 301022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 301122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 301222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3013eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3014eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 301529d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 301629d196e071b2dc1db47702085469396f2b956820Chris Forbes result |= validatePipelineDrawtimeState(my_data, state, pCB, pPipe); 3017eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3021a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3022a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3023a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3024a27508babf63d50aea75883a3702979193c23683Mark Young 3025a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3026a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 3027a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3028a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3029a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3030a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3031a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3032a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3033a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3034a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3035a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3036a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3037a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3038a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3039a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3040a27508babf63d50aea75883a3702979193c23683Mark Young } 3041a27508babf63d50aea75883a3702979193c23683Mark Young } 3042a27508babf63d50aea75883a3702979193c23683Mark Young 3043a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3044a27508babf63d50aea75883a3702979193c23683Mark Young} 3045a27508babf63d50aea75883a3702979193c23683Mark Young 30465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 3047e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 3048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 304983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 306083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 306183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 306283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 306583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 307783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 307883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 307983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3084b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 308626c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3087c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 308806811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 308906811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 309006811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 309106811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 309206811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 309383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 309483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 309583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 309683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 309706811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3098c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3102b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 310483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 311283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3119a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 312216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 312316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 312416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 312583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 312683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 312783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 312883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3131e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 313269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 313383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 313552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 313652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 313752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 313852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 313983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 314083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 314183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 314283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 314352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 314452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 314552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 314883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 315583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 315683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 315783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 31585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 316483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 316583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 316683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3171ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3172ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 317383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 317483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 317583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 317683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3178ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3179ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 318183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 318283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 318383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 318483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 318583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3187ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 318883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 318983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 319083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 319183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 319283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3193ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3194ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 319583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 319683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 319783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 319883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 319983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 320083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3203a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3204a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3205a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 320683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 320783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3208a27508babf63d50aea75883a3702979193c23683Mark Young } 3209a27508babf63d50aea75883a3702979193c23683Mark Young } 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 32135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 321445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 321683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 321783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 321883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 321983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 322283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 322383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 322483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 322583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 322683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 323483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 323583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 323683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 323783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 323883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 323983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 324083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 324683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 324783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 324883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 324983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 325083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 325183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 325683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3263ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3264ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3272e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3273bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3274bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3277bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3285e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3308fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3310fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3313fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3316fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3319fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 332283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 33231d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 333383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 333483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 333583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 333683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 333883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3339fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 334083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3341fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3342fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3343fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3344fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 334783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 33504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 33514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 33524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 33584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 33594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 33624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 33664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 33684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 33714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 33724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 33744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 33784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 33794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 33824a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 33834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 33844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 33854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 33864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 33884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 33894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 33904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 33914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 33924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 33934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 33944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 33954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 33964a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 34004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 34014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 34024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 34034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 34044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 34054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 34074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 34174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 34184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 34194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 34204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 34214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 34224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 34244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34416d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 34426d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 34476d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 34625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 347408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 347708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 347808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 347908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 348008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 348408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 348608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 348708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 34937068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 34947068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 34957068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 349608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 350008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 350108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 350208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 350308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 350408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 350508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 350808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 350908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 351108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 351208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 351308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 351408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 351708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 351908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 35232c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 35242c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(iv_data); 35252c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = iv_data->image; 35262c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = iv_data->subresourceRange; 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3541e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3542e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3543e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3548414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3554414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3560f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3561e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 35629dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 35639dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 35649dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 35659dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3572c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3573cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 35749dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3576f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 3584de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3585de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3586de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3587de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3588de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3589de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3590de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3591de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3592de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3594de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 35985121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 35995121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 36005121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 360172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 360272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3603414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36065121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3611400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3626e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3629e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3630d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3631d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3669a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 367083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3671a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3672a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3673a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 368883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 371283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 371683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 37267651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 373383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 37347651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 373583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 374283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37449822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 37459822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add object_binding to cmd buffer 37469822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add cb_binding to object 37479822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 37489822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_bindings->insert(cb_node); 37499822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_node->object_bindings.insert(obj); 37509822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis} 3751bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 3752bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 3753bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis switch (object->type) { 3754bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 375564d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto img_node = getImageNode(dev_data, reinterpret_cast<const VkImage &>(object->handle)); 3756bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (img_node) 3757bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis img_node->cb_bindings.erase(cb_node); 3758bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3759bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3760bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 376164d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto buf_node = getBufferNode(dev_data, reinterpret_cast<const VkBuffer &>(object->handle)); 3762bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (buf_node) 3763bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis buf_node->cb_bindings.erase(cb_node); 3764bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3765bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 37669822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 3767e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto evt_node = getEventNode(dev_data, reinterpret_cast<const VkEvent &>(object->handle)); 37689822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis if (evt_node) 37699822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis evt_node->cb_bindings.erase(cb_node); 37709822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 37719822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 3772ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 3773e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto qp_node = getQueryPoolNode(dev_data, reinterpret_cast<const VkQueryPool &>(object->handle)); 3774ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) 3775ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis qp_node->cb_bindings.erase(cb_node); 3776ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 3777ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 3778a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 3779e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto pipe_node = getPipeline(dev_data, reinterpret_cast<const VkPipeline &>(object->handle)); 3780a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) 3781a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis pipe_node->cb_bindings.erase(cb_node); 3782a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 3783a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 3784bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 3785bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis assert(0); // unhandled object type 3786bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3787bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3790400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3791400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3793b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 380693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 380772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 380872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 380972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 381071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(pCB); 381172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 381272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 381372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 381493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3816ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 3819e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 3822c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 3827abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 3833bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 3834bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 3835bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 3836bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 38387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 38397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 3840400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 3841b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 3842d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 384393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 3844bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 3845bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 3846bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 3847bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 384893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 384993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 3850d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 3851d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) 3852b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis fb_node->cb_bindings.erase(pCB); 385393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 385493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 38557003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 3862ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 3863ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 3870ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 3871ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 38853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 3909e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 391083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 391372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 391783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 391883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 391983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 392083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 392183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 392483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3931414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 3936414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3943e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 394483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 394683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 394883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 394983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 3954e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3955e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 3959414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 3960ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 3967e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3968e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3979b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 3980d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 3981b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 398589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 398689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4002b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 400356a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 4004b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4005b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4007b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4008b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4009b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 4010b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4011825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 4012b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski instance_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE()); 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 401989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4028b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 40335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4062838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 4063838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskibool ValidateRequestedQueueFamilyProperties(layer_data *dev_data, const VkDeviceCreateInfo *create_info) { 4064838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 4065838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 4066838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (!dev_data->physical_device_state) { 4067838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4068838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4069838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 4070838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (QUERY_DETAILS != dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4071838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 4072838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4073838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4074838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4075838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4076838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4077838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4078838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 4079838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (dev_data->queue_family_properties.size() <= 4080838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex) { // requested index is out of bounds for this physical device 4081838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 4082838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4083838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4084838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4085838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 4086838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->queue_family_properties[requestedIndex]->queueCount) { 4087838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 4088838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4089838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4090838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4091838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 4092838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex, dev_data->queue_family_properties[requestedIndex]->queueCount, 4093838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4094838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4095838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4096838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4097838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4098838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4099838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4100f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 4101838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskistatic bool ValidateRequestedFeatures(layer_data *dev_data, const VkPhysicalDeviceFeatures *requested_features) { 4102f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4103f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4104825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski VkBool32 *actual = reinterpret_cast<VkBool32 *>(&(dev_data->physical_device_features)); 4105825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4106f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4107f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4108f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4109f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4110f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4111f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4112f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4113f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4114838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4115f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4116f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4117f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4118f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4119f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4120f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4121f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4122838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (errors && (UNCALLED == dev_data->physical_device_state->vkGetPhysicalDeviceFeaturesState)) { 4123f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4124f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4125838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4126cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4127cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4128cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4129f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4130f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4131f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4132f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 413389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 413489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 413556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 4136f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4137f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4138f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4139f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 4140f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski skip_call |= ValidateRequestedFeatures(my_instance_data, pCreateInfo->pEnabledFeatures); 4141f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4142838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, pCreateInfo); 4143f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 414956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4162b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 41686c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4173b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4176b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4178b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4181b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4183b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4185b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4186b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4187b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 419689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4201b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4205f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4207f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4208f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4209a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4210a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4211a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4212fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 42191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 42201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4221b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 422203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 422383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4224b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 42290a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 42300a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 423258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4233400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 423557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 423883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 423983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 424083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 424183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 424283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4248b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4251414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 425483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4269971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4270e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4276414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4282856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4283856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4284856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4285971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4286414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4287856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4288414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4289414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4290414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4291856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4292856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4293856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4294856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4295971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4296414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4297856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4298856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4299856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4300856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 430739d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4309da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4311a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4312a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes pCB->in_use.fetch_add(1); 4313a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes my_data->globalInFlightCmdBuffers.insert(pCB->commandBuffer); 4314a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 43178718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 43188718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4321414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43238718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 432772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 432872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 432971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis if (!my_data->setMap.count(set->GetSet())) { 433072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 433172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 433272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4333414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", (uint64_t)(set)); 433472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 433571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_add(1); 433672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 43409556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(my_data, event); 43419556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!event_node) { 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4345414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->in_use.fetch_add(1); 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4350c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 43519556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(my_data, event); 43529556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) 43539556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->write_in_use++; 4354c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4358b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4359b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4360b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4361b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4362b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4363b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4364b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4365b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4366b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4367b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4368b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4369414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4370414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4371b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4372b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4373b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4374b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4375b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4376b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4377b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4378b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4379b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4380b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4381b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4382b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4383b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4384b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4385b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4386b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4387b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4388651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void decrementResources(layer_data *my_data, CB_SUBMISSION *submission) { 4389da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission->cbs) { 4390da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto pCB = getCBNode(my_data, cb); 4391da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto drawDataElement : pCB->drawData) { 4392da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto buffer : drawDataElement.buffers) { 4393da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto buffer_node = getBufferNode(my_data, buffer); 4394da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (buffer_node) { 4395da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes buffer_node->in_use.fetch_sub(1); 4396da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4399da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 4400da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4401da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes set->in_use.fetch_sub(1); 4402da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4404da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto event : pCB->events) { 4405da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto eventNode = my_data->eventMap.find(event); 4406da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (eventNode != my_data->eventMap.end()) { 4407da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes eventNode->second.in_use.fetch_sub(1); 4408da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4410da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto event : pCB->writeEventsBeforeWait) { 4411da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto eventNode = my_data->eventMap.find(event); 4412da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (eventNode != my_data->eventMap.end()) { 4413da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes eventNode->second.write_in_use--; 4414da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4416da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto queryStatePair : pCB->queryToStateMap) { 4417da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 4418da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4419da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto eventStagePair : pCB->eventToStageMap) { 4420da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4421c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4422c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4423da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 4424da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto semaphore : submission->semaphores) { 4425da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes auto pSemaphore = getSemaphoreNode(my_data, semaphore); 4426da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes if (pSemaphore) { 4427da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 4428da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4431a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4432a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4433b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4434b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4435ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis std::vector<std::pair<VkFence, FENCE_NODE *>> fence_pairs; 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 4437accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes auto pFence = getFenceNode(my_data, pFences[i]); 4438cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (!pFence || pFence->state != FENCE_INFLIGHT) 4439cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes continue; 4440cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4441cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_pairs.emplace_back(pFences[i], pFence); 4442cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_RETIRED; 4443cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 4444accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes decrementResources(my_data, static_cast<uint32_t>(pFence->priorFences.size()), 4445accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.data()); 4446accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes for (auto & submission : pFence->submissions) { 4447651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4448da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission.cbs) { 4449da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, cb); 4450da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes removeInFlightCmdBuffer(my_data, cb); 4451da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4453accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->submissions.clear(); 4454accf816d3b205bb36a9a32ed8c278e45e8e0d188Chris Forbes pFence->priorFences.clear(); 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4456ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis for (auto fence_pair : fence_pairs) { 44576bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis for (auto queue : fence_pair.second->queues) { 4458df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pQueue = getQueueNode(my_data, queue); 4459df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (pQueue) { 44606bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto last_fence_data = 4461df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes std::find(pQueue->lastFences.begin(), pQueue->lastFences.end(), fence_pair.first); 4462df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes if (last_fence_data != pQueue->lastFences.end()) 4463df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes pQueue->lastFences.erase(last_fence_data); 44646bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 4465bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4466be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine for (auto& fence_data : my_data->fenceMap) { 4467be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine auto prior_fence_data = 4468be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine std::find(fence_data.second.priorFences.begin(), fence_data.second.priorFences.end(), fence_pair.first); 4469be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine if (prior_fence_data != fence_data.second.priorFences.end()) 4470be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine fence_data.second.priorFences.erase(prior_fence_data); 4471be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine } 4472bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4473b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4475a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4476b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4477b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 4480651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto & submission : queue_data->second.untrackedSubmissions) { 4481651d92815dfff917308137bb67aacccc4f60df86Chris Forbes decrementResources(my_data, &submission); 4482da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes for (auto cb : submission.cbs) { 4483da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes skip_call |= cleanInFlightCmdBuffer(my_data, cb); 4484da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes removeInFlightCmdBuffer(my_data, cb); 4485da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4487651d92815dfff917308137bb67aacccc4f60df86Chris Forbes queue_data->second.untrackedSubmissions.clear(); 4488b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4489b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 44900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4491b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 44920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 44930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4494b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4495b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4496b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4497b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4498e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 44990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 45000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 45010a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4502a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pQueue = getQueueNode(dev_data, queue); 4503a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pOtherQueue = getQueueNode(dev_data, other_queue); 4504a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (!pQueue || !pOtherQueue) { 45050a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 45060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4507a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto fenceInner : pOtherQueue->lastFences) { 4508a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->lastFences.push_back(fenceInner); 4509a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pFenceInner = getFenceNode(dev_data, fenceInner); 4510a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (pFenceInner) 4511a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pFenceInner->queues.insert(other_queue); 45120a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 45134b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // TODO: Stealing the untracked CBs out of the signaling queue isn't really 45144b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // correct. A subsequent submission + wait, or a QWI on that queue, or 45154b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // another semaphore dependency to a third queue may /all/ provide 45164b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // suitable proof that the work we're stealing here has completed on the 45174b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // device, but we've lost that information by moving the tracking between 45184b5d5254c68655201f38090ea6e8ff83700d3604Chris Forbes // queues. 4519a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes auto pFence = getFenceNode(dev_data, fence); 4520a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes if (pFence) { 4521a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto submission : pOtherQueue->untrackedSubmissions) { 4522a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pFence->submissions.push_back(submission); 45230a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4524a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pOtherQueue->untrackedSubmissions.clear(); 45250a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 4526a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto submission : pOtherQueue->untrackedSubmissions) { 4527a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->untrackedSubmissions.push_back(submission); 45280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4529a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pOtherQueue->untrackedSubmissions.clear(); 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4531a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto eventStagePair : pOtherQueue->eventToStageMap) { 4532a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->eventToStageMap[eventStagePair.first] = eventStagePair.second; 4533b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 4534a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes for (auto queryStatePair : pOtherQueue->queryToStateMap) { 4535a9a689bef49d3e7e4c3e814099009f6bf2747ddfChris Forbes pQueue->queryToStateMap[queryStatePair.first] = queryStatePair.second; 4536d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4539b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 4540b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 4541b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 4542b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 4543b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 4544b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 4545b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 4546b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 4547651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4548651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4549651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4550651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4551651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 4552651d92815dfff917308137bb67aacccc4f60df86Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence) 4553651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4554651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->priorFences.size()); 4555651d92815dfff917308137bb67aacccc4f60df86Chris Forbes assert(!pFence->submissions.size()); 4556651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4557651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->priorFences, pQueue->lastFences); 4558651d92815dfff917308137bb67aacccc4f60df86Chris Forbes std::swap(pFence->submissions, pQueue->untrackedSubmissions); 4559651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4560651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pFence->queues.insert(pQueue->queue); 4561cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 4562651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4563651d92815dfff917308137bb67aacccc4f60df86Chris Forbes pQueue->lastFences.push_back(pFence->fence); 4564b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4565b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 457227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4573414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 458083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 45810a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 45820a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 458383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 458483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis 0, __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 458583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 458683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 458783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 45880a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4593e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4594e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4595e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4596e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4597e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 459983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4602e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4603e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4604e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 460783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4610414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 461483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4617da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 461983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4620a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4621a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 4622a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 462383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 4624a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 462583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 4626a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 463083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 46314c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 46324c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4635414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4637414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 46384c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4644a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 464583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB); 4646a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 464783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 465081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4651651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 465281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 465383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 465481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4655651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4656cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 465783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 465883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 465983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4660a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 466181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4662cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 466383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 466483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 466583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 466683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 466783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 4668a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 467081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 467183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 467281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 467381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4674651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 467581c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 467681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 467783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 467881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 467981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 468081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 468181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4682651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4683651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 468483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 468581c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 468683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 4687d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4688d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4689d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 46901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 46911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 46921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4693651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4694651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4695651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4696651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 4697651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4698651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4699651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // If a fence is supplied, all the command buffers for this call will be 4700651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // delimited by that fence. Otherwise, they go in the untracked portion of 4701651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // the queue, and may end up being delimited by a fence supplied in a 4702651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // subsequent submission. 4703651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto & submitTarget = pFence ? pFence->submissions : pQueue->untrackedSubmissions; 4704651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 47060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 471101a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 471201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 471341bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 471401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 471501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 471601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 4717da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 47181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 471983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 47211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4722414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 47231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 47241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 472501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkQueue other_queue = pSemaphore->queue; 47261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 47271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 47281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 47291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 473301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 473401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 473501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 47361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 473701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 473883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 47401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4741414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4742414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 47431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 4744da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->queue)); 47451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 474601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 474701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->queue = queue; 4748da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 47491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 47500a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4752651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4753da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 4754da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4756971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 475783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 47581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 4759da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 4760651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 4761da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 4762651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4763651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 47641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 476583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, pCBNode); 47661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 47671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 476883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 47691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 47701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 477183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 47721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4773d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 477483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 4775d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 47761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4778da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 4779da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes submitTarget.emplace_back(cbs, semaphoreList); 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4781b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 478283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 478889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 478989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4793b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 47950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 47965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 479989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 480089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 48075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 48085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4810b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 481174243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller bool skip_call = freeMemObjInfo(my_data, device, mem, false); 48120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 48130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4814b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 481574243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller if (!skip_call) { 481674243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 481774243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 482183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 482483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 482583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 482683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 483157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 483357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.size != 0) { 483483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 483583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 483683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 484157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (offset >= mem_info->allocInfo.allocationSize) { 484283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 484383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 484483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 484583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 484683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, mem_info->allocInfo.allocationSize, mem_info->allocInfo.allocationSize); 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 484957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((offset + size) > mem_info->allocInfo.allocationSize) { 485083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 485157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 485257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 485357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 485457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size + offset, mem_info->allocInfo.allocationSize); 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 485883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4861e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 486257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 486357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 486457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.offset = offset; 486557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = size; 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4869e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 487083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 487157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 487257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 487357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (!mem_info->memRange.size) { 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 487583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 487683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 487783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 487957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->memRange.size = 0; 488057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 488157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis free(mem_info->pData); 488257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 488583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 48865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 48895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4890b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 489157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 489257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 489357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pDriverData = *ppData; 489457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis uint32_t index = mem_info->allocInfo.memoryTypeIndex; 4895b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 489657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = 0; 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 489957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis size = mem_info->allocInfo.allocationSize; 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 490257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->pData = malloc(2 * convSize); 490357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memset(mem_info->pData, NoncoherentMemoryFillValue, 2 * convSize); 490457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis *ppData = static_cast<char *>(mem_info->pData) + (convSize / 2); 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4908a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 4909a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 4910a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 491149f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 491283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 49139b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 491449f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 49159b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 4916cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 491783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 491883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 491983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 492083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 492183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 492483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4926a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 492789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 492889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4930e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 4932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 493449f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4936b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 49385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4939a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 4941414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 4946b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 4951b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4953e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 496083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4961b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 496283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 4963b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4964a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 496583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 496683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4967a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 496883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 4969b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 497183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= decrementResources(dev_data, 1, &fence); 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4974e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 497989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 4980b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 4983b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 4984b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 4985b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 4986b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 4987b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 4988b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 49898988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 4990b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 4991b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 49925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 499489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 49955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 4996e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4997b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 4998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 49995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 50025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 500489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5005e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 50065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5007b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 5009b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 5012b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5013e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 501989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 502183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5022b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 50231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 50241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5025cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 502683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 502783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 502883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 50291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 50315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5032b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 503483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 503889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 503989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5041e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5042e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 50475c2563284eeaaa37c12558fd541e2416fe618a38Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5048414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5052e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5053e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 505689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5059b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 50609556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 50619556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 5062e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (event_node->in_use.load()) { 5063ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis skip_call |= log_msg( 5064ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 5065833764b21e2893b6ea057fe211c220ec6a83d09cTobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5066ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 5067e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 50689556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis // Any bound cmd buffers are now invalid 50699556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis invalidateCommandBuffers(event_node->cb_bindings, 50709556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}); 50719556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis dev_data->eventMap.erase(event); 50729556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 5073e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5074e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (!skip_call) 5075e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 50765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 507889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 507989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5080ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5081d71203a8c706f522fca32399d5459a031250b83cTobin Ehlis // TODO : Add detection for an in-flight queryPool 5082ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5083ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5084ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5085ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5086ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, 5087ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}); 5088ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5089ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5090e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5091e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 50925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 509489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 509589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 509689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5101971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 51035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 51045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 51075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5112ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5113ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5114ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5115ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5116971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5117ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5118ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5119ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5120ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5121414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5122ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5123ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5124ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5125ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5126ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5127ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5128ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5129ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5130ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5131ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5132ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5133ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5134ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5135971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5136ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5137ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5138ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5141414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5144ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5145ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5148414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5150ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5151ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5152ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5153ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5154414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5155ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5156ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5160b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5168e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 51698718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 51708718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5173414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 51758718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 51765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5178414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 518447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 518547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 518647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 518747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5188414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Buffer 0x%" PRIx64 " is aliased with image 0x%" PRIx64, object_handle, 518947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 519047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } else { 519147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 5192414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Image 0x%" PRIx64 " is aliased with buffer 0x%" PRIx64, object_handle, 519347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 519447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 519547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 519647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 519747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 519847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 519947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski bool skip_call = false; 520047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 520147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (auto range : ranges) { 520247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 520347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 520447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 520547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 520647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 520747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 520847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 520947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 521047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return skip_call; 521147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 521247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 521347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic MEMORY_RANGE insert_memory_ranges(uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 521447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges) { 521547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski MEMORY_RANGE range; 521647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 521747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.memory = mem; 521847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 521947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 522047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.push_back(range); 522147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return range; 522247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 522347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 522447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic void remove_memory_ranges(uint64_t handle, VkDeviceMemory mem, vector<MEMORY_RANGE> &ranges) { 522547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (uint32_t item = 0; item < ranges.size(); item++) { 522647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((ranges[item].handle == handle) && (ranges[item].memory == mem)) { 522747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.erase(ranges.begin() + item); 522847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski break; 522947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 523047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 523147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 523247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 523389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 523489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52375a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5238e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5239e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5240e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5241e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5242e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5243e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5244e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->mem); 5245e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5246e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(buffer), buff_node->mem, mem_info->bufferRanges); 5247e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5248e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5249e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5250e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5251b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 525347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 525789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5259e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5260e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5265e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5266e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 526989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5272e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 527399df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto img_node = getImageNode(dev_data, image); 527499df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis if (img_node) { 527599df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis // Any bound cmd buffers are now invalid 527699df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis invalidateCommandBuffers(img_node->cb_bindings, 527799df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis {reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 527847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 527999df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, img_node->mem); 528057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 528199df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis remove_memory_ranges(reinterpret_cast<uint64_t &>(image), img_node->mem, mem_info->imageRanges); 528247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 528357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis mem_info->image = VK_NULL_HANDLE; 528447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 528558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 528699df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis dev_data->imageMap.erase(img_node->image); 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5295e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5296e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52994261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 53004261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 53014261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 53024261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski if (((1 << mem_info->allocInfo.memoryTypeIndex) & memory_type_bits) == 0) { 53034261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53044261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 53054261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 53064261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "type (0x%X) of this memory object 0x%" PRIx64 ".", 53074261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski funcName, memory_type_bits, mem_info->allocInfo.memoryTypeIndex, 53084261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski reinterpret_cast<const uint64_t &>(mem_info->mem)); 53094261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 53104261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 53114261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 53124261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 531389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 531489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 531558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5317b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 532083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 53218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 53228718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 532494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 53254bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->mem = mem; 53264bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memOffset = memoryOffset; 53274bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memSize = memRequirements.size; 532847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 532947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 533057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 533157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 533247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 533357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(buffer_handle, mem, memoryOffset, memRequirements, mem_info->bufferRanges); 533483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validate_memory_range(dev_data, mem_info->imageRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 533583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 533647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 533747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 53382c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 53392c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 534083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 53412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 53422c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5343414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5344414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 53452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 53462c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 53472c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5348ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 53492c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5350ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5351ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5352ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5353ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5354ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5355ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5356ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5357ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5358ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5359ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5360ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5361ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5362ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5363ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5364ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5365ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5366ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5367ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5368ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 53698718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5370ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5371ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5372ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5373ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5374ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5375ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5376ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5377ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5378ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5379ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5380ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 53812c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 53822c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5385b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 538683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 538758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 539289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 539389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 540089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 540189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5407593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 540889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 540989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 5410e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 541589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 541689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5417918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5418918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5419b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5420918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5421b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5422918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5423918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 542689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 542789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 5428a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5429e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Add detection for in-flight pipeline 5430e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5431a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis auto pipe_node = getPipeline(dev_data, pipeline); 5432a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) { 5433a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis // Any bound cmd buffers are now invalid 5434a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis invalidateCommandBuffers(pipe_node->cb_bindings, 5435a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}); 5436a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis dev_data->pipelineMap.erase(pipeline); 5437a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 5438e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5439e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 544289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 544389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 54446792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5445e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 54466792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 5447e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 5448e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5449e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 545389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 5455e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 545989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 5460e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 546589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 546689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 5467e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5471bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5472bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5473bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5474bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5475a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5476bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5477bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5478bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5479bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5480bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5481bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5482bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5483bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5484414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5485bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5486bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5487bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5488bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5489bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5490a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 5491bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5492a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 5493bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5494a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5495a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5496a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5497bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5498bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5499bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5500bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5502a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 5503a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5504a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 5505a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 5506a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 5507a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 550889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 550989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 55105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5512b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5513c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 55159f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 55179f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 55189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free"); 5519c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5520c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5521c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5522c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 5523c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 5524c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5525c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5526c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 55279f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 5528c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 55299f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 55309f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 55329f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 55339f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 55349f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 5538c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5542e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5543e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 554689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 554789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 554889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5554b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 556189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 556289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 55635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5567b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 557489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 557589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 557783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5578b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5580a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 558183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 558383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 55859f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 5586a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5587a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 5588a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 55899f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 55907165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 55917165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 55927165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 55939f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 55949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 5595a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 5596a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 5597a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 5598e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5599e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 560289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 560389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 560583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5606400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 56071ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 5608a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 560983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 56101ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 5611a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 561283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5615a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 56191ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 5620a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5621a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 5622a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56241ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 562989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 563183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5632b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 5634df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5635090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 563683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 563783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 563883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5641b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5642090da73358f71ba026e2474a822fecf55267d166Chris Forbes 564383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 5644090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5645090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5646090da73358f71ba026e2474a822fecf55267d166Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 5647090da73358f71ba026e2474a822fecf55267d166Chris Forbes 5648090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 5649090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 5650090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 5651090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 5652090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 5653090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 5654090da73358f71ba026e2474a822fecf55267d166Chris Forbes // TODO: these should really have already been enforced on 5655090da73358f71ba026e2474a822fecf55267d166Chris Forbes // INFLIGHT->RETIRED transition. 5656090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->queues.clear(); 5657090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->priorFences.clear(); 5658090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5659090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5660090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 5661090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 5662090da73358f71ba026e2474a822fecf55267d166Chris Forbes 56635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5666e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 5667e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 5668e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 5669e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 5670e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 5671e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 5672e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 5673e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 567489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 567589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5677b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5678d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 5679d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) { 5680e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis invalidateCommandBuffers(fb_node->cb_bindings, 5681e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis {reinterpret_cast<uint64_t &>(fb_node->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}); 5682d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis dev_data->frameBufferMap.erase(fb_node->framebuffer); 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5684b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 568889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 568989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5691e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 56937bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes // TODO: leaking all the guts of the renderpass node here! 5694e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5695e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 569889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 569989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 57005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 570147892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 570247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5705b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 5707b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57128c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 57138c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 57148c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 57158c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 5716b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 5717b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 5718cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 5719cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 5720b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= validateBufferUsageFlags(dev_data, buf_node, 5721b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 5722b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 5723b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 57248c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 57258c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 57268c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 572789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 572889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 57295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57308c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 57318c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 57328c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 57338c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 57348c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 57378c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 57382f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<VkBufferViewCreateInfo>(new VkBufferViewCreateInfo(*pCreateInfo)); 57398c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 574489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 574589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 574747892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 574847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5751b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 575529e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(*pImage, pCreateInfo)))); 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 5764b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57666d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 57676d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 57685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 57736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 57776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 57845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 5786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 57906d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 57916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 57936d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 57966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 57975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58018c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo) { 58028c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 58038c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young IMAGE_NODE *image_node = getImageNode(dev_data, pCreateInfo->image); 5804b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (image_node) { 5805b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= validateImageUsageFlags(dev_data, image_node, 5806b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 5807b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 5808b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 5809b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 5810b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_node, "vkCreateImageView()"); 5811bb6624cb996175d8945190886a200e720b3871efChris Forbes } 58128c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 58138c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 5814bb6624cb996175d8945190886a200e720b3871efChris Forbes 58158c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo, VkImageView *pView) { 58168c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young dev_data->imageViewMap[*pView] = unique_ptr<VkImageViewCreateInfo>(new VkImageViewCreateInfo(*pCreateInfo)); 58178c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[*pView].get()->subresourceRange, pCreateInfo->image); 58188c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 5819bb6624cb996175d8945190886a200e720b3871efChris Forbes 58208c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 58218c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 58228c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58238c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 58248c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateImageView(dev_data, pCreateInfo); 58258c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 58268c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 58278c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 58288c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 58308c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 58318c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young PostCallRecordCreateImageView(dev_data, pCreateInfo, pView); 58328c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 58335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5834bb6624cb996175d8945190886a200e720b3871efChris Forbes 58355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 583989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 58405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 58425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5844a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 58458988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 5846a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 5847cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 585389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 585489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 58555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 58575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 586189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 586789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 58705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 587489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 58755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 58775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 58813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 58823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 58833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 58843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 58853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 58863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 58873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 58883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 58893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 58903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 58913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 58923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 58933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 58943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 58953d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 58963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 58973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 58983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 58993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 59003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 590189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 590289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 590389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 590489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 59055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 59065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 59075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 59085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 59095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 591183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5917b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 5920ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5921ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 59228da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeNode[i]->render_pass_ci.initialize(getRenderPass(dev_data, pCreateInfos[i].renderPass)->pCreateInfo); 5923c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 592467220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 592583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 592883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 5929b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 59405188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5942b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 594889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 594989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 595089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 595189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 595383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5960b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5966ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 5967c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 5968ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 59695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 597183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], &dev_data->phys_dev_properties.features, 597283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 597383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 597683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 5977b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5980b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5985b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 59875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5991b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 599789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 599889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6002b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6003cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 600889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 600989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 601089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 60135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 6015b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6016cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 6017cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 60239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 60249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 60259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 60269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 602783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 60289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 60299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 60309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 60319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 60329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 603383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 60349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 60359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 60369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 60379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 60389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 603983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 604083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 604183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 604283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 60439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 604483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 604583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 60469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 60479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 60489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 60499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 60509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 605183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 60529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 60539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 60549e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 60559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 60569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 605783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 60589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 60599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 60609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 60619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 60629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 606383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 606483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 60659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 60669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 60679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 60689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 60699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 607083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 607183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 607283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 607383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 60749e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 607583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 607683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 607783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 607883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 60799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 608083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 608183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 60829e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 608483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 608789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 608889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 608983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 609483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 609583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 60969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 609783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 609883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 60999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 61009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 61019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 610283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 61039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 61049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 61059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 61069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 61079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 61089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 61099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 61109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 611183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6112a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 61139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 61149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 61159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 61169e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 61179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6120f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 612183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6122f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6123f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6126b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 612869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6129416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6131416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6133416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6135416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 614189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 614289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 614389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6149414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6159b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 616889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 616989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6173b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61782c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6179789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6180789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 61817f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 61827f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 61837e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6184e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 61857e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 61867e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 61877e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 61887f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 61897f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 61907e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 61912c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6192b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 61932c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 61942c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 619589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 619689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6198b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61997f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 62007f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6201b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6202d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 62037e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6205d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 62076511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6209b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 62107f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6211b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6215cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6216cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6217cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6218cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6219cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6220cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6221cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6222cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6223cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6224cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6225cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6226cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6227cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6228cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6229cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6230cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6231cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6232cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6233cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6234cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6235cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6236cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6237cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6238cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6239cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6240cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6241cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6242cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6243cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6244cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6245cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6246cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6247cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6248cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6249cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6250cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6251cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6252cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 625489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 625589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6258b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 625983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6260b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6261e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 626283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6266b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6267cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6268b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62726b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 62736b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 62746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 62756b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 62766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 62776b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 62786b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 62796b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 62806b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 62816b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 62826b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 62836b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 62846b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 62856b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6286104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6287104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 62886b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 62896b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 62906b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 62916b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 62926b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6293104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 62946b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 62956b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 629789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 629889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 629989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 63006b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6302b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63036b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 63046b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6305b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63066b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 63096b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 63106b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 63116b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 63126b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 631689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 631789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 63205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6321b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6322cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 6323cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 6324cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 632572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 6327cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 63325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63360a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6337b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 634289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 634389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 634483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6346b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6351a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 635283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6353a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6354a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6355414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6356a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6357a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6359a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 636483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6367414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6371400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 637283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 63745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6375414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6378400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 637983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 638083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 638183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 638283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 638383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 638483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6387f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6388f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6389a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 6390a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 6391a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis getRenderPass(dev_data, pInfo->renderPass)->pCreateInfo, 6392a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 6393400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 639483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6395a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6396a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 6397a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 6398a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 6399a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6400a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 6401a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 6402a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 6403a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6406b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis framebuffer->cb_bindings.insert(pCB); 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6411b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 641383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 641483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 641583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 641683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 641783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 641883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 641983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 642316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 642416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 642516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 642683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 642783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 642883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 642983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 643083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 643183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 643783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6440414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 64437651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else if (CB_RECORDED == pCB->state || (CB_INVALID == pCB->state && CMD_END == pCB->cmds.back().type)) { 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6445cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6446cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 644783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6450414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6463888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6464888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6465888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 646616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = getRenderPass(dev_data, pCB->beginInfo.pInheritanceInfo->renderPass); 6467888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6468888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6469888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 647283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 647383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 647483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6476b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 647783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6481400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 648589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 648683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6489b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6492fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6493fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6494fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 649583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6496fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 649783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 649983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 650083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 650183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 650283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 650583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6506b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6508b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6518b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 652289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 652389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6524bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6526b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6529cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6530cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 6531bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6532bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6533414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6534bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6535bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6537a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 6538b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6539bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6543b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6544a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6546b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 655093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 655189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 655289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 655383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6555b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 655883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 656083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6563414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6564ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 656972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 65705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 65713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 657383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 657483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 657583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6577a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis addCommandBufferBinding(&getPipeline(dev_data, pipeline)->cb_bindings, 6578a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, pCB); 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6580b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 658183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 658589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 658689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 658783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6589b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 659283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 65965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6597b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 659883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 660289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 660389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 660483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6606b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 660983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 66135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6614b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 661583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 661989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6620a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6622b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6625a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6627a27508babf63d50aea75883a3702979193c23683Mark Young 6628a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6629a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6630a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6631a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6632386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6633a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6634a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6635a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6636a27508babf63d50aea75883a3702979193c23683Mark Young } 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6638b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6639a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 664389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 664489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 664583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6647b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 665083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6653b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 665483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 66565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 665989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 666083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6662b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 666583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 66663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6668b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 666983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 667389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 667489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 667583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6677b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 668083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6683b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 668483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 668889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 668989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 669083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6692b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 669583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6698b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 669983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 670389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 670489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 670583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6707b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 671083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 671483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 671889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 671989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 672083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6722b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 672583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6728b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 672983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 673389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 673489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 673589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 673689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 673783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6739b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 6743787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 6744787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 6745787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 6746787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 6747dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 674872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 6749dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 6750dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 675171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 675269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 6753787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 6754397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 6755787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 675671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pSet); 67579d17becd811b49e1ecf91a02eee22f9cf7cbc026Tobin Ehlis pSet->BindCommandBuffer(pCB); 675869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 675971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 676083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 676183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 676283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 676383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 6764397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 676583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 676683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 676783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 676883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "DS 0x%" PRIxLEAST64 676983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 677083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6771787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6772787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 677369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 677483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 677583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 677683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 677783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 677883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 677983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 6780787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6781dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6782dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 6783dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6784dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 6785dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6786dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 6787787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 6788dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 678983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6790787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6791787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6792787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6793414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 6794787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 6795787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 6796397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 6797787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 6798787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 6799787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 6800787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 6801397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 6802397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 6803787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6804787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6805b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 680683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6807787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6808787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6809787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 6810787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6811414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 6812787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6813b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 6814787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6815787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 6816397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 6817787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6818787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6819b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 682083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6821787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6822787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6823787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 6824787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6825414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 6826787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6827b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6829787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6832dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6833dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 6834dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 6835dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 6836787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 6837dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 6838dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6841787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 684283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 684383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 684483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 684583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 684783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 684872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 684972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 685072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 685172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 685271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 685369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 685483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 685572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 685672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 685772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 6858414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 6859414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 686072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 686172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 686272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 686372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 686472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 686572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 686672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 686772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 686869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 686971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 687083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 687172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 687271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 6873414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 6874414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 687572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 6876414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 687771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 687872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 687972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 688072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6884787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 6885787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 688683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 688783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 688883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 688983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 689083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 689183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 6892787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 689483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6897b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 689883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 690389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 690489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 690583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6907593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 6908b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6909b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 6910ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 69119f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 6912ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 6913b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 6914ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 6915ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_memory_is_valid(dev_data, buff_node->mem, "vkCmdBindIndexBuffer()"); 6916ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 69179f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 691883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 693283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 693383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 693483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 693583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69379f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 6938ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 6939ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6941b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 694283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6956e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 695889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 695989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 696089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 696183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6963593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 6964b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6965b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 69669f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 69679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 6968593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 6969ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 6970ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 6971b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 6972ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 6973ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_memory_is_valid(dev_data, buff_node->mem, "vkCmdBindVertexBuffers()"); 6974ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 69759f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69779f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 69789f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 698083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6982b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 698383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6987b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 6988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 69907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 69917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 69922c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_data = getImageViewData(dev_data, imageView); 69932c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!iv_data) 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 6995249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 6996249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, iv_data->image); 6997249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(img_node); 6998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 6999249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, img_node->mem, true, iv_data->image); 7000e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 70027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 70037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 70047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7005ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7006ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7007e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7008ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, buff_node->mem, true); 7009e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 70117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 701689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 701789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 701883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7020b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 702383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 702583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 702683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 702883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7030414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 703183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 703283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 703583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7037b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 703883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 704289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 704389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 704683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 705083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 705283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 705383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 705583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 705683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 705783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 705883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 705983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 706283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7064b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 706583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 707089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 707189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 707383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7074b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7075ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7076ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7077ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7078ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7079b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7080b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, buff_node, "vkCmdDrawIndirect()"); 7081ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7082ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7083ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 7084ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 708683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 708783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 708883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 708983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 709083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7091ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 70925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7093b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7094ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7095ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7097b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 709883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 710289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 710389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 710483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7106b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7107ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7108ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7109ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7110ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7111b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 7112b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, buff_node, "vkCmdDrawIndexedIndirect()"); 7113ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 7114ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 7115ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 7116ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 711883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 712283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 712383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7124ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7126b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 7127ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7128ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 713183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 713589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 713683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7138b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 714183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 714283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 714383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 714483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7146b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 714783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 71495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 715189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 715289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 715383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7155b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7156ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7157ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7158ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7159b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 7160b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 7161b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, buff_node, "vkCmdDispatchIndirect()"); 7162ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE); 7163ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 7164ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 7165b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7167b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 716883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 71705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 717289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 717389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 717483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7176b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7177ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 71789f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7179ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7180ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7181ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 7182b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7183b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 7184ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 7185b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node, "vkCmdCopyBuffer()"); 7186b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node, "vkCmdCopyBuffer()"); 7187ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 7188ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 7189ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7190ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 7191ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7192ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7193ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7194ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_memory_is_valid(dev_data, src_buff_node->mem, "vkCmdCopyBuffer()"); 7195ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 71969f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7197593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7198ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, dst_buff_node->mem, true); 7199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 72019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7202593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 720383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7204b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 7205ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7206ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 7207ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7209b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 721083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 721427e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 721527e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 7216e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 72175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 72215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 722227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 722327e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 72255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 72275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 72285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 72325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 72335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 72365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 723707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 723807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, srcImage); 723907b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 724007b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 724107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 724207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 724307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 724407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725527e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 725627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 7257e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 726327e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 726427e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 72665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 727707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, destImage); 727807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 727907b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 728007b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 728107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 728207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 728307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 72875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 729489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 729589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 729689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 729783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7299b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7300249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 73019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7302249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7303249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7304249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7305b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImage()"); 7306b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyImage()"); 7307249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7308b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, src_img_node, "vkCmdCopyImage()"); 7309b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, dst_img_node, "vkCmdCopyImage()"); 7310249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 7311249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, src_img_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 7312249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7313249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, dst_img_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 7314249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7315e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7316249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_memory_is_valid(dev_data, src_img_node->mem, "vkCmdCopyImage()", srcImage); 7317593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 73189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7319593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7320249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, dst_img_node->mem, true, dstImage); 7321e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 73239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7324593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 732583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7326b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 732827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 732927e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7331249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7332249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7334b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 733583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 734089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 734189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 734289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 734383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7345b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7346593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 73479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7348249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7349249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7350249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7351b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdBlitImage()"); 7352b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdBlitImage()"); 7353249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7354b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, src_img_node, "vkCmdBlitImage()"); 7355b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, dst_img_node, "vkCmdBlitImage()"); 7356249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 7357249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, src_img_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 7358249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7359249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, dst_img_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 7360249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7361e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7362249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_memory_is_valid(dev_data, src_img_node->mem, "vkCmdBlitImage()", srcImage); 7363593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 73649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7365593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7366249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, dst_img_node->mem, true, dstImage); 7367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 73699f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7370593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 737183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7372b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 7373249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7374249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7376b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 737783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 738289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 738389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 738489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 738583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7387b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7388593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 73899f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7390ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7391249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7392249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_buff_node && dst_img_node) { 7393b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 7394b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyBufferToImage()"); 7395b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node, "vkCmdCopyBufferToImage()"); 7396b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, dst_img_node, "vkCmdCopyBufferToImage()"); 7397ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 7398ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7399249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, dst_img_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7400249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7401e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7402249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, dst_img_node->mem, true, dstImage); 7403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 74059f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7406ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis function = [=]() { return validate_memory_is_valid(dev_data, src_buff_node->mem, "vkCmdCopyBufferToImage()"); }; 74079f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7408593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 740983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7410b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 741227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7414ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7415ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7417b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 741883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 742389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 742489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 742589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 742683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7428b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7429593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 74309f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7431249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7432ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7433249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_buff_node) { 7434b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 7435b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 7436249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 7437b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, src_img_node, "vkCmdCopyImageToBuffer()"); 7438b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node, "vkCmdCopyImageToBuffer()"); 7439249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 7440249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validateImageUsageFlags(dev_data, src_img_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 7441249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7442ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7443ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7444e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7445249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_memory_is_valid(dev_data, src_img_node->mem, "vkCmdCopyImageToBuffer()", srcImage); 7446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 74479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7448593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7449ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, dst_buff_node->mem, true); 7450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 74529f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7453593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 745483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 7455b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 745727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7459ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7460ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7462b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 746383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 746889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 746989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 747083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7473593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 74749f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7475ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7476ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 7477b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 7478ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 7479b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node, "vkCmdUpdateBuffer()"); 7480ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 7481ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 7482ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7483e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7484ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, dst_buff_node->mem, true); 7485e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 74879f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7488593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 748983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 7490b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 7491ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7492ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7494b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 749583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 749989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 750089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 750183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7503b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7504593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 75059f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7506ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7507ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 7508b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 7509ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 7510b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node, "vkCmdFillBuffer()"); 7511ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 7512ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 7513ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7515ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, dst_buff_node->mem, true); 7516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 75189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7519593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 752083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 7521b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 7522ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7523ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7525b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 752683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 753089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 753189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 753289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 753383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7535b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 753883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 754783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 754883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 754983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 755083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 755183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7553b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7558ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7567e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 757283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 758383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7595b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 759683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 760089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 760189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 760289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 760383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7605b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 7607249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 76089f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7609249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 7610249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 7611b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearColorImage()"); 7612b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, img_node, "vkCmdClearColorImage()"); 7613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7614249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, img_node->mem, true, image); 7615e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 76179f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7618593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 761983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 7620b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 7621249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7622249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7624b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 762583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 762989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 763089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 763189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 763289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 763383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7635b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 7637249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 76389f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7639249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 7640249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 7641b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearDepthStencilImage()"); 7642b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, img_node, "vkCmdClearDepthStencilImage()"); 7643e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7644249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, img_node->mem, true, image); 7645e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 76479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7648593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 764983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 7650b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 7651249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7652249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7654b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 765583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 766089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 766189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 766289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 766383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7665b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7666593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 76679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7668249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7669249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7670249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7671b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdResolveImage()"); 7672b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdResolveImage()"); 7673249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7674b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, src_img_node, "vkCmdCopyImage()"); 7675b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingImage(dev_data, cb_node, dst_img_node, "vkCmdCopyImage()"); 7676e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7677249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_memory_is_valid(dev_data, src_img_node->mem, "vkCmdResolveImage()", srcImage); 7678593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 76799f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7680593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7681249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis set_memory_valid(dev_data, dst_img_node->mem, true, dstImage); 7682e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 76849f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7685593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 768683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 7687b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 7688249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7689249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7691b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 769283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7697b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7698b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7699b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7700b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 7701b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 7702b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7703b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7704b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 7705b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 7706b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7707b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 7708b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7709b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 771089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 771189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 771283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7714b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 771783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 771883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 7719ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 7720ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 7721ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 7722ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 7723ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 7724ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7726c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7727c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7728c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7729b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7730b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 7731b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7733b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 773483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 773889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 773989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 774083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7742b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 774583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 774683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 7747ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 7748ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 7749ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 7750ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 7751ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 7752ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7754c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7755c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7756c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7757b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7758b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 7759b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7761b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 776283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7766e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7767e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 77685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 77695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 7770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 778908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 779008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 78065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 7809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 7831e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7832e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 7833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 7834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 783743986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7841577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 78466044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 78495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 78525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 78545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 78555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78596044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 78635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7871e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 7872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 78735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 78855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 78955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 78995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 79005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7911577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7922e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7923e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 7924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 7925e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 7926e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 79275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 7930ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 79396d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 79406d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 79436d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 7968b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 7969b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 7977b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79936d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 79941d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 79951d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 79976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 79986d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 79996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 80006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 8003170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 8004170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 8005b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 8006b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 8007b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 8008b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 80205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8024f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8025f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8026f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8027f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8035f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8036f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8037f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8038f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 80525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 80585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8061b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8063b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 80665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8069b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80728718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 80738718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 80740c6dd4dd7c7e444efc979299f8f445fb4fc4febeChris Forbes auto buffer_size = buffer_node->memSize; 80755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 807694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 807794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 807894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 8079414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 808094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 808194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 808394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 808494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8085414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 8086414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 808794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 808894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 808994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80962ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8097b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8098b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8099b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8100b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 81012ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8102b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8103b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8104b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 81052ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8106b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8107b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8108b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 81099556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 81109556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 8111b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 811227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 811327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 81142ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8115b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 81169556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 8117b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8118b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8119b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8120c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 8121c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 8122c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 8123c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8124c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 81254261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 8126c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 8127c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 81284261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 8129c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 8130b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8131b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8132b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8133b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 813489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 813589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 813689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 813789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 813889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 813983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8141b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81442ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 8146ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, pEvents[i]); 8147ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8148ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8149ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 8150ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 8151ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8152ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 8153c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8156b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 81572ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8158b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 816083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 816283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 816483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 816583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8169b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 817083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 81725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 81745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 817689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 817789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 817889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 817989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 818089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 818183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8183b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 818683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 818783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 818883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8192b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 819383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8199d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 8200d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8201d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8202d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 8203d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 8204d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8205d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8206d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 8207d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 8208d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8209d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8210d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8211d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 821289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 821389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 821483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8216b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 822483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 8225ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8226ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8228b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 822983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 823389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 823483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 824183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8243414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8248c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8249d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 825183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 825383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8255ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8256ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8258b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 825983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 826389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 826489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 826583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8267b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 8273c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 8274d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 827783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 827983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 828183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 8282ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8283ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 828683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8290d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 8291d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 8292d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 8293d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8294d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 8295d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8296d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 8297d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 8298d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 8299d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 8300d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 8301d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 8302d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8303d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8304d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8305d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 8306d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 8307d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 8308d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8309d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8310d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8311d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8312d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8313d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8314d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8315d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8316d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8317d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8318d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8319d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8320d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8321d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8322d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8323d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 832489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 832589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 832689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 832783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8329b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8330ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 83319f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8332ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8333ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8334b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 8335ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8336b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= addCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 8337ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 8338ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= validateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8339ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8340e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8341ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis set_memory_valid(dev_data, dst_buff_node->mem, true); 8342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 83449f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8345d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8346ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 8347ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 8348ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 8349ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 835183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8353b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 8354ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8355ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 8356ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8357ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8359b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 836083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 836589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 836689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 836789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 836883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8370b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 837483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 837683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 837983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 83809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 838183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 838283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 83839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 83849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8385a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 83864a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 838715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 838815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 838915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 839015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 839115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 839215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 839315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 839415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 839515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 839615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 839715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 839815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 839915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 840015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 840115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 840215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 840315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 840415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 840515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 840615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 840715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 840815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 84099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 841015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 841115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 841215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 841315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 841415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 841515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 841615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 841715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 841815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 841915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 842015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 842115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 842215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 842315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 842415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 842515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 842615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 842715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 842815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 842915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 843015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 84319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 84329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8433a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 843415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 843515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 843615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 843715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 843815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 843915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 8440a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 84419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 844215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 844315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 844415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 844515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 844615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 844715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 844815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 844915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8451b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 845283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 845689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 845789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 845883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8460b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 8464c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8465d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 846783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 846983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 847383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84776600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 84786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 84796600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 84806600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 84816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 84826600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 84836600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 84846600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 84856600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 84866600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VkImageViewCreateInfo *ivci = getImageViewData(dev_data, *image_view); 84876600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ivci != nullptr) { 84886600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 84896600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 84906600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 84916600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 84926600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 84936600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 84946600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 84956600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 84966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 84976600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 84986600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 84996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 85006600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 85016600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 85026600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 85036600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 85046600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8505d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 8506d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 85075ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 85085ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 85095ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 85105ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 85115ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 85125ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 85136fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 8514d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 85156600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 85166600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 8517d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis auto rp_node = getRenderPass(dev_data, pCreateInfo->renderPass); 8518d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rp_node) { 8519d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis const VkRenderPassCreateInfo *rpci = rp_node->pCreateInfo; 8520d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 8521d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 8522d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 8523d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 8524d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 8525d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 8526d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 85275ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 852841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 85295ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 85305ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 85315ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis VkImageViewCreateInfo *ivci = getImageViewData(dev_data, image_views[i]); 85325ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->format != rpci->pAttachments[i].format) { 85335ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 85345ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 85355ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 85365ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 85375ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 85385ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 85395ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis i, string_VkFormat(ivci->format), string_VkFormat(rpci->pAttachments[i].format), 85405ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 85415ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 85425ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci->image)->createInfo; 85435ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 854441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 854541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 854641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 854741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 854841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 854941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 855041ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 85515ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 85525ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 85535ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ivci->subresourceRange.levelCount != 1) { 85546fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 85556fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 85566fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 85576fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 85586fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis i, ivci->subresourceRange.levelCount); 85595ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 85605ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const uint32_t mip_level = ivci->subresourceRange.baseMipLevel; 8561aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 8562aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 8563aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if ((ivci->subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 8564aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 8565aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 85666fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 8567aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 8568aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 8569aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 8570aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 8571aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 8572aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 8573aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 8574aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 8575aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 8576aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis i, ivci->subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 8577aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis pCreateInfo->height, ivci->subresourceRange.layerCount, pCreateInfo->layers); 85785ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 8579aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis if (((ivci->components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.r != VK_COMPONENT_SWIZZLE_R)) || 8580aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.g != VK_COMPONENT_SWIZZLE_G)) || 8581aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.b != VK_COMPONENT_SWIZZLE_B)) || 8582aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis ((ivci->components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci->components.a != VK_COMPONENT_SWIZZLE_A))) { 8583da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 85846fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 8585da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 8586da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 8587da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 8588da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 8589da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 8590da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 8591da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 8592da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis i, string_VkComponentSwizzle(ivci->components.r), string_VkComponentSwizzle(ivci->components.g), 8593da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis string_VkComponentSwizzle(ivci->components.b), string_VkComponentSwizzle(ivci->components.a)); 85945ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 85955ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 8596d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 85975ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 85986600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 85996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 86006600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 86016600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 86026600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 86036600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 86046600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 86056600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 86066600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 86076600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 86086600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 86096600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 86106600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 8611d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 8612d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 8613d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 8614d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 8615d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 8616d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 86176600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 86186fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 86196fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 86206fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 86216fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 86226fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 86236fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 86246fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 86256fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 86266fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 86276fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 86286fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 86296fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 86306fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 86316fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 86326fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 86336600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 86346600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 86356600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 863664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 863764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 863864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 863964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 864064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 864164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 8642d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 864364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 864464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 864564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 864654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 864754e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 864854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 864976f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis std::unique_ptr<FRAMEBUFFER_NODE> fb_node( 8650d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis new FRAMEBUFFER_NODE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->pCreateInfo)); 865176f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 865254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 865354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 865454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis auto view_data = getImageViewData(dev_data, view); 865554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis if (!view_data) { 865654e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 865754e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 865854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 8659249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis fb_info.mem = getImageNode(dev_data, view_data->image)->mem; 866054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis fb_info.image = view_data->image; 866176f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis fb_node->attachments.push_back(fb_info); 866254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 866376f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_node); 866454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 866554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 866689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 866789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 866889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 867064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 867164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 867264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 867364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 867464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 867564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 867664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 867764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 86786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 868064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 868154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 868254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8687e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8691e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8698e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8701e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8706e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8707e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8708e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 87111d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 87187655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 87207655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 87217655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8726e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8734e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8740e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8744e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8746e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8757e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8761e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8781f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 878216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 8783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 878404861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 878516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 878616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88002c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_i = getImageViewData(my_data, viewi); 88012c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto view_data_j = getImageViewData(my_data, viewj); 88022c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (!view_data_i || !view_data_j) { 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88052c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (view_data_i->image == view_data_j->image && 88062c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis isRegionOverlapping(view_data_i->subresourceRange, view_data_j->subresourceRange)) { 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88116d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_i = getImageNode(my_data, view_data_i->image); 88126d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data_j = getImageNode(my_data, view_data_j->image); 88136d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88166d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 88176d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 88431c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 88461c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 884993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 885093fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 885893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 885993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88641c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88721c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 88731c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 88741c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 88751c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 88761c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88771c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 88781c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 88791c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 888793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 888893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 888993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 889493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 889593fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 889693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8916be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 8917be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 8918be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 8919be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 8920be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 8921be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 8922be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 8923be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 8924be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 8925be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 8926be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 8927be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 8928be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 8929be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 8930be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 8931be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8932be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8933be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 8934be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8936e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8937e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 893977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 894077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89440ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 89450ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 89460ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 89470ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89554d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 896177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 896277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, 896377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 896477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 896577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 89764d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8982be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 898377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 898477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 898577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 898677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 898777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 898877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 898977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 899077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 899177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 899277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 899377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 899477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 899577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 899677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 899777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 899877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 899977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 900077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 900177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } else { 900277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 900377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 900477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 900577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 900677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 900777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 900877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 900977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, 901077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 901177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 901277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9018e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9019e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9047918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 904989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 905089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 905189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9053e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9054b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9055b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 9056b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 9057b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 9058b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 9059b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9060b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 9061b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 9062b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 9063b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 9064b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 9065b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 9066b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9069b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 9070b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 9071b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9072e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9078b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9079918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 90854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 90864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 90874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 90894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 90904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 90914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 90924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 90934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 90944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9095805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 9096805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 9097805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 9098805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 90994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 91004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 91014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 91024f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 91034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 91044f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 91054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91064f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 91074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 91084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 91104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 91114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 91124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 91134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 91144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 91154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 91164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 91174f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91196a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 91206a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 91216a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 91226a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 91236a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9124805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 9125805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 91264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 91274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 91284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 91294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 91304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 91316a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 91326a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 91336a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 91346a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 91356a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 91366a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 91376a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 91386a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 91396a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 91404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 91424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 91436a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9144805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9145805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9146805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9147dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 9148dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 9149dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9150dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9151dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 9152dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 9153dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 9154dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 91556a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 91564f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9157dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 91584f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 91594f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 91604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 9161805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9162805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9163805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9164805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 91654f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9166dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 91674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 91684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 91694f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 91704f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9171805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9172805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 9173805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9174805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9175805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 9176805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 9177805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 9178805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 91794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 91814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 91824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 918389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 91844f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 9185e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 91874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 91884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 91894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 91904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 91914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 91924f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 91934f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 9194ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 91954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 91964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 91974f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 91984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 91994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9200ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 9201ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 92034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 92044f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 92054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 92064f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 92074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 92084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 92125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 92135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 92285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 92295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 92375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 92385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 92395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 92545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9256cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 9257cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 925898cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 9259cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 9260cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 926187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 926287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 926387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 926487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 926587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 926687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 926787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 92681a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_load_op = desc.stencilLoadOp; 92691a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_store_op = desc.stencilStoreOp; 927087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 9271cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 927287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 927387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 9274cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 92756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 927687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 927787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 927887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 92794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 92804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 92814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 92824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 92830d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 928487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 928587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 928687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 92874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 92884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 92894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 929024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 929187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9292a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9293a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 92944f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 92954f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 92964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 929724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9298a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 929987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 930087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 93014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski dev_data->renderPassMap[*pRenderPass] = render_pass; 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 93087bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes for (auto renderPass : my_data->renderPassMap) { 93097bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass.second->pCreateInfo; 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 93297bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes delete renderPass.second; 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9334e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 9335e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 933704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 93452c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto image_data = getImageViewData(dev_data, image_view); 93462c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis assert(image_data); 93472c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImage &image = image_data->image; 93482c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->subresourceRange; 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9362c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 9363c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9366c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 9367c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 9368c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 9369c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 9370c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 9371c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 93721c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9380628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbesstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, 9381628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes FRAMEBUFFER_NODE *pFramebuffer, 9382628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes VkAttachmentReference ref) 9383628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes{ 9384628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 9385628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 9386628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 9387628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 9388628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 9389628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 939027ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 9391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 939216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 939316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 939516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 9396e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9397e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9399e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 940016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9402628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 9405628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9407628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 9408628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9412e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9413e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9422f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 942316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 942416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 942616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 942716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 9428e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 9429e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9431e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 94325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 9433628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9438e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9439885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 944004861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &getFramebuffer(my_data, pRenderPassBegin->framebuffer)->createInfo; 9441885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9442885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9443885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9444885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9445885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9446885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9447885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9448885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9449885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9450885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9451885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9452885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9453885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9454885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9455885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9456885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 94571a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 94581a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 94591a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 94601a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 9461a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 9462a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 9463a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 94641a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 94651a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 9466a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 9467a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 9468a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 94691a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 94701a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 947189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 947289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 947383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 947716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 9478f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 948016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 94816de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 948216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeFramebuffer = pRenderPassBegin->framebuffer; 948316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 9484f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 94851a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = renderPass->pCreateInfo->pAttachments[renderPass->attachments[i].attachment].format; 94861a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 94871a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 94881a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 94896de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis clear_op_size = i + 1; 949016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 949116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 949216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 949316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 949416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 94951a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 94961a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 94971a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 949816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 949916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 950016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 950116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 950216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 95031a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 95041a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 95051a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 950616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 950716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 950816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 950916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 951016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 951116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 951216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 951316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 951416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 951516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95186de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 95196de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 95206de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 95216de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 95226de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 95236de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 95246de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 95256de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 95266de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 95276de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "attachments that aren't cleared they will be ignored.", 95286de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 95296de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis clear_op_size, clear_op_size - 1); 95303d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 953183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 953283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, pCB, pRenderPassBegin); 953383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 953483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 953583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 953683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 95378168af0c4c5b12708d5ddbeb6ce513207d01f0e4Chris Forbes pCB->activeRenderPass = renderPass; 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 954293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 9544b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis framebuffer->cb_bindings.insert(pCB); 9545ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes 9546ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 9547ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 954983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 955083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 955183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9554b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 955583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 956089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 956183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9563b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 956683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 956783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 95685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 957027ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 957183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 95725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9573b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 957483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 95765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 957889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 957983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9581b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 958258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 958358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 958458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 9585e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 9586ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 958787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 9588e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 95891a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = pRPNode->pCreateInfo->pAttachments[pRPNode->attachments[i].attachment].format; 95901a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 95911a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, VK_ATTACHMENT_STORE_OP_STORE)) { 959258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 959358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 959458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 959558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 959658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 95971a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 95981a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, 95991a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 960058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 960158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 960258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 960358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 960458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 960883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 960983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 961083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 9611f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 961258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 961358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 961458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9616b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 961783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9621a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 9622a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9625a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 9626a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 9627a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 9628a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9631a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 9632a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 9633a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 9634e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 9636a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9639a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 9646a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 9647a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 9651a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 9652a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9655a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 9656a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 9657a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9659a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 9660a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 9661a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9663a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 9664a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 9665a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9670a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 9671a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 9672a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 9674a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 9675a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9685a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 9686a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9697a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 9698a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9706a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 9707a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9716a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 9717a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9721a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 9722a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 9723a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 9724a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 9725a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 9726a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 9728a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 9729a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9732a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 9733a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 9734a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 9735a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 9736a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 9737a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 9738a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 9739a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 9740a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 9741a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9746e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9747e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9752c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9758414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a framebuffer 0x%" PRIx64 9759414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current framebuffer 0x%" PRIx64 ".", 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9762e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 9763e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9766414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9767414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9771a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto cb_renderpass = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 9772a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 9773a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 9774a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis cb_renderpass->pCreateInfo); 9775a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9780e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 978183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 979083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9793414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9794414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 980583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9808414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9809414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 9810414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 981583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 981889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 981989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 982083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9822b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 982983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9832414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 983583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 983683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 983783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 983883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 983983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 9841a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto secondary_rp_node = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 984383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 9846414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 9848ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 9851a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) { 985283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->pCreateInfo, 9853a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis pCommandBuffers[i], secondary_rp_node->pCreateInfo); 9854a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 985583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 9858a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) && 9859a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->pCreateInfo, secondary_rp_node->pCreateInfo, 9860a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 986183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9864414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 9865414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 9867ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 987383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 9876414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) references framebuffer (0x%" PRIxLEAST64 9877414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") that does not match framebuffer (0x%" PRIxLEAST64 ") in active renderpass (0x%" PRIxLEAST64 ").", 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 9879ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass->renderPass); 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 988483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 988583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB); 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 989083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9893414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 989983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9902414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 9904414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 990583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9910b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 991183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 9915414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 992483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 992583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 992883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9932e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9933e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 993557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 993657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if ((mem_info) && (mem_info->image != VK_NULL_HANDLE)) { 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 993857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (FindLayouts(dev_data, mem_info->image, layouts)) { 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 995289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 995389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9956e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9958b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 995903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 996057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObj = getMemObjInfo(dev_data, mem); 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9963b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9964b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 9968414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 997358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9974b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 99787c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 997903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 99807c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 99817c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 99827c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 99837c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 99857c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 999089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 999283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 99935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9994b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 999583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= deleteMemRanges(my_data, mem); 9996b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 999783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 99985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10002e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10003e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1000483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1000657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1000757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 1000857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->memRange.offset > pMemRanges[i].offset) { 1000983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1001057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1001157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1001257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1001357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 1001457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->memRange.offset)); 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100164b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 100174b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller const uint64_t my_dataTerminus = 1001857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.size == VK_WHOLE_SIZE) ? mem_info->allocInfo.allocationSize : 1001957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (mem_info->memRange.offset + mem_info->memRange.size); 100204b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 1002183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1002283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1002383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1002483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER ") exceeds the Memory Object's upper-bound " 1002583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 1002683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), static_cast<size_t>(my_dataTerminus)); 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1003083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10033e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10034e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1003583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1003757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1003857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 1003957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info->pData) { 1004057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis VkDeviceSize size = mem_info->memRange.size; 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 1004257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis char *data = static_cast<char *>(mem_info->pData); 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1004583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1004683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1004783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1004883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1005383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1005483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1005583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1005683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1005957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis memcpy(mem_info->pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1006383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1006689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1006789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1006983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10072b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1007383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 1007483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10075b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1007683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1008289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1008389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1008583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10088b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1008983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10090b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1009183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1009789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 100985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1010083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 10101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 101036d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 1010494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1010547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 1010683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10108b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1010994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10110b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1011147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1011247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1011357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1011457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 1011547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 1011657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis insert_memory_ranges(image_handle, mem, memoryOffset, memRequirements, mem_info->imageRanges); 1011783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validate_memory_range(dev_data, mem_info->bufferRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 1011883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1011947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1012047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 101210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10122b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1012383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 1012494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10125b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1012657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis dev_data->memObjMap[mem].get()->image = image; 101276d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 101286d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 101296d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 10130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1013194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1013294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1013394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1013494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 10135414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1013694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 101375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1014189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 101423ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 101433ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 101445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10145b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 101469556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 101479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 101489556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->needsSignaled = false; 101499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 101509556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node->write_in_use) { 101513ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 101523ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10153414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 101543ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 101553ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 101563ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10157b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 101586fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 101596fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 101606fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 101616fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 101626fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 101636fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 101646fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 101656fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101666fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101673ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 101683ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1017389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 101745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 101755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10176e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10177b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10178651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 10179651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 10180651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 101814b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 10182651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 10183651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 10184a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 10185651d92815dfff917308137bb67aacccc4f60df86Chris Forbes SubmitFence(pQueue, pFence); 101864b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 10187651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 101881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 101891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 101905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 101911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 101921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 101931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 101941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10196e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 102001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 102011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 102021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 102035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 102081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 102091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 102101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 102115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10212e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1021601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1021701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1021801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1021901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 1022001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 102211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 102221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10225414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 102261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 102271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1023201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1023301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1023401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1023501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 102375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10239414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 102401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 102411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1024301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 102445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102470a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10248b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10250e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 102515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1025689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1025789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 102585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10261b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 102631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 102640a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 102665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1027189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10275b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 10278293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1028489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1028589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1028689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 10291b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102923f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1029889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1029989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1030183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 103025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10303b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10304b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 10305b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 10306b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 10307b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 103085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1031883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 1031983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis clear_object_binding(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1032094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 103245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10325b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1032683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1033089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1033189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 103325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 103345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 10339b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 10341b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 10342b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 103430801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 103440801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 103450801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 103485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 103495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 10350414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 103525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 103596d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 103606d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 103616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 103626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 103636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 103646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1036541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 103666d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 103676d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 103686d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 1036929e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pSwapchainImages[i], &image_ci)); 1037094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 103716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 103726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 103765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1038389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 103855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103876c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 103886c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 103896c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 103906c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 103916c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 103926c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 103936c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103946c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 103956c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103976c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 10398249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 103996c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 104006c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 104016c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (swapchain_data && pPresentInfo->pImageIndices[i] < swapchain_data->images.size()) { 104026c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkImage image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 10403249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, getImageNode(dev_data, image)->mem, "vkQueuePresentKHR()", image); 104046c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes vector<VkImageLayout> layouts; 104056c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (FindLayouts(dev_data, image, layouts)) { 104066c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (auto layout : layouts) { 104076c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 104086c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 104105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104206c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 104216c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 104226c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 104236c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 104246c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 104256c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 104266c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 104276c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 104286c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 104296c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 104306c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 104316c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && pSemaphore->signaled) { 104326c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 104336c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 104346c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 104356c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 104361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1044089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1044189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1044383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 104441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 10445b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10446f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 10447f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1044883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1044983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1045083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10452f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10453f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 10454f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1045583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10457b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 104581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1045983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 10460f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 10461f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10462f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 10464f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10465f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 10466f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 10467f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 10468f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 10469f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 10470f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 10471f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 10472f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 10473f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 10474f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10476f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 104771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10481f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 10482f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1048383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 10484f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 10485f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (my_data->instance_state) { 10486f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 10487f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 10488f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 10489f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 10490f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (UNCALLED == my_data->instance_state->vkEnumeratePhysicalDevicesState) { 10491f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 10492f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 1049383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 10494f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 10495f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 10496f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 10497f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 10498cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else if (my_data->instance_state->physical_devices_count != *pPhysicalDeviceCount) { 10499f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 1050083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 10501f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 10502f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 10503f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "supported by this instance is %u.", 10504cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pPhysicalDeviceCount, my_data->instance_state->physical_devices_count); 10505f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 10506f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 10507f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1050883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 10509f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 10510f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 10511f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkResult result = 10512f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 10513f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 10514cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski my_data->instance_state->physical_devices_count = *pPhysicalDeviceCount; 10515f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { // Save physical devices 10516f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 10517f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(pPhysicalDevices[i]), layer_data_map); 10518cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state = unique_ptr<PHYSICAL_DEVICE_STATE>(new PHYSICAL_DEVICE_STATE()); 10519f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 10520f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->GetPhysicalDeviceFeatures(pPhysicalDevices[i], 10521f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski &phy_dev_data->physical_device_features); 10522f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 10523f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 10524f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 10525f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 10526f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 10527f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 10528f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 10529f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 10530f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 10531f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 10532f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 10533cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 10534cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 10535cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 10536cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 10537cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); 10538cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state) { 10539cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 10540cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 10541cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10542cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 10543cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 10544cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 10545cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (UNCALLED == phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 10546cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 10547cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 10548cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 10549cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 10550cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 10551cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10552cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 10553cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state->queueFamilyPropertiesCount != *pCount) { 10554cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 10555cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 10556cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 10557cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 10558cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 10559cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 10560cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 10561cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pCount, phy_dev_data->physical_device_state->queueFamilyPropertiesCount); 10562cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10563cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 10564cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10565cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 10566cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 10567cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10568cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, 10569cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski pQueueFamilyProperties); 10570cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 10571cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->queueFamilyPropertiesCount = *pCount; 10572cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10573cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 10574cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.reserve(*pCount); 10575cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 10576cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.emplace_back(new VkQueueFamilyProperties(pQueueFamilyProperties[i])); 10577cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10578cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10579cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 10580cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10581cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 10582cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 10583cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 10584cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 10585cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 10586cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 10587cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 10588cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 1058989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1059089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1059189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 10596b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 10597c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1060289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1060389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1060489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10608b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1061289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1061389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1061489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10620a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10621a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10622a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10623a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10624a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10625a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10626a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10627a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 10628a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10629a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10630a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10631a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10632a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 10633a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 10634a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 10635a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 10636a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 10637a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1063889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1063989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1064089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 10641a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1064208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 10643a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10644a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 10645a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 10646a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 10647a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 10648a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1064908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1065008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1065180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 106527ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 106537ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 106547ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1065580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1065680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1065709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1065809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1065909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1066089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1066180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1066280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1066380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1066480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1066580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1066709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1066809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1066909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1067009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1068289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 106837ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 106843f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 106853f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 106863f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 106873f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 106887ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 106897ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106917ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 106957ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 106967ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 106977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1070408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1070580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 107067ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 107077ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 107087ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 107097ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 107107ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 107117ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 107127ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 107137ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 107147ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 10715f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 10716cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 107177ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 10718a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 10719a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 10720a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 107217ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 107227ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 107237ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 107247ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 107257ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 107267ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 107277ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 107287ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 107297ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 107307ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 107317ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 107327ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1073380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1073480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1073580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1073680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1073780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 10738593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 10739593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 10740593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 10741593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 10742593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 10743593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 10744593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 10745593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 10746593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 10747593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 10748593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 10749593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 10750593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 10751593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 10752593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 10753593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 10754593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 10755593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 10756593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 10757593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 10758593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 10759593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 10760593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 10761593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 10762593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 10763593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 10764593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 10765593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 10766593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 10767593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 10768593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 10769593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 10770593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 10771593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 10772593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 10773593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 10774593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 10775593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 10776593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 10777593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 10778593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 10779593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 10780593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 10781593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 10782593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 10783593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 10784593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 10785593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 10786593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 10787593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 10788593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 10789593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 10790593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 10791593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 10792593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 10793593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 10794593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 10795593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 10796593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 10797593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 10798593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 10799593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 10800593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 10801593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 10802593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 10803593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 10804593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 10805593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 10806593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 10807593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 10808593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 10809593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 10810593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 10811593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 10812593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 10813593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 10814593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 10815593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 10816593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 10817593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 10818593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 10819593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 10820593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 10821593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 10822593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 10823593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 10824593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 10825593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 10826593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 10827593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 10828593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 10829593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 10830593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 10831593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 10832593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 10833593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 10834593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 10835593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 10836593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 10837593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 10838593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 10839593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 10840593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 10841593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 10842593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 10843593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 10844593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 10845593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 10846593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 10847593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 10848593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 10849593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 10850593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 10851593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 10852593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 10853593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1085480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1085580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1085680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1085780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1085880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1085980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1086080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1086180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1086280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1086380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1086409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1086509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1086609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1086709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1086809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1086909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1087009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1087109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1087209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1087309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1087409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1087509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1087609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 108773f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 108783f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 108793f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 108803f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 108813f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1088209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1088309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1088409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1088509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1088609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1088709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1088809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1088909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1089009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 10891d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 10892d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10893d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 10894d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10895d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10896d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 10897d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1089889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 10899d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10900d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10901d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10902d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 10903d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 10904d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1090589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10906d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10907d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10908d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10909d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 10910d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1091189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 10912d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10913d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10914a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 10915d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1091608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1091708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10918a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1091908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1092008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1092108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1092208939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10923a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1092408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1092508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1092608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1092708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10928a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10929a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10930a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 10931d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10932d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10933d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 10934d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 10935d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 10936a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 10937a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 10938a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 10939d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10940d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10941d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1094289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 10943d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10944d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10945d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1094689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1094708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 10948