core_validation.cpp revision 350841afb70bf8dcfc3c6ec6b66f0aaa639553a3
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 36b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 38825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 43dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 60b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 66c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 67c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 68c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73d147a5463f8581604ca542aa1a44a27e512e0f60Mike Stroyan// This intentionally includes a cpp file 74d147a5463f8581604ca542aa1a44a27e512e0f60Mike Stroyan#include "vk_safe_struct.cpp" 75d147a5463f8581604ca542aa1a44a27e512e0f60Mike Stroyan 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 78d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 79d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 86888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// 2nd special memory handle used to flag object as unbound from memory 87888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); 88b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 90e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 91c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young bool wsi_display_swapchain_enabled; 923f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstruct instance_layer_data { 100d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkInstance instance = VK_NULL_HANDLE; 101d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes debug_report_data *report_data = nullptr; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1039172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkLayerInstanceDispatchTable dispatch_table; 1049172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes 105219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes CALL_STATE vkEnumeratePhysicalDevicesState = UNCALLED; 106219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes uint32_t physical_devices_count = 0; 107219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes CHECK_DISABLED disabled = {}; 108219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes 109f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; 110747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes unordered_map<VkSurfaceKHR, SURFACE_STATE> surface_map; 111747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 112747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool surfaceExtensionEnabled = false; 113747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool displayExtensionEnabled = false; 114747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 115747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool androidSurfaceExtensionEnabled = false; 116747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 117747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 118747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool mirSurfaceExtensionEnabled = false; 119747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 120747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 121747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool waylandSurfaceExtensionEnabled = false; 122747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 123747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 124747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool win32SurfaceExtensionEnabled = false; 125747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 126747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 127747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool xcbSurfaceExtensionEnabled = false; 128747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 129747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 130747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool xlibSurfaceExtensionEnabled = false; 131747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 132f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes}; 133f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes 134f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstruct layer_data { 135f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes debug_report_data *report_data = nullptr; 1364a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkLayerDispatchTable dispatch_table; 13794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 138d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes devExts device_extensions = {}; 139cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 143d31a44af6da568692a73201825459689c9431867Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_STATE>> samplerMap; 14479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; 1451facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_STATE>> imageMap; 14639267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; 1478718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1484c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis unordered_map<VkPipeline, PIPELINE_STATE *> pipelineMap; 1498d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 150a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_STATE *> descriptorPoolMap; 151397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 152cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 15457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1574710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis unordered_map<VkEvent, EVENT_STATE> eventMap; 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 16172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 162c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_STATE>> frameBufferMap; 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 165127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis unordered_map<VkRenderPass, unique_ptr<RENDER_PASS_STATE>> renderPassMap; 166918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 167d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkDevice device = VK_NULL_HANDLE; 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 169f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = nullptr; // from device to enclosing instance 17007a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes 171f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes VkPhysicalDeviceFeatures enabled_features = {}; 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 173d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; 174d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 177b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 178b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 179f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic unordered_map<void *, instance_layer_data *> instance_layer_data_map; 180b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 181e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 182f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 183e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 188e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 194e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 208b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 209b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 210b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 211b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 212b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 213b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 215b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 216b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 217b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 218b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 219b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 220b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 279b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 280593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 28179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis// Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL 28279fde938178535f598e030a0e9d19a0cb61b72e0Tobin EhlisIMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { 2832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2842c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2852c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2862c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2872c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2882c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2899a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 290d31a44af6da568692a73201825459689c9431867Tobin EhlisSAMPLER_STATE *getSamplerState(const layer_data *dev_data, VkSampler sampler) { 2912c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2922c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2939a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2949a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2959a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2969a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 2981facd2c91911508b9fb61f54a56269841299f663Tobin EhlisIMAGE_STATE *getImageState(const layer_data *dev_data, VkImage image) { 2996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 3006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 3016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 3026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 3036d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 3046d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 3058718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 306a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 3072c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 3082c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 3098718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 3108718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 3118718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 3128718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 313b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 314a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 315b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 316b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 317b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 318b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 3193f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 320b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 321170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 322a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 323170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 324170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 325170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 326170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 327170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 328170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3292f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 33039267c0c27b8f032f05a6747eb02d4508247fdc1Tobin EhlisBUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { 3312f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3322f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3332f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3342f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3352f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3362f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3378718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 33866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 33966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 34066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 34166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 34266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 34366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 34466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 34566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3464710dda89a1dd2e023334d4eda710a394b211cdcTobin EhlisEVENT_STATE *getEventNode(layer_data *dev_data, VkEvent event) { 3479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3489556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3509556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3519556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3529556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3539556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 354ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 355ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 356ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 357ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 358ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 359ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 360ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 361ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 36266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 36366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 36466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 36566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 36666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 36766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 36866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 36966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3705e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3715e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3725e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3735e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3745e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3755e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3765e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3775e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3788d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3798d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3808d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3818d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3828d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3838d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3848d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3853bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 386f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris ForbesPHYSICAL_DEVICE_STATE *getPhysicalDeviceState(instance_layer_data *instance_data, VkPhysicalDevice phys) { 387f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes auto it = instance_data->physical_device_map.find(phys); 388f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes if (it == instance_data->physical_device_map.end()) { 3893bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return nullptr; 3903bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes } 3913bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return &it->second; 3923bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes} 3933bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 394747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesSURFACE_STATE *getSurfaceState(instance_layer_data *instance_data, VkSurfaceKHR surface) { 395747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes auto it = instance_data->surface_map.find(surface); 396747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (it == instance_data->surface_map.end()) { 397747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 398747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 399747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return &it->second; 400747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 401747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 402f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// Return ptr to memory binding for given handle of specified type 403f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlisstatic BINDABLE *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 405f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 406f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis return getImageState(my_data, VkImage(handle)); 407f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 408f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis return getBufferNode(my_data, VkBuffer(handle)); 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 4155121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 41672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 4210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 4220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 4230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 424e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 42583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 43183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 43283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 43383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 43483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 440249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 441249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 4421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_STATE const *image_state, VkFlags desired, VkBool32 strict, 443249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 4441facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return validate_usage_flags(dev_data, image_state->createInfo.usage, desired, strict, 4451facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<const uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 446249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 447249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 448249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 449249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 450ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 451ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 45259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 453ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 454ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 455ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 456ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 457ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 458ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 46157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 46257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 46357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 475dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 476dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// Helper function to print lowercase string of object type 477dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// TODO: Unify string helper functions, this should really come out of a string helper if not there already 478dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 479dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis switch (type) { 480dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 481dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "image"; 482dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 483dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "buffer"; 4847e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: 4857e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "image view"; 4867e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: 4877e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "buffer view"; 488dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 489dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "swapchain"; 490dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 491dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "descriptor set"; 492dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 4936f62283faa835f7fd302771a3a693d1aafff4652Tobin Ehlis return "framebuffer"; 494dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 495dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "event"; 496dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 497dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "query pool"; 4987e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: 4997e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "descriptor pool"; 5007e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: 5017e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "command pool"; 502dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 503dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "pipeline"; 504dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: 505dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "sampler"; 5067e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: 5077e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "renderpass"; 5087e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: 5097e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "device memory"; 510eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: 511eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return "semaphore"; 512dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis default: 513dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "unknown"; 514dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis } 515dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis} 516dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 517cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid 518f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, 519dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *functionName) { 520f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 521f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 522f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!mem_info->bound_ranges[bound_object_handle].valid) { 523f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 524ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 525dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 526dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis ", please fill the memory before using.", 527dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); 528f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 529f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 530f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return false; 531f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// For given image_state 5331facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// If mem is special swapchain key, then verify that image_state valid member is true 534f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else verify that the image's bound memory range is valid 5351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_STATE *image_state, const char *functionName) { 536e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5371facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state->valid) { 538f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 539e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->binding.mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 540414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 5411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(image_state->image)); 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 544e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis return ValidateMemoryIsValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), 545dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 549f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer_node, verify that the range it's bound to is valid 550f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *functionName) { 551e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis return ValidateMemoryIsValid(dev_data, buffer_node->binding.mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), 552dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); 553f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 554f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For the given memory allocation, set the range bound by the given handle object to the valid param value 555f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { 556f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 557f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 558f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis mem_info->bound_ranges[handle].valid = valid; 559f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 560f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 561f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image node 5621facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis// If mem is special swapchain key, then set entire image_state to valid param value 563f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else set the image's bound memory range to valid param value 5641facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic void SetImageMemoryValid(layer_data *dev_data, IMAGE_STATE *image_state, bool valid) { 565e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis if (image_state->binding.mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5661facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->valid = valid; 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 568e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis SetMemoryValid(dev_data, image_state->binding.mem, reinterpret_cast<uint64_t &>(image_state->image), valid); 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 571f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer node set the buffer's bound memory range to valid param value 572f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetBufferMemoryValid(layer_data *dev_data, BUFFER_NODE *buffer_node, bool valid) { 573e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis SetMemoryValid(dev_data, buffer_node->binding.mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), valid); 574f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 577e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 578e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 57983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 58557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 5865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 5875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 588d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, cb); 589d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis pMemInfo->cb_bindings.insert(cb_node); 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 591d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis if (cb_node) { 592d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis cb_node->memObjs.insert(mem); 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 598ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 59956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given sampler and command buffer node 600d31a44af6da568692a73201825459689c9431867Tobin Ehlisvoid AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_STATE *sampler_state) { 601d31a44af6da568692a73201825459689c9431867Tobin Ehlis sampler_state->cb_bindings.insert(cb_node); 602d31a44af6da568692a73201825459689c9431867Tobin Ehlis cb_node->object_bindings.insert( 603d31a44af6da568692a73201825459689c9431867Tobin Ehlis {reinterpret_cast<uint64_t &>(sampler_state->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 60456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis} 60556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis 60656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given image node and command buffer node 6071facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisvoid AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_STATE *image_state) { 608ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 609e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis if (image_state->binding.mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 610ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 611e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, image_state->binding.mem); 612ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 613d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis pMemInfo->cb_bindings.insert(cb_node); 614ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 615e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis cb_node->memObjs.insert(image_state->binding.mem); 616ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 617f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis // Now update cb binding for image 6181facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(image_state->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 6191facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->cb_bindings.insert(cb_node); 620ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 621ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 622ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 62303ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis// Create binding link between given image view node and its image with command buffer node 62403ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlisvoid AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { 62503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // First add bindings for imageView 62603ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis view_state->cb_bindings.insert(cb_node); 62703ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis cb_node->object_bindings.insert( 62803ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}); 6291facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, view_state->create_info.image); 63003ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // Add bindings for image within imageView 6311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 6321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 63303ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis } 63403ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis} 63503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis 636ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 637c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node) { 638ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 639e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->binding.mem); 640ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 641d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis pMemInfo->cb_bindings.insert(cb_node); 642ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 643e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis cb_node->memObjs.insert(buff_node->binding.mem); 644ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 645ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 64682ed6a21be1831c0c712be3215c34dea6ff79926Tobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 647ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 648ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 649ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 65077b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis// Create binding link between given buffer view node and its buffer with command buffer node 65177b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlisvoid AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { 65277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // First add bindings for bufferView 65377b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis view_state->cb_bindings.insert(cb_node); 65477b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis cb_node->object_bindings.insert( 65577b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}); 65677b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis auto buffer_node = getBufferNode(dev_data, view_state->create_info.buffer); 65777b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // Add bindings for buffer within bufferView 65877b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis if (buffer_node) { 65977b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_node); 66077b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis } 66177b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis} 66277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis 663400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 664d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 665d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis if (cb_node) { 666d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis if (cb_node->memObjs.size() > 0) { 667d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto mem : cb_node->memObjs) { 66857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 670d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis pInfo->cb_bindings.erase(cb_node); 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 673d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis cb_node->memObjs.clear(); 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 675d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis cb_node->validate_functions.clear(); 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 678400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 679400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 680400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 683f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// Clear a single object binding from given memory object, or report error if binding is missing 684f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlisstatic bool ClearMemoryObjectBinding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory mem) { 685f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 686f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // This obj is bound to a memory object. Remove the reference to this object in that memory object's list 687f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (mem_info && !mem_info->obj_bindings.erase({handle, type})) { 688f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 689f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 690f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 691f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis object_type_to_string(type), handle, (uint64_t)mem); 692f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis } 693f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis return false; 694f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis} 695f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis 696f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// ClearMemoryObjectBindings clears the binding of objects to memory 697f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// For the given object it pulls the memory bindings and makes sure that the bindings 698f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// no longer refer to the object being cleared. This occurs when objects are destroyed. 699f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlisstatic bool ClearMemoryObjectBindings(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 700f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis bool skip = false; 701f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); 702f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (mem_binding) { 703f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (!mem_binding->sparse) { 704f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis skip = ClearMemoryObjectBinding(dev_data, handle, type, mem_binding->binding.mem); 705f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis } else { // Sparse, clear all bindings 706f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis for (auto& sparse_mem_binding : mem_binding->sparse_bindings) { 707f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis skip |= ClearMemoryObjectBinding(dev_data, handle, type, sparse_mem_binding.mem); 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 711f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis return skip; 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 714888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. 715888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisbool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, 716888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *type_name) { 717888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool result = false; 718888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (VK_NULL_HANDLE == mem) { 719888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 720888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 721888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound. Memory should be bound by calling " 722888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "vkBind%sMemory().", 723888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle, type_name); 724888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } else if (MEMORY_UNBOUND == mem) { 725888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 726888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 727888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound and previously bound memory was freed. " 728888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Memory must not be freed prior to this operation.", 729888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle); 730888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } 731888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis return result; 732888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis} 733888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis 734b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 7351facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisbool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_STATE *image_state, const char *api_name) { 736b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 7371facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (0 == (static_cast<uint32_t>(image_state->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 738e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, image_state->binding.mem, reinterpret_cast<const uint64_t &>(image_state->image), 739888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, "Image"); 740b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 741b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 742b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 743b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 744b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 745694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_NODE *buffer_node, const char *api_name) { 746b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 74712e3a5f6e672b103f705424595ffe3c4687492ceTobin Ehlis if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { 748e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, buffer_node->binding.mem, 749e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), api_name, "Buffer"); 750b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 751b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 752b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 753b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 754f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis// SetMemBinding is used to establish immutable, non-sparse binding between a single image/buffer object and memory object 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 7565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 760888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic bool SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VkDebugReportObjectTypeEXT type, 761888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *apiName) { 76283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 763f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // It's an error to bind an object to NULL memory 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 76583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 76683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 768f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); 769888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis assert(mem_binding); 770f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // TODO : Add check here to make sure object isn't sparse 771f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // VALIDATION_ERROR_00792 for buffers 772f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // VALIDATION_ERROR_00804 for images 773f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis assert(!mem_binding->sparse); 774888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 775888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (mem_info) { 776f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis DEVICE_MEM_INFO *prev_binding = getMemObjInfo(dev_data, mem_binding->binding.mem); 777888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (prev_binding) { 778888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 779888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 780888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 781888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 782888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 783888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle, reinterpret_cast<uint64_t &>(prev_binding->mem)); 784f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis } else if (mem_binding->binding.mem == MEMORY_UNBOUND) { 785888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 786888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 787888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 788888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 789888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " 790888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Vulkan so this attempt to bind to new memory is not allowed.", 791888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle); 7922e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 793888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis mem_info->obj_bindings.insert({handle, type}); 7942e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 7952e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 7962e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 7971facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto const image_state = getImageState(dev_data, VkImage(handle)); 7981facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 7991facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis VkImageCreateInfo ici = image_state->createInfo; 8002e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 8012e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 805f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis mem_binding->binding.mem = mem; 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 8170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 818f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlisstatic bool SetSparseMemBinding(layer_data *dev_data, MEM_BINDING binding, uint64_t handle, VkDebugReportObjectTypeEXT type, 819f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis const char *apiName) { 82083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 822f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (binding.mem == VK_NULL_HANDLE) { 823f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // TODO : This should cause the range of the resource to be unbound according to spec 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 825f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis BINDABLE *mem_binding = GetObjectMemBinding(dev_data, handle, type); 826f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis assert(mem_binding); 827f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis assert(mem_binding->sparse); 828f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, binding.mem); 829f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (mem_info) { 830f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis mem_info->obj_bindings.insert({handle, type}); 8312e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 832f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis mem_binding->sparse_bindings.insert(binding); 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 838caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 839caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 840caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 842caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 843caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 844e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis *mem = getImageState(dev_data, VkImage(handle))->binding.mem; 845caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 846caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 847e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->binding.mem; 848caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 849caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 850caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 852caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 853caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 854caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 855caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 856caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 857caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 858caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 859caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 860caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 8620a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 86458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 86958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 87158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 87258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 87957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 88257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 88358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 88457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 88558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 886c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 887d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis mem_info->cb_bindings.size() + mem_info->obj_bindings.size()); 888de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (0 != mem_info->alloc_info.allocationSize) { 889de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->alloc_info, "MEM(INFO): "); 89058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 899de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->obj_bindings.size()); 900de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->obj_bindings.size() > 0) { 901de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : mem_info->obj_bindings) { 90258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 903414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 910d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis mem_info->cb_bindings.size()); 911d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis if (mem_info->cb_bindings.size() > 0) { 912d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto cb : mem_info->cb_bindings) { 91358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 914d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen 0, __LINE__, MEMTRACK_NONE, "MEM", " VK command buffer 0x%p", cb); 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 92172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 929d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen MEMTRACK_NONE, "MEM", "Details of command buffer list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 93072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 93872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 941d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has command buffer 0x%p", (void *)pCBInfo, 942d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen (void *)pCBInfo->commandBuffer); 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 944c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 946c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 948414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 11645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 11655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 11849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 11879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 11909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 11939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 11979ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 12019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 12059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 12069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 12089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 12109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 12119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 12129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 12139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 12149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 12159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 12209ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 12219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 12239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 12249ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 12279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 12289ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 12319ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 12379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 12389ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 12399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 12409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 12419ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12429ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 124337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 124437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 124537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 124637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 124737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 124837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 124937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 125037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 125137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12587c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 125937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 12607c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12617c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 126437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 126537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 126637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 126737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 126837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12757c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 12767c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 127737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 12787c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12797c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12807c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 12817c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 12827c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 12837c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12847c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12877c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 12907c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 12937c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 129537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 129637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 129737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 129837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 129937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 130037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 130137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 130237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 130337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 130537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 130637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 131137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 132137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1362cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1363cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1364cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1365cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1366cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1367cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1368cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1369cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1370cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1380c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1381c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1382c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1383c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1384c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1385c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1386c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1387c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1388c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1389c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1390c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1391c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1392c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1393c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1401b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1402fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1406031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1407031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1408031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1409031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1410031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1411031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1412031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1413031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1414031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1415031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1416031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1417031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1418031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1419031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1436edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 14373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> *out, 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1439b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1441031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1479b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1480fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 14813a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes (*out)[std::make_pair(location + offset, component)] = v; 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14883a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::map<location_t, interface_var> collect_interface_by_location( 14893a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes shader_module const *src, spirv_inst_iter entrypoint, 14903a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes spv::StorageClass sinterface, bool is_array_of_verts) { 14913a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1496b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1519b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1520b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1521b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1522b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 152881264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1533c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15393a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> out; 15403a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15461d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1553b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 15545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 15667c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1572b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1573fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 15783a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15823a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15833a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15863a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( 15873a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 15883a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 15893a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15903a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<uint32_t, interface_var>> out; 1591745d49409296f060402b57950384caadb636a2b2Chris Forbes 1592745d49409296f060402b57950384caadb636a2b2Chris Forbes for (auto insn : *src) { 1593745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.opcode() == spv::OpDecorate) { 1594745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.word(2) == spv::DecorationInputAttachmentIndex) { 1595745d49409296f060402b57950384caadb636a2b2Chris Forbes auto attachment_index = insn.word(3); 1596745d49409296f060402b57950384caadb636a2b2Chris Forbes auto id = insn.word(1); 1597745d49409296f060402b57950384caadb636a2b2Chris Forbes 1598745d49409296f060402b57950384caadb636a2b2Chris Forbes if (accessible_ids.count(id)) { 1599745d49409296f060402b57950384caadb636a2b2Chris Forbes auto def = src->get_def(id); 1600745d49409296f060402b57950384caadb636a2b2Chris Forbes assert(def != src->end()); 1601745d49409296f060402b57950384caadb636a2b2Chris Forbes 1602745d49409296f060402b57950384caadb636a2b2Chris Forbes if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { 1603e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); 1604e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes for (unsigned int offset = 0; offset < num_locations; offset++) { 1605e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes interface_var v; 1606e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.id = id; 1607e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.type_id = def.word(1); 1608e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.offset = offset; 1609e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_patch = false; 1610e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_block_member = false; 1611e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes out.emplace_back(attachment_index + offset, v); 1612e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes } 1613745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1614745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1615745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1616745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1617745d49409296f060402b57950384caadb636a2b2Chris Forbes } 16183a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16193a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 1620745d49409296f060402b57950384caadb636a2b2Chris Forbes} 1621745d49409296f060402b57950384caadb636a2b2Chris Forbes 16223a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( 16233a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 16243a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16443a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> out; 16453a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1658b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1659b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1660fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1661cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16643a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16653a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1668edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1669031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1671031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16743a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); 16753a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1688edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1689080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1690031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1691031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1696edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1698031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1699031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1704fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1705fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1706fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1707fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 17080f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1709fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1710fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 171137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1712edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 17149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 17159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 17169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17200f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1721edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17220f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1723f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 17240f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 17250f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 17260f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 17270f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 17280f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17290f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 176131c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 176231c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 176331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 176431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1767f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 178331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 178431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 178531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 178631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1789f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 1817f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes case spv::OpTypeImage: 1818f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes return get_fundamental_type(src, insn.word(2)); 1819f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1830edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1841edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1854edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18583a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1863c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1864c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1865c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1866c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1867c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1868c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 18731730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 18811730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1882080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1883d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Vertex attribute at location %d not consumed by vertex shader", a_first)) { 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18861730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1889edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18904b5890faffa54a735782a6b0a628a991ddc86944Mike Weiblen __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Vertex shader consumes input at location %d but not provided", 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1901edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 19034b5890faffa54a735782a6b0a628a991ddc86944Mike Weiblen "Attribute type of `%s` at location %d does not match vertex shader input type of `%s`", 19049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 19059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 19111730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1919edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 19208da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 19218da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 1922025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 19238da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 19248da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 1925d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 1926d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 1927d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 1928d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 1929d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 1930025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1931025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1932025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1939025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1940025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1942025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1943025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1944025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1945025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1946025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1948025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1949edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1951d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "fragment shader writes to output location %d with no matching attachment", it_a->first.first)) { 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1954025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1955025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1956edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1957d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by fragment shader", 1958d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen it_b->first)) { 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1961025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1963025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1964025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1968edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1970d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Attachment %d of type `%s` does not match fragment shader output type of `%s`", it_b->first, 1971025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1972025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1978025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1979025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19953a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { 19963a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> ids; 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 200781264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 20585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 2087c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2093c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21023a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 21033a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return ids; 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2106edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2107416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 21175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2127416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2132edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2133080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2146edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2147080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2161edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2162416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2169416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2170416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2177fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2178fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 21794a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 218237083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2184416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 218537083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2187416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2202e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2208e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2209e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 22103d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 22113d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 22123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2213d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "command buffer object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), 2214d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen fail_msg); 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2216e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 22204c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic PIPELINE_STATE *getPipelineState(layer_data const *my_data, VkPipeline pipeline) { 2221ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2222ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2223ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2225ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2228127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlisstatic RENDER_PASS_STATE *getRenderPassState(layer_data const *my_data, VkRenderPass renderpass) { 222916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 223016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 223116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 223216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 2233fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes return it->second.get(); 223416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 223516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 2236c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic FRAMEBUFFER_STATE *getFramebufferState(const layer_data *my_data, VkFramebuffer framebuffer) { 2237f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2238f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2239f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2240f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 224104861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2242f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2243f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2244e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 224511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 224611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 224711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 224811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 224911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 225011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 225111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 2252c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlisstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 22534a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 22544a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 22554a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 22564a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 22574a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 22584a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 22594a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2260e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 22614c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool isDynamic(const PIPELINE_STATE *pPipeline, const VkDynamicState state) { 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2265e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2268e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 22724c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe, bool indexedDraw) { 22739c4006684a13db43f0dbc8d0015a9ef34872ca09Chris Forbes bool result = false; 2274ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2275ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2276ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 22773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 22793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 228045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 228145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 22823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 22843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 22863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 22883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 228945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 229045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 22913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 22933d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 229445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 229545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 22963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22973d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 22983d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22993d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 23003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23013d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 23023d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23033d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 23043d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23053d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 23073d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 23135ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 23175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 23185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 23195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2320e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2321e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2322e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2323e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2324e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2325e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2326e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2327e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2328e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 233006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 233106e963555b0df747c98c43816c16647349d21001Mark Young return true; 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 233306e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 233406e963555b0df747c98c43816c16647349d21001Mark Young return true; 23355ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 23365ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23375ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 23385ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23395ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 23405ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2350a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 23518da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2352a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 23538da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2355c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 23575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 23625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 23635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 23645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2371c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2379c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2385fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2386fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2387fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2388fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2389fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2390c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2391fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2392fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2393fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2394fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2395fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 23995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 24005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 24015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2403c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 24055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 24115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2413397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2414397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2415397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 241669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 241769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2418416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 24199b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2420c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 242169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 242269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 242369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2427416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2428397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 24295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2432edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2433e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 24345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 24365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 24385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 24395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2440edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 24415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 24425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 24435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 24475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 24555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2457edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 24581b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 24595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 24605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24611b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 24621b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 24637b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 24647b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 24655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 24667b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 24677b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 24687b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 24697b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24707b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 24717b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 24727b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 24765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 24775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 24785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 24795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 24805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 24815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 24825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 24835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 24845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 24855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 24905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 249467d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 249567d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 249835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 249935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 250035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 250135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 250235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 250335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 250435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 250535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 250635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 250735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 25085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 25115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 25125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 25135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 25145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 25155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 25175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 25185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 25205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 25215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 25225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 25235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 25245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 25255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 25265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 252867d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 252967d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 25315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 25325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 25365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 25375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 25395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 25405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25434110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 25454110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2546080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2547a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2548a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2550a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2551a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2552a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2553a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2554a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2555a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2556a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 255769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 255869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2560a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2561a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2562a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2563a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2564a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2565a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2566a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2567a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2568a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2569a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2570a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2571a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2572a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2573a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2574a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2575a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2576a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2577a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 25784110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2579a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2580a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2581a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 25824110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2583a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2584a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2585a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 25864110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2587a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2588a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2589a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 25904110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2591a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2592a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2593a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2594a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 25954110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2596a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2597a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2598a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2599a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 26004110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2601a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2602a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2603a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 26044110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2605a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2606a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2607a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 26084110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2609a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2610a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2611a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2612a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 26134110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2614a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2615a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2616a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2617a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 26184110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2619a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2620a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2621a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2622a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 26234110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2624a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2625a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2626a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2627a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 26284110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2629a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2630a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2631a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 26324110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2633a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2634a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2635a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 26364110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2637a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2638a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2639a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 26404110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2641a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2642a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2643a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 26444110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2645a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2646a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2647a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 26484110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2649a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2650a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2651a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 26524110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2653a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2654a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2655a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 26564110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2657a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2658a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2659a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 26604110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2661a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2662a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2663a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2664a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 26654110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2666a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2667a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2668a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 26694110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2670a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2671a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2672a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2673a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 26744110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2675a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2676a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2677a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2678a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 26794110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2680a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2681a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2682a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 26834110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2684a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2685a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2686a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2687e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2688a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2689a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2690a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2691a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2692a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2693a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2694a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2695a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2696b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2697b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbesstatic uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { 26982aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto type = module->get_def(type_id); 26992aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 27002aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes while (true) { 27012aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (type.opcode()) { 27022aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeArray: 27032aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeSampledImage: 27042aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(2)); 27052aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 27062aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypePointer: 27072aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(3)); 27082aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 27092aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeImage: { 27102aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto dim = type.word(3); 27112aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto arrayed = type.word(5); 27122aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto msaa = type.word(6); 27132aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 27142aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (dim) { 27152aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim1D: 2716488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; 27172aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim2D: 27182aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | 2719488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); 27202aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim3D: 27212aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return DESCRIPTOR_REQ_VIEW_TYPE_3D; 27222aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::DimCube: 2723488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; 272428db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes case spv::DimSubpassData: 272528db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; 272628db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes default: // buffer, etc. 27272aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 27282aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27292aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27302aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: 27312aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 27322aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27332aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 2734b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes} 2735b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 27364c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool 27374c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvalidate_pipeline_shader_stage(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *pStage, 27384c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pipeline, shader_module **out_module, spirv_inst_iter *out_entrypoint, 27394c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 27404c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, std::unique_ptr<shader_module>> const &shaderModuleMap) { 2741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 274269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 274369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 274478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 274578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 274678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 274778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2748557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2749080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 275078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 275178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 27520cfa9c3a1747749777581684536218f83c3977a9Chris Forbes return false; // no point continuing beyond here, any analysis is just going to be garbage. 275378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 275478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 275578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 275678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2757557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 275878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 275978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 27603a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto accessible_ids = mark_accessible_ids(module, entrypoint); 276178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 276278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 27633a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); 276478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 27652e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2766ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 27670cfa9c3a1747749777581684536218f83c3977a9Chris Forbes pass &= validate_specialization_offsets(report_data, pStage); 2768416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 276978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 277078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 277178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 277278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 2773b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; 2774b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); 277578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2776fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2777c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 277878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 277978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 278078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2781557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2782080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 278378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 278478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2785e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 278678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2788557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 278978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 279078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 279178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 279278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2793fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 279478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 279678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2797edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2798fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2799557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2800fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2801fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2802fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2803fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 280478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2805e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 280678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 280778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2808557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2809fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 281078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 281178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2812fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2813e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 281478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 281578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 281678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 281778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2818c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes /* validate use of input attachments against subpass structure */ 2819c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { 28203a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); 2821c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2822c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto rpci = pipeline->render_pass_ci.ptr(); 2823c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto subpass = pipeline->graphicsPipelineCI.subpass; 2824c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2825c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes for (auto use : input_attachment_uses) { 2826c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; 2827c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? 2828c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; 2829c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2830c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (index == VK_ATTACHMENT_UNUSED) { 2831c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2832c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", 2833c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes "Shader consumes input attachment index %d but not provided in subpass", 2834c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes use.first)) { 2835c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes pass = false; 2836c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2837c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2838eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes else if (get_format_type(rpci->pAttachments[index].format) != 2839eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes get_fundamental_type(module, use.second.type_id)) { 2840eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2841eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", 2842eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes "Subpass input attachment %u format of %s does not match type used in shader `%s`", 2843eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes use.first, string_VkFormat(rpci->pAttachments[index].format), 2844eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes describe_type(module, use.second.type_id).c_str())) { 2845eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes pass = false; 2846eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2847eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2848c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2849c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2850c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 285178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 285278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 285378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 285478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2855a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2856a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 28574c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool 28584c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvalidate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_STATE *pPipeline, 28594c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 28604c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { 28616660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 28625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 28645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 28665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 28675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 28685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 28695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 28715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 28736660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 287478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2875e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 287669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 287769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 28785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2880d5365427feb4a6c16371ecb651afa37b89dabd96Chris Forbes // if the shader stages are no good individually, cross-stage validation is pointless. 2881b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes if (!pass) 2882b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes return false; 2883b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes 28845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 28855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2887e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 28885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2891e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 28965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 28985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 29005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 29035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2905e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2906031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2907031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 29105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29138da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 2914e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 29158da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 29195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29214c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_STATE *pPipeline, 29224c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis VkPhysicalDeviceFeatures const *enabledFeatures, 29234c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const &shaderModuleMap) { 29246660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 292503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 292603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 292703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 292803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2929e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 293069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 293103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2933a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2934104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2935104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 29375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2938104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 29395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 29417a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 29427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 29437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 29447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 29457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 29467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2947e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 29487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 29491abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 29501abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis &activeSetBindingsPairs, 29511abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const char *function) { 2952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2953a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2954dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2955cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2956dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2957397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2958cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2959397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2960cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2961cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2962d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Descriptor set 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", 2963e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); 2964cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2965dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2970eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 29714c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(PIPELINE_STATE const *pipe) { 2972ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2973ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2974eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2975eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2976eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2977eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2978eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2979b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbesstatic void list_bits(std::ostream& s, uint32_t bits) { 2980b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes for (int i = 0; i < 32 && bits; i++) { 2981b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits & (1 << i)) { 2982b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << i; 2983b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes bits &= ~(1 << i); 2984b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits) { 2985b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << ","; 2986b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2987b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2988b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2989b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes} 2990b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 2991eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 29924c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool validatePipelineDrawtimeState(layer_data const *my_data, LAST_BOUND_STATE const &state, const GLOBAL_CB_NODE *pCB, 29934c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE const *pPipeline) { 2994eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 299529d196e071b2dc1db47702085469396f2b956820Chris Forbes 2996d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen // Verify vertex binding 299729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 299829d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 2999312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; 3000312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || 3001312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { 3002312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis skip_call |= log_msg( 3003312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3004312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 3005312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " 3006312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " 3007312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", 30084c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis (uint64_t)state.pipeline_state->pipeline, vertex_binding, i, vertex_binding); 300929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301129d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 301229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 301329d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 30145c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 30155c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 30165c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 30174c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline_state->pipeline); 301829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 302029d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 302129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 302229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 302329d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 302429d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 302529d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 302629d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 3027b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 302829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 3029b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; 3030b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; 3031b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingViewportMask) { 3032b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3033b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic viewport(s) "; 3034b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingViewportMask); 3035d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetViewport()."; 3036b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3037b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3038b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 303929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 304029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3041b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 304229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 3043b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; 3044b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; 3045b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingScissorMask) { 3046b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3047b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic scissor(s) "; 3048b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingScissorMask); 3049d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen ss << " are used by pipeline state object, but were not provided via calls to vkCmdSetScissor()."; 3050b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3051b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3052b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 305329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 305429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 305529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 305629d196e071b2dc1db47702085469396f2b956820Chris Forbes 305729d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 305829d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 305929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 306029d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 306129d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 306229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 3063fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); 306429d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 306529d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 306629d196e071b2dc1db47702085469396f2b956820Chris Forbes 306729d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 306829d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 306929d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 307029d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3071eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3072ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 3073eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 3074414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 3075eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 3076eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 3077ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 307829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3079eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 308076957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 30810a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 308229d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 308376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 308476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 308576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 308629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 30870a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 308876957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 308976957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 309076957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 309176957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 309229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3093eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 30940dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 309529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3096eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3097ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 3098414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 3099414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 3100ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 3101ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 3102eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 310329d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 310429d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 310529d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 310629d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 310729d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 3108eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3109eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3110528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 3111528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 3112528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 3113a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 3114fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->createInfo.ptr(), pPipeline->render_pass_ci.ptr(), 3115528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 3116528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 3117528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 3118528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3119528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3120528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 3121528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 31226de0e43adfbd3c049252412d998524e7edbd3796Chris Forbes reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), 31236de0e43adfbd3c049252412d998524e7edbd3796Chris Forbes reinterpret_cast<uint64_t const &>(pPipeline->pipeline), 3124528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 3125528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 3126c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes 3127c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { 3128c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes skip_call |= 3129c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3130c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes reinterpret_cast<uint64_t const &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3131c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes "Pipeline was built for subpass %u but used in subpass %u", pPipeline->graphicsPipelineCI.subpass, 3132c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes pCB->activeSubpass); 3133c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes } 3134528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 313529d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 313629d196e071b2dc1db47702085469396f2b956820Chris Forbes 3137eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 3138eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3139eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 3141aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlisstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexedDraw, 3142e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski const VkPipelineBindPoint bindPoint, const char *function) { 3143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3144aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis auto const &state = cb_node->lastBound[bindPoint]; 31454c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipe = state.pipeline_state; 314622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 314722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 314822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 314922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 315022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 315122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 315222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 315322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 315422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 31553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 31567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3157aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result = validate_draw_state_flags(my_data, cb_node, pPipe, indexedDraw); 31587a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 316069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 316122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 316269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 3163169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 316422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 31651abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 31661abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis activeSetBindingsPairs; 3167dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 316822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 316922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 317022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 317122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 317222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 3173414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 317422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 317569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 317669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 317769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 317871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 317922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 318022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 318122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 3182414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 3183414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 318469b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 318569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 318622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 318722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 318871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 3189aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Gather active bindings 3190aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis std::unordered_set<uint32_t> bindings; 3191aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : setBindingPair.second) { 3192aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis bindings.insert(binding.first); 3193aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis } 3194aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Bind this set and its active descriptor resources to the command buffer 3195aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis pSet->BindCommandBuffer(cb_node, bindings); 319622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 3197aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, &state.dynamicOffsets[setIndex])); 319822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 319922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 3200397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 3201aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : bindings) { 3202aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 320322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 320422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3205397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3206d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Descriptor Set 0x%" PRIxLEAST64 " bound but was never updated. It is now being used to draw so " 320722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3208397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3209fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 321322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 321422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 3215aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, cb_node, activeSetBindingsPairs, function); 321622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3217eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3218eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 321929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3220aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validatePipelineDrawtimeState(my_data, state, cb_node, pPipe); 3221eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3225a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3226a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3227a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3228a27508babf63d50aea75883a3702979193c23683Mark Young 3229a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3230f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if ((VK_FALSE == my_data->enabled_features.wideLines) && (1.0f != lineWidth)) { 3231a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3232a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3233a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3234a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3235a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3236a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3237a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3238a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3239a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3240a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3241a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3242a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3243a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3244a27508babf63d50aea75883a3702979193c23683Mark Young } 3245a27508babf63d50aea75883a3702979193c23683Mark Young } 3246a27508babf63d50aea75883a3702979193c23683Mark Young 3247a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3248a27508babf63d50aea75883a3702979193c23683Mark Young} 3249a27508babf63d50aea75883a3702979193c23683Mark Young 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 32514c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_STATE *> pPipelines, 3252e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 325383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32554c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeline = pPipelines[pipelineIndex]; 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 32614c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pBasePipeline = nullptr; 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 32635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 326483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 326583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 326683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 326983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 32774c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pBasePipeline = getPipelineState(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 328183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 328283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 328383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3288f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.independentBlend) { 32893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 329026c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3291c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 329206811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 329306811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 329406811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 329506811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 329606811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 329783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 329883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 329983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 330083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 330106811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3302c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3306f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.logicOp && 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 330883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3315a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 3318127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(my_data, pPipeline->graphicsPipelineCI.renderPass); 3319fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (renderPass && pPipeline->graphicsPipelineCI.subpass >= renderPass->createInfo.subpassCount) { 332083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 332183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 332283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 3323fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->createInfo.subpassCount - 1); 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3326f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->enabled_features, 332769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 332883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 333052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 333152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 333252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 333352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 333483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 333583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 333683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 333783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 333852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 333952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 334052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 334383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3345d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vertex Shader required"); 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 335083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 335183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 335283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 335983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 336083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 336183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3366ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3367ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 336883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 336983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 337083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 337183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3373ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3374ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 337683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 337783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 337883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 337983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 338083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3382ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 338383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 338483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 338583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 338683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 338783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3388ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3389ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 339083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 339183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 339283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 339383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 339483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 339583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3398a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3399a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3400a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 34016de0e43adfbd3c049252412d998524e7edbd3796Chris Forbes skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, 34026de0e43adfbd3c049252412d998524e7edbd3796Chris Forbes reinterpret_cast<uint64_t const &>(pPipeline->pipeline), 340383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3404a27508babf63d50aea75883a3702979193c23683Mark Young } 3405a27508babf63d50aea75883a3702979193c23683Mark Young } 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 341045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 341283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 341383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 341483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 341583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 341883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 341983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 342083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 342183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 342283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 343083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 343183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 343283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 343383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 343483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 343583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 343683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 344283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 344383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 344483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 344583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 344683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 344783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34515dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes 34525dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // If rasterization is not disabled, and subpass uses a depth/stencil 34535dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // attachment, pDepthStencilState must be a pointer to a valid structure 3454fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpass_desc = renderPass ? &renderPass->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; 34555dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (subpass_desc && subpass_desc->pDepthStencilAttachment && 34565dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 34575dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { 34585dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 34595dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 34605dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "Invalid Pipeline CreateInfo State: " 34615dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " 34625dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "depth/stencil attachment"); 34635dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 34645dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 346683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3473ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3474ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3482a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin EhlisDESCRIPTOR_POOL_STATE *getDescriptorPoolState(const layer_data *dev_data, const VkDescriptorPool pool) { 3483bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3484bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3487bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3518fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3520fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3523fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3526fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3529fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3530e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 353283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 35331d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 354383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 354483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 354583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 354683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 354883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3549fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 355083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3551fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3552fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3553fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3554fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 355783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 35604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 35614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 35624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 35694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 35724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 35764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 35784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 35814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 35824a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 35884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 35954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35964a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35974a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 35984a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35994a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 36014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 36024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 36044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 36054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 36064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 36104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 36114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 36124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 36134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 36144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 36154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 36174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 36274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 36284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 36294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 36304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 36314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 36344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36511facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(my_data, image); 36521facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state) 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 36571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (sub_data->second.size() >= (image_state->createInfo.arrayLayers * image_state->createInfo.mipLevels + 1)) { 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 368408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 368708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 368808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 368908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 369008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 369408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 369608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 369708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 37037068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 37047068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 37057068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 370608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 371008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 371108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 371208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 371308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 371408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 371508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 371808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 371908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 372108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 372208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 372308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 372408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 372708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 372908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 373379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 373479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 373512d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto image = view_state->create_info.image; 373679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 3743915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // TODO: If ImageView was created with depth or stencil, transition both layouts as 3744915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // the aspectMask is ignored and both are used. Verify that the extra implicit layout 3745915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // is OK for descriptor set layout validation 3746038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 374779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { 3748038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); 3749038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 3750038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 37600dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlisstatic bool validateIdleDescriptorSet(const layer_data *dev_data, VkDescriptorSet set, std::string func_str) { 3761219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.idle_descriptor_set) 37620dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 3763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 37640dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis auto set_node = dev_data->setMap.find(set); 37650dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis if (set_node == dev_data->setMap.end()) { 37660dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3768414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37711c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This covers various error cases so should pass error enum into this function and use passed in enum here 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 37731c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis skip_call |= 37740dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 37751c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis (uint64_t)(set), __LINE__, VALIDATION_ERROR_00919, "DS", 37761c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer. %s", 37771c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis func_str.c_str(), (uint64_t)(set), validation_error_map[VALIDATION_ERROR_00919]); 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3782f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3783e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 37849dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 37859dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 37869dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 37879dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3794c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3795cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 37969dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3798f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 3805a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pPool = getDescriptorPoolState(my_data, pool); 3806de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3807de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3808de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3809de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3810de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3811de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3812de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3813de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3814de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3816de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 38205121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 38215121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 38225121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 382372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 382472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3825414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38285121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3833400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3851e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3852d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3853d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3891a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 389283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3893a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3894a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3895a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 391083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 393483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 393883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 39487651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 395583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 39567651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 395783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 396483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39667e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For given object struct return a ptr of BASE_NODE type for its wrapping struct 39677e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin EhlisBASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { 39687e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_ptr = nullptr; 39697e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis switch (object_struct.type) { 39707e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 39717e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); 39727e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39737e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39747e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 3975d31a44af6da568692a73201825459689c9431867Tobin Ehlis base_ptr = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); 39767e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39777e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39787e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 39797e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); 39807e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39817e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 39834c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis base_ptr = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); 3984bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3985bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3986bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 39877e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); 39887e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39897e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39907e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 39917e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); 39927e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39937e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39947e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 39951facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis base_ptr = getImageState(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); 39967e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 39977e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 39987e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 39997e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); 4000bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 4001bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 40029822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 40037e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); 40049822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 40059822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 40067e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 4007a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis base_ptr = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); 4008ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 4009ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 40107e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 40117e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); 4012a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 4013a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 40147e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 4015c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis base_ptr = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); 4016a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4017a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 40187e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 4019127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis base_ptr = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); 40207e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40217e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40227e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 40237e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); 402456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 402556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 4026bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 40277e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis // TODO : Any other objects to be handled here? 40287e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis assert(0); 40297e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 4030bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 40317e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return base_ptr; 40327e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 40337e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis 40347e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 40357e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add object_binding to cmd buffer 40367e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add cb_binding to object 40377e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 40387e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_bindings->insert(cb_node); 40397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_node->object_bindings.insert(obj); 40407e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 40417e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 40427e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 40437e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); 40447e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis if (base_obj) 40457e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj->cb_bindings.erase(cb_node); 4046bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4049400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4050400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 4052b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 4063b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask = 0; 4064b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask = 0; 406593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 406672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 406772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 406872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 406993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 4071ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 4074e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 4077c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4082abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4088bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4089bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4090bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4091bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 40937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 40947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4095400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4096b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 4097d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 409893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 4099bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 4100bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 4101bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 4102bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4103a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis pCB->object_bindings.clear(); 410493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 410593c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 4106c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb_state = getFramebufferState(dev_data, framebuffer); 4107c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis if (fb_state) 4108c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->cb_bindings.erase(pCB); 410993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 411093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 41117003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 41164c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_STATE *pPipe) { 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4118ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4119ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 41204052946ae557337ff95f3725e879131b1c63f865Tobin Ehlis pCB->status |= CBSTATUS_ALL_STATE_SET; 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 41254052946ae557337ff95f3725e879131b1c63f865Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL_STATE_SET; 4126ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4127ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 41353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4159e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 416083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 41634c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 416783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 416883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 416983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 417083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 417183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 417483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 4181d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen DRAWSTATE_NONE, "DS", "Cmds in command buffer 0x%p", (void *)cb); 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 4184d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen // TODO : Need to pass cmdbuffer as srcObj here 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4186414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4193e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 419483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 419683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 419883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 419983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4205e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 4209414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 4210ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4218e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4229f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic void init_core_validation(instance_layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4230d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4231b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4235747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic void checkInstanceRegisterExtensions(const VkInstanceCreateInfo *pCreateInfo, instance_layer_data *instance_data) { 4236747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes for (uint32_t i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 4237747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SURFACE_EXTENSION_NAME)) 4238747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surfaceExtensionEnabled = true; 4239747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_EXTENSION_NAME)) 4240747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->displayExtensionEnabled = true; 4241747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 4242747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_ANDROID_SURFACE_EXTENSION_NAME)) 4243747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->androidSurfaceExtensionEnabled = true; 4244747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4245747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 4246747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_MIR_SURFACE_EXTENSION_NAME)) 4247747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->mirSurfaceExtensionEnabled = true; 4248747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4249747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 4250747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WAYLAND_SURFACE_EXTENSION_NAME)) 4251747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->waylandSurfaceExtensionEnabled = true; 4252747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4253747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 4254747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_WIN32_SURFACE_EXTENSION_NAME)) 4255747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->win32SurfaceExtensionEnabled = true; 4256747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4257747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 4258747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XCB_SURFACE_EXTENSION_NAME)) 4259747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->xcbSurfaceExtensionEnabled = true; 4260747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4261747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 4262747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_XLIB_SURFACE_EXTENSION_NAME)) 4263747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->xlibSurfaceExtensionEnabled = true; 4264747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif 4265747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 4266747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 4267747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 426889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 426989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 42765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4285f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), instance_layer_data_map); 428656a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 42879172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_init_instance_dispatch_table(*pInstance, &instance_data->dispatch_table, fpGetInstanceProcAddr); 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42899172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->report_data = debug_report_create_instance( 42909172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes &instance_data->dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, pCreateInfo->ppEnabledExtensionNames); 4291747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes checkInstanceRegisterExtensions(pCreateInfo, instance_data); 4292b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4293825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 430089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 43059172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_layer_data *instance_data = get_my_data_ptr(key, instance_layer_data_map); 43069172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DestroyInstance(instance, pAllocator); 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4308b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 43109172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes while (instance_data->logging_callback.size() > 0) { 43119172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkDebugReportCallbackEXT callback = instance_data->logging_callback.back(); 43129172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_destroy_msg_callback(instance_data->report_data, callback, pAllocator); 43139172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->logging_callback.pop_back(); 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43169172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes layer_debug_report_destroy_instance(instance_data->report_data); 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4320373469f006399d6b5204ee05db3b56beb168b36fMark Youngstatic void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 4326c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = false; 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 4331c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) 4332c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = true; 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4336838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 4337f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesbool ValidateRequestedQueueFamilyProperties(instance_layer_data *instance_data, VkPhysicalDevice gpu, const VkDeviceCreateInfo *create_info) { 4338838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 43394b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes auto physical_device_state = getPhysicalDeviceState(instance_data, gpu); 4340838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 43414b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!physical_device_state) { 43424b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4343838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4344838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 43454b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes } else if (QUERY_DETAILS != physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4346838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 43474b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4348838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4349838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4350838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4351838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4352838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4353838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 43547d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes if (requestedIndex >= physical_device_state->queue_family_properties.size()) { 4355838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 43564b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4357838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4358838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4359838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 43607d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties[requestedIndex].queueCount) { 4361838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 43624b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4363838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4364838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4365838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 43667d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes requestedIndex, physical_device_state->queue_family_properties[requestedIndex].queueCount, 4367838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4368838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4369838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4370838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4371838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4372838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4373838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4374f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 4375f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbesstatic bool ValidateRequestedFeatures(instance_layer_data *dev_data, VkPhysicalDevice phys, const VkPhysicalDeviceFeatures *requested_features) { 4376f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4377f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 43783bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto phys_device_state = getPhysicalDeviceState(dev_data, phys); 43793bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes const VkBool32 *actual = reinterpret_cast<VkBool32 *>(&phys_device_state->features); 4380825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4381f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4382f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4383f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4384f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4385f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4386f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4387f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4388f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4389838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4390f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4391f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4392f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4393f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4394f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4395f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4396f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 43973bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes if (errors && (UNCALLED == phys_device_state->vkGetPhysicalDeviceFeaturesState)) { 4398f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4399f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4400838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4401cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4402cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4403cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4404f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4405f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4406f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4407f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 440889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 440989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 4410f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), instance_layer_data_map); 4411f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4412f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4413f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4414f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 44153bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes skip_call |= ValidateRequestedFeatures(my_instance_data, gpu, pCreateInfo->pEnabledFeatures); 4416f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 44174b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, gpu, pCreateInfo); 4418f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 44191d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller if (skip_call) { 44201d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller return VK_ERROR_VALIDATION_FAILED_EXT; 44211d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller } 44221d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 442856a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4441b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 444407a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes my_device_data->instance_data = my_instance_data; 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 44464a0754042cf090e131e9e769d8a3633c228625beChris Forbes layer_init_device_dispatch_table(*pDevice, &my_device_data->dispatch_table, fpGetDeviceProcAddr); 44476c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 4450373469f006399d6b5204ee05db3b56beb168b36fMark Young checkDeviceRegisterExtensions(pCreateInfo, *pDevice); 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 44529172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 44549172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4455b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 44569172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties( 4457b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4460f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes my_device_data->enabled_features = *pCreateInfo->pEnabledFeatures; 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4462f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes memset(&my_device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4464b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 44659172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes my_instance_data->dispatch_table.GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4466b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 447489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 44755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 44763ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis bool skip = false; 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4480b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 4482fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap.clear(); 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4484f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4486f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4487f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4488a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4489a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4490a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4491fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 44981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 44991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 45040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 45050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 450758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4508400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 451057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 4511de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->alloc_info.allocationSize != 0) { 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 45133ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 45143ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 45153ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 45163ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 45173ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4522b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4525414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 45273ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis if (!skip) { 45284a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyDevice(device, pAllocator); 45293ec39aeb6d6f08fb1ee45f64f72543a710754c62Tobin Ehlis layer_data_map.erase(key); 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4538971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4539e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4545414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4551856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4552856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4553856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4554971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4555414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4556856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4557414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4558414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4559414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4560856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4561856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4562856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4563856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4564971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4565414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4566856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4567856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4568856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4569856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 457639d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 4577a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Loop through bound objects and increment their in_use counts 4578a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// For any unknown objects, flag an error 45792f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 4580162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis bool skip = false; 4581162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; 4582162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis BASE_NODE *base_obj = nullptr; 4583a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4584a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4585a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4586162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4587162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; 4588a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4589a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 459056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 4591d31a44af6da568692a73201825459689c9431867Tobin Ehlis base_obj = getSamplerState(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 4592162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_SAMPLER; 459356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 459456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 45952f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 4596162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); 4597162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_QUERY_POOL; 45982f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45992f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46002f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 46014c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis base_obj = getPipelineState(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); 4602162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_PIPELINE; 46032f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46042f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46052f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 4606162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 4607162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER; 46082f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46092f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46107e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 46117e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(obj.handle)); 46127e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER_VIEW; 46137e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46147e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46152f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 46161facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis base_obj = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 4617162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE; 46182f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46192f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46207e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 46217e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(obj.handle)); 46227e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE_VIEW; 46237e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46247e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46252f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 4626162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); 4627162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_EVENT; 46282f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46292f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46307e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 4631a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis base_obj = getDescriptorPoolState(dev_data, reinterpret_cast<VkDescriptorPool &>(obj.handle)); 46327e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_POOL; 46337e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46347e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46357e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 46367e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(obj.handle)); 46377e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_COMMAND_POOL; 46387e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46407e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 4641c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis base_obj = getFramebufferState(dev_data, reinterpret_cast<VkFramebuffer &>(obj.handle)); 46427e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_FRAMEBUFFER; 46437e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46447e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46457e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 4646127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis base_obj = getRenderPassState(dev_data, reinterpret_cast<VkRenderPass &>(obj.handle)); 46477e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_RENDERPASS; 46487e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46497e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46507e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 46517e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(obj.handle)); 46527e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DEVICE_MEMORY; 46537e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46547e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 4655a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4656a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4657a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4658a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4659162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis if (!base_obj) { 4660162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis skip |= 4661162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", 4662162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); 4663162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } else { 4664162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj->in_use.fetch_add(1); 4665162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } 4666a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4667162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis return skip; 4668a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4669a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 46719a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlisstatic bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 4672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4673a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 46749a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis cb_node->in_use.fetch_add(1); 46759a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); 4676a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4677a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below 46789a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); 4679a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : We should be able to remove the NULL look-up checks from the code below as long as 4680a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state 4681a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // should then be flagged prior to calling this function 46829a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 46849a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 46858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 46869a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4688414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46908718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46949a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 46954710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis auto event_state = getEventNode(dev_data, event); 46964710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state) 46974710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->write_in_use++; 4698c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4702b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4703b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 47047d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: untangle this. 4705b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4706b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4707b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4708b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4709b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4710b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4711b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4712b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4713b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4714414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4715414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4716b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4717b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4718b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4719b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4720b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4721b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4722b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 47237d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes 47247d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: nuke this completely. 4725b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4726b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4727b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4728b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4729b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4730b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4731b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4732b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4733b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4734b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4735a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Decrement in-use count for objects bound to command buffer 47362f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 473700e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis BASE_NODE *base_obj = nullptr; 4738a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 47397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = GetStateStructPtrFromObject(dev_data, obj); 474000e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis if (base_obj) { 474100e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj->in_use.fetch_sub(1); 474200e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis } 4743a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4744a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4745da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 47469867daedbf52debc77d6568162ee21e071699b80Chris Forbesstatic bool RetireWorkOnQueue(layer_data *dev_data, QUEUE_NODE *pQueue, uint64_t seq) 47479867daedbf52debc77d6568162ee21e071699b80Chris Forbes{ 47489867daedbf52debc77d6568162ee21e071699b80Chris Forbes bool skip_call = false; // TODO: extract everything that might fail to precheck 47499867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; 47509867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47519867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll this queue forward, one submission at a time. 47529867daedbf52debc77d6568162ee21e071699b80Chris Forbes while (pQueue->seq < seq) { 47539867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & submission = pQueue->submissions.front(); 47549867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47559867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & wait : submission.waitSemaphores) { 47569867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); 4757da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 47589867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & lastSeq = otherQueueSeqs[wait.queue]; 47599867daedbf52debc77d6568162ee21e071699b80Chris Forbes lastSeq = std::max(lastSeq, wait.seq); 4760da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4761cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 47629867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & semaphore : submission.signalSemaphores) { 47639867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 47649867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_sub(1); 47659867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4766cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 47679867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto cb : submission.cbs) { 47689a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto cb_node = getCBNode(dev_data, cb); 4769a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First perform decrement on general case bound objects 47709a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis DecrementBoundResources(dev_data, cb_node); 47719a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 47729867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto buffer : drawDataElement.buffers) { 47739867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto buffer_node = getBufferNode(dev_data, buffer); 47749867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (buffer_node) { 47759867daedbf52debc77d6568162ee21e071699b80Chris Forbes buffer_node->in_use.fetch_sub(1); 47769867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47779867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4778da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 47799a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 47809867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 47819867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 47829867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.write_in_use--; 47839867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47849867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47859a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto queryStatePair : cb_node->queryToStateMap) { 47869867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 47879867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47889a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto eventStagePair : cb_node->eventToStageMap) { 47899867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4790da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 47910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 47929867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= cleanInFlightCmdBuffer(dev_data, cb); 47939867daedbf52debc77d6568162ee21e071699b80Chris Forbes removeInFlightCmdBuffer(dev_data, cb); 47940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 47959867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47969867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, submission.fence); 47979867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 47989867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->state = FENCE_RETIRED; 47990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48009867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48019867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.pop_front(); 48029867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->seq++; 4803b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 48049867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48059867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll other queues forward to the highest seq we saw a wait for 48069867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto qs : otherQueueSeqs) { 48079867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, getQueueNode(dev_data, qs.first), qs.second); 4808d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48109867daedbf52debc77d6568162ee21e071699b80Chris Forbes return skip_call; 48119867daedbf52debc77d6568162ee21e071699b80Chris Forbes} 4812651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4813651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4814651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4815651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4816651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 48179867daedbf52debc77d6568162ee21e071699b80Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) 4818651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4819cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 48209867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = pQueue->queue; 48219867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; 4822b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4823b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4824e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 483027c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4831414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 483775b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *call_source) { 4838c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis bool skip = false; 4839219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.command_buffer_state) 4840c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 48410a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 48420a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 4843c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4844c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4845d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Commandbuffer 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4846c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 4847c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 48480a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4853e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4854e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4855e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4856e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4857e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4859c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 48615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4862e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4863e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4864e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 4867c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4868c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4869d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "You must call vkEndCommandBuffer() on command buffer 0x%" PRIxLEAST64 " before this call to %s!", 4870c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), call_source); 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4873c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48767bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Validate that queueFamilyIndices of primary command buffers match this queue 48777bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Secondary command buffers were previously validated in vkCmdExecuteCommands(). 48787bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinskistatic bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { 48797bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski bool skip_call = false; 48807bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 48817bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto queue_node = getQueueNode(dev_data, queue); 48827bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 48837bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (pPool && queue_node && (pPool->queueFamilyIndex != queue_node->queueFamilyIndex)) { 48847bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 48857bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 48867bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkQueueSubmit: Primary command buffer 0x%" PRIxLEAST64 48877bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d is being submitted on queue 0x%" PRIxLEAST64 " from queue family %d.", 48887bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), pPool->queueFamilyIndex, 48897bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(queue), queue_node->queueFamilyIndex); 48907bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 48917bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 48927bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski return skip_call; 48937bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski} 48947bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 4895da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 48965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 489783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4898a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4899a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 4900a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 490183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 4902a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 490383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 4904a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 490883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 49094c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 49104c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 49115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4913d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Commandbuffer 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4915414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 49164c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4922a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 492375b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()"); 4924a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 492583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 49265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 492881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4929651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 493081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 493183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 493281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4933651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4934cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 493583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 493683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 493783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4938a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 493981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4940cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 494183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 494283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 494383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 494483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 494583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 4946a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 494881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 494983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 495081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 495181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4952651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 495381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 495481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 495583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 495681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 495781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 495881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 495981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4960651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4961651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 496283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 496381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 496483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 4965d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4966d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4967d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 49681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 49691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 49701344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4971651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4972651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4973651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 49749867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, std::max(1u, submitCount)); 4975651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4976651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49809867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<SEMAPHORE_WAIT> semaphore_waits; 49819867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<VkSemaphore> semaphore_signals; 49825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 498301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 498401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 498501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 498601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 49879867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 49889867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 49899867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 49909867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 49919867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 499201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 49931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 499483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 49951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4997414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 49981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 49991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 500301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 500401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 500501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 500601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 500783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 50081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 50091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 5010414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 5011414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 50121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 50139867daedbf52debc77d6568162ee21e071699b80Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); 50141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 50159867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 50169867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 501701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 5018da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 50199867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 50201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50210a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5023651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5024da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 5025da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 5027d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis auto cb_node = getCBNode(dev_data, submit->pCommandBuffers[i]); 5028d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, cb_node); 5029d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis if (cb_node) { 5030da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 5031d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto secondaryCmdBuffer : cb_node->secondaryCommandBuffers) { 5032da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 5033651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 5034651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5035d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis cb_node->submitCount++; // increment submit count 5036d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, cb_node); 5037d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis skip_call |= validateQueueFamilyIndices(dev_data, cb_node, queue); 5038ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis // Potential early exit here as bad object state may crash in delayed function calls 5039ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (skip_call) 5040ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis return result; 50411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 5042d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto &function : cb_node->validate_functions) { 504383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 50441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 5045d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto &function : cb_node->eventUpdates) { 504683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 50471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 5048d74f8771414d9e80618cd7604ea4b1c459dfa42eTobin Ehlis for (auto &function : cb_node->queryUpdates) { 504983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 5050d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 50511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5053da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 50549867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, 50559867daedbf52debc77d6568162ee21e071699b80Chris Forbes submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); 50569867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 50579867daedbf52debc77d6568162ee21e071699b80Chris Forbes 50589867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !submitCount) { 50599867daedbf52debc77d6568162ee21e071699b80Chris Forbes // If no submissions, but just dropping a fence on the end of the queue, 50609867daedbf52debc77d6568162ee21e071699b80Chris Forbes // record an empty submission with just the fence, so we can determine 50619867daedbf52debc77d6568162ee21e071699b80Chris Forbes // its completion. 50629867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 50639867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 50649867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 50659867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50679867daedbf52debc77d6568162ee21e071699b80Chris Forbes 5068b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 506983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 50704a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.QueueSubmit(queue, submitCount, pSubmits, fence); 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 507589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 507689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50784a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = my_data->dispatch_table.AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5080b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 50820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5086177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis// For given obj node, if it is use, flag a validation error and return callback result, else return false 5087177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlisbool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct, 5088177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis UNIQUE_VALIDATION_ERROR_CODE error_code) { 5089177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis if (dev_data->instance_data->disabled.object_in_use) 5090177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis return false; 5091177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis bool skip = false; 5092177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis if (obj_node->in_use.load()) { 5093177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, 5094177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis error_code, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer. %s", 5095177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis object_type_to_string(obj_struct.type), obj_struct.handle, validation_error_map[error_code]); 5096177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis } 5097177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis return skip; 5098177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis} 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5100177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlisstatic bool PreCallValidateFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO **mem_info, VK_OBJECT *obj_struct) { 510194165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *mem_info = getMemObjInfo(dev_data, mem); 510294165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(mem), VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT}; 5103177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis if (dev_data->instance_data->disabled.free_memory) 5104177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis return false; 5105177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis bool skip = false; 5106177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis if (*mem_info) { 5107177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *mem_info, *obj_struct, VALIDATION_ERROR_00620); 5108177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis } 5109177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis return skip; 5110177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis} 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5112177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlisstatic void PostCallRecordFreeMemory(layer_data *dev_data, VkDeviceMemory mem, DEVICE_MEM_INFO *mem_info, VK_OBJECT obj_struct) { 5113177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis // Clear mem binding for any bound objects 511447705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis for (auto obj : mem_info->obj_bindings) { 511547705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, MEMTRACK_FREED_MEM_REF, 511647705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, obj.handle, 511747705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis (uint64_t)mem_info->mem); 511847705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis switch (obj.type) { 511947705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 512047705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis auto image_state = getImageState(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 512147705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis assert(image_state); // Any destroyed images should already be removed from bindings 512247705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis image_state->binding.mem = MEMORY_UNBOUND; 512347705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis break; 512447705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis } 512547705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 512647705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis auto buff_node = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 512747705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis assert(buff_node); // Any destroyed buffers should already be removed from bindings 512847705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis buff_node->binding.mem = MEMORY_UNBOUND; 512947705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis break; 513047705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis } 513147705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis default: 513247705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis // Should only have buffer or image objects bound to memory 513347705d01140c9f1492885e6efc5fa262e7e1c6a0Tobin Ehlis assert(0); 5134177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis } 5135177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis } 5136177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis // Any bound cmd buffers are now invalid 5137177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis invalidateCommandBuffers(mem_info->cb_bindings, obj_struct); 5138177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis dev_data->memObjMap.erase(mem); 5139177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis} 5140177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis 5141177063aac84fac6f4e650c2629a08b48be643f96Tobin EhlisVKAPI_ATTR void VKAPI_CALL FreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 5142177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5143177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis DEVICE_MEM_INFO *mem_info = nullptr; 5144177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis VK_OBJECT obj_struct; 5145b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5146177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis bool skip = PreCallValidateFreeMemory(dev_data, mem, &mem_info, &obj_struct); 5147177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis if (!skip) { 5148177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis lock.unlock(); 5149177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis dev_data->dispatch_table.FreeMemory(device, mem, pAllocator); 5150177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis lock.lock(); 5151177063aac84fac6f4e650c2629a08b48be643f96Tobin Ehlis PostCallRecordFreeMemory(dev_data, mem, mem_info, obj_struct); 515274243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5155f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// Validate that given Map memory range is valid. This means that the memory should not already be mapped, 5156f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// and that the size of the map range should be: 5157f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 1. Not zero 5158f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 2. Within the size of the memory allocation 5159f57fc64ac43691ad98e1713886b345465573070aTobin Ehlisstatic bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 516083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 516383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 516483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 516583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 517057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 5172de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.size != 0) { 517383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 517483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 517583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 51765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 51795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 5180de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (offset >= mem_info->alloc_info.allocationSize) { 518183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 518283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 518383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 518483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 5185de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5188de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((offset + size) > mem_info->alloc_info.allocationSize) { 518983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 519057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 519157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 519257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 5193de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size + offset, mem_info->alloc_info.allocationSize); 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 519783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5200e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 520157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 520257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5203de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.offset = offset; 5204de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = size; 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5208e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 520983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 521057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 521157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5212de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!mem_info->mem_range.size) { 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 521483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 521583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 521683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 52175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5218de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = 0; 52195f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 52205f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski free(mem_info->shadow_copy_base); 52215f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = 0; 52225f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 522583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52285f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski// Guard value for pad data 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52315f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, 52325f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski void **ppData) { 523357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 523457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5235de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->p_driver_data = *ppData; 5236de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis uint32_t index = mem_info->alloc_info.memoryTypeIndex; 5237b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 52385f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 52415f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski size = mem_info->alloc_info.allocationSize - offset; 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52435f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 52445f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(mem_info->shadow_pad_size, 52455f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); 52465f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Ensure start of mapped region reflects hardware alignment constraints 52475f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 52485f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52495f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. 52505f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t start_offset = offset % map_alignment; 52515f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. 52526e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski mem_info->shadow_copy_base = malloc(static_cast<size_t>(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset)); 52535f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52545f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 52555f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & 52565f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ~(map_alignment - 1)) + start_offset; 52575f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, 52585f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski map_alignment) == 0); 52595f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52606e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, static_cast<size_t>(2 * mem_info->shadow_pad_size + size)); 52615f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52655f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 5266a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 52679867daedbf52debc77d6568162ee21e071699b80Chris Forbes// a fence being waited on should not already be signaled and 5268a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 526949f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 527083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 52719b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 527249f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 52739b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 5274cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 527583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 527683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 527783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 527883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 527983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 528283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5284a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 5285b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbesstatic bool RetireFence(layer_data *dev_data, VkFence fence) { 5286b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes auto pFence = getFenceNode(dev_data, fence); 5287b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 5288b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes /* Fence signaller is a queue -- use this as proof that prior operations 5289b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes * on that queue have completed. 5290b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes */ 5291b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes return RetireWorkOnQueue(dev_data, 5292b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 5293b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes pFence->signaler.second); 5294b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes } 5295d4513979120463171eb479cdded9336eb9944da1Chris Forbes else { 5296d4513979120463171eb479cdded9336eb9944da1Chris Forbes /* Fence signaller is the WSI. We're not tracking what the WSI op 5297d4513979120463171eb479cdded9336eb9944da1Chris Forbes * actually /was/ in CV yet, but we need to mark the fence as retired. 5298d4513979120463171eb479cdded9336eb9944da1Chris Forbes */ 5299d4513979120463171eb479cdded9336eb9944da1Chris Forbes pFence->state = FENCE_RETIRED; 5300d4513979120463171eb479cdded9336eb9944da1Chris Forbes return false; 5301d4513979120463171eb479cdded9336eb9944da1Chris Forbes } 5302b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes} 5303b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes 530489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 530589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5307e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5309b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 531149f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5316a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 53174a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.WaitForFences(device, fenceCount, pFences, waitAll, timeout); 5318414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5320b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 53239867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (uint32_t i = 0; i < fenceCount; i++) { 5324b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes skip_call |= RetireFence(dev_data, pFences[i]); 53259867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5330b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5332e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 533789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 533983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5340b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 534183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 5342b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5343a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 534483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 534583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5346a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 53474a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetFenceStatus(device, fence); 5348b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5350d4513979120463171eb479cdded9336eb9944da1Chris Forbes skip_call |= RetireFence(dev_data, fence); 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5353e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5359b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53614a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5362b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5363b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5364b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5365b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5366b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5367b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 53688988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 53697bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski pQNode->queueFamilyIndex = queueFamilyIndex; 53709867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQNode->seq = 0; 5371b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 537489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5376e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53779867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 53789867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 53799867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, pQueue, pQueue->seq + pQueue->submissions.size()); 53809867daedbf52debc77d6568162ee21e071699b80Chris Forbes lock.unlock(); 5381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53834a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.QueueWaitIdle(queue); 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 538789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5390b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53919867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & queue : dev_data->queueMap) { 53929867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5395e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53974a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.DeviceWaitIdle(device); 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 540189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 540383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5404b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 54061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5407cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 540883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 540983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 541083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 54111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 54121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5414b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 541683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 54174a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyFence(device, fence, pAllocator); 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 542089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 542189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5423eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5424e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5425eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis auto sema_node = getSemaphoreNode(dev_data, semaphore); 5426eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (sema_node) { 5427eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sema_node, 54281803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}, 54291803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis VALIDATION_ERROR_00199); 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5431eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (!skip) { 5432eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->semaphoreMap.erase(semaphore); 5433eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis lock.unlock(); 54344a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySemaphore(device, semaphore, pAllocator); 543599d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller } 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54384710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlisstatic bool PreCallValidateDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE **event_state, VK_OBJECT *obj_struct) { 543994165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *event_state = getEventNode(dev_data, event); 544094165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; 5441d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis if (dev_data->instance_data->disabled.destroy_event) 5442d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis return false; 5443d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis bool skip = false; 5444d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis if (*event_state) { 5445d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *event_state, *obj_struct, VALIDATION_ERROR_00213); 5446d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis } 5447d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis return skip; 5448d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis} 5449d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis 54504710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlisstatic void PostCallRecordDestroyEvent(layer_data *dev_data, VkEvent event, EVENT_STATE *event_state, VK_OBJECT obj_struct) { 5451d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis invalidateCommandBuffers(event_state->cb_bindings, obj_struct); 5452d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis dev_data->eventMap.erase(event); 5453d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis} 5454d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis 545589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54574710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis EVENT_STATE *event_state = nullptr; 5458d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis VK_OBJECT obj_struct; 5459b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5460d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis bool skip = PreCallValidateDestroyEvent(dev_data, event, &event_state, &obj_struct); 5461f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5462f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 54634a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyEvent(device, event, pAllocator); 5464d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis lock.lock(); 5465d379c77e4254a740aa838a82e7af186525524617Tobin Ehlis PostCallRecordDestroyEvent(dev_data, event, event_state, obj_struct); 5466f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 546989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 547089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5471ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5472eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5473ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5474ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5475ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5476eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; 54771803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, qp_node, obj_struct, VALIDATION_ERROR_01012); 5478ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5479eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, obj_struct); 5480ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5481f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5482f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5483f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 54844a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyQueryPool(device, queryPool, pAllocator); 5485f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 548889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 548989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 549089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5493b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5495971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5500e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5506ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5507ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5508ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5509ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5510971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5511ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5512ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5513ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5514ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5515414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5516ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5517ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5518ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5519ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5520ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5521ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5522ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5523ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5524ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5525ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5526ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5527ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5528ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5529971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5530ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5531ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5532ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5535414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5538ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5539ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5542414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5544ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5545ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5546ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5547ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5548414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5549ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5550ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5554b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55574a0754042cf090e131e9e769d8a3633c228625beChris Forbes return dev_data->dispatch_table.GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, flags); 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55628718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 55638718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5566414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 55688718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5571414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5577825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if given ranges intersect, else false 5578825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted 5579825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// in an error so not checking that here 5580825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// pad_ranges bool indicates a linear and non-linear comparison which requires padding 5581825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call 5582825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// may be set by the callback function so caller should merge in skip_call value if padding case is possible. 55837dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { 55847dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call = false; 5585825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_start = range1->start; 5586825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_end = range1->end; 5587825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_start = range2->start; 5588825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_end = range2->end; 5589825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkDeviceSize pad_align = 1; 5590825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5591825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; 5592825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5593825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) 5594825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 5595825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) 5596825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 559747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5598825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5599825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // In linear vs. non-linear case, it's an error to alias 5600825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; 5601825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_type_str = range1->image ? "image" : "buffer"; 5602825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; 5603825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_type_str = range2->image ? "image" : "buffer"; 5604825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; 56057dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call |= 5606825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, 5607825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 5608825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis " which is in violation of the Buffer-Image Granularity section of the Vulkan specification.", 5609825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); 561047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 5611825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Ranges intersect 5612825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return true; 561347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 5614623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis// Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses 5615cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { 5616825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Create a local MEMORY_RANGE struct to wrap offset/size 5617825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis MEMORY_RANGE range_wrap; 5618825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Synch linear with range1 to avoid padding and potential validation error case 5619825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.linear = range1->linear; 5620825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.start = offset; 5621cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis range_wrap.end = end; 5622825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool tmp_bool; 56237dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); 5624825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5625cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given mem_info, set all ranges valid that intersect [offset-end] range 5626cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid 5627cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { 5628cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis bool tmp_bool = false; 5629cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis MEMORY_RANGE map_range; 5630cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.linear = true; 5631cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.start = offset; 5632cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.end = end; 5633cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto &handle_range_pair : mem_info->bound_ranges) { 56347dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { 5635cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : WARN here if tmp_bool true? 5636cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis handle_range_pair.second.valid = true; 5637cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5638cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5639cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis} 5640825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Object with given handle is being bound to memory w/ given mem_info struct. 5641825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Track the newly bound memory range with given memoryOffset 5642825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear 5643825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// and non-linear range incorrectly overlap. 5644825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if an error is flagged and the user callback returns "true", otherwise false 5645825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates an image object, otherwise handle is for a buffer 5646825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_linear indicates a buffer or linear image 5647825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, 5648825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { 5649825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool skip_call = false; 56505360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis MEMORY_RANGE range; 5651825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5652825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.image = is_image; 565347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 5654825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.linear = is_linear; 5655f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis range.valid = mem_info->global_valid; 5656825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.memory = mem_info->mem; 565747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 5658825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.size = memRequirements.size; 565947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 56605360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis range.aliases.clear(); 56615360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Update Memory aliasing 56625360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Save aliase ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we 56635360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself 56645360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; 5665825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto &obj_range_pair : mem_info->bound_ranges) { 5666825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto check_range = &obj_range_pair.second; 56675360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis bool intersection_error = false; 56687dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { 5669825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis skip_call |= intersection_error; 5670825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.aliases.insert(check_range); 56715360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_alias_ranges.insert(check_range); 5672825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5673825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 56745360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis mem_info->bound_ranges[handle] = std::move(range); 56755360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis for (auto tmp_range : tmp_alias_ranges) { 56765360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); 56775360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis } 5678825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5679825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.insert(handle); 5680825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5681825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.insert(handle); 5682825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5683825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return skip_call; 568447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 568547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 56869f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5687825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs, bool is_linear) { 56889f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); 5689825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5690825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 56919f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5692825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs) { 56939f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); 5694825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5695825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5696825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info 5697825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates if handle is for image or buffer 5698825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// This function will also remove the handle-to-index mapping from the appropriate 5699825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// map and clean up any aliases for range being removed. 5700825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { 5701825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto erase_range = &mem_info->bound_ranges[handle]; 5702825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto alias_range : erase_range->aliases) { 5703825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis alias_range->aliases.erase(erase_range); 570447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57055360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis erase_range->aliases.clear(); 5706825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_ranges.erase(handle); 57071cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis if (is_image) { 5708825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.erase(handle); 57091cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } else { 5710825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.erase(handle); 57111cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 571247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 571347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5714825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } 5715825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5716825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } 5717825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 571889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 571989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 57205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5721b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57225a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5723e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5724e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5725e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5726e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5727e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5728e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5729e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->binding.mem); 5730e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5731825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); 5732e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5733f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis ClearMemoryObjectBindings(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5734e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5735e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5736b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57374a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyBuffer(device, buffer, pAllocator); 573847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57418e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic bool PreCallValidateDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE **buffer_view_state, 57428e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT *obj_struct) { 574394165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *buffer_view_state = getBufferViewState(dev_data, buffer_view); 574494165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}; 5745219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_buffer_view) 57467626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis return false; 57478e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = false; 5748f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis if (*buffer_view_state) { 57491803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *buffer_view_state, *obj_struct, VALIDATION_ERROR_00701); 57508e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis } 57518e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis return skip; 57528e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 57538e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 57548e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic void PostCallRecordDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE *buffer_view_state, 57558e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct) { 57568e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Any bound cmd buffers are now invalid 57578e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis invalidateCommandBuffers(buffer_view_state->cb_bindings, obj_struct); 5758c6f1a9ab8d9bee0a805a298c9d28f5e81f8877b5Tobin Ehlis dev_data->bufferViewMap.erase(buffer_view); 57598e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 57608e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 576189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 576289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5764f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Common data objects used pre & post call 57658e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis BUFFER_VIEW_STATE *buffer_view_state = nullptr; 57668e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct; 5767a123662876eebfa844faa65ae3f071d3d77618ebTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 57688e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Validate state before calling down chain, update common data if we'll be calling down chain 57698e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); 577038e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis if (!skip) { 577138e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis lock.unlock(); 57724a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyBufferView(device, bufferView, pAllocator); 57738e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis lock.lock(); 57748e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57781facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic bool PreCallValidateDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE **image_state, VK_OBJECT *obj_struct) { 577994165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *image_state = getImageState(dev_data, image); 578094165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}; 5781219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_image) 57822a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis return false; 5783f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis bool skip = false; 57842a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (*image_state) { 57852a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *image_state, *obj_struct, VALIDATION_ERROR_00743); 5786f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis } 57872a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis return skip; 57882a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis} 5789f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis 57901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic void PostCallRecordDestroyImage(layer_data *dev_data, VkImage image, IMAGE_STATE *image_state, VK_OBJECT obj_struct) { 57912a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis invalidateCommandBuffers(image_state->cb_bindings, obj_struct); 57922a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis // Clean up memory mapping, bindings and range references for image 5793e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, image_state->binding.mem); 57942a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (mem_info) { 57952a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis RemoveImageMemoryRange(obj_struct.handle, mem_info); 57962a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis } 57974bd8f42e6f6542c0eac2492ce70edc6bebc6a2d8Tobin Ehlis ClearMemoryObjectBindings(dev_data, obj_struct.handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 57982a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis // Remove image from imageMap 57992a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageMap.erase(image); 58002a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis 58012a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis const auto &sub_entry = dev_data->imageSubresourceMap.find(image); 58022a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (sub_entry != dev_data->imageSubresourceMap.end()) { 58032a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis for (const auto &pair : sub_entry->second) { 58042a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58062a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis dev_data->imageSubresourceMap.erase(sub_entry); 58072a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis } 58082a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis} 58092a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis 58102a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin EhlisVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 58112a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58121facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis IMAGE_STATE *image_state = nullptr; 58132a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis VK_OBJECT obj_struct; 58142a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 58152a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis bool skip = PreCallValidateDestroyImage(dev_data, image, &image_state, &obj_struct); 58162a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis if (!skip) { 5817f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis lock.unlock(); 58184a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyImage(device, image, pAllocator); 58192a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis lock.lock(); 58202a0dd15a44bf665c97a3ff6adcbe7fe5853cdf60Tobin Ehlis PostCallRecordDestroyImage(dev_data, image, image_state, obj_struct); 58215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58244261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 58254261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 58264261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 5827de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { 5828de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis skip_call = log_msg( 5829de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5830de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 5831de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 5832de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "type (0x%X) of this memory object 0x%" PRIx64 ".", 5833de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, reinterpret_cast<const uint64_t &>(mem_info->mem)); 58344261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 58354261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 58364261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 58374261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 583889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 583989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 584058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5842b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 58435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58449f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); 5845888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool skip_call = SetMemBinding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 58468718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 58478718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 58494a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, &memRequirements); 5850e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis buffer_node->binding.mem = mem; 5851e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis buffer_node->binding.offset = memoryOffset; 5852e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis buffer_node->binding.size = memRequirements.size; 585347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 585447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 585557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 585657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 58579f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, memRequirements); 585883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 585947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 586047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 58612c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58622c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 586383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 58642c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58652c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5866414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5867414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 58682c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58692c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58702c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5871ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 58722c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5873ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5874ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5875ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5876ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5877ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5878ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5879ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5880ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5881ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5882ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5883ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5884ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5885ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5886ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5887ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5888ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5889ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5890ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5891ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 58928718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5893ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5894ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5895ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5896ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5897ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5898ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5899ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5900ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5901ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5902ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5903ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 59042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59052c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 59065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5908b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 590983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 59104a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.BindBufferMemory(device, buffer, mem, memoryOffset); 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 591589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 591689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 59204a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 59215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 592389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 592489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59284a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.GetImageMemoryRequirements(device, image, pMemoryRequirements); 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5930593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 5931f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlisstatic bool PreCallValidateDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE **image_view_state, 5932f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT *obj_struct) { 593394165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *image_view_state = getImageViewState(dev_data, image_view); 593494165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}; 5935219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_image_view) 5936f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis return false; 5937f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis bool skip = false; 5938f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis if (*image_view_state) { 59391803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *image_view_state, *obj_struct, VALIDATION_ERROR_00776); 5940f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis } 5941f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis return skip; 5942f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis} 5943f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis 5944f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlisstatic void PostCallRecordDestroyImageView(layer_data *dev_data, VkImageView image_view, IMAGE_VIEW_STATE *image_view_state, 5945f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT obj_struct) { 5946f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Any bound cmd buffers are now invalid 5947f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis invalidateCommandBuffers(image_view_state->cb_bindings, obj_struct); 5948f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis dev_data->imageViewMap.erase(image_view); 5949f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis} 5950f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis 595189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 595289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 5953d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5954f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis // Common data objects used pre & post call 5955f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis IMAGE_VIEW_STATE *image_view_state = nullptr; 5956f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis VK_OBJECT obj_struct; 5957a123662876eebfa844faa65ae3f071d3d77618ebTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5958f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis bool skip = PreCallValidateDestroyImageView(dev_data, imageView, &image_view_state, &obj_struct); 5959d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis if (!skip) { 5960d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis lock.unlock(); 59614a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyImageView(device, imageView, pAllocator); 5962f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis lock.lock(); 5963f61017735c3291a2665487f2bac310578fc60a68Tobin Ehlis PostCallRecordDestroyImageView(dev_data, imageView, image_view_state, obj_struct); 5964d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis } 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 596889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5969918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5970918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5971b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5972918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5974918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 59754a0754042cf090e131e9e769d8a3633c228625beChris Forbes my_data->dispatch_table.DestroyShaderModule(device, shaderModule, pAllocator); 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59784c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic bool PreCallValidateDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE **pipeline_state, 59798bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT *obj_struct) { 598094165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *pipeline_state = getPipelineState(dev_data, pipeline); 598194165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; 5982219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_pipeline) 59838bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis return false; 59848bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis bool skip = false; 59858bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis if (*pipeline_state) { 59861803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *pipeline_state, *obj_struct, VALIDATION_ERROR_00555); 59878bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis } 59888bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis return skip; 59898bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis} 59908bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis 59914c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisstatic void PostCallRecordDestroyPipeline(layer_data *dev_data, VkPipeline pipeline, PIPELINE_STATE *pipeline_state, 59928bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT obj_struct) { 59938bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis // Any bound cmd buffers are now invalid 59948bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis invalidateCommandBuffers(pipeline_state->cb_bindings, obj_struct); 59958bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis dev_data->pipelineMap.erase(pipeline); 59968bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis} 59978bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis 599889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 599989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 6000a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60014c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pipeline_state = nullptr; 60028bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis VK_OBJECT obj_struct; 6003e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 60048bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis bool skip = PreCallValidateDestroyPipeline(dev_data, pipeline, &pipeline_state, &obj_struct); 6005f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 6006f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 60074a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipeline(device, pipeline, pAllocator); 60088bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis lock.lock(); 60098bd2ec9a26cca477de2de93304774cdba0af77bcTobin Ehlis PostCallRecordDestroyPipeline(dev_data, pipeline, pipeline_state, obj_struct); 6010f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 601389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 601489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 60156792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6016e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 60176792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 6018e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 6019e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 60204a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipelineLayout(device, pipelineLayout, pAllocator); 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6023d31a44af6da568692a73201825459689c9431867Tobin Ehlisstatic bool PreCallValidateDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE **sampler_state, 6024806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis VK_OBJECT *obj_struct) { 602594165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *sampler_state = getSamplerState(dev_data, sampler); 602694165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; 6027806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis if (dev_data->instance_data->disabled.destroy_sampler) 6028806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis return false; 6029806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis bool skip = false; 6030806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis if (*sampler_state) { 6031806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *sampler_state, *obj_struct, VALIDATION_ERROR_00837); 6032806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis } 6033806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis return skip; 6034806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis} 6035806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis 6036d31a44af6da568692a73201825459689c9431867Tobin Ehlisstatic void PostCallRecordDestroySampler(layer_data *dev_data, VkSampler sampler, SAMPLER_STATE *sampler_state, 6037806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis VK_OBJECT obj_struct) { 6038806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis // Any bound cmd buffers are now invalid 603994165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis if (sampler_state) 604094165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis invalidateCommandBuffers(sampler_state->cb_bindings, obj_struct); 6041806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis dev_data->samplerMap.erase(sampler); 6042806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis} 6043806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis 604489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 604589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 604656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6047d31a44af6da568692a73201825459689c9431867Tobin Ehlis SAMPLER_STATE *sampler_state = nullptr; 6048806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis VK_OBJECT obj_struct; 604956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 6050806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis bool skip = PreCallValidateDestroySampler(dev_data, sampler, &sampler_state, &obj_struct); 6051f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 6052f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 60534a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySampler(device, sampler, pAllocator); 6054806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis lock.lock(); 6055806095ea973371ad4c82bd0c2c58d53cc5557f0bTobin Ehlis PostCallRecordDestroySampler(dev_data, sampler, sampler_state, obj_struct); 6056f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 605989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 606089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 6061e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60634a0754042cf090e131e9e769d8a3633c228625beChris Forbes ->dispatch_table.DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6066c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlisstatic bool PreCallValidateDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool pool, 6067a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE **desc_pool_state, VK_OBJECT *obj_struct) { 606894165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *desc_pool_state = getDescriptorPoolState(dev_data, pool); 606994165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(pool), VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT}; 6070219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_descriptor_pool) 6071c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis return false; 6072c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis bool skip = false; 6073c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis if (*desc_pool_state) { 60741803032f91d772ff3589c9f5a51ade5b299ba538Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *desc_pool_state, *obj_struct, VALIDATION_ERROR_00901); 6075c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 6076c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis return skip; 6077c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis} 6078c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis 6079c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlisstatic void PostCallRecordDestroyDescriptorPool(layer_data *dev_data, VkDescriptorPool descriptorPool, 6080a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *desc_pool_state, VK_OBJECT obj_struct) { 6081c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis // Any bound cmd buffers are now invalid 6082c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis invalidateCommandBuffers(desc_pool_state->cb_bindings, obj_struct); 6083c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis // Free sets that were in this pool 6084c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis for (auto ds : desc_pool_state->sets) { 6085c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis freeDescriptorSet(dev_data, ds); 6086c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 6087c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis dev_data->descriptorPoolMap.erase(descriptorPool); 6088c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis} 6089c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis 609089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 609189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 6092c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6093a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *desc_pool_state = nullptr; 6094c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis VK_OBJECT obj_struct; 6095c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 6096c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis bool skip = PreCallValidateDestroyDescriptorPool(dev_data, descriptorPool, &desc_pool_state, &obj_struct); 6097c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis if (!skip) { 6098c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis lock.unlock(); 6099c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis dev_data->dispatch_table.DestroyDescriptorPool(device, descriptorPool, pAllocator); 6100c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis lock.lock(); 6101c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis PostCallRecordDestroyDescriptorPool(dev_data, descriptorPool, desc_pool_state, obj_struct); 6102c656e38f76da254b8b19e653d0945cabb43329bcTobin Ehlis } 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6104bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 6105bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 6106bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 6107bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 6108cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlisstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action, 6109cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis UNIQUE_VALIDATION_ERROR_CODE error_code) { 6110bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6111bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 6112bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 6113bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 6114bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 6115cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis skip_call |= 6116cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6117cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, error_code, "DS", 6118cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use. %s", action, 6119cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), validation_error_map[error_code]); 6120bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6121bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6122bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6123bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 6124a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 6125bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 6126cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlisstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action, 6127cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis UNIQUE_VALIDATION_ERROR_CODE error_code) { 6128bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6129a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6130a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 6131cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action, error_code); 6132bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6133bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6134bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6135bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6137a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 6138a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6139a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 6140a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 6141a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 6142a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 614389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 614489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 6147b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6148c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 61509f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 61529f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 6153cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free", VALIDATION_ERROR_00096); 6154c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6155c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6156c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6157c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 6158c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 6159c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6160c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 6161c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 61629f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 6163c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 61649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 61659f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 61679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 61689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 61699f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 6173c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6176b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6177e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 61784a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 618189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 618289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 618389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61864a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6189b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 619689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 619789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62004a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 6202b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6203eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; 6204eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis qp_node->createInfo = *pCreateInfo; 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62095f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlisstatic bool PreCallValidateDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE **cp_state) { 621094165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *cp_state = getCommandPoolNode(dev_data, pool); 62115f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis if (dev_data->instance_data->disabled.destroy_command_pool) 62125f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis return false; 62135f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis bool skip = false; 62145f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis if (*cp_state) { 62155f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 62165f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis skip |= checkCommandBuffersInFlight(dev_data, *cp_state, "destroy command pool with", VALIDATION_ERROR_00077); 62175f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis } 62185f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis return skip; 62195f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis} 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62215f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlisstatic void PostCallRecordDestroyCommandPool(layer_data *dev_data, VkCommandPool pool, COMMAND_POOL_NODE *cp_state) { 62229f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 62235f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis clearCommandBuffersInFlight(dev_data, cp_state); 62245f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis for (auto cb : cp_state->commandBuffers) { 6225a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 62269f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 6227d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // Remove references to this cb_node prior to delete 6228d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // TODO : Need better solution here, resetCB? 62297165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 62307165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 62317165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 6232d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis for (auto framebuffer : cb_node->framebuffers) { 6233c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb_state = getFramebufferState(dev_data, framebuffer); 6234c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis if (fb_state) 6235c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->cb_bindings.erase(cb_node); 6236d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis } 62379f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 62389f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 6239a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 62405f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis dev_data->commandPoolMap.erase(pool); 62415f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis} 6242e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 62435f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 62445f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin EhlisVKAPI_ATTR void VKAPI_CALL DestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 62455f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62465f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis COMMAND_POOL_NODE *cp_state = nullptr; 62475f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 62485f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis bool skip = PreCallValidateDestroyCommandPool(dev_data, commandPool, &cp_state); 62495f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis if (!skip) { 62505f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis lock.unlock(); 62515f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis dev_data->dispatch_table.DestroyCommandPool(device, commandPool, pAllocator); 62525f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis lock.lock(); 62535f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis PostCallRecordDestroyCommandPool(dev_data, commandPool, cp_state); 62545f9c0dbd099bd351bc564e0f05170ceeadcc995dTobin Ehlis } 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 625789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 625889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 626083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6261400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 62621ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 6263a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 6264cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with", VALIDATION_ERROR_00072); 62651ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 6266a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 626783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62704a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetCommandPool(device, commandPool, flags); 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62741ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 6275a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 6276a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 6277a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62791ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 628489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 628683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6287b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 6289df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6290090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 629183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 629283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 629383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6296b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6297090da73358f71ba026e2474a822fecf55267d166Chris Forbes 629883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6299090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6300090da73358f71ba026e2474a822fecf55267d166Chris Forbes 63014a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetFences(device, fenceCount, pFences); 6302090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6303090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 6304090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 6305090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 6306090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6307090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 6308090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 6309090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6310090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6311090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 6312090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6313090da73358f71ba026e2474a822fecf55267d166Chris Forbes 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6317e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 6318e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 6319e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 6320e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 6321e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 6322e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 6323e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 6324e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 6325c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic bool PreCallValidateDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, 6326c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis FRAMEBUFFER_STATE **framebuffer_state, VK_OBJECT *obj_struct) { 632794165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *framebuffer_state = getFramebufferState(dev_data, framebuffer); 632894165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}; 6329219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_framebuffer) 6330728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis return false; 6331728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis bool skip = false; 6332728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis if (*framebuffer_state) { 6333728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *framebuffer_state, *obj_struct, VALIDATION_ERROR_00422); 6334728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis } 6335728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis return skip; 6336728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis} 6337728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis 6338c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void PostCallRecordDestroyFramebuffer(layer_data *dev_data, VkFramebuffer framebuffer, FRAMEBUFFER_STATE *framebuffer_state, 6339728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis VK_OBJECT obj_struct) { 6340728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis invalidateCommandBuffers(framebuffer_state->cb_bindings, obj_struct); 6341728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis dev_data->frameBufferMap.erase(framebuffer); 6342728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis} 6343728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis 634489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 634589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6347c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis FRAMEBUFFER_STATE *framebuffer_state = nullptr; 6348728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis VK_OBJECT obj_struct; 6349b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6350728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis bool skip = PreCallValidateDestroyFramebuffer(dev_data, framebuffer, &framebuffer_state, &obj_struct); 6351728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis if (!skip) { 6352728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis lock.unlock(); 6353728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis dev_data->dispatch_table.DestroyFramebuffer(device, framebuffer, pAllocator); 6354728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis lock.lock(); 6355728a3e68af2277743cc59185dab7281e96480efeTobin Ehlis PostCallRecordDestroyFramebuffer(dev_data, framebuffer, framebuffer_state, obj_struct); 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63590ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlisstatic bool PreCallValidateDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE **rp_state, 63600ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT *obj_struct) { 636194165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *rp_state = getRenderPassState(dev_data, render_pass); 636294165f5005d1fa37801d49067fe7751789b89d27Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(render_pass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}; 6363219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.destroy_renderpass) 63640ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis return false; 63650ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis bool skip = false; 63660ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis if (*rp_state) { 63670ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *rp_state, *obj_struct, VALIDATION_ERROR_00393); 63680ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis } 63690ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis return skip; 63700ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis} 63710ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis 63720ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlisstatic void PostCallRecordDestroyRenderPass(layer_data *dev_data, VkRenderPass render_pass, RENDER_PASS_STATE *rp_state, 63730ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT obj_struct) { 63740ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis invalidateCommandBuffers(rp_state->cb_bindings, obj_struct); 63750ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis dev_data->renderPassMap.erase(render_pass); 63760ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis} 63770ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis 637889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 637989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63810ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis RENDER_PASS_STATE *rp_state = nullptr; 63820ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis VK_OBJECT obj_struct; 6383e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 63840ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis bool skip = PreCallValidateDestroyRenderPass(dev_data, renderPass, &rp_state, &obj_struct); 6385a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis if (!skip) { 6386a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis lock.unlock(); 63874a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyRenderPass(device, renderPass, pAllocator); 63880ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis lock.lock(); 63890ffd03853dc28123fa113e6cd49264838559ee39Tobin Ehlis PostCallRecordDestroyRenderPass(dev_data, renderPass, rp_state, obj_struct); 6390a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis } 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 639389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 639489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63964f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00658 63974f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00666 63984f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00667 63994f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00668 64004f38db6ace251a2f5302c9de6c5d7c791a610505Karl Schultz // TODO: Add check for VALIDATION_ERROR_00669 64014a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6404b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 6406b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64118c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 64128c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 64138c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 64148c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 6415b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 6416b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 6417cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 6418cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 641959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, buf_node, 6420b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 6421b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 6422b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 64238c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 64248c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 64258c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 642689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 642789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64298c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 64308c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 64318c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 64328c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 64338c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 64344a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateBufferView(device, pCreateInfo, pAllocator, pView); 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64368c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 643739267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); 64388c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 644389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 644489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 644647892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 64474a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateImage(device, pCreateInfo, pAllocator, pImage); 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6450b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64511facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis IMAGE_LAYOUT_NODE image_state; 64521facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state.layout = pCreateInfo->initialLayout; 64531facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state.format = pCreateInfo->format; 64541facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_STATE>(new IMAGE_STATE(*pImage, pCreateInfo)))); 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 64571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_state; 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6463b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64651facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 64661facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 64721facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis range->levelCount = image_state->createInfo.mipLevels - range->baseMipLevel; 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 64761facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis range->layerCount = image_state->createInfo.arrayLayers - range->baseArrayLayer; 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6485b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 64891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 64901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 64921facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *levels = image_state->createInfo.mipLevels - range.baseMipLevel; 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 64951facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis *layers = image_state->createInfo.arrayLayers - range.baseArrayLayer; 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6500a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis// For the given format verify that the aspect masks make sense 6501a4a1923d21087ded8e990190acd6752264712319Tobin Ehlisstatic bool ValidateImageAspectMask(layer_data *dev_data, VkImage image, VkFormat format, VkImageAspectFlags aspect_mask, 6502a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis const char *func_name) { 6503a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis bool skip = false; 6504a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if (vk_format_is_color(format)) { 6505a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 6506a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6507a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6508a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Color image formats must have the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, 6509a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6510a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6511a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT) != aspect_mask) { 6512a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6513a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6514a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Color image formats must have ONLY the VK_IMAGE_ASPECT_COLOR_BIT set. %s", func_name, 6515a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6516a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6517a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } else if (vk_format_is_depth_and_stencil(format)) { 6518a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) == 0) { 6519a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6520a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", "%s: Depth/stencil image formats must have " 6521a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "at least one of VK_IMAGE_ASPECT_DEPTH_BIT " 6522a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "and VK_IMAGE_ASPECT_STENCIL_BIT set. %s", 6523a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis func_name, validation_error_map[VALIDATION_ERROR_00741]); 6524a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6525a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) != aspect_mask) { 6526a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6527a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6528a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Combination depth/stencil image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT and " 6529a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set. %s", 6530a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis func_name, validation_error_map[VALIDATION_ERROR_00741]); 6531a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6532a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } else if (vk_format_is_depth_only(format)) { 6533a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != VK_IMAGE_ASPECT_DEPTH_BIT) { 6534a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6535a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6536a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Depth-only image formats must have the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, 6537a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6538a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6539a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) != aspect_mask) { 6540a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6541a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6542a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Depth-only image formats can have only the VK_IMAGE_ASPECT_DEPTH_BIT set. %s", func_name, 6543a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6544a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6545a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } else if (vk_format_is_stencil_only(format)) { 6546a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != VK_IMAGE_ASPECT_STENCIL_BIT) { 6547a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6548a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6549a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Stencil-only image formats must have the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, 6550a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6551a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6552a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if ((aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) != aspect_mask) { 6553a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6554a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)image, __LINE__, VALIDATION_ERROR_00741, "IMAGE", 6555a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Stencil-only image formats can have only the VK_IMAGE_ASPECT_STENCIL_BIT set. %s", func_name, 6556a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_00741]); 6557a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6558a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis } 6559a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis return skip; 6560a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis} 6561a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis 6562a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlisstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info) { 6563e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis bool skip = false; 6564a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis IMAGE_STATE *image_state = getImageState(dev_data, create_info->image); 65651facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 6566e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis skip |= ValidateImageUsageFlags( 65671facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data, image_state, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | 65681facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 65695a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour false, "vkCreateImageView()", 65705a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); 6571b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 6572e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis skip |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCreateImageView()"); 6573a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Checks imported from image layer 6574a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (create_info->subresourceRange.baseMipLevel >= image_state->createInfo.mipLevels) { 6575a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6576a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis ss << "vkCreateImageView called with baseMipLevel " << create_info->subresourceRange.baseMipLevel << " for image " 6577a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << create_info->image << " that only has " << image_state->createInfo.mipLevels << " mip levels."; 6578a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= 6579a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6580a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); 6581a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6582a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (create_info->subresourceRange.baseArrayLayer >= image_state->createInfo.arrayLayers) { 6583a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6584a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis ss << "vkCreateImageView called with baseArrayLayer " << create_info->subresourceRange.baseArrayLayer << " for image " 6585a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << create_info->image << " that only has " << image_state->createInfo.arrayLayers << " array layers."; 6586a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= 6587a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6588a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); 6589a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6590a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // TODO: Need new valid usage language for levelCount == 0 & layerCount == 0 6591a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (!create_info->subresourceRange.levelCount) { 6592a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6593a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.levelCount."; 6594a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= 6595a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6596a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_00768, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00768]); 6597a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6598a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (!create_info->subresourceRange.layerCount) { 6599a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6600a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis ss << "vkCreateImageView called with 0 in pCreateInfo->subresourceRange.layerCount."; 6601a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= 6602a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6603a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_00769, "IMAGE", "%s %s", ss.str().c_str(), validation_error_map[VALIDATION_ERROR_00769]); 6604a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6605a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis 6606a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VkImageCreateFlags image_flags = image_state->createInfo.flags; 6607a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VkFormat image_format = image_state->createInfo.format; 6608a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VkFormat view_format = create_info->format; 6609a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VkImageAspectFlags aspect_mask = create_info->subresourceRange.aspectMask; 6610a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis 6611a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Validate VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT state 6612a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (image_flags & VK_IMAGE_CREATE_MUTABLE_FORMAT_BIT) { 6613a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Format MUST be compatible (in the same format compatibility class) as the format the image was created with 6614a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (vk_format_get_compatibility_class(image_format) != vk_format_get_compatibility_class(view_format)) { 6615a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6616a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis ss << "vkCreateImageView(): ImageView format " << string_VkFormat(view_format) 6617a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << " is not in the same format compatibility class as image (" << (uint64_t)create_info->image << ") format " 6618a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << string_VkFormat(image_format) << ". Images created with the VK_IMAGE_CREATE_MUTABLE_FORMAT BIT " 6619a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << "can support ImageViews with differing formats but they must be in the same compatibility class."; 6620a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6621a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_02171, "IMAGE", "%s %s", ss.str().c_str(), 6622a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis validation_error_map[VALIDATION_ERROR_02171]); 6623a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6624a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } else { 6625a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Format MUST be IDENTICAL to the format the image was created with 6626a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis if (image_format != view_format) { 6627a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis std::stringstream ss; 6628a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis ss << "vkCreateImageView() format " << string_VkFormat(view_format) << " differs from image " 6629a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << (uint64_t)create_info->image << " format " << string_VkFormat(image_format) 6630a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis << ". Formats MUST be IDENTICAL unless VK_IMAGE_CREATE_MUTABLE_FORMAT BIT was set on image creation."; 6631a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 6632a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis VALIDATION_ERROR_02172, "IMAGE", "%s %s", ss.str().c_str(), 6633a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis validation_error_map[VALIDATION_ERROR_02172]); 6634a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6635a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6636a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis 6637a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Validate correct image aspect bits for desired formats and format consistency 6638a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= ValidateImageAspectMask(dev_data, image_state->image, image_format, aspect_mask, "vkCreateImageView()"); 6639a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis if (vk_format_is_color(image_format) && !vk_format_is_color(view_format)) { 6640a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis std::stringstream ss; 6641a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis ss << "vkCreateImageView: The image view's format can differ from the parent image's format, but both must be " 6642a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis << "color formats. ImageFormat is " << string_VkFormat(image_format) << " ImageViewFormat is " 6643a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis << string_VkFormat(view_format); 6644a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 6645a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis (uint64_t)create_info->image, __LINE__, VALIDATION_ERROR_02171, "IMAGE", "%s %s", ss.str().c_str(), 6646a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis validation_error_map[VALIDATION_ERROR_02171]); 6647a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // TODO: Uncompressed formats are compatible if they occupy they same number of bits per pixel. 6648a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // Compressed formats are compatible if the only difference between them is the numerical type of 6649a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis // the uncompressed pixels (e.g. signed vs. unsigned, or sRGB vs. UNORM encoding). 6650a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis } 6651bb6624cb996175d8945190886a200e720b3871efChris Forbes } 6652e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis return skip; 66538c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6654bb6624cb996175d8945190886a200e720b3871efChris Forbes 6655a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlisstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *create_info, VkImageView view) { 6656a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, create_info)); 6657a7660be5cf06febf98b35674796b8d2e53c77155Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, create_info->image); 66588c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6659bb6624cb996175d8945190886a200e720b3871efChris Forbes 66608c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 66618c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 66628c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66638c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 6664e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis bool skip = PreCallValidateCreateImageView(dev_data, pCreateInfo); 66658c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 6666e3effabf8e97cae8e006477806ceaca62e4f2ce7Tobin Ehlis if (skip) 66678c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 66684a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateImageView(device, pCreateInfo, pAllocator, pView); 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66708c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 667179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); 66728c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6674bb6624cb996175d8945190886a200e720b3871efChris Forbes 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 667889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 667989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66814a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateFence(device, pCreateInfo, pAllocator, pFence); 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6683b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6684a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 66858988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 6686a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6687cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 669389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 669489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66964a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 670189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67034a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroyPipelineCache(device, pipelineCache, pAllocator); 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 670789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67094a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 671489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67164a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 67214c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlisvoid set_pipeline_state(PIPELINE_STATE *pPipe) { 67223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 67233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 67243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 67253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 67263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 67273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 67283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 67293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 67303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 67313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 67323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 67333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 67343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 67353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 67363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 67373d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 67383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 67393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 67403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 674189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 674289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 674389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 674489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 67484c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_STATE struct 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 675183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 67534c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis vector<PIPELINE_STATE *> pPipeState(count); 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6757b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 67604c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i] = new PIPELINE_STATE; 67614c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->initGraphicsPipeline(&pCreateInfos[i]); 6762127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis pPipeState[i]->render_pass_ci.initialize(getRenderPassState(dev_data, pCreateInfos[i].renderPass)->createInfo.ptr()); 6763c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 676467220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 67654c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeState, i); 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 676883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67704a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = 67714a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); 6772b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 67744c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->pipeline = pPipelines[i]; 67754c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6777b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 67804c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis delete pPipeState[i]; 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6782b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 678889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 678989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 679089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 679189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 679383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 67964c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis vector<PIPELINE_STATE *> pPipeState(count); 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6800b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 68054c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i] = new PIPELINE_STATE; 68064c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->initComputePipeline(&pCreateInfos[i]); 6807c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis pPipeState[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 68084c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // memcpy(&pPipeState[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 68114c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeState[i], &dev_data->enabled_features, 681283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 68134c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeState[i]); 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 681683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6817b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68184a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = 68194a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, pPipelines); 6820b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 68224c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis pPipeState[i]->pipeline = pPipelines[i]; 68234c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis dev_data->pipelineMap[pPipeState[i]->pipeline] = pPipeState[i]; 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6825b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 68294c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis delete pPipeState[i]; 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 683789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 683889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68404a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSampler(device, pCreateInfo, pAllocator, pSampler); 68415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6842b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6843d31a44af6da568692a73201825459689c9431867Tobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_STATE>(new SAMPLER_STATE(pSampler, pCreateInfo)); 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68480c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlisstatic bool PreCallValidateCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info) { 68490c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis if (dev_data->instance_data->disabled.create_descriptor_set_layout) 68500c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis return false; 68510c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis return cvdescriptorset::DescriptorSetLayout::ValidateCreateInfo(dev_data->report_data, create_info); 68520c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis} 68530c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis 68540c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlisstatic void PostCallRecordCreateDescriptorSetLayout(layer_data *dev_data, const VkDescriptorSetLayoutCreateInfo *create_info, 68550c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis VkDescriptorSetLayout set_layout) { 68563f1d2ba6852cf6b1bb4e1f06d690293565108e2cTobin Ehlis // TODO: Convert this to unique_ptr to avoid leaks 68570c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis dev_data->descriptorSetLayoutMap[set_layout] = new cvdescriptorset::DescriptorSetLayout(create_info, set_layout); 68580c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis} 68590c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis 686089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 686189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 686289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68640c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 68650c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 68660c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis bool skip = PreCallValidateCreateDescriptorSetLayout(dev_data, pCreateInfo); 68670c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis if (!skip) { 68680c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis lock.unlock(); 68690c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis result = dev_data->dispatch_table.CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 68700c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis if (VK_SUCCESS == result) { 68710c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis lock.lock(); 68720c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis PostCallRecordCreateDescriptorSetLayout(dev_data, pCreateInfo, *pSetLayout); 68730c347fc6b08172b778c259e1a1219a2403495d48Tobin Ehlis } 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 68799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 68809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 68819e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 6882219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.push_constant_range) 68830dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 68849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 688583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 68879e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 68881c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This check combines VALIDATION_ERROR_00877 & 880, need to break out separately 68899e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 68909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 68919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 689283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 68939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 68941c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis VALIDATION_ERROR_00877, "DS", "%s call has push constants index %u with offset %u and size %u that " 68951c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "exceeds this device's maxPushConstantSize of %u. %s", 68961c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis caller_name, index, offset, size, maxPushConstantsSize, validation_error_map[VALIDATION_ERROR_00877]); 68979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 689883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 689983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 690083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 690183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 69029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 690383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 690483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 69059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 69081c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : This check combines VALIDATION_ERROR_00878 & 879, need to break out separately 69099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 69109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 69111c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69121c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis VALIDATION_ERROR_00878, "DS", "%s call has push constants index %u with " 69131c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "size %u. Size must be greater than zero and a multiple of 4. %s", 69141c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis caller_name, index, size, validation_error_map[VALIDATION_ERROR_00878]); 69159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 691683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 69179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69189e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 69199e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 69209e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 69219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 692283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 692383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 69249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 69279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 69289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 692983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 693083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 693183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 693283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 69339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 693483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 693583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 693683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 693783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 69389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 693983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 694083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 69419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 694383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 694689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 694789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 694883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 69501c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis // TODO : Add checks for VALIDATION_ERRORS 865-871 69519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 695207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz uint32_t i, j; 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 695483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 695583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 69569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 695783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 695883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 69599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 696107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if (skip_call) 696207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz return VK_ERROR_VALIDATION_FAILED_EXT; 696307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz 69649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 696507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz // There's no explicit Valid Usage language against this, so issue a warning instead of an error. 696607a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 696707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 696807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 696907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 697007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 697107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 697207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 697307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz skip_call |= 697407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 697507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 697607a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 697707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz i, minA, maxA, j, minB, maxB); 69789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6981f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 69824a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6984b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 698669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6987416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6989416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6991416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6993416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 699989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 700089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 700189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 70034a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 7006414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 7009a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pNewNode = new DESCRIPTOR_POOL_STATE(*pDescriptorPool, pCreateInfo); 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 7013a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_STATE in vkCreateDescriptorPool()")) 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 7016b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 702589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 702689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 70277286e20c06011d3c6fa7edfbdbadd42bb6e8cc35Tobin Ehlis // TODO : Add checks for VALIDATION_ERROR_00928 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 70294a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetDescriptorPool(device, descriptorPool, flags); 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7031b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70362c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 7037789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 7038789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 70397f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 70407f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 7041219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.allocate_descriptor_sets) 70420dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 70437e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 7044e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 70457e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 70467e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 70477e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 70487f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 70497f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 70507e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 70512c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 7052b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 70532c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 70542c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 705589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 705689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 7058b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70597f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 70607f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 7061b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7062d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 70637e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 7065d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 70664a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 70676511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 70707f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 7071b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7075cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 7076cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 7077cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 7078219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.free_descriptor_sets) 70790dcd0f7b37456e2e552d37094ba503c0d089b906Tobin Ehlis return false; 7080cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 7081cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 7082cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 7083cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 7084cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 7085a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); 7086a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis if (pool_state && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_state->createInfo.flags)) { 7087cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 7088cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 70891c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, VALIDATION_ERROR_00922, "DS", 7090cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 70911c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT. %s", 70921c48e214b2ed50690da7f42f2013be3a6ef267dfTobin Ehlis validation_error_map[VALIDATION_ERROR_00922]); 7093cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 7094cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 7095cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 7096cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 7097cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 7098cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 7099a21f0d8ac8389dc4e23749efc02d82a7ec1eaee3Tobin Ehlis DESCRIPTOR_POOL_STATE *pool_state = getDescriptorPoolState(dev_data, pool); 7100cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 7101cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 7102cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 7103cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 7104cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 7105cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 7106cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 7107cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 7108cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 7109cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 7110cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 7111cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 7112cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 7113cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 7114cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 7115cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 711789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 711889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 7121b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 712283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 7123b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7124e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 712583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 71274a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 71285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7129b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 7130cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 7131b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71356b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 71366b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 71376b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 71386b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 71396b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 71406b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 71416b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 7142219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (dev_data->instance_data->disabled.update_descriptor_sets) 7143793fead81a7a480b5609b36121dc5ddd31d7e9dfTobin Ehlis return false; 71446b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 71456b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 71466b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 71476b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 71486b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 71496b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 71506b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 7151104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 7152104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 71536b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 71546b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 71556b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 71566b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 71576b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 7158104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 71596b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 71606b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 71615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 716289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 716389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 716489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 71656b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 7167b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71686b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 71696b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 7170b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 71716b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 71724a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 71734a0754042cf090e131e9e769d8a3633c228625beChris Forbes pDescriptorCopies); 71746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 71756b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 71766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 71776b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 71785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 718189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 718289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 71844a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7186b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7187cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 7188cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 7189cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 719072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 71915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 7192cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 71935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 71945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 71965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 71975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 71985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 7202b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 72035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 72055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7207883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis// Add bindings between the given cmd buffer & framebuffer and the framebuffer's children 7208c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_STATE *fb_state) { 72090245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis addCommandBufferBinding(&fb_state->cb_bindings, 72100245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis {reinterpret_cast<uint64_t &>(fb_state->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}, 72110245b74a083d2cb3b083571deb0fe13b4ab428a4Tobin Ehlis cb_state); 7212883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis for (auto attachment : fb_state->attachments) { 7213883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis auto view_state = attachment.view_state; 7214883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (view_state) { 721503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis AddCommandBufferBindingImageView(dev_data, cb_state, view_state); 7216883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7217127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto rp_state = getRenderPassState(dev_data, fb_state->createInfo.renderPass); 7218883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (rp_state) { 7219883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis addCommandBufferBinding( 7220883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis &rp_state->cb_bindings, 7221883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); 7222883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7223883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 7224883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis} 7225883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis 722689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 722789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 722883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7230b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 7232f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 7233f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 7235a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 723683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7237a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 7238a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 7239d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Calling vkBeginCommandBuffer() on active command buffer 0x%p before it has completed. " 7240d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "You must check command buffer fence before this call.", 7241a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 72425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7243f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, cb_node); 7244f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 724883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7251414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 7255400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 725683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 72575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7259414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7262400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 726383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 726483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 726583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 726683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 726783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 726883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 7271c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pInfo->framebuffer); 7272f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 7273a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 7274a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 7275127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis getRenderPassState(dev_data, pInfo->renderPass)->createInfo.ptr(), 7276a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 7277400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 727883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7279a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7280a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 7281a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 7282a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 7283a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 7284a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 7285a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 7286a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 7287a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7289883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 7290883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 7295f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 729783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 729883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 729983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 730083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 730183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 730283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 730383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 7307127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pInfo->renderPass); 730816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 7309fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (pInfo->subpass >= renderPass->createInfo.subpassCount) { 731083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 731183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 731283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 731383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 731483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 7315fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->createInfo.subpassCount); 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7320f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (CB_RECORDING == cb_node->state) { 732183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7324d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "vkBeginCommandBuffer(): Cannot call Begin on command buffer (0x%" PRIxLEAST64 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 7327f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->cmds.back().type)) { 7328f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis VkCommandPool cmdPool = cb_node->createInfo.commandPool; 7329cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7330cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 733183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7334414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 7335414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 7342f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->state = CB_RECORDING; 7343f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo = *pBeginInfo; 7344f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->beginInfo.pInheritanceInfo) { 7345f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); 7346f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; 7347888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 7348f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 7349f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7350127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis cb_node->activeRenderPass = getRenderPassState(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); 7351f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; 7352350841afb70bf8dcfc3c6ec6b66f0aaa639553a3Tobin Ehlis cb_node->activeFramebuffer = cb_node->beginInfo.pInheritanceInfo->framebuffer; 7353f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); 7354888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 735783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 735883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 7359d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for command buffer 0x%p!", 7360d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen (void *)commandBuffer); 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7362b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 736383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73664a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.BeginCommandBuffer(commandBuffer, pBeginInfo); 7367400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 73685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 737189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 737283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7375b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7378fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7379fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 7380fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 738183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 7382fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 738383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 738583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 738683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 738783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 738883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 739183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7392b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 73934a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.EndCommandBuffer(commandBuffer); 7394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 73965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 73985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 73995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7404b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 74055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 740889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 740989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 7410bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7412b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 7415cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7416cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 7417bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 7418bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7419414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 7420bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 7421bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7423cdc73d5b6b64942b377db7220cd16b4045f73c9aTobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset", VALIDATION_ERROR_00092); 7424b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7425bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 74274a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.ResetCommandBuffer(commandBuffer, flags); 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7429b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 7430a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 7432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 743693c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 743789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 743889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 7439e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis bool skip = false; 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7441b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7442e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis GLOBAL_CB_NODE *cb_state = getCBNode(dev_data, commandBuffer); 7443e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if (cb_state) { 7444e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis skip |= addCmd(dev_data, cb_state, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 7445e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (cb_state->activeRenderPass)) { 7446e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis skip |= 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 7449414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 7450e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis (uint64_t)pipeline, (uint64_t)cb_state->activeRenderPass->renderPass); 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7453e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis PIPELINE_STATE *pipe_state = getPipelineState(dev_data, pipeline); 7454e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if (pipe_state) { 7455e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis cb_state->lastBound[pipelineBindPoint].pipeline_state = pipe_state; 7456e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis set_cb_pso_status(cb_state, pipe_state); 7457e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis set_pipeline_state(pipe_state); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 7459e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 7460e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 7461e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 7462e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis } 7463e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis addCommandBufferBinding(&pipe_state->cb_bindings, 7464e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, cb_state); 7465e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 7466e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis // Add binding for child renderpass 7467e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis auto rp_state = getRenderPassState(dev_data, pipe_state->graphicsPipelineCI.renderPass); 7468e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if (rp_state) { 7469e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis addCommandBufferBinding( 7470e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis &rp_state->cb_bindings, 7471e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); 7472e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis } 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7476e92495715edaa63453ce5775bf60f3795df72876Tobin Ehlis if (!skip) 74774a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 748089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 748189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 748283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 748783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 7488b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; 74895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7490b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 749183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74924a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 749589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 749689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 749783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7499b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 750283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 7503b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7505b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 750683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75074a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 751089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7511a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7516a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 7518a27508babf63d50aea75883a3702979193c23683Mark Young 75194c0df90de562aa248b524a28b355765d8e3eff25Tobin Ehlis PIPELINE_STATE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state; 7520a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 7521a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 7522a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 7523386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 7524a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 7525a27508babf63d50aea75883a3702979193c23683Mark Young } else { 7526a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 7527a27508babf63d50aea75883a3702979193c23683Mark Young } 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7529b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7530a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 75314a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetLineWidth(commandBuffer, lineWidth); 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 753489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 753589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 753683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7538b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 754183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7544b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 754583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75464a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, depthBiasSlopeFactor); 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 754989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 755083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7552b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 755583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 75563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7558b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 755983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75604a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetBlendConstants(commandBuffer, blendConstants); 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 756389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 756489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 756583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7567b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 757083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7573b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 757483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75754a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 757889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 757989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 758083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7582b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 758583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7588b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 758983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75904a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 759389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 759489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 759583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7597b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 760083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7603b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 760483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76054a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 760889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 760989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 761083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7612b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 761583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7618b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 761983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76204a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetStencilReference(commandBuffer, faceMask, reference); 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 762389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 762489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 762589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 762689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 762783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7629b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7633787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7634787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7635787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7636787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 7637dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 763872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 7639dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 7640dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 764171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7642c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 7643787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7644397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7645787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 764669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 764771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 764883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 764983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7650d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen DRAWSTATE_NONE, "DS", "Descriptor Set 0x%" PRIxLEAST64 " bound on pipeline %s", 765183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7652397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 765383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 765483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 765583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7656d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Descriptor Set 0x%" PRIxLEAST64 765783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 765883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7659787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7660787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 766169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 766283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 766383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 766483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 766583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 766683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 766783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 7668787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7669dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7670dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 7671dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7672dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 7673dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7674dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 7675787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7676dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 767783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7678787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7679787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7680787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7681414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 7682787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7683787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7684397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 7685787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7686787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7687787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7688787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7689397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 7690397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7691787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7692787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7693b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 769483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7695787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7696787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7697787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7698787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7699414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 7700787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7701b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7702787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7703787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7704397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7705787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7706787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7707b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 770883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7709787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7710787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7711787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7712787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7713414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 7714787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7715b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7717787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7720dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7721dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 7722dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 7723dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 7724787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7725dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 7726dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7729787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 773083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 773183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7732d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen DRAWSTATE_INVALID_SET, "DS", "Attempt to bind descriptor set 0x%" PRIxLEAST64 7733d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen " that doesn't exist!", 773483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 773683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 773772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 773872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 773972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 774072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 774171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 774269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 774383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 774472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 774572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 774672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 7747d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "DescriptorSet 0x%" PRIxLEAST64 7748414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 774972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 775072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 775172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 775272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 775372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 775472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 775572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 775672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 775769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 775871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 775983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 776072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 776171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 7762d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen DRAWSTATE_NONE, "DS", "DescriptorSet 0x%" PRIxLEAST64 7763414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 776472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 7765414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 776671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 776772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 776872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 776972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7773787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7774787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 777583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 777683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 777783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 777883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 777983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 778083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7781787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 778383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 778783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77884a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 77894a0754042cf090e131e9e769d8a3633c228625beChris Forbes pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 779289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 779389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 779483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7796593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 7797b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7798b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7799ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 78009f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7801ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7802b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7803ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7804f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7805ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 78069f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 780783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 782183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 782283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 782383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 782483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78269f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 7827ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7828ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7830b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 783183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78324a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7845e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 78465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 784789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 784889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 784989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 785083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7852593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 7853b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7854b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 78559f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 78569f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 7857593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 7858ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 7859ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7860b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7861ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7862f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7863ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 78649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78669f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 78679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 786983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7871b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 787283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78734a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7876b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 78797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 78807a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 788179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 788279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 7884249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 78851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, view_state->create_info.image); 78861facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis assert(image_state); 7887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 7889e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 78917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 78927a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 78937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7894ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7895ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7897f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, buff_node, true); 7898e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 79007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 790589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 790689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 790783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7909b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 791283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7914e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDraw"); 791583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 791783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7919d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting descriptor set state:", 7920d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen g_drawCount[DRAW]++); 792183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 792283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 792583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 792883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79294a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 793289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 793389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 793683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 794083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7942e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexed"); 794383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 794583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 794683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 7947d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting descriptor set state:", 7948d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen g_drawCount[DRAW_INDEXED]++); 794983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 795083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 795383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7955b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 795683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79574a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, firstInstance); 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 796089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 796189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 796383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7964b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7965ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7966ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7967ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7968ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7969b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7970c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7971ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7972ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7973e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndirect"); 7974ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 797683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 797783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 7978d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting descriptor set state:", 7979d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen g_drawCount[DRAW_INDIRECT]++); 798083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 798183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7982ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7984b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7985ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7986ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7988b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 798983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79904a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 799389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 799489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 799583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7997b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7998ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7999ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8000ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 8001ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 8002b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 8003c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 8004ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 8005ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 8006e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 8007e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexedIndirect"); 8008ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 801083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 8012d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting descriptor set state:", 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 801483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 801583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 8016ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8018b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 8019ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8020ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8022b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 802383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80244a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 802789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 802883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8030b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 8033e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatch"); 803483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 803583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 803683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8038b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 803983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80404a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDispatch(commandBuffer, x, y, z); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 804389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 804489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 804583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8048ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 8049ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8050ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 8051b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 8052b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 8053c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 8054e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 8055e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatchIndirect"); 8056ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 8057ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 8058b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8060b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 806183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80624a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdDispatchIndirect(commandBuffer, buffer, offset); 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 806589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 806689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 806783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8070ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 80719f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8072ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 8073ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8074ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 8075b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 8076b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 8077ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 8078c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 8079c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8080ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 808159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 8082ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 808359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 8084ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8085ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 8086ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 8087f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 8088ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 80899f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8090593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8091f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8095593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 809683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 8097b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 8098ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8099ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 8100ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8102b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 810383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81044a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 81055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 810727e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 810827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 8109e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 81135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 811527e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 811627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 81205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 81235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 81245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 81255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 813007b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 81311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, srcImage); 81321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 813307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 813407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 813507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 813607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 813707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 81415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 81465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 814827e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 814927e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 8150e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 81515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 815627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 815727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 81655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 81701facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, destImage); 81711facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 817207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 817307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 817407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 817507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 817607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81879ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if two VkExtent3D structs are equivalent 81889ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { 81899ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool result = true; 81909ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || 81919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (extent->depth != other_extent->depth)) { 81929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano result = false; 81939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 81949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return result; 81959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 81969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 81979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image extent of a specific subresource. 81981facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline VkExtent3D GetImageSubresourceExtent(const IMAGE_STATE *img, const VkImageSubresourceLayers *subresource) { 81999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t mip = subresource->mipLevel; 82009ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D extent = img->createInfo.extent; 820190b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.width = std::max(1U, extent.width >> mip); 820290b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.height = std::max(1U, extent.height >> mip); 820390b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.depth = std::max(1U, extent.depth >> mip); 82049ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return extent; 82059ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 82069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 82079ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if the extent argument has all dimensions set to 0. 82089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentZero(const VkExtent3D *extent) { 82099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); 82109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 82119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 82129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. 82131facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_STATE *img) { 82149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. 82159ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = { 0, 0, 0 }; 8216f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 8217f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 82189ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 82199ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_format_is_compressed(img->createInfo.format)) { 82209ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano auto block_size = vk_format_compressed_block_size(img->createInfo.format); 82219ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.width *= block_size.width; 82229ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.height *= block_size.height; 8223f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8224f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 82259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return granularity; 82269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 82279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 82289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure 82299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { 82309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool valid = true; 82319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || 82329ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (vk_safe_modulo(extent->height, granularity->height) != 0)) { 82339ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano valid = false; 82349ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8235f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return valid; 8236f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8237f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8238f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values 82399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, 82409ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { 8241f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 82429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent = {}; 82439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.width = static_cast<uint32_t>(abs(offset->x)); 82449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.height = static_cast<uint32_t>(abs(offset->y)); 82459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); 82469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 82479ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) 82489ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(&offset_extent) == false) { 82499ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82509ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 82519ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " 82529ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 82539ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z); 82549ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 82559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 82569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even 82579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity. 82589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentAligned(&offset_extent, granularity) == false) { 82599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 82619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " 82629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", 82639ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, 82649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth); 82659ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8266f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8267f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8268f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8269f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8270f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values 82719ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, 82729ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, 82739ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function, const char *member) { 8274f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 82759ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 82769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image 82779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent. 82789ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentEqual(extent, subresource_extent) == false) { 82799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 82819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " 82829ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 82839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, 82849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->height, subresource_extent->depth); 82859ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 82869ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 82879ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even 82889ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image 82899ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent dimensions. 82909ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent_sum = {}; 82919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; 82929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; 82939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; 82949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { 82959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= 82969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8297f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 82989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " 82999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " 83009ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", 83019ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, 83029ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, 83039ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->width, subresource_extent->height, subresource_extent->depth); 83049ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 8305f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8306f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8307f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8308f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8309f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value 83109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, 83119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 8312f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 83139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 8314f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8315f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 83169ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " 83179ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "transfer granularity width (%d).", 83189ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 8319f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8320f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8321f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8322f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8323f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value 83249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, 83259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 8326f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 83279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 83289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 83309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%" PRIdLEAST64 83319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano ") must be an even integer multiple of this command buffer's queue family image transfer " 83329ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "granularity width (%d).", 83339ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 8334f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8335f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8336f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8337f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8338f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure 8339f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 83401facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const IMAGE_STATE *img, const VkImageCopy *region, 83419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8342f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 83439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 83449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); 83459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); 83469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); 83479ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, 83489ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent"); 8349f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8350f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8351f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8352f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure 8353f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 83541facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const IMAGE_STATE *img, const VkBufferImageCopy *region, 83559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8356f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 83579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 83589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); 83599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); 83609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); 83619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); 83629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); 83639ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, 83649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, "imageExtent"); 8365f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8366f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8367f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 836889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 836989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 837089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 837183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8373b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8374249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 83759f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 83761facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 83771facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 83781facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 83791facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImage()"); 83801facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyImage()"); 8381249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 83821facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 83831facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8384249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 83851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 8386ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 83871facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 8388ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 83891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis std::function<bool()> function = [=]() { 83901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImage()"); 83911facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis }; 83929f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8393593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 83941facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8395e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 83979f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8398593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 839983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 8400b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 840227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 840327e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 84041facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, 84059ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyImage()"); 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8407249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8408249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 841183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84124a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 84134a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8416eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski// Validate that an image's sampleCount matches the requirement for a specific API call 84171facd2c91911508b9fb61f54a56269841299f663Tobin Ehlisstatic inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_STATE *image_state, VkSampleCountFlagBits sample_count, 8418eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski const char *location) { 8419eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski bool skip = false; 84201facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state->createInfo.samples != sample_count) { 8421eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 84221facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->image), 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 8423eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s.", location, 84241facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis reinterpret_cast<uint64_t &>(image_state->image), 84251facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis string_VkSampleCountFlagBits(image_state->createInfo.samples), string_VkSampleCountFlagBits(sample_count)); 8426eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski } 8427eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski return skip; 8428eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski} 8429eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski 843089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 843189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 843289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 843383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8435b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8436593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 84379f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 84381facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 84391facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 84401facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 84411facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage"); 84421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage"); 84431facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdBlitImage()"); 84441facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdBlitImage()"); 8445249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 84461facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 84471facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8448249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 84491facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 8450ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 84511facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 8452ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 84531facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis std::function<bool()> function = [=]() { 84541facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdBlitImage()"); 84551facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis }; 84569f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8457593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 84581facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8459e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84619f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8462593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 846383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 8464b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 8465249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8466249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8468b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 846983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84704a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 84714a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions, filter); 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 847489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 847589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 847689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 847783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8479b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8480593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 84819f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8482ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 84831facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 84841facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_buff_node && dst_image_state) { 84851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= 84861facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis ValidateImageSampleCount(dev_data, dst_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage"); 8487b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 84881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdCopyBufferToImage()"); 8489c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 84901facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 849159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 8492ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 84931facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_image_state, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 8494ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 8495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 84961facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84999f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8500f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); }; 85019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8502593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 850383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 8504b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 850627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 85071facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_image_state, &pRegions[i], i, 85089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyBufferToImage()"); 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8510ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8511ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 851483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85154a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, pRegions); 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 851889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 851989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 852089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 852183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8523b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8524593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 85259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 85261facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 8527ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 85281facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_buff_node) { 85291facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= 85301facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis ValidateImageSampleCount(dev_data, src_image_state, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage"); 85311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); 8532b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 8533249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 85341facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 8535c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8536249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 85371facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_image_state, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 8538ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 853959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8540ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8541e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 85421facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdCopyImageToBuffer()"); 8543e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 85449f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8545593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8546f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8547e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 85499f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8550593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 855183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 8552b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 855427e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 85551facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_image_state, &pRegions[i], i, 85569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "CmdCopyImageToBuffer"); 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8558ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8559ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8561b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 856283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85634a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, pRegions); 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 856689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 856789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 856883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8570b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8571593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 85729f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8573ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8574ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8575b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 8576ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8577c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8578ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 857959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8580ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8581e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8582f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8583e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 85859f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8586593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 858783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 8588b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 8589ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8590ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8592b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 859383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85944a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 859789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 859889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 859983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8601b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8602593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 86039f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8604ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8605ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8606b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 8607ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8608c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8609ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 861059b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 8611ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8613f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 86169f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8617593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 861883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 8619b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 8620ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8621ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8623b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 862483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 86254a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 862889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 862989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 863089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 863183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8633b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 863683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 864483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 8645a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), 8646a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 8647d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "vkCmdClearAttachments() issued on command buffer object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 864883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 864983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8651b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 8656fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->createInfo.ptr(); 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 8658932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 866071bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes for (uint32_t i = 0; i < attachmentCount; i++) { 866171bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes auto clear_desc = &pAttachments[i]; 8662932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes VkImageView image_view = VK_NULL_HANDLE; 8663932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes 866471bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes if (clear_desc->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 866571bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes if (clear_desc->colorAttachment >= pSD->colorAttachmentCount) { 866683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 866721a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 8668e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes (uint64_t)commandBuffer, __LINE__, VALIDATION_ERROR_01114, "DS", 8669e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d. %s", 8670e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes clear_desc->colorAttachment, pCB->activeSubpass, validation_error_map[VALIDATION_ERROR_01114]); 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 867271bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes else if (pSD->pColorAttachments[clear_desc->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { 8673dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes skip_call |= log_msg( 8674e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 8675dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 8676e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored.", 867771bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes clear_desc->colorAttachment); 8678dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes } 8679932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes else { 8680932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes image_view = framebuffer->createInfo.pAttachments[pSD->pColorAttachments[clear_desc->colorAttachment].attachment]; 8681932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes } 868271bd13d45fa6d188e8f6ff9c0302aa0514c6ff2aChris Forbes } else if (clear_desc->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 868783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 8688e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 86907386605ae0fe78241c997605a843bdc9a5499e2bChris Forbes "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8692932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes else { 8693932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes image_view = framebuffer->createInfo.pAttachments[pSD->pDepthStencilAttachment->attachment]; 8694932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes } 8695932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes } 8696932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes 8697932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes if (image_view) { 8698932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes auto image_view_state = getImageViewState(dev_data, image_view); 8699932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes auto aspects_present = image_view_state->create_info.subresourceRange.aspectMask; 8700932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes auto extra_aspects = clear_desc->aspectMask & ~aspects_present; 8701932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes 8702932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes if (extra_aspects) { 8703932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes skip_call |= log_msg( 8704932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 8705e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes reinterpret_cast<uint64_t &>(image_view), __LINE__, VALIDATION_ERROR_01125, "DS", 8706e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes "vkCmdClearAttachments() with aspects not present in image view: %s. %s", 8707e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes string_VkImageAspectFlagBits((VkImageAspectFlagBits)extra_aspects), 8708e9005417571718f4a3c114929e12cb9d088443a2Chris Forbes validation_error_map[VALIDATION_ERROR_01125]); 8709932099bcf863cd3cffc0d779a01710a4d28b4c52Chris Forbes } 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 871483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87154a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 871889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 871989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 872089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 872183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8723b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8725249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 87269f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 87271facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 87281facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && image_state) { 87291facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearColorImage()"); 87301facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 8731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 87321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 8733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 87359f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8736593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 873783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 8738b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 8739249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8740249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8742b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 874383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87444a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 874789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 874889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 874989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 875089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 875183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8753b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8755249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 87569f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 87571facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 87581facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && image_state) { 87591facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_state, "vkCmdClearDepthStencilImage()"); 87601facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_state); 8761e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 87621facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, image_state, true); 8763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 87659f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8766593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 876783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 8768b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 8769249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8770249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8772b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 877383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87744a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, pRanges); 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 877789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 877889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 877989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 878083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8782b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8783593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 87849f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 87851facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto src_image_state = getImageState(dev_data, srcImage); 87861facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto dst_image_state = getImageState(dev_data, dstImage); 87871facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (cb_node && src_image_state && dst_image_state) { 87881facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_image_state, "vkCmdResolveImage()"); 87891facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_image_state, "vkCmdResolveImage()"); 8790249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 87911facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_image_state); 87921facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_image_state); 8793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 87941facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_image_state, "vkCmdResolveImage()"); 8795593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 87969f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8797593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 87981facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, dst_image_state, true); 8799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 88019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8802593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 880383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 8804b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 8805249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8806249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8808b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 880983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88104a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, regionCount, 88114a0754042cf090e131e9e769d8a3633c228625beChris Forbes pRegions); 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8814b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8815b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8816b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8817b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8818b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8819b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8820b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8821b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8822b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8823b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8824b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8825b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8826b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 882789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 882889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 882983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 883483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 883583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 88364710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis auto event_state = getEventNode(dev_data, event); 88374710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state) { 88384710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis addCommandBufferBinding(&event_state->cb_bindings, 8839ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 88404710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->cb_bindings.insert(pCB); 8841ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8843c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8844c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8845c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8846b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8847b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8848b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8850b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 885183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88524a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdSetEvent(commandBuffer, event, stageMask); 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 885589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 885689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 885783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8859b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 886283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 886383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 88644710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis auto event_state = getEventNode(dev_data, event); 88654710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state) { 88664710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis addCommandBufferBinding(&event_state->cb_bindings, 8867ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 88684710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->cb_bindings.insert(pCB); 8869ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8871c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8872c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8873c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8874b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8875b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8876b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8878b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 887983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88804a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResetEvent(commandBuffer, event, stageMask); 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8884e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 890608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 890708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8926e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8948e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8949e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8951e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 895443986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8958577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 89636044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89766044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8987e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8989e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 89932d0b3724d6f7038d6cea5608b7c3be9637034b84Jan-Harald Fredriksen VK_ACCESS_COLOR_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 89982d0b3724d6f7038d6cea5608b7c3be9637034b84Jan-Harald Fredriksen VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 90112d0b3724d6f7038d6cea5608b7c3be9637034b84Jan-Harald Fredriksen VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | 90122d0b3724d6f7038d6cea5608b7c3be9637034b84Jan-Harald Fredriksen VK_ACCESS_SHADER_READ_BIT | VK_ACCESS_INPUT_ATTACHMENT_READ_BIT, type); 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 902408d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour case VK_IMAGE_LAYOUT_PRESENT_SRC_KHR: { 902508d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_MEMORY_READ_BIT, 0, type); 902608d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour break; 902708d0512735df3d7ee6d2b085e4a2fbcac9d990c2Tony Barbour } 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9033577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 9045e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 9046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 9047e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 9048a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis bool skip = false; 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 9052ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 9053a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9054a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 9055a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "with no self dependency specified.", 9056a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, pCB->activeSubpass); 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 90611facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data = getImageState(dev_data, mem_barrier->image); 90626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 90656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 9069a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9070a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 9071a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 9072a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 9073a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 9074a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 9082a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 9090b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 9091b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 9092a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9093a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 9094a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 9095a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 9096a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 9097a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "queueFamilies crated for this device.", 9098a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, dst_q_f_index, 9099a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 9105d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour if (mem_barrier->oldLayout != mem_barrier->newLayout) { 9106a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= 9107d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 9108a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= 9109d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 9110d678ec4f57d80aa89c24562e9ffe941d8d69e455Tony Barbour } 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 9112a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9113a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 9114a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "PREINITIALIZED.", 9115a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName); 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91171facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data = getImageState(dev_data, mem_barrier->image); 91181d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 91191d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 91216d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 91226d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 91236d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 91246d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 91265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 9127170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 9128170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 9129b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 9130b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 9131b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 9132b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 91355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 9139c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis auto aspect_mask = mem_barrier->subresourceRange.aspectMask; 9140a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= ValidateImageAspectMask(dev_data, image_data->image, format, aspect_mask, funcName); 9141f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 9142f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 9143f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 9144f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 9145a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9146a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 9147a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 9148a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "than or equal to the total number of layers (%d).", 9149a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, 9150a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis mem_barrier->subresourceRange.layerCount, arrayLayers); 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9152f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 9153f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 9154f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 9155f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 9156a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg( 9157a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9158a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 9159a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 9160a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "the total number of levels (%d).", 9161a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, mipLevels); 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 9169a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9170a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 9177b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 9179b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 9180a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9181a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 9182a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 9183a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 9184a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 9185a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91888718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 91898718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 9190e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis auto buffer_size = buffer_node->binding.size; 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 9192a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9193a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 9194a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis " which is not less than total size 0x%" PRIx64 ".", 9195a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 9196a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), 9197a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 9199a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis skip |= log_msg( 920094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9201414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 9202414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 920394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 920494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 920594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9209a4a1923d21087ded8e990190acd6752264712319Tobin Ehlis return skip; 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92122ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 9213b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 9214b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 9215b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 9216b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 92172ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 9218b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 9219b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 9220b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 92212ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 9222b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 9223b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 9224b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 92259556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 92269556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 9227b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 922827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 922927c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 92302ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 9231b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 92329556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 9233b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9234b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9235b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9236c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 9237c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 9238c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 9239c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9240c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 92414261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 9242c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 9243c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 92444261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 9245c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 9246b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 9247b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 9248b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 9249b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 925089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 925189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 925289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 925389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 925489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 925583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 92565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9257b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92602ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 92624710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis auto event_state = getEventNode(dev_data, pEvents[i]); 92634710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state) { 92644710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis addCommandBufferBinding(&event_state->cb_bindings, 9265ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 9266ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 92674710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->cb_bindings.insert(pCB); 9268ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 9269c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9272b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 92732ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 9274b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 927683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 927883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 928083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 928183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 928683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92874a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 92884a0754042cf090e131e9e769d8a3633c228625beChris Forbes memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, 92894a0754042cf090e131e9e769d8a3633c228625beChris Forbes imageMemoryBarrierCount, pImageMemoryBarriers); 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 929289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 929389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 929489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 929589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 929689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 929783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9299b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 930283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 930383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 930483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9308b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 930983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 93104a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, memoryBarrierCount, 93114a0754042cf090e131e9e769d8a3633c228625beChris Forbes pMemoryBarriers, bufferMemoryBarrierCount, pBufferMemoryBarriers, 93124a0754042cf090e131e9e769d8a3633c228625beChris Forbes imageMemoryBarrierCount, pImageMemoryBarriers); 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9315d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 9316d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9317d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 9318d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 9319d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 9320d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9321d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 9322d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 9323d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 9324d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9325d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 9326d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 9327d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 932889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 932989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 933083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9332b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 934083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 9341ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9342ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9344b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 934583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 93464a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBeginQuery(commandBuffer, queryPool, slot, flags); 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 934989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 935083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 935783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9359414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9364c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9365d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 936783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 936983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9371ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9372ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9374b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 937583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 93764a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdEndQuery(commandBuffer, queryPool, slot); 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 937989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 938089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 938183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9383b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 9389c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 9390d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 939383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 939583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 939783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 9398ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9399ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9401b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 940283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 94034a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9406d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 9407d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 9408d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 9409d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 9410d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 9411d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 9412d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 9413d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 9414d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 9415d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 9416d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 9417d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 9418d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9419d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9420d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9421d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 9422d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 9423d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 9424d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9425d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9426d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9427d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9428d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9429d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9430d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 9431d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9432d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 9433d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 9434d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 9435d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9436d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9437d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 9438d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 9439d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 944089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 944189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 944289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 944383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9445b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9446ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 94479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 9448ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 9449ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 9450b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 9451ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 9452c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 9453ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 945459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 9455ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 9456e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 9457f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 9458e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 94609f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 9461d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 9462ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 9463ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 9464ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 9465ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 946783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9469b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 9470ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9471ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 9472ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 9473ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9475b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 947683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 94774a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, dstOffset, 94784a0754042cf090e131e9e769d8a3633c228625beChris Forbes stride, flags); 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 948189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 948289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 948389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 948483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9486b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 949083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 949283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 949583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 94969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 949783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 949883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 94999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 95009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 9501a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 9502c2a5a36d03bbe52f5854a5884346e4a84115e259Tobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 950315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 950415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 950515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 950615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 950715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 950815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 950915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 951015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 951115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 951215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 951315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 951415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 951515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 951615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 951715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 951815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 951915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 952015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 952115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 952215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 952315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 952415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 95259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 952615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 952715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 952815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 952915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 953015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 953115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 953215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 953315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 953415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 953515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 953615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 953715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 953815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 953915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 954015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 954115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 954215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 954315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 954415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 954515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 954615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 95479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 95489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 9549a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 955015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 955115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 955215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 955315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 955415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 955515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 9556a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 95579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 955815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 955915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 956015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 956115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 956215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 956315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 956415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 956515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 95665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9567b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 956883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 95694a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 957289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 957389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 957483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9576b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 9580c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9581d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 958383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 958583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9588b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 958983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 95904a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95936600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 95946600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 95956600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 95966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 95976600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 95986600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 95996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 96006600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 96016600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 960279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, *image_view); 960379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_state) { 96041facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const VkImageCreateInfo *ici = &getImageState(dev_data, view_state->create_info.image)->createInfo; 96056600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 96066600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 96076600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 96086600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 96096600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 96106600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 96116600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 96126600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96136600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96146600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96156600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96166600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96176600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 96186600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 96196600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 96206600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9621d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 9622d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 96235ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 96245ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 96255ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 96265ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 96275ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 96285ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 96296fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 9630d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 96316600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 96326600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9633127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto rp_state = getRenderPassState(dev_data, pCreateInfo->renderPass); 9634127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (rp_state) { 9635127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis const VkRenderPassCreateInfo *rpci = rp_state->createInfo.ptr(); 9636d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 9637d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 9638d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9639d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9640d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 9641d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 9642d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 96435ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 964441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 96455ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 96465ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 964779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_views[i]); 964812d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto &ivci = view_state->create_info; 964979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.format != rpci->pAttachments[i].format) { 96505ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 96515ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 96525ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 96535ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 96545ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 96555ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 965679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), 96575ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 96585ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 96591facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis const VkImageCreateInfo *ici = &getImageState(dev_data, ivci.image)->createInfo; 96605ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 966141ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 966241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 966341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 966441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 966541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 966641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 966741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 96685ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 96695ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 967079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.subresourceRange.levelCount != 1) { 96716fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 96726fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 96736fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 96746fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 967579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.levelCount); 96765ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 967779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; 9678aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 9679aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 968079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 9681aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 9682aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 96836fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9684aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9685aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 9686aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 9687aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 9688aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 9689aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 9690aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 9691aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 9692aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 969379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 969479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); 96955ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 969679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || 969779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || 969879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || 969979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { 9700da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 97016fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9702da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9703da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 9704da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 9705da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 9706da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 9707da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 9708da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 970979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), 971079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a)); 97115ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 97125ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9713d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 97145ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 97156600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 97166600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 97176600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 97186600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 97196600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 97206600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 97216600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 97226600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 97236600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 97246600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 97256600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 97266600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 97276600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 9728d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 9729d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 9730d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9731d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9732d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 9733d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 97346600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 97356fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 97366fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 97376fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 97386fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 97396fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 97406fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 97416fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 97426fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 97436fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 97446fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 97456fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 97466fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 97476fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 97486fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 97496fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 97506600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 97516600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 97526600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 975364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 975464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 975564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 975664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 975764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 975864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 9759d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 976064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 976164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 976264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 976354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 976454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 976554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 9766c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis std::unique_ptr<FRAMEBUFFER_STATE> fb_state( 9767c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis new FRAMEBUFFER_STATE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->createInfo.ptr())); 976876f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 976954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 977054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 977179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, view); 977279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) { 977354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 977454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 977554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 9776e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis fb_info.mem = getImageState(dev_data, view_state->create_info.image)->binding.mem; 9777883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis fb_info.view_state = view_state; 977879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.image = view_state->create_info.image; 9779c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis fb_state->attachments.push_back(fb_info); 978054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 9781c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_state); 978254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 978354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 978489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 978589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 978689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 978864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 978964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 979064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 979164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 979264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 979364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 979464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 97954a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 97966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 979864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 979954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 980054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9805e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 9806e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 9809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 9816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98248860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CheckDependencyExists(const layer_data *dev_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 9825e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 9826e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 98291d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 98367655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 98387655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 98397655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 98408860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 9844e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98518860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CheckPreserved(const layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 9852e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 9858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 9862e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9864e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 98678860b85a52096f9f9b28616bc37feed505497a54Chris Forbes result |= CheckPreserved(dev_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 9872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 9875e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98818860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9899c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic bool ValidateDependencies(const layer_data *dev_data, FRAMEBUFFER_STATE const *framebuffer, 9900127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis RENDER_PASS_STATE const *renderPass) { 9901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9902fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pFramebufferInfo = framebuffer->createInfo.ptr(); 9903fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pCreateInfo = renderPass->createInfo.ptr(); 990416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99188860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto view_state_i = getImageViewState(dev_data, viewi); 99198860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto view_state_j = getImageViewState(dev_data, viewj); 992079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state_i || !view_state_j) { 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 992379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_i = view_state_i->create_info; 992479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_j = view_state_j->create_info; 992579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 99275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99301facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data_i = getImageState(dev_data, view_ci_i.image); 99311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_data_j = getImageState(dev_data, view_ci_j.image); 99326d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9935e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis if (image_data_i->binding.mem == image_data_j->binding.mem && 9936e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis isRangeOverlapping(image_data_i->binding.offset, image_data_i->binding.size, image_data_j->binding.offset, 9937e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis image_data_j->binding.size)) { 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 99488860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 99558860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 99631c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 99661c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 996993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 997093fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 997893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 997993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99841c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99921c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 99931c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 99941c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 99958860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99968860b85a52096f9f9b28616bc37feed505497a54Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 99978860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", attachment, i); 99981c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 1000693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 1000793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 1000893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 100098860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 100125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 1001393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 1001493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 1001593fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 100168860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 100178860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 100218860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 100228860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckDependencyExists(dev_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 100308860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CheckPreserved(dev_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10035be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 10036be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 10037be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 10038be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 10039be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 10040be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 10041be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 10042be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 10043be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 10044be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 10045be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 10046be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 10047be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 10048be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10049be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 10050be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 10051be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 10052be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 10053be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100558860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool ValidateLayouts(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 10056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1005877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 1005977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 100630ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 100640ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 100650ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 100660ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 10067c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pColorAttachments[j].layout) { 10068c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 10069c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* This is ideal. */ 10070c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 10071c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 10072c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 10073c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 10074c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints? 10075c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 100768860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 100778860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10078c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 10079c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 10080c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 10081c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 100828860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 100838860b85a52096f9f9b28616bc37feed505497a54Chris Forbes __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10084c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 10085c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pColorAttachments[j].layout)); 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10087c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 1008877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 100898860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pColorAttachments[j].layout, 1009077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 1009177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 1009277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10094c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 10095cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes switch (subpass.pDepthStencilAttachment->layout) { 10096cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 10097cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 10098cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* These are ideal. */ 10099cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 10100cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 10101cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 10102cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 10103cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * other constraints? GENERAL can be better than doing a bunch 10104cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * of transitions. 10105cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes */ 101068860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 101078860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10108cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "GENERAL layout for depth attachment may not give optimal performance."); 10109cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 10110cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 10111cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes default: 10112cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* No other layouts are acceptable */ 101138860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 101148860b85a52096f9f9b28616bc37feed505497a54Chris Forbes __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10115cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " 10116cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", 101175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 101185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10119cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 10120be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 1012177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 101228860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pDepthStencilAttachment->layout, 1012377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 1012477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 1012577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 1012677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 1012777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 1012877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 1012977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 1013077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 1013177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 10132c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pInputAttachments[j].layout) { 10133c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 10134c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: 10135c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* These are ideal. */ 10136c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 10137c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 10138c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 10139c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal. TODO: reconsider this warning based on 10140c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints. 10141c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 101428860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 101438860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10144c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 10145c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 10146c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 10147c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 10148c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* No other layouts are acceptable */ 101498860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10150c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 10151c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 10152c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pInputAttachments[j].layout)); 1015377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 10154c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 1015577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 101568860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip |= ValidateLayoutVsAttachmentDescription(dev_data->report_data, subpass.pInputAttachments[j].layout, 1015777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 1015877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 1015977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 101605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 101635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101658860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool CreatePassDAG(const layer_data *dev_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 10166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 10167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 101735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 1017466a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 1017566a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == dependency.dstSubpass) { 1017666a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes skip_call |= 101778860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1017866a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 1017966a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } 1018066a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } else if (dependency.srcSubpass > dependency.dstSubpass) { 101818860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 101825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 101835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 101855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 101865c6aacf95832467d52b2fde1130b04bef559573aChris Forbes } else { 101875c6aacf95832467d52b2fde1130b04bef559573aChris Forbes subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 101885c6aacf95832467d52b2fde1130b04bef559573aChris Forbes subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 101895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10193918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1019589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 1019689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1019789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 101988860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10200b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10201b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 10202b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 10203b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 10204b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 10205b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10206b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 10207b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 102088860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= 102098860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 102108860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VkDebugReportObjectTypeEXT(0), 0, __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 102118860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "SPIR-V module not valid: %s", diag && diag->error ? diag->error : "(no error text)"); 102125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10214b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 10215b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 10216b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 10217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 102185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 102195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102204a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult res = dev_data->dispatch_table.CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 102215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 10223b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 102248860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 102255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 102275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 102304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 102314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 102324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 102344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 102354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 102364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 102384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 102394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10240805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 10241805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 10242805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 10243805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 102444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 102454f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 102464f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 102474f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 102484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 102494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 102504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 102524f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 102534f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102544f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 102554f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 102564f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 102574f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 102584f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 102594f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 102604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 102614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 102624f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102634f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102646a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 102656a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 102666a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 102676a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 102686a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 10269805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 10270805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 102714f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 102724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 102734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 102744f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 102754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 102766a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 102776a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 102786a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 102796a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 102806a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 102816a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 102826a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 102836a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 102846a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 102854f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 102864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 102874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 102886a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 10289805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 10290805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 10291805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10292dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 10293dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 10294dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 10295dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 10296dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 10297dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 10298dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 10299dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 103006a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 103014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10302dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 103034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 103044f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 103054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 10306805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10307805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 10308805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 10309805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 103104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10311dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 103124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 103134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 103144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 103154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 10316805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 10317805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 10318805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 10319805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 10320805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 10321805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 10322805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 10323805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 103244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 103254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 103264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 103274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 1032889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 103294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 10330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 103334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 103344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 103354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 103364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 103374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 103384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 10339ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 103404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 103414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 103424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 103434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 103444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 103454a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 10346ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 103484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 103494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 103504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 103514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 103524f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 103534f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10354127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto render_pass = unique_ptr<RENDER_PASS_STATE>(new RENDER_PASS_STATE(pCreateInfo)); 1035598cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 10356cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 10357cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 10358db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 1035987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 10360cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 103616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 1036287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 1036387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 1036487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 103654f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 103664f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 103674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 103684f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 103690d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 1037087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 1037187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 1037287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 103734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 103744f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 103754f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 1037624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 1037787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10378a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10379a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 103804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 103814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 103824f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 1038324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 10384a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 1038587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10386db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 10387fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10392e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 10393e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10394127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto const pRenderPassInfo = getRenderPassState(dev_data, pRenderPassBegin->renderPass)->createInfo.ptr(); 1039548a43d923a7b126a78770bd209d63902ffa0520aChris Forbes auto const & framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 103975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 1040379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_view); 1040479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 1040579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImage &image = view_state->create_info.image; 1040679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 104105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10420c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 10421c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10424c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 10425c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 10426c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 10427c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 10428c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 10429c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 104301c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10438c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlisstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, FRAMEBUFFER_STATE *pFramebuffer, 10439c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis VkAttachmentReference ref) { 10440628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 10441628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 10442628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 10443628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 10444628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 10445628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 1044627ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 10447e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 10448127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); 1044916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1045116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10452c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); 10453e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10455e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 10456fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const &subpass = renderPass->createInfo.pSubpasses[subpass_index]; 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10458628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 10461628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10463628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 10464628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 104655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104688860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool validatePrimaryCommandBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 10469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 104718860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10478f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 10479127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = getRenderPassState(dev_data, pRenderPassBegin->renderPass); 1048016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1048216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10483fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->createInfo.ptr(); 10484c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pRenderPassBegin->framebuffer); 10485e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10487e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 10489628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 104905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104948860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool VerifyRenderAreaBounds(const layer_data *dev_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 10495885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 10496c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = 10497c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis &getFramebufferState(dev_data, pRenderPassBegin->framebuffer)->createInfo; 10498885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 10499885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 10500885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 10501885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 10502885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 105038860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10504885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 10505885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 10506885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 10507885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 10508885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 10509885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 10510885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 10511885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 10512885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 10513885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 105141a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 105151a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 105161a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 105171a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 10518a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 10519a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 10520a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 105211a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 105221a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 10523a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 10524a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 10525a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 105261a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 105271a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 1052889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1052989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 1053083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10532b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10533f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 10534127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto renderPass = pRenderPassBegin ? getRenderPassState(dev_data, pRenderPassBegin->renderPass) : nullptr; 10535c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = pRenderPassBegin ? getFramebufferState(dev_data, pRenderPassBegin->framebuffer) : nullptr; 10536f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 1053716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 105386de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 10539f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; 105406e17c244b21ce43ac57404a00a0d844039eed363Mark Lobodzinski for (uint32_t i = 0; i < renderPass->createInfo.attachmentCount; ++i) { 10541f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10542fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto pAttachment = &renderPass->createInfo.pAttachments[i]; 10543db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10544db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 105451a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 1054692bc0680357019834b7529148ab6d73353ce02c7Mark Lobodzinski clear_op_size = static_cast<uint32_t>(i) + 1; 1054716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 105481facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); 1054916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1055016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10551f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10552db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10553db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 105541a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 1055516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 105561facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); 1055716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1055816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10559f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10560db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10561db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 105621a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 1056316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 105641facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), 10565f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1056616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10567f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 1056816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 10569db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (renderPass->attachment_first_read[i]) { 1057016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 105711facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageState(dev_data, fb_info.image), 10572f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1057316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10574f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105776de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 105786de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 105796de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 1058077aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, VALIDATION_ERROR_00442, "DS", 105816de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 105826de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 105836de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 105846de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 105856de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 1058677aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis "attachments that aren't cleared they will be ignored. %s", 105876de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 1058877aa75f997ecb8c39c815d79042d1553c08a9b85Tobin Ehlis clear_op_size, clear_op_size - 1, validation_error_map[VALIDATION_ERROR_00442]); 105893d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 1059083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 10591f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); 10592f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass"); 1059383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 10594f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass"); 10595f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 10596f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = renderPass; 105975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 10598f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; 10599f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = 0; 10600f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpassContents = contents; 10601f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); 10602883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 10603883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 10604ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 10605f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1060783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1060883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1060983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10612b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1061383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 106144a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1061889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 1061983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10621b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 1062483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 1062583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 1062683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 1062780281691386b37385846f21b38e8c9d4b12cc74eChris Forbes 10628fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; 1062980281691386b37385846f21b38e8c9d4b12cc74eChris Forbes if (pCB->activeSubpass == subpassCount - 1) { 1063080281691386b37385846f21b38e8c9d4b12cc74eChris Forbes skip_call |= 1063180281691386b37385846f21b38e8c9d4b12cc74eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1063280281691386b37385846f21b38e8c9d4b12cc74eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1063380281691386b37385846f21b38e8c9d4b12cc74eChris Forbes "vkCmdNextSubpass(): Attempted to advance beyond final subpass"); 1063480281691386b37385846f21b38e8c9d4b12cc74eChris Forbes } 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10636b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1063796ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1063896ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (skip_call) 1063996ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes return; 1064096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 106414a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdNextSubpass(commandBuffer, contents); 1064296ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1064396ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (pCB) { 1064496ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes lock.lock(); 1064596ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpass++; 1064696ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpassContents = contents; 1064796ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 1064896ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes } 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1065189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 1065283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10654b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1065558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 1065658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 10657127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis RENDER_PASS_STATE *rp_state = pCB->activeRenderPass; 10658c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto framebuffer = getFramebufferState(dev_data, pCB->activeFramebuffer); 10659127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (rp_state) { 10660127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (pCB->activeSubpass != rp_state->createInfo.subpassCount - 1) { 1066102a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes skip_call |= 1066202a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1066302a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1066402a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes "vkCmdEndRenderPass(): Called before reaching final subpass"); 1066502a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes } 1066602a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes 10667127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis for (size_t i = 0; i < rp_state->createInfo.attachmentCount; ++i) { 10668e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10669127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto pAttachment = &rp_state->createInfo.pAttachments[i]; 10670db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10671db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_STORE)) { 1067258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 106731facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), true); 1067458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1067558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1067658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 10677db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10678db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, 106791a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 1068058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 106811facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis SetImageMemoryValid(dev_data, getImageState(dev_data, fb_info.image), false); 1068258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1068358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1068458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1068883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 1068983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 1069083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 106910e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes } 106920e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.unlock(); 106930e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 106940e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (skip_call) 106950e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes return; 106960e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 106974a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdEndRenderPass(commandBuffer); 106980e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 106990e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (pCB) { 107000e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.lock(); 10701f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 1070258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 1070358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 1070458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10708a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 10709a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10712a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 10713a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 10714a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 10715a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10718a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10719a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 10720a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 10721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10723a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 107245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10726a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 10733a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10734a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 10738a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10739a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10742a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 10743a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10744a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10746a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 10747a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10748a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10750a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 10751a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10752a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10757a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10758a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10759a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10761a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 10762a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 107675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10772a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 10773a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 107765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 107775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10784a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 10785a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 107865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 107895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 107915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10793a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 10794a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 107995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10803a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 10804a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 108055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 108065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10808a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 10809a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 10810a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 10811a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10812a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10813a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10815a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 10816a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 108175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 108185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10819a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 10820a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 10821a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 10822a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 10823a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 10824a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 10825a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 10826a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 10827a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 10828a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 108295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 108315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 10834e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 108355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 108365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 108375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 108385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10839c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 108425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 108435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 108441af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 10845d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "vkCmdExecuteCommands() called w/ invalid secondary command buffer 0x%" PRIx64 108461af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " which has a framebuffer 0x%" PRIx64 10847d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen " that is not the same as the primary command buffer's current active framebuffer 0x%" PRIx64 ".", 108481af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), 108491af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(primary_fb)); 108505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10851c54e405a4ce05f4de10bb78bfc3a4769c41d2d59Tobin Ehlis auto fb = getFramebufferState(dev_data, secondary_fb); 10852e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 108535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 108545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10855414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10856414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 108575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 108585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 108595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10860127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto cb_renderpass = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 10861a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 10862a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 10863fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes cb_renderpass->createInfo.ptr()); 10864a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 108655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 108675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10869e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 1087083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 108715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 108725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 108735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 108745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 108755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 108775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 108785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 1087983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 108805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 108815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10882414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10883414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 108845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 108855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 108865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 108895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 108925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 108935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 1089483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 108955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 108965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10897414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10898414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 10899414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 109005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 109015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 109025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109047bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 109057bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 109067bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); 109077bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { 109087bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 109097bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 109107bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIxLEAST64 109117bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d has secondary command buffer 0x%" PRIxLEAST64 " created in queue family %d.", 109127bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), primary_pool->queueFamilyIndex, 109137bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), secondary_pool->queueFamilyIndex); 109147bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 109157bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 1091683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 109175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1091989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1092089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 1092183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 109225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10923b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 109245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 109255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 109265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 109275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 109285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 109295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 1093083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 109315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 109325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10933414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 109345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 109355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 1093683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 1093783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 1093883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 1093983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 1094083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 109415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 10942127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis auto secondary_rp_state = getRenderPassState(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 109435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 1094483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 109455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 109465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 10947414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 109485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 10949ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 109505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 109515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 10952127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) { 10953fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes skip_call |= 10954fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->createInfo.ptr(), 10955127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis pCommandBuffers[i], secondary_rp_state->createInfo.ptr()); 10956a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 109571af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB 1095883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 109595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 109611af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass 10962127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_state->renderPass) && 10963fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->createInfo.ptr(), 10964127937bcdb5817ee4568887c298ce36c88f3c58bTobin Ehlis secondary_rp_state->createInfo.ptr(), errorString)) { 1096583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 109665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 109675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 10968414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 10969414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 109705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 10971ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 109725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 1097583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 1097675b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()"); 109775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 109785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 109795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 109805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 1098183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 109825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 109835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10984d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen "Attempt to simultaneously execute command buffer 0x%" PRIxLEAST64 10985d79335137b414d5f89284a9ab3e014beb4ada3ebMike Weiblen " without VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set!", 109865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 109875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 109895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 1099083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 109915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 109925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10993414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 109945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 10995414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 1099683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 109975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 109985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 109995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11001f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { 1100283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 110035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 110045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 110055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 11006414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 110075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 110085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 110095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 110105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 110125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 110135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 11014d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine for (auto &function : pSubCB->queryUpdates) { 11015d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine pCB->queryUpdates.push_back(function); 11016d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine } 110175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1101883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 1101983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 110205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11021b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1102283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 110234a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 110245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11026b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis// For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL 11027cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, 11028623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis VkDeviceSize end_offset) { 11029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 110305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11031cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // Iterate over all bound image ranges and verify that for any that overlap the 11032cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL 11033cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range 11034cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto image_handle : mem_info->bound_images) { 11035cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis auto img_it = mem_info->bound_ranges.find(image_handle); 11036cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (img_it != mem_info->bound_ranges.end()) { 11037623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { 11038b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis std::vector<VkImageLayout> layouts; 11039825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { 11040b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis for (auto layout : layouts) { 11041b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 11042b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis skip_call |= 11043b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 11044b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 11045b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 11046b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis string_VkImageLayout(layout)); 11047b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 11048b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 11049b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 11050b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 11051b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 110525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 110545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1105689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1105789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 110585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 110615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 11062b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11063cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 11064cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (mem_info) { 11065f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis // TODO : This could me more fine-grained to track just region that is valid 11066f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis mem_info->global_valid = true; 11067623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; 11068623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); 11069cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : Do we need to create new "bound_range" for the mapped range? 11070623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis SetMemRangesValid(dev_data, mem_info, offset, end_offset); 11071cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & 11072b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 110735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 110745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 110755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 11076414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 110775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11079f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); 11080b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 110815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11082e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 110834a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.MapMemory(device, mem, offset, size, flags, ppData); 110847c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 110857c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 11086cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this 110877c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 110885f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski initializeAndTrackMemory(dev_data, mem, offset, size, ppData); 110897c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 110907c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 110915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1109589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 110968860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1109783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 110985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 111008860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= deleteMemRanges(dev_data, mem); 11101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1110283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 111034a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.UnmapMemory(device, mem); 111045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111078860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool validateMemoryIsMapped(layer_data *dev_data, const char *funcName, uint32_t memRangeCount, 11108e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1110983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 111105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 111118860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); 1111257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 11113de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.offset > pMemRanges[i].offset) { 1111483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 111158860b85a52096f9f9b28616bc37feed505497a54Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1111657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1111757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1111857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 11119de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->mem_range.offset)); 111205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111214b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 111228860b85a52096f9f9b28616bc37feed505497a54Chris Forbes const uint64_t dev_dataTerminus = (mem_info->mem_range.size == VK_WHOLE_SIZE) 111238860b85a52096f9f9b28616bc37feed505497a54Chris Forbes ? mem_info->alloc_info.allocationSize 111248860b85a52096f9f9b28616bc37feed505497a54Chris Forbes : (mem_info->mem_range.offset + mem_info->mem_range.size); 111258860b85a52096f9f9b28616bc37feed505497a54Chris Forbes if (pMemRanges[i].size != VK_WHOLE_SIZE && (dev_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 111268860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 111278860b85a52096f9f9b28616bc37feed505497a54Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 111288860b85a52096f9f9b28616bc37feed505497a54Chris Forbes MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 111298860b85a52096f9f9b28616bc37feed505497a54Chris Forbes ") exceeds the Memory Object's upper-bound " 111308860b85a52096f9f9b28616bc37feed505497a54Chris Forbes "(" PRINTF_SIZE_T_SPECIFIER ").", 111318860b85a52096f9f9b28616bc37feed505497a54Chris Forbes funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 111328860b85a52096f9f9b28616bc37feed505497a54Chris Forbes static_cast<size_t>(dev_dataTerminus)); 111335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1113683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 111375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111398860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *dev_data, uint32_t memRangeCount, 11140e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1114183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 111425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 111438860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, pMemRanges[i].memory); 1114457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 111455f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 111465f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 111475f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 11148d8a53ade6b5501256798a8b4ec0bc14f72adc1faTobin Ehlis : (mem_info->alloc_info.allocationSize - mem_info->mem_range.offset); 111495f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 111505f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { 111515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1115283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 111538860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1115483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 111555f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 111565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111585f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { 111595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1116083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 111618860b85a52096f9f9b28616bc37feed505497a54Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1116283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1116383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 111645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111665f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); 111675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1117083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 111715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111738860b85a52096f9f9b28616bc37feed505497a54Chris Forbesstatic void CopyNoncoherentMemoryFromDriver(layer_data *dev_data, uint32_t memory_range_count, 111745f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski const VkMappedMemoryRange *mem_ranges) { 111759e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski for (uint32_t i = 0; i < memory_range_count; ++i) { 111768860b85a52096f9f9b28616bc37feed505497a54Chris Forbes auto mem_info = getMemObjInfo(dev_data, mem_ranges[i].memory); 111775f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info && mem_info->shadow_copy) { 111785f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 111795f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 111805f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); 111815f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 111825f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); 111839e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 111849e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 111859e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski} 111869e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski 1118732cfeefe331adc1f1d779b02b4f60221d9935985Mike StroyanVKAPI_ATTR VkResult VKAPI_CALL 1118889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 111895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1119083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 111918860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 111925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11193b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 111948860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= ValidateAndCopyNoncoherentMemoryToDriver(dev_data, memRangeCount, pMemRanges); 111958860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= validateMemoryIsMapped(dev_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 11196b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1119783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 111984a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 111995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1120332cfeefe331adc1f1d779b02b4f60221d9935985Mike StroyanVKAPI_ATTR VkResult VKAPI_CALL 1120489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 112055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1120683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 112078860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 112085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11209b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 112108860b85a52096f9f9b28616bc37feed505497a54Chris Forbes skip_call |= validateMemoryIsMapped(dev_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 11211b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1121283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 112134a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 112149e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski // Update our shadow copy with modified driver data 112158860b85a52096f9f9b28616bc37feed505497a54Chris Forbes CopyNoncoherentMemoryFromDriver(dev_data, memRangeCount, pMemRanges); 112165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1122089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 112215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 112225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1122383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11224b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 112251facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 112261facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (image_state) { 1122794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1122847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 11229888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call = SetMemBinding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 112305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 11231b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 112324a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.GetImageMemoryRequirements(device, image, &memRequirements); 11233b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1123447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1123547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1123657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1123757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 112389f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, memRequirements, 112391facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->createInfo.tiling == VK_IMAGE_TILING_LINEAR); 1124083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1124147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1124247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 112430a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 11244b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1124583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 112464a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.BindImageMemory(device, image, mem, memoryOffset); 11247b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 11248e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis image_state->binding.mem = mem; 11249e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis image_state->binding.offset = memoryOffset; 11250e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis image_state->binding.size = memRequirements.size; 11251b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1125294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1125394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1125494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1125594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 11256414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1125794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 112585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1126289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 112633ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 112643ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 112655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11266b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 112674710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis auto event_state = getEventNode(dev_data, event); 112684710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state) { 112694710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->needsSignaled = false; 112704710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis event_state->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 112714710dda89a1dd2e023334d4eda710a394b211cdcTobin Ehlis if (event_state->write_in_use) { 112723ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 112733ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11274414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 112753ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 112763ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 112773ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 11278b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 112796fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 112806fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 112816fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 112826fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 112836fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 112846fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 112856fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 112866fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 112876fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 112883ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 112894a0754042cf090e131e9e769d8a3633c228625beChris Forbes result = dev_data->dispatch_table.SetEvent(device, event); 112905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1129489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 112955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 112965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 11297e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 11298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11299651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 11300651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 11301651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 113024b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 11303651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 11304651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 113059867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 113069867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, bindInfoCount); 113074b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 11308651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 113091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 113101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 113115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 113121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 113131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 11314f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis auto sparse_binding = bindInfo.pBufferBinds[j].pBinds[k]; 11315f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, 11316f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 11317f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis "vkQueueBindSparse")) 11318e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 113195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 113221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 11323f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis auto sparse_binding = bindInfo.pImageOpaqueBinds[j].pBinds[k]; 11324f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, sparse_binding.size}, 11325f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 11326f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis "vkQueueBindSparse")) 11327e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 113285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 113311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 11332f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis auto sparse_binding = bindInfo.pImageBinds[j].pBinds[k]; 11333f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis // TODO: This size is broken for non-opaque bindings, need to update to comprehend full sparse binding data 11334f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis VkDeviceSize size = sparse_binding.extent.depth * sparse_binding.extent.height * sparse_binding.extent.width * 4; 11335f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis if (SetSparseMemBinding(dev_data, {sparse_binding.memory, sparse_binding.memoryOffset, size}, 11336f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 11337f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis "vkQueueBindSparse")) 11338e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 113395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113419867daedbf52debc77d6568162ee21e071699b80Chris Forbes 113429867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT> semaphore_waits; 113439867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore> semaphore_signals; 113441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1134501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1134601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1134701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1134801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 113499867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 113509867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 113519867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 113529867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 113539867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 1135401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 113551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 113561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 113575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 113581344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11359414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 113601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 113611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 113625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1136601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1136701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1136801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1136901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 113705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 113715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 113721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11373414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 113741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 113751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 113765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113779867daedbf52debc77d6568162ee21e071699b80Chris Forbes else { 113789867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 113799867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 113809867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaled = true; 113819867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 113829867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 113839867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 113845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113869867daedbf52debc77d6568162ee21e071699b80Chris Forbes 113879867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 113889867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits, 113899867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals, 113909867daedbf52debc77d6568162ee21e071699b80Chris Forbes bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); 113915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113929867daedbf52debc77d6568162ee21e071699b80Chris Forbes 113939867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !bindInfoCount) { 113949867daedbf52debc77d6568162ee21e071699b80Chris Forbes // No work to do, just dropping a fence in the queue by itself. 113959867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 113969867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 113979867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 113989867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 113999867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 114009867daedbf52debc77d6568162ee21e071699b80Chris Forbes 114010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 11402b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 114035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 114054a0754042cf090e131e9e769d8a3633c228625beChris Forbes return dev_data->dispatch_table.QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 114065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 114085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1141089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1141189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 114125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 114134a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 114145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11415b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 114165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 114179867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.first = VK_NULL_HANDLE; 114189867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.second = 0; 114191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 114205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 114225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1142589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 114265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 114274a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateEvent(device, pCreateInfo, pAllocator, pEvent); 114285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11429b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 114305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 11431293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 114325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 114335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 114355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11437d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbesstatic bool PreCallValidateCreateSwapchainKHR(layer_data *dev_data, VkSwapchainCreateInfoKHR const *pCreateInfo, 11438d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes SURFACE_STATE *surface_state, SWAPCHAIN_NODE *old_swapchain_state) { 11439d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes auto most_recent_swapchain = surface_state->swapchain ? surface_state->swapchain : surface_state->old_swapchain; 11440d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 11441d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (most_recent_swapchain != old_swapchain_state || (surface_state->old_swapchain && surface_state->swapchain)) { 11442d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 11443d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes reinterpret_cast<uint64_t>(dev_data->device), __LINE__, DRAWSTATE_SWAPCHAIN_ALREADY_EXISTS, "DS", 11444d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes "vkCreateSwapchainKHR(): surface has an existing swapchain other than oldSwapchain")) 11445d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return true; 11446d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes } 11447d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (old_swapchain_state && old_swapchain_state->createInfo.surface != pCreateInfo->surface) { 11448d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11449d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes reinterpret_cast<uint64_t const &>(pCreateInfo->oldSwapchain), __LINE__, DRAWSTATE_SWAPCHAIN_WRONG_SURFACE, 11450d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes "DS", "vkCreateSwapchainKHR(): pCreateInfo->oldSwapchain's surface is not pCreateInfo->surface")) 11451d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return true; 11452d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes } 11453d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 11454d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return false; 11455d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes} 11456d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 1145789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1145889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1145989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 114605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11461ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto surface_state = getSurfaceState(dev_data->instance_data, pCreateInfo->surface); 11462ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto old_swapchain_state = getSwapchainNode(dev_data, pCreateInfo->oldSwapchain); 11463ddc5201048319558ce66701163a4546ee957af19Chris Forbes 11464d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes if (PreCallValidateCreateSwapchainKHR(dev_data, pCreateInfo, surface_state, old_swapchain_state)) 11465d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11466d3b3114fb37a32af2ba563f784da54a877492b23Chris Forbes 114674a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 114685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 11470b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 11471ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto swapchain_state = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo, *pSwapchain)); 11472ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = swapchain_state.get(); 11473ddc5201048319558ce66701163a4546ee957af19Chris Forbes dev_data->device_extensions.swapchainMap[*pSwapchain] = std::move(swapchain_state); 11474ddc5201048319558ce66701163a4546ee957af19Chris Forbes } else { 11475ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = nullptr; 114765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11478ddc5201048319558ce66701163a4546ee957af19Chris Forbes // Spec requires that even if CreateSwapchainKHR fails, oldSwapchain behaves as replaced. 11479ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->old_swapchain = old_swapchain_state; 11480ddc5201048319558ce66701163a4546ee957af19Chris Forbes 114815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 114825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1148489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1148589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 114865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1148783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 114885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11489b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11490b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11491b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 11492b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 11493b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 114945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 114955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 114965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 114975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 114985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 114995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 115005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 115035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1150483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 11505f19cf73769d6fc784ef4c3bf70b85739b4810693Tobin Ehlis ClearMemoryObjectBindings(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1150694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 115075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11509ddc5201048319558ce66701163a4546ee957af19Chris Forbes 11510ddc5201048319558ce66701163a4546ee957af19Chris Forbes auto surface_state = getSurfaceState(dev_data->instance_data, swapchain_data->createInfo.surface); 11511ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state) { 11512ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state->swapchain == swapchain_data) 11513ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->swapchain = nullptr; 11514ddc5201048319558ce66701163a4546ee957af19Chris Forbes if (surface_state->old_swapchain == swapchain_data) 11515ddc5201048319558ce66701163a4546ee957af19Chris Forbes surface_state->old_swapchain = nullptr; 11516ddc5201048319558ce66701163a4546ee957af19Chris Forbes } 11517ddc5201048319558ce66701163a4546ee957af19Chris Forbes 115185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 115195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11520b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1152183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 115224a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.DestroySwapchainKHR(device, swapchain, pAllocator); 115235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1152589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1152689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 115275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 115284a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 115295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 115315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 115325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 115335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 11534b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 115355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 11536b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 11537b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 115380801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 115390801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 115400801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 115415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 115425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 115435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 115445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 11545414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 115465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 115475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 115485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 115515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 115525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 115535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 115546d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 115556d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 115566d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 115576d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 115586d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 115596d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1156041ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 115616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 115626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 115636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 115641facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_STATE>(new IMAGE_STATE(pSwapchainImages[i], &image_ci)); 115651facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto &image_state = dev_data->imageMap[pSwapchainImages[i]]; 115661facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->valid = false; 11567e46491ee6f16b9d29e68914fc6522aba2fde0ad4Tobin Ehlis image_state->binding.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 115685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 115695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 115705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 115715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 115725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 115735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 115765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1157889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 115795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 115805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 115815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115826c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 115836c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 115846c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 115856c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 115866c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 115876c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 115886c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 115896c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 115906c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 115915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115926c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 11593249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 115946c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 115956c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11596a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (swapchain_data) { 11597a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { 11598a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11599d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, 11600a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", 11601a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); 11602a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11603a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes else { 11604a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 116051facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 116061facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis skip_call |= ValidateImageMemoryIsValid(dev_data, image_state, "vkQueuePresentKHR()"); 11607a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 116081facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis if (!image_state->acquired) { 11609a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11610a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, 11611a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", 11612a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i]); 11613a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11614a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 11615a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes vector<VkImageLayout> layouts; 11616a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (FindLayouts(dev_data, image, layouts)) { 11617a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes for (auto layout : layouts) { 11618a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 11619a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= 11620a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 11621a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 11622a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "Images passed to present must be in layout " 11623a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s", 11624a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes string_VkImageLayout(layout)); 11625a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 116265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 116275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 116285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 116295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 116305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 116315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 116326c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 116336c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 116346c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 116356c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 116364a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.QueuePresentKHR(queue, pPresentInfo); 116376c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 116386c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 116396c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 116406c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 116416c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 116426c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 116439867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore) { 116449867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 116456c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 116466c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 116476c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 116489867daedbf52debc77d6568162ee21e071699b80Chris Forbes 11649220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 11650220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Note: this is imperfect, in that we can get confused about what 11651220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // did or didn't succeed-- but if the app does that, it's confused 11652220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // itself just as much. 11653220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; 11654220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11655220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) 11656220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes continue; // this present didn't actually happen. 11657220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11658220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as having been released to the WSI 11659220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11660220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 116611facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 116621facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->acquired = false; 11663220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes } 11664220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 116659867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Note: even though presentation is directed to a queue, there is no 116669867daedbf52debc77d6568162ee21e071699b80Chris Forbes // direct ordering between QP and subsequent work, so QP (and its 116679867daedbf52debc77d6568162ee21e071699b80Chris Forbes // semaphore waits) /never/ participate in any completion proof. 116686c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 116691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 116705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 116715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 116725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11673c827a5880dc3fabfc7d1a58bb62798649cab1181Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, 11674c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkSwapchainCreateInfoKHR *pCreateInfos, 11675c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { 11676c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11677c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young std::unique_lock<std::mutex> lock(global_lock); 11678c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young VkResult result = 116794a0754042cf090e131e9e769d8a3633c228625beChris Forbes dev_data->dispatch_table.CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); 11680c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return result; 11681c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young} 11682c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1168389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1168489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 116855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1168683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 116871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 11688b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11689449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11690449670637ef4214b33018f497cf10daeff9dc85bChris Forbes if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { 11691449670637ef4214b33018f497cf10daeff9dc85bChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 11692d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t &>(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", 11693449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way " 11694449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "to determine the completion of this operation."); 11695449670637ef4214b33018f497cf10daeff9dc85bChris Forbes } 11696449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11697f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 11698f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1169983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1170083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1170183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 117025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11703f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11704f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 11705f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1170683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 117075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11708b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 117091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1171083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 11711f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11712f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 117134a0754042cf090e131e9e769d8a3633c228625beChris Forbes VkResult result = dev_data->dispatch_table.AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 11714f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11715f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 11716f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 11717f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 11718f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 117199867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. 11720f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11721f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11722f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 11723f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 11724f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 117259867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 11726f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11727220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11728220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as acquired. 11729220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11730220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[*pImageIndex]; 117311facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis auto image_state = getImageState(dev_data, image); 117321facd2c91911508b9fb61f54a56269841299f663Tobin Ehlis image_state->acquired = true; 117335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11734f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 117351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 117365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 117375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 117385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11739f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 11740f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1174183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11742f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11743219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes 11744219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (instance_data) { 11745f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 11746f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11747219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes instance_data->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 11748f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11749219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes if (UNCALLED == instance_data->vkEnumeratePhysicalDevicesState) { 11750f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 11751f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 11752b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 11753219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11754219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 11755219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 11756f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 11757219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes else if (instance_data->physical_devices_count != *pPhysicalDeviceCount) { 11758f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 11759b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11760219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11761219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 11762219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes "supported by this instance is %u.", 11763219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes *pPhysicalDeviceCount, instance_data->physical_devices_count); 11764f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11765219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes instance_data->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 11766f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1176783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 11768f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11769f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 117709172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkResult result = instance_data->dispatch_table.EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 11771f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11772219f00ffed576643641976122fa1db8e5fce5dc1Chris Forbes instance_data->physical_devices_count = *pPhysicalDeviceCount; 117735f270eedee8426a5b556a8a9432dd836d83f7b51Tony Barbour } else if (result == VK_SUCCESS){ // Save physical devices 11774f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 117753bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto & phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; 117763bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes phys_device_state.phys_device = pPhysicalDevices[i]; 11777f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 117789172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); 11779f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11780f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11781f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 11782f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11783b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 11784f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 11785f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 11786f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11787f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11788f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 11789f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 11790cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 11791cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 11792cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 11793cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 11794f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); 117951f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes auto physical_device_state = getPhysicalDeviceState(instance_data, physicalDevice); 117964b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state) { 117974b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 117984b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 11799cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11800cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11801cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 11802cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 118034b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (UNCALLED == physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 118041f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11805cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11806cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 11807cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 11808cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 11809cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11810cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 118114b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state->queueFamilyPropertiesCount != *pCount) { 11812cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11813cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 11814cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 118151f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11816cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11817cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 11818cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 118194b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes *pCount, physical_device_state->queueFamilyPropertiesCount); 11820cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 118214b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 11822cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11823cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 11824cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11825cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 118269172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, pQueueFamilyProperties); 118274b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 118284b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->queueFamilyPropertiesCount = *pCount; 11829cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11830cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 118317d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes if (physical_device_state->queue_family_properties.size() < *pCount) 118327d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties.resize(*pCount); 11833cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 118347d8b6ab1b68c397da50bad43deb1fba389ebace7Chris Forbes physical_device_state->queue_family_properties[i] = pQueueFamilyProperties[i]; 11835cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11836cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11837cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11838cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 118391f8e18308ae29b5220ce300f0d4dc964bc0941d6Chris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 11840cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 11841cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 11842cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 11843cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11844cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 11845cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11846747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbestemplate<typename TCreateInfo, typename FPtr> 11847747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic VkResult CreateSurface(VkInstance instance, TCreateInfo const *pCreateInfo, 11848747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes VkAllocationCallbacks const *pAllocator, VkSurfaceKHR *pSurface, 11849747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes FPtr fptr) 11850747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes{ 11851747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11852747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11853747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // Call down the call chain: 11854747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes VkResult result = (instance_data->dispatch_table.*fptr)(instance, pCreateInfo, pAllocator, pSurface); 11855747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11856747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (result == VK_SUCCESS) { 11857747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 11858747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surface_map[*pSurface] = SURFACE_STATE(*pSurface); 11859747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes lock.unlock(); 11860747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11861747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11862747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return result; 11863747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11864747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11865747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR void VKAPI_CALL DestroySurfaceKHR(VkInstance instance, VkSurfaceKHR surface, const VkAllocationCallbacks *pAllocator) { 11866747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool skip_call = false; 11867747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 11868747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 11869747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes auto surface_state = getSurfaceState(instance_data, surface); 11870747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11871747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (surface_state) { 11872747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // TODO: track swapchains created from this surface. 11873747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->surface_map.erase(surface); 11874747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11875747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes lock.unlock(); 11876747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11877747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!skip_call) { 11878747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes // Call down the call chain: 11879747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data->dispatch_table.DestroySurfaceKHR(instance, surface, pAllocator); 11880747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 11881747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11882747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11883747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 11884747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateAndroidSurfaceKHR(VkInstance instance, const VkAndroidSurfaceCreateInfoKHR *pCreateInfo, 11885747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11886747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateAndroidSurfaceKHR); 11887747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11888747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_ANDROID_KHR 11889747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11890747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 11891747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateMirSurfaceKHR(VkInstance instance, const VkMirSurfaceCreateInfoKHR *pCreateInfo, 11892747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11893747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateMirSurfaceKHR); 11894747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11895747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_MIR_KHR 11896747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11897747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 11898747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateWaylandSurfaceKHR(VkInstance instance, const VkWaylandSurfaceCreateInfoKHR *pCreateInfo, 11899747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11900a9c6cc532ce0ef61d48d1419a96aae51b0e4c64aTobin Ehlis return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWaylandSurfaceKHR); 11901747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11902747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WAYLAND_KHR 11903747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11904747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 11905747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateWin32SurfaceKHR(VkInstance instance, const VkWin32SurfaceCreateInfoKHR *pCreateInfo, 11906747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11907747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateWin32SurfaceKHR); 11908747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11909747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WIN32_KHR 11910747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11911747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 11912747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateXcbSurfaceKHR(VkInstance instance, const VkXcbSurfaceCreateInfoKHR *pCreateInfo, 11913747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11914747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXcbSurfaceKHR); 11915747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11916747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XCB_KHR 11917747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11918747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 11919747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL CreateXlibSurfaceKHR(VkInstance instance, const VkXlibSurfaceCreateInfoKHR *pCreateInfo, 11920747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const VkAllocationCallbacks *pAllocator, VkSurfaceKHR *pSurface) { 11921747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return CreateSurface(instance, pCreateInfo, pAllocator, pSurface, &VkLayerInstanceDispatchTable::CreateXlibSurfaceKHR); 11922747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 11923747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XLIB_KHR 11924747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 11925747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 1192689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1192789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1192889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 119298860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 119309172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes VkResult res = instance_data->dispatch_table.CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 119315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 11932b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 119338860b85a52096f9f9b28616bc37feed505497a54Chris Forbes res = layer_create_msg_callback(instance_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 119345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 119355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 119365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 119375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1193889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1193989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1194089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 119418860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 119429172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11943b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 119448860b85a52096f9f9b28616bc37feed505497a54Chris Forbes layer_destroy_msg_callback(instance_data->report_data, msgCallback, pAllocator); 119455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 119465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1194789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1194889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1194989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 119508860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 119519172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_data->dispatch_table.DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 119525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 119535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11954a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11955a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11956a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11957a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11958a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11959a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11960a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11961a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11962a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11963a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11964a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11965a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11966a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 11967a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 11968a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11969a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 11970a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11971a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1197289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1197389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1197489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 11975a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1197608939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 11977a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11978a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 11979a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 119809172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(physicalDevice), instance_layer_data_map); 119819172b640a0ae6a92f24ad0609d92b2c228cde89cChris Forbes return instance_data->dispatch_table.EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1198208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1198308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1198480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 119857ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 119867ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 119877ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1198880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1198980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1199009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1199109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1199209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11993747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic PFN_vkVoidFunction 11994747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesintercept_khr_surface_command(const char *name, VkInstance instance); 11995747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 1199689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1199780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1199880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1199980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1200080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1200180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 120025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1200309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1200409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1200509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1200609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 12007f0f7d8aa2286bd7516d9fb5c2e58890505e3e5d4Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 120085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 120094a0754042cf090e131e9e769d8a3633c228625beChris Forbes auto &table = dev_data->dispatch_table; 120104a0754042cf090e131e9e769d8a3633c228625beChris Forbes if (!table.GetDeviceProcAddr) 120114a0754042cf090e131e9e769d8a3633c228625beChris Forbes return nullptr; 120124a0754042cf090e131e9e769d8a3633c228625beChris Forbes return table.GetDeviceProcAddr(dev, funcName); 120135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 120145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1201589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 120167ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 120173f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 120183f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 120193f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 120203f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 12021747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!proc) 12022747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes proc = intercept_khr_surface_command(funcName, instance); 120237ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 120247ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 120255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 120267ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 120275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 120288860b85a52096f9f9b28616bc37feed505497a54Chris Forbes instance_layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 120298860b85a52096f9f9b28616bc37feed505497a54Chris Forbes proc = debug_report_get_instance_proc_addr(instance_data->report_data, funcName); 120307ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 120317ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 120325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 120334a0754042cf090e131e9e769d8a3633c228625beChris Forbes auto &table = instance_data->dispatch_table; 120344a0754042cf090e131e9e769d8a3633c228625beChris Forbes if (!table.GetInstanceProcAddr) 120354a0754042cf090e131e9e769d8a3633c228625beChris Forbes return nullptr; 120364a0754042cf090e131e9e769d8a3633c228625beChris Forbes return table.GetInstanceProcAddr(instance, funcName); 120375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1203808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1203980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 120407ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 120417ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 120427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 120437ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 120447ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 120457ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 120467ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 120477ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 120487ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 12049f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 12050cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 120517ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 12052a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 12053a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 12054a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 120557ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 120567ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 120577ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 120587ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 120597ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 120607ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 120617ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 120627ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 120637ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 120647ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 120657ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 120667ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1206780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1206880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1206980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1207080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1207180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 12072593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 12073593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 12074593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 12075593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 12076593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 12077593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 12078593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 12079593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 12080593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 12081593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 12082593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 12083593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 12084593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 12085593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 12086593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 12087593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 12088593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 12089593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 12090593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 12091593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 12092593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 12093593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 12094593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 12095593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 12096593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 12097593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 12098593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 12099593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 12100593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 12101593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 12102593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 12103593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 12104593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 12105593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 12106593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 12107593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 12108593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 12109593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 12110593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 12111593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 12112593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 12113593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 12114593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 12115593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 12116593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 12117593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 12118593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 12119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 12120593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 12121593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 12122593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 12123593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 12124593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 12125593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 12126593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 12127593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 12128593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 12129593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 12130593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 12131593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 12132593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 12133593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 12134593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 12135593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 12136593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 12137593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 12138593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 12139593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 12140593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 12141593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 12142593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 12143593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 12144593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 12145593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 12146593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 12147593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 12148593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 12149593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 12150593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 12151593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 12152593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 12153593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 12154593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 12155593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 12156593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 12157593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 12158593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 12159593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 12160593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 12161593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 12162593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 12163593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 12164593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 12165593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 12166593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 12167593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 12168593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 12169593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 12170593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 12171593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 12172593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 12173593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 12174593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 12175593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 12176593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 12177593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 12178593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 12179593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 12180593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 12181593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 12182593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 12183593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 12184593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 12185593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 12186593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 12187593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1218880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1218980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1219080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1219180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1219280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1219380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1219480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1219580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1219680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1219780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1219809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1219909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1220009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1220109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1220209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1220309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1220409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1220509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1220609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1220709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1220809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1220909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 12210c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = nullptr; 1221109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 122123f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 12213c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 122143f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 122153f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 122163f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1221709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1221809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1221909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1222009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1222109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1222209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 12223c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (dev_data) { 12224c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!dev_data->device_extensions.wsi_display_swapchain_enabled) 12225c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return nullptr; 12226c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young } 12227c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 12228c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!strcmp("vkCreateSharedSwapchainsKHR", name)) 12229c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); 12230c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1223109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 12232747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes} 12233747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12234747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesstatic PFN_vkVoidFunction 12235747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbesintercept_khr_surface_command(const char *name, VkInstance instance) { 12236747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes static const struct { 12237747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes const char *name; 12238747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes PFN_vkVoidFunction proc; 12239747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes bool instance_layer_data::*enable; 12240747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } khr_surface_commands[] = { 12241747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_ANDROID_KHR 12242747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateAndroidSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateAndroidSurfaceKHR), 12243747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::androidSurfaceExtensionEnabled}, 12244747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_ANDROID_KHR 12245747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_MIR_KHR 12246747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateMirSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateMirSurfaceKHR), 12247747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::mirSurfaceExtensionEnabled}, 12248747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_MIR_KHR 12249747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WAYLAND_KHR 12250747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateWaylandSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWaylandSurfaceKHR), 12251747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::waylandSurfaceExtensionEnabled}, 12252747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WAYLAND_KHR 12253747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_WIN32_KHR 12254747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateWin32SurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateWin32SurfaceKHR), 12255747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::win32SurfaceExtensionEnabled}, 12256747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_WIN32_KHR 12257747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XCB_KHR 12258747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateXcbSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXcbSurfaceKHR), 12259747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::xcbSurfaceExtensionEnabled}, 12260747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XCB_KHR 12261747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#ifdef VK_USE_PLATFORM_XLIB_KHR 12262747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkCreateXlibSurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateXlibSurfaceKHR), 12263747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::xlibSurfaceExtensionEnabled}, 12264747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes#endif // VK_USE_PLATFORM_XLIB_KHR 12265747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes {"vkDestroySurfaceKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySurfaceKHR), 12266747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes &instance_layer_data::surfaceExtensionEnabled}, 12267747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes }; 12268747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12269747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_layer_data *instance_data = nullptr; 12270747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (instance) { 12271747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes instance_data = get_my_data_ptr(get_dispatch_key(instance), instance_layer_data_map); 12272747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12273747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12274747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes for (size_t i = 0; i < ARRAY_SIZE(khr_surface_commands); i++) { 12275747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (!strcmp(khr_surface_commands[i].name, name)) { 12276747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes if (instance_data && !(instance_data->*(khr_surface_commands[i].enable))) 12277747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 12278747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return khr_surface_commands[i].proc; 12279747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12280747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes } 12281747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes 12282747ce6dd32eafd93da3dc12a6ffd670e746ae453Chris Forbes return nullptr; 1228309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1228409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 12285d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 12286d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12287d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 12288d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12289d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 12290d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 12291d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1229289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 12293d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12294d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12295d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 12296d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 12297d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 12298d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1229989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 12300d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12301d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12302d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 12303d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 12304d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1230589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 12306d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12307d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12308a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 12309d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1231008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1231108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 12312a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1231308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1231408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1231508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1231608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 12317a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1231808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1231908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1232008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1232108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 12322a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 12323a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 12324a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 12325d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12326d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12327d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 12328d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 12329d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 12330a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 12331a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 12332a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 12333d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12334d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12335d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1233689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 12337d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 12338d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 12339d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1234089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1234108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 12342