core_validation.cpp revision 39267c0c27b8f032f05a6747eb02d4508247fdc1
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 41825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 46dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 63b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 73c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 78d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 79d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 86b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 88e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 89c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young bool wsi_display_swapchain_enabled; 903f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 9956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 100b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski unique_ptr<INSTANCE_STATE> instance_state; 101b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski 10256a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 109cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 110cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Vector indices correspond to queueFamilyIndex 111cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski vector<unique_ptr<VkQueueFamilyProperties>> queue_family_properties; 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 115cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 11679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; 1176d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 11839267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; 1198718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1218d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 123397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 124cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 13404861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_NODE>> frameBufferMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 138918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1396c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 142b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 143b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 144f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDeviceFeatures physical_device_features; 145cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unique_ptr<PHYSICAL_DEVICE_STATE> physical_device_state; 146b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 148b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski : instance_state(nullptr), report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), 149825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski device_extensions(), device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{}, physical_device_features{}, 150cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski physical_device_state(nullptr){}; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 156e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 157f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 158e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 163e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 169e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 183b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 184b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 185b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 186b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 187b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 188b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 190b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 254b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 255593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 25679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis// Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL 25779fde938178535f598e030a0e9d19a0cb61b72e0Tobin EhlisIMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { 2582c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2592c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2602c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2622c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2632c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2649a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 265a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2662c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2672c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2689a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2699a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2709a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2719a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 273a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2786d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2796d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2808718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 281a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2848718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2868718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2878718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 288b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 289a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 290b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 291b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 292b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 293b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 2943f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 295b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 296170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 297a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 298170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 299170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 300170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 301170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 302170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 303170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3042f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 30539267c0c27b8f032f05a6747eb02d4508247fdc1Tobin EhlisBUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { 3062f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3072f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3082f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3092f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3102f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3112f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3128718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 31366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 31466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 31566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 31666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 31766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 31866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 31966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3219556936067fd0c4eb74c4a13631bc163b154faedTobin EhlisEVENT_NODE *getEventNode(layer_data *dev_data, VkEvent event) { 3229556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3239556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3249556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3259556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3269556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3279556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3289556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 329ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 330ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 331ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 332ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 333ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 334ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 335ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 336ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 33766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 33866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 33966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 34066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 34166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 34266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 34366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 34466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3455e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3465e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3475e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3485e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3495e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3505e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3515e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3525e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3538d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3548d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3558d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3568d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3578d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3588d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3598d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3608d6a38de0389036581ada119e548180c614fe0efChris Forbes 36194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 3656d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3666d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3708718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 3718718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3728718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3825121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 38372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3880a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 39283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 39883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 39983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 40083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 40183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 407249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 408249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 40959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_NODE const *image_node, VkFlags desired, VkBool32 strict, 410249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 411249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, 412249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 413249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 414249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 415249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 416249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 417ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 418ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 41959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 420ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 421ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 422ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 423ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 424ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 425ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 42857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 42957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 43057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 442dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 443dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// Helper function to print lowercase string of object type 444dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// TODO: Unify string helper functions, this should really come out of a string helper if not there already 445dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 446dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis switch (type) { 447dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 448dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "image"; 449dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 450dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "buffer"; 451dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 452dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "swapchain"; 453dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 454dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "descriptor set"; 455dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 4566f62283faa835f7fd302771a3a693d1aafff4652Tobin Ehlis return "framebuffer"; 457dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 458dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "event"; 459dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 460dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "query pool"; 461dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 462dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "pipeline"; 463dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: 464dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "sampler"; 465eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: 466eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return "semaphore"; 467dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis default: 468dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "unknown"; 469dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis } 470dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis} 471dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 472cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid 473f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, 474dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *functionName) { 475f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 476f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 477f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!mem_info->bound_ranges[bound_object_handle].valid) { 478f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 479ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 480dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 481dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis ", please fill the memory before using.", 482dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); 483f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 484f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 485f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return false; 486f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 487f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image_node 488f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then verify that image_node valid member is true 489f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else verify that the image's bound memory range is valid 490f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_NODE *image_node, const char *functionName) { 491f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 492f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!image_node->valid) { 49358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 494ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(image_node->mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 495414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 496f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis functionName, reinterpret_cast<uint64_t &>(image_node->image)); 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 499dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return ValidateMemoryIsValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), 500dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 504f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer_node, verify that the range it's bound to is valid 505f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *functionName) { 506dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return ValidateMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), 507dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); 508f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 509f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For the given memory allocation, set the range bound by the given handle object to the valid param value 510f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { 511f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 512f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 513f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis mem_info->bound_ranges[handle].valid = valid; 514f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 515f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 516f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image node 517f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then set entire image_node to valid param value 518f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else set the image's bound memory range to valid param value 519f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetImageMemoryValid(layer_data *dev_data, IMAGE_NODE *image_node, bool valid) { 520f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 521f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis image_node->valid = valid; 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 523f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), valid); 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 526f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer node set the buffer's bound memory range to valid param value 527f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetBufferMemoryValid(layer_data *dev_data, BUFFER_NODE *buffer_node, bool valid) { 528f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), valid); 529f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 532e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 533e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 53483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 54057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 5415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 542de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb); 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 54472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 54672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 547c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 553ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 55456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given sampler and command buffer node 55556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlisvoid AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_NODE *sampler_node) { 55656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.insert(cb_node); 55756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(sampler_node->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 55856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis} 55956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis 56056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given image node and command buffer node 561c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_NODE *img_node) { 562ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 563ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (img_node->mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 564ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 565ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, img_node->mem); 566ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 567de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 568ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 569ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(img_node->mem); 570ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 571bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 572ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 573ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for image 574ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis img_node->cb_bindings.insert(cb_node); 575ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 576ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 577ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 578c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node) { 579ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 580ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->mem); 581ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 582de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 583ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 584ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(buff_node->mem); 585bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 586ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 587ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 588ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 589ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 590ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 591400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 592400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 59372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 594c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 595c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 59657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 598de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->command_buffer_bindings.erase(pCBNode->commandBuffer); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 601c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 606400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 607400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 608400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 61383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 614de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t cmdBufRefCount = pMemObjInfo->command_buffer_bindings.size(); 615de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t objRefCount = pMemObjInfo->obj_bindings.size(); 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 617de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((pMemObjInfo->command_buffer_bindings.size()) != 0) { 61883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 61983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 62083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 62183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " references", 62283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 6235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 625de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (cmdBufRefCount > 0 && pMemObjInfo->command_buffer_bindings.size() > 0) { 626de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : pMemObjInfo->command_buffer_bindings) { 62758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 628de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 629414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 6305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 632de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->command_buffer_bindings.clear(); 6335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 635de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (objRefCount > 0 && pMemObjInfo->obj_bindings.size() > 0) { 636de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : pMemObjInfo->obj_bindings) { 637896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 638414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 639896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 642de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->obj_bindings.clear(); 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 647e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 64883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 65057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 652ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO: Verify against Valid Use section 653ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Clear any CB bindings for completed CBs 654ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO : Is there a better place to do this? 655ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 656ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller assert(pInfo->object != VK_NULL_HANDLE); 657ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // clear_cmd_buf_and_mem_references removes elements from 658de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis // pInfo->command_buffer_bindings -- this copy not needed in c++14, 659ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // and probably not needed in practice in c++11 660de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis auto bindings = pInfo->command_buffer_bindings; 661ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (auto cb : bindings) { 662ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 663ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller clear_cmd_buf_and_mem_references(dev_data, cb); 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 665ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 667ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Now verify that no references to this mem obj remain and remove bindings 668de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->command_buffer_bindings.size() || pInfo->obj_bindings.size()) { 669ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= reportMemReferencesAndCleanUp(dev_data, pInfo); 6705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 671ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Delete mem obj info 672ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->memObjMap.erase(dev_data->memObjMap.find(mem)); 673ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } else if (VK_NULL_HANDLE != mem) { 674ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // The request is to free an invalid, non-zero handle 675ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 676ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 677ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem), __LINE__, 678ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller MEMTRACK_INVALID_MEM_OBJ, 679ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "MEM", "Request to delete memory object 0x%" 680ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller PRIxLEAST64 " not present in memory Object Map", 681ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem)); 6825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 688c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 69283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 69494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 69557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 69794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 699c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 701de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!pMemObjInfo->obj_bindings.erase({handle, type})) { 70283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 70358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 704414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 705414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 713b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 714694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_NODE *image_node, const char *api_name) { 715b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 716b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == (static_cast<uint32_t>(image_node->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 717b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == image_node->mem) { 718b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 719694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 720694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis "%s: VkImage object 0x%" PRIxLEAST64 " used without first calling vkBindImageMemory.", api_name, 721694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image)); 722b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 723b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 724b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 725b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 726b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 727b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 728694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_NODE *buffer_node, const char *api_name) { 729b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 73012e3a5f6e672b103f705424595ffe3c4687492ceTobin Ehlis if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { 731b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == buffer_node->mem) { 732b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 733694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 734694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis "%s: VkBuffer object 0x%" PRIxLEAST64 " used without first calling vkBindBufferMemory.", api_name, 735694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer)); 736b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 737b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 738b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 739b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 740b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 7455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 74694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 74794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 74883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 75283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 75383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 7562e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 75757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 7582e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 75957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = getMemObjInfo(dev_data, *pMemBinding); 7602e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 76183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 76283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 76383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 76483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 76583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 7662e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 767de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->obj_bindings.insert({handle, type}); 7682e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 7692e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 7702e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 7716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 7726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 7736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 7742e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 7752e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7792e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 7910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 7920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 7930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 79483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 79783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = clear_object_binding(dev_data, handle, type); 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 8002e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 80157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 8022e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 803de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->obj_bindings.insert({handle, type}); 8042e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 8052e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 811caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 812caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 813caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 815caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 816caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 817caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getImageNode(dev_data, VkImage(handle))->mem; 818caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 819caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 820caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->mem; 821caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 822caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 823caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 825caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 826caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 827caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 828caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 829caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 830caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 831caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 832caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 833caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 8350a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 83758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 84258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 84458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 84558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 85257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 85557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 85658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 85757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 85858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 859c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 860de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size() + mem_info->obj_bindings.size()); 861de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (0 != mem_info->alloc_info.allocationSize) { 862de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->alloc_info, "MEM(INFO): "); 86358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 872de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->obj_bindings.size()); 873de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->obj_bindings.size() > 0) { 874de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : mem_info->obj_bindings) { 87558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 876414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 883de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size()); 884de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->command_buffer_bindings.size() > 0) { 885de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : mem_info->command_buffer_bindings) { 88658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 887414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 89472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 90272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 90372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 91172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 914414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 916c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 918c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 920414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 11569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 11599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11619ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 11629ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 11659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 11699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11709ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 11739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 11779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 11789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 11809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 11829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 11839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11979ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 12009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 12039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 12099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 12109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 12119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 12129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 12139ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 121537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 121637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 121737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 121837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 121937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 122037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 122137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 122237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 122337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12307c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 123137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 12327c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12337c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 123637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 123737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 123837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 123937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 124037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12477c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 12487c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 124937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 12507c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12517c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12527c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 12537c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 12547c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 12557c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 12567c755c8aca6857046df9516d8336416165969cb9Chris Forbes 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12597c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 12627c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 12657c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 126737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 126837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 126937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 127037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 127137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 127237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 127337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 127437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 127537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 127737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 127837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 128337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 129337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1334cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1335cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1336cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1337cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1338cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1339cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1340cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1341cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1342cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1352c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1353c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1354c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1355c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1356c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1357c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1358c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1359c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1360c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1361c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1362c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1363c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1364c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1365c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1373b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1374fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1378031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1379031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1380031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1381031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1382031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1383031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1384031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1385031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1386031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1387031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1388031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1389031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1390031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1391031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1408edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 14093a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> *out, 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1411b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1413031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1451b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1452fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 14533a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes (*out)[std::make_pair(location + offset, component)] = v; 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14603a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::map<location_t, interface_var> collect_interface_by_location( 14613a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes shader_module const *src, spirv_inst_iter entrypoint, 14623a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes spv::StorageClass sinterface, bool is_array_of_verts) { 14633a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1468b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1491b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1492b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1493b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1494b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 150081264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1505c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15113a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> out; 15123a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15181d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1525b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 15387c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1544b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1545fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 15503a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15543a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15553a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15583a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( 15593a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 15603a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 15613a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15623a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<uint32_t, interface_var>> out; 1563745d49409296f060402b57950384caadb636a2b2Chris Forbes 1564745d49409296f060402b57950384caadb636a2b2Chris Forbes for (auto insn : *src) { 1565745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.opcode() == spv::OpDecorate) { 1566745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.word(2) == spv::DecorationInputAttachmentIndex) { 1567745d49409296f060402b57950384caadb636a2b2Chris Forbes auto attachment_index = insn.word(3); 1568745d49409296f060402b57950384caadb636a2b2Chris Forbes auto id = insn.word(1); 1569745d49409296f060402b57950384caadb636a2b2Chris Forbes 1570745d49409296f060402b57950384caadb636a2b2Chris Forbes if (accessible_ids.count(id)) { 1571745d49409296f060402b57950384caadb636a2b2Chris Forbes auto def = src->get_def(id); 1572745d49409296f060402b57950384caadb636a2b2Chris Forbes assert(def != src->end()); 1573745d49409296f060402b57950384caadb636a2b2Chris Forbes 1574745d49409296f060402b57950384caadb636a2b2Chris Forbes if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { 1575e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); 1576e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes for (unsigned int offset = 0; offset < num_locations; offset++) { 1577e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes interface_var v; 1578e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.id = id; 1579e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.type_id = def.word(1); 1580e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.offset = offset; 1581e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_patch = false; 1582e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_block_member = false; 1583e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes out.emplace_back(attachment_index + offset, v); 1584e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes } 1585745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1586745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1587745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1588745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1589745d49409296f060402b57950384caadb636a2b2Chris Forbes } 15903a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15913a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 1592745d49409296f060402b57950384caadb636a2b2Chris Forbes} 1593745d49409296f060402b57950384caadb636a2b2Chris Forbes 15943a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( 15953a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 15963a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16163a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> out; 16173a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1630b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1631b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1632fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1633cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16363a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1640edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1641031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1643031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16463a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); 16473a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1660edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1661080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1662031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1663031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1668edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1670031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1671031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1676fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1677fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1678fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1679fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 16800f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1681fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1682fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 168337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1684edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 16869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 16879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 16889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1693edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16940f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1695f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 16960f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 16970f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 16980f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 16990f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 17000f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17010f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 173331c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 173431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 173531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 173631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1739f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 175531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 175631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 175731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 175831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1761f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 1789f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes case spv::OpTypeImage: 1790f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes return get_fundamental_type(src, insn.word(2)); 1791f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1802edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1813edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1826edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18303a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1835c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1836c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1837c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1838c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1839c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1840c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 18451730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 18531730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1854080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18581730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1861edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1873edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 18769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 18779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 18831730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1891edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 18928da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 18938da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 1894025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 18958da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 18968da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 1897d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 1898d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 1899d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 1900d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 1901d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 1902025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1903025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1904025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19093a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1911025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1912025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1914025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1915025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1916025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1917025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1918025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1920025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1921edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1923025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1926025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1927025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1928edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1929025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1932025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1934025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1935025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1939edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1941025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1942025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1943025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1949025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1950025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 19663a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { 19673a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> ids; 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 197881264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 19925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 20325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 2058c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2064c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20733a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 20743a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return ids; 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2077edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2078416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2098416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2103edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2104080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2117edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2118080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2132edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2133416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2140416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2141416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2148fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2149fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 21504a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 215337083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2155416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 215637083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2158416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2170e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2173e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2175e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2179e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2180e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 21813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 21823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 21833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2184414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2186e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 219016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2191ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2192ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2193ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2195ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 219816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 219916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 220016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 220116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 220216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 220316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 220416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 220516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 220604861caca7eb93a5241b164e8480bb93c826902cTobin Ehlisstatic FRAMEBUFFER_NODE *getFramebuffer(const layer_data *my_data, VkFramebuffer framebuffer) { 2207f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2208f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2209f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2210f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 221104861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2212f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2213f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2214e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 221511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 221611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 221711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 221811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 221911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 222011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 222111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 22224a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 22234a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 22244a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 22254a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 22264a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 22274a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 22284a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 22294a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2235e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2238e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2242e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 22439c4006684a13db43f0dbc8d0015a9ef34872ca09Chris Forbes bool result = false; 2244ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2245ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2246ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 22473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 22493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 225045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 225145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 22523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 22543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 22563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 22583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 225945824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 226045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 22613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 22633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 226445824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 226545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 22663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 22683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 22703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 22723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 22743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 22753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 22773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 22835ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2290e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2291e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2292e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2293e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2294e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2295e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2296e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2297e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2298e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 230006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 230106e963555b0df747c98c43816c16647349d21001Mark Young return true; 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 230306e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 230406e963555b0df747c98c43816c16647349d21001Mark Young return true; 23055ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 23065ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23075ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 23085ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23095ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 23105ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 23185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2320a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 23218da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2322a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 23238da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 23245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2325c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2341c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2349c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2355fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2356fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2357fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2358fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2359fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2360c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2361fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2362fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2363fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2364fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2365fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 23665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 23685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2373c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 23745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 23815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2383397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2384397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2385397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 238669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 238769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2388416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 23899b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2390c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 239169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 239269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 239369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 23945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 23955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2397416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2398397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 23995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2402edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 24045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 24085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 24095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2410edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 24115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 24125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 24135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 24145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 24155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 24165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 24175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 24195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2427edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 24281b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 24295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24311b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 24321b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 24337b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 24347b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 24355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 24367b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 24377b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 24387b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 24397b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24407b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 24417b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 24427b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 24435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 24465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 24475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 24485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 24495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 24505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 24515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 24525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 24535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 24545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 24555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 24605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 246467d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 246567d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 246835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 246935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 247035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 247135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 247235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 247335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 247435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 247535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 247635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 247735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 24785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 24795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 24815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 24825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 24835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 24845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 24855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 24865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 24875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 24885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 24905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 24915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 24925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 24935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 24945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 24955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 24965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 249867d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 249967d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 25015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 25025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 25065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 25075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 25095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 25105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25134110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2514a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 25154110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2516080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2517a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2518a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2519a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2520a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2521a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2522a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2523a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2524a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2525a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2526a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 252769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 252869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2530a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2531a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2532a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2533a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2534a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2535a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2536a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2537a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2538a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2539a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2540a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2541a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2542a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2543a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2544a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2545a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2546a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2547a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 25484110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2549a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2550a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2551a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 25524110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2553a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2554a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2555a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 25564110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2557a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2558a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2559a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 25604110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2561a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2562a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2563a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2564a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 25654110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2566a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2567a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2568a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2569a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 25704110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2571a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2572a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2573a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 25744110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2575a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2576a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2577a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 25784110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2579a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2580a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2581a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2582a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 25834110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2584a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2585a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2586a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2587a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 25884110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2589a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2590a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2591a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2592a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 25934110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2594a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2595a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2596a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2597a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 25984110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2599a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2600a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2601a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 26024110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2603a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2604a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2605a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 26064110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2607a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2608a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2609a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 26104110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2611a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2612a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2613a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 26144110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2615a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2616a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2617a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 26184110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2619a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2620a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2621a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 26224110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2623a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2624a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2625a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 26264110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2627a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2628a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2629a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 26304110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2631a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2632a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2633a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2634a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 26354110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2636a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2637a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2638a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 26394110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2640a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2641a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2642a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2643a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 26444110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2645a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2646a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2647a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2648a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 26494110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2650a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2651a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2652a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 26534110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2654a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2655a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2656a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2657e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2658a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2659a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2660a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2661a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2662a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2663a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2664a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2665a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2666b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2667b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbesstatic uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { 26682aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto type = module->get_def(type_id); 26692aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 26702aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes while (true) { 26712aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (type.opcode()) { 26722aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeArray: 26732aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeSampledImage: 26742aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(2)); 26752aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 26762aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypePointer: 26772aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(3)); 26782aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 26792aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeImage: { 26802aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto dim = type.word(3); 26812aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto arrayed = type.word(5); 26822aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto msaa = type.word(6); 26832aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 26842aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (dim) { 26852aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim1D: 2686488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; 26872aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim2D: 26882aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | 2689488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); 26902aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim3D: 26912aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return DESCRIPTOR_REQ_VIEW_TYPE_3D; 26922aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::DimCube: 2693488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; 269428db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes case spv::DimSubpassData: 269528db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; 269628db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes default: // buffer, etc. 26972aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 26982aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 26992aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27002aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: 27012aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 27022aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27032aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 2704b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes} 2705b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2706b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2707ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2708ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2709ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2710ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2711ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 271269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2713ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2714ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2715e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 271669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 271769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 271878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 271978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 272078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 272178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2722557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2723080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 272478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 272578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 27260cfa9c3a1747749777581684536218f83c3977a9Chris Forbes return false; // no point continuing beyond here, any analysis is just going to be garbage. 272778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 272878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 272978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 273078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2731557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 273278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 273378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 27343a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto accessible_ids = mark_accessible_ids(module, entrypoint); 273578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 273678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 27373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); 273878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 27392e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2740ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 27410cfa9c3a1747749777581684536218f83c3977a9Chris Forbes pass &= validate_specialization_offsets(report_data, pStage); 2742416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 274378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 274478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 274578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 274678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 2747b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; 2748b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); 274978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2750fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2751c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 275278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 275378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 275478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2755557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2756080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 275778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 275878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 276078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 276178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2762557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 276378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 276478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 276578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 276678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2767fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 276878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 277078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2771edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2772fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2773557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2774fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2775fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2776fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2777fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 277878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2779e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 278078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2782557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2783fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 278478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 278578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2786fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 278878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 278978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 279078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 279178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2792c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes /* validate use of input attachments against subpass structure */ 2793c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { 27943a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); 2795c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2796c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto rpci = pipeline->render_pass_ci.ptr(); 2797c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto subpass = pipeline->graphicsPipelineCI.subpass; 2798c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2799c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes for (auto use : input_attachment_uses) { 2800c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; 2801c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? 2802c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; 2803c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2804c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (index == VK_ATTACHMENT_UNUSED) { 2805c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2806c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", 2807c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes "Shader consumes input attachment index %d but not provided in subpass", 2808c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes use.first)) { 2809c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes pass = false; 2810c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2811c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2812eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes else if (get_format_type(rpci->pAttachments[index].format) != 2813eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes get_fundamental_type(module, use.second.type_id)) { 2814eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2815eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", 2816eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes "Subpass input attachment %u format of %s does not match type used in shader `%s`", 2817eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes use.first, string_VkFormat(rpci->pAttachments[index].format), 2818eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes describe_type(module, use.second.type_id).c_str())) { 2819eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes pass = false; 2820eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2821eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2822c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2823c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2824c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 282578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 282678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 282778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 282878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2829a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2830a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2831e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 283269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 283369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 28346660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 28355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 28375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 28395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 28405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 28415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 28425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2843e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 28445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 28466660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 284778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2848e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 284969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 285069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 28515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2853d5365427feb4a6c16371ecb651afa37b89dabd96Chris Forbes // if the shader stages are no good individually, cross-stage validation is pointless. 2854b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes if (!pass) 2855b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes return false; 2856b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes 28575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 28585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2860e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 28615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2864e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 28655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 28685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 28695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 28715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 28725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 28735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 28765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 28775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2878e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2879031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2880031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 28815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 28835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28868da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 2887e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 28888da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 28895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2894e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 289569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 28966660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 289703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 289803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 289903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 290003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2901e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 290269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 290303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2905a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2906104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2907104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2910104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 29137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 29147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 29157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 29167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 29177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 29187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2919e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 29207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 29211abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 29221abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis &activeSetBindingsPairs, 29231abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const char *function) { 2924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2925a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2926dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2927cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2928dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2929397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2930cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2931397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2932cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2933cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2934e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski "DS 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", 2935e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); 2936cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2937dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 29385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2942eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2943ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2944ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2945ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2946eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2947eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2948eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2949eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2950eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2951b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbesstatic void list_bits(std::ostream& s, uint32_t bits) { 2952b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes for (int i = 0; i < 32 && bits; i++) { 2953b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits & (1 << i)) { 2954b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << i; 2955b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes bits &= ~(1 << i); 2956b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits) { 2957b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << ","; 2958b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2959b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2960b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 2961b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes} 2962b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 2963eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 296429d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 296529d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 296629d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 296729d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2968eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 296929d196e071b2dc1db47702085469396f2b956820Chris Forbes 297029d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 297129d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 297229d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 2973312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; 2974312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || 2975312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { 2976312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis skip_call |= log_msg( 2977312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 2978312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 2979312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " 2980312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " 2981312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", 29825c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)state.pipeline_node->pipeline, vertex_binding, i, vertex_binding); 298329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 298429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 298529d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 298629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 298729d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 29885c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29895c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 29905c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 29915c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline_node->pipeline); 299229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 299329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 299429d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 299529d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 299629d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 299729d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 299829d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 299929d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 300029d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 3001b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 300229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 3003b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; 3004b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; 3005b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingViewportMask) { 3006b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3007b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic viewport(s) "; 3008b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingViewportMask); 3009b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetViewport()."; 3010b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3011b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3012b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 301329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 301429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3015b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 301629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 3017b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; 3018b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; 3019b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingScissorMask) { 3020b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3021b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic scissor(s) "; 3022b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingScissorMask); 3023b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetScissor()."; 3024b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3025b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3026b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 302729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 302829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 302929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 303029d196e071b2dc1db47702085469396f2b956820Chris Forbes 303129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 303229d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 303329d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 303429d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 303529d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 303629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 303729d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 303829d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 303929d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 304029d196e071b2dc1db47702085469396f2b956820Chris Forbes 304129d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 304229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 304329d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 304429d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3045eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3046ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 3047eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 3048414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 3049eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 3050eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 3051ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 305229d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3053eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 305476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 30550a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 305629d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 305776957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 305876957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 305976957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 306029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 30610a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 306276957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 306376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 306476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 306576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 306629d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3067eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 30680dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 306929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3070eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3071ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 3072414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 3073414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 3074ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 3075ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 3076eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 307729d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 307829d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 307929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 308029d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 308129d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 3082eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3083eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3084528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 3085528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 3086528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 3087a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 3088a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->pCreateInfo, pPipeline->render_pass_ci.ptr(), 3089528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 3090528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 3091528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 3092528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3093528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3094528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 3095528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 3096528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 3097528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 3098528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 3099528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 310029d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 310129d196e071b2dc1db47702085469396f2b956820Chris Forbes 3102eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 3103eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3104eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 3106aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlisstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexedDraw, 3107e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski const VkPipelineBindPoint bindPoint, const char *function) { 3108e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3109aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis auto const &state = cb_node->lastBound[bindPoint]; 31105c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipe = state.pipeline_node; 311122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 311222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 311322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 311422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 311522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 311622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 311722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 311822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 311922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 31203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 31217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3122aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result = validate_draw_state_flags(my_data, cb_node, pPipe, indexedDraw); 31237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 31245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 312569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 312622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 312769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 3128169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 312922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 31301abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 31311abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis activeSetBindingsPairs; 3132dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 313322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 313422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 313522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 313622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 313722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 3138414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 313922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 314069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 314169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 314269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 314371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 314422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 314522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 314622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 3147414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 3148414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 314969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 315069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 315122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 315222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 315371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 3154aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Gather active bindings 3155aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis std::unordered_set<uint32_t> bindings; 3156aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : setBindingPair.second) { 3157aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis bindings.insert(binding.first); 3158aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis } 3159aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Bind this set and its active descriptor resources to the command buffer 3160aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis pSet->BindCommandBuffer(cb_node, bindings); 316122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 3162aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, &state.dynamicOffsets[setIndex])); 316322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 316422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 3165397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 3166aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : bindings) { 3167aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 316822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 316922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3170397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3171414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 317222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3173397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3174fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 317822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 317922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 3180aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, cb_node, activeSetBindingsPairs, function); 318122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3182eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3183eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 318429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3185aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validatePipelineDrawtimeState(my_data, state, cb_node, pPipe); 3186eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3190a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3191a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3192a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3193a27508babf63d50aea75883a3702979193c23683Mark Young 3194a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3195a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 3196a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3197a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3198a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3199a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3200a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3201a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3202a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3203a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3204a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3205a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3206a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3207a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3208a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3209a27508babf63d50aea75883a3702979193c23683Mark Young } 3210a27508babf63d50aea75883a3702979193c23683Mark Young } 3211a27508babf63d50aea75883a3702979193c23683Mark Young 3212a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3213a27508babf63d50aea75883a3702979193c23683Mark Young} 3214a27508babf63d50aea75883a3702979193c23683Mark Young 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 3216e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 3217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 321883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 322983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 323083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 323183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 323483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 324683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 324783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 324883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 32495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3253b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 32543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 325526c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3256c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 325706811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 325806811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 325906811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 326006811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 326106811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 326283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 326383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 326483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 326583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 326606811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3267c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3271b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 327383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 328183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3288a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 329116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 329216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 329316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 329483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 329583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 329683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 329783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3300e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 330169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 330283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 330452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 330552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 330652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 330752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 330883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 330983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 331083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 331183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 331252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 331352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 331452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 331783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 332483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 332583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 332683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 333383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 333483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 333583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3340ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3341ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 334283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 334383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 334483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 334583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3347ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3348ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 335083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 335183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 335283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 335383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 335483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3356ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 335783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 335883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 335983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 336083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 336183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3362ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3363ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 336483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 336583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 336683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 336783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 336883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 336983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3372a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3373a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3374a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 337583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 337683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3377a27508babf63d50aea75883a3702979193c23683Mark Young } 3378a27508babf63d50aea75883a3702979193c23683Mark Young } 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 338345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 338583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 338683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 338783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 338883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 339183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 339283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 339383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 339483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 339583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3398e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 340383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 340483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 340583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 340683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 340783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 340883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 340983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 341583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 341683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 341783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 341883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 341983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 342083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34245dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes 34255dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // If rasterization is not disabled, and subpass uses a depth/stencil 34265dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // attachment, pDepthStencilState must be a pointer to a valid structure 34275dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes auto subpass_desc = renderPass ? &renderPass->pCreateInfo->pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; 34285dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (subpass_desc && subpass_desc->pDepthStencilAttachment && 34295dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 34305dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { 34315dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 34325dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 34335dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "Invalid Pipeline CreateInfo State: " 34345dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " 34355dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "depth/stencil attachment"); 34365dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 34375dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 343983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 34405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3446ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3447ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3455e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3456bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3457bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3460bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3468e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 34855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3491fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3493fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3496fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3499fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3502fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 350583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 35061d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3513e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 351683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 351783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 351883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 351983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 352183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3522fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 352383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3524fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3525fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3526fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3527fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 353083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 35334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 35344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 35354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 35424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 35454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 35494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 35514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 35544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 35554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 35614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 35624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 35654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 35664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 35684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 35694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 35714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 35754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 35844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 35854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 35864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 35874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 35884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 36004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 36014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 36024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 36034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 36044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 36065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 36074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36246d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 36256d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 36306d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 365708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 366008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 366108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 366208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 366308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 366708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 366908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 367008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 36767068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 36777068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 36787068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 367908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 368308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 368408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 368508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 368608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 368708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 368808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 369108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 369208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 369408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 369508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 369608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 369708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 370008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 370208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 370679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 370779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 370879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImage &image = view_state->create_info.image; 370979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 3716915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // TODO: If ImageView was created with depth or stencil, transition both layouts as 3717915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // the aspectMask is ignored and both are used. Verify that the extra implicit layout 3718915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // is OK for descriptor set layout validation 3719038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 372079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { 3721038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); 3722038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 3723038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3732e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3734e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3739414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3745414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3751f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3752e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 37539dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 37549dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 37559dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 37569dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3763c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3764cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 37659dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3767f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 3775de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3776de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3777de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3778de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3779de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3780de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3781de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3782de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3783de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3785de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 37895121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 37905121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 37915121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 379272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 379372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3794414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37975121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3802400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3817e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3821d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3822d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3860a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 386183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3862a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3863a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3864a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 387983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 390383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 390783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 39177651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 392483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 39257651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 392683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 393383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39359822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 39369822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add object_binding to cmd buffer 39379822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis// Add cb_binding to object 39389822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 39399822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_bindings->insert(cb_node); 39409822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis cb_node->object_bindings.insert(obj); 39419822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis} 3942bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 3943bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 3944bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis switch (object->type) { 3945bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 394664d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto img_node = getImageNode(dev_data, reinterpret_cast<const VkImage &>(object->handle)); 3947bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (img_node) 3948bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis img_node->cb_bindings.erase(cb_node); 3949bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3950bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3951bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 395264d375f52e2011964e196710ca78b0d4d68b20d0Dustin Graves auto buf_node = getBufferNode(dev_data, reinterpret_cast<const VkBuffer &>(object->handle)); 3953bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis if (buf_node) 3954bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis buf_node->cb_bindings.erase(cb_node); 3955bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 3956bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 39579822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 3958e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto evt_node = getEventNode(dev_data, reinterpret_cast<const VkEvent &>(object->handle)); 39599822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis if (evt_node) 39609822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis evt_node->cb_bindings.erase(cb_node); 39619822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 39629822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 3963ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 3964e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto qp_node = getQueryPoolNode(dev_data, reinterpret_cast<const VkQueryPool &>(object->handle)); 3965ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) 3966ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis qp_node->cb_bindings.erase(cb_node); 3967ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 3968ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 3969a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 3970e9941022f1933b7300a4a7f52187dba446aca7a9Mark Lobodzinski auto pipe_node = getPipeline(dev_data, reinterpret_cast<const VkPipeline &>(object->handle)); 3971a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) 3972a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis pipe_node->cb_bindings.erase(cb_node); 3973a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 3974a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 3975a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 3976a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis auto set_node = getSetNode(dev_data, reinterpret_cast<const VkDescriptorSet &>(object->handle)); 3977a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis if (set_node) 3978a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis set_node->RemoveBoundCommandBuffer(cb_node); 3979a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 3980a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 398156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 398256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, reinterpret_cast<const VkSampler &>(object->handle)); 398356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) 398456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.erase(cb_node); 398556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 398656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 3987bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 3988bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis assert(0); // unhandled object type 3989bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 3990bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3993400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3994400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3996b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 4007b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask = 0; 4008b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask = 0; 400993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 401072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 401172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 401272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 401393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 4015ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 4018e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 4021c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4026abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4032bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4033bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4034bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4035bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 40377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 40387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4039400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4040b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 4041d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 404293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 4043bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 4044bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 4045bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 4046bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4047a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis pCB->object_bindings.clear(); 404893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 404993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 4050d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 4051d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) 4052b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis fb_node->cb_bindings.erase(pCB); 405393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 405493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 40557003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4062ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4063ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 40641afd60fa23eaee2000e232efd5d05a64224a91dcTony Barbour pCB->status |= CBSTATUS_ALL; 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4070ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4071ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 40793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4103e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 410483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 41075c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 411183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 411283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 411383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 411483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 411583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 411883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 4125414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4130414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4137e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 413883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 414083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 414283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 414383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4148e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4149e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 4153414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 4154ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4161e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4162e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4173b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4174d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4175b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 417989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 418089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4196b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 419756a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 4198b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4199b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4201b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4202b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4203b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 4204b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4205825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 4206b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski instance_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE()); 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 421389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4222b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4235373469f006399d6b5204ee05db3b56beb168b36fMark Youngstatic void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 42405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 4241c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = false; 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 4246c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) 4247c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = true; 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4251838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 4252838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskibool ValidateRequestedQueueFamilyProperties(layer_data *dev_data, const VkDeviceCreateInfo *create_info) { 4253838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 4254838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 4255838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (!dev_data->physical_device_state) { 4256838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4257838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4258838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 4259838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (QUERY_DETAILS != dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4260838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 4261838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4262838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4263838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4264838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4265838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4266838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4267838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 4268838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (dev_data->queue_family_properties.size() <= 4269838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex) { // requested index is out of bounds for this physical device 4270838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 4271838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4272838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4273838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4274838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 4275838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski dev_data->queue_family_properties[requestedIndex]->queueCount) { 4276838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 4277838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4278838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4279838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4280838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 4281838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex, dev_data->queue_family_properties[requestedIndex]->queueCount, 4282838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4283838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4284838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4285838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4286838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4287838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4288838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4289f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 4290838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinskistatic bool ValidateRequestedFeatures(layer_data *dev_data, const VkPhysicalDeviceFeatures *requested_features) { 4291f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4292f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4293825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski VkBool32 *actual = reinterpret_cast<VkBool32 *>(&(dev_data->physical_device_features)); 4294825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4295f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4296f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4297f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4298f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4299f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4300f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4301f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4302f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4303838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4304f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4305f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4306f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4307f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4308f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4309f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4310f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4311838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski if (errors && (UNCALLED == dev_data->physical_device_state->vkGetPhysicalDeviceFeaturesState)) { 4312f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4313f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4314838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4315cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4316cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4317cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4318f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4319f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4320f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4321f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 432289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 432389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 432456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 4325f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4326f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4327f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4328f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 4329f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski skip_call |= ValidateRequestedFeatures(my_instance_data, pCreateInfo->pEnabledFeatures); 4330f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4331838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, pCreateInfo); 4332f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 43331d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller if (skip_call) { 43341d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller return VK_ERROR_VALIDATION_FAILED_EXT; 43351d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller } 43361d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 434256a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4355b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 43616c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 4364373469f006399d6b5204ee05db3b56beb168b36fMark Young checkDeviceRegisterExtensions(pCreateInfo, *pDevice); 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4366b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4369b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4371b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4374b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4376b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 43775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4378b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4379b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4380b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 438989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4394b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4398f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4400f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4401f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4402a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4403a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4404a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4405fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 44121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 44131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4414b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 441503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 441683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4417b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 44220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 44230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 442558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4426400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 442857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 4429de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->alloc_info.allocationSize != 0) { 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 443183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 443283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 443383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 443483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 443583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4441b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4444414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 444783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4462971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4469414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4475856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4476856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4477856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4478971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4479414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4480856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4481414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4482414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4483414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4484856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4485856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4486856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4487856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4488971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4489414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4490856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4491856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4492856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4493856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 450039d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 4501a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Loop through bound objects and increment their in_use counts 4502a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// For any unknown objects, flag an error 45032f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 4504162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis bool skip = false; 4505162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; 4506162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis BASE_NODE *base_obj = nullptr; 4507a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4508a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4509a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4510162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4511162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; 4512a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4513a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 451456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 4515162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 4516162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_SAMPLER; 451756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 451856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 45192f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 4520162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); 4521162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_QUERY_POOL; 45222f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45232f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 45242f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 4525162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getPipeline(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); 4526162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_PIPELINE; 45272f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45282f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 45292f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 4530162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 4531162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER; 45322f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45332f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 45342f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 4535162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getImageNode(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 4536162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE; 45372f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45382f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 45392f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 4540162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); 4541162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_EVENT; 45422f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 45432f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 4544a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4545a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4546a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4547a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4548162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis if (!base_obj) { 4549162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis skip |= 4550162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", 4551162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); 4552162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } else { 4553162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj->in_use.fetch_add(1); 4554162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } 4555a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4556162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis return skip; 4557a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4558a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 45609a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlisstatic bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 4561e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4562a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 45639a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis cb_node->in_use.fetch_add(1); 45649a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); 4565a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4566a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below 45679a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); 4568a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : We should be able to remove the NULL look-up checks from the code below as long as 4569a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state 4570a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // should then be flagged prior to calling this function 45719a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 45739a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 45748718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 45759a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4577414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45798718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45839a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 45849a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto event_node = getEventNode(dev_data, event); 45859556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) 45869556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->write_in_use++; 4587c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4591b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4592b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 45937d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: untangle this. 4594b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4595b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4596b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4597b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4598b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4599b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4600b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4601b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4602b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4603414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4604414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4605b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4606b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4607b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4608b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4609b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4610b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4611b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 46127d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes 46137d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: nuke this completely. 4614b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4615b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4616b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4617b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4618b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4619b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4620b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4621b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4622b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4623b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4624a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Decrement in-use count for objects bound to command buffer 46252f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 462600e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis BASE_NODE *base_obj = nullptr; 4627a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4628a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4629a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 463000e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4631a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4632a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 463356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 463400e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 463556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 463656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 46372f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 463800e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); 46392f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46402f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46412f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 464200e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getPipeline(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); 46432f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46442f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46452f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 464600e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 46472f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46482f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46492f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 465000e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getImageNode(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 46512f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46522f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46532f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 465400e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); 46552f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46562f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 4657a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4658a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4659a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4660a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 466100e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis if (base_obj) { 466200e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj->in_use.fetch_sub(1); 466300e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis } 4664a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4665a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4666da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 46679867daedbf52debc77d6568162ee21e071699b80Chris Forbesstatic bool RetireWorkOnQueue(layer_data *dev_data, QUEUE_NODE *pQueue, uint64_t seq) 46689867daedbf52debc77d6568162ee21e071699b80Chris Forbes{ 46699867daedbf52debc77d6568162ee21e071699b80Chris Forbes bool skip_call = false; // TODO: extract everything that might fail to precheck 46709867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; 46719867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46729867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll this queue forward, one submission at a time. 46739867daedbf52debc77d6568162ee21e071699b80Chris Forbes while (pQueue->seq < seq) { 46749867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & submission = pQueue->submissions.front(); 46759867daedbf52debc77d6568162ee21e071699b80Chris Forbes 46769867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & wait : submission.waitSemaphores) { 46779867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); 4678da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 46799867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & lastSeq = otherQueueSeqs[wait.queue]; 46809867daedbf52debc77d6568162ee21e071699b80Chris Forbes lastSeq = std::max(lastSeq, wait.seq); 4681da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4682cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 46839867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & semaphore : submission.signalSemaphores) { 46849867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 46859867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_sub(1); 46869867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4687cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 46889867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto cb : submission.cbs) { 46899a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto cb_node = getCBNode(dev_data, cb); 4690a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First perform decrement on general case bound objects 46919a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis DecrementBoundResources(dev_data, cb_node); 46929a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 46939867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto buffer : drawDataElement.buffers) { 46949867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto buffer_node = getBufferNode(dev_data, buffer); 46959867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (buffer_node) { 46969867daedbf52debc77d6568162ee21e071699b80Chris Forbes buffer_node->in_use.fetch_sub(1); 46979867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 46989867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4699da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 47009a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 47019867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 47029867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 47039867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.write_in_use--; 47049867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47059867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47069a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto queryStatePair : cb_node->queryToStateMap) { 47079867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 47089867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 47099a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto eventStagePair : cb_node->eventToStageMap) { 47109867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4711da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 47120a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 47139867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= cleanInFlightCmdBuffer(dev_data, cb); 47149867daedbf52debc77d6568162ee21e071699b80Chris Forbes removeInFlightCmdBuffer(dev_data, cb); 47150a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 47169867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47179867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, submission.fence); 47189867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 47199867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->state = FENCE_RETIRED; 47200a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 47219867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47229867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.pop_front(); 47239867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->seq++; 4724b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 47259867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47269867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll other queues forward to the highest seq we saw a wait for 47279867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto qs : otherQueueSeqs) { 47289867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, getQueueNode(dev_data, qs.first), qs.second); 4729d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47319867daedbf52debc77d6568162ee21e071699b80Chris Forbes return skip_call; 47329867daedbf52debc77d6568162ee21e071699b80Chris Forbes} 4733651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4734651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4735651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4736651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4737651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 47389867daedbf52debc77d6568162ee21e071699b80Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) 4739651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4740cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 47419867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = pQueue->queue; 47429867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; 4743b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4744b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4745e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 475127c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4752414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 475983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 47600a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 47610a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 476283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 476383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis 0, __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 476483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 476583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 476683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 47670a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4772e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4773e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4774e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4775e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4776e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 477883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4781e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4782e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4783e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 478683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4789414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 479383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47967bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Validate that queueFamilyIndices of primary command buffers match this queue 47977bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Secondary command buffers were previously validated in vkCmdExecuteCommands(). 47987bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinskistatic bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { 47997bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski bool skip_call = false; 48007bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 48017bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto queue_node = getQueueNode(dev_data, queue); 48027bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 48037bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (pPool && queue_node && (pPool->queueFamilyIndex != queue_node->queueFamilyIndex)) { 48047bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 48057bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 48067bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkQueueSubmit: Primary command buffer 0x%" PRIxLEAST64 48077bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d is being submitted on queue 0x%" PRIxLEAST64 " from queue family %d.", 48087bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), pPool->queueFamilyIndex, 48097bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(queue), queue_node->queueFamilyIndex); 48107bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 48117bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 48127bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski return skip_call; 48137bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski} 48147bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 4815da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 481783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4818a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4819a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 4820a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 482183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 4822a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 482383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 4824a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 482883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 48294c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 48304c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4833414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4835414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 48364c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4842a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 484383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB); 4844a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 484583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 484881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4849651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 485081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 485183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 485281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4853651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4854cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 485583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 485683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 485783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4858a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 485981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4860cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 486183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 486283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 486383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 486483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 486583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 4866a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 486881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 486983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 487081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 487181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4872651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 487381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 487481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 487583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 487681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 487781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 487881c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 487981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4880651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 4881651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 488283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 488381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 488483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 4885d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 4886d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 4887d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 48881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 48891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 48901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4891651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4892651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 4893651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 48949867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, std::max(1u, submitCount)); 4895651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4896651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49009867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<SEMAPHORE_WAIT> semaphore_waits; 49019867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<VkSemaphore> semaphore_signals; 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 490301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 490401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 490501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 490601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 49079867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 49089867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 49099867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 49109867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 49119867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 491201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 49131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 491483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 49151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4917414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 49181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 49191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 492301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 492401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 492501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 492601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 492783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 49281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 49291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4930414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4931414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 49321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 49339867daedbf52debc77d6568162ee21e071699b80Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); 49341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 49359867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 49369867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 493701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 4938da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 49399867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 49401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49410a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4943651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4944da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 4945da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4947971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 494883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 49491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 4950da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 4951651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 4952da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 4953651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 4954651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 49551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 495683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, pCBNode); 49577bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= validateQueueFamilyIndices(dev_data, pCBNode, queue); 4958ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis // Potential early exit here as bad object state may crash in delayed function calls 4959ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (skip_call) 4960ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis return result; 49611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 49621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 496383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 49641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 496683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 49671344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4968d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 496983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 4970d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 49711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4973da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 49749867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, 49759867daedbf52debc77d6568162ee21e071699b80Chris Forbes submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); 49769867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 49779867daedbf52debc77d6568162ee21e071699b80Chris Forbes 49789867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !submitCount) { 49799867daedbf52debc77d6568162ee21e071699b80Chris Forbes // If no submissions, but just dropping a fence on the end of the queue, 49809867daedbf52debc77d6568162ee21e071699b80Chris Forbes // record an empty submission with just the fence, so we can determine 49819867daedbf52debc77d6568162ee21e071699b80Chris Forbes // its completion. 49829867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 49839867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 49849867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 49859867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 49865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49879867daedbf52debc77d6568162ee21e071699b80Chris Forbes 4988b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 498983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 49905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 49915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 49935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 499589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 499689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 49975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 49985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 49995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5000b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 50020a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 50035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 50045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 500689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 500789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 501874243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller bool skip_call = freeMemObjInfo(my_data, device, mem, false); 50190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 50200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 5021b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 502274243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller if (!skip_call) { 502374243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 502474243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5027f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// Validate that given Map memory range is valid. This means that the memory should not already be mapped, 5028f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// and that the size of the map range should be: 5029f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 1. Not zero 5030f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 2. Within the size of the memory allocation 5031f57fc64ac43691ad98e1713886b345465573070aTobin Ehlisstatic bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 503283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 503583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 503683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 503783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 504257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 5044de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.size != 0) { 504583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 504683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 504783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 5052de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (offset >= mem_info->alloc_info.allocationSize) { 505383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 505483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 505583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 505683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 5057de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5060de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((offset + size) > mem_info->alloc_info.allocationSize) { 506183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 506257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 506357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 506457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 5065de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size + offset, mem_info->alloc_info.allocationSize); 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 506983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5072e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 507357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 507457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5075de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.offset = offset; 5076de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = size; 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 508183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 508257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 508357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5084de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!mem_info->mem_range.size) { 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 508683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 508783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 508883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5090de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = 0; 50915f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 50925f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski free(mem_info->shadow_copy_base); 50935f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = 0; 50945f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 509783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51005f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski// Guard value for pad data 51015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51035f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, 51045f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski void **ppData) { 510557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 510657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5107de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->p_driver_data = *ppData; 5108de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis uint32_t index = mem_info->alloc_info.memoryTypeIndex; 5109b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 51105f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 51135f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski size = mem_info->alloc_info.allocationSize - offset; 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51155f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 51165f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(mem_info->shadow_pad_size, 51175f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); 51185f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Ensure start of mapped region reflects hardware alignment constraints 51195f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 51205f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 51215f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. 51225f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t start_offset = offset % map_alignment; 51235f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. 51245f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = malloc(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset); 51255f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 51265f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 51275f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & 51285f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ~(map_alignment - 1)) + start_offset; 51295f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, 51305f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski map_alignment) == 0); 51315f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 51325f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, 2 * mem_info->shadow_pad_size + size); 51335f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51375f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 5138a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 51399867daedbf52debc77d6568162ee21e071699b80Chris Forbes// a fence being waited on should not already be signaled and 5140a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 514149f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 514283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 51439b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 514449f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 51459b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 5146cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 514783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 514883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 514983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 515083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 515183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 515483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5156a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 5157b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbesstatic bool RetireFence(layer_data *dev_data, VkFence fence) { 5158b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes auto pFence = getFenceNode(dev_data, fence); 5159b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 5160b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes /* Fence signaller is a queue -- use this as proof that prior operations 5161b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes * on that queue have completed. 5162b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes */ 5163b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes return RetireWorkOnQueue(dev_data, 5164b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 5165b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes pFence->signaler.second); 5166b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes } 5167d4513979120463171eb479cdded9336eb9944da1Chris Forbes else { 5168d4513979120463171eb479cdded9336eb9944da1Chris Forbes /* Fence signaller is the WSI. We're not tracking what the WSI op 5169d4513979120463171eb479cdded9336eb9944da1Chris Forbes * actually /was/ in CV yet, but we need to mark the fence as retired. 5170d4513979120463171eb479cdded9336eb9944da1Chris Forbes */ 5171d4513979120463171eb479cdded9336eb9944da1Chris Forbes pFence->state = FENCE_RETIRED; 5172d4513979120463171eb479cdded9336eb9944da1Chris Forbes return false; 5173d4513979120463171eb479cdded9336eb9944da1Chris Forbes } 5174b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes} 5175b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes 517689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 517789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 51785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5179e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 51805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 518349f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5185b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 51865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5188a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 5190414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5192b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 51959867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (uint32_t i = 0; i < fenceCount; i++) { 5196b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes skip_call |= RetireFence(dev_data, pFences[i]); 51979867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5202b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 52035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 52065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 520989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 521183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5212b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 521383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 5214b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5215a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 521683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 521783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5218a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 521983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5220b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5222d4513979120463171eb479cdded9336eb9944da1Chris Forbes skip_call |= RetireFence(dev_data, fence); 52235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5224b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5225e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 523089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5231b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5234b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5235b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5236b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5237b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5238b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5239b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 52408988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 52417bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski pQNode->queueFamilyIndex = queueFamilyIndex; 52429867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQNode->seq = 0; 5243b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 524689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 52475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5248e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 52499867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 52509867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 52519867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, pQueue, pQueue->seq + pQueue->submissions.size()); 52529867daedbf52debc77d6568162ee21e071699b80Chris Forbes lock.unlock(); 5253e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 52565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 525989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5260e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5262b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52639867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & queue : dev_data->queueMap) { 52649867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5266b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5267e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 527583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5276b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 52781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5279cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 528083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 528183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 528283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 52831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 52855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5286b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 52871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 528883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5292eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis// For given obj node, if it is use, flag a validation error and return callback result, else return false 5293eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlisbool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct) { 5294eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5295eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (obj_node->in_use.load()) { 5296eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, 5297f4cc4424ca6a7819cd8e9ed646d337b4a74ed7f3Tobin Ehlis DRAWSTATE_OBJECT_INUSE, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer.", 5298eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis object_type_to_string(obj_struct.type), obj_struct.handle); 5299eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis } 5300eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return skip; 5301eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis} 5302eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis 530389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 530489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5306eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5307e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5308eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis auto sema_node = getSemaphoreNode(dev_data, semaphore); 5309eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (sema_node) { 5310eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sema_node, 5311eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}); 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5313eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (!skip) { 5314eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->semaphoreMap.erase(semaphore); 5315eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis lock.unlock(); 531699d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 531799d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller } 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 532089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5322eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5323b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53249556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 53259556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 5326eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; 5327eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, event_node, obj_struct); 53289556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis // Any bound cmd buffers are now invalid 5329eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(event_node->cb_bindings, obj_struct); 53309556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 5331f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5332f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->eventMap.erase(event); 5333f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5334e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 5335f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 533889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 533989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5340ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5341eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5342ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5343ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5344ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5345eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; 5346eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, qp_node, obj_struct); 5347ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5348eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, obj_struct); 5349ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5350f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5351f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5352f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5353eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 5354f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 535889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 535989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5362b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5364971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5375ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5376ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5377ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5378ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5379971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5380ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5381ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5382ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5383ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5384414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5385ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5386ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5387ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5388ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5389ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5390ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5391ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5392ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5393ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5394ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5395ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5396ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5397ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5398971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5399ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5400ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5401ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5404414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5407ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5408ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5411414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5413ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5414ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5415ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5416ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5417414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5418ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5419ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5423b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5430e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5431e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54328718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 54338718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5436414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 54388718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5441414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5447825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if given ranges intersect, else false 5448825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted 5449825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// in an error so not checking that here 5450825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// pad_ranges bool indicates a linear and non-linear comparison which requires padding 5451825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call 5452825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// may be set by the callback function so caller should merge in skip_call value if padding case is possible. 54537dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { 54547dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call = false; 5455825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_start = range1->start; 5456825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_end = range1->end; 5457825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_start = range2->start; 5458825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_end = range2->end; 5459825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkDeviceSize pad_align = 1; 5460825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5461825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; 5462825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5463825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) 5464825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 5465825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) 5466825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 546747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5468825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5469825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // In linear vs. non-linear case, it's an error to alias 5470825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; 5471825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_type_str = range1->image ? "image" : "buffer"; 5472825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; 5473825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_type_str = range2->image ? "image" : "buffer"; 5474825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; 54757dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call |= 5476825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, 5477825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 5478825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis " which is in violation of the Buffer-Image Granularity section of the Vulkan specification.", 5479825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); 548047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 5481825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Ranges intersect 5482825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return true; 548347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 5484623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis// Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses 5485cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { 5486825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Create a local MEMORY_RANGE struct to wrap offset/size 5487825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis MEMORY_RANGE range_wrap; 5488825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Synch linear with range1 to avoid padding and potential validation error case 5489825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.linear = range1->linear; 5490825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.start = offset; 5491cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis range_wrap.end = end; 5492825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool tmp_bool; 54937dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); 5494825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5495cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given mem_info, set all ranges valid that intersect [offset-end] range 5496cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid 5497cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { 5498cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis bool tmp_bool = false; 5499cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis MEMORY_RANGE map_range; 5500cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.linear = true; 5501cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.start = offset; 5502cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.end = end; 5503cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto &handle_range_pair : mem_info->bound_ranges) { 55047dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { 5505cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : WARN here if tmp_bool true? 5506cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis handle_range_pair.second.valid = true; 5507cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5508cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5509cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis} 5510825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Object with given handle is being bound to memory w/ given mem_info struct. 5511825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Track the newly bound memory range with given memoryOffset 5512825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear 5513825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// and non-linear range incorrectly overlap. 5514825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if an error is flagged and the user callback returns "true", otherwise false 5515825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates an image object, otherwise handle is for a buffer 5516825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_linear indicates a buffer or linear image 5517825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, 5518825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { 5519825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool skip_call = false; 55205360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis MEMORY_RANGE range; 5521825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5522825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.image = is_image; 552347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 5524825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.linear = is_linear; 5525f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis range.valid = mem_info->global_valid; 5526825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.memory = mem_info->mem; 552747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 5528825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.size = memRequirements.size; 552947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 55305360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis range.aliases.clear(); 55315360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Update Memory aliasing 55325360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Save aliase ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we 55335360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself 55345360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; 5535825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto &obj_range_pair : mem_info->bound_ranges) { 5536825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto check_range = &obj_range_pair.second; 55375360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis bool intersection_error = false; 55387dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { 5539825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis skip_call |= intersection_error; 5540825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.aliases.insert(check_range); 55415360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_alias_ranges.insert(check_range); 5542825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5543825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 55445360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis mem_info->bound_ranges[handle] = std::move(range); 55455360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis for (auto tmp_range : tmp_alias_ranges) { 55465360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); 55475360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis } 5548825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5549825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.insert(handle); 5550825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5551825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.insert(handle); 5552825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5553825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return skip_call; 555447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 555547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 55569f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5557825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs, bool is_linear) { 55589f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); 5559825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5560825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 55619f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5562825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs) { 55639f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); 5564825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5565825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5566825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info 5567825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates if handle is for image or buffer 5568825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// This function will also remove the handle-to-index mapping from the appropriate 5569825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// map and clean up any aliases for range being removed. 5570825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { 5571825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto erase_range = &mem_info->bound_ranges[handle]; 5572825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto alias_range : erase_range->aliases) { 5573825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis alias_range->aliases.erase(erase_range); 557447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 55755360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis erase_range->aliases.clear(); 5576825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_ranges.erase(handle); 5577825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5578825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.erase(handle); 5579825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5580825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.erase(handle); 558147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 558247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5583825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } 5584825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5585825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } 5586825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 558789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 558889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5590b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 55915a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5592e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5593e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5594e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5595e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5596e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5597e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5598e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->mem); 5599e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5600825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); 5601e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5602e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5603e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5604e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5605b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 560747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 561089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 561189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5613e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5614e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 561539267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis auto view_state = getBufferViewState(dev_data, bufferView); 561639267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis if (view_state) { 561739267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis dev_data->bufferViewMap.erase(bufferView); 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5619e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5620e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 562389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5626e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 562799df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto img_node = getImageNode(dev_data, image); 562899df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis if (img_node) { 562999df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis // Any bound cmd buffers are now invalid 563099df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis invalidateCommandBuffers(img_node->cb_bindings, 563199df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis {reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 563247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 563399df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, img_node->mem); 563457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5635825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveImageMemoryRange(reinterpret_cast<uint64_t &>(image), mem_info); 563647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 563747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 563858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 563999df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis dev_data->imageMap.erase(img_node->image); 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5648e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 5649e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56524261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 56534261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 56544261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 5655de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { 5656de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis skip_call = log_msg( 5657de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5658de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 5659de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 5660de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "type (0x%X) of this memory object 0x%" PRIx64 ".", 5661de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, reinterpret_cast<const uint64_t &>(mem_info->mem)); 56624261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 56634261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 56644261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 56654261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 566689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 566789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 566858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5670b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 56729f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); 567383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 56748718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 56758718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 567794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 56784bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->mem = mem; 56794bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memOffset = memoryOffset; 56804bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memSize = memRequirements.size; 568147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 568247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 568357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 568457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 56859f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, memRequirements); 568683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 568747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 568847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 56892c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 56902c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 569183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 56922c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 56932c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5694414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5695414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 56962c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 56972c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 56982c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5699ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 57002c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5701ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5702ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5703ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5704ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5705ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5706ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5707ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5708ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5709ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5710ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5711ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5712ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5713ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5714ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5715ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5716ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5717ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5718ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5719ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 57208718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5721ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5722ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5723ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5724ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5725ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5726ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5727ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5728ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5729ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5730ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5731ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 57322c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 57332c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57350a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5736b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 573783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 573858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 574389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 574489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 57475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 575189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 575289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 57565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5758593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 575989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 576089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 5761e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 576689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 576789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5768918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5769918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5770b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5771918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5772b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5773918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5774918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 577789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 577889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 5779a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5780eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5781e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5782a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis auto pipe_node = getPipeline(dev_data, pipeline); 5783a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) { 5784eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; 5785eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, pipe_node, obj_struct); 5786a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis // Any bound cmd buffers are now invalid 5787eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(pipe_node->cb_bindings, obj_struct); 5788a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 5789f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5790f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->pipelineMap.erase(pipeline); 5791f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5792eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 5793f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 579689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 579789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 57986792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5799e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 58006792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 5801e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 5802e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5803e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 580689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 580789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 580856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5809eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 581056f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 581156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, sampler); 581256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) { 5813eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; 5814eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sampler_node, obj_struct); 581556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis // Any bound cmd buffers are now invalid 5816eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(sampler_node->cb_bindings, obj_struct); 581756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 5818f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5819f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->samplerMap.erase(sampler); 5820f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5821eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 5822f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 582589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 582689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 5827e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 583389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 5834e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 58355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 58365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5838bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5839bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5840bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5841bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5842a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5843bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5844bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5845bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5846bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5847bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5848bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5849bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5850bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5851414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5852bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5853bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5854bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5855bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5856bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5857a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 5858bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5859a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 5860bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5861a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5862a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5863a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5864bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5865bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5866bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5867bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5869a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 5870a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 5871a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 5872a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 5873a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 5874a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 587589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 587689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 58775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5879b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5880c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 58815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 58829f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 58835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 58849f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 58859f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free"); 5886c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5887c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 5888c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5889c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 5890c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 5891c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 5892c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 5893c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 58949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 5895c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 58969f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 58979f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 58985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 58999f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 59009f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 59019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 5905c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 59065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5908b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5909e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5910e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 591389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 591489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 591589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5921b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 59225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 59235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 59245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 592889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 592989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5934b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5935eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; 5936eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis qp_node->createInfo = *pCreateInfo; 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 594289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 594389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 594583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5946b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5948a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 594983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 595183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 59539f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 5954a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5955a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 5956a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 59579f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 5958d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // Remove references to this cb_node prior to delete 5959d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // TODO : Need better solution here, resetCB? 59607165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 59617165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 59627165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 5963d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis for (auto framebuffer : cb_node->framebuffers) { 5964d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 5965d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis if (fb_node) 5966d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis fb_node->cb_bindings.erase(cb_node); 5967d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis } 59689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 59699f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 5970a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 5971a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 5972a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 5973e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5974e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 597789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 597889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 598083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5981400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 59821ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 5983a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 598483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 59851ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 5986a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 598783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5990a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59941ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 5995a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 5996a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 5997a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59991ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 600489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 600683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6007b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 6009df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6010090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 601183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 601283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 601383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6016b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6017090da73358f71ba026e2474a822fecf55267d166Chris Forbes 601883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6019090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6020090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6021090da73358f71ba026e2474a822fecf55267d166Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 6022090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6023090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 6024090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 6025090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 6026090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6027090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 6028090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 6029090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6030090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6031090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 6032090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6033090da73358f71ba026e2474a822fecf55267d166Chris Forbes 60345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6037e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 6038e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 6039e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 6040e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 6041e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 6042e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 6043e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 6044e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 604589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 604689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 60475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6048b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6049d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 6050d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) { 6051e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis invalidateCommandBuffers(fb_node->cb_bindings, 6052e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis {reinterpret_cast<uint64_t &>(fb_node->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}); 6053d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis dev_data->frameBufferMap.erase(fb_node->framebuffer); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6055b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 605989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 606089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6062e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 60647bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes // TODO: leaking all the guts of the renderpass node here! 6065e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis lock.unlock(); 6066e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 606989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 607089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 607247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 607347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6076b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 6078b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60838c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 60848c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 60858c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 60868c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 6087b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 6088b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 6089cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 6090cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 609159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, buf_node, 6092b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 6093b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 6094b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 60958c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 60968c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 60978c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 609889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 609989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61018c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 61028c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 61038c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 61048c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 61058c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61088c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 610939267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); 61108c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 611589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 611689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 611847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 611947892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 61205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6122b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 612629e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(*pImage, pCreateInfo)))); 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6135b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61376d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 61386d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 61415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 61446d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 61486d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6157b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 61616d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 61626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 61646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 61676d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61728c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo) { 61738c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 61748c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young IMAGE_NODE *image_node = getImageNode(dev_data, pCreateInfo->image); 6175b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (image_node) { 61765a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour skip_call |= ValidateImageUsageFlags( 61775a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour dev_data, image_node, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | 61785a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 61795a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour false, "vkCreateImageView()", 61805a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); 6181b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 6182b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_node, "vkCreateImageView()"); 6183bb6624cb996175d8945190886a200e720b3871efChris Forbes } 61848c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 61858c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6186bb6624cb996175d8945190886a200e720b3871efChris Forbes 618779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlisstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo, VkImageView view) { 618879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, pCreateInfo)); 618979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, pCreateInfo->image); 61908c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6191bb6624cb996175d8945190886a200e720b3871efChris Forbes 61928c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 61938c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 61948c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61958c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 61968c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateImageView(dev_data, pCreateInfo); 61978c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 61988c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 61998c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 62008c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62028c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 620379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); 62048c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6206bb6624cb996175d8945190886a200e720b3871efChris Forbes 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 621089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 621189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6215b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6216a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 62178988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 6218a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6219cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 622589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 622689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 623389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 623989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 624689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 62533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 62543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 62553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 62563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 62573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 62583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 62643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 62653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 62663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 62673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 62713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 62723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 627389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 627489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 627589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 627689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 628383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6289b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6292ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6293ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 62948da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeNode[i]->render_pass_ci.initialize(getRenderPass(dev_data, pCreateInfos[i].renderPass)->pCreateInfo); 6295c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 629667220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 629783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 630083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6301b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6304b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6309b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63125188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6314b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 632089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 632189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 632289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 632389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 63245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 632583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6332b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6338ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6339c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 6340ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 634383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], &dev_data->phys_dev_properties.features, 634483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 634583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 634883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6349b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6357b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6363b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 636989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 637089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6374b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6375cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 638089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 638189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 638289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 6387b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6388cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 6389cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 63959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 63969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 63979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 63989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 639983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 64009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 64019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 64029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 64039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 64049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 640583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 64069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 64089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 64099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 64109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 641183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 641283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 641383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 641483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 64159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 641683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 641783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 64189e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64199e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64209e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 64219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 64229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 642383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 64249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 64269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 64279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 64289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 642983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 64309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 64319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 64329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 64339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 64349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 643583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 643683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 64379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64399e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 64409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 64419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 644283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 644383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 644483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 644583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 64469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 644783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 644883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 644983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 645083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 64519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 645283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 645383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 64549e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 645683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 645989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 646089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 646183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 646407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz uint32_t i, j; 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 646683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 646783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 64689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 646983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 647083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 64719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64729e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 647307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if (skip_call) 647407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz return VK_ERROR_VALIDATION_FAILED_EXT; 647507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz 64769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 647707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz // There's no explicit Valid Usage language against this, so issue a warning instead of an error. 647807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 647907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 648007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 648107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 648207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 648307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 648407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 648507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz skip_call |= 648607a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 648707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 648807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 648907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz i, minA, maxA, j, minB, maxB); 64909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6493f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 649869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6499416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6501416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6503416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6505416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 651189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 651289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 651389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6519414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6529b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 653889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 653989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6543b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65482c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6549789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6550789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 65517f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 65527f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 65537e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6554e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 65557e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 65567e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 65577e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 65587f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 65597f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 65607e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 65612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6562b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 65632c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 65642c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 656589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 656689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6568b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65697f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 65707f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6571b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6572d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 65737e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6575d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 65776511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6579b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 65807f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6581b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6585cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6586cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6587cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6588cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6589cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6590cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6591cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6592cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6593cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6594cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6595cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6596cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6597cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6598cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6599cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6600cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6601cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6602cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6603cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6604cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6605cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6606cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6607cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6608cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6609cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6610cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6611cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6612cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6613cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6614cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6615cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6616cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6617cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6618cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6619cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6620cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6621cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6622cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 662489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 662589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6628b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 662983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6630b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6631e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 663283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6636b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6637cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6638b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66426b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 66436b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 66446b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 66456b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 66466b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 66476b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 66486b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 66496b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 66506b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 66516b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 66526b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 66536b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 66546b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 66556b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6656104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6657104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 66586b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 66596b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 66606b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 66616b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 66626b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6663104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66646b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 66656b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 666789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 666889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 666989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 66706b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6672b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66736b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6675b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 66766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 66796b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 66806b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 66816b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 66826b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 668689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 668789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6691b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6692cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 6693cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 6694cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 669572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 6697cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6707b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 671289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 671389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 671483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6716b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 6718f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 6719f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6721a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 672283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6723a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6724a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6725414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6726a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6727a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6729f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, cb_node); 6730f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 673483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6737414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6741400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 674283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6745414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6748400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 674983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 675083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 675183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 675283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 675383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 675483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6757f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6758f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6759a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 6760a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 6761a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis getRenderPass(dev_data, pInfo->renderPass)->pCreateInfo, 6762a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 6763400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 676483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6765a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6766a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 6767a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 6768a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 6769a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6770a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 6771a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 6772a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 6773a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6776f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis framebuffer->cb_bindings.insert(cb_node); 6777ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis for (auto attach : framebuffer->attachments) { 6778ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis auto img_node = getImageNode(dev_data, attach.image); 6779ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (img_node) { 6780f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis addCommandBufferBinding(&img_node->cb_bindings, {reinterpret_cast<uint64_t &>(attach.image), 6781f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}, 6782f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node); 6783ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis } 6784ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis } 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6789b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 679183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 679283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 679383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 679483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 679583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 679683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 679783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 680116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 680216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 680316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 680483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 680583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 680683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 680783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 680883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 680983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6814f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (CB_RECORDING == cb_node->state) { 681583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6818414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 6821f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->cmds.back().type)) { 6822f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis VkCommandPool cmdPool = cb_node->createInfo.commandPool; 6823cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6824cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 682583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6828414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6829414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 6836f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->state = CB_RECORDING; 6837f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo = *pBeginInfo; 6838f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->beginInfo.pInheritanceInfo) { 6839f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); 6840f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; 6841888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6842f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6843f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6844f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = getRenderPass(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); 6845f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; 6846f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); 6847888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 685083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 685183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 685283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 685583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6859400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 686389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 686483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6867b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6870fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6871fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6872fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 687383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6874fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 687583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 687783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 687883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 687983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 688083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 688383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6884b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6886b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6896b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 690089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 690189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6902bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6904b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 6907cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 6908cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 6909bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6910bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6911414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6912bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6913bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6915a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 6916b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6917bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6921b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6922a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6924b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 692893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 692989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 693089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 693183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6933b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 693683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 693883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6941414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6942ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 69475c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_node = pPN; 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 69493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 695183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 695283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 695383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6955a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis addCommandBufferBinding(&getPipeline(dev_data, pipeline)->cb_bindings, 6956a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, pCB); 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6958b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 695983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 696389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 696489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 696583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6967b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 697083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 6971b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 697483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 697889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 697989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 698083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6982b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 698583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 6986b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6988b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 698983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 699389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6994a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6996b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6999a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 7001a27508babf63d50aea75883a3702979193c23683Mark Young 70025c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 7003a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 7004a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 7005a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 7006386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 7007a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 7008a27508babf63d50aea75883a3702979193c23683Mark Young } else { 7009a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 7010a27508babf63d50aea75883a3702979193c23683Mark Young } 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7012b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7013a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 701789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 701889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 701983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7021b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 702483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7027b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 702883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 703389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 703483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7036b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 703983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 70403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7042b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 704383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 704789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 704889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 704983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7051b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 705483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7057b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 705883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 706289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 706389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 706483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7066b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 706983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7072b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 707383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 707789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 707889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 707983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7081b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 708483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7087b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 708883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 709289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 709389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 709483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7096b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 709983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7102b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 710383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 710789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 710889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 710989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 711089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 711183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7113b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7117787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7118787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7119787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7120787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 7121dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 712272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 7123dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 7124dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 712571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 712669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 7127787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7128397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7129787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 713069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 713171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 713283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 713383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 713483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 713583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7136397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 713783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 713883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 713983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 714083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "DS 0x%" PRIxLEAST64 714183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 714283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7143787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7144787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 714569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 714683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 714783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 714883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 714983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 715083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 715183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 7152787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7153dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7154dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 7155dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7156dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 7157dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7158dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 7159787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7160dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 716183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7162787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7163787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7164787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7165414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 7166787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7167787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7168397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 7169787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7170787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7171787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7172787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7173397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 7174397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7175787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7176787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7177b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 717883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7179787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7180787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7181787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7182787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7183414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 7184787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7185b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7186787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7187787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7188397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7189787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7190787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7191b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 719283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7193787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7194787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7195787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7196787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7197414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 7198787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7199b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7201787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 72025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7204dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7205dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 7206dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 7207dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 7208787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7209dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 7210dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 72115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7213787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 721483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 721583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 721683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 721783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 721983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 722072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 722172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 722272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 722372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 722471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 722569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 722683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 722772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 722872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 722972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 7230414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 7231414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 723272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 723372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 723472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 723572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 723672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 723772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 723872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 723972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 724069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 724171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 724283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 724372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 724471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 7245414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 7246414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 724772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 7248414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 724971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 725072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 725172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 725272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7256787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7257787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 725883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 725983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 726083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 726183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 726283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 726383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7264787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 726683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7269b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 727083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 727589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 727689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 727783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7279593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 7280b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7281b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7282ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 72839f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7284ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7285b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7286ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7287f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7288ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 72899f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 729083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 730483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 730583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 730683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 730783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73099f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 7310ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7311ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 731483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 73215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7328e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 733089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 733189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 733289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 733383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7335593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 7336b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7337b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 73389f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 73399f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 7340593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 7341ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 7342ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7343b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7344ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7345f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7346ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 73479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73499f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 73509f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 735283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7354b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 735583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 73575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7359b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 73627a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 73637a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 736479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 736579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) 73665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 7367249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 736879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto img_node = getImageNode(dev_data, view_state->create_info.image); 7369249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(img_node); 7370e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7371f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 7372e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 73747a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 73757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 73767a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7377ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7378ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7379e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7380f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, buff_node, true); 7381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 73837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 738889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 738989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 739083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 73915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7392b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 739583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 73965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7397e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDraw"); 739883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 73995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 740083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 74015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7402414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 740383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 740483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 74055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 740783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 74085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7409b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 741083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 74125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 741489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 741589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 741883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7419b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 742283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7424e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexed"); 742583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 742783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 742883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 742983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 743083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 743183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 74325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 743483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7436b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 743783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 744389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 744583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7446b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7447ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7448ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7449ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7450ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7451b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7452c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7453ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7454ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7455e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndirect"); 7456ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 745883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 745983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 746083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 746183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 746283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7463ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7465b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7466ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7467ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7469b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 747083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 747489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 747589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 747683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7478b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7479ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7480ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7481ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7482ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7483b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 7484c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7485ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 7486ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 7487e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7488e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexedIndirect"); 7489ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 749183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7493414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 749583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 749683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7497ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7499b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 7500ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7501ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7503b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 750483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 750889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 750983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7511b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7514e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatch"); 751583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 751683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 751783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7519b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 752083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 752489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 752589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 752683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7528b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7529ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7530ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7531ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7532b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 7533b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 7534c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7535e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7536e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatchIndirect"); 7537ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 7538ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 7539b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 754283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 754689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 754789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 754883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7550b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7551ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 75529f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7553ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7554ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7555ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 7556b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7557b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 7558ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 7559c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7560c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7561ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 756259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 7563ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 756459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 7565ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7566ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7567ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7568f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7569ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 75709f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7571593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7572f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7573e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 75759f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7576593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 757783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7578b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 7579ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7580ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 7581ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7583b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 758483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 758827e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 758927e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 7590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 759627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 759727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 761107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 761207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, srcImage); 761307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 761407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 761507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 761607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 761707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 761807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 762927e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 763027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 7631e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 763727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 763827e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 765107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, destImage); 765207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 765307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 765407b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 765507b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 765607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 765707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if two VkExtent3D structs are equivalent 76699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { 76709ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool result = true; 76719ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || 76729ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (extent->depth != other_extent->depth)) { 76739ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano result = false; 76749ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 76759ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return result; 76769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 76779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 76789ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image extent of a specific subresource. 76799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline VkExtent3D GetImageSubresourceExtent(const IMAGE_NODE *img, const VkImageSubresourceLayers *subresource) { 76809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t mip = subresource->mipLevel; 76819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D extent = img->createInfo.extent; 768290b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.width = std::max(1U, extent.width >> mip); 768390b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.height = std::max(1U, extent.height >> mip); 768490b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.depth = std::max(1U, extent.depth >> mip); 76859ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return extent; 76869ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 76879ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 76889ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if the extent argument has all dimensions set to 0. 76899ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentZero(const VkExtent3D *extent) { 76909ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); 76919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 76929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 76939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. 76949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_NODE *img) { 76959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. 76969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = { 0, 0, 0 }; 7697f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 7698f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 76999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 77009ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_format_is_compressed(img->createInfo.format)) { 77019ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano auto block_size = vk_format_compressed_block_size(img->createInfo.format); 77029ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.width *= block_size.width; 77039ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.height *= block_size.height; 7704f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7705f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 77069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return granularity; 77079ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 77089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 77099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure 77109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { 77119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool valid = true; 77129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || 77139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (vk_safe_modulo(extent->height, granularity->height) != 0)) { 77149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano valid = false; 77159ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7716f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return valid; 7717f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7718f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7719f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values 77209ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, 77219ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { 7722f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 77239ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent = {}; 77249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.width = static_cast<uint32_t>(abs(offset->x)); 77259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.height = static_cast<uint32_t>(abs(offset->y)); 77269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); 77279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 77289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) 77299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(&offset_extent) == false) { 77309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 77329ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " 77339ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 77349ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z); 77359ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 77369ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 77379ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even 77389ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity. 77399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentAligned(&offset_extent, granularity) == false) { 77409ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 77429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " 77439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", 77449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, 77459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth); 77469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7747f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7748f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7749f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7750f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7751f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values 77529ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, 77539ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, 77549ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function, const char *member) { 7755f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 77569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 77579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image 77589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent. 77599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentEqual(extent, subresource_extent) == false) { 77609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 77629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " 77639ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 77649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, 77659ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->height, subresource_extent->depth); 77669ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 77679ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 77689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even 77699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image 77709ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent dimensions. 77719ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent_sum = {}; 77729ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; 77739ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; 77749ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; 77759ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { 77769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= 77779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7778f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 77799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " 77809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " 77819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", 77829ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, 77839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, 77849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->width, subresource_extent->height, subresource_extent->depth); 77859ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7786f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7787f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7788f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7789f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7790f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value 77919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, 77929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 7793f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 77949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 7795f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7796f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 77979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " 77989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "transfer granularity width (%d).", 77999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 7800f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7801f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7802f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7803f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7804f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value 78059ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, 78069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 7807f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 78089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 78099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 78119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%" PRIdLEAST64 78129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano ") must be an even integer multiple of this command buffer's queue family image transfer " 78139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "granularity width (%d).", 78149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 7815f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7816f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7817f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7818f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7819f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure 7820f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 78219ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const IMAGE_NODE *img, const VkImageCopy *region, 78229ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 7823f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 78249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 78259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); 78269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); 78279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); 78289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, 78299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent"); 7830f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7831f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7832f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7833f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure 7834f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 78359ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const IMAGE_NODE *img, const VkBufferImageCopy *region, 78369ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 7837f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 78389ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 78399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); 78409ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); 78419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); 78429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); 78439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); 78449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, 78459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, "imageExtent"); 7846f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7847f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7848f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 784989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 785089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 785189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 785283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7855249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 78569f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7857249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7858249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7859249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7860b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImage()"); 7861b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyImage()"); 7862249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7863c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 7864c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 7865249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 786659b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 7867ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 786859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 7869ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7870f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImage()"); }; 78719f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7872593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7873f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 78769f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7877593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 787883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7879b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 788127e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 788227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 78839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_img_node, &pRegions[i], i, 78849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyImage()"); 78855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7886249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7887249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7889b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 789083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7895eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski// Validate that an image's sampleCount matches the requirement for a specific API call 7896eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinskistatic inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_NODE *image_node, VkSampleCountFlagBits sample_count, 7897eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski const char *location) { 7898eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski bool skip = false; 7899eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski if (image_node->createInfo.samples != sample_count) { 7900eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 7901eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 7902eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s.", location, 7903eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 7904eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski string_VkSampleCountFlagBits(image_node->createInfo.samples), string_VkSampleCountFlagBits(sample_count)); 7905eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski } 7906eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski return skip; 7907eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski} 7908eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski 790989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 791089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 791189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 791283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7914b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7915593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 79169f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7917249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 7918249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7919249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 7920eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage"); 7921eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage"); 7922b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdBlitImage()"); 7923b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdBlitImage()"); 7924249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 7925c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 7926c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 7927249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 792859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 7929ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 793059b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 7931ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7932f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdBlitImage()"); }; 79339f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7934593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7935f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7936e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 79389f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7939593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 794083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7941b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 7942249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 7943249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7945b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 794683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 795289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 795389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 795483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7956b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7957593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 79589f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7959ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7960249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 7961249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_buff_node && dst_img_node) { 7962eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage"); 7963b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 7964b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyBufferToImage()"); 7965c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7966c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 796759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 7968ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 796959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7970ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7971e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7972f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 7973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 79759f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7976f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); }; 79779f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7978593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 797983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7980b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 798227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 79839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_img_node, &pRegions[i], i, 79849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyBufferToImage()"); 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7986ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7987ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7989b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 799083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 799589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 799689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 799789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 799883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8000b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8001593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 80029f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8003249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8004ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8005249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_buff_node) { 8006eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage"); 8007b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 8008b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 8009249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 8010c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8011c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8012249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 801359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 8014ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 801559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8016ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8018f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 8019e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 80209f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8021593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8022f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8023e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8026593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 802783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 8028b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 803027e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 80319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_img_node, &pRegions[i], i, 80329ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "CmdCopyImageToBuffer"); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8034ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8035ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8037b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 803883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 804389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 804489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 804583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8048593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 80499f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8050ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8051ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8052b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 8053ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8054c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8055ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 805659b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8057ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8058e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8059f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8060e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80629f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8063593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 806483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 8065b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 8066ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8067ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 807083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 80725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 807489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 807589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 807683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8078b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8079593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 80809f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8081ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8082ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8083b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 8084ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8085c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8086ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 808759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 8088ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8090f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8091e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80939f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8094593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 809583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 8096b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 8097ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8098ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8100b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 810183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 81035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 810589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 810689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 810789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 810883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8110b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 811383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 81155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 81185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 81195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 81205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 812283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 812383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 812483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 812583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 812683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8128b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 81325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 8133ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 81345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 81355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 81375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 81385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 81391710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes if (attachment->colorAttachment >= pSD->colorAttachmentCount) { 814083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 814121a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 81431710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d; ignored", 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8146dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes else if (pSD->pColorAttachments[attachment->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { 8147dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes skip_call |= log_msg( 814821a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 8149dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 8150dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored", 8151dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes attachment->colorAttachment); 8152dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes } 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 81565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 81575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 815883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 815921a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 81617386605ae0fe78241c997605a843bdc9a5499e2bChris Forbes "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8166b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 816783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 817189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 817289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 817389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 817483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8176b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8178249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 81799f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8180249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8181249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8182b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearColorImage()"); 8183c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8184e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8185f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8186e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 81889f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8189593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 819083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 8191b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 8192249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8193249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8195b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 819683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 820089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 820189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 820289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 820389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 820483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8206b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8208249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 82099f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8210249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8211249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8212b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearDepthStencilImage()"); 8213c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8214e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8215f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8216e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8219593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 822083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 8221b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 8222249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8223249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8225b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 822683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 823189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 823289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 823389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 823483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8237593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 82389f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8239249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8240249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8241249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 8242b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdResolveImage()"); 8243b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdResolveImage()"); 8244249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 8245c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8246c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 8247e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8248f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdResolveImage()"); 8249593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 82509f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8251593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8252f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8253e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82559f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8256593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 825783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 8258b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 8259249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8260249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8262b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 826383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8268b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8269b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8270b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8271b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8272b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8273b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8274b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8275b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8276b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8277b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8278b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8279b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8280b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 828189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 828289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 828383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 828883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 828983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 8290ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8291ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8292ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8293ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8294ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8295ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8297c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8298c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8299c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8300b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8301b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8302b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8304b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 830583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 830989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 831089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 831183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 831683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 831783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 8318ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8319ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8320ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8321ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8322ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8323ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8325c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8326c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8327c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8328b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8329b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8330b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8332b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 833383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8337e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8338e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8341e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 836008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 836108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8380e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8402e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 840843986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8412577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 84176044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84306044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 84335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 84345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 84355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8441e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8443e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8482577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 84835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 84895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8496e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 8501ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 85106d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 85116d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 85146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 85175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 85185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8539b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8540b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8548b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 85651d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 85661d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 85686d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 85696d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 85706d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 85716d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 8574170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 8575170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 8576b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 8577b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 8578b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 8579b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 8586c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis auto aspect_mask = mem_barrier->subresourceRange.aspectMask; 8587c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_or_stencil(format)) { 8588c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_and_stencil(format)) { 8589c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) && !(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8590c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8591c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", 8592c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "%s: Image is a depth and stencil format and thus must " 8593c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have either one or both of VK_IMAGE_ASPECT_DEPTH_BIT and " 8594c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 8595c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8596c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8597c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else if (vk_format_is_depth_only(format)) { 8598c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT)) { 8599c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8600c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth-only format and thus must " 8601c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_DEPTH_BIT set.", 8602c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8603c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8604c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // stencil-only case 8605a968f468c0aafdf33b7af68fb8e7961e37e32f7fTobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8606c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8607c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a stencil-only format and thus must " 8608c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_STENCIL_BIT set.", 8609c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8610c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8611c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8612c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // image is a color format 8613c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT)) { 8614c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8615c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a color format and thus must " 8616c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_COLOR_BIT set.", 8617c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8618c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8620f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8621f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8622f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8623f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8631f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8632f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8633f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8634f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8657b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8659b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8665b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86688718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 86698718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 86700c6dd4dd7c7e444efc979299f8f445fb4fc4febeChris Forbes auto buffer_size = buffer_node->memSize; 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 867294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 867394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 867494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 8675414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 867694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 867794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 867994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 868094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8681414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 8682414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 868394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 868494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 868594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86922ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8693b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8694b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8695b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8696b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 86972ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8698b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8699b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8700b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 87012ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8702b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8703b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8704b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 87059556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 87069556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 8707b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 870827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 870927c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 87102ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8711b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 87129556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 8713b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8714b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8715b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8716c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 8717c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 8718c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 8719c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8720c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 87214261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 8722c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 8723c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 87244261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 8725c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 8726b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8727b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8728b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8729b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 873089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 873189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 873289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 873389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 873489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 873583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8737b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87402ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 8742ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, pEvents[i]); 8743ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8744ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8745ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 8746ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 8747ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8748ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 8749c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8752b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 87532ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8754b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 875683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 875883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 876083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 876183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8765b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 876683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 877289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 877389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 877489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 877589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 877689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 877783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8779b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 878283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 878383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 878483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8788b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 878983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8795d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 8796d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8797d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8798d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 8799d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 8800d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8801d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8802d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 8803d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 8804d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8805d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8806d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8807d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 880889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 880989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 881083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8812b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 882083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 8821ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8822ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8824b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 882583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 882989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 883083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8832b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 883783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8839414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8844c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8845d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 884783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 884983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8851ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8852ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 885583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 885989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 886089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 886183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8863b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 8869c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 8870d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 887383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 887583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 887783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 8878ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8879ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8881b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 888283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8886d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 8887d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 8888d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 8889d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8890d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 8891d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8892d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 8893d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 8894d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 8895d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 8896d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 8897d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 8898d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8899d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8900d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8901d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 8902d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 8903d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 8904d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8905d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8906d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 8907d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 8908d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8909d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8910d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8911d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8912d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8913d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8914d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8915d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8916d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8917d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8918d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8919d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 892089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 892189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 892289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 892383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8925b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8926ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 89279f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8928ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8929ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8930b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 8931ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8932c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8933ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 893459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8935ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8936e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8937f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8938e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 89409f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8941d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8942ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 8943ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 8944ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 8945ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 894783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8949b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 8950ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 8951ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 8952ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8953ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8955b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 895683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 896189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 896289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 896389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 896483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8966b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 897083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 897283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 897583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 89769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 897783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 897883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 89799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 89809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8981a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 89824a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 898315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 898415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 898515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 898615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 898715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 898815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 898915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 899015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 899115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 899215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 899315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 899415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 899515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 899615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 899715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 899815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 899915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 900015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 900115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 900215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 900315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 900415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 90059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 900615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 900715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 900815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 900915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 901015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 901115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 901215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 901315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 901415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 901515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 901615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 901715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 901815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 901915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 902015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 902115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 902215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 902315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 902415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 902515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 902615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 90279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 90289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 9029a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 903015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 903115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 903215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 903315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 903415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 903515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 9036a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 90379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 903815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 903915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 904015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 904115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 904215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 904315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 904415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 904515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9047b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 904883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 905289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 905389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 905483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9056b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 9060c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9061d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 906383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 906583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9068b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 906983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90736600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 90746600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 90756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 90766600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 90776600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 90786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 90796600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 90806600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 90816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 908279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, *image_view); 908379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_state) { 908479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, view_state->create_info.image)->createInfo; 90856600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 90866600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 90876600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 90886600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 90896600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 90906600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 90916600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 90926600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90936600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90946600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90956600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90976600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 90986600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 90996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 91006600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9101d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 9102d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 91035ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 91045ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 91055ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 91065ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 91075ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 91085ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 91096fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 9110d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 91116600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 91126600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9113d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis auto rp_node = getRenderPass(dev_data, pCreateInfo->renderPass); 9114d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rp_node) { 9115d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis const VkRenderPassCreateInfo *rpci = rp_node->pCreateInfo; 9116d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 9117d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 9118d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9119d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9120d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 9121d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 9122d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 91235ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 912441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 91255ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 91265ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 912779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_views[i]); 912879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto ivci = view_state->create_info; 912979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.format != rpci->pAttachments[i].format) { 91305ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 91315ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 91325ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 91335ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 91345ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 91355ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 913679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), 91375ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 91385ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 913979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci.image)->createInfo; 91405ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 914141ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 914241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 914341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 914441ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 914541ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 914641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 914741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 91485ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 91495ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 915079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.subresourceRange.levelCount != 1) { 91516fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 91526fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 91536fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 91546fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 915579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.levelCount); 91565ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 915779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; 9158aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 9159aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 916079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 9161aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 9162aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 91636fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9164aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9165aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 9166aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 9167aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 9168aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 9169aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 9170aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 9171aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 9172aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 917379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 917479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); 91755ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 917679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || 917779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || 917879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || 917979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { 9180da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 91816fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9182da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9183da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 9184da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 9185da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 9186da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 9187da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 9188da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 918979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), 919079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a)); 91915ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 91925ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9193d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 91945ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 91956600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 91966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 91976600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 91986600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 91996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 92006600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 92016600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 92026600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 92036600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 92046600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 92056600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 92066600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92076600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 9208d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 9209d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 9210d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9211d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9212d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 9213d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 92146600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92156fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 92166fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 92176fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 92186fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 92196fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 92206fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 92216fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 92226fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 92236fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 92246fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 92256fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 92266fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 92276fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 92286fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 92296fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 92306600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 92316600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 92326600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 923364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 923464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 923564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 923664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 923764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 923864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 9239d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 924064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 924164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 924264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 924354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 924454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 924554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 924676f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis std::unique_ptr<FRAMEBUFFER_NODE> fb_node( 9247d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis new FRAMEBUFFER_NODE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->pCreateInfo)); 924876f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 924954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 925054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 925179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, view); 925279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) { 925354e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 925454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 925554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 925679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.mem = getImageNode(dev_data, view_state->create_info.image)->mem; 925779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.image = view_state->create_info.image; 925876f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis fb_node->attachments.push_back(fb_info); 925954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 926076f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_node); 926154e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 926254e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 926389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 926489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 926589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 92665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 926764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 926864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 926964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 927064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 927164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 927264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 927364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 927464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 92756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 927764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 927854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 927954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9284e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 9285e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 9288e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 9295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9298e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9300e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 9304e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 9305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 93081d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 93157655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 93177655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 93187655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 9323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 9331e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 9337e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 9341e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 9351e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 9354e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9378f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 937916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 9380e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 938104861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 938216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 938316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 939779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state_i = getImageViewState(my_data, viewi); 939879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state_j = getImageViewState(my_data, viewj); 939979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state_i || !view_state_j) { 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 940279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_i = view_state_i->create_info; 940379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_j = view_state_j->create_info; 940479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 940979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto image_data_i = getImageNode(my_data, view_ci_i.image); 941079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto image_data_j = getImageNode(my_data, view_ci_j.image); 94116d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 94156d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 94325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 94335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 94411c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 94441c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 944793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 944893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 945693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 945793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94621c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94701c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 94711c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 94721c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 94731c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 94741c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 94751c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 94761c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 94771c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 948593fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 948693fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 948793fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 949293fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 949393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 949493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9514be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 9515be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 9516be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 9517be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 9518be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 9519be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 9520be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 9521be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 9522be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 9523be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 9524be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 9525be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 9526be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 9527be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9528be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 9529be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9530be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9531be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 9532be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9534e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9535e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 953777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 953877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 95420ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 95430ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 95440ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 95450ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 9546c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pColorAttachments[j].layout) { 9547c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 9548c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* This is ideal. */ 9549c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9550c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9551c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9552c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9553c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints? 9554c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9555c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9556c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9557c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9558c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 9559c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9560c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9561c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9562c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9563c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9564c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9565c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 9566c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pColorAttachments[j].layout)); 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9568c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 956977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 957077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, 957177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 957277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 957377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9575c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 9576cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes switch (subpass.pDepthStencilAttachment->layout) { 9577cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 9578cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9579cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* These are ideal. */ 9580cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9581cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9582cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9583cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9584cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * other constraints? GENERAL can be better than doing a bunch 9585cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * of transitions. 9586cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes */ 9587cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9588cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9590cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "GENERAL layout for depth attachment may not give optimal performance."); 9591cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9592cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9593cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes default: 9594cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* No other layouts are acceptable */ 9595cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9596cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9597cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9598cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " 9599cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", 96005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 96015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9602cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9603be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 960477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 960577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 960677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 960777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 960877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 960977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 961077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 961177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 961277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 961377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 961477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 9615c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pInputAttachments[j].layout) { 9616c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9617c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: 9618c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* These are ideal. */ 9619c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9620c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9621c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9622c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal. TODO: reconsider this warning based on 9623c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints. 9624c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9625c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9626c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9627c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9628c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 9629c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9630c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9631c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9632c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* No other layouts are acceptable */ 9633c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9634c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9635c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 9636c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pInputAttachments[j].layout)); 963777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 9638c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 963977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 964077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, 964177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 964277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 964377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9649e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9650e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 96575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9678918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 968089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 968189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 968289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9684e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9685b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9686b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 9687b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 9688b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 9689b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 9690b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9691b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 9692b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 9693b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 9694b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 9695b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 9696b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 9697b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9700b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 9701b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 9702b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9709b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9710918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 97164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 97174f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 97184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 97204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 97214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 97224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 97234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 97244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 97254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9726805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 9727805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 9728805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 9729805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 97304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 97314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 97324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 97334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 97344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 97354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 97364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 97384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 97394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 97404f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 97414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 97424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 97434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 97444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 97454f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 97464f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 97474f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 97484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 97494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 97506a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 97516a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 97526a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 97536a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 97546a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9755805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 9756805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 97574f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 97584f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 97594f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 97604f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 97614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 97626a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 97636a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 97646a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 97656a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 97666a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 97676a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 97686a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 97696a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 97706a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 97714f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 97724f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 97734f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 97746a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9775805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9776805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9777805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9778dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 9779dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 9780dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9781dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9782dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 9783dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 9784dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 9785dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 97866a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 97874f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9788dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 97894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 97904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 97914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 9792805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9793805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9794805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9795805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 97964f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9797dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 97984f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 97994f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 98004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 98014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9802805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9803805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 9804805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9805805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9806805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 9807805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 9808805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 9809805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 98104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 98114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 98124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 98134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 981489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 98154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 9816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 98194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 98204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 98214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 98224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 98234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 98244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 9825ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 98264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 98274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 98284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 98294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 98304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9831ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 9832ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 98344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 98354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 98364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 98374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 98384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 98394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9887cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 9888cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 988998cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 9890cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 9891cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 989287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 989387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 989487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 989587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 989687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 989787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 989887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 98991a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_load_op = desc.stencilLoadOp; 99001a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pass_info.stencil_store_op = desc.stencilStoreOp; 990187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 9902cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 990387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 990487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 9905cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 99066600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 990787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 990887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 990987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 99104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 99114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 99124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 99134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 99140d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 991587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 991687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 991787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 99184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 99194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 99204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 992124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 992287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9923a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9924a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 99254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 99264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 99274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 992824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9929a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 993087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 993187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 99324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski dev_data->renderPassMap[*pRenderPass] = render_pass; 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 99397bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes for (auto renderPass : my_data->renderPassMap) { 99407bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass.second->pCreateInfo; 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 99607bed8723272ee4550abc3d8691633e7a40a6271fChris Forbes delete renderPass.second; 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9965e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 9966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 996804861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 997679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_view); 997779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 997879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImage &image = view_state->create_info.image; 997979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9993c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 9994c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 99955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9997c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 9998c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 9999c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 10000c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 10001c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 10002c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 100031c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10011628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbesstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, 10012628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes FRAMEBUFFER_NODE *pFramebuffer, 10013628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes VkAttachmentReference ref) 10014628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes{ 10015628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 10016628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 10017628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 10018628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 10019628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 10020628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 1002127ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 10022e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 1002316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 1002416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1002616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10027e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 10028e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10030e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 1003116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10033628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 10036628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10038628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 10039628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10043e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 10044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10053f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 1005416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 1005516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 100565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1005716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 1005816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 10059e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 10060e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10062e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 10064628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 100665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10069e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 10070885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 1007104861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &getFramebuffer(my_data, pRenderPassBegin->framebuffer)->createInfo; 10072885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 10073885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 10074885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 10075885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 10076885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 10077885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10078885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 10079885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 10080885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 10081885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 10082885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 10083885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 10084885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 10085885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 10086885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 10087885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 100881a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 100891a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 100901a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 100911a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 10092a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 10093a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 10094a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 100951a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 100961a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 10097a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 10098a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 10099a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 101001a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 101011a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 1010289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1010389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 1010483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 101055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10106b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10107f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 1010816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 10109f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 10110f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 1011116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 101126de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 10113f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; 1011416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 10115f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 101161a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = renderPass->pCreateInfo->pAttachments[renderPass->attachments[i].attachment].format; 101171a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 101181a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 101191a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 1012092bc0680357019834b7529148ab6d73353ce02c7Mark Lobodzinski clear_op_size = static_cast<uint32_t>(i) + 1; 1012116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10122f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 1012316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1012416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10125f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 101261a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 101271a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 101281a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 1012916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10130f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 1013116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1013216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10133f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 101341a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, renderPass->attachments[i].load_op, 101351a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski renderPass->attachments[i].stencil_load_op, 101361a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 1013716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10138f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 10139f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1014016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10141f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 1014216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 1014316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 1014416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10145f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 10146f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1014716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10148f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101516de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 101526de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 101536de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 101546de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 101556de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 101566de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 101576de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 101586de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 101596de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 101606de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "attachments that aren't cleared they will be ignored.", 101616de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 101626de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis clear_op_size, clear_op_size - 1); 101633d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 1016483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 10165f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); 10166f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass"); 1016783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 10168f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass"); 10169f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 10170f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = renderPass; 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 10172f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; 10173f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = 0; 10174f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpassContents = contents; 10175f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); 101765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 10177f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis framebuffer->cb_bindings.insert(cb_node); 10178ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis for (auto attach : framebuffer->attachments) { 10179ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis auto img_node = getImageNode(dev_data, attach.image); 10180ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (img_node) { 10181ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis addCommandBufferBinding(&img_node->cb_bindings, 10182ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis {reinterpret_cast<uint64_t &>(attach.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}, 10183f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node); 10184ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis } 10185ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis } 10186ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 10187f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1018983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1019083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1019183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10194b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1019583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1020089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 1020183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10203b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 102045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 102055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 1020683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 1020783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 1020883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 1020980281691386b37385846f21b38e8c9d4b12cc74eChris Forbes 1021080281691386b37385846f21b38e8c9d4b12cc74eChris Forbes auto subpassCount = pCB->activeRenderPass->pCreateInfo->subpassCount; 1021180281691386b37385846f21b38e8c9d4b12cc74eChris Forbes if (pCB->activeSubpass == subpassCount - 1) { 1021280281691386b37385846f21b38e8c9d4b12cc74eChris Forbes skip_call |= 1021380281691386b37385846f21b38e8c9d4b12cc74eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1021480281691386b37385846f21b38e8c9d4b12cc74eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1021580281691386b37385846f21b38e8c9d4b12cc74eChris Forbes "vkCmdNextSubpass(): Attempted to advance beyond final subpass"); 1021680281691386b37385846f21b38e8c9d4b12cc74eChris Forbes } 102175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10218b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1021996ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1022096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (skip_call) 1022196ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes return; 1022296ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1022396ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 1022496ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1022596ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (pCB) { 1022696ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes lock.lock(); 1022796ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpass++; 1022896ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpassContents = contents; 1022996ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 1023096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes } 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1023389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 1023483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 102355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1023758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 1023858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 1023958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 10240e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 10241ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 1024202a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes if (pCB->activeSubpass != pRPNode->pCreateInfo->subpassCount - 1) { 1024302a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes skip_call |= 1024402a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1024502a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1024602a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes "vkCmdEndRenderPass(): Called before reaching final subpass"); 1024702a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes } 1024802a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes 1024987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 10250e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 102511a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VkFormat format = pRPNode->pCreateInfo->pAttachments[pRPNode->attachments[i].attachment].format; 102521a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 102531a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, VK_ATTACHMENT_STORE_OP_STORE)) { 1025458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10255f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 1025658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1025758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1025858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 102591a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski } else if (FormatSpecificLoadAndStoreOpSettings(format, pRPNode->attachments[i].store_op, 102601a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski pRPNode->attachments[i].stencil_store_op, 102611a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 1026258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10263f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 1026458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1026558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1026658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1027083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 1027183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 1027283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 102730e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes } 102740e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.unlock(); 102750e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 102760e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (skip_call) 102770e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes return; 102780e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 102790e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 102800e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 102810e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (pCB) { 102820e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.lock(); 10283f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 1028458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 1028558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 1028658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10290a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 10291a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10294a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 10295a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 10296a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 10297a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10300a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10301a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 10302a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 10303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 103045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10305a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 103065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 103075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10308a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 10315a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10316a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 10320a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10321a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10324a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 10325a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10326a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10328a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 10329a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10330a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10332a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 10333a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10334a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10339a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10340a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10341a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10343a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 10344a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 103455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 103485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 103495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 103505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 103525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10354a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 10355a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10366a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 10367a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 103685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 103695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 103705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 103715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10375a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 10376a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 103795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10385a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 10386a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10390a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 10391a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 10392a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 10393a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10394a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10395a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10397a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 10398a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10401a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 10402a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 10403a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 10404a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 10405a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 10406a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 10407a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 10408a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 10409a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 10410a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10415e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 10416e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10421c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104261af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 104271af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 104281af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " which has a framebuffer 0x%" PRIx64 104291af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " that is not the same as the primaryCB's current active framebuffer 0x%" PRIx64 ".", 104301af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), 104311af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(primary_fb)); 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10433e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 10434e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10437414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10438414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10442a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto cb_renderpass = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 10443a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 10444a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 10445a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis cb_renderpass->pCreateInfo); 10446a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 1045283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 1046183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10464414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10465414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 1047683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10479414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10480414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 10481414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104867bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 104877bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 104887bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); 104897bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { 104907bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 104917bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 104927bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIxLEAST64 104937bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d has secondary command buffer 0x%" PRIxLEAST64 " created in queue family %d.", 104947bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), primary_pool->queueFamilyIndex, 104957bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), secondary_pool->queueFamilyIndex); 104967bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 104977bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 1049883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1050189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1050289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 1050383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10505b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 1051283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10515414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 1051883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 1051983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 1052083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 1052183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 1052283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 105235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 10524a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto secondary_rp_node = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 1052683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 10529414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 10531ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 10534a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) { 1053583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->pCreateInfo, 10536a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis pCommandBuffers[i], secondary_rp_node->pCreateInfo); 10537a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 105381af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB 1053983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 105421af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass 10543a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) && 10544a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->pCreateInfo, secondary_rp_node->pCreateInfo, 10545a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 1054683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 10549414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 10550414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 10552ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 1055683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 1055783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB); 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 1056283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10565414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 1057183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10574414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 10576414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 1057783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10582b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 1058383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 10587414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 10595d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine for (auto &function : pSubCB->queryUpdates) { 10596d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine pCB->queryUpdates.push_back(function); 10597d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine } 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1059983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 1060083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10602b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1060383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10607b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis// For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL 10608cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, 10609623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis VkDeviceSize end_offset) { 10610e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10612cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // Iterate over all bound image ranges and verify that for any that overlap the 10613cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL 10614cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range 10615cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto image_handle : mem_info->bound_images) { 10616cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis auto img_it = mem_info->bound_ranges.find(image_handle); 10617cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (img_it != mem_info->bound_ranges.end()) { 10618623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { 10619b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis std::vector<VkImageLayout> layouts; 10620825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { 10621b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis for (auto layout : layouts) { 10622b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 10623b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis skip_call |= 10624b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 10625b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 10626b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 10627b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis string_VkImageLayout(layout)); 10628b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10629b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10630b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10631b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10632b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1063789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1063889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10641e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10643b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10644cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 10645cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (mem_info) { 10646f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis // TODO : This could me more fine-grained to track just region that is valid 10647f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis mem_info->global_valid = true; 10648623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; 10649623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); 10650cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : Do we need to create new "bound_range" for the mapped range? 10651623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis SetMemRangesValid(dev_data, mem_info, offset, end_offset); 10652cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & 10653b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 10657414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10660f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); 10661b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10663e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 106657c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 106667c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 10667cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this 106687c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 106695f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski initializeAndTrackMemory(dev_data, mem, offset, size, ppData); 106707c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 106717c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1067689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1067883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10680b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1068183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= deleteMemRanges(my_data, mem); 10682b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1068383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10689e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1069083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1069257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1069357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 10694de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.offset > pMemRanges[i].offset) { 1069583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1069657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1069757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1069857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1069957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 10700de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->mem_range.offset)); 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107024b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 10703de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis const uint64_t my_dataTerminus = (mem_info->mem_range.size == VK_WHOLE_SIZE) 10704de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis ? mem_info->alloc_info.allocationSize 10705de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis : (mem_info->mem_range.offset + mem_info->mem_range.size); 107064b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 1070783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1070883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1070983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1071083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER ") exceeds the Memory Object's upper-bound " 1071183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 1071283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), static_cast<size_t>(my_dataTerminus)); 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1071683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107199e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinskistatic bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1072183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1072357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1072457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 107255f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 107265f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 107275f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 107285f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - pMemRanges[i].offset); 107295f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 107305f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1073283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1073383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1073483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 107355f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107385f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1074083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1074183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1074283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1074383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107465f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1075083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107535f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void CopyNoncoherentMemoryFromDriver(layer_data *my_data, uint32_t memory_range_count, 107545f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski const VkMappedMemoryRange *mem_ranges) { 107559e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski for (uint32_t i = 0; i < memory_range_count; ++i) { 107569e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski auto mem_info = getMemObjInfo(my_data, mem_ranges[i].memory); 107575f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info && mem_info->shadow_copy) { 107585f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 107595f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 107605f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); 107615f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 107625f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); 107639e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 107649e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 107659e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski} 107669e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski 1076789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1076889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1077083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 107725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10773b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 107749e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski skip_call |= ValidateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 1077583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10776b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1077783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1078389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1078489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1078683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10789b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1079083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10791b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1079283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 107935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 107949e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski // Update our shadow copy with modified driver data 107959e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski CopyNoncoherentMemoryFromDriver(my_data, memRangeCount, pMemRanges); 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1080089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1080383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 10804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 108056d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 108066d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 1080794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1080847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 1080983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10811b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1081294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10813b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1081447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1081547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1081657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1081757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 108189f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, memRequirements, 10819825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis image_node->createInfo.tiling == VK_IMAGE_TILING_LINEAR); 1082083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1082147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1082247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 108230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10824b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1082583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 1082694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10827b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 108286d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 108296d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 108306d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 10831b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1083294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1083394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1083494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1083594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 10836414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1083794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 108385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1084289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 108433ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 108443ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 108455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10846b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 108479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 108489556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 108499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->needsSignaled = false; 108509556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 108519556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node->write_in_use) { 108523ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 108533ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10854414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 108553ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 108563ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 108573ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10858b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 108596fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 108606fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 108616fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 108626fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 108636fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 108646fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 108656fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 108666fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 108676fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 108683ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 108693ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 108705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1087489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 108755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10878b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10879651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 10880651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 10881651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 108824b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 10883651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 10884651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 108859867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 108869867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, bindInfoCount); 108874b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 10888651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 108891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 108901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 108915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 108921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 108931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 108941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 108951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 108965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10897e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 108985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 109011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 109021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 109031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 109045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10905e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 109065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 109091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 109101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 109111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 109125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 109145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109169867daedbf52debc77d6568162ee21e071699b80Chris Forbes 109179867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT> semaphore_waits; 109189867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore> semaphore_signals; 109191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1092001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1092101a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1092201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1092301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 109249867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 109259867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 109269867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 109279867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 109289867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 1092901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 109301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 109311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 109325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 109331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10934414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 109351344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 109361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 109375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1094101a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1094201a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1094301a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1094401a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 109455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 109465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 109471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10948414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 109491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 109501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 109515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109529867daedbf52debc77d6568162ee21e071699b80Chris Forbes else { 109539867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 109549867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 109559867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaled = true; 109569867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 109579867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 109589867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 109595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109619867daedbf52debc77d6568162ee21e071699b80Chris Forbes 109629867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 109639867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits, 109649867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals, 109659867daedbf52debc77d6568162ee21e071699b80Chris Forbes bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); 109665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109679867daedbf52debc77d6568162ee21e071699b80Chris Forbes 109689867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !bindInfoCount) { 109699867daedbf52debc77d6568162ee21e071699b80Chris Forbes // No work to do, just dropping a fence in the queue by itself. 109709867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 109719867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 109729867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 109739867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 109749867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 109759867daedbf52debc77d6568162ee21e071699b80Chris Forbes 109760a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10977b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 109785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10979e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 109805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 109815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1098589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1098689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 109875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 109885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 109895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 10990b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 109915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 109929867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.first = VK_NULL_HANDLE; 109939867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.second = 0; 109941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 109955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1100089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 110015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 110035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11004b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 110055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 11006293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 110075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 110085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1101289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1101389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1101489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 110155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 110175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 11019b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 110203f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 110215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1102689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1102789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 110285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1102983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 110305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11031b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11032b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11033b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 11034b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 11035b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 110365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 110375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 110385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 110395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 110405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 110415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 110425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 110455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1104683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 1104783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis clear_object_binding(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1104894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 110495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 110525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11053b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1105483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 110555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 110565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1105889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1105989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 110605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 110625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 110645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 110655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 110665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 11067b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 110685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 11069b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 11070b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 110710801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 110720801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 110730801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 110745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 110755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 110765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 110775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 11078414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 110795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 110805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 110815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 110845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 110855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 110865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 110876d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 110886d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 110896d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 110906d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 110916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 110926d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1109341ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 110946d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 110956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 110966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 1109729e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pSwapchainImages[i], &image_ci)); 1109894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 110996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 111006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 111015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 111025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 111035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 111045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 111055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 111065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1111189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 111125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 111135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 111145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111156c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 111166c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 111176c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 111186c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 111196c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 111206c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 111216c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 111226c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 111236c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 111245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111256c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 11126249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 111276c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 111286c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 111296c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (swapchain_data && pPresentInfo->pImageIndices[i] < swapchain_data->images.size()) { 111306c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkImage image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 11131f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis skip_call |= ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, image), "vkQueuePresentKHR()"); 111326c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes vector<VkImageLayout> layouts; 111336c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (FindLayouts(dev_data, image, layouts)) { 111346c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (auto layout : layouts) { 111356c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 111366c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 111375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 111385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 111395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 11140e8f1d00379587293d46b993a598f519d07b77f37Karl Schultz "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s", 111415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 111425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111486c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 111496c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 111506c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 111516c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 111526c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 111536c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 111546c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 111556c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 111566c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 111576c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 111586c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 111599867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore) { 111609867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 111616c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 111626c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 111636c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 111649867daedbf52debc77d6568162ee21e071699b80Chris Forbes 111659867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Note: even though presentation is directed to a queue, there is no 111669867daedbf52debc77d6568162ee21e071699b80Chris Forbes // direct ordering between QP and subsequent work, so QP (and its 111679867daedbf52debc77d6568162ee21e071699b80Chris Forbes // semaphore waits) /never/ participate in any completion proof. 111686c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 111691344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 111705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11173c827a5880dc3fabfc7d1a58bb62798649cab1181Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, 11174c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkSwapchainCreateInfoKHR *pCreateInfos, 11175c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { 11176c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11177c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young std::unique_lock<std::mutex> lock(global_lock); 11178c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young VkResult result = 11179c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_dispatch_table->CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); 11180c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return result; 11181c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young} 11182c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1118389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1118489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 111855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1118683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 111871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 11188b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11189f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 11190f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1119183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1119283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1119383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 111945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11195f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11196f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 11197f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1119883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 111995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11200b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 112011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1120283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 11203f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11204f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11205f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 112065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 11207f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11208f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 11209f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 11210f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 11211f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 112129867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. 11213f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11214f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11215f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 11216f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 11217f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 112189867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 11219f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 112205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11221f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 112221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 112235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11226f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 11227f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1122883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 11229f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 11230f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (my_data->instance_state) { 11231f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 11232f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11233f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 11234f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11235f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (UNCALLED == my_data->instance_state->vkEnumeratePhysicalDevicesState) { 11236f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 11237f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 1123883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 11239f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11240f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 11241f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 11242f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 11243cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else if (my_data->instance_state->physical_devices_count != *pPhysicalDeviceCount) { 11244f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 1124583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11246f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11247f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 11248f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "supported by this instance is %u.", 11249cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pPhysicalDeviceCount, my_data->instance_state->physical_devices_count); 11250f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11251f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 11252f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1125383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 11254f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11255f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11256f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkResult result = 11257f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 11258f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11259cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski my_data->instance_state->physical_devices_count = *pPhysicalDeviceCount; 112605f270eedee8426a5b556a8a9432dd836d83f7b51Tony Barbour } else if (result == VK_SUCCESS){ // Save physical devices 11261f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 11262f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(pPhysicalDevices[i]), layer_data_map); 11263cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state = unique_ptr<PHYSICAL_DEVICE_STATE>(new PHYSICAL_DEVICE_STATE()); 11264f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 11265f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski my_data->instance_dispatch_table->GetPhysicalDeviceFeatures(pPhysicalDevices[i], 11266f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski &phy_dev_data->physical_device_features); 11267f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11268f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11269f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 11270f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11271f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 11272f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 11273f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 11274f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11275f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11276f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 11277f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 11278cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 11279cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 11280cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 11281cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 11282cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); 11283cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state) { 11284cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 11285cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 11286cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11287cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11288cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 11289cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 11290cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (UNCALLED == phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 11291cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11292cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11293cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 11294cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 11295cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 11296cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11297cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 11298cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (phy_dev_data->physical_device_state->queueFamilyPropertiesCount != *pCount) { 11299cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11300cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 11301cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 11302cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11303cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11304cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 11305cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 11306cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski *pCount, phy_dev_data->physical_device_state->queueFamilyPropertiesCount); 11307cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11308cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 11309cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11310cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 11311cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11312cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11313cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, 11314cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski pQueueFamilyProperties); 11315cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (NULL == pQueueFamilyProperties) { 11316cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->physical_device_state->queueFamilyPropertiesCount = *pCount; 11317cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11318cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 11319cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.reserve(*pCount); 11320cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 11321cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.emplace_back(new VkQueueFamilyProperties(pQueueFamilyProperties[i])); 11322cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11323cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11324cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11325cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11326cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11327cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 11328cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 11329cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 11330cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 11331cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11332cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 11333cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 1133489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1133589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1133689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 113375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 113385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 113395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 113405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 11341b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 11342c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 113435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 113445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 113455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1134789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1134889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1134989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 113505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 113515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 113525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11353b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 113545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 113555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1135789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1135889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1135989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 113605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 113615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 113625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 113635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11365a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11366a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11367a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11368a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11369a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11370a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11371a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11372a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11373a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11374a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11375a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11376a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11377a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 11378a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 11379a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11380a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 11381a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11382a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1138389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1138489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1138589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 11386a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1138708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 11388a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11389a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 11390a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11391a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 11392a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 11393a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1139408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1139508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1139680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 113977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 113987ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 113997ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1140080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1140180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1140209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1140309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1140409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1140589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1140680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1140780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1140880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1140980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1141080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 114115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1141209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1141309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1141409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1141509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 114165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 114175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 114185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 114205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 114215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 114225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 114235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 114245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1142789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 114287ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 114293f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 114303f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 114313f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 114323f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 114337ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 114347ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 114355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114367ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 114375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 114395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 114407ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 114417ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 114427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 114435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 114445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 114455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 114465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 114475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 114485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1144908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1145080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 114517ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 114527ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 114537ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 114547ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 114557ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 114567ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 114577ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 114587ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 114597ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 11460f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 11461cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 114627ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 11463a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 11464a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 11465a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 114667ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 114677ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 114687ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 114697ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 114707ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 114717ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 114727ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 114737ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 114747ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 114757ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 114767ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 114777ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1147880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1147980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1148080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1148180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1148280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 11483593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 11484593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 11485593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 11486593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 11487593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 11488593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 11489593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 11490593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 11491593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 11492593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 11493593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 11494593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 11495593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 11496593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 11497593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 11498593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 11499593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 11500593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 11501593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 11502593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 11503593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 11504593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 11505593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 11506593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 11507593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 11508593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 11509593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 11510593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 11511593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 11512593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 11513593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 11514593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 11515593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 11516593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 11517593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 11518593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 11519593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 11520593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 11521593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 11522593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 11523593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 11524593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 11525593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 11526593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 11527593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 11528593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 11529593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 11530593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 11531593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 11532593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 11533593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 11534593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 11535593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 11536593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 11537593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 11538593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 11539593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 11540593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 11541593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 11542593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 11543593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 11544593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 11545593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 11546593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 11547593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 11548593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 11549593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 11550593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 11551593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 11552593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 11553593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 11554593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 11555593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 11556593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 11557593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 11558593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 11559593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 11560593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 11561593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 11562593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 11563593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 11564593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 11565593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 11566593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 11567593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 11568593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 11569593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 11570593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 11571593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 11572593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 11573593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 11574593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 11575593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 11576593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 11577593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 11578593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 11579593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 11580593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 11581593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 11582593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 11583593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 11584593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 11585593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 11586593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 11587593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 11588593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 11589593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 11590593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 11591593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 11592593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 11593593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 11594593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 11595593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 11596593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 11597593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 11598593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1159980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1160080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1160180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1160280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1160380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1160480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1160580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1160680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1160780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1160880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1160909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1161009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1161109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1161209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1161309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1161409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1161509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1161609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1161709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1161809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1161909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1162009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 11621c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = nullptr; 1162209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 116233f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 11624c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 116253f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 116263f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 116273f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1162809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1162909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1163009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1163109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1163209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1163309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11634c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (dev_data) { 11635c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!dev_data->device_extensions.wsi_display_swapchain_enabled) 11636c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return nullptr; 11637c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young } 11638c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 11639c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!strcmp("vkCreateSharedSwapchainsKHR", name)) 11640c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); 11641c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1164209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1164309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1164409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11645d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 11646d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11647d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 11648d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11649d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11650d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 11651d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1165289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 11653d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11654d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11655d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11656d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 11657d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 11658d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1165989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11660d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11661d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11662d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11663d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 11664d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1166589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 11666d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11667d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11668a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 11669d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1167008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1167108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11672a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1167308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1167408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1167508939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1167608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11677a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1167808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1167908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1168008939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1168108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11682a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11683a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11684a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 11685d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11686d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11687d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 11688d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 11689d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 11690a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11691a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11692a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 11693d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11694d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11695d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1169689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 11697d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11698d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11699d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1170089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1170108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 11702