core_validation.cpp revision 3da84689683bb257cc0f64953966666d19321119
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 65b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Permission is hereby granted, free of charge, to any person obtaining a copy 75b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * of this software and/or associated documentation files (the "Materials"), to 85b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * deal in the Materials without restriction, including without limitation the 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or 105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sell copies of the Materials, and to permit persons to whom the Materials 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are furnished to do so, subject to the following conditions: 125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * The above copyright notice(s) and this permission notice shall be included 145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * in all copies or substantial portions of the Materials. 155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE MATERIALS OR THE 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * USE OR OTHER DEALINGS IN THE MATERIALS 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 4194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 4294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 4394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 4694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 5094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_map> 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_set> 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_config.h" 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_logging.h" 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 85b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 94e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 11094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis uint64_t currentFenceId; 111b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, SET_NODE *> setMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSetLayout, LAYOUT_NODE *> descriptorSetLayoutMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 138918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1396c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 142b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 143b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 144b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 14694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 147dcf917f7e9b04916caf3f7bb067f7f760d0daa99Chris Forbes currentFenceId(1), device(VK_NULL_HANDLE), phys_dev_properties{}, 148b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis phys_dev_mem_props{} {}; 1495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 151b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 152b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_global_layers[] = {{ 155f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(createInfo.ppEnabledLayerNames[i], cv_global_layers[0].layerName)) { 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cv_global_layers[0].layerName); 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t len() { return *it >> 16; } 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t const &word(unsigned n) { return it[n]; } 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int globalLockInitialized = 0; 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic loader_platform_thread_mutex globalLock; 24403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 24503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 24694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 24994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 25094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 25194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 25594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 25694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 25794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate layer_data *get_my_data_ptr<layer_data>(void *data_key, std::unordered_map<void *, layer_data *> &data_map); 2685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 27072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *, const VkCommandBuffer); 27172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 27203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add a fence, creating one if necessary to our list of fences/fenceIds 274e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool add_fence_info(layer_data *my_data, VkFence fence, VkQueue queue, uint64_t *fenceId) { 275e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *fenceId = my_data->currentFenceId++; 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no fence, create an internal fence to track the submissions 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].fenceId = *fenceId; 2815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].queue = queue; 2825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that fence is in UNSIGNALED state 2835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFenceCreateInfo *pFenceCI = &(my_data->fenceMap[fence].createInfo); 2845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceCI->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence); 2895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 2915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Do we need to create an internal fence here for tracking purposes? 2925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update most recently submitted fence and fenceId for Queue 2945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap[queue].lastSubmittedId = *fenceId; 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Record information when a fence is known to be signalled 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void update_fence_tracking(layer_data *my_data, VkFence fence) { 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = my_data->fenceMap.find(fence); 3015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != my_data->fenceMap.end()) { 3025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pCurFenceInfo = &(*fence_item).second; 3035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue queue = pCurFenceInfo->queue; 3045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_item = my_data->queueMap.find(queue); 3055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_item != my_data->queueMap.end()) { 3065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*queue_item).second; 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pQueueInfo->lastRetiredId < pCurFenceInfo->fenceId) { 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pCurFenceInfo->fenceId; 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update fence state in fenceCreateInfo structure 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFCI = &(my_data->fenceMap[fence].createInfo); 3155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFCI->flags = static_cast<VkFenceCreateFlags>(pFCI->flags | VK_FENCE_CREATE_SIGNALED_BIT); 3165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates the fence list for a specific queue to all-retired 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_queue_fences(layer_data *my_data, VkQueue queue) { 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates all queues to all-retired 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_device_fences(layer_data *my_data, VkDevice device) { 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process each queue for device 3285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add multiple device support 3295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->queueMap.begin(); ii != my_data->queueMap.end(); ++ii) { 3305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*ii).second; 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3420a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 344e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s %#" PRIxLEAST64 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 36294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 363e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 36594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 3660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3750a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 37694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 37994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 38858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 38958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 39058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 3915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 40658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 414e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 415e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 41794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 41894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 41958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid swapchain image %" PRIx64 ", please fill the memory before using.", 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 42758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid memory %" PRIx64 ", please fill the memory before using.", functionName, 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 43894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 43994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 44094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 452e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 453e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 454e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 46058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 462de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 46472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 46672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 467c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 473400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 474400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 47572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 476c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 477c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 47820b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 480400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 483c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 488400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 489400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 490400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 496de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 497896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 499de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 50058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory object %#" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 507de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 508de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 50958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 510de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 511de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes "Command Buffer %p still has a reference to mem obj %#" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 514de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 517896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 518896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 519896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_FREED_MEM_REF, "MEM", "VK Object %#" PRIxLEAST64 " still has a reference to mem obj %#" PRIxLEAST64, 521896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 524896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 530e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 5325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Request to delete memory object %#" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check if fence for given CB is completed 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkCBCompleted(layer_data *my_data, const VkCommandBuffer cb, bool *complete) { 54472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(my_data, cb); 545e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = true; 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 54972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->lastSubmittedQueue != NULL) { 55072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkQueue queue = pCBNode->lastSubmittedQueue; 5515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 55272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->fenceId > pQueueInfo->lastRetiredId) { 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)cb, __LINE__, MEMTRACK_NONE, "MEM", 5555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "fence %#" PRIxLEAST64 " for CB %p has not been checked for completion", 55672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCBNode->lastSubmittedFence, cb); 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = false; 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 565e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 56758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 57158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory associated with a Persistent Image, %#" PRIxLEAST64 ", " 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 581de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 582de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 583de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 584de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 585de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 586de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes bool commandBufferComplete = false; 587de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes skipCall |= checkCBCompleted(dev_data, cb, &commandBufferComplete); 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (commandBufferComplete) { 589de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 594de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 59558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 59858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 619c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 623e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 62594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 62694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 6275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 62894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 630c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 632896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 6335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 6355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj %#" PRIxLEAST64 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", unable to find that object referenced by mem obj %#" PRIxLEAST64, 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 64994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 65094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 651e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 65558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(%#" PRIxLEAST64 ") to NULL", apiName, handle); 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 65994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 6605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 66158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 6624f085d96e1f9ba7cba58b480ae64a8546c9a00eeChris Forbes "MEM", "In %s, attempting to update Binding of %s Obj(%#" PRIxLEAST64 ") that's not in global list", 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 66658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 66894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 6705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 6735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to bind memory (%#" PRIxLEAST64 ") to object (%#" PRIxLEAST64 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") which has already been bound to mem object %#" PRIxLEAST64, 6755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 677896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemInfo->objBindings.insert({handle, type}); 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 6795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 68194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 68294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 68394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 68494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 68594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // TODO:: More memory state transition stuff. 68694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 7005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 7015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 7020a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 7030a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 7040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 7050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 71094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 71194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 71358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to update Binding of Obj(%#" PRIxLEAST64 ") that's not in global list()", apiName, handle); 71594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 71694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // non-null case so should have real mem obj 71794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 71894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pInfo) { 71994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis pInfo->objBindings.insert({handle, type}); 72094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Need to set mem binding for this object 72194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 72294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 7290a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 73094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 73394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 73494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 73594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 7385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but no such object in %s list", handle, 7395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 7450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 74658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 74958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 75458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 75658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 75758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at %p===", (void *)pInfo); 76858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: %#" PRIxLEAST64, (uint64_t)(pInfo->mem)); 77058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 771c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 772de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 77558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 784896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 785896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 786896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 78758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 788896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT %" PRIu64, obj.handle); 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 795de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 796de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 797de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 79858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 799de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB %p", cb); 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 80672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 81472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 81572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 82372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " CB Info (%p) has CB %p, fenceId %" PRIx64 ", and fence %#" PRIxLEAST64, 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCBInfo, (void *)pCBInfo->commandBuffer, pCBInfo->fenceId, (uint64_t)pCBInfo->lastSubmittedFence); 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 829c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 831c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 833c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Mem obj %" PRIu64, (uint64_t)obj); 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) { 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t *words = (uint32_t *)pCreateInfo->pCode; 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Just validate that the header makes sense. */ 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10729ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 10799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 10829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 10859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 10889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 10919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 10929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 10959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 10969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10979ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 11009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 11019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 11039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 11059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 11069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11159ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11209ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 11239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 11269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11319ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11329ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 113837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 113937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 114037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 114137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 114237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 114337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 114437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 114537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 114637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11537c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 115437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 11557c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11567c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 115937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 116037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 116137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 116237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 116337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 11645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11707c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 11717c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 117237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 11737c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11747c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11757c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 11767c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 11777c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 11787c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11797c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11827c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 11857c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 11887c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 119037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 119137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 119237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 119337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 119437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 119537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 119637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 119737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 119837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 120037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 120137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 120637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 121637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1273b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1277031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1278031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1279031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1280031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1281031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1282031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1283031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1284031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1285031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1286031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1287031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1288031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1289031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1290031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13076c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_block_members(layer_data *my_data, shader_module const *src, 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1310b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1312031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1350b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13586c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_location(layer_data *my_data, shader_module const *src, spirv_inst_iter entrypoint, 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1365b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1388b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1389b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1390b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1391b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 139781264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1402c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14131d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1420b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 14315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 14337c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1439b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1444b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes collect_interface_block_members(my_data, src, out, blocks, is_array_of_verts, id, type, is_patch); 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14506c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_descriptor_slot(layer_data *my_data, shader_module const *src, 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 14555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1484080afef66a53dbdd085698b713697296458edfd9Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1494b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1495b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15016c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_interface_between_stages(layer_data *my_data, shader_module const *producer, 1502031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1504031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1510031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1511031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1524080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1525080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1526031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1527031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1532080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1534031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1535031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 15400f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1541031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch, 154237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch, 154337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1544080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 15469ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 15479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 15489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15520f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 15530f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 15540f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1555f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 15560f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 15570f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 15580f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 15590f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 15600f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15610f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16496c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_consistency(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi) { 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1660080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16736c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_against_vs_inputs(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi, 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16786c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, vs, entrypoint, spv::StorageClassInput, inputs, false); 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) 16845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attribs[vi->pVertexAttributeDescriptions[i].location] = &vi->pVertexAttributeDescriptions[i]; 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1696080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1697080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1715080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 17189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 17199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17336c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_fs_outputs_against_render_pass(layer_data *my_data, shader_module const *fs, 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17416c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, fs, entrypoint, spv::StorageClassOutput, outputs, false); 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = outputs.begin(); 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = 0; 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk attachment list and outputs together -- this is a little overpowered since attachments 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are currently dense, but the parallel with matching between shader stages is nice. 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == color_formats.size() || (it != outputs.end() && it->first.first < attachment)) { 1752080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "FS writes to output location %d with no matching attachment", it->first.first)) { 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (it == outputs.end() || it->first.first > attachment) { 1759080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", attachment)) { 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned output_type = get_fundamental_type(fs, it->second.type_id); 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned att_type = get_format_type(color_formats[attachment]); 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1770080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d of type `%s` does not match FS output type of `%s`", attachment, 17739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(color_formats[attachment]), 17749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(fs, it->second.type_id).c_str())) { 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 180881264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1888c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1894c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19056c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_block_against_pipeline(layer_data *my_data, 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1931080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1932080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1945080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1946080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19606c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_usage(layer_data *my_data, 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1968080afef66a53dbdd085698b713697296458edfd9Chris Forbes pass &= validate_push_constant_block_against_pipeline(my_data, pushConstantRanges, src, 1969080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipelineLayout verify that the setLayout at slot.first 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// has the requested binding at slot.second 197878be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(layer_data *my_data, PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 198137083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 198378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 198437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 198678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto const layout_node = my_data->descriptorSetLayoutMap[pipelineLayout->descriptorSetLayouts[slot.first]]; 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingIt = layout_node->bindingToIndexMap.find(slot.second); 198914fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis if ((bindingIt == layout_node->bindingToIndexMap.end()) || (layout_node->createInfo.pBindings == NULL)) 199037083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 199214fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis assert(bindingIt->second < layout_node->createInfo.bindingCount); 199337083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return &layout_node->createInfo.pBindings[bindingIt->second]; 19945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 20035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2008e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2010e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2014e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2015e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 20163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 20173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 20183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 20193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2021e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 20255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *getPipeline(layer_data *my_data, const VkPipeline pipeline) { 20265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->pipelineMap[pipeline]; 20305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2033e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2040e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2045e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20463d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2050ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2051ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2052ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 205645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 205745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 20623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 20643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 206545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 206645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 20673d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 20693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 207045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 207145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 20723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 20743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 20763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 20783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 20803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 20833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 209706e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 209806e963555b0df747c98c43816c16647349d21001Mark Young return true; 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 210006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 210106e963555b0df747c98c43816c16647349d21001Mark Young return true; 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 2117c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 2122c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2134c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2150c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2158c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2164fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2165fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2166fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2167fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2168fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2169c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2170fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2171fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2172fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2173fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2174fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2182c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const SET_NODE *pSet, const VkPipelineLayout layout, 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t layoutIndex, string &errorMsg) { 2195ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2196ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 2197c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 21995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2202ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2203c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2204ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2205ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get the specific setLayout from PipelineLayout that overlaps this set 2211ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes LAYOUT_NODE *pLayoutNode = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t descriptorCount = pLayoutNode->descriptorTypes.size(); 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { 2217c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors."; 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; // trivial fail case 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now need to check set against corresponding pipelineLayout to verify compatibility 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (size_t i = 0; i < descriptorCount; ++i) { 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to verify that layouts are identically defined 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // do we also need to check immutable samplers? 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { 2230c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "descriptor " << i << " for descriptorSet being bound is type '" 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout is type '" 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; 22355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { 2239c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 22405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2250e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_specialization_offsets(layer_data *my_data, VkPipelineShaderStageCreateInfo const *info) { 2251e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2266e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool descriptor_type_match(layer_data *my_data, shader_module const *module, uint32_t type_id, 22761b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22791b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 22801b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 22817b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 22827b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 22847b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 22857b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 22867b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 22877b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22887b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 22897b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 22907b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 231535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 231635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 231735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 231835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 231935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 232035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 232135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 232235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 232335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 232435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 23255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool require_feature(layer_data *my_data, VkBool32 feature, char const *feature_name) { 2360a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 2361080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2362080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2363a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2364a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2365a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2366a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2367a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2368a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2369a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2370a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2371a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2372a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2373e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_shader_capabilities(layer_data *my_data, shader_module const *src) { 2374e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2375a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2376b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto enabledFeatures = &my_data->phys_dev_properties.features; 2377a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2378a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2379a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2380a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2381a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2382a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2383a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2384a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2385a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2386a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2387a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2388a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2389a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2390a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2391a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2392a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->geometryShader, "geometryShader"); 2395a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->tessellationShader, "tessellationShader"); 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderInt64, "shaderInt64"); 2407a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2432a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2436a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2450a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2463a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2467a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 2468a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2469a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 2472a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2473a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageExtendedFormats, 2477a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 2481a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2492a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->multiViewport, "multiViewport"); 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 2499080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2500a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2504a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2505a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2510a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2512e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_pipeline_shader_stage(layer_data *dev_data, VkPipelineShaderStageCreateInfo const *pStage, 2513e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves PIPELINE_NODE *pipeline, PIPELINE_LAYOUT_NODE *pipelineLayout, 2514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves shader_module **out_module, spirv_inst_iter *out_entrypoint) { 2515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 251678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto module = *out_module = dev_data->shaderModuleMap[pStage->module].get(); 251778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_specialization_offsets(dev_data, pStage); 251878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 251978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 252078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 252178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2522080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2523080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 252478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 252578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2526e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 252778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 252878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 252978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 253178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_shader_capabilities(dev_data, module); 253278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 253478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 253578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 253678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 253878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 253978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes collect_interface_by_descriptor_slot(dev_data, module, accessible_ids, descriptor_uses); 254078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 254278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_push_constant_usage(dev_data, &pipelineLayout->pushConstantRanges, 254378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 254478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 254678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 254778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 254878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 254978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the matching binding */ 255178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto binding = get_descriptor_binding(dev_data, pipelineLayout, use.first); 255278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 255378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2555080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2556080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 255778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 255878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 256078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 256278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 256378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 256478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 256578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 256678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 256978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 257178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 257278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (!descriptor_type_match(dev_data, module, use.second.type_id, binding->descriptorType, /*out*/ required_descriptor_count)) { 2573080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2574080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 257578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Type mismatch on descriptor slot " 257678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "%u.%u (used as type `%s`) but " 257778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "descriptor of type %s", 257878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 257978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 258078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2581e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 258278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 258378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2584080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2585080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 258678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 258778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 258878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 258978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes binding->descriptorCount)) { 2590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 259178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 259678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 259778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2599a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2600a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_capture_pipeline_shader_state(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2602ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkGraphicsPipelineCreateInfo const *>(&pPipeline->graphicsPipelineCI); 26035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 26055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 26075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 26085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 26095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 26105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2611e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 26125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 261378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 261478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 2616ca546210846c65808717f8875deae39bd227c240Tobin Ehlis VkPipelineShaderStageCreateInfo const *pStage = 2617ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<VkPipelineShaderStageCreateInfo const *>(&pCreateInfo->pStages[i]); 261878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 261978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_pipeline_shader_stage(my_data, pStage, pPipeline, pipelineLayout, 262078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes &shaders[stage_id], &entrypoints[stage_id]); 26215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 26245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 262609042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_consistency(my_data, vi); 26275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 263009042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_against_vs_inputs(my_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 26315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 26355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 26375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 26385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 26395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 26425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 26435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2644031261d21af8907953dd763398ce9a23e65b8749Chris Forbes pass &= validate_interface_between_stages(my_data, 2645031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2646031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 265278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto rp = pCreateInfo->renderPass != VK_NULL_HANDLE ? my_data->renderPassMap[pCreateInfo->renderPass] : nullptr; 265378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[fragment_stage] && rp) { 265509042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_fs_outputs_against_render_pass(my_data, shaders[fragment_stage], entrypoints[fragment_stage], rp, 265609042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pCreateInfo->subpass); 26575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_compute_pipeline(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2663ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkComputePipelineCreateInfo const *>(&pPipeline->computePipelineCI); 266403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 266503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 266603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 266703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 266803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 266903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 267003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes return validate_pipeline_shader_stage(my_data, &pCreateInfo->stage, pPipeline, pipelineLayout, 267103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes &module, &entrypoint); 267203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 267303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 26745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 26755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic SET_NODE *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 26765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 26775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 26785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 26805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2681a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2682a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given Layout Node and binding, return index where that binding begins 2683a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingStartIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2684a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2685a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2686a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2687a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2688a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2689a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2690a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex; 2691a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2692a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2693a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given layout node and binding, return last index that is updated 2694a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingEndIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2695a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2696a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2697a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2698a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2699a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2700a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2701a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex - 1; 2702a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2703a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 27047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 27137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis const vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 2714e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 27155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 27175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dynOffsetIndex = 0; 27185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize bufferSize = 0; 2719a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2720a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis SET_NODE *set_node = set_bindings_pair.first; 2721a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis LAYOUT_NODE *layout_node = set_node->pLayout; 2722a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto binding : set_bindings_pair.second) { 2723a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t startIdx = getBindingStartIndex(layout_node, binding); 2724a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t endIdx = getBindingEndIndex(layout_node, binding); 2725a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = startIdx; i <= endIdx; ++i) { 2726e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // We did check earlier to verify that set was updated, but now make sure given slot was updated 2727e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // TODO : Would be better to store set# that set is bound to so we can report set.binding[index] not updated 2728e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis if (!set_node->pDescriptorUpdates[i]) { 2729e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2730e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2731e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2732e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "DS %#" PRIxLEAST64 " bound and active but it never had binding %u updated. It is now being used to draw so " 2733e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "this will result in undefined behavior.", 2734e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), binding); 2735e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else { 2736e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis switch (set_node->pDescriptorUpdates[i]->sType) { 2737e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 2738e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS = (VkWriteDescriptorSet *)set_node->pDescriptorUpdates[i]; 2739dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young 2740dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // Verify uniform and storage buffers actually are bound to valid memory at draw time. 2741dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER) || 2742dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2743dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER) || 2744e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2745e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2746dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto buffer_node = dev_data->bufferMap.find(pWDS->pBufferInfo[j].buffer); 2747dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (buffer_node == dev_data->bufferMap.end()) { 2748dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2749dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2750dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2751dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2752dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index #%u" 2753dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " is not defined! Has vkCreateBuffer been called?", 2754dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2755dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2756dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2757dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else { 2758dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young auto mem_entry = dev_data->memObjMap.find(buffer_node->second.mem); 2759dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (mem_entry == dev_data->memObjMap.end()) { 2760e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2761e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2762e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2763dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_INVALID_BUFFER, "DS", 2764dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") %s (%#" PRIxLEAST64 ") at index" 2765dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " #%u, has no memory bound to it!", 2766dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), 2767dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young string_VkDescriptorType(pWDS->descriptorType), 2768dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), i); 2769e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 27705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2771dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young // If it's a dynamic buffer, make sure the offsets are within the buffer. 2772dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2773dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2774dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize = dev_data->bufferMap[pWDS->pBufferInfo[j].buffer].createInfo.size; 2775dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young uint32_t dynOffset = 2776dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets[dynOffsetIndex]; 2777dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->pBufferInfo[j].range == VK_WHOLE_SIZE) { 2778dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if ((dynOffset + pWDS->pBufferInfo[j].offset) > bufferSize) { 2779dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= log_msg( 2780dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2781dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2782dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2783dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2784dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has range of " 2785dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VK_WHOLE_SIZE but dynamic offset %#" PRIxLEAST32 ". " 2786dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "combined with offset %#" PRIxLEAST64 " oversteps its buffer (%#" PRIxLEAST64 2787dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") which has a size of %#" PRIxLEAST64 ".", 2788dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2789dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, 2790dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2791dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2792dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > 2793dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young bufferSize) { 2794dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young result |= 2795dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2796dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2797dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2798dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2799dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "VkDescriptorSet (%#" PRIxLEAST64 2800dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2801dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2802dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young " from its update, this oversteps its buffer " 2803dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2804dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2805dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2806dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2807dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2808dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young dynOffsetIndex++; 2809dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2810e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2811dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young } 2812dfc3ecf3aeb24f3f80ebe6830ce700ad4ec60595Mark Young if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 2813e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2814e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 2815e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2816e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 2817e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2818e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(dev_data->bufferViewMap.find(pWDS->pTexelBufferView[j]) != dev_data->bufferViewMap.end()); 2819e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 2820e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2821e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 2822e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 2823e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2824e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 28255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2827e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis i += pWDS->descriptorCount; // Advance i to end of this set of descriptors (++i at end of for loop will move 1 2828e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // index past last of these descriptors) 2829e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis break; 2830e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis default: // Currently only shadowing Write update nodes so shouldn't get here 2831e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(0); 2832e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis continue; 28335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// TODO : This is a temp function that naively updates bound storage images and buffers based on which descriptor sets are bound. 28417a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// When validate_and_update_draw_state() handles computer shaders so that active_slots is correct for compute pipelines, this 28427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// function can be killed and validate_and_update_draw_state() used instead 28437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlisstatic void update_shader_storage_images_and_buffers(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 28447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkWriteDescriptorSet *pWDS = nullptr; 28457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis SET_NODE *pSet = nullptr; 28467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For the bound descriptor sets, pull off any storage images and buffers 28477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // This may be more than are actually updated depending on which are active, but for now this is a stop-gap for compute 28487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // pipelines 28497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto set : pCB->lastBound[VK_PIPELINE_BIND_POINT_COMPUTE].uniqueBoundSets) { 28507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Get the set node 28517a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pSet = getSetNode(dev_data, set); 28527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For each update in the set 28537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto pUpdate : pSet->pDescriptorUpdates) { 28547a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If it's a write update to STORAGE type capture image/buffer being updated 28557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pUpdate && (pUpdate->sType == VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET)) { 28567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS = reinterpret_cast<VkWriteDescriptorSet *>(pUpdate); 28577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 28587a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 28607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 28627a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28637a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 28647a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28657a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 28667a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 28677a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28687a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 28697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28707a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28717a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28727a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28747a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis} 28755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2877e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28807a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 28817a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 28823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 28837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 28847a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 28857a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 28865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 28875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Currently only performing next check if *something* was bound (non-zero last bound) 28885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There is probably a better way to gate when this check happens, and to know if something *should* have been bound 28895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // We should have that check separately and then gate this check based on that check 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipe) { 289172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (state.pipelineLayout) { 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString; 28935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2894a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> activeSetBindingsPairs; 2895a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 2896a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t setIndex = setBindingPair.first; 28975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If valid set is not bound throw an error 289872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 29015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", 29025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPipe->pipeline, setIndex); 290372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 29055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 290672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->set; 29075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg( 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 29105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", 29125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 29137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 29145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull the set node 291572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis SET_NODE *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2917a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // activeSetNodes.push_back(pSet); 2918a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 29195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure set has been updated 29205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet->pUpdateStructs) { 29215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 29225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pSet->set, __LINE__, 29235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 29245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS %#" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 29255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this will result in undefined behavior.", 29265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSet->set); 29275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 29317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 29327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) { 29347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Verify Vtx binding 29357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pPipe->vertexBindingDescriptions.size() > 0) { 29367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 29377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 29387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "The Pipeline State Object (%#" PRIxLEAST64 29417a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 29427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis " should be set via vkCmdBindVertexBuffers.", 29437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)state.pipeline, i); 29447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { 29477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 29487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 29497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 29517a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", 29527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 29567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 29577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 295845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 29597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 2960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 2961e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 29627a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynViewport) { 29637a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 29647a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29657a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29667a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 29677a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 29687a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 29697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29707a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29717a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynScissor) { 29727a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 29737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29747a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 29767a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 29777a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 29787a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2987e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2989e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 29905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 29925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 29945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 29965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 29975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 29985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 29995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3024b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 30253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 302626c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3027c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 3028c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 3029c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 3030c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 3031c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 3032c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 3033c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 3034c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 3035c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 3036c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3037c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3038c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3039c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3040c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3044b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3061a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30736c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data, pPipeline)) { 3074e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 307652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 307752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 307852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 307952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 308052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 308152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 308252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 308352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 308452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 308552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 308652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 30965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3112ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3113ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3119ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3120ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 31265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3127ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3128ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3129ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3130ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3131ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3132ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3133ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3134ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3140ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 314745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3158ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3159ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3162e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3163e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 31835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3195ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3196ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipeline, return number of MSAA samples, or one if MSAA disabled 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(layer_data *my_data, const VkPipeline pipeline) { 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipe = my_data->pipelineMap[pipeline]; 3204ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pMultisampleState && 3205ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->graphicsPipelineCI.pMultisampleState->sType)) { 3206ca546210846c65808717f8875deae39bd227c240Tobin Ehlis return pPipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_SAMPLE_COUNT_1_BIT; 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state related to the PSO 3212e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePipelineState(layer_data *my_data, const GLOBAL_CB_NODE *pCB, const VkPipelineBindPoint pipelineBindPoint, 3213e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipeline pipeline) { 3214e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 32165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that any MSAA request in PSO matches sample# in bound FB 32175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip the check if rasterization is disabled. 32185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = my_data->pipelineMap[pipeline]; 32195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 322045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits)0; 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32286f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young const VkPipelineColorBlendStateCreateInfo *pColorBlendState = pPipeline->graphicsPipelineCI.pColorBlendState; 32296f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young if ((pColorBlendState != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 32306f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young (pColorBlendState->attachmentCount != pSD->colorAttachmentCount)) { 32316f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32326f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young reinterpret_cast<const uint64_t &>(pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 32336f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 32346f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young "count %u but subpass color attachment count %u! These must be the same.", 32356f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young pCB->activeSubpass, pColorBlendState->attachmentCount, pSD->colorAttachmentCount); 32366f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young } 32376f65b420ec34b089bc1c68b135ad37ede5565d41Mark Young 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pSD->colorAttachmentCount; i++) { 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits samples; 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) { 32465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (subpassNumSamples != samples) { 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) 32555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else if (subpassNumSamples != samples) 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 326004826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak if ((pSD->colorAttachmentCount > 0 || pSD->pDepthStencilAttachment) && 326104826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak psoNumSamples != subpassNumSamples) { 32620292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32630292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 32640292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 32650292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", 32660292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, psoNumSamples, (uint64_t)pCB->activeRenderPass, subpassNumSamples); 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify and flag error as appropriate 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add more checks here 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Validate non-gfx pipeline updates 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32770292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young return skipCall; 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic LAYOUT_NODE *getLayoutNode(layer_data *my_data, const VkDescriptorSetLayout layout) { 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorSetLayoutMap[layout]; 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3297e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3298e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3302e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex; 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 33335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex + count - 1; 33355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3338e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, 3339e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 33405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3341e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33421d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3350e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set first stageFlags as reference and verify that all other updates match it 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = startIndex; i <= endIndex; i++) { 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->descriptorTypes[i] != actualType) { 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->stageFlags[i] != refStageFlags) { 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis refStageFlags, pLayout->stageFlags[i]); 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Determine the update type, allocate a new struct of that type, shadow the given pUpdate 3382e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// struct into the pNewNode param. Return true if error condition encountered and callback signals early exit. 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 3384e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool shadowUpdateNode(layer_data *my_data, const VkDevice device, GENERIC_HEADER *pUpdate, GENERIC_HEADER **pNewNode) { 3385e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCopyDescriptorSet *pCDS = NULL; 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdate->sType) { 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = new VkWriteDescriptorSet; 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pWDS; 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); 33935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pImageInfo = info; 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pTexelBufferView = info; 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); 34155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pBufferInfo = info; 34165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS = new VkCopyDescriptorSet; 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pCDS; 34255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), pUpdate->sType)) 3432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that pNext for the end of shadow copy is NULL 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*pNewNode)->pNext = NULL; 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given sampler is valid 3440e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSampler(const layer_data *my_data, const VkSampler *pSampler, const bool immutable) { 3441e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->sampleMap.find(*pSampler); 34435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->sampleMap.end()) { 34445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!immutable) { 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, 34485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // immutable 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable " 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "sampler %#" PRIxLEAST64, 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the sampler? 34585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 34634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 34644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 34654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 34714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 34724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 34754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 34784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 34794a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 34814a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34824a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 34844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 34854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 34874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 34884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 34894a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 34904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 34914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34964a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 34974a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 34984a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34994a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 35014a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 35024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 35034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 35044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 35054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 35064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 35084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 35094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 35144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 35154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 35164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 35174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 35184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 35204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 35304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 35314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 35324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 35334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 35344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 35374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 358708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 359008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 359108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 359208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 359308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 359708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 359908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 360008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 36067068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 36077068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 36087068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 360908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 361308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 361408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 361508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 361608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 361708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 361808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 362108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 362208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 362408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 362508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 362608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 362708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 363008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 363208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given imageView is valid 3652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateImageView(const layer_data *my_data, const VkImageView *pImageView, const VkImageLayout imageLayout) { 3653e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ivIt = my_data->imageViewMap.find(*pImageView); 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ivIt == my_data->imageViewMap.end()) { 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that imageLayout is compatible with aspectMask and image format 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageAspectFlags aspectMask = ivIt->second.subresourceRange.aspectMask; 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = ivIt->second.image; 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Check here in case we have a bad image 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format = VK_FORMAT_MAX_ENUM; 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt != my_data->imageMap.end()) { 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = (*imgIt).second.createInfo.format; 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Also need to check the swapchains. 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchainIt = my_data->device_extensions.imageToSwapchainMap.find(image); 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchainIt != my_data->device_extensions.imageToSwapchainMap.end()) { 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR swapchain = swapchainIt->second; 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_nodeIt = my_data->device_extensions.swapchainMap.find(swapchain); 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_nodeIt != my_data->device_extensions.swapchainMap.end()) { 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SWAPCHAIN_NODE *pswapchain_node = swapchain_nodeIt->second; 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = pswapchain_node->createInfo.imageFormat; 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (format == VK_FORMAT_MAX_ENUM) { 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " in imageView %#" PRIxLEAST64, 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, (uint64_t)*pImageView); 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3688e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool ds = vk_format_is_depth_or_stencil(format); 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (imageLayout) { 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Only Color bit must be set 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must NOT be DS 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds) { 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a color format.", 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, string_VkFormat(format)); 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Depth or stencil bit must be set, but both must NOT be set 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // both must NOT be set 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that has both STENCIL and DEPTH aspects set", 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Neither were set 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have STENCIL or DEPTH aspect set.", 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView); 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must be DS 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ds) { 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a depth/stencil format.", 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView, string_VkFormat(format)); 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // anything to check for other layouts? 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferView is valid 3754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferView(const layer_data *my_data, const VkBufferView *pBufferView) { 3755e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferViewMap.find(*pBufferView); 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferViewMap.end()) { 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView, __LINE__, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView); 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferInfo is valid 3769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferInfo(const layer_data *my_data, const VkDescriptorBufferInfo *pBufferInfo) { 3770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferMap.end()) { 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 37755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer, __LINE__, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer); 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3784e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateContents(const layer_data *my_data, const VkWriteDescriptorSet *pWDS, 3785e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayoutBinding *pLayoutBinding) { 3786e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampler *pSampler = NULL; 3789e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool immutable = false; 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For given update type, verify that update contents are correct 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayoutBinding->pImmutableSamplers) { 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pWDS->pImageInfo[i].sampler); 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (immutable) { 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but previous update(s) from this " 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, (uint64_t)*pSampler); 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i > 0 && !immutable) { 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i); 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves immutable = true; 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pLayoutBinding->pImmutableSamplers[i]); 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, pSampler, immutable); 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Intentionally fall through here to also validate image stuff 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3856e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3859e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s() on descriptor set %" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Cannot call %s() on descriptor set %" PRIxLEAST64 " that is in use by a command buffer.", 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const SET_NODE *pSet) { 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : pSet->boundCmdBuffers) { 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 3886e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 3887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 3888e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = NULL; 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSetLayoutCreateInfo *pLayoutCI = NULL; 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = my_data->setMap[ds]; 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3898e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == true) 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayout = pSet->pLayout; 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 3905e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == true) { 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t binding = 0, endIndex = 0; 39095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = pWDS[i].dstBinding; 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingToIndex = pLayout->bindingToIndexMap.find(binding); 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that layout being updated has the binding being updated 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (bindingToIndex == pLayout->bindingToIndexMap.end()) { 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor Set %" PRIu64 " does not have binding to match " 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "update binding %u for update type " 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s!", 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), binding, string_VkStructureType(pUpdate->sType)); 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Next verify that update falls within size of given binding 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pLayout, binding) < endIndex) { 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pLayout->createInfo; 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // TODO : should we skip update on a type mismatch or force it? 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t startIndex; 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layout bindings match w/ update, now verify that update type 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // & stageFlags are the same for entire update 3935e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == false) { 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The update is within bounds and consistent, but need to 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // make sure contents make sense as well 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateContents(my_data, &pWDS[i], 3939e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves &pLayout->createInfo.pBindings[bindingToIndex->second])) == false) { 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update is good. Save the update info 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new update struct for this set's shadow copy 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pNewNode = NULL; 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert shadow node into LL of updates for this set 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pSet->pUpdateStructs; 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = pNewNode; 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update appropriate descriptor(s) to point to new Update node 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = startIndex; j <= endIndex; j++) { 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(j < pSet->descriptorCount); 39563a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates[j] = pNewNode; 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSrcSet = NULL, *pDstSet = NULL; 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->set, "VkUpdateDescriptorSets")) == true) 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcLayout = pSrcSet->pLayout; 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstLayout = pDstSet->pLayout; 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src binding is valid for src set layout 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->bindingToIndexMap.find(pCDS[i].srcBinding) == pSrcLayout->bindingToIndexMap.end()) { 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has srcBinding %u " 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].srcBinding, (uint64_t)pSrcLayout->layout, pSrcLayout->createInfo.bindingCount - 1); 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDstLayout->bindingToIndexMap.find(pCDS[i].dstBinding) == pDstLayout->bindingToIndexMap.end()) { 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has dstBinding %u " 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].dstBinding, (uint64_t)pDstLayout->layout, pDstLayout->createInfo.bindingCount - 1); 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pSrcLayout->createInfo; 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].srcBinding, DSstr.c_str()); 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pDstLayout->createInfo; 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].dstBinding, DSstr.c_str()); 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pCDS[i].descriptorCount; ++j) { 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For copy just make sure that the types match and then perform the update 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->descriptorTypes[srcStartIndex + j] != pDstLayout->descriptorTypes[dstStartIndex + j]) { 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update index %u, update count #%u, has src update descriptor type %s " 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that does not match overlapping dest descriptor type of %s!", 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, j + 1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex + j]), 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex + j])); 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // point dst descriptor at corresponding src descriptor 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This may be a hole. I believe copy should be its own copy, 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // otherwise a subsequent write update to src will incorrectly affect the copy 40333a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pDstSet->pDescriptorUpdates[j + dstStartIndex] = pSrcSet->pDescriptorUpdates[j + srcStartIndex]; 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet->pUpdateStructs = pSrcSet->pUpdateStructs; 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4043a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 4044a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 4045e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 4046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayout *pSetLayouts) { 4047e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4048a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 4049a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 4050a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 4051a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 4052a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 4053a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 4054a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 4055a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski "Unable to allocate %u descriptorSets from pool %#" PRIxLEAST64 4056a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 4057a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 4058a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 4059a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 4060a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 4061a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pSetLayouts[i]); 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pLayout->createInfo.bindingCount; ++j) { 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pLayout->layout, __LINE__, 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 4080a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptors of this type remaining.", 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBindings[j].descriptorType), 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the shadowed update node for this Set 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void freeShadowUpdateTree(SET_NODE *pSet) { 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pShadowUpdate = pSet->pUpdateStructs; 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = NULL; 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pFreeUpdate = pShadowUpdate; 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the descriptor mappings as they will now be invalid 40993a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates.clear(); 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pShadowUpdate) { 41015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeUpdate = pShadowUpdate; 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pShadowUpdate = (GENERIC_HEADER *)pShadowUpdate->pNext; 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pFreeUpdate->sType) { 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = (VkWriteDescriptorSet *)pFreeUpdate; 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pImageInfo; 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pTexelBufferView; 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pBufferInfo; 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeUpdate; 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = (*ii).second->pSets; 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pFreeSet = pSet; 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeSet = pSet; 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Freeing layouts handled in deleteLayouts() function 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free Update shadow struct tree 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pFreeSet); 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeSet; 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid 41605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteLayouts(layer_data *my_data) { 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.size() <= 0) 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorSetLayoutMap.begin(); ii != my_data->descriptorSetLayoutMap.end(); ++ii) { 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = (*ii).second; 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->createInfo.pBindings) { 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings[i].pImmutableSamplers; 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pLayout; 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorSetLayoutMap.clear(); 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Currently clearing a set is removing all previous updates to that set 41785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Validate if this is correct clearing behavior 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorSet(layer_data *my_data, VkDescriptorSet set) { 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = getSetNode(my_data, set); 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet) { 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Return error 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pSet); 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For every set off of this pool, clear it 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = pPool->pSets; 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorSet(my_data, pSet->set); 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4203e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4207e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *my_data, const VkCommandBuffer cb) { 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.count(cb) == 0) { 421472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 421572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 421672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->commandBufferMap[cb]; 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 4225400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4234e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4240e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 4242e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 4243e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 4282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 4283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 4286b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 42905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 43285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4357400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4358400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 43695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 43705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 437272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 437372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 437472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4375400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis auto set_node = dev_data->setMap.find(set); 4376400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (set_node != dev_data->setMap.end()) { 437772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis set_node->second->boundCmdBuffers.erase(pCB->commandBuffer); 437872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 437972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 438072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 438172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = 0; 438772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->fenceId = 0; 438872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 438972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 44067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 44077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4408400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4409b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4416ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4417ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4424ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4425ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 44393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 44515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 4464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 446772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 4473ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 4474ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 4475ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_NONE, "DS", "Cmds in CB %p", (void *)cb); 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", " CMD#%" PRIu64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4497e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 4498e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4508e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4509e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 45135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", apiName, 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass); 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4521e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4522e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4533b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4534d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4535b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!globalLockInitialized) { 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_create_mutex(&globalLock); 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 1; 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4560b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 4561b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4562b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4564b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4565b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4566b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4568b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layer_data_map.empty()) { 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Release mutex when destroying last instance. 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_delete_mutex(&globalLock); 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 0; 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 46105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 46225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(NULL, "vkCreateDevice"); 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 46515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 46526c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4657b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 46585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 46595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4660b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4662b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4665b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4667b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4669b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4670b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 46855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteLayouts(dev_data); 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 46955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 46971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 46981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 470003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4701e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 47070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 47080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 471058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4711400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 47165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mem Object %" PRIu64 " has not been freed. You should clean up this memory by calling " 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkFreeMemory(%" PRIu64 ") prior to vkDestroyDevice().", 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fprintf(stderr, "Device: %p, key: %p\n", device, key); 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4732e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_global_layers), cv_global_layers, pCount, pProperties); 47525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Why does this exist - can we just use global? 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_device_layers[] = {{ 4756f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *pLayerName, uint32_t *pCount, 47615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkExtensionProperties *pProperties) { 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayerName == NULL) { 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(physicalDevice); 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(0, NULL, pCount, pProperties); 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* draw_state physical device layers are the same as global */ 47745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_device_layers), cv_device_layers, pCount, pProperties); 47755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 47795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4780e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 4781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 47835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image %" PRIu64 ".", 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4795856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4796856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4797856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4798856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4799856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") [sub-resource: array layer %u, mip level %u], " 4800856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4801856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.arrayLayer, 4802856ecb404bc959ddb877c150c9caa0649055b9cbMark Young cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4803856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4804856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4805856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4806856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4807856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4808856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "Cannot submit cmd buffer using image (%" PRIx64 ") with layout %s when " 4809856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4810856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4811856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4812856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 48155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 481939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 48275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted buffer %" PRIu64 ".", (uint64_t)(buffer)); 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 483572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 483672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 483772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 483872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 483972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 484072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 484172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 484272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Cannot submit cmd buffer using deleted descriptor set %" PRIu64 ".", (uint64_t)(set)); 484372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 484472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 484572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 48545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted semaphore %" PRIu64 ".", reinterpret_cast<uint64_t &>(semaphore)); 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 48605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 48615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 48625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted event %" PRIu64 ".", reinterpret_cast<uint64_t &>(event)); 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4873e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 48795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 48805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 488372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 488472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 488572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 488672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 488772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 488872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 48895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 48925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 48935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 48945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 48955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 48985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 48995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 49005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 49055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 49075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 49085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4911e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_sub(1); 49181d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 49191d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4926e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkQueue queue) { 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 49331d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 49341d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill queue_data->second.lastFences.data()); 49350a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 49370a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4938e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 49390a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 49400a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49410a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49420a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 49430a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 49440a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 49450a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49460a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4947ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4948ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 49490a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49500a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 49510a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 49520a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 49530a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 49540a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49550a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 49560a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 49570a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49580a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 49590a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 49600a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 49610a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 49620a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49630a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4965b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 4966b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 4967b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4970e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4971e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 49740a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49800a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 49810a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 49820a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 49830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 49840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 49855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 49875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.clear(); 49890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 49905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 49915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.queue = queue; 49925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 49935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 49945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 49965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 49975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 49985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 50035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 50095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add cmdBuffers to both the global set and queue set 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(secondaryCmdBuffer); 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 503727c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 503827c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Command Buffer %#" PRIx64 " is already in use and is not marked for simultaneous use.", 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 50460a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 50470a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 50480a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 50490a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 50500a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 50510a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis "set, but has been submitted %#" PRIxLEAST64 " times.", 50520a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 50530a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 50565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 50635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 50755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 50765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 50875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 50885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid because it had the following " 50945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 51015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 51035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 51045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 51065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 51075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 51105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 51125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5122e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 5124e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->primaryCommandBuffer != pCB->commandBuffer) { 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was submitted with secondary buffer %#" PRIxLEAST64 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "primary cmd buffer %#" PRIxLEAST64 ".", 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 5149e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 515072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((fence != VK_NULL_HANDLE) && (submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis uint64_t fenceId = 0; 51611344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall = add_fence_info(dev_data, fence, queue, &fenceId); 51621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 51631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 51641344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 51660a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 51705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 51710a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 517241bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 51731344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 51741344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 51751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 51761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 51771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 51781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 51791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 51801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 51811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 51821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 51841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 51851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 51861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 51871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 51910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 51921344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 51931344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 51941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 51951344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 51961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 51971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 51981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 51991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has already been signaled but not waited on by queue %#" PRIx64 ".", 52001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 52011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 52021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 52031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 52041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 52051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52060a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 521072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 52111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 52121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->semaphores = semaphoreList; 52131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 52141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->fenceId = fenceId; 52151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedFence = fence; 52161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedQueue = queue; 52171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 52181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 52191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 52201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 52211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 52231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 52241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update cmdBuffer-related data structs and mark fence in-use 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 523703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 52405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 52435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 52450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 52475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 52565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 52605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 526158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5262e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 52630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 52640a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 52665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5269e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 5270e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 52735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 52845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 52855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object %#" PRIxLEAST64, (uint64_t)mem); 52865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 52945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5308e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5318e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 5319e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj %#" PRIxLEAST64, (uint64_t)mem); 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 53305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5339b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 5340b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 5341b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 5344b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 5360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 5361e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : queryEventsPair.second) { 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->eventMap[event].needsSignaled) { 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " with index %d which was guarded by unsignaled event %" PRIu64 ".", 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove given cmd_buffer from the global inFlight set. 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Also, if given queue is valid, then remove the cmd_buffer from that queues 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// inFlightCmdBuffer set. Finally, check all other queues and if given cmd_buffer 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// is still in flight on another queue, add it back into the global set. 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkQueue queue) { 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull it off of global list initially, but if we find it in any other queue list, add it back in 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.erase(cmd_buffer); 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto q : dev_data->queues) { 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((q != queue) && 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dev_data->queueMap[q].inFlightCmdBuffers.find(cmd_buffer) != dev_data->queueMap[q].inFlightCmdBuffers.end())) { 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cmd_buffer); 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 539803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline bool verifyFenceStatus(VkDevice device, VkFence fence, const char *apiCall) { 54005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5401e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 5404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 5405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((pFenceInfo->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT) && !pFenceInfo->second.firstTimeFlag) { 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s specified fence %#" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pFenceInfo->second.queue && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s called for fence %#" PRIxLEAST64 " which has not been submitted on a Queue or during " 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5419e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 542903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= verifyFenceStatus(device, pFences[i], "vkWaitForFences"); 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 544603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, pFences[i]); 54485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue fence_queue = dev_data->fenceMap[pFences[i]].queue; 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[pFences[i]].cmdBuffers) { 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, fenceCount, pFences); 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetFenceStatus(VkDevice device, VkFence fence) { 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 547103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = verifyFenceStatus(device, fence, "vkGetFenceStatus"); 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 548203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, fence); 54845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_queue = dev_data->fenceMap[fence].queue; 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[fence].cmdBuffers) { 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 54895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, 1, &fence); 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5498b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5499b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 55005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5503b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5504b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5505b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5506b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5507b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 5508b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 550903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5510b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastRetiredId = 0; 5511b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastSubmittedId = 0; 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5513b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 5514b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 55155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueWaitIdle(VkQueue queue) { 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 5521e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Iterate over local set since we erase set members as we go in for loop 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto local_cb_set = dev_data->queueMap[queue].inFlightCmdBuffers; 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : local_cb_set) { 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, queue); 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5531e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 553403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_queue_fences(dev_data, queue); 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDeviceWaitIdle(VkDevice device) { 5545e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear all of the queue inFlightCmdBuffers (global set cleared below) 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 556303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_device_fences(dev_data, device); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 55781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 55791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair->second.in_use.load()) { 55801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 55811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 55821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 55831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 55841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 55855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 55985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 55995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete semaphore %" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete event %" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 56325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 56385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryResultFlags flags) { 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 56485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5650e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 56545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 56555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5656ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5657ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5658ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5659ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5660ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5661ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5662ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5663ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5664ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5665ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is in flight.", 5666ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5667ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5668ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5669ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5670ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5671ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5672ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5673ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5674ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5675ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5676ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5677ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5678ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5679ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5680ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5681ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5682ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5685ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 56875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5688ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5689ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5694ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5695ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5696ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5697ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5698ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 5699ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5700ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5712e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 57155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 57185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 57205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 57225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 57265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { 57305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.erase(buffer); 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 57555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5756e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5757e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& entry = dev_data->imageMap.find(image); 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (entry != dev_data->imageMap.end()) { 576358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Clear any memory mapping for this image 576494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto mem_entry = dev_data->memObjMap.find(entry->second.mem); 576558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (mem_entry != dev_data->memObjMap.end()) 576658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis mem_entry->second.image = VK_NULL_HANDLE; 576758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 576858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 57695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.erase(entry); 57705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 578003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 5782e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 57835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 578458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Buffer %" PRIx64 " is alised with image %" PRIx64, object_handle, 57865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 578858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Image %" PRIx64 " is alised with buffer %" PRIx64, object_handle, 57905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5794e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 5795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 5796e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 579758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 57985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto range : ranges) { 5799b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 5800b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 5802b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 5803b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 580558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5810e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_buffer_image_aliasing(layer_data *dev_data, uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 5811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges, 5812e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const vector<MEMORY_RANGE> &other_ranges, VkDebugReportObjectTypeEXT object_type) { 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMORY_RANGE range; 58145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.handle = handle; 58155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.memory = mem; 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.start = memoryOffset; 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.end = memoryOffset + memRequirements.size - 1; 581858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis ranges.push_back(range); 581958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return validate_memory_range(dev_data, other_ranges, range, object_type); 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 582458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5829e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 583094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 583194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 583294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 583394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 58345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 583594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 583658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, buffer_handle, mem, memoryOffset, memRequirements, 583758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].bufferRanges, dev_data->memObjMap[mem].imageRanges, 583858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 58392c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58402c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 58412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58422c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58432c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 58442c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be an integer multiple of the " 58452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "VkMemoryRequirements::alignment value %#" PRIxLEAST64 58462c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58472c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58482c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58492c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 585094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 58512c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5852b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 58532c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58542c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58552c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 58562c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58572c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minTexelBufferOffsetAlignment %#" PRIxLEAST64, 5858b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 58592c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58602c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58612c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5862b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5863b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58642c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58652c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58662c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 58672c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58682c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 5869b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 58702c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58712c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58722c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5873b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5874b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58752c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58762c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58772c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 58782c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58792c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 5880b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 58812c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58822c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 58855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5886e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 588758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 58885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 58975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 58985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 59065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 59085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5917918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5918918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5919918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_lock_mutex(&globalLock); 5920918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5921918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5922918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5923918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_unlock_mutex(&globalLock); 5924918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5925918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 59495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 59685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCommandBuffers[i])) { 59695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to free command buffer (%#" PRIxLEAST64 ") which is in use.", 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 59765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]); 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb != dev_data->commandBufferMap.end()) { 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*cb).second->commandBuffer); 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*cb).second; 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap.erase(cb); 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 598703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 59880a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool *pCommandPool) { 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 60135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 60175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 60205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6025400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic bool validateCommandBuffersNotInUse(const layer_data *dev_data, VkCommandPool commandPool, const char *action) { 6026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 60275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 60285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : pool_data->second.commandBuffers) { 60305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmdBuffer)) { 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT, 60335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandPool), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 6034400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis "Cannot %s command pool %" PRIx64 " when allocated command buffer %" PRIx64 " is in use.", action, 6035400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis reinterpret_cast<const uint64_t &>(commandPool), reinterpret_cast<const uint64_t &>(cmdBuffer)); 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 60435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6049400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis VkBool32 result = validateCommandBuffersNotInUse(dev_data, commandPool, "destroy"); 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 60515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 6054400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *poolCb); 60555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 605772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6066f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 60685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 6078400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 6079400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (validateCommandBuffersNotInUse(dev_data, commandPool, "reset")) 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 610403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset fence state in fenceCreateInfo structure 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge with code below 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 61095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate fences in SIGNALED state 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(fence_item->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT)) { 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: I don't see a Valid Usage section for ResetFences. This behavior should be documented there. 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pFences[i], __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted to VkResetFences in UNSIGNALED STATE", (uint64_t)pFences[i]); 61155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_item->second.createInfo.flags = 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<VkFenceCreateFlags>(fence_item->second.createInfo.flags & ~VK_FENCE_CREATE_SIGNALED_BIT); 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[pFences[i]].in_use.load()) { 61225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6137f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes loader_platform_thread_lock_mutex(&globalLock); 61385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 61415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6148f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 6149f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6151f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes loader_platform_thread_unlock_mutex(&globalLock); 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 616447892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 616547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 616747892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 616847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 617394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->bufferMap[*pBuffer].createInfo = *pCreateInfo; 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].in_use.store(0); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 618703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 61895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 61900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 6191e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 619947892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 620047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 620247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 620347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6206e5bc02759d9ab768d67b2f45ec53d29fb59a4705Tony Barbour loader_platform_thread_lock_mutex(&globalLock); 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[*pImage].createInfo = *pCreateInfo; 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 626603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that img has correct usage flags set 62680a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_image_usage_flags(dev_data, pCreateInfo->image, 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 6271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pFN = &dev_data->fenceMap[*pFence]; 628503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pFN, 0, sizeof(MT_FENCE_INFO)); 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&(pFN->createInfo), pCreateInfo, sizeof(VkFenceCreateInfo)); 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 6289e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFN->firstTimeFlag = true; 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFN->in_use.store(0); 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 63215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 63273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 63283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 63293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 63303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 63313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 63323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63373d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 63403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 63413d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63423d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63433d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 63463d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 6357e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6366ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6367ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 63755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63835188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 6396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6409ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6410ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6416e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pNewNode = new LAYOUT_NODE; 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSetLayout, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->createInfo.pBindings = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pNewNode->createInfo.pBindings, pCreateInfo->pBindings, 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sizeof(VkDescriptorSetLayoutBinding) * pCreateInfo->bindingCount); 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // g++ does not like reserve with size 0 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->bindingCount) 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap.reserve(pCreateInfo->bindingCount); 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t totalCount = 0; 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pNewNode->bindingToIndexMap.emplace(pCreateInfo->pBindings[i].binding, i).second) { 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)*pSetLayout, __LINE__, 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LAYOUT, "DS", "duplicated binding number in " 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSetLayoutBinding")) 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap[pCreateInfo->pBindings[i].binding] = i; 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis totalCount += pCreateInfo->pBindings[i].descriptorCount; 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pBindings[i].pImmutableSamplers) { 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampler **ppIS = (VkSampler **)&pNewNode->createInfo.pBindings[i].pImmutableSamplers; 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppIS = new VkSampler[pCreateInfo->pBindings[i].descriptorCount]; 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(*ppIS, pCreateInfo->pBindings[i].pImmutableSamplers, 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pBindings[i].descriptorCount * sizeof(VkSampler)); 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->layout = *pSetLayout; 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->startIndex = 0; 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (totalCount > 0) { 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes.resize(totalCount); 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags.resize(totalCount); 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset = 0; 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType dType; 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dType = pCreateInfo->pBindings[i].descriptorType; 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pCreateInfo->pBindings[i].descriptorCount; j++) { 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes[offset + j] = dType; 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags[offset + j] = pCreateInfo->pBindings[i].stageFlags; 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->dynamicDescriptorCount++; 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset += j; 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // no descriptors 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = 0; 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Put new node at Head of global Layer list 65145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validatePushConstantSize(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *caller_name) { 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6524b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 6528b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis caller_name, offset, size, dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize); 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()"); 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCreateInfo->pPushConstantRanges[i].size == 0) || ((pCreateInfo->pPushConstantRanges[i].size & 0x3) != 0)) { 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constant index %u with " 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "size %u. Size must be greater than zero and a multiple of 4.", 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCreateInfo->pPushConstantRanges[i].size); 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if ranges overlap 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge capture of the setLayouts per pipeline 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 65585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 65705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPool *pDescriptorPool) { 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 65755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool %#" PRIxLEAST64, 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 65985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 66035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 6610e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 66225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 66395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set %#" PRIxLEAST64, 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new set node and add to head of pool nodes 66435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pNewNode = new SET_NODE; 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", 6648ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) { 6649ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6651ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Pool should store a total count of each type of Descriptor available 66545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When descriptors are allocated, decrement the count and validate here 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that the count doesn't go below 0. One reset/free need to bump count back up. 66565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert set at head of Set LL for this pool 66575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pPoolNode->pSets; 66585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->pSets = pNewNode; 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " specified in vkAllocateDescriptorSets() call", 6667ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6668ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6670ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pLayout = pLayout; 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pool = pAllocateInfo->descriptorPool; 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->set = pDescriptorSets[i]; 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorCount = (pLayout->createInfo.bindingCount != 0) ? pLayout->endIndex + 1 : 0; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pNewNode->descriptorCount) { 6677656b1a5d2165c66fd4af21d070243d387cd4ac56Karl Schultz pNewNode->pDescriptorUpdates.resize(pNewNode->descriptorCount); 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 6690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6695ce62d9f596fa03529c4961ab715473a0e9254e0eMark Mueller skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDescriptorSets"); 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6705e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 6710a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6711a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6712a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6713a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6714a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // For each freed descriptor add it back into the pool as available 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(dev_data, pSet); 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = pSet->pLayout; 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pLayout->createInfo.bindingCount; ++j) { 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 6735e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // dsUpdate will return true only if a bailout error occurs, so we want to call down tree when update returns false 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 6738e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 67425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 67485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 675272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 675372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 675472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 67555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 675672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 676503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 67660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 67825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, commandBuffer, &commandBufferComplete); 6784400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 67895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Calling vkBeginCommandBuffer() on active CB %p before it has completed. " 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must check CB flag before this call.", 67915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBuffer); 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 67965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must have inheritance info.", 68015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6804400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6811400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a " 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6824400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Buffer (%p) renderPass (%#" PRIxLEAST64 ") is incompatible w/ framebuffer " 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") w/ render pass (%#" PRIxLEAST64 ") due to: %s", 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6841b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must not have " 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must has a subpass index (%d) " 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 68895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void *)commandBuffer); 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6899e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6903400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) { 6908e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Ending command buffer with in progress query: queryPool %" PRIu64 ", index %d", 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6943e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") which is in use.", 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer)); 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6962e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 697203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6978e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")", 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass); 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 69935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 699472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 69963d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7005e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 7011e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7022e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 7028e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7039e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7053e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 7059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7068e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 7074e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 70803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 7089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7098e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 7104e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7113e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 7119e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7128e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 71305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 7134e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 71415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7143e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 71495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 71505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t *pDynamicOffsets) { 7151e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7157787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7158787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7159787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7160787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 716172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 716272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 716372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7164787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7165787f29d93dee194c015789cf61c079504c980572Tobin Ehlis SET_NODE *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7166787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 716772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 7168787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pSet->boundCmdBuffers.insert(commandBuffer); 716972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 717072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 7171787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 7172787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7173787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_NONE, "DS", "DS %#" PRIxLEAST64 " bound on pipeline %s", 7174787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7175787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!pSet->pUpdateStructs && (pSet->descriptorCount != 0)) { 7176787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 7177787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7178787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7179787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "DS %#" PRIxLEAST64 7180787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 7181787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7182787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7183787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 7184787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 7185787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7186787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7187787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 7188787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping layout in " 7189787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "pipelineLayout due to: %s", 7190787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, errorString.c_str()); 7191787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7192787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->dynamicDescriptorCount) { 7193787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7194787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if ((totalDynamicDescriptors + pSet->pLayout->dynamicDescriptorCount) > dynamicOffsetCount) { 7195787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 7196787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7197787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7198787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7199787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u (%#" PRIxLEAST64 7200787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7201787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7202787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->pLayout->dynamicDescriptorCount, 7203787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7204787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7205787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7206787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7207787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t d = 0; d < pSet->descriptorCount; d++) { 7208787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7209787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7210787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7211b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 7212787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7213787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7214787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7215787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7216787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7217787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 7218787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7219b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7220787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7221787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7222787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7223787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7224787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7225b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 7226787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7227787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7228787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7229787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7230787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7231787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 7232787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7233b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 72345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7235787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 72365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7238787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7239787f29d93dee194c015789cf61c079504c980572Tobin Ehlis totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7242787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 7243787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7244787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7245787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", 7246787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 724872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 724972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 725072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 725172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 725272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 725372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 725472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 725572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 725672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 725772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 725872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 725972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 726072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "DescriptorSetDS %#" PRIxLEAST64 726172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 726272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 726372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 726472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 726572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 726672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 726772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 726872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 726972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 727072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 727272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 727372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 727472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 727572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_NONE, "DS", "DescriptorSetDS %#" PRIxLEAST64 727672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 727772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 727872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 727972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 728072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 728172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 728272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7286787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7287787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 7288787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7289787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 7290787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7291787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 7292787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 7293787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7294787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7295787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 7296787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 7297e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]); 7298787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7304e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 7311e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 731403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 73170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 731872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 731972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 732172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7349e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 73575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 73605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7363e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 73645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 73665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bindingCount, const VkBuffer *pBuffers, 73675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceSize *pOffsets) { 7368e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 737103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 737572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 737672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 737872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 73825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 73865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 73895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 73935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* expects globalLock to be held by caller */ 7396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 73987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 73997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 74007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 74017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 74025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 74037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 74047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 74057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 74060a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7407e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 74137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 74147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 74150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 74167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7417e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 7419e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 74245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstVertex, uint32_t firstInstance) { 7428e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 74305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7435e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 74465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 74535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 74545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 74555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7456e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 74637a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 74675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7483e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 748503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 74890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 74915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 7496e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7503e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7509e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 7515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 751803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 7529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 75307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7543e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 7548e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7554e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75567a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7562e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 7568e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 757103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75797a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7580e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75817a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75827a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75837a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7588e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferCopy *pRegions) { 7594e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 759703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 759972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 76010a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 760272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7603e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 760472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 76080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 760972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7610e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 761472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 76180a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 76200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7629e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7633e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7634e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7635e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 764408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7673e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7674e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 768308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7713e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 771603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 771872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77200a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 772172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7722e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 772372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77270a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 772872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7729e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 773372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77360a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77380a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7751e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 776203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 776472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 776772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7768e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 776972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 777472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7777e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 777972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7793e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 77965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 77995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage dstImage, VkImageLayout dstImageLayout, 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7801e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 780403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 780672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 780872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 781372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 781872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7819e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 782072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 78240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 78260a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7838e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout, VkBuffer dstBuffer, 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 784903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 785172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78520a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 785372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7854e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7855e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); 7856e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 785772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 786272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7863e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 786772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 78710a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 78730a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7885e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7892e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 789503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 789772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 78990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 790072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7903e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 790572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 79090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7918e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 792703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 792972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 79310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 793272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7933e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7935e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 793772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 79405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 79410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 79475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *pAttachments, uint32_t rectCount, 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearRect *pRects) { 7957e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 79785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 79815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7991e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7995e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 80105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout, const VkClearColorValue *pColor, 80265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 8027e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 803003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 803372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 803572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8036e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8038e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 804072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8050e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 80525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 80575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange *pRanges) { 8058e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 806103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 806472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80650a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 806672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8067e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8069e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 807172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 80745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8081e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 80835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 80885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 8089e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 809203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 809372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 80950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 809672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8097e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 809872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 81020a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 810372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8104e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 81055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 8106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 810872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 81155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 81165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8118e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 81205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 81215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8123b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8124b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8125b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8126b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8127b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8128b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8129b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8130b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8131b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8132b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8133b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8134b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8135b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 81365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8138e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 81415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8146b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8147b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8148b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8151e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8157e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8165b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8166b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8167b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8170e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 81725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8174e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8175e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8178e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 819708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 819808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8239e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8240e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8241e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8242e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & !(required_bit | optional_bits)) { 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 82546044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82676044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8278e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8279e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8280e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8330e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8331e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8332e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8333e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8334e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 83665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8376b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8377b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8385b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 83935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 84021d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 84031d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8432f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8433f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8434f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8435f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 84365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8443f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8444f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8445f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8446f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8469b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8471b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8477b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 848194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 848294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis ? buffer_data->second.createInfo.size 848394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : 0; 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 848694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 848794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 848894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 848994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " which is not less than total size %" PRIu64 ".", 849094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 849194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 849394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 849494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 849594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " and size %" PRIu64 849694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis " whose sum is greater than total size %" PRIu64 ".", 849794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 849894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 849994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85062ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8507b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8508b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8509b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8510b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 85112ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8512b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8513b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8514b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 85152ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8516b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8517b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8518b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 85192ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 8520b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 8521b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 852227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 852327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 85242ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8525b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8526b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 8527b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8528b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8529b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8530b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 8531b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 8532b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 853327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes DRAWSTATE_INVALID_EVENT, "DS", 8534b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 8535b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 8536b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 8537b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8538b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8539b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8540b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85512ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8556b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 85572ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8558b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8581e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8593e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 8601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 8619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool %" PRIu64 ", index %d", 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8641e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8647e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8665e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 867603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 867872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 868172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8682e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8684e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 868672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 86900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Requesting a copy from query to buffer with invalid query: queryPool %" PRIu64 ", index %d", 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pValues) { 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 87205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8730b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, offset, size, "vkCmdPushConstants()"); 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if push constant update doesn't align with range 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8755e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer *pFramebuffer) { 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8766fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes loader_platform_thread_lock_mutex(&globalLock); 8767fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8768fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8769fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8771fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8772fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8773fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8774fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8775fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 87840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8787fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8789fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8796e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8806e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8815e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 88191d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 88303da84689683bb257cc0f64953966666d19321119Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8839e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8847e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8857e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8859e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 88615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 88855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 88865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 88875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 8895e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node) { 8896e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 89561c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89591c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89731c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89811c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 89821c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 89831c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 89841c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 89851c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 89861c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 89871c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 89881c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 89895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9022e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9023e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90364d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90514d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 90674d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9078e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9079e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9107918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderModule *pShaderModule) { 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9113e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!shader_is_spirv(pCreateInfo)) { 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* dev */ 0, __LINE__, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", "Shader is not SPIR-V"); 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9119e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 9126918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass *pRenderPass) { 9135e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 9144e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) { 9145ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 91995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->subpassToNode = subpass_to_node; 920387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 920487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 920587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 920687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 920787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 920887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 920987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 921087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 921187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachments.push_back(pass_info); 921287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 921387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 921487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, bool> &attachment_first_read = dev_data->renderPassMap[*pRenderPass]->attachment_first_read; 921587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 921687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachment_first_layout; 921787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 921887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 9219b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 9220b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9221b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9222b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 9223b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 92240d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 92250d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 92260d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 92270d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92280d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92290d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 92300d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92310d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92320d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 923387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 92340d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 92350d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 92360d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 92370d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 92380d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92390d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92400d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 92410d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92420d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 92430d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92440d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92450d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 924624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 924724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 924824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 924924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 925024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 925124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 925224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 925387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 925487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 925587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 925687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 925787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 925887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 925987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 926024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 926124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 926224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 926324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 926424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 926524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 926624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 926787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 926887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 926987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 927087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 927187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9272a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9273a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 927424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 927524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 927624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 927724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 927824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 927924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 928024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9281a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 9282a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 9283a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 9284a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 9285a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 928687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 928787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 9323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 93485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 93505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9357d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 93581c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 93591c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, 9368e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 93885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9397e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 93995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9406e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 94195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9426885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 9427885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 9428885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9429885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9430885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9431885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9432885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9433885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9434885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9435885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9436885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9437885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9438885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9439885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9440885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9441885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9442885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9443885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 94495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 945287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 945387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 945487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 945587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 945687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 945772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 945887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 945987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 946087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 946172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 946672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 946887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkImageLayout &attachment_layout = pRPNode->attachment_first_layout[pRPNode->attachments[i].attachment]; 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL || 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, (uint64_t)(pRenderPassBegin->renderPass), __LINE__, 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_LAYOUT, "MEM", "Cannot clear attachment %d with invalid first layout %d.", 947587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->attachments[i].attachment, attachment_layout); 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 947787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 947872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9481e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 948372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 948587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 948672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9487e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 949072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 949387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 949472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 949872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 9504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = pRenderPassBegin->renderPass; 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = pRenderPassBegin->framebuffer; 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->frameBufferMap[pCB->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9534e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 954472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline) { 954572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, 954672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) { 9556e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 955903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 956072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 956172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 956287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(cb_data->second->activeRenderPass); 956387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 956487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 956587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 956687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 956787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 956872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9569e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 957372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 957587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 957672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9577e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9579e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 958172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9598e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 96005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9602e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9603e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkRenderPass primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9604e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 960981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass), primaryAttach, secondaryAttach, 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 96125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9615e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9616e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->attachmentCount <= primaryAttach) { 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data->second->pCreateInfo->attachmentCount <= secondaryAttach) { 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].format != 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].format) { 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].samples != 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].samples) { 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_data->second->pCreateInfo->pAttachments[primaryAttach].flags != 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].flags) { 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9658e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9659e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, const int subpass, 9660e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &primary_desc = primary_data->second->pCreateInfo->pSubpasses[subpass]; 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &secondary_desc = secondary_data->second->pCreateInfo->pSubpasses[subpass]; 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9712e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validateSubpassCompatibility(dev_data, primaryBuffer, primaryPass, secondaryBuffer, secondaryPass, i, is_multi); 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9752e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9753e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer primary_fb = pCB->framebuffer; 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 97625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a framebuffer %" PRIx64 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current framebuffer %" PRIx64 ".", 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid framebuffer %" PRIx64 ".", 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 ". Pipeline statistics is being queried so the command " 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 "of type %d but a query of that type has been started on " 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "secondary Cmd Buffer %p.", 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9823e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers " 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) executed within render pass (%#" PRIxLEAST64 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass); 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass, pCommandBuffers[i], 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass, 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) w/ render pass (%#" PRIxLEAST64 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") is incompatible w/ primary command buffer (%p) w/ render pass (%#" PRIxLEAST64 ") due to: %s", 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass, errorString.c_str()); 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) references framebuffer (%#" PRIxLEAST64 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does not match framebuffer (%#" PRIxLEAST64 ") in active renderpass (%#" PRIxLEAST64 ").", 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass); 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to simultaneously execute CB %#" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%#" PRIxLEAST64 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9909b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") cannot be submitted with a query in " 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 99255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9927e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 99295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9931e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9932e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 993458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 993558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 993758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9955e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 995803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 995958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9962b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9963b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj %#" PRIxLEAST64, (uint64_t)mem); 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 99715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 997358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9976e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 99775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 997803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 997981a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_lock_mutex(&globalLock); 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 998181a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_unlock_mutex(&globalLock); 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 998703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 99885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUnmapMemory(VkDevice device, VkDeviceMemory mem) { 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9990e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 99935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 99945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9995e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10000e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10001e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10002e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 100175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10031e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10066e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 100705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 100715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 10073e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10082e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 100875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 10088e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 100965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10098e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1010094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 1010194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 1010294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1010309df2b6afd74a6494aa530ba23a80ba69abc79dfDustin Graves uint64_t image_handle = reinterpret_cast<uint64_t&>(image); 1010494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 101055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 1010694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1010794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 1010894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1010958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, image_handle, mem, memoryOffset, memRequirements, 1011058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].imageRanges, dev_data->memObjMap[mem].bufferRanges, 1011158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 101120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 101135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1011494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 1011594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 1011694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1011794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 1011894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 1011994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 1012094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 1012194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1012294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1012394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1012494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1012594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 1012694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "vkBindImageMemory: Cannot find invalid image %" PRIx64 ", has it already been deleted?", 1012794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkSetEvent(VkDevice device, VkEvent event) { 101333ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 101343ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 101355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 101373ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 101383ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 101393ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 101403ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 101413ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node->second.in_use.load()) { 101423ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 101433ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 101443ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis "Cannot call vkSetEvent() on event %" PRIxLEAST64 " that is already in use by a command buffer.", 101453ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 101463ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 101473ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 101485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 101496fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 101506fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 101516fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 101526fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 101536fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 101546fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 101556fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 101566fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101576fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101583ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 101593ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 101605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 101655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10167e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 101694b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 101704b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis if ((fence != VK_NULL_HANDLE) && (bindInfoCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 101714b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 1017247c4ec0c3856ae594e26241bf6796785a2150cbfMark Lobodzinski reinterpret_cast<uint64_t &>(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 1017347c4ec0c3856ae594e26241bf6796785a2150cbfMark Lobodzinski "Fence %#" PRIx64 " is already in use by another submission.", reinterpret_cast<uint64_t &>(fence)); 101744b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 101754b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis uint64_t fenceId = 0; 101764b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis skip_call = add_fence_info(dev_data, fence, queue, &fenceId); 101771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 101781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 101795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 101801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 101811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 101821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 101831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10185e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 101891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 101901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 101911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10193e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 101971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 101981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 101991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10201e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 102051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 102061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 102071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 102081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 102091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 102101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 102115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 102131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 102141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 102151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 102201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 102211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 102221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 102245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 102261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "vkQueueBindSparse: Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 102271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 102281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 102295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102340a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 102355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10237e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 102395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 102445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 102455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 102475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 102485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 102501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 102510a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 102665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR *pSwapchain) { 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 102790801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102810801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 102955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 103015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 103025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 103035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 103045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 103075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 103090801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1031094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 103155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 103255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 103320801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 103330801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 103340801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 103350801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 103360801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 103415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkGetSwapchainInfoKHR(%" PRIu64 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 103435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 103485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 103495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 1035094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 1035194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 1035294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 1035394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 1035494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 1035594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 103685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 103695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 103705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 103715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 103751344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = pPresentInfo->pWaitSemaphores[i]; 103761344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 103771344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 103781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 103791344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 103801344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 103811344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 103821344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 103841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 103851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103880801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 103915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 1039403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 103950801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 103960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 103970801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1039803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 104191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 104275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 104281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104301657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 104311657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 104321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 104341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104371344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 104505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 104655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT msgCallback, 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator) { 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 104905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueSubmit")) 104925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueSubmit; 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkWaitForFences")) 104945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkWaitForFences; 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetFenceStatus")) 104965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetFenceStatus; 104975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueWaitIdle")) 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueWaitIdle; 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDeviceWaitIdle")) 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDeviceWaitIdle; 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceQueue")) 105025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceQueue; 105035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFence")) 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFence; 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetFences")) 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetFences; 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySemaphore")) 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySemaphore; 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyEvent")) 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyEvent; 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyQueryPool")) 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyQueryPool; 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBuffer")) 105185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBuffer; 105195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBufferView")) 105205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBufferView; 105215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImage")) 105225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImage; 105235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImageView")) 105245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImageView; 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyShaderModule")) 105265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyShaderModule; 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipeline")) 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipeline; 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipelineLayout")) 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineLayout; 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySampler")) 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySampler; 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorSetLayout; 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorPool")) 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorPool; 105375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFramebuffer")) 105385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFramebuffer; 105395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyRenderPass")) 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyRenderPass; 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBuffer")) 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBuffer; 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBufferView")) 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBufferView; 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImage")) 105465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImage; 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImageView")) 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImageView; 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFence")) 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFence; 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "CreatePipelineCache")) 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineCache; 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "DestroyPipelineCache")) 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineCache; 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "GetPipelineCacheData")) 105565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPipelineCacheData; 105575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "MergePipelineCaches")) 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMergePipelineCaches; 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateGraphicsPipelines")) 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateGraphicsPipelines; 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateComputePipelines")) 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateComputePipelines; 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSampler")) 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSampler; 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorSetLayout; 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreatePipelineLayout")) 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineLayout; 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorPool")) 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorPool; 105715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetDescriptorPool")) 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetDescriptorPool; 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateDescriptorSets")) 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateDescriptorSets; 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeDescriptorSets")) 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeDescriptorSets; 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUpdateDescriptorSets")) 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUpdateDescriptorSets; 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateCommandPool")) 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateCommandPool; 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyCommandPool")) 105825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyCommandPool; 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandPool")) 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandPool; 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateQueryPool")) 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateQueryPool; 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateCommandBuffers")) 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateCommandBuffers; 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeCommandBuffers")) 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeCommandBuffers; 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBeginCommandBuffer")) 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBeginCommandBuffer; 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEndCommandBuffer")) 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEndCommandBuffer; 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandBuffer")) 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandBuffer; 105975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindPipeline")) 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindPipeline; 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetViewport")) 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetViewport; 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetScissor")) 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetScissor; 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetLineWidth")) 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetLineWidth; 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBias")) 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBias; 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetBlendConstants")) 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetBlendConstants; 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBounds")) 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBounds; 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilCompareMask; 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) 106145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilWriteMask; 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilReference")) 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilReference; 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindDescriptorSets")) 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindDescriptorSets; 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindVertexBuffers")) 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindVertexBuffers; 106215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindIndexBuffer")) 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindIndexBuffer; 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDraw")) 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDraw; 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexed")) 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexed; 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndirect")) 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndirect; 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexedIndirect; 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatch")) 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatch; 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatchIndirect")) 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatchIndirect; 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBuffer")) 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBuffer; 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImage")) 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImage; 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBlitImage")) 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBlitImage; 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBufferToImage")) 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBufferToImage; 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImageToBuffer; 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdUpdateBuffer")) 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdUpdateBuffer; 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdFillBuffer")) 106485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdFillBuffer; 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearColorImage")) 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearColorImage; 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearDepthStencilImage; 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearAttachments")) 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearAttachments; 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResolveImage")) 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResolveImage; 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetEvent")) 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetEvent; 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetEvent")) 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetEvent; 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWaitEvents")) 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWaitEvents; 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPipelineBarrier")) 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPipelineBarrier; 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginQuery")) 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginQuery; 106675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndQuery")) 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndQuery; 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetQueryPool")) 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetQueryPool; 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyQueryPoolResults")) 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyQueryPoolResults; 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPushConstants")) 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPushConstants; 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWriteTimestamp")) 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWriteTimestamp; 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFramebuffer")) 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFramebuffer; 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateShaderModule")) 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateShaderModule; 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateRenderPass")) 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateRenderPass; 106835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginRenderPass")) 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginRenderPass; 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdNextSubpass")) 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdNextSubpass; 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndRenderPass")) 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndRenderPass; 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdExecuteCommands")) 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdExecuteCommands; 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkSetEvent")) 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkSetEvent; 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkMapMemory")) 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMapMemory; 1069503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 106965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUnmapMemory")) 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUnmapMemory; 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateMemory")) 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateMemory; 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeMemory")) 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeMemory; 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFlushMappedMemoryRanges")) 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFlushMappedMemoryRanges; 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkInvalidateMappedMemoryRanges")) 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkInvalidateMappedMemoryRanges; 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindBufferMemory")) 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindBufferMemory; 107085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetBufferMemoryRequirements")) 107095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetBufferMemoryRequirements; 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetImageMemoryRequirements")) 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetImageMemoryRequirements; 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetQueryPoolResults")) 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetQueryPoolResults; 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindImageMemory")) 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindImageMemory; 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueBindSparse")) 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueBindSparse; 107195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSemaphore")) 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSemaphore; 107215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateEvent")) 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateEvent; 107235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev == NULL) 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->device_extensions.wsi_enabled) { 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSwapchainKHR")) 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSwapchainKHR; 107335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySwapchainKHR")) 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySwapchainKHR; 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetSwapchainImagesKHR; 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAcquireNextImageKHR")) 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAcquireNextImageKHR; 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueuePresentKHR")) 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueuePresentKHR; 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 107465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetInstanceProcAddr")) 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetInstanceProcAddr; 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateInstance")) 107575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateInstance; 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDevice")) 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDevice; 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 107615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 107625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceLayerProperties; 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceExtensionProperties; 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 107675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceLayerProperties; 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceExtensionProperties; 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (instance == NULL) 107725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkVoidFunction fptr; 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 107775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fptr) 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return fptr; 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 107845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 107865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10787