core_validation.cpp revision 400cff9fad0e19c80f6c9ed1181795d411a4bec5
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 65b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Permission is hereby granted, free of charge, to any person obtaining a copy 75b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * of this software and/or associated documentation files (the "Materials"), to 85b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * deal in the Materials without restriction, including without limitation the 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * rights to use, copy, modify, merge, publish, distribute, sublicense, and/or 105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sell copies of the Materials, and to permit persons to whom the Materials 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are furnished to do so, subject to the following conditions: 125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * The above copyright notice(s) and this permission notice shall be included 145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * in all copies or substantial portions of the Materials. 155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * THE MATERIALS ARE PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE MATERIALS OR THE 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * USE OR OTHER DEALINGS IN THE MATERIALS 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 4194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 4294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 4394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 4694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 5094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_map> 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <unordered_set> 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_config.h" 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_logging.h" 695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) printf(__VA_ARGS__) 775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 85b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 94e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 1045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 10894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 11094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis uint64_t currentFenceId; 111b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> sampleMap; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSet, SET_NODE *> setMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorSetLayout, LAYOUT_NODE *> descriptorSetLayoutMap; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 138918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Current render pass 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassBeginInfo renderPassBeginInfo; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t currentSubpass; 1426c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 145b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 146b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 147b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 14994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 150b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis currentFenceId(1), renderPassBeginInfo{}, currentSubpass(0), device(VK_NULL_HANDLE), phys_dev_properties{}, 151b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis phys_dev_mem_props{} {}; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 156b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_global_layers[] = {{ 158f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(createInfo.ppEnabledLayerNames[i], cv_global_layers[0].layerName)) { 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cv_global_layers[0].layerName); 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t len() { return *it >> 16; } 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t const &word(unsigned n) { return it[n]; } 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 1925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 1945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int globalLockInitialized = 0; 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic loader_platform_thread_mutex globalLock; 24703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 24803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - start of direct pull 24994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 25294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 25394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 25494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 25894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 25994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 26094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski// MTMERGESOURCE - end section 2695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate layer_data *get_my_data_ptr<layer_data>(void *data_key, std::unordered_map<void *, layer_data *> &data_map); 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 27372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *, const VkCommandBuffer); 27472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 27503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void delete_queue_info_list(layer_data *my_data) { 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process queue list, cleaning up each entry before deleting 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap.clear(); 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add a fence, creating one if necessary to our list of fences/fenceIds 282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool add_fence_info(layer_data *my_data, VkFence fence, VkQueue queue, uint64_t *fenceId) { 283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *fenceId = my_data->currentFenceId++; 2855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no fence, create an internal fence to track the submissions 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].fenceId = *fenceId; 2895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->fenceMap[fence].queue = queue; 2905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that fence is in UNSIGNALED state 2915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFenceCreateInfo *pFenceCI = &(my_data->fenceMap[fence].createInfo); 2925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceCI->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 2935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 2945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 2955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence); 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Do we need to create an internal fence here for tracking purposes? 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update most recently submitted fence and fenceId for Queue 3025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queueMap[queue].lastSubmittedId = *fenceId; 3035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove a fenceInfo from our list of fences/fenceIds 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void delete_fence_info(layer_data *my_data, VkFence fence) { my_data->fenceMap.erase(fence); } 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Record information when a fence is known to be signalled 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void update_fence_tracking(layer_data *my_data, VkFence fence) { 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = my_data->fenceMap.find(fence); 3125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != my_data->fenceMap.end()) { 3135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pCurFenceInfo = &(*fence_item).second; 3145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue queue = pCurFenceInfo->queue; 3155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_item = my_data->queueMap.find(queue); 3165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_item != my_data->queueMap.end()) { 3175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*queue_item).second; 3185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pQueueInfo->lastRetiredId < pCurFenceInfo->fenceId) { 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pCurFenceInfo->fenceId; 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update fence state in fenceCreateInfo structure 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFCI = &(my_data->fenceMap[fence].createInfo); 3265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFCI->flags = static_cast<VkFenceCreateFlags>(pFCI->flags | VK_FENCE_CREATE_SIGNALED_BIT); 3275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates the fence list for a specific queue to all-retired 3305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_queue_fences(layer_data *my_data, VkQueue queue) { 3315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper routine that updates all queues to all-retired 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void retire_device_fences(layer_data *my_data, VkDevice device) { 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Process each queue for device 3395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add multiple device support 3405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->queueMap.begin(); ii != my_data->queueMap.end(); ++ii) { 3415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set queue's lastRetired to lastSubmitted indicating all fences completed 3425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &(*ii).second; 3435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pQueueInfo->lastRetiredId = pQueueInfo->lastSubmittedId; 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 3510a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 3520a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 3530a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 354e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 355e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 3575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s %#" PRIxLEAST64 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 37394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 374e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 37694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 3770a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3860a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 38794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 39094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 39958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 40058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 40158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 4035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 4135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 4155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 41758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 4185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 426e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 4275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 42894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 42994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 43058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid swapchain image %" PRIx64 ", please fill the memory before using.", 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 4345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 43858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 4405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Cannot read invalid memory %" PRIx64 ", please fill the memory before using.", functionName, 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 4455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 4485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 44994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 45094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 45194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 4575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 463e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 47158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 4725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 473de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 47572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 47772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 478c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 484400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 485400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 48672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 487c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 488c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 48920b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 491400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 494c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 499400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 500400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 501400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 5025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 505e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 506e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 507de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 508896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 510de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 51158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 5135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory object %#" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 5145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 5155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 5165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 518de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 519de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 52058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 521de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 522de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes "Command Buffer %p still has a reference to mem obj %#" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 525de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 529896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 530896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_FREED_MEM_REF, "MEM", "VK Object %#" PRIxLEAST64 " still has a reference to mem obj %#" PRIxLEAST64, 532896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 535896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 541e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Request to delete memory object %#" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check if fence for given CB is completed 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkCBCompleted(layer_data *my_data, const VkCommandBuffer cb, bool *complete) { 55572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(my_data, cb); 556e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = true; 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 56072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->lastSubmittedQueue != NULL) { 56172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkQueue queue = pCBNode->lastSubmittedQueue; 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QUEUE_NODE *pQueueInfo = &my_data->queueMap[queue]; 56372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode->fenceId > pQueueInfo->lastRetiredId) { 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)cb, __LINE__, MEMTRACK_NONE, "MEM", 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "fence %#" PRIxLEAST64 " for CB %p has not been checked for completion", 56772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCBNode->lastSubmittedFence, cb); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *complete = false; 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 575e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 576e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 57858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 58258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempting to free memory associated with a Persistent Image, %#" PRIxLEAST64 ", " 5855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 592de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 593de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 594de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 595de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 596de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 597de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes bool commandBufferComplete = false; 598de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes skipCall |= checkCBCompleted(dev_data, cb, &commandBufferComplete); 5995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (commandBufferComplete) { 600de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 6015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 605de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 60658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 60958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 6195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 6215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 6225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 6235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 6245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 6295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 630c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 6315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 6320a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 6335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 634e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 63694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 63794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 63994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 641c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 6425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 643896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 6445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 64558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 6465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "While trying to clear mem binding for %s obj %#" PRIxLEAST64 6475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", unable to find that object referenced by mem obj %#" PRIxLEAST64, 6485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 6595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 66094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 66194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 66658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 6675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(%#" PRIxLEAST64 ") to NULL", apiName, handle); 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 67094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, 6734f085d96e1f9ba7cba58b480ae64a8546c9a00eeChris Forbes "MEM", "In %s, attempting to update Binding of %s Obj(%#" PRIxLEAST64 ") that's not in global list", 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), apiName, handle); 6755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // non-null case so should have real mem obj 67758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 67994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 6805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPrevBinding != NULL) { 6815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to bind memory (%#" PRIxLEAST64 ") to object (%#" PRIxLEAST64 6855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") which has already been bound to mem object %#" PRIxLEAST64, 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 688896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemInfo->objBindings.insert({handle, type}); 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For image objects, make sure default memory state is correctly set 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What's the best/correct way to handle this? 6915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 69294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 69394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 69494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 69594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 69694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // TODO:: More memory state transition stuff. 69794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 6985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 7015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 7095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 7105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 7130a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 7140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 7150a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 7160a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 7185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 7190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 72294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!pMemBinding) { 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 72458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_MISSING_MEM_BINDINGS, "MEM", 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In %s, attempting to update Binding of Obj(%#" PRIxLEAST64 ") that's not in global list()", apiName, handle); 72694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 72794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // non-null case so should have real mem obj 72894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 72994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pInfo) { 73094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis pInfo->objBindings.insert({handle, type}); 73194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Need to set mem binding for this object 73294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = mem; 73394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 7400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 74194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 7435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 74494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 74594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 74694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 74894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Trying to get mem binding for object %#" PRIxLEAST64 " but no such object in %s list", handle, 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 7560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 75758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 76058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 76558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 76758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 76858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at %p===", (void *)pInfo); 77958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: %#" PRIxLEAST64, (uint64_t)(pInfo->mem)); 78158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 782c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 783de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 78658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 795896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 796896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 797896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 79858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 799896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT %" PRIu64, obj.handle); 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 806de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 807de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 808de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 80958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 810de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB %p", cb); 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8160a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 81772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 82572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 82672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 83472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " CB Info (%p) has CB %p, fenceId %" PRIx64 ", and fence %#" PRIxLEAST64, 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCBInfo, (void *)pCBInfo->commandBuffer, pCBInfo->fenceId, (uint64_t)pCBInfo->lastSubmittedFence); 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 840c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 842c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 844c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Mem obj %" PRIu64, (uint64_t)obj); 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 9745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 9845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 9935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 9985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 10025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 10095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool shader_is_spirv(VkShaderModuleCreateInfo const *pCreateInfo) { 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t *words = (uint32_t *)pCreateInfo->pCode; 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t sizeInWords = pCreateInfo->codeSize / sizeof(uint32_t); 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Just validate that the header makes sense. */ 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return sizeInWords >= 5 && words[0] == spv::MagicNumber && words[1] == spv::Version; 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10829ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 10909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10929ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 10939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 10969ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 10989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 10999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 11039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11069ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 11079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 11119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 11129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 11149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 11169ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 11179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 11189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 11199ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 11209ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 11219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11239ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11269ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 11279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 11309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 11319ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 11349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 11379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11419ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11429ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 11439ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 11449ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 11459ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 11469ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 11479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 11489ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 114937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 115037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 115137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 115237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 115337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 115437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 115537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 115637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 115737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11647c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 116537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 11667c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11677c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 117037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 117137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 117237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 117337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 117437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11817c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 11827c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 118337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 11847c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11857c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11867c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 11877c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 11887c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 11897c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 11907c755c8aca6857046df9516d8336416165969cb9Chris Forbes 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11937c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 11967c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 11997c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 120137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 120237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 120337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 120437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 120537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 120637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 120737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 120837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 120937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 121137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 121237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 121737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 122737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1284b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1288031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1289031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1290031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1291031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1292031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1293031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1294031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1295031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1296031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1297031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1298031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1299031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1300031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1301031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13186c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_block_members(layer_data *my_data, shader_module const *src, 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1321b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1323031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 13245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 13475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 13605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1361b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13696c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_location(layer_data *my_data, shader_module const *src, spirv_inst_iter entrypoint, 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1376b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1399b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1400b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1401b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1402b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 140881264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1413c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14241d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 14305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1431b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 14447c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1450b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 14545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1455b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes collect_interface_block_members(my_data, src, out, blocks, is_array_of_verts, id, type, is_patch); 14565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14616c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic void collect_interface_by_descriptor_slot(layer_data *my_data, shader_module const *src, 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 14645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 14695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 14705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 14715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 14725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 14735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 14745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 14755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 14795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1495080afef66a53dbdd085698b713697296458edfd9Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1505b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1506b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15126c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_interface_between_stages(layer_data *my_data, shader_module const *producer, 1513031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1515031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1521031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1522031261d21af8907953dd763398ce9a23e65b8749Chris Forbes collect_interface_by_location(my_data, consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1535080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1536080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1537031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1538031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1543080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1545031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1546031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 15510f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1552031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch, 155337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch, 155437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1555080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 15579ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 15589ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 15599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15630f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 15640f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 15650f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1566f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 15670f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 15680f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 15690f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 15700f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 15710f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15720f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 16035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 16165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 16505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16606c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_consistency(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi) { 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 16625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 16655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1671080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16846c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_vi_against_vs_inputs(layer_data *my_data, VkPipelineVertexInputStateCreateInfo const *vi, 16855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16896c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, vs, entrypoint, spv::StorageClassInput, inputs, false); 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attribs[vi->pVertexAttributeDescriptions[i].location] = &vi->pVertexAttributeDescriptions[i]; 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1707080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1708080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1726080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 17299ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 17309ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17446c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_fs_outputs_against_render_pass(layer_data *my_data, shader_module const *fs, 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const std::vector<VkFormat> &color_formats = rp->subpassColorFormats[subpass]; 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17526c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes collect_interface_by_location(my_data, fs, entrypoint, spv::StorageClassOutput, outputs, false); 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = outputs.begin(); 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = 0; 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk attachment list and outputs together -- this is a little overpowered since attachments 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are currently dense, but the parallel with matching between shader stages is nice. 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && it != outputs.end()) || attachment < color_formats.size()) { 17625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == color_formats.size() || (it != outputs.end() && it->first.first < attachment)) { 1763080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "FS writes to output location %d with no matching attachment", it->first.first)) { 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (it == outputs.end() || it->first.first > attachment) { 1770080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", attachment)) { 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned output_type = get_fundamental_type(fs, it->second.type_id); 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned att_type = get_format_type(color_formats[attachment]); 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1781080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d of type `%s` does not match FS output type of `%s`", attachment, 17849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(color_formats[attachment]), 17859ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(fs, it->second.type_id).c_str())) { 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it++; 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment++; 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 181981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 18485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1899c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1905c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19166c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_block_against_pipeline(layer_data *my_data, 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 19305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 19315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1942080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1943080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 19525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1956080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1957080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19716c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbesstatic bool validate_push_constant_usage(layer_data *my_data, 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1979080afef66a53dbdd085698b713697296458edfd9Chris Forbes pass &= validate_push_constant_block_against_pipeline(my_data, pushConstantRanges, src, 1980080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipelineLayout verify that the setLayout at slot.first 19885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// has the requested binding at slot.second 198978be5018e238bd464b1f1c55138df277c0c18922Chris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(layer_data *my_data, PIPELINE_LAYOUT_NODE *pipelineLayout, descriptor_slot_t slot) { 19905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 199237083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 199478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 199537083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 199778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto const layout_node = my_data->descriptorSetLayoutMap[pipelineLayout->descriptorSetLayouts[slot.first]]; 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingIt = layout_node->bindingToIndexMap.find(slot.second); 200014fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis if ((bindingIt == layout_node->bindingToIndexMap.end()) || (layout_node->createInfo.pBindings == NULL)) 200137083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 20025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 200314fbd08bf52bcbd4b5e65538d30c643c04535e30Tobin Ehlis assert(bindingIt->second < layout_node->createInfo.bindingCount); 200437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return &layout_node->createInfo.pBindings[bindingIt->second]; 20055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 20085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 20125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2016e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 20175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2019e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2021e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 20273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 20283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 20293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 20303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "CB object %#" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2032e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic PIPELINE_NODE *getPipeline(layer_data *my_data, const VkPipeline pipeline) { 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.find(pipeline) == my_data->pipelineMap.end()) { 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->pipelineMap[pipeline]; 20415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2043e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2044e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2051e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2055e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2061ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2062ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2063ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 206745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 206845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 20733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 20753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 207645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 207745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 20783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 20803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 208145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 208245824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 20833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 20853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 20873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 20893d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20903d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 20913d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 20943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 210806e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 210906e963555b0df747c98c43816c16647349d21001Mark Young return true; 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 211106e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 211206e963555b0df747c98c43816c16647349d21001Mark Young return true; 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 21175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis stringstream errorStr; 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.find(primaryRP) == my_data->renderPassMap.end()) { 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (my_data->renderPassMap.find(secondaryRP) == my_data->renderPassMap.end()) { 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *primaryRPCI = my_data->renderPassMap[primaryRP]->pCreateInfo; 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI = my_data->renderPassMap[secondaryRP]->pCreateInfo; 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 21555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2171fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2172fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2173fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2174fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2175fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2176fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2177fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2178fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2179fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2180fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 21895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give SET_NODE, verify that its Set is compatible w/ the setLayout corresponding to pipelineLayout[layoutIndex] 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const SET_NODE *pSet, const VkPipelineLayout layout, 21995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t layoutIndex, string &errorMsg) { 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis stringstream errorStr; 2201ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes auto pipeline_layout_it = my_data->pipelineLayoutMap.find(layout); 2202ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (pipeline_layout_it == my_data->pipelineLayoutMap.end()) { 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2207ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes if (layoutIndex >= pipeline_layout_it->second.descriptorSetLayouts.size()) { 2208ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout_it->second.descriptorSetLayouts.size() 2209ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout_it->second.descriptorSetLayouts.size() - 1 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get the specific setLayout from PipelineLayout that overlaps this set 2215ea26140408c3361500b5d5b8498a4f28a3e92ef5Chris Forbes LAYOUT_NODE *pLayoutNode = my_data->descriptorSetLayoutMap[pipeline_layout_it->second.descriptorSetLayouts[layoutIndex]]; 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->layout == pSet->pLayout->layout) { // trivial pass case 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t descriptorCount = pLayoutNode->descriptorTypes.size(); 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (descriptorCount != pSet->pLayout->descriptorTypes.size()) { 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "setLayout " << layoutIndex << " from pipelineLayout " << layout << " has " << descriptorCount 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors, but corresponding set being bound has " << pSet->pLayout->descriptorTypes.size() 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " descriptors."; 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; // trivial fail case 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now need to check set against corresponding pipelineLayout to verify compatibility 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (size_t i = 0; i < descriptorCount; ++i) { 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to verify that layouts are identically defined 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is below sufficient? Making sure that types & stageFlags match per descriptor 22315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // do we also need to check immutable samplers? 22325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->descriptorTypes[i] != pSet->pLayout->descriptorTypes[i]) { 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "descriptor " << i << " for descriptorSet being bound is type '" 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pSet->pLayout->descriptorTypes[i]) 22355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout is type '" 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << string_VkDescriptorType(pLayoutNode->descriptorTypes[i]) << "'"; 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayoutNode->stageFlags[i] != pSet->pLayout->stageFlags[i]) { 22415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "stageFlags " << i << " for descriptorSet being bound is " << pSet->pLayout->stageFlags[i] 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << "' but corresponding descriptor from pipelineLayout has stageFlags " << pLayoutNode->stageFlags[i]; 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2251e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_specialization_offsets(layer_data *my_data, VkPipelineShaderStageCreateInfo const *info) { 2252e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2267e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool descriptor_type_match(layer_data *my_data, shader_module const *module, uint32_t type_id, 22771b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22801b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 22811b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 22827b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 22837b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 22857b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 22867b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 22877b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 22887b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22897b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 22907b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 22917b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 23105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 23135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 23145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 231635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 231735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 231835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 231935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 232035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 232135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 232235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 232335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 232435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 232535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 23265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 23295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 23335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 23355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 23365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 23385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 23395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 23405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 23415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 23425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 23445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 23465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 23475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 23485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 23495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2360e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool require_feature(layer_data *my_data, VkBool32 feature, char const *feature_name) { 2361a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 2362080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2363080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2364a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2365a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2366a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2367a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2368a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2369a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2370a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2371a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2372a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2373a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2374e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_shader_capabilities(layer_data *my_data, shader_module const *src) { 2375e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2376a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2377b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto enabledFeatures = &my_data->phys_dev_properties.features; 2378a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2379a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2380a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2381a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2382a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2383a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2384a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2385a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2386a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2387a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2388a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2389a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2390a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2391a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2392a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 2395a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->geometryShader, "geometryShader"); 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 2399a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->tessellationShader, "tessellationShader"); 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 2403a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 2407a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderInt64, "shaderInt64"); 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2411a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2415a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2419a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2423a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2427a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2432a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2436a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2441a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2446a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2450a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2454a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2463a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2464a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 2465a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2466a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2467a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2468a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 2469a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2470a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2471a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2472a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 2473a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2474a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2475a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2476a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 2477a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageExtendedFormats, 2478a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2479a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2480a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2481a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 2482a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2483a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2484a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2485a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 2486a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2487a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2488a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2489a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2490a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 2491a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2492a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2493a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2494a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2495a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 2496a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes pass &= require_feature(my_data, enabledFeatures->multiViewport, "multiViewport"); 2497a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2498a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2499a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 2500080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2501a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2502a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2503a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2504e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2505a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2506a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2507a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2508a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2509a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2510a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2511a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2512a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2513e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_pipeline_shader_stage(layer_data *dev_data, VkPipelineShaderStageCreateInfo const *pStage, 2514e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves PIPELINE_NODE *pipeline, PIPELINE_LAYOUT_NODE *pipelineLayout, 2515e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves shader_module **out_module, spirv_inst_iter *out_entrypoint) { 2516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 251778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto module = *out_module = dev_data->shaderModuleMap[pStage->module].get(); 251878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_specialization_offsets(dev_data, pStage); 251978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 252078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 252178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 252278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2523080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2524080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 252578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 252678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 252878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 252978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 253078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 253278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_shader_capabilities(dev_data, module); 253378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 253578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 253678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 253778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 253878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 253978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 254078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes collect_interface_by_descriptor_slot(dev_data, module, accessible_ids, descriptor_uses); 254178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 254378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_push_constant_usage(dev_data, &pipelineLayout->pushConstantRanges, 254478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 254578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 254678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 254778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 254878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 254978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 255078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the matching binding */ 255278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto binding = get_descriptor_binding(dev_data, pipelineLayout, use.first); 255378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 255478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2556080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2557080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 255878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 255978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 256178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 256278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 256378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 256478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 256578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 256678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 256778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 256878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 256978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 257078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 257278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 257378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (!descriptor_type_match(dev_data, module, use.second.type_id, binding->descriptorType, /*out*/ required_descriptor_count)) { 2574080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2575080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 257678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Type mismatch on descriptor slot " 257778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "%u.%u (used as type `%s`) but " 257878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "descriptor of type %s", 257978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, 258078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 258178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 258378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 258478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2585080afef66a53dbdd085698b713697296458edfd9Chris Forbes if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2586080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 258778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 258878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 258978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes describe_type(module, use.second.type_id).c_str(), 259078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes binding->descriptorCount)) { 2591e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 259278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 259578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 259778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 259878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 259978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2600a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2601a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2602e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_capture_pipeline_shader_state(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2603ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkGraphicsPipelineCreateInfo const *>(&pPipeline->graphicsPipelineCI); 26045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 26065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 26085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 26095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 26105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 26115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 26135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 261478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 261578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 2617ca546210846c65808717f8875deae39bd227c240Tobin Ehlis VkPipelineShaderStageCreateInfo const *pStage = 2618ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<VkPipelineShaderStageCreateInfo const *>(&pCreateInfo->pStages[i]); 261978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 262078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pass &= validate_pipeline_shader_stage(my_data, pStage, pPipeline, pipelineLayout, 262178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes &shaders[stage_id], &entrypoints[stage_id]); 26225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 26255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 262709042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_consistency(my_data, vi); 26285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 263109042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_vi_against_vs_inputs(my_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 26325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 26355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 26365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 26385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 26395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 26405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 26435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 26445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2645031261d21af8907953dd763398ce9a23e65b8749Chris Forbes pass &= validate_interface_between_stages(my_data, 2646031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2647031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 265378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto rp = pCreateInfo->renderPass != VK_NULL_HANDLE ? my_data->renderPassMap[pCreateInfo->renderPass] : nullptr; 265478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 26555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[fragment_stage] && rp) { 265609042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pass &= validate_fs_outputs_against_render_pass(my_data, shaders[fragment_stage], entrypoints[fragment_stage], rp, 265709042aa0b6f4b3c579f58ed07c9eb4f20899e0beChris Forbes pCreateInfo->subpass); 26585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2663e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_compute_pipeline(layer_data *my_data, PIPELINE_NODE *pPipeline) { 2664ca546210846c65808717f8875deae39bd227c240Tobin Ehlis auto pCreateInfo = reinterpret_cast<VkComputePipelineCreateInfo const *>(&pPipeline->computePipelineCI); 266503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 266603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes auto pipelineLayout = pCreateInfo->layout != VK_NULL_HANDLE ? &my_data->pipelineLayoutMap[pCreateInfo->layout] : nullptr; 266703857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 266803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 266903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 267003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 267103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes return validate_pipeline_shader_stage(my_data, &pCreateInfo->stage, pPipeline, pipelineLayout, 267203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes &module, &entrypoint); 267303857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 267403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 26755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 26765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic SET_NODE *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 26775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 26785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 26795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 26815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2682a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2683a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given Layout Node and binding, return index where that binding begins 2684a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingStartIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2685a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2686a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2687a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2688a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2689a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2690a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2691a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex; 2692a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2693a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 2694a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// For given layout node and binding, return last index that is updated 2695a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlisstatic uint32_t getBindingEndIndex(const LAYOUT_NODE *pLayout, const uint32_t binding) { 2696a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t offsetIndex = 0; 2697a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 2698a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis offsetIndex += pLayout->createInfo.pBindings[i].descriptorCount; 2699a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis if (pLayout->createInfo.pBindings[i].binding == binding) 2700a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis break; 2701a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis } 2702a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis return offsetIndex - 1; 2703a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis} 2704a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis 27057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 27067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 27077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 27087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 27097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 27107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 27117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2712e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 27137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 27147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis const vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> &activeSetBindingsPairs) { 2715e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 27165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 27175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 27185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dynOffsetIndex = 0; 27195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize bufferSize = 0; 2720a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2721a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis SET_NODE *set_node = set_bindings_pair.first; 2722a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis LAYOUT_NODE *layout_node = set_node->pLayout; 2723a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto binding : set_bindings_pair.second) { 2724a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t startIdx = getBindingStartIndex(layout_node, binding); 2725a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t endIdx = getBindingEndIndex(layout_node, binding); 2726a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (uint32_t i = startIdx; i <= endIdx; ++i) { 2727e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // We did check earlier to verify that set was updated, but now make sure given slot was updated 2728e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // TODO : Would be better to store set# that set is bound to so we can report set.binding[index] not updated 2729e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis if (!set_node->pDescriptorUpdates[i]) { 2730e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2731e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2732e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2733e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "DS %#" PRIxLEAST64 " bound and active but it never had binding %u updated. It is now being used to draw so " 2734e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "this will result in undefined behavior.", 2735e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), binding); 2736e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else { 2737e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis switch (set_node->pDescriptorUpdates[i]->sType) { 2738e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 2739e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS = (VkWriteDescriptorSet *)set_node->pDescriptorUpdates[i]; 2740e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis if ((pWDS->descriptorType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 2741e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 2742e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 274394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis bufferSize = dev_data->bufferMap[pWDS->pBufferInfo[j].buffer].createInfo.size; 2744e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis uint32_t dynOffset = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].dynamicOffsets[dynOffsetIndex]; 2745e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis if (pWDS->pBufferInfo[j].range == VK_WHOLE_SIZE) { 2746e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis if ((dynOffset + pWDS->pBufferInfo[j].offset) > bufferSize) { 2747e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2748e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2749e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2750e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2751e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 ") bound as set #%u has range of " 2752e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "VK_WHOLE_SIZE but dynamic offset %#" PRIxLEAST32 ". " 2753e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "combined with offset %#" PRIxLEAST64 " oversteps its buffer (%#" PRIxLEAST64 2754e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis ") which has a size of %#" PRIxLEAST64 ".", 2755e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2756e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->pBufferInfo[j].offset, 2757e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 2758e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2759e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if ((dynOffset + pWDS->pBufferInfo[j].offset + pWDS->pBufferInfo[j].range) > bufferSize) { 27607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 2761c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2762c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), __LINE__, 2763c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis DRAWSTATE_DYNAMIC_OFFSET_OVERFLOW, "DS", 2764e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 2765e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis ") bound as set #%u has dynamic offset %#" PRIxLEAST32 ". " 2766e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "Combined with offset %#" PRIxLEAST64 " and range %#" PRIxLEAST64 2767e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis " from its update, this oversteps its buffer " 2768e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis "(%#" PRIxLEAST64 ") which has a size of %#" PRIxLEAST64 ".", 2769e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis reinterpret_cast<const uint64_t &>(set_node->set), i, dynOffset, 2770e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->pBufferInfo[j].offset, pWDS->pBufferInfo[j].range, 2771c7f3656e5af8628fa6670d67feea563cecfece19Tobin Ehlis reinterpret_cast<const uint64_t &>(pWDS->pBufferInfo[j].buffer), bufferSize); 27725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2773e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis dynOffsetIndex++; 2774e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2775e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 2776e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2777e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 2778e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2779e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 2780e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2781e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(dev_data->bufferViewMap.find(pWDS->pTexelBufferView[j]) != dev_data->bufferViewMap.end()); 2782e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 2783e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } 2784e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 2785e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 2786e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 2787e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 27885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2790e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis i += pWDS->descriptorCount; // Advance i to end of this set of descriptors (++i at end of for loop will move 1 2791e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis // index past last of these descriptors) 2792e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis break; 2793e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis default: // Currently only shadowing Write update nodes so shouldn't get here 2794e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis assert(0); 2795e1e6c09294ddc4f915a332b495db9c14163b2cd3Tobin Ehlis continue; 27965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 27995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// TODO : This is a temp function that naively updates bound storage images and buffers based on which descriptor sets are bound. 28047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// When validate_and_update_draw_state() handles computer shaders so that active_slots is correct for compute pipelines, this 28057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// function can be killed and validate_and_update_draw_state() used instead 28067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlisstatic void update_shader_storage_images_and_buffers(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 28077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkWriteDescriptorSet *pWDS = nullptr; 28087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis SET_NODE *pSet = nullptr; 28097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For the bound descriptor sets, pull off any storage images and buffers 28107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // This may be more than are actually updated depending on which are active, but for now this is a stop-gap for compute 28117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // pipelines 28127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto set : pCB->lastBound[VK_PIPELINE_BIND_POINT_COMPUTE].uniqueBoundSets) { 28137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Get the set node 28147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pSet = getSetNode(dev_data, set); 28157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For each update in the set 28167a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto pUpdate : pSet->pDescriptorUpdates) { 28177a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If it's a write update to STORAGE type capture image/buffer being updated 28187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pUpdate && (pUpdate->sType == VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET)) { 28197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS = reinterpret_cast<VkWriteDescriptorSet *>(pUpdate); 28207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE) { 28217a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.insert(pWDS->pImageInfo[j].imageView); 28237a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28247a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER) { 28257a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(dev_data->bufferViewMap[pWDS->pTexelBufferView[j]].buffer); 28277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else if (pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 28297a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pWDS->descriptorType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 28307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (uint32_t j = 0; j < pWDS->descriptorCount; ++j) { 28317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.insert(pWDS->pBufferInfo[j].buffer); 28327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis} 28385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2840e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2842e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 28447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 28453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 28467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 28477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 28487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 28495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 28505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Currently only performing next check if *something* was bound (non-zero last bound) 28515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There is probably a better way to gate when this check happens, and to know if something *should* have been bound 28525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // We should have that check separately and then gate this check based on that check 28535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipe) { 285472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (state.pipelineLayout) { 28555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString; 28565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2857a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis vector<std::pair<SET_NODE *, unordered_set<uint32_t>>> activeSetBindingsPairs; 2858a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto setBindingPair : pPipe->active_slots) { 2859a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis uint32_t setIndex = setBindingPair.first; 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If valid set is not bound throw an error 286172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 28625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 28635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 28645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkPipeline %#" PRIxLEAST64 " uses set #%u but that set is not bound.", 28655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPipe->pipeline, setIndex); 286672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, my_data->setMap[state.boundDescriptorSets[setIndex]], 28675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipe->graphicsPipelineCI.layout, setIndex, errorString)) { 28685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 286972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet setHandle = my_data->setMap[state.boundDescriptorSets[setIndex]]->set; 28705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg( 28715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 28725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 28735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSet (%#" PRIxLEAST64 28745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") bound as set #%u is not compatible with overlapping VkPipelineLayout %#" PRIxLEAST64 " due to: %s", 28755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)setHandle, setIndex, (uint64_t)pPipe->graphicsPipelineCI.layout, errorString.c_str()); 28767a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 28775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull the set node 287872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis SET_NODE *pSet = my_data->setMap[state.boundDescriptorSets[setIndex]]; 28795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2880a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // activeSetNodes.push_back(pSet); 2881a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis activeSetBindingsPairs.push_back(std::make_pair(pSet, setBindingPair.second)); 28825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure set has been updated 28835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet->pUpdateStructs) { 28845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 28855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pSet->set, __LINE__, 28865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 28875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS %#" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 28885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this will result in undefined behavior.", 28895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSet->set); 28905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 28947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 28957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 28967a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) { 28977a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Verify Vtx binding 28987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pPipe->vertexBindingDescriptions.size() > 0) { 28997a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (size_t i = 0; i < pPipe->vertexBindingDescriptions.size(); i++) { 29007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 29017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "The Pipeline State Object (%#" PRIxLEAST64 29047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 29057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis " should be set via vkCmdBindVertexBuffers.", 29067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)state.pipeline, i); 29077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } else { 29107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (!pCB->currentDrawData.buffers.empty()) { 29117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 29127a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 29137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Vertex buffers are bound to command buffer (%#" PRIxLEAST64 29147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (%#" PRIxLEAST64 ").", 29157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29187a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 29197a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // Skip check if rasterization is disabled or there is no viewport. 29207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if ((!pPipe->graphicsPipelineCI.pRasterizationState || 292145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 29227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pPipe->graphicsPipelineCI.pViewportState) { 2923e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipe, VK_DYNAMIC_STATE_VIEWPORT); 2924e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipe, VK_DYNAMIC_STATE_SCISSOR); 29257a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynViewport) { 29267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->viewports.size() != pPipe->graphicsPipelineCI.pViewportState->viewportCount) { 29277a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29287a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29297a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 29307a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO viewportCount is %u. These counts must match.", 29317a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->viewports.size(), pPipe->graphicsPipelineCI.pViewportState->viewportCount); 29327a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29337a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (dynScissor) { 29357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (pCB->scissors.size() != pPipe->graphicsPipelineCI.pViewportState->scissorCount) { 29367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 29377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 29387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 29397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis ", but PSO scissorCount is %u. These counts must match.", 29407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->scissors.size(), pPipe->graphicsPipelineCI.pViewportState->scissorCount); 29417a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 29425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 29475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2950e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2951e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 29555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 29605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 29615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 29625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 29635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 29735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 29745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 29775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 29835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 2987b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 29883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 298926c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 2990c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 2991c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 2992c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 2993c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 2994c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 2995c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 2996c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 2997c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 2998c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 2999c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 3000c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3001c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 3002c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 3003c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3007b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3024a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 30265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 30275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = my_data->renderPassMap.find(pPipeline->graphicsPipelineCI.renderPass); 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != my_data->renderPassMap.end() && 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass >= rp_data->second->pCreateInfo->subpassCount) { 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 30335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.subpass, rp_data->second->pCreateInfo->subpassCount - 1); 30345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 30366c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data, pPipeline)) { 3037e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 303952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 304052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 304152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 304252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 304352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 304452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 304552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 304652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 304752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 304852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 304952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 30575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 30585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 30595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 30625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 30685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3075ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3076ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 30805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3082ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3083ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 30845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3090ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3091ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3092ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3093ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3094ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3095ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3096ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3097ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3103ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 311045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 31165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 31175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3121ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3122ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 31245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3125e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3126e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 31275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 31305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 31335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 31345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 31555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3158ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3159ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given pipeline, return number of MSAA samples, or one if MSAA disabled 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic VkSampleCountFlagBits getNumSamples(layer_data *my_data, const VkPipeline pipeline) { 31665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipe = my_data->pipelineMap[pipeline]; 3167ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pMultisampleState && 3168ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pPipe->graphicsPipelineCI.pMultisampleState->sType)) { 3169ca546210846c65808717f8875deae39bd227c240Tobin Ehlis return pPipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_SAMPLE_COUNT_1_BIT; 31725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state related to the PSO 3175e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePipelineState(layer_data *my_data, const GLOBAL_CB_NODE *pCB, const VkPipelineBindPoint pipelineBindPoint, 3176e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipeline pipeline) { 3177e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == pipelineBindPoint) { 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that any MSAA request in PSO matches sample# in bound FB 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip the check if rasterization is disabled. 31815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = my_data->pipelineMap[pipeline]; 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 318345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits psoNumSamples = getNumSamples(my_data, pipeline); 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = my_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits subpassNumSamples = (VkSampleCountFlagBits)0; 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pSD->colorAttachmentCount; i++) { 31925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampleCountFlagBits samples; 31935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 31955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 31965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis samples = pRPCI->pAttachments[pSD->pColorAttachments[i].attachment].samples; 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) { 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (subpassNumSamples != samples) { 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 32035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSD->pDepthStencilAttachment && pSD->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 32065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampleCountFlagBits samples = pRPCI->pAttachments[pSD->pDepthStencilAttachment->attachment].samples; 32075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpassNumSamples == (VkSampleCountFlagBits)0) 32085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = samples; 32095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else if (subpassNumSamples != samples) 32105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpassNumSamples = (VkSampleCountFlagBits)-1; 32115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 321304826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak if ((pSD->colorAttachmentCount > 0 || pSD->pDepthStencilAttachment) && 321404826a08000a815c3d7949348c7dfcaac277d7c9Dominik Witczak psoNumSamples != subpassNumSamples) { 32150292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 32160292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 32170292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young "Num samples mismatch! Binding PSO (%#" PRIxLEAST64 32180292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young ") with %u samples while current RenderPass (%#" PRIxLEAST64 ") w/ %u samples!", 32190292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young (uint64_t)pipeline, psoNumSamples, (uint64_t)pCB->activeRenderPass, subpassNumSamples); 32205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : I believe it's an error if we reach this point and don't have an activeRenderPass 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify and flag error as appropriate 32245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add more checks here 32275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 32285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Validate non-gfx pipeline updates 32295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32300292df5015fd4bc660ec2612ad8e9b091059b3f5Mark Young return skipCall; 32315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 32345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 32365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(layer_data *my_data, const VkDescriptorPool pool) { 32375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.find(pool) == my_data->descriptorPoolMap.end()) { 32385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorPoolMap[pool]; 32415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic LAYOUT_NODE *getLayoutNode(layer_data *my_data, const VkDescriptorSetLayout layout) { 32445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.find(layout) == my_data->descriptorSetLayoutMap.end()) { 32455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 32465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->descriptorSetLayoutMap[layout]; 32485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3250e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3251e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 32565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 32585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 32605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 32705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 32715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 32725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 32735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 32805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex; 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, const uint32_t binding, 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return getBindingStartIndex(pLayout, binding) + arrayIndex + count - 1; 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const LAYOUT_NODE *pLayout, 3292e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32951d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3303e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3311e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set first stageFlags as reference and verify that all other updates match it 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags refStageFlags = pLayout->stageFlags[startIndex]; 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = startIndex; i <= endIndex; i++) { 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->descriptorTypes[i] != actualType) { 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(pLayout->descriptorTypes[i])); 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->stageFlags[i] != refStageFlags) { 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_STAGEFLAGS_MISMATCH, "DS", 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Write descriptor update has stageFlags %x that do not match overlapping binding descriptor stageFlags of %x!", 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis refStageFlags, pLayout->stageFlags[i]); 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Determine the update type, allocate a new struct of that type, shadow the given pUpdate 3335e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// struct into the pNewNode param. Return true if error condition encountered and callback signals early exit. 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 3337e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool shadowUpdateNode(layer_data *my_data, const VkDevice device, GENERIC_HEADER *pUpdate, GENERIC_HEADER **pNewNode) { 3338e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 33405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCopyDescriptorSet *pCDS = NULL; 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdate->sType) { 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = new VkWriteDescriptorSet; 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pWDS; 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pWDS, pUpdate, sizeof(VkWriteDescriptorSet)); 33465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorImageInfo *info = new VkDescriptorImageInfo[pWDS->descriptorCount]; 33535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pImageInfo, pWDS->descriptorCount * sizeof(VkDescriptorImageInfo)); 33545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pImageInfo = info; 33555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 33565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 33575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 33585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBufferView *info = new VkBufferView[pWDS->descriptorCount]; 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pTexelBufferView, pWDS->descriptorCount * sizeof(VkBufferView)); 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pTexelBufferView = info; 33615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 33625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 33645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 33655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 33665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorBufferInfo *info = new VkDescriptorBufferInfo[pWDS->descriptorCount]; 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(info, pWDS->pBufferInfo, pWDS->descriptorCount * sizeof(VkDescriptorBufferInfo)); 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS->pBufferInfo = info; 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 33705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 33725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS = new VkCopyDescriptorSet; 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *pNewNode = (GENERIC_HEADER *)pCDS; 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCDS, pUpdate, sizeof(VkCopyDescriptorSet)); 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), pUpdate->sType)) 3385e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that pNext for the end of shadow copy is NULL 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (*pNewNode)->pNext = NULL; 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given sampler is valid 3393e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSampler(const layer_data *my_data, const VkSampler *pSampler, const bool immutable) { 3394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 33955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->sampleMap.find(*pSampler); 33965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->sampleMap.end()) { 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!immutable) { 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid sampler %#" PRIxLEAST64, 34015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // immutable 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_SAMPLER_DESCRIPTOR_ERROR, "DS", 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor whose binding has an invalid immutable " 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "sampler %#" PRIxLEAST64, 34075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler); 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the sampler? 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 34164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 34174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 34184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 34244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 34254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 34284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 34314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 34324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 34344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 34374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 34384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 34404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 34414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 34424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 34434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 34444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 34454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 34484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 34494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 34504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 34514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 34524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 34544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 34554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 34564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 34574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 34584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 34594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 34604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 34614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 34624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 34655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 34664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 34674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 34684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 34694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 34704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 34714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 34734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 34834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 34844a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 34854a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 34864a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 34874a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 34884a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 34895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 34904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 34934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 354008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 354308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 354408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 354508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 354608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 355008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 355208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 355308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 35597068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 35607068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 35617068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 356208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 356608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 356708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 356808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 356908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 357008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 357108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 357408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 357508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 357708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 357808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 357908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 358008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 358308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 358508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 35935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given imageView is valid 3605e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateImageView(const layer_data *my_data, const VkImageView *pImageView, const VkImageLayout imageLayout) { 3606e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto ivIt = my_data->imageViewMap.find(*pImageView); 36085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ivIt == my_data->imageViewMap.end()) { 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid imageView %#" PRIxLEAST64, 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that imageLayout is compatible with aspectMask and image format 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageAspectFlags aspectMask = ivIt->second.subresourceRange.aspectMask; 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = ivIt->second.image; 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Check here in case we have a bad image 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFormat format = VK_FORMAT_MAX_ENUM; 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt != my_data->imageMap.end()) { 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = (*imgIt).second.createInfo.format; 36225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Also need to check the swapchains. 36245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchainIt = my_data->device_extensions.imageToSwapchainMap.find(image); 36255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchainIt != my_data->device_extensions.imageToSwapchainMap.end()) { 36265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR swapchain = swapchainIt->second; 36275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_nodeIt = my_data->device_extensions.swapchainMap.find(swapchain); 36285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_nodeIt != my_data->device_extensions.swapchainMap.end()) { 36295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SWAPCHAIN_NODE *pswapchain_node = swapchain_nodeIt->second; 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = pswapchain_node->createInfo.imageFormat; 36315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (format == VK_FORMAT_MAX_ENUM) { 36355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid image %#" PRIxLEAST64 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " in imageView %#" PRIxLEAST64, 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)image, (uint64_t)*pImageView); 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3641e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool ds = vk_format_is_depth_or_stencil(format); 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (imageLayout) { 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Only Color bit must be set 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) != VK_IMAGE_ASPECT_COLOR_BIT) { 36465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have VK_IMAGE_ASPECT_COLOR_BIT set.", 36525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must NOT be DS 36555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ds) { 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL " 36605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and imageView %#" PRIxLEAST64 "" 36615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a color format.", 36625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, string_VkFormat(format)); 36635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 36665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 36675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Depth or stencil bit must be set, but both must NOT be set 36685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) { 36695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT) { 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // both must NOT be set 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with imageView %#" PRIxLEAST64 "" 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that has both STENCIL and DEPTH aspects set", 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView); 36775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!(aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Neither were set 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_INVALID_IMAGE_ASPECT, "DS", 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that does not have STENCIL or DEPTH aspect set.", 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView); 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // format must be DS 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ds) { 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT, 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pImageView, __LINE__, DRAWSTATE_IMAGEVIEW_DESCRIPTOR_ERROR, "DS", 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Updating descriptor with layout %s and imageView %#" PRIxLEAST64 "" 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but the image format is %s which is not a depth/stencil format.", 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(imageLayout), (uint64_t)*pImageView, string_VkFormat(format)); 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // anything to check for other layouts? 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferView is valid 3707e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferView(const layer_data *my_data, const VkBufferView *pBufferView) { 3708e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferViewMap.find(*pBufferView); 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferViewMap.end()) { 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT, 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView, __LINE__, DRAWSTATE_BUFFERVIEW_DESCRIPTOR_ERROR, "DS", 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor with invalid bufferView %#" PRIxLEAST64, 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pBufferView); 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that given bufferInfo is valid 3722e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateBufferInfo(const layer_data *my_data, const VkDescriptorBufferInfo *pBufferInfo) { 3723e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampIt = my_data->bufferMap.find(pBufferInfo->buffer); 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampIt == my_data->bufferMap.end()) { 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer, __LINE__, DRAWSTATE_BUFFERINFO_DESCRIPTOR_ERROR, "DS", 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Attempt to update descriptor where bufferInfo has invalid buffer %#" PRIxLEAST64, 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pBufferInfo->buffer); 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any further checks we want to do on the bufferView? 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3737e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateUpdateContents(const layer_data *my_data, const VkWriteDescriptorSet *pWDS, 3738e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayoutBinding *pLayoutBinding) { 3739e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that for the given Descriptor type, the correct DescriptorInfo data is supplied 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSampler *pSampler = NULL; 3742e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool immutable = false; 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For given update type, verify that update contents are correct 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, &(pWDS->pImageInfo[i].sampler), immutable); 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayoutBinding->pImmutableSamplers) { 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pWDS->pImageInfo[i].sampler); 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (immutable) { 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 37595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is not an immutable sampler %#" PRIxLEAST64 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", but previous update(s) from this " 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used an immutable sampler. All updates from a single struct must either " 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, (uint64_t)*pSampler); 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i > 0 && !immutable) { 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT, 37695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSampler, __LINE__, DRAWSTATE_INCONSISTENT_IMMUTABLE_SAMPLER_UPDATE, "DS", 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkUpdateDescriptorSets: Update #%u is an immutable sampler, but previous update(s) from this " 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkWriteDescriptorSet struct used a non-immutable sampler. All updates from a single struct must either " 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "use immutable or non-immutable samplers.", 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i); 37745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves immutable = true; 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSampler = &(pLayoutBinding->pImmutableSamplers[i]); 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSampler(my_data, pSampler, immutable); 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Intentionally fall through here to also validate image stuff 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 37825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT: 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateImageView(my_data, &(pWDS->pImageInfo[i].imageView), pWDS->pImageInfo[i].imageLayout); 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferView(my_data, &(pWDS->pTexelBufferView[i])); 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 37965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pWDS->descriptorCount; ++i) { 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateBufferInfo(my_data, &(pWDS->pBufferInfo[i])); 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3810e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3811e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3812e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s() on descriptor set %" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 38225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 38235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Cannot call %s() on descriptor set %" PRIxLEAST64 " that is in use by a command buffer.", 38245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void invalidateBoundCmdBuffers(layer_data *dev_data, const SET_NODE *pSet) { 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Flag any CBs this set is bound to as INVALID 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : pSet->boundCmdBuffers) { 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb_node = dev_data->commandBufferMap.find(cb); 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_node != dev_data->commandBufferMap.end()) { 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cb_node->second->state = CB_INVALID; 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// update DS mappings based on write and copy update arrays 3839e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool dsUpdate(layer_data *my_data, VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pWDS, 3840e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pCDS) { 3841e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = NULL; 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSetLayoutCreateInfo *pLayoutCI = NULL; 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate Write updates 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorWriteCount; i++) { 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorSet ds = pWDS[i].dstSet; 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = my_data->setMap[ds]; 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3851e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, ds, "VkUpdateDescriptorSets")) == true) 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If set is bound to any cmdBuffers, mark them invalid 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pSet); 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pUpdate = (GENERIC_HEADER *)&pWDS[i]; 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayout = pSet->pLayout; 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify valid update struct 3858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validUpdateStruct(my_data, device, pUpdate)) == true) { 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t binding = 0, endIndex = 0; 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = pWDS[i].dstBinding; 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto bindingToIndex = pLayout->bindingToIndexMap.find(binding); 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that layout being updated has the binding being updated 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (bindingToIndex == pLayout->bindingToIndexMap.end()) { 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor Set %" PRIu64 " does not have binding to match " 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "update binding %u for update type " 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s!", 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), binding, string_VkStructureType(pUpdate->sType)); 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Next verify that update falls within size of given binding 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis endIndex = getUpdateEndIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pLayout, binding) < endIndex) { 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pLayout->createInfo; 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 38795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Descriptor update type of %s is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdate->sType), binding, DSstr.c_str()); 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // TODO : should we skip update on a type mismatch or force it? 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t startIndex; 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis startIndex = getUpdateStartIndex(my_data, device, pLayout, binding, pWDS[i].dstArrayElement, pUpdate); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layout bindings match w/ update, now verify that update type 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // & stageFlags are the same for entire update 3888e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateUpdateConsistency(my_data, device, pLayout, pUpdate, startIndex, endIndex)) == false) { 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The update is within bounds and consistent, but need to 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // make sure contents make sense as well 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((skipCall = validateUpdateContents(my_data, &pWDS[i], 3892e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves &pLayout->createInfo.pBindings[bindingToIndex->second])) == false) { 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update is good. Save the update info 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new update struct for this set's shadow copy 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pNewNode = NULL; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= shadowUpdateNode(my_data, device, pUpdate, &pNewNode); 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(ds), __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate UPDATE struct in vkUpdateDescriptors()"); 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert shadow node into LL of updates for this set 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pSet->pUpdateStructs; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = pNewNode; 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update appropriate descriptor(s) to point to new Update node 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = startIndex; j <= endIndex; j++) { 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(j < pSet->descriptorCount); 39093a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates[j] = pNewNode; 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now validate copy updates 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < descriptorCopyCount; ++i) { 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSrcSet = NULL, *pDstSet = NULL; 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pSrcLayout = NULL, *pDstLayout = NULL; 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t srcStartIndex = 0, srcEndIndex = 0, dstStartIndex = 0, dstEndIndex = 0; 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each copy make sure that update falls within given layout and that types match 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcSet = my_data->setMap[pCDS[i].srcSet]; 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet = my_data->setMap[pCDS[i].dstSet]; 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set being updated cannot be in-flight 3926e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((skipCall = validateIdleDescriptorSet(my_data, pDstSet->set, "VkUpdateDescriptorSets")) == true) 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(my_data, pDstSet); 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSrcLayout = pSrcSet->pLayout; 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstLayout = pDstSet->pLayout; 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src binding is valid for src set layout 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->bindingToIndexMap.find(pCDS[i].srcBinding) == pSrcLayout->bindingToIndexMap.end()) { 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has srcBinding %u " 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].srcBinding, (uint64_t)pSrcLayout->layout, pSrcLayout->createInfo.bindingCount - 1); 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pDstLayout->bindingToIndexMap.find(pCDS[i].dstBinding) == pDstLayout->bindingToIndexMap.end()) { 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_INVALID_UPDATE_INDEX, "DS", 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update %u has dstBinding %u " 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which is out of bounds for underlying SetLayout " 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%#" PRIxLEAST64 " which only has bindings 0-%u.", 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCDS[i].dstBinding, (uint64_t)pDstLayout->layout, pDstLayout->createInfo.bindingCount - 1); 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Proceed with validation. Bindings are ok, but make sure update is within bounds of given layout 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcEndIndex = getUpdateEndIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstEndIndex = getUpdateEndIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (getBindingEndIndex(pSrcLayout, pCDS[i].srcBinding) < srcEndIndex) { 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pSrcLayout->createInfo; 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSrcSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor src update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].srcBinding, DSstr.c_str()); 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (getBindingEndIndex(pDstLayout, pCDS[i].dstBinding) < dstEndIndex) { 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pLayoutCI = &pDstLayout->createInfo; 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string DSstr = vk_print_vkdescriptorsetlayoutcreateinfo(pLayoutCI, "{DS} "); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDstSet->set, __LINE__, DRAWSTATE_DESCRIPTOR_UPDATE_OUT_OF_BOUNDS, "DS", 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor dest update is out of bounds for matching binding %u in Layout w/ CI:\n%s!", 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCDS[i].dstBinding, DSstr.c_str()); 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis srcStartIndex = getUpdateStartIndex(my_data, device, pSrcLayout, pCDS[i].srcBinding, pCDS[i].srcArrayElement, 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstStartIndex = getUpdateStartIndex(my_data, device, pDstLayout, pCDS[i].dstBinding, pCDS[i].dstArrayElement, 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (const GENERIC_HEADER *)&(pCDS[i])); 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pCDS[i].descriptorCount; ++j) { 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For copy just make sure that the types match and then perform the update 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSrcLayout->descriptorTypes[srcStartIndex + j] != pDstLayout->descriptorTypes[dstStartIndex + j]) { 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Copy descriptor update index %u, update count #%u, has src update descriptor type %s " 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that does not match overlapping dest descriptor type of %s!", 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, j + 1, string_VkDescriptorType(pSrcLayout->descriptorTypes[srcStartIndex + j]), 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkDescriptorType(pDstLayout->descriptorTypes[dstStartIndex + j])); 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // point dst descriptor at corresponding src descriptor 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This may be a hole. I believe copy should be its own copy, 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // otherwise a subsequent write update to src will incorrectly affect the copy 39863a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pDstSet->pDescriptorUpdates[j + dstStartIndex] = pSrcSet->pDescriptorUpdates[j + srcStartIndex]; 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDstSet->pUpdateStructs = pSrcSet->pUpdateStructs; 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3996a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// Verify that given pool has descriptors that are being requested for allocation. 3997a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski// NOTE : Calls to this function should be wrapped in mutex 3998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_descriptor_availability_in_pool(layer_data *dev_data, DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 3999e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkDescriptorSetLayout *pSetLayouts) { 4000e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4001a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t i = 0; 4002a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski uint32_t j = 0; 4003a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 4004a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Track number of descriptorSets allowable in this pool 4005a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski if (pPoolNode->availableSets < count) { 4006a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 4007a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski reinterpret_cast<uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 4008a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski "Unable to allocate %u descriptorSets from pool %#" PRIxLEAST64 4009a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptorSets remaining.", 4010a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski count, reinterpret_cast<uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 4011a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } else { 4012a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets -= count; 4013a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski } 4014a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; ++i) { 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pSetLayouts[i]); 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pSetLayouts[i]); 40235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 40255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pLayout->createInfo.bindingCount; ++j) { 40265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 40275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 40285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (poolSizeCount > pPoolNode->availableDescriptorTypeCount[typeIndex]) { 40295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 40305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pLayout->layout, __LINE__, 40315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 40325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to allocate %u descriptors of type %s from pool %#" PRIxLEAST64 4033a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski ". This pool only has %d descriptors of this type remaining.", 40345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount, string_VkDescriptorType(pLayout->createInfo.pBindings[j].descriptorType), 40355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pPoolNode->pool, pPoolNode->availableDescriptorTypeCount[typeIndex]); 40365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Decrement available descriptors of this type 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] -= poolSizeCount; 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 40435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the shadowed update node for this Set 40465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void freeShadowUpdateTree(SET_NODE *pSet) { 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pShadowUpdate = pSet->pUpdateStructs; 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet->pUpdateStructs = NULL; 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GENERIC_HEADER *pFreeUpdate = pShadowUpdate; 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the descriptor mappings as they will now be invalid 40523a417a5ce9f836b2b8602f7886f735a7ad6acdbbTobin Ehlis pSet->pDescriptorUpdates.clear(); 40535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pShadowUpdate) { 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeUpdate = pShadowUpdate; 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pShadowUpdate = (GENERIC_HEADER *)pShadowUpdate->pNext; 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkWriteDescriptorSet *pWDS = NULL; 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pFreeUpdate->sType) { 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 40595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pWDS = (VkWriteDescriptorSet *)pFreeUpdate; 40605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pWDS->descriptorType) { 40615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLER: 40625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER: 40635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE: 40645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_IMAGE: { 40655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pImageInfo; 40665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 40675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER: 40685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER: { 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pTexelBufferView; 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER: 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER: 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC: 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC: { 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pWDS->pBufferInfo; 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } break; 40775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(0); 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeUpdate; 40885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 40935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 40945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 40955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 40965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = (*ii).second->pSets; 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pFreeSet = pSet; 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFreeSet = pSet; 41015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 41025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Freeing layouts handled in deleteLayouts() function 41035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free Update shadow struct tree 41045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pFreeSet); 41055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pFreeSet; 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 41085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WARN : Once deleteLayouts() called, any layout ptrs in Pool/Set data structure will be invalid 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteLayouts(layer_data *my_data) { 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorSetLayoutMap.size() <= 0) 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorSetLayoutMap.begin(); ii != my_data->descriptorSetLayoutMap.end(); ++ii) { 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = (*ii).second; 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayout->createInfo.pBindings) { 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pLayout->createInfo.bindingCount; i++) { 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings[i].pImmutableSamplers; 41225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pLayout->createInfo.pBindings; 41245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pLayout; 41265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorSetLayoutMap.clear(); 41285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Currently clearing a set is removing all previous updates to that set 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Validate if this is correct clearing behavior 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorSet(layer_data *my_data, VkDescriptorSet set) { 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = getSetNode(my_data, set); 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSet) { 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Return error 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis freeShadowUpdateTree(pSet); 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For every set off of this pool, clear it 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = pPool->pSets; 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (pSet) { 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorSet(my_data, pSet->set); 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSet = pSet->pNext; 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4156e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 41575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 41585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 41595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4160e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 41615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic GLOBAL_CB_NODE *getCBNode(layer_data *my_data, const VkCommandBuffer cb) { 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->commandBufferMap.count(cb) == 0) { 416772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 416872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 416972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Attempt to use CommandBuffer %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 41705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->commandBufferMap[cb]; 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 4178400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 41855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4187e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4193e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 41945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 4195e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 4196e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && cmd_type != CMD_EXECUTECOMMANDS) { 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 42265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 42275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 42285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 42295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 42305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 4235e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 4236e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 4239b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 42405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 42455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 42525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 42535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 42555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 42575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 42585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 42635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 42685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 42695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 42765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 42775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 42905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 42945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4310400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4311400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 432572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 432672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 432772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 4328400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis auto set_node = dev_data->setMap.find(set); 4329400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (set_node != dev_data->setMap.end()) { 433072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis set_node->second->boundCmdBuffers.erase(pCB->commandBuffer); 433172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 433272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 433372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 433472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = 0; 434072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->fenceId = 0; 434172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 434272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 43565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 43597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 43607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4361400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4362b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 43675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 43685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4369ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4370ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 43715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4377ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4378ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 43795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 43805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 43923d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 43985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4416e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 4417e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 442072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 4426ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 4427ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 4428ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_NONE, "DS", "Cmds in CB %p", (void *)cb); 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 44405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 44425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", " CMD#%" PRIu64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 44475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 4451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 44535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4461e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4462e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: It is invalid to issue this call inside an active render pass (%#" PRIxLEAST64 ")", apiName, 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass); 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 44765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 44775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 44815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 44845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4486b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4487d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4488b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 44895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!globalLockInitialized) { 44915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_create_mutex(&globalLock); 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 1; 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 44985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 44995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 45085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4513b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 4514b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4515b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4517b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4518b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4519b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 45205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4521b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 45225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 45245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 45315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 45325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 45335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 45365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 45415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 45425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 45445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 45475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 45485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 45505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layer_data_map.empty()) { 45515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Release mutex when destroying last instance. 45525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_delete_mutex(&globalLock); 45535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis globalLockInitialized = 0; 45545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 45625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 45665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(NULL, "vkCreateDevice"); 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 45885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 45955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 45995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 46056c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4610b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4613b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4615b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4618b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4620b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4622b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4623b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 46245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 46255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 46335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 46435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteLayouts(dev_data); 46445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 465103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 4652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 46580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 46590a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 466158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4662400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 46645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 46655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 46665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 46695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mem Object %" PRIu64 " has not been freed. You should clean up this memory by calling " 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkFreeMemory(%" PRIu64 ") prior to vkDestroyDevice().", 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Queues persist until device is destroyed 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete_queue_info_list(dev_data); 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 46825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fprintf(stderr, "Device: %p, key: %p\n", device, key); 46835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 46845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 4685e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 46875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 46905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 46915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 47005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_global_layers), cv_global_layers, pCount, pProperties); 47055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Why does this exist - can we just use global? 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkLayerProperties cv_device_layers[] = {{ 4709f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 47105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}}; 47115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *pLayerName, uint32_t *pCount, 47145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkExtensionProperties *pProperties) { 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pLayerName == NULL) { 47165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(physicalDevice); 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 47185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetExtensionProperties(0, NULL, pCount, pProperties); 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 47255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* draw_state physical device layers are the same as global */ 47275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return util_GetLayerProperties(ARRAY_SIZE(cv_device_layers), cv_device_layers, pCount, pProperties); 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4733e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateCmdBufImageLayouts(VkCommandBuffer cmdBuffer) { 4734e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 47375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image %" PRIu64 ".", 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 47465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 47475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 474839d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski skip_call |= 474939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 475039d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski reinterpret_cast<uint64_t &>(cmdBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 475139d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski "Cannot submit cmd buffer using image (%" PRIx64 ") with layout %s when " 475239d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski "first use is %s.", 475339d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 475439d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski string_VkImageLayout(cb_image_data.second.initialLayout)); 47555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 47575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 47605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 476139d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4763e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4764e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 47665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 47695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 47705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 47715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted buffer %" PRIu64 ".", (uint64_t)(buffer)); 47725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 47745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 477772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 477872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 477972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 478072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode == my_data->setMap.end()) { 478172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 478272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 478372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 478472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "Cannot submit cmd buffer using deleted descriptor set %" PRIu64 ".", (uint64_t)(set)); 478572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 478672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_add(1); 478772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 47925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 47945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 47955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 47965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted semaphore %" PRIu64 ".", reinterpret_cast<uint64_t &>(semaphore)); 47975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 48045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 48075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot submit cmd buffer using deleted event %" PRIu64 ".", reinterpret_cast<uint64_t &>(event)); 48085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 48095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 48105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4815e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 48175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 48185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 482572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 482672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 482772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto setNode = my_data->setMap.find(set); 482872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (setNode != my_data->setMap.end()) { 482972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis setNode->second->in_use.fetch_sub(1); 483072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 48405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 48435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 48505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 48545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 48565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_sub(1); 48601d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 48611d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 48625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4868e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkQueue queue) { 48695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 48735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 48751d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 48761d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill queue_data->second.lastFences.data()); 48770a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48780a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 48790a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4880e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 48810a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 48820a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 48830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 48850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 48860a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 48870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 48880a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4889ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4890ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 48910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 48930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 48940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 48950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 48960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48970a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 48980a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 48990a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 49010a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 49020a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 49030a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 49040a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 49050a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 49065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4907b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 4908b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 4909b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 49105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4912e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4913e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 49160a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49220a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 49230a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 49240a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 49250a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 49260a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 49275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 49295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.clear(); 49310a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 49335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.queue = queue; 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 49385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 49405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 49515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 49585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 49595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add cmdBuffers to both the global set and queue set 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(secondaryCmdBuffer); 49655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 49675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.inFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 49685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 49745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 49755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 49765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 49775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 49785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 497927c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 498027c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Command Buffer %#" PRIx64 " is already in use and is not marked for simultaneous use.", 49815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 49825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 49845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 49875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 49885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 49895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 49905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 49915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 49925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 49935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 49945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 49955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 49965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 49975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 49995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 50025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 50035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 50045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 50075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 50095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 50105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 50165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 50175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 50235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid because it had the following " 50285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 50295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 50315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You are submitting command buffer %#" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 50415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 50425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 50465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 50475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 50485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 50495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkEndCommandBuffer() on CB %#" PRIxLEAST64 " before this call to vkQueueSubmit()!", 50505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 50515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 50545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5056e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 50575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 5058e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 50635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->primaryCommandBuffer != pCB->commandBuffer) { 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was submitted with secondary buffer %#" PRIxLEAST64 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 50685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "primary cmd buffer %#" PRIxLEAST64 ".", 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 50705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify if this also needs to be checked for secondary command 50755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers. If so, this block of code can move to 50765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // validateCommandBufferState() function. vulkan GL106 filed to clarify 50775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 50785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 50795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "CB %#" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 50815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, but has been submitted %#" PRIxLEAST64 " times.", 50825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 50835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 50855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 50865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 50875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 50885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 50895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 50915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 50925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 5093e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 509472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = NULL; 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 50965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 50975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 509803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 50995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to track fence and clear mem references when fence clears 51005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge this code with code below to avoid duplicating efforts 51015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t fenceId = 0; 51025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = add_fence_info(dev_data, fence, queue, &fenceId); 51035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 51050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 51065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 51075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 51085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 510972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 511072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 511172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->fenceId = fenceId; 511272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->lastSubmittedFence = fence; 511372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->lastSubmittedQueue = queue; 511472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &function : pCBNode->validate_functions) { 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= function(); 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5117b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto &function : pCBNode->eventUpdates) { 5118e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= function(queue); 5119b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; i++) { 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pWaitSemaphores[i]; 51255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_SIGNALLED) { 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 51295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 51305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueSubmit: Semaphore must be in signaled state before passing to pWaitSemaphores"); 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_WAIT; 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; i++) { 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pSignalSemaphores[i]; 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 51405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, (uint64_t)sem, __LINE__, MEMTRACK_NONE, 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "SEMAPHORE", "vkQueueSubmit: Semaphore must not be currently signaled or in a wait state"); 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 51465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((fence != VK_NULL_HANDLE) && (submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 51535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 51545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 51570a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 51605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 51620a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 51630a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (dev_data->semaphoreMap[semaphore].signaled) { 51640a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].signaled = 0; 51653d722f98b98af892a5c2b98a26068db98de39c33Mark Lobodzinski dev_data->semaphoreMap[semaphore].in_use.fetch_sub(1); 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 51685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, 51695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 51700a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 51710a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 51720a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 51730a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 51740a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 51750a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine processed_other_queues.insert(other_queue); 51765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 51790a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 51800a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine semaphoreList.push_back(semaphore); 51810a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (dev_data->semaphoreMap[semaphore].signaled) { 51820a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 51830a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, 51840a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine "DS", "Queue %#" PRIx64 " is signaling semaphore %#" PRIx64 51850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine " that has already been signaled but not waited on by queue %#" PRIx64 ".", 51860a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 51870a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 51880a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 51890a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].signaled = 1; 51900a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine dev_data->semaphoreMap[semaphore].queue = queue; 51910a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 51925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateCmdBufImageLayouts(submit->pCommandBuffers[i]); 519572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 519672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->semaphores = semaphoreList; 519772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->submitCount++; // increment submit count 519872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 51995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update cmdBuffer-related data structs and mark fence in-use 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 52035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 52055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 520603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; i++) { 52115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = submit->pWaitSemaphores[i]; 52125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 52145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 52155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 52195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 52205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 522303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 52245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 52255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 52265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 52285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 52295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 52305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 52310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 52325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 52335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 52375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 52385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 52415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 52425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 52435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 52445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 52465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 524758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5248e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 52490a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 52500a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 52515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 52535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 5256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: a size of 0 is not listed as an invalid use in the spec, should it be? 52605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 52665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 52675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object %#" PRIxLEAST64, (uint64_t)mem); 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 52795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 52815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 52845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 52855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 52865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "MEM", "Mapping Memory from %" PRIu64 " to %" PRIu64 " with total array size %" PRIu64, offset, 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 52885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5304e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 5305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 53115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj %#" PRIxLEAST64, (uint64_t)mem); 53135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 53155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5325b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 5326b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 5327b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 5330b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 53345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 53355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 53395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 53405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 5346e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 5347e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : queryEventsPair.second) { 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->eventMap[event].needsSignaled) { 53535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " with index %d which was guarded by unsignaled event %" PRIu64 ".", 53575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 53635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove given cmd_buffer from the global inFlight set. 53655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Also, if given queue is valid, then remove the cmd_buffer from that queues 53665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// inFlightCmdBuffer set. Finally, check all other queues and if given cmd_buffer 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// is still in flight on another queue, add it back into the global set. 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Note: This function assumes that the global lock is held by the calling 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// thread. 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer, VkQueue queue) { 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Pull it off of global list initially, but if we find it in any other queue list, add it back in 53725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.erase(cmd_buffer); 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto q : dev_data->queues) { 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((q != queue) && 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dev_data->queueMap[q].inFlightCmdBuffers.find(cmd_buffer) != dev_data->queueMap[q].inFlightCmdBuffers.end())) { 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cmd_buffer); 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 538403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic inline bool verifyFenceStatus(VkDevice device, VkFence fence, const char *apiCall) { 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5387e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 5390e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 5391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if ((pFenceInfo->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT) && !pFenceInfo->second.firstTimeFlag) { 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s specified fence %#" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pFenceInfo->second.queue && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 53995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 54005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s called for fence %#" PRIxLEAST64 " which has not been submitted on a Queue or during " 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 54035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5414e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 541503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= verifyFenceStatus(device, pFences[i], "vkWaitForFences"); 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 54265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 54315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 543203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, pFences[i]); 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueue fence_queue = dev_data->fenceMap[pFences[i]].queue; 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[pFences[i]].cmdBuffers) { 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 54385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, fenceCount, pFences); 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5448e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkGetFenceStatus(VkDevice device, VkFence fence) { 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 545703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = verifyFenceStatus(device, fence, "vkGetFenceStatus"); 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 546803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis update_fence_tracking(dev_data, fence); 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_queue = dev_data->fenceMap[fence].queue; 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->fenceMap[fence].cmdBuffers) { 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, fence_queue); 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, 1, &fence); 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5484b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkGetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5485b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5489b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5490b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5491b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5492b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5493b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 5494b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 549503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5496b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastRetiredId = 0; 5497b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->lastSubmittedId = 0; 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 5499b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 5500b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 55015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueueWaitIdle(VkQueue queue) { 55055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 55065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 5507e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Iterate over local set since we erase set members as we go in for loop 55105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto local_cb_set = dev_data->queueMap[queue].inFlightCmdBuffers; 55115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : local_cb_set) { 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis removeInFlightCmdBuffer(dev_data, cmdBuffer, queue); 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 552003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 55225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_queue_fences(dev_data, queue); 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkDeviceWaitIdle(VkDevice device) { 5531e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(dev_data, queue); 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->queueMap.find(queue) != dev_data->queueMap.end()) { 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear all of the queue inFlightCmdBuffers (global set cleared below) 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queueMap[queue].inFlightCmdBuffers.clear(); 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 55425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= cleanInFlightCmdBuffer(dev_data, cmdBuffer); 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 554903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis retire_device_fences(dev_data, device); 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[fence].in_use.load()) { 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 556803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete_fence_info(dev_data, fence); 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->fenceMap.find(fence); 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->fenceMap.end()) { 55725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->fenceMap.erase(item); 55735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 55755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 55775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 55785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 55815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 55825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 55845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 55855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 55865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 55875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 55885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 55895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 55905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete semaphore %" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 55915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 55995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 56055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 56085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot delete event %" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 56095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 56115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 56205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkGetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryResultFlags flags) { 56285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 56305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = nullptr; 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 56325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB = getCBNode(dev_data, cmdBuffer); 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 56365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5638e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 56395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 56415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5644ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5645ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5646ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5647ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5648ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5649ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5650ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5651ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5652ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5653ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is in flight.", 5654ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5655ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5656ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5657ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5658ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5659ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5660ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5661ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5662ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5663ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5664ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5665ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5666ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5667ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski pCB = getCBNode(dev_data, cmdBuffer); 5668ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5669ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5670ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5673ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5676ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5677ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 56805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot get query results on queryPool %" PRIu64 " with index %d which is unavailable.", 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5682ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5683ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5684ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5685ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5686ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski "Cannot get query results on queryPool %" PRIu64 5687ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5688ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 56975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5699e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5700e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 57055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 57065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot free buffer %" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 57115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 57145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBuffer(VkDevice device, VkBuffer buffer, const VkAllocationCallbacks *pAllocator) { 57185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5719e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 57205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 5721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 57225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 57245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.erase(buffer); 57275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 57315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 57365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 57375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 57385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 57435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5744e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5745e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 57465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 57475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 57495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& entry = dev_data->imageMap.find(image); 57505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (entry != dev_data->imageMap.end()) { 575158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Clear any memory mapping for this image 575294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto mem_entry = dev_data->memObjMap.find(entry->second.mem); 575358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (mem_entry != dev_data->memObjMap.end()) 575458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis mem_entry->second.image = VK_NULL_HANDLE; 575558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 575658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 57575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.erase(entry); 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 57605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 57615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 57625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 57635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 57655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 57675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 576803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 5769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 5770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 577258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Buffer %" PRIx64 " is alised with image %" PRIx64, object_handle, 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 577658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 57775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_ALIASING, "MEM", "Image %" PRIx64 " is alised with buffer %" PRIx64, object_handle, 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_handle); 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5782e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 5783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkDebugReportObjectTypeEXT object_type) { 5784e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 578558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis 57865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto range : ranges) { 5787b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 5788b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 57895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 5790b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 5791b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 57925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 579358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 57945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 57965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_buffer_image_aliasing(layer_data *dev_data, uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 5799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges, 5800e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const vector<MEMORY_RANGE> &other_ranges, VkDebugReportObjectTypeEXT object_type) { 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMORY_RANGE range; 58025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.handle = handle; 58035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.memory = mem; 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.start = memoryOffset; 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range.end = memoryOffset + memRequirements.size - 1; 580658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis ranges.push_back(range); 580758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return validate_memory_range(dev_data, other_ranges, range, object_type); 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 58115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 581258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 58145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 58155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5817e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 581894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 581994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 582094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 582194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 582394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 582458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, buffer_handle, mem, memoryOffset, memRequirements, 582558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].bufferRanges, dev_data->memObjMap[mem].imageRanges, 582658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 58272c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 58292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58312c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 58322c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be an integer multiple of the " 58332c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "VkMemoryRequirements::alignment value %#" PRIxLEAST64 58342c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58352c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58362c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58372c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 583894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 58392c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5840b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 58412c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58422c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58432c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 58442c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minTexelBufferOffsetAlignment %#" PRIxLEAST64, 5846b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 58472c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58482c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58492c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5850b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5851b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58522c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58532c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58542c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 58552c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58562c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 5857b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 58582c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58592c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58602c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5861b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5862b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 58632c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 58642c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 58652c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 58662c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "vkBindBufferMemory(): memoryOffset is %#" PRIxLEAST64 " but must be a multiple of " 58672c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 5868b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 58692c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58702c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 58735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 5874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 587558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 58765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 58825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 58845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 58855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 58865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 58905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 58925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 58935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 58975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 58985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 58995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5905918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5906918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5907918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_lock_mutex(&globalLock); 5908918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5909918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5910918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5911918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes loader_platform_thread_unlock_mutex(&globalLock); 5912918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5913918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 59145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 59185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 59195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 59245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 59265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 59445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 59505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 59545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 59555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 59565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCommandBuffers[i])) { 59575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 59585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 59595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 59605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to free command buffer (%#" PRIxLEAST64 ") which is in use.", 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 59645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cb = dev_data->commandBufferMap.find(pCommandBuffers[i]); 59655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb != dev_data->commandBufferMap.end()) { 59665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 59675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*cb).second->commandBuffer); 59685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*cb).second; 59695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap.erase(cb); 59705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 597503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 59760a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 59815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 59825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 59855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 59865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool *pCommandPool) { 59875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 59925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 59935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 59945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 60015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 60055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 60065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 60085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6013400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic bool validateCommandBuffersNotInUse(const layer_data *dev_data, VkCommandPool commandPool, const char *action) { 6014e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 60155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 60165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 60175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : pool_data->second.commandBuffers) { 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmdBuffer)) { 60195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 60205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT, 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandPool), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 6022400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis "Cannot %s command pool %" PRIx64 " when allocated command buffer %" PRIx64 " is in use.", action, 6023400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis reinterpret_cast<const uint64_t &>(commandPool), reinterpret_cast<const uint64_t &>(cmdBuffer)); 60245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 60285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 60315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 60325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 60335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 60355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6038400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis VkBool32 result = validateCommandBuffersNotInUse(dev_data, commandPool, "destroy"); 60395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 60405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->commandPoolMap.find(commandPool) != dev_data->commandPoolMap.end()) { 60415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb != dev_data->commandPoolMap[commandPool].commandBuffers.end();) { 6043400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, *poolCb); 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto del_cb = dev_data->commandBufferMap.find(*poolCb); 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*del_cb).second; // delete CB info structure 604672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 60475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb = dev_data->commandPoolMap[commandPool].commandBuffers.erase( 60485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolCb); // Remove CB reference from commandPoolMap's list 60495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 60525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6055f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 60565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 60575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 60635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 60645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 60665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 6068400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 6069400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (validateCommandBuffersNotInUse(dev_data, commandPool, "reset")) 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 60745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 60765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 60805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 60815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 609403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset fence state in fenceCreateInfo structure 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : Merge with code below 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate fences in SIGNALED state 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(fence_item->second.createInfo.flags & VK_FENCE_CREATE_SIGNALED_BIT)) { 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: I don't see a Valid Usage section for ResetFences. This behavior should be documented there. 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pFences[i], __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 61045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIxLEAST64 " submitted to VkResetFences in UNSIGNALED STATE", (uint64_t)pFences[i]); 61055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_item->second.createInfo.flags = 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<VkFenceCreateFlags>(fence_item->second.createInfo.flags & ~VK_FENCE_CREATE_SIGNALED_BIT); 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->fenceMap[pFences[i]].in_use.load()) { 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 61155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Fence %#" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 61165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 61205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6127f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes loader_platform_thread_lock_mutex(&globalLock); 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 61305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 61345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6138f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 6139f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6141f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes loader_platform_thread_unlock_mutex(&globalLock); 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 61515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 615447892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 615547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 615747892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 615847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 616394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->bufferMap[*pBuffer].createInfo = *pCreateInfo; 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap[*pBuffer].in_use.store(0); 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 61715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 61765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 617703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 61800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 6181e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 61835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 61845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 61855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 618947892024546c67e8db98b51b2ddb962c21088894Mark LobodzinskiVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 619047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 61915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 619247892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 619347892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6196e5bc02759d9ab768d67b2f45ec53d29fb59a4705Tony Barbour loader_platform_thread_lock_mutex(&globalLock); 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 62005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap[*pImage].createInfo = *pCreateInfo; 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 62105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expects globalLock to be held by caller */ 62335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 62355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 62365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 62405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 62485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 62545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 625603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that img has correct usage flags set 62580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_image_usage_flags(dev_data, pCreateInfo->image, 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 62605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 6261e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FENCE_NODE *pFN = &dev_data->fenceMap[*pFence]; 627503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pFN, 0, sizeof(MT_FENCE_INFO)); 62775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&(pFN->createInfo), pCreateInfo, sizeof(VkFenceCreateInfo)); 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 6279e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFN->firstTimeFlag = true; 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pFN->in_use.store(0); 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 62895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 62915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63163d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 63173d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 63183d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 63193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 63203d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 63213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 63223d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63233d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63243d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 63283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 63293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 63303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 63313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 63353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 63363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 6347e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 63535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6356ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6357ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 63585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 63595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6361e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 63695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63735188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 63745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 63825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipeline *pPipelines) { 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 6386e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 63935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 63945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6399ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6400ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6406e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 64285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 64295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->sampleMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 64445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 64455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pNewNode = new LAYOUT_NODE; 64475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pSetLayout, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate LAYOUT_NODE in vkCreateDescriptorSetLayout()")) 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)&pNewNode->createInfo, pCreateInfo, sizeof(VkDescriptorSetLayoutCreateInfo)); 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->createInfo.pBindings = new VkDescriptorSetLayoutBinding[pCreateInfo->bindingCount]; 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)pNewNode->createInfo.pBindings, pCreateInfo->pBindings, 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sizeof(VkDescriptorSetLayoutBinding) * pCreateInfo->bindingCount); 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // g++ does not like reserve with size 0 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->bindingCount) 64595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap.reserve(pCreateInfo->bindingCount); 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t totalCount = 0; 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pNewNode->bindingToIndexMap.emplace(pCreateInfo->pBindings[i].binding, i).second) { 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)*pSetLayout, __LINE__, 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LAYOUT, "DS", "duplicated binding number in " 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkDescriptorSetLayoutBinding")) 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->bindingToIndexMap[pCreateInfo->pBindings[i].binding] = i; 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis totalCount += pCreateInfo->pBindings[i].descriptorCount; 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pBindings[i].pImmutableSamplers) { 64735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSampler **ppIS = (VkSampler **)&pNewNode->createInfo.pBindings[i].pImmutableSamplers; 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppIS = new VkSampler[pCreateInfo->pBindings[i].descriptorCount]; 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(*ppIS, pCreateInfo->pBindings[i].pImmutableSamplers, 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pBindings[i].descriptorCount * sizeof(VkSampler)); 64775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->layout = *pSetLayout; 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->startIndex = 0; 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (totalCount > 0) { 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes.resize(totalCount); 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags.resize(totalCount); 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset = 0; 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t j = 0; 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorType dType; 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->bindingCount; i++) { 64885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dType = pCreateInfo->pBindings[i].descriptorType; 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (j = 0; j < pCreateInfo->pBindings[i].descriptorCount; j++) { 64905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorTypes[offset + j] = dType; 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->stageFlags[offset + j] = pCreateInfo->pBindings[i].stageFlags; 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((dType == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) || 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (dType == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC)) { 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->dynamicDescriptorCount++; 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset += j; 64985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = pNewNode->startIndex + totalCount - 1; 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // no descriptors 65015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->endIndex = 0; 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Put new node at Head of global Layer list 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = pNewNode; 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validatePushConstantSize(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const char *caller_name) { 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 6514b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 65155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 6518b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis caller_name, offset, size, dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize); 65195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 65215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 65245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 65255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 65285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()"); 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pCreateInfo->pPushConstantRanges[i].size == 0) || ((pCreateInfo->pPushConstantRanges[i].size & 0x3) != 0)) { 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 65335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constant index %u with " 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "size %u. Size must be greater than zero and a multiple of 4.", 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, pCreateInfo->pPushConstantRanges[i].size); 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if ranges overlap 65395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge capture of the setLayouts per pipeline 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 65455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 65465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 65505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 65515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPool *pDescriptorPool) { 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 65635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 65655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool %#" PRIxLEAST64, 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 65705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 65715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 65725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 65735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 65745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 65785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 65885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 65905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 65925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 65995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 6600e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that requested descriptorSets are available in pool 66055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 66075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 66085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 66095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find pool node for pool %#" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 66105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 66115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 66125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validate_descriptor_availability_in_pool(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 66135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->pSetLayouts); 66145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 66175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 66195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 66225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 66235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pAllocateInfo->descriptorSetCount == 0) { 66245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pAllocateInfo->descriptorSetCount, __LINE__, DRAWSTATE_NONE, "DS", 66265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "AllocateDescriptorSets called with 0 count"); 66275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 66295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 66305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", "Created Descriptor Set %#" PRIxLEAST64, 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create new set node and add to head of pool nodes 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pNewNode = new SET_NODE; 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_OUT_OF_MEMORY, "DS", 6638ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis "Out of memory while attempting to allocate SET_NODE in vkAllocateDescriptorSets()")) { 6639ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6641ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Pool should store a total count of each type of Descriptor available 66445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When descriptors are allocated, decrement the count and validate here 66455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that the count doesn't go below 0. One reset/free need to bump count back up. 66465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert set at head of Set LL for this pool 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pNext = pPoolNode->pSets; 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->pSets = pNewNode; 66505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = getLayoutNode(dev_data, pAllocateInfo->pSetLayouts[i]); 66515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pLayout) { 66525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 66535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, (uint64_t)pAllocateInfo->pSetLayouts[i], 66545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unable to find set layout node for layout %#" PRIxLEAST64 66565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " specified in vkAllocateDescriptorSets() call", 6657ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis (uint64_t)pAllocateInfo->pSetLayouts[i])) { 6658ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6660ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis } 66615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pLayout = pLayout; 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->pool = pAllocateInfo->descriptorPool; 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->set = pDescriptorSets[i]; 66655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->descriptorCount = (pLayout->createInfo.bindingCount != 0) ? pLayout->endIndex + 1 : 0; 66665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pNewNode->descriptorCount) { 6667656b1a5d2165c66fd4af21d070243d387cd4ac56Karl Schultz pNewNode->pDescriptorUpdates.resize(pNewNode->descriptorCount); 66685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 6680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateIdleDescriptorSet(dev_data, pDescriptorSets[i], "vkFreeDesriptorSets"); 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, descriptorPool); 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pPoolNode->createInfo.flags)) { 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can't Free from a NON_FREE pool 66895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6695e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 6700a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6701a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // Update available descriptor sets in pool 6702a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski pPoolNode->availableSets += count; 6703a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski 6704a2d5d61d3c324e027f78bfd1d8c4c49c66898520Mark Lobodzinski // For each freed descriptor add it back into the pool as available 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SET_NODE *pSet = dev_data->setMap[pDescriptorSets[i]]; // getSetNode() without locking 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis invalidateBoundCmdBuffers(dev_data, pSet); 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LAYOUT_NODE *pLayout = pSet->pLayout; 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t typeIndex = 0, poolSizeCount = 0; 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < pLayout->createInfo.bindingCount; ++j) { 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis typeIndex = static_cast<uint32_t>(pLayout->createInfo.pBindings[j].descriptorType); 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis poolSizeCount = pLayout->createInfo.pBindings[j].descriptorCount; 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPoolNode->availableDescriptorTypeCount[typeIndex] += poolSizeCount; 67145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Any other clean-up or book-keeping to do here? 67195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 67245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 6725e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // dsUpdate will return true only if a bailout error occurs, so we want to call down tree when update returns false 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 6728e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool rtn = dsUpdate(dev_data, device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 67295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!rtn) { 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 67385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 67405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 674272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 674372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 674472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 67455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 674672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 67475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 67485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 67495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 67515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 67535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 675503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 67560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 67575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6765e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 67675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 67695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool commandBufferComplete = false; 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = checkCBCompleted(dev_data, commandBuffer, &commandBufferComplete); 6774400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 67755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!commandBufferComplete) { 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 67795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Calling vkBeginCommandBuffer() on active CB %p before it has completed. " 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must check CB flag before this call.", 67815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis commandBuffer); 67825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 67865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 67875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must have inheritance info.", 67915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 67925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6794400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 67955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 67965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must specify a valid renderpass parameter.", 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6801400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (%p) may perform better if a " 68065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(pInfo->framebuffer); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass fbRP = fbNode->second.createInfo.renderPass; 68135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6814400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 68195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 68205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Buffer (%p) renderPass (%#" PRIxLEAST64 ") is incompatible w/ framebuffer " 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") w/ render pass (%#" PRIxLEAST64 ") due to: %s", 68225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 68235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fbNode->second.referencingCmdBuffers.insert(pCB->commandBuffer); 68275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6831b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 68335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (%p) must not have " 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 68385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 68405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto rp_data = dev_data->renderPassMap.find(pInfo->renderPass); 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (rp_data != dev_data->renderPassMap.end() && rp_data->second && rp_data->second->pCreateInfo) { 68455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->subpass >= rp_data->second->pCreateInfo->subpassCount) { 68465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (%p) must has a subpass index (%d) " 68505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 68515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)commandBuffer, pInfo->subpass, rp_data->second->pCreateInfo->subpassCount); 68525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkBeginCommandBuffer(): Cannot call Begin on CB (%#" PRIxLEAST64 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (CB_RECORDED == pCB->state) { 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 68695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Call to vkBeginCommandBuffer() on command buffer (%#" PRIxLEAST64 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") attempts to implicitly reset cmdBuffer created from command pool (%#" PRIxLEAST64 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 68825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB %p!", (void *)commandBuffer); 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6889e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6893400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 68945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEndCommandBuffer(VkCommandBuffer commandBuffer) { 6898e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 69005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 69055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkEndCommandBuffer()"); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Ending command buffer with in progress query: queryPool %" PRIu64 ", index %d", 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6914e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 69155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 69175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 69195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 69205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 69235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6933e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 69385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 69415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") created from command pool (%#" PRIxLEAST64 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 69435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 69445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 69465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to reset command buffer (%#" PRIxLEAST64 ") which is in use.", 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer)); 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 69535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 69545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 69555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 696203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : For any vkCmdBind* calls that include an object which has mem bound to it, 69645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// need to account for that mem now having binding to given commandBuffer 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6968e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Incorrectly binding compute pipeline (%#" PRIxLEAST64 ") during active RenderPass (%#" PRIxLEAST64 ")", 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass); 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 698472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 69863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, pipelineBindPoint, pipeline); 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to bind Pipeline %#" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 69925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 6995e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 7001e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7012e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 7018e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 70315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7034e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 70405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7043e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 7049e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 70555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7058e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 70605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 7064e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 70703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7073e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 7079e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 70855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 70865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7088e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 70935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 7094e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 70965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 70975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 71005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 71015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7103e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 7109e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 71165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7118e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 7124e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 71305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7133e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 71385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t *pDynamicOffsets) { 7141e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 71445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7147787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7148787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7149787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7150787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 715172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) 715272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 715372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VkDescriptorSet oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 7154787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7155787f29d93dee194c015789cf61c079504c980572Tobin Ehlis SET_NODE *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7156787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 715772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pDescriptorSets[i]); 7158787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pSet->boundCmdBuffers.insert(commandBuffer); 715972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 716072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pDescriptorSets[i]; 7161787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 7162787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7163787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_NONE, "DS", "DS %#" PRIxLEAST64 " bound on pipeline %s", 7164787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7165787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!pSet->pUpdateStructs && (pSet->descriptorCount != 0)) { 7166787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 7167787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7168787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 7169787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "DS %#" PRIxLEAST64 7170787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 7171787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7172787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7173787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 7174787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 7175787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7176787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 7177787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 7178787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping layout in " 7179787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "pipelineLayout due to: %s", 7180787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, errorString.c_str()); 7181787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7182787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->dynamicDescriptorCount) { 7183787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7184787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if ((totalDynamicDescriptors + pSet->pLayout->dynamicDescriptorCount) > dynamicOffsetCount) { 7185787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 7186787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7187787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7188787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7189787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "descriptorSet #%u (%#" PRIxLEAST64 7190787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7191787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7192787f29d93dee194c015789cf61c079504c980572Tobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->pLayout->dynamicDescriptorCount, 7193787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7194787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7195787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7196787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7197787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t d = 0; d < pSet->descriptorCount; d++) { 7198787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7199787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7200787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7201b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 7202787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7203787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7204787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7205787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7206787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7207787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minUniformBufferOffsetAlignment %#" PRIxLEAST64, 7208787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7209b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7210787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7211787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7212787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else if (pSet->pLayout->descriptorTypes[d] == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7213787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7214787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7215b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 7216787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 7217787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7218787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7219787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7220787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7221787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "device limit minStorageBufferOffsetAlignment %#" PRIxLEAST64, 7222787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7223b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7225787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7228787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7229787f29d93dee194c015789cf61c079504c980572Tobin Ehlis totalDynamicDescriptors += pSet->pLayout->dynamicDescriptorCount; 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7232787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 7233787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7234787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7235787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS %#" PRIxLEAST64 " that doesn't exist!", 7236787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 723872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 723972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 724072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 724172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 724272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 724372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility( 724472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data, dev_data->setMap[pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i]], layout, i, 724572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis errorString)) { 724672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 724772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 724872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 724972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 725072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "DescriptorSetDS %#" PRIxLEAST64 725172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u was disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 725272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 725372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 725472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 725572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 725672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 725772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 725872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 725972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 726072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis !verify_set_layout_compatibility(dev_data, dev_data->setMap[oldFinalBoundSet], layout, lastSetIndex, 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorString)) { 726272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 726372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 726472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)oldFinalBoundSet, __LINE__, 726572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis DRAWSTATE_NONE, "DS", "DescriptorSetDS %#" PRIxLEAST64 726672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " previously bound as set #%u is incompatible with set %#" PRIxLEAST64 726772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 726872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis "disturbed by newly bound pipelineLayout (%#" PRIxLEAST64 ")", 726972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)oldFinalBoundSet, lastSetIndex, 727072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 727172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 727272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7276787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7277787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 7278787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7279787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 7280787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7281787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 7282787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 7283787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7284787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7285787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Save dynamicOffsets bound to this CB 7286787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < dynamicOffsetCount; i++) { 7287e576798e0a38a7d941b6202d784ad705024e9fdcTobin Ehlis pCB->lastBound[pipelineBindPoint].dynamicOffsets.emplace_back(pDynamicOffsets[i]); 7288787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 7301e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 730403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 73070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 730872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 730972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 731172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 73205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 73215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 73225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 73255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 73285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 73295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 73315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 73325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBindIndexBuffer() offset (%#" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 73345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_INDEX_BUFFER_BOUND; 73375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7339e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 73415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 73465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 73475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 73505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7353e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 73565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bindingCount, const VkBuffer *pBuffers, 73575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkDeviceSize *pOffsets) { 7358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 73605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 736103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 73635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73640a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 736572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 736672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7367e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 736872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 73695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis addCmd(dev_data, pCB, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 73765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTracking(pCB, firstBinding, bindingCount, pBuffers); 73775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 73795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7381e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 73835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* expects globalLock to be held by caller */ 7386e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 73887a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 73897a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 73907a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 73917a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 73925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 73937a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 73947a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 73957a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 73960a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7397e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73987a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74007a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 74037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 74047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 74050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 74067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7407e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 74087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 7409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 74107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 74117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 74125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 74145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 74175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstVertex, uint32_t firstInstance) { 7418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 74205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 74215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 74245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7425e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74267a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 74295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 74305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW]++); 74315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 74365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7438e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 74435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 74445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 74455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7452e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 74537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndexed() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7459e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 74675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 74685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7473e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 747503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 74790a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 7486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 74877a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 74895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 74915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdDrawIndirect() call #%" PRIu64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7499e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 7505e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 750803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 7519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 75207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call #%" PRIu64 ", reporting DS state:", 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 7527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 75315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7533e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 75355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 7538e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7544e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75457a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75467a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7552e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 75575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 7558e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 756103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75640a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 75697a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Re-enable validate_and_update_draw_state() when it supports compute shaders 7570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves // skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 75717a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis // TODO : Call below is temporary until call above can be re-enabled 75727a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis update_shader_storage_images_and_buffers(dev_data, pCB); 75737a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7578e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferCopy *pRegions) { 7584e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 758703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 758972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 75910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 759272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7593e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBuffer()"); }; 759472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 75980a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 759972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7600e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7602e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 760472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBuffer"); 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 76080a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 76095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 76100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBuffer"); 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7619e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 76215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7623e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 7624e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 7625e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 763408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 7663e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 7664e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 767308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 76935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7703e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 770603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 770872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 771172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7712e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImage()", srcImage); }; 771372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 771872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7719e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 772372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImage"); 77260a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGE, "vkCmdCopyImage()"); 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImage"); 77355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 77365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7741e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7749e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 775203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 775472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 77560a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 775772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBlitImage()", srcImage); }; 775972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 77630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 776472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7765e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 77665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7767e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 776972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdBlitImage"); 77720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 77735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 77740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BLITIMAGE, "vkCmdBlitImage()"); 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBlitImage"); 77815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage dstImage, VkImageLayout dstImageLayout, 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7791e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 779403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 779672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 77970a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 779872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 7801e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 780372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78070a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 780872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7809e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdCopyBufferToImage()"); }; 781072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyBufferToImage"); 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 78140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 78155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 78160a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 78225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyBufferToImage"); 78235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7828e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout srcImageLayout, VkBuffer dstBuffer, 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7836e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 783903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 784172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78420a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 784372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7844e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7845e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return validate_memory_is_valid(dev_data, mem, "vkCmdCopyImageToBuffer()", srcImage); 7846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 784772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78510a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 785272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7853e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7855e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 785772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyImageToBuffer"); 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 78610a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 78625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 78630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 78695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyImageToBuffer"); 78705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 78715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 78725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7875e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7882e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 788503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 78865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 788772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 78890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 789072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7891e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 78925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7893e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 78945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 789572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 78965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 78985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 78990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 79055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyUpdateBuffer"); 79065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7908e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7914e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 791703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 791972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 79205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 79210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 792272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7923e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 79245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7925e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 792772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that dst buff has correct usage flags set 79310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdFillBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 79345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyFillBuffer"); 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 7940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *pAttachments, uint32_t rectCount, 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearRect *pRects) { 7947e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 79535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 79545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 79565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 79625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 79635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 79725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRPCI = dev_data->renderPassMap[pCB->activeRenderPass]->pCreateInfo; 79735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 79775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7978e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 79795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 79805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7981e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 79825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 79835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7985e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 79865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 79875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 79895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 79905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 79915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 79935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 79945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 79955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 79965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 79975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 79985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 79995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 80005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 80015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 80025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 80035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 80045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 80055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8010e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 80125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout, const VkClearColorValue *pColor, 80165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 8017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 802003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 802372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 802572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8028e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 803072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 80375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearColorImage"); 80385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8040e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 80465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 80475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange *pRanges) { 8048e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 805103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 80535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 805472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80550a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 805672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8057e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 8059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 806172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 80685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdClearDepthStencilImage"); 80695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8071e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 80745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 8079e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 80815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 808203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 808372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 80850a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 808672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8087e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdResolveImage()", srcImage); }; 808872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 80915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 809372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8094e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, dstImage); 8096e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 809872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdResolveImage"); 81015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 81025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 81055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResolveImage"); 81065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8108e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 81105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 81115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8113b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8114b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8115b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8116b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8117b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8118b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8119b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8120b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8121b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8122b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8123b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8124b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8125b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 81265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8128e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 81315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 81345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 81355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8136b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8137b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8138b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8141e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 81465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8147e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 81495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 81505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 81535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8155b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8156b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8157b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 81585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8160e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8164e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8165e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8168e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 81705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 81715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 81745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 81805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 81825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 81835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 81855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 81865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 818708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 818808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 81955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 81985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 82045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8207e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 82085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 82155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 82285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8229e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8230e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8231e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8232e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & !(required_bit | optional_bits)) { 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 82485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 82555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 82665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8268e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8269e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8270e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 82795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 82835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 83065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 83075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask %d %s are specified when layout is %s.", 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8320e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8321e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8324e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dev_data->renderPassMap[pCB->activeRenderPass]->hasSelfDependency[pCB->activeSubpass]) { 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8366b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8367b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 83695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8375b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 83921d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 83931d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 83945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 83955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 83965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 83975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 83985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8422f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8423f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8424f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8425f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 84315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 84325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8433f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8434f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8435f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8436f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 84375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 84405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 84415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 84425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 84435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 84485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8459b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8461b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 84655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8467b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 847194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 847294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis ? buffer_data->second.createInfo.size 847394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : 0; 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 847694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 847794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 847894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 847994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " which is not less than total size %" PRIu64 ".", 848094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 848194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 84825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 848394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 848494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 848594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset %" PRIu64 " and size %" PRIu64 848694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis " whose sum is greater than total size %" PRIu64 ".", 848794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 848894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 848994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 84905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84962ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8497b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8498b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8499b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8500b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 85012ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8502b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8503b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8504b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 85052ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8506b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8507b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8508b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 85092ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 8510b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 8511b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 851227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 851327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 85142ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8515b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 8516b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 8517b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8518b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8519b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8520b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (sourceStageMask != stageMask) { 8521b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= 8522b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 852327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes DRAWSTATE_INVALID_EVENT, "DS", 8524b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "Submitting cmdbuffer with call to VkCmdWaitEvents using srcStageMask 0x%x which must be the bitwise OR of the " 8525b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine "stageMask parameters used in calls to vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if used with vkSetEvent.", 8526b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine sourceStageMask); 8527b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8528b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8529b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8530b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8536e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85412ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.push_back(pEvents[i]); 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 85455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8546b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 85472ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8548b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 8571e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8583e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 85905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 8591e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 85935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 85975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8604e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 8609e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool %" PRIu64 ", index %d", 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8631e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 8637e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 0; 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8655e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8662e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 866603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 86675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 866872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 86700a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 867172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8674e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 867672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 86795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 86800a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 86815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 86825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 86865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->queryToStateMap[query]) { 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Requesting a copy from query to buffer with invalid query: queryPool %" PRIu64 ", index %d", 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 86955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 86995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8701e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 87035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const void *pValues) { 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8720b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((offset + size) > dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize) { 87215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePushConstantSize(dev_data, offset, size, "vkCmdPushConstants()"); 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Add warning if push constant update doesn't align with range 87245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8731e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 87335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap[query] = 1; 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 8745e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer *pFramebuffer) { 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8756fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes loader_platform_thread_lock_mutex(&globalLock); 8757fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8758fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8759fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8761fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8762fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8763fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8764fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8765fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 87740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 87765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8777fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8779fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8785e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8786e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8789e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8796e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8801e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8804e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8805e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8806e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 88091d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 88195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8830e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8837e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8838e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8844e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8848e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 88575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8858e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 88595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 88605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8861e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 88625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8865e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 88665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 88775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 88785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 88815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 88825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 88835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8885e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateDependencies(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin, 8886e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node) { 8887e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 88895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pCreateInfo = my_data->renderPassMap.at(pRenderPassBegin->renderPass)->pCreateInfo; 88905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 88915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 88925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 88945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 88965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 88975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 88995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 89045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 89055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 89065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 89095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 89105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 89155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 89165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 89175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 89185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 89205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 89225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 89305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 89385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 89395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 89415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 89435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 89471c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89501c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 89605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89641c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 89685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89721c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 89731c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 89741c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 89751c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 89761c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 89771c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 89781c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 89791c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 89835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 89845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 89865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 89875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 89885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 89915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 89925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 89935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 89975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9013e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9014e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 90155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90274d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 90305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 90365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90424d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 90584d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 90625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9069e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9070e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9071e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 90775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 90785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9098918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderModule *pShaderModule) { 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9104e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!shader_is_spirv(pCreateInfo)) { 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* dev */ 0, __LINE__, SHADER_CHECKER_NON_SPIRV_SHADER, "SC", "Shader is not SPIR-V"); 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9110e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 9117918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPass *pRenderPass) { 9126e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 91275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 91285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate 91345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 9135e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) { 9136ada0fecba2975cef315b77d8210748eafa2b078eTobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 91475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 91605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 91615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 91635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 91685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 91745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 91805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 91845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 91885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 91895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass] = new RENDER_PASS_NODE(localRPCI); 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->hasSelfDependency = has_self_dependency; 91935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->subpassToNode = subpass_to_node; 919487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 919587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 919687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 919787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 919887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 919987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 920087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 920187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 920287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachments.push_back(pass_info); 920387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 920487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 920587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, bool> &attachment_first_read = dev_data->renderPassMap[*pRenderPass]->attachment_first_read; 920687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 920787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis dev_data->renderPassMap[*pRenderPass]->attachment_first_layout; 920887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 920987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 9210b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 9211b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 9212b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9213b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 9214b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 92150d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 92160d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 92170d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 92180d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92190d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92200d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 92210d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92220d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92230d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 922487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 92250d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 92260d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 92270d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 92280d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 92290d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92300d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 92310d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 92320d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 92330d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 92340d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92350d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 92360d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 923724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 923824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 923924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 924024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 924124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 924224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 924324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 924487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 924587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 924687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 924787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 924887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 924987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 925087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 925124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 925224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 925324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 925424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 925524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 925624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 925724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 925887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 925987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 926087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 926187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 926287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 9263a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 9264a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 926524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 926624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 926724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 926824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 926924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 927024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 927124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 9272a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 9273a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 9274a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 9275a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 9276a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 927787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 927887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 92795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 92805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 92825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 92915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 92925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 92945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 93085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9313e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyFramebufferAndRenderPassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 9314e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 93195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 93255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 93305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 93425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 93475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 9348d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 93491c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 93501c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 93515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9358e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, 9359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 93675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 93685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pRenderPassInfo->pSubpasses[subpass_index]; 93735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 93745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 93755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 93785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 93795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 93835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9387e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 9388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 93915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 93935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9397e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void TransitionFinalSubpassLayouts(VkCommandBuffer cmdBuffer, const VkRenderPassBeginInfo *pRenderPassBegin) { 93985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 93995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 94005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data == dev_data->renderPassMap.end()) { 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = render_pass_data->second->pCreateInfo; 94055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto framebuffer_data = dev_data->frameBufferMap.find(pRenderPassBegin->framebuffer); 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (framebuffer_data == dev_data->frameBufferMap.end()) { 94075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = framebuffer_data->second.createInfo; 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 94115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 94125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9416e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 9417885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 9418885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 9419885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 9420885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 9421885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 9422885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 9423885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 9424885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9425885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 9426885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 9427885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 9428885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 9429885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 9430885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 9431885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 9432885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 9433885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 9434885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 94355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 9437e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 94405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 94425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassBegin && pRenderPassBegin->renderPass) { 944387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGE 944487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 944587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 944687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 944787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->fb = pRenderPassBegin->framebuffer; 944872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 944987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 945087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 945187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 945272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9453e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9455e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 945772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 945987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkImageLayout &attachment_layout = pRPNode->attachment_first_layout[pRPNode->attachments[i].attachment]; 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL || 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 94635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, (uint64_t)(pRenderPassBegin->renderPass), __LINE__, 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_LAYOUT, "MEM", "Cannot clear attachment %d with invalid first layout %d.", 946687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pRPNode->attachments[i].attachment, attachment_layout); 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 946887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 946972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9472e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 947472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 947687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 947772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9478e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 948172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 948487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachment_first_read[pRPNode->attachments[i].attachment]) { 948572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 948972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 9495e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyFramebufferAndRenderPassLayouts(commandBuffer, pRenderPassBegin); 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto render_pass_data = dev_data->renderPassMap.find(pRenderPassBegin->renderPass); 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (render_pass_data != dev_data->renderPassMap.end()) { 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= ValidateDependencies(dev_data, pRenderPassBegin, render_pass_data->second->subpassToNode); 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 95045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = pRenderPassBegin->renderPass; 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->framebuffer = pRenderPassBegin->framebuffer; 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->frameBufferMap[pCB->framebuffer].referencingCmdBuffers.insert(pCB->commandBuffer); 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 95165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9519e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassBeginInfo = *pRenderPassBegin; 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->currentSubpass = 0; 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 9530e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo, ++dev_data->currentSubpass); 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 95375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 95405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 954172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline) { 954272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= validatePipelineState(dev_data, pCB, VK_PIPELINE_BIND_POINT_GRAPHICS, 954372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 95445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9548e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkCmdEndRenderPass(VkCommandBuffer commandBuffer) { 9553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 955603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 955772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 955872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 955987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis auto pass_data = dev_data->renderPassMap.find(cb_data->second->activeRenderPass); 956087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pass_data != dev_data->renderPassMap.end()) { 956187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis RENDER_PASS_NODE* pRPNode = pass_data->second; 956287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 956387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_FB_ATTACHMENT_INFO &fb_info = dev_data->frameBufferMap[pRPNode->fb].attachments[i]; 956487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 956572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 9568e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 957072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 957287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 957372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 9574e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 9576e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 957872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 95795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &dev_data->renderPassBeginInfo); 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 95895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis TransitionFinalSubpassLayouts(commandBuffer, &pCB->activeRenderPassBeginInfo); 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPass = 0; 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9596e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 95975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 95985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9600e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9601e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkRenderPass primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9602e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 96035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 960781264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass), primaryAttach, secondaryAttach, 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9612e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9613e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, 9614e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->attachmentCount <= primaryAttach) { 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data->second->pCreateInfo->attachmentCount <= secondaryAttach) { 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 96335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].format != 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].format) { 96395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->pAttachments[primaryAttach].samples != 96435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].samples) { 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 96485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_data->second->pCreateInfo->pAttachments[primaryAttach].flags != 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_data->second->pCreateInfo->pAttachments[secondaryAttach].flags) { 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9656e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9657e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass, const int subpass, 9658e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 96605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 96615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 96625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &primary_desc = primary_data->second->pCreateInfo->pSubpasses[subpass]; 96635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &secondary_desc = secondary_data->second->pCreateInfo->pSubpasses[subpass]; 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 96725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 96785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 96795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 97055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 97065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9709e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9710e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 97135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 97145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto primary_data = dev_data->renderPassMap.find(primaryPass); 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto secondary_data = dev_data->renderPassMap.find(secondaryPass); 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data == dev_data->renderPassMap.end() || primary_data->second == nullptr) { 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_data == dev_data->renderPassMap.end() || secondary_data->second == nullptr) { 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer %p which has invalid render pass %" PRIx64 ".", 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_data->second->pCreateInfo->subpassCount != secondary_data->second->pCreateInfo->subpassCount) { 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a render pass %" PRIx64 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current render pass %" PRIx64 "." 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 97405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_multi = primary_data->second->pCreateInfo->subpassCount > 1; 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < primary_data->second->pCreateInfo->subpassCount; ++i) { 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis validateSubpassCompatibility(dev_data, primaryBuffer, primaryPass, secondaryBuffer, secondaryPass, i, is_multi); 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9750e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9751e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 97545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer primary_fb = pCB->framebuffer; 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p which has a framebuffer %" PRIx64 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is not compatible with the current framebuffer %" PRIx64 ".", 97645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 97655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fb_data = dev_data->frameBufferMap.find(secondary_fb); 97675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fb_data == dev_data->frameBufferMap.end()) { 97685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid framebuffer %" PRIx64 ".", 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 97735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb_data->second.createInfo.renderPass, 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 97825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 97835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 97845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 97855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 97885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 97895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 97905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 97915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 ". Pipeline statistics is being queried so the command " 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p " 98105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "which has invalid active query pool %" PRIx64 "of type %d but a query of that type has been started on " 98115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "secondary Cmd Buffer %p.", 98125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 98135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 98145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 98175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 98205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 98235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 98295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Cmd Buffer %p in element %u of pCommandBuffers array.", 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer %p in element %u of pCommandBuffers " 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) executed within render pass (%#" PRIxLEAST64 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass); 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass, pCommandBuffers[i], 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 98535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass, 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) w/ render pass (%#" PRIxLEAST64 98625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") is incompatible w/ primary command buffer (%p) w/ render pass (%#" PRIxLEAST64 ") due to: %s", 98635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 98645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPass, errorString.c_str()); 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 98685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%p) references framebuffer (%#" PRIxLEAST64 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does not match framebuffer (%#" PRIxLEAST64 ") in active renderpass (%#" PRIxLEAST64 ").", 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass); 98775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 98835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 98875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attempt to simultaneously execute CB %#" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer (%#" PRIxLEAST64 99005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9907b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 99105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 99115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 99125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%#" PRIxLEAST64 ") cannot be submitted with a query in " 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 99185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 99195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 99205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 99225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 99235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9925e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 99265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 99275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9929e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9930e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 993258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 993358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 99345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 993558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 99365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 99375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 99385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 99405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 99415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 99425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 99475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 99505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9953e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 995603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 995758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9960b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9961b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 99625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 99635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 99645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 99655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj %#" PRIxLEAST64, (uint64_t)mem); 99665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 99695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis storeMemRanges(dev_data, mem, offset, size); 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 997158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9974e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 99755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 997603b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 997781a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_lock_mutex(&globalLock); 99785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 997981a46bbcaaf47ce86080d8a86dcab9817dbcc34fMark Lobodzinski loader_platform_thread_unlock_mutex(&globalLock); 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 998503b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 99865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkUnmapMemory(VkDevice device, VkDeviceMemory mem) { 99875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 99895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 99915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 99925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 9993e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 99945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 99955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9998e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9999e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10000e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 100055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 100065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 100085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 100095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 100115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_element->second.memRange.size != VK_WHOLE_SIZE) && 100135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((mem_element->second.memRange.offset + mem_element->second.memRange.size) < 100145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pMemRanges[i].offset + pMemRanges[i].size))) { 100155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 100185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 100195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 100205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 100215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis static_cast<size_t>(mem_element->second.memRange.offset + mem_element->second.memRange.size)); 100225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10028e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10029e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 10030e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 100325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 100335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 100345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 100355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 100365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 100375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 100385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 100395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 100475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 100485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 100495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 100505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj %" PRIxLEAST64, 100515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 100525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 100555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 100595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10064e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 100685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 100695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 100705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 10071e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 100735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VkResult VKAPI_CALL 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 100795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10080e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 100855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 10086e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 100875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkBindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10096e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 100975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1009894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 1009994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 1010094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1010109df2b6afd74a6494aa530ba23a80ba69abc79dfDustin Graves uint64_t image_handle = reinterpret_cast<uint64_t&>(image); 1010294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 101035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 1010494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1010594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 1010694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1010758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= validate_buffer_image_aliasing(dev_data, image_handle, mem, memoryOffset, memRequirements, 1010858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap[mem].imageRanges, dev_data->memObjMap[mem].bufferRanges, 1010958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 101100a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1011294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 1011394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 1011494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 1011594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 1011694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 1011794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 1011894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 1011994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 1012094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1012194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1012294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1012394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 1012494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis "vkBindImageMemory: Cannot find invalid image %" PRIx64 ", has it already been deleted?", 1012594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 101265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkSetEvent(VkDevice device, VkEvent event) { 101315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 101335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[event].needsSignaled = false; 101345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[event].stageMask = VK_PIPELINE_STAGE_HOST_BIT; 101355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 101366fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 101376fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 101386fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 101396fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 101406fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 101416fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 101426fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 101436fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101446fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 101455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->SetEvent(device, event); 101465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 101475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 101515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 101525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10153e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 1015403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 101555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis //MTMTODO : Merge this code with the checks below 101565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 101575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfoCount; i++) { 101595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo *bindInfo = &pBindInfo[i]; 101605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 101615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->bufferBindCount; j++) { 101625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pBufferBinds[j].bindCount; k++) { 101630a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes if (set_sparse_mem_binding(dev_data, bindInfo->pBufferBinds[j].pBinds[k].memory, 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 101655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->imageOpaqueBindCount; j++) { 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pImageOpaqueBinds[j].bindCount; k++) { 101710a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes if (set_sparse_mem_binding(dev_data, bindInfo->pImageOpaqueBinds[j].pBinds[k].memory, 101725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 101735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10174e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < bindInfo->imageBindCount; j++) { 101785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < bindInfo->pImageBinds[j].bindCount; k++) { 101790a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes if (set_sparse_mem_binding(dev_data, bindInfo->pImageBinds[j].pBinds[k].memory, 101805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)bindInfo->pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 101815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10182e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 101835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate semaphore state 101865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->waitSemaphoreCount; i++) { 101875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pWaitSemaphores[i]; 101885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 101895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 101905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_SIGNALLED) { 101915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 101925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 101935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 101945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse: Semaphore must be in signaled state before passing to pWaitSemaphores"); 101955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_WAIT; 101975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->signalSemaphoreCount; i++) { 102005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pSignalSemaphores[i]; 102015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 102035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[sem].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 102045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 102055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 102065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)sem, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 102075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse: Semaphore must not be currently signaled or in a wait state"); 102085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 102105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102140a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 102155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 102175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 102195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 102205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 102215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[bindInfo.pWaitSemaphores[i]].signaled) { 102225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[bindInfo.pWaitSemaphores[i]].signaled = 0; 102235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 102245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 102255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 102265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 102275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 102285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queue), (uint64_t)(bindInfo.pWaitSemaphores[i])); 102295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 102325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[bindInfo.pSignalSemaphores[i]].signaled = 1; 102335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10237e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 102385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 1023903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 102405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Update semaphore state 102415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t bind_info_idx = 0; bind_info_idx < bindInfoCount; bind_info_idx++) { 102435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkBindSparseInfo *bindInfo = &pBindInfo[bind_info_idx]; 102445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindInfo->waitSemaphoreCount; i++) { 102455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = bindInfo->pWaitSemaphores[i]; 102465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 102485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 102495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 102545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkCreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 102595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 102605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 102625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 102635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 102655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->signaled = 0; 102660a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 102675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 102685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->state = MEMTRACK_SEMAPHORE_STATE_UNSET; 102695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 102755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 102765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 102785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 102795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 102815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 102825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 102865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkCreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 102895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, 102905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSwapchainKHR *pSwapchain) { 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 102950801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 102965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 102970801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 102985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 103055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 103065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 103085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 103115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 103135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 103145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 103155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 103165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 103175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 103185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 103195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 103205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 103235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 103250801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1032694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 103315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 103345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 103355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 103385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 103395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 103405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 103415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 103435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 103445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 103455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 103480801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 103490801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 103500801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 103510801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 103520801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 103535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 103545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 103555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 103565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 103575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkGetSwapchainInfoKHR(%" PRIu64 103585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 103595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 103605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 103655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 1036694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 1036794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 1036894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 1036994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 1037094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 1037194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 103725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 103735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 103745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 103755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 103765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 103775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 103795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 103815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkQueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 103855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 103865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 103895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 103905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 103915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[pPresentInfo->pWaitSemaphores[i]].signaled) { 103925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[pPresentInfo->pWaitSemaphores[i]].signaled = 0; 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 103955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 103965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 103975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Queue %#" PRIx64 " is waiting on semaphore %#" PRIx64 " that has no way to be signaled.", 103985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queue), (uint64_t)(pPresentInfo->pWaitSemaphores[i])); 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104010801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 104035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 1040703b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 104080801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 104090a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 104100801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 1041103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 104155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 104165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 104195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 104205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 104215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 1043203b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; i++) { 104355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore sem = pPresentInfo->pWaitSemaphores[i]; 104365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap.find(sem) != dev_data->semaphoreMap.end()) { 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[sem].state = MEMTRACK_SEMAPHORE_STATE_UNSET; 104385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL vkAcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 104495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 1045003b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104521657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 104531657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->semaphoreMap[semaphore].state != MEMTRACK_SEMAPHORE_STATE_UNSET) { 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)semaphore, __LINE__, MEMTRACK_NONE, "SEMAPHORE", 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[semaphore].state = MEMTRACK_SEMAPHORE_STATE_SIGNALLED; 104603d722f98b98af892a5c2b98a26068db98de39c33Mark Lobodzinski dev_data->semaphoreMap[semaphore].in_use.fetch_add(1); 104615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 104645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 104655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 104705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 104715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // FIXME/TODO: Need to add some thing code the "fence" parameter 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap[semaphore].signaled = 1; 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 104805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 104815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 104855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 104865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 104875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 104885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 104895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 104935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL vkDestroyDebugReportCallbackEXT(VkInstance instance, 104945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT msgCallback, 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAllocationCallbacks *pAllocator) { 104965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 104975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 104985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 104995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_lock_mutex(&globalLock); 105005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 105015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis loader_platform_thread_unlock_mutex(&globalLock); 105025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR void VKAPI_CALL 105055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 105105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 105165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueSubmit")) 105185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueSubmit; 105195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkWaitForFences")) 105205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkWaitForFences; 105215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetFenceStatus")) 105225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetFenceStatus; 105235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueWaitIdle")) 105245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueWaitIdle; 105255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDeviceWaitIdle")) 105265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDeviceWaitIdle; 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceQueue")) 105285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceQueue; 105295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDevice")) 105325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDevice; 105335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFence")) 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFence; 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetFences")) 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetFences; 105375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySemaphore")) 105385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySemaphore; 105395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyEvent")) 105405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyEvent; 105415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyQueryPool")) 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyQueryPool; 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBuffer")) 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBuffer; 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyBufferView")) 105465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyBufferView; 105475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImage")) 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImage; 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyImageView")) 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyImageView; 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyShaderModule")) 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyShaderModule; 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipeline")) 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipeline; 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyPipelineLayout")) 105565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineLayout; 105575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySampler")) 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySampler; 105595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorSetLayout")) 105605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorSetLayout; 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyDescriptorPool")) 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyDescriptorPool; 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyFramebuffer")) 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyFramebuffer; 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyRenderPass")) 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyRenderPass; 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBuffer")) 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBuffer; 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateBufferView")) 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateBufferView; 105715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImage")) 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImage; 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateImageView")) 105745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateImageView; 105755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFence")) 105765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFence; 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "CreatePipelineCache")) 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineCache; 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "DestroyPipelineCache")) 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyPipelineCache; 105815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "GetPipelineCacheData")) 105825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetPipelineCacheData; 105835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "MergePipelineCaches")) 105845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMergePipelineCaches; 105855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateGraphicsPipelines")) 105865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateGraphicsPipelines; 105875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateComputePipelines")) 105885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateComputePipelines; 105895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSampler")) 105905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSampler; 105915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorSetLayout")) 105925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorSetLayout; 105935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreatePipelineLayout")) 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreatePipelineLayout; 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDescriptorPool")) 105965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDescriptorPool; 105975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetDescriptorPool")) 105985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetDescriptorPool; 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateDescriptorSets")) 106005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateDescriptorSets; 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeDescriptorSets")) 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeDescriptorSets; 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUpdateDescriptorSets")) 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUpdateDescriptorSets; 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateCommandPool")) 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateCommandPool; 106075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyCommandPool")) 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyCommandPool; 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandPool")) 106105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandPool; 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateQueryPool")) 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateQueryPool; 106135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateCommandBuffers")) 106145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateCommandBuffers; 106155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeCommandBuffers")) 106165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeCommandBuffers; 106175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBeginCommandBuffer")) 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBeginCommandBuffer; 106195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEndCommandBuffer")) 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEndCommandBuffer; 106215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkResetCommandBuffer")) 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkResetCommandBuffer; 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindPipeline")) 106245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindPipeline; 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetViewport")) 106265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetViewport; 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetScissor")) 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetScissor; 106295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetLineWidth")) 106305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetLineWidth; 106315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBias")) 106325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBias; 106335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetBlendConstants")) 106345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetBlendConstants; 106355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetDepthBounds")) 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetDepthBounds; 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilCompareMask")) 106385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilCompareMask; 106395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilWriteMask")) 106405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilWriteMask; 106415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetStencilReference")) 106425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetStencilReference; 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindDescriptorSets")) 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindDescriptorSets; 106455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindVertexBuffers")) 106465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindVertexBuffers; 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBindIndexBuffer")) 106485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBindIndexBuffer; 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDraw")) 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDraw; 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexed")) 106525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexed; 106535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndirect")) 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndirect; 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDrawIndexedIndirect")) 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDrawIndexedIndirect; 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatch")) 106585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatch; 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdDispatchIndirect")) 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdDispatchIndirect; 106615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBuffer")) 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBuffer; 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImage")) 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImage; 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBlitImage")) 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBlitImage; 106675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyBufferToImage")) 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyBufferToImage; 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyImageToBuffer")) 106705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyImageToBuffer; 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdUpdateBuffer")) 106725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdUpdateBuffer; 106735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdFillBuffer")) 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdFillBuffer; 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearColorImage")) 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearColorImage; 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearDepthStencilImage")) 106785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearDepthStencilImage; 106795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdClearAttachments")) 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdClearAttachments; 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResolveImage")) 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResolveImage; 106835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdSetEvent")) 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdSetEvent; 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetEvent")) 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetEvent; 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWaitEvents")) 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWaitEvents; 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPipelineBarrier")) 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPipelineBarrier; 106915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginQuery")) 106925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginQuery; 106935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndQuery")) 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndQuery; 106955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdResetQueryPool")) 106965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdResetQueryPool; 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdCopyQueryPoolResults")) 106985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdCopyQueryPoolResults; 106995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdPushConstants")) 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdPushConstants; 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdWriteTimestamp")) 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdWriteTimestamp; 107035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateFramebuffer")) 107045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateFramebuffer; 107055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateShaderModule")) 107065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateShaderModule; 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateRenderPass")) 107085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateRenderPass; 107095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdBeginRenderPass")) 107105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdBeginRenderPass; 107115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdNextSubpass")) 107125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdNextSubpass; 107135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdEndRenderPass")) 107145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdEndRenderPass; 107155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCmdExecuteCommands")) 107165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCmdExecuteCommands; 107175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkSetEvent")) 107185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkSetEvent; 107195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkMapMemory")) 107205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkMapMemory; 1072103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 107225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkUnmapMemory")) 107235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkUnmapMemory; 107245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAllocateMemory")) 107255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAllocateMemory; 107265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFreeMemory")) 107275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFreeMemory; 107285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkFlushMappedMemoryRanges")) 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkFlushMappedMemoryRanges; 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkInvalidateMappedMemoryRanges")) 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkInvalidateMappedMemoryRanges; 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindBufferMemory")) 107335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindBufferMemory; 107345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetBufferMemoryRequirements")) 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetBufferMemoryRequirements; 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetImageMemoryRequirements")) 107375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetImageMemoryRequirements; 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 107395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetQueryPoolResults")) 107405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetQueryPoolResults; 107415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkBindImageMemory")) 107425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkBindImageMemory; 107435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueueBindSparse")) 107445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueueBindSparse; 107455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSemaphore")) 107465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSemaphore; 107475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateEvent")) 107485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateEvent; 107495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev == NULL) 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->device_extensions.wsi_enabled) { 107575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateSwapchainKHR")) 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateSwapchainKHR; 107595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroySwapchainKHR")) 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroySwapchainKHR; 107615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetSwapchainImagesKHR")) 107625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetSwapchainImagesKHR; 107635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkAcquireNextImageKHR")) 107645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkAcquireNextImageKHR; 107655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkQueuePresentKHR")) 107665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkQueuePresentKHR; 107675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 107725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 107745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 107785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetInstanceProcAddr")) 107795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetInstanceProcAddr; 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkGetDeviceProcAddr")) 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkGetDeviceProcAddr; 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateInstance")) 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateInstance; 107845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkCreateDevice")) 107855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkCreateDevice; 107865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkDestroyInstance")) 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkDestroyInstance; 107885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 107895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceLayerProperties; 107905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 107915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateInstanceExtensionProperties; 107925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 107935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceLayerProperties; 107945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(funcName, "vkEnumerateDeviceExtensionProperties")) 107955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (PFN_vkVoidFunction)vkEnumerateDeviceExtensionProperties; 107965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (instance == NULL) 107985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 107995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkVoidFunction fptr; 108015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 108035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 108045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fptr = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 108055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fptr) 108065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return fptr; 108075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 108125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10813