core_validation.cpp revision 4b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fc
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 41825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski//#include <memory> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 46dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 63b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 73c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 77414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 78d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 79d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 86888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// 2nd special memory handle used to flag object as unbound from memory 87888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic const VkDeviceMemory MEMORY_UNBOUND = VkDeviceMemory(~((uint64_t)(0)) - 1); 88b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 90e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 91c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young bool wsi_display_swapchain_enabled; 923f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis unordered_map<VkSwapchainKHR, unique_ptr<SWAPCHAIN_NODE>> swapchainMap; 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 101d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkInstance instance = VK_NULL_HANDLE; 102d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes unique_ptr<INSTANCE_STATE> instance_state = nullptr; 103b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski 10456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 105d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes debug_report_data *report_data = nullptr; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 107d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkLayerDispatchTable *device_dispatch_table = nullptr; 108d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkLayerInstanceDispatchTable *instance_dispatch_table = nullptr; 10994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 110d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes devExts device_extensions = {}; 111cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski unordered_set<VkQueue> queues; // All queues under given device 112cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Vector indices correspond to queueFamilyIndex 113cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski vector<unique_ptr<VkQueueFamilyProperties>> queue_family_properties; 1145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 117cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 11879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis unordered_map<VkImageView, unique_ptr<IMAGE_VIEW_STATE>> imageViewMap; 1196d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis unordered_map<VkImage, unique_ptr<IMAGE_NODE>> imageMap; 12039267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis unordered_map<VkBufferView, unique_ptr<BUFFER_VIEW_STATE>> bufferViewMap; 1218718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis unordered_map<VkBuffer, unique_ptr<BUFFER_NODE>> bufferMap; 1225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1238d6a38de0389036581ada119e548180c614fe0efChris Forbes unordered_map<VkCommandPool, COMMAND_POOL_NODE> commandPoolMap; 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 125397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 126cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 12857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis unordered_map<VkDeviceMemory, unique_ptr<DEVICE_MEM_INFO>> memObjMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 13572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 13604861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis unordered_map<VkFramebuffer, unique_ptr<FRAMEBUFFER_NODE>> frameBufferMap; 1375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 139fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes unordered_map<VkRenderPass, unique_ptr<RENDER_PASS_NODE>> renderPassMap; 140918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 141d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkDevice device = VK_NULL_HANDLE; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14307a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes layer_data *instance_data = nullptr; // from device to enclosing instance 14407a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes 145f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes VkPhysicalDeviceFeatures enabled_features = {}; 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 147d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes PHYS_DEV_PROPERTIES_NODE phys_dev_properties = {}; 148d3578035fec44db2380099c2f59d3e4d8e0b98d6Chris Forbes VkPhysicalDeviceMemoryProperties phys_dev_mem_props = {}; 1493bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 1503bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes unordered_map<VkPhysicalDevice, PHYSICAL_DEVICE_STATE> physical_device_map; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 156e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 157f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 158e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 163e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 169e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 183b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 184b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 185b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 186b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 187b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 188b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 190b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 1995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 254b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 255593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 25679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis// Return IMAGE_VIEW_STATE ptr for specified imageView or else NULL 25779fde938178535f598e030a0e9d19a0cb61b72e0Tobin EhlisIMAGE_VIEW_STATE *getImageViewState(const layer_data *dev_data, VkImageView image_view) { 2582c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto iv_it = dev_data->imageViewMap.find(image_view); 2592c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (iv_it == dev_data->imageViewMap.end()) { 2602c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return nullptr; 2612c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis } 2622c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis return iv_it->second.get(); 2632c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis} 2649a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis// Return sampler node ptr for specified sampler or else NULL 265a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSAMPLER_NODE *getSamplerNode(const layer_data *dev_data, VkSampler sampler) { 2662c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto sampler_it = dev_data->samplerMap.find(sampler); 2672c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (sampler_it == dev_data->samplerMap.end()) { 2689a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return nullptr; 2699a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis } 2709a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis return sampler_it->second.get(); 2719a55ca3674bb3fac3fbdfca9515a16a224aa9055Tobin Ehlis} 2726d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis// Return image node ptr for specified image or else NULL 273a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisIMAGE_NODE *getImageNode(const layer_data *dev_data, VkImage image) { 2746d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_it = dev_data->imageMap.find(image); 2756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_it == dev_data->imageMap.end()) { 2766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return nullptr; 2776d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis } 2786d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return img_it->second.get(); 2796d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis} 2808718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis// Return buffer node ptr for specified buffer or else NULL 281a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisBUFFER_NODE *getBufferNode(const layer_data *dev_data, VkBuffer buffer) { 2822c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis auto buff_it = dev_data->bufferMap.find(buffer); 2832c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis if (buff_it == dev_data->bufferMap.end()) { 2848718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return nullptr; 2858718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis } 2868718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return buff_it->second.get(); 2878718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis} 288b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis// Return swapchain node for specified swapchain or else NULL 289a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisSWAPCHAIN_NODE *getSwapchainNode(const layer_data *dev_data, VkSwapchainKHR swapchain) { 290b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swp_it = dev_data->device_extensions.swapchainMap.find(swapchain); 291b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swp_it == dev_data->device_extensions.swapchainMap.end()) { 292b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis return nullptr; 293b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis } 2943f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis return swp_it->second.get(); 295b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis} 296170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis// Return swapchain for specified image or else NULL 297a682b1c533d9a492243b363c6585c4f03bcd87aaTobin EhlisVkSwapchainKHR getSwapchainFromImage(const layer_data *dev_data, VkImage image) { 298170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto img_it = dev_data->device_extensions.imageToSwapchainMap.find(image); 299170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (img_it == dev_data->device_extensions.imageToSwapchainMap.end()) { 300170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return VK_NULL_HANDLE; 301170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis } 302170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis return img_it->second; 303170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis} 3042f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis// Return buffer node ptr for specified buffer or else NULL 30539267c0c27b8f032f05a6747eb02d4508247fdc1Tobin EhlisBUFFER_VIEW_STATE *getBufferViewState(const layer_data *my_data, VkBufferView buffer_view) { 3062f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis auto bv_it = my_data->bufferViewMap.find(buffer_view); 3072f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis if (bv_it == my_data->bufferViewMap.end()) { 3082f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return nullptr; 3092f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis } 3102f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis return bv_it->second.get(); 3112f2db584f5d79892bd84d0a24b8ca3499985a5c2Tobin Ehlis} 3128718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis 31366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesFENCE_NODE *getFenceNode(layer_data *dev_data, VkFence fence) { 31466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->fenceMap.find(fence); 31566fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->fenceMap.end()) { 31666fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 31766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 31866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 31966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 32066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3219556936067fd0c4eb74c4a13631bc163b154faedTobin EhlisEVENT_NODE *getEventNode(layer_data *dev_data, VkEvent event) { 3229556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto it = dev_data->eventMap.find(event); 3239556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (it == dev_data->eventMap.end()) { 3249556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return nullptr; 3259556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 3269556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis return &it->second; 3279556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis} 3289556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis 329ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin EhlisQUERY_POOL_NODE *getQueryPoolNode(layer_data *dev_data, VkQueryPool query_pool) { 330ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto it = dev_data->queryPoolMap.find(query_pool); 331ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (it == dev_data->queryPoolMap.end()) { 332ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return nullptr; 333ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 334ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis return &it->second; 335ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis} 336ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis 33766fb98d19a758f79dd11ba354e47d0c66c6aac1eChris ForbesQUEUE_NODE *getQueueNode(layer_data *dev_data, VkQueue queue) { 33866fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes auto it = dev_data->queueMap.find(queue); 33966fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes if (it == dev_data->queueMap.end()) { 34066fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return nullptr; 34166fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes } 34266fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes return &it->second; 34366fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes} 34466fb98d19a758f79dd11ba354e47d0c66c6aac1eChris Forbes 3455e92f3cfdca6a52a3dcefd053c41f728bd036cebChris ForbesSEMAPHORE_NODE *getSemaphoreNode(layer_data *dev_data, VkSemaphore semaphore) { 3465e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes auto it = dev_data->semaphoreMap.find(semaphore); 3475e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes if (it == dev_data->semaphoreMap.end()) { 3485e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return nullptr; 3495e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes } 3505e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes return &it->second; 3515e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes} 3525e92f3cfdca6a52a3dcefd053c41f728bd036cebChris Forbes 3538d6a38de0389036581ada119e548180c614fe0efChris ForbesCOMMAND_POOL_NODE *getCommandPoolNode(layer_data *dev_data, VkCommandPool pool) { 3548d6a38de0389036581ada119e548180c614fe0efChris Forbes auto it = dev_data->commandPoolMap.find(pool); 3558d6a38de0389036581ada119e548180c614fe0efChris Forbes if (it == dev_data->commandPoolMap.end()) { 3568d6a38de0389036581ada119e548180c614fe0efChris Forbes return nullptr; 3578d6a38de0389036581ada119e548180c614fe0efChris Forbes } 3588d6a38de0389036581ada119e548180c614fe0efChris Forbes return &it->second; 3598d6a38de0389036581ada119e548180c614fe0efChris Forbes} 3603bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 3613bb2c67470811e4eaf908b3eade82f73aa3f87bcChris ForbesPHYSICAL_DEVICE_STATE *getPhysicalDeviceState(layer_data *dev_data, VkPhysicalDevice phys) { 3623bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto it = dev_data->physical_device_map.find(phys); 3633bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes if (it == dev_data->physical_device_map.end()) { 3643bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return nullptr; 3653bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes } 3663bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes return &it->second; 3673bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes} 3683bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes 369888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// Return ptr to bound memory for given handle of specified type and set sparse param to indicate if binding is sparse 370888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic VkDeviceMemory *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type, bool *sparse) { 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 3725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 3736d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, VkImage(handle)); 374888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis *sparse = img_node->createInfo.flags & VK_IMAGE_CREATE_SPARSE_BINDING_BIT; 3756d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (img_node) 3766d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis return &img_node->mem; 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 3808718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buff_node = getBufferNode(my_data, VkBuffer(handle)); 381888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis *sparse = buff_node->createInfo.flags & VK_BUFFER_CREATE_SPARSE_BINDING_BIT; 3828718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buff_node) 3838718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis return &buff_node->mem; 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 3875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 3905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 391888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// Overloaded version of above function that doesn't care about sparse bool 392888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic VkDeviceMemory *GetObjectMemBinding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 393888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool sparse; 394888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis return GetObjectMemBinding(my_data, handle, type, &sparse); 395888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis} 39672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 3975121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 39872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 4030a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 4040a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 4050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 406e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 40783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 4115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 41383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 41483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 41583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 41683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 4175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 422249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 423249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// an error will be flagged if usage is not correct 42459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateImageUsageFlags(layer_data *dev_data, IMAGE_NODE const *image_node, VkFlags desired, VkBool32 strict, 425249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis char const *func_name, char const *usage_string) { 426249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis return validate_usage_flags(dev_data, image_node->createInfo.usage, desired, strict, 427249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis reinterpret_cast<const uint64_t &>(image_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 428249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis "image", func_name, usage_string); 429249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis} 430249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 431249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis// Helper function to validate usage flags for buffers 432ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// For given buffer_node send actual vs. desired usage off to helper above where 433ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// an error will be flagged if usage is not correct 43459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlisstatic bool ValidateBufferUsageFlags(layer_data *dev_data, BUFFER_NODE const *buffer_node, VkFlags desired, VkBool32 strict, 435ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis char const *func_name, char const *usage_string) { 436ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis return validate_usage_flags(dev_data, buffer_node->createInfo.usage, desired, strict, 437ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis reinterpret_cast<const uint64_t &>(buffer_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 438ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "buffer", func_name, usage_string); 439ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 440ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 4415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 44357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin EhlisDEVICE_MEM_INFO *getMemObjInfo(const layer_data *dev_data, const VkDeviceMemory mem) { 44457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_it = dev_data->memObjMap.find(mem); 44557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_it == dev_data->memObjMap.end()) { 4465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 4475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis return mem_it->second.get(); 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 4535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis my_data->memObjMap[mem] = unique_ptr<DEVICE_MEM_INFO>(new DEVICE_MEM_INFO(object, mem, pAllocateInfo)); 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 457dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 458dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// Helper function to print lowercase string of object type 459dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis// TODO: Unify string helper functions, this should really come out of a string helper if not there already 460dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 461dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis switch (type) { 462dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 463dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "image"; 464dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 465dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "buffer"; 4667e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: 4677e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "image view"; 4687e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: 4697e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "buffer view"; 470dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 471dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "swapchain"; 472dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: 473dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "descriptor set"; 474dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: 4756f62283faa835f7fd302771a3a693d1aafff4652Tobin Ehlis return "framebuffer"; 476dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: 477dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "event"; 478dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: 479dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "query pool"; 4807e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: 4817e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "descriptor pool"; 4827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: 4837e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "command pool"; 484dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: 485dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "pipeline"; 486dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: 487dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "sampler"; 4887e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: 4897e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "renderpass"; 4907e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: 4917e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return "device memory"; 492eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT: 493eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return "semaphore"; 494dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis default: 495dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return "unknown"; 496dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis } 497dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis} 498dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis 499cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given bound_object_handle, bound to given mem allocation, verify that the range for the bound object is valid 500f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateMemoryIsValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t bound_object_handle, 501dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *functionName) { 502f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 503f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 504f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!mem_info->bound_ranges[bound_object_handle].valid) { 505f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 506ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 507dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis "%s: Cannot read invalid region of memory allocation 0x%" PRIx64 " for bound %s object 0x%" PRIx64 508dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis ", please fill the memory before using.", 509dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis functionName, reinterpret_cast<uint64_t &>(mem), object_type_to_string(type), bound_object_handle); 510f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 511f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 512f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return false; 513f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 514f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image_node 515f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then verify that image_node valid member is true 516f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else verify that the image's bound memory range is valid 517f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateImageMemoryIsValid(layer_data *dev_data, IMAGE_NODE *image_node, const char *functionName) { 518f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 519f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (!image_node->valid) { 520f48a83f5b5548cd46a12770c7542ff902537ad3eKarl Schultz return log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 521ea8e85ade623a09c601d939622cbd7740d8d66c9Tobin Ehlis reinterpret_cast<uint64_t &>(image_node->mem), __LINE__, MEMTRACK_INVALID_MEM_REGION, "MEM", 522414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 523f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis functionName, reinterpret_cast<uint64_t &>(image_node->image)); 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 526dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return ValidateMemoryIsValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), 527dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, functionName); 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 531f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer_node, verify that the range it's bound to is valid 532f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic bool ValidateBufferMemoryIsValid(layer_data *dev_data, BUFFER_NODE *buffer_node, const char *functionName) { 533dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis return ValidateMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), 534dc21d4c322604e04e0b8433970f6a1ced6a0b647Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, functionName); 535f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 536f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For the given memory allocation, set the range bound by the given handle object to the valid param value 537f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetMemoryValid(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, bool valid) { 538f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 539f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (mem_info) { 540f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis mem_info->bound_ranges[handle].valid = valid; 541f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis } 542f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 543f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given image node 544f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// If mem is special swapchain key, then set entire image_node to valid param value 545f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// Else set the image's bound memory range to valid param value 546f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetImageMemoryValid(layer_data *dev_data, IMAGE_NODE *image_node, bool valid) { 547f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis if (image_node->mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 548f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis image_node->valid = valid; 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 550f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, image_node->mem, reinterpret_cast<uint64_t &>(image_node->image), valid); 5515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 553f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis// For given buffer node set the buffer's bound memory range to valid param value 554f989de4217bce0f293121d0da53dc8328276370fTobin Ehlisstatic void SetBufferMemoryValid(layer_data *dev_data, BUFFER_NODE *buffer_node, bool valid) { 555f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetMemoryValid(dev_data, buffer_node->mem, reinterpret_cast<uint64_t &>(buffer_node->buffer), valid); 556f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis} 5575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 560e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 56183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 56757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, mem); 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 569de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb); 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 57172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 57372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 574c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 580ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 58156f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given sampler and command buffer node 58256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlisvoid AddCommandBufferBindingSampler(GLOBAL_CB_NODE *cb_node, SAMPLER_NODE *sampler_node) { 58356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis sampler_node->cb_bindings.insert(cb_node); 58456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(sampler_node->sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}); 58556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis} 58656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis 58756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis// Create binding link between given image node and command buffer node 588c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingImage(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_NODE *img_node) { 589ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Skip validation if this image was created through WSI 590ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (img_node->mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 591ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 592ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, img_node->mem); 593ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 594de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 595ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 596ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(img_node->mem); 597ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 598f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis // Now update cb binding for image 599bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}); 600f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis img_node->cb_bindings.insert(cb_node); 601ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 602ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 603ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 60403ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis// Create binding link between given image view node and its image with command buffer node 60503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlisvoid AddCommandBufferBindingImageView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, IMAGE_VIEW_STATE *view_state) { 60603ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // First add bindings for imageView 60703ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis view_state->cb_bindings.insert(cb_node); 60803ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis cb_node->object_bindings.insert( 60903ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->image_view), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}); 610f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis auto image_node = getImageNode(dev_data, view_state->create_info.image); 61103ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis // Add bindings for image within imageView 61203ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis if (image_node) { 61303ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, image_node); 61403ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis } 61503ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis} 61603ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis 617ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis// Create binding link between given buffer node and command buffer node 618c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlisvoid AddCommandBufferBindingBuffer(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_NODE *buff_node) { 619ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // First update CB binding in MemObj mini CB list 620ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis DEVICE_MEM_INFO *pMemInfo = getMemObjInfo(dev_data, buff_node->mem); 621ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (pMemInfo) { 622de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemInfo->command_buffer_bindings.insert(cb_node->commandBuffer); 623ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update CBInfo's Mem reference list 624ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->memObjs.insert(buff_node->mem); 625bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis cb_node->object_bindings.insert({reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 626ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } 627ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Now update cb binding for buffer 628ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis buff_node->cb_bindings.insert(cb_node); 629ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis} 630ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 63177b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis// Create binding link between given buffer view node and its buffer with command buffer node 63277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlisvoid AddCommandBufferBindingBufferView(const layer_data *dev_data, GLOBAL_CB_NODE *cb_node, BUFFER_VIEW_STATE *view_state) { 63377b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // First add bindings for bufferView 63477b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis view_state->cb_bindings.insert(cb_node); 63577b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis cb_node->object_bindings.insert( 63677b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis {reinterpret_cast<uint64_t &>(view_state->buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}); 63777b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis auto buffer_node = getBufferNode(dev_data, view_state->create_info.buffer); 63877b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis // Add bindings for buffer within bufferView 63977b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis if (buffer_node) { 64077b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buffer_node); 64177b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis } 64277b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis} 64377b6217754b9c167b08cb151e70b41a948e36277Tobin Ehlis 644400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 645400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 64672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 647c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 648c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 64957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 6505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 651de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->command_buffer_bindings.erase(pCBNode->commandBuffer); 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 654c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 659400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 660400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 661400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 6625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6641cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis// For given MemObjInfo, report Obj & CB bindings. Clear any object bindings. 6651cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlisstatic bool ReportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 66683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 667de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t cmdBufRefCount = pMemObjInfo->command_buffer_bindings.size(); 668de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size_t objRefCount = pMemObjInfo->obj_bindings.size(); 6695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 670de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((pMemObjInfo->command_buffer_bindings.size()) != 0) { 67183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 67283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 67383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 67483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " references", 67583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 6765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 678de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (cmdBufRefCount > 0 && pMemObjInfo->command_buffer_bindings.size() > 0) { 679de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : pMemObjInfo->command_buffer_bindings) { 68058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 681de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 682414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 6835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 685de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->command_buffer_bindings.clear(); 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (objRefCount > 0 && pMemObjInfo->obj_bindings.size() > 0) { 689de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : pMemObjInfo->obj_bindings) { 690896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 691414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 692896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 6931cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Clear mem binding for bound objects 6941cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis switch (obj.type) { 6951cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 6961cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis auto image_node = getImageNode(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 6971cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis assert(image_node); // Any destroyed images should already be removed from bindings 698888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis image_node->mem = MEMORY_UNBOUND; 6991cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis break; 7001cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7011cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 7021cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis auto buff_node = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 7031cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis assert(buff_node); // Any destroyed buffers should already be removed from bindings 704888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis buff_node->mem = MEMORY_UNBOUND; 7051cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis break; 7061cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7071cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis default: 7081cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Should only have buffer or image objects bound to memory 7091cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis assert(0); 7101cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 7115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 713de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pMemObjInfo->obj_bindings.clear(); 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 718e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 71983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 72157fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 7225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 723ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO: Verify against Valid Use section 724ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Clear any CB bindings for completed CBs 725ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // TODO : Is there a better place to do this? 726ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 727ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller assert(pInfo->object != VK_NULL_HANDLE); 728ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // clear_cmd_buf_and_mem_references removes elements from 729de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis // pInfo->command_buffer_bindings -- this copy not needed in c++14, 730ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // and probably not needed in practice in c++11 731de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis auto bindings = pInfo->command_buffer_bindings; 732ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (auto cb : bindings) { 733ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 734ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller clear_cmd_buf_and_mem_references(dev_data, cb); 7355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 736ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 7371cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis // Now check for any remaining references to this mem obj and remove bindings 738de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->command_buffer_bindings.size() || pInfo->obj_bindings.size()) { 7391cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis skip_call |= ReportMemReferencesAndCleanUp(dev_data, pInfo); 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 741ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Delete mem obj info 742ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->memObjMap.erase(dev_data->memObjMap.find(mem)); 743ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } else if (VK_NULL_HANDLE != mem) { 744ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // The request is to free an invalid, non-zero handle 745ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 746ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 747ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem), __LINE__, 748ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller MEMTRACK_INVALID_MEM_OBJ, 749ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "MEM", "Request to delete memory object 0x%" 750ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller PRIxLEAST64 " not present in memory Object Map", 751ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller reinterpret_cast<uint64_t &>(mem)); 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 758c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 7600a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 76283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 763888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *pMemBinding = GetObjectMemBinding(dev_data, handle, type); 76494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 76557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = getMemObjInfo(dev_data, *pMemBinding); 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 76794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 769c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 771de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!pMemObjInfo->obj_bindings.erase({handle, type})) { 77283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 77358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 774414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 775414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 783888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis// For given mem object, verify that it is not null or UNBOUND, if it is, report error. Return skip value. 784888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisbool VerifyBoundMemoryIsValid(const layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, const char *api_name, 785888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *type_name) { 786888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool result = false; 787888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (VK_NULL_HANDLE == mem) { 788888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 789888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 790888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound. Memory should be bound by calling " 791888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "vkBind%sMemory().", 792888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle, type_name); 793888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } else if (MEMORY_UNBOUND == mem) { 794888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, handle, 795888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis __LINE__, MEMTRACK_OBJECT_NOT_BOUND, "MEM", 796888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "%s: Vk%s object 0x%" PRIxLEAST64 " used with no memory bound and previously bound memory was freed. " 797888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Memory must not be freed prior to this operation.", 798888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, type_name, handle); 799888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } 800888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis return result; 801888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis} 802888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis 803b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was ever bound to this image 804694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToImage(const layer_data *dev_data, const IMAGE_NODE *image_node, const char *api_name) { 805b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 806b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (0 == (static_cast<uint32_t>(image_node->createInfo.flags) & VK_IMAGE_CREATE_SPARSE_BINDING_BIT)) { 807888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, image_node->mem, reinterpret_cast<const uint64_t &>(image_node->image), 808888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, "Image"); 809b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 810b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 811b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 812b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 813b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski// Check to see if memory was bound to this buffer 814694002f8c182c84fc2b670f1cbb1a838119b1c14Tobin Ehlisbool ValidateMemoryIsBoundToBuffer(const layer_data *dev_data, const BUFFER_NODE *buffer_node, const char *api_name) { 815b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski bool result = false; 81612e3a5f6e672b103f705424595ffe3c4687492ceTobin Ehlis if (0 == (static_cast<uint32_t>(buffer_node->createInfo.flags) & VK_BUFFER_CREATE_SPARSE_BINDING_BIT)) { 817888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis result = VerifyBoundMemoryIsValid(dev_data, buffer_node->mem, reinterpret_cast<const uint64_t &>(buffer_node->buffer), 818888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis api_name, "Buffer"); 819b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 820b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski return result; 821b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski} 822b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 828888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlisstatic bool SetMemBinding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, VkDebugReportObjectTypeEXT type, 829888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis const char *apiName) { 83083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 83383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 83483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 836888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool sparse = false; 837888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *mem_binding = GetObjectMemBinding(dev_data, handle, type, &sparse); 838888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis assert(mem_binding); 839888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 840888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (mem_info) { 841888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis DEVICE_MEM_INFO *prev_binding = getMemObjInfo(dev_data, *mem_binding); 842888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis if (prev_binding) { 843888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 844888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 845888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 846888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 847888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 848888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle, reinterpret_cast<uint64_t &>(prev_binding->mem)); 849888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis } else if ((*mem_binding == MEMORY_UNBOUND) && (!sparse)) { 850888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call |= 851888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 852888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis reinterpret_cast<uint64_t &>(mem), __LINE__, MEMTRACK_REBIND_OBJECT, "MEM", 853888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 854888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis ") which was previous bound to memory that has since been freed. Memory bindings are immutable in " 855888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis "Vulkan so this attempt to bind to new memory is not allowed.", 856888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis apiName, reinterpret_cast<uint64_t &>(mem), handle); 8572e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 858888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis mem_info->obj_bindings.insert({handle, type}); 8592e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 8602e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 8612e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 8626d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto const image_node = getImageNode(dev_data, VkImage(handle)); 8636d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 8646d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo ici = image_node->createInfo; 8652e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 8662e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 870888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis *mem_binding = mem; 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 8820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 8830a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 8840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 88583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = VK_FALSE; 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 88883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = clear_object_binding(dev_data, handle, type); 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 890888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis VkDeviceMemory *pMemBinding = GetObjectMemBinding(dev_data, handle, type); 8912e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 89257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis DEVICE_MEM_INFO *pInfo = getMemObjInfo(dev_data, mem); 8932e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 894de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis pInfo->obj_bindings.insert({handle, type}); 8952e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 8962e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 902caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis// For handle of given object type, return memory binding 903caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlisstatic bool get_mem_for_type(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 904caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis bool skip_call = false; 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 906caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis switch (type) { 907caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 908caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getImageNode(dev_data, VkImage(handle))->mem; 909caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 910caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 911caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis *mem = getBufferNode(dev_data, VkBuffer(handle))->mem; 912caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis break; 913caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis default: 914caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis assert(0); 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 916caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis if (!*mem) { 917caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis skip_call = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 918caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis "MEM", "Trying to get mem binding for %s object 0x%" PRIxLEAST64 919caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis " but binding is NULL. Has memory been bound to this object?", 920caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis object_type_to_string(type), handle); 921caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis } 922caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis return skip_call; 923caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis} 924caf05e0db4959ae196ab34b024f352d9c0326870Tobin Ehlis 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 9260a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 92858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 93358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 93558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 93658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 93958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 94357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = (*ii).second.get(); 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 94558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 94657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)mem_info); 94758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 94857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(mem_info->mem)); 94958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 950c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 951de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size() + mem_info->obj_bindings.size()); 952de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (0 != mem_info->alloc_info.allocationSize) { 953de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&mem_info->alloc_info, "MEM(INFO): "); 95458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 95758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 963de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->obj_bindings.size()); 964de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->obj_bindings.size() > 0) { 965de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto obj : mem_info->obj_bindings) { 96658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 967414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 9735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 974de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->command_buffer_bindings.size()); 975de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->command_buffer_bindings.size() > 0) { 976de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis for (auto cb : mem_info->command_buffer_bindings) { 97758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 978414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9840a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 98572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 9865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 9895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 9905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 99372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 99472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 9955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 9975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 9995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 100172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 100272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 10035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 1005414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1007c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 10085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 1009c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 10105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 1011414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 10125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 10175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 10185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 10205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 10215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 10225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 10245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 10255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 10275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 10285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 10325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 10335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 10345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 10355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 10365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 10375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 10385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 10395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 10405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 10415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 10425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 10435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 10445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 10455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 10465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 10475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 10485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 10555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 10565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 10575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 10585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 10615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 10625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 10635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 10645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 10655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 10725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 10735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 10745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 10755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 10765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 10775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 10785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 10795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 10805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 10815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 10845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 10875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 10905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 10925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 10935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 10945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 10955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 10965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 10975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 10985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 10995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 11005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 11025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 11035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 11085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 11625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 11635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 11675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 11795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 11805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 11815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 11825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 11835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 11855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 11865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 11985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 11995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 12035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 12045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 12055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 12065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 12075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 12085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 12095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 12105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 12115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 12125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 12135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 12145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 12155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 12165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12409ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 12469ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 12479ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 12499ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 12509ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 12529ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 12539ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 12559ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 12569ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12579ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 12599ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 12609ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12619ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 12639ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 12649ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 12679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 12689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 12699ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 12719ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 12739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 12749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 12759ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 12769ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 12779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 12789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 12839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 12849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 12869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 12879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 12889ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 12909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 12919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 12939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 12949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 12999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 13009ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 13019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 13029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 13039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 13049ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 13059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 130637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 130737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 130837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 130937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 131037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 131137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 131237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 131337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 131437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 13155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 13165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 13175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 13185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13217c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 132237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 13237c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13247c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 132737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 132837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 132937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 133037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 133137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13387c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 13397c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 134037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 13417c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13427c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13437c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 13447c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 13457c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 13467c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 13477c755c8aca6857046df9516d8336416165969cb9Chris Forbes 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 13507c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 13537c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 13567c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 135837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 135937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 136037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 136137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 136237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 136337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 136437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 136537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 136637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 13675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 136837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 136937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 13725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 137437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 13785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 138437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 14125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 14235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 14245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1425cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1426cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1427cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1428cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1429cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1430cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1431cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1432cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1433cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 14395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 14405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1443c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1444c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1445c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1446c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1447c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1448c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1449c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1450c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1451c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1452c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1453c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1454c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1455c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1456c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 14615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 14635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1464b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1465fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1469031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1470031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1471031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1472031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1473031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1474031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1475031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1476031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1477031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1478031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1479031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1480031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1481031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1482031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 14855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 14875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 14885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 14895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 14905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 14915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 14925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 14935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 14945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1499edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 15003a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> *out, 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1502b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1504031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 15275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 15285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 15295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 15325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1542b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1543fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 15443a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes (*out)[std::make_pair(location + offset, component)] = v; 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15513a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::map<location_t, interface_var> collect_interface_by_location( 15523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes shader_module const *src, spirv_inst_iter entrypoint, 15533a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes spv::StorageClass sinterface, bool is_array_of_verts) { 15543a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1559b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1582b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1583b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1584b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1585b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 159181264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 15925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1596c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16023a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::map<location_t, interface_var> out; 16033a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16091d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1616b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 16215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 16275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 16285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 16297c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 16305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 16315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1635b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1636fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 16413a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes collect_interface_block_members(src, &out, blocks, is_array_of_verts, id, type, is_patch); 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16453a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16463a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16493a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<uint32_t, interface_var>> collect_interface_by_input_attachment_index( 16503a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 16513a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 16523a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16533a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<uint32_t, interface_var>> out; 1654745d49409296f060402b57950384caadb636a2b2Chris Forbes 1655745d49409296f060402b57950384caadb636a2b2Chris Forbes for (auto insn : *src) { 1656745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.opcode() == spv::OpDecorate) { 1657745d49409296f060402b57950384caadb636a2b2Chris Forbes if (insn.word(2) == spv::DecorationInputAttachmentIndex) { 1658745d49409296f060402b57950384caadb636a2b2Chris Forbes auto attachment_index = insn.word(3); 1659745d49409296f060402b57950384caadb636a2b2Chris Forbes auto id = insn.word(1); 1660745d49409296f060402b57950384caadb636a2b2Chris Forbes 1661745d49409296f060402b57950384caadb636a2b2Chris Forbes if (accessible_ids.count(id)) { 1662745d49409296f060402b57950384caadb636a2b2Chris Forbes auto def = src->get_def(id); 1663745d49409296f060402b57950384caadb636a2b2Chris Forbes assert(def != src->end()); 1664745d49409296f060402b57950384caadb636a2b2Chris Forbes 1665745d49409296f060402b57950384caadb636a2b2Chris Forbes if (def.opcode() == spv::OpVariable && insn.word(3) == spv::StorageClassUniformConstant) { 1666e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes auto num_locations = get_locations_consumed_by_type(src, def.word(1), false); 1667e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes for (unsigned int offset = 0; offset < num_locations; offset++) { 1668e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes interface_var v; 1669e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.id = id; 1670e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.type_id = def.word(1); 1671e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.offset = offset; 1672e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_patch = false; 1673e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes v.is_block_member = false; 1674e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes out.emplace_back(attachment_index + offset, v); 1675e0cc9b3441a24e4fbd2b4e0a9d163dab2140264aChris Forbes } 1676745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1677745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1678745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1679745d49409296f060402b57950384caadb636a2b2Chris Forbes } 1680745d49409296f060402b57950384caadb636a2b2Chris Forbes } 16813a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 16823a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 1683745d49409296f060402b57950384caadb636a2b2Chris Forbes} 1684745d49409296f060402b57950384caadb636a2b2Chris Forbes 16853a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::vector<std::pair<descriptor_slot_t, interface_var>> collect_interface_by_descriptor_slot( 16863a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes debug_report_data *report_data, shader_module const *src, 16873a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> const &accessible_ids) { 16885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 16945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 16965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 16975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 16995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 17025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 17035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17073a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::vector<std::pair<descriptor_slot_t, interface_var>> out; 17083a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 17115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 17125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 17145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 17175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 17195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 17205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1721b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1722b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1723fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 1724cefd4dd8e03c5dae11a05d04a03cb856190358e0Chris Forbes out.emplace_back(std::make_pair(set, binding), v); 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17273a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 17283a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return out; 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1731edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1732031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1734031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 17355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17373a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, producer_stage->arrayed_output); 17383a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, consumer_stage->arrayed_input); 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1751edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1752080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1753031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1754031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1759edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1761031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1762031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1767fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1768fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1769fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1770fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 17710f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1772fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1773fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 177437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1775edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 17779ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 17789ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 17799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17830f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1784edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 17850f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1786f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 17870f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 17880f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 17890f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 17900f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 17910f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 182431c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 182531c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 182631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 182731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1830f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 18425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 184631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 184731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 184831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 184931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1852f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 1880f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes case spv::OpTypeImage: 1881f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes return get_fundamental_type(src, insn.word(2)); 1882f95c35481cba95e16f9e70a62df61b49e2085076Chris Forbes 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 18855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1893edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1904edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1917edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19213a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto inputs = collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, false); 19225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1926c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1927c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1928c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1929c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1930c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1931c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 19325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 19355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 19361730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes bool used = false; 19375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 19405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 19441730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes if (!used && log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1945080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19491730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = false; 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1952edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 19555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 19615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 19635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1964edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 19655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 19665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 19679ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 19689ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 19741730e0dd28b3abc660b4e4704cf6d414f7fd4ad6Chris Forbes used = true; 19755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1982edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 19838da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis spirv_inst_iter entrypoint, VkRenderPassCreateInfo const *rpci, 19848da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis uint32_t subpass_index) { 1985025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 19868da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis auto subpass = rpci->pSubpasses[subpass_index]; 19878da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis for (auto i = 0u; i < subpass.colorAttachmentCount; ++i) { 1988d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis uint32_t attachment = subpass.pColorAttachments[i].attachment; 1989d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (attachment == VK_ATTACHMENT_UNUSED) 1990d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis continue; 1991d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis if (rpci->pAttachments[attachment].format != VK_FORMAT_UNDEFINED) { 1992d9da90d92748c37962766868f8b0354637672c2aTobin Ehlis color_attachments[i] = rpci->pAttachments[attachment].format; 1993025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1994025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1995025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 19965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 19995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20003a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto outputs = collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, false); 20015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2002025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 2003025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 20045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2005025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 2006025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 2007025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 2008025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 2009025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 20105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2011025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 2012edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 20135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 2014025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2017025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 2018025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 2019edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2020025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2023025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 20245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 2025025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 2026025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 20275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 20295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 2030edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 20315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 2032025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 2033025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 2034025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 20355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 20365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 2040025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 2041025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 20425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 20465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 20495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 20505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 20515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 20525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 20535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 20545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 20555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 20565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 20573a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbesstatic std::unordered_set<uint32_t> mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint) { 20583a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes std::unordered_set<uint32_t> ids; 20595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 20605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 20615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 20635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 206981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 20775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 20805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 20815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 20965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 20975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 20985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 20995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 21005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 21045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 21055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 21075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 21165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 21175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 21195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 21355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 21435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 2149c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 21505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 21515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 2155c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 21565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 21575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21643a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes 21653a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes return ids; 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2168edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 2169416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 21775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 21795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 21805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 21815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 21825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 21835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 2189416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis for (auto const &range : *push_constant_ranges) { 21905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 21915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 2194edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2195080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 21965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 21975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 21995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 2208edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2209080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2223edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 2224416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis std::vector<VkPushConstantRange> const *push_constant_ranges, shader_module const *src, 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 22265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 22275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 22305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 2231416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_block_against_pipeline(report_data, push_constant_ranges, src, 2232416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis src->get_def(def_insn.word(1)), stage); 22335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2239fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 2240fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 22414a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 224437083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2246416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis if (slot.first >= pipelineLayout->set_layouts.size()) 224737083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2249416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis return pipelineLayout->set_layouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2261e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 2264e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2266e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 2270e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 2271e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 22723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 22733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 22743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 2275414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2277e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 228116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 2282ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 2283ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 2284ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2286ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 228916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 229016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 229116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 229216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 229316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 2294fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes return it->second.get(); 229516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 229616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 229704861caca7eb93a5241b164e8480bb93c826902cTobin Ehlisstatic FRAMEBUFFER_NODE *getFramebuffer(const layer_data *my_data, VkFramebuffer framebuffer) { 2298f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 2299f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 2300f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 2301f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 230204861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis return it->second.get(); 2303f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 2304f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 2305e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehliscvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 230611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 230711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 230811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 230911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 231011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 231111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 231211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 23134a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 23144a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 23154a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 23164a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 23174a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 23184a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 23194a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 23204a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2321e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2322e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 23235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 23245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 23255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2326e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 23275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2329e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 23305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2333e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 23349c4006684a13db43f0dbc8d0015a9ef34872ca09Chris Forbes bool result = false; 2335ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2336ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2337ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 23383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 23403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 234145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 234245824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 23433d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 23453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23463d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 23473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 23493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 235045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 235145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 23523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 23543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 235545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 235645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 23573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 23593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 23613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23623d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 23633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 23653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 23663d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 23675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 23683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 23695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 23705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 23735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 23745ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski// If both AttachmentReference arrays have requested index, check their corresponding AttachmentDescriptions 23755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 23765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 23775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 23785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 23795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 23805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 2381e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis // Check potential NULL cases first to avoid nullptr issues later 2382e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pPrimary == nullptr) { 2383e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis if (pSecondary == nullptr) { 2384e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return true; 2385e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 2386e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2387e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } else if (pSecondary == nullptr) { 2388e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis return false; 2389e62f2e46eeffde494c0d734964b389c09dec9d64Tobin Ehlis } 23905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 239106e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 239206e963555b0df747c98c43816c16647349d21001Mark Young return true; 23935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 239406e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 239506e963555b0df747c98c43816c16647349d21001Mark Young return true; 23965ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else { // Format and sample count must match 23975ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) && (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 23985ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return true; 23995ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } else if ((pPrimary[index].attachment == VK_ATTACHMENT_UNUSED) || (pSecondary[index].attachment == VK_ATTACHMENT_UNUSED)) { 24005ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski return false; 24015ca3c071afc98f9144f489b74aa3affaa93633b0Mark Lobodzinski } 24025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 24035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 24045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 24055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 24065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 24075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 24095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2411a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// TODO : Scrub verify_renderpass_compatibility() and validateRenderPassCompatibility() and unify them and/or share code 24128da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis// For given primary RenderPass object and secondry RenderPassCreateInfo, verify that they're compatible 2413a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool verify_renderpass_compatibility(const layer_data *my_data, const VkRenderPassCreateInfo *primaryRPCI, 24148da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis const VkRenderPassCreateInfo *secondaryRPCI, string &errorMsg) { 24155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2416c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 24185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 24195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 24235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 24245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 24255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 24265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 24275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 24285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 24295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 24305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 24315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2432c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 24345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 24375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 24385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 24395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2440c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 24425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2446fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2447fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2448fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2449fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2450fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2451c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2452fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2453fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2454fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2455fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2456fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 24575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 24585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 24595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 24605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 24615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 24625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 24635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2464c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 24655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 24665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 24715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 24725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2474397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2475397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2476397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 247769b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis PIPELINE_LAYOUT_NODE const *pipeline_layout, const uint32_t layoutIndex, 247869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis string &errorMsg) { 2479416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto num_sets = pipeline_layout->set_layouts.size(); 24809b5d124aff50234cb0450e1b805baef577c90d83Tobin Ehlis if (layoutIndex >= num_sets) { 2481c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 248269b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorStr << "VkPipelineLayout (" << pipeline_layout->layout << ") only contains " << num_sets 248369b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << " setLayouts corresponding to sets 0-" << num_sets - 1 << ", but you're attempting to bind set to index " 248469b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis << layoutIndex; 24855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 24865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 24875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2488416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis auto layout_node = pipeline_layout->set_layouts[layoutIndex]; 2489397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 24905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 24915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2493edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 24955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 24975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 24985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 24995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 25005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2501edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 25025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 25035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 25045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 25055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 25065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 25075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 25085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2509e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 25105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 25165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 25175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2518edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 25191b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 25205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 25215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25221b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 25231b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 25247b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 25257b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 25265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 25277b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 25287b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 25297b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 25307b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 25317b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 25327b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 25337b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 25345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 25375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 25385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 25395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 25405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 25415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 25425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 25435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 25445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 25455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 25465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 25515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 25525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 255567d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER || 255667d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 255935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 256035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 256135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 256235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 256335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 256435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 256535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 256635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 256735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 256835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 25695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 25725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 25735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 25745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 25755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 25765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 25785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 25795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 25815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 25825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 25835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 25845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 25855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 25865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 25875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 258967d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE || 259067d9e049b7eb6a440707031b8eb7ddd21061e1abChris Forbes descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 25915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 25925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 25935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 25975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 25985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 25995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 26005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 26015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26044110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2605a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 26064110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2607080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2608a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2609a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2610a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2611a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2612a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2613a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2614a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2615a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2616a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2617a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 261869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 261969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2621a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2622a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2623a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2624a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2625a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2626a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2627a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2628a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2629a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2630a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2631a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2632a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2633a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2634a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2635a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2636a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2637a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2638a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 26394110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2640a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2641a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2642a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 26434110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2644a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2645a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2646a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 26474110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2648a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2649a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2650a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 26514110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2652a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2653a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2654a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2655a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 26564110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2657a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2658a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2659a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2660a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 26614110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2662a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2663a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2664a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 26654110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2666a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2667a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2668a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 26694110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2670a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2671a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2672a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2673a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 26744110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2675a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2676a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2677a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2678a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 26794110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2680a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2681a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2682a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2683a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 26844110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2685a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2686a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2687a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2688a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 26894110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2690a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2691a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2692a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 26934110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2694a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2695a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2696a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 26974110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2698a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2699a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2700a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 27014110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2702a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2703a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2704a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 27054110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2706a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2707a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2708a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 27094110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2710a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2711a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2712a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 27134110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2714a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2715a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2716a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 27174110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2718a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2719a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2720a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 27214110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2722a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2723a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2724a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2725a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 27264110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2727a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2728a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2729a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 27304110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2731a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2732a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2733a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2734a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 27354110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2736a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2737a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2738a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2739a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 27404110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2741a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2742a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2743a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 27444110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2745a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2746a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2747a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2748e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2749a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2750a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2751a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2752a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2753a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2754a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2755a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2756a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2757b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2758b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbesstatic uint32_t descriptor_type_to_reqs(shader_module const *module, uint32_t type_id) { 27592aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto type = module->get_def(type_id); 27602aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 27612aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes while (true) { 27622aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (type.opcode()) { 27632aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeArray: 27642aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeSampledImage: 27652aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(2)); 27662aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 27672aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypePointer: 27682aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes type = module->get_def(type.word(3)); 27692aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes break; 27702aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::OpTypeImage: { 27712aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto dim = type.word(3); 27722aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto arrayed = type.word(5); 27732aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes auto msaa = type.word(6); 27742aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes 27752aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes switch (dim) { 27762aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim1D: 2777488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_1D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_1D; 27782aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim2D: 27792aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return (msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE) | 2780488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes (arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_2D_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_2D); 27812aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::Dim3D: 27822aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return DESCRIPTOR_REQ_VIEW_TYPE_3D; 27832aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes case spv::DimCube: 2784488514f7ca0a92f1d493e5da62ab697e65731854Chris Forbes return arrayed ? DESCRIPTOR_REQ_VIEW_TYPE_CUBE_ARRAY : DESCRIPTOR_REQ_VIEW_TYPE_CUBE; 278528db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes case spv::DimSubpassData: 278628db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes return msaa ? DESCRIPTOR_REQ_MULTI_SAMPLE : DESCRIPTOR_REQ_SINGLE_SAMPLE; 278728db3859aeeca6ab2fcbe51e016c2b785d158edcChris Forbes default: // buffer, etc. 27882aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 27892aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27902aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27912aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes default: 27922aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes return 0; 27932aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 27942aa6e0c0e34095c0c84699f98172d05750a9c587Chris Forbes } 2795b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes} 2796b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2797b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes 2798ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2799ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2800ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2801ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2802ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 280369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2804ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2805ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2806e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 280769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 280869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 280978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 281078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 281178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 281278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2813557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2814080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 281578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 281678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 28170cfa9c3a1747749777581684536218f83c3977a9Chris Forbes return false; // no point continuing beyond here, any analysis is just going to be garbage. 281878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 281978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 282078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 282178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2822557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 282378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 282478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 28253a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto accessible_ids = mark_accessible_ids(module, entrypoint); 282678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 282778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 28283a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto descriptor_uses = collect_interface_by_descriptor_slot(report_data, module, accessible_ids); 282978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 28302e0eca3d6fad72a29ae072e3895e29a2d2d66476Tobin Ehlis auto pipelineLayout = pipeline->pipeline_layout; 2831ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 28320cfa9c3a1747749777581684536218f83c3977a9Chris Forbes pass &= validate_specialization_offsets(report_data, pStage); 2833416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis pass &= validate_push_constant_usage(report_data, &pipelineLayout.push_constant_ranges, module, accessible_ids, pStage->stage); 283478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 283578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 283678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 283778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 2838b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes auto & reqs = pipeline->active_slots[use.first.first][use.first.second]; 2839b2a61f3cd17c68887759817059fa1872f1e1464aChris Forbes reqs = descriptor_req(reqs | descriptor_type_to_reqs(module, use.second.type_id)); 284078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2841fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 2842c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis const auto &binding = get_descriptor_binding(&pipelineLayout, use.first); 284378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 284478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 284578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2846557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2847080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 284878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 284978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2850e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 285178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 285278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2853557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 285478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 285578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 285678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 285778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2858fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 285978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2860e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 286178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2862edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2863fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2864557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2865fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2866fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2867fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2868fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 286978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2870e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 287178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 287278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2873557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2874fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 287578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 287678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2877fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 287978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 288078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 288178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 288278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2883c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes /* validate use of input attachments against subpass structure */ 2884c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (pStage->stage == VK_SHADER_STAGE_FRAGMENT_BIT) { 28853a1adf43eb19fc8e32b5cf64eab56d120d6e00e8Chris Forbes auto input_attachment_uses = collect_interface_by_input_attachment_index(report_data, module, accessible_ids); 2886c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2887c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto rpci = pipeline->render_pass_ci.ptr(); 2888c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto subpass = pipeline->graphicsPipelineCI.subpass; 2889c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2890c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes for (auto use : input_attachment_uses) { 2891c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto input_attachments = rpci->pSubpasses[subpass].pInputAttachments; 2892c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes auto index = (input_attachments && use.first < rpci->pSubpasses[subpass].inputAttachmentCount) ? 2893c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes input_attachments[use.first].attachment : VK_ATTACHMENT_UNUSED; 2894c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 2895c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (index == VK_ATTACHMENT_UNUSED) { 2896c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2897c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes SHADER_CHECKER_MISSING_INPUT_ATTACHMENT, "SC", 2898c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes "Shader consumes input attachment index %d but not provided in subpass", 2899c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes use.first)) { 2900c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes pass = false; 2901c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2902c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2903eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes else if (get_format_type(rpci->pAttachments[index].format) != 2904eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes get_fundamental_type(module, use.second.type_id)) { 2905eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2906eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes SHADER_CHECKER_INPUT_ATTACHMENT_TYPE_MISMATCH, "SC", 2907eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes "Subpass input attachment %u format of %s does not match type used in shader `%s`", 2908eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes use.first, string_VkFormat(rpci->pAttachments[index].format), 2909eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes describe_type(module, use.second.type_id).c_str())) { 2910eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes pass = false; 2911eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2912eeb9f6a27f1acc11e54080fb3bcda7b513b5c89fChris Forbes } 2913c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2914c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes } 2915c024994b70f304ed7c6a472b90803c9911be09ddChris Forbes 291678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 291778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 291878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 291978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2920a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2921a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2922e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 292369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 292469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 29256660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 29265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 29275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 29285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 29305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 29315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 29335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2934e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 29355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 29376660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 293878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2939e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 294069f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 294169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 29425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2944d5365427feb4a6c16371ecb651afa37b89dabd96Chris Forbes // if the shader stages are no good individually, cross-stage validation is pointless. 2945b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes if (!pass) 2946b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes return false; 2947b7476f4c4998ae20e579bd2d134667b71acdbf91Chris Forbes 29485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 29495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2951e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 29525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2955e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 29605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 29625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 29635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2969e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2970031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2971031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 29745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29778da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis if (shaders[fragment_stage]) { 2978e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 29798da1edac0fbed13831b2f458f27c51e64d6210ffTobin Ehlis pPipeline->render_pass_ci.ptr(), pCreateInfo->subpass); 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 29835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2985e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 298669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 29876660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 298803857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 298903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 299003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 299103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2992e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 299369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 299403857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 29955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2996a682b1c533d9a492243b363c6585c4f03bcd87aaTobin Ehliscvdescriptorset::DescriptorSet *getSetNode(const layer_data *my_data, VkDescriptorSet set) { 2997104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis auto set_it = my_data->setMap.find(set); 2998104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis if (set_it == my_data->setMap.end()) { 29995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 30005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3001104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return set_it->second; 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30037a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 30047a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 30057a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 30067a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 30077a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 30087a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 30097a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 3010e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 30117a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 30121abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 30131abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis &activeSetBindingsPairs, 30141abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis const char *function) { 3015e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3016a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 3017dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 3018cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 3019dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 3020397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 3021cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 3022397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 3023cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3024cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3025e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski "DS 0x%" PRIxLEAST64 " encountered the following validation error at %s() time: %s", 3026e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski reinterpret_cast<const uint64_t &>(set), function, err_str.c_str()); 3027cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3028dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3033eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 3034ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 3035ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 3036ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 3037eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 3038eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3039eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 3040eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3041eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3042b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbesstatic void list_bits(std::ostream& s, uint32_t bits) { 3043b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes for (int i = 0; i < 32 && bits; i++) { 3044b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits & (1 << i)) { 3045b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << i; 3046b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes bits &= ~(1 << i); 3047b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (bits) { 3048b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes s << ","; 3049b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3050b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3051b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes } 3052b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes} 3053b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 3054eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 305529d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 305629d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 305729d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 305829d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 3059eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 306029d196e071b2dc1db47702085469396f2b956820Chris Forbes 306129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 306229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 306329d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 3064312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis auto vertex_binding = pPipeline->vertexBindingDescriptions[i].binding; 3065312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis if ((pCB->currentDrawData.buffers.size() < (vertex_binding + 1)) || 3066312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis (pCB->currentDrawData.buffers[vertex_binding] == VK_NULL_HANDLE)) { 3067312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis skip_call |= log_msg( 3068312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3069312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 3070312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "The Pipeline State Object (0x%" PRIxLEAST64 ") expects that this Command Buffer's vertex binding Index %u " 3071312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "should be set via vkCmdBindVertexBuffers. This is because VkVertexInputBindingDescription struct " 3072312129ec52e6249aa453e27e6be17a8dab1e98b8Tobin Ehlis "at index " PRINTF_SIZE_T_SPECIFIER " of pVertexBindingDescriptions has a binding value of %u.", 30735c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)state.pipeline_node->pipeline, vertex_binding, i, vertex_binding); 307429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 307529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 307629d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 307729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 307829d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 30795c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 30805c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 30815c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 30825c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline_node->pipeline); 308329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 308429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 308529d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 308629d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 308729d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 308829d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 308929d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 309029d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 309129d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 3092b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 309329d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 3094b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredViewportsMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->viewportCount) - 1; 3095b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingViewportMask = ~pCB->viewportMask & requiredViewportsMask; 3096b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingViewportMask) { 3097b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3098b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic viewport(s) "; 3099b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingViewportMask); 3100b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetViewport()."; 3101b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3102b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3103b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 310429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 310529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3106b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes 310729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 3108b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto requiredScissorMask = (1 << pPipeline->graphicsPipelineCI.pViewportState->scissorCount) - 1; 3109b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes auto missingScissorMask = ~pCB->scissorMask & requiredScissorMask; 3110b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes if (missingScissorMask) { 3111b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes std::stringstream ss; 3112b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << "Dynamic scissor(s) "; 3113b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes list_bits(ss, missingScissorMask); 3114b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes ss << " are used by PSO, but were not provided via calls to vkCmdSetScissor()."; 3115b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 3116b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 3117b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes "%s", ss.str().c_str()); 311829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 311929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 312029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 312129d196e071b2dc1db47702085469396f2b956820Chris Forbes 312229d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 312329d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 312429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 312529d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 312629d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 312729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 3128fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const render_pass_info = pCB->activeRenderPass->createInfo.ptr(); 312929d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 313029d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 313129d196e071b2dc1db47702085469396f2b956820Chris Forbes 313229d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 313329d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 313429d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 313529d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3136eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3137ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 3138eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 3139414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 3140eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 3141eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 3142ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 314329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3144eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 314576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes unsigned subpass_num_samples = 0; 31460a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 314729d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 314876957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pColorAttachments[i].attachment; 314976957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (attachment != VK_ATTACHMENT_UNUSED) 315076957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 315129d196e071b2dc1db47702085469396f2b956820Chris Forbes } 31520a7ed0466d3d3c6c71be07d66c200482d9a9d073Chris Forbes 315376957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes if (subpass_desc->pDepthStencilAttachment && 315476957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 315576957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes auto attachment = subpass_desc->pDepthStencilAttachment->attachment; 315676957dd352738b7ceec82c38be8b1b1347a90040Chris Forbes subpass_num_samples |= (unsigned)render_pass_info->pAttachments[attachment].samples; 315729d196e071b2dc1db47702085469396f2b956820Chris Forbes } 3158eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 31590dc3fd4e57b8531638781daa01a2fb5d1048a6fbJamie Madill if (subpass_num_samples && static_cast<unsigned>(pso_num_samples) != subpass_num_samples) { 316029d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 3161eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3162ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 3163414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 3164414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 3165ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 3166ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 3167eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 316829d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 316929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 317029d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 317129d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 317229d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 3173eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3174eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 3175528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // Verify that PSO creation renderPass is compatible with active renderPass 3176528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis if (pCB->activeRenderPass) { 3177528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis std::string err_string; 3178a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != pPipeline->graphicsPipelineCI.renderPass) && 3179fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(my_data, pCB->activeRenderPass->createInfo.ptr(), pPipeline->render_pass_ci.ptr(), 3180528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis err_string)) { 3181528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis // renderPass that PSO was created with must be compatible with active renderPass that PSO is being used with 3182528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis skip_call |= 3183528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3184528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3185528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "At Draw time the active render pass (0x%" PRIxLEAST64 ") is incompatible w/ gfx pipeline " 3186528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis "(0x%" PRIxLEAST64 ") that was created w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 3187528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->activeRenderPass->renderPass), reinterpret_cast<uint64_t &>(pPipeline), 3188528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis reinterpret_cast<const uint64_t &>(pPipeline->graphicsPipelineCI.renderPass), err_string.c_str()); 3189528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 3190c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes 3191c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes if (pPipeline->graphicsPipelineCI.subpass != pCB->activeSubpass) { 3192c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes skip_call |= 3193c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 3194c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes reinterpret_cast<uint64_t const &>(pPipeline->pipeline), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 3195c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes "Pipeline was built for subpass %u but used in subpass %u", pPipeline->graphicsPipelineCI.subpass, 3196c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes pCB->activeSubpass); 3197c307df2953e6b023531a6ef7fd11e3ee2f2c58b0Chris Forbes } 3198528f623d935b0ab102a2f9c1c82787a8810ca360Tobin Ehlis } 319929d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 320029d196e071b2dc1db47702085469396f2b956820Chris Forbes 3201eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 3202eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 3203eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 32045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 3205aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlisstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *cb_node, const bool indexedDraw, 3206e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski const VkPipelineBindPoint bindPoint, const char *function) { 3207e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 3208aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis auto const &state = cb_node->lastBound[bindPoint]; 32095c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipe = state.pipeline_node; 321022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 321122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 321222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 321322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 321422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 321522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 321622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 321722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 321822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 32193d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 32207a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3221aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result = validate_draw_state_flags(my_data, cb_node, pPipe, indexedDraw); 32227a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 32235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 322469b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (VK_NULL_HANDLE != state.pipeline_layout.layout) { 322522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 322669b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = pPipe->pipeline_layout; 3227169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 322822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 32291abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis vector<std::tuple<cvdescriptorset::DescriptorSet *, std::map<uint32_t, descriptor_req>, std::vector<uint32_t> const *>> 32301abb984ebd667af808ed308ddf79cbaeaed129caTobin Ehlis activeSetBindingsPairs; 3231dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 323222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 323322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 323422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 323522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 323622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 3237414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 323822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 323969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], &pipeline_layout, setIndex, 324069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString)) { 324169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis // Set is bound but not compatible w/ overlapping pipeline_layout from PSO 324271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 324322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 324422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 324522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 3246414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 3247414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 324869b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis reinterpret_cast<uint64_t &>(setHandle), setIndex, reinterpret_cast<uint64_t &>(pipeline_layout.layout), 324969b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis errorString.c_str()); 325022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 325122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 325271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 3253aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Gather active bindings 3254aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis std::unordered_set<uint32_t> bindings; 3255aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : setBindingPair.second) { 3256aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis bindings.insert(binding.first); 3257aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis } 3258aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis // Bind this set and its active descriptor resources to the command buffer 3259aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis pSet->BindCommandBuffer(cb_node, bindings); 326022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 3261aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, &state.dynamicOffsets[setIndex])); 326222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 326322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 3264397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 3265aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis for (auto binding : bindings) { 3266aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 326722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 326822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 3269397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 3270414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 327122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 3272397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 3273fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 32745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 327722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 327822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 3279aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, cb_node, activeSetBindingsPairs, function); 328022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 3281eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 3282eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 328329d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 3284aa21bc3b3c5c7adfeb488fc80bdcb339d63615b8Tobin Ehlis result |= validatePipelineDrawtimeState(my_data, state, cb_node, pPipe); 3285eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3289a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 3290a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 3291a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 3292a27508babf63d50aea75883a3702979193c23683Mark Young 3293a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 3294f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if ((VK_FALSE == my_data->enabled_features.wideLines) && (1.0f != lineWidth)) { 3295a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 3296a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 3297a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 3298a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 3299a27508babf63d50aea75883a3702979193c23683Mark Young } else { 3300a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 3301a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 3302a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 3303a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 3304a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 3305a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 3306a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 3307a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 3308a27508babf63d50aea75883a3702979193c23683Mark Young } 3309a27508babf63d50aea75883a3702979193c23683Mark Young } 3310a27508babf63d50aea75883a3702979193c23683Mark Young 3311a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 3312a27508babf63d50aea75883a3702979193c23683Mark Young} 3313a27508babf63d50aea75883a3702979193c23683Mark Young 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 3315e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 3316e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 331783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 33275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 332883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 332983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 333083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 33315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 33325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 333383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 33375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 33395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 334583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 334683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 334783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 33485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 3352f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.independentBlend) { 33533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 335426c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 3355c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 335606811df0256552cd7da9d7297672af377463fc4aMark Mueller // Quoting the spec: "If [the independent blend] feature is not enabled, the VkPipelineColorBlendAttachmentState 335706811df0256552cd7da9d7297672af377463fc4aMark Mueller // settings for all color attachments must be identical." VkPipelineColorBlendAttachmentState contains 335806811df0256552cd7da9d7297672af377463fc4aMark Mueller // only attachment state, so memcmp is best suited for the comparison 335906811df0256552cd7da9d7297672af377463fc4aMark Mueller if (memcmp(static_cast<const void *>(pAttachments), static_cast<const void *>(&pAttachments[i]), 336006811df0256552cd7da9d7297672af377463fc4aMark Mueller sizeof(pAttachments[0]))) { 336183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 336283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INDEPENDENT_BLEND, "DS", 336383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo: If independent blend feature not " 336483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "enabled, all elements of pAttachments must be identical"); 336506811df0256552cd7da9d7297672af377463fc4aMark Mueller break; 3366c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 33675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3370f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!my_data->enabled_features.logicOp && 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 337283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3379a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 338216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 3383fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (renderPass && pPipeline->graphicsPipelineCI.subpass >= renderPass->createInfo.subpassCount) { 338483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 338583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 338683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is out of range for this renderpass (0..%u)", 3387fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->createInfo.subpassCount - 1); 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3390f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->enabled_features, 339169f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 339283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = true; 33935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 339452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 339552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 339652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 339752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 339883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 339983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 340083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 340183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 340252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 340352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 340452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 340783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 34135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 341483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 341583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 341683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 34175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 342383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 342483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 342583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 34265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 34295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3430ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3431ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 343283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 343383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 343483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 343583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology for tessellation pipelines"); 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3437ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3438ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 344083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 344183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 344283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 344383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 344483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology is only valid for tessellation pipelines"); 34455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3446ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 344783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 344883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 344983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Invalid Pipeline CreateInfo State: " 345083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 345183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3452ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3453ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 345483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 345583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 345683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 345783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "topology used with patchControlPoints value %u." 345883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " patchControlPoints should be >0 and <=32.", 345983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 34605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3462a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3463a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3464a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 346583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 346683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3467a27508babf63d50aea75883a3702979193c23683Mark Young } 3468a27508babf63d50aea75883a3702979193c23683Mark Young } 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 34705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 347345824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 347583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 347683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 347783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "and scissors are dynamic PSO must include " 347883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 34795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 348183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 348283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 348383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 348483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 348583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3488e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3489e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 34905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 349383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 349483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 349583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 349683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 349783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 349883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetViewport().", 349983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 350583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 350683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 350783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 350883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 350983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdSetScissor().", 351083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35145dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes 35155dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // If rasterization is not disabled, and subpass uses a depth/stencil 35165dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes // attachment, pDepthStencilState must be a pointer to a valid structure 3517fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpass_desc = renderPass ? &renderPass->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass] : nullptr; 35185dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (subpass_desc && subpass_desc->pDepthStencilAttachment && 35195dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 35205dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes if (!pPipeline->graphicsPipelineCI.pDepthStencilState) { 35215dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, 35225dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 35235dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "Invalid Pipeline CreateInfo State: " 35245dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "pDepthStencilState is NULL when rasterization is enabled and subpass uses a " 35255dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes "depth/stencil attachment"); 35265dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 35275dcdd90e54199dfeb29938a3a03d998397c22664Chris Forbes } 35285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 352983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3536ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3537ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 35435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3545e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin EhlisDESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3546bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3547bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3550bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3553e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3554e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3558e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3581fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3583fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3586fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3589fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3592fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3593e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 359583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 35961d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3603e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 360683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 360783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 360883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 360983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 361183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 3612fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 361383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 3614fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3615fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3616fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3617fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 362083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 36215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 36234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 36244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 36254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 36264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 36294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 36304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 36314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 36324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 36354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 36384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 36394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 36414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 36444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 36454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 36474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 36484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 36494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 36504a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 36514a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 36524a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 36554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 36564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 36574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 36584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 36594a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 36614a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 36624a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 36634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 36644a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 36654a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 36664a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 36674a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 36684a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 36694a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 36705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 36734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 36744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 36754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 36764a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 36774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 36784a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 36804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 36834a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 36865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 36904a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 36914a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 36924a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 36934a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 36944a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 36954a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 36974a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37004a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto img_node = getImageNode(my_data, image); 37156d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!img_node) 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 37206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (sub_data->second.size() >= (img_node->createInfo.arrayLayers * img_node->createInfo.mipLevels + 1)) { 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 37245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 37255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 37285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 37355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 37365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 374708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 375008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 375108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 375208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 375308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 375708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 37585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 375908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 376008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 37667068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 37677068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 37687068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 376908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 37705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 377308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 377408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 377508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 377608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 377708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 377808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 378108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 378208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 37835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 378408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 378508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 378608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 378708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 379008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 379208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 379679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 379779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 379812d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto image = view_state->create_info.image; 379979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 38005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 38015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 3806915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // TODO: If ImageView was created with depth or stencil, transition both layouts as 3807915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // the aspectMask is ignored and both are used. Verify that the extra implicit layout 3808915963fbb05941d3d457f62d6ef61d066b7d73a9Mark Lobodzinski // is OK for descriptor set layout validation 3809038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski if (subRange.aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 381079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (vk_format_is_depth_and_stencil(view_state->create_info.format)) { 3811038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski sub.aspectMask |= (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT); 3812038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 3813038f931c1696f3e96aeec0e3786b5a47acf908e1Mark Lobodzinski } 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 38205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3821e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3823e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3824e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 38265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3829414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 38345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3835414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3841f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3842e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 38439dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 38449dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 38459dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 38469dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3853c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3854cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 38559dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3857f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 3865de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // TODO: validate flags 3866de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3867de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (auto ds : pPool->sets) { 3868de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis freeDescriptorSet(my_data, ds); 3869de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis } 3870de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->sets.clear(); 3871de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis // Reset available count for each type and available sets for this pool 3872de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 3873de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3875de7672b6b749c09c5991bd8038b3a35ef82a69dcTobin Ehlis pPool->availableSets = pPool->maxSets; 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 38795121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 38805121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 38815121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 388272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 388372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3884414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 38855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38875121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3892400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 39045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3907e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3909e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3910e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3911d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3912d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 39175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 39225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 39375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 39415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 39435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 39445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 39455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 39465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3950a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool addCmd(layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 395183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 3952a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(my_data, pCB->createInfo.commandPool); 3953a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (pPool) { 3954a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].queueFlags; 39555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 39565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 39575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 39585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 39595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 39605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 39655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 39665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 39685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 396983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 39775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 39785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 39845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 39875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 39905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 399383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 399783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 40055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 40065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 40077651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 401483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 40157651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 401683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 40185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 40195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 40205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 40215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 40225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 402383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 40245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40257e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For given object struct return a ptr of BASE_NODE type for its wrapping struct 40267e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin EhlisBASE_NODE *GetStateStructPtrFromObject(layer_data *dev_data, VK_OBJECT object_struct) { 40277e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_ptr = nullptr; 40287e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis switch (object_struct.type) { 40297e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 40307e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(object_struct.handle)); 40317e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40327e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40337e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 40347e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(object_struct.handle)); 40357e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40367e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40377e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 40387e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(object_struct.handle)); 40397e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40407e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40417e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 40427e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getPipeline(dev_data, reinterpret_cast<VkPipeline &>(object_struct.handle)); 4043bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 4044bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4045bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 40467e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(object_struct.handle)); 40477e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40487e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40497e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 40507e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(object_struct.handle)); 40517e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40527e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40537e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 40547e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getImageNode(dev_data, reinterpret_cast<VkImage &>(object_struct.handle)); 40557e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40567e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40577e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 40587e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(object_struct.handle)); 4059bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis break; 4060bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 40619822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 40627e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getEventNode(dev_data, reinterpret_cast<VkEvent &>(object_struct.handle)); 40639822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis break; 40649822fe9cda4c97bfa374f680fa90419e0f82580eTobin Ehlis } 40657e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 40667e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getPoolNode(dev_data, reinterpret_cast<VkDescriptorPool &>(object_struct.handle)); 4067ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis break; 4068ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 40697e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 40707e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(object_struct.handle)); 4071a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis break; 4072a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 40737e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 40747e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getFramebuffer(dev_data, reinterpret_cast<VkFramebuffer &>(object_struct.handle)); 4075a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4076a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 40777e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 40787e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getRenderPass(dev_data, reinterpret_cast<VkRenderPass &>(object_struct.handle)); 40797e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 40807e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 40817e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 40827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_ptr = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(object_struct.handle)); 408356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 408456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 4085bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis default: 40867e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis // TODO : Any other objects to be handled here? 40877e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis assert(0); 40887e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 4089bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 40907e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis return base_ptr; 40917e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 40927e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis 40937e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Tie the VK_OBJECT to the cmd buffer which includes: 40947e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add object_binding to cmd buffer 40957e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// Add cb_binding to object 40967e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void addCommandBufferBinding(std::unordered_set<GLOBAL_CB_NODE *> *cb_bindings, VK_OBJECT obj, GLOBAL_CB_NODE *cb_node) { 40977e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_bindings->insert(cb_node); 40987e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis cb_node->object_bindings.insert(obj); 40997e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis} 41007e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis// For a given object, if cb_node is in that objects cb_bindings, remove cb_node 41017e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlisstatic void removeCommandBufferBinding(layer_data *dev_data, VK_OBJECT const *object, GLOBAL_CB_NODE *cb_node) { 41027e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis BASE_NODE *base_obj = GetStateStructPtrFromObject(dev_data, *object); 41037e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis if (base_obj) 41047e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj->cb_bindings.erase(cb_node); 4105bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis} 41065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 41075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 4108400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 4109400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 41105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 4111b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 41125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 41135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 41145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 41155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 41165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 41175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 41185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 41195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 41205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 41215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 4122b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask = 0; 4123b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask = 0; 412493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 412572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 412672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 412772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 412893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 41295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 4130ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 4133e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis pCB->broken_bindings.clear(); 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 4136c7e6bc41aa9c6e5a677b138b9459b252cd3bedf2Mark Lobodzinski pCB->writeEventsBeforeWait.clear(); 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 41405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 4141abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 41425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 4147bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 4148bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 4149bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 4150bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 41527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 41537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 4154400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 4155b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 4156d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 415793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 4158bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis // Remove object bindings 4159bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis for (auto obj : pCB->object_bindings) { 4160bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis removeCommandBufferBinding(dev_data, &obj, pCB); 4161bf66bca5d96f2721897c5f3100da2df741da9addTobin Ehlis } 4162a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis pCB->object_bindings.clear(); 416393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 416493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 4165d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 4166d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) 4167b6fe8da9537ef985960fd1d32b83c952b422f00bTobin Ehlis fb_node->cb_bindings.erase(pCB); 416893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 416993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 41707003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 41715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 41735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 41745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 4177ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 4178ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 41791afd60fa23eaee2000e232efd5d05a64224a91dcTony Barbour pCB->status |= CBSTATUS_ALL; 41805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 41815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 41825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 41835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 41845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 4185ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 4186ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 41885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 41895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 41915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 41925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 41943d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 41955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 41975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 41985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 41995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 42005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 42015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 42035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 42045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 42065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 42075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 42095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 42105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 42115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 42145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 4218e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 421983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 42205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 42215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 42225c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 42245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 42255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 422683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 422783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 422883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 422983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 423083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis .c_str()); 42315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 423383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 42375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 42385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 42395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 4240414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 42415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 42425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 42435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 42445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4245414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 42465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 42485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 42495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4252e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 425383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 42545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 425583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 425783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= printPipeline(my_data, cb); 425883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 42595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 42625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 4263e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4264e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 42655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 42665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 4268414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 4269ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 42705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 42755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 4276e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 4277e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 42785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 42795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 42805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 42815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 42825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4288b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 4289d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 4290b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 429489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 429589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 42965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 43005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 43025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4311b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 431256a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 4313b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 4314b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4316b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 4317b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 4318b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 4319b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 4320825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski 4321b51f48f9e79665e20830097dd9c6434bac68de34Mark Lobodzinski instance_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE()); 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 432889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 43295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 43305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 43355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 43365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4337b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 43395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 43405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 43435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4350373469f006399d6b5204ee05db3b56beb168b36fMark Youngstatic void checkDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 43555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 4356c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = false; 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 4361c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_DISPLAY_SWAPCHAIN_EXTENSION_NAME) == 0) 4362c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_extensions.wsi_display_swapchain_enabled = true; 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4366838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski// Verify that queue family has been properly requested 43674b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbesbool ValidateRequestedQueueFamilyProperties(layer_data *instance_data, VkPhysicalDevice gpu, const VkDeviceCreateInfo *create_info) { 4368838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski bool skip_call = false; 43694b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes auto physical_device_state = getPhysicalDeviceState(instance_data, gpu); 4370838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // First check is app has actually requested queueFamilyProperties 43714b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!physical_device_state) { 43724b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4373838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_MUST_QUERY_COUNT, "DL", 4374838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid call to vkCreateDevice() w/o first calling vkEnumeratePhysicalDevices()."); 43754b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes } else if (QUERY_DETAILS != physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 4376838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // TODO: This is not called out as an invalid use in the spec so make more informative recommendation. 43774b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 4378838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, 4379838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "DL", "Call to vkCreateDevice() w/o first calling vkGetPhysicalDeviceQueueFamilyProperties()."); 4380838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else { 4381838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski // Check that the requested queue properties are valid 4382838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski for (uint32_t i = 0; i < create_info->queueCreateInfoCount; i++) { 4383838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski uint32_t requestedIndex = create_info->pQueueCreateInfos[i].queueFamilyIndex; 43844b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (instance_data->queue_family_properties.size() <= 4385838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski requestedIndex) { // requested index is out of bounds for this physical device 4386838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg( 43874b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 4388838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4389838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). Invalid queueFamilyIndex %u requested.", requestedIndex); 4390838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } else if (create_info->pQueueCreateInfos[i].queueCount > 43914b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes instance_data->queue_family_properties[requestedIndex]->queueCount) { 4392838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= 43934b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 4394838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 0, __LINE__, DEVLIMITS_INVALID_QUEUE_CREATE_REQUEST, "DL", 4395838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "Invalid queue create request in vkCreateDevice(). QueueFamilyIndex %u only has %u queues, but " 4396838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski "requested queueCount is %u.", 43974b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes requestedIndex, instance_data->queue_family_properties[requestedIndex]->queueCount, 4398838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski create_info->pQueueCreateInfos[i].queueCount); 4399838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4400838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4401838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski } 4402838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski return skip_call; 4403838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski} 4404838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski 4405f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski// Verify that features have been queried and that they are available 44063bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbesstatic bool ValidateRequestedFeatures(layer_data *dev_data, VkPhysicalDevice phys, const VkPhysicalDeviceFeatures *requested_features) { 4407f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4408f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 44093bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto phys_device_state = getPhysicalDeviceState(dev_data, phys); 44103bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes const VkBool32 *actual = reinterpret_cast<VkBool32 *>(&phys_device_state->features); 4411825ac70f99460ccb9494d34f93d8ee7ec303e5deMark Lobodzinski const VkBool32 *requested = reinterpret_cast<const VkBool32 *>(requested_features); 4412f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO : This is a nice, compact way to loop through struct, but a bad way to report issues 4413f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Need to provide the struct member name with the issue. To do that seems like we'll 4414f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // have to loop through each struct member which should be done w/ codegen to keep in synch. 4415f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t errors = 0; 4416f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski uint32_t total_bools = sizeof(VkPhysicalDeviceFeatures) / sizeof(VkBool32); 4417f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < total_bools; i++) { 4418f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (requested[i] > actual[i]) { 4419f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Add index to struct member name helper to be able to include a feature name 4420838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4421f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4422f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "DL", "While calling vkCreateDevice(), requesting feature #%u in VkPhysicalDeviceFeatures struct, " 4423f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "which is not available on this device.", 4424f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski i); 4425f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski errors++; 4426f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4427f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 44283bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes if (errors && (UNCALLED == phys_device_state->vkGetPhysicalDeviceFeaturesState)) { 4429f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // If user didn't request features, notify them that they should 4430f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // TODO: Verify this against the spec. I believe this is an invalid use of the API and should return an error 4431838e3917bc1a0479174dd753b5c28b8b2cf1954dMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4432cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_INVALID_FEATURE_REQUESTED, 4433cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "DL", "You requested features that are unavailable on this device. You should first query feature " 4434cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "availability by calling vkGetPhysicalDeviceFeatures()."); 4435f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 4436f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return skip_call; 4437f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 4438f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 443989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 444089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 444156a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 4442f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski bool skip_call = false; 4443f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 4444f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Check that any requested features are available 4445f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (pCreateInfo->pEnabledFeatures) { 44463bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes skip_call |= ValidateRequestedFeatures(my_instance_data, gpu, pCreateInfo->pEnabledFeatures); 4447f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 44484b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes skip_call |= ValidateRequestedQueueFamilyProperties(my_instance_data, gpu, pCreateInfo); 4449f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 44501d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller if (skip_call) { 44511d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller return VK_ERROR_VALIDATION_FAILED_EXT; 44521d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller } 44531d659b4113b77a95325df10d602a03f1e7abf8b7Mark Mueller 44545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 445956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 44685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 44695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 44745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4475c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis // Copy instance state into this device's layer_data struct 4476c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis my_device_data->instance_state = unique_ptr<INSTANCE_STATE>(new INSTANCE_STATE(*(my_instance_data->instance_state))); 447707a464bd7fec9583f346b8c4b8d43c88d2e9ffa4Chris Forbes my_device_data->instance_data = my_instance_data; 44785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 44795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 44805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 44816c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 44825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 4484373469f006399d6b5204ee05db3b56beb168b36fMark Young checkDeviceRegisterExtensions(pCreateInfo, *pDevice); 44855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 4486b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 44875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 44885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 4489b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 44905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 4491b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 44935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 4494f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes my_device_data->enabled_features = *pCreateInfo->pEnabledFeatures; 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4496f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes memset(&my_device_data->enabled_features, 0, sizeof(VkPhysicalDeviceFeatures)); 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4498b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 4499b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 4500b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 45015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 45035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 450889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 45095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 45105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 45115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 45125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 4513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 45145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 4515fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap.clear(); 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 4517f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 45185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 4519f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 4520f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 4521a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 4522a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 4523a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 4524fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 45255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 45265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 45275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 45285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 45295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 45305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 45311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 45321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 4533b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 453403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 453583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4536b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 45375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 45395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 45405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 45410a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 45420a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 45435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 454458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 4545400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 45465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 454757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis pInfo = (*ii).second.get(); 4548de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (pInfo->alloc_info.allocationSize != 0) { 45495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 455083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 455183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 455283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, "MEM", 455383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 455483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 4560b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 4563414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 45655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 456683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 45705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 45725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 45775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4581971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4582e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 45875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4588414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 45895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 45905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 45915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4594856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4595856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4596856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4597971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4598414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4599856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4600414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4601414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4602414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4603856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4604856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4605856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4606856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4607971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4608414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4609856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4610856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4611856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4612856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 46185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 461939d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 4620a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Loop through bound objects and increment their in_use counts 4621a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// For any unknown objects, flag an error 46222f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic bool ValidateAndIncrementBoundObjects(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 4623162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis bool skip = false; 4624162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis DRAW_STATE_ERROR error_code = DRAWSTATE_NONE; 4625162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis BASE_NODE *base_obj = nullptr; 4626a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 4627a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis switch (obj.type) { 4628a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT: { 4629162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSetNode(dev_data, reinterpret_cast<VkDescriptorSet &>(obj.handle)); 4630162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_SET; 4631a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4632a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 463356f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT: { 4634162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getSamplerNode(dev_data, reinterpret_cast<VkSampler &>(obj.handle)); 4635162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_SAMPLER; 463656f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis break; 463756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 46382f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT: { 4639162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getQueryPoolNode(dev_data, reinterpret_cast<VkQueryPool &>(obj.handle)); 4640162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_QUERY_POOL; 46412f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46422f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46432f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT: { 4644162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getPipeline(dev_data, reinterpret_cast<VkPipeline &>(obj.handle)); 4645162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_PIPELINE; 46462f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46472f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46482f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 4649162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getBufferNode(dev_data, reinterpret_cast<VkBuffer &>(obj.handle)); 4650162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER; 46512f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46522f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46537e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT: { 46547e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getBufferViewState(dev_data, reinterpret_cast<VkBufferView &>(obj.handle)); 46557e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_BUFFER_VIEW; 46567e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46577e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46582f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 4659162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getImageNode(dev_data, reinterpret_cast<VkImage &>(obj.handle)); 4660162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE; 46612f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46622f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46637e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT: { 46647e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getImageViewState(dev_data, reinterpret_cast<VkImageView &>(obj.handle)); 46657e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_IMAGE_VIEW; 46667e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46677e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46682f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT: { 4669162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj = getEventNode(dev_data, reinterpret_cast<VkEvent &>(obj.handle)); 4670162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis error_code = DRAWSTATE_INVALID_EVENT; 46712f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis break; 46722f8cbf3b166e175174877a59929902e005953d6dTobin Ehlis } 46737e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT: { 46747e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getPoolNode(dev_data, reinterpret_cast<VkDescriptorPool &>(obj.handle)); 46757e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DESCRIPTOR_POOL; 46767e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46777e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46787e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_POOL_EXT: { 46797e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getCommandPoolNode(dev_data, reinterpret_cast<VkCommandPool &>(obj.handle)); 46807e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_COMMAND_POOL; 46817e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46837e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT: { 46847e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getFramebuffer(dev_data, reinterpret_cast<VkFramebuffer &>(obj.handle)); 46857e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_FRAMEBUFFER; 46867e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46877e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46887e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT: { 46897e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getRenderPass(dev_data, reinterpret_cast<VkRenderPass &>(obj.handle)); 46907e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_RENDERPASS; 46917e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46927e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 46937e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT: { 46947e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = getMemObjInfo(dev_data, reinterpret_cast<VkDeviceMemory &>(obj.handle)); 46957e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis error_code = DRAWSTATE_INVALID_DEVICE_MEMORY; 46967e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis break; 46977e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis } 4698a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis default: 4699a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : Merge handling of other objects types into this code 4700a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis break; 4701a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4702162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis if (!base_obj) { 4703162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis skip |= 4704162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj.type, obj.handle, __LINE__, error_code, "DS", 4705162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis "Cannot submit cmd buffer using deleted %s 0x%" PRIx64 ".", object_type_to_string(obj.type), obj.handle); 4706162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } else { 4707162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis base_obj->in_use.fetch_add(1); 4708162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis } 4709a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4710162dac96d3883e8fffaa1f988043f62c06662d2eTobin Ehlis return skip; 4711a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4712a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 47149a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlisstatic bool validateAndIncrementResources(layer_data *dev_data, GLOBAL_CB_NODE *cb_node) { 4715e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4716a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 47179a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis cb_node->in_use.fetch_add(1); 47189a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis dev_data->globalInFlightCmdBuffers.insert(cb_node->commandBuffer); 4719a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4720a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First Increment for all "generic" objects bound to cmd buffer, followed by special-case objects below 47219a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= ValidateAndIncrementBoundObjects(dev_data, cb_node); 4722a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // TODO : We should be able to remove the NULL look-up checks from the code below as long as 4723a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // all the corresponding cases are verified to cause CB_INVALID state and the CB_INVALID state 4724a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // should then be flagged prior to calling this function 47259a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 47279a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 47288718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 47299a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 47305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4731414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 47338718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis buffer_node->in_use.fetch_add(1); 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47379a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 47389a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto event_node = getEventNode(dev_data, event); 47399556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) 47409556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->write_in_use++; 4741c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 47425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4745b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4746b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 47477d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: untangle this. 4748b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4749b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4750b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4751b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4752b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4753b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4754b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4755b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4756b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4757414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4758414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4759b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4760b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4761b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4762b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4763b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4764b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4765b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 47667d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes 47677d33205c3aa4aba751a2c07f956634aac616f916Chris Forbes// TODO: nuke this completely. 4768b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4769b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4770b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4771b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4772b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4773b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4774b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4775b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4776b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4777b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4778a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis// Decrement in-use count for objects bound to command buffer 47792f8cbf3b166e175174877a59929902e005953d6dTobin Ehlisstatic void DecrementBoundResources(layer_data *dev_data, GLOBAL_CB_NODE const *cb_node) { 478000e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis BASE_NODE *base_obj = nullptr; 4781a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis for (auto obj : cb_node->object_bindings) { 47827e5c0c26004626cf6826dfe2779a738a1f9f1fffTobin Ehlis base_obj = GetStateStructPtrFromObject(dev_data, obj); 478300e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis if (base_obj) { 478400e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis base_obj->in_use.fetch_sub(1); 478500e8ce2e6c1c191758f7b7c15eeaf350e5b4a3b6Tobin Ehlis } 4786a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis } 4787a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis} 4788da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 47899867daedbf52debc77d6568162ee21e071699b80Chris Forbesstatic bool RetireWorkOnQueue(layer_data *dev_data, QUEUE_NODE *pQueue, uint64_t seq) 47909867daedbf52debc77d6568162ee21e071699b80Chris Forbes{ 47919867daedbf52debc77d6568162ee21e071699b80Chris Forbes bool skip_call = false; // TODO: extract everything that might fail to precheck 47929867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unordered_map<VkQueue, uint64_t> otherQueueSeqs; 47939867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47949867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll this queue forward, one submission at a time. 47959867daedbf52debc77d6568162ee21e071699b80Chris Forbes while (pQueue->seq < seq) { 47969867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & submission = pQueue->submissions.front(); 47979867daedbf52debc77d6568162ee21e071699b80Chris Forbes 47989867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & wait : submission.waitSemaphores) { 47999867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, wait.semaphore); 4800da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_sub(1); 48019867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto & lastSeq = otherQueueSeqs[wait.queue]; 48029867daedbf52debc77d6568162ee21e071699b80Chris Forbes lastSeq = std::max(lastSeq, wait.seq); 4803da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 4804cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 48059867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & semaphore : submission.signalSemaphores) { 48069867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 48079867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_sub(1); 48089867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4809cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes 48109867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto cb : submission.cbs) { 48119a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis auto cb_node = getCBNode(dev_data, cb); 4812a45bdcb94b2fbda36bc191e12cc20218f62fb0e0Tobin Ehlis // First perform decrement on general case bound objects 48139a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis DecrementBoundResources(dev_data, cb_node); 48149a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto drawDataElement : cb_node->drawData) { 48159867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto buffer : drawDataElement.buffers) { 48169867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto buffer_node = getBufferNode(dev_data, buffer); 48179867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (buffer_node) { 48189867daedbf52debc77d6568162ee21e071699b80Chris Forbes buffer_node->in_use.fetch_sub(1); 48199867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48209867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 4821da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 48229a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto event : cb_node->writeEventsBeforeWait) { 48239867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto eventNode = dev_data->eventMap.find(event); 48249867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (eventNode != dev_data->eventMap.end()) { 48259867daedbf52debc77d6568162ee21e071699b80Chris Forbes eventNode->second.write_in_use--; 48269867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48279867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48289a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto queryStatePair : cb_node->queryToStateMap) { 48299867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 48309867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 48319a61300d900fe3e43e9a03c7fa6876934bc1264eTobin Ehlis for (auto eventStagePair : cb_node->eventToStageMap) { 48329867daedbf52debc77d6568162ee21e071699b80Chris Forbes dev_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 4833da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes } 48340a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 48359867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= cleanInFlightCmdBuffer(dev_data, cb); 48369867daedbf52debc77d6568162ee21e071699b80Chris Forbes removeInFlightCmdBuffer(dev_data, cb); 48370a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48389867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48399867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pFence = getFenceNode(dev_data, submission.fence); 48409867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 48419867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->state = FENCE_RETIRED; 48420a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 48439867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48449867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.pop_front(); 48459867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->seq++; 4846b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 48479867daedbf52debc77d6568162ee21e071699b80Chris Forbes 48489867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Roll other queues forward to the highest seq we saw a wait for 48499867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto qs : otherQueueSeqs) { 48509867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, getQueueNode(dev_data, qs.first), qs.second); 4851d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 48539867daedbf52debc77d6568162ee21e071699b80Chris Forbes return skip_call; 48549867daedbf52debc77d6568162ee21e071699b80Chris Forbes} 4855651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4856651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 4857651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// Submit a fence to a queue, delimiting previous fences and previous untracked 4858651d92815dfff917308137bb67aacccc4f60df86Chris Forbes// work by it. 4859651d92815dfff917308137bb67aacccc4f60df86Chris Forbesstatic void 48609867daedbf52debc77d6568162ee21e071699b80Chris ForbesSubmitFence(QUEUE_NODE *pQueue, FENCE_NODE *pFence, uint64_t submitCount) 4861651d92815dfff917308137bb67aacccc4f60df86Chris Forbes{ 4862cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes pFence->state = FENCE_INFLIGHT; 48639867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = pQueue->queue; 48649867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.second = pQueue->seq + pQueue->submissions.size() + submitCount; 4865b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4866b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4867e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 48685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 48695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 48725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 487327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4874414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 48765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 488075b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const char *call_source) { 4881c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis bool skip = false; 4882c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis if (dev_data->instance_state->disabled.command_buffer_state) 4883c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 48840a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 48850a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 4886c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4887c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4888c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4889c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "set, but has been submitted 0x%" PRIxLEAST64 " times.", 4890c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 48910a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 48925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 48935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 48945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 48955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 4896e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto obj : pCB->broken_bindings) { 4897e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *type_str = object_type_to_string(obj.type); 4898e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis // Descriptor sets are a special case that can be either destroyed or updated to invalidated a CB 4899e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis const char *cause_str = 4900e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis (obj.type == VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT) ? "destroyed or updated" : "destroyed"; 49015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4902c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= 49035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 49045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4905e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because bound %s 0x%" PRIxLEAST64 4906e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis " was %s.", 4907e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), type_str, obj.handle, cause_str); 49085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 4910c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4911c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4912c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to %s!", 4913c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), call_source); 49145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4916c264142df95edb7eb96b5dc2d87562efce6ded43Tobin Ehlis return skip; 49175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 49197bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Validate that queueFamilyIndices of primary command buffers match this queue 49207bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski// Secondary command buffers were previously validated in vkCmdExecuteCommands(). 49217bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinskistatic bool validateQueueFamilyIndices(layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkQueue queue) { 49227bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski bool skip_call = false; 49237bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto pPool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 49247bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto queue_node = getQueueNode(dev_data, queue); 49257bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 49267bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (pPool && queue_node && (pPool->queueFamilyIndex != queue_node->queueFamilyIndex)) { 49277bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 49287bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 49297bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkQueueSubmit: Primary command buffer 0x%" PRIxLEAST64 49307bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d is being submitted on queue 0x%" PRIxLEAST64 " from queue family %d.", 49317bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), pPool->queueFamilyIndex, 49327bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(queue), queue_node->queueFamilyIndex); 49337bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 49347bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 49357bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski return skip_call; 49367bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski} 49377bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 4938da8f07baf262972eb3e719fa07b073c180dff157Chris Forbesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 494083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 4941a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 4942a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 4943a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes // on device 494483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateCommandBufferSimultaneousUse(dev_data, pCB); 4945a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 494683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pCB); 4947a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 495183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateAndIncrementResources(dev_data, pSubCB); 49524c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 49534c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4956414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 49575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4958414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 49594c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 49605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 49615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 49625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4965a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 496675b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pCB, "vkQueueSubmit()"); 4967a2d08a743ac1178e4d46da4d41c73fb73b5e79d7Chris Forbes 496883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 49695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 497181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbesstatic bool 4972651d92815dfff917308137bb67aacccc4f60df86Chris ForbesValidateFenceForSubmit(layer_data *dev_data, FENCE_NODE *pFence) 497381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes{ 497483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 497581c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4976651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 4977cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_INFLIGHT) { 497883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 497983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(pFence->fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 498083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(pFence->fence)); 4981a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 498281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4983cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes else if (pFence->state == FENCE_RETIRED) { 498483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 498583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 498683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 498783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 498883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(pFence->fence)); 4989a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 49905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 499181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 499283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 499381c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes} 499481c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 4995651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 499681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesVKAPI_ATTR VkResult VKAPI_CALL 499781c4a32a622486043c15e427fb0e85cc1cf7dd47Chris ForbesQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 499883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 499981c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 500081c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 500181c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 500281c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 5003651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 5004651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 500583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 500681c4a32a622486043c15e427fb0e85cc1cf7dd47Chris Forbes 500783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 5008d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5009d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes } 5010d7d60cccc862fee2d0b3ad410c5fdcc40ddc83aeChris Forbes 50111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 50121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 50131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 5014651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5015651d92815dfff917308137bb67aacccc4f60df86Chris Forbes // Mark the fence in-use. 5016651d92815dfff917308137bb67aacccc4f60df86Chris Forbes if (pFence) { 50179867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, std::max(1u, submitCount)); 5018651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 5019651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 50205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 50215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 50225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 50239867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<SEMAPHORE_WAIT> semaphore_waits; 50249867daedbf52debc77d6568162ee21e071699b80Chris Forbes vector<VkSemaphore> semaphore_signals; 50255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 502601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pWaitSemaphores[i]; 502701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 502801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 502901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 50309867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 50319867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 50329867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 50339867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 50349867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 503501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 50361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 503783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 50381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 50391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 5040414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 50411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 50421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 504601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = submit->pSignalSemaphores[i]; 504701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 504801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 504901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 505083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 50511344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 50521344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 5053414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 5054414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 50551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 50569867daedbf52debc77d6568162ee21e071699b80Chris Forbes reinterpret_cast<uint64_t &>(pSemaphore->signaler.first)); 50571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 50589867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 50599867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 506001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = true; 5061da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes pSemaphore->in_use.fetch_add(1); 50629867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 50631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50640a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5066651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 5067da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes std::vector<VkCommandBuffer> cbs; 5068da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 50695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 5070971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 507183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 50721344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 5073da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(submit->pCommandBuffers[i]); 5074651d92815dfff917308137bb67aacccc4f60df86Chris Forbes for (auto secondaryCmdBuffer : pCBNode->secondaryCommandBuffers) { 5075da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes cbs.push_back(secondaryCmdBuffer); 5076651d92815dfff917308137bb67aacccc4f60df86Chris Forbes } 5077651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 50781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 507983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBufferState(dev_data, pCBNode); 50807bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= validateQueueFamilyIndices(dev_data, pCBNode, queue); 5081ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis // Potential early exit here as bad object state may crash in delayed function calls 5082ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis if (skip_call) 5083ea371fa7c8c57edb4d1436e4570cf54f3fc0463fTobin Ehlis return result; 50841344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 50851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 508683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(); 50871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 508983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 50901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 5091d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 509283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= function(queue); 5093d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 50941344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 50955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5096da8f07baf262972eb3e719fa07b073c180dff157Chris Forbes 50979867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(cbs, semaphore_waits, semaphore_signals, 50989867daedbf52debc77d6568162ee21e071699b80Chris Forbes submit_idx == submitCount - 1 ? fence : VK_NULL_HANDLE); 50999867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 51009867daedbf52debc77d6568162ee21e071699b80Chris Forbes 51019867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !submitCount) { 51029867daedbf52debc77d6568162ee21e071699b80Chris Forbes // If no submissions, but just dropping a fence on the end of the queue, 51039867daedbf52debc77d6568162ee21e071699b80Chris Forbes // record an empty submission with just the fence, so we can determine 51049867daedbf52debc77d6568162ee21e071699b80Chris Forbes // its completion. 51059867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 51069867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 51079867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 51089867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 51095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51109867daedbf52debc77d6568162ee21e071699b80Chris Forbes 5111b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 511283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 51135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 51145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 511889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 511989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 51205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 51225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 5123b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 51245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 51250a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 51265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 512989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 513089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 51315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 51345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 51355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 51375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 51385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 51395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5140b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 514174243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller bool skip_call = freeMemObjInfo(my_data, device, mem, false); 51420a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 51430a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 5144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 514574243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller if (!skip_call) { 514674243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 514774243a735fe102b370237ddf80d3e6f7ec5246dbMark Mueller } 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5150f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// Validate that given Map memory range is valid. This means that the memory should not already be mapped, 5151f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// and that the size of the map range should be: 5152f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 1. Not zero 5153f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis// 2. Within the size of the memory allocation 5154f57fc64ac43691ad98e1713886b345465573070aTobin Ehlisstatic bool ValidateMapMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 515583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 515883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 515983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 516083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 51615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 516557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = mem_element->second.get(); 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 5167de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.size != 0) { 516883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 516983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 517083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 51715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 51735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 51745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 5175de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (offset >= mem_info->alloc_info.allocationSize) { 517683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 517783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 517883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 517983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, 5180de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis offset, mem_info->alloc_info.allocationSize, mem_info->alloc_info.allocationSize); 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5183de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if ((offset + size) > mem_info->alloc_info.allocationSize) { 518483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 518557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 518657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 518757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 5188de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis size + offset, mem_info->alloc_info.allocationSize); 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 519283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 51935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5195e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 519657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 519757fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5198de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.offset = offset; 5199de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = size; 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5203e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 520483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 520557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, mem); 520657fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5207de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (!mem_info->mem_range.size) { 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 520983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 521083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 521183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 52125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5213de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->mem_range.size = 0; 52145f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 52155f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski free(mem_info->shadow_copy_base); 52165f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = 0; 52175f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 522083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52235f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski// Guard value for pad data 52245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 52255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52265f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, 52275f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski void **ppData) { 522857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 522957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5230de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis mem_info->p_driver_data = *ppData; 5231de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis uint32_t index = mem_info->alloc_info.memoryTypeIndex; 5232b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 52335f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 0; 52345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 52355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 52365f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski size = mem_info->alloc_info.allocationSize - offset; 52375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52385f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_pad_size = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 52395f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(mem_info->shadow_pad_size, 52405f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment) == 0); 52415f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Ensure start of mapped region reflects hardware alignment constraints 52425f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t map_alignment = dev_data->phys_dev_properties.properties.limits.minMemoryMapAlignment; 52435f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52445f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // From spec: (ppData - offset) must be aligned to at least limits::minMemoryMapAlignment. 52455f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski uint64_t start_offset = offset % map_alignment; 52465f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski // Data passed to driver will be wrapped by a guardband of data to detect over- or under-writes. 52475f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy_base = malloc(2 * mem_info->shadow_pad_size + size + map_alignment + start_offset); 52485f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52495f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski mem_info->shadow_copy = 52505f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski reinterpret_cast<char *>((reinterpret_cast<uintptr_t>(mem_info->shadow_copy_base) + map_alignment) & 52515f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ~(map_alignment - 1)) + start_offset; 52525f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski assert(vk_safe_modulo(reinterpret_cast<uintptr_t>(mem_info->shadow_copy) + mem_info->shadow_pad_size - start_offset, 52535f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski map_alignment) == 0); 52545f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 52555f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memset(mem_info->shadow_copy, NoncoherentMemoryFillValue, 2 * mem_info->shadow_pad_size + size); 52565f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski *ppData = static_cast<char *>(mem_info->shadow_copy) + mem_info->shadow_pad_size; 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52605f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski 5261a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 52629867daedbf52debc77d6568162ee21e071699b80Chris Forbes// a fence being waited on should not already be signaled and 5263a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 526449f6132af865afd5b7f413c91125971ac97c135aChris Forbesstatic inline bool verifyWaitFenceState(layer_data *dev_data, VkFence fence, const char *apiCall) { 526583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 52669b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes 526749f6132af865afd5b7f413c91125971ac97c135aChris Forbes auto pFence = getFenceNode(dev_data, fence); 52689b48b44dd917f95b5f34dd629ec4076fc87eb3a2Chris Forbes if (pFence) { 5269cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (pFence->state == FENCE_UNSIGNALED) { 527083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 527183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 527283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 527383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "acquire next image.", 527483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 52755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 527783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5279a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 5280b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbesstatic bool RetireFence(layer_data *dev_data, VkFence fence) { 5281b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes auto pFence = getFenceNode(dev_data, fence); 5282b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes if (pFence->signaler.first != VK_NULL_HANDLE) { 5283b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes /* Fence signaller is a queue -- use this as proof that prior operations 5284b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes * on that queue have completed. 5285b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes */ 5286b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes return RetireWorkOnQueue(dev_data, 5287b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes getQueueNode(dev_data, pFence->signaler.first), 5288b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes pFence->signaler.second); 5289b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes } 5290d4513979120463171eb479cdded9336eb9944da1Chris Forbes else { 5291d4513979120463171eb479cdded9336eb9944da1Chris Forbes /* Fence signaller is the WSI. We're not tracking what the WSI op 5292d4513979120463171eb479cdded9336eb9944da1Chris Forbes * actually /was/ in CV yet, but we need to mark the fence as retired. 5293d4513979120463171eb479cdded9336eb9944da1Chris Forbes */ 5294d4513979120463171eb479cdded9336eb9944da1Chris Forbes pFence->state = FENCE_RETIRED; 5295d4513979120463171eb479cdded9336eb9944da1Chris Forbes return false; 5296d4513979120463171eb479cdded9336eb9944da1Chris Forbes } 5297b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes} 5298b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes 529989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 530089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 53015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5302e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 5304b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 530649f6132af865afd5b7f413c91125971ac97c135aChris Forbes skip_call |= verifyWaitFenceState(dev_data, pFences[i], "vkWaitForFences"); 53075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5308b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 53105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5311a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 53125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 5313414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 53145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5315b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 53189867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (uint32_t i = 0; i < fenceCount; i++) { 5319b3ecd4c1fb44a2e65dfc13256afa9150aabde1d4Chris Forbes skip_call |= RetireFence(dev_data, pFences[i]); 53209867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 5325b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5327e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 533289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 533483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5335b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 533683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = verifyWaitFenceState(dev_data, fence, "vkGetFenceStatus"); 5337b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5338a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 533983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 534083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5341a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 534283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 5343b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5345d4513979120463171eb479cdded9336eb9944da1Chris Forbes skip_call |= RetireFence(dev_data, fence); 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5347b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5348e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 5354b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 5357b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5358b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 5359b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 5360b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 5361b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 5362b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 53638988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes pQNode->queue = *pQueue; 53647bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski pQNode->queueFamilyIndex = queueFamilyIndex; 53659867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQNode->seq = 0; 5366b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 53675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 536989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 5371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53729867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 53739867daedbf52debc77d6568162ee21e071699b80Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 53749867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, pQueue, pQueue->seq + pQueue->submissions.size()); 53759867daedbf52debc77d6568162ee21e071699b80Chris Forbes lock.unlock(); 5376e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 53795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 538289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 5383e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5385b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53869867daedbf52debc77d6568162ee21e071699b80Chris Forbes for (auto & queue : dev_data->queueMap) { 53879867daedbf52debc77d6568162ee21e071699b80Chris Forbes skip_call |= RetireWorkOnQueue(dev_data, &queue.second, queue.second.seq + queue.second.submissions.size()); 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5389b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5390e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 53935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 539689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 539883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 5399b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 54011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 5402cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes if (fence_pair->second.state == FENCE_INFLIGHT) { 540383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 540483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", "Fence 0x%" PRIx64 " is in use.", 540583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(fence)); 54061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 54071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 54085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5409b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 54101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 541183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5415eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis// For given obj node, if it is use, flag a validation error and return callback result, else return false 5416eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlisbool ValidateObjectNotInUse(const layer_data *dev_data, BASE_NODE *obj_node, VK_OBJECT obj_struct) { 54177626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis if (dev_data->instance_state->disabled.object_in_use) 54187626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis return false; 5419eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5420eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (obj_node->in_use.load()) { 5421eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_struct.type, obj_struct.handle, __LINE__, 5422f4cc4424ca6a7819cd8e9ed646d337b4a74ed7f3Tobin Ehlis DRAWSTATE_OBJECT_INUSE, "DS", "Cannot delete %s 0x%" PRIx64 " that is currently in use by a command buffer.", 5423eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis object_type_to_string(obj_struct.type), obj_struct.handle); 5424eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis } 5425eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis return skip; 5426eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis} 5427eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis 542889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 542989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 54305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5431eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5432e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5433eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis auto sema_node = getSemaphoreNode(dev_data, semaphore); 5434eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (sema_node) { 5435eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sema_node, 5436eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis {reinterpret_cast<uint64_t &>(semaphore), VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT}); 54375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5438eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis if (!skip) { 5439eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->semaphoreMap.erase(semaphore); 5440eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis lock.unlock(); 544199d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 544299d938c90c2f000ee73fb13513dacf84ffa5651fMark Mueller } 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 544589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5447eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5448b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54499556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 54509556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 5451eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}; 5452eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, event_node, obj_struct); 54539556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis // Any bound cmd buffers are now invalid 5454eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(event_node->cb_bindings, obj_struct); 54559556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis } 5456f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5457f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->eventMap.erase(event); 5458f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5459e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 5460f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 546389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 546489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 5465ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5466eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5467ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5468ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis auto qp_node = getQueryPoolNode(dev_data, queryPool); 5469ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis if (qp_node) { 5470eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}; 5471eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, qp_node, obj_struct); 5472ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis // Any bound cmd buffers are now invalid 5473eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(qp_node->cb_bindings, obj_struct); 5474ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis } 5475f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5476f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->queryPoolMap.erase(queryPool); 5477f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5478eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 5479f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 548289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 548389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 548489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 5487b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 5489971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 54955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 54965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 54975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 54995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 5500ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 5501ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5502ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 5503ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5504971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5505ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 5506ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 5507ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5508ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5509414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 5510ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 5511ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 5512ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 5513ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 5514ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5515ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5516ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5517ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 5518ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 5519ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 5520ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 5521ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 5522ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 5523971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 5524ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 5525ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 5526ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 55275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5529414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5532ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 5533ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 55355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5536414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 5538ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 5539ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 5540ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5541ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 5542414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 5543ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 5544ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5548b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 55495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5555e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 5556e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 55578718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(my_data, buffer); 55588718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (!buffer_node) { 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 5561414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 55625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 55638718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node->in_use.load()) { 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 5566414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 55705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5572825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if given ranges intersect, else false 5573825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Prereq : For both ranges, range->end - range->start > 0. This case should have already resulted 5574825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// in an error so not checking that here 5575825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// pad_ranges bool indicates a linear and non-linear comparison which requires padding 5576825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// In the case where padding is required, if an alias is encountered then a validation error is reported and skip_call 5577825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// may be set by the callback function so caller should merge in skip_call value if padding case is possible. 55787dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, MEMORY_RANGE const *range2, bool *skip_call) { 55797dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call = false; 5580825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_start = range1->start; 5581825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r1_end = range1->end; 5582825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_start = range2->start; 5583825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto r2_end = range2->end; 5584825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkDeviceSize pad_align = 1; 5585825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5586825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis pad_align = dev_data->phys_dev_properties.properties.limits.bufferImageGranularity; 5587825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5588825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_end & ~(pad_align - 1)) < (r2_start & ~(pad_align - 1))) 5589825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 5590825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if ((r1_start & ~(pad_align - 1)) > (r2_end & ~(pad_align - 1))) 5591825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return false; 559247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5593825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (range1->linear != range2->linear) { 5594825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // In linear vs. non-linear case, it's an error to alias 5595825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_linear_str = range1->linear ? "Linear" : "Non-linear"; 5596825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r1_type_str = range1->image ? "image" : "buffer"; 5597825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_linear_str = range2->linear ? "linear" : "non-linear"; 5598825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis const char *r2_type_str = range2->image ? "image" : "buffer"; 5599825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto obj_type = range1->image ? VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT : VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT; 56007dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis *skip_call |= 5601825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, range1->handle, 0, MEMTRACK_INVALID_ALIASING, 5602825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis "MEM", "%s %s 0x%" PRIx64 " is aliased with %s %s 0x%" PRIx64 5603825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis " which is in violation of the Buffer-Image Granularity section of the Vulkan specification.", 5604825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis r1_linear_str, r1_type_str, range1->handle, r2_linear_str, r2_type_str, range2->handle); 560547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 5606825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Ranges intersect 5607825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return true; 560847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 5609623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis// Simplified rangesIntersect that calls above function to check range1 for intersection with offset & end addresses 5610cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool rangesIntersect(layer_data const *dev_data, MEMORY_RANGE const *range1, VkDeviceSize offset, VkDeviceSize end) { 5611825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Create a local MEMORY_RANGE struct to wrap offset/size 5612825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis MEMORY_RANGE range_wrap; 5613825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis // Synch linear with range1 to avoid padding and potential validation error case 5614825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.linear = range1->linear; 5615825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range_wrap.start = offset; 5616cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis range_wrap.end = end; 5617825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool tmp_bool; 56187dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis return rangesIntersect(dev_data, range1, &range_wrap, &tmp_bool); 5619825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5620cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// For given mem_info, set all ranges valid that intersect [offset-end] range 5621cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis// TODO : For ranges where there is no alias, we may want to create new buffer ranges that are valid 5622cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic void SetMemRangesValid(layer_data const *dev_data, DEVICE_MEM_INFO *mem_info, VkDeviceSize offset, VkDeviceSize end) { 5623cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis bool tmp_bool = false; 5624cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis MEMORY_RANGE map_range; 5625cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.linear = true; 5626cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.start = offset; 5627cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis map_range.end = end; 5628cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto &handle_range_pair : mem_info->bound_ranges) { 56297dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &handle_range_pair.second, &map_range, &tmp_bool)) { 5630cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : WARN here if tmp_bool true? 5631cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis handle_range_pair.second.valid = true; 5632cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5633cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis } 5634cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis} 5635825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Object with given handle is being bound to memory w/ given mem_info struct. 5636825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Track the newly bound memory range with given memoryOffset 5637825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Also scan any previous ranges, track aliased ranges with new range, and flag an error if a linear 5638825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// and non-linear range incorrectly overlap. 5639825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Return true if an error is flagged and the user callback returns "true", otherwise false 5640825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates an image object, otherwise handle is for a buffer 5641825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_linear indicates a buffer or linear image 5642825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic bool InsertMemoryRange(layer_data const *dev_data, uint64_t handle, DEVICE_MEM_INFO *mem_info, VkDeviceSize memoryOffset, 5643825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements memRequirements, bool is_image, bool is_linear) { 5644825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis bool skip_call = false; 56455360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis MEMORY_RANGE range; 5646825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5647825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.image = is_image; 564847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 5649825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.linear = is_linear; 5650f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis range.valid = mem_info->global_valid; 5651825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.memory = mem_info->mem; 565247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 5653825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.size = memRequirements.size; 565447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 56555360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis range.aliases.clear(); 56565360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Update Memory aliasing 56575360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // Save aliase ranges so we can copy into final map entry below. Can't do it in loop b/c we don't yet have final ptr. If we 56585360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis // inserted into map before loop to get the final ptr, then we may enter loop when not needed & we check range against itself 56595360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis std::unordered_set<MEMORY_RANGE *> tmp_alias_ranges; 5660825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto &obj_range_pair : mem_info->bound_ranges) { 5661825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto check_range = &obj_range_pair.second; 56625360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis bool intersection_error = false; 56637dc3fbb89e2dcf3df8fc2e6639a867a959fef3f3Tobin Ehlis if (rangesIntersect(dev_data, &range, check_range, &intersection_error)) { 5664825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis skip_call |= intersection_error; 5665825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis range.aliases.insert(check_range); 56665360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_alias_ranges.insert(check_range); 5667825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 5668825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis } 56695360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis mem_info->bound_ranges[handle] = std::move(range); 56705360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis for (auto tmp_range : tmp_alias_ranges) { 56715360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis tmp_range->aliases.insert(&mem_info->bound_ranges[handle]); 56725360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis } 5673825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (is_image) 5674825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.insert(handle); 5675825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis else 5676825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.insert(handle); 5677825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5678825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis return skip_call; 567947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 568047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 56819f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertImageMemoryRange(layer_data const *dev_data, VkImage image, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5682825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs, bool is_linear) { 56839f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(image), mem_info, mem_offset, mem_reqs, true, is_linear); 5684825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5685825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 56869f12a235bb9c014878a98ce385b68587add2538aTobin Ehlisstatic bool InsertBufferMemoryRange(layer_data const *dev_data, VkBuffer buffer, DEVICE_MEM_INFO *mem_info, VkDeviceSize mem_offset, 5687825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis VkMemoryRequirements mem_reqs) { 56889f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis return InsertMemoryRange(dev_data, reinterpret_cast<uint64_t &>(buffer), mem_info, mem_offset, mem_reqs, false, true); 5689825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis} 5690825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5691825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// Remove MEMORY_RANGE struct for give handle from bound_ranges of mem_info 5692825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// is_image indicates if handle is for image or buffer 5693825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// This function will also remove the handle-to-index mapping from the appropriate 5694825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis// map and clean up any aliases for range being removed. 5695825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info, bool is_image) { 5696825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis auto erase_range = &mem_info->bound_ranges[handle]; 5697825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis for (auto alias_range : erase_range->aliases) { 5698825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis alias_range->aliases.erase(erase_range); 569947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57005360871dd546e8aa7c1a273e9036c201fe4e3ffbTobin Ehlis erase_range->aliases.clear(); 5701825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_ranges.erase(handle); 57021cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis if (is_image) { 5703825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_images.erase(handle); 57041cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } else { 5705825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis mem_info->bound_buffers.erase(handle); 57061cba4e1b5940c6818572e05dcad5a3a47fafbc9eTobin Ehlis } 570747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 570847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 5709825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveBufferMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, false); } 5710825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 5711825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlisstatic void RemoveImageMemoryRange(uint64_t handle, DEVICE_MEM_INFO *mem_info) { RemoveMemoryRange(handle, mem_info, true); } 5712825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis 571389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 571489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 57155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5716b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 57175a758b24bbcdad37a5ccf41c3581c289acf11c2dTobin Ehlis if (!validateIdleBuffer(dev_data, buffer)) { 5718e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Clean up memory binding and range information for buffer 5719e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 5720e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (buff_node) { 5721e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // Any bound cmd buffers are now invalid 5722e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis invalidateCommandBuffers(buff_node->cb_bindings, 5723e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis {reinterpret_cast<uint64_t &>(buff_node->buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT}); 5724e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis auto mem_info = getMemObjInfo(dev_data, buff_node->mem); 5725e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis if (mem_info) { 5726825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveBufferMemoryRange(reinterpret_cast<uint64_t &>(buffer), mem_info); 5727e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5728e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 5729e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->bufferMap.erase(buff_node->buffer); 5730e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis } 5731b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 57325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 573347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 57345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57368e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic bool PreCallValidateDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE **buffer_view_state, 57378e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT *obj_struct) { 57387626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis if (dev_data->instance_state->disabled.destroy_buffer_view) 57397626815e3c23be98681f3fcf733ee938022af612Tobin Ehlis return false; 57408e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = false; 57418e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis *buffer_view_state = getBufferViewState(dev_data, buffer_view); 57428e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis if (buffer_view_state) { 57438e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis *obj_struct = {reinterpret_cast<uint64_t &>(buffer_view), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_VIEW_EXT}; 57448e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, *buffer_view_state, *obj_struct); 57458e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis } 57468e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis return skip; 57478e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 57488e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 57498e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlisstatic void PostCallRecordDestroyBufferView(layer_data *dev_data, VkBufferView buffer_view, BUFFER_VIEW_STATE *buffer_view_state, 57508e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct) { 57518e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis dev_data->bufferViewMap.erase(buffer_view); 57528e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Any bound cmd buffers are now invalid 57538e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis invalidateCommandBuffers(buffer_view_state->cb_bindings, obj_struct); 57548e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis} 57558e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis 575689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 575789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 57585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5759e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 57608e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Common data objects use pre & post call 57618e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis BUFFER_VIEW_STATE *buffer_view_state = nullptr; 57628e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis VK_OBJECT obj_struct; 57638e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // Validate state before calling down chain, update common data if we'll be calling down chain 57648e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis bool skip = PreCallValidateDestroyBufferView(dev_data, bufferView, &buffer_view_state, &obj_struct); 576538e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis if (!skip) { 576638e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis lock.unlock(); 576738e26abbaa884eb48bfec4ddb4e0ae2c90634e06Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 57688e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis lock.lock(); 57698e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis // We made call so update state 57708e0ffae5b5c87fa062229b8c003be10c7e48aea1Tobin Ehlis PostCallRecordDestroyBufferView(dev_data, bufferView, buffer_view_state, obj_struct); 57715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 577489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5776f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis bool skip = false; 5777e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 577899df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto img_node = getImageNode(dev_data, image); 577999df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis if (img_node) { 5780f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(img_node->image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT}; 578199df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis // Any bound cmd buffers are now invalid 5782f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis invalidateCommandBuffers(img_node->cb_bindings, obj_struct); 5783f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis skip |= ValidateObjectNotInUse(dev_data, img_node, obj_struct); 5784f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis } 5785f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis if (!skip) { 578647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 578799df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, img_node->mem); 578857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 5789825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis RemoveImageMemoryRange(reinterpret_cast<uint64_t &>(image), mem_info); 579047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 579147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 579258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 579399df1a43113407af9ddb0aa2322fb99d9f59e5c2Tobin Ehlis dev_data->imageMap.erase(img_node->image); 5794f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis 5795f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis const auto &subEntry = dev_data->imageSubresourceMap.find(image); 5796f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 5797f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis for (const auto &pair : subEntry->second) { 5798f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 5799f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis } 5800f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 58015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5802f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis lock.unlock(); 5803f940225c9e5e3e14b3f5a32d3ea360b585614600Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 58045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58074261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinskistatic bool ValidateMemoryTypes(const layer_data *dev_data, const DEVICE_MEM_INFO *mem_info, const uint32_t memory_type_bits, 58084261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski const char *funcName) { 58094261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski bool skip_call = false; 5810de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (((1 << mem_info->alloc_info.memoryTypeIndex) & memory_type_bits) == 0) { 5811de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis skip_call = log_msg( 5812de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5813de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis reinterpret_cast<const uint64_t &>(mem_info->mem), __LINE__, MEMTRACK_INVALID_MEM_TYPE, "MT", 5814de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "%s(): MemoryRequirements->memoryTypeBits (0x%X) for this object type are not compatible with the memory " 5815de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis "type (0x%X) of this memory object 0x%" PRIx64 ".", 5816de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, memory_type_bits, mem_info->alloc_info.memoryTypeIndex, reinterpret_cast<const uint64_t &>(mem_info->mem)); 58174261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski } 58184261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski return skip_call; 58194261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski} 58204261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski 582189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 582289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 582358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5825b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 58279f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis uint64_t buffer_handle = reinterpret_cast<uint64_t &>(buffer); 5828888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis bool skip_call = SetMemBinding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 58298718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, buffer); 58308718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 58315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 583294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 58334bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->mem = mem; 58344bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memOffset = memoryOffset; 58354bf66272b011176416dd42e726decd70d5a02fa2Chris Forbes buffer_node->memSize = memRequirements.size; 583647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 583747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 583857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 583957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 58409f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertBufferMemoryRange(dev_data, buffer, mem_info, memoryOffset, memRequirements); 584183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "BindBufferMemory"); 584247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 584347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 58442c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 58452c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 584683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 58472c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 58482c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5849414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5850414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 58512c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 58522c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 58532c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 5854ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 58552c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 5856ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const VkBufferUsageFlagBits usage_list[3] = { 5857ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static_cast<VkBufferUsageFlagBits>(VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT), 5858ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT, 5859ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller VK_BUFFER_USAGE_STORAGE_BUFFER_BIT}; 5860ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *memory_type[3] = {"texel", 5861ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "uniform", 5862ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "storage"}; 5863ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller static const char *offset_name[3] = { 5864ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minTexelBufferOffsetAlignment", 5865ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minUniformBufferOffsetAlignment", 5866ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "minStorageBufferOffsetAlignment" 5867ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 5868ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5869ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller // Keep this one fresh! 5870ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller const VkDeviceSize offset_requirement[3] = { 5871ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment, 5872ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment, 5873ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment 5874ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller }; 58758718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].get()->createInfo.usage; 5876ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 5877ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller for (int i = 0; i < 3; i++) { 5878ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (usage & usage_list[i]) { 5879ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller if (vk_safe_modulo(memoryOffset, offset_requirement[i]) != 0) { 5880ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller skip_call |= 5881ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 5882ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5883ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "vkBindBufferMemory(): %s memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5884ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller "device limit %s 0x%" PRIxLEAST64, 5885ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller memory_type[i], memoryOffset, offset_name[i], offset_requirement[i]); 5886ba4316045bf5f1054629bb7c2fced7bae98ed52aMark Mueller } 58872c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58882c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 58895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5891b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 589283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 589358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 58945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 589889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 589989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 59005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 59035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 59045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 590689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 590789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 59085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 59095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 59105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 59115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 59125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5913593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 591489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 591589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 5916d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5917d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis bool skip = false; 5918d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5919d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 5920d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis if (view_state) { 5921d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(imageView), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_VIEW_EXT}; 5922d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, view_state, obj_struct); 5923d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis // Any bound cmd buffers are now invalid 5924d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis invalidateCommandBuffers(view_state->cb_bindings, obj_struct); 5925d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis } 5926d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis if (!skip) { 5927d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis dev_data->imageViewMap.erase(imageView); 5928d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis lock.unlock(); 5929d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis dev_data->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 5930d85c42a6c1d6ad7a6f684c5bd793aab482b7705cTobin Ehlis } 59315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 593389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 593489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5935918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5936918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5938918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5939b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5940918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5941918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 59425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 594489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 594589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 5946a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5947eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 5948e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 5949a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis auto pipe_node = getPipeline(dev_data, pipeline); 5950a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis if (pipe_node) { 5951eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}; 5952eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, pipe_node, obj_struct); 5953a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis // Any bound cmd buffers are now invalid 5954eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(pipe_node->cb_bindings, obj_struct); 5955a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis } 5956f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5957f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->pipelineMap.erase(pipeline); 5958f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5959eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 5960f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 59615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 596389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 596489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 59656792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5966e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 59676792ea7cc0ce5fa64b7bd6c946460608cbda91c7Tobin Ehlis dev_data->pipelineLayoutMap.erase(pipelineLayout); 5968e28cddb35c63274c13873b9a7060ad43b255c6f1Tobin Ehlis lock.unlock(); 5969e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 5970e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 597389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 597489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 597556f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5976eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis bool skip = false; 597756f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 597856f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis auto sampler_node = getSamplerNode(dev_data, sampler); 597956f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis if (sampler_node) { 5980eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(sampler), VK_DEBUG_REPORT_OBJECT_TYPE_SAMPLER_EXT}; 5981eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, sampler_node, obj_struct); 598256f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis // Any bound cmd buffers are now invalid 5983eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis invalidateCommandBuffers(sampler_node->cb_bindings, obj_struct); 598456f8a8f9b7e8c01d76d73be117ebcb66035db6dfTobin Ehlis } 5985f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis if (!skip) { 5986f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis dev_data->samplerMap.erase(sampler); 5987f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis lock.unlock(); 5988eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis dev_data->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 5989f57cf525e45f3a65e25c2691464d65e29a79ba77Tobin Ehlis } 59905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 599289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 599389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 5994e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 59955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 59965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 59975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 59985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 599989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 600089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 6001e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis // TODO : Clean up any internal data structures using this obj. 60025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 60035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 60045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6005bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 6006bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 6007bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 6008bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 6009a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbesstatic bool checkCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 6010bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6011bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 6012bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 6013bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 6014bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 6015bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 6016bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6017bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6018414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 6019bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 6020bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6021bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6022bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6023bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 6024a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 6025bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 6026a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic bool checkCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool, const char *action) { 6027bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 6028a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6029a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 6030a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 6031bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6032bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 6033bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 6034bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 60355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6036a01b5eb150981aad061238e64b173d0da8c11140Chris Forbesstatic void clearCommandBuffersInFlight(layer_data *dev_data, COMMAND_POOL_NODE *pPool) { 6037a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmd_buffer : pPool->commandBuffers) { 6038a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 6039a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes } 6040a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes} 6041a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes 604289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 604389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 60445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 6046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6047c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 60485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 60499f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 60505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 60519f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 60529f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis skip_call |= checkCommandBufferInFlight(dev_data, cb_node, "free"); 6053c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6054c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes } 6055c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6056c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes if (skip_call) 6057c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes return; 6058c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes 6059c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 6060c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes for (uint32_t i = 0; i < commandBufferCount; i++) { 60619f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, pCommandBuffers[i]); 6062c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes // Delete CB information structure, and remove from commandBufferMap 60639f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 60649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 60669f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis resetCB(dev_data, cb_node->commandBuffer); 60679f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb_node->commandBuffer); 60689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; 60695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 6072c05d773a018aa47e89841533a6968d9e5b314038Chris Forbes pPool->commandBuffers.remove(pCommandBuffers[i]); 60735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60740a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6075b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6076e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 6077e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 608089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 608189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 608289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 60865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6088b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 60905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 609589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 609689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 61005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 6101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6102eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis QUERY_POOL_NODE *qp_node = &dev_data->queryPoolMap[*pQueryPool]; 6103eafbf0b68ee6ea6e0bf33f07e0058d00a96efd9aTobin Ehlis qp_node->createInfo = *pCreateInfo; 61045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 610989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 611089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 611283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6113b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 6115a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 611683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "destroy command pool with"); 61175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 611883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 61195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 61209f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandBufferMap 6121a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 6122a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cb : pPool->commandBuffers) { 6123a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 61249f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, cb); 6125d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // Remove references to this cb_node prior to delete 6126d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis // TODO : Need better solution here, resetCB? 61277165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski for (auto obj : cb_node->object_bindings) { 61287165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski removeCommandBufferBinding(dev_data, &obj, cb_node); 61297165385f3a39f1f951f3a6a9a06ed2cce4642b6dMark Lobodzinski } 6130d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis for (auto framebuffer : cb_node->framebuffers) { 6131d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 6132d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis if (fb_node) 6133d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis fb_node->cb_bindings.erase(cb_node); 6134d61de0e68063faa169a9a632f811c9c9adec9897Tobin Ehlis } 61359f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis dev_data->commandBufferMap.erase(cb); // Remove this command buffer 61369f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis delete cb_node; // delete CB info structure 6137a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes } 6138a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes dev_data->commandPoolMap.erase(commandPool); 6139a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes lock.unlock(); 6140e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 6141e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 614489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 614589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 614783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6148400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 61491ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes std::unique_lock<std::mutex> lock(global_lock); 6150a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes auto pPool = getCommandPoolNode(dev_data, commandPool); 615183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= checkCommandBuffersInFlight(dev_data, pPool, "reset command pool with"); 61521ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 6153a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes 615483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6157a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 61605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 61611ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.lock(); 6162a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes clearCommandBuffersInFlight(dev_data, pPool); 6163a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes for (auto cmdBuffer : pPool->commandBuffers) { 6164a01b5eb150981aad061238e64b173d0da8c11140Chris Forbes resetCB(dev_data, cmdBuffer); 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61661ec6311a8537f4467db08eacbd762ebaa87e70b0Chris Forbes lock.unlock(); 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 617189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 617383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 6174b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 6176df1846b33487b02061c0ff42d768588a9abeb6c7Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6177090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence && pFence->state == FENCE_INFLIGHT) { 617883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 617983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 618083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Fence 0x%" PRIx64 " is in use.", reinterpret_cast<const uint64_t &>(pFences[i])); 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6183b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6184090da73358f71ba026e2474a822fecf55267d166Chris Forbes 618583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 6186090da73358f71ba026e2474a822fecf55267d166Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 6187090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6188090da73358f71ba026e2474a822fecf55267d166Chris Forbes VkResult result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 6189090da73358f71ba026e2474a822fecf55267d166Chris Forbes 6190090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (result == VK_SUCCESS) { 6191090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.lock(); 6192090da73358f71ba026e2474a822fecf55267d166Chris Forbes for (uint32_t i = 0; i < fenceCount; ++i) { 6193090da73358f71ba026e2474a822fecf55267d166Chris Forbes auto pFence = getFenceNode(dev_data, pFences[i]); 6194090da73358f71ba026e2474a822fecf55267d166Chris Forbes if (pFence) { 6195090da73358f71ba026e2474a822fecf55267d166Chris Forbes pFence->state = FENCE_UNSIGNALED; 6196090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6197090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6198090da73358f71ba026e2474a822fecf55267d166Chris Forbes lock.unlock(); 6199090da73358f71ba026e2474a822fecf55267d166Chris Forbes } 6200090da73358f71ba026e2474a822fecf55267d166Chris Forbes 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6204e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis// For given cb_nodes, invalidate them and track object causing invalidation 6205e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlisvoid invalidateCommandBuffers(std::unordered_set<GLOBAL_CB_NODE *> cb_nodes, VK_OBJECT obj) { 6206e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis for (auto cb_node : cb_nodes) { 6207e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->state = CB_INVALID; 6208e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis cb_node->broken_bindings.push_back(obj); 6209e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis } 6210e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis} 6211e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis 621289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 621389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6215b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6216d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis auto fb_node = getFramebuffer(dev_data, framebuffer); 6217d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis if (fb_node) { 6218e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis invalidateCommandBuffers(fb_node->cb_bindings, 6219e1cc7cf9e8a7808209ecc45df2421f3a494dacccTobin Ehlis {reinterpret_cast<uint64_t &>(fb_node->framebuffer), VK_DEBUG_REPORT_OBJECT_TYPE_FRAMEBUFFER_EXT}); 6220d9369e5a41f95b7bd1670240d441dbed58bc36fbTobin Ehlis dev_data->frameBufferMap.erase(fb_node->framebuffer); 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6222b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 62245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 622689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 622789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 62285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6229a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis bool skip = false; 6230e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 6231a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis auto rp_state = getRenderPass(dev_data, renderPass); 6232a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis if (rp_state) { 6233a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis VK_OBJECT obj_struct = {reinterpret_cast<uint64_t &>(renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}; 6234a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis skip |= ValidateObjectNotInUse(dev_data, rp_state, obj_struct); 6235a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis // Any bound cmd buffers are now invalid 6236a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis invalidateCommandBuffers(rp_state->cb_bindings, obj_struct); 6237a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis } 6238a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis if (!skip) { 6239a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis dev_data->renderPassMap.erase(renderPass); 6240a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis lock.unlock(); 6241a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 6242a9fbfe0c622e9fa4b56ddd015ed4c3c409020c2eTobin Ehlis } 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 624589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 624689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 624847892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 624947892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6252b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 6254b5e51047540e12567fbf674b23fe75ca86ca0371Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, unique_ptr<BUFFER_NODE>(new BUFFER_NODE(*pBuffer, pCreateInfo)))); 62555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62598c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateBufferView(layer_data *dev_data, const VkBufferViewCreateInfo *pCreateInfo) { 62608c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 62618c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young BUFFER_NODE *buf_node = getBufferNode(dev_data, pCreateInfo->buffer); 62628c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young // If this isn't a sparse buffer, it needs to have memory backing it at CreateBufferView time 6263b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (buf_node) { 6264b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buf_node, "vkCreateBufferView()"); 6265cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 6266cf64d39a58d4903515232a17eea47ff3ed82faadTobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 626759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, buf_node, 6268b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, 6269b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski false, "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 6270b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski } 62718c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 62728c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 62738c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young 627489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 627589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 62778c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 62788c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateBufferView(dev_data, pCreateInfo); 62798c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 62808c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 62818c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 62825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 62835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62848c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 628539267c0c27b8f032f05a6747eb02d4508247fdc1Tobin Ehlis dev_data->bufferViewMap[*pView] = unique_ptr<BUFFER_VIEW_STATE>(new BUFFER_VIEW_STATE(*pView, pCreateInfo)); 62868c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 629189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 629289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 62935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 629447892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 629547892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 62965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 62975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 63015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 630229e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, unique_ptr<IMAGE_NODE>(new IMAGE_NODE(*pImage, pCreateInfo)))); 63035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 6311b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 63125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63136d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 63146d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 63206d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->levelCount = image_node->createInfo.mipLevels - range->baseMipLevel; 63215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 63246d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis range->layerCount = image_node->createInfo.arrayLayers - range->baseArrayLayer; 63255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 63325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 6333b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 63365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 63376d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 63386d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 63406d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *levels = image_node->createInfo.mipLevels - range.baseMipLevel; 63415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 63436d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis *layers = image_node->createInfo.arrayLayers - range.baseArrayLayer; 63445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63488c07a094dc9cc4afb6b62181f341c12b9e969041Mark Youngstatic bool PreCallValidateCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo) { 63498c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = false; 63508c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young IMAGE_NODE *image_node = getImageNode(dev_data, pCreateInfo->image); 6351b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (image_node) { 63525a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour skip_call |= ValidateImageUsageFlags( 63535a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour dev_data, image_node, VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT | 63545a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 63555a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour false, "vkCreateImageView()", 63565a8cba534d14ce341ba7a2100a542e93f0e3033cTony Barbour "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT|DEPTH_STENCIL_ATTACHMENT|INPUT_ATTACHMENT]_BIT"); 6357b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski // If this isn't a sparse image, it needs to have memory backing it at CreateImageView time 6358b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, image_node, "vkCreateImageView()"); 6359bb6624cb996175d8945190886a200e720b3871efChris Forbes } 63608c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return skip_call; 63618c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6362bb6624cb996175d8945190886a200e720b3871efChris Forbes 636379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlisstatic inline void PostCallRecordCreateImageView(layer_data *dev_data, const VkImageViewCreateInfo *pCreateInfo, VkImageView view) { 636479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis dev_data->imageViewMap[view] = unique_ptr<IMAGE_VIEW_STATE>(new IMAGE_VIEW_STATE(view, pCreateInfo)); 636579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &dev_data->imageViewMap[view].get()->create_info.subresourceRange, pCreateInfo->image); 63668c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young} 6367bb6624cb996175d8945190886a200e720b3871efChris Forbes 63688c07a094dc9cc4afb6b62181f341c12b9e969041Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 63698c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 63708c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63718c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young std::unique_lock<std::mutex> lock(global_lock); 63728c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young bool skip_call = PreCallValidateCreateImageView(dev_data, pCreateInfo); 63738c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 63748c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young if (skip_call) 63758c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young return VK_ERROR_VALIDATION_FAILED_EXT; 63768c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young VkResult result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 63775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 63788c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.lock(); 637979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis PostCallRecordCreateImageView(dev_data, pCreateInfo, *pView); 63808c07a094dc9cc4afb6b62181f341c12b9e969041Mark Young lock.unlock(); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6382bb6624cb996175d8945190886a200e720b3871efChris Forbes 63835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 638689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 638789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 63885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 63895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 63905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6391b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6392a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 63938988ad37ea5a054ff2ae3cbe4b767ae6c13cf48bChris Forbes fence_node.fence = *pFence; 6394a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 6395cdb1ea0ff0d966dda02543468377eae93b9e2f8fChris Forbes fence_node.state = (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) ? FENCE_RETIRED : FENCE_UNSIGNALED; 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 640189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 640289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 640989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 641589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 642289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 64235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 64293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 64303d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 64313d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 64323d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 64333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 64343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64363d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64373d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 64403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 64413d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 64423d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 64433d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64453d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64463d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 64473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 64483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 644989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 645089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 645189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 645289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 64535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 64545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 64585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 645983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 64605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 64625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6465b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 6468ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6469ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 6470fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes pPipeNode[i]->render_pass_ci.initialize(getRenderPass(dev_data, pCreateInfos[i].renderPass)->createInfo.ptr()); 6471c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 647267220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 647383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 64745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 647683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6477b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6480b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 64835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 64845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6485b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 64885188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 64895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6490b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 64915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 64925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 64945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 649689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 649789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 649889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 649989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 65005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 650183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 65025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 65045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 65055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 6508b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 65095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 65115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 65135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 6514ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 6515c8268861aaa8f9c47920065d6323e4609e5081b0Tobin Ehlis pPipeNode[i]->pipeline_layout = *getPipelineLayout(dev_data, pCreateInfos[i].layout); 6516ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 65175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 6519f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes skip_call |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], &dev_data->enabled_features, 652083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->shaderModuleMap); 652183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis // skip_call |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 65225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 652483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 6525b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 65275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 6528b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 65295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 65315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 65325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6533b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 65365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 65375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 65385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6539b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 65405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 65415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 654589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 654689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 65475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 65495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6550b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6551cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 65525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 655689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 655789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 655889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 65595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 65605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 65615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 65625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 6563b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 6564cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 6565cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 65665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 65685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 65695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 65709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 65719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 65729e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 65739e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 65749e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 657583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 65769e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 65779e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 65789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 65799e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 65809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 658183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 65829e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 65839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 65849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 65859e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 65869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 658783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 658883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 658983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "exceeds this device's maxPushConstantSize of %u.", 659083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset, size, maxPushConstantsSize); 65919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 659283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 659383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 65949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 65959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 65969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 65979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 65989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 659983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 66009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 66019e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 66029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 66039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 66049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 660583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 66069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 66079e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 66089e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 66099e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 66109e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 661183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 661283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 66139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 66149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 66159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 66169e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 66179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 661883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 661983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 662083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 662183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, index, offset); 66229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 662383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 662483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 662583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "offset %u. Offset must be a multiple of 4.", 662683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis caller_name, offset); 66279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 662883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 662983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 66309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 66315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 663283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 66335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 663589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 663689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 663783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 66385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66399e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 664007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz uint32_t i, j; 66415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 664283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 664383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 66449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 664583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 664683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 66479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 66489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 664907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if (skip_call) 665007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz return VK_ERROR_VALIDATION_FAILED_EXT; 665107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz 66529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 665307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz // There's no explicit Valid Usage language against this, so issue a warning instead of an error. 665407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 665507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 665607a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 665707a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 665807a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 665907a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 666007a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 666107a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz skip_call |= 666207a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 666307a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 666407a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 666507a398f7c8da45c8286cba4ef33239646ee87dc9Karl Schultz i, minA, maxA, j, minB, maxB); 66669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 66675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6669f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 66705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6672b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 667469b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis plNode.layout = *pPipelineLayout; 6675416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts.resize(pCreateInfo->setLayoutCount); 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 6677416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.set_layouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6679416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges.resize(pCreateInfo->pushConstantRangeCount); 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 6681416bfef833408786b4a17f725b0ed6480bc65120Tobin Ehlis plNode.push_constant_ranges[i] = pCreateInfo->pPushConstantRanges[i]; 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 668789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 668889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 668989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 66915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 66925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6695414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 6705b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 67065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 67105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 671489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 671589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 67165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 67175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 67185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6719b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 67205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 67215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67242c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 6725789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// an allocation request. Fills common_data with the total number of descriptors of each type required, 6726789832b514862c7a7b5b847eeb8e7cacb733b77bTobin Ehlis// as well as DescriptorSetLayout ptrs used for later update. 67277f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 67287f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData *common_data) { 67297e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All state checks for AllocateDescriptorSets is done in single function 6730e3f7c45fd64a44a67ce96c89e2bbee426c6ecf24Tobin Ehlis return cvdescriptorset::ValidateAllocateDescriptorSets(dev_data->report_data, pAllocateInfo, dev_data, common_data); 67317e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis} 67327e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis// Allocation state was good and call down chain was made so update state based on allocating descriptor sets 67337e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlisstatic void PostCallRecordAllocateDescriptorSets(layer_data *dev_data, const VkDescriptorSetAllocateInfo *pAllocateInfo, 67347f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis VkDescriptorSet *pDescriptorSets, 67357f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis const cvdescriptorset::AllocateDescriptorSetsData *common_data) { 67367e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis // All the updates are contained in a single cvdescriptorset function 67372c59c1d90b22aa759d785e4233e468616990ff92Tobin Ehlis cvdescriptorset::PerformAllocateDescriptorSets(pAllocateInfo, pDescriptorSets, common_data, &dev_data->descriptorPoolMap, 6738b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis &dev_data->setMap, dev_data); 67392c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 67402c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 674189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 674289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 67435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6744b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67457f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis cvdescriptorset::AllocateDescriptorSetsData common_data(pAllocateInfo->descriptorSetCount); 67467f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis bool skip_call = PreCallValidateAllocateDescriptorSets(dev_data, pAllocateInfo, &common_data); 6747b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6748d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 67497e73e5c6b3020b96a821985f73012f2af0f1b992Tobin Ehlis if (skip_call) 67505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 6751d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 67525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 67536511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 67545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6755b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 67567f61868b44f1da1dfa6a4ff726020411db92ce0dTobin Ehlis PostCallRecordAllocateDescriptorSets(dev_data, pAllocateInfo, pDescriptorSets, &common_data); 6757b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 67585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 67605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6761cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 6762cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6763cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6764cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 6765cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 6766cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 6767cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 6768cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6769cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 6770cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 6771cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 6772cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 6773cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 6774cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 6775cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 6776cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6777cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 6778cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 6779cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 6780cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6781cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6782cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6783cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6784cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6785cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6786cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6787cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6788cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6789cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6790cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6791cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6792cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6793cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6794cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6795cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6796cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6797cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6798cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 680089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 680189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 68025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6804b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 680583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6806b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6807e1a3be272f365a7d75f9cc1338d2eebafbf1e6cdTobin Ehlis 680883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6812b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6813cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6814b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68186b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 68196b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 68206b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 68216b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 68226b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 68236b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 68246b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 68256b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 68266b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 68276b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 68286b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 68296b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 68306b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 68316b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 6832104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data, descriptorWriteCount, pDescriptorWrites, 6833104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis descriptorCopyCount, pDescriptorCopies); 68346b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 68356b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 68366b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 68376b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 68386b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 6839104ab082916e41467ef60baaab7a5a8b2e02c59cTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 68406b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 68416b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 684389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 684489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 684589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 68466b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6848b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68496b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 68506b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6851b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68526b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 68545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 68556b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 68566b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 68576b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 68586b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 686289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 686389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 68645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 68655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6867b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6868cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, pCreateInfo->commandPool); 6869cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes 6870cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (pPool) { 687172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 68725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 6873cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes pPool->commandBuffers.push_back(pCommandBuffer[i]); 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 68775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 68785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68820a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6883b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6888883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis// Add bindings between the given cmd buffer & framebuffer and the framebuffer's children 6889883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlisstatic void AddFramebufferBinding(layer_data *dev_data, GLOBAL_CB_NODE *cb_state, FRAMEBUFFER_NODE *fb_state) { 6890883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis fb_state->cb_bindings.insert(cb_state); 6891883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis for (auto attachment : fb_state->attachments) { 6892883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis auto view_state = attachment.view_state; 6893883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (view_state) { 689403ea795b83fdf0099594808a1a57064dea7f02a1Tobin Ehlis AddCommandBufferBindingImageView(dev_data, cb_state, view_state); 6895883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 6896883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis auto rp_state = getRenderPass(dev_data, fb_state->createInfo.renderPass); 6897883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis if (rp_state) { 6898883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis addCommandBufferBinding( 6899883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis &rp_state->cb_bindings, 6900883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis {reinterpret_cast<uint64_t &>(rp_state->renderPass), VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT}, cb_state); 6901883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 6902883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis } 6903883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis} 6904883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis 690589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 690689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 690783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6909b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 6911f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 6912f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6914a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 691583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 6916a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6917a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6918414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6919a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6920a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 69215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6922f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis clear_cmd_buf_and_mem_references(dev_data, cb_node); 6923f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 69245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 69255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 69265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 692783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 69285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6930414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 69315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6934400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 693583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 69365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 69375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6938414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 69395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6941400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 694283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 694383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 694483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 694583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 694683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "valid framebuffer parameter is specified.", 694783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6950f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6951f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6952a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((framebuffer->createInfo.renderPass != pInfo->renderPass) && 6953a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis !verify_renderpass_compatibility(dev_data, framebuffer->renderPassCreateInfo.ptr(), 6954fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes getRenderPass(dev_data, pInfo->renderPass)->createInfo.ptr(), 6955a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis errorString)) { 6956400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 695783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 6958a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6959a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 6960a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 6961a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command " 6962a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6963a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 6964a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<void *>(commandBuffer), reinterpret_cast<const uint64_t &>(pInfo->renderPass), 6965a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<const uint64_t &>(pInfo->framebuffer), 6966a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(framebuffer->createInfo.renderPass), errorString.c_str()); 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6968883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 6969883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6974f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes dev_data->enabled_features.occlusionQueryPrecise == VK_FALSE) && 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 697683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 697783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 697883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 697983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 698083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 698183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "support precise occlusion queries.", 698283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 698616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 698716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 6988fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (pInfo->subpass >= renderPass->createInfo.subpassCount) { 698983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 699083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 699183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 699283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 699383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "that is less than the number of subpasses (%d).", 6994fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->createInfo.subpassCount); 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6999f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (CB_RECORDING == cb_node->state) { 700083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 7003414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 7006f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis } else if (CB_RECORDED == cb_node->state || (CB_INVALID == cb_node->state && CMD_END == cb_node->cmds.back().type)) { 7007f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis VkCommandPool cmdPool = cb_node->createInfo.commandPool; 7008cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7009cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 701083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7013414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 7014414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 7021f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->state = CB_RECORDING; 7022f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo = *pBeginInfo; 7023f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node->beginInfo.pInheritanceInfo) { 7024f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->inheritanceInfo = *(cb_node->beginInfo.pInheritanceInfo); 7025f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->beginInfo.pInheritanceInfo = &cb_node->inheritanceInfo; 7026888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 7027f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 7028f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis (cb_node->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7029f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = getRenderPass(dev_data, cb_node->beginInfo.pInheritanceInfo->renderPass); 7030f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = cb_node->beginInfo.pInheritanceInfo->subpass; 7031f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(cb_node->beginInfo.pInheritanceInfo->framebuffer); 7032888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 70335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 703583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 703683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 703783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 70385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7039b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 704083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 70415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 70425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 7044400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 70455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 704889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 704983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 70505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 70515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7052b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7055fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 7056fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 7057fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 705883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 7059fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 706083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 706283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 706383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 706483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 706583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(query.pool), query.index); 70665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 706883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 7071b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 70725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 70735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 70745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 70755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 70775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 70805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7081b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 70825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 70835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 708589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 708689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 7087bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 70885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7089b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 70905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 70915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 7092cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes auto pPool = getCommandPoolNode(dev_data, cmdPool); 7093cd9a648074f67a1d44c15a056b90fc66da8ead17Chris Forbes if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & pPool->createFlags)) { 7094bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 7095bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 7096414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 7097bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 7098bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7100a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes skip_call |= checkCommandBufferInFlight(dev_data, pCB, "reset"); 7101b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7102bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 71035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 71055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 7106b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 7107a964cad279f9749cd9ebfc7555247ff3bff26d53Chris Forbes dev_data->globalInFlightCmdBuffers.erase(commandBuffer); 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 7109b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 71125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 711393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 711489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 711589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 711683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7118b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 712183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 71225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 712383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 71245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 71255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 7126414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 7127ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 71285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 71305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 71315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 71325c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_node = pPN; 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 71343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 71355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 713683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 713783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 713883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 71395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7140a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis addCommandBufferBinding(&getPipeline(dev_data, pipeline)->cb_bindings, 7141a86b57cf1145ee63d5997547ac0f9847933fc3b6Tobin Ehlis {reinterpret_cast<uint64_t &>(pipeline), VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT}, pCB); 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7143b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 714483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 714889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 714989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 715083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7152b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 715583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 7156b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->viewportMask |= ((1u<<viewportCount) - 1u) << firstViewport; 71575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7158b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 715983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 71615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 716389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 716489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 716583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 71665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7167b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 717083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 7171b0df98f4fa837a06691c1e3c05b4ed21c7e2d014Chris Forbes pCB->scissorMask |= ((1u<<scissorCount) - 1u) << firstScissor; 71725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7173b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 717483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 71755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 71765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 717889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 7179a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 71805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7181b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7184a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 7186a27508babf63d50aea75883a3702979193c23683Mark Young 71875c288f35b2eab0dab95d18768235fef6ffd69b30Tobin Ehlis PIPELINE_NODE *pPipeTrav = pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_node; 7188a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 7189a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 7190a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 7191386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 7192a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 7193a27508babf63d50aea75883a3702979193c23683Mark Young } else { 7194a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 7195a27508babf63d50aea75883a3702979193c23683Mark Young } 71965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7197b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7198a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 71995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 72005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 720289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 720389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 720483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7206b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 720983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 72105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 72115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7212b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 721383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 72155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 72165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 721889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 721983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7221b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 722483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 72253d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7227b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 722883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 72305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 723289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 723389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 723483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7236b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 723983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 72405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 72415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7242b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 724383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 72455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 724789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 724889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 724983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7251b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 725483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 72555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 72565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7257b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 725883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 726289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 726389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 726483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7266b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 726983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7272b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 727383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 727789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 727889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 727983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7281b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 728483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7287b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 728883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 729289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 729389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 729489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 729589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 729683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 7302787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 7303787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 7304787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 7305787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 7306dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 730772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 7308dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 7309dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 731071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 731169b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis auto pipeline_layout = getPipelineLayout(dev_data, layout); 7312787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 7313397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 7314787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 731569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline_layout = *pipeline_layout; 731671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 731783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 731883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 731983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 732083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 7321397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 732283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 732383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 732483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 732583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "DS 0x%" PRIxLEAST64 732683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 732783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 7328787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7329787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 733069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, pipeline_layout, i + firstSet, errorString)) { 733183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 733283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 733383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 733483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 733583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 733683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 7337787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7338dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7339dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 7340dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7341dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 7342dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7343dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 7344787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 7345dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 734683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 7347787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7348787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 7349787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 7350414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 7351787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 7352787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 7353397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 7354787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 7355787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 7356787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 7357787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 7358397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 7359397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 7360787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7361787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7362b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 736383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7364787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7365787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7366787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 7367787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7368414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 7369787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7370b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 7371787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 7372787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 7373397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 7374787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 7375787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 7376b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 737783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 7378787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 7379787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 7380787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 7381787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 7382414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 7383787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 7384b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 73855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7386787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 73875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7389dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 7390dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 7391dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 7392dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 7393787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 7394dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 7395dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 73965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7398787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 739983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 740083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 740183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 740283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pDescriptorSets[i]); 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 740483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 740572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 740672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 740772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 740872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 740971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 741069b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis pipeline_layout, i, errorString)) { 741183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 741272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 741372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 741472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 7415414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 7416414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 741772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 741872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 741972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 742072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 742172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 742272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 742372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 742472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 742569b71d9c89447ec87d823669ee9edbfc58af174aTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, pipeline_layout, lastSetIndex, errorString)) { 742671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 742783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 742872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 742971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 7430414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 7431414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 743272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 7433414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 743471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 743572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 743672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 743772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 74385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7441787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 7442787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 744383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 744483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 744583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 744683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 744783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 744883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 7449787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 745183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 74525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7454b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 745583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 74565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 74575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 746089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 746189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 746283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7464593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 7465b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7466b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 7467ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 74689f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7469ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7470b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7471ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7472f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindIndexBuffer()"); 7473ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 74749f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 747583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 74875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 748983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 749083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 749183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 749283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis offset, string_VkIndexType(indexType)); 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->status |= CBSTATUS_INDEX_BUFFER_BOUND; 7495ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7496ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7498b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 749983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 75075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7513e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 751589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 751689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 751789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 751883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7520593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 7521b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7522b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski 75239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 75249f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis if (cb_node) { 7525593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 7526ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, pBuffers[i]); 7527ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7528b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7529ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7530f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, buff_node, "vkCmdBindVertexBuffers()"); 7531ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 75329f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75349f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis addCmd(dev_data, cb_node, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 75359f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis updateResourceTracking(cb_node, firstBinding, bindingCount, pBuffers); 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 753783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7539b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 754083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7544b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 7545e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 75477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 75487a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 754979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, imageView); 755079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 7552249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 755379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto img_node = getImageNode(dev_data, view_state->create_info.image); 7554249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(img_node); 7555e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7556f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 7557e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 75587a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 75597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 75607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 75617a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 7562ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7563ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(buff_node); 7564e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7565f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, buff_node, true); 7566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 75677a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 75687a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 75695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 757389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 757489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 757583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7577b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 758083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 7582e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDraw"); 758383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 758583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7587414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 758883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 758983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 759283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7594b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 759583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 759989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 760089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 760383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7604b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 760783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 7609e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexed"); 761083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 761283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 761383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 761483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 761583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 761683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 761983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 76205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7621b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 762283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 76245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 762789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 762889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 763083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 7631b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7632ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7633ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7634ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7635ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7636b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndirect()"); 7637c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7638ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 7639ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDIRECT]++; 7640e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndirect"); 7641ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 764383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 764483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 764583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 764683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 764783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7648ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7650b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndirect()"); 7651ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7652ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7654b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 765583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 765989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 766089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 766183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7663b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7664ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7665ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7666ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7667ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && buff_node) { 7668b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDrawIndexedIndirect()"); 7669c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7670ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 7671ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->drawCount[DRAW_INDEXED_INDIRECT]++; 7672e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7673e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, true, VK_PIPELINE_BIND_POINT_GRAPHICS, "vkCmdDrawIndexedIndirect"); 7674ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 76755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 767683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 7678414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 768083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= synchAndPrintDSConfig(dev_data, commandBuffer); 768183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 7682ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis updateResourceTrackingOnDraw(cb_node); 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7684b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, cb_node, "vkCmdDrawIndexedIndirect()"); 7685ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7686ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7688b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 768983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 769389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 769483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7696b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 7699e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatch"); 770083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 770183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 770283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7704b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 770583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 770989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 771089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 771183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7714ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7715ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7716ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto buff_node = getBufferNode(dev_data, buffer); 7717b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski if (cb_node && buff_node) { 7718b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, buff_node, "vkCmdDispatchIndirect()"); 7719c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, buff_node); 7720e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski skip_call |= 7721e7f1fab24ce4b59bce87246a510b7e52638f83d0Mark Lobodzinski validate_and_update_draw_state(dev_data, cb_node, false, VK_PIPELINE_BIND_POINT_COMPUTE, "vkCmdDispatchIndirect"); 7722ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= markStoreImagesAndBuffersAsWritten(dev_data, cb_node); 7723ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 7724b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdDispatchIndirect()"); 77255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7726b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 772783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 773189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 773289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 773383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 77345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7735b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7736ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 77379f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 7738ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 7739ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 7740ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && src_buff_node && dst_buff_node) { 7741b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7742b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyBuffer()"); 7743ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffers and cmd buffer 7744c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 7745c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 7746ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 774759b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBuffer()", 7748ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 774959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBuffer()", 7750ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7751ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 7752ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::function<bool()> function = [=]() { 7753f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBuffer()"); 7754ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis }; 77559f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7756593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7757f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 7758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 77595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 77609f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 7761593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 776283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 7763b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBuffer()"); 7764ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 7765ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Param_checker will flag errors on invalid objects, just assert here as debugging aid 7766ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 77675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7768b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 776983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 777327e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifySourceImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage srcImage, 777427e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout srcImageLayout) { 7775e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 77765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 77785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 77795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 77805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 778127e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, srcImage, sub, node)) { 778227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 77835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 77865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 77875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 77895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 779607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // TODO : Can we deal with image node from the top of call tree and avoid map look-up here? 779707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, srcImage); 779807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 779907b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 780007b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 780107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 780207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 780307b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 78045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 78075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 78085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 78095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 781427e2917587adf1738c71851a128806f7de578cbeTobin Ehlisstatic bool VerifyDestImageLayout(layer_data *dev_data, GLOBAL_CB_NODE *cb_node, VkImage destImage, 781527e2917587adf1738c71851a128806f7de578cbeTobin Ehlis VkImageSubresourceLayers subLayers, VkImageLayout destImageLayout) { 7816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 78175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 78195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 78205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 78215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 782227e2917587adf1738c71851a128806f7de578cbeTobin Ehlis if (!FindLayout(cb_node, destImage, sub, node)) { 782327e2917587adf1738c71851a128806f7de578cbeTobin Ehlis SetLayout(cb_node, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 78245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 78255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 78275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 78285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 78295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 78305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 78315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 78325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 78355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 783607b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis auto image_node = getImageNode(dev_data, destImage); 783707b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis if (image_node->createInfo.tiling != VK_IMAGE_TILING_LINEAR) { 783807b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 783907b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 784007b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 784107b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 784207b081bc51bf0151b7d2074967b948c02961c166Tobin Ehlis } 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 78465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 78515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 78539ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if two VkExtent3D structs are equivalent 78549ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentEqual(const VkExtent3D *extent, const VkExtent3D *other_extent) { 78559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool result = true; 78569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((extent->width != other_extent->width) || (extent->height != other_extent->height) || 78579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (extent->depth != other_extent->depth)) { 78589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano result = false; 78599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 78609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return result; 78619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 78629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 78639ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image extent of a specific subresource. 78649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline VkExtent3D GetImageSubresourceExtent(const IMAGE_NODE *img, const VkImageSubresourceLayers *subresource) { 78659ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t mip = subresource->mipLevel; 78669ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D extent = img->createInfo.extent; 786790b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.width = std::max(1U, extent.width >> mip); 786890b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.height = std::max(1U, extent.height >> mip); 786990b7c8c094c263b33382ff4756f2a23f484e8400Gregory Mitrano extent.depth = std::max(1U, extent.depth >> mip); 78709ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return extent; 78719ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 78729ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 78739ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test if the extent argument has all dimensions set to 0. 78749ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentZero(const VkExtent3D *extent) { 78759ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return ((extent->width == 0) && (extent->height == 0) && (extent->depth == 0)); 78769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 78779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 78789ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Returns the image transfer granularity for a specific image scaled by compressed block size if necessary. 78799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline VkExtent3D GetScaledItg(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const IMAGE_NODE *img) { 78809ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // Default to (0, 0, 0) granularity in case we can't find the real granularity for the physical device. 78819ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = { 0, 0, 0 }; 7882f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski auto pPool = getCommandPoolNode(dev_data, cb_node->createInfo.commandPool); 7883f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski if (pPool) { 78849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity = dev_data->phys_dev_properties.queue_family_properties[pPool->queueFamilyIndex].minImageTransferGranularity; 78859ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_format_is_compressed(img->createInfo.format)) { 78869ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano auto block_size = vk_format_compressed_block_size(img->createInfo.format); 78879ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.width *= block_size.width; 78889ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity.height *= block_size.height; 7889f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7890f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 78919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano return granularity; 78929ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano} 78939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano 78949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano// Test elements of a VkExtent3D structure against alignment constraints contained in another VkExtent3D structure 78959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool IsExtentAligned(const VkExtent3D *extent, const VkExtent3D *granularity) { 78969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano bool valid = true; 78979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((vk_safe_modulo(extent->depth, granularity->depth) != 0) || (vk_safe_modulo(extent->width, granularity->width) != 0) || 78989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano (vk_safe_modulo(extent->height, granularity->height) != 0)) { 78999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano valid = false; 79009ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7901f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return valid; 7902f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7903f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7904f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkOffset3D structure against a queue family's Image Transfer Granularity values 79059ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgOffset(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkOffset3D *offset, 79069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkExtent3D *granularity, const uint32_t i, const char *function, const char *member) { 7907f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 79089ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent = {}; 79099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.width = static_cast<uint32_t>(abs(offset->x)); 79109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.height = static_cast<uint32_t>(abs(offset->y)); 79119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent.depth = static_cast<uint32_t>(abs(offset->z)); 79129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 79139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the offset must always be (0, 0, 0) 79149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(&offset_extent) == false) { 79159ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79169ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79179ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) must be (x=0, y=0, z=0) " 79189ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 79199ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z); 79209ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 79219ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 79229ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the offset dimensions must always be even 79239ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity. 79249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentAligned(&offset_extent, granularity) == false) { 79259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (x=%d, y=%d, z=%d) dimensions must be even integer " 79289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "multiples of this command buffer's queue family image transfer granularity (w=%d, h=%d, d=%d).", 79299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, offset->x, offset->y, offset->z, granularity->width, granularity->height, 79309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth); 79319ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7932f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7933f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7934f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7935f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7936f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check elements of a VkExtent3D structure against a queue family's Image Transfer Granularity values 79379ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgExtent(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkExtent3D *extent, 79389ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const VkOffset3D *offset, const VkExtent3D *granularity, const VkExtent3D *subresource_extent, 79399ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function, const char *member) { 7940f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 79419ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentZero(granularity)) { 79429ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is (0, 0, 0), then the extent must always match the image 79439ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent. 79449ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (IsExtentEqual(extent, subresource_extent) == false) { 79459ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79469ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79479ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d) " 79489ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "when the command buffer's queue family image transfer granularity is (w=0, h=0, d=0).", 79499ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, subresource_extent->width, 79509ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->height, subresource_extent->depth); 79519ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 79529ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } else { 79539ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // If the queue family image transfer granularity is not (0, 0, 0), then the extent dimensions must always be even 79549ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // integer multiples of the image transfer granularity or the offset + extent dimensions must always match the image 79559ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano // subresource extent dimensions. 79569ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D offset_extent_sum = {}; 79579ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.width = static_cast<uint32_t>(abs(offset->x)) + extent->width; 79589ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.height = static_cast<uint32_t>(abs(offset->y)) + extent->height; 79599ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano offset_extent_sum.depth = static_cast<uint32_t>(abs(offset->z)) + extent->depth; 79609ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if ((IsExtentAligned(extent, granularity) == false) && (IsExtentEqual(&offset_extent_sum, subresource_extent) == false)) { 79619ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= 79629ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7963f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79649ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (w=%d, h=%d, d=%d) dimensions must be even integer multiples of this command buffer's " 79659ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "queue family image transfer granularity (w=%d, h=%d, d=%d) or offset (x=%d, y=%d, z=%d) + " 79669ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent (w=%d, h=%d, d=%d) must match the image subresource extents (w=%d, h=%d, d=%d).", 79679ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, extent->width, extent->height, extent->depth, granularity->width, granularity->height, 79689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano granularity->depth, offset->x, offset->y, offset->z, extent->width, extent->height, extent->depth, 79699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano subresource_extent->width, subresource_extent->height, subresource_extent->depth); 79709ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano } 7971f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7972f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7973f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7974f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7975f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a uint32_t width or stride value against a queue family's Image Transfer Granularity width value 79769ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgInt(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const uint32_t value, 79779ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 7978f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 79799ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 7980f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7981f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79829ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%d) must be an even integer multiple of this command buffer's queue family image " 79839ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "transfer granularity width (%d).", 79849ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 7985f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 7986f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 7987f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 7988f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 7989f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check a VkDeviceSize value against a queue family's Image Transfer Granularity width value 79909ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitranostatic inline bool CheckItgSize(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const VkDeviceSize value, 79919ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t granularity, const uint32_t i, const char *function, const char *member) { 7992f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 79939ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano if (vk_safe_modulo(value, granularity) != 0) { 79949ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 79959ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano DRAWSTATE_IMAGE_TRANSFER_GRANULARITY, "DS", 79969ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "%s: pRegion[%d].%s (%" PRIdLEAST64 79979ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano ") must be an even integer multiple of this command buffer's queue family image transfer " 79989ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "granularity width (%d).", 79999ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, i, member, value, granularity); 8000f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski } 8001f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8002f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8003f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8004f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkImageCopy structure 8005f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 80069ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const IMAGE_NODE *img, const VkImageCopy *region, 80079ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8008f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 80099ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 80109ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->srcOffset, &granularity, i, function, "srcOffset"); 80119ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->dstOffset, &granularity, i, function, "dstOffset"); 80129ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->dstSubresource); 80139ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->extent, ®ion->dstOffset, &granularity, &subresource_extent, i, function, 80149ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "extent"); 8015f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8016f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8017f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 8018f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski// Check valid usage Image Tranfer Granularity requirements for elements of a VkBufferImageCopy structure 8019f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinskistatic inline bool ValidateCopyBufferImageTransferGranularityRequirements(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, 80209ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const IMAGE_NODE *img, const VkBufferImageCopy *region, 80219ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano const uint32_t i, const char *function) { 8022f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski bool skip = false; 80239ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D granularity = GetScaledItg(dev_data, cb_node, img); 80249ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgSize(dev_data, cb_node, region->bufferOffset, granularity.width, i, function, "bufferOffset"); 80259ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferRowLength, granularity.width, i, function, "bufferRowLength"); 80269ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgInt(dev_data, cb_node, region->bufferImageHeight, granularity.width, i, function, "bufferImageHeight"); 80279ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgOffset(dev_data, cb_node, ®ion->imageOffset, &granularity, i, function, "imageOffset"); 80289ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano VkExtent3D subresource_extent = GetImageSubresourceExtent(img, ®ion->imageSubresource); 80299ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip |= CheckItgExtent(dev_data, cb_node, ®ion->imageExtent, ®ion->imageOffset, &granularity, &subresource_extent, i, 80309ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano function, "imageExtent"); 8031f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski return skip; 8032f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski} 8033f7f74f870488f026061dec2d4d3c3329a25d4dcdMark Lobodzinski 803489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 803589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 803689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 803783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8039b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8040249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 80419f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8042249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8043249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8044249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 8045b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImage()"); 8046b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyImage()"); 8047249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 8048c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8049c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 8050249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 805159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImage()", 8052ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 805359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImage()", 8054ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 8055f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImage()"); }; 80569f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8057593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8058f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8059e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 80619f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8062593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 806383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGE, "vkCmdCopyImage()"); 8064b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImage()"); 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 806627e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].srcSubresource, srcImageLayout); 806727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].dstSubresource, dstImageLayout); 80689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyImageTransferGranularityRequirements(dev_data, cb_node, dst_img_node, &pRegions[i], i, 80699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyImage()"); 80705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8071249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8072249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 80735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8074b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 807583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 80765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 80775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 80785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8080eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski// Validate that an image's sampleCount matches the requirement for a specific API call 8081eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinskistatic inline bool ValidateImageSampleCount(layer_data *dev_data, IMAGE_NODE *image_node, VkSampleCountFlagBits sample_count, 8082eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski const char *location) { 8083eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski bool skip = false; 8084eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski if (image_node->createInfo.samples != sample_count) { 8085eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 8086eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 0, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 8087eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski "%s for image 0x%" PRIxLEAST64 " was created with a sample count of %s but must be %s.", location, 8088eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski reinterpret_cast<uint64_t &>(image_node->image), 8089eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski string_VkSampleCountFlagBits(image_node->createInfo.samples), string_VkSampleCountFlagBits(sample_count)); 8090eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski } 8091eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski return skip; 8092eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski} 8093eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski 809489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 809589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 809689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 809783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 80985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8099b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8100593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 81019f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8102249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8103249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8104249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 8105eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): srcImage"); 8106eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdBlitImage(): dstImage"); 8107b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdBlitImage()"); 8108b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdBlitImage()"); 8109249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 8110c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8111c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 8112249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC & DST images have correct usage flags set 811359b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdBlitImage()", 8114ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 811559b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdBlitImage()", 8116ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 8117f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis std::function<bool()> function = [=]() { return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdBlitImage()"); }; 81189f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8120f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8121e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 81239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8124593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 812583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BLITIMAGE, "vkCmdBlitImage()"); 8126b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBlitImage()"); 8127249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8128249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 81295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8130b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 813183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 81335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 81345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 813689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 813789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 813889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 813983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8141b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8142593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 81439f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8144ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto src_buff_node = getBufferNode(dev_data, srcBuffer); 8145249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8146249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_buff_node && dst_img_node) { 8147eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, dst_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyBufferToImage(): dstImage"); 8148b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); 8149b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdCopyBufferToImage()"); 8150c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, src_buff_node); 8151c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 815259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, src_buff_node, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 8153ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyBufferToImage()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 815459b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, dst_img_node, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 8155ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyBufferToImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 8156e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8157f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8158e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 81609f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8161f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis function = [=]() { return ValidateBufferMemoryIsValid(dev_data, src_buff_node, "vkCmdCopyBufferToImage()"); }; 81629f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8163593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 816483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 8165b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyBufferToImage()"); 81665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 816727e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifyDestImageLayout(dev_data, cb_node, dstImage, pRegions[i].imageSubresource, dstImageLayout); 81689ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, dst_img_node, &pRegions[i], i, 81699ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "vkCmdCopyBufferToImage()"); 81705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8171ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8172ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8174b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 817583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 81775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 81785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 818089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 818189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 818289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 818383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 81845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8185b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8186593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 81879f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8188249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8189ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8190249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_buff_node) { 8191eebf670a2f04c402f2875f85aa4f889b06db48fcMark Lobodzinski skip_call |= ValidateImageSampleCount(dev_data, src_img_node, VK_SAMPLE_COUNT_1_BIT, "vkCmdCopyImageToBuffer(): srcImage"); 8192b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 8193b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyImageToBuffer()"); 8194249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between buffer/image and cmd buffer 8195c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8196c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8197249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Validate that SRC image & DST buffer have correct usage flags set 819859b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateImageUsageFlags(dev_data, src_img_node, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 8199ff97b06aed7555ae043b3920bdfbd36b31498d89Tobin Ehlis "vkCmdCopyImageToBuffer()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 820059b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8201ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyImageToBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8202e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8203f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdCopyImageToBuffer()"); 8204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 82059f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8206593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8207f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8208e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82109f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8211593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 821283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 8213b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyImageToBuffer()"); 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 821527e2917587adf1738c71851a128806f7de578cbeTobin Ehlis skip_call |= VerifySourceImageLayout(dev_data, cb_node, srcImage, pRegions[i].imageSubresource, srcImageLayout); 82169ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano skip_call |= ValidateCopyBufferImageTransferGranularityRequirements(dev_data, cb_node, src_img_node, &pRegions[i], i, 82179ecb1daf727b16dfa6a26236bd93cd75f4d12696Gregory Mitrano "CmdCopyImageToBuffer"); 82185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8219ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8220ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8222b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 822383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 82255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 822889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 822989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 823083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8232b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8233593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 82349f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8235ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8236ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8237b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdUpdateBuffer()"); 8238ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8239c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8240ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 824159b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 8242ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdUpdateBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8243e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8244f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8245e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82479f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8248593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 824983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 8250b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyUpdateBuffer()"); 8251ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8252ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8254b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 825583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 825989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 826089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 826183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8263b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8264593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 82659f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8266ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 8267ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 8268b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdFillBuffer()"); 8269ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 8270c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 8271ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 827259b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 8273ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 8274e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8275f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 8276e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 82789f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8279593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 828083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 8281b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyFillBuffer()"); 8282ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 8283ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 828683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 829089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 829189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 829289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 829383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8295b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 829883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 83035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 83045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 83055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 830683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 8307a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t &>(commandBuffer), 8308a1a137ec383fef3881f86d4c202b1de56a91edf0Chris Forbes 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 830983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 831083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 831183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)(commandBuffer)); 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8313b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments()"); 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 8318fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->createInfo.ptr(); 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 83241710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes if (attachment->colorAttachment >= pSD->colorAttachmentCount) { 832583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 832621a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 83281710af939cd452f3c02e93f598f20e5e12eb6c3bChris Forbes "vkCmdClearAttachments() color attachment index %d out of range for active subpass %d; ignored", 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8331dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes else if (pSD->pColorAttachments[attachment->colorAttachment].attachment == VK_ATTACHMENT_UNUSED) { 8332dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes skip_call |= log_msg( 833321a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 8334dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 8335dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes "vkCmdClearAttachments() color attachment index %d is VK_ATTACHMENT_UNUSED; ignored", 8336dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes attachment->colorAttachment); 8337dd2e11f29131ab2a77ccb9ae0c4c5c3bcf95c1d5Chris Forbes } 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 834383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 834421a714edaf9b670a60102430c36b221ff27f0f25Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 83467386605ae0fe78241c997605a843bdc9a5499e2bChris Forbes "vkCmdClearAttachments() depth/stencil clear with no depth/stencil attachment in subpass; ignored"); 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8351b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 835283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 835689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 835789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 835889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 835983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8361b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8363249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 83649f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8365249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8366249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8367b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearColorImage()"); 8368c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8370f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 83739f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8374593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 837583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 8376b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearColorImage()"); 8377249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8378249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8380b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 838183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 83835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 838589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 838689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 838789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 838889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 838983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8391b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 83925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 8393249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 83949f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8395249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto img_node = getImageNode(dev_data, image); 8396249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && img_node) { 8397b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, img_node, "vkCmdClearDepthStencilImage()"); 8398c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, img_node); 8399e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8400f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, img_node, true); 8401e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84039f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8404593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 840583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 8406b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdClearDepthStencilImage()"); 8407249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8408249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8410b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 841183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 841689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 841789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 841889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 841983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8421b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 8422593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 84239f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 8424249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto src_img_node = getImageNode(dev_data, srcImage); 8425249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis auto dst_img_node = getImageNode(dev_data, dstImage); 8426249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis if (cb_node && src_img_node && dst_img_node) { 8427b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, src_img_node, "vkCmdResolveImage()"); 8428b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToImage(dev_data, dst_img_node, "vkCmdResolveImage()"); 8429249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis // Update bindings between images and cmd buffer 8430c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, src_img_node); 8431c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingImage(dev_data, cb_node, dst_img_node); 8432e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 8433f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, src_img_node, "vkCmdResolveImage()"); 8434593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 84359f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8436593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 8437f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, dst_img_node, true); 8438e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 84395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 84409f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 8441593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 844283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 8443b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdResolveImage()"); 8444249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis } else { 8445249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis assert(0); 84465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8447b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 844883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 84515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8453b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 8454b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8455b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8456b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 8457b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 8458b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8459b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8460b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 8461b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 8462b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8463b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 8464b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8465b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 846689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 846789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 846883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8470b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 84715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 84725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 847383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 847483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 8475ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8476ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8477ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8478ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8479ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8480ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8482c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8483c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8484c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8485b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8486b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 8487b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8489b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 849083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 84915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 849489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 849589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 849683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8498b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 850183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 850283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 8503ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, event); 8504ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8505ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8506ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<uint64_t &>(event), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, pCB); 8507ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8508ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 85095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 8510c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 8511c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 8512c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 8513b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 8514b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 8515b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 85165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8517b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 851883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8522e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 8526e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 854508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 854608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 85475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 85485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 85515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 85525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 85535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 85545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 85555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 85565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 85585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 85625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 8565e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 85675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 85685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 85705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 85765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 85775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 85825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 85855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 8587e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8588e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 8589e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 8590e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 85915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 859343986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 85945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 85955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 85965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8597577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 86026044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86156044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8626e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 8627e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 8628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 86315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 86495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 86505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 86515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 86545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 86555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 86565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 86595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 86605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 86635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 86645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 86655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 86665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8667577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 86685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 86695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 86715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 86735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 86745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 86765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 86775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8678e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 8679e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 8680e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 8681e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 8682e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 86835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 86845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 86855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 8686ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 86875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 86885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 86895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 86905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 86915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 86945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 86956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 86966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 86975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 86985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 86996d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 87005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 87015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 87025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 87035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 87055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 87065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 87075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 87085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 87095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 87115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 87125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 87135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 87145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 87155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 87165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 87175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 87195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 87205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 87215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 87225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 87235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 8724b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 8725b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 87265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 87275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 87285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 87295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 87305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 87315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 87325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 8733b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 87345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 87385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 87395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 87405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 87415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 87425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87496d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_data = getImageNode(dev_data, mem_barrier->image); 87501d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 87511d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 87536d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data) { 87546d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis format = image_data->createInfo.format; 87556d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis arrayLayers = image_data->createInfo.arrayLayers; 87566d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis mipLevels = image_data->createInfo.mipLevels; 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 8759170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis auto imageswap_data = getSwapchainFromImage(dev_data, mem_barrier->image); 8760170dc65b45f6bcdec47e02b3aa19435e55b32804Tobin Ehlis if (imageswap_data) { 8761b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, imageswap_data); 8762b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 8763b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis format = swapchain_data->createInfo.imageFormat; 8764b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis arrayLayers = swapchain_data->createInfo.imageArrayLayers; 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 8771c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis auto aspect_mask = mem_barrier->subresourceRange.aspectMask; 8772c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_or_stencil(format)) { 8773c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (vk_format_is_depth_and_stencil(format)) { 8774c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT) && !(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8775c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8776c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", 8777c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "%s: Image is a depth and stencil format and thus must " 8778c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have either one or both of VK_IMAGE_ASPECT_DEPTH_BIT and " 8779c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 8780c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8781c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8782c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else if (vk_format_is_depth_only(format)) { 8783c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT)) { 8784c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8785c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth-only format and thus must " 8786c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_DEPTH_BIT set.", 8787c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8788c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8789c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // stencil-only case 8790a968f468c0aafdf33b7af68fb8e7961e37e32f7fTobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT)) { 8791c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8792c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis __LINE__, DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a stencil-only format and thus must " 8793c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_STENCIL_BIT set.", 8794c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8795c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8796c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 8797c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } else { // image is a color format 8798c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis if (!(aspect_mask & VK_IMAGE_ASPECT_COLOR_BIT)) { 8799c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8800c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a color format and thus must " 8801c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis "have VK_IMAGE_ASPECT_COLOR_BIT set.", 8802c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis funcName); 8803c37c65e9ff3a0abc86e706ee61d21e1dec882731Tobin Ehlis } 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8805f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 8806f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8807f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 8808f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 88095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 88115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8816f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 8817f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 8818f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 8819f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 88205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 88225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 88245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 88255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 88265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8842b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 8844b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 88455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 8850b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88538718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis auto buffer_node = getBufferNode(dev_data, mem_barrier->buffer); 88548718070cf3e206488c168f1e6b9dd06d6880c9bcTobin Ehlis if (buffer_node) { 88550c6dd4dd7c7e444efc979299f8f445fb4fc4febeChris Forbes auto buffer_size = buffer_node->memSize; 88565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 885794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 885894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 885994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 8860414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 886194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 886294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 886494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 886594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8866414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 8867414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 886894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 886994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 887094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 88715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 88772ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 8878b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 8879b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 8880b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 8881b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 88822ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 8883b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 8884b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 8885b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 88862ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 8887b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 8888b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 8889b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 88909556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto global_event_data = getEventNode(dev_data, event); 88919556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (!global_event_data) { 8892b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 889327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 889427c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 88952ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 8896b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 88979556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis stageMask |= global_event_data->stageMask; 8898b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8899b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8900b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8901c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 8902c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 8903c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 8904c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8905c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 89064261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "using srcStageMask 0x%X which must be the bitwise " 8907c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 8908c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 89094261f1e2c91c90ce040ab36a13c9d92f6e988f10Mark Lobodzinski "used with vkSetEvent but instead is 0x%X.", 8910c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 8911b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 8912b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 8913b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 8914b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 891589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 891689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 891789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 891889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 891989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 892083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8922b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89252ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 89265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 8927ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis auto event_node = getEventNode(dev_data, pEvents[i]); 8928ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis if (event_node) { 8929ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis addCommandBufferBinding(&event_node->cb_bindings, 8930ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis {reinterpret_cast<const uint64_t &>(pEvents[i]), VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT}, 8931ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis pCB); 8932ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis event_node->cb_bindings.insert(pCB); 8933ad13b09db50a49347ea6a8c1408fcc5280042898Tobin Ehlis } 8934c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 89355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 89365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8937b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 89382ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 8939b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 89405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 894183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 89425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 894383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 894583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 894683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8950b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 895183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 89525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 89555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 895789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 895889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 895989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 896089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 896189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 896283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8964b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 896783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 896883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 896983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8973b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 897483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 89755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 89785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8980d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 8981d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8982d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 8983d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 8984d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 8985d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8986d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 8987d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 8988d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 8989d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8990d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 8991d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8992d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 899389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 899489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 899583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 89965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8997b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 90015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 90025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 90035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 90045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 900583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 9006ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9007ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9009b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 901083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 90115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 90125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 901489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 901583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 902283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 90235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9024414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 90275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 90285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9029c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9030d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 903283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 903483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 90355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9036ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9037ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 90385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9039b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 904083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 90415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 904489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 904589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 904683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9048b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 9054c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 9055d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 905883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 906083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 906283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 9063ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9064ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, pCB); 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9066b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 906783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 90685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 90695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9071d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 9072d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 9073d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 9074d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 9075d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 9076d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 9077d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 9078d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 9079d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 9080d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 9081d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 9082d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 9083d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9084d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9085d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9086d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 9087d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 9088d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 9089d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9090d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9091d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 9092d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 9093d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9094d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9095d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 9096d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9097d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 9098d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 9099d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 9100d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9101d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 9102d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 9103d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 9104d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 910589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 910689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 910789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 910883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9110b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 9111ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis 91129f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis auto cb_node = getCBNode(dev_data, commandBuffer); 9113ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis auto dst_buff_node = getBufferNode(dev_data, dstBuffer); 9114ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node && dst_buff_node) { 9115b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= ValidateMemoryIsBoundToBuffer(dev_data, dst_buff_node, "vkCmdCopyQueryPoolResults()"); 9116ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Update bindings between buffer and cmd buffer 9117c3eda058338f7ba4e776ec74202b1c95ce6e6220Tobin Ehlis AddCommandBufferBindingBuffer(dev_data, cb_node, dst_buff_node); 9118ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis // Validate that DST buffer has correct usage flags set 911959b0561b0bd298885f90b9f524c0583cd8ee6f61Tobin Ehlis skip_call |= ValidateBufferUsageFlags(dev_data, dst_buff_node, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 9120ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 9121e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 9122f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetBufferMemoryValid(dev_data, dst_buff_node, true); 9123e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 91259f229695cf32913dab3fb75e5d52548ea57b3851Tobin Ehlis cb_node->validate_functions.push_back(function); 9126d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 9127ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis std::bind(validateQuery, std::placeholders::_1, cb_node, queryPool, queryCount, firstQuery); 9128ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis cb_node->queryUpdates.push_back(queryUpdate); 9129ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis if (cb_node->state == CB_RECORDING) { 9130ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 913283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 91335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9134b3c2024e0ed61d7f68630d7eb7c8c03100689bb1Mark Lobodzinski skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdCopyQueryPoolResults()"); 9135ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis addCommandBufferBinding(&getQueryPoolNode(dev_data, queryPool)->cb_bindings, 9136ccdcc9686c664e9407dd03262f3aaf3245b23be2Tobin Ehlis {reinterpret_cast<uint64_t &>(queryPool), VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT}, cb_node); 9137ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis } else { 9138ebc92c86f5a63df6ab4d325f83d385b23c11bf5eTobin Ehlis assert(0); 91395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9140b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 914183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 91435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 914689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 914789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 914889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 914983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9151b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 91545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 915583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 915783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 916083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 91619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 916283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 916383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 91649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 91659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 9166a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 91674a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 916815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 916915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // contained in the pipeline ranges. 917015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Build a {start, end} span list for ranges with matching stage flags. 917115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis const auto &ranges = pipeline_layout->push_constant_ranges; 917215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct span { 917315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t start; 917415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis uint32_t end; 917515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis }; 917615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span> spans; 917715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.reserve(ranges.size()); 917815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (const auto &iter : ranges) { 917915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (iter.stageFlags == stageFlags) { 918015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis spans.push_back({iter.offset, iter.offset + iter.size}); 918115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 918215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 918315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (spans.size() == 0) { 918415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There were no ranges that matched the stageFlags. 918515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 918615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 918715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 918815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 918915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis (uint32_t)stageFlags, (uint64_t)layout); 91909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 919115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Sort span list by start value. 919215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis struct comparer { 919315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool operator()(struct span i, struct span j) { return i.start < j.start; } 919415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } my_comparer; 919515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::sort(spans.begin(), spans.end(), my_comparer); 919615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis 919715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Examine two spans at a time. 919815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator current = spans.begin(); 919915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis std::vector<span>::iterator next = current + 1; 920015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis while (next != spans.end()) { 920115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (current->end < next->start) { 920215a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // There is a gap; cannot coalesce. Move to the next two spans. 920315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++current; 920415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis ++next; 920515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } else { 920615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Coalesce the two spans. The start of the next span 920715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // is within the current span, so pick the larger of 920815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // the end values to extend the current span. 920915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Then delete the next span and set next to the span after it. 921015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis current->end = max(current->end, next->end); 921115a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis next = spans.erase(next); 92129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 92139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 9214a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 921515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis // Now we can check if the incoming range is within any of the spans. 921615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis bool contained_in_a_range = false; 921715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis for (uint32_t i = 0; i < spans.size(); ++i) { 921815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 921915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis contained_in_a_range = true; 922015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis break; 9221a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 92229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 922315a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis if (!contained_in_a_range) { 922415a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis skip_call |= 922515a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 922615a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Push constant range [%d, %d) " 922715a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "with stageFlags = 0x%" PRIx32 " " 922815a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 922915a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 923015a574466ede280b595c451ad52f2b7b18f20b2dTobin Ehlis } 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9232b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 923383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 923789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 923889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 923983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9241b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 9245c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 9246d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 924883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 925083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 92515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9253b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 925483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 92565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 92586600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinskistatic bool MatchUsage(layer_data *dev_data, uint32_t count, const VkAttachmentReference *attachments, 92596600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkFramebufferCreateInfo *fbci, VkImageUsageFlagBits usage_flag) { 92606600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 92616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 92626600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t attach = 0; attach < count; attach++) { 92636600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment != VK_ATTACHMENT_UNUSED) { 92646600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Attachment counts are verified elsewhere, but prevent an invalid access 92656600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (attachments[attach].attachment < fbci->attachmentCount) { 92666600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski const VkImageView *image_view = &fbci->pAttachments[attachments[attach].attachment]; 926779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, *image_view); 926879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_state) { 926979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, view_state->create_info.image)->createInfo; 92706600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (ici != nullptr) { 92716600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if ((ici->usage & usage_flag) == 0) { 92726600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 92736600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_USAGE, "DS", 92746600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "vkCreateFramebuffer: Framebuffer Attachment (%d) conflicts with the image's " 92756600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski "IMAGE_USAGE flags (%s).", 92766600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski attachments[attach].attachment, string_VkImageUsageFlagBits(usage_flag)); 92776600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92786600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92796600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92806600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92826600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 92836600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 92846600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 92856600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9286d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// Validate VkFramebufferCreateInfo which includes: 9287d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis// 1. attachmentCount equals renderPass attachmentCount 92885ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 2. corresponding framebuffer and renderpass attachments have matching formats 92895ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 3. corresponding framebuffer and renderpass attachments have matching sample counts 92905ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 4. fb attachments only have a single mip level 92915ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 5. fb attachment dimensions are each at least as large as the fb 92925ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 6. fb attachments use idenity swizzle 92935ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis// 7. fb attachments used by renderPass for color/input/ds have correct usage bit set 92946fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis// 8. fb dimensions are within physical device limits 9295d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlisstatic bool ValidateFramebufferCreateInfo(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 92966600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski bool skip_call = false; 92976600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 9298d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis auto rp_node = getRenderPass(dev_data, pCreateInfo->renderPass); 9299d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rp_node) { 9300fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *rpci = rp_node->createInfo.ptr(); 9301d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis if (rpci->attachmentCount != pCreateInfo->attachmentCount) { 9302d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= log_msg( 9303d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9304d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9305d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachmentCount of %u does not match attachmentCount of %u of " 9306d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "renderPass (0x%" PRIxLEAST64 ") being used to create Framebuffer.", 9307d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis pCreateInfo->attachmentCount, rpci->attachmentCount, reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 93085ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } else { 930941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis // attachmentCounts match, so make sure corresponding attachment details line up 93105ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis const VkImageView *image_views = pCreateInfo->pAttachments; 93115ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 931279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_views[i]); 931312d5600c2f9e32343016fd944432ba95df370797Tobin Ehlis auto &ivci = view_state->create_info; 931479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.format != rpci->pAttachments[i].format) { 93155ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis skip_call |= log_msg( 93165ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 93175ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 93185ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has format of %s that does not match " 93195ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "the format of " 93205ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis "%s used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 932179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkFormat(ivci.format), string_VkFormat(rpci->pAttachments[i].format), 93225ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 93235ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 932479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageCreateInfo *ici = &getImageNode(dev_data, ivci.image)->createInfo; 93255ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis if (ici->samples != rpci->pAttachments[i].samples) { 932641ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis skip_call |= log_msg( 932741ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 932841ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 932941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "DS", "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has %s samples that do not match " 933041ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis "the %s samples used by the corresponding attachment for renderPass (0x%" PRIxLEAST64 ").", 933141ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis i, string_VkSampleCountFlagBits(ici->samples), string_VkSampleCountFlagBits(rpci->pAttachments[i].samples), 933241ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 93335ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 93345ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify that view only has a single mip level 933579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (ivci.subresourceRange.levelCount != 1) { 93366fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 93376fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis __LINE__, DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 93386fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has mip levelCount of %u " 93396fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "but only a single mip level (levelCount == 1) is allowed when creating a Framebuffer.", 934079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.levelCount); 93415ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 934279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const uint32_t mip_level = ivci.subresourceRange.baseMipLevel; 9343aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_width = max(1u, ici->extent.width >> mip_level); 9344aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis uint32_t mip_height = max(1u, ici->extent.height >> mip_level); 934579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if ((ivci.subresourceRange.layerCount < pCreateInfo->layers) || (mip_width < pCreateInfo->width) || 9346aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis (mip_height < pCreateInfo->height)) { 9347aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis skip_call |= 93486fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9349aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9350aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u mip level %u has dimensions smaller " 9351aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "than the corresponding " 9352aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "framebuffer dimensions. Attachment dimensions must be at least as large. Here are the respective " 9353aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "dimensions for " 9354aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "attachment #%u, framebuffer:\n" 9355aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "width: %u, %u\n" 9356aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "height: %u, %u\n" 9357aac6fea2aeb81a0d354d80a9226bdc5de2aef5e2Tobin Ehlis "layerCount: %u, %u\n", 935879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, ivci.subresourceRange.baseMipLevel, i, mip_width, pCreateInfo->width, mip_height, 935979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis pCreateInfo->height, ivci.subresourceRange.layerCount, pCreateInfo->layers); 93605ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 936179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (((ivci.components.r != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.r != VK_COMPONENT_SWIZZLE_R)) || 936279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.g != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.g != VK_COMPONENT_SWIZZLE_G)) || 936379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.b != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.b != VK_COMPONENT_SWIZZLE_B)) || 936479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis ((ivci.components.a != VK_COMPONENT_SWIZZLE_IDENTITY) && (ivci.components.a != VK_COMPONENT_SWIZZLE_A))) { 9365da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis skip_call |= log_msg( 93666fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 9367da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 9368da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "vkCreateFramebuffer(): VkFramebufferCreateInfo attachment #%u has non-identy swizzle. All framebuffer " 9369da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "attachments must have been created with the identity swizzle. Here are the actual swizzle values:\n" 9370da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "r swizzle = %s\n" 9371da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "g swizzle = %s\n" 9372da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "b swizzle = %s\n" 9373da5b8b1df2368168be93e563eccdb500d62b97a5Tobin Ehlis "a swizzle = %s\n", 937479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis i, string_VkComponentSwizzle(ivci.components.r), string_VkComponentSwizzle(ivci.components.g), 937579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis string_VkComponentSwizzle(ivci.components.b), string_VkComponentSwizzle(ivci.components.a)); 93765ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 93775ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis } 9378d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } 93795ef4ed03801d1456b7c30dd59ea014be126df771Tobin Ehlis // Verify correct attachment usage flags 93806600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski for (uint32_t subpass = 0; subpass < rpci->subpassCount; subpass++) { 93816600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify input attachments: 93826600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].inputAttachmentCount, 93836600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pInputAttachments, pCreateInfo, VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT); 93846600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify color attachments: 93856600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, rpci->pSubpasses[subpass].colorAttachmentCount, 93866600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski rpci->pSubpasses[subpass].pColorAttachments, pCreateInfo, VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT); 93876600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski // Verify depth/stencil attachments: 93886600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski if (rpci->pSubpasses[subpass].pDepthStencilAttachment != nullptr) { 93896600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski skip_call |= MatchUsage(dev_data, 1, rpci->pSubpasses[subpass].pDepthStencilAttachment, pCreateInfo, 93906600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT); 93916600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 93926600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 9393d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis } else { 9394d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= 9395d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 9396d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9397d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis "vkCreateFramebuffer(): Attempt to create framebuffer with invalid renderPass (0x%" PRIxLEAST64 ").", 9398d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis reinterpret_cast<const uint64_t &>(pCreateInfo->renderPass)); 93996600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski } 94006fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis // Verify FB dimensions are within physical device limits 94016fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis if ((pCreateInfo->height > dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight) || 94026fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->width > dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth) || 94036fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis (pCreateInfo->layers > dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers)) { 94046fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 94056fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis DRAWSTATE_INVALID_FRAMEBUFFER_CREATE_INFO, "DS", 94066fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "vkCreateFramebuffer(): Requested VkFramebufferCreateInfo dimensions exceed physical device limits. " 94076fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "Here are the respective dimensions: requested, device max:\n" 94086fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "width: %u, %u\n" 94096fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "height: %u, %u\n" 94106fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis "layerCount: %u, %u\n", 94116fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->width, dev_data->phys_dev_properties.properties.limits.maxFramebufferWidth, 94126fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->height, dev_data->phys_dev_properties.properties.limits.maxFramebufferHeight, 94136fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis pCreateInfo->layers, dev_data->phys_dev_properties.properties.limits.maxFramebufferLayers); 94146fb721e0f21c85d4457561d17c196280601cebc1Tobin Ehlis } 94156600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski return skip_call; 94166600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski} 94176600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 941864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Validate VkFramebufferCreateInfo state prior to calling down chain to create Framebuffer object 941964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// Return true if an error is encountered and callback returns true to skip call down chain 942064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis// false indicates that call down chain should proceed 942164c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlisstatic bool PreCallValidateCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo) { 942264c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis // TODO : Verify that renderPass FB is created with is compatible with FB 942364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = false; 9424d73d9c5ffd42f300d3ec49f64910a2b370694186Tobin Ehlis skip_call |= ValidateFramebufferCreateInfo(dev_data, pCreateInfo); 942564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return skip_call; 942664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis} 942764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 942854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis// CreateFramebuffer state has been validated and call down chain completed so record new framebuffer object 942954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlisstatic void PostCallRecordCreateFramebuffer(layer_data *dev_data, const VkFramebufferCreateInfo *pCreateInfo, VkFramebuffer fb) { 943054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis // Shadow create info and store in map 943176f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis std::unique_ptr<FRAMEBUFFER_NODE> fb_node( 9432fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes new FRAMEBUFFER_NODE(fb, pCreateInfo, dev_data->renderPassMap[pCreateInfo->renderPass]->createInfo.ptr())); 943376f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis 943454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 943554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 943679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, view); 943779fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state) { 943854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis continue; 943954e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 944054e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 944179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.mem = getImageNode(dev_data, view_state->create_info.image)->mem; 9442883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis fb_info.view_state = view_state; 944379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis fb_info.image = view_state->create_info.image; 944476f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis fb_node->attachments.push_back(fb_info); 944554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis } 944676f04ca0e692f9f15d5ef7e0c658c24d11f34ebcTobin Ehlis dev_data->frameBufferMap[fb] = std::move(fb_node); 944754e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis} 944854e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis 944989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 945089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 945189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 945364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis std::unique_lock<std::mutex> lock(global_lock); 945464c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis bool skip_call = PreCallValidateCreateFramebuffer(dev_data, pCreateInfo); 945564c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.unlock(); 945664c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 945764c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis if (skip_call) 945864c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 945964c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis 946064c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 94616600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 946364c259c2660d24b5b032f0cfa668de086dcd7eb4Tobin Ehlis lock.lock(); 946454e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis PostCallRecordCreateFramebuffer(dev_data, pCreateInfo, *pFramebuffer); 946554e0bb0ace13cc34255e0dc9ca6b0da2b4ac5be1Tobin Ehlis lock.unlock(); 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9470e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 9471e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 9474e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 9481e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 94825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 9484e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 94855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9486e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9489e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 9490e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 9491e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 94925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 94941d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 94985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 94995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 95017655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen // If no dependency exits an implicit dependency still might. If not, throw an error. 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 95037655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen if (!(FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 95047655cb8b5eb52badee0b011729a05afa36316d69Jan-Harald Fredriksen FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes))) { 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 95065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 95075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 9509e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 9517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 95185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 95195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 95205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 95215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 95225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 9523e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 95245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 95265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 9527e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 95285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 95305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 95315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 95325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 95335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 95355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 95365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 9537e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 95385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 95395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 9540e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 95415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 95425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9544e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 95455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 95465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 95475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 95485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 95495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 95575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 95615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 95625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9564f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 956516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 9566e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9567fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pFramebufferInfo = framebuffer->createInfo.ptr(); 9568fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pCreateInfo = renderPass->createInfo.ptr(); 956916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 95705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 95715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 95725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 95735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 95745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 95755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 95765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 95775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 95785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 95795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 95805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 95815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 95825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 958379fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state_i = getImageViewState(my_data, viewi); 958479fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state_j = getImageViewState(my_data, viewj); 958579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (!view_state_i || !view_state_j) { 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 958879fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_i = view_state_i->create_info; 958979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_ci_j = view_state_j->create_info; 959079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis if (view_ci_i.image == view_ci_j.image && isRegionOverlapping(view_ci_i.subresourceRange, view_ci_j.subresourceRange)) { 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 95925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 95935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 95945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 959579fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto image_data_i = getImageNode(my_data, view_ci_i.image); 959679fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto image_data_j = getImageNode(my_data, view_ci_j.image); 95976d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (!image_data_i || !image_data_j) { 95985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 95995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96006d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_data_i->mem == image_data_j->mem && isRangeOverlapping(image_data_i->memOffset, image_data_i->memSize, 96016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_data_j->memOffset, image_data_j->memSize)) { 96025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 96035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 96045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 96085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 96095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 96105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 96115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 96125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 96155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 96165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 96185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 96205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 96235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 96271c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 96285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 96301c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 96315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 96325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 963393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 963493fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 96365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 96415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 964293fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 964393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 96445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 96455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 96475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96481c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 96495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 96545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 96555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96561c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 96571c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 96581c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 96591c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 96601c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 96611c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 96621c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 96631c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 96695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 96705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 967193fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pInputAttachments[j].attachment; 967293fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 967393fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 967893fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes uint32_t attachment = subpass.pColorAttachments[j].attachment; 967993fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes if (attachment == VK_ATTACHMENT_UNUSED) 968093fe72ec8460857bdb3c101095e6eb96d6171341Chris Forbes continue; 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 96835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 96855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 96865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 96935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9700be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 9701be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 9702be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 9703be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 9704be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 9705be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 9706be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 9707be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 9708be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 9709be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 9710be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 9711be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 9712be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 9713be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9714be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 9715be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9716be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 9717be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 9718be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9720e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 9721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 972377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis // Track when we're observing the first use of an attachment 972477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis std::vector<bool> attach_first_use(pCreateInfo->attachmentCount, true); 97255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 97280ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes auto attach_index = subpass.pColorAttachments[j].attachment; 97290ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes if (attach_index == VK_ATTACHMENT_UNUSED) 97300ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes continue; 97310ad39e0de2f23ebec8c8ffbf6b54754ebf5ae9a7Chris Forbes 9732c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pColorAttachments[j].layout) { 9733c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: 9734c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* This is ideal. */ 9735c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9736c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9737c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9738c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9739c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints? 9740c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9741c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9742c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9743c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9744c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 9745c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9746c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9747c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9748c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9749c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9750c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9751c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 9752c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pColorAttachments[j].layout)); 97535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9754c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 975577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 975677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, 975777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 975877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 975977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9761c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 9762cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes switch (subpass.pDepthStencilAttachment->layout) { 9763cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: 9764cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9765cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* These are ideal. */ 9766cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9767cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9768cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9769cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* May not be optimal; TODO: reconsider this warning based on 9770cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * other constraints? GENERAL can be better than doing a bunch 9771cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes * of transitions. 9772cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes */ 9773cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9774cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9776cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "GENERAL layout for depth attachment may not give optimal performance."); 9777cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes break; 9778cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9779cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes default: 9780cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes /* No other layouts are acceptable */ 9781cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 9782cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9783cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9784cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL, " 9785cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes "DEPTH_STENCIL_READ_ONLY_OPTIMAL or GENERAL.", 97865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 97875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9788cfa128db908c2462aaf616950fb2fdb9d2f92bc1Chris Forbes 9789be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 979077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 979177c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 979277c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 979377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 979477c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 979577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 979677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 979777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 979877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_index == VK_ATTACHMENT_UNUSED) 979977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis continue; 980077c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis 9801c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes switch (subpass.pInputAttachments[j].layout) { 9802c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: 9803c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: 9804c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* These are ideal. */ 9805c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9806c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9807c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes case VK_IMAGE_LAYOUT_GENERAL: 9808c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* May not be optimal. TODO: reconsider this warning based on 9809c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes * other constraints. 9810c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes */ 9811c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 9812c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0, __LINE__, 9813c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9814c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 9815c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes break; 9816c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 9817c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes default: 9818c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes /* No other layouts are acceptable */ 9819c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9820c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 9821c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 9822c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes string_VkImageLayout(subpass.pInputAttachments[j].layout)); 982377c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 9824c74f9e8c7fe6b470f757da0c42367fe725fe0928Chris Forbes 982577c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis if (attach_first_use[attach_index]) { 982677c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, 982777c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 982877c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis } 982977c531defc2e8614acee0969b170cc2fa68f55d3Tobin Ehlis attach_first_use[attach_index] = false; 98305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 98335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9835e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 9836e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 9837e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 984466a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL || dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 984566a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes if (dependency.srcSubpass == dependency.dstSubpass) { 984666a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes skip_call |= 984766a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 984866a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 984966a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } 985066a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes 985166a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // We don't want to add edges to the DAG for dependencies to/from 985266a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // VK_SUBPASS_EXTERNAL. We don't use them for anything, and their 985366a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes // presence complicates other code. 985466a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes continue; 985566a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes } else if (dependency.srcSubpass > dependency.dstSubpass) { 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 98575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 98585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 986266a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes 986366a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 986466a7318a24c9dd8162a6ae49fd62867a263d4402Chris Forbes subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 98655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9868918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 987089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 987189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 987289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9875b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9876b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 9877b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 9878b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 9879b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 9880b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9881b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 9882b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 9883b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 9884b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 9885b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 9886b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 9887b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 98885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9890b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 9891b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 9892b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 9893e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 98945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 9899b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 9900918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 99015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateAttachmentIndex(layer_data *dev_data, uint32_t attachment, uint32_t attachment_count, const char *type) { 99064f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 99074f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment >= attachment_count && attachment != VK_ATTACHMENT_UNUSED) { 99084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 99104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: %s attachment %d cannot be greater than the total number of attachments %d.", 99114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski type, attachment, attachment_count); 99124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 99134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 99144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 99154f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 9916805ec497391f6bc513f7653ba6d535c509b54062Chris Forbesstatic bool IsPowerOfTwo(unsigned x) { 9917805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes return x && !(x & (x-1)); 9918805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes} 9919805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 99204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinskistatic bool ValidateRenderpassAttachmentUsage(layer_data *dev_data, const VkRenderPassCreateInfo *pCreateInfo) { 99214f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski bool skip_call = false; 99224f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 99234f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 99244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 99254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= 99264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 99274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski DRAWSTATE_INVALID_RENDERPASS, "DS", 99284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 99294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 99304f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 99314f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pPreserveAttachments[j]; 99324f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (attachment == VK_ATTACHMENT_UNUSED) { 99334f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 99344f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski __LINE__, DRAWSTATE_INVALID_ATTACHMENT_INDEX, "DS", 99354f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski "CreateRenderPass: Preserve attachment (%d) must not be VK_ATTACHMENT_UNUSED.", j); 99364f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } else { 99374f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Preserve"); 99384f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 99394f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 99406a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 99416a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes auto subpass_performs_resolve = subpass.pResolveAttachments && std::any_of( 99426a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes subpass.pResolveAttachments, subpass.pResolveAttachments + subpass.colorAttachmentCount, 99436a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes [](VkAttachmentReference ref) { return ref.attachment != VK_ATTACHMENT_UNUSED; }); 99446a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9945805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes unsigned sample_count = 0; 9946805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 99474f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 99484f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment; 99494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pResolveAttachments) { 99504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pResolveAttachments[j].attachment; 99514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Resolve"); 99526a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 99536a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED && 99546a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes pCreateInfo->pAttachments[attachment].samples != VK_SAMPLE_COUNT_1_BIT) { 99556a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 99566a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 99576a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "CreateRenderPass: Subpass %u requests multisample resolve into attachment %u, " 99586a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes "which must have VK_SAMPLE_COUNT_1_BIT but has %s", 99596a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes i, attachment, string_VkSampleCountFlagBits(pCreateInfo->pAttachments[attachment].samples)); 99606a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 99614f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 99624f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment = subpass.pColorAttachments[j].attachment; 99634f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Color"); 99646a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes 9965805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9966805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9967805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9968dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes if (subpass_performs_resolve && 9969dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes pCreateInfo->pAttachments[attachment].samples == VK_SAMPLE_COUNT_1_BIT) { 9970dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9971dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9972dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "CreateRenderPass: Subpass %u requests multisample resolve from attachment %u " 9973dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes "which has VK_SAMPLE_COUNT_1_BIT", 9974dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes i, attachment); 9975dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes } 99766a3bc5f071fe21799f0f7ae844716c333f11f39cChris Forbes } 99774f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9978dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 99794f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 99804f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 99814f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Depth stencil"); 9982805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9983805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (!skip_call && attachment != VK_ATTACHMENT_UNUSED) { 9984805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes sample_count |= (unsigned)pCreateInfo->pAttachments[attachment].samples; 9985805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 99864f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9987dc7c45f01ae5690f7c969b4760463c1a6bac52d5Chris Forbes 99884f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 99894f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pInputAttachments[j].attachment; 99904f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateAttachmentIndex(dev_data, attachment, pCreateInfo->attachmentCount, "Input"); 99914f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 9992805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes 9993805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes if (sample_count && !IsPowerOfTwo(sample_count)) { 9994805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 9995805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 9996805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "CreateRenderPass: Subpass %u attempts to render to " 9997805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes "attachments with inconsistent sample counts", 9998805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes i); 9999805ec497391f6bc513f7653ba6d535c509b54062Chris Forbes } 100004f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 100014f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return skip_call; 100024f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski} 100034f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 1000489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 100054f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski const VkAllocationCallbacks *pAllocator, VkRenderPass *pRenderPass) { 10006e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 100075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 100084f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 100094f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::unique_lock<std::mutex> lock(global_lock); 100104f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 100114f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 100124f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // TODO: As part of wrapping up the mem_tracker/core_validation merge the following routine should be consolidated with 100134f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski // ValidateLayouts. 100144f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= ValidateRenderpassAttachmentUsage(dev_data, pCreateInfo); 10015ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes lock.unlock(); 100164f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 100174f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (skip_call) { 100184f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 100194f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski } 100204f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10021ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 10022ff6101de02d1677fb54962e2ff57875e76898e26Chris Forbes 100235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 100244f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski lock.lock(); 100254f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 100264f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 100274f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 100284f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 100294f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10030fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto render_pass = unique_ptr<RENDER_PASS_NODE>(new RENDER_PASS_NODE(pCreateInfo)); 1003198cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 10032cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 10033cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 10034db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 1003587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 10036cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 100376600a7662f6dac6a8c8622a8305f02625439bf30Mark Lobodzinski std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = render_pass->attachment_first_layout; 1003887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 1003987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 1004087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 100414f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski uint32_t attachment = subpass.pColorAttachments[j].attachment; 100424f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 100434f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 100444f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 100450d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 1004687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 1004787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 1004887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 100494f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 100504f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, false)); 100514f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 1005224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 1005387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10054a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10055a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 100564f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski if (!attachment_first_read.count(attachment)) { 100574f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_read.insert(std::make_pair(attachment, true)); 100584f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 1005924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 10060a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 1006187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 10062db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes 10063fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes dev_data->renderPassMap[*pRenderPass] = std::move(render_pass); 100645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 100665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 100674f76794409854faf16dd51f37d5fa21dff1c5d44Mark Lobodzinski 10068e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 10069e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10070fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const pRenderPassInfo = getRenderPass(dev_data, pRenderPassBegin->renderPass)->createInfo.ptr(); 1007148a43d923a7b126a78770bd209d63902ffa0520aChris Forbes auto const & framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer]->createInfo; 100725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 100735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 100745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 100755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 100765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 100775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 100785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 1007979fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis auto view_state = getImageViewState(dev_data, image_view); 1008079fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis assert(view_state); 1008179fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImage &image = view_state->create_info.image; 1008279fde938178535f598e030a0e9d19a0cb61b72e0Tobin Ehlis const VkImageSubresourceRange &subRange = view_state->create_info.subresourceRange; 100835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 100845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 100855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 100865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 100875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 100885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 100895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 100905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 100915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 100925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 100935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 100945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 100955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10096c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes if (newNode.layout != VK_IMAGE_LAYOUT_UNDEFINED && 10097c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes newNode.layout != node.layout) { 100985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 100995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10100c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", 10101c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "You cannot start a render pass using attachment %u " 10102c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "where the render pass initial layout is %s and the previous " 10103c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "known layout of the attachment is %s. The layouts must match, or " 10104c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "the render pass initial layout for the attachment must be " 10105c83d821f524b75cbcfa5e8b661a3a605ea221b92Chris Forbes "VK_IMAGE_LAYOUT_UNDEFINED", 101061c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 101075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10114628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbesstatic void TransitionAttachmentRefLayout(layer_data *dev_data, GLOBAL_CB_NODE *pCB, 10115628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes FRAMEBUFFER_NODE *pFramebuffer, 10116628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes VkAttachmentReference ref) 10117628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes{ 10118628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (ref.attachment != VK_ATTACHMENT_UNUSED) { 10119628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = pFramebuffer->createInfo.pAttachments[ref.attachment]; 10120628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes SetLayout(dev_data, pCB, image_view, ref.layout); 10121628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes } 10122628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes} 10123628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes 1012427ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 10125e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 1012616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 1012716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 101285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1012916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10130e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 10131e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 101325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10133e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 10134fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto const &subpass = renderPass->createInfo.pSubpasses[subpass_index]; 101355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 10136628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pInputAttachments[j]); 101375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 10139628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, subpass.pColorAttachments[j]); 101405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10141628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes if (subpass.pDepthStencilAttachment) { 10142628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes TransitionAttachmentRefLayout(dev_data, pCB, framebuffer, *subpass.pDepthStencilAttachment); 101435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10146e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 10147e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 101485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 101495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 101505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 101515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 101525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 101545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10156f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 1015716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 1015816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 101595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 1016016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 10161fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->createInfo.ptr(); 10162e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 10163e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 101645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 10165e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 101665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 10167628f0e370a17207a87d2632616fc8ca27e7ac80cChris Forbes auto image_view = framebuffer->createInfo.pAttachments[i]; 101685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 101695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 101705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 101715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10172e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 10173885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 1017404861caca7eb93a5241b164e8480bb93c826902cTobin Ehlis const safe_VkFramebufferCreateInfo *pFramebufferInfo = &getFramebuffer(my_data, pRenderPassBegin->framebuffer)->createInfo; 10175885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 10176885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 10177885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 10178885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 10179885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 10180885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10181885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 10182885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 10183885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 10184885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 10185885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 10186885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 10187885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 10188885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 10189885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 10190885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 101911a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// If this is a stencil format, make sure the stencil[Load|Store]Op flag is checked, while if it is a depth/color attachment the 101921a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// [load|store]Op flag must be checked 101931a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski// TODO: The memory valid flag in DEVICE_MEM_INFO should probably be split to track the validity of stencil memory separately. 101941a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinskitemplate <typename T> static bool FormatSpecificLoadAndStoreOpSettings(VkFormat format, T color_depth_op, T stencil_op, T op) { 10195a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski if (color_depth_op != op && stencil_op != op) { 10196a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return false; 10197a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski } 101981a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_color_depth_load_op = !vk_format_is_stencil_only(format); 101991a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski bool check_stencil_load_op = vk_format_is_depth_and_stencil(format) || !check_color_depth_load_op; 10200a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski 10201a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski return (((check_color_depth_load_op == true) && (color_depth_op == op)) || 10202a49b8a211ce07e7fa2225d23f8cb11f1055b418aMark Lobodzinski ((check_stencil_load_op == true) && (stencil_op == op))); 102031a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski} 102041a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski 1020589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1020689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 1020783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 102085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10209b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10210f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis GLOBAL_CB_NODE *cb_node = getCBNode(dev_data, commandBuffer); 1021116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 10212f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 10213f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis if (cb_node) { 1021416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 102156de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis uint32_t clear_op_size = 0; // Make sure pClearValues is at least as large as last LOAD_OP_CLEAR 10216f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeFramebuffer = pRenderPassBegin->framebuffer; 10217fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes for (size_t i = 0; i < renderPass->createInfo.attachmentCount; ++i) { 10218f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10219fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto pAttachment = &renderPass->createInfo.pAttachments[i]; 10220db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10221db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 102221a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_CLEAR)) { 1022392bc0680357019834b7529148ab6d73353ce02c7Mark Lobodzinski clear_op_size = static_cast<uint32_t>(i) + 1; 1022416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10225f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 1022616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1022716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10228f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10229db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10230db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 102311a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_DONT_CARE)) { 1023216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10233f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 1023416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 1023516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10236f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 10237db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->loadOp, 10238db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilLoadOp, 102391a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_LOAD_OP_LOAD)) { 1024016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10241f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 10242f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1024316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10244f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 1024516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 10246db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (renderPass->attachment_first_read[i]) { 1024716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 10248f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis return ValidateImageMemoryIsValid(dev_data, getImageNode(dev_data, fb_info.image), 10249f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis "vkCmdBeginRenderPass()"); 1025016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 10251f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->validate_functions.push_back(function); 102525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102546de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis if (clear_op_size > pRenderPassBegin->clearValueCount) { 102556de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis skip_call |= 102566de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 102576de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 102586de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but there must " 102596de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "be at least %u " 102606de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "entries in pClearValues array to account for the highest index attachment in renderPass 0x%" PRIx64 102616de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis " that uses VK_ATTACHMENT_LOAD_OP_CLEAR is %u. Note that the pClearValues array " 102626de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "is indexed by attachment number so even if some pClearValues entries between 0 and %u correspond to " 102636de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis "attachments that aren't cleared they will be ignored.", 102646de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis pRenderPassBegin->clearValueCount, clear_op_size, reinterpret_cast<uint64_t &>(renderPass), 102656de3c6ffa0819ee37cd5cecee918b062145e2ff1Tobin Ehlis clear_op_size, clear_op_size - 1); 102663d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 1026783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 10268f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= VerifyFramebufferAndRenderPassLayouts(dev_data, cb_node, pRenderPassBegin); 10269f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= insideRenderPass(dev_data, cb_node, "vkCmdBeginRenderPass"); 1027083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateDependencies(dev_data, framebuffer, renderPass); 10271f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, cb_node, "vkCmdBeginRenderPass"); 10272f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis skip_call |= addCmd(dev_data, cb_node, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 10273f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPass = renderPass; 102745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 10275f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeRenderPassBeginInfo = *pRenderPassBegin; 10276f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpass = 0; 10277f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->activeSubpassContents = contents; 10278f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis cb_node->framebuffers.insert(pRenderPassBegin->framebuffer); 10279883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis // Connect this framebuffer and its children to this cmdBuffer 10280883ee3f865f9dbd83134d148b26e96cb6a926b3dTobin Ehlis AddFramebufferBinding(dev_data, cb_node, framebuffer); 10281ea0f86230ff5c52f805ac831a1ed5a92bd123368Chris Forbes // transition attachments to the correct layouts for the first subpass 10282f909505280723ee24d2e74afc759d38dc09a37beTobin Ehlis TransitionSubpassLayouts(dev_data, cb_node, &cb_node->activeRenderPassBeginInfo, cb_node->activeSubpass); 102835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1028483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1028583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 1028683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 102875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10289b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1029083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 102915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 102925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 102935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 102945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1029589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 1029683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 102975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10298b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 102995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 103005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 1030183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 1030283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 1030383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 1030480281691386b37385846f21b38e8c9d4b12cc74eChris Forbes 10305fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto subpassCount = pCB->activeRenderPass->createInfo.subpassCount; 1030680281691386b37385846f21b38e8c9d4b12cc74eChris Forbes if (pCB->activeSubpass == subpassCount - 1) { 1030780281691386b37385846f21b38e8c9d4b12cc74eChris Forbes skip_call |= 1030880281691386b37385846f21b38e8c9d4b12cc74eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1030980281691386b37385846f21b38e8c9d4b12cc74eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1031080281691386b37385846f21b38e8c9d4b12cc74eChris Forbes "vkCmdNextSubpass(): Attempted to advance beyond final subpass"); 1031180281691386b37385846f21b38e8c9d4b12cc74eChris Forbes } 103125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10313b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1031496ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1031596ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (skip_call) 1031696ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes return; 1031796ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1031896ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 1031996ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes 1032096ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes if (pCB) { 1032196ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes lock.lock(); 1032296ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpass++; 1032396ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes pCB->activeSubpassContents = contents; 1032496ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 1032596ebb1e373cc0993339e2ecc1dc47e9918406f87Chris Forbes } 103265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1032889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 1032983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 103305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10331b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1033258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 1033358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 1033458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 10335e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 10336ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 10337fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes if (pCB->activeSubpass != pRPNode->createInfo.subpassCount - 1) { 1033802a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes skip_call |= 1033902a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 1034002a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SUBPASS_INDEX, "DS", 1034102a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes "vkCmdEndRenderPass(): Called before reaching final subpass"); 1034202a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes } 1034302a3382f28fc7c6ec6018165be88aa6fc4f05c9eChris Forbes 10344fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes for (size_t i = 0; i < pRPNode->createInfo.attachmentCount; ++i) { 10345e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 10346fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes auto pAttachment = &pRPNode->createInfo.pAttachments[i]; 10347db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10348db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, VK_ATTACHMENT_STORE_OP_STORE)) { 1034958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10350f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), true); 1035158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1035258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1035358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 10354db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes } else if (FormatSpecificLoadAndStoreOpSettings(pAttachment->format, pAttachment->storeOp, 10355db6ad16f7690669bb664b970a8e5c47abb8db9faChris Forbes pAttachment->stencilStoreOp, 103561a65650f856376768d7b03ea2d080aaff87cacfdMark Lobodzinski VK_ATTACHMENT_STORE_OP_DONT_CARE)) { 1035758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 10358f989de4217bce0f293121d0da53dc8328276370fTobin Ehlis SetImageMemoryValid(dev_data, getImageNode(dev_data, fb_info.image), false); 1035958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 1036058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 1036158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 103625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1036583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 1036683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 1036783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 103680e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes } 103690e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.unlock(); 103700e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 103710e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (skip_call) 103720e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes return; 103730e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 103740e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 103750e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes 103760e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes if (pCB) { 103770e21dda98453b5ced1fe7a2ffd5ca4b21847fe09Chris Forbes lock.lock(); 10378f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 1037958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 1038058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 1038158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 103825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 103835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10385a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, uint32_t primaryAttach, 10386a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis uint32_t secondaryAttach, const char *msg) { 103875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 103885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10389a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid Secondary Cmd Buffer 0x%" PRIx64 " which has a render pass " 10390a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "that is not compatible with the Primary Cmd Buffer current render pass. " 10391a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "Attachment %u is not compatible with %u: %s", 10392a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), primaryAttach, secondaryAttach, msg); 103935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 103945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10395a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10396a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, uint32_t primaryAttach, 10397a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkCommandBuffer secondaryBuffer, VkRenderPassCreateInfo const *secondaryPassCI, 10398e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 103995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10400a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->attachmentCount <= primaryAttach) { 104015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 104025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10403a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (secondaryPassCI->attachmentCount <= secondaryAttach) { 104045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 104055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 104075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 10410a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10411a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The first is unused while the second is not."); 104125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 10415a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, 10416a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "The second is unused while the first is not."); 104175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10419a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].format != secondaryPassCI->pAttachments[secondaryAttach].format) { 10420a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10421a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different formats."); 104225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10423a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->pAttachments[primaryAttach].samples != secondaryPassCI->pAttachments[secondaryAttach].samples) { 10424a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10425a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different samples."); 104265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10427a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (is_multi && primaryPassCI->pAttachments[primaryAttach].flags != secondaryPassCI->pAttachments[secondaryAttach].flags) { 10428a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= 10429a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis logInvalidAttachmentMessage(dev_data, secondaryBuffer, primaryAttach, secondaryAttach, "They have different flags."); 104305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10434a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10435a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10436a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI, const int subpass, bool is_multi) { 104375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10438a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &primary_desc = primaryPassCI->pSubpasses[subpass]; 10439a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis const VkSubpassDescription &secondary_desc = secondaryPassCI->pSubpasses[subpass]; 104405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 104415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 104425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 104435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 104445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 104455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 104475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 104485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10449a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_input_attach, secondaryBuffer, 10450a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_input_attach, is_multi); 104515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 104535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 104545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 104555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 104565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 104575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 104595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 104605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10461a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_color_attach, secondaryBuffer, 10462a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryPassCI, secondary_color_attach, is_multi); 104635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 104645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 104655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 104665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 104685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 104695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10470a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_resolve_attach, 10471a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_resolve_attach, is_multi); 104725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 104745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 104755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 104765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 104775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 104785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 104795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10480a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPassCI, primary_depthstencil_attach, 10481a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis secondaryBuffer, secondaryPassCI, secondary_depthstencil_attach, is_multi); 104825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 104835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 104845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10485a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// Verify that given renderPass CreateInfo for primary and secondary command buffers are compatible. 10486a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// This function deals directly with the CreateInfo, there are overloaded versions below that can take the renderPass handle and 10487a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis// will then feed into this function 10488a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlisstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, 10489a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *primaryPassCI, VkCommandBuffer secondaryBuffer, 10490a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis VkRenderPassCreateInfo const *secondaryPassCI) { 104915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 10492a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis 10493a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (primaryPassCI->subpassCount != secondaryPassCI->subpassCount) { 104945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 104955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10496a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 10497a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u that is incompatible with the primary Cmd Buffer 0x%" PRIx64 10498a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis " that has a subpassCount of %u.", 10499a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), secondaryPassCI->subpassCount, 10500a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis reinterpret_cast<uint64_t &>(primaryBuffer), primaryPassCI->subpassCount); 10501a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } else { 10502a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis for (uint32_t i = 0; i < primaryPassCI->subpassCount; ++i) { 10503a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primaryPassCI, secondaryBuffer, secondaryPassCI, i, 10504a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis primaryPassCI->subpassCount > 1); 10505a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 105065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10510e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 10511e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 105125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 105135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 105145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10516c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 105175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 105185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 105195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 105205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 105211af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 105221af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%" PRIx64 105231af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " which has a framebuffer 0x%" PRIx64 105241af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis " that is not the same as the primaryCB's current active framebuffer 0x%" PRIx64 ".", 105251af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(secondaryBuffer), reinterpret_cast<uint64_t &>(secondary_fb), 105261af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis reinterpret_cast<uint64_t &>(primary_fb)); 105275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10528e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 10529e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 105305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 105315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 10532414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10533414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 105345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 105355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10537a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto cb_renderpass = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 10538a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (cb_renderpass->renderPass != fb->createInfo.renderPass) { 10539a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->renderPassCreateInfo.ptr(), secondaryBuffer, 10540fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes cb_renderpass->createInfo.ptr()); 10541a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 105425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 105445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 1054783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 105495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 105505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 105515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 105525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 105535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 105545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 105555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 1055683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 105575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 105585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10559414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10560414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 105615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 105625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 105635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 105665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 105695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 105705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 1057183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 105725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 105735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10574414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 10575414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 10576414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 105775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 105785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 105795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 105817bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 105827bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto primary_pool = getCommandPoolNode(dev_data, pCB->createInfo.commandPool); 105837bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski auto secondary_pool = getCommandPoolNode(dev_data, pSubCB->createInfo.commandPool); 105847bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski if (primary_pool && secondary_pool && (primary_pool->queueFamilyIndex != secondary_pool->queueFamilyIndex)) { 105857bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 105867bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_QUEUE_FAMILY, "DS", 105877bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski "vkCmdExecuteCommands(): Primary command buffer 0x%" PRIxLEAST64 105887bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski " created in queue family %d has secondary command buffer 0x%" PRIxLEAST64 " created in queue family %d.", 105897bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pCB->commandBuffer), primary_pool->queueFamilyIndex, 105907bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski reinterpret_cast<uint64_t>(pSubCB->commandBuffer), secondary_pool->queueFamilyIndex); 105917bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski } 105927bd96b29f4b8df99339ff1f7bc64f2f8940f8d25Mark Lobodzinski 1059383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 105945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 105955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1059689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1059789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 1059883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 105995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 10600b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 106015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 106025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 106035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 106045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 106055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 106065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 1060783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 106085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 106095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 10610414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 106115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 106125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 1061383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 1061483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 1061583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 1061683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 1061783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (void *)pCommandBuffers[i], i); 106185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 10619a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis auto secondary_rp_node = getRenderPass(dev_data, pSubCB->beginInfo.pInheritanceInfo->renderPass); 106205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 1062183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 106225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 106235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 10624414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 106255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 10626ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 106275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 106285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 10629a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if (pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) { 10630fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes skip_call |= 10631fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->createInfo.ptr(), 10632fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes pCommandBuffers[i], secondary_rp_node->createInfo.ptr()); 10633a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis } 106341af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match active FB from primaryCB 1063583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 106365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 106381af6125615cd6dd9735d32e2ee8684abeff28d41Tobin Ehlis // secondaryCB must have been created w/ RP compatible w/ primaryCB active renderpass 10639a092085c225bbc24edb29cd34ca6b30889f7e111Tobin Ehlis if ((pCB->activeRenderPass->renderPass != secondary_rp_node->renderPass) && 10640fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes !verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->createInfo.ptr(), 10641fb13c2c4174108223d9f8e43084020eb09115ed6Chris Forbes secondary_rp_node->createInfo.ptr(), errorString)) { 1064283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 106435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 106445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 10645414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 10646414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 106475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 10648ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 106495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 1065283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 1065375b0d6603382dcb3e3de24c11ea6e4aa2ef8b4d2Tobin Ehlis skip_call |= validateCommandBufferState(dev_data, pSubCB, "vkCmdExecuteCommands()"); 106545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 106555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 106565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 106575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 1065883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 106595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 106605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10661414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 106625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 106635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 106645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 106665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 1066783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 106685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 106695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 10670414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 106715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 10672414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 1067383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "set, even though it does.", 106745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 106755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 106765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10678f71dd305f197826a61f398bff725267a20ea1d90Chris Forbes if (!pCB->activeQueries.empty() && !dev_data->enabled_features.inheritedQueries) { 1067983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 106805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 106815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 106825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 10683414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 106845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 106855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 106865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 106875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 106885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 106895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 106905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 10691d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine for (auto &function : pSubCB->queryUpdates) { 10692d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine pCB->queryUpdates.push_back(function); 10693d4ee9fdb2def1e9dc70c5627c9103e264471b8ebMichael Lentine } 106945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1069583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 1069683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 106975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10698b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1069983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 107005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 107015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10703b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis// For any image objects that overlap mapped memory, verify that their layouts are PREINIT or GENERAL 10704cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlisstatic bool ValidateMapImageLayouts(VkDevice device, DEVICE_MEM_INFO const *mem_info, VkDeviceSize offset, 10705623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis VkDeviceSize end_offset) { 10706e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 107075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10708cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // Iterate over all bound image ranges and verify that for any that overlap the 10709cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // map ranges, the layouts are VK_IMAGE_LAYOUT_PREINITIALIZED or VK_IMAGE_LAYOUT_GENERAL 10710cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : This can be optimized if we store ranges based on starting address and early exit when we pass our range 10711cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis for (auto image_handle : mem_info->bound_images) { 10712cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis auto img_it = mem_info->bound_ranges.find(image_handle); 10713cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (img_it != mem_info->bound_ranges.end()) { 10714623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis if (rangesIntersect(dev_data, &img_it->second, offset, end_offset)) { 10715b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis std::vector<VkImageLayout> layouts; 10716825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis if (FindLayouts(dev_data, VkImage(image_handle), layouts)) { 10717b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis for (auto layout : layouts) { 10718b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 10719b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis skip_call |= 10720b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 10721b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 10722b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 10723b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis string_VkImageLayout(layout)); 10724b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10725b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10726b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10727b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 10728b05be7c81dfbaef10cf00e2cc1c3832026fde765Tobin Ehlis } 107295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 107315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1073389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1073489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 107355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 107365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10737e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 107385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10739b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10740cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis DEVICE_MEM_INFO *mem_info = getMemObjInfo(dev_data, mem); 10741cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if (mem_info) { 10742f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis // TODO : This could me more fine-grained to track just region that is valid 10743f541bf53dee6daf82a4c8304354eac599a884d29Tobin Ehlis mem_info->global_valid = true; 10744623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis auto end_offset = (VK_WHOLE_SIZE == size) ? mem_info->alloc_info.allocationSize - 1 : offset + size - 1; 10745623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem_info, offset, end_offset); 10746cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : Do we need to create new "bound_range" for the mapped range? 10747623548a271287ae55415e45e3c654ee66d4e79ffTobin Ehlis SetMemRangesValid(dev_data, mem_info, offset, end_offset); 10748cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[mem_info->alloc_info.memoryTypeIndex].propertyFlags & 10749b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 107505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 107515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 107525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 10753414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 107545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10756f57fc64ac43691ad98e1713886b345465573070aTobin Ehlis skip_call |= ValidateMapMemRange(dev_data, mem, offset, size); 10757b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 107585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 107605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 107617c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 107627c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 10763cf17f50f6489504c0d8151c46d6f77404ce2ffffTobin Ehlis // TODO : What's the point of this range? See comment on creating new "bound_range" above, which may replace this 107647c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 107655f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski initializeAndTrackMemory(dev_data, mem, offset, size, ppData); 107667c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 107677c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 107685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 107705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1077289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 107735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1077483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10776b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1077783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= deleteMemRanges(my_data, mem); 10778b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1077983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 107805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 107815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 107835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10784e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 10785e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1078683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 107875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1078857fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1078957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 10790de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis if (mem_info->mem_range.offset > pMemRanges[i].offset) { 1079183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= 1079257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1079357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1079457fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 1079557fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 10796de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_info->mem_range.offset)); 107975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 107984b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 10799de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis const uint64_t my_dataTerminus = (mem_info->mem_range.size == VK_WHOLE_SIZE) 10800de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis ? mem_info->alloc_info.allocationSize 10801de1d2592cdd497642de5b0e6f27ebc439018383bTobin Ehlis : (mem_info->mem_range.offset + mem_info->mem_range.size); 108024b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 1080383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1080483b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1080583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1080683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER ") exceeds the Memory Object's upper-bound " 1080783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 1080883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), static_cast<size_t>(my_dataTerminus)); 108095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1081283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 108135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108159e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinskistatic bool ValidateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 10816e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 1081783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 108185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 1081957fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(my_data, pMemRanges[i].memory); 1082057fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 108215f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info->shadow_copy) { 108225f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 108235f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 108245f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - pMemRanges[i].offset); 108255f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 108265f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = 0; j < mem_info->shadow_pad_size; ++j) { 108275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1082883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1082983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1083083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 108315f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski "Memory underflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 108325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108345f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski for (uint64_t j = (size + mem_info->shadow_pad_size); j < (2 * mem_info->shadow_pad_size + size); ++j) { 108355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 1083683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg( 1083783b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1083883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 1083983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, (uint64_t)pMemRanges[i].memory); 108405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108425f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(mem_info->p_driver_data, static_cast<void *>(data + mem_info->shadow_pad_size), (size_t)(size)); 108435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1084683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis return skip_call; 108475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 108495f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinskistatic void CopyNoncoherentMemoryFromDriver(layer_data *my_data, uint32_t memory_range_count, 108505f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski const VkMappedMemoryRange *mem_ranges) { 108519e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski for (uint32_t i = 0; i < memory_range_count; ++i) { 108529e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski auto mem_info = getMemObjInfo(my_data, mem_ranges[i].memory); 108535f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski if (mem_info && mem_info->shadow_copy) { 108545f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski VkDeviceSize size = (mem_info->mem_range.size != VK_WHOLE_SIZE) 108555f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski ? mem_info->mem_range.size 108565f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski : (mem_info->alloc_info.allocationSize - mem_ranges[i].offset); 108575f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski char *data = static_cast<char *>(mem_info->shadow_copy); 108585f06b9eba1bf89d4066ca44120dcb72c4cf44104Mark Lobodzinski memcpy(data + mem_info->shadow_pad_size, mem_info->p_driver_data, (size_t)(size)); 108599e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 108609e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski } 108619e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski} 108629e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski 1086389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1086489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 108655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1086683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 108675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10869b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 108709e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski skip_call |= ValidateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 1087183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 10872b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1087383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 108745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 108755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1087989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 1088089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 108815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1088283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 108835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10885b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 1088683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 10887b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1088883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 108895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 108909e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski // Update our shadow copy with modified driver data 108919e21e56fc23ade48efd3752d2e2729895eb90349Mark Lobodzinski CopyNoncoherentMemoryFromDriver(my_data, memRangeCount, pMemRanges); 108925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 108935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 108945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 108955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1089689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 108975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 108985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 1089983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 10900b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 109016d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis auto image_node = getImageNode(dev_data, image); 109026d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis if (image_node) { 1090394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 1090447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 10905888cae09036ec622d6014e18efbda55e6226cf22Tobin Ehlis skip_call = SetMemBinding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 109065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 10907b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1090894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 10909b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 1091047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 1091147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 1091257fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis auto mem_info = getMemObjInfo(dev_data, mem); 1091357fc8e28c2e16118f9827e3ae1b107a27e0451a2Tobin Ehlis if (mem_info) { 109149f12a235bb9c014878a98ce385b68587add2538aTobin Ehlis skip_call |= InsertImageMemoryRange(dev_data, image, mem_info, memoryOffset, memRequirements, 10915825446075d5f6c6b531754c0709bddd9dae8945fTobin Ehlis image_node->createInfo.tiling == VK_IMAGE_TILING_LINEAR); 1091683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateMemoryTypes(dev_data, mem_info, memRequirements.memoryTypeBits, "vkBindImageMemory"); 1091747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 1091847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 109190a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 10920b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1092183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) { 1092294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 10923b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 109246d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = mem; 109256d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memOffset = memoryOffset; 109266d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->memSize = memRequirements.size; 10927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1092894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 1092994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 1093094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 1093194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 10932414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 1093394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 109345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1093889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 109393ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 109403ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 109415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 10942b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 109439556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis auto event_node = getEventNode(dev_data, event); 109449556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node) { 109459556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->needsSignaled = false; 109469556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis event_node->stageMask = VK_PIPELINE_STAGE_HOST_BIT; 109479556936067fd0c4eb74c4a13631bc163b154faedTobin Ehlis if (event_node->write_in_use) { 109483ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 109493ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 10950414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 109513ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 109523ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 109533ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 10954b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 109556fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 109566fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 109576fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 109586fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 109596fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 109606fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 109616fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 109626fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 109636fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 109643ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 109653ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 109665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 109675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 109685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 109695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1097089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 109715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 109725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 10973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 10974b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 10975651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pFence = getFenceNode(dev_data, fence); 10976651d92815dfff917308137bb67aacccc4f60df86Chris Forbes auto pQueue = getQueueNode(dev_data, queue); 10977651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 109784b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 10979651d92815dfff917308137bb67aacccc4f60df86Chris Forbes skip_call |= ValidateFenceForSubmit(dev_data, pFence); 10980651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 109819867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence) { 109829867daedbf52debc77d6568162ee21e071699b80Chris Forbes SubmitFence(pQueue, pFence, bindInfoCount); 109834b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 10984651d92815dfff917308137bb67aacccc4f60df86Chris Forbes 109851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 109861344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 109875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 109881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 109891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 109901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 109911344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 109925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 10993e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 109945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 109961344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 109971344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 109981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 109991344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 110005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 11001e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 110025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 110051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 110061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 110071344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 110085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 11009e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 110105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110129867daedbf52debc77d6568162ee21e071699b80Chris Forbes 110139867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT> semaphore_waits; 110149867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore> semaphore_signals; 110151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 1101601a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pWaitSemaphores[i]; 1101701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1101801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1101901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 110209867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore->signaler.first != VK_NULL_HANDLE) { 110219867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits.push_back({semaphore, pSemaphore->signaler.first, pSemaphore->signaler.second}); 110229867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 110239867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 110249867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 1102501a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes pSemaphore->signaled = false; 110261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 110271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 110285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 110291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11030414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 110311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 110321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 110335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110361344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 1103701a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes VkSemaphore semaphore = bindInfo.pSignalSemaphores[i]; 1103801a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 1103901a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore) { 1104001a48e41895b3951b297ff4245eff8f9c129ae20Chris Forbes if (pSemaphore->signaled) { 110415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 110425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 110431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 11044414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 110451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 110461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 110475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110489867daedbf52debc77d6568162ee21e071699b80Chris Forbes else { 110499867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = queue; 110509867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.second = pQueue->seq + pQueue->submissions.size() + 1; 110519867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaled = true; 110529867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->in_use.fetch_add(1); 110539867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals.push_back(semaphore); 110549867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 110555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110579867daedbf52debc77d6568162ee21e071699b80Chris Forbes 110589867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 110599867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_waits, 110609867daedbf52debc77d6568162ee21e071699b80Chris Forbes semaphore_signals, 110619867daedbf52debc77d6568162ee21e071699b80Chris Forbes bindIdx == bindInfoCount - 1 ? fence : VK_NULL_HANDLE); 110625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110639867daedbf52debc77d6568162ee21e071699b80Chris Forbes 110649867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pFence && !bindInfoCount) { 110659867daedbf52debc77d6568162ee21e071699b80Chris Forbes // No work to do, just dropping a fence in the queue by itself. 110669867daedbf52debc77d6568162ee21e071699b80Chris Forbes pQueue->submissions.emplace_back(std::vector<VkCommandBuffer>(), 110679867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<SEMAPHORE_WAIT>(), 110689867daedbf52debc77d6568162ee21e071699b80Chris Forbes std::vector<VkSemaphore>(), 110699867daedbf52debc77d6568162ee21e071699b80Chris Forbes fence); 110709867daedbf52debc77d6568162ee21e071699b80Chris Forbes } 110719867daedbf52debc77d6568162ee21e071699b80Chris Forbes 110720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 11073b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 110745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 110765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 110775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1108189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 1108289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 110835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 110855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11086b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 110875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 110889867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.first = VK_NULL_HANDLE; 110899867daedbf52debc77d6568162ee21e071699b80Chris Forbes sNode->signaler.second = 0; 110901344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 110915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 110925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 110935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 110945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 110955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 1109689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 110975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 110985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 110995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 11100b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 111015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 11102293ecfc5e69ed3978a8c04518166d828294870a4Tony Barbour dev_data->eventMap[*pEvent].write_in_use = 0; 111035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 111045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1110889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 1110989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 1111089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 111115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 111125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 111135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 11115b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 111163f687bf405355f3eec6bd1bc0e8d04daba37a0f9Tobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = unique_ptr<SWAPCHAIN_NODE>(new SWAPCHAIN_NODE(pCreateInfo)); 111175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 111205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1112289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1112389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 111245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1112583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 111265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11127b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11128b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11129b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data) { 11130b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_data->images.size() > 0) { 11131b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis for (auto swapchain_image : swapchain_data->images) { 111325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 111335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 111345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 111355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 111365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 111375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 111385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 111415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1114283b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call = 1114383b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis clear_object_binding(dev_data, (uint64_t)swapchain_image, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 1114494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 111455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 111485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11149b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 1115083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (!skip_call) 111515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 111525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 111535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1115489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1115589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 111565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 111575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 111585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 111595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 111605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 111615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 111625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 11163b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 111645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 11165b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis auto swapchain_node = getSwapchainNode(dev_data, swapchain); 11166b110cb87b9478586719d7f7dc769b350857366baTobin Ehlis if (swapchain_node && !swapchain_node->images.empty()) { 111670801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 111680801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 111690801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 111705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 111715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 111725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 111735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 11174414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 111755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 111765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 111775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 111795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 111805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 111815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 111825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 111836d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis // Add imageMap entries for each swapchain image 111846d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis VkImageCreateInfo image_ci = {}; 111856d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.mipLevels = 1; 111866d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 111876d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.usage = swapchain_node->createInfo.imageUsage; 111886d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.format = swapchain_node->createInfo.imageFormat; 1118941ebcb6b517b1de5ae456d46d866f5e84a96a2c5Tobin Ehlis image_ci.samples = VK_SAMPLE_COUNT_1_BIT; 111906d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.width = swapchain_node->createInfo.imageExtent.width; 111916d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.extent.height = swapchain_node->createInfo.imageExtent.height; 111926d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_ci.sharingMode = swapchain_node->createInfo.imageSharingMode; 1119329e9a148072b1015633a102470f0cf706a9e2e55Tobin Ehlis dev_data->imageMap[pSwapchainImages[i]] = unique_ptr<IMAGE_NODE>(new IMAGE_NODE(pSwapchainImages[i], &image_ci)); 1119494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 111956d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->valid = false; 111966d1373829eded68f6e080ff2c33e03231360ed57Tobin Ehlis image_node->mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 111975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 111985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 111995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 112005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 112015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 112025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 112055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 112065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1120789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 112085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 112095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 112105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112116c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes std::lock_guard<std::mutex> lock(global_lock); 112126c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 112136c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 112146c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (pSemaphore && !pSemaphore->signaled) { 112156c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes skip_call |= 112166c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 112176c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 112186c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 112196c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(pPresentInfo->pWaitSemaphores[i])); 112205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112216c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 11222249eb117f85f5e0f3f3a83a2bf297893e0d054ceTobin Ehlis 112236c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 112246c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11225a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (swapchain_data) { 11226a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (pPresentInfo->pImageIndices[i] >= swapchain_data->images.size()) { 11227a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11228d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_INVALID_IMAGE, 11229a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index too large (%u). There are only %u images in this swapchain.", 11230a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i], (uint32_t)swapchain_data->images.size()); 11231a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11232a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes else { 11233a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 11234a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes auto image_node = getImageNode(dev_data, image); 11235a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= ValidateImageMemoryIsValid(dev_data, image_node, "vkQueuePresentKHR()"); 11236a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 11237a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (!image_node->acquired) { 11238a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 11239a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t const &>(pPresentInfo->pSwapchains[i]), __LINE__, DRAWSTATE_SWAPCHAIN_IMAGE_NOT_ACQUIRED, 11240a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "DS", "vkQueuePresentKHR: Swapchain image index %u has not been acquired.", 11241a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes pPresentInfo->pImageIndices[i]); 11242a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 11243a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes 11244a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes vector<VkImageLayout> layouts; 11245a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (FindLayouts(dev_data, image, layouts)) { 11246a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes for (auto layout : layouts) { 11247a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 11248a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes skip_call |= 11249a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 11250a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 11251a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "Images passed to present must be in layout " 11252a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes "VK_IMAGE_LAYOUT_PRESENT_SRC_KHR but is in %s", 11253a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes string_VkImageLayout(layout)); 11254a96bccebcf27add1b38bfe46c541e1484d7b4d88Chris Forbes } 112555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 112605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112616c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (skip_call) { 112626c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 112636c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 112646c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 112656c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes VkResult result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 112666c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes 112676c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes if (result != VK_ERROR_VALIDATION_FAILED_EXT) { 112686c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // Semaphore waits occur before error generation, if the call reached 112696c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes // the ICD. (Confirm?) 112706c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 112716c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, pPresentInfo->pWaitSemaphores[i]); 112729867daedbf52debc77d6568162ee21e071699b80Chris Forbes if (pSemaphore) { 112739867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 112746c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes pSemaphore->signaled = false; 112756c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 112766c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 112779867daedbf52debc77d6568162ee21e071699b80Chris Forbes 11278220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 11279220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Note: this is imperfect, in that we can get confused about what 11280220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // did or didn't succeed-- but if the app does that, it's confused 11281220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // itself just as much. 11282220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto local_result = pPresentInfo->pResults ? pPresentInfo->pResults[i] : result; 11283220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11284220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes if (local_result != VK_SUCCESS && local_result != VK_SUBOPTIMAL_KHR) 11285220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes continue; // this present didn't actually happen. 11286220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11287220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as having been released to the WSI 11288220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, pPresentInfo->pSwapchains[i]); 11289220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[pPresentInfo->pImageIndices[i]]; 11290220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image_node = getImageNode(dev_data, image); 11291220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes image_node->acquired = false; 11292220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes } 11293220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 112949867daedbf52debc77d6568162ee21e071699b80Chris Forbes // Note: even though presentation is directed to a queue, there is no 112959867daedbf52debc77d6568162ee21e071699b80Chris Forbes // direct ordering between QP and subsequent work, so QP (and its 112969867daedbf52debc77d6568162ee21e071699b80Chris Forbes // semaphore waits) /never/ participate in any completion proof. 112976c87c6a8acda49a6406192a1b634e9bf060bd6fdChris Forbes } 112981344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 112995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 113005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11302c827a5880dc3fabfc7d1a58bb62798649cab1181Mark YoungVKAPI_ATTR VkResult VKAPI_CALL CreateSharedSwapchainsKHR(VkDevice device, uint32_t swapchainCount, 11303c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkSwapchainCreateInfoKHR *pCreateInfos, 11304c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young const VkAllocationCallbacks *pAllocator, VkSwapchainKHR *pSwapchains) { 11305c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 11306c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young std::unique_lock<std::mutex> lock(global_lock); 11307c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young VkResult result = 11308c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data->device_dispatch_table->CreateSharedSwapchainsKHR(device, swapchainCount, pCreateInfos, pAllocator, pSwapchains); 11309c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return result; 11310c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young} 11311c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1131289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 1131389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 113145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 1131583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 113161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 11317b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 11318449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11319449670637ef4214b33018f497cf10daeff9dc85bChris Forbes if (fence == VK_NULL_HANDLE && semaphore == VK_NULL_HANDLE) { 11320449670637ef4214b33018f497cf10daeff9dc85bChris Forbes skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 11321d17d86d15a733f1ec988956721ea4b7cdfb6771bChris Forbes reinterpret_cast<uint64_t &>(device), __LINE__, DRAWSTATE_SWAPCHAIN_NO_SYNC_FOR_ACQUIRE, "DS", 11322449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "vkAcquireNextImageKHR: Semaphore and fence cannot both be VK_NULL_HANDLE. There would be no way " 11323449670637ef4214b33018f497cf10daeff9dc85bChris Forbes "to determine the completion of this operation."); 11324449670637ef4214b33018f497cf10daeff9dc85bChris Forbes } 11325449670637ef4214b33018f497cf10daeff9dc85bChris Forbes 11326f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pSemaphore = getSemaphoreNode(dev_data, semaphore); 11327f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore && pSemaphore->signaled) { 1132883b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 1132983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 1133083b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 113315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11332f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11333f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes auto pFence = getFenceNode(dev_data, fence); 11334f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 1133583b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis skip_call |= ValidateFenceForSubmit(dev_data, pFence); 113365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11337b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 113381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 1133983b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) 11340f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 11341f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11342f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes VkResult result = 113435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 11344f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11345f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.lock(); 11346f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (result == VK_SUCCESS || result == VK_SUBOPTIMAL_KHR) { 11347f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pFence) { 11348f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pFence->state = FENCE_INFLIGHT; 113499867daedbf52debc77d6568162ee21e071699b80Chris Forbes pFence->signaler.first = VK_NULL_HANDLE; // ANI isn't on a queue, so this can't participate in a completion proof. 11350f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11351f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes 11352f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes // A successful call to AcquireNextImageKHR counts as a signal operation on semaphore 11353f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes if (pSemaphore) { 11354f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes pSemaphore->signaled = true; 113559867daedbf52debc77d6568162ee21e071699b80Chris Forbes pSemaphore->signaler.first = VK_NULL_HANDLE; 11356f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes } 11357220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes 11358220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes // Mark the image as acquired. 11359220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto swapchain_data = getSwapchainNode(dev_data, swapchain); 11360220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image = swapchain_data->images[*pImageIndex]; 11361220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes auto image_node = getImageNode(dev_data, image); 11362220a9249bd81543e570b3f38c79d9b1e82e0d0dbChris Forbes image_node->acquired = true; 113635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11364f91af4dfe0646cf509616910a8ec2d72c423ccdaChris Forbes lock.unlock(); 113651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 113665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 113675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 113685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11369f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark LobodzinskiVKAPI_ATTR VkResult VKAPI_CALL EnumeratePhysicalDevices(VkInstance instance, uint32_t *pPhysicalDeviceCount, 11370f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkPhysicalDevice *pPhysicalDevices) { 1137183b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis bool skip_call = false; 113723bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes layer_data *instance_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 11373b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes if (instance_data->instance_state) { 11374f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // For this instance, flag when vkEnumeratePhysicalDevices goes to QUERY_COUNT and then QUERY_DETAILS 11375f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11376b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_COUNT; 11377f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11378b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes if (UNCALLED == instance_data->instance_state->vkEnumeratePhysicalDevicesState) { 11379f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Flag warning here. You can call this without having queried the count, but it may not be 11380f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // robust on platforms with multiple physical devices. 11381b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 11382f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11383f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call sequence has vkEnumeratePhysicalDevices() w/ non-NULL pPhysicalDevices. You should first " 11384f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "call vkEnumeratePhysicalDevices() w/ NULL pPhysicalDevices to query pPhysicalDeviceCount."); 11385f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } // TODO : Could also flag a warning if re-calling this function in QUERY_DETAILS state 11386b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes else if (instance_data->instance_state->physical_devices_count != *pPhysicalDeviceCount) { 11387f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Having actual count match count from app is not a requirement, so this can be a warning 11388b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes skip_call |= log_msg(instance_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11389f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11390f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "Call to vkEnumeratePhysicalDevices() w/ pPhysicalDeviceCount value %u, but actual count " 11391f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski "supported by this instance is %u.", 11392b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes *pPhysicalDeviceCount, instance_data->instance_state->physical_devices_count); 11393f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11394b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->vkEnumeratePhysicalDevicesState = QUERY_DETAILS; 11395f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 1139683b40cb743b7d87753e7503b148fef660ca45289Tobin Ehlis if (skip_call) { 11397f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11398f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11399f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski VkResult result = 11400b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_dispatch_table->EnumeratePhysicalDevices(instance, pPhysicalDeviceCount, pPhysicalDevices); 11401f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski if (NULL == pPhysicalDevices) { 11402b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes instance_data->instance_state->physical_devices_count = *pPhysicalDeviceCount; 114035f270eedee8426a5b556a8a9432dd836d83f7b51Tony Barbour } else if (result == VK_SUCCESS){ // Save physical devices 11404f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski for (uint32_t i = 0; i < *pPhysicalDeviceCount; i++) { 114053bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes auto & phys_device_state = instance_data->physical_device_map[pPhysicalDevices[i]]; 114063bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes phys_device_state.phys_device = pPhysicalDevices[i]; 11407f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski // Init actual features for each physical device 114083bb2c67470811e4eaf908b3eade82f73aa3f87bcChris Forbes instance_data->instance_dispatch_table->GetPhysicalDeviceFeatures(pPhysicalDevices[i], &phys_device_state.features); 11409f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11410f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11411f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return result; 11412f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } else { 11413b1f16c99e817d67a9f6c87d92e312478de4721d7Chris Forbes log_msg(instance_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_INSTANCE_EXT, 0, __LINE__, 11414f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski DEVLIMITS_INVALID_INSTANCE, "DL", "Invalid instance (0x%" PRIxLEAST64 ") passed into vkEnumeratePhysicalDevices().", 11415f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski (uint64_t)instance); 11416f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski } 11417f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski return VK_ERROR_VALIDATION_FAILED_EXT; 11418f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski} 11419f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski 11420cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiVKAPI_ATTR void VKAPI_CALL 11421cd569b3559a7f8dca06012165480a4e6d7e6c492Mark LobodzinskiGetPhysicalDeviceQueueFamilyProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, 11422cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VkQueueFamilyProperties *pQueueFamilyProperties) { 11423cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski bool skip_call = false; 11424cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski layer_data *phy_dev_data = get_my_data_ptr(get_dispatch_key(physicalDevice), layer_data_map); 114254b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes auto physical_device_state = getPhysicalDeviceState(phy_dev_data, physicalDevice); 114264b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state) { 114274b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 114284b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_COUNT; 11429cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11430cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11431cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Verify that for each physical device, this function is called first with NULL pQueueFamilyProperties ptr in order to 11432cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // get count 114334b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (UNCALLED == physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState) { 11434cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11435cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_MISSING_QUERY_COUNT, "DL", 11436cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call sequence has vkGetPhysicalDeviceQueueFamilyProperties() w/ non-NULL " 11437cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "pQueueFamilyProperties. You should first call vkGetPhysicalDeviceQueueFamilyProperties() w/ " 11438cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "NULL pQueueFamilyProperties to query pCount."); 11439cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11440cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // Then verify that pCount that is passed in on second call matches what was returned 114414b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (physical_device_state->queueFamilyPropertiesCount != *pCount) { 11442cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 11443cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // TODO: this is not a requirement of the Valid Usage section for vkGetPhysicalDeviceQueueFamilyProperties, so 11444cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski // provide as warning 11445cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski skip_call |= log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 11446cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, DEVLIMITS_COUNT_MISMATCH, "DL", 11447cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Call to vkGetPhysicalDeviceQueueFamilyProperties() w/ pCount value %u, but actual count " 11448cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "supported by this physicalDevice is %u.", 114494b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes *pCount, physical_device_state->queueFamilyPropertiesCount); 11450cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 114514b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->vkGetPhysicalDeviceQueueFamilyPropertiesState = QUERY_DETAILS; 11452cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11453cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski if (skip_call) { 11454cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11455cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11456cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(physicalDevice, pCount, 11457cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski pQueueFamilyProperties); 114584b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes if (!pQueueFamilyProperties) { 114594b293996aa6a9bd92ef1f0175eca4b0e8a9fd9fcChris Forbes physical_device_state->queueFamilyPropertiesCount = *pCount; 11460cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11461cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { // Save queue family properties 11462cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.reserve(*pCount); 11463cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski for (uint32_t i = 0; i < *pCount; i++) { 11464cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski phy_dev_data->queue_family_properties.emplace_back(new VkQueueFamilyProperties(pQueueFamilyProperties[i])); 11465cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11466cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11467cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski return; 11468cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11469cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski else { 11470cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski log_msg(phy_dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 11471cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski __LINE__, DEVLIMITS_INVALID_PHYSICAL_DEVICE, "DL", 11472cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski "Invalid physicalDevice (0x%" PRIxLEAST64 ") passed into vkGetPhysicalDeviceQueueFamilyProperties().", 11473cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski (uint64_t)physicalDevice); 11474cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski } 11475cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski} 11476cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski 1147789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 1147889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 1147989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 114805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 114815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 114825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 114835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 11484b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 11485c34ab18ac7c064590a1020a8db4b6abf5a8d3a18Mark Lobodzinski res = layer_create_msg_callback(my_data->report_data, false, pCreateInfo, pAllocator, pMsgCallback); 114865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 114875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 114885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1149089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 1149189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 1149289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 114935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 114945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 114955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11496b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 114975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 114985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 114995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1150089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 1150189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 1150289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 115035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 115045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 115055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 115065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11508a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11509a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11510a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11511a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11512a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11513a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11514a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11515a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetLayerProperties(1, &global_layer, pCount, pProperties); 11516a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11517a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11518a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11519a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I WuEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11520a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 11521a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return util_GetExtensionProperties(1, instance_extensions, pCount, pProperties); 11522a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 11523a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return VK_ERROR_LAYER_NOT_PRESENT; 11524a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu} 11525a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu 1152689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 1152789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 1152889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 11529a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 1153008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 11531a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11532a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 11533a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 11534a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 11535a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 11536a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 1153708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1153808939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1153980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 115407ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 115417ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 115427ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1154380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 1154480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1154509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1154609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 1154709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1154889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 1154980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 1155080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 1155180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 1155280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1155380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 115545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1155509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 1155609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 1155709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 1155809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 115595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 115605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 115615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 115635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 115645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 115655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 115665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 115675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 115685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 115695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1157089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 115717ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 115723f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 115733f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 115743f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 115753f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 115767ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 115777ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 115785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115797ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 115805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 115825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 115837ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 115847ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 115857ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 115865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 115875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 115885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 115895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 115905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 115915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1159208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1159380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 115947ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 115957ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 115967ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 115977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 115987ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 115997ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 116007ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 116017ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 116027ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 11603f83fcc51d156b056966509bfe4d05c9ccb37ce5dMark Lobodzinski { "vkEnumeratePhysicalDevices", reinterpret_cast<PFN_vkVoidFunction>(EnumeratePhysicalDevices) }, 11604cd569b3559a7f8dca06012165480a4e6d7e6c492Mark Lobodzinski { "vkGetPhysicalDeviceQueueFamilyProperties", reinterpret_cast<PFN_vkVoidFunction>(GetPhysicalDeviceQueueFamilyProperties) }, 116057ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 11606a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceLayerProperties) }, 11607a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateDeviceLayerProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceLayerProperties) }, 11608a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu { "vkEnumerateInstanceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateInstanceExtensionProperties) }, 116097ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 116107ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 116117ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 116127ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 116137ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 116147ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 116157ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 116167ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 116177ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 116187ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 116197ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 116207ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1162180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1162280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1162380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1162480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1162580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 11626593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 11627593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 11628593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 11629593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 11630593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 11631593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 11632593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 11633593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 11634593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 11635593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 11636593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 11637593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 11638593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 11639593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 11640593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 11641593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 11642593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 11643593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 11644593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 11645593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 11646593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 11647593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 11648593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 11649593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 11650593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 11651593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 11652593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 11653593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 11654593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 11655593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 11656593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 11657593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 11658593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 11659593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 11660593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 11661593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 11662593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 11663593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 11664593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 11665593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 11666593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 11667593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 11668593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 11669593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 11670593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 11671593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 11672593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 11673593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 11674593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 11675593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 11676593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 11677593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 11678593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 11679593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 11680593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 11681593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 11682593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 11683593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 11684593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 11685593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 11686593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 11687593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 11688593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 11689593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 11690593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 11691593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 11692593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 11693593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 11694593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 11695593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 11696593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 11697593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 11698593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 11699593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 11700593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 11701593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 11702593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 11703593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 11704593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 11705593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 11706593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 11707593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 11708593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 11709593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 11710593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 11711593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 11712593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 11713593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 11714593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 11715593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 11716593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 11717593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 11718593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 11719593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 11720593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 11721593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 11722593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 11723593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 11724593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 11725593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 11726593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 11727593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 11728593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 11729593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 11730593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 11731593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 11732593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 11733593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 11734593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 11735593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 11736593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 11737593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 11738593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 11739593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 11740593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 11741593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1174280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1174380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1174480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1174580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1174680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1174780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1174880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1174980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1175080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1175180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1175209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1175309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1175409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1175509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1175609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1175709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1175809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1175909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1176009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1176109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1176209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1176309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 11764c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young layer_data *dev_data = nullptr; 1176509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 117663f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 11767c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 117683f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 117693f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 117703f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1177109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1177209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1177309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1177409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1177509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1177609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11777c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (dev_data) { 11778c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!dev_data->device_extensions.wsi_display_swapchain_enabled) 11779c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return nullptr; 11780c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young } 11781c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 11782c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young if (!strcmp("vkCreateSharedSwapchainsKHR", name)) 11783c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young return reinterpret_cast<PFN_vkVoidFunction>(CreateSharedSwapchainsKHR); 11784c827a5880dc3fabfc7d1a58bb62798649cab1181Mark Young 1178509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1178609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1178709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 11788d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 11789d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11790d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 11791d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11792d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 11793d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 11794d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1179589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 11796d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11797d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11798d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11799d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 11800d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 11801d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1180289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 11803d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11804d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11805d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 11806d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 11807d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1180889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 11809d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11810d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11811a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu// loader-layer interface v0, just wrappers since there is only a layer 11812d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1181308939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1181408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 11815a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceExtensionProperties(pLayerName, pCount, pProperties); 1181608939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1181708939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1181808939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1181908939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 11820a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateInstanceLayerProperties(pCount, pProperties); 1182108939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1182208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1182308939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1182408939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 11825a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11826a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11827a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu return core_validation::EnumerateDeviceLayerProperties(VK_NULL_HANDLE, pCount, pProperties); 11828d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11829d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11830d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 11831d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 11832d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 11833a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine internally 11834a4e71cd8b4e77502943dd894ed95426a25dffbd5Chia-I Wu assert(physicalDevice == VK_NULL_HANDLE); 11835a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 11836d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11837d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11838d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1183989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 11840d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 11841d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 11842d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 1184389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1184408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 11845