core_validation.cpp revision 4b70ef75f98d2a6196132d8c48d43d1d5e04992e
15b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* Copyright (c) 2015-2016 The Khronos Group Inc. 25b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 Valve Corporation 35b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (c) 2015-2016 LunarG, Inc. 45b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Copyright (C) 2015-2016 Google Inc. 55b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Licensed under the Apache License, Version 2.0 (the "License"); 743b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * you may not use this file except in compliance with the License. 843b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * You may obtain a copy of the License at 95b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1043b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * http://www.apache.org/licenses/LICENSE-2.0 115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 1243b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * Unless required by applicable law or agreed to in writing, software 1343b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * distributed under the License is distributed on an "AS IS" BASIS, 1443b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. 1543b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * See the License for the specific language governing permissions and 1643b53e83705f02245da6ae61e31273866a35b833Jon Ashburn * limitations under the License. 175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Cody Northrop <cnorthrop@google.com> 195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Michael Lentine <mlentine@google.com> 205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Tobin Ehlis <tobine@google.com> 215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chia-I Wu <olv@google.com> 225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Chris Forbes <chrisf@ijw.co.nz> 235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Mark Lobodzinski <mark@lunarg.com> 245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Author: Ian Elliott <ianelliott@google.com> 255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Allow use of STL min and max functions in Windows 285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define NOMINMAX 295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Turn on mem_tracker merged code 3103b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#define MTMERGESOURCE 1 325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <SPIRV/spirv.hpp> 3494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <algorithm> 3594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <assert.h> 3694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <iostream> 3794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <list> 3894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <map> 39b9e992386a44404152747d66817a733aa127e281Jeremy Hayes#include <mutex> 4094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <set> 415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdio.h> 425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <stdlib.h> 435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <string.h> 4494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis#include <string> 45dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes#include <tuple> 465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_loader_platform.h" 485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_dispatch_table_helper.h" 495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_string_helper_cpp.h" 505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic ignored "-Wwrite-strings" 525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined(__GNUC__) 545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#pragma GCC diagnostic warning "-Wwrite-strings" 555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_struct_size_helper.h" 575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "core_validation.h" 585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_table.h" 595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_data.h" 605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_extension_utils.h" 615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include "vk_layer_utils.h" 62b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes#include "spirv-tools/libspirv.h" 635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if defined __ANDROID__ 655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#include <android/log.h> 665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#define LOGCONSOLE(...) ((void)__android_log_print(ANDROID_LOG_INFO, "DS", __VA_ARGS__)) 675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 68c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine#define LOGCONSOLE(...) \ 69c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine { \ 70c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf(__VA_ARGS__); \ 71c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine printf("\n"); \ 72c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Muellerusing namespace std; 76414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 7771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis// TODO : CB really needs it's own class and files so this is just temp code until that happens 7871511c5a10533c910bfe62c3bcf58e2a4054e7acTobin EhlisGLOBAL_CB_NODE::~GLOBAL_CB_NODE() { 7971511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (uint32_t i=0; i<VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 8071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis // Make sure that no sets hold onto deleted CB binding 8171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis for (auto set : lastBound[i].uniqueBoundSets) { 8271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(this); 8371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } 8571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis} 8671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis 87d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wunamespace core_validation { 88d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_map; 905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisusing std::unordered_set; 915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// WSI Image Objects bypass usual Image Object creation methods. A special Memory 935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Object value will be used to identify them internally. 945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkDeviceMemory MEMTRACKER_SWAP_CHAIN_IMAGE_KEY = (VkDeviceMemory)(-1); 95b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track command pools and their command buffers 975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct CMD_POOL_INFO { 985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPoolCreateFlags createFlags; 995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t queueFamilyIndex; 1005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis list<VkCommandBuffer> commandBuffers; // list container of cmd buffers allocated from this pool 1015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct devExts { 104e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool wsi_enabled; 1055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSwapchainKHR, SWAPCHAIN_NODE *> swapchainMap; 1065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, VkSwapchainKHR> imageToSwapchainMap; 1075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// fwd decls 1105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module; 1115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 112b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Split this into separate structs for instance and device level data? 1135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct layer_data { 11456a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu VkInstance instance; 11556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu 1165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis debug_report_data *report_data; 1175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkDebugReportCallbackEXT> logging_callback; 1185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *device_dispatch_table; 1195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *instance_dispatch_table; 12094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis 1215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis devExts device_extensions; 122b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski unordered_set<VkQueue> queues; // all queues under given device 1235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Global set of all cmdBuffers that are inFlight on this device 1245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<VkCommandBuffer> globalInFlightCmdBuffers; 1255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Layer specific data 126cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkSampler, unique_ptr<SAMPLER_NODE>> samplerMap; 1275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImageView, VkImageViewCreateInfo> imageViewMap; 1285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, IMAGE_NODE> imageMap; 1295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBufferView, VkBufferViewCreateInfo> bufferViewMap; 1305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkBuffer, BUFFER_NODE> bufferMap; 1315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipeline, PIPELINE_NODE *> pipelineMap; 1325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkCommandPool, CMD_POOL_INFO> commandPoolMap; 1335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkDescriptorPool, DESCRIPTOR_POOL_NODE *> descriptorPoolMap; 134397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis unordered_map<VkDescriptorSet, cvdescriptorset::DescriptorSet *> setMap; 135cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis unordered_map<VkDescriptorSetLayout, cvdescriptorset::DescriptorSetLayout *> descriptorSetLayoutMap; 1365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkPipelineLayout, PIPELINE_LAYOUT_NODE> pipelineLayoutMap; 13758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis unordered_map<VkDeviceMemory, DEVICE_MEM_INFO> memObjMap; 1385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFence, FENCE_NODE> fenceMap; 1395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueue, QUEUE_NODE> queueMap; 1405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkEvent, EVENT_NODE> eventMap; 1415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, bool> queryToStateMap; 1425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkQueryPool, QUERY_POOL_NODE> queryPoolMap; 1435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkSemaphore, SEMAPHORE_NODE> semaphoreMap; 14472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis unordered_map<VkCommandBuffer, GLOBAL_CB_NODE *> commandBufferMap; 1455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkFramebuffer, FRAMEBUFFER_NODE> frameBufferMap; 1465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkImage, vector<ImageSubresourcePair>> imageSubresourceMap; 1475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<ImageSubresourcePair, IMAGE_LAYOUT_NODE> imageLayoutMap; 1485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<VkRenderPass, RENDER_PASS_NODE *> renderPassMap; 149918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes unordered_map<VkShaderModule, unique_ptr<shader_module>> shaderModuleMap; 1506c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes VkDevice device; 1515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Device specific data 153b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis PHYS_DEV_PROPERTIES_NODE phys_dev_properties; 154b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkPhysicalDeviceMemoryProperties phys_dev_mem_props; 155b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 1565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data() 15794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis : report_data(nullptr), device_dispatch_table(nullptr), instance_dispatch_table(nullptr), device_extensions(), 158a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis device(VK_NULL_HANDLE), phys_dev_properties{}, phys_dev_mem_props{} {}; 1595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 1605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 161b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis// TODO : Do we need to guard access to layer_data_map w/ lock? 162b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic unordered_map<void *, layer_data *> layer_data_map; 163b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 164e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wustatic const VkLayerProperties global_layer = { 165f1ea418f193d10a8455cdf47e0eeeeb1f4d8b5bfJon Ashburn "VK_LAYER_LUNARG_core_validation", VK_LAYER_API_VERSION, 1, "LunarG Validation Layer", 166e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu}; 1675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class TCreateInfo> void ValidateLayerOrdering(const TCreateInfo &createInfo) { 1695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool foundLayer = false; 1705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < createInfo.enabledLayerCount; ++i) { 171e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu if (!strcmp(createInfo.ppEnabledLayerNames[i], global_layer.layerName)) { 1725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis foundLayer = true; 1735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This has to be logged to console as we don't have a callback at this point. 1755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!foundLayer && !strcmp(createInfo.ppEnabledLayerNames[0], "VK_LAYER_GOOGLE_unique_objects")) { 1765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis LOGCONSOLE("Cannot activate layer VK_LAYER_GOOGLE_unique_objects prior to activating %s.", 177e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu global_layer.layerName); 1785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 1815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Code imported from shader_checker 1835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *); 1845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// A forward iterator over spirv instructions. Provides easy access to len, opcode, and content words 1865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// without the caller needing to care too much about the physical SPIRV module layout. 1875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct spirv_inst_iter { 1885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator zero; 1895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<uint32_t>::const_iterator it; 1905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 191b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t len() { 192b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes auto result = *it >> 16; 193b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(result > 0); 194b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return result; 195b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 196b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 1975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t opcode() { return *it & 0x0ffffu; } 198b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 199b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes uint32_t const &word(unsigned n) { 200b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes assert(n < len()); 201b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes return it[n]; 202b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes } 203b95616f79b105741b1399b01d527a8ef3b7ccfb7Chris Forbes 2045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset() { return (uint32_t)(it - zero); } 2055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter() {} 2075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter(std::vector<uint32_t>::const_iterator zero, std::vector<uint32_t>::const_iterator it) : zero(zero), it(it) {} 2095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator==(spirv_inst_iter const &other) { return it == other.it; } 2115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool operator!=(spirv_inst_iter const &other) { return it != other.it; } 2135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++(int) { /* x++ */ 2155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter ii = *this; 2165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ii; 2185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter operator++() { /* ++x; */ 2215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it += len(); 2225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return *this; 2235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* The iterator and the value are the same thing. */ 2265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter &operator*() { return *this; } 2275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter const &operator*() const { return *this; } 2285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct shader_module { 2315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* the spirv image itself */ 2325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<uint32_t> words; 2335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* a mapping of <id> to the first word of its def. this is useful because walking type 2345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * trees, constant expressions, etc requires jumping all over the instruction stream. 2355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 2365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<unsigned, unsigned> def_index; 2375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module(VkShaderModuleCreateInfo const *pCreateInfo) 2395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis : words((uint32_t *)pCreateInfo->pCode, (uint32_t *)pCreateInfo->pCode + pCreateInfo->codeSize / sizeof(uint32_t)), 2405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def_index() { 2415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis build_def_index(this); 2435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* expose begin() / end() to enable range-based for */ 2465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter begin() const { return spirv_inst_iter(words.begin(), words.begin() + 5); } /* first insn */ 2475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter end() const { return spirv_inst_iter(words.begin(), words.end()); } /* just past last insn */ 2485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* given an offset into the module, produce an iterator there. */ 2495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter at(unsigned offset) const { return spirv_inst_iter(words.begin(), words.begin() + offset); } 2505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* gets an iterator to the definition of an id */ 2525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter get_def(unsigned id) const { 2535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = def_index.find(id); 2545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == def_index.end()) { 2555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return end(); 2565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return at(it->second); 2585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 2605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This can be much smarter, using separate locks for separate global data 262b9e992386a44404152747d66817a733aa127e281Jeremy Hayesstatic std::mutex global_lock; 263593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 26494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic VkDeviceMemory *get_object_mem_binding(layer_data *my_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 2655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 2665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: { 26794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->imageMap.find(VkImage(handle)); 26894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->imageMap.end()) 26994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: { 27394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto it = my_data->bufferMap.find(VkBuffer(handle)); 27494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (it != my_data->bufferMap.end()) 27594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return &(*it).second.mem; 2765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 2795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 2805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis return nullptr; 2825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 2835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 28472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis// prototype 2855121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *, const VkCommandBuffer); 28672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis 2875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate correct usage bits set for buffers or images 2885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that (actual & desired) flags != 0 or, 2895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// if strict is true, verify that (actual & desired) flags == desired 2905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// In case of error, report it via dbg callbacks 2910a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_usage_flags(layer_data *my_data, VkFlags actual, VkFlags desired, VkBool32 strict, 2920a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes uint64_t obj_handle, VkDebugReportObjectTypeEXT obj_type, char const *ty_str, 2930a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes char const *func_name, char const *usage_str) { 294e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool correct_usage = false; 295e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 2965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strict) 2975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) == desired); 2985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 2995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis correct_usage = ((actual & desired) != 0); 3005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!correct_usage) { 3015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, obj_type, obj_handle, __LINE__, 302414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_USAGE_FLAG, "MEM", "Invalid usage flag for %s 0x%" PRIxLEAST64 3035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " used by %s. In this case, %s should have %s set during creation.", 3045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ty_str, obj_handle, func_name, ty_str, usage_str); 3055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for images 3105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls image info and then sends actual vs. desired usage off to helper above where 3115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3120a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_image_usage_flags(layer_data *dev_data, VkImage image, VkFlags desired, VkBool32 strict, 31394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 314e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 31594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 31694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 3170a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, image_node->second.createInfo.usage, desired, strict, (uint64_t)image, 3185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "image", func_name, usage_string); 3195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Helper function to validate usage flags for buffers 3245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Pulls buffer info and then sends actual vs. desired usage off to helper above where 3255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// an error will be flagged if usage is not correct 3260a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool validate_buffer_usage_flags(layer_data *dev_data, VkBuffer buffer, VkFlags desired, VkBool32 strict, 32794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis char const *func_name, char const *usage_string) { 328e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 32994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const buffer_node = dev_data->bufferMap.find(buffer); 33094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 3310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = validate_usage_flags(dev_data, buffer_node->second.createInfo.usage, desired, strict, (uint64_t)buffer, 3325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "buffer", func_name, usage_string); 3335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 3355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return ptr to info in map container containing mem, or NULL if not found 3385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Calls to this function should be wrapped in mutex 33958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic DEVICE_MEM_INFO *get_mem_obj_info(layer_data *dev_data, const VkDeviceMemory mem) { 34058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto item = dev_data->memObjMap.find(mem); 34158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (item != dev_data->memObjMap.end()) { 3425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return &(*item).second; 3435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 3455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void add_mem_obj_info(layer_data *my_data, void *object, const VkDeviceMemory mem, 3495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkMemoryAllocateInfo *pAllocateInfo) { 3505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(object != NULL); 3515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(&my_data->memObjMap[mem].allocInfo, pAllocateInfo, sizeof(VkMemoryAllocateInfo)); 3535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Update for real hardware, actually process allocation info structures 3545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].allocInfo.pNext = NULL; 3555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].object = object; 3565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].mem = mem; 35758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis my_data->memObjMap[mem].image = VK_NULL_HANDLE; 3585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.offset = 0; 3595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].memRange.size = 0; 3605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pData = 0; 3615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].pDriverData = 0; 3625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap[mem].valid = false; 3635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 365e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_memory_is_valid(layer_data *dev_data, VkDeviceMemory mem, const char *functionName, 366e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImage image = VK_NULL_HANDLE) { 3675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 36894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto const image_node = dev_data->imageMap.find(image); 36994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end() && !image_node->second.valid) { 37058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 372414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid swapchain image 0x%" PRIx64 ", please fill the memory before using.", 3735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis functionName, (uint64_t)(image)); 3745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj && !pMemObj->valid) { 37858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 3795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem), __LINE__, MEMTRACK_INVALID_USAGE_FLAG, "MEM", 380414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Cannot read invalid memory 0x%" PRIx64 ", please fill the memory before using.", functionName, 3815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(mem)); 3825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 3855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlisstatic void set_memory_valid(layer_data *dev_data, VkDeviceMemory mem, bool valid, VkImage image = VK_NULL_HANDLE) { 3885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 38994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 39094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 39194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.valid = valid; 3925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 39458070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 3955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 3965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = valid; 3975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find CB Info and add mem reference to list container 4025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Find Mem Obj Info and add CB reference to list container 403e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool update_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb, const VkDeviceMemory mem, 404e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *apiName) { 405e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Skip validation if this image was created through WSI 4085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem != MEMTRACKER_SWAP_CHAIN_IMAGE_KEY) { 4095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First update CB binding in MemObj mini CB list 41158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 4125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemInfo) { 413de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemInfo->commandBufferBindings.insert(cb); 4145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now update CBInfo's Mem reference list 41572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBNode = getCBNode(dev_data, cb); 4165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: keep track of all destroyed CBs so we know if this is a stale or simply invalid object 41772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 418c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.insert(mem); 4195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 424400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// For every mem obj bound to particular CB, free bindings related to that CB 425400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, GLOBAL_CB_NODE *pCBNode) { 42672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCBNode) { 427c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBNode->memObjs.size() > 0) { 428c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto mem : pCBNode->memObjs) { 42920b3e28d96ae4f3cbd4535e53eb68521d31bb91bChris Forbes DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 431400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis pInfo->commandBufferBindings.erase(pCBNode->commandBuffer); 4325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 434c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes pCBNode->memObjs.clear(); 4355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBNode->validate_functions.clear(); 4375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 439400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis// Overloaded call to above function when GLOBAL_CB_NODE has not already been looked-up 440400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void clear_cmd_buf_and_mem_references(layer_data *dev_data, const VkCommandBuffer cb) { 441400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, getCBNode(dev_data, cb)); 4425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given MemObjInfo, report Obj & CB bindings 445e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool reportMemReferencesAndCleanUp(layer_data *dev_data, DEVICE_MEM_INFO *pMemObjInfo) { 446e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 447de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes size_t cmdBufRefCount = pMemObjInfo->commandBufferBindings.size(); 448896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes size_t objRefCount = pMemObjInfo->objBindings.size(); 4495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 450de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if ((pMemObjInfo->commandBufferBindings.size()) != 0) { 45158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 453414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory object 0x%" PRIxLEAST64 " which still contains " PRINTF_SIZE_T_SPECIFIER 4545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " references", 4555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemObjInfo->mem, (cmdBufRefCount + objRefCount)); 4565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 458de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (cmdBufRefCount > 0 && pMemObjInfo->commandBufferBindings.size() > 0) { 459de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pMemObjInfo->commandBufferBindings) { 46058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 461de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes (uint64_t)cb, __LINE__, MEMTRACK_FREED_MEM_REF, "MEM", 462414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%p still has a reference to mem obj 0x%" PRIxLEAST64, cb, (uint64_t)pMemObjInfo->mem); 4635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 465de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pMemObjInfo->commandBufferBindings.clear(); 4665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 468896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (objRefCount > 0 && pMemObjInfo->objBindings.size() > 0) { 469896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pMemObjInfo->objBindings) { 470896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, obj.type, obj.handle, __LINE__, 471414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_FREED_MEM_REF, "MEM", "VK Object 0x%" PRIxLEAST64 " still has a reference to mem obj 0x%" PRIxLEAST64, 472896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes obj.handle, (uint64_t)pMemObjInfo->mem); 4735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear the list of hanging references 475896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pMemObjInfo->objBindings.clear(); 4765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 480e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemObjInfo(layer_data *my_data, void *object, VkDeviceMemory mem) { 481e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = my_data->memObjMap.find(mem); 4835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != my_data->memObjMap.end()) { 4845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->memObjMap.erase(item); 4855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 4875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 488414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Request to delete memory object 0x%" PRIxLEAST64 " not present in memory Object Map", (uint64_t)mem); 4895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 4915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 493e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool freeMemObjInfo(layer_data *dev_data, void *object, VkDeviceMemory mem, bool internal) { 494e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 4955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Parse global list to find info w/ mem 49658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 4975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo) { 4985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize == 0 && !internal) { 4995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section 50058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 5015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MEM_OBJ, "MEM", 502414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempting to free memory associated with a Persistent Image, 0x%" PRIxLEAST64 ", " 5035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this should not be explicitly freed\n", 5045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem); 5055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clear any CB bindings for completed CBs 5075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Is there a better place to do this? 5085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(pInfo->object != VK_NULL_HANDLE); 510de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // clear_cmd_buf_and_mem_references removes elements from 511de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // pInfo->commandBufferBindings -- this copy not needed in c++14, 512de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes // and probably not needed in practice in c++11 513de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes auto bindings = pInfo->commandBufferBindings; 514de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : bindings) { 515a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->globalInFlightCmdBuffers.count(cb)) { 516de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 5175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify that no references to this mem obj remain and remove bindings 521de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() || pInfo->objBindings.size()) { 52258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= reportMemReferencesAndCleanUp(dev_data, pInfo); 5235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete mem obj info 52558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall |= deleteMemObjInfo(dev_data, object, mem); 5265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const char *object_type_to_string(VkDebugReportObjectTypeEXT type) { 5325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type) { 5335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT: 5345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 5355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT: 5365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "buffer"; 5375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT: 5385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "swapchain"; 5395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 5405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 5415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Remove object binding performs 3 tasks: 5455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// 1. Remove ObjectInfo from MemObjInfo list container of obj bindings & free it 546c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes// 2. Clear mem binding for image/buffer by setting its handle to 0 5475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : This only applied to Buffer, Image, and Swapchain objects now, how should it be updated/customized? 5480a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool clear_object_binding(layer_data *dev_data, uint64_t handle, VkDebugReportObjectTypeEXT type) { 5495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to customize images/buffers/swapchains to track mem binding and clear it here appropriately 550e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 55194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 55294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 55394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DEVICE_MEM_INFO *pMemObjInfo = get_mem_obj_info(dev_data, *pMemBinding); 5545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Make sure this is a reasonable way to reset mem binding 55594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *pMemBinding = VK_NULL_HANDLE; 5565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObjInfo) { 557c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes // This obj is bound to a memory object. Remove the reference to this object in that memory object's list, 5585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // and set the objects memory binding pointer to NULL. 559896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (!pMemObjInfo->objBindings.erase({handle, type})) { 5605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 56158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 562414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "While trying to clear mem binding for %s obj 0x%" PRIxLEAST64 563414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ", unable to find that object referenced by mem obj 0x%" PRIxLEAST64, 5645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type), handle, (uint64_t)pMemObjInfo->mem); 5655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 5695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, output warning 5725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in global object map 5735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, output validation error 5745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Otherwise, add reference from objectInfo to memoryInfo 5755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of objInfo 57694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlisstatic bool set_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 57794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDebugReportObjectTypeEXT type, const char *apiName) { 578e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 5805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 5815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section of spec. 58258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_MEM_OBJ, 583414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "In %s, attempting to Bind Obj(0x%" PRIxLEAST64 ") to NULL", apiName, handle); 5845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 58594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 5862e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 5872e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis DEVICE_MEM_INFO *pMemInfo = get_mem_obj_info(dev_data, mem); 5882e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pMemInfo) { 5892e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis DEVICE_MEM_INFO *pPrevBinding = get_mem_obj_info(dev_data, *pMemBinding); 5902e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pPrevBinding != NULL) { 5912e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 5922e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_REBIND_OBJECT, 5932e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis "MEM", "In %s, attempting to bind memory (0x%" PRIxLEAST64 ") to object (0x%" PRIxLEAST64 5942e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis ") which has already been bound to mem object 0x%" PRIxLEAST64, 5952e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis apiName, (uint64_t)mem, handle, (uint64_t)pPrevBinding->mem); 5962e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis } else { 5972e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pMemInfo->objBindings.insert({handle, type}); 5982e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // For image objects, make sure default memory state is correctly set 5992e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO : What's the best/correct way to handle this? 6002e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT == type) { 6012e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis auto const image_node = dev_data->imageMap.find(VkImage(handle)); 6022e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (image_node != dev_data->imageMap.end()) { 6032e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis VkImageCreateInfo ici = image_node->second.createInfo; 6042e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (ici.usage & (VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT | VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT)) { 6052e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // TODO:: More memory state transition stuff. 6065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6092e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 6105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For NULL mem case, clear any previous binding Else... 6175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Make sure given object is in its object map 6185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// IF a previous binding existed, update binding 6195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference from objectInfo to memoryInfo 6205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add reference off of object's binding info 6210a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes// Return VK_TRUE if addition is successful, VK_FALSE otherwise 6220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool set_sparse_mem_binding(layer_data *dev_data, VkDeviceMemory mem, uint64_t handle, 6230a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes VkDebugReportObjectTypeEXT type, const char *apiName) { 6240a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes bool skipCall = VK_FALSE; 6255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Handle NULL case separately, just clear previous binding & decrement reference 6265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem == VK_NULL_HANDLE) { 6270a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, handle, type); 6285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 6302e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis assert(pMemBinding); 6312e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis DEVICE_MEM_INFO *pInfo = get_mem_obj_info(dev_data, mem); 6322e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis if (pInfo) { 6332e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis pInfo->objBindings.insert({handle, type}); 6342e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis // Need to set mem binding for this object 6352e415b757c1e43fda35311aad026af8d5c96681cTobin Ehlis *pMemBinding = mem; 6365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given Object, get 'mem' obj that it's bound to or NULL if no binding 6420a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic bool get_mem_binding_from_object(layer_data *dev_data, const uint64_t handle, 64394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis const VkDebugReportObjectTypeEXT type, VkDeviceMemory *mem) { 644e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *mem = VK_NULL_HANDLE; 64694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkDeviceMemory *pMemBinding = get_object_mem_binding(dev_data, handle, type); 64794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (pMemBinding) { 64894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis *mem = *pMemBinding; 6495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 65094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, type, handle, __LINE__, MEMTRACK_INVALID_OBJECT, 651414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Trying to get mem binding for object 0x%" PRIxLEAST64 " but no such object in %s list", handle, 6525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis object_type_to_string(type)); 6535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 6555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 6565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print details of MemObjInfo list 6580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void print_mem_list(layer_data *dev_data) { 65958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 6605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 66258070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (!(dev_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 6635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Just printing each msg individually for now, may want to package these into single large print 66758070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "Details of Memory Object list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 66958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis dev_data->memObjMap.size()); 67058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 6715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "============================="); 6725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (dev_data->memObjMap.size() <= 0) 6745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 6755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 6775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 6785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 67958070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 680414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " ===MemObjInfo at 0x%p===", (void *)pInfo); 68158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 682414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem object: 0x%" PRIxLEAST64, (uint64_t)(pInfo->mem)); 68358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 684c025ba3a7a8ad299af93449fbc234b6631d6f9ebChris Forbes __LINE__, MEMTRACK_NONE, "MEM", " Ref Count: " PRINTF_SIZE_T_SPECIFIER, 685de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size() + pInfo->objBindings.size()); 6865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (0 != pInfo->allocInfo.allocationSize) { 6875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string pAllocInfoMsg = vk_print_vkmemoryallocateinfo(&pInfo->allocInfo, "MEM(INFO): "); 68858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info:\n%s", pAllocInfoMsg.c_str()); 6905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " Mem Alloc info is NULL (alloc done by vkCreateSwapchainKHR())"); 6935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 6965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT Binding list of size " PRINTF_SIZE_T_SPECIFIER " elements:", 697896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes pInfo->objBindings.size()); 698896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes if (pInfo->objBindings.size() > 0) { 699896fc32d6f25e4bbe916bd27f2d5358d235840d4Chris Forbes for (auto obj : pInfo->objBindings) { 70058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 701414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK OBJECT 0x%" PRIx64, obj.handle); 7025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 70558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 7065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, MEMTRACK_NONE, "MEM", 7075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " VK Command Buffer (CB) binding list of size " PRINTF_SIZE_T_SPECIFIER " elements", 708de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes pInfo->commandBufferBindings.size()); 709de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes if (pInfo->commandBufferBindings.size() > 0) { 710de886ba66b4535930eda3f737b1460bd62e1b2a5Chris Forbes for (auto cb : pInfo->commandBufferBindings) { 71158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 712414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 0, __LINE__, MEMTRACK_NONE, "MEM", " VK CB 0x%p", cb); 7135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7180a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbesstatic void printCBList(layer_data *my_data) { 71972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis GLOBAL_CB_NODE *pCBInfo = NULL; 7205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early out if info is not requested 7225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 7235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 72772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis MEMTRACK_NONE, "MEM", "Details of CB list (of size " PRINTF_SIZE_T_SPECIFIER " elements)", 72872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis my_data->commandBufferMap.size()); 7295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, __LINE__, 7305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_NONE, "MEM", "=================="); 7315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (my_data->commandBufferMap.size() <= 0) 7335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 7345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto &cb_node : my_data->commandBufferMap) { 73672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCBInfo = cb_node.second; 7375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 739414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " CB Info (0x%p) has CB 0x%p", (void *)pCBInfo, (void *)pCBInfo->commandBuffer); 7405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 741c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes if (pCBInfo->memObjs.size() <= 0) 7425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 743c7196adb126cc3c77dc932e29193ca886532bac5Chris Forbes for (auto obj : pCBInfo->memObjs) { 7445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 0, 745414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, MEMTRACK_NONE, "MEM", " Mem obj 0x%" PRIx64, (uint64_t)obj); 7465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 7495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return a string representation of CMD_TYPE enum 7515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic string cmdTypeToString(CMD_TYPE cmd) { 7525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 7535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 7545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINE"; 7555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 7565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDPIPELINEDELTA"; 7575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 7585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETVIEWPORTSTATE"; 7595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 7605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETLINEWIDTHSTATE"; 7615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 7625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBIASSTATE"; 7635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 7645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETBLENDSTATE"; 7655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 7665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETDEPTHBOUNDSSTATE"; 7675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 7685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREADMASKSTATE"; 7695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 7705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILWRITEMASKSTATE"; 7715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 7725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETSTENCILREFERENCESTATE"; 7735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 7745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDDESCRIPTORSETS"; 7755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 7765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDINDEXBUFFER"; 7775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 7785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BINDVERTEXBUFFER"; 7795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 7805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAW"; 7815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 7825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXED"; 7835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 7845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDIRECT"; 7855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 7865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DRAWINDEXEDINDIRECT"; 7875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 7885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCH"; 7895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 7905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_DISPATCHINDIRECT"; 7915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 7925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFER"; 7935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 7945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGE"; 7955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 7965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BLITIMAGE"; 7975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 7985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYBUFFERTOIMAGE"; 7995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 8005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYIMAGETOBUFFER"; 8015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 8025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLONEIMAGEDATA"; 8035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 8045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_UPDATEBUFFER"; 8055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 8065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_FILLBUFFER"; 8075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 8085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORIMAGE"; 8095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 8105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARCOLORATTACHMENT"; 8115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 8125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_CLEARDEPTHSTENCILIMAGE"; 8135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 8145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESOLVEIMAGE"; 8155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 8165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SETEVENT"; 8175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 8185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETEVENT"; 8195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 8205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WAITEVENTS"; 8215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 8225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_PIPELINEBARRIER"; 8235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 8245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINQUERY"; 8255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 8265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDQUERY"; 8275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 8285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_RESETQUERYPOOL"; 8295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 8305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_COPYQUERYPOOLRESULTS"; 8315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 8325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_WRITETIMESTAMP"; 8335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_INITATOMICCOUNTERS: 8345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_INITATOMICCOUNTERS"; 8355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_LOADATOMICCOUNTERS: 8365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_LOADATOMICCOUNTERS"; 8375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SAVEATOMICCOUNTERS: 8385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_SAVEATOMICCOUNTERS"; 8395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 8405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_BEGINRENDERPASS"; 8415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 8425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "CMD_ENDRENDERPASS"; 8435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 8445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "UNKNOWN"; 8455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// SPIRV utility functions 8495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void build_def_index(shader_module *module) { 8505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 8515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 8525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Types */ 8535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVoid: 8545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 8555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 8565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 8575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 8585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 8595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 8605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 8615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 8625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 8635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeRuntimeArray: 8645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 8655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeOpaque: 8665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 8675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFunction: 8685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeEvent: 8695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeDeviceEvent: 8705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeReserveId: 8715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeQueue: 8725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePipe: 8735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(1)] = insn.offset(); 8745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Fixed constants */ 8775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantTrue: 8785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantFalse: 8795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstant: 8805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantComposite: 8815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantSampler: 8825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpConstantNull: 8835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Specialization constants */ 8875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantTrue: 8885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantFalse: 8895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstant: 8905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantComposite: 8915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSpecConstantOp: 8925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Variables */ 8965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpVariable: 8975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 8985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 8995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Functions */ 9015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 9025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis module->def_index[insn.word(2)] = insn.offset(); 9035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We don't care about any other defs for now. */ 9075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 9085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter find_entrypoint(shader_module *src, char const *name, VkShaderStageFlagBits stageBits) { 9135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 9145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpEntryPoint) { 9155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointName = (char const *)&insn.word(3); 9165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto entrypointStageBits = 1u << insn.word(1); 9175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!strcmp(entrypointName, name) && (entrypointStageBits & stageBits)) { 9195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn; 9205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 9255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char const *storage_class_name(unsigned sc) { 9285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (sc) { 9295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassInput: 9305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "input"; 9315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassOutput: 9325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "output"; 9335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniformConstant: 9345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "const uniform"; 9355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassUniform: 9365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "uniform"; 9375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassWorkgroup: 9385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup local"; 9395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassCrossWorkgroup: 9405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "workgroup global"; 9415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPrivate: 9425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "private global"; 9435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassFunction: 9445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "function"; 9455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassGeneric: 9465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "generic"; 9475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassAtomicCounter: 9485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "atomic counter"; 9495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassImage: 9505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "image"; 9515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::StorageClassPushConstant: 9525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "push constant"; 9535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 9545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return "unknown"; 9555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* get the value of an integral constant */ 9595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisunsigned get_constant_value(shader_module const *src, unsigned id) { 9605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto value = src->get_def(id); 9615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(value != src->end()); 9625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (value.opcode() != spv::OpConstant) { 9645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: Either ensure that the specialization transform is already performed on a module we're 9655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis considering here, OR -- specialize on the fly now. 9665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 9675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 9685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return value.word(3); 9715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 9725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9739ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 9749ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic void describe_type_inner(std::ostringstream &ss, shader_module const *src, unsigned type) { 9755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 9765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 9775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 9795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 9809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "bool"; 9819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 9839ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << (insn.word(3) ? 's' : 'u') << "int" << insn.word(2); 9849ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 9869ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "float" << insn.word(2); 9879ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 9899ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "vec" << insn.word(3) << " of "; 9909ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9919ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 9939ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "mat" << insn.word(3) << " of "; 9949ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9959ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 9965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 9979ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "arr[" << get_constant_value(src, insn.word(3)) << "] of "; 9989ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 9999ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 10019ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "ptr to " << storage_class_name(insn.word(2)) << " "; 10029ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(3)); 10039ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 10059ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "struct of ("; 10065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < insn.len(); i++) { 10079ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(i)); 10089ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes if (i == insn.len() - 1) { 10099ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ")"; 10109ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } else { 10119ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << ", "; 10129ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes } 10135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10149ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 10179ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler"; 10189ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 10209ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "sampler+"; 10219ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, insn.word(2)); 10229ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: 10249ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "image(dim=" << insn.word(3) << ", sampled=" << insn.word(7) << ")"; 10259ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 10279ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes ss << "oddtype"; 10289ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes break; 10295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 10315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10329ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10339ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbesstatic std::string describe_type(shader_module const *src, unsigned type) { 10349ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes std::ostringstream ss; 10359ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type_inner(ss, src, type); 10369ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes return ss.str(); 10379ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes} 10389ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 10399ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes 104037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool is_narrow_numeric_type(spirv_inst_iter type) 104137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes{ 104237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (type.opcode() != spv::OpTypeInt && type.opcode() != spv::OpTypeFloat) 104337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 104437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return type.word(2) < 64; 104537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes} 104637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 104737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 104837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbesstatic bool types_match(shader_module const *a, shader_module const *b, unsigned a_type, unsigned b_type, bool a_arrayed, bool b_arrayed, bool relaxed) { 10495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk two type trees together, and complain about differences */ 10505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_insn = a->get_def(a_type); 10515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_insn = b->get_def(b_type); 10525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(a_insn != a->end()); 10535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(b_insn != b->end()); 10545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10557c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed && a_insn.opcode() == spv::OpTypeArray) { 105637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, false, b_arrayed, relaxed); 10577c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10587c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_arrayed && b_insn.opcode() == spv::OpTypeArray) { 10605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* we probably just found the extra level of arrayness in b_type: compare the type inside it to a_type */ 106137576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_type, b_insn.word(2), a_arrayed, false, relaxed); 106237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 106337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes 106437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (a_insn.opcode() == spv::OpTypeVector && relaxed && is_narrow_numeric_type(b_insn)) { 106537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_type, a_arrayed, b_arrayed, false); 10665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.opcode() != b_insn.opcode()) { 10695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 10705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 10715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 10727c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_insn.opcode() == spv::OpTypePointer) { 10737c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* match on pointee type. storage class is expected to differ */ 107437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(3), b_insn.word(3), a_arrayed, b_arrayed, relaxed); 10757c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10767c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10777c755c8aca6857046df9516d8336416165969cb9Chris Forbes if (a_arrayed || b_arrayed) { 10787c755c8aca6857046df9516d8336416165969cb9Chris Forbes /* if we havent resolved array-of-verts by here, we're not going to. */ 10797c755c8aca6857046df9516d8336416165969cb9Chris Forbes return false; 10807c755c8aca6857046df9516d8336416165969cb9Chris Forbes } 10817c755c8aca6857046df9516d8336416165969cb9Chris Forbes 10825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (a_insn.opcode()) { 10835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeBool: 10847c755c8aca6857046df9516d8336416165969cb9Chris Forbes return true; 10855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 10865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width, signedness */ 10877c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2) && a_insn.word(3) == b_insn.word(3); 10885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 10895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on width */ 10907c755c8aca6857046df9516d8336416165969cb9Chris Forbes return a_insn.word(2) == b_insn.word(2); 10915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 109237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 109337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false)) 109437576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return false; 109537576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (relaxed && is_narrow_numeric_type(a->get_def(a_insn.word(2)))) { 109637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) >= b_insn.word(3); 109737576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 109837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes else { 109937576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return a_insn.word(3) == b_insn.word(3); 110037576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes } 11015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 110237576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes /* match on element type, count. */ 110337576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && a_insn.word(3) == b_insn.word(3); 11045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on element type, count. these all have the same layout. we don't get here if 11065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * b_arrayed. This differs from vector & matrix types in that the array size is the id of a constant instruction, 11075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * not a literal within OpTypeArray */ 110837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes return types_match(a, b, a_insn.word(2), b_insn.word(2), a_arrayed, b_arrayed, false) && 11095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_constant_value(a, a_insn.word(3)) == get_constant_value(b, b_insn.word(3)); 11105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: 11115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* match on all element types */ 11125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 11135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (a_insn.len() != b_insn.len()) { 11145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* structs cannot match if member counts differ */ 11155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 2; i < a_insn.len(); i++) { 111837576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes if (!types_match(a, b, a_insn.word(i), b_insn.word(i), a_arrayed, b_arrayed, false)) { 11195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 11245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* remaining types are CLisms, or may not appear in the interfaces we 11275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * are interested in. Just claim no match. 11285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 11295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 11305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic int value_or_default(std::unordered_map<unsigned, unsigned> const &map, unsigned id, int def) { 11345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = map.find(id); 11355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (it == map.end()) 11365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 11375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis else 11385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return it->second; 11395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_locations_consumed_by_type(shader_module const *src, unsigned type, bool strip_array_level) { 11425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 11435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 11445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 11465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 11475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* see through the ptr -- this is only ever at the toplevel for graphics shaders; 11485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * we're never actually passing pointers around. */ 11495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(3), strip_array_level); 11505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 11515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strip_array_level) { 11525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_locations_consumed_by_type(src, insn.word(2), false); 11535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 11545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_constant_value(src, insn.word(3)) * get_locations_consumed_by_type(src, insn.word(2), false); 11555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 11575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* num locations is the dimension * element size */ 11585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) * get_locations_consumed_by_type(src, insn.word(2), false); 1159cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes case spv::OpTypeVector: { 1160cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto scalar_type = src->get_def(insn.word(2)); 1161cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes auto bit_width = (scalar_type.opcode() == spv::OpTypeInt || scalar_type.opcode() == spv::OpTypeFloat) ? 1162cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes scalar_type.word(2) : 32; 1163cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes 1164cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes /* locations are 128-bit wide; 3- and 4-component vectors of 64 bit 1165cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes * types require two. */ 1166cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes return (bit_width * insn.word(3) + 127) / 128; 1167cc52143fc093e1e62d2dacc4abc3966e04b6f6d6Chris Forbes } 11685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 11695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* everything else is just 1. */ 11705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 1; 11715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: extend to handle 64bit scalar types, whose vectors may need 11735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * multiple locations. */ 11745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 11755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 11765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1177c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbesstatic unsigned get_locations_consumed_by_format(VkFormat format) { 1178c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes switch (format) { 1179c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SFLOAT: 1180c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 1181c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 1182c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SFLOAT: 1183c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_SINT: 1184c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes case VK_FORMAT_R64G64B64_UINT: 1185c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 2; 1186c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes default: 1187c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes return 1; 1188c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1189c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes} 1190c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes 11915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> location_t; 11925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistypedef std::pair<unsigned, unsigned> descriptor_slot_t; 11935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 11945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstruct interface_var { 11955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t id; 11965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t type_id; 11975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t offset; 1198b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch; 1199fff9393206f66a154438e16fa0562c989f425498Chris Forbes bool is_block_member; 12005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: collect the name, too? Isn't required to be present. */ 12015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 12025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1203031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstruct shader_stage_attributes { 1204031261d21af8907953dd763398ce9a23e65b8749Chris Forbes char const *const name; 1205031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_input; 1206031261d21af8907953dd763398ce9a23e65b8749Chris Forbes bool arrayed_output; 1207031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1208031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 1209031261d21af8907953dd763398ce9a23e65b8749Chris Forbesstatic shader_stage_attributes shader_stage_attribs[] = { 1210031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"vertex shader", false, false}, 1211031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation control shader", true, true}, 1212031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"tessellation evaluation shader", true, false}, 1213031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"geometry shader", true, false}, 1214031261d21af8907953dd763398ce9a23e65b8749Chris Forbes {"fragment shader", false, false}, 1215031261d21af8907953dd763398ce9a23e65b8749Chris Forbes}; 1216031261d21af8907953dd763398ce9a23e65b8749Chris Forbes 12175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic spirv_inst_iter get_struct_type(shader_module const *src, spirv_inst_iter def, bool is_array_of_verts) { 12185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (true) { 12195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def.opcode() == spv::OpTypePointer) { 12215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(3)); 12225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeArray && is_array_of_verts) { 12235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis def = src->get_def(def.word(2)); 12245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis is_array_of_verts = false; 12255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (def.opcode() == spv::OpTypeStruct) { 12265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return def; 12275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 12285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return src->end(); 12295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1233edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_block_members(shader_module const *src, 12345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> &out, 12355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> const &blocks, bool is_array_of_verts, 1236b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes uint32_t id, uint32_t type_id, bool is_patch) { 12375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk down the type_id presented, trying to determine whether it's actually an interface block. */ 1238031261d21af8907953dd763398ce9a23e65b8749Chris Forbes auto type = get_struct_type(src, src->get_def(type_id), is_array_of_verts && !is_patch); 12395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (type == src->end() || blocks.find(type.word(1)) == blocks.end()) { 12405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* this isn't an interface block. */ 12415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 12425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> member_components; 12455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Walk all the OpMemberDecorate for type's result id -- first pass, collect components. */ 12475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationComponent) { 12525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = insn.word(4); 12535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis member_components[member_index] = component; 12545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Second pass -- produce the output, from Location decorations */ 12595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 12615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_index = insn.word(2); 12625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned member_type_id = type.word(2 + member_index); 12635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationLocation) { 12655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned location = insn.word(4); 12665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned num_locations = get_locations_consumed_by_type(src, member_type_id, false); 12675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto component_it = member_components.find(member_index); 12685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = component_it == member_components.end() ? 0 : component_it->second; 12695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 12715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 12725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 12735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: member index in interface_var too? */ 12745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = member_type_id; 12755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1276b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1277fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = true; 12785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 12795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 12835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 12845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1285edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_location(shader_module const *src, spirv_inst_iter entrypoint, 12865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spv::StorageClass sinterface, std::map<location_t, interface_var> &out, 12875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool is_array_of_verts) { 12885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_locations; 12895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_builtins; 12905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_components; 12915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> blocks; 1292b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes std::unordered_map<unsigned, unsigned> var_patch; 12935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 12955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 12965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We consider two interface models: SSO rendezvous-by-location, and 12975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * builtins. Complain about anything that fits neither model. 12985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 12995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationLocation) { 13015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_locations[insn.word(1)] = insn.word(3); 13025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBuiltIn) { 13055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_builtins[insn.word(1)] = insn.word(3); 13065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationComponent) { 13095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_components[insn.word(1)] = insn.word(3); 13105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 13135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis blocks[insn.word(1)] = 1; 13145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1315b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes 1316b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes if (insn.word(2) == spv::DecorationPatch) { 1317b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes var_patch[insn.word(1)] = 1; 1318b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes } 13195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle grouped decorations */ 13235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: handle index=1 dual source outputs from FS -- two vars will 132481264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom * have the same location, and we DON'T want to clobber. */ 13255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* find the end of the entrypoint's name string. additional zero bytes follow the actual null 13275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis terminator, to fill out the rest of the word - so we only need to look at the last byte in 13285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis the word to determine which word contains the terminator. */ 1329c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell uint32_t word = 3; 13305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (entrypoint.word(word) & 0xff000000u) { 13315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++word; 13345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; word < entrypoint.len(); word++) { 13365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(entrypoint.word(word)); 13375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 13385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn.opcode() == spv::OpVariable); 13395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13401d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (insn.word(3) == static_cast<uint32_t>(sinterface)) { 13415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned id = insn.word(2); 13425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned type = insn.word(1); 13435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int location = value_or_default(var_locations, id, -1); 13455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int builtin = value_or_default(var_builtins, id, -1); 13465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned component = value_or_default(var_components, id, 0); /* unspecified is OK, is 0 */ 1347b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes bool is_patch = var_patch.find(id) != var_patch.end(); 13485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables and interface block members in the Input or Output storage classes 13505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * must be decorated with either a builtin or an explicit location. 13515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 13525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: integrate the interface block support here. For now, don't complain -- 13535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a valid SPIRV module will only hit this path for the interface block case, as the 13545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * individual members of the type are decorated, rather than variable declarations. 13555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (location != -1) { 13585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* A user-defined interface variable, with a location. Where a variable 13595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * occupied multiple locations, emit one result for each. */ 13607c755c8aca6857046df9516d8336416165969cb9Chris Forbes unsigned num_locations = get_locations_consumed_by_type(src, type, is_array_of_verts && !is_patch); 13615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned int offset = 0; offset < num_locations; offset++) { 13625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 13635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = id; 13645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = type; 13655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.offset = offset; 1366b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = is_patch; 1367fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 13685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(location + offset, component)] = v; 13695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (builtin == -1) { 13715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* An interface block instance */ 1372edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_block_members(src, out, blocks, is_array_of_verts, id, type, is_patch); 13735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 13775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1378edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic void collect_interface_by_descriptor_slot(debug_report_data *report_data, shader_module const *src, 13795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> const &accessible_ids, 13805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<descriptor_slot_t, interface_var> &out) { 13815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_sets; 13835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<unsigned, unsigned> var_bindings; 13845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 13865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* All variables in the Uniform or UniformConstant storage classes are required to be decorated with both 13875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * DecorationDescriptorSet and DecorationBinding. 13885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 13895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate) { 13905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationDescriptorSet) { 13915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_sets[insn.word(1)] = insn.word(3); 13925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 13945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBinding) { 13955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis var_bindings[insn.word(1)] = insn.word(3); 13965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 13995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 14015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 14025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 14035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpVariable && 14055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (insn.word(3) == spv::StorageClassUniform || insn.word(3) == spv::StorageClassUniformConstant)) { 14065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned set = value_or_default(var_sets, insn.word(2), 0); 14075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned binding = value_or_default(var_bindings, insn.word(2), 0); 14085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto existing_it = out.find(std::make_pair(set, binding)); 14105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (existing_it != out.end()) { 14115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* conflict within spv image */ 1412edef66e03ed509994449d598f4fadea1a487d41bChris Forbes log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", 14145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "var %d (type %d) in %s interface in descriptor slot (%u,%u) conflicts with existing definition", 14155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis insn.word(2), insn.word(1), storage_class_name(insn.word(3)), existing_it->first.first, 14165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis existing_it->first.second); 14175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis interface_var v; 14205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.id = insn.word(2); 14215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis v.type_id = insn.word(1); 1422b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.offset = 0; 1423b934cb26db50b965da46ca3e3f006d5a93478f71Chris Forbes v.is_patch = false; 1424fff9393206f66a154438e16fa0562c989f425498Chris Forbes v.is_block_member = false; 14255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis out[std::make_pair(set, binding)] = v; 14265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 14295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1430edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_interface_between_stages(debug_report_data *report_data, shader_module const *producer, 1431031261d21af8907953dd763398ce9a23e65b8749Chris Forbes spirv_inst_iter producer_entrypoint, shader_stage_attributes const *producer_stage, 14325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *consumer, spirv_inst_iter consumer_entrypoint, 1433031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shader_stage_attributes const *consumer_stage) { 14345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 14355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 14365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 14385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1439edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(producer, producer_entrypoint, spv::StorageClassOutput, outputs, producer_stage->arrayed_output); 1440edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(consumer, consumer_entrypoint, spv::StorageClassInput, inputs, consumer_stage->arrayed_input); 14415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_it = outputs.begin(); 14435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_it = inputs.begin(); 14445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* maps sorted by key (location); walk them together to find mismatches */ 14465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((outputs.size() > 0 && a_it != outputs.end()) || (inputs.size() && b_it != inputs.end())) { 14475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = outputs.size() == 0 || a_it == outputs.end(); 14485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || b_it == inputs.end(); 14495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? std::make_pair(0u, 0u) : a_it->first; 14505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? std::make_pair(0u, 0u) : b_it->first; 14515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 14525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (b_at_end || ((!a_at_end) && (a_first < b_first))) { 1453edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1454080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1455031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s writes to output location %u.%u which is not consumed by %s", producer_stage->name, a_first.first, 1456031261d21af8907953dd763398ce9a23e65b8749Chris Forbes a_first.second, consumer_stage->name)) { 14575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 14605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (a_at_end || a_first > b_first) { 1461edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", 1463031261d21af8907953dd763398ce9a23e65b8749Chris Forbes "%s consumes input location %u.%u which is not written by %s", consumer_stage->name, b_first.first, b_first.second, 1464031261d21af8907953dd763398ce9a23e65b8749Chris Forbes producer_stage->name)) { 14655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 14685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1469fff9393206f66a154438e16fa0562c989f425498Chris Forbes // subtleties of arrayed interfaces: 1470fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_patch, then the member is not arrayed, even though the interface may be. 1471fff9393206f66a154438e16fa0562c989f425498Chris Forbes // - if is_block_member, then the extra array level of an arrayed interface is not 1472fff9393206f66a154438e16fa0562c989f425498Chris Forbes // expressed in the member type -- it's expressed in the block type. 14730f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (!types_match(producer, consumer, a_it->second.type_id, b_it->second.type_id, 1474fff9393206f66a154438e16fa0562c989f425498Chris Forbes producer_stage->arrayed_output && !a_it->second.is_patch && !a_it->second.is_block_member, 1475fff9393206f66a154438e16fa0562c989f425498Chris Forbes consumer_stage->arrayed_input && !b_it->second.is_patch && !b_it->second.is_block_member, 147637576f9c5ccc190c53a1c10baf383d77c3c6d476Chris Forbes true)) { 1477edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 14785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", "Type mismatch on location %u.%u: '%s' vs '%s'", 14799ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes a_first.first, a_first.second, 14809ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(producer, a_it->second.type_id).c_str(), 14819ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(consumer, b_it->second.type_id).c_str())) { 14825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 14835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14850f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes if (a_it->second.is_patch != b_it->second.is_patch) { 1486edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 14870f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1488f706c50be3a9d4d1e131c2f43ee2fb443f028d30Chris Forbes "Decoration mismatch on location %u.%u: is per-%s in %s stage but " 14890f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes "per-%s in %s stage", a_first.first, a_first.second, 14900f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes a_it->second.is_patch ? "patch" : "vertex", producer_stage->name, 14910f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes b_it->second.is_patch ? "patch" : "vertex", consumer_stage->name)) { 14920f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes pass = false; 14930f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 14940f44c68c2575ba2fc83d8c8f2f5ea09548f40686Chris Forbes } 14955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis a_it++; 14965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_it++; 14975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 14995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 15015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisenum FORMAT_TYPE { 15045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UNDEFINED, 15055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_FLOAT, /* UNORM, SNORM, FLOAT, USCALED, SSCALED, SRGB -- anything we consider float in the shader */ 15065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_SINT, 15075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FORMAT_TYPE_UINT, 15085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis}; 15095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_format_type(VkFormat fmt) { 15115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (fmt) { 15125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_UNDEFINED: 15135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_SINT: 15155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_SINT: 15165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_SINT: 15175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_SINT: 15185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_SINT: 15195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_SINT: 15205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_SINT: 15215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_SINT: 15225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_SINT: 15235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_SINT: 15245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_SINT: 15255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_SINT: 152631c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_SINT: 152731c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_SINT: 152831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_SINT: 152931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_SINT: 15305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_SINT: 15315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_SINT: 1532f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_SINT_PACK32: 15335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_SINT_PACK32: 15345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_SINT_PACK32: 15355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_SINT; 15365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8_UINT: 15375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8_UINT: 15385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8_UINT: 15395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R8G8B8A8_UINT: 15405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16_UINT: 15415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16_UINT: 15425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16_UINT: 15435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R16G16B16A16_UINT: 15445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32_UINT: 15455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32_UINT: 15465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32_UINT: 15475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_R32G32B32A32_UINT: 154831c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64_UINT: 154931c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64_UINT: 155031c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64_UINT: 155131c2b86c259f87e539d544702c30e3c368e6b905Chris Forbes case VK_FORMAT_R64G64B64A64_UINT: 15525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8_UINT: 15535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_B8G8R8A8_UINT: 1554f0e6d40360fcfcc98df5ada68c14b08f11eec531Chris Forbes case VK_FORMAT_A8B8G8R8_UINT_PACK32: 15555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2B10G10R10_UINT_PACK32: 15565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_FORMAT_A2R10G10B10_UINT_PACK32: 15575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UINT; 15585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* characterizes a SPIR-V type appearing in an interface to a FF stage, 15645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for comparison to a VkFormat's characterization above. */ 15655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic unsigned get_fundamental_type(shader_module const *src, unsigned type) { 15665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(type); 15675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(insn != src->end()); 15685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 15705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeInt: 15715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return insn.word(3) ? FORMAT_TYPE_SINT : FORMAT_TYPE_UINT; 15725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeFloat: 15735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_FLOAT; 15745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeVector: 15755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeMatrix: 15775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeArray: 15795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(2)); 15805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypePointer: 15815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return get_fundamental_type(src, insn.word(3)); 15825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 15835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FORMAT_TYPE_UNDEFINED; 15845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 15855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t get_shader_stage_id(VkShaderStageFlagBits stage) { 15885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t bit_pos = u_ffs(stage); 15895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return bit_pos - 1; 15905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 15915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1592edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_consistency(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi) { 15935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* walk the binding descriptions, which describe the step rate and stride of each vertex buffer. 15945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * each binding should be specified only once. 15955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 15965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_map<uint32_t, VkVertexInputBindingDescription const *> bindings; 15975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 15985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 15995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (unsigned i = 0; i < vi->vertexBindingDescriptionCount; i++) { 16005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto desc = &vi->pVertexBindingDescriptions[i]; 16015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto &binding = bindings[desc->binding]; 16025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (binding) { 1603edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INCONSISTENT_VI, "SC", 16055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Duplicate vertex input binding descriptions for binding %d", desc->binding)) { 16065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis binding = desc; 16105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1616edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_vi_against_vs_inputs(debug_report_data *report_data, VkPipelineVertexInputStateCreateInfo const *vi, 16175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *vs, spirv_inst_iter entrypoint) { 16185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> inputs; 16195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1621edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(vs, entrypoint, spv::StorageClassInput, inputs, false); 16225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Build index by location */ 16245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<uint32_t, VkVertexInputAttributeDescription const *> attribs; 16255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 1626c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (unsigned i = 0; i < vi->vertexAttributeDescriptionCount; i++) { 1627c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes auto num_locations = get_locations_consumed_by_format(vi->pVertexAttributeDescriptions[i].format); 1628c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes for (auto j = 0u; j < num_locations; j++) { 1629c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes attribs[vi->pVertexAttributeDescriptions[i].location + j] = &vi->pVertexAttributeDescriptions[i]; 1630c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 1631c7255e92ea81e8639dc21388ec2a959bd63319c7Chris Forbes } 16325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_a = attribs.begin(); 16355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it_b = inputs.begin(); 16365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while ((attribs.size() > 0 && it_a != attribs.end()) || (inputs.size() > 0 && it_b != inputs.end())) { 16385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool a_at_end = attribs.size() == 0 || it_a == attribs.end(); 16395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool b_at_end = inputs.size() == 0 || it_b == inputs.end(); 16405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto a_first = a_at_end ? 0 : it_a->first; 16415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto b_first = b_at_end ? 0 : it_b->first.first; 16425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!a_at_end && (b_at_end || a_first < b_first)) { 1643edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1644080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 16455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Vertex attribute at location %d not consumed by VS", a_first)) { 16465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!b_at_end && (a_at_end || b_first < a_first)) { 1650edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, /*dev*/ 0, 16515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "VS consumes input at location %d but not provided", 16525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis b_first)) { 16535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 16575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned attrib_type = get_format_type(it_a->second->format); 16585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned input_type = get_fundamental_type(vs, it_b->second.type_id); 16595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 16615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attrib_type != FORMAT_TYPE_UNDEFINED && input_type != FORMAT_TYPE_UNDEFINED && attrib_type != input_type) { 1662edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 16635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 16645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attribute type of `%s` at location %d does not match VS input type of `%s`", 16659ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes string_VkFormat(it_a->second->format), a_first, 16669ccb7b1342fd1a901f1ae0d202721a50d2c227f9Chris Forbes describe_type(vs, it_b->second.type_id).c_str())) { 16675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 16685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 16725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_a++; 16735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis it_b++; 16745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 16765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 16785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 16795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1680edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_fs_outputs_against_render_pass(debug_report_data *report_data, shader_module const *fs, 16815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoint, RENDER_PASS_NODE const *rp, uint32_t subpass) { 16825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::map<location_t, interface_var> outputs; 1683025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes std::map<uint32_t, VkFormat> color_attachments; 1684025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes for (auto i = 0u; i < rp->subpassColorFormats[subpass].size(); i++) { 1685025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (rp->subpassColorFormats[subpass][i] != VK_FORMAT_UNDEFINED) { 1686025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes color_attachments[i] = rp->subpassColorFormats[subpass][i]; 1687025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1688025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } 1689025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 16905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 16915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 16925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* TODO: dual source blend index (spv::DecIndex, zero if not provided) */ 16935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1694edef66e03ed509994449d598f4fadea1a487d41bChris Forbes collect_interface_by_location(fs, entrypoint, spv::StorageClassOutput, outputs, false); 16955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1696025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_a = outputs.begin(); 1697025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes auto it_b = color_attachments.begin(); 16985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1699025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes /* Walk attachment list and outputs together */ 1700025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes 1701025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes while ((outputs.size() > 0 && it_a != outputs.end()) || (color_attachments.size() > 0 && it_b != color_attachments.end())) { 1702025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool a_at_end = outputs.size() == 0 || it_a == outputs.end(); 1703025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes bool b_at_end = color_attachments.size() == 0 || it_b == color_attachments.end(); 17045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1705025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes if (!a_at_end && (b_at_end || it_a->first.first < it_b->first)) { 1706edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_OUTPUT_NOT_CONSUMED, "SC", 1708025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "FS writes to output location %d with no matching attachment", it_a->first.first)) { 17095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1711025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1712025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes } else if (!b_at_end && (a_at_end || it_a->first.first > it_b->first)) { 1713edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1714025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes __LINE__, SHADER_CHECKER_INPUT_NOT_PRODUCED, "SC", "Attachment %d not written by FS", it_b->first)) { 17155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1717025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 1719025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned output_type = get_fundamental_type(fs, it_a->second.type_id); 1720025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes unsigned att_type = get_format_type(it_b->second); 17215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* type checking */ 17235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (att_type != FORMAT_TYPE_UNDEFINED && output_type != FORMAT_TYPE_UNDEFINED && att_type != output_type) { 1724edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 17255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, SHADER_CHECKER_INTERFACE_TYPE_MISMATCH, "SC", 1726025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes "Attachment %d of type `%s` does not match FS output type of `%s`", it_b->first, 1727025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes string_VkFormat(it_b->second), 1728025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes describe_type(fs, it_a->second.type_id).c_str())) { 17295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 17305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* OK! */ 1734025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_a++; 1735025e5113963305eff75601c96eac61d2c5b57e3cChris Forbes it_b++; 17365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 17405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 17415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* For some analyses, we need to know about all ids referenced by the static call tree of a particular 17435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * entrypoint. This is important for identifying the set of shader resources actually used by an entrypoint, 17445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * for example. 17455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Note: we only explore parts of the image which might actually contain ids we care about for the above analyses. 17465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * - NOT the shader input/output interfaces. 17475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * 17485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * TODO: The set of interesting opcodes here was determined by eyeballing the SPIRV spec. It might be worth 17495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * converting parts of this to be generated from the machine-readable spec instead. 17505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 17515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void mark_accessible_ids(shader_module const *src, spirv_inst_iter entrypoint, std::unordered_set<uint32_t> &ids) { 17525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> worklist; 17535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(entrypoint.word(2)); 17545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!worklist.empty()) { 17565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id_iter = worklist.begin(); 17575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto id = *id_iter; 17585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.erase(id_iter); 17595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto insn = src->get_def(id); 17615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn == src->end()) { 176281264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom /* id is something we didn't collect in build_def_index. that's OK -- we'll stumble 17635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * across all kinds of things here that we may not care about. */ 17645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 17655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* try to add to the output set */ 17685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!ids.insert(id).second) { 17695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; /* if we already saw this id, we don't want to walk it again. */ 17705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 17715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 17725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunction: 17745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* scan whole body of the function, enlisting anything interesting */ 17755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (++insn, insn.opcode() != spv::OpFunctionEnd) { 17765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (insn.opcode()) { 17775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpLoad: 17785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicLoad: 17795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicExchange: 17805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchange: 17815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicCompareExchangeWeak: 17825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIIncrement: 17835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIDecrement: 17845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicIAdd: 17855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicISub: 17865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMin: 17875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMin: 17885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicSMax: 17895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicUMax: 17905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicAnd: 17915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicOr: 17925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicXor: 17935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* ptr */ 17945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 17955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpStore: 17965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAtomicStore: 17975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* ptr */ 17985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 17995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpAccessChain: 18005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpInBoundsAccessChain: 18015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* base ptr */ 18025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpSampledImage: 18045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleImplicitLod: 18055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleExplicitLod: 18065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefImplicitLod: 18075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleDrefExplicitLod: 18085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjImplicitLod: 18095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjExplicitLod: 18105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefImplicitLod: 18115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSampleProjDrefExplicitLod: 18125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageFetch: 18135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageGather: 18145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageDrefGather: 18155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageRead: 18165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImage: 18175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryFormat: 18185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryOrder: 18195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySizeLod: 18205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySize: 18215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLod: 18225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQueryLevels: 18235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageQuerySamples: 18245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleImplicitLod: 18255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleExplicitLod: 18265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefImplicitLod: 18275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleDrefExplicitLod: 18285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjImplicitLod: 18295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjExplicitLod: 18305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefImplicitLod: 18315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseSampleProjDrefExplicitLod: 18325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseFetch: 18335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseGather: 18345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageSparseDrefGather: 18355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageTexelPointer: 18365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(3)); /* image or sampled image */ 18375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpImageWrite: 18395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(1)); /* image -- different operand order to above */ 18405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpFunctionCall: 1842c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 3; i < insn.len(); i++) { 18435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* fn itself, and all args */ 18445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpExtInst: 1848c15b801a6e1a5dd5eed09e689aecdde7c4a90a5bMichael Mc Donnell for (uint32_t i = 5; i < insn.len(); i++) { 18495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis worklist.insert(insn.word(i)); /* operands to ext inst */ 18505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 18585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1859edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_block_against_pipeline(debug_report_data *report_data, 18605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, 18615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module const *src, spirv_inst_iter type, 18625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkShaderStageFlagBits stage) { 18635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 18645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* strip off ptrs etc */ 18665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type = get_struct_type(src, type, false); 18675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(type != src->end()); 18685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* validate directly off the offsets. this isn't quite correct for arrays 18705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and matrices, but is a good first step. TODO: arrays, matrices, weird 18715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * sizes */ 18725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *src) { 18735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpMemberDecorate && insn.word(1) == type.word(1)) { 18745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(3) == spv::DecorationOffset) { 18765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unsigned offset = insn.word(4); 18775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto size = 4; /* bytes; TODO: calculate this based on the type */ 18785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool found_range = false; 18805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto const &range : *pushConstantRanges) { 18815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.offset <= offset && range.offset + range.size >= offset + size) { 18825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis found_range = true; 18835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((range.stageFlags & stage) == 0) { 1885edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1886080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_NOT_ACCESSIBLE_FROM_STAGE, "SC", 18875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 18885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not accessible from stage %s", 18895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkShaderStageFlagBits(stage))) { 18905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 18915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 18955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 18975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 18985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!found_range) { 1899edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 1900080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_PUSH_CONSTANT_OUT_OF_RANGE, "SC", 19015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Push constant range covering variable starting at " 19025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "offset %u not declared in layout", 19035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset)) { 19045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pass = false; 19055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1914edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_push_constant_usage(debug_report_data *report_data, 19155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkPushConstantRange> const *pushConstantRanges, shader_module const *src, 19165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> accessible_ids, VkShaderStageFlagBits stage) { 19175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool pass = true; 19185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto id : accessible_ids) { 19205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto def_insn = src->get_def(id); 19215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (def_insn.opcode() == spv::OpVariable && def_insn.word(3) == spv::StorageClassPushConstant) { 1922edef66e03ed509994449d598f4fadea1a487d41bChris Forbes pass &= validate_push_constant_block_against_pipeline(report_data, pushConstantRanges, src, 1923080afef66a53dbdd085698b713697296458edfd9Chris Forbes src->get_def(def_insn.word(1)), stage); 19245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 19265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 19285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1930fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// For given pipelineLayout verify that the set_layout_node at slot.first 1931fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis// has the requested binding at slot.second and return ptr to that binding 19324a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic VkDescriptorSetLayoutBinding const * get_descriptor_binding(PIPELINE_LAYOUT_NODE const *pipelineLayout, descriptor_slot_t slot) { 19335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pipelineLayout) 193537083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 193778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (slot.first >= pipelineLayout->descriptorSetLayouts.size()) 193837083dec1ff1ca643bfc06b5308ca5ac718d58b0Chris Forbes return nullptr; 19395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1940f54d085ac836f3b0a2b62f6b401f759e586f0ea7Chris Forbes return pipelineLayout->setLayouts[slot.first]->GetDescriptorSetLayoutBindingPtrFromBinding(slot.second); 19415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here for managing/tracking Pipeline state that this layer cares about 19445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint64_t g_drawCount[NUM_DRAW_TYPES] = {0, 0, 0, 0}; 19465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO : Should be tracking lastBound per commandBuffer and when draws occur, report based on that cmd buffer lastBound 19485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Then need to synchronize the accesses based on cmd buffer so that if I'm reading state on one cmd buffer, updates 19495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to that same cmd buffer by separate thread are not changing state from underneath us 19505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track the last cmd buffer touched by this thread 19515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 1952e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool hasDrawCmd(GLOBAL_CB_NODE *pCB) { 19535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < NUM_DRAW_TYPES; i++) { 19545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->drawCount[i]) 1955e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 19565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1957e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Check object status for selected flag state 1961e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_status(layer_data *my_data, GLOBAL_CB_NODE *pNode, CBStatusFlags status_mask, VkFlags msg_flags, 1962e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves DRAW_STATE_ERROR error_code, const char *fail_msg) { 19633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (!(pNode->status & status_mask)) { 19643d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis return log_msg(my_data->report_data, msg_flags, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 19653d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis reinterpret_cast<const uint64_t &>(pNode->commandBuffer), __LINE__, error_code, "DS", 1966414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB object 0x%" PRIxLEAST64 ": %s", reinterpret_cast<const uint64_t &>(pNode->commandBuffer), fail_msg); 19675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1968e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 19695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 19715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Retrieve pipeline node ptr for given pipeline object 197216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic PIPELINE_NODE *getPipeline(layer_data const *my_data, VkPipeline pipeline) { 1973ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes auto it = my_data->pipelineMap.find(pipeline); 1974ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (it == my_data->pipelineMap.end()) { 1975ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return nullptr; 19765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 1977ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes return it->second; 19785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 19795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 198016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbesstatic RENDER_PASS_NODE *getRenderPass(layer_data const *my_data, VkRenderPass renderpass) { 198116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto it = my_data->renderPassMap.find(renderpass); 198216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (it == my_data->renderPassMap.end()) { 198316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return nullptr; 198416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 198516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return it->second; 198616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes} 198716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 1988f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic FRAMEBUFFER_NODE *getFramebuffer(layer_data *my_data, VkFramebuffer framebuffer) { 1989f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto it = my_data->frameBufferMap.find(framebuffer); 1990f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (it == my_data->frameBufferMap.end()) { 1991f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return nullptr; 1992f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes } 1993f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes return &it->second; 1994f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes} 1995f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes 199611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbesstatic cvdescriptorset::DescriptorSetLayout const *getDescriptorSetLayout(layer_data const *my_data, VkDescriptorSetLayout dsLayout) { 199711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto it = my_data->descriptorSetLayoutMap.find(dsLayout); 199811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (it == my_data->descriptorSetLayoutMap.end()) { 199911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return nullptr; 200011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 200111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes return it->second; 200211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes} 200311f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 20044a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbesstatic PIPELINE_LAYOUT_NODE const *getPipelineLayout(layer_data const *my_data, VkPipelineLayout pipeLayout) { 20054a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto it = my_data->pipelineLayoutMap.find(pipeLayout); 20064a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (it == my_data->pipelineLayoutMap.end()) { 20074a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return nullptr; 20084a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes } 20094a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes return &it->second; 20104a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes} 20114a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes 2012e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if for a given PSO, the given state enum is dynamic, else return false 2013e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool isDynamic(const PIPELINE_NODE *pPipeline, const VkDynamicState state) { 20145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline && pPipeline->graphicsPipelineCI.pDynamicState) { 20155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPipeline->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 20165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (state == pPipeline->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) 2017e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 20185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2020e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 20215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate state stored as flags at time of draw call 2024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_draw_state_flags(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe, bool indexedDraw) { 2025e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result; 20263d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result = validate_status(dev_data, pCB, CBSTATUS_VIEWPORT_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_VIEWPORT_NOT_BOUND, 20273d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic viewport state not set for this command buffer"); 20283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_SCISSOR_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, DRAWSTATE_SCISSOR_NOT_BOUND, 20293d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis "Dynamic scissor state not set for this command buffer"); 2030ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipe->graphicsPipelineCI.pInputAssemblyState && 2031ca546210846c65808717f8875deae39bd227c240Tobin Ehlis ((pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_LIST) || 2032ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipe->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_LINE_STRIP))) { 20333d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_LINE_WIDTH_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20343d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_LINE_WIDTH_NOT_BOUND, "Dynamic line width state not set for this command buffer"); 20353d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 203645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pRasterizationState && 203745824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pRasterizationState->depthBiasEnable == VK_TRUE)) { 20383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BIAS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20393d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BIAS_NOT_BOUND, "Dynamic depth bias state not set for this command buffer"); 20403d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20413d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->blendConstantsEnabled) { 20423d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_BLEND_CONSTANTS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20433d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_BLEND_NOT_BOUND, "Dynamic blend constants state not set for this command buffer"); 20443d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 204545824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 204645824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->depthBoundsTestEnable == VK_TRUE)) { 20473d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_DEPTH_BOUNDS_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20483d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_DEPTH_BOUNDS_NOT_BOUND, "Dynamic depth bounds state not set for this command buffer"); 20493d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 205045824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves if (pPipe->graphicsPipelineCI.pDepthStencilState && 205145824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipe->graphicsPipelineCI.pDepthStencilState->stencilTestEnable == VK_TRUE)) { 20523d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_READ_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20533d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil read mask state not set for this command buffer"); 20543d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_WRITE_MASK_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20553d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil write mask state not set for this command buffer"); 20563d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_STENCIL_REFERENCE_SET, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20573d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_STENCIL_NOT_BOUND, "Dynamic stencil reference state not set for this command buffer"); 20583d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20593d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (indexedDraw) { 20603d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis result |= validate_status(dev_data, pCB, CBSTATUS_INDEX_BUFFER_BOUND, VK_DEBUG_REPORT_ERROR_BIT_EXT, 20613d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis DRAWSTATE_INDEX_BUFFER_NOT_BOUND, 20625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Index buffer object not bound to this command buffer when Indexed Draw attempted"); 20633d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 20645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 20655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify attachment reference compatibility according to spec 20685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If one array is larger, treat missing elements of shorter array as VK_ATTACHMENT_UNUSED & other array much match this 20695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If both AttachmentReference arrays have requested index, check their corresponding AttachementDescriptions 20705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// to make sure that format and samples counts match. 20715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If not, they are not compatible. 20725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool attachment_references_compatible(const uint32_t index, const VkAttachmentReference *pPrimary, 20735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t primaryCount, const VkAttachmentDescription *pPrimaryAttachments, 20745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentReference *pSecondary, const uint32_t secondaryCount, 20755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkAttachmentDescription *pSecondaryAttachments) { 20765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (index >= primaryCount) { // Check secondary as if primary is VK_ATTACHMENT_UNUSED 207706e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pSecondary[index].attachment) 207806e963555b0df747c98c43816c16647349d21001Mark Young return true; 20795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (index >= secondaryCount) { // Check primary as if secondary is VK_ATTACHMENT_UNUSED 208006e963555b0df747c98c43816c16647349d21001Mark Young if (VK_ATTACHMENT_UNUSED == pPrimary[index].attachment) 208106e963555b0df747c98c43816c16647349d21001Mark Young return true; 20825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // format and sample count must match 20835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPrimaryAttachments[pPrimary[index].attachment].format == 20845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].format) && 20855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPrimaryAttachments[pPrimary[index].attachment].samples == 20865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSecondaryAttachments[pSecondary[index].attachment].samples)) 20875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 20885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 20895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Format and sample counts didn't match 20905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 20915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 20925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 20935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For give primary and secondary RenderPass objects, verify that they're compatible 20945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool verify_renderpass_compatibility(layer_data *my_data, const VkRenderPass primaryRP, const VkRenderPass secondaryRP, 20955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string &errorMsg) { 209616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(my_data, primaryRP); 209716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(my_data, secondaryRP); 209816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 209916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 2100c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << primaryRP << ")"; 21025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 210416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 210516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 210616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 2107c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkRenderPass (" << secondaryRP << ")"; 21095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Trivial pass case is exact same RP 21135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRP == secondaryRP) { 21145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 211616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *primaryRPCI = primary_render_pass->pCreateInfo; 211716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *secondaryRPCI = secondary_render_pass->pCreateInfo; 21185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryRPCI->subpassCount != secondaryRPCI->subpassCount) { 2119c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "RenderPass for primary cmdBuffer has " << primaryRPCI->subpassCount 21215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << " subpasses but renderPass for secondary cmdBuffer has " << secondaryRPCI->subpassCount << " subpasses."; 21225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t spIndex = 0; 21265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (spIndex = 0; spIndex < primaryRPCI->subpassCount; ++spIndex) { 21275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // For each subpass, verify that corresponding color, input, resolve & depth/stencil attachment references are compatible 21285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryColorCount = primaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryColorCount = secondaryRPCI->pSubpasses[spIndex].colorAttachmentCount; 21305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t colorMax = std::max(primaryColorCount, secondaryColorCount); 21315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t cIdx = 0; cIdx < colorMax; ++cIdx) { 21325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pColorAttachments, primaryColorCount, 21335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pColorAttachments, 21345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2135c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "color attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (!attachment_references_compatible(cIdx, primaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryColorCount, primaryRPCI->pAttachments, 21415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryRPCI->pSubpasses[spIndex].pResolveAttachments, 21425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2143c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "resolve attachments at index " << cIdx << " of subpass index " << spIndex << " are not compatible."; 21455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2149fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 2150fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes if (!attachment_references_compatible(0, primaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2151fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, primaryRPCI->pAttachments, 2152fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes secondaryRPCI->pSubpasses[spIndex].pDepthStencilAttachment, 2153fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 1, secondaryRPCI->pAttachments)) { 2154c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 2155fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorStr << "depth/stencil attachments of subpass index " << spIndex << " are not compatible."; 2156fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes errorMsg = errorStr.str(); 2157fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes return false; 2158fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes } 2159fd50683af1a7a54c6b8c13d790ad57c48072f55bChris Forbes 21605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primaryInputCount = primaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t secondaryInputCount = secondaryRPCI->pSubpasses[spIndex].inputAttachmentCount; 21625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t inputMax = std::max(primaryInputCount, secondaryInputCount); 21635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < inputMax; ++i) { 21645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!attachment_references_compatible(i, primaryRPCI->pSubpasses[spIndex].pInputAttachments, primaryColorCount, 21655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryRPCI->pAttachments, secondaryRPCI->pSubpasses[spIndex].pInputAttachments, 21665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryColorCount, secondaryRPCI->pAttachments)) { 2167c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "input attachments at index " << i << " of subpass index " << spIndex << " are not compatible."; 21695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 21755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2177397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// For given cvdescriptorset::DescriptorSet, verify that its Set is compatible w/ the setLayout corresponding to 2178397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis// pipelineLayout[layoutIndex] 2179397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic bool verify_set_layout_compatibility(layer_data *my_data, const cvdescriptorset::DescriptorSet *pSet, 2180397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis const VkPipelineLayout layout, const uint32_t layoutIndex, string &errorMsg) { 21814a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(my_data, layout); 21824a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 2183c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorStr << "invalid VkPipelineLayout (" << layout << ")"; 21855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21884a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (layoutIndex >= pipeline_layout->descriptorSetLayouts.size()) { 2189c07fa78efa7d4edfaa4ffbb0c2046ee8154b27beChris Forbes stringstream errorStr; 21904a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes errorStr << "VkPipelineLayout (" << layout << ") only contains " << pipeline_layout->descriptorSetLayouts.size() 21914a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes << " setLayouts corresponding to sets 0-" << pipeline_layout->descriptorSetLayouts.size() - 1 21925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis << ", but you're attempting to bind set to index " << layoutIndex; 21935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis errorMsg = errorStr.str(); 21945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 21955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 21964a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto layout_node = pipeline_layout->setLayouts[layoutIndex]; 2197397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis return pSet->IsCompatible(layout_node, &errorMsg); 21985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 21995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that data for each specialization entry is fully contained within the buffer. 2201edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool validate_specialization_offsets(debug_report_data *report_data, VkPipelineShaderStageCreateInfo const *info) { 2202e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 22035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSpecializationInfo const *spec = info->pSpecializationInfo; 22055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec) { 22075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0u; i < spec->mapEntryCount; i++) { 22085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (spec->pMapEntries[i].offset + spec->pMapEntries[i].size > spec->dataSize) { 2209edef66e03ed509994449d598f4fadea1a487d41bChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 22105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /*dev*/ 0, __LINE__, SHADER_CHECKER_BAD_SPECIALIZATION, "SC", 22115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Specialization entry %u (for constant id %u) references memory outside provided " 22125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "specialization data (bytes %u.." PRINTF_SIZE_T_SPECIFIER "; " PRINTF_SIZE_T_SPECIFIER 22135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " bytes provided)", 22145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis i, spec->pMapEntries[i].constantID, spec->pMapEntries[i].offset, 22155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spec->pMapEntries[i].offset + spec->pMapEntries[i].size - 1, spec->dataSize)) { 22165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 22185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 22245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 22255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2226edef66e03ed509994449d598f4fadea1a487d41bChris Forbesstatic bool descriptor_type_match(shader_module const *module, uint32_t type_id, 22271b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes VkDescriptorType descriptor_type, unsigned &descriptor_count) { 22285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto type = module->get_def(type_id); 22295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22301b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes descriptor_count = 1; 22311b8c581791ac3c05d7829e04a2d8ecb964b8f2a6Chris Forbes 22327b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes /* Strip off any array or ptrs. Where we remove array levels, adjust the 22337b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes * descriptor count for each dimension. */ 22345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (type.opcode() == spv::OpTypeArray || type.opcode() == spv::OpTypePointer) { 22357b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes if (type.opcode() == spv::OpTypeArray) { 22367b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes descriptor_count *= get_constant_value(module, type.word(3)); 22377b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(2)); 22387b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22397b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes else { 22407b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes type = module->get_def(type.word(3)); 22417b892d2fc502b57d26dc9bff61b0f23cccc595fdChris Forbes } 22425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (type.opcode()) { 22455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeStruct: { 22465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto insn : *module) { 22475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.opcode() == spv::OpDecorate && insn.word(1) == type.word(1)) { 22485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (insn.word(2) == spv::DecorationBlock) { 22495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER || 22505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC; 22515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (insn.word(2) == spv::DecorationBufferBlock) { 22525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER || 22535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC; 22545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Invalid */ 22595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 22605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampler: 22635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLER; 22645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeSampledImage: 226635cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes if (descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER) { 226735cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes /* Slight relaxation for some GLSL historical madness: samplerBuffer 226835cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really have a sampler, and a texel buffer descriptor 226935cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes * doesn't really provide one. Allow this slight mismatch. 227035cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes */ 227135cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto image_type = module->get_def(type.word(2)); 227235cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto dim = image_type.word(3); 227335cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes auto sampled = image_type.word(7); 227435cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes return dim == spv::DimBuffer && sampled == 1; 227535cd175466f88e5a0a081b29c59c3246d5bf7f78Chris Forbes } 22765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_COMBINED_IMAGE_SAMPLER; 22775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case spv::OpTypeImage: { 22795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* Many descriptor types backing image types-- depends on dimension 22805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * and whether the image will be used with a sampler. SPIRV for 22815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * Vulkan requires that sampled be 1 or 2 -- leaving the decision to 22825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * runtime is unacceptable. 22835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 22845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto dim = type.word(3); 22855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sampled = type.word(7); 22865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 22875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dim == spv::DimSubpassData) { 22885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_INPUT_ATTACHMENT; 22895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dim == spv::DimBuffer) { 22905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sampled == 1) { 22915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_UNIFORM_TEXEL_BUFFER; 22925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_TEXEL_BUFFER; 22945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 22955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (sampled == 1) { 22965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_SAMPLED_IMAGE; 22975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 22985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return descriptor_type == VK_DESCRIPTOR_TYPE_STORAGE_IMAGE; 22995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* We shouldn't really see any other junk types -- but if we do, they're 23035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * a mismatch. 23045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 23055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 23065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; /* Mismatch */ 23075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 23085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 23095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 23104110a6be7a8a287d459475926985f71c27d01298Chris Forbesstatic bool require_feature(debug_report_data *report_data, VkBool32 feature, char const *feature_name) { 2311a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (!feature) { 23124110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2313080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_FEATURE_NOT_ENABLED, "SC", 2314a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader requires VkPhysicalDeviceFeatures::%s but is not " 2315a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "enabled on the device", 2316a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes feature_name)) { 2317a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return false; 2318a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2319a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2320a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2321a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return true; 2322a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2323a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 232469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbesstatic bool validate_shader_capabilities(debug_report_data *report_data, shader_module const *src, 232569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures) { 2326e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 2327a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2328a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2329a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes for (auto insn : *src) { 2330a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes if (insn.opcode() == spv::OpCapability) { 2331a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes switch (insn.word(1)) { 2332a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMatrix: 2333a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityShader: 2334a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInputAttachment: 2335a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampled1D: 2336a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImage1D: 2337a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledBuffer: 2338a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageBuffer: 2339a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageQuery: 2340a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityDerivativeControl: 2341a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes // Always supported by a Vulkan 1.0 implementation -- no feature bits. 2342a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2343a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2344a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometry: 23454110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->geometryShader, "geometryShader"); 2346a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2347a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2348a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellation: 23494110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->tessellationShader, "tessellationShader"); 2350a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2351a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2352a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityFloat64: 23534110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderFloat64, "shaderFloat64"); 2354a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2355a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2356a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInt64: 23574110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderInt64, "shaderInt64"); 2358a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2359a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2360a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityTessellationPointSize: 2361a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityGeometryPointSize: 23624110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderTessellationAndGeometryPointSize, 2363a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderTessellationAndGeometryPointSize"); 2364a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2365a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2366a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageGatherExtended: 23674110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderImageGatherExtended, "shaderImageGatherExtended"); 2368a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2369a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2370a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageMultisample: 23714110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2372a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2373a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2374a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityUniformBufferArrayDynamicIndexing: 23754110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderUniformBufferArrayDynamicIndexing, 2376a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderUniformBufferArrayDynamicIndexing"); 2377a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2378a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2379a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledImageArrayDynamicIndexing: 23804110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderSampledImageArrayDynamicIndexing, 2381a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderSampledImageArrayDynamicIndexing"); 2382a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2383a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2384a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageBufferArrayDynamicIndexing: 23854110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageBufferArrayDynamicIndexing, 2386a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageBufferArrayDynamicIndexing"); 2387a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2388a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2389a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageArrayDynamicIndexing: 23904110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageArrayDynamicIndexing, 2391a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageArrayDynamicIndexing"); 2392a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2393a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2394a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityClipDistance: 23954110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderClipDistance, "shaderClipDistance"); 2396a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2397a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2398a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityCullDistance: 23994110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderCullDistance, "shaderCullDistance"); 2400a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2401a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2402a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageCubeArray: 24034110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2404a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2405a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2406a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampleRateShading: 24074110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2408a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2409a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2410a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySparseResidency: 24114110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceResidency, "shaderResourceResidency"); 2412a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2413a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2414a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMinLod: 24154110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderResourceMinLod, "shaderResourceMinLod"); 2416a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2417a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2418a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilitySampledCubeArray: 24194110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->imageCubeArray, "imageCubeArray"); 2420a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2421a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2422a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityImageMSArray: 24234110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageMultisample, "shaderStorageImageMultisample"); 2424a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2425a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2426a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageExtendedFormats: 24274110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageExtendedFormats, 2428a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageExtendedFormats"); 2429a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2430a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2431a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityInterpolationFunction: 24324110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->sampleRateShading, "sampleRateShading"); 2433a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2434a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2435a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageReadWithoutFormat: 24364110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageReadWithoutFormat, 2437a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageReadWithoutFormat"); 2438a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2439a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2440a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityStorageImageWriteWithoutFormat: 24414110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->shaderStorageImageWriteWithoutFormat, 2442a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "shaderStorageImageWriteWithoutFormat"); 2443a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2444a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2445a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes case spv::CapabilityMultiViewport: 24464110a6be7a8a287d459475926985f71c27d01298Chris Forbes pass &= require_feature(report_data, enabledFeatures->multiViewport, "multiViewport"); 2447a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2448a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2449a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes default: 24504110a6be7a8a287d459475926985f71c27d01298Chris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2451a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes __LINE__, SHADER_CHECKER_BAD_CAPABILITY, "SC", 2452a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes "Shader declares capability %u, not supported in Vulkan.", 2453a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes insn.word(1))) 2454e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 2455a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes break; 2456a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2457a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2458a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes } 2459a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2460a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes return pass; 2461a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes} 2462a3c20a28f119d24faec013fb4513605b654c36c3Chris Forbes 2463ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbesstatic bool validate_pipeline_shader_stage(debug_report_data *report_data, 2464ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes VkPipelineShaderStageCreateInfo const *pStage, 2465ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes PIPELINE_NODE *pipeline, 2466ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes shader_module **out_module, 2467ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes spirv_inst_iter *out_entrypoint, 246869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 2469ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unordered_map<VkShaderModule, 2470ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes std::unique_ptr<shader_module>> const &shaderModuleMap) { 2471e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 247269f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module_it = shaderModuleMap.find(pStage->module); 247369f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes auto module = *out_module = module_it->second.get(); 2474557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_specialization_offsets(report_data, pStage); 247578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 247678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* find the entrypoint */ 247778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto entrypoint = *out_entrypoint = find_entrypoint(module, pStage->pName, pStage->stage); 247878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (entrypoint == module->end()) { 2479557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2480080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_ENTRYPOINT, "SC", 248178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "No entrypoint found named `%s` for stage %s", pStage->pName, 248278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2483e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 248478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 248578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 248678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 248778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate shader capabilities against enabled device features */ 2488557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_shader_capabilities(report_data, module, enabledFeatures); 248978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 249078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* mark accessible ids */ 249178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::unordered_set<uint32_t> accessible_ids; 249278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes mark_accessible_ids(module, entrypoint, accessible_ids); 249378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 249478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor set layout against what the entrypoint actually uses */ 249578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes std::map<descriptor_slot_t, interface_var> descriptor_uses; 2496557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes collect_interface_by_descriptor_slot(report_data, module, accessible_ids, descriptor_uses); 249778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2498ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes auto pipelineLayout = pipeline->pipelineLayout; 2499ed399f66e0512ef077d0e0a7cb903248726d2424Chris Forbes 250078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate push constant usage */ 2501557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes pass &= validate_push_constant_usage(report_data, &pipelineLayout->pushConstantRanges, 250278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes module, accessible_ids, pStage->stage); 250378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 250478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /* validate descriptor use */ 250578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes for (auto use : descriptor_uses) { 250678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes // While validating shaders capture which slots are used by the pipeline 250778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes pipeline->active_slots[use.first.first].insert(use.first.second); 250878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2509fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /* verify given pipelineLayout has requested setLayout with requested binding */ 25104110a6be7a8a287d459475926985f71c27d01298Chris Forbes const auto & binding = get_descriptor_binding(pipelineLayout, use.first); 251178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes unsigned required_descriptor_count; 251278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 251378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes if (!binding) { 2514557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 2515080afef66a53dbdd085698b713697296458edfd9Chris Forbes __LINE__, SHADER_CHECKER_MISSING_DESCRIPTOR, "SC", 251678be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used as type `%s`) but not declared in pipeline layout", 251778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str())) { 2518e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 251978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 252078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (~binding->stageFlags & pStage->stage) { 2521557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 252278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes /*dev*/ 0, __LINE__, SHADER_CHECKER_DESCRIPTOR_NOT_ACCESSIBLE_FROM_STAGE, "SC", 252378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader uses descriptor slot %u.%u (used " 252478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "as type `%s`) but descriptor not " 252578be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "accessible from stage %s", 2526fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 252778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkShaderStageFlagBits(pStage->stage))) { 2528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 252978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 2530edef66e03ed509994449d598f4fadea1a487d41bChris Forbes } else if (!descriptor_type_match(module, use.second.type_id, binding->descriptorType, 2531fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis /*out*/ required_descriptor_count)) { 2532557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2533fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", "Type mismatch on descriptor slot " 2534fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "%u.%u (used as type `%s`) but " 2535fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "descriptor of type %s", 2536fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis use.first.first, use.first.second, describe_type(module, use.second.type_id).c_str(), 253778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes string_VkDescriptorType(binding->descriptorType))) { 2538e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 253978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } else if (binding->descriptorCount < required_descriptor_count) { 2541557cdd5218accf51ca894a14b7c6eeeb733f5cbbChris Forbes if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 2542fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis SHADER_CHECKER_DESCRIPTOR_TYPE_MISMATCH, "SC", 254378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes "Shader expects at least %u descriptors for binding %u.%u (used as type `%s`) but only %u provided", 254478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes required_descriptor_count, use.first.first, use.first.second, 2545fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis describe_type(module, use.second.type_id).c_str(), binding->descriptorCount)) { 2546e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pass = false; 254778be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254878be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 254978be5018e238bd464b1f1c55138df277c0c18922Chris Forbes } 255078be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255178be5018e238bd464b1f1c55138df277c0c18922Chris Forbes return pass; 255278be5018e238bd464b1f1c55138df277c0c18922Chris Forbes} 255378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 255478be5018e238bd464b1f1c55138df277c0c18922Chris Forbes 2555a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// Validate that the shaders used by the given pipeline and store the active_slots 2556a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis// that are actually used by the pipeline into pPipeline->active_slots 2557e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_and_capture_pipeline_shader_state(debug_report_data *report_data, PIPELINE_NODE *pPipeline, 255869f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes VkPhysicalDeviceFeatures const *enabledFeatures, 255969f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 25606660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->graphicsPipelineCI.ptr(); 25615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int vertex_stage = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int fragment_stage = get_shader_stage_id(VK_SHADER_STAGE_FRAGMENT_BIT); 25635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis shader_module *shaders[5]; 25655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(shaders, 0, sizeof(shaders)); 25665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis spirv_inst_iter entrypoints[5]; 25675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(entrypoints, 0, sizeof(entrypoints)); 25685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkPipelineVertexInputStateCreateInfo const *vi = 0; 2569e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool pass = true; 25705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) { 25726660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pStage = &pCreateInfo->pStages[i]; 257378be5018e238bd464b1f1c55138df277c0c18922Chris Forbes auto stage_id = get_shader_stage_id(pStage->stage); 2574e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_pipeline_shader_stage(report_data, pStage, pPipeline, 257569f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &shaders[stage_id], &entrypoints[stage_id], 257669f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes enabledFeatures, shaderModuleMap); 25775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vi = pCreateInfo->pVertexInputState; 25805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vi) { 2582e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_consistency(report_data, vi); 25835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[vertex_stage]) { 2586e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_vi_against_vs_inputs(report_data, vi, shaders[vertex_stage], entrypoints[vertex_stage]); 25875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int producer = get_shader_stage_id(VK_SHADER_STAGE_VERTEX_BIT); 25905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis int consumer = get_shader_stage_id(VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT); 25915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (!shaders[producer] && producer != fragment_stage) { 25935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer++; 25945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis consumer++; 25955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 25965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 25975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (; producer != fragment_stage && consumer <= fragment_stage; consumer++) { 25985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(shaders[producer]); 25995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (shaders[consumer]) { 2600e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_interface_between_stages(report_data, 2601031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[producer], entrypoints[producer], &shader_stage_attribs[producer], 2602031261d21af8907953dd763398ce9a23e65b8749Chris Forbes shaders[consumer], entrypoints[consumer], &shader_stage_attribs[consumer]); 26035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis producer = consumer; 26055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26087c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes if (shaders[fragment_stage] && pPipeline->renderPass) { 2609e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes pass &= validate_fs_outputs_against_render_pass(report_data, shaders[fragment_stage], entrypoints[fragment_stage], 26107c7400aa231c3dbb21e51158adebb83d5f528130Chris Forbes pPipeline->renderPass, pCreateInfo->subpass); 26115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 26135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pass; 26145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2616e4be8c69231df45752686575f22168b6d0fc5687Chris Forbesstatic bool validate_compute_pipeline(debug_report_data *report_data, PIPELINE_NODE *pPipeline, VkPhysicalDeviceFeatures const *enabledFeatures, 261769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes std::unordered_map<VkShaderModule, unique_ptr<shader_module>> const & shaderModuleMap) { 26186660d6f3e4e4c895063e8d99098162bd2f508b24Chris Forbes auto pCreateInfo = pPipeline->computePipelineCI.ptr(); 261903857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 262003857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes shader_module *module; 262103857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes spirv_inst_iter entrypoint; 262203857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 2623e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes return validate_pipeline_shader_stage(report_data, &pCreateInfo->stage, pPipeline, 262469f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes &module, &entrypoint, enabledFeatures, shaderModuleMap); 262503857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes} 262603857e826cdc6e8d814137fb3245596ca1cb7bc7Chris Forbes 26275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Set node ptr for specified set or else NULL 2628397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlisstatic cvdescriptorset::DescriptorSet *getSetNode(layer_data *my_data, const VkDescriptorSet set) { 26295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->setMap.find(set) == my_data->setMap.end()) { 26305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 26315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return my_data->setMap[set]; 26335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// For the given command buffer, verify and update the state for activeSetBindingsPairs 26357a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// This includes: 26367a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 1. Verifying that any dynamic descriptor in that set has a valid dynamic offset bound. 26377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// To be valid, the dynamic offset combined with the offset and range from its 26387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// descriptor update must not overflow the size of its buffer being updated 26397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 2. Grow updateImages for given pCB to include any bound STORAGE_IMAGE descriptor images 26407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis// 3. Grow updateBuffers for pCB to include buffers from STORAGE*_BUFFER descriptor buffers 2641e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_drawtime_descriptor_state( 26427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis layer_data *dev_data, GLOBAL_CB_NODE *pCB, 2643dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes const vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, 2644dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t> const *>> &activeSetBindingsPairs) { 2645e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 2646a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis for (auto set_bindings_pair : activeSetBindingsPairs) { 2647dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes cvdescriptorset::DescriptorSet *set_node = std::get<0>(set_bindings_pair); 2648cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis std::string err_str; 2649dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (!set_node->ValidateDrawState(std::get<1>(set_bindings_pair), *std::get<2>(set_bindings_pair), 2650397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis &err_str)) { 2651cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis // Report error here 2652397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis auto set = set_node->GetSet(); 2653cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis result |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2654cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2655414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " encountered the following validation error at draw time: %s", 2656cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis reinterpret_cast<const uint64_t &>(set), err_str.c_str()); 2657cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 2658dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes set_node->GetStorageUpdates(std::get<1>(set_bindings_pair), &pCB->updateBuffers, &pCB->updateImages); 26595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 26605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 26615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 26625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2663eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// For given pipeline, return number of MSAA samples, or one if MSAA disabled 2664ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbesstatic VkSampleCountFlagBits getNumSamples(PIPELINE_NODE const *pipe) { 2665ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes if (pipe->graphicsPipelineCI.pMultisampleState != NULL && 2666ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes VK_STRUCTURE_TYPE_PIPELINE_MULTISAMPLE_STATE_CREATE_INFO == pipe->graphicsPipelineCI.pMultisampleState->sType) { 2667eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return pipe->graphicsPipelineCI.pMultisampleState->rasterizationSamples; 2668eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2669eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return VK_SAMPLE_COUNT_1_BIT; 2670eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2671eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2672eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young// Validate draw-time state related to the PSO 267329d196e071b2dc1db47702085469396f2b956820Chris Forbesstatic bool validatePipelineDrawtimeState(layer_data const *my_data, 267429d196e071b2dc1db47702085469396f2b956820Chris Forbes LAST_BOUND_STATE const &state, 267529d196e071b2dc1db47702085469396f2b956820Chris Forbes const GLOBAL_CB_NODE *pCB, 267629d196e071b2dc1db47702085469396f2b956820Chris Forbes PIPELINE_NODE const *pPipeline) { 2677eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young bool skip_call = false; 267829d196e071b2dc1db47702085469396f2b956820Chris Forbes 267929d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify Vtx binding 268029d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pPipeline->vertexBindingDescriptions.size() > 0) { 268129d196e071b2dc1db47702085469396f2b956820Chris Forbes for (size_t i = 0; i < pPipeline->vertexBindingDescriptions.size(); i++) { 268229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((pCB->currentDrawData.buffers.size() < (i + 1)) || (pCB->currentDrawData.buffers[i] == VK_NULL_HANDLE)) { 268329d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 268429d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 268529d196e071b2dc1db47702085469396f2b956820Chris Forbes "The Pipeline State Object (0x%" PRIxLEAST64 268629d196e071b2dc1db47702085469396f2b956820Chris Forbes ") expects that this Command Buffer's vertex binding Index " PRINTF_SIZE_T_SPECIFIER 268729d196e071b2dc1db47702085469396f2b956820Chris Forbes " should be set via vkCmdBindVertexBuffers.", 268829d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)state.pipeline, i); 268929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 269029d196e071b2dc1db47702085469396f2b956820Chris Forbes } 269129d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 269229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pCB->currentDrawData.buffers.empty()) { 269329d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 269429d196e071b2dc1db47702085469396f2b956820Chris Forbes 0, __LINE__, DRAWSTATE_VTX_INDEX_OUT_OF_BOUNDS, "DS", 269529d196e071b2dc1db47702085469396f2b956820Chris Forbes "Vertex buffers are bound to command buffer (0x%" PRIxLEAST64 269629d196e071b2dc1db47702085469396f2b956820Chris Forbes ") but no vertex buffers are attached to this Pipeline State Object (0x%" PRIxLEAST64 ").", 269729d196e071b2dc1db47702085469396f2b956820Chris Forbes (uint64_t)pCB->commandBuffer, (uint64_t)state.pipeline); 269829d196e071b2dc1db47702085469396f2b956820Chris Forbes } 269929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 270029d196e071b2dc1db47702085469396f2b956820Chris Forbes // If Viewport or scissors are dynamic, verify that dynamic count matches PSO count. 270129d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip check if rasterization is disabled or there is no viewport. 270229d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((!pPipeline->graphicsPipelineCI.pRasterizationState || 270329d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) && 270429d196e071b2dc1db47702085469396f2b956820Chris Forbes pPipeline->graphicsPipelineCI.pViewportState) { 270529d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 270629d196e071b2dc1db47702085469396f2b956820Chris Forbes bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 270729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynViewport) { 270829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->viewports.size() != pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 270929d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 271029d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 271129d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic viewportCount from vkCmdSetViewport() is " PRINTF_SIZE_T_SPECIFIER 271229d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO viewportCount is %u. These counts must match.", 271329d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->viewports.size(), pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 271429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 271529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 271629d196e071b2dc1db47702085469396f2b956820Chris Forbes if (dynScissor) { 271729d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->scissors.size() != pPipeline->graphicsPipelineCI.pViewportState->scissorCount) { 271829d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 271929d196e071b2dc1db47702085469396f2b956820Chris Forbes __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 272029d196e071b2dc1db47702085469396f2b956820Chris Forbes "Dynamic scissorCount from vkCmdSetScissor() is " PRINTF_SIZE_T_SPECIFIER 272129d196e071b2dc1db47702085469396f2b956820Chris Forbes ", but PSO scissorCount is %u. These counts must match.", 272229d196e071b2dc1db47702085469396f2b956820Chris Forbes pCB->scissors.size(), pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 272329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 272429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 272529d196e071b2dc1db47702085469396f2b956820Chris Forbes } 272629d196e071b2dc1db47702085469396f2b956820Chris Forbes 272729d196e071b2dc1db47702085469396f2b956820Chris Forbes // Verify that any MSAA request in PSO matches sample# in bound FB 272829d196e071b2dc1db47702085469396f2b956820Chris Forbes // Skip the check if rasterization is disabled. 272929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (!pPipeline->graphicsPipelineCI.pRasterizationState || 273029d196e071b2dc1db47702085469396f2b956820Chris Forbes (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 273129d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits pso_num_samples = getNumSamples(pPipeline); 273229d196e071b2dc1db47702085469396f2b956820Chris Forbes if (pCB->activeRenderPass) { 273329d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkRenderPassCreateInfo *render_pass_info = pCB->activeRenderPass->pCreateInfo; 273429d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSubpassDescription *subpass_desc = &render_pass_info->pSubpasses[pCB->activeSubpass]; 273529d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits subpass_num_samples = VkSampleCountFlagBits(0); 273629d196e071b2dc1db47702085469396f2b956820Chris Forbes uint32_t i; 273729d196e071b2dc1db47702085469396f2b956820Chris Forbes 273829d196e071b2dc1db47702085469396f2b956820Chris Forbes const safe_VkPipelineColorBlendStateCreateInfo *color_blend_state = pPipeline->graphicsPipelineCI.pColorBlendState; 273929d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((color_blend_state != NULL) && (pCB->activeSubpass == pPipeline->graphicsPipelineCI.subpass) && 274029d196e071b2dc1db47702085469396f2b956820Chris Forbes (color_blend_state->attachmentCount != subpass_desc->colorAttachmentCount)) { 274129d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2742eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2743ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 2744eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "Render pass subpass %u mismatch with blending state defined and blend state attachment " 2745414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "count %u while subpass color attachment count %u in Pipeline (0x%" PRIxLEAST64 ")! These " 2746eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young "must be the same at draw-time.", 2747eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young pCB->activeSubpass, color_blend_state->attachmentCount, subpass_desc->colorAttachmentCount, 2748ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 274929d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2750eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 275129d196e071b2dc1db47702085469396f2b956820Chris Forbes for (i = 0; i < subpass_desc->colorAttachmentCount; i++) { 275229d196e071b2dc1db47702085469396f2b956820Chris Forbes VkSampleCountFlagBits samples; 2753eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 275429d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_desc->pColorAttachments[i].attachment == VK_ATTACHMENT_UNUSED) 275529d196e071b2dc1db47702085469396f2b956820Chris Forbes continue; 2756eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 275729d196e071b2dc1db47702085469396f2b956820Chris Forbes samples = render_pass_info->pAttachments[subpass_desc->pColorAttachments[i].attachment].samples; 275829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) { 275929d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 276029d196e071b2dc1db47702085469396f2b956820Chris Forbes } else if (subpass_num_samples != samples) { 276129d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 276229d196e071b2dc1db47702085469396f2b956820Chris Forbes break; 2763eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 276429d196e071b2dc1db47702085469396f2b956820Chris Forbes } 276529d196e071b2dc1db47702085469396f2b956820Chris Forbes if ((subpass_desc->pDepthStencilAttachment != NULL) && 276629d196e071b2dc1db47702085469396f2b956820Chris Forbes (subpass_desc->pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 276729d196e071b2dc1db47702085469396f2b956820Chris Forbes const VkSampleCountFlagBits samples = 2768eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young render_pass_info->pAttachments[subpass_desc->pDepthStencilAttachment->attachment].samples; 276929d196e071b2dc1db47702085469396f2b956820Chris Forbes if (subpass_num_samples == static_cast<VkSampleCountFlagBits>(0)) 277029d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = samples; 277129d196e071b2dc1db47702085469396f2b956820Chris Forbes else if (subpass_num_samples != samples) 277229d196e071b2dc1db47702085469396f2b956820Chris Forbes subpass_num_samples = static_cast<VkSampleCountFlagBits>(-1); 277329d196e071b2dc1db47702085469396f2b956820Chris Forbes } 2774eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 277529d196e071b2dc1db47702085469396f2b956820Chris Forbes if (((subpass_desc->colorAttachmentCount > 0) || (subpass_desc->pDepthStencilAttachment != NULL)) && 277629d196e071b2dc1db47702085469396f2b956820Chris Forbes (pso_num_samples != subpass_num_samples)) { 277729d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= 2778eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 2779ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 2780414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Num samples mismatch! At draw-time in Pipeline (0x%" PRIxLEAST64 2781414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") with %u samples while current RenderPass (0x%" PRIxLEAST64 ") w/ %u samples!", 2782ea8349eeee76ae2859c10870fd8bd9e60309eb28Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), pso_num_samples, 2783ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes reinterpret_cast<const uint64_t &>(pCB->activeRenderPass->renderPass), subpass_num_samples); 2784eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 278529d196e071b2dc1db47702085469396f2b956820Chris Forbes } else { 278629d196e071b2dc1db47702085469396f2b956820Chris Forbes skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 278729d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline), __LINE__, DRAWSTATE_NUM_SAMPLES_MISMATCH, "DS", 278829d196e071b2dc1db47702085469396f2b956820Chris Forbes "No active render pass found at draw-time in Pipeline (0x%" PRIxLEAST64 ")!", 278929d196e071b2dc1db47702085469396f2b956820Chris Forbes reinterpret_cast<const uint64_t &>(pPipeline->pipeline)); 2790eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 2791eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young } 279229d196e071b2dc1db47702085469396f2b956820Chris Forbes // TODO : Add more checks here 279329d196e071b2dc1db47702085469396f2b956820Chris Forbes 2794eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young return skip_call; 2795eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young} 2796eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 27975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate overall state at the time of a draw call 2798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validate_and_update_draw_state(layer_data *my_data, GLOBAL_CB_NODE *pCB, const bool indexedDraw, 2799e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkPipelineBindPoint bindPoint) { 2800e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 28017a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto const &state = pCB->lastBound[bindPoint]; 28027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis PIPELINE_NODE *pPipe = getPipeline(my_data, state.pipeline); 280322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (nullptr == pPipe) { 280422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 280522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, __LINE__, 280622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_INVALID_PIPELINE, "DS", 280722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "At Draw/Dispatch time no valid VkPipeline is bound! This is illegal. Please bind one with vkCmdBindPipeline()."); 280822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Early return as any further checks below will be busted w/o a pipeline 280922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (result) 281022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis return true; 281122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 28123d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // First check flag states 28137a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 28147a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis result = validate_draw_state_flags(my_data, pCB, pPipe, indexedDraw); 28157a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 28165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now complete other state checks 281722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if (state.pipelineLayout) { 281822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis string errorString; 2819169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes auto pipelineLayout = (bindPoint == VK_PIPELINE_BIND_POINT_GRAPHICS) ? pPipe->graphicsPipelineCI.layout : pPipe->computePipelineCI.layout; 2820169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes 282122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Need a vector (vs. std::set) of active Sets for dynamicOffset validation in case same set bound w/ different offsets 2822dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes vector<std::tuple<cvdescriptorset::DescriptorSet *, unordered_set<uint32_t>, std::vector<uint32_t> const *>> activeSetBindingsPairs; 2823dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes for (auto & setBindingPair : pPipe->active_slots) { 282422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis uint32_t setIndex = setBindingPair.first; 282522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If valid set is not bound throw an error 282622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis if ((state.boundDescriptorSets.size() <= setIndex) || (!state.boundDescriptorSets[setIndex])) { 282722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 282822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis DRAWSTATE_DESCRIPTOR_SET_NOT_BOUND, "DS", 2829414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkPipeline 0x%" PRIxLEAST64 " uses set #%u but that set is not bound.", (uint64_t)pPipe->pipeline, 283022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis setIndex); 283171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis } else if (!verify_set_layout_compatibility(my_data, state.boundDescriptorSets[setIndex], 2832169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes pipelineLayout, setIndex, errorString)) { 283322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Set is bound but not compatible w/ overlapping pipelineLayout from PSO 283471511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VkDescriptorSet setHandle = state.boundDescriptorSets[setIndex]->GetSet(); 283522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= 283622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 283722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis (uint64_t)setHandle, __LINE__, DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 2838414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkDescriptorSet (0x%" PRIxLEAST64 2839414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") bound as set #%u is not compatible with overlapping VkPipelineLayout 0x%" PRIxLEAST64 " due to: %s", 2840169c4506062f06d6676eb4da3c9e0437d1d9d659Chris Forbes (uint64_t)setHandle, setIndex, (uint64_t)pipelineLayout, errorString.c_str()); 284122fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } else { // Valid set is bound and layout compatible, validate that it's updated 284222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Pull the set node 284371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis cvdescriptorset::DescriptorSet *pSet = state.boundDescriptorSets[setIndex]; 284422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Save vector of all active sets to verify dynamicOffsets below 2845dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes activeSetBindingsPairs.push_back(std::make_tuple(pSet, setBindingPair.second, 2846dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes &state.dynamicOffsets[setIndex])); 284722fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // Make sure set has been updated if it has no immutable samplers 284822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // If it has immutable samplers, we'll flag error later as needed depending on binding 2849397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated()) { 285022fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis for (auto binding : setBindingPair.second) { 2851397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->GetImmutableSamplerPtrFromBinding(binding)) { 285222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= log_msg( 285322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 2854397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet(), __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 2855414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 " bound but it was never updated. It is now being used to draw so " 285622fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis "this will result in undefined behavior.", 2857397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis (uint64_t)pSet->GetSet()); 2858fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis } 28595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 28615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 286222fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 286322fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis // For given active slots, verify any dynamic descriptors and record updated images & buffers 286422fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis result |= validate_and_update_drawtime_descriptor_state(my_data, pCB, activeSetBindingsPairs); 286522fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis } 2866eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 2867eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young // Check general pipeline state that needs to be validated at drawtime 286829d196e071b2dc1db47702085469396f2b956820Chris Forbes if (VK_PIPELINE_BIND_POINT_GRAPHICS == bindPoint) 286929d196e071b2dc1db47702085469396f2b956820Chris Forbes result |= validatePipelineDrawtimeState(my_data, state, pCB, pPipe); 2870eca2d52a6bfa3f9d63a86ca9fd30abc0adf775b7Mark Young 28715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 28725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 28735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2874a27508babf63d50aea75883a3702979193c23683Mark Young// Validate HW line width capabilities prior to setting requested line width. 2875a27508babf63d50aea75883a3702979193c23683Mark Youngstatic bool verifyLineWidth(layer_data *my_data, DRAW_STATE_ERROR dsError, const uint64_t &target, float lineWidth) { 2876a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 2877a27508babf63d50aea75883a3702979193c23683Mark Young 2878a27508babf63d50aea75883a3702979193c23683Mark Young // First check to see if the physical device supports wide lines. 2879a27508babf63d50aea75883a3702979193c23683Mark Young if ((VK_FALSE == my_data->phys_dev_properties.features.wideLines) && (1.0f != lineWidth)) { 2880a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, __LINE__, 2881a27508babf63d50aea75883a3702979193c23683Mark Young dsError, "DS", "Attempt to set lineWidth to %f but physical device wideLines feature " 2882a27508babf63d50aea75883a3702979193c23683Mark Young "not supported/enabled so lineWidth must be 1.0f!", 2883a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth); 2884a27508babf63d50aea75883a3702979193c23683Mark Young } else { 2885a27508babf63d50aea75883a3702979193c23683Mark Young // Otherwise, make sure the width falls in the valid range. 2886a27508babf63d50aea75883a3702979193c23683Mark Young if ((my_data->phys_dev_properties.properties.limits.lineWidthRange[0] > lineWidth) || 2887a27508babf63d50aea75883a3702979193c23683Mark Young (my_data->phys_dev_properties.properties.limits.lineWidthRange[1] < lineWidth)) { 2888a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, target, 2889a27508babf63d50aea75883a3702979193c23683Mark Young __LINE__, dsError, "DS", "Attempt to set lineWidth to %f but physical device limits line width " 2890a27508babf63d50aea75883a3702979193c23683Mark Young "to between [%f, %f]!", 2891a27508babf63d50aea75883a3702979193c23683Mark Young lineWidth, my_data->phys_dev_properties.properties.limits.lineWidthRange[0], 2892a27508babf63d50aea75883a3702979193c23683Mark Young my_data->phys_dev_properties.properties.limits.lineWidthRange[1]); 2893a27508babf63d50aea75883a3702979193c23683Mark Young } 2894a27508babf63d50aea75883a3702979193c23683Mark Young } 2895a27508babf63d50aea75883a3702979193c23683Mark Young 2896a27508babf63d50aea75883a3702979193c23683Mark Young return skip_call; 2897a27508babf63d50aea75883a3702979193c23683Mark Young} 2898a27508babf63d50aea75883a3702979193c23683Mark Young 28995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that create state for a pipeline is valid 2900e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool verifyPipelineCreateState(layer_data *my_data, const VkDevice device, std::vector<PIPELINE_NODE *> pPipelines, 2901e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves int pipelineIndex) { 2902e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 29035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPipeline = pPipelines[pipelineIndex]; 29055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If create derivative bit is set, check that we've specified a base 29075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // pipeline correctly, and that the base pipeline was created to allow 29085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // derivatives. 29095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_DERIVATIVE_BIT) { 29105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pBasePipeline = nullptr; 29115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) ^ 29125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.basePipelineIndex != -1))) { 29135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: exactly one of base pipeline index and handle must be specified"); 29165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineIndex != -1) { 29175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.basePipelineIndex >= pipelineIndex) { 29185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline must occur earlier in array than derivative pipeline."); 29225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 29235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = pPipelines[pPipeline->graphicsPipelineCI.basePipelineIndex]; 29245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.basePipelineHandle != VK_NULL_HANDLE) { 29265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBasePipeline = getPipeline(my_data, pPipeline->graphicsPipelineCI.basePipelineHandle); 29275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBasePipeline && !(pBasePipeline->graphicsPipelineCI.flags & VK_PIPELINE_CREATE_ALLOW_DERIVATIVES_BIT)) { 29305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 29325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: base pipeline does not allow derivatives."); 29335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 29365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pColorBlendState != NULL) { 2937b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.independentBlend) { 29383d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipeline->attachments.size() > 1) { 293926c548826ff0f83d12c769b51e7d6f76d1265c0eChris Forbes VkPipelineColorBlendAttachmentState *pAttachments = &pPipeline->attachments[0]; 2940c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski for (size_t i = 1; i < pPipeline->attachments.size(); i++) { 2941c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski if ((pAttachments[0].blendEnable != pAttachments[i].blendEnable) || 2942c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcColorBlendFactor != pAttachments[i].srcColorBlendFactor) || 2943c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstColorBlendFactor != pAttachments[i].dstColorBlendFactor) || 2944c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorBlendOp != pAttachments[i].colorBlendOp) || 2945c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].srcAlphaBlendFactor != pAttachments[i].srcAlphaBlendFactor) || 2946c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].dstAlphaBlendFactor != pAttachments[i].dstAlphaBlendFactor) || 2947c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].alphaBlendOp != pAttachments[i].alphaBlendOp) || 2948c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski (pAttachments[0].colorWriteMask != pAttachments[i].colorWriteMask)) { 2949c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski skipCall |= 2950c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 2951c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski DRAWSTATE_INDEPENDENT_BLEND, "DS", "Invalid Pipeline CreateInfo: If independent blend feature not " 2952c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski "enabled, all elements of pAttachments must be identical"); 2953c7bd67f06427b08ba65cdf2dd529c8234beebdd5Mark Lobodzinski } 29545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 2957b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!my_data->phys_dev_properties.features.logicOp && 29585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable != VK_FALSE)) { 29595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_DISABLED_LOGIC_OP, "DS", 29625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logic operations feature not enabled, logicOpEnable must be VK_FALSE"); 29635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOpEnable == VK_TRUE) && 29655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->graphicsPipelineCI.pColorBlendState->logicOp < VK_LOGIC_OP_CLEAR) || 29665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->graphicsPipelineCI.pColorBlendState->logicOp > VK_LOGIC_OP_SET))) { 29675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 29685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_LOGIC_OP, "DS", 29705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo: If logicOpEnable is VK_TRUE, logicOp must be a valid VkLogicOp value"); 29715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2974a61b537fcb6a4f7b92cd217b3964ad7a48109da1Tobin Ehlis // Ensure the subpass index is valid. If not, then validate_and_capture_pipeline_shader_state 29755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // produces nonsense errors that confuse users. Other layers should already 29765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // emit errors for renderpass being invalid. 297716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(my_data, pPipeline->graphicsPipelineCI.renderPass); 297816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass && 297916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass >= renderPass->pCreateInfo->subpassCount) { 29805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 29815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Subpass index %u " 29825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "is out of range for this renderpass (0..%u)", 298316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeline->graphicsPipelineCI.subpass, renderPass->pCreateInfo->subpassCount - 1); 29845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 29855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 2986e4be8c69231df45752686575f22168b6d0fc5687Chris Forbes if (!validate_and_capture_pipeline_shader_state(my_data->report_data, pPipeline, &my_data->phys_dev_properties.features, 298769f9a551bfb1fd5334950f9685c12c5adda23dfbChris Forbes my_data->shaderModuleMap)) { 2988e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall = true; 29895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 299052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes // Each shader's stage must be unique 299152156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders) { 299252156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes for (uint32_t stage = VK_SHADER_STAGE_VERTEX_BIT; stage & VK_SHADER_STAGE_ALL_GRAPHICS; stage <<= 1) { 299352156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes if (pPipeline->duplicate_shaders & stage) { 299452156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VkDebugReportObjectTypeEXT(0), 0, 299552156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes __LINE__, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 299652156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes "Invalid Pipeline CreateInfo State: Multiple shaders provided for stage %s", 299752156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes string_VkShaderStageFlagBits(VkShaderStageFlagBits(stage))); 299852156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 299952156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 300052156ec29c88c0e52eb89fb42867adacb1dd31bbChris Forbes } 30015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VS is required 30025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT)) { 30035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 30045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: Vtx Shader required"); 30065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Either both or neither TC/TE shaders should be defined 30085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) == 0) != 30095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) == 0)) { 30105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: TE and TC shaders must be included or excluded as a pair"); 30135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Compute shaders should be specified independent of Gfx shaders 30155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pPipeline->active_shaders & VK_SHADER_STAGE_COMPUTE_BIT) && 30165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pPipeline->active_shaders & 30175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VK_SHADER_STAGE_VERTEX_BIT | VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT | 30185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_SHADER_STAGE_GEOMETRY_BIT | VK_SHADER_STAGE_FRAGMENT_BIT))) { 30195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 30215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Invalid Pipeline CreateInfo State: Do not specify Compute Shader for Gfx Pipeline"); 30225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive topology is only valid for tessellation pipelines. 30245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Mismatching primitive topology and tessellation fails graphics pipeline creation. 30255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->active_shaders & (VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT | VK_SHADER_STAGE_TESSELLATION_EVALUATION_BIT) && 3026ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (!pPipeline->graphicsPipelineCI.pInputAssemblyState || 3027ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology != VK_PRIMITIVE_TOPOLOGY_PATCH_LIST)) { 30285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST must be set as IA " 30315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology for tessellation pipelines"); 30325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3033ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (pPipeline->graphicsPipelineCI.pInputAssemblyState && 3034ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pInputAssemblyState->topology == VK_PRIMITIVE_TOPOLOGY_PATCH_LIST) { 30355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (~pPipeline->active_shaders & VK_SHADER_STAGE_TESSELLATION_CONTROL_BIT) { 30365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 30395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology is only valid for tessellation pipelines"); 30405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3041ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pTessellationState) { 3042ca546210846c65808717f8875deae39bd227c240Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3043ca546210846c65808717f8875deae39bd227c240Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", 3044ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "Invalid Pipeline CreateInfo State: " 3045ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "pTessellationState is NULL when VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 3046ca546210846c65808717f8875deae39bd227c240Tobin Ehlis "topology used. pTessellationState must not be NULL in this case."); 3047ca546210846c65808717f8875deae39bd227c240Tobin Ehlis } else if (!pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints || 3048ca546210846c65808717f8875deae39bd227c240Tobin Ehlis (pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints > 32)) { 30495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, "DS", "Invalid Pipeline CreateInfo State: " 30515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_PRIMITIVE_TOPOLOGY_PATCH_LIST primitive " 30525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "topology used with patchControlPoints value %u." 30535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " patchControlPoints should be >0 and <=32.", 3054ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pTessellationState->patchControlPoints); 30555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3057a27508babf63d50aea75883a3702979193c23683Mark Young // If a rasterization state is provided, make sure that the line width conforms to the HW. 3058a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeline->graphicsPipelineCI.pRasterizationState) { 3059a27508babf63d50aea75883a3702979193c23683Mark Young if (!isDynamic(pPipeline, VK_DYNAMIC_STATE_LINE_WIDTH)) { 3060a27508babf63d50aea75883a3702979193c23683Mark Young skipCall |= verifyLineWidth(my_data, DRAWSTATE_INVALID_PIPELINE_CREATE_STATE, reinterpret_cast<uint64_t &>(pPipeline), 3061a27508babf63d50aea75883a3702979193c23683Mark Young pPipeline->graphicsPipelineCI.pRasterizationState->lineWidth); 3062a27508babf63d50aea75883a3702979193c23683Mark Young } 3063a27508babf63d50aea75883a3702979193c23683Mark Young } 30645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Viewport state must be included if rasterization is enabled. 30655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the viewport state is included, the viewport and scissor counts should always match. 30665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Even if these are flagged as dynamic, counts need to be set correctly for shader compiler 30675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pRasterizationState || 306845824955f3d4d2baee6d225f84ac9c2553981b3eDustin Graves (pPipeline->graphicsPipelineCI.pRasterizationState->rasterizerDiscardEnable == VK_FALSE)) { 30695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeline->graphicsPipelineCI.pViewportState) { 30705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", "Gfx Pipeline pViewportState is null. Even if viewport " 30725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and scissors are dynamic PSO must include " 30735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "viewportCount and scissorCount in pViewportState."); 30745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount != 30755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount) { 30765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 30775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewport count (%u) must match scissor count (%u).", 3079ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount, 3080ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 30815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 30825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If viewport or scissor are not dynamic, then verify that data is appropriate for count 3083e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynViewport = isDynamic(pPipeline, VK_DYNAMIC_STATE_VIEWPORT); 3084e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool dynScissor = isDynamic(pPipeline, VK_DYNAMIC_STATE_SCISSOR); 30855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynViewport) { 30865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->viewportCount && 30875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pViewports) { 30885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 30895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 30905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline viewportCount is %u, but pViewports is NULL. For non-zero viewportCount, you " 30915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pViewports data, or include viewport in pDynamicState and set it with " 30925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetViewport().", 30935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->viewportCount); 30945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 30965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!dynScissor) { 30975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPipeline->graphicsPipelineCI.pViewportState->scissorCount && 30985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !pPipeline->graphicsPipelineCI.pViewportState->pScissors) { 30995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 31005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_VIEWPORT_SCISSOR_MISMATCH, "DS", 31015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Gfx Pipeline scissorCount is %u, but pScissors is NULL. For non-zero scissorCount, you " 31025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must either include pScissors data, or include scissor in pDynamicState and set it with " 31035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdSetScissor().", 31045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeline->graphicsPipelineCI.pViewportState->scissorCount); 31055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 31105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the Pipeline nodes 31135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePipelines(layer_data *my_data) { 31145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->pipelineMap.size() <= 0) 31155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 3116ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (auto &pipe_map_pair : my_data->pipelineMap) { 3117ca546210846c65808717f8875deae39bd227c240Tobin Ehlis delete pipe_map_pair.second; 31185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->pipelineMap.clear(); 31205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Block of code at start here specifically for managing/tracking DSs 31235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return Pool node ptr for specified pool or else NULL 3125bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlisstatic DESCRIPTOR_POOL_NODE *getPoolNode(const layer_data *dev_data, const VkDescriptorPool pool) { 3126bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis auto pool_it = dev_data->descriptorPoolMap.find(pool); 3127bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis if (pool_it == dev_data->descriptorPoolMap.end()) { 31285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 31295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3130bb7ea477706f90eb2a72887f652795bc79f60ddeTobin Ehlis return pool_it->second; 31315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3133e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if update struct is of valid type, otherwise flag error and return code from callback 3134e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validUpdateStruct(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 31355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 3138e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 31395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 31425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 31435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 31445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set count for given update struct in the last parameter 31485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic uint32_t getUpdateCount(layer_data *my_data, const VkDevice device, const GENERIC_HEADER *pUpdateStruct) { 31495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorCount; 31525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 31535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to understand this case better and make sure code is correct 31545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return ((VkCopyDescriptorSet *)pUpdateStruct)->descriptorCount; 31555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return 0; 31575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 31605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the first overall index of the layout that is updated 3161fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateStartIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 31625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 3163fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex; 31645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given layout and update, return the last overall index of the layout that is updated 3166fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic uint32_t getUpdateEndIndex(layer_data *my_data, const VkDevice device, const uint32_t binding_start_index, 31675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t arrayIndex, const GENERIC_HEADER *pUpdateStruct) { 31685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count = getUpdateCount(my_data, device, pUpdateStruct); 3169fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis return binding_start_index + arrayIndex + count - 1; 31705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 31715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Verify that the descriptor type in the update struct matches what's expected by the layout 3172fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlisstatic bool validateUpdateConsistency(layer_data *my_data, const VkDevice device, const VkDescriptorType layout_type, 3173e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const GENERIC_HEADER *pUpdateStruct, uint32_t startIndex, uint32_t endIndex) { 31745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First get actual type of update 3175e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 31761d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkDescriptorType actualType = VK_DESCRIPTOR_TYPE_MAX_ENUM; 31775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (pUpdateStruct->sType) { 31785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_WRITE_DESCRIPTOR_SET: 31795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis actualType = ((VkWriteDescriptorSet *)pUpdateStruct)->descriptorType; 31805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 31815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_STRUCTURE_TYPE_COPY_DESCRIPTOR_SET: 31825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* no need to validate */ 3183e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 31845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 31855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 31865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 31875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_UPDATE_STRUCT, "DS", 31885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Unexpected UPDATE struct of type %s (value %u) in vkUpdateDescriptors() struct tree", 31895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkStructureType(pUpdateStruct->sType), pUpdateStruct->sType); 31905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3191e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 3192fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis if (layout_type != actualType) { 3193fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis skipCall |= log_msg( 3194fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3195fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis DRAWSTATE_DESCRIPTOR_TYPE_MISMATCH, "DS", 3196fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis "Write descriptor update has descriptor type %s that does not match overlapping binding descriptor type of %s!", 3197fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis string_VkDescriptorType(actualType), string_VkDescriptorType(layout_type)); 31985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 31995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 32015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32024a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine//TODO: Consolidate functions 32034a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, IMAGE_CMD_BUF_LAYOUT_NODE &node, const VkImageAspectFlags aspectMask) { 32044a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layer_data *my_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 32054a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 32064a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32074a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32084a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 32094a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 32104a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 32114a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == pCB->imageLayoutMap.end()) { 32124a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32134a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32144a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout != VK_IMAGE_LAYOUT_MAX_ENUM && node.layout != imgsubIt->second.layout) { 32154a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32164a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32174a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 32184a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.layout), string_VkImageLayout(imgsubIt->second.layout)); 32194a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32204a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.initialLayout != VK_IMAGE_LAYOUT_MAX_ENUM && node.initialLayout != imgsubIt->second.initialLayout) { 32214a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32224a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32234a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple initial layout types: %s and %s", 32244a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(node.initialLayout), string_VkImageLayout(imgsubIt->second.initialLayout)); 32254a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32264a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 32274a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 32284a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 32294a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 32304a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentinebool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout, const VkImageAspectFlags aspectMask) { 32314a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (!(imgpair.subresource.aspectMask & aspectMask)) { 32324a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32334a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32344a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine VkImageAspectFlags oldAspectMask = imgpair.subresource.aspectMask; 32354a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine imgpair.subresource.aspectMask = aspectMask; 32364a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 32374a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (imgsubIt == my_data->imageLayoutMap.end()) { 32384a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return false; 32394a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32404a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout != VK_IMAGE_LAYOUT_MAX_ENUM && layout != imgsubIt->second.layout) { 32414a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 32424a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 32434a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine "Cannot query for VkImage 0x%" PRIx64 " layout when combined aspect mask %d has multiple layout types: %s and %s", 32444a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine reinterpret_cast<uint64_t&>(imgpair.image), oldAspectMask, string_VkImageLayout(layout), string_VkImageLayout(imgsubIt->second.layout)); 32454a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine } 32464a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 32474a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine return true; 32484a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine} 32494a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine 32505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the cmd buf level 32515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const GLOBAL_CB_NODE *pCB, VkImage image, VkImageSubresource range, IMAGE_CMD_BUF_LAYOUT_NODE &node) { 32525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 32534a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = IMAGE_CMD_BUF_LAYOUT_NODE(VK_IMAGE_LAYOUT_MAX_ENUM, VK_IMAGE_LAYOUT_MAX_ENUM); 32544a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_COLOR_BIT); 32554a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_DEPTH_BIT); 32564a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_STENCIL_BIT); 32574a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(pCB, imgpair, node, VK_IMAGE_ASPECT_METADATA_BIT); 32584a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (node.layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 32595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {image, false, VkImageSubresource()}; 32604a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = pCB->imageLayoutMap.find(imgpair); 32615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == pCB->imageLayoutMap.end()) 32625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32634a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine node = imgsubIt->second; 32645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 32665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// find layout(s) on the global level 32695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, ImageSubresourcePair imgpair, VkImageLayout &layout) { 32704a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = VK_IMAGE_LAYOUT_MAX_ENUM; 32714a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 32724a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 32734a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 32744a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine FindLayout(my_data, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 32754a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine if (layout == VK_IMAGE_LAYOUT_MAX_ENUM) { 32765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imgpair = {imgpair.image, false, VkImageSubresource()}; 32774a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine auto imgsubIt = my_data->imageLayoutMap.find(imgpair); 32785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgsubIt == my_data->imageLayoutMap.end()) 32795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32804a3279bb23b511257d80ec73ce06d6206d7ab503Michael Lentine layout = imgsubIt->second.layout; 32815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 32825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 32835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayout(const layer_data *my_data, VkImage image, VkImageSubresource range, VkImageLayout &layout) { 32865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 32875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return FindLayout(my_data, imgpair, layout); 32885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 32895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 32905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool FindLayouts(const layer_data *my_data, VkImage image, std::vector<VkImageLayout> &layouts) { 32915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto sub_data = my_data->imageSubresourceMap.find(image); 32925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data == my_data->imageSubresourceMap.end()) 32935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imgIt = my_data->imageMap.find(image); 32955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imgIt == my_data->imageMap.end()) 32965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 32975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool ignoreGlobal = false; 32985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Make this robust for >1 aspect mask. Now it will just say ignore 32995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // potential errors in this case. 33005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (sub_data->second.size() >= (imgIt->second.createInfo.arrayLayers * imgIt->second.createInfo.mipLevels + 1)) { 33015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ignoreGlobal = true; 33025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : sub_data->second) { 33045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (ignoreGlobal && !imgsubpair.hasSubresource) 33055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 33065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto img_data = my_data->imageLayoutMap.find(imgsubpair); 33075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (img_data != my_data->imageLayoutMap.end()) { 33085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layouts.push_back(img_data->second.layout); 33095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return true; 33125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the global level 33155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(layer_data *my_data, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 33165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage &image = imgpair.image; 33175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe set format if new? Not used atm. 33185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageLayoutMap[imgpair].layout = layout; 33195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 33205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto subresource = std::find(my_data->imageSubresourceMap[image].begin(), my_data->imageSubresourceMap[image].end(), imgpair); 33215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subresource == my_data->imageSubresourceMap[image].end()) { 33225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->imageSubresourceMap[image].push_back(imgpair); 33235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set the layout on the cmdbuf level 332708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const IMAGE_CMD_BUF_LAYOUT_NODE &node) { 33285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair] = node; 33295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 333008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine auto subresource = 333108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair); 333208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (subresource == pCB->imageSubresourceMap[imgpair.image].end()) { 333308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].push_back(imgpair); 33345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 333708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(GLOBAL_CB_NODE *pCB, ImageSubresourcePair imgpair, const VkImageLayout &layout) { 33385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Maybe make vector a set? 333908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (std::find(pCB->imageSubresourceMap[imgpair.image].begin(), pCB->imageSubresourceMap[imgpair.image].end(), imgpair) != 334008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine pCB->imageSubresourceMap[imgpair.image].end()) { 33415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap[imgpair].layout = layout; 33425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 33435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO (mlentine): Could be expensive and might need to be removed. 33445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(imgpair.hasSubresource); 33455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 33467068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski if (!FindLayout(pCB, imgpair.image, imgpair.subresource, node)) { 33477068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski node.initialLayout = layout; 33487068a4271b2a542d7e6931104fa62e4a788ed8e5Mark Lobodzinski } 334908682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, imgpair, {node.initialLayout, layout}); 33505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 335308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 335408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, ImageSubresourcePair imgpair, const LAYOUT &layout, VkImageAspectFlags aspectMask) { 335508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine if (imgpair.subresource.aspectMask & aspectMask) { 335608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine imgpair.subresource.aspectMask = aspectMask; 335708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout); 335808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine } 33595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 336108682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> 336208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinevoid SetLayout(OBJECT *pObject, VkImage image, VkImageSubresource range, const LAYOUT &layout) { 33635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, true, range}; 336408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_COLOR_BIT); 336508682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_DEPTH_BIT); 336608682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_STENCIL_BIT); 336708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, imgpair, layout, VK_IMAGE_ASPECT_METADATA_BIT); 33685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 337008682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentinetemplate <class OBJECT, class LAYOUT> void SetLayout(OBJECT *pObject, VkImage image, const LAYOUT &layout) { 33715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair imgpair = {image, false, VkImageSubresource()}; 337208682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pObject, image, imgpair, layout); 33735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid SetLayout(const layer_data *dev_data, GLOBAL_CB_NODE *pCB, VkImageView imageView, const VkImageLayout &layout) { 33765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_view_data = dev_data->imageViewMap.find(imageView); 33775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_view_data != dev_data->imageViewMap.end()); 33785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_view_data->second.image; 33795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_view_data->second.subresourceRange; 33805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 33815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 33825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 33835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 33845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 33855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 33865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, layout); 33875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 33895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 33905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 33915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Validate that given set is valid and that it's not being used by an in-flight CmdBuffer 33925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// func_str is the name of the calling function 3393e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return false if no errors occur 3394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves// Return true if validation error occurs and callback returns true (to skip upcoming API call down the chain) 3395e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleDescriptorSet(const layer_data *my_data, VkDescriptorSet set, std::string func_str) { 3396e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 33975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto set_node = my_data->setMap.find(set); 33985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node == my_data->setMap.end()) { 33995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 34005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 3401414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that has not been allocated.", func_str.c_str(), 34025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(set)); 34035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (set_node->second->in_use.load()) { 34055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 34065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)(set), __LINE__, DRAWSTATE_OBJECT_INUSE, 3407414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "Cannot call %s() on descriptor set 0x%" PRIxLEAST64 " that is in use by a command buffer.", 34085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis func_str.c_str(), (uint64_t)(set)); 34095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 34125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 3413f80bf38f4fb3f177b3e1be11b7b1c5edcdbf7d9bChris Forbes 3414e6651096ed8f07840447783c66827cc16d659a49Tobin Ehlis// Remove set from setMap and delete the set 34159dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlisstatic void freeDescriptorSet(layer_data *dev_data, cvdescriptorset::DescriptorSet *descriptor_set) { 34169dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis dev_data->setMap.erase(descriptor_set->GetSet()); 34179dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis delete descriptor_set; 34189dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis} 34195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all DS Pools including their Sets & related sub-structs 34205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 34215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deletePools(layer_data *my_data) { 34225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->descriptorPoolMap.size() <= 0) 34235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 34245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->descriptorPoolMap.begin(); ii != my_data->descriptorPoolMap.end(); ++ii) { 3425c5f47f0a54e14c47d402aeabc6498d981ecda9ccTobin Ehlis // Remove this pools' sets from setMap and delete them 3426cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : (*ii).second->sets) { 34279dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 34285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3429f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis (*ii).second->sets.clear(); 34305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->descriptorPoolMap.clear(); 34325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void clearDescriptorPool(layer_data *my_data, const VkDevice device, const VkDescriptorPool pool, 34355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDescriptorPoolResetFlags flags) { 34365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPool = getPoolNode(my_data, pool); 34375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPool) { 34385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 34395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 3440414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkResetDescriptorPool() call", (uint64_t)pool); 34415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 34425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: validate flags 3443397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis // For every set off of this pool, clear it, remove from setMap, and free cvdescriptorset::DescriptorSet 3444cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis for (auto ds : pPool->sets) { 34459dd448578d59cb5ce692e833ba230783b30f3550Tobin Ehlis freeDescriptorSet(my_data, ds); 3446cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis } 3447f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis pPool->sets.clear(); 3448e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis // Reset available count for each type and available sets for this pool 34495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPool->availableDescriptorTypeCount.size(); ++i) { 34505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPool->availableDescriptorTypeCount[i] = pPool->maxDescriptorTypeCount[i]; 34515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3452e9fc72c9b6850b2769d7100bb4e9cffde395f05bTobin Ehlis pPool->availableSets = pPool->maxSets; 34535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 34565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// For given CB object, fetch associated CB Node from map 34575121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic GLOBAL_CB_NODE *getCBNode(layer_data const *my_data, const VkCommandBuffer cb) { 34585121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes auto it = my_data->commandBufferMap.find(cb); 34595121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (it == my_data->commandBufferMap.end()) { 346072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 346172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis reinterpret_cast<const uint64_t &>(cb), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 3462414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to use CommandBuffer 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(cb)); 34635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 34645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34655121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes return it->second; 34665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free all CB Nodes 34685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// NOTE : Calls to this function should be wrapped in mutex 34695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteCommandBuffers(layer_data *my_data) { 3470400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (my_data->commandBufferMap.empty()) { 34715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 34725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->commandBufferMap.begin(); ii != my_data->commandBufferMap.end(); ++ii) { 34745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 34755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->commandBufferMap.clear(); 34775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3479e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool report_error_no_cb_begin(const layer_data *dev_data, const VkCommandBuffer cb, const char *caller_name) { 34805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 34815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)cb, __LINE__, DRAWSTATE_NO_BEGIN_COMMAND_BUFFER, "DS", 34825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "You must call vkBeginCommandBuffer() before this call to %s", caller_name); 34835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 34845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3485e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesbool validateCmdsInCmdBuffer(const layer_data *dev_data, const GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd_type) { 34865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeRenderPass) 3487e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 3488e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 3489d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS && 3490d0d8e333806eaac08bdc87ddeff886dc2b0f09e7Tobin Ehlis (cmd_type != CMD_EXECUTECOMMANDS && cmd_type != CMD_NEXTSUBPASS && cmd_type != CMD_ENDRENDERPASS)) { 34915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 34935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Commands cannot be called in a subpass using secondary command buffers."); 34945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeSubpassContents == VK_SUBPASS_CONTENTS_INLINE && cmd_type == CMD_EXECUTECOMMANDS) { 34955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 34965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 34975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands() cannot be called in a subpass using inline commands."); 34985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 34995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 35005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 35035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_GRAPHICS_BIT)) 35045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 35075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 35115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(flags & VK_QUEUE_COMPUTE_BIT)) 35125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without compute capabilities.", name); 35155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool checkGraphicsOrComputeBit(const layer_data *my_data, VkQueueFlags flags, const char *name) { 35195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!((flags & VK_QUEUE_GRAPHICS_BIT) || (flags & VK_QUEUE_COMPUTE_BIT))) 35205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 35215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 35225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Cannot call %s on a command buffer allocated from a pool without graphics capabilities.", name); 35235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return false; 35245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 35255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 35265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Add specified CMD to the CmdBuffer in given pCB, flagging errors if CB is not 35275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// in the recording state or if there's an issue with the Cmd ordering 3528e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool addCmd(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const CMD_TYPE cmd, const char *caller_name) { 3529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 35305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pool_data = my_data->commandPoolMap.find(pCB->createInfo.commandPool); 35315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pool_data != my_data->commandPoolMap.end()) { 3532b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VkQueueFlags flags = my_data->phys_dev_properties.queue_family_properties[pool_data->second.queueFamilyIndex].queueFlags; 35335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (cmd) { 35345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINE: 35355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDPIPELINEDELTA: 35365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDDESCRIPTORSETS: 35375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_FILLBUFFER: 35385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARCOLORIMAGE: 35395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETEVENT: 35405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETEVENT: 35415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WAITEVENTS: 35425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINQUERY: 35435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDQUERY: 35445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESETQUERYPOOL: 35455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYQUERYPOOLRESULTS: 35465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_WRITETIMESTAMP: 35475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsOrComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 35485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETVIEWPORTSTATE: 35505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSCISSORSTATE: 35515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETLINEWIDTHSTATE: 35525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBIASSTATE: 35535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETBLENDSTATE: 35545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETDEPTHBOUNDSSTATE: 35555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREADMASKSTATE: 35565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILWRITEMASKSTATE: 35575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_SETSTENCILREFERENCESTATE: 35585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDINDEXBUFFER: 35595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BINDVERTEXBUFFER: 35605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAW: 35615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXED: 35625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDIRECT: 35635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DRAWINDEXEDINDIRECT: 35645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BLITIMAGE: 35655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARATTACHMENTS: 35665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLEARDEPTHSTENCILIMAGE: 35675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_RESOLVEIMAGE: 35685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_BEGINRENDERPASS: 35695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_NEXTSUBPASS: 35705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_ENDRENDERPASS: 35715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkGraphicsBit(my_data, flags, cmdTypeToString(cmd).c_str()); 35725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCH: 35745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_DISPATCHINDIRECT: 35755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= checkComputeBit(my_data, flags, cmdTypeToString(cmd).c_str()); 35765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFER: 35785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGE: 35795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYBUFFERTOIMAGE: 35805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_COPYIMAGETOBUFFER: 35815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_CLONEIMAGEDATA: 35825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_UPDATEBUFFER: 35835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_PIPELINEBARRIER: 35845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case CMD_EXECUTECOMMANDS: 35857651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis case CMD_END: 35865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 35885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 35895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 35915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state != CB_RECORDING) { 35925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(my_data, pCB->commandBuffer, caller_name); 35937651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else { 35945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCmdsInCmdBuffer(my_data, pCB, cmd); 35955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CMD_NODE cmdNode = {}; 35965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // init cmd node and append to end of cmd LL 35975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.cmdNumber = ++pCB->numCmds; 35985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmdNode.type = cmd; 35995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.push_back(cmdNode); 36005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 36025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Reset the command buffer state 36045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Maintain the createInfo and set state to CB_NEW, but clear all other state 3605400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlisstatic void resetCB(layer_data *dev_data, const VkCommandBuffer cb) { 3606400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis GLOBAL_CB_NODE *pCB = dev_data->commandBufferMap[cb]; 36075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 3608b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.store(0); 36095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->cmds.clear(); 36105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB state (note that createInfo is not cleared) 36115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->commandBuffer = cb; 36125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->beginInfo, 0, sizeof(VkCommandBufferBeginInfo)); 36135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->inheritanceInfo, 0, sizeof(VkCommandBufferInheritanceInfo)); 36145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->numCmds = 0; 36155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(pCB->drawCount, 0, NUM_DRAW_TYPES * sizeof(uint64_t)); 36165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_NEW; 36175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->submitCount = 0; 36185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 36195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.clear(); 36205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.clear(); 362193c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 362272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 362372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Before clearing lastBoundState, remove any CB bindings from all uniqueBoundSets 362472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 362571511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->RemoveBoundCommandBuffer(pCB); 362672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 362772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[i].reset(); 362872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 362993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 36305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(&pCB->activeRenderPassBeginInfo, 0, sizeof(pCB->activeRenderPassBeginInfo)); 3631ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes pCB->activeRenderPass = nullptr; 36325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = VK_SUBPASS_CONTENTS_INLINE; 36335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 363472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedFence = VK_NULL_HANDLE; 363572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastSubmittedQueue = VK_NULL_HANDLE; 36365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedSets.clear(); 36375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->updatedSets.clear(); 36385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->destroyedFramebuffers.clear(); 36395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEvents.clear(); 36405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->semaphores.clear(); 36415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.clear(); 36425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset.clear(); 36435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->queryToStateMap.clear(); 36445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.clear(); 36455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.clear(); 3646abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine pCB->imageSubresourceMap.clear(); 36475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->imageLayoutMap.clear(); 36485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->eventToStageMap.clear(); 36495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawData.clear(); 36505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.clear(); 36515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->primaryCommandBuffer = VK_NULL_HANDLE; 3652bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Make sure any secondaryCommandBuffers are removed from globalInFlight 3653bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto secondary_cb : pCB->secondaryCommandBuffers) { 3654bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(secondary_cb); 3655bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 36565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.clear(); 36577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateImages.clear(); 36587a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->updateBuffers.clear(); 3659400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 3660b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.clear(); 3661d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.clear(); 366293c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 366393c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski // Remove this cmdBuffer's reference from each FrameBuffer's CB ref list 366493c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski for (auto framebuffer : pCB->framebuffers) { 3665f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto fbNode = getFramebuffer(dev_data, framebuffer); 3666f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (fbNode) 3667f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes fbNode->referencingCmdBuffers.erase(pCB->commandBuffer); 366893c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski } 366993c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.clear(); 36707003b38da5cc27a063af3c45080f3a35438283eeTobin Ehlis pCB->activeFramebuffer = VK_NULL_HANDLE; 36715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 36725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 36735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 36745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Set PSO-related status bits for CB, including dynamic state set via PSO 36755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void set_cb_pso_status(GLOBAL_CB_NODE *pCB, const PIPELINE_NODE *pPipe) { 36765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Account for any dynamic state not set via this PSO 3677ca546210846c65808717f8875deae39bd227c240Tobin Ehlis if (!pPipe->graphicsPipelineCI.pDynamicState || 3678ca546210846c65808717f8875deae39bd227c240Tobin Ehlis !pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount) { // All state is static 36795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = CBSTATUS_ALL; 36805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 36815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First consider all state on 36825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Then unset any state that's noted as dynamic in PSO 36835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Finally OR that into CB statemask 36845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CBStatusFlags psoDynStateMask = CBSTATUS_ALL; 3685ca546210846c65808717f8875deae39bd227c240Tobin Ehlis for (uint32_t i = 0; i < pPipe->graphicsPipelineCI.pDynamicState->dynamicStateCount; i++) { 3686ca546210846c65808717f8875deae39bd227c240Tobin Ehlis switch (pPipe->graphicsPipelineCI.pDynamicState->pDynamicStates[i]) { 36875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_VIEWPORT: 36885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_VIEWPORT_SET; 36895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_SCISSOR: 36915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_SCISSOR_SET; 36925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_LINE_WIDTH: 36945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_LINE_WIDTH_SET; 36955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BIAS: 36975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BIAS_SET; 36985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 36995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_BLEND_CONSTANTS: 37003d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis psoDynStateMask &= ~CBSTATUS_BLEND_CONSTANTS_SET; 37015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_DEPTH_BOUNDS: 37035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_DEPTH_BOUNDS_SET; 37045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_COMPARE_MASK: 37065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_READ_MASK_SET; 37075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_WRITE_MASK: 37095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_WRITE_MASK_SET; 37105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_DYNAMIC_STATE_STENCIL_REFERENCE: 37125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis psoDynStateMask &= ~CBSTATUS_STENCIL_REFERENCE_SET; 37135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 37155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Flag error here 37165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 37175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= psoDynStateMask; 37205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print the last bound Gfx Pipeline 3724e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool printPipeline(layer_data *my_data, const VkCommandBuffer cb) { 3725e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 37275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 372872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis PIPELINE_NODE *pPipeTrav = getPipeline(my_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 37295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPipeTrav) { 37305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // nothing to print 37315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 37335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_NONE, "DS", "%s", 3734ca546210846c65808717f8875deae39bd227c240Tobin Ehlis vk_print_vkgraphicspipelinecreateinfo( 3735ca546210846c65808717f8875deae39bd227c240Tobin Ehlis reinterpret_cast<const VkGraphicsPipelineCreateInfo *>(&pPipeTrav->graphicsPipelineCI), "{DS}") 3736ca546210846c65808717f8875deae39bd227c240Tobin Ehlis .c_str()); 37375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void printCB(layer_data *my_data, const VkCommandBuffer cb) { 37435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cb); 37445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB && pCB->cmds.size() > 0) { 37455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 3746414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "Cmds in CB 0x%p", (void *)cb); 37475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<CMD_NODE> cmds = pCB->cmds; 37485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = cmds.begin(); ii != cmds.end(); ++ii) { 37495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass cb as srcObj here 37505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 3751414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", " CMD 0x%" PRIx64 ": %s", (*ii).cmdNumber, cmdTypeToString((*ii).type).c_str()); 37525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 37545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Nothing to print 37555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool synchAndPrintDSConfig(layer_data *my_data, const VkCommandBuffer cb) { 3759e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 37605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(my_data->report_data->active_flags & VK_DEBUG_REPORT_INFORMATION_BIT_EXT)) { 37615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= printPipeline(my_data, cb); 37645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 37655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made inside a render pass. The apiName 37685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called outside a render pass. 3769e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool insideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3770e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool inside = false; 37715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 37725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis inside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 37735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 3774414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: It is invalid to issue this call inside an active render pass (0x%" PRIxLEAST64 ")", apiName, 3775ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass); 37765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return inside; 37785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Flags validation error if the associated call is made outside a render pass. The apiName 37815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// routine should ONLY be called inside a render pass. 3782e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool outsideRenderPass(const layer_data *my_data, GLOBAL_CB_NODE *pCB, const char *apiName) { 3783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool outside = false; 37845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_PRIMARY) && (!pCB->activeRenderPass)) || 37855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((pCB->createInfo.level == VK_COMMAND_BUFFER_LEVEL_SECONDARY) && (!pCB->activeRenderPass) && 37865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT))) { 37875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis outside = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 37885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCB->commandBuffer, __LINE__, DRAWSTATE_NO_ACTIVE_RENDERPASS, "DS", 37895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: This call must be issued inside an active render pass.", apiName); 37905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 37915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return outside; 37925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3794b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void init_core_validation(layer_data *instance_data, const VkAllocationCallbacks *pAllocator) { 3795d11c4ee2bd2a5672093d76630d895e824ee1a571Mark Lobodzinski 3796b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_debug_actions(instance_data->report_data, instance_data->logging_callback, pAllocator, "lunarg_core_validation"); 37975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 37985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 37995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 380089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 380189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateInstance(const VkInstanceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkInstance *pInstance) { 38025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 38035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 38055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 38065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkCreateInstance fpCreateInstance = (PFN_vkCreateInstance)fpGetInstanceProcAddr(NULL, "vkCreateInstance"); 38075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateInstance == NULL) 38085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 38095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 38115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 38125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateInstance(pCreateInfo, pAllocator, pInstance); 38145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) 38155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 38165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3817b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_data *instance_data = get_my_data_ptr(get_dispatch_key(*pInstance), layer_data_map); 381856a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu instance_data->instance = *pInstance; 3819b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->instance_dispatch_table = new VkLayerInstanceDispatchTable; 3820b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis layer_init_instance_dispatch_table(*pInstance, instance_data->instance_dispatch_table, fpGetInstanceProcAddr); 38215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3822b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis instance_data->report_data = 3823b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis debug_report_create_instance(instance_data->instance_dispatch_table, *pInstance, pCreateInfo->enabledExtensionCount, 3824b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis pCreateInfo->ppEnabledExtensionNames); 38255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3826b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis init_core_validation(instance_data, pAllocator); 38275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 38295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 38315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis/* hook DestroyInstance to remove tableInstanceMap entry */ 383489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyInstance(VkInstance instance, const VkAllocationCallbacks *pAllocator) { 38355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 38365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(instance); 38375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking this early, in case this function is called at the 38385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // same time by more than one thread? 38395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(key, layer_data_map); 38405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 38415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyInstance(instance, pAllocator); 38425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 38445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up logging callback, if any 38455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (my_data->logging_callback.size() > 0) { 38465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDebugReportCallbackEXT callback = my_data->logging_callback.back(); 38475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, callback, pAllocator); 38485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->logging_callback.pop_back(); 38495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_instance(my_data->report_data); 38525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete my_data->instance_dispatch_table; 38535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 38545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void createDeviceRegisterExtensions(const VkDeviceCreateInfo *pCreateInfo, VkDevice device) { 38575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i; 38585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TBD: Need any locking, in case this function is called at the same time 38595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // by more than one thread? 38605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 38615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = false; 38625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 38645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr gpa = pDisp->GetDeviceProcAddr; 38655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->CreateSwapchainKHR = (PFN_vkCreateSwapchainKHR)gpa(device, "vkCreateSwapchainKHR"); 38665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroySwapchainKHR = (PFN_vkDestroySwapchainKHR)gpa(device, "vkDestroySwapchainKHR"); 38675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->GetSwapchainImagesKHR = (PFN_vkGetSwapchainImagesKHR)gpa(device, "vkGetSwapchainImagesKHR"); 38685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->AcquireNextImageKHR = (PFN_vkAcquireNextImageKHR)gpa(device, "vkAcquireNextImageKHR"); 38695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->QueuePresentKHR = (PFN_vkQueuePresentKHR)gpa(device, "vkQueuePresentKHR"); 38705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->enabledExtensionCount; i++) { 38725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (strcmp(pCreateInfo->ppEnabledExtensionNames[i], VK_KHR_SWAPCHAIN_EXTENSION_NAME) == 0) 38735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.wsi_enabled = true; 38745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 38765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 387789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *pCreateInfo, 387889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDevice *pDevice) { 387956a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu layer_data *my_instance_data = get_my_data_ptr(get_dispatch_key(gpu), layer_data_map); 38805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDeviceCreateInfo *chain_info = get_chain_info(pCreateInfo, VK_LAYER_LINK_INFO); 38815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(chain_info->u.pLayerInfo); 38835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetInstanceProcAddr fpGetInstanceProcAddr = chain_info->u.pLayerInfo->pfnNextGetInstanceProcAddr; 38845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PFN_vkGetDeviceProcAddr fpGetDeviceProcAddr = chain_info->u.pLayerInfo->pfnNextGetDeviceProcAddr; 388556a5ba3e60a723781945959ffc10e2e215350de5Chia-I Wu PFN_vkCreateDevice fpCreateDevice = (PFN_vkCreateDevice)fpGetInstanceProcAddr(my_instance_data->instance, "vkCreateDevice"); 38865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fpCreateDevice == NULL) { 38875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_INITIALIZATION_FAILED; 38885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Advance the link info for the next element on the chain 38915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis chain_info->u.pLayerInfo = chain_info->u.pLayerInfo->pNext; 38925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 38935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = fpCreateDevice(gpu, pCreateInfo, pAllocator, pDevice); 38945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result != VK_SUCCESS) { 38955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 38965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 38975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 3898b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 38995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_device_data = get_my_data_ptr(get_dispatch_key(*pDevice), layer_data_map); 39005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Setup device dispatch table 39025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->device_dispatch_table = new VkLayerDispatchTable; 39035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_init_device_dispatch_table(*pDevice, my_device_data->device_dispatch_table, fpGetDeviceProcAddr); 39046c94fb996af5f7f79a2bff04cc8cf425086de111Chris Forbes my_device_data->device = *pDevice; 39055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_device_data->report_data = layer_debug_report_create_device(my_instance_data->report_data, *pDevice); 39075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis createDeviceRegisterExtensions(pCreateInfo, *pDevice); 39085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Get physical device limits for this device 3909b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceProperties(gpu, &(my_device_data->phys_dev_properties.properties)); 39105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t count; 39115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr); 3912b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.queue_family_properties.resize(count); 39135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceQueueFamilyProperties( 3914b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis gpu, &count, &my_device_data->phys_dev_properties.queue_family_properties[0]); 39155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: device limits should make sure these are compatible 39165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pEnabledFeatures) { 3917b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_device_data->phys_dev_properties.features = *pCreateInfo->pEnabledFeatures; 39185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 3919b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memset(&my_device_data->phys_dev_properties.features, 0, sizeof(VkPhysicalDeviceFeatures)); 39205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 3921b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis // Store physical device mem limits into device layer_data struct 3922b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis my_instance_data->instance_dispatch_table->GetPhysicalDeviceMemoryProperties(gpu, &my_device_data->phys_dev_mem_props); 3923b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 39245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateLayerOrdering(*pCreateInfo); 39265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 39285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// prototype 39315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *); 393289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDevice(VkDevice device, const VkAllocationCallbacks *pAllocator) { 39335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Shouldn't need any customization here 39345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dispatch_key key = get_dispatch_key(device); 39355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(key, layer_data_map); 39365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Free all the memory 3937b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 39385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePipelines(dev_data); 39395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteRenderPasses(dev_data); 39405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deleteCommandBuffers(dev_data); 3941f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // This will also delete all sets in the pool & remove them from setMap 39425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis deletePools(dev_data); 3943f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis // All sets should be removed 3944f13bee0887f3c3d1d597c82869864be3be836737Tobin Ehlis assert(dev_data->setMap.empty()); 3945a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis for (auto del_layout : dev_data->descriptorSetLayoutMap) { 3946a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis delete del_layout.second; 3947a1e5173c89eb7f03e0434ad45ccd1471e722fa71Tobin Ehlis } 3948fce842878e9ddcc7f37e1c457a4b018d52358087Tobin Ehlis dev_data->descriptorSetLayoutMap.clear(); 39495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap.clear(); 39505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageMap.clear(); 39515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.clear(); 39525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.clear(); 39535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.clear(); 39545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferMap.clear(); 39551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Queues persist until device is destroyed 39561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->queueMap.clear(); 3957b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 395803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 3959e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 3960b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 39615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 39625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "Printing List details prior to vkDestroyDevice()"); 39635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_EXT, 39645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)device, __LINE__, MEMTRACK_NONE, "MEM", "================================================"); 39650a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 39660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 39675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Report any memory leaks 396858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pInfo = NULL; 3969400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!dev_data->memObjMap.empty()) { 39705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = dev_data->memObjMap.begin(); ii != dev_data->memObjMap.end(); ++ii) { 39715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pInfo = &(*ii).second; 39725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo->allocInfo.allocationSize != 0) { 39735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: All child objects created on device must have been destroyed prior to destroying device 39745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 39755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 39765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pInfo->mem, __LINE__, MEMTRACK_MEMORY_LEAK, 3977414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "MEM", "Mem Object 0x%" PRIx64 " has not been freed. You should clean up this memory by calling " 3978414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkFreeMemory(0x%" PRIx64 ") prior to vkDestroyDevice().", 39795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->mem), (uint64_t)(pInfo->mem)); 39805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_debug_report_destroy_device(device); 3984b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 39855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 39865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#if DISPATCH_MAP_DEBUG 3987414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller fprintf(stderr, "Device: 0x%p, key: 0x%p\n", device, key); 39885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 39895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pDisp = dev_data->device_dispatch_table; 3990e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 39915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDisp->DestroyDevice(device, pAllocator); 39925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 39935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#else 39945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyDevice(device, pAllocator); 39955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 39965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete dev_data->device_dispatch_table; 39975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data_map.erase(key); 39985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 39995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic const VkExtensionProperties instance_extensions[] = {{VK_EXT_DEBUG_REPORT_EXTENSION_NAME, VK_EXT_DEBUG_REPORT_SPEC_VERSION}}; 40015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 40025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// This validates that the initial layout specified in the command buffer for 40035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// the IMAGE is the same 40045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// as the global IMAGE layout 4005971020aec6166f20a12a833ebd003e0193f4160aChris Forbesstatic bool ValidateCmdBufImageLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 4006e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 40075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb_image_data : pCB->imageLayoutMap) { 40085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageLayout imageLayout; 40095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(dev_data, cb_image_data.first, imageLayout)) { 40105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 40115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 4012414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot submit cmd buffer using deleted image 0x%" PRIx64 ".", 40135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_image_data.first)); 40145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cb_image_data.second.initialLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 40165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 40175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (imageLayout != cb_image_data.second.initialLayout) { 4018856ecb404bc959ddb877c150c9caa0649055b9cbMark Young if (cb_image_data.first.hasSubresource) { 4019856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4020856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4021971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4022414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") [sub-resource: aspectMask 0x%X array layer %u, mip level %u], " 4023856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "with layout %s when first use is %s.", 4024414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller reinterpret_cast<const uint64_t &>(cb_image_data.first.image), cb_image_data.first.subresource.aspectMask, 4025414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.arrayLayer, 4026414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller cb_image_data.first.subresource.mipLevel, string_VkImageLayout(imageLayout), 4027856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4028856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } else { 4029856ecb404bc959ddb877c150c9caa0649055b9cbMark Young skip_call |= log_msg( 4030856ecb404bc959ddb877c150c9caa0649055b9cbMark Young dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 4031971020aec6166f20a12a833ebd003e0193f4160aChris Forbes reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 4032414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using image (0x%" PRIx64 ") with layout %s when " 4033856ecb404bc959ddb877c150c9caa0649055b9cbMark Young "first use is %s.", 4034856ecb404bc959ddb877c150c9caa0649055b9cbMark Young reinterpret_cast<const uint64_t &>(cb_image_data.first.image), string_VkImageLayout(imageLayout), 4035856ecb404bc959ddb877c150c9caa0649055b9cbMark Young string_VkImageLayout(cb_image_data.second.initialLayout)); 4036856ecb404bc959ddb877c150c9caa0649055b9cbMark Young } 40375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, cb_image_data.first, cb_image_data.second.layout); 40395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 40425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 404339d153555b5101b1b093d80100e329368c66b79dMark Lobodzinski 40445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Track which resources are in-flight by atomically incrementing their "in_use" count 4045e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndIncrementResources(layer_data *my_data, GLOBAL_CB_NODE *pCB) { 4046e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 40475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 40485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 40495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 40505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 40515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 40525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_INVALID_BUFFER, "DS", 4053414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted buffer 0x%" PRIx64 ".", (uint64_t)(buffer)); 40545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_add(1); 40565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 405972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 406072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 406171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis if (!my_data->setMap.count(set->GetSet())) { 406272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skip_call |= 406372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 406472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)(set), __LINE__, DRAWSTATE_INVALID_DESCRIPTOR_SET, "DS", 4065414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted descriptor set 0x%" PRIx64 ".", (uint64_t)(set)); 406672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } else { 406771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_add(1); 406872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 40695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 40725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 40735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode == my_data->semaphoreMap.end()) { 40745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 40755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4077414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted semaphore 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(semaphore)); 40785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_add(1); 40805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 40835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 40845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode == my_data->eventMap.end()) { 40855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 40865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 40875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4088414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot submit cmd buffer using deleted event 0x%" PRIx64 ".", reinterpret_cast<uint64_t &>(event)); 40895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 40905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_add(1); 40915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 40925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4093c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 4094c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine auto eventNode = my_data->eventMap.find(event); 4095c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine eventNode->second.write_in_use++; 4096c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 40975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 40985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 40995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4100b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Note: This function assumes that the global lock is held by the calling 4101b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// thread. 4102b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool cleanInFlightCmdBuffer(layer_data *my_data, VkCommandBuffer cmdBuffer) { 4103b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4104b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 4105b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (pCB) { 4106b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto queryEventsPair : pCB->waitedEventsBeforeQueryReset) { 4107b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine for (auto event : queryEventsPair.second) { 4108b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (my_data->eventMap[event].needsSignaled) { 4109b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4110b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, 0, DRAWSTATE_INVALID_QUERY, "DS", 4111414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4112414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " with index %d which was guarded by unsignaled event 0x%" PRIx64 ".", 4113b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine (uint64_t)(queryEventsPair.first.pool), queryEventsPair.first.index, (uint64_t)(event)); 4114b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4115b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4116b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4117b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4118b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 4119b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4120b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Decrement cmd_buffer in_use and if it goes to 0 remove cmd_buffer from globalInFlightCmdBuffers 4121b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic inline void removeInFlightCmdBuffer(layer_data *dev_data, VkCommandBuffer cmd_buffer) { 4122b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Pull it off of global list initially, but if we find it in any other queue list, add it back in 4123b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmd_buffer); 4124b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_sub(1); 4125b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine if (!pCB->in_use.load()) { 4126b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine dev_data->globalInFlightCmdBuffers.erase(cmd_buffer); 4127b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine } 4128b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4129b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4130e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void decrementResources(layer_data *my_data, VkCommandBuffer cmdBuffer) { 41315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(my_data, cmdBuffer); 41325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto drawDataElement : pCB->drawData) { 41335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto buffer : drawDataElement.buffers) { 41345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 41355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != my_data->bufferMap.end()) { 41365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis buffer_data->second.in_use.fetch_sub(1); 41375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 414072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < VK_PIPELINE_BIND_POINT_RANGE_SIZE; ++i) { 414172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (auto set : pCB->lastBound[i].uniqueBoundSets) { 414271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis set->in_use.fetch_sub(1); 41435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto semaphore : pCB->semaphores) { 41465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto semaphoreNode = my_data->semaphoreMap.find(semaphore); 41475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (semaphoreNode != my_data->semaphoreMap.end()) { 41485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis semaphoreNode->second.in_use.fetch_sub(1); 41495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto event : pCB->events) { 41525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto eventNode = my_data->eventMap.find(event); 41535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (eventNode != my_data->eventMap.end()) { 41545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis eventNode->second.in_use.fetch_sub(1); 41555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4157c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine for (auto event : pCB->writeEventsBeforeWait) { 4158c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine auto eventNode = my_data->eventMap.find(event); 4159c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (eventNode != my_data->eventMap.end()) { 4160c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine eventNode->second.write_in_use--; 4161c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 4162c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 41635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 41645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->queryToStateMap[queryStatePair.first] = queryStatePair.second; 41655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto eventStagePair : pCB->eventToStageMap) { 41675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->eventMap[eventStagePair.first].stageMask = eventStagePair.second; 41685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 41695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4170a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// For fenceCount fences in pFences, mark fence signaled, decrement in_use, and call 4171a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// decrementResources for all priorFences and cmdBuffers associated with fence. 4172b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, uint32_t fenceCount, const VkFence *pFences) { 4173b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 4174ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis std::vector<std::pair<VkFence, FENCE_NODE *>> fence_pairs; 41755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 41765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(pFences[i]); 41775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end() || !fence_data->second.needsSignaled) 4178b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 41795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = false; 4180bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine if (fence_data->second.in_use.load()) { 4181ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis fence_pairs.push_back(std::make_pair(fence_data->first, &fence_data->second)); 4182bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine fence_data->second.in_use.fetch_sub(1); 4183bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 41841d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill decrementResources(my_data, static_cast<uint32_t>(fence_data->second.priorFences.size()), 41851d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill fence_data->second.priorFences.data()); 41865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : fence_data->second.cmdBuffers) { 41875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4188b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4189b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 41905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 419194601b592f9bf0d1e426e066f565207b2bf42699Michael Lentine fence_data->second.cmdBuffers.clear(); 419294601b592f9bf0d1e426e066f565207b2bf42699Michael Lentine fence_data->second.priorFences.clear(); 41935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4194ecc961e2db2546deef62a6d4175753d90218b678Tobin Ehlis for (auto fence_pair : fence_pairs) { 41956bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis for (auto queue : fence_pair.second->queues) { 41966bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto queue_pair = my_data->queueMap.find(queue); 41976bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (queue_pair != my_data->queueMap.end()) { 41986bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto last_fence_data = 41996bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis std::find(queue_pair->second.lastFences.begin(), queue_pair->second.lastFences.end(), fence_pair.first); 42006bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (last_fence_data != queue_pair->second.lastFences.end()) 42016bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis queue_pair->second.lastFences.erase(last_fence_data); 42026bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 4203bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4204be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine for (auto& fence_data : my_data->fenceMap) { 4205be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine auto prior_fence_data = 4206be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine std::find(fence_data.second.priorFences.begin(), fence_data.second.priorFences.end(), fence_pair.first); 4207be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine if (prior_fence_data != fence_data.second.priorFences.end()) 4208be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine fence_data.second.priorFences.erase(prior_fence_data); 4209be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine } 4210bf9672323673c925b8b926e49f80eaf6116a4694Michael Lentine } 4211b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 42125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4213a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Decrement in_use for all outstanding cmd buffers that were submitted on this queue 4214b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic bool decrementResources(layer_data *my_data, VkQueue queue) { 4215b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine bool skip_call = false; 42165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 42175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 42185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : queue_data->second.untrackedCmdBuffers) { 42195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis decrementResources(my_data, cmdBuffer); 4220b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= cleanInFlightCmdBuffer(my_data, cmdBuffer); 4221b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine removeInFlightCmdBuffer(my_data, cmdBuffer); 42225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 4224b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(my_data, static_cast<uint32_t>(queue_data->second.lastFences.size()), 4225b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine queue_data->second.lastFences.data()); 42260a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4227b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine return skip_call; 42280a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine} 42290a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine 4230b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This function merges command buffer tracking between queues when there is a semaphore dependency 4231b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// between them (see below for details as to how tracking works). When this happens, the prior 4232b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// fences from the signaling queue are merged into the wait queue as well as any untracked command 4233b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers. 4234e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void updateTrackedCommandBuffers(layer_data *dev_data, VkQueue queue, VkQueue other_queue, VkFence fence) { 42350a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue == other_queue) { 42360a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 42370a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 42380a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 42390a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto other_queue_data = dev_data->queueMap.find(other_queue); 42400a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (queue_data == dev_data->queueMap.end() || other_queue_data == dev_data->queueMap.end()) { 42410a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 42420a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 4243ca32a764ef85a255c97531164bffb073553de105Jamie Madill for (auto fenceInner : other_queue_data->second.lastFences) { 4244ca32a764ef85a255c97531164bffb073553de105Jamie Madill queue_data->second.lastFences.push_back(fenceInner); 42456bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis auto fence_node = dev_data->fenceMap.find(fenceInner); 42466bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (fence_node != dev_data->fenceMap.end()) { 42476bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_node->second.queues.insert(other_queue_data->first); 42486bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis } 42490a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 42500a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence != VK_NULL_HANDLE) { 42510a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 42520a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine if (fence_data == dev_data->fenceMap.end()) { 42530a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine return; 42540a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 42550a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 42560a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 42570a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 42580a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 42590a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } else { 42600a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : other_queue_data->second.untrackedCmdBuffers) { 42610a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.untrackedCmdBuffers.push_back(cmdbuffer); 42620a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 42630a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine other_queue_data->second.untrackedCmdBuffers.clear(); 42645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4265b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (auto eventStagePair : other_queue_data->second.eventToStageMap) { 4266b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[eventStagePair.first] = eventStagePair.second; 4267b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 4268d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto queryStatePair : other_queue_data->second.queryToStateMap) { 4269d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[queryStatePair.first] = queryStatePair.second; 4270d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 42715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 42725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4273b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// This is the core function for tracking command buffers. There are two primary ways command 4274b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// buffers are tracked. When submitted they are stored in the command buffer list associated 4275b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// with a fence or the untracked command buffer list associated with a queue if no fence is used. 4276b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// Each queue also stores the last fence that was submitted onto the queue. This allows us to 4277b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// create a linked list of fences and their associated command buffers so if one fence is 4278b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on, prior fences on that queue are also considered to have been waited on. When a fence is 4279b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// waited on (either via a queue, device or fence), we free the cmd buffers for that fence and 4280b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine// recursively call with the prior fences. 4281e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void trackCommandBuffers(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4282e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkFence fence) { 42835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queue_data = my_data->queueMap.find(queue); 42845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence != VK_NULL_HANDLE) { 42850a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine vector<VkFence> prior_fences; 42865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = my_data->fenceMap.find(fence); 42875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data == my_data->fenceMap.end()) { 42885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 42895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4290abfafae4ec5d76e520916b03d196e474e972c949Michael Lentine fence_data->second.cmdBuffers.clear(); 42915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 42920a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine prior_fences = queue_data->second.lastFences; 42930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.clear(); 42940a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine queue_data->second.lastFences.push_back(fence); 42950a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine for (auto cmdbuffer : queue_data->second.untrackedCmdBuffers) { 42960a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.cmdBuffers.push_back(cmdbuffer); 42975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 42985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.clear(); 42995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43000a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine fence_data->second.priorFences = prior_fences; 43015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.needsSignaled = true; 43026bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_data->second.queues.insert(queue); 43035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.in_use.fetch_add(1); 43045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 43065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 43075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 43085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(secondaryCmdBuffer); 43095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.cmdBuffers.push_back(submit->pCommandBuffers[i]); 43115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 43145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 43155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 43175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 43185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 43195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(secondaryCmdBuffer); 43205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queue_data->second.untrackedCmdBuffers.push_back(submit->pCommandBuffers[i]); 43225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4326b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine} 4327b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine 4328b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentinestatic void markCommandBuffersInFlight(layer_data *my_data, VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, 4329b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine VkFence fence) { 4330b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine auto queue_data = my_data->queueMap.find(queue); 43315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queue_data != my_data->queueMap.end()) { 43325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 43335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 43345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; ++i) { 4335b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Add cmdBuffers to the global set and increment count 4336b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(my_data, submit->pCommandBuffers[i]); 43375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : my_data->commandBufferMap[submit->pCommandBuffers[i]]->secondaryCommandBuffers) { 43385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(secondaryCmdBuffer); 4339b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine GLOBAL_CB_NODE *pSubCB = getCBNode(my_data, secondaryCmdBuffer); 4340b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pSubCB->in_use.fetch_add(1); 43415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->globalInFlightCmdBuffers.insert(submit->pCommandBuffers[i]); 4343b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine pCB->in_use.fetch_add(1); 43445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4349e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateCommandBufferSimultaneousUse(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 43505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 43515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(pCB->commandBuffer) && 43525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 43535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 43545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 435527c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 4356414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Command Buffer 0x%" PRIx64 " is already in use and is not marked for simultaneous use.", 43575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer)); 43585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 43605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 43615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic bool validateCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 43635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 43640a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis // Validate ONE_TIME_SUBMIT_BIT CB is not being submitted more than once 43650a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis if ((pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT) && (pCB->submitCount > 1)) { 43660a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 43670a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4368414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was begun w/ VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT " 4369414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "set, but has been submitted 0x%" PRIxLEAST64 " times.", 43700a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis (uint64_t)(pCB->commandBuffer), pCB->submitCount); 43710a59acde4b40fde3bbfea5811d2abf2c85ca62f4Tobin Ehlis } 43725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that cmd buffers have been updated 43735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDED != pCB->state) { 43745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_INVALID == pCB->state) { 43755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Inform app of reason CB invalid 43765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool causeReported = false; 43775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedSets.empty()) { 43785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 43795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->destroyedSets) 43805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 43815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 43835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 43845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4385414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 43865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) destroyed: %s", 43875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 43885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 43895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 43905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->updatedSets.empty()) { 43915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream set_string; 43925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto set : pCB->updatedSets) 43935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_string << " " << set; 43945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 43955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 43965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 43975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4398414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 43995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " that is invalid because it had the following bound descriptor set(s) updated: %s", 44005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), set_string.str().c_str()); 44015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->destroyedFramebuffers.empty()) { 44045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream fb_string; 44055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto fb : pCB->destroyedFramebuffers) 44065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_string << " " << fb; 44075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 44085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4411414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid because it had the following " 44125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "referenced framebuffers destroyed: %s", 44135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), fb_string.str().c_str()); 44145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis causeReported = true; 44155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This is defensive programming to make sure an error is 44175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // flagged if we hit this INVALID cmd buffer case and none of the 44185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // above cases are hit. As the number of INVALID cases grows, this 44195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // code should be updated to seemlessly handle all the cases. 44205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!causeReported) { 44215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 44225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 4424414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You are submitting command buffer 0x%" PRIxLEAST64 " that is invalid due to an unknown cause. Validation " 44255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "should " 44265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "be improved to report the exact cause.", 44275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(pCB->commandBuffer)); 44285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Flag error for using CB w/o vkEndCommandBuffer() called 44305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 44315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 44325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_NO_END_COMMAND_BUFFER, "DS", 4433414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "You must call vkEndCommandBuffer() on CB 0x%" PRIxLEAST64 " before this call to vkQueueSubmit()!", 44345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 44355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4440e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 44415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track in-use for resources off of primary and any secondary CBs 4442e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = validateAndIncrementResources(dev_data, pCB); 44435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->secondaryCommandBuffers.empty()) { 44445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto secondaryCmdBuffer : pCB->secondaryCommandBuffers) { 44455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndIncrementResources(dev_data, dev_data->commandBufferMap[secondaryCmdBuffer]); 44465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = getCBNode(dev_data, secondaryCmdBuffer); 44474c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis if ((pSubCB->primaryCommandBuffer != pCB->commandBuffer) && 44484c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis !(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 44495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 44505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_COMMAND_BUFFER_SINGLE_SUBMIT_VIOLATION, "DS", 4451414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "CB 0x%" PRIxLEAST64 " was submitted with secondary buffer 0x%" PRIxLEAST64 44525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " but that buffer has subsequently been bound to " 4453414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "primary cmd buffer 0x%" PRIxLEAST64 44544c665b29a9d2906a378417546c7fc6436731d07fTobin Ehlis " and it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set.", 44555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCB->commandBuffer), reinterpret_cast<uint64_t>(secondaryCmdBuffer), 44565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pSubCB->primaryCommandBuffer)); 44575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pCB); 44615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If USAGE_SIMULTANEOUS_USE_BIT not set then CB cannot already be executing 44625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // on device 44635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferSimultaneousUse(dev_data, pCB); 44645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 44655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 44665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 446789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 446889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueSubmit(VkQueue queue, uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) { 4469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 44705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 44715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4472b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 44735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // First verify that fence is not in use 4474a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 4475a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if ((submitCount != 0) && dev_data->fenceMap[fence].in_use.load()) { 4476a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4477a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4478414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is already in use by another submission.", (uint64_t)(fence)); 4479a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 4480a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!dev_data->fenceMap[fence].needsSignaled) { 4481a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 4482a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4483414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 4484a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 4485a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 44865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 44871344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // TODO : Review these old print functions and clean up as appropriate 44881344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis print_mem_list(dev_data); 44891344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis printCBList(dev_data); 4490b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine // Update cmdBuffer-related data structs and mark fence in-use 4491b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine trackCommandBuffers(dev_data, queue, submitCount, pSubmits, fence); 44925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Now verify each individual submit 44930a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine std::unordered_set<VkQueue> processed_other_queues; 44945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t submit_idx = 0; submit_idx < submitCount; submit_idx++) { 44955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubmitInfo *submit = &pSubmits[submit_idx]; 44965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkSemaphore> semaphoreList; 44975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->waitSemaphoreCount; ++i) { 44980a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pWaitSemaphores[i]; 449941bb23666442c59912c630f85db04ce1a052f3efTobin Ehlis semaphoreList.push_back(semaphore); 45001344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 45011344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 45021344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 45031344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 45041344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 45051344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 45061344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4507414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 45081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 45091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkQueue &other_queue = dev_data->semaphoreMap[semaphore].queue; 45111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (other_queue != VK_NULL_HANDLE && !processed_other_queues.count(other_queue)) { 45121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis updateTrackedCommandBuffers(dev_data, queue, other_queue, fence); 45131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis processed_other_queues.insert(other_queue); 45141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->signalSemaphoreCount; ++i) { 45180a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine const VkSemaphore &semaphore = submit->pSignalSemaphores[i]; 45191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 45201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis semaphoreList.push_back(semaphore); 45211344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 45221344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= 45231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 45241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 4525414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 4526414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that has already been signaled but not waited on by queue 0x%" PRIx64 ".", 45271344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore), 45281344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(dev_data->semaphoreMap[semaphore].queue)); 45291344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 45301344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 45311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].queue = queue; 45321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45330a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine } 45345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < submit->commandBufferCount; i++) { 4536971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCBNode = getCBNode(dev_data, submit->pCommandBuffers[i]); 4537971020aec6166f20a12a833ebd003e0193f4160aChris Forbes skipCall |= ValidateCmdBufImageLayouts(dev_data, pCBNode); 45381344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (pCBNode) { 45391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->semaphores = semaphoreList; 45401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->submitCount++; // increment submit count 45411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedFence = fence; 45421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis pCBNode->lastSubmittedQueue = queue; 45431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= validatePrimaryCommandBufferState(dev_data, pCBNode); 45441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis // Call submit-time functions to validate/update state 45451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->validate_functions) { 45461344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(); 45471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45481344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (auto &function : pCBNode->eventUpdates) { 45491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= function(queue); 45501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 4551d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (auto &function : pCBNode->queryUpdates) { 4552d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skipCall |= function(queue); 4553d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 45541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 45555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 45565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4557b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine markCommandBuffersInFlight(dev_data, queue, submitCount, pSubmits, fence); 4558b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4559e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 45605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueueSubmit(queue, submitCount, pSubmits, fence); 45615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 456589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo, 456689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) { 45675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 45685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = my_data->device_dispatch_table->AllocateMemory(device, pAllocateInfo, pAllocator, pMemory); 45695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Track allocations and overall size here 4570b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 45715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis add_mem_obj_info(my_data, device, *pMemory, pAllocateInfo); 45720a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 45735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 45745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 457689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 457789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeMemory(VkDevice device, VkDeviceMemory mem, const VkAllocationCallbacks *pAllocator) { 45785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 45795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // From spec : A memory object is freed by calling vkFreeMemory() when it is no longer needed. 45815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Before freeing a memory object, an application must ensure the memory object is no longer 45825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // in use by the device—for example by command buffers queued for execution. The memory need 45835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // not yet be unbound from all images and buffers, but any further use of those images or 45845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // buffers (on host or device) for anything other than destroying those objects will result in 45855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // undefined behavior. 45865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4587b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4588e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves freeMemObjInfo(my_data, device, mem, false); 45890a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(my_data); 45900a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(my_data); 4591b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 45925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->FreeMemory(device, mem, pAllocator); 45935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 45945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4595e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemRange(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 4596e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 45975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 45985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == 0) { 45997c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 46005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 46015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VkMapMemory: Attempting to map memory range of size zero"); 46025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 46055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 46065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // It is an application error to call VkMapMemory on an object that is already mapped 46075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.size != 0) { 46085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 46095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4610414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMapMemory: Attempting to map memory on an already-mapped object 0x%" PRIxLEAST64, (uint64_t)mem); 46115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that offset + size is within object's allocationSize 46145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 46155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (offset >= mem_element->second.allocInfo.allocationSize) { 46165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 46175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 46187c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " with size of VK_WHOLE_SIZE oversteps total array size 0x%" PRIx64, offset, 46195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.allocInfo.allocationSize, mem_element->second.allocInfo.allocationSize); 46205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((offset + size) > mem_element->second.allocInfo.allocationSize) { 46235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 46245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, 46257c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis "MEM", "Mapping Memory from 0x%" PRIx64 " to 0x%" PRIx64 " oversteps total array size 0x%" PRIx64, offset, 46265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size + offset, mem_element->second.allocInfo.allocationSize); 46275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 46315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4633e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic void storeMemRanges(layer_data *my_data, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size) { 46345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 46355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 46365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MemRange new_range; 46375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.offset = offset; 46385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis new_range.size = size; 46395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange = new_range; 46405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4643e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool deleteMemRanges(layer_data *my_data, VkDeviceMemory mem) { 4644e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 46455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(mem); 46465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 46475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_element->second.memRange.size) { 46485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Valid Usage: memory must currently be mapped 46495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 46505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 4651414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unmapping Memory without memory being mapped: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 46525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.memRange.size = 0; 46545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 46555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis free(mem_element->second.pData); 46565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 46575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 46605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 46615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 46625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic char NoncoherentMemoryFillValue = 0xb; 46635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4664b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlisstatic void initializeAndTrackMemory(layer_data *dev_data, VkDeviceMemory mem, VkDeviceSize size, void **ppData) { 4665b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis auto mem_element = dev_data->memObjMap.find(mem); 4666b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (mem_element != dev_data->memObjMap.end()) { 46675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pDriverData = *ppData; 46685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t index = mem_element->second.allocInfo.memoryTypeIndex; 4669b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (dev_data->phys_dev_mem_props.memoryTypes[index].propertyFlags & VK_MEMORY_PROPERTY_HOST_COHERENT_BIT) { 46705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = 0; 46715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 46725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (size == VK_WHOLE_SIZE) { 46735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size = mem_element->second.allocInfo.allocationSize; 46745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis size_t convSize = (size_t)(size); 46765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mem_element->second.pData = malloc(2 * convSize); 46775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memset(mem_element->second.pData, NoncoherentMemoryFillValue, 2 * convSize); 46785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *ppData = static_cast<char *>(mem_element->second.pData) + (convSize / 2); 46795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4682a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// Verify that state for fence being waited on is appropriate. That is, 4683a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// a fence being waited on should not already be signalled and 4684a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis// it should have been submitted on a queue or during acquire next image 4685a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlisstatic inline bool verifyWaitFenceState(VkDevice device, VkFence fence, const char *apiCall) { 46865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4687e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 46885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto pFenceInfo = my_data->fenceMap.find(fence); 46895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pFenceInfo != my_data->fenceMap.end()) { 4690e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!pFenceInfo->second.firstTimeFlag) { 4691a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (!pFenceInfo->second.needsSignaled) { 46925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 46935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 46945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)fence, __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4695414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s specified fence 0x%" PRIxLEAST64 " already in SIGNALED state.", apiCall, (uint64_t)fence); 46965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 46976bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis if (pFenceInfo->second.queues.empty() && !pFenceInfo->second.swapchain) { // Checking status of unsubmitted fence 46985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 46995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 4700414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s called for fence 0x%" PRIxLEAST64 " which has not been submitted on a Queue or during " 47015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "acquire next image.", 47025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis apiCall, reinterpret_cast<uint64_t &>(fence)); 47035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 4705e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves pFenceInfo->second.firstTimeFlag = false; 47065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 47095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 4710a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 471189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 471289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuWaitForFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences, VkBool32 waitAll, uint64_t timeout) { 47135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4714e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify fence status of submitted fences 4716b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 47175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; i++) { 4718a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= verifyWaitFenceState(device, pFences[i], "vkWaitForFences"); 47195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4720b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 47215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 47225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 4723a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 47245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->WaitForFences(device, fenceCount, pFences, waitAll, timeout); 4725414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller 47265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4727b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 47285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // When we know that all fences are complete we can clean/remove their CBs 47295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (waitAll || fenceCount == 1) { 4730b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, fenceCount, pFences); 47315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // NOTE : Alternate case not handled here is when some fences have completed. In 47335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // this case for app to guarantee which fences completed it will have to call 47345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // vkGetFenceStatus() at which point we'll clean/remove their CBs if complete. 4735b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 47365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4737e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 47385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 47395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 474289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetFenceStatus(VkDevice device, VkFence fence) { 47435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 47445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 47455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 4746b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 4747a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall = verifyWaitFenceState(device, fence, "vkGetFenceStatus"); 4748b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4749a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 47505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 47515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 4752a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis 47535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->GetFenceStatus(device, fence); 4754e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4755b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 47565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 4757b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skipCall |= decrementResources(dev_data, 1, &fence); 47585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4759b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4760e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 47615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 47625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 476589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL GetDeviceQueue(VkDevice device, uint32_t queueFamilyIndex, uint32_t queueIndex, 4766b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski VkQueue *pQueue) { 47675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 47685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->GetDeviceQueue(device, queueFamilyIndex, queueIndex, pQueue); 4769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 4770b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski 4771b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski // Add queue to tracking set only if it is new 4772b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski auto result = dev_data->queues.emplace(*pQueue); 4773b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski if (result.second == true) { 4774b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski QUEUE_NODE *pQNode = &dev_data->queueMap[*pQueue]; 4775b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski pQNode->device = device; 4776b376edacad6f7ab3fcc0a914e9b1673a9fcd5143Mark Lobodzinski } 47775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 477989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueueWaitIdle(VkQueue queue) { 47805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 4781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 4782b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 4783e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 47845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 47855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->QueueWaitIdle(queue); 47865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 47875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 47885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 478989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL DeviceWaitIdle(VkDevice device) { 4790e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 47915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 4792b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 47935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queue : dev_data->queues) { 4794b3d308d63ba34f40839f009ac83b33962d7f26b2Michael Lentine skip_call |= decrementResources(dev_data, queue); 47955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 47965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.clear(); 4797b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 4798e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 47995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 48005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->DeviceWaitIdle(device); 48015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 48025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 480489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyFence(VkDevice device, VkFence fence, const VkAllocationCallbacks *pAllocator) { 48055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 4807b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48081344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis auto fence_pair = dev_data->fenceMap.find(fence); 48091344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair != dev_data->fenceMap.end()) { 48101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (fence_pair->second.in_use.load()) { 48111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 48121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 4813414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is in use by a command buffer.", (uint64_t)(fence)); 48141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 48151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->fenceMap.erase(fence_pair); 48165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4817b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 48195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 48205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFence(device, fence, pAllocator); 48215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 482389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 482489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySemaphore(VkDevice device, VkSemaphore semaphore, const VkAllocationCallbacks *pAllocator) { 48255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySemaphore(device, semaphore, pAllocator); 4827b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 48285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->semaphoreMap.find(semaphore); 48295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->semaphoreMap.end()) { 48305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item->second.in_use.load()) { 48315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 48325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(semaphore), __LINE__, DRAWSTATE_INVALID_SEMAPHORE, "DS", 4833414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete semaphore 0x%" PRIx64 " which is in use.", reinterpret_cast<uint64_t &>(semaphore)); 48345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->semaphoreMap.erase(semaphore); 48365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 48385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 484089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyEvent(VkDevice device, VkEvent event, const VkAllocationCallbacks *pAllocator) { 48415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 4843b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto event_data = dev_data->eventMap.find(event); 48455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data != dev_data->eventMap.end()) { 48465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (event_data->second.in_use.load()) { 48475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg( 48485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 48495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 4850414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot delete event 0x%" PRIx64 " which is in use by a command buffer.", reinterpret_cast<uint64_t &>(event)); 48515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap.erase(event_data); 48535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 48555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 48565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyEvent(device, event, pAllocator); 48575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 48585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 486089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 486189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyQueryPool(VkDevice device, VkQueryPool queryPool, const VkAllocationCallbacks *pAllocator) { 48625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 48635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyQueryPool(device, queryPool, pAllocator); 48645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 48655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 48665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 486789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL GetQueryPoolResults(VkDevice device, VkQueryPool queryPool, uint32_t firstQuery, 486889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t queryCount, size_t dataSize, void *pData, VkDeviceSize stride, 486989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkQueryResultFlags flags) { 48705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 48715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_map<QueryObject, vector<VkCommandBuffer>> queriesInFlight; 4872b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 48735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cmdBuffer : dev_data->globalInFlightCmdBuffers) { 4874971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 48755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryStatePair : pCB->queryToStateMap) { 48765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queriesInFlight[queryStatePair.first].push_back(cmdBuffer); 48775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 48785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4879e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 48805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; ++i) { 48815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 48825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryElement = queriesInFlight.find(query); 48835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryToStateElement = dev_data->queryToStateMap.find(query); 48845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryToStateElement != dev_data->queryToStateMap.end()) { 4885ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Available and in flight 4886ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4887ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski queryToStateElement->second) { 4888ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4889971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 4890ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski auto queryEventElement = pCB->waitedEventsBeforeQueryReset.find(query); 4891ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (queryEventElement == pCB->waitedEventsBeforeQueryReset.end()) { 4892ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4893ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4894414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is in flight.", 4895ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 4896ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else { 4897ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto event : queryEventElement->second) { 4898ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski dev_data->eventMap[event].needsSignaled = true; 4899ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4900ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4901ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4902ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable and in flight 4903ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryElement != queriesInFlight.end() && queryToStateElement != dev_data->queryToStateMap.end() && 4904ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski !queryToStateElement->second) { 4905ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // TODO : Can there be the same query in use by multiple command buffers in flight? 4906ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski bool make_available = false; 4907ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski for (auto cmdBuffer : queryElement->second) { 4908971020aec6166f20a12a833ebd003e0193f4160aChris Forbes auto pCB = getCBNode(dev_data, cmdBuffer); 4909ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski make_available |= pCB->queryToStateMap[query]; 4910ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } 4911ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski if (!(((flags & VK_QUERY_RESULT_PARTIAL_BIT) || (flags & VK_QUERY_RESULT_WAIT_BIT)) && make_available)) { 49125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 49135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4914414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 49155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 49165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4917ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unavailable 4918ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement != dev_data->queryToStateMap.end() && !queryToStateElement->second) { 49195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 49205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4921414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 " with index %d which is unavailable.", 49225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), firstQuery + i); 4923ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski // Unitialized 4924ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski } else if (queryToStateElement == dev_data->queryToStateMap.end()) { 4925ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 4926ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski VK_DEBUG_REPORT_OBJECT_TYPE_QUERY_POOL_EXT, 0, __LINE__, DRAWSTATE_INVALID_QUERY, "DS", 4927414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot get query results on queryPool 0x%" PRIx64 4928ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski " with index %d as data has not been collected for this index.", 4929ec27ab7d1aa03fa187755b6720e1be995a994f5cMark Lobodzinski (uint64_t)(queryPool), firstQuery + i); 49305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 4933b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 49345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skip_call) 49355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 49365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->GetQueryPoolResults(device, queryPool, firstQuery, queryCount, dataSize, pData, stride, 49375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis flags); 49385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 4940e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateIdleBuffer(const layer_data *my_data, VkBuffer buffer) { 4941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 49425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = my_data->bufferMap.find(buffer); 49435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data == my_data->bufferMap.end()) { 49445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 49455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_DOUBLE_DESTROY, "DS", 4946414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that has not been allocated.", (uint64_t)(buffer)); 49475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 49485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data->second.in_use.load()) { 49495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 49505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(buffer), __LINE__, DRAWSTATE_OBJECT_INUSE, "DS", 4951414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot free buffer 0x%" PRIxLEAST64 " that is in use by a command buffer.", (uint64_t)(buffer)); 49525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 49545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 49555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 49565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 495747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool print_memory_range_error(layer_data *dev_data, const uint64_t object_handle, const uint64_t other_handle, 495847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 495947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (object_type == VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT) { 496047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 4961414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Buffer 0x%" PRIx64 " is aliased with image 0x%" PRIx64, object_handle, 496247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 496347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } else { 496447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, object_type, object_handle, 0, 4965414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_ALIASING, "MEM", "Image 0x%" PRIx64 " is aliased with buffer 0x%" PRIx64, object_handle, 496647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski other_handle); 496747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 496847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 496947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 497047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic bool validate_memory_range(layer_data *dev_data, const vector<MEMORY_RANGE> &ranges, const MEMORY_RANGE &new_range, 497147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkDebugReportObjectTypeEXT object_type) { 497247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski bool skip_call = false; 497347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 497447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (auto range : ranges) { 497547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) < 497647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 497747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 497847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((range.start & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1)) > 497947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski (new_range.end & ~(dev_data->phys_dev_properties.properties.limits.bufferImageGranularity - 1))) 498047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski continue; 498147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skip_call |= print_memory_range_error(dev_data, new_range.handle, range.handle, object_type); 498247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 498347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return skip_call; 498447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 498547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 498647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic MEMORY_RANGE insert_memory_ranges(uint64_t handle, VkDeviceMemory mem, VkDeviceSize memoryOffset, 498747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski VkMemoryRequirements memRequirements, vector<MEMORY_RANGE> &ranges) { 498847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski MEMORY_RANGE range; 498947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.handle = handle; 499047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.memory = mem; 499147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.start = memoryOffset; 499247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski range.end = memoryOffset + memRequirements.size - 1; 499347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.push_back(range); 499447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski return range; 499547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 499647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 499747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinskistatic void remove_memory_ranges(uint64_t handle, VkDeviceMemory mem, vector<MEMORY_RANGE> &ranges) { 499847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski for (uint32_t item = 0; item < ranges.size(); item++) { 499947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if ((ranges[item].handle == handle) && (ranges[item].memory == mem)) { 500047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski ranges.erase(ranges.begin() + item); 500147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski break; 500247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 500347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 500447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski} 500547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 500689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyBuffer(VkDevice device, VkBuffer buffer, 500789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 50085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5009e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 5010b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5011e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!validateIdleBuffer(dev_data, buffer) && !skipCall) { 5012b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 50135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBuffer(device, buffer, pAllocator); 5014b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 50155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 501647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory binding and range information for buffer 501747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &bufferEntry = dev_data->bufferMap.find(buffer); 501847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (bufferEntry != dev_data->bufferMap.end()) { 501947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(bufferEntry->second.mem); 502047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 502147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski remove_memory_ranges(reinterpret_cast<uint64_t &>(buffer), bufferEntry->second.mem, memEntry->second.bufferRanges); 502247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 502347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(buffer), VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 502447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->bufferMap.erase(bufferEntry); 502547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 50265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 502889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 502989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyBufferView(VkDevice device, VkBufferView bufferView, const VkAllocationCallbacks *pAllocator) { 50305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyBufferView(device, bufferView, pAllocator); 5032b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 50335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto item = dev_data->bufferViewMap.find(bufferView); 50345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (item != dev_data->bufferViewMap.end()) { 50355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap.erase(item); 50365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 503989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyImage(VkDevice device, VkImage image, const VkAllocationCallbacks *pAllocator) { 50405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5041e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 504247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (!skipCall) { 50435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyImage(device, image, pAllocator); 504447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 50455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 504747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &imageEntry = dev_data->imageMap.find(image); 504847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (imageEntry != dev_data->imageMap.end()) { 504947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Clean up memory mapping, bindings and range references for image 505047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski auto memEntry = dev_data->memObjMap.find(imageEntry->second.mem); 505147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 505247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski remove_memory_ranges(reinterpret_cast<uint64_t &>(image), imageEntry->second.mem, memEntry->second.imageRanges); 505347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski clear_object_binding(dev_data, reinterpret_cast<uint64_t &>(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 505447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski memEntry->second.image = VK_NULL_HANDLE; 505547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 505658070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis // Remove image from imageMap 505747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski dev_data->imageMap.erase(imageEntry); 50585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const auto& subEntry = dev_data->imageSubresourceMap.find(image); 50605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subEntry != dev_data->imageSubresourceMap.end()) { 50615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (const auto& pair : subEntry->second) { 50625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(pair); 50635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(subEntry); 50655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 50665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 50675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 506889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 506989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBindBufferMemory(VkDevice device, VkBuffer buffer, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 507058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 50715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5072b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 50735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 50745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint64_t buffer_handle = (uint64_t)(buffer); 5075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = 507694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis set_mem_binding(dev_data, mem, buffer_handle, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, "vkBindBufferMemory"); 507794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto buffer_node = dev_data->bufferMap.find(buffer); 507894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (buffer_node != dev_data->bufferMap.end()) { 507994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis buffer_node->second.mem = mem; 50805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 508194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, &memRequirements); 508247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 508347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 508447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(mem); 508547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 508647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 508747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski insert_memory_ranges(buffer_handle, mem, memoryOffset, memRequirements, memEntry->second.bufferRanges); 508847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skipCall |= 508947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski validate_memory_range(dev_data, memEntry->second.imageRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT); 509047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 509147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 50922c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate memory requirements alignment 50932c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (vk_safe_modulo(memoryOffset, memRequirements.alignment) != 0) { 50942c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 50952c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, 50962c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves __LINE__, DRAWSTATE_INVALID_BUFFER_MEMORY_OFFSET, "DS", 5097414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be an integer multiple of the " 5098414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "VkMemoryRequirements::alignment value 0x%" PRIxLEAST64 50992c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves ", returned from a call to vkGetBufferMemoryRequirements with buffer", 51002c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves memoryOffset, memRequirements.alignment); 51012c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51022c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves // Validate device limits alignments 510394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis VkBufferUsageFlags usage = dev_data->bufferMap[buffer].createInfo.usage; 51042c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & (VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT)) { 5105b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment) != 0) { 51062c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 51072c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 51082c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_TEXEL_BUFFER_OFFSET, "DS", 5109414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5110414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minTexelBufferOffsetAlignment 0x%" PRIxLEAST64, 5111b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minTexelBufferOffsetAlignment); 51122c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51132c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51142c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_UNIFORM_BUFFER_BIT) { 5115b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 5116b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 51172c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 51182c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 51192c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 5120414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5121414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 5122b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 51232c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51242c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51252c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves if (usage & VK_BUFFER_USAGE_STORAGE_BUFFER_BIT) { 5126b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (vk_safe_modulo(memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 5127b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis 0) { 51282c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves skipCall |= 51292c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 51302c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves 0, __LINE__, DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 5131414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindBufferMemory(): memoryOffset is 0x%" PRIxLEAST64 " but must be a multiple of " 5132414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 5133b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis memoryOffset, dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 51342c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51352c905c8b5aca814df6c680348145ca48885f9f69Dustin Graves } 51365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51370a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 5138b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5139e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 514058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis result = dev_data->device_dispatch_table->BindBufferMemory(device, buffer, mem, memoryOffset); 51415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 51425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 51435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 514589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 514689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetBufferMemoryRequirements(VkDevice device, VkBuffer buffer, VkMemoryRequirements *pMemoryRequirements) { 51475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 51495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindBufferMemory 51505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetBufferMemoryRequirements(device, buffer, pMemoryRequirements); 51515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 515389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 515489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetImageMemoryRequirements(VkDevice device, VkImage image, VkMemoryRequirements *pMemoryRequirements) { 51555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 51565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : What to track here? 51575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Could potentially save returned mem requirements and validate values passed into BindImageMemory 51585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->GetImageMemoryRequirements(device, image, pMemoryRequirements); 51595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5160593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 516189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 516289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyImageView(VkDevice device, VkImageView imageView, const VkAllocationCallbacks *pAllocator) { 51635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 51645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyImageView(device, imageView, pAllocator); 51655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 51665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 516889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 516989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyShaderModule(VkDevice device, VkShaderModule shaderModule, const VkAllocationCallbacks *pAllocator) { 5170918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5171918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5172b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 5173918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap.erase(shaderModule); 5174b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5175918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 5176918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->device_dispatch_table->DestroyShaderModule(device, shaderModule, pAllocator); 51775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 517989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 518089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipeline(VkDevice device, VkPipeline pipeline, const VkAllocationCallbacks *pAllocator) { 51815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroyPipeline(device, pipeline, pAllocator); 51825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 51835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 518589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 518689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineLayout(VkDevice device, VkPipelineLayout pipelineLayout, const VkAllocationCallbacks *pAllocator) { 51875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 51885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyPipelineLayout(device, pipelineLayout, pAllocator); 51895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 51905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 519289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 519389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySampler(VkDevice device, VkSampler sampler, const VkAllocationCallbacks *pAllocator) { 51945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map)->device_dispatch_table->DestroySampler(device, sampler, pAllocator); 51955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 51965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 51975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 519889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 519989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorSetLayout(VkDevice device, VkDescriptorSetLayout descriptorSetLayout, const VkAllocationCallbacks *pAllocator) { 52005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorSetLayout(device, descriptorSetLayout, pAllocator); 52025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 520589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 520689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, const VkAllocationCallbacks *pAllocator) { 52075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis get_my_data_ptr(get_dispatch_key(device), layer_data_map) 52085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ->device_dispatch_table->DestroyDescriptorPool(device, descriptorPool, pAllocator); 52095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Clean up any internal data structures using this obj. 52105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5211bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Verify cmdBuffer in given cb_node is not in global in-flight set, and return skip_call result 5212bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If this is a secondary command buffer, then make sure its primary is also in-flight 5213bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// If primary is not in-flight, then remove secondary from global in-flight set 5214bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// This function is only valid at a point when cmdBuffer is being reset or freed 5215bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBufferInFlight(layer_data *dev_data, const GLOBAL_CB_NODE *cb_node, const char *action) { 5216bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5217bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cb_node->commandBuffer)) { 5218bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis // Primary CB or secondary where primary is also in-flight is an error 5219bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if ((cb_node->createInfo.level != VK_COMMAND_BUFFER_LEVEL_SECONDARY) || 5220bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (dev_data->globalInFlightCmdBuffers.count(cb_node->primaryCommandBuffer))) { 5221bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg( 5222bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 5223bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 5224414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to %s command buffer (0x%" PRIxLEAST64 ") which is in use.", action, 5225bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis reinterpret_cast<const uint64_t &>(cb_node->commandBuffer)); 5226bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } else { // Secondary CB w/o primary in-flight, remove from in-flight 5227bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->globalInFlightCmdBuffers.erase(cb_node->commandBuffer); 5228bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5229bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5230bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5231bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 5232bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis// Iterate over all cmdBuffers in given commandPool and verify that each is not in use 5233bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlisstatic bool checkAndClearCommandBuffersInFlight(layer_data *dev_data, const VkCommandPool commandPool, const char *action) { 5234bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 5235bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto pool_data = dev_data->commandPoolMap.find(commandPool); 5236bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (pool_data != dev_data->commandPoolMap.end()) { 5237bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis for (auto cmd_buffer : pool_data->second.commandBuffers) { 5238bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(cmd_buffer)) { 5239bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, getCBNode(dev_data, cmd_buffer), action); 5240bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5241bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5242bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis } 5243bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis return skip_call; 5244bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis} 52455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 524689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 524789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeCommandBuffers(VkDevice device, VkCommandPool commandPool, uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) { 52485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 5251b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 52525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBufferCount; i++) { 5253bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis auto cb_pair = dev_data->commandBufferMap.find(pCommandBuffers[i]); 5254bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, cb_pair->second, "free"); 52555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Delete CB information structure, and remove from commandBufferMap 5256bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (cb_pair != dev_data->commandBufferMap.end()) { 52575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // reset prior to delete for data clean-up 5258bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis resetCB(dev_data, (*cb_pair).second->commandBuffer); 5259bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis delete (*cb_pair).second; 5260bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis dev_data->commandBufferMap.erase(cb_pair); 52615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Remove commandBuffer reference from commandPoolMap 52645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[commandPool].commandBuffers.remove(pCommandBuffers[i]); 52655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52660a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 5267b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 52685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 52705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->FreeCommandBuffers(device, commandPool, commandBufferCount, pCommandBuffers); 52715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 527389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateCommandPool(VkDevice device, const VkCommandPoolCreateInfo *pCreateInfo, 527489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 527589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkCommandPool *pCommandPool) { 52765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateCommandPool(device, pCreateInfo, pAllocator, pCommandPool); 52795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5281b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 52825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].createFlags = pCreateInfo->flags; 52835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap[*pCommandPool].queueFamilyIndex = pCreateInfo->queueFamilyIndex; 52845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 528889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateQueryPool(VkDevice device, const VkQueryPoolCreateInfo *pCreateInfo, 528989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkQueryPool *pQueryPool) { 52905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 52915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 52925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateQueryPool(device, pCreateInfo, pAllocator, pQueryPool); 52935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 5294b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 52955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->queryPoolMap[*pQueryPool].createInfo = *pCreateInfo; 52965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 52975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 52985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 52995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Destroy commandPool along with all of the commandBuffers allocated from that pool 530189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 530289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyCommandPool(VkDevice device, VkCommandPool commandPool, const VkAllocationCallbacks *pAllocator) { 53035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5305b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Verify that command buffers in pool are complete (not in-flight) 5307bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis VkBool32 result = checkAndClearCommandBuffersInFlight(dev_data, commandPool, "destroy command pool with"); 53085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Must remove cmdpool from cmdpoolmap, after removing all cmdbuffers in its list from the commandPoolMap 530941051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes auto pool_it = dev_data->commandPoolMap.find(commandPool); 531041051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes if (pool_it != dev_data->commandPoolMap.end()) { 531141051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes for (auto cb : pool_it->second.commandBuffers) { 531241051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes clear_cmd_buf_and_mem_references(dev_data, cb); 531341051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes auto del_cb = dev_data->commandBufferMap.find(cb); 531441051f44c4d5e571f7b8a3efd5eb060b767b351aChris Forbes delete del_cb->second; // delete CB info structure 531572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->commandBufferMap.erase(del_cb); // Remove this command buffer 53165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandPoolMap.erase(commandPool); 53195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5320b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5322f90830842fdd43e8f1834f2eb76bda28eef435b8Tony Barbour if (result) 53235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 53245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 53265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyCommandPool(device, commandPool, pAllocator); 53275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 532989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 533089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandPool(VkDevice device, VkCommandPool commandPool, VkCommandPoolResetFlags flags) { 53315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 53335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 5334400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 5335bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (checkAndClearCommandBuffersInFlight(dev_data, commandPool, "reset command pool with")) 53365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 53375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 53395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetCommandPool(device, commandPool, flags); 53405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 53415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset all of the CBs allocated from this pool 53425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5343b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 53445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto it = dev_data->commandPoolMap[commandPool].commandBuffers.begin(); 53455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis while (it != dev_data->commandPoolMap[commandPool].commandBuffers.end()) { 53465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, (*it)); 53475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ++it; 53485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 535389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL ResetFences(VkDevice device, uint32_t fenceCount, const VkFence *pFences) { 53545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 53555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 53565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 5357b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < fenceCount; ++i) { 53595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_item = dev_data->fenceMap.find(pFences[i]); 53605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_item != dev_data->fenceMap.end()) { 5361a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_item->second.needsSignaled = true; 53626bdabc8615f7c55234e644fdfa143e223cfc7719Tobin Ehlis fence_item->second.queues.clear(); 5363be19196be2afb022117c65fa71cebfd35fe1a633Michael Lentine fence_item->second.priorFences.clear(); 5364a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence_item->second.in_use.load()) { 5365a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 5366a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 5367a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<const uint64_t &>(pFences[i]), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 5368414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is in use by a command buffer.", reinterpret_cast<const uint64_t &>(pFences[i])); 53695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5372b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 53745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->ResetFences(device, fenceCount, pFences); 53755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 53765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 537889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 537989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyFramebuffer(VkDevice device, VkFramebuffer framebuffer, const VkAllocationCallbacks *pAllocator) { 53805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5381b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 53825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fbNode = dev_data->frameBufferMap.find(framebuffer); 53835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fbNode != dev_data->frameBufferMap.end()) { 53845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto cb : fbNode->second.referencingCmdBuffers) { 53855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto cbNode = dev_data->commandBufferMap.find(cb); 53865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (cbNode != dev_data->commandBufferMap.end()) { 53875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set CB as invalid and record destroyed framebuffer 53885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->state = CB_INVALID; 53895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cbNode->second->destroyedFramebuffers.insert(framebuffer); 53905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 53915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5392f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes delete [] fbNode->second.createInfo.pAttachments; 5393f05c35fb24123fd1bcba89accc7fed2c2d0181b7Chris Forbes dev_data->frameBufferMap.erase(fbNode); 53945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5395b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 53965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyFramebuffer(device, framebuffer, pAllocator); 53975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 53985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 539989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 540089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyRenderPass(VkDevice device, VkRenderPass renderPass, const VkAllocationCallbacks *pAllocator) { 54015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyRenderPass(device, renderPass, pAllocator); 5403b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->renderPassMap.erase(renderPass); 54055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 540789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBuffer(VkDevice device, const VkBufferCreateInfo *pCreateInfo, 540889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBuffer *pBuffer) { 54095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 541047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 541147892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateBuffer(device, pCreateInfo, pAllocator, pBuffer); 54125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5414b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : This doesn't create deep copy of pQueueFamilyIndices so need to fix that if/when we want that data to be valid 541601f3372271027b700265e5fbdbef5ad9c3b94649Tobin Ehlis dev_data->bufferMap.insert(std::make_pair(*pBuffer, BUFFER_NODE(pCreateInfo))); 54175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 542189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateBufferView(VkDevice device, const VkBufferViewCreateInfo *pCreateInfo, 542289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkBufferView *pView) { 54235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 54245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateBufferView(device, pCreateInfo, pAllocator, pView); 54255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5426b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->bufferViewMap[*pView] = VkBufferViewCreateInfo(*pCreateInfo); 54285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // In order to create a valid buffer view, the buffer must have been created with at least one of the 54295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // following flags: UNIFORM_TEXEL_BUFFER_BIT or STORAGE_TEXEL_BUFFER_BIT 54300a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes validate_buffer_usage_flags(dev_data, pCreateInfo->buffer, 5431e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VK_BUFFER_USAGE_UNIFORM_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT, false, 54325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCreateBufferView()", "VK_BUFFER_USAGE_[STORAGE|UNIFORM]_TEXEL_BUFFER_BIT"); 54335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 543789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImage(VkDevice device, const VkImageCreateInfo *pCreateInfo, 543889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImage *pImage) { 54395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 544047892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski 544147892024546c67e8db98b51b2ddb962c21088894Mark Lobodzinski VkResult result = dev_data->device_dispatch_table->CreateImage(device, pCreateInfo, pAllocator, pImage); 54425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5444b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 54455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_node; 54465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.layout = pCreateInfo->initialLayout; 54475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_node.format = pCreateInfo->format; 544801f3372271027b700265e5fbdbef5ad9c3b94649Tobin Ehlis dev_data->imageMap.insert(std::make_pair(*pImage, IMAGE_NODE(pCreateInfo))); 54495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {*pImage, false, VkImageSubresource()}; 54505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[*pImage].push_back(subpair); 54515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_node; 54525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 54545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, VkImageSubresourceRange *range, VkImage image) { 5457b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 54585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 54605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 54615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis /* If the caller used the special values VK_REMAINING_MIP_LEVELS and 54625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * VK_REMAINING_ARRAY_LAYERS, resolve them now in our internal state to 54635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis * the actual values. 54645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis */ 54655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->levelCount == VK_REMAINING_MIP_LEVELS) { 54665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->levelCount = image_node_it->second.createInfo.mipLevels - range->baseMipLevel; 54675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range->layerCount == VK_REMAINING_ARRAY_LAYERS) { 54705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis range->layerCount = image_node_it->second.createInfo.arrayLayers - range->baseArrayLayer; 54715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Return the correct layer/level counts if the caller used the special 54765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// values VK_REMAINING_MIP_LEVELS or VK_REMAINING_ARRAY_LAYERS. 54775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void ResolveRemainingLevelsLayers(layer_data *dev_data, uint32_t *levels, uint32_t *layers, VkImageSubresourceRange range, 54785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image) { 5479b9e992386a44404152747d66817a733aa127e281Jeremy Hayes /* expects global_lock to be held by caller */ 54805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 54815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = range.levelCount; 54825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = range.layerCount; 54835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_node_it = dev_data->imageMap.find(image); 54845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_node_it != dev_data->imageMap.end()) { 54855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.levelCount == VK_REMAINING_MIP_LEVELS) { 54865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *levels = image_node_it->second.createInfo.mipLevels - range.baseMipLevel; 54875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (range.layerCount == VK_REMAINING_ARRAY_LAYERS) { 54895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis *layers = image_node_it->second.createInfo.arrayLayers - range.baseArrayLayer; 54905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 54925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 54935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 549489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateImageView(VkDevice device, const VkImageViewCreateInfo *pCreateInfo, 549589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkImageView *pView) { 5496bb6624cb996175d8945190886a200e720b3871efChris Forbes bool skipCall = false; 5497bb6624cb996175d8945190886a200e720b3871efChris Forbes VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 54985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 5499bb6624cb996175d8945190886a200e720b3871efChris Forbes { 5500bb6624cb996175d8945190886a200e720b3871efChris Forbes // Validate that img has correct usage flags set 5501bb6624cb996175d8945190886a200e720b3871efChris Forbes std::lock_guard<std::mutex> lock(global_lock); 5502bb6624cb996175d8945190886a200e720b3871efChris Forbes skipCall |= validate_image_usage_flags(dev_data, pCreateInfo->image, 5503bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_SAMPLED_BIT | VK_IMAGE_USAGE_STORAGE_BIT | 5504bb6624cb996175d8945190886a200e720b3871efChris Forbes VK_IMAGE_USAGE_DEPTH_STENCIL_ATTACHMENT_BIT | VK_IMAGE_USAGE_COLOR_ATTACHMENT_BIT, 5505bb6624cb996175d8945190886a200e720b3871efChris Forbes false, "vkCreateImageView()", "VK_IMAGE_USAGE_[SAMPLED|STORAGE|COLOR_ATTACHMENT]_BIT"); 5506bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5507bb6624cb996175d8945190886a200e720b3871efChris Forbes 5508bb6624cb996175d8945190886a200e720b3871efChris Forbes if (!skipCall) { 5509bb6624cb996175d8945190886a200e720b3871efChris Forbes result = dev_data->device_dispatch_table->CreateImageView(device, pCreateInfo, pAllocator, pView); 5510bb6624cb996175d8945190886a200e720b3871efChris Forbes } 5511bb6624cb996175d8945190886a200e720b3871efChris Forbes 55125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5513b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 55145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageViewCreateInfo localCI = VkImageViewCreateInfo(*pCreateInfo); 55155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &localCI.subresourceRange, pCreateInfo->image); 55165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageViewMap[*pView] = localCI; 55175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5518bb6624cb996175d8945190886a200e720b3871efChris Forbes 55195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 552289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 552389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateFence(VkDevice device, const VkFenceCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkFence *pFence) { 55245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFence(device, pCreateInfo, pAllocator, pFence); 55265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5527b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5528a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis auto &fence_node = dev_data->fenceMap[*pFence]; 5529a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.createInfo = *pCreateInfo; 5530a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = true; 55315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->flags & VK_FENCE_CREATE_SIGNALED_BIT) { 5532a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.firstTimeFlag = true; 5533a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.needsSignaled = false; 55345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5535a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis fence_node.in_use.store(0); 55365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 55375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO handle pipeline caches 554189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineCache(VkDevice device, const VkPipelineCacheCreateInfo *pCreateInfo, 554289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineCache *pPipelineCache) { 55435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineCache(device, pCreateInfo, pAllocator, pPipelineCache); 55455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR void VKAPI_CALL 554989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroyPipelineCache(VkDevice device, VkPipelineCache pipelineCache, const VkAllocationCallbacks *pAllocator) { 55505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroyPipelineCache(device, pipelineCache, pAllocator); 55525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 555589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetPipelineCacheData(VkDevice device, VkPipelineCache pipelineCache, size_t *pDataSize, void *pData) { 55565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetPipelineCacheData(device, pipelineCache, pDataSize, pData); 55585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 556289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMergePipelineCaches(VkDevice device, VkPipelineCache dstCache, uint32_t srcCacheCount, const VkPipelineCache *pSrcCaches) { 55635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 55645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->MergePipelineCaches(device, dstCache, srcCacheCount, pSrcCaches); 55655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 55665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 55675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 55683d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis// utility function to set collective state for pipeline 55693d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlisvoid set_pipeline_state(PIPELINE_NODE *pPipe) { 55703d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis // If any attachment used by this pipeline has blendEnable, set top-level blendEnable 55713d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (pPipe->graphicsPipelineCI.pColorBlendState) { 55723d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis for (size_t i = 0; i < pPipe->attachments.size(); ++i) { 55733d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (VK_TRUE == pPipe->attachments[i].blendEnable) { 55743d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis if (((pPipe->attachments[i].dstAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 55753d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 55763d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].dstColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 55773d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].dstColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 55783d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcAlphaBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 55793d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcAlphaBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA)) || 55803d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis ((pPipe->attachments[i].srcColorBlendFactor >= VK_BLEND_FACTOR_CONSTANT_COLOR) && 55813d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis (pPipe->attachments[i].srcColorBlendFactor <= VK_BLEND_FACTOR_ONE_MINUS_CONSTANT_ALPHA))) { 55823d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pPipe->blendConstantsEnabled = true; 55833d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 55843d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 55853d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 55863d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis } 55873d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis} 55883d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis 558989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 559089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateGraphicsPipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 559189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkGraphicsPipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 559289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 55935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 55945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO What to do with pipelineCache? 55955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // The order of operations here is a little convoluted but gets the job done 55965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 1. Pipeline create state is first shadowed into PIPELINE_NODE struct 55975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 2. Create state is then validated (which uses flags setup during shadowing) 55985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // 3. If everything looks good, we'll then create the pipeline and add NODE to pipelineMap 5599e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 56005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 56015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 56025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5605b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 5608ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5609ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initGraphicsPipeline(&pCreateInfos[i]); 561016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pPipeNode[i]->renderPass = getRenderPass(dev_data, pCreateInfos[i].renderPass); 56114a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 561267220c96300606b517394e25c7aa144dd4601bb6Chris Forbes 56135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode, i); 56145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5616e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5617b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateGraphicsPipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 56195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5620b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 56215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 56225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 56235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 56245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5625b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 56275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 56285188e31f172f7dee49b6ae0a3d81d4cfd8c1b231Chris Forbes delete pPipeNode[i]; 56295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5630b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 563689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 563789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateComputePipelines(VkDevice device, VkPipelineCache pipelineCache, uint32_t count, 563889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkComputePipelineCreateInfo *pCreateInfos, const VkAllocationCallbacks *pAllocator, 563989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipeline *pPipelines) { 56405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 5641e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 56425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Improve this data struct w/ unique_ptrs so cleanup below is automatic 56445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<PIPELINE_NODE *> pPipeNode(count); 56455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 5648b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 56495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 56505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify compute stage bits 56515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create and initialize internal tracking data structure 56535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i] = new PIPELINE_NODE; 5654ca546210846c65808717f8875deae39bd227c240Tobin Ehlis pPipeNode[i]->initComputePipeline(&pCreateInfos[i]); 56554a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes pPipeNode[i]->pipelineLayout = getPipelineLayout(dev_data, pCreateInfos[i].layout); 5656ca546210846c65808717f8875deae39bd227c240Tobin Ehlis // memcpy(&pPipeNode[i]->computePipelineCI, (const void *)&pCreateInfos[i], sizeof(VkComputePipelineCreateInfo)); 56575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 56585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Add Compute Pipeline Verification 5659396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes skipCall |= !validate_compute_pipeline(dev_data->report_data, pPipeNode[i], 5660396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes &dev_data->phys_dev_properties.features, 5661396244fbebb3dca48be8e37a828fb1034f8c410cChris Forbes dev_data->shaderModuleMap); 56625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // skipCall |= verifyPipelineCreateState(dev_data, device, pPipeNode[i]); 56635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5665e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 5666b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->CreateComputePipelines(device, pipelineCache, count, pCreateInfos, pAllocator, 56685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipelines); 5669b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 56705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 56715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPipeNode[i]->pipeline = pPipelines[i]; 56725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->pipelineMap[pPipeNode[i]->pipeline] = pPipeNode[i]; 56735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5674b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 56765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < count; i++) { 56775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Clean up any locally allocated data structures 56785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pPipeNode[i]; 56795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5680b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 56815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 56825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 568689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSampler(VkDevice device, const VkSamplerCreateInfo *pCreateInfo, 568789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSampler *pSampler) { 56885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 56895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSampler(device, pCreateInfo, pAllocator, pSampler); 56905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5691b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5692cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->samplerMap[*pSampler] = unique_ptr<SAMPLER_NODE>(new SAMPLER_NODE(pSampler, pCreateInfo)); 56935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 56945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 56955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 56965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 569789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 569889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorSetLayout(VkDevice device, const VkDescriptorSetLayoutCreateInfo *pCreateInfo, 569989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDescriptorSetLayout *pSetLayout) { 57005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorSetLayout(device, pCreateInfo, pAllocator, pSetLayout); 57025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 57035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Capture layout bindings set 5704b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 5705cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis dev_data->descriptorSetLayoutMap[*pSetLayout] = 5706cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis new cvdescriptorset::DescriptorSetLayout(dev_data->report_data, pCreateInfo, *pSetLayout); 57075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 57095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 57119e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Used by CreatePipelineLayout and CmdPushConstants. 57129e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz// Note that the index argument is optional and only used by CreatePipelineLayout. 57139e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultzstatic bool validatePushConstantRange(const layer_data *dev_data, const uint32_t offset, const uint32_t size, 57149e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const char *caller_name, uint32_t index = 0) { 57159e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t const maxPushConstantsSize = dev_data->phys_dev_properties.properties.limits.maxPushConstantsSize; 57165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 57179e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Check that offset + size don't exceed the max. 57189e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Prevent arithetic overflow here by avoiding addition and testing in this order. 57199e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset >= maxPushConstantsSize) || (size > maxPushConstantsSize - offset)) { 57209e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // This is a pain just to adapt the log message to the caller, but better to sort it out only when there is a problem. 57219e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 57229e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 57239e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57249e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with offset %u and size %u that " 57259e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 57269e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset, size, maxPushConstantsSize); 57279e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 57289e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57299e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with offset %u and size %u that " 57309e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "exceeds this device's maxPushConstantSize of %u.", 57319e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset, size, maxPushConstantsSize); 57329e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 57339e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57349e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 57359e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57369e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57379e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // size needs to be non-zero and a multiple of 4. 57389e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((size == 0) || ((size & 0x3) != 0)) { 57399e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 57409e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 57419e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57429e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 57439e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 57449e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, size); 57459e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 57469e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 57479e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57489e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 57499e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "size %u. Size must be greater than zero and a multiple of 4.", 57509e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, size); 57519e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 57529e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57539e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 57549e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57559e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57569e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // offset needs to be a multiple of 4. 57579e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((offset & 0x3) != 0) { 57589e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == strcmp(caller_name, "vkCreatePipelineLayout()")) { 57599e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57609e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants index %u with " 57619e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 57629e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, index, offset); 57639e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else if (0 == strcmp(caller_name, "vkCmdPushConstants()")) { 57649e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57659e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "%s call has push constants with " 57669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "offset %u. Offset must be a multiple of 4.", 57679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz caller_name, offset); 57689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 57699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_INTERNAL_ERROR, "DS", "%s caller not supported.", caller_name); 57719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 57735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 57745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 57755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 577689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreatePipelineLayout(VkDevice device, const VkPipelineLayoutCreateInfo *pCreateInfo, 577789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkPipelineLayout *pPipelineLayout) { 57785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 57795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 57809e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Push Constant Range checks 57815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t i = 0; 57825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 57839e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, pCreateInfo->pPushConstantRanges[i].offset, 57849e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz pCreateInfo->pPushConstantRanges[i].size, "vkCreatePipelineLayout()", i); 57859e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == pCreateInfo->pPushConstantRanges[i].stageFlags) { 57869e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 57879e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has no stageFlags set."); 57889e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57899e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 57909e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz // Each range has been validated. Now check for overlap between ranges (if they are good). 57919e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (!skipCall) { 57929e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz uint32_t i, j; 57939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 57949e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz for (j = i + 1; j < pCreateInfo->pushConstantRangeCount; ++j) { 57959e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minA = pCreateInfo->pPushConstantRanges[i].offset; 57969e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxA = minA + pCreateInfo->pPushConstantRanges[i].size; 57979e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t minB = pCreateInfo->pPushConstantRanges[j].offset; 57989e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz const uint32_t maxB = minB + pCreateInfo->pPushConstantRanges[j].size; 57999e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if ((minA <= minB && maxA > minB) || (minB <= minA && maxB > minA)) { 58009e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= 5801a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 58029e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCreatePipelineLayout() call has push constants with " 58039e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz "overlapping ranges: %u:[%u, %u), %u:[%u, %u)", 58049e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz i, minA, maxA, j, minB, maxB); 58059e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58069e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 58075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5809f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 5810f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes if (skipCall) 5811f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 5812f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes 58135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreatePipelineLayout(device, pCreateInfo, pAllocator, pPipelineLayout); 58145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5815b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_LAYOUT_NODE &plNode = dev_data->pipelineLayoutMap[*pPipelineLayout]; 58175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts.resize(pCreateInfo->setLayoutCount); 5818f73b2046273413ea1338dd714d67c39f8e0fa09eChris Forbes plNode.setLayouts.resize(pCreateInfo->setLayoutCount); 58195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->setLayoutCount; ++i) { 58205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.descriptorSetLayouts[i] = pCreateInfo->pSetLayouts[i]; 5821addeafba8720251f59f73dc2200bd512ae498bd5Chris Forbes plNode.setLayouts[i] = getDescriptorSetLayout(dev_data, pCreateInfo->pSetLayouts[i]); 58225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges.resize(pCreateInfo->pushConstantRangeCount); 58245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (i = 0; i < pCreateInfo->pushConstantRangeCount; ++i) { 58255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis plNode.pushConstantRanges[i] = pCreateInfo->pPushConstantRanges[i]; 58265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 583189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 583289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDescriptorPool(VkDevice device, const VkDescriptorPoolCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, 583389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDescriptorPool *pDescriptorPool) { 58345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateDescriptorPool(device, pCreateInfo, pAllocator, pDescriptorPool); 58365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 58375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Insert this pool into Global Pool LL at head 58385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5839414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", "Created Descriptor Pool 0x%" PRIxLEAST64, 58405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool)) 58415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 58425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pNewNode = new DESCRIPTOR_POOL_NODE(*pDescriptorPool, pCreateInfo); 58435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (NULL == pNewNode) { 58445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 58455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)*pDescriptorPool, __LINE__, DRAWSTATE_OUT_OF_MEMORY, "DS", 58465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Out of memory while attempting to allocate DESCRIPTOR_POOL_NODE in vkCreateDescriptorPool()")) 58475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 58485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 5849b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->descriptorPoolMap[*pDescriptorPool] = pNewNode; 58515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 58535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Need to do anything if pool create fails? 58545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 585889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 585989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetDescriptorPool(VkDevice device, VkDescriptorPool descriptorPool, VkDescriptorPoolResetFlags flags) { 58605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 58615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetDescriptorPool(device, descriptorPool, flags); 58625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5863b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 58645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis clearDescriptorPool(dev_data, device, descriptorPool, flags); 58655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 58665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 58675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 58685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 58692c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// Ensure the pool contains enough descriptors and descriptor sets to satisfy 58702c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// an allocation request. Fills requiredDescriptorsByType with the total number 58712c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes// of descriptors of each type required, for later update. 5872cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateAllocateDescriptorSets(const layer_data *dev_data, const DESCRIPTOR_POOL_NODE *pPoolNode, uint32_t count, 5873cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis std::vector<cvdescriptorset::DescriptorSetLayout const *> const &layout_nodes, 58742c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes uint32_t requiredDescriptorsByType[]) { 58752c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes bool skipCall = false; 58762c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 58772c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes // Track number of descriptorSets allowable in this pool 58782c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes if (pPoolNode->availableSets < count) { 58792c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5880cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<const uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 58812c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes "Unable to allocate %u descriptorSets from pool 0x%" PRIxLEAST64 58822c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes ". This pool only has %d descriptorSets remaining.", 5883cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis count, reinterpret_cast<const uint64_t &>(pPoolNode->pool), pPoolNode->availableSets); 58842c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 58852c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 58862c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes // Count total descriptors required per type 58872c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes for (auto layout_node : layout_nodes) { 58882c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes if (layout_node) { 58892c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes for (uint32_t j = 0; j < layout_node->GetBindingCount(); ++j) { 58902c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes const auto &binding_layout = layout_node->GetDescriptorSetLayoutBindingPtrFromIndex(j); 58912c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes uint32_t typeIndex = static_cast<uint32_t>(binding_layout->descriptorType); 58922c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes requiredDescriptorsByType[typeIndex] += binding_layout->descriptorCount; 58932c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 58942c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 58952c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 58962c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 58972c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes // Determine whether descriptor counts are satisfiable 58982c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes for (uint32_t i = 0; i < VK_DESCRIPTOR_TYPE_RANGE_SIZE; i++) { 58992c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes if (requiredDescriptorsByType[i] > pPoolNode->availableDescriptorTypeCount[i]) { 59002c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes skipCall |= log_msg( 59012c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59022c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes reinterpret_cast<const uint64_t &>(pPoolNode->pool), __LINE__, DRAWSTATE_DESCRIPTOR_POOL_EMPTY, "DS", 59032c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes "Unable to allocate %u descriptors of type %s from pool 0x%" PRIxLEAST64 59042c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes ". This pool only has %d descriptors of this type remaining.", 59052c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes requiredDescriptorsByType[i], string_VkDescriptorType(VkDescriptorType(i)), (uint64_t)pPoolNode->pool, 59062c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes pPoolNode->availableDescriptorTypeCount[i]); 59072c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 59082c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes } 59092c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 59102c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes return skipCall; 59112c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes} 59122c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes 591389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 591489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateDescriptorSets(VkDevice device, const VkDescriptorSetAllocateInfo *pAllocateInfo, VkDescriptorSet *pDescriptorSets) { 5915e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 59165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 591711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 59186511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes uint32_t requiredDescriptorsByType[VK_DESCRIPTOR_TYPE_RANGE_SIZE] {}; 591911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes std::vector<cvdescriptorset::DescriptorSetLayout const *> layout_nodes(pAllocateInfo->descriptorSetCount, nullptr); 59205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 5921b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 592211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 592311f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 592411f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes layout_nodes[i] = getDescriptorSetLayout(dev_data, pAllocateInfo->pSetLayouts[i]); 592511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (!layout_nodes[i]) { 592611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_LAYOUT_EXT, 592711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes (uint64_t)pAllocateInfo->pSetLayouts[i], __LINE__, DRAWSTATE_INVALID_LAYOUT, "DS", 592811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes "Unable to find set layout node for layout 0x%" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 592911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes (uint64_t)pAllocateInfo->pSetLayouts[i]); 593011f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 593111f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes } 593211f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 59335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DESCRIPTOR_POOL_NODE *pPoolNode = getPoolNode(dev_data, pAllocateInfo->descriptorPool); 59346511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 59355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pPoolNode) { 59365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 59375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool, __LINE__, DRAWSTATE_INVALID_POOL, "DS", 5938414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Unable to find pool node for pool 0x%" PRIxLEAST64 " specified in vkAllocateDescriptorSets() call", 59395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pAllocateInfo->descriptorPool); 59405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { // Make sure pool has all the available descriptors before calling down chain 59412c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes skipCall |= PreCallValidateAllocateDescriptorSets(dev_data, pPoolNode, pAllocateInfo->descriptorSetCount, 59422c4e180a4442f968b44f3d5136f7ffda706f6428Chris Forbes layout_nodes, requiredDescriptorsByType); 59435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5944b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 5945d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 59465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (skipCall) 59475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 5948d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes 59495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateDescriptorSets(device, pAllocateInfo, pDescriptorSets); 59506511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 59515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 5952b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 59535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPoolNode) { 59546511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes /* Account for sets and descriptors allocated */ 59556511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes pPoolNode->availableSets -= pAllocateInfo->descriptorSetCount; 59566511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes for (uint32_t i = 0; i < VK_DESCRIPTOR_TYPE_RANGE_SIZE; i++) { 59576511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes pPoolNode->availableDescriptorTypeCount[i] -= requiredDescriptorsByType[i]; 59586511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes } 59596511ce241f7f210211e0c0e882f3c14889071f4dChris Forbes 5960d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes /* Create tracking object for each descriptor set; insert into 5961d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes * global map and the pool's set. 5962d173e0daab123373ce75105f2a908f6ae7cef6abChris Forbes */ 59635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pAllocateInfo->descriptorSetCount; i++) { 596411f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes if (layout_nodes[i]) { 596511f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes auto pNewNode = new cvdescriptorset::DescriptorSet( 596611f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes pDescriptorSets[i], layout_nodes[i], &dev_data->bufferMap, &dev_data->memObjMap, &dev_data->bufferViewMap, 596711f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes &dev_data->samplerMap, &dev_data->imageViewMap, &dev_data->imageMap, 596811f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes &dev_data->device_extensions.imageToSwapchainMap, &dev_data->device_extensions.swapchainMap); 596911f1fde2721c198a619e4a22fff60eef9a16fae8Chris Forbes 5970cb9ce9e05b8e939d3da35c64997c70049877f4feTobin Ehlis pPoolNode->sets.insert(pNewNode); 59715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pNewNode->in_use.store(0); 59725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->setMap[pDescriptorSets[i]] = pNewNode; 59735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 5976b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 59775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 59785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 59795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 5980cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Verify state before freeing DescriptorSets 5981cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic bool PreCallValidateFreeDescriptorSets(const layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 5982cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 5983cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skip_call = false; 5984cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // First make sure sets being destroyed are not currently in-use 5985cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) 5986cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= validateIdleDescriptorSet(dev_data, descriptor_sets[i], "vkFreeDescriptorSets"); 5987cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 5988cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_node = getPoolNode(dev_data, pool); 5989cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis if (pool_node && !(VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT & pool_node->createInfo.flags)) { 5990cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Can't Free from a NON_FREE pool 5991cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_POOL_EXT, 5992cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis reinterpret_cast<uint64_t &>(pool), __LINE__, DRAWSTATE_CANT_FREE_FROM_NON_FREE_POOL, "DS", 5993cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "It is invalid to call vkFreeDescriptorSets() with a pool created without setting " 5994cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis "VK_DESCRIPTOR_POOL_CREATE_FREE_DESCRIPTOR_SET_BIT."); 5995cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 5996cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis return skip_call; 5997cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 5998cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis// Sets have been removed from the pool so update underlying state 5999cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlisstatic void PostCallRecordFreeDescriptorSets(layer_data *dev_data, VkDescriptorPool pool, uint32_t count, 6000cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis const VkDescriptorSet *descriptor_sets) { 6001cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis DESCRIPTOR_POOL_NODE *pool_state = getPoolNode(dev_data, pool); 6002cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // Update available descriptor sets in pool 6003cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableSets += count; 6004cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis 6005cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis // For each freed descriptor add its resources back into the pool as available and remove from pool and setMap 6006cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t i = 0; i < count; ++i) { 6007cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis auto set_state = dev_data->setMap[descriptor_sets[i]]; 6008cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis uint32_t type_index = 0, descriptor_count = 0; 6009cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis for (uint32_t j = 0; j < set_state->GetBindingCount(); ++j) { 6010cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis type_index = static_cast<uint32_t>(set_state->GetTypeFromIndex(j)); 6011cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis descriptor_count = set_state->GetDescriptorCountFromIndex(j); 6012cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->availableDescriptorTypeCount[type_index] += descriptor_count; 6013cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6014cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis freeDescriptorSet(dev_data, set_state); 6015cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis pool_state->sets.erase(set_state); 6016cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis } 6017cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis} 60185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 601989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 602089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFreeDescriptorSets(VkDevice device, VkDescriptorPool descriptorPool, uint32_t count, const VkDescriptorSet *pDescriptorSets) { 60215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure that no sets being destroyed are in-flight 6023b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6024cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis bool skipCall = PreCallValidateFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6025b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) 60275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 60285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->FreeDescriptorSets(device, descriptorPool, count, pDescriptorSets); 60295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6030b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 6031cd53549dd5a597894f308b4bb993c02ae30817d6Tobin Ehlis PostCallRecordFreeDescriptorSets(dev_data, descriptorPool, count, pDescriptorSets); 6032b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 60355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60366b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// TODO : This is a Proof-of-concept for core validation architecture 60376b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// Really we'll want to break out these functions to separate files but 60386b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// keeping it all together here to prove out design 60396b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PreCallValidate* handles validating all of the state prior to calling down chain to UpdateDescriptorSets() 60406b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic bool PreCallValidateUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 60416b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 60426b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 60436b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // First thing to do is perform map look-ups. 60446b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // NOTE : UpdateDescriptorSets is somewhat unique in that it's operating on a number of DescriptorSets 60456b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // so we can't just do a single map look-up up-front, but do them individually in functions below 60466b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis 60476b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Now make call(s) that validate state, but don't perform state updates in this function 60486b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Note, here DescriptorSets is unique in that we don't yet have an instance. Using a helper function in the 60496b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // namespace which will parse params and make calls into specific class instances 60506b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis return cvdescriptorset::ValidateUpdateDescriptorSets(dev_data->report_data, dev_data->setMap, descriptorWriteCount, 60516b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorWrites, descriptorCopyCount, pDescriptorCopies); 60526b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 60536b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis// PostCallRecord* handles recording state updates following call down chain to UpdateDescriptorSets() 60546b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlisstatic void PostCallRecordUpdateDescriptorSets(layer_data *dev_data, uint32_t descriptorWriteCount, 60556b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkWriteDescriptorSet *pDescriptorWrites, uint32_t descriptorCopyCount, 60566b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis const VkCopyDescriptorSet *pDescriptorCopies) { 60576b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis cvdescriptorset::PerformUpdateDescriptorSets(dev_data->setMap, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 60586b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 60596b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis} 60605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 606189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 606289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuUpdateDescriptorSets(VkDevice device, uint32_t descriptorWriteCount, const VkWriteDescriptorSet *pDescriptorWrites, 606389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t descriptorCopyCount, const VkCopyDescriptorSet *pDescriptorCopies) { 60646b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Only map look-up at top level is for device-level layer_data 60655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 6066b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 60676b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis bool skip_call = PreCallValidateUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 60686b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 6069b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 60706b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis if (!skip_call) { 60715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->UpdateDescriptorSets(device, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 60725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorCopies); 60736b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis lock.lock(); 60746b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis // Since UpdateDescriptorSets() is void, nothing to check prior to updating state 60756b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis PostCallRecordUpdateDescriptorSets(dev_data, descriptorWriteCount, pDescriptorWrites, descriptorCopyCount, 60766b67c2aac9862a21e0dd068966c8b0b3aaf0bafdTobin Ehlis pDescriptorCopies); 60775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 60795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 608089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 608189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuAllocateCommandBuffers(VkDevice device, const VkCommandBufferAllocateInfo *pCreateInfo, VkCommandBuffer *pCommandBuffer) { 60825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 60835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->AllocateCommandBuffers(device, pCreateInfo, pCommandBuffer); 60845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6085b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 608672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto const &cp_it = dev_data->commandPoolMap.find(pCreateInfo->commandPool); 608772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cp_it != dev_data->commandPoolMap.end()) { 608872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < pCreateInfo->commandBufferCount; i++) { 60895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to its commandPool map 609072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cp_it->second.commandBuffers.push_back(pCommandBuffer[i]); 60915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = new GLOBAL_CB_NODE; 60925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Add command buffer to map 60935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->commandBufferMap[pCommandBuffer[i]] = pCB; 60945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, pCommandBuffer[i]); 60955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->createInfo = *pCreateInfo; 60965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->device = device; 60975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 60990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes printCBList(dev_data); 6100b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 61015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 61035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 61045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 610589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 610689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuBeginCommandBuffer(VkCommandBuffer commandBuffer, const VkCommandBufferBeginInfo *pBeginInfo) { 6107e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 61085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6109b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 61105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate command buffer level 61115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 61125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 61135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This implicitly resets the Cmd Buffer so make sure any fence is done and then clear memory references 6114a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.count(commandBuffer)) { 6115a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skipCall |= 6116a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6117a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis (uint64_t)commandBuffer, __LINE__, MEMTRACK_RESET_CB_WHILE_IN_FLIGHT, "MEM", 6118414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Calling vkBeginCommandBuffer() on active CB 0x%p before it has completed. " 6119a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis "You must check CB fence before this call.", 6120a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis commandBuffer); 61215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6122a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis clear_cmd_buf_and_mem_references(dev_data, pCB); 61235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 61245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary Command Buffer 61255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkCommandBufferInheritanceInfo *pInfo = pBeginInfo->pInheritanceInfo; 61265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pInfo) { 61275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6130414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must have inheritance info.", 61315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pBeginInfo->flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT) { 6134400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->renderPass) { // renderpass should NOT be null for a Secondary CB 61355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 61365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6138414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must specify a valid renderpass parameter.", 61395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6141400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis if (!pInfo->framebuffer) { // framebuffer may be null for a Secondary CB, but this affects perf 61425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 61435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, 6145414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS", "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) may perform better if a " 61465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "valid framebuffer parameter is specified.", 61475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 61495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 6150f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = getFramebuffer(dev_data, pInfo->framebuffer); 6151f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes if (framebuffer) { 6152f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes VkRenderPass fbRP = framebuffer->createInfo.renderPass; 61535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!verify_renderpass_compatibility(dev_data, fbRP, pInfo->renderPass, errorString)) { 6154400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis // renderPass that framebuffer was created with must be compatible with local renderPass 61555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 61575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(commandBuffer), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, 61595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "DS", "vkBeginCommandBuffer(): Secondary Command " 6160414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Buffer (0x%p) renderPass (0x%" PRIxLEAST64 ") is incompatible w/ framebuffer " 6161414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 61625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer), (uint64_t)(pInfo->renderPass), 61635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pInfo->framebuffer), (uint64_t)(fbRP), errorString.c_str()); 61645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 6166f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 61675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((pInfo->occlusionQueryEnable == VK_FALSE || 6171b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.features.occlusionQueryPrecise == VK_FALSE) && 61725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pInfo->queryFlags & VK_QUERY_CONTROL_PRECISE_BIT)) { 61735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 61745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, reinterpret_cast<uint64_t>(commandBuffer), 61755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6176414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffer (0x%p) must not have " 61775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_QUERY_CONTROL_PRECISE_BIT if occulusionQuery is disabled or the device does not " 61785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "support precise occlusion queries.", 61795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(commandBuffer)); 61805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pInfo && pInfo->renderPass != VK_NULL_HANDLE) { 618316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pInfo->renderPass); 618416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 618516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (pInfo->subpass >= renderPass->pCreateInfo->subpassCount) { 61865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 61875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 61885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6189414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Secondary Command Buffers (0x%p) must has a subpass index (%d) " 61905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "that is less than the number of subpasses (%d).", 619116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes (void *)commandBuffer, pInfo->subpass, renderPass->pCreateInfo->subpassCount); 61925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 61965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (CB_RECORDING == pCB->state) { 61975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 61985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 61995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 6200414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBeginCommandBuffer(): Cannot call Begin on CB (0x%" PRIxLEAST64 62015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") in the RECORDING state. Must first call vkEndCommandBuffer().", 62025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer); 62037651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis } else if (CB_RECORDED == pCB->state || (CB_INVALID == pCB->state && CMD_END == pCB->cmds.back().type)) { 62045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 62055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 62065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 62075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6209414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Call to vkBeginCommandBuffer() on command buffer (0x%" PRIxLEAST64 6210414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") attempts to implicitly reset cmdBuffer created from command pool (0x%" PRIxLEAST64 62115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 62125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 62135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 62155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Set updated state here in case implicit reset occurs above 62175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDING; 62185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo = *pBeginInfo; 62195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.pInheritanceInfo) { 62205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->inheritanceInfo = *(pCB->beginInfo.pInheritanceInfo); 62215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.pInheritanceInfo = &pCB->inheritanceInfo; 6222888e1d268098177fde4a2263e3d7b7cc415f1debMark Young // If we are a secondary command-buffer and inheriting. Update the items we should inherit. 6223888e1d268098177fde4a2263e3d7b7cc415f1debMark Young if ((pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) && 6224888e1d268098177fde4a2263e3d7b7cc415f1debMark Young (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 622516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = getRenderPass(dev_data, pCB->beginInfo.pInheritanceInfo->renderPass); 6226888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->activeSubpass = pCB->beginInfo.pInheritanceInfo->subpass; 6227888e1d268098177fde4a2263e3d7b7cc415f1debMark Young pCB->framebuffers.insert(pCB->beginInfo.pInheritanceInfo->framebuffer); 6228888e1d268098177fde4a2263e3d7b7cc415f1debMark Young } 62295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 62325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 6233414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "In vkBeginCommandBuffer() and unable to find CommandBuffer Node for CB 0x%p!", (void *)commandBuffer); 62345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6235b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6236e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skipCall) { 62375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->BeginCommandBuffer(commandBuffer, pBeginInfo); 6240400cff9fad0e19c80f6c9ed1181795d411a4bec5Tobin Ehlis 62415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 624489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EndCommandBuffer(VkCommandBuffer commandBuffer) { 6245e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 62465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_SUCCESS; 62475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6248b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 62505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6251fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop if ((VK_COMMAND_BUFFER_LEVEL_PRIMARY == pCB->createInfo.level) || !(pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 6252fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // This needs spec clarification to update valid usage, see comments in PR: 6253fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop // https://github.com/KhronosGroup/Vulkan-LoaderAndValidationLayers/pull/516#discussion_r63013756 6254fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop skipCall |= insideRenderPass(dev_data, pCB, "vkEndCommandBuffer"); 6255fd61966f8d41b5bce15620b70563b7864cbb28feCody Northrop } 62567651c2eb9fe152ba62921ed60454afd882357e2aTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_END, "vkEndCommandBuffer()"); 62575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto query : pCB->activeQueries) { 62585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 62595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUERY, "DS", 6260414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Ending command buffer with in progress query: queryPool 0x%" PRIx64 ", index %d", 62615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(query.pool), query.index); 62625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6264e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 6265b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->EndCommandBuffer(commandBuffer); 6267b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 62685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 62695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->state = CB_RECORDED; 62705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Reset CB status flags 62715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status = 0; 62725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis printCB(dev_data, commandBuffer); 62735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 62745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 62755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = VK_ERROR_VALIDATION_FAILED_EXT; 62765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6277b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 62785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 62795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 62805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 628189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 628289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuResetCommandBuffer(VkCommandBuffer commandBuffer, VkCommandBufferResetFlags flags) { 6283bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis bool skip_call = false; 62845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6285b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 62865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 62875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkCommandPool cmdPool = pCB->createInfo.commandPool; 62885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT & dev_data->commandPoolMap[cmdPool].createFlags)) { 6289bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 6290bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER_RESET, "DS", 6291414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to reset command buffer (0x%" PRIxLEAST64 ") created from command pool (0x%" PRIxLEAST64 6292bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis ") that does NOT have the VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT bit set.", 6293bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis (uint64_t)commandBuffer, (uint64_t)cmdPool); 62945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6295bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis skip_call |= checkAndClearCommandBufferInFlight(dev_data, pCB, "reset"); 6296b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6297bc300ace5ad8d1935d42ee5dbbf36ce6ace4c0e8Tobin Ehlis if (skip_call) 62985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 62995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->ResetCommandBuffer(commandBuffer, flags); 63005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 6301b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 63025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis resetCB(dev_data, commandBuffer); 6303b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 63045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 63065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 630793c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski 630889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 630989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindPipeline(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipeline pipeline) { 6310e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6312b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDPIPELINE, "vkCmdBindPipeline()"); 63165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((VK_PIPELINE_BIND_POINT_COMPUTE == pipelineBindPoint) && (pCB->activeRenderPass)) { 63175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 63185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_RENDERPASS_CMD, "DS", 6320414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Incorrectly binding compute pipeline (0x%" PRIxLEAST64 ") during active RenderPass (0x%" PRIxLEAST64 ")", 6321ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pipeline, (uint64_t)pCB->activeRenderPass->renderPass); 63225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 63245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis PIPELINE_NODE *pPN = getPipeline(dev_data, pipeline); 63255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPN) { 632672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipeline = pipeline; 63275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_cb_pso_status(pCB, pPN); 63283d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis set_pipeline_state(pPN); 63295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 63305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PIPELINE_EXT, 63315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pipeline, __LINE__, DRAWSTATE_INVALID_PIPELINE, "DS", 6332414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to bind Pipeline 0x%" PRIxLEAST64 " that doesn't exist!", (uint64_t)(pipeline)); 63335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 63345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6335b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6336e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindPipeline(commandBuffer, pipelineBindPoint, pipeline); 63385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 634089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 634189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetViewport(VkCommandBuffer commandBuffer, uint32_t firstViewport, uint32_t viewportCount, const VkViewport *pViewports) { 6342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6344b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETVIEWPORTSTATE, "vkCmdSetViewport()"); 63485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_VIEWPORT_SET; 63495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->viewports.resize(viewportCount); 63505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->viewports.data(), pViewports, viewportCount * sizeof(VkViewport)); 63515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6353e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetViewport(commandBuffer, firstViewport, viewportCount, pViewports); 63555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 635789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 635889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetScissor(VkCommandBuffer commandBuffer, uint32_t firstScissor, uint32_t scissorCount, const VkRect2D *pScissors) { 6359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 63605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6361b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 63645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSCISSORSTATE, "vkCmdSetScissor()"); 63655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_SCISSOR_SET; 63665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->scissors.resize(scissorCount); 63675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(pCB->scissors.data(), pScissors, scissorCount * sizeof(VkRect2D)); 63685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6369b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6370e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 63715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetScissor(commandBuffer, firstScissor, scissorCount, pScissors); 63725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 637489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetLineWidth(VkCommandBuffer commandBuffer, float lineWidth) { 6375a27508babf63d50aea75883a3702979193c23683Mark Young bool skip_call = false; 63765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6377b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 63785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 63795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 6380a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= addCmd(dev_data, pCB, CMD_SETLINEWIDTHSTATE, "vkCmdSetLineWidth()"); 63815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_LINE_WIDTH_SET; 6382a27508babf63d50aea75883a3702979193c23683Mark Young 6383a27508babf63d50aea75883a3702979193c23683Mark Young PIPELINE_NODE *pPipeTrav = getPipeline(dev_data, pCB->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline); 6384a27508babf63d50aea75883a3702979193c23683Mark Young if (pPipeTrav != NULL && !isDynamic(pPipeTrav, VK_DYNAMIC_STATE_LINE_WIDTH)) { 6385a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 6386a27508babf63d50aea75883a3702979193c23683Mark Young reinterpret_cast<uint64_t &>(commandBuffer), __LINE__, DRAWSTATE_INVALID_SET, "DS", 6387386d9a9a77f884789a7ae4c3890aecd47132f2babaldurk "vkCmdSetLineWidth called but pipeline was created without VK_DYNAMIC_STATE_LINE_WIDTH " 6388a27508babf63d50aea75883a3702979193c23683Mark Young "flag. This is undefined behavior and could be ignored."); 6389a27508babf63d50aea75883a3702979193c23683Mark Young } else { 6390a27508babf63d50aea75883a3702979193c23683Mark Young skip_call |= verifyLineWidth(dev_data, DRAWSTATE_INVALID_SET, reinterpret_cast<uint64_t &>(commandBuffer), lineWidth); 6391a27508babf63d50aea75883a3702979193c23683Mark Young } 63925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6393b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6394a27508babf63d50aea75883a3702979193c23683Mark Young if (!skip_call) 63955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetLineWidth(commandBuffer, lineWidth); 63965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 63975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 639889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 639989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBias(VkCommandBuffer commandBuffer, float depthBiasConstantFactor, float depthBiasClamp, float depthBiasSlopeFactor) { 6400e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6402b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBIASSTATE, "vkCmdSetDepthBias()"); 64065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BIAS_SET; 64075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6408b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6409e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBias(commandBuffer, depthBiasConstantFactor, depthBiasClamp, 64115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis depthBiasSlopeFactor); 64125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 641489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdSetBlendConstants(VkCommandBuffer commandBuffer, const float blendConstants[4]) { 6415e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6417b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETBLENDSTATE, "vkCmdSetBlendConstants()"); 64213d3e06b40a06f099e741b9299efa66bddb69a074Tobin Ehlis pCB->status |= CBSTATUS_BLEND_CONSTANTS_SET; 64225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6423b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6424e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetBlendConstants(commandBuffer, blendConstants); 64265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 642889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 642989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetDepthBounds(VkCommandBuffer commandBuffer, float minDepthBounds, float maxDepthBounds) { 6430e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6432b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETDEPTHBOUNDSSTATE, "vkCmdSetDepthBounds()"); 64365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_DEPTH_BOUNDS_SET; 64375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6438b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6439e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetDepthBounds(commandBuffer, minDepthBounds, maxDepthBounds); 64415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 644389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 644489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilCompareMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t compareMask) { 6445e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6447b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREADMASKSTATE, "vkCmdSetStencilCompareMask()"); 64515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_READ_MASK_SET; 64525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6453b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6454e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilCompareMask(commandBuffer, faceMask, compareMask); 64565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 645889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 645989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilWriteMask(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t writeMask) { 6460e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6462b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILWRITEMASKSTATE, "vkCmdSetStencilWriteMask()"); 64665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_WRITE_MASK_SET; 64675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6468b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6469e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilWriteMask(commandBuffer, faceMask, writeMask); 64715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 647389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 647489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetStencilReference(VkCommandBuffer commandBuffer, VkStencilFaceFlags faceMask, uint32_t reference) { 6475e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6477b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETSTENCILREFERENCESTATE, "vkCmdSetStencilReference()"); 64815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->status |= CBSTATUS_STENCIL_REFERENCE_SET; 64825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6483b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6484e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 64855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetStencilReference(commandBuffer, faceMask, reference); 64865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 64875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 648889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 648989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindDescriptorSets(VkCommandBuffer commandBuffer, VkPipelineBindPoint pipelineBindPoint, VkPipelineLayout layout, 649089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstSet, uint32_t setCount, const VkDescriptorSet *pDescriptorSets, uint32_t dynamicOffsetCount, 649189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const uint32_t *pDynamicOffsets) { 6492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 64935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6494b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 64955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 64965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 64975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 6498787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Track total count of dynamic descriptor types to make sure we have an offset for each one 6499787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t totalDynamicDescriptors = 0; 6500787f29d93dee194c015789cf61c079504c980572Tobin Ehlis string errorString = ""; 6501787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t lastSetIndex = firstSet + setCount - 1; 6502dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (lastSetIndex >= pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size()) { 650372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 6504dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets.resize(lastSetIndex + 1); 6505dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes } 650671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto oldFinalBoundSet = pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex]; 6507787f29d93dee194c015789cf61c079504c980572Tobin Ehlis for (uint32_t i = 0; i < setCount; i++) { 6508397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis cvdescriptorset::DescriptorSet *pSet = getSetNode(dev_data, pDescriptorSets[i]); 6509787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (pSet) { 651071511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].uniqueBoundSets.insert(pSet); 65119d17becd811b49e1ecf91a02eee22f9cf7cbc026Tobin Ehlis pSet->BindCommandBuffer(pCB); 651272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].pipelineLayout = layout; 651371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i + firstSet] = pSet; 6514787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 6515787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6516414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DS 0x%" PRIxLEAST64 " bound on pipeline %s", 6517787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i], string_VkPipelineBindPoint(pipelineBindPoint)); 6518397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (!pSet->IsUpdated() && (pSet->GetTotalDescriptorCount() != 0)) { 6519787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, 6520787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], 6521787f29d93dee194c015789cf61c079504c980572Tobin Ehlis __LINE__, DRAWSTATE_DESCRIPTOR_SET_NOT_UPDATED, "DS", 6522414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DS 0x%" PRIxLEAST64 6523787f29d93dee194c015789cf61c079504c980572Tobin Ehlis " bound but it was never updated. You may want to either update it or not bind it.", 6524787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 6525787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6526787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Verify that set being bound is compatible with overlapping setLayout of pipelineLayout 6527787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (!verify_set_layout_compatibility(dev_data, pSet, layout, i + firstSet, errorString)) { 6528787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6529e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6530e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis DRAWSTATE_PIPELINE_LAYOUTS_INCOMPATIBLE, "DS", 6531e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis "descriptorSet #%u being bound is not compatible with overlapping descriptorSetLayout " 6532414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "at index %u of pipelineLayout 0x%" PRIxLEAST64 " due to: %s", 6533e44200cc4e1a293ff04baed6dcc4f1e37c2d66f1Tobin Ehlis i, i + firstSet, reinterpret_cast<uint64_t &>(layout), errorString.c_str()); 6534787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6535dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6536dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes auto setDynamicDescriptorCount = pSet->GetDynamicDescriptorCount(); 6537dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6538dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i].clear(); 6539dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6540dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if (setDynamicDescriptorCount) { 6541787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // First make sure we won't overstep bounds of pDynamicOffsets array 6542dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes if ((totalDynamicDescriptors + setDynamicDescriptorCount) > dynamicOffsetCount) { 6543787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= 6544787f29d93dee194c015789cf61c079504c980572Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6545787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6546787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6547414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "descriptorSet #%u (0x%" PRIxLEAST64 6548787f29d93dee194c015789cf61c079504c980572Tobin Ehlis ") requires %u dynamicOffsets, but only %u dynamicOffsets are left in pDynamicOffsets " 6549787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "array. There must be one dynamic offset for each dynamic descriptor being bound.", 6550397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis i, (uint64_t)pDescriptorSets[i], pSet->GetDynamicDescriptorCount(), 6551787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (dynamicOffsetCount - totalDynamicDescriptors)); 6552787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { // Validate and store dynamic offsets with the set 6553787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Validate Dynamic Offset Minimums 6554787f29d93dee194c015789cf61c079504c980572Tobin Ehlis uint32_t cur_dyn_offset = totalDynamicDescriptors; 6555397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis for (uint32_t d = 0; d < pSet->GetTotalDescriptorCount(); d++) { 6556397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER_DYNAMIC) { 6557787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6558787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6559b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment) != 0) { 6560787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6561787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6562787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6563787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_UNIFORM_BUFFER_OFFSET, "DS", 6564787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6565414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minUniformBufferOffsetAlignment 0x%" PRIxLEAST64, 6566787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6567b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minUniformBufferOffsetAlignment); 6568787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 6569787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 6570397d27da37095073c8b86f9ff5289d0a39ce486eTobin Ehlis } else if (pSet->GetTypeFromGlobalIndex(d) == VK_DESCRIPTOR_TYPE_STORAGE_BUFFER_DYNAMIC) { 6571787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (vk_safe_modulo( 6572787f29d93dee194c015789cf61c079504c980572Tobin Ehlis pDynamicOffsets[cur_dyn_offset], 6573b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment) != 0) { 6574787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg( 6575787f29d93dee194c015789cf61c079504c980572Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6576787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT, 0, __LINE__, 6577787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_STORAGE_BUFFER_OFFSET, "DS", 6578787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "vkCmdBindDescriptorSets(): pDynamicOffsets[%d] is %d but must be a multiple of " 6579414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "device limit minStorageBufferOffsetAlignment 0x%" PRIxLEAST64, 6580787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset, pDynamicOffsets[cur_dyn_offset], 6581b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.properties.limits.minStorageBufferOffsetAlignment); 65825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6583787f29d93dee194c015789cf61c079504c980572Tobin Ehlis cur_dyn_offset++; 65845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6586dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 6587dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pCB->lastBound[pipelineBindPoint].dynamicOffsets[firstSet + i] = 6588dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes std::vector<uint32_t>(pDynamicOffsets + totalDynamicDescriptors, 6589dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes pDynamicOffsets + totalDynamicDescriptors + setDynamicDescriptorCount); 6590787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // Keep running total of dynamic descriptor count to verify at the end 6591dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes totalDynamicDescriptors += setDynamicDescriptorCount; 6592dd725b03ae4d1296a722d0ec5c9fe63941cabe4bChris Forbes 65935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 65945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6595787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } else { 6596787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6597787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, (uint64_t)pDescriptorSets[i], __LINE__, 6598414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SET, "DS", "Attempt to bind DS 0x%" PRIxLEAST64 " that doesn't exist!", 6599787f29d93dee194c015789cf61c079504c980572Tobin Ehlis (uint64_t)pDescriptorSets[i]); 66005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 660172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BINDDESCRIPTORSETS, "vkCmdBindDescriptorSets()"); 660272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // For any previously bound sets, need to set them to "invalid" if they were disturbed by this update 660372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (firstSet > 0) { // Check set #s below the first bound set 660472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis for (uint32_t i = 0; i < firstSet; ++i) { 660572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] && 660671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], 660771511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis layout, i, errorString)) { 660872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= log_msg( 660972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 661072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, 661172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], __LINE__, DRAWSTATE_NONE, "DS", 6612414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "DescriptorSetDS 0x%" PRIxLEAST64 6613414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u was disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 661472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i], i, (uint64_t)layout); 661572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets[i] = VK_NULL_HANDLE; 661672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 661772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 661872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis } 661972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis // Check if newly last bound set invalidates any remaining bound sets 662072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if ((pCB->lastBound[pipelineBindPoint].boundDescriptorSets.size() - 1) > (lastSetIndex)) { 662172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (oldFinalBoundSet && 662271511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis !verify_set_layout_compatibility(dev_data, oldFinalBoundSet, layout, lastSetIndex, errorString)) { 662371511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis auto old_set = oldFinalBoundSet->GetSet(); 662472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis skipCall |= 662572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 662671511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DESCRIPTOR_SET_EXT, reinterpret_cast<uint64_t &>(old_set), __LINE__, 6627414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_NONE, "DS", "DescriptorSetDS 0x%" PRIxLEAST64 6628414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " previously bound as set #%u is incompatible with set 0x%" PRIxLEAST64 662972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis " newly bound as set #%u so set #%u and any subsequent sets were " 6630414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "disturbed by newly bound pipelineLayout (0x%" PRIxLEAST64 ")", 663171511c5a10533c910bfe62c3bcf58e2a4054e7acTobin Ehlis reinterpret_cast<uint64_t &>(old_set), lastSetIndex, 663272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis (uint64_t)pCB->lastBound[pipelineBindPoint].boundDescriptorSets[lastSetIndex], lastSetIndex, 663372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis lastSetIndex + 1, (uint64_t)layout); 663472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis pCB->lastBound[pipelineBindPoint].boundDescriptorSets.resize(lastSetIndex + 1); 66355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6638787f29d93dee194c015789cf61c079504c980572Tobin Ehlis // dynamicOffsetCount must equal the total number of dynamic descriptors in the sets being bound 6639787f29d93dee194c015789cf61c079504c980572Tobin Ehlis if (totalDynamicDescriptors != dynamicOffsetCount) { 6640787f29d93dee194c015789cf61c079504c980572Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 6641787f29d93dee194c015789cf61c079504c980572Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, (uint64_t)commandBuffer, __LINE__, 6642787f29d93dee194c015789cf61c079504c980572Tobin Ehlis DRAWSTATE_INVALID_DYNAMIC_OFFSET_COUNT, "DS", 6643787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "Attempting to bind %u descriptorSets with %u dynamic descriptors, but dynamicOffsetCount " 6644787f29d93dee194c015789cf61c079504c980572Tobin Ehlis "is %u. It should exactly match the number of dynamic descriptors.", 6645787f29d93dee194c015789cf61c079504c980572Tobin Ehlis setCount, totalDynamicDescriptors, dynamicOffsetCount); 6646787f29d93dee194c015789cf61c079504c980572Tobin Ehlis } 66475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 66485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindDescriptorSets()"); 66495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6651b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6652e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 66535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindDescriptorSets(commandBuffer, pipelineBindPoint, layout, firstSet, setCount, 66545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pDescriptorSets, dynamicOffsetCount, pDynamicOffsets); 66555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 665789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 665889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBindIndexBuffer(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, VkIndexType indexType) { 6659e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 66605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6661593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that IBs have correct usage state flagged 6662b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 66635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 66645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 66650a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 666672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 666772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6668e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindIndexBuffer()"); }; 666972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6670593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BINDINDEXBUFFER, "vkCmdBindIndexBuffer()"); 66715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize offset_align = 0; 66725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (indexType) { 66735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT16: 66745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 2; 66755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 66765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_INDEX_TYPE_UINT32: 66775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset_align = 4; 66785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 66795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: 66805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // ParamChecker should catch bad enum, we'll also throw alignment error below if offset_align stays 0 66815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 66825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 66835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!offset_align || (offset % offset_align)) { 66845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 66855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_VTX_INDEX_ALIGNMENT_ERROR, "DS", 6686414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdBindIndexBuffer() offset (0x%" PRIxLEAST64 ") does not fall on alignment (%s) boundary.", 66875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis offset, string_VkIndexType(indexType)); 66885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6689593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->status |= CBSTATUS_INDEX_BUFFER_BOUND; 66905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6691b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6692e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 66935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindIndexBuffer(commandBuffer, buffer, offset, indexType); 66945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 66955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 66965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisvoid updateResourceTracking(GLOBAL_CB_NODE *pCB, uint32_t firstBinding, uint32_t bindingCount, const VkBuffer *pBuffers) { 66975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t end = firstBinding + bindingCount; 66985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->currentDrawData.buffers.size() < end) { 66995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers.resize(end); 67005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 67025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->currentDrawData.buffers[i + firstBinding] = pBuffers[i]; 67035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6706e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic inline void updateResourceTrackingOnDraw(GLOBAL_CB_NODE *pCB) { pCB->drawData.push_back(pCB->currentDrawData); } 67075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 670889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdBindVertexBuffers(VkCommandBuffer commandBuffer, uint32_t firstBinding, 670989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bindingCount, const VkBuffer *pBuffers, 671089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkDeviceSize *pOffsets) { 6711e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6713593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // TODO : Somewhere need to verify that VBs have correct usage state flagged 6714b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6715593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 6716593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6717593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis for (uint32_t i = 0; i < bindingCount; ++i) { 6718593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory mem; 6719593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)pBuffers[i], VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6720593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6721e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, mem, "vkCmdBindVertexBuffers()"); }; 672272d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 67235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6724593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis addCmd(dev_data, cb_data->second, CMD_BINDVERTEXBUFFER, "vkCmdBindVertexBuffer()"); 6725593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis updateResourceTracking(cb_data->second, firstBinding, bindingCount, pBuffers); 67265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 67275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdBindVertexBuffer()"); 67285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6729b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6730e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBindVertexBuffers(commandBuffer, firstBinding, bindingCount, pBuffers, pOffsets); 67325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6734b9e992386a44404152747d66817a733aa127e281Jeremy Hayes/* expects global_lock to be held by caller */ 6735e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool markStoreImagesAndBuffersAsWritten(layer_data *dev_data, GLOBAL_CB_NODE *pCB) { 67365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 67377a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis 67387a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto imageView : pCB->updateImages) { 67397a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis auto iv_data = dev_data->imageViewMap.find(imageView); 67407a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis if (iv_data == dev_data->imageViewMap.end()) 67415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 67427a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkImage image = iv_data->second.image; 67437a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67447a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skip_call |= 67450a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 6746e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67477a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 6748e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67497a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67507a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67517a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis } 67527a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis for (auto buffer : pCB->updateBuffers) { 67537a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VkDeviceMemory mem; 67540a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skip_call |= get_mem_binding_from_object(dev_data, (uint64_t)buffer, 67557a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 6756e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 67577a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis set_memory_valid(dev_data, mem, true); 6758e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 67597a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis }; 67607a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis pCB->validate_functions.push_back(function); 67615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 67635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 676589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDraw(VkCommandBuffer commandBuffer, uint32_t vertexCount, uint32_t instanceCount, 676689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t firstVertex, uint32_t firstInstance) { 6767e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 67685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6769b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAW, "vkCmdDraw()"); 67735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW]++; 6774e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 67757a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 67765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 67775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 67785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6779414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDraw() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW]++); 67805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6781e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 67825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 67835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 67845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDraw"); 67855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6786b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6787e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 67885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDraw(commandBuffer, vertexCount, instanceCount, firstVertex, firstInstance); 67895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 67905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 679189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDrawIndexed(VkCommandBuffer commandBuffer, uint32_t indexCount, 679289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t instanceCount, uint32_t firstIndex, int32_t vertexOffset, 67935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t firstInstance) { 67945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6795e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6796b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 67975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 67985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 67995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXED, "vkCmdDrawIndexed()"); 68005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED]++; 6801e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 68027a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6806414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndexed() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDEXED]++); 68075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6808e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexed"); 68125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6813b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6814e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexed(commandBuffer, indexCount, instanceCount, firstIndex, vertexOffset, 68165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis firstInstance); 68175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 681989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 682089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 68215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6822e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 6823b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68270a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndirect"); 68295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDIRECT, "vkCmdDrawIndirect()"); 68325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDIRECT]++; 6833e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_GRAPHICS); 68347a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, 68375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_NONE, "DS", 6838414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdDrawIndirect() call 0x%" PRIx64 ", reporting DS state:", g_drawCount[DRAW_INDIRECT]++); 68395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6840e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndirect"); 68445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6845b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndirect(commandBuffer, buffer, offset, count, stride); 68485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 685089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 685189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDrawIndexedIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset, uint32_t count, uint32_t stride) { 6852e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6854b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 68565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // MTMTODO : merge with code below 68575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 68580a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 68595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDrawIndexedIndirect"); 68605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 68625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DRAWINDEXEDINDIRECT, "vkCmdDrawIndexedIndirect()"); 68635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->drawCount[DRAW_INDEXED_INDIRECT]++; 6864e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= validate_and_update_draw_state(dev_data, pCB, true, VK_PIPELINE_BIND_POINT_GRAPHICS); 68657a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Need to pass commandBuffer as srcObj here 68675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 68685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 6869414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller __LINE__, DRAWSTATE_NONE, "DS", "vkCmdDrawIndexedIndirect() call 0x%" PRIx64 ", reporting DS state:", 68705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis g_drawCount[DRAW_INDEXED_INDIRECT]++); 68715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= synchAndPrintDSConfig(dev_data, commandBuffer); 6872e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 68735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis updateResourceTrackingOnDraw(pCB); 68745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 68755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdDrawIndexedIndirect"); 68765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6877b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6878e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDrawIndexedIndirect(commandBuffer, buffer, offset, count, stride); 68805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 688289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdDispatch(VkCommandBuffer commandBuffer, uint32_t x, uint32_t y, uint32_t z) { 6883e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 68845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6885b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 68865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 68875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 688822fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 68897a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 68905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCH, "vkCmdDispatch()"); 68915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatch"); 68925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6893b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6894e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 68955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatch(commandBuffer, x, y, z); 68965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 68975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 689889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 689989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdDispatchIndirect(VkCommandBuffer commandBuffer, VkBuffer buffer, VkDeviceSize offset) { 6900e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6902b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 69035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 69045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 69050a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 69065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdDispatchIndirect"); 69075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 69085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 690922fb3c0393ef588b11f8313f01c508028d77dec0Tobin Ehlis skipCall |= validate_and_update_draw_state(dev_data, pCB, false, VK_PIPELINE_BIND_POINT_COMPUTE); 69107a3985a8a9d255dcca9f5992ca2262c7e5df41c6Tobin Ehlis skipCall |= markStoreImagesAndBuffersAsWritten(dev_data, pCB); 69115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_DISPATCHINDIRECT, "vkCmdDispatchIndirect()"); 69125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdDispatchIndirect"); 69135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6914b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6915e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdDispatchIndirect(commandBuffer, buffer, offset); 69175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 691989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBuffer(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, VkBuffer dstBuffer, 692089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferCopy *pRegions) { 6921e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 69225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 6923b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 6924593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 6925593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 6926593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBuffer"); 6927593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 6928593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6929593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBuffer"); 6930593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that SRC & DST buffers have correct usage flags set 6931593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, 6932593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 6933593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 6934593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyBuffer()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 693572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 693672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 6937593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis std::function<bool()> function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBuffer()"); }; 693872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6939593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 6940593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 6941e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 69425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 694372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 6944593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 6945593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFER, "vkCmdCopyBuffer()"); 6946593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBuffer"); 69475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 6948b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 6949e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 69505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBuffer(commandBuffer, srcBuffer, dstBuffer, regionCount, pRegions); 69515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6953e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifySourceImageLayout(VkCommandBuffer cmdBuffer, VkImage srcImage, VkImageSubresourceLayers subLayers, 6954e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout srcImageLayout) { 6955e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 69565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 69585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 69595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 69605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 69615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 69625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 69635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, srcImage, sub, node)) { 696408682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, srcImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(srcImageLayout, srcImageLayout)); 69655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 69665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != srcImageLayout) { 69685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Improve log message in the next pass 69695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 69705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 69715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose source layout is %s " 69725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "and doesn't match the current layout %s.", 69735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout), string_VkImageLayout(node.layout)); 69745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout != VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL) { 69775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (srcImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 69785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 69795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 69805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 69815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input image should be TRANSFER_SRC_OPTIMAL instead of GENERAL."); 69825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 69835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 69845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for input image is %s but can only be " 69855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_SRC_OPTIMAL or GENERAL.", 69865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(srcImageLayout)); 69875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 69895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 69905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 69915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 6992e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyDestImageLayout(VkCommandBuffer cmdBuffer, VkImage destImage, VkImageSubresourceLayers subLayers, 6993e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkImageLayout destImageLayout) { 6994e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 69955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 69965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 69975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 69985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < subLayers.layerCount; ++i) { 69995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = i + subLayers.baseArrayLayer; 70005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subLayers.aspectMask, subLayers.mipLevel, layer}; 70015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 70025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, destImage, sub, node)) { 700308682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, destImage, sub, IMAGE_CMD_BUF_LAYOUT_NODE(destImageLayout, destImageLayout)); 70045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 70055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (node.layout != destImageLayout) { 70075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 70085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 70095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot copy from an image whose dest layout is %s and " 70105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "doesn't match the current layout %s.", 70115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout), string_VkImageLayout(node.layout)); 70125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout != VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL) { 70155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (destImageLayout == VK_IMAGE_LAYOUT_GENERAL) { 70165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // LAYOUT_GENERAL is allowed, but may not be performance optimal, flag as perf warning. 70175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 70185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 70195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for output image should be TRANSFER_DST_OPTIMAL instead of GENERAL."); 70205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 70215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 70225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Layout for output image is %s but can only be " 70235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "TRANSFER_DST_OPTIMAL or GENERAL.", 70245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(destImageLayout)); 70255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 70285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 703089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 703189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 703289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageCopy *pRegions) { 7033e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7035b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7036593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 70375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7038593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7039593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImage"); 7040593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7041593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7042593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImage"); 7043593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7044593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7045593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7046593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdCopyImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7047593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 704872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7049e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7050593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImage()", srcImage); 7051593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7052593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7053593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7054593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7055e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 705772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7058593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7059593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGE, "vkCmdCopyImage()"); 7060593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImage"); 70615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 70625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].srcSubresource, srcImageLayout); 70635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].dstSubresource, dstImageLayout); 70645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 70655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7066b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7067e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 70685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 70695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 70705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 70715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 707289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 707389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBlitImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 707489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageBlit *pRegions, VkFilter filter) { 7075e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 70765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7077b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7078593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 70795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that src & dst images have correct usage flags set 7080593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7081593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdBlitImage"); 7082593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7083593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7084593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdBlitImage"); 7085593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, 7086593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7087593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, 7088593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "vkCmdBlitImage()", "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 7089593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7090593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 709172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7092e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7093593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdBlitImage()", srcImage); 7094593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7095593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7096593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7097593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7098e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 70995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 710072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7101593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7102593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_BLITIMAGE, "vkCmdBlitImage()"); 7103593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdBlitImage"); 71045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7105b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7106e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBlitImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 71085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions, filter); 71095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 711189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyBufferToImage(VkCommandBuffer commandBuffer, VkBuffer srcBuffer, 711289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImage dstImage, VkImageLayout dstImageLayout, 711389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7114e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7116b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7117593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory dst_mem, src_mem; 7118593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyBufferToImage"); 7120593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7121593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)srcBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &src_mem); 7122593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyBufferToImage"); 7123593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that src buff & dst image have correct usage flags set 7124593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, srcBuffer, VK_BUFFER_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyBufferToImage()", 7125593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_SRC_BIT"); 7126593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, dstImage, VK_IMAGE_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyBufferToImage()", 7127593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_DST_BIT"); 712872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 712972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7130e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7131593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7132e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 713472d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7135593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyBufferToImage()"); }; 713672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7137593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7138593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYBUFFERTOIMAGE, "vkCmdCopyBufferToImage()"); 7139593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyBufferToImage"); 71405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 71415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifyDestImageLayout(commandBuffer, dstImage, pRegions[i].imageSubresource, dstImageLayout); 71425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7145e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyBufferToImage(commandBuffer, srcBuffer, dstImage, dstImageLayout, regionCount, 71475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 71485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 715089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdCopyImageToBuffer(VkCommandBuffer commandBuffer, VkImage srcImage, 715189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout srcImageLayout, VkBuffer dstBuffer, 715289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t regionCount, const VkBufferImageCopy *pRegions) { 7153e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7155b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7156593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7157593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7158593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdCopyImageToBuffer"); 7159593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7160593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &dst_mem); 7161593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdCopyImageToBuffer"); 7162593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff & src image have correct usage flags set 7163593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_image_usage_flags(dev_data, srcImage, VK_IMAGE_USAGE_TRANSFER_SRC_BIT, true, "vkCmdCopyImageToBuffer()", 7164593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_IMAGE_USAGE_TRANSFER_SRC_BIT"); 7165593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdCopyImageToBuffer()", 7166593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7167593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 716872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 716972d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7170e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7171593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdCopyImageToBuffer()", srcImage); 7172e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves }; 717372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7174593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7175593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true); 7176e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 71775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 717872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7179593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7180593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_COPYIMAGETOBUFFER, "vkCmdCopyImageToBuffer()"); 7181593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyImageToBuffer"); 71825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < regionCount; ++i) { 71835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= VerifySourceImageLayout(commandBuffer, srcImage, pRegions[i].imageSubresource, srcImageLayout); 71845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 71855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7186b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7187e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 71885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyImageToBuffer(commandBuffer, srcImage, srcImageLayout, dstBuffer, regionCount, 71895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRegions); 71905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 71915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 719289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdUpdateBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, 719389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDeviceSize dstOffset, VkDeviceSize dataSize, const uint32_t *pData) { 7194e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 71955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7196b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 71975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 71985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 71990a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7200593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdUpdateBuffer"); 7201593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7202593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdUpdateBuffer()", 7203593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7204593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7205593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 720672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7207e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7209e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 721172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7212593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7213593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_UPDATEBUFFER, "vkCmdUpdateBuffer()"); 7214593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyUpdateBuffer"); 72155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7216b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7217e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdUpdateBuffer(commandBuffer, dstBuffer, dstOffset, dataSize, pData); 72195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 722189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 722289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdFillBuffer(VkCommandBuffer commandBuffer, VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize size, uint32_t data) { 7223e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7225b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 72275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = 72280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 7229593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdFillBuffer"); 7230593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis // Validate that dst buff has correct usage flags set 7231593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, "vkCmdFillBuffer()", 7232593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 7233593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7234593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 723572d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7236e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 72375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 7238e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 72395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 724072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7241593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7242593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_FILLBUFFER, "vkCmdFillBuffer()"); 7243593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdCopyFillBuffer"); 72445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7245b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7246e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 72475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdFillBuffer(commandBuffer, dstBuffer, dstOffset, size, data); 72485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 72495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 725089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearAttachments(VkCommandBuffer commandBuffer, uint32_t attachmentCount, 725189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearAttachment *pAttachments, uint32_t rectCount, 725289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearRect *pRects) { 7253e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 72545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7255b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 72565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 72575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 72585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_CLEARATTACHMENTS, "vkCmdClearAttachments()"); 72595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn if this is issued prior to Draw Cmd and clearing the entire attachment 72605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!hasDrawCmd(pCB) && (pCB->activeRenderPassBeginInfo.renderArea.extent.width == pRects[0].rect.extent.width) && 72615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pCB->activeRenderPassBeginInfo.renderArea.extent.height == pRects[0].rect.extent.height)) { 72625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : commandBuffer should be srcObj 72635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // There are times where app needs to use ClearAttachments (generally when reusing a buffer inside of a render pass) 72645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Can we make this warning more specific? I'd like to avoid triggering this test if we can tell it's a use that must 72655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // call CmdClearAttachments 72665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Otherwise this seems more like a performance warning. 72675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 72685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, 0, DRAWSTATE_CLEAR_CMD_BEFORE_DRAW, "DS", 72695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() issued on CB object 0x%" PRIxLEAST64 " prior to any Draw Cmds." 72705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " It is recommended you use RenderPass LOAD_OP_CLEAR on Attachments prior to any Draw.", 72715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(commandBuffer)); 72725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdClearAttachments"); 72745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that attachment is in reference list of active subpass 72775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 7278ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes const VkRenderPassCreateInfo *pRPCI = pCB->activeRenderPass->pCreateInfo; 72795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription *pSD = &pRPCI->pSubpasses[pCB->activeSubpass]; 72805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 72815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t attachment_idx = 0; attachment_idx < attachmentCount; attachment_idx++) { 72825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkClearAttachment *attachment = &pAttachments[attachment_idx]; 72835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) { 7284e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool found = false; 72855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pSD->colorAttachmentCount; i++) { 72865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment->colorAttachment == pSD->pColorAttachments[i].attachment) { 7287e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves found = true; 72885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 72895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7291e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!found) { 72925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 72935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 72945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 72955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d not found in attachment reference array of active subpass %d", 72965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, pCB->activeSubpass); 72975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 72985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (attachment->aspectMask & (VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT)) { 72995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSD->pDepthStencilAttachment || // Says no DS will be used in active subpass 73005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment->attachment == 73015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ATTACHMENT_UNUSED)) { // Says no DS will be used in active subpass 73025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 73035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 73045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 73055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)commandBuffer, __LINE__, DRAWSTATE_MISSING_ATTACHMENT_REFERENCE, "DS", 73065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdClearAttachments() attachment index %d does not match depthStencilAttachment.attachment (%d) found " 73075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "in active subpass %d", 73085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment->colorAttachment, 73095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (pSD->pDepthStencilAttachment) ? pSD->pDepthStencilAttachment->attachment : VK_ATTACHMENT_UNUSED, 73105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass); 73115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 73145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7315b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7316e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearAttachments(commandBuffer, attachmentCount, pAttachments, rectCount, pRects); 73185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 732089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdClearColorImage(VkCommandBuffer commandBuffer, VkImage image, 732189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout imageLayout, const VkClearColorValue *pColor, 732289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t rangeCount, const VkImageSubresourceRange *pRanges) { 7323e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7325b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 73275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73280a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7329593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearColorImage"); 7330593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 733172d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7332e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7334e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 733672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7337593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7338593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARCOLORIMAGE, "vkCmdClearColorImage()"); 7339593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearColorImage"); 73405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7341b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7342e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearColorImage(commandBuffer, image, imageLayout, pColor, rangeCount, pRanges); 73445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 734689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 734789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdClearDepthStencilImage(VkCommandBuffer commandBuffer, VkImage image, VkImageLayout imageLayout, 734889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkClearDepthStencilValue *pDepthStencil, uint32_t rangeCount, 734989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkImageSubresourceRange *pRanges) { 7350e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7352b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 73535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO : Verify memory is in VK_IMAGE_STATE_CLEAR state 73545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 73550a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = get_mem_binding_from_object(dev_data, (uint64_t)image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 7356593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdClearDepthStencilImage"); 7357593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 735872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7359e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 73605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true, image); 7361e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 736372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7364593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7365593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_CLEARDEPTHSTENCILIMAGE, "vkCmdClearDepthStencilImage()"); 7366593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdClearDepthStencilImage"); 73675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7368b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7369e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 73705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdClearDepthStencilImage(commandBuffer, image, imageLayout, pDepthStencil, rangeCount, 73715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRanges); 73725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 73735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 737489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 737589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResolveImage(VkCommandBuffer commandBuffer, VkImage srcImage, VkImageLayout srcImageLayout, VkImage dstImage, 737689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkImageLayout dstImageLayout, uint32_t regionCount, const VkImageResolve *pRegions) { 7377e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 73785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7379b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 7380593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis VkDeviceMemory src_mem, dst_mem; 7381593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall = get_mem_binding_from_object(dev_data, (uint64_t)srcImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &src_mem); 7382593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, src_mem, "vkCmdResolveImage"); 7383593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7384593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= get_mem_binding_from_object(dev_data, (uint64_t)dstImage, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &dst_mem); 7385593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, dst_mem, "vkCmdResolveImage"); 738672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 738772d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 7388e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 7389593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis return validate_memory_is_valid(dev_data, src_mem, "vkCmdResolveImage()", srcImage); 7390593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis }; 7391593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis cb_data->second->validate_functions.push_back(function); 7392593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis function = [=]() { 7393593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis set_memory_valid(dev_data, dst_mem, true, dstImage); 7394e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 73955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 739672d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 7397593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis 7398593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= addCmd(dev_data, cb_data->second, CMD_RESOLVEIMAGE, "vkCmdResolveImage()"); 7399593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis skipCall |= insideRenderPass(dev_data, cb_data->second, "vkCmdResolveImage"); 74005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7401b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7402e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResolveImage(commandBuffer, srcImage, srcImageLayout, dstImage, dstImageLayout, 74045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis regionCount, pRegions); 74055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7407b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentinebool setEventStageMask(VkQueue queue, VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7408b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7409b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7410b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (pCB) { 7411b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventToStageMap[event] = stageMask; 7412b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7413b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7414b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data != dev_data->queueMap.end()) { 7415b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine queue_data->second.eventToStageMap[event] = stageMask; 7416b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7417b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 7418b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7419b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 742089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 742189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdSetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7422e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7424b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_SETEVENT, "vkCmdSetEvent()"); 74285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdSetEvent"); 74295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7430c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7431c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7432c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7433b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7434b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, stageMask); 7435b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 74365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7437b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7438e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdSetEvent(commandBuffer, event, stageMask); 74405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 744289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 744389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetEvent(VkCommandBuffer commandBuffer, VkEvent event, VkPipelineStageFlags stageMask) { 7444e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 74455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7446b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 74475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 74485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 74495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETEVENT, "vkCmdResetEvent()"); 74505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdResetEvent"); 74515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(event); 7452c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (!pCB->waitedEvents.count(event)) { 7453c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->writeEventsBeforeWait.push_back(event); 7454c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine } 7455b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 7456b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::bind(setEventStageMask, std::placeholders::_1, commandBuffer, event, VkPipelineStageFlags(0)); 7457b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 74585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7459b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7460e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 74615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetEvent(commandBuffer, event, stageMask); 74625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 74635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7464e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool TransitionImageLayouts(VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7465e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImgMemBarriers) { 74665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 74675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 7468e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 74695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t levelCount = 0; 74705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layerCount = 0; 74715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memBarrierCount; ++i) { 74735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImgMemBarriers[i]; 74745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 74755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 74765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where 74775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // possible 74785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ResolveRemainingLevelsLayers(dev_data, &levelCount, &layerCount, mem_barrier->subresourceRange, mem_barrier->image); 74795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 74805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < levelCount; j++) { 74815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = mem_barrier->subresourceRange.baseMipLevel + j; 74825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < layerCount; k++) { 74835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = mem_barrier->subresourceRange.baseArrayLayer + k; 74845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {mem_barrier->subresourceRange.aspectMask, level, layer}; 74855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 74865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, mem_barrier->image, sub, node)) { 748708682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine SetLayout(pCB, mem_barrier->image, sub, 748808682cd3f4809493847b6bdf7605e0a2fede0d56Michael Lentine IMAGE_CMD_BUF_LAYOUT_NODE(mem_barrier->oldLayout, mem_barrier->newLayout)); 74895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 74905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->oldLayout == VK_IMAGE_LAYOUT_UNDEFINED) { 74925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Set memory invalid which is in mem_tracker currently 74935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (node.layout != mem_barrier->oldLayout) { 74945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 74955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "You cannot transition the layout from %s " 74965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "when current layout is %s.", 74975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(mem_barrier->oldLayout), string_VkImageLayout(node.layout)); 74985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 74995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, mem_barrier->image, sub, mem_barrier->newLayout); 75005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 75045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Print readable FlagBits in FlagMask 7507e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic std::string string_VkAccessFlags(VkAccessFlags accessMask) { 75085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string result; 75095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string separator; 75105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask == 0) { 75125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "[None]"; 75135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = "["; 75155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto i = 0; i < 32; i++) { 75165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask & (1 << i)) { 75175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + separator + string_VkAccessFlagBits((VkAccessFlagBits)(1 << i)); 75185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis separator = " | "; 75195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = result + "]"; 75225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 75245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// AccessFlags MUST have 'required_bit' set, and may have one or more of 'optional_bits' set. 75275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// If required_bit is zero, accessMask must have at least one of 'optional_bits' set 75285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// TODO: Add tracking to ensure that at least one barrier has been set for these layout transitions 7529e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBits(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7530e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, VkAccessFlags required_bit, VkAccessFlags optional_bits, 7531e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *type) { 7532e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 75345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((accessMask & required_bit) || (!required_bit && (accessMask & optional_bits))) { 753543986b69242d252623f4ee7278f1ecd07370adc8Chris Forbes if (accessMask & ~(required_bit | optional_bits)) { 75365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use 75375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 75385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7539577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 75405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 75415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!required_bit) { 75446044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must contain at least one of access bits %d " 75465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s when layout is %s, unless the app has previously added a " 75475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "barrier for this transition.", 75485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), optional_bits, 75495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(optional_bits).c_str(), string_VkImageLayout(layout)); 75505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 75515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::string opt_bits; 75525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (optional_bits != 0) { 75535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::stringstream ss; 75545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ss << optional_bits; 75555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis opt_bits = "and may have optional bits " + ss.str() + ' ' + string_VkAccessFlags(optional_bits); 75565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75576044e94c13064f4663b31854951b7d4edf7877b2Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 75585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s AccessMask %d %s must have required access bit %d %s %s when " 75595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "layout is %s, unless the app has previously added a barrier for " 75605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "this transition.", 75615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), required_bit, 75625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkAccessFlags(required_bit).c_str(), opt_bits.c_str(), string_VkImageLayout(layout)); 75635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 75665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 75675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7568e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMaskBitsFromLayouts(const layer_data *my_data, VkCommandBuffer cmdBuffer, const VkAccessFlags &accessMask, 7569e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageLayout &layout, const char *type) { 7570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 75715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis switch (layout) { 75725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL: { 75735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT, 75745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_COLOR_ATTACHMENT_READ_BIT, type); 75755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL: { 75785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT, 75795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT, type); 75805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_DST_OPTIMAL: { 75835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_WRITE_BIT, 0, type); 75845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_PREINITIALIZED: { 75875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_HOST_WRITE_BIT, 0, type); 75885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL: { 75915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 75925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 75935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 75955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL: { 75965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, 0, 75975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_ACCESS_INPUT_ATTACHMENT_READ_BIT | VK_ACCESS_SHADER_READ_BIT, type); 75985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 75995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL: { 76015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= ValidateMaskBits(my_data, cmdBuffer, accessMask, layout, VK_ACCESS_TRANSFER_READ_BIT, 0, type); 76025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_UNDEFINED: { 76055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (accessMask != 0) { 76065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Use section spec 76075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7609577d4588e09a06f957ca76991d5bd7b645261d6dTobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "Additional bits in %s accessMask 0x%X %s are specified when layout is %s.", 76105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis type, accessMask, string_VkAccessFlags(accessMask).c_str(), string_VkImageLayout(layout)); 76115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 76135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis case VK_IMAGE_LAYOUT_GENERAL: 76155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis default: { break; } 76165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 76185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 76195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateBarriers(const char *funcName, VkCommandBuffer cmdBuffer, uint32_t memBarrierCount, 7621e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMemoryBarrier *pMemBarriers, uint32_t bufferBarrierCount, 7622e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkBufferMemoryBarrier *pBufferMemBarriers, uint32_t imageMemBarrierCount, 7623e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkImageMemoryBarrier *pImageMemBarriers) { 7624e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 76255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(cmdBuffer), layer_data_map); 76265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, cmdBuffer); 76275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass && memBarrierCount) { 7628ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!pCB->activeRenderPass->hasSelfDependency[pCB->activeSubpass]) { 76295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Barriers cannot be set during subpass %d " 76315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with no self dependency specified.", 76325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, pCB->activeSubpass); 76335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < imageMemBarrierCount; ++i) { 76365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pImageMemBarriers[i]; 76375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 76385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 76395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t src_q_f_index = mem_barrier->srcQueueFamilyIndex; 76405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t dst_q_f_index = mem_barrier->dstQueueFamilyIndex; 76415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data->second.createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT) { 76425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // srcQueueFamilyIndex and dstQueueFamilyIndex must both 76435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // be VK_QUEUE_FAMILY_IGNORED 76445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) { 76455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 76465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 76475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image Barrier for image 0x%" PRIx64 " was created with sharingMode of " 76485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_SHARING_MODE_CONCURRENT. Src and dst " 76495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " queueFamilyIndices must be VK_QUEUE_FAMILY_IGNORED.", 76505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 76515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 76535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Sharing mode is VK_SHARING_MODE_EXCLUSIVE. srcQueueFamilyIndex and 76545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // dstQueueFamilyIndex must either both be VK_QUEUE_FAMILY_IGNORED, 76555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // or both be a valid queue family 76565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (((src_q_f_index == VK_QUEUE_FAMILY_IGNORED) || (dst_q_f_index == VK_QUEUE_FAMILY_IGNORED)) && 76575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (src_q_f_index != dst_q_f_index)) { 76585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", "%s: Image 0x%" PRIx64 " was created with sharingMode " 76615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE. If one of src- or " 76625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "dstQueueFamilyIndex is VK_QUEUE_FAMILY_IGNORED, both " 76635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "must be.", 76645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image)); 76655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (((src_q_f_index != VK_QUEUE_FAMILY_IGNORED) && (dst_q_f_index != VK_QUEUE_FAMILY_IGNORED)) && 7666b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis ((src_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()) || 7667b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis (dst_q_f_index >= dev_data->phys_dev_properties.queue_family_properties.size()))) { 76685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 76695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 76705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Image 0x%" PRIx64 " was created with sharingMode " 76715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "of VK_SHARING_MODE_EXCLUSIVE, but srcQueueFamilyIndex %d" 76725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis " or dstQueueFamilyIndex %d is greater than " PRINTF_SIZE_T_SPECIFIER 76735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "queueFamilies crated for this device.", 76745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->image), src_q_f_index, 7675b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dst_q_f_index, dev_data->phys_dev_properties.queue_family_properties.size()); 76765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 76805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier) { 76815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->srcAccessMask, mem_barrier->oldLayout, "Source"); 76835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 76845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateMaskBitsFromLayouts(dev_data, cmdBuffer, mem_barrier->dstAccessMask, mem_barrier->newLayout, "Dest"); 76855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->newLayout == VK_IMAGE_LAYOUT_UNDEFINED || mem_barrier->newLayout == VK_IMAGE_LAYOUT_PREINITIALIZED) { 76865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 76875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image Layout cannot be transitioned to UNDEFINED or " 76885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PREINITIALIZED.", 76895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 76905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 76915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageMap.find(mem_barrier->image); 76921d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill VkFormat format = VK_FORMAT_UNDEFINED; 76931d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill uint32_t arrayLayers = 0, mipLevels = 0; 76945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool imageFound = false; 76955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data != dev_data->imageMap.end()) { 76965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = image_data->second.createInfo.format; 76975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = image_data->second.createInfo.arrayLayers; 76985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = image_data->second.createInfo.mipLevels; 76995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dev_data->device_extensions.wsi_enabled) { 77015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto imageswap_data = dev_data->device_extensions.imageToSwapchainMap.find(mem_barrier->image); 77025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageswap_data != dev_data->device_extensions.imageToSwapchainMap.end()) { 77035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(imageswap_data->second); 77045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 77055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis format = swapchain_data->second->createInfo.imageFormat; 77065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers = swapchain_data->second->createInfo.imageArrayLayers; 77075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels = 1; 77085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis imageFound = true; 77095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (imageFound) { 77135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (vk_format_is_depth_and_stencil(format) && 77145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (!(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_DEPTH_BIT) || 77155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis !(mem_barrier->subresourceRange.aspectMask & VK_IMAGE_ASPECT_STENCIL_BIT))) { 77165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Image is a depth and stencil format and thus must " 77185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "have both VK_IMAGE_ASPECT_DEPTH_BIT and " 77195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "VK_IMAGE_ASPECT_STENCIL_BIT set.", 77205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName); 77215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7722f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int layerCount = (mem_barrier->subresourceRange.layerCount == VK_REMAINING_ARRAY_LAYERS) 7723f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7724f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.layerCount; 7725f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseArrayLayer + layerCount) > arrayLayers) { 77265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the " 77285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "baseArrayLayer (%d) and layerCount (%d) be less " 77295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than or equal to the total number of layers (%d).", 77305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseArrayLayer, mem_barrier->subresourceRange.layerCount, 77315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis arrayLayers); 77325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7733f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine int levelCount = (mem_barrier->subresourceRange.levelCount == VK_REMAINING_MIP_LEVELS) 7734f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine ? 1 7735f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine : mem_barrier->subresourceRange.levelCount; 7736f0d091deca3d4b90e1f31d75e062684dca160ad1Michael Lentine if ((mem_barrier->subresourceRange.baseMipLevel + levelCount) > mipLevels) { 77375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Subresource must have the sum of the baseMipLevel " 77395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(%d) and levelCount (%d) be less than or equal to " 77405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "the total number of levels (%d).", 77415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, mem_barrier->subresourceRange.baseMipLevel, mem_barrier->subresourceRange.levelCount, 77425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis mipLevels); 77435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < bufferBarrierCount; ++i) { 77485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_barrier = &pBufferMemBarriers[i]; 77495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->activeRenderPass) { 77505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 77515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barriers cannot be used during a render pass.", funcName); 77535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!mem_barrier) 77555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 77565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate buffer barrier queue family indices 77585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((mem_barrier->srcQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7759b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->srcQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size()) || 77605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (mem_barrier->dstQueueFamilyIndex != VK_QUEUE_FAMILY_IGNORED && 7761b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis mem_barrier->dstQueueFamilyIndex >= dev_data->phys_dev_properties.queue_family_properties.size())) { 77625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 77635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_QUEUE_INDEX, "DS", 77645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Buffer Barrier 0x%" PRIx64 " has QueueFamilyIndex greater " 77655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "than the number of QueueFamilies (" PRINTF_SIZE_T_SPECIFIER ") for this device.", 77665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 7767b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis dev_data->phys_dev_properties.queue_family_properties.size()); 77685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto buffer_data = dev_data->bufferMap.find(mem_barrier->buffer); 77715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (buffer_data != dev_data->bufferMap.end()) { 7772672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz VkDeviceSize buffer_size = (buffer_data->second.createInfo.sType == VK_STRUCTURE_TYPE_BUFFER_CREATE_INFO) 7773672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz ? buffer_data->second.createInfo.size 7774672a7ee979486eaec10f96063f0455e8c2a02595Karl Schultz : 0; 77755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_barrier->offset >= buffer_size) { 777694c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 777794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 777894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis DRAWSTATE_INVALID_BARRIER, "DS", 7779414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " which is not less than total size 0x%" PRIx64 ".", 778094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 778194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(buffer_size)); 77825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (mem_barrier->size != VK_WHOLE_SIZE && (mem_barrier->offset + mem_barrier->size > buffer_size)) { 778394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skip_call |= log_msg( 778494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7785414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_BARRIER, "DS", "%s: Buffer Barrier 0x%" PRIx64 " has offset 0x%" PRIx64 " and size 0x%" PRIx64 7786414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " whose sum is greater than total size 0x%" PRIx64 ".", 778794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis funcName, reinterpret_cast<const uint64_t &>(mem_barrier->buffer), 778894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(mem_barrier->offset), reinterpret_cast<const uint64_t &>(mem_barrier->size), 778994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(buffer_size)); 77905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 77935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 77945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 77955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 77962ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbesbool validateEventStageMask(VkQueue queue, GLOBAL_CB_NODE *pCB, uint32_t eventCount, size_t firstEventIndex, VkPipelineStageFlags sourceStageMask) { 7797b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine bool skip_call = false; 7798b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine VkPipelineStageFlags stageMask = 0; 7799b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 7800b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine for (uint32_t i = 0; i < eventCount; ++i) { 78012ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event = pCB->events[firstEventIndex + i]; 7802b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine auto queue_data = dev_data->queueMap.find(queue); 7803b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (queue_data == dev_data->queueMap.end()) 7804b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return false; 78052ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto event_data = queue_data->second.eventToStageMap.find(event); 7806b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (event_data != queue_data->second.eventToStageMap.end()) { 7807b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= event_data->second; 7808b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 78092ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto global_event_data = dev_data->eventMap.find(event); 7810b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine if (global_event_data == dev_data->eventMap.end()) { 7811b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 781227c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_INVALID_EVENT, "DS", 781327c3e0dda9e30d1d334728bbd373e8d7011257d4Chris Forbes "Event 0x%" PRIx64 " cannot be waited on if it has never been set.", 78142ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes reinterpret_cast<const uint64_t &>(event)); 7815b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } else { 7816b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine stageMask |= global_event_data->second.stageMask; 7817b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7818b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7819b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7820c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // TODO: Need to validate that host_bit is only set if set event is called 7821c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine // but set event can be called at any time. 7822c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (sourceStageMask != stageMask && sourceStageMask != (stageMask | VK_PIPELINE_STAGE_HOST_BIT)) { 7823c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7824c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine DRAWSTATE_INVALID_EVENT, "DS", "Submitting cmdbuffer with call to VkCmdWaitEvents " 7825c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "using srcStageMask 0x%x which must be the bitwise " 7826c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "OR of the stageMask parameters used in calls to " 7827c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "vkCmdSetEvent and VK_PIPELINE_STAGE_HOST_BIT if " 7828c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine "used with vkSetEvent but instead is 0x%x.", 7829c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine sourceStageMask, stageMask); 7830b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine } 7831b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine return skip_call; 7832b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine} 7833b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine 783489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 783589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWaitEvents(VkCommandBuffer commandBuffer, uint32_t eventCount, const VkEvent *pEvents, VkPipelineStageFlags sourceStageMask, 783689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkPipelineStageFlags dstStageMask, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 783789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 783889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7839e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7841b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 78425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78442ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes auto firstEventIndex = pCB->events.size(); 78455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < eventCount; ++i) { 7846c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine pCB->waitedEvents.insert(pEvents[i]); 78475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->events.push_back(pEvents[i]); 78485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7849b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine std::function<bool(VkQueue)> eventUpdate = 78502ab14387df9b890fe4b13494ea249dd03cf898d2Chris Forbes std::bind(validateEventStageMask, std::placeholders::_1, pCB, eventCount, firstEventIndex, sourceStageMask); 7851b4cc521cc1250cec2a064e22a4d840f1ab42370dMichael Lentine pCB->eventUpdates.push_back(eventUpdate); 78525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 78535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WAITEVENTS, "vkCmdWaitEvents()"); 78545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 78555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWaitEvents()"); 78565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 78575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 78585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdWaitEvents", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 78605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 78615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7862b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7863e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWaitEvents(commandBuffer, eventCount, pEvents, sourceStageMask, dstStageMask, 78655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 78665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 78675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 786989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 787089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdPipelineBarrier(VkCommandBuffer commandBuffer, VkPipelineStageFlags srcStageMask, VkPipelineStageFlags dstStageMask, 787189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDependencyFlags dependencyFlags, uint32_t memoryBarrierCount, const VkMemoryBarrier *pMemoryBarriers, 787289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t bufferMemoryBarrierCount, const VkBufferMemoryBarrier *pBufferMemoryBarriers, 787389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu uint32_t imageMemoryBarrierCount, const VkImageMemoryBarrier *pImageMemoryBarriers) { 7874e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 78755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7876b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 78775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 78785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 78795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PIPELINEBARRIER, "vkCmdPipelineBarrier()"); 78805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= TransitionImageLayouts(commandBuffer, imageMemoryBarrierCount, pImageMemoryBarriers); 78815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 78825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ValidateBarriers("vkCmdPipelineBarrier", commandBuffer, memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 78835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 78845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7885b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7886e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 78875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPipelineBarrier(commandBuffer, srcStageMask, dstStageMask, dependencyFlags, 78885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memoryBarrierCount, pMemoryBarriers, bufferMemoryBarrierCount, 78895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pBufferMemoryBarriers, imageMemoryBarrierCount, pImageMemoryBarriers); 78905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 78915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7892d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool setQueryState(VkQueue queue, VkCommandBuffer commandBuffer, QueryObject object, bool value) { 7893d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7894d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 7895d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (pCB) { 7896d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryToStateMap[object] = value; 7897d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7898d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 7899d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data != dev_data->queueMap.end()) { 7900d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine queue_data->second.queryToStateMap[object] = value; 7901d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7902d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 7903d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 7904d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 790589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 790689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot, VkFlags flags) { 7907e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7909b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.insert(query); 79145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->startedQueries.count(query)) { 79155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->startedQueries.insert(query); 79165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINQUERY, "vkCmdBeginQuery()"); 79185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7919b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7920e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginQuery(commandBuffer, queryPool, slot, flags); 79225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 792489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndQuery(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t slot) { 7925e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7927b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 79315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCB->activeQueries.count(query)) { 79325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 79335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 7934414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_QUERY, "DS", "Ending a query before it was started: queryPool 0x%" PRIx64 ", index %d", 79355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(queryPool), slot); 79365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeQueries.erase(query); 79385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7939c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 7940d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 79415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 79425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_ENDQUERY, "VkCmdEndQuery()"); 79435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdEndQuery()"); 79455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7947b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7948e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndQuery(commandBuffer, queryPool, slot); 79505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 795289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 795389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdResetQueryPool(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount) { 7954e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 79555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 7956b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 79575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 79585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 79595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < queryCount; i++) { 79605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, firstQuery + i}; 79615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->waitedEventsBeforeQueryReset[query] = pCB->waitedEvents; 7962c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, false); 7963d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 79645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 79665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_RESETQUERYPOOL, "VkCmdResetQueryPool()"); 79675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 79685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdResetQueryPool()"); 79695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 79705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdQueryPool"); 79715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 7972b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 7973e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 79745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdResetQueryPool(commandBuffer, queryPool, firstQuery, queryCount); 79755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 79765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 7977d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentinebool validateQuery(VkQueue queue, GLOBAL_CB_NODE *pCB, VkQueryPool queryPool, uint32_t queryCount, uint32_t firstQuery) { 7978d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool skip_call = false; 7979d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine layer_data *dev_data = get_my_data_ptr(get_dispatch_key(pCB->commandBuffer), layer_data_map); 7980d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto queue_data = dev_data->queueMap.find(queue); 7981d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (queue_data == dev_data->queueMap.end()) 7982d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return false; 7983d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine for (uint32_t i = 0; i < queryCount; i++) { 7984d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine QueryObject query = {queryPool, firstQuery + i}; 7985d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto query_data = queue_data->second.queryToStateMap.find(query); 7986d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine bool fail = false; 7987d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (query_data != queue_data->second.queryToStateMap.end()) { 7988d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!query_data->second) { 7989d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 7990d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7991d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 7992d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine auto global_query_data = dev_data->queryToStateMap.find(query); 7993d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (global_query_data != dev_data->queryToStateMap.end()) { 7994d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (!global_query_data->second) { 7995d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 7996d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 7997d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } else { 7998d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine fail = true; 7999d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8000d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8001d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine if (fail) { 8002d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8003d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine DRAWSTATE_INVALID_QUERY, "DS", 8004d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine "Requesting a copy from query to buffer with invalid query: queryPool 0x%" PRIx64 ", index %d", 8005d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine reinterpret_cast<uint64_t &>(queryPool), firstQuery + i); 8006d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8007d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine } 8008d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine return skip_call; 8009d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine} 8010d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine 801189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 801289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdCopyQueryPoolResults(VkCommandBuffer commandBuffer, VkQueryPool queryPool, uint32_t firstQuery, uint32_t queryCount, 801389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkBuffer dstBuffer, VkDeviceSize dstOffset, VkDeviceSize stride, VkQueryResultFlags flags) { 8014e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 80155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8016b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 801803b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 80195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceMemory mem; 802072d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis auto cb_data = dev_data->commandBufferMap.find(commandBuffer); 80215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 80220a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)dstBuffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, &mem); 802372d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis if (cb_data != dev_data->commandBufferMap.end()) { 8024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::function<bool()> function = [=]() { 80255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis set_memory_valid(dev_data, mem, true); 8026e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 80275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis }; 802872d66f0c1639cbaca92459498452d06db32d7aefTobin Ehlis cb_data->second->validate_functions.push_back(function); 80295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= update_cmd_buf_and_mem_references(dev_data, commandBuffer, mem, "vkCmdCopyQueryPoolResults"); 80315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Validate that DST buffer has correct usage flags set 80320a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall |= validate_buffer_usage_flags(dev_data, dstBuffer, VK_BUFFER_USAGE_TRANSFER_DST_BIT, true, 80335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdCopyQueryPoolResults()", "VK_BUFFER_USAGE_TRANSFER_DST_BIT"); 80345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 80355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 8036d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::function<bool(VkQueue)> queryUpdate = 8037d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine std::bind(validateQuery, std::placeholders::_1, pCB, queryPool, queryCount, firstQuery); 8038d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 80395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_COPYQUERYPOOLRESULTS, "vkCmdCopyQueryPoolResults()"); 80415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdCopyQueryPoolResults()"); 80435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= insideRenderPass(dev_data, pCB, "vkCmdCopyQueryPoolResults"); 80455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8046b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8047e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 80485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdCopyQueryPoolResults(commandBuffer, queryPool, firstQuery, queryCount, dstBuffer, 80495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dstOffset, stride, flags); 80505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 80515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 805289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdPushConstants(VkCommandBuffer commandBuffer, VkPipelineLayout layout, 805389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderStageFlags stageFlags, uint32_t offset, uint32_t size, 805489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const void *pValues) { 80555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 80565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8057b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 80585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 80595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 80605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 80615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_PUSHCONSTANTS, "vkCmdPushConstants()"); 80625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 80635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdPushConstants()"); 80645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 80669e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= validatePushConstantRange(dev_data, offset, size, "vkCmdPushConstants()"); 80679e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz if (0 == stageFlags) { 80689e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 80699e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() call has no stageFlags set."); 80709e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 80719e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz 8072a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Check if push constant update is within any of the ranges with the same stage flags specified in pipeline layout. 80734a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes auto pipeline_layout = getPipelineLayout(dev_data, layout); 80744a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes if (!pipeline_layout) { 80759e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8076a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", "vkCmdPushConstants() Pipeline Layout 0x%" PRIx64 " not found.", 80779e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz (uint64_t)layout); 80789e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } else { 8079a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce adjacent/overlapping pipeline ranges before checking to see if incoming range is 8080a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // contained in the pipeline ranges. 8081a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Build a {start, end} span list for ranges with matching stage flags. 80824a45a42023b281f55953222c1a6c3e80f50e5f2aChris Forbes const auto &ranges = pipeline_layout->pushConstantRanges; 8083a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct span { 8084a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t start; 8085a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz uint32_t end; 8086a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz }; 8087a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span> spans; 8088a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.reserve(ranges.size()); 8089a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (const auto &iter : ranges) { 8090a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (iter.stageFlags == stageFlags) { 8091a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz spans.push_back({iter.offset, iter.offset + iter.size}); 80929e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 80939e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 8094a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (spans.size() == 0) { 8095a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There were no ranges that matched the stageFlags. 8096a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8097a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8098a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() stageFlags = 0x%" PRIx32 " do not match " 8099a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "the stageFlags in any of the ranges in pipeline layout 0x%" PRIx64 ".", 8100a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz (uint32_t)stageFlags, (uint64_t)layout); 8101a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8102a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Sort span list by start value. 8103a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz struct comparer { 8104a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool operator()(struct span i, struct span j) { return i.start < j.start; } 8105a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } my_comparer; 8106a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::sort(spans.begin(), spans.end(), my_comparer); 8107a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8108a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Examine two spans at a time. 8109a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator current = spans.begin(); 8110a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz std::vector<span>::iterator next = current + 1; 8111a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz while (next != spans.end()) { 8112a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (current->end < next->start) { 8113a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // There is a gap; cannot coalesce. Move to the next two spans. 8114a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++current; 8115a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz ++next; 8116a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } else { 8117a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Coalesce the two spans. The start of the next span 8118a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // is within the current span, so pick the larger of 8119a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // the end values to extend the current span. 8120a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Then delete the next span and set next to the span after it. 8121a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz current->end = max(current->end, next->end); 8122a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz next = spans.erase(next); 8123a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8124a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8125a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz 8126a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz // Now we can check if the incoming range is within any of the spans. 8127a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz bool contained_in_a_range = false; 8128a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz for (uint32_t i = 0; i < spans.size(); ++i) { 8129a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if ((offset >= spans[i].start) && ((uint64_t)offset + (uint64_t)size <= (uint64_t)spans[i].end)) { 8130a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz contained_in_a_range = true; 8131a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz break; 8132a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8133a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 8134a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz if (!contained_in_a_range) { 8135a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8136a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz __LINE__, DRAWSTATE_PUSH_CONSTANTS_ERROR, "DS", 8137a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "vkCmdPushConstants() Push constant range [%d, %d) " 8138a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "with stageFlags = 0x%" PRIx32 " " 8139a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz "not within flag-matching ranges in pipeline layout 0x%" PRIx64 ".", 8140a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz offset, offset + size, (uint32_t)stageFlags, (uint64_t)layout); 8141a95cb74c9d0947ab3821b15e1289755286ea78eeKarl Schultz } 81429e24d8153ab63bc3ac08b5a1517c203930b5de91Karl Schultz } 81435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8144b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 81455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 81465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdPushConstants(commandBuffer, layout, stageFlags, offset, size, pValues); 81475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 814989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 815089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdWriteTimestamp(VkCommandBuffer commandBuffer, VkPipelineStageFlagBits pipelineStage, VkQueryPool queryPool, uint32_t slot) { 8151e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 81525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8153b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 81545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 81555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 81565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis QueryObject query = {queryPool, slot}; 8157c2ec509029604290e981885108c06a9b7de565c1Karl Schultz std::function<bool(VkQueue)> queryUpdate = std::bind(setQueryState, std::placeholders::_1, commandBuffer, query, true); 8158d78749ee260a3ce7244cbfd97c11aacc2250f8d3Michael Lentine pCB->queryUpdates.push_back(queryUpdate); 81595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->state == CB_RECORDING) { 81605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_WRITETIMESTAMP, "vkCmdWriteTimestamp()"); 81615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 81625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= report_error_no_cb_begin(dev_data, commandBuffer, "vkCmdWriteTimestamp()"); 81635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8165b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8166e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 81675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdWriteTimestamp(commandBuffer, pipelineStage, queryPool, slot); 81685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 81695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 817089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateFramebuffer(VkDevice device, const VkFramebufferCreateInfo *pCreateInfo, 817189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 817289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkFramebuffer *pFramebuffer) { 81735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 81745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateFramebuffer(device, pCreateInfo, pAllocator, pFramebuffer); 81755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 81765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 8177b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8178fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes 8179fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto & fbNode = dev_data->frameBufferMap[*pFramebuffer]; 8180fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo = *pCreateInfo; 81815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 8182fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes auto attachments = new VkImageView[pCreateInfo->attachmentCount]; 8183fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes memcpy(attachments, 8184fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->pAttachments, 8185fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes pCreateInfo->attachmentCount * sizeof(VkImageView)); 8186fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.createInfo.pAttachments = attachments; 81875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 81895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView view = pCreateInfo->pAttachments[i]; 81905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data = dev_data->imageViewMap.find(view); 81915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data == dev_data->imageViewMap.end()) { 81925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 81935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 81945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MT_FB_ATTACHMENT_INFO fb_info; 81950a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(view_data->second.image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 81965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis &fb_info.mem); 81975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fb_info.image = view_data->second.image; 8198fcaf4f848530651450a39dfd7aa6997f5343b04bChris Forbes fbNode.attachments.push_back(fb_info); 81995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8204e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool FindDependency(const int index, const int dependent, const std::vector<DAGNode> &subpass_to_node, 8205e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::unordered_set<uint32_t> &processed_nodes) { 82065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If we have already checked this node we have not found a dependency path so return false. 82075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (processed_nodes.count(index)) 8208e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis processed_nodes.insert(index); 82105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 82115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Look for a dependency path. If one exists return true else recurse on the previous nodes. 82125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (std::find(node.prev.begin(), node.prev.end(), dependent) == node.prev.end()) { 82135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 82145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(elem, dependent, subpass_to_node, processed_nodes)) 8215e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 8218e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8220e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return false; 82215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8223e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckDependencyExists(const layer_data *my_data, const int subpass, const std::vector<uint32_t> &dependent_subpasses, 8224e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const std::vector<DAGNode> &subpass_to_node, bool &skip_call) { 8225e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = true; 82265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through all subpasses that share the same attachment and make sure a dependency exists 82275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < dependent_subpasses.size(); ++k) { 82281d5109d5e0dcc530b27e632e73e1be5e12a28dcdJamie Madill if (static_cast<uint32_t>(subpass) == dependent_subpasses[k]) 82295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 82305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[subpass]; 82315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Check for a specified dependency between the two nodes. If one exists we are done. 82325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto prev_elem = std::find(node.prev.begin(), node.prev.end(), dependent_subpasses[k]); 82335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto next_elem = std::find(node.next.begin(), node.next.end(), dependent_subpasses[k]); 82345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (prev_elem == node.prev.end() && next_elem == node.next.end()) { 82355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If no dependency exits an implicit dependency still might. If so, warn and if not throw an error. 82365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::unordered_set<uint32_t> processed_nodes; 82375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindDependency(subpass, dependent_subpasses[k], subpass_to_node, processed_nodes) || 82385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis FindDependency(dependent_subpasses[k], subpass, subpass_to_node, processed_nodes)) { 82393da84689683bb257cc0f64953966666d19321119Michael Lentine skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 82415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but only an implicit one is specified.", 82425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass, dependent_subpasses[k]); 82435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 82445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 82455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 82465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "A dependency between subpasses %d and %d must exist but one is not specified.", subpass, 82475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependent_subpasses[k]); 8248e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves result = false; 82495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8255e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CheckPreserved(const layer_data *my_data, const VkRenderPassCreateInfo *pCreateInfo, const int index, 8256e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const uint32_t attachment, const std::vector<DAGNode> &subpass_to_node, int depth, bool &skip_call) { 82575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const DAGNode &node = subpass_to_node[index]; 82585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If this node writes to the attachment return true as next nodes need to preserve the attachment. 82595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 82605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 82615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pColorAttachments[j].attachment) 8262e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 82655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (attachment == subpass.pDepthStencilAttachment->attachment) 8266e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves return true; 82675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8268e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool result = false; 82695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through previous nodes and see if any of them write to the attachment. 82705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto elem : node.prev) { 82715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result |= CheckPreserved(my_data, pCreateInfo, elem, attachment, subpass_to_node, depth + 1, skip_call); 82725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment was written to by a previous node than this node needs to preserve it. 82745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result && depth > 0) { 82755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[index]; 8276e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool has_preserved = false; 82775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 82785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pPreserveAttachments[j] == attachment) { 8279e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves has_preserved = true; 82805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis break; 82815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8283e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!has_preserved) { 82845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 82855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 82865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 82875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Attachment %d is used by a later subpass and must be preserved in subpass %d.", attachment, index); 82885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 82905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 82915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlistemplate <class T> bool isRangeOverlapping(T offset1, T size1, T offset2, T size2) { 82945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (((offset1 + size1) > offset2) && ((offset1 + size1) < (offset2 + size2))) || 82955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((offset1 > offset2) && (offset1 < (offset2 + size2))); 82965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 82975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 82985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisbool isRegionOverlapping(VkImageSubresourceRange range1, VkImageSubresourceRange range2) { 82995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return (isRangeOverlapping(range1.baseMipLevel, range1.levelCount, range2.baseMipLevel, range2.levelCount) && 83005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(range1.baseArrayLayer, range1.layerCount, range2.baseArrayLayer, range2.layerCount)); 83015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 83025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8303f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic bool ValidateDependencies(const layer_data *my_data, FRAMEBUFFER_NODE const * framebuffer, 830416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes RENDER_PASS_NODE const * renderPass) { 8305e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8306f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes const VkFramebufferCreateInfo *pFramebufferInfo = &framebuffer->createInfo; 830716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pCreateInfo = renderPass->pCreateInfo; 830816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto const & subpass_to_node = renderPass->subpassToNode; 83095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> output_attachment_to_subpass(pCreateInfo->attachmentCount); 83105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> input_attachment_to_subpass(pCreateInfo->attachmentCount); 83115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<std::vector<uint32_t>> overlapping_attachments(pCreateInfo->attachmentCount); 83125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find overlapping attachments 83135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 83145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = i + 1; j < pCreateInfo->attachmentCount; ++j) { 83155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewi = pFramebufferInfo->pAttachments[i]; 83165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageView viewj = pFramebufferInfo->pAttachments[j]; 83175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (viewi == viewj) { 83185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_i = my_data->imageViewMap.find(viewi); 83235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto view_data_j = my_data->imageViewMap.find(viewj); 83245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i == my_data->imageViewMap.end() || view_data_j == my_data->imageViewMap.end()) { 83255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (view_data_i->second.image == view_data_j->second.image && 83285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRegionOverlapping(view_data_i->second.subresourceRange, view_data_j->second.subresourceRange)) { 83295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_i = my_data->imageMap.find(view_data_i->second.image); 83345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data_j = my_data->imageMap.find(view_data_j->second.image); 83355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i == my_data->imageMap.end() || image_data_j == my_data->imageMap.end()) { 83365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 83375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_data_i->second.mem == image_data_j->second.mem && 83395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis isRangeOverlapping(image_data_i->second.memOffset, image_data_i->second.memSize, image_data_j->second.memOffset, 83405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_data_j->second.memSize)) { 83415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[i].push_back(j); 83425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis overlapping_attachments[j].push_back(i); 83435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < overlapping_attachments.size(); ++i) { 83475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = i; 83485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto other_attachment : overlapping_attachments[i]) { 83495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 83505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 83535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 83545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachment, other_attachment); 83555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pCreateInfo->pAttachments[other_attachment].flags & VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT)) { 83575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 83585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 83595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "Attachment %d aliases attachment %d but doesn't " 83605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set VK_ATTACHMENT_DESCRIPTION_MAY_ALIAS_BIT.", 83615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis other_attachment, attachment); 83625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Find for each attachment the subpasses that use them. 83661c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young unordered_set<uint32_t> attachmentIndices; 83675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 83685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 83691c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.clear(); 83705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 83715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pInputAttachments[j].attachment; 83725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[attachment].push_back(i); 83735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 83745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis input_attachment_to_subpass[overlapping_attachment].push_back(i); 83755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 83785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pColorAttachments[j].attachment; 83795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 83805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 83815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 83825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83831c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachmentIndices.insert(attachment); 83845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 83865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 83875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[attachment].push_back(i); 83885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto overlapping_attachment : overlapping_attachments[attachment]) { 83895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis output_attachment_to_subpass[overlapping_attachment].push_back(i); 83905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 83911c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 83921c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young if (attachmentIndices.count(attachment)) { 83931c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young skip_call |= 83941c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 83951c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young 0, __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 83961c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young "Cannot use same attachment (%u) as both color and depth output in same subpass (%u).", 83971c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young attachment, i); 83981c1ee7bf64fb8cc2ba4b8661baa11dce24b3b23aMark Young } 83995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If there is a dependency needed make sure one exists 84025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an input then all subpasses that output must have a dependency relationship 84055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pInputAttachments[j].attachment; 84075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If the attachment is an output then all subpasses that use the attachment must have a dependency relationship 84105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pColorAttachments[j].attachment; 84125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 84165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t &attachment = subpass.pDepthStencilAttachment->attachment; 84175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, output_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckDependencyExists(my_data, i, input_attachment_to_subpass[attachment], subpass_to_node, skip_call); 84195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Loop through implicit dependencies, if this pass reads make sure the attachment is preserved for all passes after it was 84225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // written. 84235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis CheckPreserved(my_data, pCreateInfo, i, subpass.pInputAttachments[j].attachment, subpass_to_node, 0, skip_call); 84275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 84305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8431be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// ValidateLayoutVsAttachmentDescription is a general function where we can validate various state associated with the 8432be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// VkAttachmentDescription structs that are used by the sub-passes of a renderpass. Initial check is to make sure that 8433be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis// READ_ONLY layout attachments don't have CLEAR as their loadOp. 8434be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlisstatic bool ValidateLayoutVsAttachmentDescription(debug_report_data *report_data, const VkImageLayout first_layout, 8435be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const uint32_t attachment, 8436be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis const VkAttachmentDescription &attachment_description) { 8437be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis bool skip_call = false; 8438be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis // Verify that initial loadOp on READ_ONLY attachments is not CLEAR 8439be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if (attachment_description.loadOp == VK_ATTACHMENT_LOAD_OP_CLEAR) { 8440be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis if ((first_layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) || 8441be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis (first_layout == VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL)) { 8442be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip_call |= 8443be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 8444be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis VkDebugReportObjectTypeEXT(0), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 8445be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis "Cannot clear attachment %d with invalid first layout %s.", attachment, string_VkImageLayout(first_layout)); 8446be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8447be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis } 8448be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis return skip_call; 8449be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis} 84505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateLayouts(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo) { 8452e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip = false; 84535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 84545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 84555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 84565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 84575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL && 84585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass.pInputAttachments[j].layout != VK_IMAGE_LAYOUT_SHADER_READ_ONLY_OPTIMAL) { 84595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pInputAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 84605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 84615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 84625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is GENERAL but should be READ_ONLY_OPTIMAL."); 84645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84654d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for input attachment is %s but can only be READ_ONLY_OPTIMAL or GENERAL.", 84685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pInputAttachments[j].layout)); 84695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8471be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pInputAttachments[j].attachment; 8472be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pInputAttachments[j].layout, attach_index, 8473be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 84745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 84765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout != VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) { 84775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pColorAttachments[j].layout == VK_IMAGE_LAYOUT_GENERAL) { 84785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 84795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 84805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is GENERAL but should be COLOR_ATTACHMENT_OPTIMAL."); 84825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 84834d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 84845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for color attachment is %s but can only be COLOR_ATTACHMENT_OPTIMAL or GENERAL.", 84865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pColorAttachments[j].layout)); 84875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8489be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pColorAttachments[j].attachment; 8490be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pColorAttachments[j].layout, attach_index, 8491be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis pCreateInfo->pAttachments[attach_index]); 84925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 84935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 84945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout != VK_IMAGE_LAYOUT_DEPTH_STENCIL_ATTACHMENT_OPTIMAL) { 84955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass.pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_GENERAL) { 84965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify Valid Use in spec. I believe this is allowed (valid) but may not be optimal performance 84975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= log_msg(my_data->report_data, VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT, 84985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (VkDebugReportObjectTypeEXT)0, 0, __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 84995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is GENERAL but should be DEPTH_STENCIL_ATTACHMENT_OPTIMAL."); 85005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 85015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip |= 85024d23e010bf71b5b276fbf7035c3fb5e8873a64aeMichael Lentine log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 85045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Layout for depth attachment is %s but can only be DEPTH_STENCIL_ATTACHMENT_OPTIMAL or GENERAL.", 85055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(subpass.pDepthStencilAttachment->layout)); 85065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8508be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis auto attach_index = subpass.pDepthStencilAttachment->attachment; 8509be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis skip |= ValidateLayoutVsAttachmentDescription(my_data->report_data, subpass.pDepthStencilAttachment->layout, 8510be45dd763c94dfcb0b52709d8d613848c4c914e1Tobin Ehlis attach_index, pCreateInfo->pAttachments[attach_index]); 85115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip; 85145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool CreatePassDAG(const layer_data *my_data, VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 8517e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves std::vector<DAGNode> &subpass_to_node, std::vector<bool> &has_self_dependency) { 8518e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 85195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 85205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DAGNode &subpass_node = subpass_to_node[i]; 85215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_node.pass = i; 85225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->dependencyCount; ++i) { 85245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkSubpassDependency &dependency = pCreateInfo->pDependencies[i]; 85255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass > dependency.dstSubpass && dependency.srcSubpass != VK_SUBPASS_EXTERNAL && 85265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 85275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", 85295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Depedency graph must be specified such that an earlier pass cannot depend on a later pass."); 85305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == VK_SUBPASS_EXTERNAL && dependency.dstSubpass == VK_SUBPASS_EXTERNAL) { 85315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 85325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "The src and dest subpasses cannot both be external."); 85335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (dependency.srcSubpass == dependency.dstSubpass) { 85345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis has_self_dependency[dependency.srcSubpass] = true; 85355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.dstSubpass != VK_SUBPASS_EXTERNAL) { 85375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.dstSubpass].prev.push_back(dependency.srcSubpass); 85385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dependency.srcSubpass != VK_SUBPASS_EXTERNAL) { 85405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass_to_node[dependency.srcSubpass].next.push_back(dependency.dstSubpass); 85415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 85445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 8545918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes 85465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 854789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateShaderModule(VkDevice device, const VkShaderModuleCreateInfo *pCreateInfo, 854889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 854989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkShaderModule *pShaderModule) { 85505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 8551e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 8552b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8553b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes /* Use SPIRV-Tools validator to try and catch any issues with the module itself */ 8554b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_context ctx = spvContextCreate(SPV_ENV_VULKAN_1_0); 8555b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_const_binary_t binary { pCreateInfo->pCode, pCreateInfo->codeSize / sizeof(uint32_t) }; 8556b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spv_diagnostic diag = nullptr; 8557b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8558b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes auto result = spvValidate(ctx, &binary, &diag); 8559b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes if (result != SPV_SUCCESS) { 8560b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes skip_call |= log_msg(my_data->report_data, 8561b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes result == SPV_WARNING ? VK_DEBUG_REPORT_WARNING_BIT_EXT : VK_DEBUG_REPORT_ERROR_BIT_EXT, 8562b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes VkDebugReportObjectTypeEXT(0), 0, 8563b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes __LINE__, SHADER_CHECKER_INCONSISTENT_SPIRV, "SC", "SPIR-V module not valid: %s", 8564b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes diag && diag->error ? diag->error : "(no error text)"); 85655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8567b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvDiagnosticDestroy(diag); 8568b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes spvContextDestroy(ctx); 8569b1f65702539fd041337fccd493dc6d38dd2a603eChris Forbes 8570e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (skip_call) 85715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return VK_ERROR_VALIDATION_FAILED_EXT; 85725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = my_data->device_dispatch_table->CreateShaderModule(device, pCreateInfo, pAllocator, pShaderModule); 85745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 85755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (res == VK_SUCCESS) { 8576b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 8577918c283ac4f8c604b79abd0c8b5706d2a7352a34Chris Forbes my_data->shaderModuleMap[*pShaderModule] = unique_ptr<shader_module>(new shader_module(pCreateInfo)); 85785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 85805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 85815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 858289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateRenderPass(VkDevice device, const VkRenderPassCreateInfo *pCreateInfo, 858389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 858489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkRenderPass *pRenderPass) { 8585e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 85865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 85875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Create DAG 85885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<bool> has_self_dependency(pCreateInfo->subpassCount); 85895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<DAGNode> subpass_to_node(pCreateInfo->subpassCount); 8590cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes { 8591cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::lock_guard<std::mutex> lock(global_lock); 8592cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes skip_call |= CreatePassDAG(dev_data, device, pCreateInfo, subpass_to_node, has_self_dependency); 8593cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes // Validate 8594cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes skip_call |= ValidateLayouts(dev_data, device, pCreateInfo); 8595cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes if (skip_call) { 8596cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes return VK_ERROR_VALIDATION_FAILED_EXT; 8597cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes } 85985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 85995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateRenderPass(device, pCreateInfo, pAllocator, pRenderPass); 86005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 86015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODOSC : Merge in tracking of renderpass from shader_checker 86025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Shadow create info and store in map 86035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkRenderPassCreateInfo *localRPCI = new VkRenderPassCreateInfo(*pCreateInfo); 86045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pAttachments) { 86055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pAttachments = new VkAttachmentDescription[localRPCI->attachmentCount]; 86065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pAttachments, pCreateInfo->pAttachments, 86075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->attachmentCount * sizeof(VkAttachmentDescription)); 86085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pSubpasses) { 86105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pSubpasses = new VkSubpassDescription[localRPCI->subpassCount]; 86115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pSubpasses, pCreateInfo->pSubpasses, localRPCI->subpassCount * sizeof(VkSubpassDescription)); 86125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < localRPCI->subpassCount; i++) { 86145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkSubpassDescription *subpass = (VkSubpassDescription *)&localRPCI->pSubpasses[i]; 86155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const uint32_t attachmentCount = subpass->inputAttachmentCount + 86165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->colorAttachmentCount * (1 + (subpass->pResolveAttachments ? 1 : 0)) + 86175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ((subpass->pDepthStencilAttachment) ? 1 : 0) + subpass->preserveAttachmentCount; 86185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkAttachmentReference *attachments = new VkAttachmentReference[attachmentCount]; 86195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pInputAttachments, sizeof(attachments[0]) * subpass->inputAttachmentCount); 86215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pInputAttachments = attachments; 86225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->inputAttachmentCount; 86235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pColorAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 86255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pColorAttachments = attachments; 86265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 86275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pResolveAttachments) { 86295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pResolveAttachments, sizeof(attachments[0]) * subpass->colorAttachmentCount); 86305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pResolveAttachments = attachments; 86315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += subpass->colorAttachmentCount; 86325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (subpass->pDepthStencilAttachment) { 86355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pDepthStencilAttachment, sizeof(attachments[0]) * 1); 86365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pDepthStencilAttachment = attachments; 86375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis attachments += 1; 86385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 86405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(attachments, subpass->pPreserveAttachments, sizeof(attachments[0]) * subpass->preserveAttachmentCount); 86415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis subpass->pPreserveAttachments = &attachments->attachment; 86425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 86445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCreateInfo->pDependencies) { 86455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->pDependencies = new VkSubpassDependency[localRPCI->dependencyCount]; 86465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy((void *)localRPCI->pDependencies, pCreateInfo->pDependencies, 86475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis localRPCI->dependencyCount * sizeof(VkSubpassDependency)); 86485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8649cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes 8650cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes auto render_pass = new RENDER_PASS_NODE(localRPCI); 865198cddf7090b5d5dcc382045867753ef703d1c3d3Chris Forbes render_pass->renderPass = *pRenderPass; 8652cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->hasSelfDependency = has_self_dependency; 8653cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->subpassToNode = subpass_to_node; 865487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#if MTMERGESOURCE 865587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // MTMTODO : Merge with code from above to eliminate duplication 865687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->attachmentCount; ++i) { 865787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis VkAttachmentDescription desc = pCreateInfo->pAttachments[i]; 865887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis MT_PASS_ATTACHMENT_INFO pass_info; 865987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.load_op = desc.loadOp; 866087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.store_op = desc.storeOp; 866187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis pass_info.attachment = i; 8662cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachments.push_back(pass_info); 866387e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 866487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis // TODO: Maybe fill list and then copy instead of locking 8665cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::unordered_map<uint32_t, bool> &attachment_first_read = render_pass->attachment_first_read; 866687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis std::unordered_map<uint32_t, VkImageLayout> &attachment_first_layout = 8667cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes render_pass->attachment_first_layout; 866887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t i = 0; i < pCreateInfo->subpassCount; ++i) { 866987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis const VkSubpassDescription &subpass = pCreateInfo->pSubpasses[i]; 8670b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine if (subpass.pipelineBindPoint != VK_PIPELINE_BIND_POINT_GRAPHICS) { 8671b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 8672b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 8673b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine "Pipeline bind point for subpass %d must be VK_PIPELINE_BIND_POINT_GRAPHICS.", i); 8674b5d4c1684e41455cb2da487c808fd72070b564d2Michael Lentine } 86750d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine for (uint32_t j = 0; j < subpass.preserveAttachmentCount; ++j) { 86760d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment = subpass.pPreserveAttachments[j]; 86770d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount) { 86780d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86790d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 86800d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Preserve attachment %d cannot be greater than the total number of attachments %d.", 86810d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 86820d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 86830d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 868487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 86850d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine uint32_t attachment; 86860d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (subpass.pResolveAttachments) { 86870d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pResolveAttachments[j].attachment; 86880d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine if (attachment >= pCreateInfo->attachmentCount && attachment != VK_ATTACHMENT_UNUSED) { 86890d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 86900d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 86910d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 86920d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment, pCreateInfo->attachmentCount); 86930d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine continue; 86940d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 86950d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine } 86960d615f0a5724edac98475366cf3e486dccc1f2d6Michael Lentine attachment = subpass.pColorAttachments[j].attachment; 869724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 869824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 869924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 870024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Color attachment %d cannot be greater than the total number of attachments %d.", 870124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 870224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 870324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 870487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 870587e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 870687e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 870787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pColorAttachments[j].layout)); 870887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 870987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (subpass.pDepthStencilAttachment && subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED) { 871087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis uint32_t attachment = subpass.pDepthStencilAttachment->attachment; 871124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 871224991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 871324991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 871424991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Depth stencil attachment %d cannot be greater than the total number of attachments %d.", 871524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 871624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 871724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 871887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (attachment_first_read.count(attachment)) 871987e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis continue; 872087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_read.insert(std::make_pair(attachment, false)); 872187e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis attachment_first_layout.insert(std::make_pair(attachment, subpass.pDepthStencilAttachment->layout)); 872287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 8723a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 8724a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine uint32_t attachment = subpass.pInputAttachments[j].attachment; 872524991fb692f7e2d457da50d50c40f2705591300cMichael Lentine if (attachment >= pCreateInfo->attachmentCount) { 872624991fb692f7e2d457da50d50c40f2705591300cMichael Lentine skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 872724991fb692f7e2d457da50d50c40f2705591300cMichael Lentine __LINE__, DRAWSTATE_INVALID_RENDERPASS, "DS", 872824991fb692f7e2d457da50d50c40f2705591300cMichael Lentine "Input attachment %d cannot be greater than the total number of attachments %d.", 872924991fb692f7e2d457da50d50c40f2705591300cMichael Lentine attachment, pCreateInfo->attachmentCount); 873024991fb692f7e2d457da50d50c40f2705591300cMichael Lentine continue; 873124991fb692f7e2d457da50d50c40f2705591300cMichael Lentine } 8732a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine if (attachment_first_read.count(attachment)) 8733a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine continue; 8734a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_read.insert(std::make_pair(attachment, true)); 8735a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine attachment_first_layout.insert(std::make_pair(attachment, subpass.pInputAttachments[j].layout)); 8736a5ce96d7c88653668a2b33a6b72bd3cb16d73f48Michael Lentine } 873787e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } 873887e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis#endif 8739cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes { 8740cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes std::lock_guard<std::mutex> lock(global_lock); 8741cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes dev_data->renderPassMap[*pRenderPass] = render_pass; 8742cf2686cdbb12af8a29ca598c126b5e37215f0ef7Chris Forbes } 87435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 87455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis// Free the renderpass shadow 87475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlisstatic void deleteRenderPasses(layer_data *my_data) { 87485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (my_data->renderPassMap.size() <= 0) 87495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 87505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto ii = my_data->renderPassMap.begin(); ii != my_data->renderPassMap.end(); ++ii) { 87515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = (*ii).second->pCreateInfo; 87525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pAttachments; 87535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses) { 87545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->subpassCount; ++i) { 87555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Attachements are all allocated in a block, so just need to 87565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // find the first non-null one to delete 87575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->pSubpasses[i].pInputAttachments) { 87585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pInputAttachments; 87595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pColorAttachments) { 87605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pColorAttachments; 87615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pResolveAttachments) { 87625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pResolveAttachments; 87635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pRenderPassInfo->pSubpasses[i].pPreserveAttachments) { 87645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses[i].pPreserveAttachments; 87655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pSubpasses; 87685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete[] pRenderPassInfo->pDependencies; 87705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete pRenderPassInfo; 87715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete (*ii).second; 87725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->renderPassMap.clear(); 87745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 87755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8776e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbesstatic bool VerifyFramebufferAndRenderPassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 8777e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 87785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkRenderPassCreateInfo *pRenderPassInfo = dev_data->renderPassMap[pRenderPassBegin->renderPass]->pCreateInfo; 87795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkFramebufferCreateInfo framebufferInfo = dev_data->frameBufferMap[pRenderPassBegin->framebuffer].createInfo; 87805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pRenderPassInfo->attachmentCount != framebufferInfo.attachmentCount) { 87815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 87825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using a framebuffer " 87835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "with a different number of attachments."); 87845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 87855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 87865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[i]; 87875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_data = dev_data->imageViewMap.find(image_view); 87885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis assert(image_data != dev_data->imageViewMap.end()); 87895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImage &image = image_data->second.image; 87905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageSubresourceRange &subRange = image_data->second.subresourceRange; 87915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE newNode = {pRenderPassInfo->pAttachments[i].initialLayout, 87925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pRenderPassInfo->pAttachments[i].initialLayout}; 87935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Do not iterate over every possibility - consolidate where possible 87945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subRange.levelCount; j++) { 87955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t level = subRange.baseMipLevel + j; 87965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t k = 0; k < subRange.layerCount; k++) { 87975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t layer = subRange.baseArrayLayer + k; 87985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImageSubresource sub = {subRange.aspectMask, level, layer}; 87995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_CMD_BUF_LAYOUT_NODE node; 88005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!FindLayout(pCB, image, sub, node)) { 88015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(pCB, image, sub, newNode); 88025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis continue; 88035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (newNode.layout != node.layout) { 88055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 88065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot start a render pass using attachment %i " 88085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "where the " 8809d6c1882c31a88ae01b94f3135679f739287be31aKarl Schultz "initial layout is %s and the layout of the attachment at the " 88101c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine "start of the render pass is %s. The layouts must match.", 88111c0f4ce5068dadb12be8715c18a7769d9457b5eaMichael Lentine i, string_VkImageLayout(newNode.layout), string_VkImageLayout(node.layout)); 88125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 881927ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbesstatic void TransitionSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin, 8820e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const int subpass_index) { 882116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 882216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 88235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 882416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 8825e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 8826e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 88275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8828e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 8829e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes const VkFramebufferCreateInfo &framebufferInfo = framebuffer->createInfo; 883016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkSubpassDescription &subpass = renderPass->pCreateInfo->pSubpasses[subpass_index]; 88315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.inputAttachmentCount; ++j) { 88325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pInputAttachments[j].attachment]; 88335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pInputAttachments[j].layout); 88345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t j = 0; j < subpass.colorAttachmentCount; ++j) { 88365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pColorAttachments[j].attachment]; 88375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pColorAttachments[j].layout); 88385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((subpass.pDepthStencilAttachment != NULL) && (subpass.pDepthStencilAttachment->attachment != VK_ATTACHMENT_UNUSED)) { 88405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const VkImageView &image_view = framebufferInfo.pAttachments[subpass.pDepthStencilAttachment->attachment]; 88415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, subpass.pDepthStencilAttachment->layout); 88425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8845e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validatePrimaryCommandBuffer(const layer_data *my_data, const GLOBAL_CB_NODE *pCB, const std::string &cmd_name) { 8846e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 88475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->createInfo.level != VK_COMMAND_BUFFER_LEVEL_PRIMARY) { 88485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 88495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", "Cannot execute command %s on a secondary command buffer.", 88505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis cmd_name.c_str()); 88515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 88535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8855f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbesstatic void TransitionFinalSubpassLayouts(layer_data *dev_data, GLOBAL_CB_NODE *pCB, const VkRenderPassBeginInfo *pRenderPassBegin) { 885616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = getRenderPass(dev_data, pRenderPassBegin->renderPass); 885716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!renderPass) 88585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 885916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes 886016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes const VkRenderPassCreateInfo *pRenderPassInfo = renderPass->pCreateInfo; 8861e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pRenderPassBegin->framebuffer); 8862e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!framebuffer) 88635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return; 8864e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes 88655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pRenderPassInfo->attachmentCount; ++i) { 8866e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes const VkImageView &image_view = framebuffer->createInfo.pAttachments[i]; 88675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SetLayout(dev_data, pCB, image_view, pRenderPassInfo->pAttachments[i].finalLayout); 88685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 88695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 88705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 8871e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool VerifyRenderAreaBounds(const layer_data *my_data, const VkRenderPassBeginInfo *pRenderPassBegin) { 8872885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine bool skip_call = false; 8873885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine const VkFramebufferCreateInfo *pFramebufferInfo = &my_data->frameBufferMap.at(pRenderPassBegin->framebuffer).createInfo; 8874885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine if (pRenderPassBegin->renderArea.offset.x < 0 || 8875885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.x + pRenderPassBegin->renderArea.extent.width) > pFramebufferInfo->width || 8876885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.y < 0 || 8877885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine (pRenderPassBegin->renderArea.offset.y + pRenderPassBegin->renderArea.extent.height) > pFramebufferInfo->height) { 8878885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine skip_call |= static_cast<bool>(log_msg( 8879885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 8880885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine DRAWSTATE_INVALID_RENDER_AREA, "CORE", 8881885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "Cannot execute a render pass with renderArea not within the bound of the " 8882885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "framebuffer. RenderArea: x %d, y %d, width %d, height %d. Framebuffer: width %d, " 8883885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine "height %d.", 8884885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.offset.x, pRenderPassBegin->renderArea.offset.y, pRenderPassBegin->renderArea.extent.width, 8885885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine pRenderPassBegin->renderArea.extent.height, pFramebufferInfo->width, pFramebufferInfo->height)); 8886885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine } 8887885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine return skip_call; 8888885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine} 8889885537d813d6fb3d199e76f6d63b6d3f78d0eeb0Michael Lentine 889089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 889189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdBeginRenderPass(VkCommandBuffer commandBuffer, const VkRenderPassBeginInfo *pRenderPassBegin, VkSubpassContents contents) { 8892e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 88935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8894b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 88955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 889616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto renderPass = pRenderPassBegin ? getRenderPass(dev_data, pRenderPassBegin->renderPass) : nullptr; 8897f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes auto framebuffer = pRenderPassBegin ? getFramebuffer(dev_data, pRenderPassBegin->framebuffer) : nullptr; 88985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 889916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass) { 89003d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis uint32_t clear_op_count = 0; 890116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeFramebuffer = pRenderPassBegin->framebuffer; 890216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (size_t i = 0; i < renderPass->attachments.size(); ++i) { 8903f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 890416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_CLEAR) { 89053d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis ++clear_op_count; 890616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 890716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 890816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 890916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 891016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 891116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } else if (renderPass->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_DONT_CARE) { 891216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 891316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 891416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return false; 891516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 891616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 891716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } else if (renderPass->attachments[i].load_op == VK_ATTACHMENT_LOAD_OP_LOAD) { 891816387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 891916387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 892016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 892116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 892216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes } 892316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (renderPass->attachment_first_read[renderPass->attachments[i].attachment]) { 892416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes std::function<bool()> function = [=]() { 892516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes return validate_memory_is_valid(dev_data, fb_info.mem, "vkCmdBeginRenderPass()", fb_info.image); 892616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes }; 892716387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->validate_functions.push_back(function); 89285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89303d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis if (clear_op_count > pRenderPassBegin->clearValueCount) { 89313d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis skipCall |= log_msg( 89323d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_RENDER_PASS_EXT, 89333d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis reinterpret_cast<uint64_t &>(renderPass), __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 89343d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "In vkCmdBeginRenderPass() the VkRenderPassBeginInfo struct has a clearValueCount of %u but the actual number " 89353d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "of attachments in renderPass 0x%" PRIx64 " that use VK_ATTACHMENT_LOAD_OP_CLEAR is %u. The clearValueCount " 89363d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis "must therefore be greater than or equal to %u.", 89373d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis pRenderPassBegin->clearValueCount, reinterpret_cast<uint64_t &>(renderPass), clear_op_count, clear_op_count); 89383d71bca42a843966040d6ada9c029e0ec9f35ca6Tobin Ehlis } 8939e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skipCall |= VerifyRenderAreaBounds(dev_data, pRenderPassBegin); 8940e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skipCall |= VerifyFramebufferAndRenderPassLayouts(dev_data, pCB, pRenderPassBegin); 8941ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= insideRenderPass(dev_data, pCB, "vkCmdBeginRenderPass"); 8942e5f0c7b48d7b8020aa0877ad216aac257f9e4212Tobin Ehlis skipCall |= ValidateDependencies(dev_data, framebuffer, renderPass); 894316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes pCB->activeRenderPass = renderPass; 89445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdBeginRenderPass"); 89455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_BEGINRENDERPASS, "vkCmdBeginRenderPass()"); 89465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This is a shallow copy as that is all that is needed for now 89475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeRenderPassBeginInfo = *pRenderPassBegin; 89485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass = 0; 89495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 895093c396d566d722dc5c6f438eae212da0e9337ba3Mark Lobodzinski pCB->framebuffers.insert(pRenderPassBegin->framebuffer); 89515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Connect this framebuffer to this cmdBuffer 8952e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes framebuffer->referencingCmdBuffers.insert(pCB->commandBuffer); 89535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 89545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 895516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 895616387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes DRAWSTATE_INVALID_RENDERPASS, "DS", "You cannot use a NULL RenderPass object in vkCmdBeginRenderPass()"); 89575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8959b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8960e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 89615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdBeginRenderPass(commandBuffer, pRenderPassBegin, contents); 89625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 89635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 896589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdNextSubpass(VkCommandBuffer commandBuffer, VkSubpassContents contents) { 8966e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 89675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8968b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 89695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 89705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 89715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdNextSubpass"); 89725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_NEXTSUBPASS, "vkCmdNextSubpass()"); 89735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpass++; 89745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->activeSubpassContents = contents; 897527ed8211a6c2cd0947b7929d0d55d0840618855dChris Forbes TransitionSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo, pCB->activeSubpass); 89765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdNextSubpass"); 89775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 8978b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 8979e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 89805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdNextSubpass(commandBuffer, contents); 89815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 89825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 898389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL CmdEndRenderPass(VkCommandBuffer commandBuffer) { 8984e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 89855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 8986b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 898758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes auto pCB = getCBNode(dev_data, commandBuffer); 898858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes if (pCB) { 898958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes RENDER_PASS_NODE* pRPNode = pCB->activeRenderPass; 8990e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto framebuffer = getFramebuffer(dev_data, pCB->activeFramebuffer); 8991ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (pRPNode) { 899287e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis for (size_t i = 0; i < pRPNode->attachments.size(); ++i) { 8993e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes MT_FB_ATTACHMENT_INFO &fb_info = framebuffer->attachments[i]; 899487e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_STORE) { 899558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 899658c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, true, fb_info.image); 899758c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 899858c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 899958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 900087e0afcd98dcf3c1e5e2cbb3023fe89d9dd10cd2Tobin Ehlis } else if (pRPNode->attachments[i].store_op == VK_ATTACHMENT_STORE_OP_DONT_CARE) { 900158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes std::function<bool()> function = [=]() { 900258c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes set_memory_valid(dev_data, fb_info.mem, false, fb_info.image); 900358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes return false; 900458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes }; 900558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->validate_functions.push_back(function); 90065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 900958c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= outsideRenderPass(dev_data, pCB, "vkCmdEndRenderpass"); 901058c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdEndRenderPass"); 901158c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes skipCall |= addCmd(dev_data, pCB, CMD_ENDRENDERPASS, "vkCmdEndRenderPass()"); 9012f40ab6d10b8d755ce0e461c33916b0d4d5a5d437Chris Forbes TransitionFinalSubpassLayouts(dev_data, pCB, &pCB->activeRenderPassBeginInfo); 901358c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeRenderPass = nullptr; 901458c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeSubpass = 0; 901558c3d40b47b6b30c1e7c508ec14ee67fcd238c93Chris Forbes pCB->activeFramebuffer = VK_NULL_HANDLE; 90165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9017b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9018e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 90195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdEndRenderPass(commandBuffer); 90205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90225121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool logInvalidAttachmentMessage(layer_data *dev_data, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 90235121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes RENDER_PASS_NODE const *primaryPass, uint32_t primaryAttach, uint32_t secondaryAttach, 9024e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const char *msg) { 90255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 90265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9027414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9028414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 902981264ddfa672e895a201f034617eca45bf8b9059Eric Engestrom "Attachment %" PRIu32 " is not compatible with %" PRIu32 ". %s", 90305121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes (void *)secondaryBuffer, (uint64_t)(secondaryPass->renderPass), (uint64_t)(primaryPass->renderPass), primaryAttach, secondaryAttach, 90315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis msg); 90325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90345121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateAttachmentCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 90355121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes uint32_t primaryAttach, VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, 9036e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves uint32_t secondaryAttach, bool is_multi) { 90375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 90385121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->attachmentCount <= primaryAttach) { 90395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primaryAttach = VK_ATTACHMENT_UNUSED; 90405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90415121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (secondaryPass->pCreateInfo->attachmentCount <= secondaryAttach) { 90425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach = VK_ATTACHMENT_UNUSED; 90435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED && secondaryAttach == VK_ATTACHMENT_UNUSED) { 90455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryAttach == VK_ATTACHMENT_UNUSED) { 90485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 90495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The first is unused while the second is not."); 90505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondaryAttach == VK_ATTACHMENT_UNUSED) { 90535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 90545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "The second is unused while the first is not."); 90555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90575121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].format != 90585121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].format) { 90595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 90605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different formats."); 90615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90625121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes if (primaryPass->pCreateInfo->pAttachments[primaryAttach].samples != 90635121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].samples) { 90645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 90655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different samples."); 90665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (is_multi && 90685121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes primaryPass->pCreateInfo->pAttachments[primaryAttach].flags != 90695121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes secondaryPass->pCreateInfo->pAttachments[secondaryAttach].flags) { 90705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= logInvalidAttachmentMessage(dev_data, secondaryBuffer, secondaryPass, primaryPass, primaryAttach, 90715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryAttach, "They have different flags."); 90725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 90745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 90755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 90765121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbesstatic bool validateSubpassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, RENDER_PASS_NODE const *primaryPass, 90775121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes VkCommandBuffer secondaryBuffer, RENDER_PASS_NODE const *secondaryPass, const int subpass, 9078e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool is_multi) { 90795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 90805121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &primary_desc = primaryPass->pCreateInfo->pSubpasses[subpass]; 90815121a8dcacb23766ba4455b4eea429f0a3d62099Chris Forbes const VkSubpassDescription &secondary_desc = secondaryPass->pCreateInfo->pSubpasses[subpass]; 90825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxInputAttachmentCount = std::max(primary_desc.inputAttachmentCount, secondary_desc.inputAttachmentCount); 90835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxInputAttachmentCount; ++i) { 90845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_input_attach = VK_ATTACHMENT_UNUSED, secondary_input_attach = VK_ATTACHMENT_UNUSED; 90855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.inputAttachmentCount) { 90865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_input_attach = primary_desc.pInputAttachments[i].attachment; 90875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.inputAttachmentCount) { 90895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_input_attach = secondary_desc.pInputAttachments[i].attachment; 90905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_input_attach, secondaryBuffer, 90925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_input_attach, is_multi); 90935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 90945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t maxColorAttachmentCount = std::max(primary_desc.colorAttachmentCount, secondary_desc.colorAttachmentCount); 90955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < maxColorAttachmentCount; ++i) { 90965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_color_attach = VK_ATTACHMENT_UNUSED, secondary_color_attach = VK_ATTACHMENT_UNUSED; 90975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount) { 90985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_color_attach = primary_desc.pColorAttachments[i].attachment; 90995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount) { 91015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_color_attach = secondary_desc.pColorAttachments[i].attachment; 91025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_color_attach, secondaryBuffer, 91045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_color_attach, is_multi); 91055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_resolve_attach = VK_ATTACHMENT_UNUSED, secondary_resolve_attach = VK_ATTACHMENT_UNUSED; 91065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < primary_desc.colorAttachmentCount && primary_desc.pResolveAttachments) { 91075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_resolve_attach = primary_desc.pResolveAttachments[i].attachment; 91085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (i < secondary_desc.colorAttachmentCount && secondary_desc.pResolveAttachments) { 91105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_resolve_attach = secondary_desc.pResolveAttachments[i].attachment; 91115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_resolve_attach, secondaryBuffer, 91135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_resolve_attach, is_multi); 91145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis uint32_t primary_depthstencil_attach = VK_ATTACHMENT_UNUSED, secondary_depthstencil_attach = VK_ATTACHMENT_UNUSED; 91165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_desc.pDepthStencilAttachment) { 91175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis primary_depthstencil_attach = primary_desc.pDepthStencilAttachment[0].attachment; 91185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_desc.pDepthStencilAttachment) { 91205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondary_depthstencil_attach = secondary_desc.pDepthStencilAttachment[0].attachment; 91215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateAttachmentCompatibility(dev_data, primaryBuffer, primaryPass, primary_depthstencil_attach, secondaryBuffer, 91235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryPass, secondary_depthstencil_attach, is_multi); 91245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9127e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateRenderPassCompatibility(layer_data *dev_data, VkCommandBuffer primaryBuffer, VkRenderPass primaryPass, 9128e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, VkRenderPass secondaryPass) { 91295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 91305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Early exit if renderPass objects are identical (and therefore compatible) 91315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primaryPass == secondaryPass) 91325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 913316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto primary_render_pass = getRenderPass(dev_data, primaryPass); 913416387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto secondary_render_pass = getRenderPass(dev_data, secondaryPass); 913516387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!primary_render_pass) { 91365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9139414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid current Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 91405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)primaryBuffer, (uint64_t)(primaryPass)); 91415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 914316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (!secondary_render_pass) { 91445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9147414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid secondary Cmd Buffer 0x%p which has invalid render pass 0x%" PRIx64 ".", 91485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass)); 91495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 915116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes if (primary_render_pass->pCreateInfo->subpassCount != secondary_render_pass->pCreateInfo->subpassCount) { 91525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9154414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a render pass 0x%" PRIx64 9155414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current render pass 0x%" PRIx64 "." 91565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "They have a different number of subpasses.", 91575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondaryPass), (uint64_t)(primaryPass)); 91585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 916016387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes auto subpassCount = primary_render_pass->pCreateInfo->subpassCount; 916116387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes for (uint32_t i = 0; i < subpassCount; ++i) { 916216387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes skip_call |= validateSubpassCompatibility(dev_data, primaryBuffer, primary_render_pass, secondaryBuffer, 916316387282d11e414ae7cb9ddf3d0c1bebf8f2c74dChris Forbes secondary_render_pass, i, subpassCount > 1); 91645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9168e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateFramebuffer(layer_data *dev_data, VkCommandBuffer primaryBuffer, const GLOBAL_CB_NODE *pCB, 9169e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves VkCommandBuffer secondaryBuffer, const GLOBAL_CB_NODE *pSubCB) { 91705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 91715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB->beginInfo.pInheritanceInfo) { 91725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9174c5b97dda856ff837638b3ebb7e231d5507c495a3Chris Forbes VkFramebuffer primary_fb = pCB->activeFramebuffer; 91755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkFramebuffer secondary_fb = pSubCB->beginInfo.pInheritanceInfo->framebuffer; 91765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (secondary_fb != VK_NULL_HANDLE) { 91775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (primary_fb != secondary_fb) { 91785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 91795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9180414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p which has a framebuffer 0x%" PRIx64 9181414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller " that is not compatible with the current framebuffer 0x%" PRIx64 ".", 91825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb), (uint64_t)(primary_fb)); 91835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9184e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes auto fb = getFramebuffer(dev_data, secondary_fb); 9185e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes if (!fb) { 91865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 91875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 9188414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9189414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid framebuffer 0x%" PRIx64 ".", 91905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)secondaryBuffer, (uint64_t)(secondary_fb)); 91915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9193e3ad4b1284408353cc56a04951c1df1f35a636ceChris Forbes skip_call |= validateRenderPassCompatibility(dev_data, secondaryBuffer, fb->createInfo.renderPass, 91945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis secondaryBuffer, pSubCB->beginInfo.pInheritanceInfo->renderPass); 91955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 91965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 91975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 91985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9199e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateSecondaryCommandBufferState(layer_data *dev_data, GLOBAL_CB_NODE *pCB, GLOBAL_CB_NODE *pSubCB) { 92005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 92015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis unordered_set<int> activeTypes; 92025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pCB->activeQueries) { 92035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 92045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end()) { 92055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData->second.createInfo.queryType == VK_QUERY_TYPE_PIPELINE_STATISTICS && 92065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo) { 92075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkQueryPipelineStatisticFlags cmdBufStatistics = pSubCB->beginInfo.pInheritanceInfo->pipelineStatistics; 92085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if ((cmdBufStatistics & queryPoolData->second.createInfo.pipelineStatistics) != cmdBufStatistics) { 92095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 92105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9212414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9213414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 ". Pipeline statistics is being queried so the command " 92145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "buffer must have all bits set on the queryPool.", 92155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first)); 92165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis activeTypes.insert(queryPoolData->second.createInfo.queryType); 92195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto queryObject : pSubCB->startedQueries) { 92225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto queryPoolData = dev_data->queryPoolMap.find(queryObject.pool); 92235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (queryPoolData != dev_data->queryPoolMap.end() && activeTypes.count(queryPoolData->second.createInfo.queryType)) { 92245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 92255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9227414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p " 9228414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "which has invalid active query pool 0x%" PRIx64 "of type %d but a query of that type has been started on " 9229414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "secondary Cmd Buffer 0x%p.", 92305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<void *>(pCB->commandBuffer), reinterpret_cast<const uint64_t &>(queryPoolData->first), 92315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis queryPoolData->second.createInfo.queryType, reinterpret_cast<void *>(pSubCB->commandBuffer)); 92325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 92355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 92365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 923789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 923889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCmdExecuteCommands(VkCommandBuffer commandBuffer, uint32_t commandBuffersCount, const VkCommandBuffer *pCommandBuffers) { 9239e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 92405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(commandBuffer), layer_data_map); 9241b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 92425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pCB = getCBNode(dev_data, commandBuffer); 92435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB) { 92445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis GLOBAL_CB_NODE *pSubCB = NULL; 92455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < commandBuffersCount; i++) { 92465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB = getCBNode(dev_data, pCommandBuffers[i]); 92475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pSubCB) { 92485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 92495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, __LINE__, 92505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9251414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ invalid Cmd Buffer 0x%p in element %u of pCommandBuffers array.", 92525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 92535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (VK_COMMAND_BUFFER_LEVEL_PRIMARY == pSubCB->createInfo.level) { 92545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 92555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_SECONDARY_COMMAND_BUFFER, "DS", 9256414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands() called w/ Primary Cmd Buffer 0x%p in element %u of pCommandBuffers " 92575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "array. All cmd buffers in pCommandBuffers array must be secondary.", 92585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], i); 92595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else if (pCB->activeRenderPass) { // Secondary CB w/i RenderPass must have *CONTINUE_BIT set 92605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT)) { 92615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 92625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 92635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_BEGIN_CB_INVALID_STATE, "DS", 9264414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) executed within render pass (0x%" PRIxLEAST64 92655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") must have had vkBeginCommandBuffer() called w/ VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT set.", 9266ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (void *)pCommandBuffers[i], (uint64_t)pCB->activeRenderPass->renderPass); 92675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } else { 92685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Make sure render pass is compatible with parent command buffer pass if has continue 9269ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes skipCall |= validateRenderPassCompatibility(dev_data, commandBuffer, pCB->activeRenderPass->renderPass, pCommandBuffers[i], 92705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass); 92715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateFramebuffer(dev_data, commandBuffer, pCB, pCommandBuffers[i], pSubCB); 92725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string errorString = ""; 9274ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes if (!verify_renderpass_compatibility(dev_data, pCB->activeRenderPass->renderPass, 92755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->beginInfo.pInheritanceInfo->renderPass, errorString)) { 92765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 92775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 92785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_RENDERPASS_INCOMPATIBLE, "DS", 9279414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 9280414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") is incompatible w/ primary command buffer (0x%p) w/ render pass (0x%" PRIxLEAST64 ") due to: %s", 92815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->renderPass, (void *)commandBuffer, 9282ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPass->renderPass, errorString.c_str()); 92835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // If framebuffer for secondary CB is not NULL, then it must match FB from vkCmdBeginRenderPass() 92855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // that this CB will be executed in AND framebuffer must have been created w/ RP compatible w/ renderpass 92865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer) { 92875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pSubCB->beginInfo.pInheritanceInfo->framebuffer != pCB->activeRenderPassBeginInfo.framebuffer) { 92885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 92895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 92905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pCommandBuffers[i], __LINE__, DRAWSTATE_FRAMEBUFFER_INCOMPATIBLE, "DS", 9291414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%p) references framebuffer (0x%" PRIxLEAST64 9292414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller ") that does not match framebuffer (0x%" PRIxLEAST64 ") in active renderpass (0x%" PRIxLEAST64 ").", 92935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (void *)pCommandBuffers[i], (uint64_t)pSubCB->beginInfo.pInheritanceInfo->framebuffer, 9294ee691f5c5fa87aac3750454d2bca2cb582e4e817Chris Forbes (uint64_t)pCB->activeRenderPassBeginInfo.framebuffer, (uint64_t)pCB->activeRenderPass->renderPass); 92955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 92985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO(mlentine): Move more logic into this method 92995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateSecondaryCommandBufferState(dev_data, pCB, pSubCB); 93005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateCommandBufferState(dev_data, pSubCB); 93015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Secondary cmdBuffers are considered pending execution starting w/ 93025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // being recorded 93035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!(pSubCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT)) { 93045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (dev_data->globalInFlightCmdBuffers.find(pSubCB->commandBuffer) != dev_data->globalInFlightCmdBuffers.end()) { 93055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9308414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Attempt to simultaneously execute CB 0x%" PRIxLEAST64 " w/o VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 93095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set!", 93105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCB->commandBuffer)); 93115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pCB->beginInfo.flags & VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT) { 93135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Warn that non-simultaneous secondary cmd buffer renders primary non-simultaneous 93145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 93155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_CB_SIMULTANEOUS_USE, "DS", 9317414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkCmdExecuteCommands(): Secondary Command Buffer (0x%" PRIxLEAST64 93185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT set and will cause primary command buffer " 9319414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") to be treated as if it does not have VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT " 93205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "set, even though it does.", 93215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(pCommandBuffers[i]), (uint64_t)(pCB->commandBuffer)); 93225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->beginInfo.flags &= ~VK_COMMAND_BUFFER_USAGE_SIMULTANEOUS_USE_BIT; 93235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9325b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if (!pCB->activeQueries.empty() && !dev_data->phys_dev_properties.features.inheritedQueries) { 93265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= 93275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 93285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i]), __LINE__, DRAWSTATE_INVALID_COMMAND_BUFFER, "DS", 93295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkCmdExecuteCommands(): Secondary Command Buffer " 9330414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "(0x%" PRIxLEAST64 ") cannot be submitted with a query in " 93315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "flight and inherited queries not " 93325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "supported on this device.", 93335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t>(pCommandBuffers[i])); 93345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pSubCB->primaryCommandBuffer = pCB->commandBuffer; 93365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pCB->secondaryCommandBuffers.insert(pSubCB->commandBuffer); 93375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->globalInFlightCmdBuffers.insert(pSubCB->commandBuffer); 93385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validatePrimaryCommandBuffer(dev_data, pCB, "vkCmdExecuteComands"); 93405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= addCmd(dev_data, pCB, CMD_EXECUTECOMMANDS, "vkCmdExecuteComands()"); 93415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9342b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9343e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) 93445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->CmdExecuteCommands(commandBuffer, commandBuffersCount, pCommandBuffers); 93455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9347e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool ValidateMapImageLayouts(VkDevice device, VkDeviceMemory mem) { 9348e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 935058070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis auto mem_data = dev_data->memObjMap.find(mem); 935158070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if ((mem_data != dev_data->memObjMap.end()) && (mem_data->second.image != VK_NULL_HANDLE)) { 93525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis std::vector<VkImageLayout> layouts; 935358070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis if (FindLayouts(dev_data, mem_data->second.image, layouts)) { 93545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 93555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PREINITIALIZED && layout != VK_IMAGE_LAYOUT_GENERAL) { 93565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, (VkDebugReportObjectTypeEXT)0, 0, 93575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", "Cannot map an image with layout %s. Only " 93585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "GENERAL or PREINITIALIZED are supported.", 93595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 93605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skip_call; 93655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 93665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 936789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 936889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuMapMemory(VkDevice device, VkDeviceMemory mem, VkDeviceSize offset, VkDeviceSize size, VkFlags flags, void **ppData) { 93695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 93705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9371e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 93725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9373b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 937403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 937558070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis DEVICE_MEM_INFO *pMemObj = get_mem_obj_info(dev_data, mem); 93765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pMemObj) { 93775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMemObj->valid = true; 9378b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis if ((dev_data->phys_dev_mem_props.memoryTypes[pMemObj->allocInfo.memoryTypeIndex].propertyFlags & 9379b1b606d27e8c4179534d7bbb48ce217429e37414Tobin Ehlis VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT) == 0) { 93805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 93815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 93825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)mem, __LINE__, MEMTRACK_INVALID_STATE, "MEM", 9383414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Mapping Memory without VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT set: mem obj 0x%" PRIxLEAST64, (uint64_t)mem); 93845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 93865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= validateMemRange(dev_data, mem, offset, size); 93875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 938858070a671b39e2058a799c7b9c932f3f03f2e66dTobin Ehlis skip_call |= ValidateMapImageLayouts(device, mem); 9389b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 93905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9391e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) { 93925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->MapMemory(device, mem, offset, size, flags, ppData); 93937c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis if (VK_SUCCESS == result) { 939403b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 93957c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.lock(); 93967c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis storeMemRanges(dev_data, mem, offset, size); 93977c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis initializeAndTrackMemory(dev_data, mem, size, ppData); 93987c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis lock.unlock(); 93995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis#endif 94007c0012acb5327961b0a5191434a08e5fa788786dTobin Ehlis } 94015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 94035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 940589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL UnmapMemory(VkDevice device, VkDeviceMemory mem) { 94065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9407e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9409b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= deleteMemRanges(my_data, mem); 9411b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9412e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 94135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->device_dispatch_table->UnmapMemory(device, mem); 94145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9417e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateMemoryIsMapped(layer_data *my_data, const char *funcName, uint32_t memRangeCount, 9418e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9419e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94205b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 94215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 94225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 94235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.memRange.offset > pMemRanges[i].offset) { 94245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg( 94255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 94265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory, __LINE__, MEMTRACK_INVALID_MAP, "MEM", 94275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "%s: Flush/Invalidate offset (" PRINTF_SIZE_T_SPECIFIER ") is less than Memory Object's offset " 94285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 94295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset), static_cast<size_t>(mem_element->second.memRange.offset)); 94305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94314b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller 94324b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller const uint64_t my_dataTerminus = 94334b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller (mem_element->second.memRange.size == VK_WHOLE_SIZE) ? mem_element->second.allocInfo.allocationSize : 94344b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller (mem_element->second.memRange.offset + mem_element->second.memRange.size); 94354b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller if (pMemRanges[i].size != VK_WHOLE_SIZE && (my_dataTerminus < (pMemRanges[i].offset + pMemRanges[i].size))) { 94365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 94385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis MEMTRACK_INVALID_MAP, "MEM", "%s: Flush/Invalidate upper-bound (" PRINTF_SIZE_T_SPECIFIER 94395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ") exceeds the Memory Object's upper-bound " 94405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "(" PRINTF_SIZE_T_SPECIFIER ").", 94415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis funcName, static_cast<size_t>(pMemRanges[i].offset + pMemRanges[i].size), 94424b70ef75f98d2a6196132d8c48d43d1d5e04992eMark Mueller static_cast<size_t>(my_dataTerminus)); 94435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 94475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9449e3319189d6f8e3126522df7a5935d2c42f656291Dustin Gravesstatic bool validateAndCopyNoncoherentMemoryToDriver(layer_data *my_data, uint32_t memRangeCount, 9450e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves const VkMappedMemoryRange *pMemRanges) { 9451e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < memRangeCount; ++i) { 94535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto mem_element = my_data->memObjMap.find(pMemRanges[i].memory); 94545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element != my_data->memObjMap.end()) { 94555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mem_element->second.pData) { 94565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize size = mem_element->second.memRange.size; 94575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkDeviceSize half_size = (size / 2); 94585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis char *data = static_cast<char *>(mem_element->second.pData); 94595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = 0; j < half_size; ++j) { 94605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 94615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94625b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9463414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 94645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 94655b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto j = size + half_size; j < 2 * size; ++j) { 94685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (data[j] != NoncoherentMemoryFillValue) { 94695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= log_msg(my_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 94705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, (uint64_t)pMemRanges[i].memory, __LINE__, 9471414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller MEMTRACK_INVALID_MAP, "MEM", "Memory overflow was detected on mem obj 0x%" PRIxLEAST64, 94725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)pMemRanges[i].memory); 94735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis memcpy(mem_element->second.pDriverData, static_cast<void *>(data + (size_t)(half_size)), (size_t)(size)); 94765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return skipCall; 94805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 948289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 948389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuFlushMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 94845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9485e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 94865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 94875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9488b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 94895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateAndCopyNoncoherentMemoryToDriver(my_data, memRangeCount, pMemRanges); 94905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkFlushMappedMemoryRanges", memRangeCount, pMemRanges); 9491b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9492e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 94935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->FlushMappedMemoryRanges(device, memRangeCount, pMemRanges); 94945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 94955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 94965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 94975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 949889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVkResult VKAPI_CALL 949989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuInvalidateMappedMemoryRanges(VkDevice device, uint32_t memRangeCount, const VkMappedMemoryRange *pMemRanges) { 95005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9501e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 95025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 95035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9504b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall |= validateMemoryIsMapped(my_data, "vkInvalidateMappedMemoryRanges", memRangeCount, pMemRanges); 9506b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 9507e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skipCall) { 95085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = my_data->device_dispatch_table->InvalidateMappedMemoryRanges(device, memRangeCount, pMemRanges); 95095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95125b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 951389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL BindImageMemory(VkDevice device, VkImage image, VkDeviceMemory mem, VkDeviceSize memoryOffset) { 95145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 95155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9516e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skipCall = false; 9517b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 951894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto image_node = dev_data->imageMap.find(image); 951994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (image_node != dev_data->imageMap.end()) { 952094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis // Track objects tied to memory 952147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski uint64_t image_handle = reinterpret_cast<uint64_t &>(image); 952294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis skipCall = set_mem_binding(dev_data, mem, image_handle, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, "vkBindImageMemory"); 95235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkMemoryRequirements memRequirements; 9524b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 952594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->device_dispatch_table->GetImageMemoryRequirements(device, image, &memRequirements); 9526b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 952747aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 952847aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski // Track and validate bound memory range information 952947aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const auto &memEntry = dev_data->memObjMap.find(mem); 953047aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski if (memEntry != dev_data->memObjMap.end()) { 953147aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski const MEMORY_RANGE range = 953247aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski insert_memory_ranges(image_handle, mem, memoryOffset, memRequirements, memEntry->second.imageRanges); 953347aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski skipCall |= 953447aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski validate_memory_range(dev_data, memEntry->second.bufferRanges, range, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT); 953547aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski } 953647aaf733d7394bda75c6de24289efe6b281e3cffMark Lobodzinski 95370a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9538b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 953994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis if (!skipCall) { 954094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis result = dev_data->device_dispatch_table->BindImageMemory(device, image, mem, memoryOffset); 9541b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.lock(); 954294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->memObjMap[mem].image = image; 954394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.mem = mem; 954494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memOffset = memoryOffset; 954594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node->second.memSize = memRequirements.size; 9546b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 954794c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } 954894c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis } else { 954994c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_DEVICE_MEMORY_EXT, 955094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image), __LINE__, MEMTRACK_INVALID_OBJECT, "MT", 9551414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkBindImageMemory: Cannot find invalid image 0x%" PRIx64 ", has it already been deleted?", 955294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis reinterpret_cast<const uint64_t &>(image)); 95535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 95545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 955789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL SetEvent(VkDevice device, VkEvent event) { 95583ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis bool skip_call = false; 95593ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 95605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 9561b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95623ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis auto event_node = dev_data->eventMap.find(event); 95633ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (event_node != dev_data->eventMap.end()) { 95643ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.needsSignaled = false; 95653ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis event_node->second.stageMask = VK_PIPELINE_STAGE_HOST_BIT; 9566c1eb2a3736e03aaa15b849d217fd963021dc9780Michael Lentine if (event_node->second.write_in_use) { 95673ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis skip_call |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_EVENT_EXT, 95683ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9569414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Cannot call vkSetEvent() on event 0x%" PRIxLEAST64 " that is already in use by a command buffer.", 95703ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis reinterpret_cast<const uint64_t &>(event)); 95713ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 95723ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis } 9573b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 95746fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // Host setting event is visible to all queues immediately so update stageMask for any queue that's seen this event 95756fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // TODO : For correctness this needs separate fix to verify that app doesn't make incorrect assumptions about the 95766fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis // ordering of this command in relation to vkCmd[Set|Reset]Events (see GH297) 95776fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis for (auto queue_data : dev_data->queueMap) { 95786fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis auto event_entry = queue_data.second.eventToStageMap.find(event); 95796fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis if (event_entry != queue_data.second.eventToStageMap.end()) { 95806fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis event_entry->second |= VK_PIPELINE_STAGE_HOST_BIT; 95816fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 95826fcff21b8cce5159fdfa317e612f75f5ea6a189eTobin Ehlis } 95833ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis if (!skip_call) 95843ee1d6057ee6c49b9dbbeb067b7fd149bdba7b5cTobin Ehlis result = dev_data->device_dispatch_table->SetEvent(device, event); 95855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 95865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 95875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 95885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 958989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuQueueBindSparse(VkQueue queue, uint32_t bindInfoCount, const VkBindSparseInfo *pBindInfo, VkFence fence) { 95905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 95915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 9592e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves bool skip_call = false; 9593b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 95944b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis // First verify that fence is not in use 9595a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis if (fence != VK_NULL_HANDLE) { 959618ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine auto fence_data = dev_data->fenceMap.find(fence); 959718ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine if ((bindInfoCount != 0) && fence_data->second.in_use.load()) { 9598a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 9599a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 9600a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, DRAWSTATE_INVALID_FENCE, "DS", 9601414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIx64 " is already in use by another submission.", reinterpret_cast<uint64_t &>(fence)); 9602a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 960318ef6d5a98654384d6d5c022e01324fa436c02afMichael Lentine if (!fence_data->second.needsSignaled) { 9604a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis skip_call |= 9605a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_FENCE_EXT, 9606a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence), __LINE__, MEMTRACK_INVALID_FENCE_STATE, "MEM", 9607414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Fence 0x%" PRIxLEAST64 " submitted in SIGNALED state. Fences must be reset before being submitted", 9608a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis reinterpret_cast<uint64_t &>(fence)); 9609a265a8ed3bbb32ade305b1be3148d6001a870b76Tobin Ehlis } 96105861c17dab055a598d8d38e824a8d42e9704e191Michael Lentine trackCommandBuffers(dev_data, queue, 0, nullptr, fence); 96114b38d3aa8b6be6a7f5bebb472ab439da0562824fTobin Ehlis } 96121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t bindIdx = 0; bindIdx < bindInfoCount; ++bindIdx) { 96131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkBindSparseInfo &bindInfo = pBindInfo[bindIdx]; 96145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // Track objects tied to memory 96151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.bufferBindCount; j++) { 96161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pBufferBinds[j].bindCount; k++) { 96171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pBufferBinds[j].pBinds[k].memory, 96181344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pBufferBinds[j].buffer, VK_DEBUG_REPORT_OBJECT_TYPE_BUFFER_EXT, 96195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9620e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96231344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageOpaqueBindCount; j++) { 96241344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageOpaqueBinds[j].bindCount; k++) { 96251344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageOpaqueBinds[j].pBinds[k].memory, 96261344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageOpaqueBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 96275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9628e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96311344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t j = 0; j < bindInfo.imageBindCount; j++) { 96321344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t k = 0; k < bindInfo.pImageBinds[j].bindCount; k++) { 96331344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (set_sparse_mem_binding(dev_data, bindInfo.pImageBinds[j].pBinds[k].memory, 96341344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis (uint64_t)bindInfo.pImageBinds[j].image, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, 96355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkQueueBindSparse")) 9636e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves skip_call = true; 96375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96391344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.waitSemaphoreCount; ++i) { 96401344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pWaitSemaphores[i]; 96411344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 96421344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 96431344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 96441344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 96451344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 96465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 96471344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9648414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 96491344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis " that has no way to be signaled.", 96501344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 96515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96541344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis for (uint32_t i = 0; i < bindInfo.signalSemaphoreCount; ++i) { 96551344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = bindInfo.pSignalSemaphores[i]; 96561344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 96571344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 96585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call = 96595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 96601344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9661414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkQueueBindSparse: Queue 0x%" PRIx64 " is signaling semaphore 0x%" PRIx64 96621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis ", but that semaphore is already signaled.", 96631344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 96645b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96651344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 96665b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96685b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96690a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes print_mem_list(dev_data); 9670b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 96715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9672e3319189d6f8e3126522df7a5935d2c42f656291Dustin Graves if (!skip_call) 96735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return dev_data->device_dispatch_table->QueueBindSparse(queue, bindInfoCount, pBindInfo, fence); 96745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 967889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSemaphore(VkDevice device, const VkSemaphoreCreateInfo *pCreateInfo, 967989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkSemaphore *pSemaphore) { 96805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSemaphore(device, pCreateInfo, pAllocator, pSemaphore); 96825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9683b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 96845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis SEMAPHORE_NODE* sNode = &dev_data->semaphoreMap[*pSemaphore]; 96851344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis sNode->signaled = false; 96860a32ed7bdf03e7bda914e03c0bfa6ebf400cdf5bMichael Lentine sNode->queue = VK_NULL_HANDLE; 96875b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis sNode->in_use.store(0); 96885b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 96895b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 96905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 96915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 96925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin EhlisVKAPI_ATTR VkResult VKAPI_CALL 969389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateEvent(VkDevice device, const VkEventCreateInfo *pCreateInfo, const VkAllocationCallbacks *pAllocator, VkEvent *pEvent) { 96945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 96955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateEvent(device, pCreateInfo, pAllocator, pEvent); 96965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS) { 9697b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 96985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].needsSignaled = false; 96995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].in_use.store(0); 97005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->eventMap[*pEvent].stageMask = VkPipelineStageFlags(0); 97015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97025b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 970589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL CreateSwapchainKHR(VkDevice device, const VkSwapchainCreateInfoKHR *pCreateInfo, 970689d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, 970789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSwapchainKHR *pSwapchain) { 97085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->CreateSwapchainKHR(device, pCreateInfo, pAllocator, pSwapchain); 97105b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97115b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == result) { 97120801763633180d277d26a90343464bd11646056fTobin Ehlis SWAPCHAIN_NODE *psc_node = new SWAPCHAIN_NODE(pCreateInfo); 9713b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97140801763633180d277d26a90343464bd11646056fTobin Ehlis dev_data->device_extensions.swapchainMap[*pSwapchain] = psc_node; 97155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 97185b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97195b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 972089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 972189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks *pAllocator) { 97225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97235b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 97245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 9725b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 97265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(swapchain); 97275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end()) { 97285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data->second->images.size() > 0) { 97295b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto swapchain_image : swapchain_data->second->images) { 97305b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_sub = dev_data->imageSubresourceMap.find(swapchain_image); 97315b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_sub != dev_data->imageSubresourceMap.end()) { 97325b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto imgsubpair : image_sub->second) { 97335b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto image_item = dev_data->imageLayoutMap.find(imgsubpair); 97345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (image_item != dev_data->imageLayoutMap.end()) { 97355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap.erase(image_item); 97365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap.erase(image_sub); 97395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97400a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes skipCall = clear_object_binding(dev_data, (uint64_t)swapchain_image, 97410801763633180d277d26a90343464bd11646056fTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT); 974294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis dev_data->imageMap.erase(swapchain_image); 97435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis delete swapchain_data->second; 97465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.swapchainMap.erase(swapchain); 97475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9748b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 97495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) 97505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->DestroySwapchainKHR(device, swapchain, pAllocator); 97515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 97525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 975389d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 975489d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuGetSwapchainImagesKHR(VkDevice device, VkSwapchainKHR swapchain, uint32_t *pCount, VkImage *pSwapchainImages) { 97555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 97565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = dev_data->device_dispatch_table->GetSwapchainImagesKHR(device, swapchain, pCount, pSwapchainImages); 97575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 97585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (result == VK_SUCCESS && pSwapchainImages != NULL) { 97595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // This should never happen and is checked by param checker. 97605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!pCount) 97615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 9762b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 97635b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis const size_t count = *pCount; 97640801763633180d277d26a90343464bd11646056fTobin Ehlis auto swapchain_node = dev_data->device_extensions.swapchainMap[swapchain]; 97650801763633180d277d26a90343464bd11646056fTobin Ehlis if (!swapchain_node->images.empty()) { 97660801763633180d277d26a90343464bd11646056fTobin Ehlis // TODO : Not sure I like the memcmp here, but it works 97670801763633180d277d26a90343464bd11646056fTobin Ehlis const bool mismatch = (swapchain_node->images.size() != count || 97680801763633180d277d26a90343464bd11646056fTobin Ehlis memcmp(&swapchain_node->images[0], pSwapchainImages, sizeof(swapchain_node->images[0]) * count)); 97695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (mismatch) { 97705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis // TODO: Verify against Valid Usage section of extension 97715b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SWAPCHAIN_KHR_EXT, 97725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)swapchain, __LINE__, MEMTRACK_NONE, "SWAP_CHAIN", 9773414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "vkGetSwapchainInfoKHR(0x%" PRIx64 97745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ", VK_SWAP_CHAIN_INFO_TYPE_PERSISTENT_IMAGES_KHR) returned mismatching data", 97755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis (uint64_t)(swapchain)); 97765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97775b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < *pCount; ++i) { 97795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis IMAGE_LAYOUT_NODE image_layout_node; 97805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.layout = VK_IMAGE_LAYOUT_UNDEFINED; 97815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis image_layout_node.format = swapchain_node->createInfo.imageFormat; 978294c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis auto &image_node = dev_data->imageMap[pSwapchainImages[i]]; 978394c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.mipLevels = 1; 978494c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.arrayLayers = swapchain_node->createInfo.imageArrayLayers; 978594c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.createInfo.usage = swapchain_node->createInfo.imageUsage; 9786ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.format = swapchain_node->createInfo.imageFormat; 9787ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.extent.width = swapchain_node->createInfo.imageExtent.width; 9788ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.extent.height = swapchain_node->createInfo.imageExtent.height; 9789ae7fe2b3600678e83196bb0d79ca35afc599a122Tony Barbour image_node.createInfo.sharingMode = swapchain_node->createInfo.imageSharingMode; 979094c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.valid = false; 979194c53c062f0ccc70ef0ada8e98edc90eadc4cb45Tobin Ehlis image_node.mem = MEMTRACKER_SWAP_CHAIN_IMAGE_KEY; 97925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis swapchain_node->images.push_back(pSwapchainImages[i]); 97935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis ImageSubresourcePair subpair = {pSwapchainImages[i], false, VkImageSubresource()}; 97945b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageSubresourceMap[pSwapchainImages[i]].push_back(subpair); 97955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->imageLayoutMap[subpair] = image_layout_node; 97965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_extensions.imageToSwapchainMap[pSwapchainImages[i]] = swapchain; 97975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 97995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98005b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98015b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 980289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL QueuePresentKHR(VkQueue queue, const VkPresentInfoKHR *pPresentInfo) { 98035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(queue), layer_data_map); 98045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 98055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skip_call = false; 98065b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pPresentInfo) { 9808b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->waitSemaphoreCount; ++i) { 98101344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis const VkSemaphore &semaphore = pPresentInfo->pWaitSemaphores[i]; 98111344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 98121344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 98131344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = false; 98141344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } else { 98151344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis skip_call |= 98161344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, 98171344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis VK_DEBUG_REPORT_OBJECT_TYPE_COMMAND_BUFFER_EXT, 0, __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 9818414e9a4117b500eac650d8b8f01a6e1b22d05aaeMark Mueller "Queue 0x%" PRIx64 " is waiting on semaphore 0x%" PRIx64 " that has no way to be signaled.", 98191344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<uint64_t &>(queue), reinterpret_cast<const uint64_t &>(semaphore)); 98201344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis } 98215b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98225b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98230801763633180d277d26a90343464bd11646056fTobin Ehlis VkDeviceMemory mem; 98245b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (uint32_t i = 0; i < pPresentInfo->swapchainCount; ++i) { 98255b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto swapchain_data = dev_data->device_extensions.swapchainMap.find(pPresentInfo->pSwapchains[i]); 98265b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (swapchain_data != dev_data->device_extensions.swapchainMap.end() && 98275b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pPresentInfo->pImageIndices[i] < swapchain_data->second->images.size()) { 98285b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkImage image = swapchain_data->second->images[pPresentInfo->pImageIndices[i]]; 982903b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#if MTMERGESOURCE 98300801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= 98310a1ce3dfd81c9f4efbe46f5ba5ddaea70bc4aa61Chris Forbes get_mem_binding_from_object(dev_data, (uint64_t)(image), VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT, &mem); 98320801763633180d277d26a90343464bd11646056fTobin Ehlis skip_call |= validate_memory_is_valid(dev_data, mem, "vkQueuePresentKHR()", image); 983303b71511c9e94f2e6101a3214858cee3742ec277Mark Lobodzinski#endif 98345b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis vector<VkImageLayout> layouts; 98355b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (FindLayouts(dev_data, image, layouts)) { 98365b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis for (auto layout : layouts) { 98375b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (layout != VK_IMAGE_LAYOUT_PRESENT_SRC_KHR) { 98385b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skip_call |= 98395b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_QUEUE_EXT, 98405b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis reinterpret_cast<uint64_t &>(queue), __LINE__, DRAWSTATE_INVALID_IMAGE_LAYOUT, "DS", 98415b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "Images passed to present must be in layout " 98425b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "PRESENT_SOURCE_KHR but is in %s", 98435b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis string_VkImageLayout(layout)); 98445b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98455b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98475b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98485b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98495b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98505b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 98515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skip_call) 98525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = dev_data->device_dispatch_table->QueuePresentKHR(queue, pPresentInfo); 98531344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 98545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 985789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL AcquireNextImageKHR(VkDevice device, VkSwapchainKHR swapchain, uint64_t timeout, 985889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkSemaphore semaphore, VkFence fence, uint32_t *pImageIndex) { 98595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data = get_my_data_ptr(get_dispatch_key(device), layer_data_map); 98605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult result = VK_ERROR_VALIDATION_FAILED_EXT; 98615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis bool skipCall = false; 98621344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 9863b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::unique_lock<std::mutex> lock(global_lock); 98641657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak if (semaphore != VK_NULL_HANDLE && 98651657461fe9b20d471b0d65f8fc67550cddeb6c00Dominik Witczak dev_data->semaphoreMap.find(semaphore) != dev_data->semaphoreMap.end()) { 98661344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis if (dev_data->semaphoreMap[semaphore].signaled) { 98675b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis skipCall = log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT, 98681344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis reinterpret_cast<const uint64_t &>(semaphore), __LINE__, DRAWSTATE_QUEUE_FORWARD_PROGRESS, "DS", 98695b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis "vkAcquireNextImageKHR: Semaphore must not be currently signaled or in a wait state"); 98705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98711344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis dev_data->semaphoreMap[semaphore].signaled = true; 98725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis auto fence_data = dev_data->fenceMap.find(fence); 98745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (fence_data != dev_data->fenceMap.end()) { 98755b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis fence_data->second.swapchain = swapchain; 98765b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 9877b9e992386a44404152747d66817a733aa127e281Jeremy Hayes lock.unlock(); 98781344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 98795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (!skipCall) { 98805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis result = 98815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data->device_dispatch_table->AcquireNextImageKHR(device, swapchain, timeout, semaphore, fence, pImageIndex); 98825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98831344302fce242e654df2fd518b6371a91b8a5c7dTobin Ehlis 98845b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return result; 98855b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98865b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 988789d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL 988889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 988989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 98905b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 98915b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 98925b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkResult res = pTable->CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 98935b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (VK_SUCCESS == res) { 9894b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 98955b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis res = layer_create_msg_callback(my_data->report_data, pCreateInfo, pAllocator, pMsgCallback); 98965b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 98975b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return res; 98985b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 98995b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 990089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL DestroyDebugReportCallbackEXT(VkInstance instance, 990189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkDebugReportCallbackEXT msgCallback, 990289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const VkAllocationCallbacks *pAllocator) { 99035b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99045b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 99055b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pTable->DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 9906b9e992386a44404152747d66817a733aa127e281Jeremy Hayes std::lock_guard<std::mutex> lock(global_lock); 99075b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_destroy_msg_callback(my_data->report_data, msgCallback, pAllocator); 99085b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99095b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 991089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR void VKAPI_CALL 991189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 991289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 99135b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99145b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data->instance_dispatch_table->DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, 99155b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis pMsg); 99165b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99175b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 991889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR VkResult VKAPI_CALL EnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 991989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu const char *pLayerName, uint32_t *pCount, 992089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu VkExtensionProperties *pProperties) { 9921a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu if (pLayerName && !strcmp(pLayerName, global_layer.layerName)) 992208939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu return util_GetExtensionProperties(0, NULL, pCount, pProperties); 9923a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 9924a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu assert(physicalDevice); 9925a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu 9926a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu dispatch_key key = get_dispatch_key(physicalDevice); 9927a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu layer_data *my_data = get_my_data_ptr(key, layer_data_map); 9928a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return my_data->instance_dispatch_table->EnumerateDeviceExtensionProperties(physicalDevice, NULL, pCount, pProperties); 992908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 993008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 993180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 99327ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name); 99337ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 99347ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 993580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name); 993680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 993709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 993809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev); 993909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 994089d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetDeviceProcAddr(VkDevice dev, const char *funcName) { 994180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc = intercept_core_device_command(funcName); 994280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (proc) 994380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return proc; 994480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 994580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu assert(dev); 99465b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 994709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu proc = intercept_khr_swapchain_command(funcName, dev); 994809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (proc) 994909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return proc; 995009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 99515b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *dev_data; 99525b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 99535b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99545b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerDispatchTable *pTable = dev_data->device_dispatch_table; 99555b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis { 99565b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetDeviceProcAddr == NULL) 99575b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 99585b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetDeviceProcAddr(dev, funcName); 99595b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis } 99605b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 99615b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 996289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I WuVKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL GetInstanceProcAddr(VkInstance instance, const char *funcName) { 99637ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc = intercept_core_instance_command(funcName); 99643f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 99653f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_core_device_command(funcName); 99663f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!proc) 99673f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu proc = intercept_khr_swapchain_command(funcName, VK_NULL_HANDLE); 99687ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 99697ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 99705b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99717ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu assert(instance); 99725b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99735b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis layer_data *my_data; 99745b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis my_data = get_my_data_ptr(get_dispatch_key(instance), layer_data_map); 99757ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu proc = debug_report_get_instance_proc_addr(my_data->report_data, funcName); 99767ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (proc) 99777ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return proc; 99785b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis 99795b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis VkLayerInstanceDispatchTable *pTable = my_data->instance_dispatch_table; 99805b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis if (pTable->GetInstanceProcAddr == NULL) 99815b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return NULL; 99825b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis return pTable->GetInstanceProcAddr(instance, funcName); 99835b5e7bcfe47d9ed90d0d5edbbe11edf7214a7784Tobin Ehlis} 998408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 998580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wustatic PFN_vkVoidFunction 99867ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wuintercept_core_instance_command(const char *name) { 99877ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu static const struct { 99887ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu const char *name; 99897ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu PFN_vkVoidFunction proc; 99907ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } core_instance_commands[] = { 99917ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetInstanceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetInstanceProcAddr) }, 99927ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr) }, 99937ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateInstance", reinterpret_cast<PFN_vkVoidFunction>(CreateInstance) }, 99947ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkCreateDevice", reinterpret_cast<PFN_vkVoidFunction>(CreateDevice) }, 99957ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance) }, 99967ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu { "vkEnumerateDeviceExtensionProperties", reinterpret_cast<PFN_vkVoidFunction>(EnumerateDeviceExtensionProperties) }, 99977ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu }; 99987ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 99997a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu // we should never be queried for these commands 100007a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu assert(strcmp(name, "vkEnumerateInstanceLayerProperties") && 100017a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu strcmp(name, "vkEnumerateInstanceExtensionProperties") && 100027a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu strcmp(name, "vkEnumerateDeviceLayerProperties")); 100037a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu 100047ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_instance_commands); i++) { 100057ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu if (!strcmp(core_instance_commands[i].name, name)) 100067ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return core_instance_commands[i].proc; 100077ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu } 100087ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100097ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu return nullptr; 100107ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu} 100117ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wu 100127ed76a2d9a619f963e7a1afb13e9913fbc09dc63Chia-I Wustatic PFN_vkVoidFunction 1001380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wuintercept_core_device_command(const char *name) { 1001480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu static const struct { 1001580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu const char *name; 1001680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu PFN_vkVoidFunction proc; 1001780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } core_device_commands[] = { 10018593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceProcAddr", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceProcAddr)}, 10019593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueSubmit", reinterpret_cast<PFN_vkVoidFunction>(QueueSubmit)}, 10020593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkWaitForFences", reinterpret_cast<PFN_vkVoidFunction>(WaitForFences)}, 10021593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetFenceStatus", reinterpret_cast<PFN_vkVoidFunction>(GetFenceStatus)}, 10022593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(QueueWaitIdle)}, 10023593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDeviceWaitIdle", reinterpret_cast<PFN_vkVoidFunction>(DeviceWaitIdle)}, 10024593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetDeviceQueue", reinterpret_cast<PFN_vkVoidFunction>(GetDeviceQueue)}, 10025593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyInstance", reinterpret_cast<PFN_vkVoidFunction>(DestroyInstance)}, 10026593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDevice", reinterpret_cast<PFN_vkVoidFunction>(DestroyDevice)}, 10027593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFence", reinterpret_cast<PFN_vkVoidFunction>(DestroyFence)}, 10028593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetFences", reinterpret_cast<PFN_vkVoidFunction>(ResetFences)}, 10029593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySemaphore", reinterpret_cast<PFN_vkVoidFunction>(DestroySemaphore)}, 10030593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyEvent", reinterpret_cast<PFN_vkVoidFunction>(DestroyEvent)}, 10031593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyQueryPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyQueryPool)}, 10032593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyBuffer)}, 10033593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyBufferView", reinterpret_cast<PFN_vkVoidFunction>(DestroyBufferView)}, 10034593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImage", reinterpret_cast<PFN_vkVoidFunction>(DestroyImage)}, 10035593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyImageView", reinterpret_cast<PFN_vkVoidFunction>(DestroyImageView)}, 10036593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyShaderModule", reinterpret_cast<PFN_vkVoidFunction>(DestroyShaderModule)}, 10037593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipeline", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipeline)}, 10038593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineLayout)}, 10039593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroySampler", reinterpret_cast<PFN_vkVoidFunction>(DestroySampler)}, 10040593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorSetLayout)}, 10041593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyDescriptorPool)}, 10042593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(DestroyFramebuffer)}, 10043593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyRenderPass", reinterpret_cast<PFN_vkVoidFunction>(DestroyRenderPass)}, 10044593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateBuffer)}, 10045593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateBufferView", reinterpret_cast<PFN_vkVoidFunction>(CreateBufferView)}, 10046593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImage", reinterpret_cast<PFN_vkVoidFunction>(CreateImage)}, 10047593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateImageView", reinterpret_cast<PFN_vkVoidFunction>(CreateImageView)}, 10048593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFence", reinterpret_cast<PFN_vkVoidFunction>(CreateFence)}, 10049593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineCache", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineCache)}, 10050593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyPipelineCache", reinterpret_cast<PFN_vkVoidFunction>(DestroyPipelineCache)}, 10051593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetPipelineCacheData", reinterpret_cast<PFN_vkVoidFunction>(GetPipelineCacheData)}, 10052593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMergePipelineCaches", reinterpret_cast<PFN_vkVoidFunction>(MergePipelineCaches)}, 10053593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateGraphicsPipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateGraphicsPipelines)}, 10054593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateComputePipelines", reinterpret_cast<PFN_vkVoidFunction>(CreateComputePipelines)}, 10055593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSampler", reinterpret_cast<PFN_vkVoidFunction>(CreateSampler)}, 10056593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorSetLayout", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorSetLayout)}, 10057593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreatePipelineLayout", reinterpret_cast<PFN_vkVoidFunction>(CreatePipelineLayout)}, 10058593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(CreateDescriptorPool)}, 10059593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetDescriptorPool", reinterpret_cast<PFN_vkVoidFunction>(ResetDescriptorPool)}, 10060593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(AllocateDescriptorSets)}, 10061593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(FreeDescriptorSets)}, 10062593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUpdateDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(UpdateDescriptorSets)}, 10063593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateCommandPool", reinterpret_cast<PFN_vkVoidFunction>(CreateCommandPool)}, 10064593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkDestroyCommandPool", reinterpret_cast<PFN_vkVoidFunction>(DestroyCommandPool)}, 10065593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandPool", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandPool)}, 10066593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CreateQueryPool)}, 10067593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(AllocateCommandBuffers)}, 10068593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeCommandBuffers", reinterpret_cast<PFN_vkVoidFunction>(FreeCommandBuffers)}, 10069593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBeginCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(BeginCommandBuffer)}, 10070593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkEndCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(EndCommandBuffer)}, 10071593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkResetCommandBuffer", reinterpret_cast<PFN_vkVoidFunction>(ResetCommandBuffer)}, 10072593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindPipeline", reinterpret_cast<PFN_vkVoidFunction>(CmdBindPipeline)}, 10073593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetViewport", reinterpret_cast<PFN_vkVoidFunction>(CmdSetViewport)}, 10074593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetScissor", reinterpret_cast<PFN_vkVoidFunction>(CmdSetScissor)}, 10075593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetLineWidth", reinterpret_cast<PFN_vkVoidFunction>(CmdSetLineWidth)}, 10076593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBias", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBias)}, 10077593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetBlendConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdSetBlendConstants)}, 10078593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetDepthBounds", reinterpret_cast<PFN_vkVoidFunction>(CmdSetDepthBounds)}, 10079593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilCompareMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilCompareMask)}, 10080593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilWriteMask", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilWriteMask)}, 10081593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetStencilReference", reinterpret_cast<PFN_vkVoidFunction>(CmdSetStencilReference)}, 10082593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindDescriptorSets", reinterpret_cast<PFN_vkVoidFunction>(CmdBindDescriptorSets)}, 10083593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindVertexBuffers", reinterpret_cast<PFN_vkVoidFunction>(CmdBindVertexBuffers)}, 10084593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBindIndexBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdBindIndexBuffer)}, 10085593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDraw", reinterpret_cast<PFN_vkVoidFunction>(CmdDraw)}, 10086593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexed", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexed)}, 10087593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndirect)}, 10088593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDrawIndexedIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDrawIndexedIndirect)}, 10089593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatch", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatch)}, 10090593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdDispatchIndirect", reinterpret_cast<PFN_vkVoidFunction>(CmdDispatchIndirect)}, 10091593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBuffer)}, 10092593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImage)}, 10093593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBlitImage", reinterpret_cast<PFN_vkVoidFunction>(CmdBlitImage)}, 10094593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyBufferToImage", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyBufferToImage)}, 10095593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyImageToBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyImageToBuffer)}, 10096593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdUpdateBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdUpdateBuffer)}, 10097593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdFillBuffer", reinterpret_cast<PFN_vkVoidFunction>(CmdFillBuffer)}, 10098593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearColorImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearColorImage)}, 10099593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearDepthStencilImage", reinterpret_cast<PFN_vkVoidFunction>(CmdClearDepthStencilImage)}, 10100593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdClearAttachments", reinterpret_cast<PFN_vkVoidFunction>(CmdClearAttachments)}, 10101593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResolveImage", reinterpret_cast<PFN_vkVoidFunction>(CmdResolveImage)}, 10102593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdSetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdSetEvent)}, 10103593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetEvent", reinterpret_cast<PFN_vkVoidFunction>(CmdResetEvent)}, 10104593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWaitEvents", reinterpret_cast<PFN_vkVoidFunction>(CmdWaitEvents)}, 10105593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPipelineBarrier", reinterpret_cast<PFN_vkVoidFunction>(CmdPipelineBarrier)}, 10106593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginQuery)}, 10107593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndQuery", reinterpret_cast<PFN_vkVoidFunction>(CmdEndQuery)}, 10108593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdResetQueryPool", reinterpret_cast<PFN_vkVoidFunction>(CmdResetQueryPool)}, 10109593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdCopyQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(CmdCopyQueryPoolResults)}, 10110593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdPushConstants", reinterpret_cast<PFN_vkVoidFunction>(CmdPushConstants)}, 10111593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdWriteTimestamp", reinterpret_cast<PFN_vkVoidFunction>(CmdWriteTimestamp)}, 10112593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateFramebuffer", reinterpret_cast<PFN_vkVoidFunction>(CreateFramebuffer)}, 10113593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateShaderModule", reinterpret_cast<PFN_vkVoidFunction>(CreateShaderModule)}, 10114593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CreateRenderPass)}, 10115593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdBeginRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdBeginRenderPass)}, 10116593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdNextSubpass", reinterpret_cast<PFN_vkVoidFunction>(CmdNextSubpass)}, 10117593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdEndRenderPass", reinterpret_cast<PFN_vkVoidFunction>(CmdEndRenderPass)}, 10118593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCmdExecuteCommands", reinterpret_cast<PFN_vkVoidFunction>(CmdExecuteCommands)}, 10119593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkSetEvent", reinterpret_cast<PFN_vkVoidFunction>(SetEvent)}, 10120593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkMapMemory", reinterpret_cast<PFN_vkVoidFunction>(MapMemory)}, 10121593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkUnmapMemory", reinterpret_cast<PFN_vkVoidFunction>(UnmapMemory)}, 10122593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFlushMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(FlushMappedMemoryRanges)}, 10123593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkInvalidateMappedMemoryRanges", reinterpret_cast<PFN_vkVoidFunction>(InvalidateMappedMemoryRanges)}, 10124593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkAllocateMemory", reinterpret_cast<PFN_vkVoidFunction>(AllocateMemory)}, 10125593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkFreeMemory", reinterpret_cast<PFN_vkVoidFunction>(FreeMemory)}, 10126593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindBufferMemory", reinterpret_cast<PFN_vkVoidFunction>(BindBufferMemory)}, 10127593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetBufferMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetBufferMemoryRequirements)}, 10128593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetImageMemoryRequirements", reinterpret_cast<PFN_vkVoidFunction>(GetImageMemoryRequirements)}, 10129593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkGetQueryPoolResults", reinterpret_cast<PFN_vkVoidFunction>(GetQueryPoolResults)}, 10130593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkBindImageMemory", reinterpret_cast<PFN_vkVoidFunction>(BindImageMemory)}, 10131593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkQueueBindSparse", reinterpret_cast<PFN_vkVoidFunction>(QueueBindSparse)}, 10132593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateSemaphore", reinterpret_cast<PFN_vkVoidFunction>(CreateSemaphore)}, 10133593c857d8db57cf9ae2c590b75e22dadd51bd3d4Tobin Ehlis {"vkCreateEvent", reinterpret_cast<PFN_vkVoidFunction>(CreateEvent)}, 1013480be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu }; 1013580be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1013680be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(core_device_commands); i++) { 1013780be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu if (!strcmp(core_device_commands[i].name, name)) 1013880be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return core_device_commands[i].proc; 1013980be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu } 1014080be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1014180be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu return nullptr; 1014280be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu} 1014380be5ddd2f71eae65d790fe63d1e5b1e1f4daa42Chia-I Wu 1014409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wustatic PFN_vkVoidFunction 1014509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wuintercept_khr_swapchain_command(const char *name, VkDevice dev) { 1014609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu static const struct { 1014709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu const char *name; 1014809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu PFN_vkVoidFunction proc; 1014909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } khr_swapchain_commands[] = { 1015009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkCreateSwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(CreateSwapchainKHR) }, 1015109a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkDestroySwapchainKHR", reinterpret_cast<PFN_vkVoidFunction>(DestroySwapchainKHR) }, 1015209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkGetSwapchainImagesKHR", reinterpret_cast<PFN_vkVoidFunction>(GetSwapchainImagesKHR) }, 1015309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkAcquireNextImageKHR", reinterpret_cast<PFN_vkVoidFunction>(AcquireNextImageKHR) }, 1015409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu { "vkQueuePresentKHR", reinterpret_cast<PFN_vkVoidFunction>(QueuePresentKHR) }, 1015509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu }; 1015609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 101573f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (dev) { 101583f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu layer_data *dev_data = get_my_data_ptr(get_dispatch_key(dev), layer_data_map); 101593f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu if (!dev_data->device_extensions.wsi_enabled) 101603f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu return nullptr; 101613f6f8132355ebdae2736b31fc20de2ac60a70310Chia-I Wu } 1016209a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1016309a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu for (size_t i = 0; i < ARRAY_SIZE(khr_swapchain_commands); i++) { 1016409a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu if (!strcmp(khr_swapchain_commands[i].name, name)) 1016509a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return khr_swapchain_commands[i].proc; 1016609a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu } 1016709a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 1016809a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu return nullptr; 1016909a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu} 1017009a2f8128f58f032b73d29fab5afd789626562c3Chia-I Wu 10171d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} // namespace core_validation 10172d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10173d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// vk_layer_logging.h expects these to be defined 10174d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10175d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR VkResult VKAPI_CALL 10176d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkCreateDebugReportCallbackEXT(VkInstance instance, const VkDebugReportCallbackCreateInfoEXT *pCreateInfo, 10177d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator, VkDebugReportCallbackEXT *pMsgCallback) { 1017889d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::CreateDebugReportCallbackEXT(instance, pCreateInfo, pAllocator, pMsgCallback); 10179d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10180d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10181d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10182d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDestroyDebugReportCallbackEXT(VkInstance instance, 10183d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkDebugReportCallbackEXT msgCallback, 10184d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const VkAllocationCallbacks *pAllocator) { 1018589d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DestroyDebugReportCallbackEXT(instance, msgCallback, pAllocator); 10186d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10187d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10188d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVKAPI_ATTR void VKAPI_CALL 10189d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuvkDebugReportMessageEXT(VkInstance instance, VkDebugReportFlagsEXT flags, VkDebugReportObjectTypeEXT objType, uint64_t object, 10190d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu size_t location, int32_t msgCode, const char *pLayerPrefix, const char *pMsg) { 1019189d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu core_validation::DebugReportMessageEXT(instance, flags, objType, object, location, msgCode, pLayerPrefix, pMsg); 10192d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10193d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10194d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu// loader-layer interface v0 10195d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 1019608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1019708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceExtensionProperties(const char *pLayerName, uint32_t *pCount, VkExtensionProperties *pProperties) { 10198d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu return util_GetExtensionProperties(1, core_validation::instance_extensions, pCount, pProperties); 1019908939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1020008939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1020108939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1020208939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateInstanceLayerProperties(uint32_t *pCount, VkLayerProperties *pProperties) { 10203e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu return util_GetLayerProperties(1, &core_validation::global_layer, pCount, pProperties); 1020408939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 1020508939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu 1020608939232d080c94fc7b4c5ad348644928beb1519Chia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL 1020708939232d080c94fc7b4c5ad348644928beb1519Chia-I WuvkEnumerateDeviceLayerProperties(VkPhysicalDevice physicalDevice, uint32_t *pCount, VkLayerProperties *pProperties) { 10208e11120777bcd1543455d1de54b89292879bcd2bbChia-I Wu return util_GetLayerProperties(1, &core_validation::global_layer, pCount, pProperties); 10209d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10210d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10211d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR VkResult VKAPI_CALL vkEnumerateDeviceExtensionProperties(VkPhysicalDevice physicalDevice, 10212d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu const char *pLayerName, uint32_t *pCount, 10213d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu VkExtensionProperties *pProperties) { 10214a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu // the layer command handles VK_NULL_HANDLE just fine 10215a8f4a23b1e9c068717eda47cc583a93f447c77e3Chia-I Wu return core_validation::EnumerateDeviceExtensionProperties(VK_NULL_HANDLE, pLayerName, pCount, pProperties); 10216d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10217d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10218d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetDeviceProcAddr(VkDevice dev, const char *funcName) { 1021989d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetDeviceProcAddr(dev, funcName); 10220d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu} 10221d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I Wu 10222d16a2fd05d0b6bd20c7274560c88e37e4b3adefcChia-I WuVK_LAYER_EXPORT VKAPI_ATTR PFN_vkVoidFunction VKAPI_CALL vkGetInstanceProcAddr(VkInstance instance, const char *funcName) { 102237a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateInstanceLayerProperties")) 102247a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateInstanceLayerProperties); 102257a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateDeviceLayerProperties")) 102267a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateDeviceLayerProperties); 102277a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkEnumerateInstanceExtensionProperties")) 102287a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkEnumerateInstanceExtensionProperties); 102297a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu if (!strcmp(funcName, "vkGetInstanceProcAddr")) 102307a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu return reinterpret_cast<PFN_vkVoidFunction>(vkGetInstanceProcAddr); 102317a5e039f8f74667b71d3c3b54e5abb8d9b834475Chia-I Wu 1023289d6bb8ab0ab38202ecfb3d6e21f60c884cc62e5Chia-I Wu return core_validation::GetInstanceProcAddr(instance, funcName); 1023308939232d080c94fc7b4c5ad348644928beb1519Chia-I Wu} 10234